--- Day changed Tue Nov 21 2017 00:04 -!- qrestlove [~qrestlove@cpe-66-69-225-126.austin.res.rr.com] has joined #bitcoin-core-dev 00:18 < fanquake> wumpus exposed :p 00:18 < wumpus> fanquake: yep :p 00:25 < geezas> anyone know if network-adjusted time as described in the wiki on block timestamps is used as described there 00:25 < geezas> ? 00:25 < geezas> "A timestamp is accepted as valid if it is greater than the median timestamp of previous 11 blocks, and less than the network-adjusted time + 2 hours. "Network-adjusted time" is the median of the timestamps returned by all nodes connected to you." 00:36 -!- JackH [~laptop@alvira.static.korbank.pl] has quit [Remote host closed the connection] 00:41 -!- laurentmt [~Thunderbi@92.154.68.134] has joined #bitcoin-core-dev 00:45 -!- rundom [~rundom@143.red-95-121-58.dynamicip.rima-tde.net] has quit [Ping timeout: 246 seconds] 00:46 -!- unholymachine [~quassel@2601:8c:c003:9f16:b4f6:6ecb:b8d:4303] has quit [Remote host closed the connection] 00:47 -!- unholymachine [~quassel@2601:8c:c003:9f16:30de:d59b:e913:5950] has joined #bitcoin-core-dev 01:01 -!- rundom [~rundom@143.red-95-121-58.dynamicip.rima-tde.net] has joined #bitcoin-core-dev 01:07 -!- bj_ [31330bf1@gateway/web/freenode/ip.49.51.11.241] has joined #bitcoin-core-dev 01:08 -!- bj_ [31330bf1@gateway/web/freenode/ip.49.51.11.241] has quit [Client Quit] 01:08 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:10 -!- d_t [~d_t@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 01:12 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Remote host closed the connection] 01:12 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev 01:17 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 01:33 -!- BorisYelko [6f456292@gateway/web/freenode/ip.111.69.98.146] has joined #bitcoin-core-dev 01:33 -!- BorisYelko [6f456292@gateway/web/freenode/ip.111.69.98.146] has quit [Client Quit] 01:40 -!- quantbot [~quantbot@ool-2f125d98.dyn.optonline.net] has quit [Remote host closed the connection] 01:40 -!- booyah_ is now known as booyah 01:42 < wumpus> see GetMedianTimePast 01:49 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 268 seconds] 01:50 < Sentineo> wumpus: the timespamt from node is just the timestamp in the blocks my node receives, right? Checking getMedianTimePast(), it referencis the blockchain. I have a feeling geezas tends to think it is a message that is exchanged between nodes. Can you shed some light, which view is correct? 01:51 < wumpus> the text he quotes talks about the median timestamp of the previous 11 blocks, that's implemented in GetMedianTimePast 01:52 < wumpus> there is also a median filter get relative node times at connection, in src/timedata.h, but that is a wholly separate thing 01:52 < sipa> it also talks about network-adjusted time, which is indeed there is a message exchanged between nodes 01:52 < Sentineo> ah ok, that is what I wanted to know 01:53 < Sentineo> tried doing an experiment, but can not force my system to change its time 01:53 -!- shesek [~shesek@141.226.153.219] has joined #bitcoin-core-dev 01:53 -!- shesek [~shesek@141.226.153.219] has quit [Changing host] 01:53 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 01:53 < Sentineo> so if I set my time to 2015 would I invalidate blocks? It sounds like bitcoin-core would take the blockchain (and other nodes) as the source of time 01:53 < wumpus> there's an option to override that logic IIRC 01:53 < Sentineo> need to look into timedata.h, that might answer it 01:53 < sipa> it also never adjusts more than 1 hour iirc 01:54 < wumpus> (for the node time, not for the consensus logic obviously) 01:54 < wumpus> -maxtimeadjustment=0 01:54 < Sentineo> yeah turned off ntp on my laptop, but will see. I will perhaps use regtest and disconnect from the internet for that time :) 01:55 < wumpus> also if you just want to test w/ bitcoin and times there's setmocktime 01:55 -!- quantbot [~quantbot@ool-2f125d98.dyn.optonline.net] has joined #bitcoin-core-dev 01:56 < Sentineo> ah ok, it must be in the unit tests than ... will look it up 01:56 < Sentineo> ty! 01:56 < wumpus> there's also the 'faketime' command that allows time machine experiments without changing time on your computer globally 01:57 < Sentineo> ah wow 01:57 < Sentineo> did not know that one 01:57 < wumpus> "faketime - manipulate the system time for a given command" we use or at least used that for the gitian build to force a deterministic time 01:58 < Sentineo> ah this is cool 01:59 < wumpus> from my experience it doesn't work with very far future dates due to 32-bit timestamps, but YMMV 02:00 -!- quantbot [~quantbot@ool-2f125d98.dyn.optonline.net] has quit [Ping timeout: 248 seconds] 02:07 < Sentineo> hm not getting peers when in future :) 02:11 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 268 seconds] 02:16 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:17 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has joined #bitcoin-core-dev 02:22 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Ping timeout: 248 seconds] 02:23 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev 02:23 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Remote host closed the connection] 02:24 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev 02:25 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has joined #bitcoin-core-dev 02:27 -!- Deacydal [~Deacyde@unaffiliated/deacyde] has quit [Ping timeout: 250 seconds] 02:32 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 02:32 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:37 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 248 seconds] 02:38 -!- pergaminho [~Cleber@201.47.91.172] has joined #bitcoin-core-dev 02:49 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:51 -!- TrufflePig [43c1d724@gateway/web/freenode/ip.67.193.215.36] has quit [Quit: Page closed] 03:02 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has joined #bitcoin-core-dev 03:12 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 03:13 -!- d_t [~d_t@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has quit [Ping timeout: 240 seconds] 03:14 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:31 -!- Kieran4Stehr [~Kieran4St@ns334669.ip-5-196-64.eu] has quit [Remote host closed the connection] 03:39 -!- quantbot [~quantbot@ool-2f125d98.dyn.optonline.net] has joined #bitcoin-core-dev 03:43 -!- quantbot [~quantbot@ool-2f125d98.dyn.optonline.net] has quit [Remote host closed the connection] 03:44 -!- quantbot [~quantbot@ool-2f125d98.dyn.optonline.net] has joined #bitcoin-core-dev 03:48 -!- quantbot [~quantbot@ool-2f125d98.dyn.optonline.net] has quit [Ping timeout: 240 seconds] 03:54 -!- jtimon [~quassel@164.31.134.37.dynamic.jazztel.es] has quit [Ping timeout: 248 seconds] 04:06 -!- indistylo [~indistylo@119.82.105.106] has joined #bitcoin-core-dev 04:22 -!- quantbot [~quantbot@ool-2f125d98.dyn.optonline.net] has joined #bitcoin-core-dev 04:23 -!- quantbot [~quantbot@ool-2f125d98.dyn.optonline.net] has quit [Remote host closed the connection] 04:23 -!- quantbot [~quantbot@ool-2f125d98.dyn.optonline.net] has joined #bitcoin-core-dev 04:26 < Varunram> Hey guys, have a small question - Can anyone suggest an easy way to view the nSequence bit for rbf signalling? Thanks! 04:27 -!- quantbot [~quantbot@ool-2f125d98.dyn.optonline.net] has quit [Ping timeout: 248 seconds] 04:34 < Varunram> well, nvm, I just parsed the json from getrawtransaction :) 04:49 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 05:00 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 05:00 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 05:02 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 05:06 -!- StopAndDecrypt [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has quit [Ping timeout: 250 seconds] 05:07 -!- StopAndDecrypt_ [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has joined #bitcoin-core-dev 05:26 -!- nelruk [~dax_the_c@host-7.58.217.201.copaco.com.py] has joined #bitcoin-core-dev 05:30 -!- Emcy_ [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 05:32 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 268 seconds] 05:33 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has joined #bitcoin-core-dev 05:42 -!- nelruk [~dax_the_c@host-7.58.217.201.copaco.com.py] has quit [Quit: Leaving] 05:46 -!- instagibbs [640f7423@gateway/web/freenode/ip.100.15.116.35] has quit [Quit: Page closed] 05:52 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #11743: qa: Add multiwallet prefix test (master...Mf1711-qaMultiwallet) https://github.com/bitcoin/bitcoin/pull/11743 05:58 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has quit [Read error: Connection reset by peer] 06:02 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 258 seconds] 06:03 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-tmakgmewvarezitt] has quit [Quit: Connection closed for inactivity] 06:12 -!- instagibbs [640f7423@gateway/web/freenode/ip.100.15.116.35] has joined #bitcoin-core-dev 06:14 -!- quantbot [~quantbot@cpe-74-73-145-69.nyc.res.rr.com] has joined #bitcoin-core-dev 06:14 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 06:14 -!- quantbot [~quantbot@cpe-74-73-145-69.nyc.res.rr.com] has quit [Remote host closed the connection] 06:15 -!- quantbot [~quantbot@cpe-74-73-145-69.nyc.res.rr.com] has joined #bitcoin-core-dev 06:15 -!- TimTheEngineer [~Tim@64.253.3.83.dyn-cm-pool73.pool.hargray.net] has joined #bitcoin-core-dev 06:15 -!- TimTheEngineer [~Tim@64.253.3.83.dyn-cm-pool73.pool.hargray.net] has quit [Remote host closed the connection] 06:16 -!- Emcy_ [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 252 seconds] 06:18 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Quit: Leaving.] 06:30 -!- quantbot [~quantbot@cpe-74-73-145-69.nyc.res.rr.com] has quit [] 06:30 -!- quantbot [~quantbot@cpe-74-73-145-69.nyc.res.rr.com] has joined #bitcoin-core-dev 06:33 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 06:45 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 240 seconds] 06:47 -!- Cogito_Ergo_Sum [~Myself@athedsl-4564842.home.otenet.gr] has joined #bitcoin-core-dev 06:47 -!- Cogito_Ergo_Sum [~Myself@athedsl-4564842.home.otenet.gr] has quit [Changing host] 06:47 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has joined #bitcoin-core-dev 06:53 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 06:55 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 06:57 -!- indistylo [~indistylo@119.82.105.106] has quit [Ping timeout: 248 seconds] 06:58 -!- MrPaz [~PazPazPaz@2602:306:8348:2f70:90b7:91f7:1898:e5cc] has joined #bitcoin-core-dev 06:59 -!- Kedstar [Ked@cpc84133-pool16-2-0-cust51.15-1.cable.virginm.net] has quit [Ping timeout: 250 seconds] 07:07 -!- satwo [~textual@2602:306:378a:6fb0:137:974f:d88f:5add] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 07:17 -!- laurentmt1 [~Thunderbi@92.154.68.134] has joined #bitcoin-core-dev 07:18 -!- satwo [~textual@2602:306:378a:6fb0:f5b9:7253:618c:3ff] has joined #bitcoin-core-dev 07:19 -!- laurentmt [~Thunderbi@92.154.68.134] has quit [Ping timeout: 250 seconds] 07:19 -!- laurentmt1 is now known as laurentmt 07:25 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 07:46 -!- cai [~cai@121.69.255.229] has joined #bitcoin-core-dev 07:46 -!- cai [~cai@121.69.255.229] has quit [Remote host closed the connection] 07:56 < promag> wumpus: should #10996 be discussed next meeting? 07:56 < gribble> https://github.com/bitcoin/bitcoin/issues/10996 | Add per-network config file network.conf by ajtowns · Pull Request #10996 · bitcoin/bitcoin · GitHub 07:57 < wumpus> promag: sure 07:57 < promag> I'll give it a try 07:57 < wumpus> promag: I think it'd help a lot in changes that we're making that effectively set configuration for a single network 07:58 < promag> + 07:58 < promag> +1 07:58 < promag> I don't think we should allow overwriting logs different networks 07:59 < promag> *of different networks 07:59 < wumpus> we could allow some settings to only appear in per-network configuration or command line 08:03 < wumpus> we have no way of handling multiple daemons writing to the same log file so we really want to avoid that 08:03 < promag> right 08:04 < promag> maybe GetArg and friends could automatically handle options like `-(-)?`? 08:05 < wumpus> also it'd make no sense, we'd have to distinguish which daemon is logging for each line - if you really want to dump all your bitcoin logging to one place, you can already use -printtoconsole w/ some log aggregation like systemd 08:05 < promag> right, proper logging 08:05 < wumpus> yea that'd be another option 08:06 < wumpus> to make it possible to prefix options with -regtest- and -testnet- or -mainnet-, that would (afaik) work just as well as per-network configuration files... 08:07 < promag> wumpus: the only difference is that you must launch with the network argument 08:07 < promag> so that it can read from the correct config file 08:08 < promag> with a single file, GetArg could 1st check -(-)? and then - 08:08 < aj> hmm, does "-testnet-logfile=BLAH" make more sense than "-logfile=blah-$NETWORK-log" ? 08:09 < promag> aj: IMO it does, with $NETWORK you are stick to that replacement 08:10 < promag> anyway, something to discuss thrusday 08:12 < aj> promag: you could still use different conf files (-conffile or network specific) to have different names, but yeah, i think i agree 08:13 < aj> promag: i think setting -logfile=blah should be treated as -mainnet-logfile=blah, so if you run -regtest or -testnet you get an error, though... 08:13 < hkjn0> hey, I noticed that getrawtransaction says "Use gettransaction for wallet transactions" when it doesn't have a transaction.. but the gettransaction RPC doesn't seem to exist on my node, presumably because I compiled it with --disable-wallet? 08:13 < aj> promag: (or it uses the default location, rather than erroring probably) 08:13 < hkjn0> if that's what's going on, might it make sense to still have all the wallet RPCs stubbed out with a helpful message, even when wallet support is not compiled in? 08:15 < wumpus> hkjn0: would be better to change the getrawtransaction message to not mention the wallet if wallet support is not built in 08:15 < achow101> hkjn0: gettransaction is a wallet rpc, so if you did --disable-wallet, it won't exist 08:16 < hkjn0> ok wumpus, that also would make sense to me, but we agree current messages are somewhat confusing? 08:17 < wumpus> stubbing out the methods would add some code, and would make the wallet method names exist in yet another place, I prefer for nothing wallet-related to be in the client at all if built without 08:17 < wumpus> --disable-build is very much an advanced option, we don't ship binaries with that, and assume people that use it know what they're doing 08:18 < wumpus> disable-wallet lol 08:18 < hkjn0> clearly a risky assumption, in my case! :) 08:18 < hkjn0> ok, if the change is to just modify the getrawtransaction message if wallet isn't enabled, what's the best way to do that? should I file an issue? 08:19 < wumpus> make a patch and file a PR 08:19 < wumpus> if you create an issue for something non-critical without providing code, it's unlikely it's ever picked up 08:21 < hkjn0> I'm just asking for advice for best processes here, change might be simple enough that I can give it a whirl.. but the change is so small an issue is unnecessary here? 08:22 < hkjn0> or is it preferred to have issue + patch, even for small changes? 08:24 -!- DigitalDank [DigitalDan@ip72-207-116-245.sd.sd.cox.net] has quit [] 08:24 -!- geezas [uid253218@gateway/web/irccloud.com/x-luxqyxthvcguocey] has quit [Quit: Connection closed for inactivity] 08:25 < wumpus> we always handle code changes through github PRs, even small ones 08:25 < wumpus> they still need review 08:27 -!- bule [~bule@gateway/tor-sasl/bule] has joined #bitcoin-core-dev 08:29 < aj> jnewbery: btw, are you going to revive #11047 ? 08:29 < gribble> https://github.com/bitcoin/bitcoin/issues/11047 | [tests] rename functional tests by jnewbery · Pull Request #11047 · bitcoin/bitcoin · GitHub 08:33 < hkjn0> wumpus: sorry if I was unclear, I realize all changes go through PRs, but my question was whether it was encouraged to have PR + GH issue even for small changes, or if PR alone would suffice 08:33 < wumpus> PR alone is fine 08:34 < hkjn0> cool 08:34 < wumpus> sorry, was also confused by terminology, as github regards a PR also as a kind of issue 08:34 < instagibbs> hkjn0: please at least describe if it fixes something though 08:36 < hkjn0> instagibbs: could you elaborate? are you saying "use good descriptions in commits / PRs", or something else? 08:37 < instagibbs> hkjn0: right, as appropriate. At a minimum in the PR, so I can git blame and backtrace 08:38 < instagibbs> certain contributors aren't that great at it :P 08:38 -!- Dizzle [~dizzle@108.171.182.16] has joined #bitcoin-core-dev 08:39 < hkjn0> kk, for sure.. I'm pretty used to commit messages many times longer than actual code diff :) 08:39 < bitcoin-git> [bitcoin] practicalswift opened pull request #11744: net: Add missing locks in net.{cpp,h} (master...missing-net-locks) https://github.com/bitcoin/bitcoin/pull/11744 08:40 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 08:40 -!- Emcy_ [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 08:41 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 260 seconds] 08:44 -!- jtimon [~quassel@164.31.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 08:45 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 248 seconds] 08:46 < instagibbs> hkjn0: perfect :) 08:53 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 08:53 -!- ula [~ula@b2b-78-94-11-194.unitymedia.biz] has joined #bitcoin-core-dev 08:54 -!- Emcy_ [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 240 seconds] 08:58 -!- Emcy_ [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 08:59 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 260 seconds] 09:03 -!- jb55 [~jb55@208.98.200.100] has joined #bitcoin-core-dev 09:05 < jnewbery> aj: it's not near the top of my list. If you want it, it's yours! 09:07 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 09:08 -!- Emcy_ [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 248 seconds] 09:10 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection] 09:11 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 09:15 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev 09:15 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 250 seconds] 09:20 < aj> jnewbery: does it need anything other than regular rebases and nit fixes? 09:25 -!- indistylo [~indistylo@122.179.4.153] has joined #bitcoin-core-dev 09:25 -!- Emcy_ [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 09:27 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 250 seconds] 09:30 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 09:34 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 09:42 -!- StopAndDecrypt_ [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has quit [Remote host closed the connection] 09:59 -!- photonclock_ [~photonclo@47.37.153.193] has quit [Quit: photonclock_] 10:08 -!- booyah is now known as SoCo__cpp_ 10:11 -!- SoCo__cpp_ is now known as booyah 10:15 < bitcoin-git> [bitcoin] practicalswift opened pull request #11746: trivial: Fix unsuccessful typo (master...unsuccesful) https://github.com/bitcoin/bitcoin/pull/11746 10:19 -!- dqx [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev 10:19 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-tlfpvykawquhfwgg] has joined #bitcoin-core-dev 10:19 -!- dqx [~dqx@unaffiliated/dqx] has quit [Remote host closed the connection] 10:20 -!- PaulCapestany [~PaulCapes@ip68-100-207-91.dc.dc.cox.net] has quit [Quit: .] 10:22 -!- PaulCapestany [~PaulCapes@ip68-100-207-91.dc.dc.cox.net] has joined #bitcoin-core-dev 10:22 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 10:23 -!- Emcy_ [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 260 seconds] 10:27 -!- Emcy_ [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 10:28 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 252 seconds] 10:38 -!- instagibbs [640f7423@gateway/web/freenode/ip.100.15.116.35] has quit [Ping timeout: 260 seconds] 10:41 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 10:42 -!- Emcy_ [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 258 seconds] 10:43 < jonasschnelli> sipa: do you still have that "block request amount" graph? (what depth will be received how frequently)? 10:46 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 10:47 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 10:50 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 10:50 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 10:52 -!- Emcy_ [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 10:53 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 240 seconds] 10:53 -!- laurentmt [~Thunderbi@92.154.68.134] has quit [Quit: laurentmt] 10:58 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 268 seconds] 11:00 -!- d_t [~d_t@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 11:03 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev 11:05 -!- StopAndDecrypt [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has joined #bitcoin-core-dev 11:05 < sipa> jonasschnelli: i'm still gathering the data 11:06 < jonasschnelli> sipa: okay.. you have a live graph? or you will produce one once you have collected enought points? 11:06 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 11:08 -!- Emcy_ [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 240 seconds] 11:08 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 11:08 -!- bule [~bule@gateway/tor-sasl/bule] has quit [Remote host closed the connection] 11:09 -!- bule [~bule@gateway/tor-sasl/bule] has joined #bitcoin-core-dev 11:14 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 240 seconds] 11:17 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 11:22 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection] 11:25 -!- Emcy_ [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 11:25 -!- quantbot_ [~quantbot@cpe-74-73-145-69.nyc.res.rr.com] has joined #bitcoin-core-dev 11:26 -!- quantbot [~quantbot@cpe-74-73-145-69.nyc.res.rr.com] has quit [Ping timeout: 268 seconds] 11:26 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 248 seconds] 11:27 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 11:28 -!- pergaminho [~Cleber@201.47.91.172] has quit [Quit: Saindo] 11:29 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 11:30 -!- jb55 [~jb55@208.98.200.100] has quit [Ping timeout: 258 seconds] 11:31 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 11:32 -!- Emcy_ [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 248 seconds] 11:35 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 11:36 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 11:41 -!- Emcy_ [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 11:41 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 255 seconds] 11:41 -!- ChuckSupport [620add29@gateway/web/freenode/ip.98.10.221.41] has joined #bitcoin-core-dev 11:41 -!- satwo [~textual@2602:306:378a:6fb0:f5b9:7253:618c:3ff] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 11:41 < bitcoin-git> [bitcoin] Elbandi opened pull request #11747: Fix: Open files read only if requested (master...fix11745) https://github.com/bitcoin/bitcoin/pull/11747 11:44 < ChuckSupport> Good day! I've been saving up since 2015 to buy my own antminer and finally mine on core and not GPU mine. I'm a QA first developer second and would like to contribute but I'm still new to github practices. Can someone suggest how I could go about this? Start with github practices, then how can I pull test code and test ,etc. Thanks for everything you've done and sacrificed for this! 11:47 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 11:48 -!- TrufflePig [43c1d724@gateway/web/freenode/ip.67.193.215.36] has joined #bitcoin-core-dev 11:48 -!- Emcy_ [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 240 seconds] 11:49 -!- Jackson [b85bcea2@gateway/web/freenode/ip.184.91.206.162] has joined #bitcoin-core-dev 11:49 -!- Jackson is now known as Guest32972 11:54 -!- Guest32972 [b85bcea2@gateway/web/freenode/ip.184.91.206.162] has quit [Ping timeout: 260 seconds] 11:55 -!- ChuckSupport [620add29@gateway/web/freenode/ip.98.10.221.41] has quit [Quit: Page closed] 11:59 -!- dcousens [~dcousens@CPE-101-181-114-88.lnse5.cha.bigpond.net.au] has quit [Ping timeout: 248 seconds] 12:00 -!- Emcy_ [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 12:00 -!- dcousens [~dcousens@CPE-101-181-114-171.lnse5.cha.bigpond.net.au] has joined #bitcoin-core-dev 12:01 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 264 seconds] 12:05 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-fgppwjhvvacnxstv] has joined #bitcoin-core-dev 12:06 < andytoshi> Chris_Stewart_5: #bitcoin-mining will probably be more helpful, or #bitcoin. this channel is specifically about software development of Bitcoin Core 12:06 < andytoshi> sorry Chris_Stewart_5 i meant to highlight that guy who left 12:06 -!- wunpunch [~Alli@176.27.129.249] has joined #bitcoin-core-dev 12:07 -!- quantbot [~quantbot@cpe-74-73-145-69.nyc.res.rr.com] has joined #bitcoin-core-dev 12:07 -!- wunpunch [~Alli@176.27.129.249] has quit [Remote host closed the connection] 12:08 -!- indistylo [~indistylo@122.179.4.153] has quit [Ping timeout: 240 seconds] 12:08 -!- wunpunch [~Alli@176.27.129.249] has joined #bitcoin-core-dev 12:09 -!- indistylo [~indistylo@122.179.4.153] has joined #bitcoin-core-dev 12:11 -!- quantbot_ [~quantbot@cpe-74-73-145-69.nyc.res.rr.com] has quit [Ping timeout: 248 seconds] 12:11 -!- Emcy_ [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 268 seconds] 12:11 -!- quantbot [~quantbot@cpe-74-73-145-69.nyc.res.rr.com] has quit [Ping timeout: 250 seconds] 12:17 -!- wunpunch [~Alli@176.27.129.249] has quit [Remote host closed the connection] 12:17 -!- wunpunch [~Alli@176.27.129.249] has joined #bitcoin-core-dev 12:17 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 260 seconds] 12:20 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 12:27 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 12:30 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 12:32 -!- wunpunch [~Alli@176.27.129.249] has quit [Remote host closed the connection] 12:32 -!- wunpunch [~Alli@176.27.129.249] has joined #bitcoin-core-dev 12:33 -!- wunpunch [~Alli@176.27.129.249] has quit [Read error: Connection reset by peer] 12:34 -!- wunpunch [~Alli@176.27.129.249] has joined #bitcoin-core-dev 12:35 -!- satwo [~textual@2602:306:378a:6fb0:570:2b2b:283e:9925] has joined #bitcoin-core-dev 12:38 -!- jeffrade [a7730f03@gateway/web/freenode/ip.167.115.15.3] has joined #bitcoin-core-dev 12:40 -!- jeffrade [a7730f03@gateway/web/freenode/ip.167.115.15.3] has quit [Client Quit] 12:41 -!- jannes [~jannes@095-097-246-234.static.chello.nl] has quit [Quit: Leaving] 12:44 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 12:46 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 12:51 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 268 seconds] 12:54 -!- Aaronvan_ is now known as AaronvanW 12:54 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 12:55 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 12:55 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 12:56 -!- Fabrice_ [b2c79c6c@gateway/web/freenode/ip.178.199.156.108] has joined #bitcoin-core-dev 12:57 -!- Fabrice_ [b2c79c6c@gateway/web/freenode/ip.178.199.156.108] has left #bitcoin-core-dev [] 12:59 -!- jb55 [~jb55@209.52.88.20] has joined #bitcoin-core-dev 13:00 -!- jb55 [~jb55@209.52.88.20] has quit [Read error: Connection reset by peer] 13:04 -!- indistylo [~indistylo@122.179.4.153] has quit [Ping timeout: 248 seconds] 13:15 -!- lio17 [~bumi@ns350827.ip-37-187-174.eu] has joined #bitcoin-core-dev 13:16 -!- instagibbs [~instagibb@pool-100-15-116-35.washdc.fios.verizon.net] has joined #bitcoin-core-dev 13:17 -!- jb55 [~jb55@209.52.88.20] has joined #bitcoin-core-dev 13:26 -!- jb55 [~jb55@209.52.88.20] has quit [Ping timeout: 248 seconds] 13:28 -!- TrufflePig [43c1d724@gateway/web/freenode/ip.67.193.215.36] has quit [Quit: Page closed] 13:31 -!- jtimon [~quassel@164.31.134.37.dynamic.jazztel.es] has quit [Ping timeout: 240 seconds] 13:37 -!- ula [~ula@b2b-78-94-11-194.unitymedia.biz] has quit [Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/] 13:45 -!- Randolf [~randolf@S010664777d491753.vc.shawcable.net] has joined #bitcoin-core-dev 13:51 -!- Cheeseo [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has joined #bitcoin-core-dev 13:55 -!- wunpunch [~Alli@176.27.129.249] has quit [Remote host closed the connection] 13:55 -!- wunpunch [~Alli@176.27.129.249] has joined #bitcoin-core-dev 13:56 -!- cheese_ [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has joined #bitcoin-core-dev 14:00 -!- Cheeseo [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has quit [Ping timeout: 248 seconds] 14:00 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:02 -!- rundom [~rundom@143.red-95-121-58.dynamicip.rima-tde.net] has quit [Quit: Leaving] 14:02 -!- jtimon [~quassel@164.31.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 14:08 -!- Cheeseo [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has joined #bitcoin-core-dev 14:11 -!- cheese_ [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has quit [Ping timeout: 248 seconds] 14:15 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-fgppwjhvvacnxstv] has quit [Quit: Connection closed for inactivity] 14:24 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-fohufwrqdinzpnju] has joined #bitcoin-core-dev 14:26 -!- Cheeseo [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has quit [Ping timeout: 248 seconds] 14:29 < meshcollider> aj: are you here atm? 14:29 < aj> meshcollider: hey 14:29 < meshcollider> aj: re #10996, I'm just a little confused now 14:29 < gribble> https://github.com/bitcoin/bitcoin/issues/10996 | Add per-network config file network.conf by ajtowns · Pull Request #10996 · bitcoin/bitcoin · GitHub 14:30 < meshcollider> -netconf is just -conf but relative to net-specific datadir? 14:31 < aj> meshcollider: yeah: patch makes bitcoind load two config files, .bitcoin/bitcoin.conf and .bitcoin/testnet3/network.conf; -conf lets you choose a different name for the first one, -netconf a different name for the second one 14:32 -!- Randolf [~randolf@S010664777d491753.vc.shawcable.net] has quit [Ping timeout: 240 seconds] 14:32 < meshcollider> I like the default reading of the network specific config file but I'm worried the parameter interaction between conf and netconf will confuse users 14:34 < aj> meshcollider: i worry about that too. current behaviour is that bitcoin.conf is loaded first and network.conf second (so bitcoin.conf can specify the network), and any setting in bitcoin.conf overrides any setting in network.conf 14:35 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 14:35 < aj> meshcollider: (ie, GetArg returns the first value seen, GetArgs returns all of them from both files) 14:36 < meshcollider> aj: Perhaps instead of -netconf parameter, just rely on -conf for specifying a config file if they want (because they can specify one in a net-specific directory explicitly if they want) and then only load the network.conf if -conf is not specified? 14:38 < aj> meshcollider: hmm.. the choice i'm seeing is between having a param to let you choose a different name for the file, or no param at all and just always checking for datadir/network.conf 14:38 < meshcollider> I think if people are explicitly specifying a different config with -conf parameter, we can assume they want to use it on the network they've specified right? 14:39 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 248 seconds] 14:39 < meshcollider> So if they use -conf, we only load that, but if they don't then we load the network specific file by default too? 14:39 -!- Anduck [~Anduck@unaffiliated/anduck] has quit [Quit: leaving] 14:40 < meshcollider> aj: But perhaps I haven't fully understood the use case so it's your call 14:40 -!- Cheeseo [~Cheeseo@unaffiliated/cheeseo] has joined #bitcoin-core-dev 14:40 -!- Anduck [~Anduck@unaffiliated/anduck] has joined #bitcoin-core-dev 14:43 < jnewbery> aj: sorry for long delay. Yes, just rebase and nits. Rebase should be easy - it's just a case of re-running the script 14:45 -!- Dizzle [~dizzle@108.171.182.16] has quit [Quit: Leaving...] 14:47 < aj> jnewbery: no worries about the delay, that's why the i in irc doesn't stand for instant :) sounds good, i guess i'll check with MarcoFalke that there's not more reason to close it than inactivity 14:51 < aj> meshcollider: i'm not sure if there's a use case... atm, you could have standard settings in bitcoin.conf and special settings in network.conf (mainnet addnode's say), and switch either independently via command line options. that just seems a bit more flexible and maybe natural to me? 14:53 < meshcollider> aj: Or, what if both the net specific file and the root datadir one had the same name, and -conf specified them both? 14:54 < meshcollider> Or would having them both called bitcoin.conf be confusing 14:54 < aj> meshcollider: mainnet bitcoin.conf and network.conf live in the same directory :( 14:54 < meshcollider> Ah true lol 14:56 < meshcollider> aj: Hmm perhaps someone else will give feedback on the approach too, I think I'd still prefer not having the netconf command and just using conf if it's specified but yeah no massive leaning either way 14:56 -!- JeffSlentz [883d7eaf@gateway/web/freenode/ip.136.61.126.175] has quit [Ping timeout: 260 seconds] 14:59 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 14:59 < aj> meshcollider: i might see if i can code up your way and match the tests, see what it looks liek 15:00 < meshcollider> aj: sounds good, thank you! :) 15:00 < meshcollider> Sorry for being difficult :) 15:00 < aj> meshcollider: i don't expect to like it, but i've been wrong before :) 15:06 < aj> meshcollider: hmm, question is, if i respond in less than two weeks, will the difficulty increase... 15:09 -!- cheese_ [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has joined #bitcoin-core-dev 15:12 -!- Cheeseo [~Cheeseo@unaffiliated/cheeseo] has quit [Ping timeout: 260 seconds] 15:19 -!- cheese_ [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has quit [Ping timeout: 240 seconds] 15:26 -!- Cheeseo [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has joined #bitcoin-core-dev 15:27 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has quit [] 15:30 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev 15:31 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 15:33 -!- tknp [~tknp@unaffiliated/tknp] has joined #bitcoin-core-dev 15:33 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Client Quit] 15:35 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 255 seconds] 15:35 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 15:36 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 15:37 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 15:37 -!- chjj [~chjj@unaffiliated/chjj] has quit [Ping timeout: 255 seconds] 15:37 < bitcoin-git> [bitcoin] fanquake closed pull request #11735: [refactor] Remove magic numbers from HMAC SHA256 (master...eliminate_magic_numbers) https://github.com/bitcoin/bitcoin/pull/11735 15:38 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 15:39 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 268 seconds] 15:40 -!- wxss [~user@185.94.193.181] has quit [Quit: leaving] 16:02 -!- quantbot [~quantbot@ool-2f125d98.dyn.optonline.net] has joined #bitcoin-core-dev 16:03 -!- Cheeseo [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has quit [Ping timeout: 268 seconds] 16:10 -!- vicenteH [~user@35.233.15.37.dynamic.jazztel.es] has quit [Ping timeout: 248 seconds] 16:15 -!- wunpunch [~Alli@176.27.129.249] has quit [Quit: Leaving] 16:15 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 255 seconds] 16:17 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 16:21 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 17:02 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 17:32 < bitcoin-git> [bitcoin] merehap opened pull request #11748: [Tests] Adding unit tests for GetDifficulty in blockchain.cpp. (master...blockchain_unittests) https://github.com/bitcoin/bitcoin/pull/11748 17:38 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Quit: WeeChat 1.4] 17:52 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-tlfpvykawquhfwgg] has quit [Quit: Connection closed for inactivity] 18:01 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Quit: WeeChat 1.7.1] 18:02 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 18:05 < bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d4267a3ab271...5ea932a51083 18:05 < bitcoin-git> bitcoin/master d2ea2bc practicalswift: trivial: Fix unsuccessful typo 18:05 < bitcoin-git> bitcoin/master 5ea932a Pieter Wuille: Merge #11746: trivial: Fix unsuccessful typo... 18:05 -!- ForAll [dfcf7dd8@gateway/web/freenode/ip.223.207.125.216] has joined #bitcoin-core-dev 18:06 < bitcoin-git> [bitcoin] sipa closed pull request #11746: trivial: Fix unsuccessful typo (master...unsuccesful) https://github.com/bitcoin/bitcoin/pull/11746 18:06 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Client Quit] 18:07 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 18:08 < ForAll> wrapping my head around things first by observation 18:16 -!- bule [~bule@gateway/tor-sasl/bule] has quit [Remote host closed the connection] 18:16 -!- bule [~bule@gateway/tor-sasl/bule] has joined #bitcoin-core-dev 18:29 -!- ForAll [dfcf7dd8@gateway/web/freenode/ip.223.207.125.216] has quit [Ping timeout: 260 seconds] 18:55 -!- bule [~bule@gateway/tor-sasl/bule] has quit [Ping timeout: 248 seconds] 18:58 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 19:07 -!- bule [~bule@gateway/tor-sasl/bule] has joined #bitcoin-core-dev 19:12 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has quit [Quit: Leaving.] 19:17 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 19:21 -!- jtimon [~quassel@164.31.134.37.dynamic.jazztel.es] has quit [Ping timeout: 248 seconds] 19:55 < meshcollider> sipa: are you here at the moment? 19:56 < sipa> that depends onyour definition of 'here' 19:57 < meshcollider> lol :) Just a quick question re #11708, if I make redeemScript also accept an array of scripts, do you think listunspent should also return the witnessScript inside a list of redeemScript's or as a separate entry for clarity, because otherwise the output of listunspent can't be directly passed into signrawtransaction 19:57 < gribble> https://github.com/bitcoin/bitcoin/issues/11708 | Add P2SH-P2WSH support to signrawtransaction and listunspent RPC by MeshCollider · Pull Request #11708 · bitcoin/bitcoin · GitHub 20:05 < sipa> meshcollider: hmm, nnoying 20:32 < meshcollider> sipa: yeah :/ I think it would be best to make listunspent return an array of redeemScripts too in this case, there will only be two for P2SH-P2WSH so it should always be easy to work out which is which, but that would be a breaking change 20:42 -!- sin_ [~sin@x4dbe998b.dyn.telefonica.de] has joined #bitcoin-core-dev 20:44 < sipa> meshcollider: but that's technically an API break for listunspent for P2SH-P2WPKH 20:45 -!- digifis [~sin@x4e30193b.dyn.telefonica.de] has quit [Ping timeout: 248 seconds] 20:53 < meshcollider> sipa: I can think of two cases, either listunspent returns a string or an array when needed (which only breaks P2SH-P2WSH but is uglier code), or listunspent always returns an array even if it only has one element (which breaks P2SH, P2SH-P2WPKH, and P2SH-P2WSH but is cleaner long term) 20:53 < meshcollider> is the first case acceptable? 20:56 < sipa> i wouldn't even call the second obviously acceptable 20:56 < sipa> usually we don't break the api 20:57 < meshcollider> yeah 20:58 < meshcollider> so listunspent must return a string if there is only one element 21:00 < meshcollider> So that will only break P2SH-P2WSH but currently doesn't even work in that case so that's fine right 21:03 < sipa> yes, that's why it is maybe ok :) 21:05 -!- MrPaz [~PazPazPaz@2602:306:8348:2f70:90b7:91f7:1898:e5cc] has quit [Quit: Leaving] 21:09 -!- BashCo_ [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 21:11 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 268 seconds] 21:20 -!- helo [~helo@unaffiliated/helo] has quit [Quit: leaving] 21:21 -!- helo [~helo@unaffiliated/helo] has joined #bitcoin-core-dev 21:26 -!- Jr_ [af641960@gateway/web/freenode/ip.175.100.25.96] has joined #bitcoin-core-dev 21:28 -!- Jr__ [af641960@gateway/web/freenode/ip.175.100.25.96] has joined #bitcoin-core-dev 21:31 -!- Jr_ [af641960@gateway/web/freenode/ip.175.100.25.96] has quit [Ping timeout: 260 seconds] 21:32 -!- Leminer [LeMiner@5ED1AFBF.cm-7-2c.dynamic.ziggo.nl] has quit [Read error: Connection reset by peer] 21:32 -!- Leminer [LeMiner@5ED1AFBF.cm-7-2c.dynamic.ziggo.nl] has joined #bitcoin-core-dev 21:32 -!- Leminer [LeMiner@5ED1AFBF.cm-7-2c.dynamic.ziggo.nl] has quit [Changing host] 21:32 -!- Leminer [LeMiner@unaffiliated/leminer] has joined #bitcoin-core-dev 21:32 -!- Jr__ [af641960@gateway/web/freenode/ip.175.100.25.96] has quit [Ping timeout: 260 seconds] 21:36 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 21:41 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has joined #bitcoin-core-dev 21:43 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 21:45 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 255 seconds] 21:57 -!- bifrost [ca7f0766@gateway/web/freenode/ip.202.127.7.102] has joined #bitcoin-core-dev 21:58 -!- bifrost [ca7f0766@gateway/web/freenode/ip.202.127.7.102] has left #bitcoin-core-dev [] 21:58 -!- jimharry [a003b7cc@gateway/web/freenode/ip.160.3.183.204] has joined #bitcoin-core-dev 22:00 -!- jimharry [a003b7cc@gateway/web/freenode/ip.160.3.183.204] has quit [Client Quit] 22:03 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has quit [Read error: Connection reset by peer] 22:04 -!- dabura667_ [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has joined #bitcoin-core-dev 22:07 -!- bule [~bule@gateway/tor-sasl/bule] has quit [Ping timeout: 248 seconds] 22:22 -!- indistylo [~indistylo@119.82.105.106] has joined #bitcoin-core-dev 22:26 -!- indistylo [~indistylo@119.82.105.106] has quit [Ping timeout: 248 seconds] 22:29 -!- Apocalyptic [~Apocalypt@unaffiliated/apocalyptic] has quit [Ping timeout: 240 seconds] 22:30 -!- Apocalyptic [~Apocalypt@unaffiliated/apocalyptic] has joined #bitcoin-core-dev 23:11 -!- d_t [~d_t@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has quit [Ping timeout: 248 seconds] 23:23 -!- NielsvG [~Necrathex@unaffiliated/necrathex] has quit [Ping timeout: 240 seconds] 23:28 -!- NielsvG [~Necrathex@2001:982:aa8:1:76d4:35ff:fe12:58d6] has joined #bitcoin-core-dev 23:28 -!- NielsvG [~Necrathex@2001:982:aa8:1:76d4:35ff:fe12:58d6] has quit [Changing host] 23:28 -!- NielsvG [~Necrathex@unaffiliated/necrathex] has joined #bitcoin-core-dev 23:50 < jonasschnelli> Would adding block size(s) and weight to the block index be completely wrong? https://github.com/bitcoin/bitcoin/compare/master...jonasschnelli:2017/11/blockindex_size?expand=1 23:51 < jonasschnelli> I think only stats stuff could use it. So I'm unsure if the >8MB more ram consumption is worth it. 23:52 < jonasschnelli> For things like #5896 or #9849 it would probably required... 23:52 < gribble> https://github.com/bitcoin/bitcoin/issues/5896 | [Qt][PoC] introduce "core-pulse" by jonasschnelli · Pull Request #5896 · bitcoin/bitcoin · GitHub 23:52 < gribble> https://github.com/bitcoin/bitcoin/issues/9849 | Qt: Network Watch tool by luke-jr · Pull Request #9849 · bitcoin/bitcoin · GitHub 23:52 < jonasschnelli> You don't want to load a block from the disk just to get some block size charts.