--- Day changed Tue Nov 28 2017
00:00 < wumpus> if no one cares to remember it
00:00 < fanquake> Is it more painful than not having obvious fixes easily merged
00:00 < raheel_> ?HELP
00:00 < fanquake> wumpus fair enough. I guess they get picked up again eventually anyways.
00:01 < wumpus> for criticial concerns with something that is merged always open an issue, that's what they're for
00:01 < raheel_> I want to create wallet address in pphp
00:01 < wumpus> raheel_: #bitcoin
00:01 < raheel_> php     
00:01 < raheel_> any api ?
00:01 < wumpus> raheel_, take this to #bitcoin
00:01 < jonasschnelli> raheel_: this is the core dev channel, pleae use #bitcoin or #bitcoin-dev for your Q
00:01 < wumpus> read the topic for a change
00:02 < fanquake> Thoughts on #9754 ? This is the second or third time this PR has been opened, hasn't ever gotten any real discussion
00:02 < gribble> https://github.com/bitcoin/bitcoin/issues/9754 | Change NULLFAIL => SIG_NULLFAIL. by richardkiss · Pull Request #9754 · bitcoin/bitcoin · GitHub
00:02 < raheel_> hii     
00:03 < wumpus> fanquake: it seems it doesn't really bother anyone but him
00:03 < fanquake> I think I'm just going to close it again.
00:03 -!- raheel_ [67ff054a@gateway/web/freenode/ip.103.255.5.74] has quit [Client Quit]     
00:04 < bitcoin-git> [bitcoin] fanquake closed pull request #9754: Change NULLFAIL => SIG_NULLFAIL. (master...feature/unify_sig_nullfail) https://github.com/bitcoin/bitcoin/pull/9754
00:04 < fanquake> re ready to merge. Maybe #11647 if you wanted to verify the backports.
00:05 < gribble> https://github.com/bitcoin/bitcoin/issues/11647 | 0.15: Backports by MarcoFalke · Pull Request #11647 · bitcoin/bitcoin · GitHub
00:05 < wumpus> agree with closing, I see no way forward for that PR
00:08 -!- JackH [~laptop@212.78.169.180] has joined #bitcoin-core-dev     
00:10 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev     
00:11 < aj> wumpus, fanquake: maybe having a 'highfive' bot would be an interesting idea to pursue? (auto welcome new contributors, assign reviewers, complain about lacking tests, modifying unsafe code, etc) http://sarah.thesharps.us/2016/11/17/impact-of-bots-on-github-communities/
00:12 < wumpus> I think we should add cfields's #11457 to high priority for review, to make sure his net refactoring work can move forward
00:12 < gribble> https://github.com/bitcoin/bitcoin/issues/11457 | Introduce BanMan by theuni · Pull Request #11457 · bitcoin/bitcoin · GitHub
00:13 < wumpus> aj: don't know about others, but I'm not really a fan of bots personally, they generate a lot of extra notification. We had a "pull tester" bot once, you know.
00:14 < wumpus> I like how travis integration doesn't generate a message, just shows the status inline
00:14 -!- JamesAU [~JamesAU@120.146.9.99] has quit []     
00:14 -!- victorSN [~victorSN@ec2-18-221-184-249.us-east-2.compute.amazonaws.com] has joined #bitcoin-core-dev     
00:14 -!- JamesAU [~JamesAU@120.146.9.99] has joined #bitcoin-core-dev     
00:15 -!- victorSN [~victorSN@ec2-18-221-184-249.us-east-2.compute.amazonaws.com] has quit [Remote host closed the connection]     
00:15 -!- victorSN [~victorSN@ec2-18-221-184-249.us-east-2.compute.amazonaws.com] has joined #bitcoin-core-dev     
00:16 < aj> wumpus: no, didn't know. how was the "pull tester" different to travis now?
00:16 < wumpus> it posted a message if the tests failed/passed
00:16 < aj> wumpus: ah, so same idea, just differnt github hook?
00:17 < wumpus> I guess so, it was a project specific solution. travis is generic
00:17 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has quit []     
00:18 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has quit [Read error: No route to host]     
00:18 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has joined #bitcoin-core-dev     
00:20 -!- kabaum [~kalle@h-13-35.A163.priv.bahnhof.se] has quit [Ping timeout: 248 seconds]     
00:31 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-dowkwmlclhffdslb] has quit [Quit: Connection closed for inactivity]     
00:35 -!- bule [~bule@gateway/tor-sasl/bule] has quit [Ping timeout: 248 seconds]     
00:37 -!- dqx [~dqx@unaffiliated/dqx] has quit [Ping timeout: 240 seconds]     
00:39 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection]     
00:40 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev     
00:47 -!- dqx [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev     
00:48 < Provoostenator> Coveralls can be configured to post the result like Travis does and not leave comments.
00:49 < Provoostenator> Maybe the other bots can be too.
00:54 < wumpus> if so I have no problem with them
00:58 < wumpus> aj: anyhow that article seems interesting
01:08 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]     
01:15 -!- JamesAU [~JamesAU@120.146.9.99] has quit [Remote host closed the connection]     
01:19 -!- BogatMohogat [~BogadMoho@145.90.162.255] has joined #bitcoin-core-dev     
01:22 -!- kabaum [~kalle@62.119.166.1] has joined #bitcoin-core-dev     
01:26 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev     
01:30 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Ping timeout: 240 seconds]     
01:34 -!- JamesAU [~JamesAU@120.146.9.99] has joined #bitcoin-core-dev     
01:36 < bitcoin-git> [bitcoin] laanwj opened pull request #11781: Add `-debuglogfile` option (master...2017_11_logfile) https://github.com/bitcoin/bitcoin/pull/11781
01:38 -!- JamesAU [~JamesAU@120.146.9.99] has quit [Ping timeout: 240 seconds]     
01:39 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #bitcoin-core-dev     
01:40 -!- JamesAU [~JamesAU@120.146.9.99] has joined #bitcoin-core-dev     
01:42 -!- timothy [tredaelli@redhat/timothy] has joined #bitcoin-core-dev     
01:44 -!- str4d [~str4d@183.191.6.51.dyn.plus.net] has joined #bitcoin-core-dev     
01:48 -!- BogatMohogat [~BogadMoho@145.90.162.255] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]     
02:06 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev     
02:08 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection]     
02:12 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection]     
02:13 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev     
02:14 -!- hoge_ [~hoge@p6763012-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has quit [Remote host closed the connection]     
02:14 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-cdopgqtougkijjcw] has joined #bitcoin-core-dev     
02:15 -!- hoge_ [~hoge@p6763012-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has joined #bitcoin-core-dev     
02:19 -!- hoge_ [~hoge@p6763012-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has quit [Ping timeout: 268 seconds]     
02:30 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has quit [Remote host closed the connection]     
02:31 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
02:31 -!- BogatMohogat [~BogadMoho@5249B657.cm-4-2c.dynamic.ziggo.nl] has joined #bitcoin-core-dev     
02:41 -!- kabaum [~kalle@62.119.166.1] has quit [Ping timeout: 260 seconds]     
02:47 -!- hoge_ [~hoge@ngn9-ppp85.tokyo.sannet.ne.jp] has joined #bitcoin-core-dev     
02:52 -!- str4d [~str4d@183.191.6.51.dyn.plus.net] has quit [Ping timeout: 248 seconds]     
02:53 -!- Lauda [~quassel@unaffiliated/lauda] has quit [Remote host closed the connection]     
02:54 -!- Lauda [~quassel@unaffiliated/lauda] has joined #bitcoin-core-dev     
03:03 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]     
03:04 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
03:07 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Ping timeout: 240 seconds]     
03:08 -!- btcdrak [uid234579@gateway/web/irccloud.com/x-gdhklivdhraqigsk] has quit [Quit: Connection closed for inactivity]     
03:11 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev     
03:12 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev     
03:12 < bitcoin-git> [bitcoin] laanwj opened pull request #11783: Fix shutdown in case of errors during initialization (master...2017_11_notify_callbacks_shutdown_crash) https://github.com/bitcoin/bitcoin/pull/11783
03:12 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev     
03:39 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 248 seconds]     
03:42 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
03:46 -!- jtimon [~quassel@164.31.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev     
03:46 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Read error: Connection reset by peer]     
03:47 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev     
04:01 -!- JamesAU [~JamesAU@120.146.9.99] has quit [Remote host closed the connection]     
04:06 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection]     
04:09 -!- Dev0P [53dbc32a@gateway/web/freenode/ip.83.219.195.42] has joined #bitcoin-core-dev     
04:11 < bitcoin-git> [bitcoin] laanwj closed pull request #11287: DRY config header inclusion (master...refactor/dry-config) https://github.com/bitcoin/bitcoin/pull/11287
04:12 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev     
04:13 -!- hoge_ [~hoge@ngn9-ppp85.tokyo.sannet.ne.jp] has quit [Remote host closed the connection]     
04:33 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-cdopgqtougkijjcw] has quit [Quit: Connection closed for inactivity]     
04:34 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]     
04:34 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev     
04:38 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection]     
04:41 -!- ula [~ula@b2b-78-94-9-226.unitymedia.biz] has joined #bitcoin-core-dev     
04:43 -!- dqx [~dqx@unaffiliated/dqx] has quit [Ping timeout: 240 seconds]     
04:45 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev     
04:46 < promag> wumpus: I'm going to test #11783 rebased with #11781
04:46 < gribble> https://github.com/bitcoin/bitcoin/issues/11783 | Fix shutdown in case of errors during initialization by laanwj · Pull Request #11783 · bitcoin/bitcoin · GitHub
04:46 < gribble> https://github.com/bitcoin/bitcoin/issues/11781 | Add `-debuglogfile` option by laanwj · Pull Request #11781 · bitcoin/bitcoin · GitHub
04:48 < wumpus> thanks!
04:51 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has joined #bitcoin-core-dev     
04:54 -!- JamesAU [~JamesAU@120.146.9.99] has joined #bitcoin-core-dev     
04:54 -!- roadcrap [~roadcrypt@unaffiliated/roadcrap] has quit [Ping timeout: 240 seconds]     
04:55 -!- hoge_ [~hoge@ngn9-ppp85.tokyo.sannet.ne.jp] has joined #bitcoin-core-dev     
04:55 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev     
04:56 < promag> wumpus: bitcoind -debuglogfile=/foo/bar/bar.log doesn't crash without 11783
04:57 < promag> > (currently this segfaults afterwards, but that is due to an unrelated problem introduced in #10286, see #11783)
04:57 < gribble> https://github.com/bitcoin/bitcoin/issues/10286 | Call wallet notify callbacks in scheduler thread (without cs_main) by TheBlueMatt · Pull Request #10286 · bitcoin/bitcoin · GitHub
04:57 < gribble> https://github.com/bitcoin/bitcoin/issues/11783 | Fix shutdown in case of errors during initialization by laanwj · Pull Request #11783 · bitcoin/bitcoin · GitHub
04:57 < promag> doesn't segfault here
04:59 -!- JamesAU [~JamesAU@120.146.9.99] has quit [Ping timeout: 276 seconds]     
05:00 < wumpus> well that's good
05:02 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection]     
05:03 < wumpus> still happens here
05:04 < wumpus> "src/bitcoind  -debuglogfile=/dfdf" is enough to reproduce it immediately
05:10 -!- nelruk [~dax_the_c@host-249.58.217.201.copaco.com.py] has joined #bitcoin-core-dev     
05:11 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev     
05:12 < promag> wumpus: what I mean is that 11781 alone doesn't segfault, how could it segfault there?
05:12 < wumpus> I don't know, maybe a subtle configuration difference?
05:13 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev     
05:14 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection]     
05:18 < wumpus> backtrace: https://0bin.net/paste/s2wRk1OomkBcFp3j#3-RdKCqzohpsAOe3dBIjacEmEuu6fh6tgCa9E4FIxBS
05:18 < gribble> https://github.com/bitcoin/bitcoin/issues/3 | Encrypt wallet · Issue #3 · bitcoin/bitcoin · GitHub
05:18 -!- hoge_ [~hoge@ngn9-ppp85.tokyo.sannet.ne.jp] has quit [Remote host closed the connection]     
05:18 -!- hoge_ [~hoge@ngn9-ppp85.tokyo.sannet.ne.jp] has joined #bitcoin-core-dev     
05:19 -!- JamesAU [~JamesAU@120.146.9.99] has joined #bitcoin-core-dev     
05:19 < wumpus> so it calls UnregisterValidationInterface(0) . I don't see how that could not segfault.
05:20 -!- Dev0P [53dbc32a@gateway/web/freenode/ip.83.219.195.42] has quit [Quit: Page closed]     
05:23 -!- hoge_ [~hoge@ngn9-ppp85.tokyo.sannet.ne.jp] has quit [Ping timeout: 240 seconds]     
05:26 -!- JamesAU [~JamesAU@120.146.9.99] has quit [Ping timeout: 248 seconds]     
05:35 -!- kabaum [~kalle@178.132.75.146] has joined #bitcoin-core-dev     
05:37 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]     
05:37 -!- photonclock_ [~photonclo@47.37.153.193] has quit [Ping timeout: 258 seconds]     
05:43 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 240 seconds]     
05:48 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev     
05:49 -!- JamesAU [~JamesAU@120.146.9.99] has joined #bitcoin-core-dev     
05:49 < promag> wumpus: sorry my bad, forget to git checkout . after git reset HEAD~1
05:53 -!- JamesAU [~JamesAU@120.146.9.99] has quit [Ping timeout: 260 seconds]     
05:56 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]     
05:56 -!- hoge_ [~hoge@ngn9-ppp85.tokyo.sannet.ne.jp] has joined #bitcoin-core-dev     
06:00 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]     
06:01 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
06:07 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev     
06:07 < wumpus> hah!
06:10 -!- nelruk [~dax_the_c@host-249.58.217.201.copaco.com.py] has quit [Quit: Leaving]     
06:18 -!- BogatMohogat [~BogadMoho@5249B657.cm-4-2c.dynamic.ziggo.nl] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]     
06:22 < wumpus> what would be a good functional test to add the -debuglogfile= test in? can create a new one but it seems kind of overkill
06:23 -!- laurentmt [~Thunderbi@92.154.68.134] has joined #bitcoin-core-dev     
06:24 < wumpus> none itseems, I'll just create a new one
06:29 -!- cyber55 [~cyber55@unaffiliated/cyber55] has quit [Quit: Leaving]     
06:30 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]     
06:31 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev     
06:43 < Provoostenator> In an RPC test, how would I go about debugging why sync_mempools times out, after a succesful sendrawtransaction?
06:44 < Provoostenator> See bumpfee.py in https://github.com/Sjors/bitcoin/tree/bumpfee-test-refactor
06:45 -!- victorSN [~victorSN@ec2-18-221-184-249.us-east-2.compute.amazonaws.com] has left #bitcoin-core-dev []     
06:45 < Provoostenator> I don't think it's related to the minimum relay fee, as even a 0.1 BTC fee doesn't help.
06:46 < Provoostenator> I probably broke something about the nodes in the test setup, but it would be nice if I can reveal some sort of P2P error message to get a clue what I broke.
06:47 < Provoostenator> E.g. can I access log files of the test nodes?
06:47 < wumpus> timeout problems are notoriously annoying to debug
06:47 < wumpus> yes, you can, it prints the test directory at start
06:48 < wumpus> inside that are the data directories for the nodes
06:48 < wumpus> also pass --nocleanup to not clean up
06:49 < Provoostenator> Ah yes, that's very useful.
06:51 < wumpus> there's also test/functional/combine_logs.py to merge the test log with logs of multiple nodes
06:51 < wumpus> (to show one timeline)
06:51 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has quit [Ping timeout: 276 seconds]     
06:52 < Provoostenator> I'm seeing an AddToWallet entry in the logs for the node that created the transaction, but no obvious error messages after that related to propagating it to the other peer.
06:53 < Provoostenator> The other node has a "got inv: tx" entry for the same tx
06:53 -!- Sinclair6 [~sinclair6@2602:306:c4b1:2570:74ca:8102:d9b4:ee50] has joined #bitcoin-core-dev     
06:54 < Provoostenator> And no obvious error either.
06:54 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has joined #bitcoin-core-dev     
06:55 < Provoostenator> mempool.dat is empty for the other node though
06:58 -!- kexkey [~kexkey@173.209.61.61] has joined #bitcoin-core-dev     
07:00 -!- jb55 [~jb55@70-36-49-138.dyn.novuscom.net] has joined #bitcoin-core-dev     
07:04 -!- photonclock_ [~photonclo@47.37.153.193] has joined #bitcoin-core-dev     
07:15 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]     
07:16 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev     
07:26 < Provoostenator> So I’m looking for debut messages that might explain why a node receives a transaction, but doesn’t add it to its mempool.
07:40 -!- savak [c38a525e@gateway/web/freenode/ip.195.138.82.94] has joined #bitcoin-core-dev     
07:51 -!- StopAndDecrypt_ [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has quit [Read error: Connection reset by peer]     
07:51 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has joined #bitcoin-core-dev     
08:00 -!- hoge_ [~hoge@ngn9-ppp85.tokyo.sannet.ne.jp] has quit [Remote host closed the connection]     
08:01 -!- archaeal [60462f91@gateway/web/freenode/ip.96.70.47.145] has joined #bitcoin-core-dev     
08:10 < instagibbs> Provoostenator, you may have to set debug=p2p, if you haven't yet
08:16 -!- msvr [c5f511be@gateway/web/freenode/ip.197.245.17.190] has joined #bitcoin-core-dev     
08:22 -!- jb55 [~jb55@70-36-49-138.dyn.novuscom.net] has quit [Ping timeout: 276 seconds]     
08:23 -!- JackH [~laptop@212.78.169.180] has quit [Ping timeout: 268 seconds]     
08:36 -!- JackH [~laptop@2a02:a210:2e00:300:655a:7cbf:d627:81fb] has joined #bitcoin-core-dev     
08:39 -!- LumberCartel [~randolf@96.53.47.42] has joined #bitcoin-core-dev     
08:41 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 260 seconds]     
08:49 -!- msvr [c5f511be@gateway/web/freenode/ip.197.245.17.190] has quit [Ping timeout: 260 seconds]     
08:54 -!- LumberCartel [~randolf@96.53.47.42] has quit [Ping timeout: 258 seconds]     
08:54 -!- wxss [~user@185.145.38.228] has joined #bitcoin-core-dev     
09:01 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]     
09:02 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
09:04 -!- kabaum [~kalle@178.132.75.146] has quit [Ping timeout: 276 seconds]     
09:06 -!- bule [~bule@gateway/tor-sasl/bule] has joined #bitcoin-core-dev     
09:07 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 276 seconds]     
09:13 -!- quantbot_ [~quantbot@cpe-74-73-138-18.nyc.res.rr.com] has joined #bitcoin-core-dev     
09:14 -!- laurentmt [~Thunderbi@92.154.68.134] has quit [Quit: laurentmt]     
09:16 -!- saint_ [~saint_@unaffiliated/saint-/x-0540772] has joined #bitcoin-core-dev     
09:16 -!- savak [c38a525e@gateway/web/freenode/ip.195.138.82.94] has quit [Quit: Page closed]     
09:16 -!- windsok [~windsok@unaffiliated/windsok] has quit [Quit: No Ping reply in 180 seconds.]     
09:16 -!- quantbot [~quantbot@cpe-74-73-138-18.nyc.res.rr.com] has quit [Ping timeout: 260 seconds]     
09:19 -!- windsok [~windsok@45.63.59.8] has joined #bitcoin-core-dev     
09:19 -!- windsok [~windsok@45.63.59.8] has quit [Changing host]     
09:19 -!- windsok [~windsok@unaffiliated/windsok] has joined #bitcoin-core-dev     
09:22 -!- XM [80e50402@gateway/web/freenode/ip.128.229.4.2] has joined #bitcoin-core-dev     
09:39 -!- timothy [tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!]     
09:40 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection]     
09:41 -!- Randolf [~randolf@S0106c8fb26572f40.vc.shawcable.net] has joined #bitcoin-core-dev     
09:45 -!- dqx [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev     
09:46 -!- jtimon [~quassel@164.31.134.37.dynamic.jazztel.es] has quit [Remote host closed the connection]     
09:49 -!- btcdrak [uid234579@gateway/web/irccloud.com/x-sleaptiimkswwruu] has joined #bitcoin-core-dev     
09:54 < Provoostenator> instagibbs: is that a flag to pass to the test node?
09:58 < Provoostenator>   --tracerpc is quite useful too, although in this case it just shows that the second node's mempool is indeed empty every time sync_mempools looks at it
10:00 -!- Randolf [~randolf@S0106c8fb26572f40.vc.shawcable.net] has quit [Ping timeout: 260 seconds]     
10:02 < instagibbs> Provoostenator, yes, `debug=X` is the general purpose logging argument
10:04 < Provoostenator> "<category> can be: net, tor, mempool, http, bench, zmq, db, rpc, estimatefee, addrman, selectcoins, reindex, cmpctblock, rand, prune, proxy, mempoolrej, libevent, coindb, qt, leveldb"
10:04 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev     
10:04 < instagibbs> oh sorry, so it's "net"
10:06 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev     
10:07 -!- timothy [~tredaelli@redhat/timothy] has quit [Client Quit]     
10:12 -!- jb55 [~jb55@208.98.200.100] has joined #bitcoin-core-dev     
10:14 < Provoostenator> Ok, that seems to add a bit more detail. So the node which doesn't update its mempool log says: "received: inv (37 bytes) peer=1", "got inv: tx b4e9...f354  new peer=1"
10:14 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev     
10:14 < Provoostenator> I'll turn on some more debug options...
10:16 -!- b71a48f9 [31cdde75@gateway/web/freenode/ip.49.205.222.117] has joined #bitcoin-core-dev     
10:16 -!- b71a48f9 [31cdde75@gateway/web/freenode/ip.49.205.222.117] has quit [Client Quit]     
10:18 < sipa> there is also -debug=all
10:22 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev     
10:30 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-sglmgiwvvijguxck] has joined #bitcoin-core-dev     
10:30 < Provoostenator> Even -debug-all doesn't tell me anything useful. Here's the combined log: https://gist.github.com/Sjors/f887722422f49144fe9b97cee9fef836
10:31 < Provoostenator> Interestingly the same transaction (ca43...) is sent twice, even though only one test is run.
10:38 < luke-jr> Provoostenator: -debug=all is not -debug-all
10:40 < Provoostenator> luke-jr: that was a typo in IRC only.
10:43 < Provoostenator> The test framework shows a warning if you use an unsupported debug category.
11:12 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev     
11:13 < MarcoFalke> nanotube: Where is the gribble code hosted that runs in this channel?
11:13 < MarcoFalke> nanotube: https://github.com/nanotube/supybot-bitcoin-marketmonitor is only for the market, no?
11:13 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit]     
11:17 -!- tux3do [~tux3do@ip72-201-18-238.ph.ph.cox.net] has joined #bitcoin-core-dev     
11:17 -!- tux3do [~tux3do@ip72-201-18-238.ph.ph.cox.net] has left #bitcoin-core-dev []     
11:19 -!- tux3do [~tux3do@ip72-201-18-238.ph.ph.cox.net] has joined #bitcoin-core-dev     
11:19 -!- tux3do [~tux3do@ip72-201-18-238.ph.ph.cox.net] has left #bitcoin-core-dev []     
11:31 < jonasschnelli> wumpus: Would it make sense to mention absolute paths are possibbe in #11781 (in the release notes or the init.cpp part)?
11:31 < gribble> https://github.com/bitcoin/bitcoin/issues/11781 | Add `-debuglogfile` option by laanwj · Pull Request #11781 · bitcoin/bitcoin · GitHub
11:31 < jonasschnelli> Only after reading the code I know it's possible (if (logfile.is_absolute()) {)
11:31 < jonasschnelli> *knew
11:32 < jonasschnelli> But maybe it's obvious
11:37 -!- wunpunch [~Alli@2a02:c7f:282a:6c00:cd8:e08:2bb1:3bc9] has joined #bitcoin-core-dev     
11:37 -!- Emcy_ [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev     
11:38 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has joined #bitcoin-core-dev     
11:39 -!- blockchain [~linux@95.211.172.35.adsl.inet-telecom.org] has joined #bitcoin-core-dev     
11:40 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 248 seconds]     
11:41 < blockchain> hi I have installed bitcoin-core 15.01 and want to use the replace by fee. but the "increase transaction fee" option is grey, how can i activate it ?
11:42 < jonasschnelli> blockchain: better use #bitcoin for this... off-topic here.
11:42 < blockchain> ok didnt know where to ask
11:46 -!- marcoagner [~user@gateway/tor-sasl/marcoagner] has joined #bitcoin-core-dev     
11:47 -!- bule [~bule@gateway/tor-sasl/bule] has quit [Remote host closed the connection]     
11:51 -!- JamesAU [~JamesAU@120.146.9.99] has joined #bitcoin-core-dev     
11:51 -!- jb55 [~jb55@208.98.200.100] has quit [Ping timeout: 276 seconds]     
11:52 -!- ekrok_ [~ekrok@85.200.34.95.customer.cdi.no] has quit [Quit: Leaving]     
11:54 -!- JamesAU [~JamesAU@120.146.9.99] has quit [Read error: Connection reset by peer]     
11:55 -!- JamesAU [~JamesAU@120.146.9.99] has joined #bitcoin-core-dev     
11:55 -!- JamesAU [~JamesAU@120.146.9.99] has quit [Remote host closed the connection]     
11:59 -!- PaulCapestany [~PaulCapes@ip68-100-207-91.dc.dc.cox.net] has quit [Quit: .]     
11:59 -!- jtimon [~quassel@164.31.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev     
12:02 -!- PaulCapestany [~PaulCapes@ip68-100-207-91.dc.dc.cox.net] has joined #bitcoin-core-dev     
12:04 -!- bule [~bule@gateway/tor-sasl/bule] has joined #bitcoin-core-dev     
12:06 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev     
12:08 -!- warxhead [warxhead@c-73-243-180-191.hsd1.co.comcast.net] has joined #bitcoin-core-dev     
12:10 -!- XM [80e50402@gateway/web/freenode/ip.128.229.4.2] has quit [Quit: Page closed]     
12:16 -!- paveljanik [~paveljani@79.98.72.176] has joined #bitcoin-core-dev     
12:16 -!- paveljanik [~paveljani@79.98.72.176] has quit [Changing host]     
12:16 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has joined #bitcoin-core-dev     
12:24 -!- marcoagner [~user@gateway/tor-sasl/marcoagner] has quit [Ping timeout: 248 seconds]     
12:27 -!- Cheeseo [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has joined #bitcoin-core-dev     
12:32 -!- cheese_ [~Cheeseo@unaffiliated/cheeseo] has joined #bitcoin-core-dev     
12:33 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has quit [Ping timeout: 248 seconds]     
12:35 -!- Cheeseo [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has quit [Ping timeout: 240 seconds]     
12:37 -!- marcoagner [~user@gateway/tor-sasl/marcoagner] has joined #bitcoin-core-dev     
12:43 -!- Masterboy [~Montvid@78-57-212-189.static.zebra.lt] has joined #bitcoin-core-dev     
12:46 < jonasschnelli> wumpus: every tried ODROID-XU4 with Core?
12:46 < sipa> jonasschnelli: i'm syncing on an odroid-c2 currently
12:47 < jonasschnelli> sipa: Oh. What storage?
12:50 < sipa> 128 GB microsd card, pruned
12:52 < jonasschnelli> sipa: okay. Happy to hear more... (sync speed, corruptions)
12:52 -!- DigitalDank [~Satoshi41@ip72-207-116-245.sd.sd.cox.net] has quit []     
12:53 < sipa> i just started maybe 10 hours ago
12:53 < sipa> ask me again in a week :)
12:53 < jonasschnelli> I'd say in 3 days. :)
12:54 < Masterboy> jonasschnelli, sync speed is really bad on my core i3 pentium 300mbit connection
12:54 < Masterboy> it took me days to sync from the start
12:54 < jonasschnelli> Masterboy: dbcache how large?
12:54 -!- wunpunch [~Alli@2a02:c7f:282a:6c00:cd8:e08:2bb1:3bc9] has quit [Quit: Leaving]     
12:55 < Masterboy> and the ping and speed to other clients was like 1/mbit
12:55 < Masterboy> wait i will see
12:55 < Masterboy> now it is crawling slow
12:55 < Masterboy> client 0.15.1
12:58 < jonasschnelli> Masterboy: network speed doesn't matter that much. What matters is CPU speed for signature verification, a.s.o. Disk speed is also important for the UTXO set read/writes.
12:58 < jonasschnelli> Make sure you use a large dbcache which can make a significant improvement 
13:00 -!- Dizzle [~dizzle@108.171.182.16] has joined #bitcoin-core-dev     
13:02 < sipa> jonasschnelli: running with dbcache=450 maxmempool=10
13:02 < sipa> default settings made it OOM
13:04 < jonasschnelli> sipa: but you have 2GB, right?
13:05 < jonasschnelli> maybe the maxmempool->dbcache-during-IBD-change is a OOM-problem for such systems
13:05 < sipa> the total RSS was totally within expected ranges
13:06 < sipa> it's more a question of what else was using memory i guess
13:06 < sipa> but i haven't investigated
13:06 < jonasschnelli> running with X?
13:06 < Masterboy> jonasschnelli, sorry it take some time to load btc-qt like 10 min now. i am loading it from a hdd 700gb
13:06 < sipa> jonasschnelli: yes, with a 4k screen - maybe that causes a lot of video memory
13:06 < jonasschnelli> sipa: go headless!
13:06 < sipa> yes, i should
13:07 < Masterboy> jonasschnelli, how can i find out the dbcache value?
13:07 < sipa> Masterboy: #bitcoin
13:07 < jonasschnelli> 4k screen. ;-)
13:07 < Masterboy> ok default is 450 i see in the manual
13:07 < sipa> my tv was the only screen i had available with an HDMI port
13:08 < Masterboy> jonasschnelli, so how can i make it faster? what should i set for a 300mbit connection?
13:08 < Masterboy> jonasschnelli, cpu is 2.4ghz
13:09 < jonasschnelli> Masterboy: please answer in the #bitcoin channel
13:09 -!- Krellan_ [~krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev     
13:10 -!- marcoagner [~user@gateway/tor-sasl/marcoagner] has quit [Quit: WeeChat 1.0.1]     
13:26 -!- rusty [~rusty@pdpc/supporter/bronze/rusty] has quit [Quit: Leaving.]     
13:35 < BlueMatt> sipa: I highly recommend headless c2s, you can now build upstream kernels from released branches and upstream u-boot and things work :)
13:36 < BlueMatt> no closed-source drivers needed
13:36 -!- btcdrak [uid234579@gateway/web/irccloud.com/x-sleaptiimkswwruu] has quit [Quit: Connection closed for inactivity]     
13:36 < BlueMatt> (closed source tool needed to convert u-boot build to binary image, sadly, and it does have a close-source first boot loader stage)
13:37 -!- paveljanik [~paveljani@unaffiliated/paveljanik] has quit [Quit: Leaving]     
13:37 -!- dqx [~dqx@unaffiliated/dqx] has quit [Remote host closed the connection]     
13:40 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 276 seconds]     
13:41 -!- dqx [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev     
13:42 -!- dqx [~dqx@unaffiliated/dqx] has quit [Remote host closed the connection]     
13:43 < nanotube> MarcoFalke: that repo you linked contains a bunch of the plugins, but the core of the bot is https://github.com/nanotube/supybot_fixes
13:43 < MarcoFalke> nanotube: I was specifically looking for the code that does this: #1337
13:43 < gribble> https://github.com/bitcoin/bitcoin/issues/1337 | Quieter initial block download by rebroad · Pull Request #1337 · bitcoin/bitcoin · GitHub
13:45 -!- dqx [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev     
13:46 -!- dqx [~dqx@unaffiliated/dqx] has quit [Remote host closed the connection]     
13:46 -!- dqx [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev     
13:48 < nanotube> MarcoFalke: ah, that's the MessageParser plugin :) the actual function to spit out issues is just config in the plugin
13:48 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]     
13:50 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
13:51 < cluelessperson> I'm sorry to annoy you, is there an ETA on Core segwit support in the QT wallet?
13:57 -!- RoyceX [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has joined #bitcoin-core-dev     
13:58 -!- kexkey [~kexkey@173.209.61.61] has quit [Ping timeout: 260 seconds]     
14:00 < sipa> cluelessperson: when it's done
14:00 -!- cheese_ [~Cheeseo@unaffiliated/cheeseo] has quit [Ping timeout: 240 seconds]     
14:00 -!- saint_ [~saint_@unaffiliated/saint-/x-0540772] has quit [Quit: UNIVERSE CORRUPTED. REBOOT (Y/N) ?]     
14:01 < sipa> cluelessperson: we never have the ability to set ETAs on features, as they depend on review, which is done by people volunteering their time
14:05 < cluelessperson> sipa: how can I help?  (I don't know C++)
14:05 < sipa> cluelessperson: you can help by testing it for sure
14:06 < cluelessperson> sipa: can you lead me through what I need to do?
14:06 < sipa> https://github.com/bitcoin/bitcoin/pull/11403
14:06 < cluelessperson> maybe I can gain some experience and help more on my own in the future
14:06 < sipa> can you compile from sourcr?
14:06 < cluelessperson> yes     
14:07 < sipa> well the hardest part of being a good testing is figuring out what are good scenarios to test
14:07 < sipa> identifying potential edge cases
14:07 < cluelessperson> I figure I could try to test everythign on testnet
14:07 < Chris_Stewart_5> *something something* #8469 *something something*
14:07 < gribble> https://github.com/bitcoin/bitcoin/issues/8469 | [POC] Introducing property based testing to Core by Christewart · Pull Request #8469 · bitcoin/bitcoin · GitHub
14:10 < cfields> Chris_Stewart_5: ugh, sorry. I promised you at Stanford that I'd take a look at that again, and never did.
14:11 < cfields> adding it to my review queue.
14:11 < BlueMatt> Chris_Stewart_5: I believe its still blocked on gcc 4.9, no?
14:11 < BlueMatt> jnewbery: seemed to think so, at least
14:11 < BlueMatt> (we currently only require 4.8)
14:11 < Chris_Stewart_5> cfields: It's fine! I just like to make shameless plugs when I can. 
14:11  * BlueMatt still has it marked as "awaiting gcc bump"
14:12 < Chris_Stewart_5> BlueMatt: I'm far from an expert on the build system, but can we make it only build if we have a >= 4.9 compiler? 
14:12 < Chris_Stewart_5> it was my understanding that 4.8 is going to be around for awhile 
14:12 < BlueMatt> 4.8 is some debian thing, right?
14:13 < BlueMatt> like oldstable?
14:13 < cfields> that's what we just did for DEBUG_LOCKORDER, so that sounds like fair game to me
14:13 < BlueMatt> true
14:13 < cfields> Trusty is 4.8 too
14:13 < BlueMatt> ah, an ubuntu thing
14:14 < BlueMatt> oldstable appears to be 4.9
14:14 < sipa> what feature in 4.9 is needed?
14:14 < BlueMatt> heh, trusty doesn't die until 2019
14:14 < BlueMatt> man I'm so glad ubuntu shortened their supported cycle
14:15 < Chris_Stewart_5> sipa: See the pull request. The library I'm using uses lambda's heavily
14:15 < Chris_Stewart_5> apparently there is an issue with parameter packs 
14:16 < cfields> variadic lambdas? I thought that was a c++14 (or higher?) thing
14:17 < cfields> oh, maybe that's a variadic in the callback definition as opposed to unpacking inside the lambda
14:17 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev     
14:17 < MarcoFalke> nanotube: Ah, so the config is not in the repo... Have you enabled the Scheduler plugin? If so, mind adding a repeat every seconds=7*24*60*60 with a message of 'Meeting in ~30min' (first time at around 18:30UTC next Thursday)?
14:19 < MarcoFalke> cfields: yeah travis is on trusty.
14:19 < MarcoFalke> And I'd prefer to have it run on travis. Or at least compile
14:19 < sipa> Chris_Stewart_5: it looks like it's a c++11 feature that's just buggy in gcc 4.5-4.8
14:19 < sipa> cfields: ^
14:19 < MarcoFalke> Jup, it is a bug in gcc4.8 that was never fixed (or backported)
14:19 < cfields> MarcoFalke: well we could always work around that. The issue is what we consider to be the minimum for building.
14:20 < BlueMatt> cfields: werent you gonna get us a depends-built gcc by 0.15 :p
14:21 < MarcoFalke> Jup, could use that as work-around and keep min-gcc at 4.8
14:21 < cfields> BlueMatt: yea, I just started messing with it again. Still unclear, though, whether we should go the gcc or clang route :(
14:21 < BlueMatt> i thought we were going the "trusting trust" route :p
14:21 < BlueMatt> (ie: both)
14:22 < cfields> BlueMatt: both available for use? or use them to compile each-other, then use 1 of the resulting ones?
14:22 < BlueMatt> the second
14:23 < cfields> yea, even if we use clang for everything, we'll still want to build it with gcc at least once.
14:25 < cfields> Chris_Stewart_5: https://github.com/emil-e/rapidcheck/commit/100fc66908b7c063160a3eebc5b778becaa335d1
14:25 < cfields> Chris_Stewart_5: have you tried with a very recent rapidcheck, as opposed to what's shipped by distros?
14:26 < MarcoFalke> lol, what disto ships that? 
14:27 < MarcoFalke> Aren't we fetching the code from the git directly?
14:28 < Chris_Stewart_5> cfields: I did not see that and MarcoFalke yes. IIRC someone created a .mk file for it
14:28 < cfields> oh, i assumed distros packaged it so we could use a local copy. nm.
14:28 < MarcoFalke> I did ;)
14:28 < Chris_Stewart_5> hah I thought it was you. 
14:29 < Chris_Stewart_5> cfields: I'll look at that later and see if I can just use that hack instead of having to do all this extra work
14:29 < Chris_Stewart_5> thanks! 
14:29 < cfields> Chris_Stewart_5: well it's pretty old, so I assume it's not enough
14:30 < cfields> (I was thinking you were testing with a stale distro package)
14:31 -!- blockchain [~linux@95.211.172.35.adsl.inet-telecom.org] has quit [Quit: Verlassend]     
14:34 < cfields> yea, your commit includes the hack
14:34 -!- quantbot [~quantbot@cpe-74-73-138-18.nyc.res.rr.com] has joined #bitcoin-core-dev     
14:34 -!- quantbot_ [~quantbot@cpe-74-73-138-18.nyc.res.rr.com] has quit [Read error: Connection reset by peer]     
14:38 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]     
14:39 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has quit []     
14:42 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev     
14:43 -!- JamesAU [~JamesAU@203.210.69.68] has joined #bitcoin-core-dev     
14:43 -!- hoge_ [~hoge@ngn9-ppp85.tokyo.sannet.ne.jp] has joined #bitcoin-core-dev     
14:44 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 276 seconds]     
14:44 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]     
14:46 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev     
14:49 -!- JamesAU [~JamesAU@203.210.69.68] has quit [Ping timeout: 268 seconds]     
14:55 -!- archaeal [60462f91@gateway/web/freenode/ip.96.70.47.145] has quit [Quit: Page closed]     
14:56 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-dexlolywspvvcxmx] has joined #bitcoin-core-dev     
15:07 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
15:07 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Client Quit]     
15:07 -!- RoyceX [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has quit [Ping timeout: 240 seconds]     
15:10 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 250 seconds]     
15:14 -!- Cheeseo [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has joined #bitcoin-core-dev     
15:14 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt]     
15:14 -!- Cheeseo [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has quit [Remote host closed the connection]     
15:15 -!- Cheeseo [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has joined #bitcoin-core-dev     
15:19 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]     
15:20 -!- goatpig [68a01584@gateway/web/freenode/ip.104.160.21.132] has joined #bitcoin-core-dev     
15:21 -!- Dizzle [~dizzle@108.171.182.16] has quit [Quit: Leaving...]     
15:23 -!- andyjdee [569a56eb@gateway/web/freenode/ip.86.154.86.235] has joined #bitcoin-core-dev     
15:24 -!- dqx [~dqx@unaffiliated/dqx] has quit [Remote host closed the connection]     
15:24 -!- hoge_ [~hoge@ngn9-ppp85.tokyo.sannet.ne.jp] has quit [Remote host closed the connection]     
15:27 -!- dqx [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev     
15:28 -!- hoge_ [~hoge@ngn9-ppp85.tokyo.sannet.ne.jp] has joined #bitcoin-core-dev     
15:30 -!- vicenteH [~user@35.233.15.37.dynamic.jazztel.es] has quit [Ping timeout: 268 seconds]     
15:33 -!- cheese_ [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has joined #bitcoin-core-dev     
15:36 -!- JamesAU [~JamesAU@203.210.69.68] has joined #bitcoin-core-dev     
15:36 -!- Cheeseo [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has quit [Ping timeout: 268 seconds]     
15:36 -!- ctya [~ctya@cpe-76-93-160-50.san.res.rr.com] has joined #bitcoin-core-dev     
15:40 -!- dqx [~dqx@unaffiliated/dqx] has quit [Remote host closed the connection]     
15:42 -!- dqx [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev     
15:42 -!- qrestlove [~qrestlove@cpe-66-69-225-126.austin.res.rr.com] has quit [Ping timeout: 255 seconds]     
15:44 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
15:48 -!- andyjdee [569a56eb@gateway/web/freenode/ip.86.154.86.235] has quit [Ping timeout: 260 seconds]     
15:50 -!- wunpunch [~Alli@2a02:c7f:282a:6c00:e8c9:c1ed:a49b:42b4] has joined #bitcoin-core-dev     
15:50 < meshcollider> promag: are you here?
15:51 < promag> y     
15:51 < meshcollider> re: https://github.com/bitcoin/bitcoin/pull/11726/commits/75ae7453769517397df1020407bfa201121c5e31#r151863274 what do you mean by removing the default value?
15:51 -!- cheese_ [~Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has quit [Ping timeout: 240 seconds]     
15:51 < meshcollider> what would you suggest I put there instead?
15:53 < promag> I thought this was true: std::string GetArg(const std::string& strArg, const std::string& strDefault="") const;
15:53 < promag> Because your code is inside if (gArgs.IsArgSet("-walletdir") ...
15:54 < promag> So this would look better gArgs.GetArg("-walletdir")
15:54 < meshcollider> iirc GetArg didn't default to empty string?
15:55 < meshcollider> https://github.com/bitcoin/bitcoin/blob/master/src/util.h#L229
15:55 < promag> right, it doesn't
15:55 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev     
15:56 < promag> it could be overloaded: std::string GetArg(const std::string& strArg) const; and there it would assert(IsSet(strArg))
15:56 -!- dqx [~dqx@unaffiliated/dqx] has quit [Remote host closed the connection]     
15:56 < meshcollider> yeah true, probably out of scope for this PR though :)
15:57 -!- dqx [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev     
15:57 < meshcollider> Also re: same PR, I'm unsure about the change you suggested to files.md, because even nodes running 0.16.0 will use the old file location if its an upgrade not a new install
15:57 -!- merehap [~sean@c-73-239-115-62.hsd1.wa.comcast.net] has quit [Ping timeout: 240 seconds]     
15:58 < meshcollider> if I move it to a "Only used in pre-0.16.0" section, users may not realise that
15:58 < promag> you mean this https://github.com/bitcoin/bitcoin/pull/11726/files#r153250209 ?
15:58 < promag> just say:
15:58 < meshcollider> yep     
15:59 < promag> * db.log: wallet database log file; replaced by wallets/ directory in 0.16.0 for fresh installs?
15:59 < promag> or something?
16:01 < promag> my point is that there should be one line for each file
16:02 < promag> and:
16:02 < meshcollider> mmm yeah, ok
16:02 < promag> * wallets/db.log; since 0.16.0 for fresh installs
16:03 < meshcollider> Yep that sounds sensible
16:03 < meshcollider> Thanks :)
16:03 < promag> err, don't know, I'm bad at copy..
16:03 < promag> np     
16:05 -!- ctya [~ctya@cpe-76-93-160-50.san.res.rr.com] has quit [Remote host closed the connection]     
16:06 -!- archaeal [62ce095e@gateway/web/freenode/ip.98.206.9.94] has joined #bitcoin-core-dev     
16:06 -!- JamesAU [~JamesAU@203.210.69.68] has quit []     
16:06 -!- JamesAU [~JamesAU@203.210.69.68] has joined #bitcoin-core-dev     
16:07 -!- hoge_ [~hoge@ngn9-ppp85.tokyo.sannet.ne.jp] has quit [Remote host closed the connection]     
16:07 -!- merehap [~sean@c-73-239-115-62.hsd1.wa.comcast.net] has joined #bitcoin-core-dev     
16:11 < bitcoin-git> [bitcoin] MoneyMakerLTD opened pull request #11784: Update README.md (master...master) https://github.com/bitcoin/bitcoin/pull/11784
16:15 -!- ctya [~ctya@cpe-76-93-160-50.san.res.rr.com] has joined #bitcoin-core-dev     
16:18 -!- JamesAU [~JamesAU@203.210.69.68] has quit []     
16:19 < promag> fanquake: 11784 why?
16:19 -!- JamesAU [~JamesAU@203.210.69.68] has joined #bitcoin-core-dev     
16:20 < fanquake> progmag it's replacing the readme with one line about some money maker coin?
16:21 < meshcollider> heh trivial ACK to that, sounds like a necessary upgrade 
16:22 < promag> fanquake: sounds legit
16:22 < promag> meshcollider: files.md is almost sorted, wallets/* should be on the bottom?
16:23 -!- wunpunch [~Alli@2a02:c7f:282a:6c00:e8c9:c1ed:a49b:42b4] has quit [Read error: Connection reset by peer]     
16:23 -!- roadcrap [~roadcrypt@unaffiliated/roadcrap] has joined #bitcoin-core-dev     
16:23 < meshcollider> oops that should be database/* not wallets/* lol
16:23 < meshcollider> nice catch
16:24 < promag> that too
16:25 < promag> line 10 should move to line 18?
16:26 -!- quantbot [~quantbot@cpe-74-73-138-18.nyc.res.rr.com] has quit [Read error: Connection reset by peer]     
16:26 < promag> line 12 too
16:26 -!- ctya [~ctya@cpe-76-93-160-50.san.res.rr.com] has quit [Remote host closed the connection]     
16:28 -!- quantbot [~quantbot@cpe-74-73-145-69.nyc.res.rr.com] has joined #bitcoin-core-dev     
16:30 -!- quantbot_ [~quantbot@38.101.106.141] has joined #bitcoin-core-dev     
16:30 < meshcollider> done
16:30 -!- Krellan_ is now known as Krellan     
16:31 -!- mrios [b5a57c6a@gateway/web/freenode/ip.181.165.124.106] has joined #bitcoin-core-dev     
16:32 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]     
16:32 -!- ctya [~ctya@cpe-76-93-160-50.san.res.rr.com] has joined #bitcoin-core-dev     
16:33 -!- quantbot [~quantbot@cpe-74-73-145-69.nyc.res.rr.com] has quit [Ping timeout: 248 seconds]     
16:33 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 248 seconds]     
16:37 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev     
16:38 -!- baltakatei [~Roses_Rav@50.109.201.84] has quit [Ping timeout: 240 seconds]     
16:38 -!- DvdKhl [~Arokh@ip-37-201-211-111.hsi13.unitymediagroup.de] has quit [Ping timeout: 240 seconds]     
16:38 -!- baltakatei [~Roses_Rav@50.109.203.212] has joined #bitcoin-core-dev     
16:39 < promag> meshcollider: wallets/database/*: BDB database environment; only used for wallet since 0.8.0; since 0.16.0
16:39 -!- mrios [b5a57c6a@gateway/web/freenode/ip.181.165.124.106] has quit [Quit: Page closed]     
16:39 < promag> should be wallets/database/*: BDB database environment; only used for wallet since 0.16.0?
16:40 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]     
16:41 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
16:45 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]     
16:46 < luke-jr> new wallets*
16:48 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]     
16:49 -!- ctya [~ctya@cpe-76-93-160-50.san.res.rr.com] has quit [Remote host closed the connection]     
16:49 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
16:52 < promag> that too
16:55 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]     
16:56 -!- Emcy_ [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 240 seconds]     
16:57 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev     
17:01 -!- hoge_ [~hoge@p6763012-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has joined #bitcoin-core-dev     
17:01 -!- Masterboy [~Montvid@78-57-212-189.static.zebra.lt] has quit [Ping timeout: 248 seconds]     
17:06 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev     
17:08 -!- Masterboy [~Montvid@78-57-212-189.static.zebra.lt] has joined #bitcoin-core-dev     
17:10 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev     
17:13 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection]     
17:22 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has joined #bitcoin-core-dev     
17:24 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has quit [Client Quit]     
17:25 -!- Randolf [~randolf@24.244.32.156] has joined #bitcoin-core-dev     
17:26 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Quit: Leaving.]     
17:26 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has joined #bitcoin-core-dev     
17:28 -!- ctya [~cmackinde@cpe-76-93-160-50.san.res.rr.com] has joined #bitcoin-core-dev     
17:30 -!- Randolf [~randolf@24.244.32.156] has quit [Ping timeout: 260 seconds]     
17:31 -!- Randolf [~randolf@96.53.65.102] has joined #bitcoin-core-dev     
17:33 -!- hoge_ [~hoge@p6763012-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has quit []     
17:33 -!- Masterboy [~Montvid@78-57-212-189.static.zebra.lt] has quit [Remote host closed the connection]     
17:34 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
17:37 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has quit [Remote host closed the connection]     
17:38 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has joined #bitcoin-core-dev     
17:43 -!- goatpig [68a01584@gateway/web/freenode/ip.104.160.21.132] has quit [Quit: Page closed]     
17:45 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]     
18:00 -!- Chris_Stewart_5 [~chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Quit: WeeChat 1.4]     
18:05 -!- Randolf [~randolf@96.53.65.102] has quit [Ping timeout: 248 seconds]     
18:06 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev     
18:09 < mlz> Hello Core devs, 10000!!! Congratulations and thank you for all your hard work, the price didn't happen without your help! So thank you!  :)
18:15 -!- Randolf [~randolf@96.53.65.102] has joined #bitcoin-core-dev     
18:17 -!- bule [~bule@gateway/tor-sasl/bule] has quit [Remote host closed the connection]     
18:17 -!- bule [~bule@gateway/tor-sasl/bule] has joined #bitcoin-core-dev     
18:28 -!- Ylbam [uid99779@gateway/web/irccloud.com/x-sglmgiwvvijguxck] has quit [Quit: Connection closed for inactivity]     
18:37 -!- Randolf [~randolf@96.53.65.102] has quit [Ping timeout: 268 seconds]     
18:45 -!- dqx [~dqx@unaffiliated/dqx] has quit [Quit: .]     
18:50 -!- bule [~bule@gateway/tor-sasl/bule] has quit [Remote host closed the connection]     
18:51 -!- wxss [~user@185.145.38.228] has quit [Quit: leaving]     
18:57 -!- JamesAU [~JamesAU@203.210.69.68] has quit []     
18:58 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]     
18:59 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
19:04 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 276 seconds]     
19:04 -!- ctya [~cmackinde@cpe-76-93-160-50.san.res.rr.com] has quit [Quit: Lost terminal]     
19:08 -!- JamesAU [~JamesAU@203.210.69.68] has joined #bitcoin-core-dev     
19:08 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has joined #bitcoin-core-dev     
19:20 -!- Krellan [~krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection]     
19:23 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
19:32 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]     
19:33 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
19:34 -!- JamesAU [~JamesAU@203.210.69.68] has quit [Ping timeout: 255 seconds]     
19:36 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]     
19:36 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
19:56 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]     
19:57 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has quit [Ping timeout: 260 seconds]     
19:58 -!- Mahesh [312204e3@gateway/web/freenode/ip.49.34.4.227] has joined #bitcoin-core-dev     
20:00 < Mahesh> Mahesh/dchsjzumck/web/886659427
20:01 -!- Randolf [~randolf@96.53.47.38] has joined #bitcoin-core-dev     
20:01 -!- Mahesh [312204e3@gateway/web/freenode/ip.49.34.4.227] has quit [Client Quit]     
20:02 -!- ctya [~ctya@cpe-76-93-160-50.san.res.rr.com] has joined #bitcoin-core-dev     
20:15 -!- Giszmo [~leo@ip-60-226-107-190.nextelmovil.cl] has joined #bitcoin-core-dev     
20:18 -!- Giszmo [~leo@ip-60-226-107-190.nextelmovil.cl] has quit [Read error: Connection reset by peer]     
20:20 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Quit: Leaving.]     
20:29 -!- cysm [cysm@gateway/shell/elitebnc/x-hghpelgumamvkozt] has quit [Ping timeout: 268 seconds]     
20:31 -!- JamesAU [~JamesAU@203.210.69.68] has joined #bitcoin-core-dev     
20:34 -!- cysm [cysm@gateway/shell/elitebnc/x-ambjwiazqxrigisn] has joined #bitcoin-core-dev     
20:35 -!- JamesAU [~JamesAU@203.210.69.68] has quit [Ping timeout: 240 seconds]     
20:41 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has joined #bitcoin-core-dev     
20:44 -!- ctya [~ctya@cpe-76-93-160-50.san.res.rr.com] has quit [Remote host closed the connection]     
20:53 -!- Sinclair6 [~sinclair6@2602:306:c4b1:2570:74ca:8102:d9b4:ee50] has quit []     
20:58 -!- Sinclair6 [~sinclair6@108-75-18-87.lightspeed.clmboh.sbcglobal.net] has joined #bitcoin-core-dev     
21:07 -!- Emcy_ [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev     
21:10 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 240 seconds]     
21:15 -!- musalbas [~musalbas@2001:bc8:30c2:ff00::] has quit [Ping timeout: 255 seconds]     
21:17 -!- JamesAU [~JamesAU@120.146.9.99] has joined #bitcoin-core-dev     
21:21 -!- JamesAU [~JamesAU@120.146.9.99] has quit [Remote host closed the connection]     
21:21 -!- JamesAU [~JamesAU@120.146.9.99] has joined #bitcoin-core-dev     
21:26 < bitcoin-git> [bitcoin] vii opened pull request #11785: Prevent file-descriptor exhaustion from RPC layer (master...master) https://github.com/bitcoin/bitcoin/pull/11785
21:54 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]     
21:55 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
22:26 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 248 seconds]     
22:35 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-dexlolywspvvcxmx] has quit [Quit: Connection closed for inactivity]     
22:38 -!- shesek [~shesek@bzq-84-110-53-47.cablep.bezeqint.net] has joined #bitcoin-core-dev     
22:38 -!- shesek [~shesek@bzq-84-110-53-47.cablep.bezeqint.net] has quit [Changing host]     
22:38 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev     
22:41 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev     
22:43 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-tnqquspxmzycmjwz] has joined #bitcoin-core-dev     
22:47 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has quit [Ping timeout: 248 seconds]     
22:56 -!- miker_ [cfa197c5@gateway/web/freenode/ip.207.161.151.197] has joined #bitcoin-core-dev     
22:56 -!- miker_ [cfa197c5@gateway/web/freenode/ip.207.161.151.197] has quit [Client Quit]     
22:58 -!- Krellan [~krellan@2601:640:4000:ab47:208f:23df:4e27:a1c9] has joined #bitcoin-core-dev     
22:58 -!- Krellan [~krellan@2601:640:4000:ab47:208f:23df:4e27:a1c9] has quit [Remote host closed the connection]     
22:58 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has joined #bitcoin-core-dev     
22:58 -!- Krellan [~krellan@2601:640:4000:ab47:208f:23df:4e27:a1c9] has joined #bitcoin-core-dev     
22:59 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has joined #bitcoin-core-dev     
23:17 -!- qrestlove [~qrestlove@2605:6000:eb4a:ef00::1] has joined #bitcoin-core-dev     
23:18 -!- qrestlove [~qrestlove@2605:6000:eb4a:ef00::1] has quit [Max SendQ exceeded]     
23:19 -!- qrestlove [~qrestlove@2605:6000:eb4a:ef00::1] has joined #bitcoin-core-dev     
23:22 -!- JamesAU [~JamesAU@120.146.9.99] has quit []     
23:36 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Remote host closed the connection]     
23:37 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev     
23:38 -!- photonclock_ [~photonclo@47.37.153.193] has quit [Ping timeout: 276 seconds]     
23:41 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 240 seconds]