--- Day changed Thu Feb 15 2018
00:01 -!- JackH [~laptop@alvira.static.korbank.pl] has quit [Ping timeout: 265 seconds]     
00:01 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev     
00:13 -!- JackH [~laptop@91.189.61.70] has joined #bitcoin-core-dev     
00:20 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev     
00:21 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has joined #bitcoin-core-dev     
00:24 < wumpus> booyah: lol! people kept contributing to the project, so the poor guy couldn't get his changes in :(
00:27 < wumpus> booyah: one thing seems to be consistent, they never really get open source development
00:28 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 248 seconds]     
00:29 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev     
00:35 < wumpus> or what Gavin's task was in the first place. for that matter
00:35 -!- drizztbsd [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev     
00:36 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 268 seconds]     
00:39 -!- Styil [Styil@gateway/vpn/privateinternetaccess/styil] has joined #bitcoin-core-dev     
00:51 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has joined #bitcoin-core-dev     
00:55 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has quit [Ping timeout: 240 seconds]     
01:02 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has joined #bitcoin-core-dev     
01:16 -!- murrayn [~dafuq@unaffiliated/murrayn] has joined #bitcoin-core-dev     
01:18 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Ping timeout: 256 seconds]     
01:25 -!- go1111111 [go1111111@gateway/vpn/privateinternetaccess/go1111111] has quit [Quit: Leaving]     
01:26 -!- TheRec [~toto@84-75-205-212.dclient.hispeed.ch] has joined #bitcoin-core-dev     
01:26 -!- TheRec [~toto@84-75-205-212.dclient.hispeed.ch] has quit [Changing host]     
01:26 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev     
01:29 < wumpus> cfields: our level of misunderanding of boost::interprocess::file_lock is phenomenal, can't we just delete that function :/
01:30 < wumpus> cfields: I think I'll just revert #12422 to the OpenBSD compile fix that it was, for 0.16, and leave the rest for master/0.17
01:30 < gribble> https://github.com/bitcoin/bitcoin/issues/12422 | util: Make LockDirectory thread-safe, consistent, and fix OpenBSD 6.2 build by laanwj · Pull Request #12422 · bitcoin/bitcoin · GitHub
01:33 < wumpus> cfields: the 'other process' test likely should have another case, that after process A giving up the locks (e.g. if it was only probing), B should succeed in getting it
01:34 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev     
01:37 -!- murrayn [~dafuq@unaffiliated/murrayn] has quit [Read error: Connection reset by peer]     
01:37 -!- murrayn [~dafuq@S01061cabc0b054b3.ok.shawcable.net] has joined #bitcoin-core-dev     
01:37 -!- murrayn [~dafuq@S01061cabc0b054b3.ok.shawcable.net] has quit [Changing host]     
01:37 -!- murrayn [~dafuq@unaffiliated/murrayn] has joined #bitcoin-core-dev     
01:51 -!- murrayn [~dafuq@unaffiliated/murrayn] has quit [Read error: Connection reset by peer]     
01:51 -!- murrayn [~dafuq@unaffiliated/murrayn] has joined #bitcoin-core-dev     
01:52 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has quit [Remote host closed the connection]     
01:52 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has joined #bitcoin-core-dev     
01:53 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has quit [Remote host closed the connection]     
01:53 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has joined #bitcoin-core-dev     
01:53 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has quit [Remote host closed the connection]     
01:54 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has joined #bitcoin-core-dev     
01:54 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has quit [Remote host closed the connection]     
01:55 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has joined #bitcoin-core-dev     
01:55 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has quit [Remote host closed the connection]     
01:56 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has joined #bitcoin-core-dev     
01:56 -!- murrayn [~dafuq@unaffiliated/murrayn] has quit [Read error: Connection reset by peer]     
01:56 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has quit [Remote host closed the connection]     
01:56 -!- murrayn [~dafuq@unaffiliated/murrayn] has joined #bitcoin-core-dev     
02:02 -!- murrayn [~dafuq@unaffiliated/murrayn] has quit [Read error: Connection reset by peer]     
02:03 -!- murrayn [~dafuq@unaffiliated/murrayn] has joined #bitcoin-core-dev     
02:09 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
02:11 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
02:14 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 276 seconds]     
02:17 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has quit [Quit: Ping timeout (120 seconds)]     
02:17 -!- Styil [Styil@gateway/vpn/privateinternetaccess/styil] has quit [Remote host closed the connection]     
02:18 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has joined #bitcoin-core-dev     
02:21 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev     
02:21 -!- ossifrage_ [~ossifrage@unaffiliated/ossifrage] has joined #bitcoin-core-dev     
02:22 < fanquake> wumpus I have a fix for the miniupnpc compile issue, will push up shortly
02:22 < wumpus> fanquake: great!
02:24 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has quit [Ping timeout: 260 seconds]     
02:30 -!- dafuq_ [~dafuq@S01061cabc0b054b3.ok.shawcable.net] has joined #bitcoin-core-dev     
02:31 -!- murrayn [~dafuq@unaffiliated/murrayn] has quit [Ping timeout: 276 seconds]     
02:32 -!- ken2812221 [~User@133-203.dorm.ncu.edu.tw] has quit [Ping timeout: 248 seconds]     
02:32 -!- ken2812221 [~User@133-203.dorm.ncu.edu.tw] has joined #bitcoin-core-dev     
02:34 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]     
02:35 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
02:38 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt]     
02:45 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev     
02:46 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection]     
02:46 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev     
02:49 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev     
02:50 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Read error: Connection reset by peer]     
02:54 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection]     
02:59 -!- Scrat [~herp@unaffiliated/scrat] has quit [Ping timeout: 255 seconds]     
02:59 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has joined #bitcoin-core-dev     
03:01 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev     
03:19 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has quit [Remote host closed the connection]     
03:20 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection]     
03:26 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev     
03:31 < fanquake> wumpus 12417 Should be able to go in now
03:39 < provoostenator> Rebasing is a pain, but my impression so far is that most of the time the stuff that's ready first goes in first.
03:42 < fanquake> provoostenator Are you just talking generally, or in regards to specific PR?
03:42 < provoostenator> I mean in general.
03:43 < meshcollider> yeah PRs which need rebasing or are failing travis tests tend to get fewer reviews than those which are ready from what I've seen
03:44 < provoostenator> That was ambiguous. Rebasing is a pain for some types of PR's and if Travis is having a bad day, but often a simple chore. In general when a PR has had enough review and feedback is addressed quickly enough, it goes in quickly, and then other PR's need to rebase.
03:44 < meshcollider> Oh I see what you meant
03:48 < provoostenator> 4 open PR's on 0.16.0. I'll try to test #12427
03:48 < gribble> https://github.com/bitcoin/bitcoin/issues/12427 | Make signrawtransaction accept P2SH-P2WSH redeemscripts by sipa · Pull Request #12427 · bitcoin/bitcoin · GitHub
03:50 -!- dafuq_ [~dafuq@S01061cabc0b054b3.ok.shawcable.net] has quit [Quit: Adios mofos]     
03:50 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection]     
03:51 -!- murrayn [~dafuq@S01061cabc0b054b3.ok.shawcable.net] has joined #bitcoin-core-dev     
03:51 -!- murrayn [~dafuq@S01061cabc0b054b3.ok.shawcable.net] has quit [Changing host]     
03:51 -!- murrayn [~dafuq@unaffiliated/murrayn] has joined #bitcoin-core-dev     
03:56 -!- lnostdal [~lnostdal@gateway/tor-sasl/lnostdal] has quit [Ping timeout: 255 seconds]     
03:58 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Quit: Leaving.]     
04:05 -!- anome [~anome@unaffiliated/anome] has joined #bitcoin-core-dev     
04:09 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/b2089c51cc4a...ae0fbf09817f
04:09 < bitcoin-git> bitcoin/master deee216 Douglas Roark: Delete mac_alias patch...
04:09 < bitcoin-git> bitcoin/master fc1bfcf Douglas Roark: Update mac_alias to 2.0.7
04:09 < bitcoin-git> bitcoin/master ae0fbf0 Wladimir J. van der Laan: Merge #12417: Upgrade mac_alias to 2.0.7...
04:09 < bitcoin-git> [bitcoin] laanwj closed pull request #12417: Upgrade mac_alias to 2.0.7 (master...master_del_mac_alias) https://github.com/bitcoin/bitcoin/pull/12417
04:12 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds]     
04:16 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
04:21 -!- Deinogalerix21 [~Deinogale@cpc93832-hari18-2-0-cust876.20-2.cable.virginm.net] has joined #bitcoin-core-dev     
04:26 -!- Deinogalerix21 [~Deinogale@cpc93832-hari18-2-0-cust876.20-2.cable.virginm.net] has quit [Ping timeout: 256 seconds]     
04:27 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-ashnfftsnfexandn] has joined #bitcoin-core-dev     
04:28 -!- Deinogalerix21 [~Deinogale@cpc93832-hari18-2-0-cust876.20-2.cable.virginm.net] has joined #bitcoin-core-dev     
04:29 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev     
04:35 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Read error: Connection reset by peer]     
04:36 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
04:43 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]     
04:45 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has quit [Quit: Leaving.]     
04:46 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
04:48 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
04:51 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]     
04:54 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]     
04:55 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
05:08 -!- d9b4bef9 [~d9b4bef9@207.38.94.106] has quit [Remote host closed the connection]     
05:09 -!- d9b4bef9 [~d9b4bef9@207.38.94.106] has joined #bitcoin-core-dev     
05:18 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev     
05:26 < wumpus> cfields: so I think you're right on the longer run - then we likely want the wallets (and init, for the main data dir) themselves to carry a RAII lock on the data directory instead of the funky map
05:34 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ae0fbf09817f...737ed8bb77d1
05:34 < bitcoin-git> bitcoin/master 2e9406c João Barbosa: Interrupt loading thread after shutdown request
05:34 < bitcoin-git> bitcoin/master 737ed8b Wladimir J. van der Laan: Merge #12415: Interrupt loading thread after shutdown request...
05:34 < bitcoin-git> [bitcoin] laanwj closed pull request #12415: Interrupt loading thread after shutdown request (master...2018-02-shutdown) https://github.com/bitcoin/bitcoin/pull/12415
05:37 -!- Sinclair_ [~sinclair6@108-75-18-87.lightspeed.clmboh.sbcglobal.net] has quit [Read error: Connection reset by peer]     
05:37 -!- Sinclair6 [~sinclair6@2602:306:c4b1:2570:47b:a46e:e3b1:404d] has joined #bitcoin-core-dev     
05:41 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]     
05:43 < bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.16: https://github.com/bitcoin/bitcoin/commit/f8938248ef37f67986e36ef897a548123b2d7a36
05:43 < bitcoin-git> bitcoin/0.16 f893824 João Barbosa: Interrupt loading thread after shutdown request...
05:43 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
05:46 < wumpus> re: #12349, can we be sure this issue is really solved after that?
05:46 < gribble> https://github.com/bitcoin/bitcoin/issues/12349 | shutdown: fix crash on shutdown with reindex-chainstate by theuni · Pull Request #12349 · bitcoin/bitcoin · GitHub
05:46 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 260 seconds]     
05:48 < wumpus> if not, I think we should think about it somewhat longer how to effectively fix it, and remove the 0.16.0 tag, we shouldn't merge fix after fix to different parts of the code without a clear idea if it's really fixed
05:55 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]     
05:59 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has joined #bitcoin-core-dev     
06:00 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
06:00 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
06:04 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]     
06:04 < wumpus> let's discuss it at the meeting
06:22 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-aqqlkbjngmrfcfto] has quit [Quit: Connection closed for inactivity]     
06:22 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev     
06:31 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev     
06:32 < promag> wumpus: will look #12349
06:32 < gribble> https://github.com/bitcoin/bitcoin/issues/12349 | shutdown: fix crash on shutdown with reindex-chainstate by theuni · Pull Request #12349 · bitcoin/bitcoin · GitHub
06:35 -!- Deinogalerix21 [~Deinogale@cpc93832-hari18-2-0-cust876.20-2.cable.virginm.net] has quit [Ping timeout: 248 seconds]     
06:36 -!- jamesob [~jamesob@rrcs-67-251-193-154.nyc.biz.rr.com] has joined #bitcoin-core-dev     
06:36 < promag> what is the idea to fix "ERROR: src/crypto/ctaes is not a subtree"? full clone?
06:37 < wumpus> promag: I really hate that solution, but yes, that'd solve it
06:37 -!- Deinogalerix21 [~Deinogale@185.169.255.9] has joined #bitcoin-core-dev     
06:37 < promag> is there an alternative?
06:39 < promag> git fetch commit_id && git reset --hard FETCH_HEAD ?
06:39 < wumpus> see #12388
06:39 < gribble> https://github.com/bitcoin/bitcoin/issues/12388 | travis failure on rc3: "src/crypto/ctaes is not a subtree" · Issue #12388 · bitcoin/bitcoin · GitHub
06:45 < wumpus> I think the scalable solution would be to skip the subtree check when the subtree is buried deeper than the shallow checkout
06:46 < wumpus> after all, the check is there to catch PRs that make changes to subtrees in the wrong way
06:46 < wumpus> if a change is buried below many other PRs then we can already be sure there's nothing to check
06:46 < wumpus> otherwise they wouldn'th ave been merged...
06:50 -!- jojeyh [~delphi@2602:306:b8b6:b970:b4ab:2df2:581f:7ebf] has quit [Ping timeout: 265 seconds]     
07:01 < bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.16: https://github.com/bitcoin/bitcoin/commit/e2431d144aa84909b106a767634126ad5821dc90
07:01 < bitcoin-git> bitcoin/0.16 e2431d1 MarcoFalke: travis: Full clone for git subtree check...
07:02 < wumpus> but I'll cherry pick that for now to the 0.16 branch
07:04 -!- Deinogalerix21 [~Deinogale@185.169.255.9] has quit [Ping timeout: 260 seconds]     
07:05 -!- Deinogalerix21 [~Deinogale@cpc93832-hari18-2-0-cust876.20-2.cable.virginm.net] has joined #bitcoin-core-dev     
07:06 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]     
07:07 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
07:11 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/737ed8bb77d1...bfa39114e2cf
07:11 < bitcoin-git> bitcoin/master fa27623 MarcoFalke: qt: Initialize members in WalletModel
07:11 < bitcoin-git> bitcoin/master bfa3911 Wladimir J. van der Laan: Merge #12426: qt: Initialize members in WalletModel...
07:11 < bitcoin-git> [bitcoin] laanwj closed pull request #12426: qt: Initialize members in WalletModel (master...Mf1802-qtInitializeMembersWalletModel) https://github.com/bitcoin/bitcoin/pull/12426
07:17 -!- Deinogalerix21 [~Deinogale@cpc93832-hari18-2-0-cust876.20-2.cable.virginm.net] has quit [Ping timeout: 256 seconds]     
07:19 -!- Deinogalerix21 [~Deinogale@185.169.255.9] has joined #bitcoin-core-dev     
07:26 -!- Deinogalerix21 [~Deinogale@185.169.255.9] has quit [Ping timeout: 256 seconds]     
07:27 -!- miya [46712ef6@gateway/web/freenode/ip.70.113.46.246] has joined #bitcoin-core-dev     
07:28 -!- Deinogalerix21 [~Deinogale@cpc93832-hari18-2-0-cust876.20-2.cable.virginm.net] has joined #bitcoin-core-dev     
07:31 -!- Murch [~murch@96-82-80-28-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev     
07:32 -!- Sabryna63Spinka [~Sabryna63@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 248 seconds]     
07:35 -!- Deinogalerix21 [~Deinogale@cpc93832-hari18-2-0-cust876.20-2.cable.virginm.net] has quit [Ping timeout: 240 seconds]     
07:36 < bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/bfa39114e2cf...fd65937ec601
07:36 < bitcoin-git> bitcoin/master c04e0f6 Ben Woosley: Fix 'mempool min fee not met' debug output...
07:36 < bitcoin-git> bitcoin/master 8b8a1c4 Ben Woosley: Add test for 'mempool min fee not met' rpc error
07:36 < bitcoin-git> bitcoin/master bb00c95 Ben Woosley: Consistently use FormatStateMessage in RPC error output...
07:36 -!- Deinogalerix21 [~Deinogale@cpc93832-hari18-2-0-cust876.20-2.cable.virginm.net] has joined #bitcoin-core-dev     
07:36 < bitcoin-git> [bitcoin] laanwj closed pull request #12356: Fix 'mempool min fee not met' debug output (master...minfee-message) https://github.com/bitcoin/bitcoin/pull/12356
07:37 -!- jamesob [~jamesob@rrcs-67-251-193-154.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds]     
07:41 -!- Deinogalerix21 [~Deinogale@cpc93832-hari18-2-0-cust876.20-2.cable.virginm.net] has quit [Ping timeout: 256 seconds]     
07:43 -!- Deinogalerix21 [~Deinogale@185.169.255.9] has joined #bitcoin-core-dev     
07:43 < bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.16: https://github.com/bitcoin/bitcoin/commit/5e40e64face29169ef355856dc0db46a98061046
07:43 < bitcoin-git> bitcoin/0.16 5e40e64 Wladimir J. van der Laan: travis: Don't fetch --unshallow when no longer shallow-cloning...
07:44 -!- jamesob [~jamesob@rrcs-67-251-193-154.nyc.biz.rr.com] has joined #bitcoin-core-dev     
07:47 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]     
07:47 -!- dcousens [~dcousens@110.140.128.4] has quit [Ping timeout: 265 seconds]     
07:47 -!- dcousens [~dcousens@101.188.205.96] has joined #bitcoin-core-dev     
07:52 -!- Marlin19Padberg [~Marlin19P@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev     
07:59 -!- jeanjean [~jean@223.73.245.150] has joined #bitcoin-core-dev     
07:59 -!- Deinogalerix21 [~Deinogale@185.169.255.9] has quit [Quit: WeeChat 2.0.1]     
08:00 -!- Deinogalerix21 [~Deinogale@185.169.255.9] has joined #bitcoin-core-dev     
08:00 -!- jeanjean [~jean@223.73.245.150] has quit [Client Quit]     
08:06 < provoostenator> Just got another whitespace error back from Travis. Anyone have a chance to bless or find problems with #12098 and #12097 so I can trivially prevent that on MacOS?
08:06 < gribble> https://github.com/bitcoin/bitcoin/issues/12098 | [scripts] lint-whitespace: add param to check last N commits by Sjors · Pull Request #12098 · bitcoin/bitcoin · GitHub
08:06 < gribble> https://github.com/bitcoin/bitcoin/issues/12097 | [scripts] lint-whitespace: use perl instead of grep -P by Sjors · Pull Request #12097 · bitcoin/bitcoin · GitHub
08:07 < ProfMac> I think the code lets us generate a block with any prev-block-hash.  That is, generate a fork at any block.  In practice, this seems to occur only at the best tip when two block arrive nearby in time.  Is it improper to think more restrictive thoughts that a new block can only point back to a tip?
08:08 < sipa> "the code" ?
08:08 < ProfMac> reference client, satoshi client ...
08:08 < sipa> in what context?
08:09 < sipa> there are many tests that mine forks
08:09 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has quit []     
08:09 < ProfMac> Do those tests only grow existing forks, or do they create new forks somewhere on the backbone?
08:10 < sipa> backbone?
08:10 < ProfMac> Yeah, backbone.  "best chain"
08:11 < sipa> oh     
08:11 < sipa> arbitrary
08:11 < sipa> look at p2p-fullnode.py
08:12 < ProfMac> I haven't looked into the test software source yet.  Thanks, I'll read that.
08:13 < sipa> but i don't understand your question at all
08:14 < sipa> forks happen all the time in the network
08:14 < sipa> and we need to deal with them
08:15 < sipa> even if only software existed that extended the tip, this would still be the case, simply due to the finite speed of communication
08:15 < sipa> (you may not have heard about the latest block someone created)
08:15 < ProfMac> Yes.  And yes.  I just wondered, in practice, do blocks show up that fork back 6 or 8 blocks from the best top.
08:15 < ProfMac> *tip
08:16 < sipa> yes     
08:16 < ProfMac> meaning, create a new fork 6 or 8 blocks back.  Not create a fork that ages to become that far back.
08:16 < sipa> very rarely though
08:17 < ProfMac> Yes, well, they would seem to be a bit pointless.
08:17 < sipa> let's move this to #bitcoin
08:17 < ProfMac> ok.     
08:17 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev     
08:20 -!- grafcaps [~haroldbr@50.90.83.229] has quit [Ping timeout: 268 seconds]     
08:22 < promag> jonasschnelli: friendly ping #11882
08:22 < gribble> https://github.com/bitcoin/bitcoin/issues/11882 | Disable default fallbackfee on mainnet by jonasschnelli · Pull Request #11882 · bitcoin/bitcoin · GitHub
08:30 -!- Marlin19Padberg [~Marlin19P@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 268 seconds]     
08:32 -!- jamesob [~jamesob@rrcs-67-251-193-154.nyc.biz.rr.com] has quit [Ping timeout: 248 seconds]     
08:36 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-ashnfftsnfexandn] has quit [Quit: Connection closed for inactivity]     
08:37 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev     
08:39 -!- grafcaps [~haroldbr@104.137.194.255] has joined #bitcoin-core-dev     
08:44 -!- miya [46712ef6@gateway/web/freenode/ip.70.113.46.246] has quit [Ping timeout: 260 seconds]     
08:47 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 240 seconds]     
08:47 -!- jeanjean [~jean@223.73.245.150] has joined #bitcoin-core-dev     
08:47 -!- JackH [~laptop@91.189.61.70] has quit [Ping timeout: 248 seconds]     
08:48 -!- NielsvG [~Necrathex@unaffiliated/necrathex] has quit [Ping timeout: 255 seconds]     
08:48 -!- jeanjean [~jean@223.73.245.150] has quit [Client Quit]     
08:49 -!- NielsvG [~Necrathex@2001:981:9573:1:d044:2ff:fe29:ad61] has joined #bitcoin-core-dev     
08:49 -!- NielsvG [~Necrathex@2001:981:9573:1:d044:2ff:fe29:ad61] has quit [Changing host]     
08:49 -!- NielsvG [~Necrathex@unaffiliated/necrathex] has joined #bitcoin-core-dev     
08:50 -!- Deinogalerix21 [~Deinogale@185.169.255.9] has quit [Ping timeout: 268 seconds]     
08:52 -!- Darion86Sauer [~Darion86S@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev     
08:53 -!- Scrat [~herp@unaffiliated/scrat] has joined #bitcoin-core-dev     
08:59 < promag> cfields: ignore my comment
08:59 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]     
09:08 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-orlpluqlkzzxegma] has joined #bitcoin-core-dev     
09:17 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/fd65937ec601...d09968f4d006
09:17 < bitcoin-git> bitcoin/master 65682da Sjors Provoost: [tests] bind functional test nodes to 127.0.0.1
09:17 < bitcoin-git> bitcoin/master d09968f Wladimir J. van der Laan: Merge #12200: Bind functional test nodes to 127.0.0.1...
09:18 < bitcoin-git> [bitcoin] laanwj closed pull request #12200: Bind functional test nodes to 127.0.0.1 (master...test-framework-bind) https://github.com/bitcoin/bitcoin/pull/12200
09:25 -!- jamesob [~jamesob@rrcs-67-251-193-154.nyc.biz.rr.com] has joined #bitcoin-core-dev     
09:37 -!- promag [~promag@31.22.144.241] has joined #bitcoin-core-dev     
09:41 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]     
09:42 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
09:43 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]     
09:47 -!- jamesob [~jamesob@rrcs-67-251-193-154.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds]     
09:54 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
09:55 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
09:59 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]     
10:07 -!- anome [~anome@unaffiliated/anome] has quit []     
10:08 -!- anome [~anome@unaffiliated/anome] has joined #bitcoin-core-dev     
10:09 -!- d3vt4r [71d2c010@gateway/web/freenode/ip.113.210.192.16] has joined #bitcoin-core-dev     
10:21 -!- anome [~anome@unaffiliated/anome] has quit []     
10:21 -!- d3vt4r [71d2c010@gateway/web/freenode/ip.113.210.192.16] has quit [Ping timeout: 260 seconds]     
10:23 -!- Dizzle [~dizzle@108.171.182.16] has joined #bitcoin-core-dev     
10:26 < cfields> wumpus: here now. my sleep schedule is all out of whack :\
10:26 < sipa> morning!
10:26 < cfields> heh     
10:27 < cfields> wumpus: yes, every time I think I understand it, something new pops up and totally confuses me again. Sorry for dragging you down with me :)
10:29 < cfields> wumpus: glad to see that we agree about longer-term. I was also thinking that we should move the wallet locks out of the map and into wallet as a follow-up.
10:29 -!- Darion86Sauer [~Darion86S@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 268 seconds]     
10:29 -!- jamesob [~jamesob@rrcs-67-251-193-154.nyc.biz.rr.com] has joined #bitcoin-core-dev     
10:30 -!- promag [~promag@31.22.144.241] has quit [Remote host closed the connection]     
10:31 < cfields> wumpus: re #12349, I'll test with current master now
10:31 < gribble> https://github.com/bitcoin/bitcoin/issues/12349 | shutdown: fix crash on shutdown with reindex-chainstate by theuni · Pull Request #12349 · bitcoin/bitcoin · GitHub
10:31 < wumpus> cfields: I feel the same about programming, and c++ in particular, there's always some new and unexpected situation that comes up
10:32 < wumpus> I also have the feeling boost doesn't help here :-)
10:32 < cfields> heh     
10:33 < wumpus> might make sense to implement this using the posix and win32 API at some point so that we actually know for sure what it's doing
10:34 -!- drizztbsd [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!]     
10:34 < wumpus> for now, having a test helps
10:42  * wumpus wonders what the windows equivalent of socketpair+fork is, e.g. create a process (doesn't have to copy the current one's state) with bidirectional pipe attached
10:46 < cfields> no clue. I assume something 100% winapi with no resemblence to posix :(
10:48 < wumpus> oh cool, we can do 90's style winapi with WM_* messages
10:49 < cfields> heh. Probably something like LockFile2Ex3Real()
10:50 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev     
10:50 < cfields> Where obviously LockFileEx might still work, but only up to Win3.1.
10:51 < cfields> it was dark days, dealing with that crap :)
10:52 < wumpus> yes :-)
11:00 < achow101> Meeting?
11:00 < Murch> aye     
11:01 < wumpus> #startmeeting
11:01 < lightningbot> Meeting started Thu Feb 15 19:01:13 2018 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
11:01 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
11:01 < wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator
11:02 < cfields> hi     
11:02 < wumpus> we're almost ready to tag rc4, the still open PRs could still use some review https://github.com/bitcoin/bitcoin/pulls?q=is%3Aopen+is%3Apr+milestone%3A0.16.0
11:02 -!- udiWertheimer_ [sid190185@gateway/web/irccloud.com/x-epuvdqgpuxevgmuk] has joined #bitcoin-core-dev     
11:02 < promag> hi     
11:02 -!- zivl [~zivl@2601:19a:837f:e4e1:69cb:77bd:b3c6:77a8] has quit [Quit: zivl]     
11:02 < kanzure> hi.     
11:02 -!- zivl [~zivl@2601:19a:837f:e4e1:5838:9e2a:88f:942b] has joined #bitcoin-core-dev     
11:03 < luke-jr> hi     
11:03 < cfields> I'm not sure if I'm happy to see people testing the RCs, or scared of how many things keep cropping up :\
11:03 < BlueMatt> heh     
11:04 -!- udiWertheimer_ [sid190185@gateway/web/irccloud.com/x-epuvdqgpuxevgmuk] has quit [Client Quit]     
11:04 < BlueMatt> yea     
11:04 < wumpus> I'd like to discuss #12349
11:04 < gribble> https://github.com/bitcoin/bitcoin/issues/12349 | shutdown: fix crash on shutdown with reindex-chainstate by theuni · Pull Request #12349 · bitcoin/bitcoin · GitHub
11:04 -!- udiWertheimer [sid190185@gateway/web/irccloud.com/x-ubcpzrugyykdkjql] has joined #bitcoin-core-dev     
11:04 < BlueMatt> i hate that fix, but it should be sufficient :(
11:04 < wumpus> #topic reindex-chainstate crash
11:04 < sipa> present
11:04 < wumpus> so we committed a fix for that in an earlier rc, but apparently the issue still exists
11:05 < BlueMatt> yes, the fix was for a highly-related bug
11:05 < BlueMatt> well, ok, essentially, either the same crash triggered by doing reindex, or the crash triggered by simply quickly quitting
11:06 < BlueMatt> so its already fixed for fast-quit
11:06 < wumpus> is it clear what the issue is in the first place? it seems it's causing workarounds to be spread over the code to 'fix' it
11:06 < wumpus> I'm not really happy to see that
11:06 < BlueMatt> yes, the issue is that we call Flush during shutdown before we've loaded genesis block
11:06 < cfields> wumpus: I just commented on the PR, I'll re-paste here for a little context:
11:06 < cfields> "As a small data point, though, we believed this to be qt only and couldn't hit it with rc3. It was @eklitzke's bitcoind backtrace that made it easy to reproduce."
11:06 < BlueMatt> so the flush assert(false)s because we have no "tip block" which we are flushing towards
11:07 < BlueMatt> huh? no?
11:07 < BlueMatt> I did not believe it to only be bitcoin-qt?
11:07 < BlueMatt> not sure where you got that
11:07 < wumpus> oh, and the flush assumes that the genesis block is there?
11:08 < BlueMatt> the flush assumes there is a tip block, including gensis
11:08 < promag> bitcoind crashed too
11:08 < MarcoFalke> ^     
11:08 < cfields> BlueMatt: huh, I was definitely working under that impression
11:08 < BlueMatt> there are several largely-unrelated bugs in qt
11:08 < BlueMatt> and there were other init-fast-shutdown-crash bugs in bitcoind
11:09 < cfields> not anymore ofc, now that we can hit it with bitcoind.
11:09 < BlueMatt> that trying to reproduce this and other issues dug up
11:09 < cfields> right, ok
11:09 < wumpus> there's no automatic test coverage for these paths, so problems are only found incidentally
11:10 < BlueMatt> yes, one thing I did during testing was just make ShutdownRequested() start shutdown after being called N times
11:10 < BlueMatt> and just restart with an incrementing N
11:10 < BlueMatt> this is something we could automate, but would largely not have caught the qt issues
11:10 < wumpus> nice idea
11:10 < wumpus> no, testing qt is a whole different can of worms
11:11 < promag> true
11:11 < wumpus> we solved some long-running bugs there recently :)
11:12 < promag> but do we care to flush if shutdown is requested?
11:12 < cfields> BlueMatt: I like that too. We'd just want to remember to grind hard on the tests before release
11:12 < promag> (on init)
11:12 < BlueMatt> to make it actually have good coverage we need to drop all direct accesses to fShutdownRequested and replace with ShutdownRequested()
11:12 < BlueMatt> which is why I missed the current incantation of the bug
11:12 < BlueMatt> cfields: its super fast, you could run it in travis
11:12 < MarcoFalke> I can do that
11:13 < wumpus>  drop all direct accesses to fShutdownRequested and replace with ShutdownRequested() -> that sounds like a good idea for encapsulation in any case
11:13 < BlueMatt> yes     
11:13 < cfields> can optimize the atomic too :p
11:14 < promag> what does that solve?
11:14 < BlueMatt> anyway, as for the current bug, I think #12349 is likely fine for 0.16, though I'd prefer it skips more of the FlushStateToDisk codepaths in the case that we've clearly never written anything we need to flush (morcos just pointed out it'd be nice to skip the wallet best chain setting, though unlikely thats a bug)
11:14 < gribble> https://github.com/bitcoin/bitcoin/issues/12349 | shutdown: fix crash on shutdown with reindex-chainstate by theuni · Pull Request #12349 · bitcoin/bitcoin · GitHub
11:14 < promag> maybe we should replace atomic var with a mutex? so that some blocks can hold the mutex and prevent others to continue?
11:14  * BlueMatt has non-x86 hardware coming soon (I think there will likely be a dev box or two available for people who want to test/work on core on powerpc at that time as well), it'd be great to see more atomic relaxations =D
11:15 < BlueMatt> promag: wat, why would you do that?
11:15 < wumpus> looks like problem that has spooked us for a long time, that much of the code cannot cope without genesis block set
11:15 < cfields> promag: that's a different long discussion :). It was really just a joke in this context
11:15 < wumpus> it should only be a problem in shutdown() because we don't exit AppInit() succesfully in that ase
11:16 < wumpus> AppInitMain()
11:16 < BlueMatt> wumpus: yes, one other thing to be done is to move fucking ThreadImport up inside init, but  regular old reindex is hard to work with to fix this issue
11:16 < BlueMatt> unless you want to re-introduce the bug where we write a copy of genesis every time we load.......
11:16 < wumpus> but other sneaky things come up all the time
11:16 < promag> BlueMatt: because once you request the shutdown other threads can start the tear down, which can mess other stuff
11:16 < BlueMatt> promag: shutdown can happen at any point, you shouldnt be able to block shutdown by taking a lock.....
11:17 < wumpus> BlueMatt: let's at least have a test for that, that if someone regresses that we'd at least detect it
11:17 < BlueMatt> subsystem separation should work.......
11:17 < BlueMatt> wumpus: yes, agreed....didnt MarcoFalke just say he'd build it? =D
11:17 < cfields> BlueMatt: yea, my earlier iterations skipped more of FlushStateToDisk, but I figured it was best to not tangle that logic up with init's
11:17 < wumpus> promag: we don't really have that issue afaik
11:18 < wumpus> but ok, then we keep #12349 for 0.16
11:18 < BlueMatt> cfields: hmm, ugh
11:18 < gribble> https://github.com/bitcoin/bitcoin/issues/12349 | shutdown: fix crash on shutdown with reindex-chainstate by theuni · Pull Request #12349 · bitcoin/bitcoin · GitHub
11:18 < BlueMatt> cfields: cant we literally skip the entire function in that case?
11:18 < BlueMatt> we clear the dbs on load themselves
11:18 < wumpus> please pray let it be fixed now 
11:18 < BlueMatt> so its not like we have anything at all whatsoever to flush
11:18 < wumpus> :P     
11:18 < BlueMatt> lol     
11:19 -!- opdenkamp [~opdenkamp@kodi/staff/dushmaniac] has quit [Quit: ZNC 1.6.5+deb1 - http://znc.in]     
11:19 < cfields> BlueMatt: yes, but that involves locking changes
11:19 < cfields> (possibly only one teeny tiny one)
11:19 < wumpus> noooooo
11:19 < BlueMatt> ugh, I still want to go back to my CChainState::fWeveDoneAnythingAtAll idea
11:19 < wumpus> we saw what happened last time we tried "locking changes" :-)
11:19 < cfields> right, hence _this_ approach :)
11:19 < BlueMatt> and just insert that and skip flush if its false
11:19 < promag> next topic suggestion #11913
11:19 < gribble> https://github.com/bitcoin/bitcoin/issues/11913 | Avoid cs_main during ReadBlockFromDisk Calls by TheBlueMatt · Pull Request #11913 · bitcoin/bitcoin · GitHub
11:19 < BlueMatt> wumpus: yea, we ended up with a super-long 0.16 release process.....sorry :(
11:20 < cfields> BlueMatt: +1 for master. Completely agree.
11:20 < wumpus> BlueMatt: it's not your fault, the code is just completely crazy in that regard
11:20 < BlueMatt> wumpus: no, I meant the validationinterface queue garbage, that had a few last-minute bugs as well
11:21 < wumpus> promag: sure
11:21 < wumpus> #topic Avoid cs_main during ReadBlockFromDisk Calls
11:21 < BlueMatt> what about it?
11:21 < wumpus> yes, what about it
11:21 < BlueMatt> I mean needs a ton of rebase due to merging of a dep, but I can do that whenever folks are ready to review
11:22 < wumpus> it's obviously a concept ack
11:22 < promag> is this going forward?
11:22 < promag> I mean, it's in priority review
11:22 < BlueMatt> I dont see why not, I mean my name's on the tin, but...
11:22 < wumpus> it's not going backward at least!
11:22 < BlueMatt> oh, you're saying I should rebase
11:22 < BlueMatt> yea, k
11:23 < BlueMatt> I mean IIRC it shoudl be reviewable if you just ignore the first few commits
11:23 < BlueMatt> which are since merged
11:23 < BlueMatt> but whatever
11:23 < promag> like that, there are others that avoid cs_main
11:23 < BlueMatt> it appears I have two things in high-priority though, which is not ok
11:23 < wumpus> if some commits are merged you can say it has been going forward
11:23 < BlueMatt> anyway, next topic?
11:23 < wumpus> any other topics?
11:24 < BlueMatt> Bitcoin!
11:24 < sipa> Bitcoin!
11:24 < achow101> encrypting wallets without restarting
11:24 < wumpus> what about it?
11:25 < cfields> wumpus: It's this new cryptocurrency...
11:25 < sipa> LOL     
11:25 < wumpus> aren't bitcoins those big, golden coins with 1's and 0's on them?
11:25 < wumpus> I think they're too heavy to ever be practical
11:25 < cfields> haha
11:25 < wumpus> #topic encrypting wallets without restarting (achow101)
11:25 < achow101> relevant PR is #11678
11:26 < gribble> https://github.com/bitcoin/bitcoin/issues/11678 | [wallet] Dont shut down after encrypting the wallet by achow101 · Pull Request #11678 · bitcoin/bitcoin · GitHub
11:26 < BlueMatt> yea, you have to carry around a computer to spend them....arent those those things that take up like a whole basement and you have to hire a few people to maintain it?
11:26 < achow101> there's a really really really ugly hack in that pr to make it work from the rpcconsole
11:27 < achow101> but I'm kinda stuck on a better way to let people encrypt from the rpcconsole and not have the gui get all screwed up
11:28 < promag> achow101: with dynamic wallet loading this should be easier?
11:28 < wumpus> BlueMatt: a computer?! oh no, I heard there wil never be demand for more than 10 of them in the whole world
11:28 < achow101> promag: I don't think so
11:28 < kanzure> what is the problem with a restart?
11:28 < achow101> I noted in the dynamic reloading pr that it actually has a similar problem if you try to reload the wallet that is currently used by the gui
11:28 < wumpus> kanzure: for multiwallet it can be kind of annoying, I guess
11:29 < wumpus> kanzure: if you want to encrypt 10 wallets and need to restart 10 times
11:29 < BlueMatt> I mean, yea, question is how it gets handled in dynamic multiwallet gui, handle it the same way........
11:29 < BlueMatt> all that code is gonna have to get written one way or another
11:29 < BlueMatt> de-init'ing the whole gui wallet stuff and re-init'ing it is gonna have to exist
11:29 < achow101> BlueMatt: the thing is, dynamic multiwallet doesn't handle it at all
11:29 < BlueMatt> not that I have any opinion on *how*
11:30 < cfields> maybe an unpopular opinion, but forcing the inconvenience of a shutdown for this doesn't seem terrible to me...
11:30 < BlueMatt> achow101: well that just sounds downright broken
11:30 < kanzure> wumpus: perhaps just do it all at once and do only one restart.
11:30 < BlueMatt> cfields: see wumpus note on encrypting multiple wallets
11:30 < wumpus> cfields: I don't think it's particularly urgent either, no
11:30 < cfields> in fact, seems like it should really be handled by a tool outside of bitcoind
11:30 < wumpus> but I never encrypt wallets so don't listen to me
11:30 < BlueMatt> sounds good, lets remove encrypted wallet support!
11:31 -!- Sinclair6 [~sinclair6@2602:306:c4b1:2570:47b:a46e:e3b1:404d] has quit [Ping timeout: 255 seconds]     
11:31 < promag> achow101: it needs fixing then, between dyn wallet, your pr and #11383
11:31 < wumpus> (well obviously I encrypt backups, but I don't use bitcoin's encrypted wallet stuff)
11:31 < gribble> https://github.com/bitcoin/bitcoin/issues/11383 | Basic Multiwallet GUI support by luke-jr · Pull Request #11383 · bitcoin/bitcoin · GitHub
11:31 < sipa> cfields: i think that we're struggling to do so is probably a sign of some problems internally, regardless of whether it's a desired feature or not
11:31 < achow101> My plan for doing wallet encryption by default needed to do something like this, so I went and did it as a separate thing
11:31 < wumpus> but yes, once we have dynamic wallet unloading and loading, it shoudl be straightforward
11:31 < BlueMatt> sipa: that was my point...we're gonna have to handle it wrt dynamic multiwallet
11:31 < wumpus> so focus on that first
11:31 < achow101> but I kinda got stuck at how the hell to get the rpcconsole to tell the gui to reload the wallet
11:32 < sipa> BlueMatt: yup, agree
11:32 < wumpus> just unload the wallet ,resilver/rewrite it, then reopen it, voila
11:32 < cfields> sipa: fair point.
11:32 < promag> wumpus: +1
11:32 < achow101> wumpus: that's what I thought. but then qt got in the way
11:32 < promag> the gui should react
11:32 < promag> some signals etc
11:32 < wumpus> achow101: GUI should subscribe to wallet unload events
11:32 < achow101> wumpus: qt and the rpcconsole donn't interact particularly well
11:32 < achow101> apparently
11:32 < wumpus> achow101: and delete the associated state from the GUI
11:32 < wumpus> promag: yes exactly
11:33 < BlueMatt> achow101: I'm confused, so this is an open issue to solve for dynamic multiwallet gui, no?
11:33 < achow101> BlueMatt: it is
11:33 < BlueMatt> ok, so the question is how to handle it properly in that case?
11:33 < wumpus> wallets have an associated GUI object (walletmodel) which then needs to be deleted, as well as the tabs/other stuff associated with that wallet
11:33 < promag> what's the deal with rpcconsole? because of the target wallet of wallet commands?
11:34 < achow101> BlueMatt: the issue that needs to be handled is how to get the gui to reload a wallet from actions that happened over rpc
11:34 < wumpus> how is the console a problem? does it care about wallets?
11:34 < promag> I think #11383 deals with changing wallets, it's a matter to change to null wallet
11:34 < gribble> https://github.com/bitcoin/bitcoin/issues/11383 | Basic Multiwallet GUI support by luke-jr · Pull Request #11383 · bitcoin/bitcoin · GitHub
11:34 < wumpus> it just interprets commands and sends them to the RPC interface IIRC
11:34 < wumpus> oh the wallet selectbox thing
11:34 < wumpus> yes, that needs to listen to wallet removal events too, then...
11:34 < achow101> wumpus: things that happen over rpc need to be reflected in the gui
11:35 < wumpus> so I'd say first implement it in the RPC
11:35 < kanzure> are the relevant qt signal hooks not implemented..?
11:35 < wumpus> then later make a PR to do it for the GUI
11:35 < promag> both gui and rpc should load/unload wallets in the same place, and only then the gui reacts
11:35 < wumpus> that's usually the order in which we do things
11:35 < achow101> wumpus: but then people may use the rpcconsole which just does the rpc things, and that will just break the gui.
11:35 < achow101> it segfaults
11:35 < wumpus> GUI is usually a hairier business, and needs different reviewers
11:36 < wumpus> oh yes it should certainly not segfault..
11:36 -!- sengehest [~sengehest@188.81-166-37.customer.lyse.net] has joined #bitcoin-core-dev     
11:36 < achow101> e.g. for the encrypting the wallet without restarting, it works over rpc and in the gui if you encrypt from gui
11:36 < achow101> but if you call encryptwallet from the rpcconsole, it will segfault
11:37 < achow101> because rpc cannot tell gui to reload the wallet
11:37 < wumpus> so that's because we don't have the hooks in place for dynamic wallet loading/unloading yet
11:37 < wumpus> we need that first
11:37 < achow101> yes     
11:37 < promag> rpc and gui don't know each other
11:37 < achow101> I guess the question is really *how*
11:37 < achow101> since rpc and gui don't really talk to each other
11:37 < wumpus> ay other topics?
11:37 < wumpus> achow101: using signals, conencting the GUI to them
11:37 < promag> achow101: let's discuss this later
11:38 < wumpus> achow101: the same as it works for other ClientModel. WalletModel signals
11:38 < jnewbery> dynamic wallet loading (#10740) is very much a work in progress. I haven't touched it for a while because it felt like we would want multiwallet in the GUI to go in first
11:38 < gribble> https://github.com/bitcoin/bitcoin/issues/10740 | [WIP] [wallet] dynamic loading/unloading of wallets by jnewbery · Pull Request #10740 · bitcoin/bitcoin · GitHub
11:39 < wumpus> so there's a signal WalletAboutToBeUnloaded, and a signal NewWallet, the GUI can handle those and take appropriate action
11:39 < promag> jnewbery: right, that was the last conclusion iirc
11:40 < wumpus> other topics?
11:40 < kanzure> please send me your topic suggestions for my collection for march things, including short-term (like specific issues or merge requests) and long-term (future stuff)
11:40 < wumpus> #action please send kanzure your topic suggestions for my collection for march things, including short-term (like specific issues or merge requests) and long-term (future stuff)
11:41 < kanzure> i could also just randomly assign issues :-)
11:41 < cfields> kanzure: thanks for doing that
11:41 < luke-jr> #12208 should still be in 0.16, somehow not tagged/merged yet
11:41 < gribble> https://github.com/bitcoin/bitcoin/issues/12208 | GUI: Rephrase Bech32 checkbox texts, and enable it with legacy address default by luke-jr · Pull Request #12208 · bitcoin/bitcoin · GitHub
11:42 < achow101> any news on the mpc rsa signing key?
11:43 < wumpus> luke-jr: doing a string change in a rc would be really unwise, we can tag it 0.16.1 though
11:43 < luke-jr> wumpus: more unwise than having confusing strings?
11:43 < wumpus> luke-jr: yes
11:43 < wumpus> it's too late, translators have no chance to even look at it anymore
11:43 < luke-jr> could copy the translations to it, but whatever
11:44 < luke-jr> long-term, I guess that could result in confusing translations persisting XD
11:44 -!- Dizzle [~dizzle@108.171.182.16] has quit [Quit: Leaving...]     
11:44 < cfields> I'm sure we'll learn a lot about bech32 confusion with 0.16.0. We'll be in better shape to clean it up for 0.16.1 with that feedback, I think.
11:45 < wumpus> &     
11:45 < wumpus> ^     
11:45 < luke-jr> well, as-is, it seems to affirm the myth that there is a from address
11:45  * booyah can translate whatever string to PL if anyone needs quickly just ping me
11:46 < booyah> if it's like 1 string I bet on #bitcoin + reddit community has someone ready for any lang
11:46 < achow101> meta topic: meeeting notes
11:47 < wumpus> #topic meeting notes
11:47 < achow101> the person I got to write the meeting notes got bored with it so they aren't happening anymore :(
11:47 < sipa> can't blame them, i guess..
11:47 < wumpus> oh :(
11:48 < cfields> sex.
11:48 < cfields> there, fixed. next topic?
11:48 < wumpus> heh     
11:48 < wumpus> I think we're out of topics
11:48 < wumpus> #endmeeting
11:48 < lightningbot> Meeting ended Thu Feb 15 19:48:53 2018 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
11:48 < lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-02-15-19.01.html
11:48 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-02-15-19.01.txt
11:48 < lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-02-15-19.01.log.html
11:49 < kanzure> for march topics, send your topics or someone else's topics. it's fair game to insist that someone else talks about a thing >:-).
11:49 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #12442: devtools: Exclude patches from lint-whitespace (master...Mf1802-devtoolsLintWhitespaceExcludePatches) https://github.com/bitcoin/bitcoin/pull/12442
11:49 < achow101> kanzure: what's the current list of topics?
11:49 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev     
11:50 < kanzure> achow101: i have a few items, might post it in public soon. i've done this a few times in the past before meetups.
11:50 < kanzure> usually i just write down a wishlist of what i want people to talk about, but i definitely overlook some items just out of sheer ignorance or something
11:51 < kanzure> or what i know people are working on
11:52 < promag> achow101: fyi later I'm going to test 11678
11:52 < achow101> kanzure: ah, I thought the list might be published already
11:52 < achow101> promag: ok
11:52 -!- Sister78Fisher [~Sister78F@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev     
11:52 < achow101> promag: that current implementation is really bad
11:52 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]     
11:52 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection]     
11:53 -!- jamespeerless [~jamespeer@c-73-234-176-58.hsd1.ma.comcast.net] has joined #bitcoin-core-dev     
11:54 -!- anome [~anome@unaffiliated/anome] has joined #bitcoin-core-dev     
11:55 -!- d_t [~d_t@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev     
11:58 -!- jamesob [~jamesob@rrcs-67-251-193-154.nyc.biz.rr.com] has quit [Ping timeout: 256 seconds]     
11:58 -!- opdenkamp [~opdenkamp@kodi/staff/dushmaniac] has joined #bitcoin-core-dev     
11:58 -!- anome [~anome@unaffiliated/anome] has quit [Client Quit]     
12:00 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt]     
12:01 -!- Sister78Fisher [~Sister78F@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 276 seconds]     
12:03 -!- ossifrage_ is now known as ossifrage     
12:06 -!- sengehest [~sengehest@188.81-166-37.customer.lyse.net] has quit [Ping timeout: 268 seconds]     
12:07 -!- sengehest [~sengehest@188.81-166-37.customer.lyse.net] has joined #bitcoin-core-dev     
12:09 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev     
12:12 -!- sengehest [~sengehest@188.81-166-37.customer.lyse.net] has quit [Ping timeout: 248 seconds]     
12:17 -!- contrapumpkin [~copumpkin@haskell/developer/copumpkin] has quit [Quit: My MacBook Pro has gone to sleep. ZZZzzz…]     
12:18 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]     
12:22 < jonasschnelli> sorry. missed the meeting. currently UTC+10.5
12:23 -!- kmels [~kmels@190.14.132.229] has joined #bitcoin-core-dev     
12:24 -!- Giszmo [~leo@ip-9-237-219-201.nextelmovil.cl] has joined #bitcoin-core-dev     
12:28 < wumpus> jonasschnelli: you didn't miss that much, though please join in our prayer that rc4 will be final :)
12:29 < sipa> i guess it will be an alleged rc4? :p
12:29 < gmaxwell> You need to discard it's initial output if you want it to be good.
12:30 < morcos> i think thats what the c stands for
12:49 -!- n1bor [~n1bor@185.9.34.66] has quit [Quit: Leaving]     
12:51 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has quit [Ping timeout: 255 seconds]     
12:52 -!- Kenneth35Wilderm [~Kenneth35@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev     
12:53 -!- kislayraj [a0ca25f4@gateway/web/freenode/ip.160.202.37.244] has joined #bitcoin-core-dev     
12:54 -!- sengehest [~sengehest@188.81-166-37.customer.lyse.net] has joined #bitcoin-core-dev     
12:58 -!- AriseChikun [Arise@gateway/vpn/privateinternetaccess/arisechikun] has quit [Read error: Connection reset by peer]     
12:58 -!- AriseChikun [Arise@gateway/vpn/privateinternetaccess/arisechikun] has joined #bitcoin-core-dev     
12:59 -!- sengehest [~sengehest@188.81-166-37.customer.lyse.net] has quit [Ping timeout: 265 seconds]     
13:02 -!- Sinclair6 [~sinclair6@2602:306:c4b1:2570:47b:a46e:e3b1:404d] has joined #bitcoin-core-dev     
13:06 -!- anome [~anome@unaffiliated/anome] has joined #bitcoin-core-dev     
13:09 -!- Dizzle [~dizzle@108.171.182.16] has joined #bitcoin-core-dev     
13:11 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/d09968f4d006...58715f6d073f
13:11 < bitcoin-git> bitcoin/master fc888bf Wladimir J. van der Laan: util: Fix multiple use of LockDirectory...
13:11 < bitcoin-git> bitcoin/master 1d4cbd2 Wladimir J. van der Laan: test: Add unit test for LockDirectory...
13:11 -!- kislayraj [a0ca25f4@gateway/web/freenode/ip.160.202.37.244] has quit [Ping timeout: 260 seconds]     
13:11 < bitcoin-git> bitcoin/master 58715f6 Wladimir J. van der Laan: Merge #12422: util: Make LockDirectory thread-safe, consistent, and fix OpenBSD 6.2 build...
13:11 < bitcoin-git> [bitcoin] laanwj closed pull request #12422: util: Make LockDirectory thread-safe, consistent, and fix OpenBSD 6.2 build (master...2018_01_openbsd_util_fix) https://github.com/bitcoin/bitcoin/pull/12422
13:17 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev     
13:22 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/58715f6d073f...5eff1c748d56
13:22 < bitcoin-git> bitcoin/master ceaefdd Cory Fields: fix possible shutdown assertion with -reindex-shutdown...
13:22 < bitcoin-git> bitcoin/master 5eff1c7 Wladimir J. van der Laan: Merge #12349: shutdown: fix crash on shutdown with reindex-chainstate...
13:23 < bitcoin-git> [bitcoin] laanwj closed pull request #12349: shutdown: fix crash on shutdown with reindex-chainstate (master...fix-qt-shutdown) https://github.com/bitcoin/bitcoin/pull/12349
13:29 -!- Kenneth35Wilderm [~Kenneth35@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 265 seconds]     
13:31 < promag> achow101: nack on those __Model::ReloadWallet()
13:32 < promag> by design an __Model instance is tied to the wallet received in the constructor
13:33 < promag> the same for WalletModel 
13:33 < achow101> promag: yeah, I'll probably ditch all of that once I figure out how to use boost signals
13:34 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5eff1c748d56...3fa556aee203
13:34 < bitcoin-git> bitcoin/master 5f605e1 Pieter Wuille: Make signrawtransaction accept P2SH-P2WSH redeemscripts
13:34 < bitcoin-git> bitcoin/master 3fa556a Wladimir J. van der Laan: Merge #12427: Make signrawtransaction accept P2SH-P2WSH redeemscripts...
13:34 -!- ZeroBug [5fea353d@gateway/web/freenode/ip.95.234.53.61] has joined #bitcoin-core-dev     
13:34 < promag> I really think you should wait for jnewbery or try to rebase his PR and build from there
13:34 < bitcoin-git> [bitcoin] laanwj closed pull request #12427: Make signrawtransaction accept P2SH-P2WSH redeemscripts (master...201802_signrawp2shp2wsh) https://github.com/bitcoin/bitcoin/pull/12427
13:36 < promag> you should consider TransactionTableModel::wallet const (the same for other models)
13:37 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Ping timeout: 255 seconds]     
13:40 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev     
13:41 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]     
13:43 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev     
13:52 -!- Weldon73Halvorso [~Weldon73H@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev     
13:54 -!- jojeyh [~delphi@99-59-126-62.lightspeed.irvnca.sbcglobal.net] has joined #bitcoin-core-dev     
13:55 < bitcoin-git> [bitcoin] laanwj pushed 4 new commits to 0.16: https://github.com/bitcoin/bitcoin/compare/5e40e64face2...3762ac127aec
13:55 < bitcoin-git> bitcoin/0.16 32a7268 Wladimir J. van der Laan: util: Fix multiple use of LockDirectory...
13:55 < bitcoin-git> bitcoin/0.16 4d54e7a Wladimir J. van der Laan: test: Add unit test for LockDirectory...
13:55 < bitcoin-git> bitcoin/0.16 ad10b90 Cory Fields: fix possible shutdown assertion with -reindex-shutdown...
14:05 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 248 seconds]     
14:05 -!- jojeyh [~delphi@99-59-126-62.lightspeed.irvnca.sbcglobal.net] has quit [Ping timeout: 248 seconds]     
14:08 -!- jojeyh [~delphi@99-59-126-62.lightspeed.irvnca.sbcglobal.net] has joined #bitcoin-core-dev     
14:10 < promag> wumpus: if you are up to merges see #12083
14:10 < gribble> https://github.com/bitcoin/bitcoin/issues/12083 | Improve getchaintxstats test coverage by promag · Pull Request #12083 · bitcoin/bitcoin · GitHub
14:10 < wumpus> sorry, I'm busy at the moment
14:12 < bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.16: https://github.com/bitcoin/bitcoin/commit/51093478c0e1d79b2aa4296c5f93dcf41c1ea92f
14:12 < bitcoin-git> bitcoin/0.16 5109347 Wladimir J. van der Laan: qt: Pre-rc4 translations update...
14:12 < promag> np, it's mainly a test pr with 2 utack
14:17 -!- ZeroBug [5fea353d@gateway/web/freenode/ip.95.234.53.61] has quit [Quit: Page closed]     
14:27 -!- jojeyh [~delphi@99-59-126-62.lightspeed.irvnca.sbcglobal.net] has quit [Ping timeout: 268 seconds]     
14:27 < cfields> wumpus: preparing to tag tonight?
14:28 < wumpus> cfields: yep
14:28 < cfields> great :)
14:32 < sipa> "the same thing we do every night, pinky"
14:32 < wumpus> pinky and the brain brain brain
14:33 < bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.16: https://github.com/bitcoin/bitcoin/commit/a8e62a842615d338d41caf1603de4263a7f4bad8
14:33 < bitcoin-git> bitcoin/0.16 a8e62a8 Wladimir J. van der Laan: doc: Update release notes from wiki for rc3...
14:33 < bitcoin-git> [bitcoin] theuni opened pull request #12444: gitian: bump descriptors for (0.)17 (master...gitian-bump) https://github.com/bitcoin/bitcoin/pull/12444
14:33 -!- jamesob [~jamesob@rrcs-67-251-193-154.nyc.biz.rr.com] has joined #bitcoin-core-dev     
14:34 < cfields> haha
14:34 -!- jamespeerless [~jamespeer@c-73-234-176-58.hsd1.ma.comcast.net] has quit [Quit: jamespeerless]     
14:38 < wumpus>  * [new tag]         v0.16.0rc4 -> v0.16.0rc4
14:41 < cfields> woohoo
14:41 < cfields> now go relax :)
14:42 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]     
14:45 < wumpus> :)     
14:47 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has quit [Remote host closed the connection]     
14:48 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has joined #bitcoin-core-dev     
14:52 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has quit [Ping timeout: 240 seconds]     
14:54  * esotericnonsense cheers
14:57 -!- sengehest [~sengehest@188.81-166-37.customer.lyse.net] has joined #bitcoin-core-dev     
14:58 -!- Weldon73Halvorso [~Weldon73H@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 256 seconds]     
15:02 -!- sengehest [~sengehest@188.81-166-37.customer.lyse.net] has quit [Ping timeout: 260 seconds]     
15:03 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has joined #bitcoin-core-dev     
15:11 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-quzsxnrrnkbuqdqt] has joined #bitcoin-core-dev     
15:20 < meshcollider> Oh I missed the meeting
15:20 -!- Giszmo [~leo@ip-9-237-219-201.nextelmovil.cl] has quit [Quit: Leaving.]     
15:20 < meshcollider> rc4 \o/
15:22 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has quit [Ping timeout: 265 seconds]     
15:23 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has joined #bitcoin-core-dev     
15:24 -!- jamesob [~jamesob@rrcs-67-251-193-154.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds]     
15:24 -!- anome [~anome@unaffiliated/anome] has quit []     
15:25 -!- anome [~anome@unaffiliated/anome] has joined #bitcoin-core-dev     
15:30 -!- Dizzle [~dizzle@108.171.182.16] has quit [Quit: Leaving...]     
15:43 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev     
15:52 -!- Jasmin42Hahn [~Jasmin42H@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev     
15:53 < dx25> @sipa, did you write the cashaddr.h/cpp module in bitcoin-abc?
15:53 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 255 seconds]     
15:54 < dx25> because if so, that's hilarious.
15:54 -!- dongcarl [~dongcarl@2601:645:8201:a6f8:ec4:7aff:fee5:3ab0] has joined #bitcoin-core-dev     
15:54 < sipa> no, but it was adapted from the bech32.cpp module in bitcoin core
15:54 < sipa> which i did write
15:54 < dx25> oh ok
16:02 -!- Jasmin42Hahn [~Jasmin42H@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 240 seconds]     
16:09 -!- grafcaps [~haroldbr@104.137.194.255] has quit [Ping timeout: 240 seconds]     
16:21 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
16:22 -!- grafcaps [~haroldbr@50.90.83.229] has joined #bitcoin-core-dev     
16:23 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]     
16:27 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit []     
16:28 < achow101> at least they kept the copyright header this time
16:30 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/3fa556aee203...a233fb4f1d03
16:30 < bitcoin-git> bitcoin/master fafbf7f MarcoFalke: devtools: Exclude patches from lint-whitespace
16:30 < bitcoin-git> bitcoin/master a233fb4 MarcoFalke: Merge #12442: devtools: Exclude patches from lint-whitespace...
16:30 < gmaxwell> yea, they changed their strategy from removing the attribution to leaving it and falsely announcing that people were contributing to their project: https://twitter.com/jimmysong/status/952611979742601216
16:31 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #12442: devtools: Exclude patches from lint-whitespace (master...Mf1802-devtoolsLintWhitespaceExcludePatches) https://github.com/bitcoin/bitcoin/pull/12442
16:32 < jimmysong> for what it's worth, deadalnix told me that one was specific to me because he wanted me to "choose sides"
16:32  * dongcarl *facepalm*
16:32 < jimmysong> no interest in aligning there
16:34 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has quit []     
16:35 < Emcy_> lolol
16:36 < Emcy_> pick a side or we will pick one for you
16:36 < esotericnonsense> well, there is the flip side
16:37 < gmaxwell> :(     
16:37 < esotericnonsense> as a bitcoin ABC contributor, I can go ahead and claim expert authority on the project being a nonsense
16:37 < Emcy_> youll have to bunk with rog if you choose the flip side
16:37 < gmaxwell> how did he expect that to work
16:37 < gmaxwell> meh, sorry I'm being offtopic
16:38 -!- Murch [~murch@96-82-80-28-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.]     
16:39 < Emcy_> jimmysong isnt deadlnix one of them libertarian voluntaryists ive heard so much about
16:39 < Emcy_> really interesting praxis
16:39 -!- dfgsr [6e1792f7@gateway/web/freenode/ip.110.23.146.247] has joined #bitcoin-core-dev     
16:40 < jimmysong> i guess he wanted me to say "yes i'm a contributor to bch"
16:40 < jimmysong> or something like that
16:40 < esotericnonsense> heh     
16:41 < Emcy_> bolster the 'multiple independent developers' rhetoric id guess
16:41 < jimmysong> something like that
16:41 < jimmysong> still don't understand why he did it that way
16:41 < jimmysong> just makes him look bad
16:41 < Emcy_> because hes a prick
16:41 < Emcy_> applying occams razor
16:42 < sipa> please, can we stick to technical topics relating to bitcoin core here
16:42 < jimmysong> sorry
16:49 -!- hsmiths [uid95325@gateway/web/irccloud.com/x-khcqgezqeozrdktu] has quit [Ping timeout: 255 seconds]     
16:49 -!- dfgsr [6e1792f7@gateway/web/freenode/ip.110.23.146.247] has quit [Quit: Page closed]     
16:50 -!- hsmiths [uid95325@gateway/web/irccloud.com/x-bznnitfpnknltrql] has joined #bitcoin-core-dev     
16:51 -!- anome [~anome@unaffiliated/anome] has quit []     
16:52 -!- Francisco16Schow [~Francisco@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev     
16:53 -!- sengehest [~sengehest@188.81-166-37.customer.lyse.net] has joined #bitcoin-core-dev     
16:55 -!- farmerwampum_ [~farmerwam@209.95.50.117] has joined #bitcoin-core-dev     
16:59 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has joined #bitcoin-core-dev     
17:01 -!- sengehest [~sengehest@188.81-166-37.customer.lyse.net] has quit [Ping timeout: 260 seconds]     
17:05 -!- Emcy_ [~Emcy@unaffiliated/emcy] has quit [Read error: Connection reset by peer]     
17:15 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev     
17:15 < Emcy> whoops i thought this was forks sorry
17:20 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Read error: Connection reset by peer]     
17:23 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev     
17:25 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has joined #bitcoin-core-dev     
17:39 -!- jamespeerless [~jamespeer@c-76-19-21-187.hsd1.ma.comcast.net] has joined #bitcoin-core-dev     
17:54 -!- sengehest [~sengehest@188.81-166-37.customer.lyse.net] has joined #bitcoin-core-dev     
17:58 -!- Francisco16Schow [~Francisco@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 260 seconds]     
17:59 -!- sengehest [~sengehest@188.81-166-37.customer.lyse.net] has quit [Ping timeout: 248 seconds]     
18:23 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has quit [Quit: Snoozing.]     
18:25 -!- jb55 [~jb55@70-36-49-138.dyn.novuscom.net] has joined #bitcoin-core-dev     
18:45 -!- ProfMac [~ProfMac@2001:470:b8ac:0:65d7:5d8:cbec:b9d3] has quit [Ping timeout: 265 seconds]     
18:47 -!- sengehest [~sengehest@188.81-166-37.customer.lyse.net] has joined #bitcoin-core-dev     
18:51 -!- sengehest [~sengehest@188.81-166-37.customer.lyse.net] has quit [Ping timeout: 240 seconds]     
18:52 -!- Andreanne8Howe [~Andreanne@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev     
18:57 -!- Andreanne8Howe [~Andreanne@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 240 seconds]     
19:02 -!- sengehest [~sengehest@188.81-166-37.customer.lyse.net] has joined #bitcoin-core-dev     
19:04 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has joined #bitcoin-core-dev     
19:07 -!- sengehest [~sengehest@188.81-166-37.customer.lyse.net] has quit [Ping timeout: 240 seconds]     
19:09 -!- meshcollider_ [uid246294@gateway/web/irccloud.com/x-qsilhhmxuiakvyln] has joined #bitcoin-core-dev     
19:10 -!- meshcollider_ [uid246294@gateway/web/irccloud.com/x-qsilhhmxuiakvyln] has quit [Client Quit]     
19:18 -!- ProfMac [~ProfMac@2001:470:b8ac:0:5024:69c9:281:623e] has joined #bitcoin-core-dev     
19:18 -!- jamespeerless [~jamespeer@c-76-19-21-187.hsd1.ma.comcast.net] has quit [Quit: jamespeerless]     
19:47 -!- sengehest [~sengehest@188.81-166-37.customer.lyse.net] has joined #bitcoin-core-dev     
19:48 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev     
19:51 -!- sengehest [~sengehest@188.81-166-37.customer.lyse.net] has quit [Ping timeout: 240 seconds]     
19:52 -!- Robin53Bartell [~Robin53Ba@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev     
19:53 -!- sengehest [~sengehest@188.81-166-37.customer.lyse.net] has joined #bitcoin-core-dev     
19:57 -!- sengehest [~sengehest@188.81-166-37.customer.lyse.net] has quit [Ping timeout: 240 seconds]     
20:00 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 276 seconds]     
20:00 -!- Madars [~null@unaffiliated/madars] has quit [Ping timeout: 256 seconds]     
20:01 -!- AriseChikun [Arise@gateway/vpn/privateinternetaccess/arisechikun] has quit [Quit: Konversation terminated!]     
20:05 -!- Madars [~null@unaffiliated/madars] has joined #bitcoin-core-dev     
20:15 < fanquake> meshcollider could you do that script testing on your own repo?
20:16 < meshcollider> fanquake: sorry, is it emailing you? Just finished testing it on my repo so its done anyway :)
20:18 < fanquake> meshcollider yes, ok
20:19 -!- jojeyh [~delphi@2602:306:b8b6:b970:3935:aa3:38a8:cfe7] has joined #bitcoin-core-dev     
20:19 < meshcollider> fanquake: why is it emailing you if travis isn't even enabled on the repo? Or does it notify you of all PR changes?
20:21 < fanquake> meshcolllier you get notified of PR changes
20:24 -!- AriseChikun [Arise@gateway/vpn/privateinternetaccess/arisechikun] has joined #bitcoin-core-dev     
20:36 -!- AriseChikun [Arise@gateway/vpn/privateinternetaccess/arisechikun] has quit [Read error: Connection reset by peer]     
20:36 -!- AriseChikun [Arise@gateway/vpn/privateinternetaccess/arisechikun] has joined #bitcoin-core-dev     
20:39 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev     
20:40 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 265 seconds]     
20:41 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has quit [Quit: Leaving.]     
20:48 -!- sengehest [~sengehest@188.81-166-37.customer.lyse.net] has joined #bitcoin-core-dev     
20:52 -!- sengehest [~sengehest@188.81-166-37.customer.lyse.net] has quit [Ping timeout: 240 seconds]     
21:06 -!- PINKY62 [bdd8bd30@gateway/web/freenode/ip.189.216.189.48] has joined #bitcoin-core-dev     
21:24 -!- niska [~niska@149.56.14.68] has quit [Ping timeout: 256 seconds]     
21:32 -!- niska [~niska@68.ip-149-56-14.net] has joined #bitcoin-core-dev     
21:33 -!- fb [67fbd17e@gateway/web/freenode/ip.103.251.209.126] has joined #bitcoin-core-dev     
21:34 -!- fb is now known as Guest2711     
21:36 -!- Guest2711 [67fbd17e@gateway/web/freenode/ip.103.251.209.126] has quit [Client Quit]     
21:36 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-orlpluqlkzzxegma] has quit [Quit: Connection closed for inactivity]     
21:45 -!- ProfMac [~ProfMac@2001:470:b8ac:0:5024:69c9:281:623e] has quit [Ping timeout: 256 seconds]     
21:47 -!- sengehest [~sengehest@188.81-166-37.customer.lyse.net] has joined #bitcoin-core-dev     
21:47 -!- jb55 [~jb55@70-36-49-138.dyn.novuscom.net] has quit [Ping timeout: 248 seconds]     
21:49 -!- grafcaps [~haroldbr@50.90.83.229] has quit [Ping timeout: 260 seconds]     
21:57 -!- neha [~narula@tbilisi.csail.mit.edu] has quit [Ping timeout: 240 seconds]     
21:58 -!- neha [~narula@tbilisi.csail.mit.edu] has joined #bitcoin-core-dev     
22:00 -!- PINKY62 [bdd8bd30@gateway/web/freenode/ip.189.216.189.48] has quit [Quit: Page closed]     
22:00 -!- sengehest [~sengehest@188.81-166-37.customer.lyse.net] has quit []     
22:07 -!- harrymm_ [~harrymm@104.207.83.25] has quit [Ping timeout: 256 seconds]     
22:10 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has joined #bitcoin-core-dev     
22:20 -!- harrymm_ [~harrymm@104.207.83.17] has joined #bitcoin-core-dev     
22:32 < GitHub1> [bitcoin-detached-sigs] jonasschnelli opened pull request #4: 0.16: osx signatures for 0.16.0rc4 (0.16...0.16) https://github.com/bitcoin-core/bitcoin-detached-sigs/pull/4
22:46 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-quzsxnrrnkbuqdqt] has quit [Quit: Connection closed for inactivity]     
23:00 -!- windsok [~windsok@unaffiliated/windsok] has quit [Remote host closed the connection]     
23:00 -!- windsok [~windsok@unaffiliated/windsok] has joined #bitcoin-core-dev     
23:07 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has quit [Ping timeout: 255 seconds]     
23:09 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has joined #bitcoin-core-dev     
23:34 -!- denis2342 [~denis@x4db4972f.dyn.telefonica.de] has joined #bitcoin-core-dev     
23:36 < denis2342> I have a small build regression on freebsd with 0.16.0rc4: https://pastebin.com/i9zPDKXd
23:36 < denis2342> seems a header is missing
23:48 < denis2342> adding #include <signal.h> to src/test/util_tests.cpp fixes the problem