--- Day changed Fri Feb 16 2018 00:04 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 00:04 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer] 00:04 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 00:07 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a233fb4f1d03...1f055ef9d798 00:07 < bitcoin-git> bitcoin/master d7f438a Cory Fields: gitian: bump descriptors for (0.)17 00:07 < bitcoin-git> bitcoin/master 1f055ef Wladimir J. van der Laan: Merge #12444: gitian: bump descriptors for (0.)17... 00:08 < bitcoin-git> [bitcoin] laanwj closed pull request #12444: gitian: bump descriptors for (0.)17 (master...gitian-bump) https://github.com/bitcoin/bitcoin/pull/12444 00:10 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1f055ef9d798...26dc2daf82d2 00:10 < bitcoin-git> bitcoin/master be45a67 Richard Kiss: Add some script tests related to BOOL ops and odd values like negative 0. 00:10 < bitcoin-git> bitcoin/master 26dc2da Wladimir J. van der Laan: Merge #12425: Add some script tests... 00:11 < bitcoin-git> [bitcoin] laanwj closed pull request #12425: Add some script tests (master...feature/bool_tests) https://github.com/bitcoin/bitcoin/pull/12425 00:19 < wumpus> denis2342: hrm, I'll try rebuildilng my freebsd node and see if I run into the same 00:19 -!- dund [~dundz@ip72-193-223-242.lv.lv.cox.net] has quit [Read error: Connection reset by peer] 00:21 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 00:33 -!- anome [~anome@unaffiliated/anome] has joined #bitcoin-core-dev 00:40 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-jtlkjgikdwrlhgai] has joined #bitcoin-core-dev 00:48 -!- tma98 [9a78e49e@gateway/web/freenode/ip.154.120.228.158] has joined #bitcoin-core-dev 00:48 < tma98> hi 00:54 -!- tma98 [9a78e49e@gateway/web/freenode/ip.154.120.228.158] has quit [Quit: Page closed] 01:05 -!- anome [~anome@unaffiliated/anome] has quit [] 01:24 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 01:26 -!- d3vt4r [71d26796@gateway/web/freenode/ip.113.210.103.150] has joined #bitcoin-core-dev 01:27 -!- timothy [tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:32 -!- denis2342_ [~denis@x4db474d4.dyn.telefonica.de] has joined #bitcoin-core-dev 01:33 -!- lnostdal [~lnostdal@gateway/tor-sasl/lnostdal] has joined #bitcoin-core-dev 01:34 -!- denis2342 [~denis@x4db4972f.dyn.telefonica.de] has quit [Ping timeout: 265 seconds] 01:38 -!- d_t [~d_t@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has quit [Ping timeout: 255 seconds] 01:45 -!- lnostdal [~lnostdal@gateway/tor-sasl/lnostdal] has quit [Remote host closed the connection] 01:45 -!- lnostdal [~lnostdal@gateway/tor-sasl/lnostdal] has joined #bitcoin-core-dev 01:46 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has joined #bitcoin-core-dev 01:55 -!- anome [~anome@unaffiliated/anome] has joined #bitcoin-core-dev 02:01 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 02:13 -!- d3vt4r [71d26796@gateway/web/freenode/ip.113.210.103.150] has quit [Ping timeout: 260 seconds] 02:18 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has quit [Remote host closed the connection] 02:26 < fanquake> wumpus I agree with closing https://github.com/bitcoin-core/gitian.sigs/pull/614 02:27 < fanquake> #678 is more interesting as a quick check, making sure that submitters are only modifying a single dir. However that is still a trivial thing to check anyways. 02:27 < gribble> https://github.com/bitcoin/bitcoin/issues/678 | changing the GUI language · Issue #678 · bitcoin/bitcoin · GitHub 02:28 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:29 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:29 < wumpus> fanquake: I think it's difficult, I mwan from a user perspective it's useful to be alerted when signatures diverge, what "m less convinced about is that travis is always the right hammer for the job 02:30 < wumpus> FWIW this is the same feeling that I have with hooking all kinds of things like whitespace linters into travis. If there was a better way to customize the message/icon that appears in the github issue it'd be better. 02:30 < fanquake> I also agree that diverging/"incorrect" signatures should be merged regardless. 02:30 < wumpus> yep, something could warn after merging 02:32 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 02:39 < promag> wumpus: https://github.com/travis-ci/travis-tasks/pull/78#issuecomment-276139159 02:39 < promag> circle does what you want https://github.com/travis-ci/travis-tasks/pull/78#issuecomment-276139159 02:41 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has joined #bitcoin-core-dev 03:02 < bitcoin-git> [bitcoin] laanwj opened pull request #12447: test: Add missing signal.h header (master...2018_02_freebsd_compile_fix) https://github.com/bitcoin/bitcoin/pull/12447 03:03 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 03:08 < wumpus> promag: interesting! 03:17 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 03:17 -!- denis2342_ [~denis@x4db474d4.dyn.telefonica.de] has quit [Quit: denis2342_] 03:20 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has quit [Read error: Connection reset by peer] 03:21 -!- Robin53Bartell [~Robin53Ba@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 240 seconds] 03:40 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has quit [Remote host closed the connection] 03:52 -!- Garrison16Lockma [~Garrison1@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 03:58 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-mcnctcczoarynfaz] has joined #bitcoin-core-dev 04:14 -!- anome [~anome@unaffiliated/anome] has quit [Read error: Connection reset by peer] 04:19 -!- jamesob [~jamesob@108.114.189.73] has joined #bitcoin-core-dev 04:21 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 04:25 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 260 seconds] 04:32 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 04:36 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 04:40 -!- jojeyh [~delphi@2602:306:b8b6:b970:3935:aa3:38a8:cfe7] has quit [Ping timeout: 252 seconds] 04:43 -!- Deinogalerix21 [~Deinogale@185.169.255.9] has joined #bitcoin-core-dev 04:45 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 05:03 < bitcoin-git> [bitcoin] promag opened pull request #12448: Interrupt block generation on shutdown request (master...2018-02-interrupt-generate-blocks) https://github.com/bitcoin/bitcoin/pull/12448 05:06 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev 05:09 < promag> wumpus: what kind of test? 05:09 < promag> generate bigcount and in parallel quit? 05:10 < wumpus> well in this case a test that does generateblock 10000 then sends an interrupt request and checks that bitcoin shuts down cleanly 05:10 < wumpus> though I'd argue this is not an important one to test 05:10 < wumpus> the early-outs in init, are 05:11 < promag> right 05:11 < promag> I was benchmarking stuff and did generate 100000 05:11 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 05:11 < wumpus> (that is where we had two fixes for, in the rc cycle... because early-outs leave the process in an inconsistent, or at least unpexpected state that may cause trouble later) 05:12 < promag> and then I had to kill -9 otherwise it didn't stop 05:12 < wumpus> which is fine, no one does software development perfectly, seeing all potential conseequences to a change (if only!), but illustrates tests are needed 05:13 < promag> and generateBlocks is non main net right? 05:15 -!- Deinogalerix21 [~Deinogale@185.169.255.9] has quit [Quit: WeeChat 2.0.1] 05:19 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 05:19 < wumpus> if you can use it for mainnet, interrupting *between* blocks isn't going to help you 05:20 < wumpus> even generating one block at the current difficulty with the naive, single-threaded miner meant for regtest is going to take a million years 05:40 -!- jochemin [~jochemin3@213.99.53.154] has quit [Remote host closed the connection] 05:40 -!- jochemin [~jochemin3@213.99.53.154] has joined #bitcoin-core-dev 05:40 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 05:41 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 264 seconds] 05:47 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Quit: Leaving.] 05:48 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Remote host closed the connection] 05:49 -!- jochemin [~jochemin3@213.99.53.154] has quit [Quit: Leaving] 05:49 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev 05:55 -!- jamespeerless [~jamespeer@c-76-19-21-187.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 05:58 -!- jamesob [~jamesob@108.114.189.73] has quit [Ping timeout: 248 seconds] 06:00 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has quit [Ping timeout: 268 seconds] 06:01 -!- Garrison16Lockma [~Garrison1@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 240 seconds] 06:03 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #12451: Bump leveldb subtree (master...Mf1802-leveldbSubtreeBump) https://github.com/bitcoin/bitcoin/pull/12451 06:04 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has joined #bitcoin-core-dev 06:04 -!- jamespeerless [~jamespeer@c-76-19-21-187.hsd1.ma.comcast.net] has quit [Quit: jamespeerless] 06:18 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/26dc2daf82d2...4a62ddd01873 06:18 < bitcoin-git> bitcoin/master dd7e42c Wladimir J. van der Laan: test: Add missing signal.h header... 06:18 < bitcoin-git> bitcoin/master 4a62ddd MarcoFalke: Merge #12447: test: Add missing signal.h header... 06:19 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #12447: test: Add missing signal.h header (master...2018_02_freebsd_compile_fix) https://github.com/bitcoin/bitcoin/pull/12447 06:21 -!- farmerwampum_ [~farmerwam@209.95.50.117] has quit [Ping timeout: 265 seconds] 06:26 -!- jamesob [~jamesob@rrcs-67-251-193-154.nyc.biz.rr.com] has joined #bitcoin-core-dev 06:32 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 06:35 -!- jamespeerless [~jamespeer@c-73-234-176-58.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 06:36 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 06:37 < provoostenator> I added an #ifdef ENABLE_WALLET in guiutil.h, but the compiler seems to think this is undefined for this particular file even though I configured with the wallet enabled. 06:41 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 252 seconds] 06:45 < kallewoof> provoostenator: you may need to do the HAVE_CONFIG_H deal first? (e.g. compat.h style) 06:47 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 06:49 < provoostenator> kallewoof: thanks, that did the trick. What does it do? 06:52 -!- Georgiana72West [~Georgiana@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 06:55 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 240 seconds] 07:00 -!- Aaronvan_ is now known as AaronvanW 07:04 -!- ProfMac [~ProfMac@2001:470:b8ac:0:d55e:ca08:161a:394d] has joined #bitcoin-core-dev 07:11 -!- Cogito_Ergo_Sum [~Myself@ppp-94-64-157-186.home.otenet.gr] has joined #bitcoin-core-dev 07:11 -!- Cogito_Ergo_Sum [~Myself@ppp-94-64-157-186.home.otenet.gr] has quit [Changing host] 07:11 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has joined #bitcoin-core-dev 07:13 -!- Georgiana72West [~Georgiana@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 248 seconds] 07:14 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 07:14 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 07:23 < kallewoof> provoostenator: it pulls in defines from autoconf etc, I believe 07:27 -!- mirese_ [~mirese@2a02:1205:507c:3710:3d8b:b52c:85a0:b9e6] has joined #bitcoin-core-dev 07:31 -!- mirese [~mirese@2a02:1205:507c:3710:4026:56c6:958:f3d2] has quit [Ping timeout: 256 seconds] 07:34 -!- dcousens [~dcousens@101.188.205.96] has quit [Ping timeout: 248 seconds] 07:35 -!- dcousens [~dcousens@101.188.191.248] has joined #bitcoin-core-dev 07:36 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 07:41 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 255 seconds] 07:46 -!- rosdi [79797437@gateway/web/freenode/ip.121.121.116.55] has joined #bitcoin-core-dev 07:52 -!- Maynard11Spinka [~Maynard11@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 07:53 -!- rosdi [79797437@gateway/web/freenode/ip.121.121.116.55] has quit [Ping timeout: 260 seconds] 07:58 -!- AriseChikun [Arise@gateway/vpn/privateinternetaccess/arisechikun] has quit [Remote host closed the connection] 08:00 -!- RubenSomsen [~RubenSoms@1.217.138.142] has joined #bitcoin-core-dev 08:02 -!- Maynard11Spinka [~Maynard11@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 256 seconds] 08:05 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 08:07 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 08:08 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 08:36 < cfields> yep 08:36 < cfields> it's so that you can tell the difference between autoconf'd builds and non 08:37 < cfields> for ex, you can (or could at one point) build bitcoind with MSVC, you just have to define all of the stuff that autoconf would've detected for you 08:39 -!- Deinogalerix21 [~Deinogale@185.169.255.9] has joined #bitcoin-core-dev 08:40 < bitcoin-git> [bitcoin] laanwj pushed 6 new commits to master: https://github.com/bitcoin/bitcoin/compare/4a62ddd01873...59e032b43cea 08:40 < bitcoin-git> bitcoin/master 5a10859 fanquake: [depends] expat 2.2.5 08:40 < bitcoin-git> bitcoin/master 61647a4 fanquake: [depends] ccache 3.4.1 08:40 < bitcoin-git> bitcoin/master 41550d6 fanquake: [depends] miniupnpc 2.0.20180203 08:41 < bitcoin-git> [bitcoin] laanwj closed pull request #12402: [depends] expat 2.2.5, ccache 3.4.1, miniupnpc 2.0.20180203 (master...depends-02-2018) https://github.com/bitcoin/bitcoin/pull/12402 08:42 < cfields> wumpus: that one wasn't ready yet :\ 08:51 -!- grafcaps [~haroldbr@50.90.83.229] has joined #bitcoin-core-dev 08:52 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 08:52 -!- Ericka76Shields [~Ericka76S@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 08:57 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 256 seconds] 08:57 -!- grafcaps [~haroldbr@50.90.83.229] has quit [Ping timeout: 276 seconds] 09:02 -!- Ericka76Shields [~Ericka76S@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 276 seconds] 09:04 < wumpus> cfields: what's the problem? 09:11 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev 09:12 -!- instagibbs [~instagibb@pool-100-15-116-35.washdc.fios.verizon.net] has quit [Ping timeout: 248 seconds] 09:18 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-jtlkjgikdwrlhgai] has quit [Quit: Connection closed for inactivity] 09:19 -!- instagibbs [~instagibb@pool-100-15-116-35.washdc.fios.verizon.net] has joined #bitcoin-core-dev 09:26 -!- grafcaps [~haroldbr@104.137.194.255] has joined #bitcoin-core-dev 09:39 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 265 seconds] 09:41 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 09:42 -!- RubenSomsen [~RubenSoms@1.217.138.142] has quit [Quit: Leaving] 09:43 -!- jb55 [~jb55@216-71-192-56.dyn.novuscom.net] has joined #bitcoin-core-dev 09:44 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 09:46 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 248 seconds] 09:47 -!- Murch [~murch@96-82-80-28-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 09:52 -!- Curtis27Boyle [~Curtis27B@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 09:56 < gmaxwell> Someone noticed again that cross chain swaps can be broken due to different size limits on different systems https://bitcointalk.org/index.php?topic=2960023.0 09:56 < gmaxwell> sipa: do you recall where this was previously pointed out? 10:03 -!- timothy [tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 10:19 -!- Curtis27Boyle [~Curtis27B@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 240 seconds] 10:21 < GitHub194> [bitcoin-detached-sigs] theuni closed pull request #4: 0.16: osx signatures for 0.16.0rc4 (0.16...0.16) https://github.com/bitcoin-core/bitcoin-detached-sigs/pull/4 10:23 < cfields> gitian builders: v0.16.0rc4 detached sigs are pushed 10:23 < cfields> wumpus: the darwin define for miniupnpc is done universally 10:23 < cfields> I'll nag on the PR 10:25 < wumpus> cfields: whoops so that define is for upnp itself, not a hint to darwin. I thought it was the latter so defining it universally wouldn't hurt. 10:26 < cfields> right. it's unlikely to be an issue, but if it turned out to manifest somewhere, it'd be really nasty to track down 10:30 -!- Deinogalerix21 [~Deinogale@185.169.255.9] has quit [Ping timeout: 240 seconds] 10:30 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 10:31 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 10:34 < jcorgan> is there a how-to-do-gitian-builds-for-fun-and-profit-and-mental-health.md somewhere? 10:36 < achow101> jcorgan: https://github.com/bitcoin-core/docs/tree/master/gitian-building and https://github.com/bitcoin/bitcoin/blob/master/doc/release-process.md 10:36 < achow101> good luck 10:38 < jcorgan> if you don't hear from me in 72 hours send out the search teams 10:39 < wumpus> achow101: he's gonna need it 10:43 -!- farmerwampum [~farmerwam@209.95.51.102] has joined #bitcoin-core-dev 10:49 < jnewbery> review beg: #10583 . achow101 has rebased about a squillion times 10:49 < gribble> https://github.com/bitcoin/bitcoin/issues/10583 | [RPC] Split part of validateaddress into getaddressinfo by achow101 · Pull Request #10583 · bitcoin/bitcoin · GitHub 10:50 < bitcoin-git> [bitcoin] DaveFromBinary opened pull request #12452: [Docs] Clarified systemd installation instructions in init.md for Ubuntu users. (master...doc-init-updates) https://github.com/bitcoin/bitcoin/pull/12452 10:52 -!- Hector67Nader [~Hector67N@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 10:53 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 10:57 -!- Hector67Nader [~Hector67N@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 256 seconds] 10:57 -!- jb55 [~jb55@216-71-192-56.dyn.novuscom.net] has quit [Ping timeout: 276 seconds] 11:06 < bitcoin-git> [bitcoin] Empact opened pull request #12455: Fix bip68 sequence test to reflect updated rpc error message (master...fix-bip68-test) https://github.com/bitcoin/bitcoin/pull/12455 11:12 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 11:16 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 255 seconds] 11:20 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 11:24 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 240 seconds] 11:29 < ProfMac> I did a gitian build back in 0.14.xx. The process was not well documented, and I could not reproduce whatever I did from my notes. Is the documentation process any better now? 11:30 -!- d_t [~d_t@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 11:39 < wumpus> https://github.com/bitcoin-core/docs/blob/master/gitian-building.md 11:39 < wumpus> improvements are always welcome 11:40 < achow101> I don't think the problem is documentation but rather that gitian doesn't always work 11:43 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 11:46 < MarcoFalke> It is like Jenga. All the virtualizations or OSes that it depends on pull out sticks and you wait until it breaks 11:48 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 252 seconds] 11:52 -!- Leopoldo4Heaney [~Leopoldo4@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 11:54 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has quit [Quit: (https://github.com/mmgen) leaving] 12:00 -!- grafcaps [~haroldbr@104.137.194.255] has quit [Quit: Lost terminal] 12:02 -!- Leopoldo4Heaney [~Leopoldo4@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 248 seconds] 12:05 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 12:10 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Remote host closed the connection] 12:10 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 248 seconds] 12:11 -!- d_t [~d_t@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has quit [Ping timeout: 276 seconds] 12:11 < bitcoin-git> [bitcoin] Empact opened pull request #12458: Enforce that amount is provided for signrawtransaction prevtxs (master...rawtransaction-amount-required) https://github.com/bitcoin/bitcoin/pull/12458 12:12 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 12:25 -!- jb55 [~jb55@s66-183-189-187.bc.hsia.telus.net] has joined #bitcoin-core-dev 12:28 < esotericnonsense> is univalue compiled seperately without C++11 ? i'm struggling with my make-fu 12:29 < esotericnonsense> it disagrees with my use of nullptr 12:29 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection] 12:33 < esotericnonsense> yeah, that's it. 12:37 < bitcoin-git> [bitcoin] Empact opened pull request #12459: Assert compressed / compact keys and sigs are strictly shorter than regular (master...assert-compressed-smaller) https://github.com/bitcoin/bitcoin/pull/12459 12:38 < bitcoin-git> [bitcoin] Empact opened pull request #12460: Assert CPubKey::ValidLength to the pubkey's header-relevent size (master...key-size-check-header) https://github.com/bitcoin/bitcoin/pull/12460 12:39 < bitcoin-git> [bitcoin] Empact opened pull request #12461: Refactor key / signature size consts to be relative to their relevant class (master...key-size-consts) https://github.com/bitcoin/bitcoin/pull/12461 12:39 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 12:40 < bitcoin-git> [bitcoin] Empact closed pull request #12319: Add header-sensitive size checking via CPubKey::ValidSize, and prefer key/sig size const references (master...pubkeysize) https://github.com/bitcoin/bitcoin/pull/12319 12:42 < cfields> esotericnonsense: "yeah, that's it" ? 12:43 < esotericnonsense> cfields: if I hack in g++ -std=c++11 into the makefile for univalue that works (I'm currently trying to figure out how to do this properly and fixing up some other compilation errors) 12:44 < cfields> yikes! 12:44 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 240 seconds] 12:44 < esotericnonsense> what's yikes? that we weren't using c++11 for univalue? the concept of using it? :) 12:44 -!- grubles [~grubles@unaffiliated/grubles] has quit [Ping timeout: 248 seconds] 12:44 < cfields> yikes that we're possibly mixing ABIs in our binaries 12:45 < cfields> I'm surprised we haven't seen issues from that yet 12:45 < esotericnonsense> mmm. unfortunately my knowledge of this stuff has kind of faded after spending years in python-land. slowly getting there again. 12:46 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 248 seconds] 12:46 < cfields> heh, no worries 12:46 < cfields> I'll PR a fix, unless you want to drill down into it 12:48 < esotericnonsense> up to you. i'm making a small change to univalue that requires it, but my knowledge of make is very limited (i' 12:48 < esotericnonsense> (i'd just be hacking in -std=c+11 into flags until it works on my box) 12:49 < esotericnonsense> well it doesn't require it because I don't _need_ to use nullptr it's just consistent that way 12:49 < bitcoin-git> [bitcoin] Empact opened pull request #12463: Drop the return argument from CValidationState::DoS and Invalid (master...drop-dos-return) https://github.com/bitcoin/bitcoin/pull/12463 12:49 < bitcoin-git> [bitcoin] Empact closed pull request #12357: Rationalize the CValidationState interface by splitting ::DoS across ::Invalid and ::Corrupt (master...validation-state-corrupt) https://github.com/bitcoin/bitcoin/pull/12357 12:51 < cfields> well, we haven't discussed it afaik, but it makes sense to keep univalue c++03 simply because it already is 12:52 -!- Mona87Dooley [~Mona87Doo@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 12:53 < sipa> cfields: using c++11 may be more efficient 12:53 < sipa> because it gives stl automagival rvalue support 12:54 < sipa> *automagical 12:54 < cfields> sipa: sure. I think it makes sense to discuss bumping. It'd just be senseless to bump for some trivial change 12:54 < cfields> sipa: or did you mean just compiling as c++11? 12:54 < jnewbery> second review beg: #10579 for the same reasons as 10583. (Obviously not as important as anything v0.16 related, but I think for achow's sanity we should merge soon) 12:54 < cfields> 'cause, yea, we'd see the rvalue optims from that alone 12:54 < gribble> https://github.com/bitcoin/bitcoin/issues/10579 | [RPC] Split signrawtransaction into wallet and non-wallet RPC command by achow101 · Pull Request #10579 · bitcoin/bitcoin · GitHub 12:55 -!- jb552 [~jb55@s66-183-189-187.bc.hsia.telus.net] has joined #bitcoin-core-dev 12:55 < sipa> jnewbery: yes, absolutely 12:55 < cfields> beg threshold hit, will review :) 12:56 < cfields> sipa: my immediate concern is catching exceptions across ABIs, though 12:56 -!- jb55 [~jb55@s66-183-189-187.bc.hsia.telus.net] has quit [Ping timeout: 256 seconds] 12:57 < jnewbery> thanks sipa, thanks cfields! 12:57 -!- Mona87Dooley [~Mona87Doo@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 240 seconds] 12:58 < instagibbs> i know I've reviewed that PR before... no comments, hm. Will do again. 12:59 -!- grubles [~grubles@unaffiliated/grubles] has joined #bitcoin-core-dev 13:00 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 13:01 < bitcoin-git> [bitcoin] jnewbery opened pull request #12464: Revert "[tests] bind functional test nodes to 127.0.0.1" (master...revert_12200) https://github.com/bitcoin/bitcoin/pull/12464 13:05 -!- jb552 [~jb55@s66-183-189-187.bc.hsia.telus.net] has quit [Ping timeout: 248 seconds] 13:05 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 248 seconds] 13:08 < achow101> jnewbery: sanity? What's that? 13:09 -!- jb552 [~jb55@s66-183-189-187.bc.hsia.telus.net] has joined #bitcoin-core-dev 13:09 -!- grafcaps [~haroldbr@104.137.194.255] has joined #bitcoin-core-dev 13:11 -!- zautomata1 [~zautomata@41.239.30.214] has joined #bitcoin-core-dev 13:11 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 248 seconds] 13:12 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 13:12 -!- zautomata [~zautomata@41.232.208.70] has quit [Ping timeout: 255 seconds] 13:12 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/59e032b43cea...27c59dc502f2 13:12 < bitcoin-git> bitcoin/master df47afb John Newbery: Revert "[tests] bind functional test nodes to 127.0.0.1"... 13:12 < bitcoin-git> bitcoin/master 27c59dc MarcoFalke: Merge #12464: Revert "[tests] bind functional test nodes to 127.0.0.1"... 13:13 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 13:13 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #12464: Revert "[tests] bind functional test nodes to 127.0.0.1" (master...revert_12200) https://github.com/bitcoin/bitcoin/pull/12464 13:13 -!- zautomata2 [~zautomata@41.232.207.62] has joined #bitcoin-core-dev 13:14 -!- grubles [~grubles@unaffiliated/grubles] has quit [Ping timeout: 268 seconds] 13:15 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 13:15 -!- zautomata1 [~zautomata@41.239.30.214] has quit [Ping timeout: 240 seconds] 13:16 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 13:17 -!- neha [~narula@tbilisi.csail.mit.edu] has quit [Ping timeout: 240 seconds] 13:18 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Remote host closed the connection] 13:18 < jnewbery> :) 13:19 -!- neha [~narula@tbilisi.csail.mit.edu] has joined #bitcoin-core-dev 13:20 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 13:23 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has joined #bitcoin-core-dev 13:23 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has quit [Client Quit] 13:23 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/27c59dc502f2...23481fa50301 13:23 < bitcoin-git> bitcoin/master e710387 Ben Woosley: test: Fix bip68 sequence test to reflect updated rpc error message... 13:24 < bitcoin-git> bitcoin/master 23481fa MarcoFalke: Merge #12455: Fix bip68 sequence test to reflect updated rpc error message... 13:24 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has joined #bitcoin-core-dev 13:24 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #12455: Fix bip68 sequence test to reflect updated rpc error message (master...fix-bip68-test) https://github.com/bitcoin/bitcoin/pull/12455 13:27 -!- jb553 [~jb55@s66-183-189-187.bc.hsia.telus.net] has joined #bitcoin-core-dev 13:30 -!- jb552 [~jb55@s66-183-189-187.bc.hsia.telus.net] has quit [Ping timeout: 268 seconds] 13:33 < esotericnonsense> cfields: changed the univalue stuff to just use NULL instead of nullptr 13:38 -!- jb554 [~jb55@s66-183-189-187.bc.hsia.telus.net] has joined #bitcoin-core-dev 13:40 -!- jb553 [~jb55@s66-183-189-187.bc.hsia.telus.net] has quit [Ping timeout: 256 seconds] 13:52 -!- Randolf [~randolf@96.53.76.26] has joined #bitcoin-core-dev 13:52 -!- Cortez83Doyle [~Cortez83D@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 13:52 -!- jb554 [~jb55@s66-183-189-187.bc.hsia.telus.net] has quit [Ping timeout: 256 seconds] 13:53 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 13:55 -!- mirese [~mirese@2a02:1205:507c:3710:f874:c6ec:7e3f:31e3] has joined #bitcoin-core-dev 13:56 -!- mirese__ [~mirese@2a02:1205:507c:3710:ad7b:8023:d651:3b8e] has joined #bitcoin-core-dev 13:57 -!- Cortez83Doyle [~Cortez83D@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 268 seconds] 13:59 -!- mirese_ [~mirese@2a02:1205:507c:3710:3d8b:b52c:85a0:b9e6] has quit [Ping timeout: 256 seconds] 13:59 -!- mirese [~mirese@2a02:1205:507c:3710:f874:c6ec:7e3f:31e3] has quit [Ping timeout: 256 seconds] 14:05 -!- mirese [~mirese@2a02:1205:507c:3710:5928:8792:e8a2:68b2] has joined #bitcoin-core-dev 14:06 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 256 seconds] 14:08 -!- mirese__ [~mirese@2a02:1205:507c:3710:ad7b:8023:d651:3b8e] has quit [Ping timeout: 256 seconds] 14:10 -!- mirese_ [~mirese@2a02:1205:507c:3710:3d43:84a0:a25e:cc3b] has joined #bitcoin-core-dev 14:11 -!- mirese__ [~mirese@2a02:1205:507c:3710:84:16fa:5708:524] has joined #bitcoin-core-dev 14:13 -!- mirese [~mirese@2a02:1205:507c:3710:5928:8792:e8a2:68b2] has quit [Ping timeout: 240 seconds] 14:15 -!- mirese_ [~mirese@2a02:1205:507c:3710:3d43:84a0:a25e:cc3b] has quit [Ping timeout: 240 seconds] 14:34 -!- jb554 [~jb55@216-71-192-56.dyn.novuscom.net] has joined #bitcoin-core-dev 14:36 -!- spinza [~spin@196.212.164.26] has quit [Quit: Coyote finally caught up with me...] 14:40 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has quit [Quit: Leaving.] 14:44 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 256 seconds] 14:51 -!- spinza [~spin@196.212.164.26] has joined #bitcoin-core-dev 14:51 -!- mirese [~mirese@2a02:1205:507c:3710:8c:676e:c03d:5162] has joined #bitcoin-core-dev 14:52 -!- mirese_ [~mirese@2a02:1205:507c:3710:e1a6:2509:8d5:85a5] has joined #bitcoin-core-dev 14:52 -!- Thomas64Runte [~Thomas64R@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 14:52 -!- jamespeerless [~jamespeer@c-73-234-176-58.hsd1.ma.comcast.net] has quit [Quit: jamespeerless] 14:52 -!- jamesob [~jamesob@rrcs-67-251-193-154.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds] 14:53 -!- mirese___ [~mirese@2a02:1205:507c:3710:55d0:179c:2d5:d587] has joined #bitcoin-core-dev 14:54 -!- mirese__ [~mirese@2a02:1205:507c:3710:84:16fa:5708:524] has quit [Ping timeout: 240 seconds] 14:56 -!- mirese [~mirese@2a02:1205:507c:3710:8c:676e:c03d:5162] has quit [Ping timeout: 256 seconds] 14:57 -!- mirese_ [~mirese@2a02:1205:507c:3710:e1a6:2509:8d5:85a5] has quit [Ping timeout: 256 seconds] 14:57 -!- Thomas64Runte [~Thomas64R@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 260 seconds] 15:01 -!- Murch [~murch@96-82-80-28-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 15:04 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 15:14 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has quit [Ping timeout: 248 seconds] 15:15 -!- StopAndDecrypt [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has joined #bitcoin-core-dev 15:15 -!- StopAndDecrypt [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has quit [Changing host] 15:15 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has joined #bitcoin-core-dev 15:15 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 15:21 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has quit [Remote host closed the connection] 15:21 -!- StopAndDecrypt [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has joined #bitcoin-core-dev 15:21 -!- StopAndDecrypt [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has quit [Changing host] 15:21 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has joined #bitcoin-core-dev 15:26 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 15:27 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 15:30 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-peeztvhyeaonujyd] has joined #bitcoin-core-dev 15:37 -!- Murch [~murch@96-82-80-28-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 15:41 -!- jojeyh [~delphi@2602:306:b8b6:b970:f141:1f5f:dd9e:6f1] has joined #bitcoin-core-dev 15:52 -!- Kali58Bayer [~Kali58Bay@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 15:57 -!- Randolf [~randolf@96.53.76.26] has quit [Ping timeout: 256 seconds] 15:57 -!- Kali58Bayer [~Kali58Bay@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 256 seconds] 16:31 -!- hynodeva [~hynodeva@200116b8408190009a29a6fffe831eb0.dip.versatel-1u1.de] has joined #bitcoin-core-dev 16:52 -!- Delia28Dooley [~Delia28Do@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 16:54 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 17:06 -!- Murch [~murch@96-82-80-28-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 17:11 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Ping timeout: 255 seconds] 17:12 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev 17:13 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has quit [] 17:20 -!- grubles_ [~grubles@unaffiliated/grubles] has joined #bitcoin-core-dev 17:23 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 17:24 -!- jb554 [~jb55@216-71-192-56.dyn.novuscom.net] has quit [Ping timeout: 248 seconds] 17:28 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 256 seconds] 17:38 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 17:45 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Remote host closed the connection] 17:52 -!- grafcaps [~haroldbr@104.137.194.255] has quit [Ping timeout: 248 seconds] 17:55 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has joined #bitcoin-core-dev 18:02 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has quit [] 18:10 -!- grafcaps [~haroldbr@50.90.83.229] has joined #bitcoin-core-dev 18:11 -!- reardencode [~reardenco@hank.reardencode.com] has quit [Ping timeout: 248 seconds] 18:13 -!- Aliencorpse [~Aliencorp@2605:a601:b024:600:dde:2889:9734:2a68] has quit [Ping timeout: 260 seconds] 18:13 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 18:14 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 18:15 -!- reardencode [~reardenco@hank.reardencode.com] has joined #bitcoin-core-dev 18:17 -!- unholymachine_ [~quassel@2601:8c:c003:9f16:7876:d45c:ebab:59bc] has joined #bitcoin-core-dev 18:20 -!- dcousens [~dcousens@101.188.191.248] has quit [Ping timeout: 264 seconds] 18:20 -!- unholymachine [~quassel@c-69-248-123-139.hsd1.nj.comcast.net] has quit [Ping timeout: 240 seconds] 18:21 -!- dcousens [~dcousens@101.188.220.146] has joined #bitcoin-core-dev 18:26 -!- Aliencorpse [~Aliencorp@2605:a601:b024:600:a070:70a:889f:e540] has joined #bitcoin-core-dev 18:34 -!- d_t [~d_t@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 18:47 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 255 seconds] 19:15 < bitcoin-git> [bitcoin] fanquake opened pull request #12466: depends: Only use D_DARWIN_C_SOURCE when building miniupnpc on darwin (master...fix-miniupnpc-darwin) https://github.com/bitcoin/bitcoin/pull/12466 19:23 < kallewoof> Review would be great #10267 - unless people are expecting me to change something and I'm not even realizing it? 19:23 < gribble> https://github.com/bitcoin/bitcoin/issues/10267 | New -includeconf argument for including external configuration files by kallewoof · Pull Request #10267 · bitcoin/bitcoin · GitHub 19:33 -!- hynodeva [~hynodeva@200116b8408190009a29a6fffe831eb0.dip.versatel-1u1.de] has quit [Ping timeout: 240 seconds] 19:38 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev 19:48 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-mcnctcczoarynfaz] has quit [Quit: Connection closed for inactivity] 19:49 -!- hynodeva [~hynodeva@200116b840c806009a29a6fffe831eb0.dip.versatel-1u1.de] has joined #bitcoin-core-dev 20:02 -!- hynodeva [~hynodeva@200116b840c806009a29a6fffe831eb0.dip.versatel-1u1.de] has quit [Ping timeout: 255 seconds] 20:02 -!- hynodeva [~hynodeva@i577A5FD1.versanet.de] has joined #bitcoin-core-dev 20:09 < bitcoin-git> [bitcoin] theuni opened pull request #12467: build: compile univalue as c++11 (master...fix-subconfigure-args) https://github.com/bitcoin/bitcoin/pull/12467 20:14 < cfields> esotericnonsense: ^^that's for you. Thanks for complaining :) 20:14 -!- hynodeva1 [~hynodeva@i5E86059D.versanet.de] has joined #bitcoin-core-dev 20:14 -!- hynodeva [~hynodeva@i577A5FD1.versanet.de] has quit [Ping timeout: 260 seconds] 20:16 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 20:18 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 21:11 -!- d_t [~d_t@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has quit [Read error: No route to host] 21:12 -!- d_t [~d_t@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 21:16 < cfields> fanquake: I know I owe you a bunch of review. Sorry for the turn-around time 21:46 -!- Delia28Dooley [~Delia28Do@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 248 seconds] 21:52 -!- Jacinto67Durgan [~Jacinto67@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 21:53 -!- jb554 [~jb55@70-36-49-138.dyn.novuscom.net] has joined #bitcoin-core-dev 21:58 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 22:36 < bitcoin-git> [bitcoin] Aesti opened pull request #12468: Trivial: Adds missing newline in init.cpp (master...master) https://github.com/bitcoin/bitcoin/pull/12468 22:45 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 22:45 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has quit [Client Quit] 22:45 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 248 seconds] 22:45 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 22:58 -!- jb554 [~jb55@70-36-49-138.dyn.novuscom.net] has quit [Ping timeout: 276 seconds] 23:49 < bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/23481fa50301...daa84b33540a 23:49 < bitcoin-git> bitcoin/master a777244 Andrea Comand: Build: Add a makefile target for Doxygen documentation... 23:49 < bitcoin-git> bitcoin/master daa84b3 Jonas Schnelli: Merge #12029: Build: Add a makefile target for Doxygen documentation... 23:50 < bitcoin-git> [bitcoin] jonasschnelli closed pull request #12029: Build: Add a makefile target for Doxygen documentation (master...make-doxygen) https://github.com/bitcoin/bitcoin/pull/12029 23:54 -!- d_t [~d_t@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has quit [Ping timeout: 248 seconds]