--- Day changed Mon Feb 26 2018 00:01 -!- n1bor [~n1bor@185.9.34.66] has quit [Quit: Leaving] 00:15 -!- CubicEarths [~cubiceart@50-0-95-188.dsl.dynamic.fusionbroadband.com] has joined #bitcoin-core-dev 00:21 -!- d9b4bef9 [~d9b4bef9@207.38.94.106] has quit [Remote host closed the connection] 00:22 -!- d9b4bef9 [~d9b4bef9@207.38.94.106] has joined #bitcoin-core-dev 00:34 -!- CubicEarths [~cubiceart@50-0-95-188.dsl.dynamic.fusionbroadband.com] has quit [Remote host closed the connection] 00:43 -!- JackH [~laptop@i25091.upc-i.chello.nl] has quit [Ping timeout: 240 seconds] 00:47 -!- whphhg [~whphhg@unaffiliated/whphhg] has joined #bitcoin-core-dev 00:54 < wumpus> j0hnson2412: this might help if you're interacting with the payment protocol manually https://github.com/achow101/payment-proto-interface 00:54 < wumpus> oh, I see someone posted that 00:56 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 00:57 -!- JackH [~laptop@212.78.169.180] has joined #bitcoin-core-dev 01:02 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:03 -!- jtimon [~quassel@41.31.134.37.dynamic.jazztel.es] has quit [Remote host closed the connection] 01:08 < wumpus> and yes the forced adoption of the payment protocol by bitpay etc has been a letdown, many wallets don't have a BIP70 implementation, some don't work properly, there's problems with cloudflare and tor when fetching the requests 01:09 < wumpus> last time I tried to pay something using bitpay I had to give up and pay by bank... all was okay when you could just pay manually to an address 01:14 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 01:17 -!- ken2812221 [~User@133-203.dorm.ncu.edu.tw] has quit [Remote host closed the connection] 01:17 -!- ken2812221 [~User@133-203.dorm.ncu.edu.tw] has joined #bitcoin-core-dev 01:19 -!- harrymm [~harrymm@104.207.83.11] has quit [] 01:21 < booyah> I was reading about the bitcoin db locks exploit, https://github.com/bitcoin/bips/blob/master/bip-0050.mediawiki - but I don't see there information when it was introduced exactly and "who is responsible" for it 01:23 < booyah> which commit/pr added this problem? 01:29 < wumpus> can anyone review https://github.com/bitcoin-core/bitcoincore.org/pull/513 please 01:30 < wumpus> booyah: that bug was always in there AFAIK, and I don't think it was intentionally exploited, it was an unexpected interaction between the db library and consensus 01:31 < booyah> wumpus: so all released versions of Bitcoin, including Satoshi's release, were vulneable? 01:31 < wumpus> booyah: yes 01:31 < echeveria> yes 01:32 < booyah> I'm asking also since there're idiots in -otc claiming that is "bitcoin core fault" 01:32 < echeveria> satoshis bitcoin 0.1 was more vulnerable in a pile of ways. there’s lots of things that aren’t understood well. 01:32 < wumpus> everything using berkeleydb for the utxo set, which was the case from the first version 01:32 -!- Foster17Will [~Foster17W@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 01:32 < echeveria> ie, you could create unlimited bitcoin out of thin air and spend anybodies bitcoin. 01:32 < wumpus> not that one echeveria 01:33 < echeveria> ? 01:33 < wumpus> that was another bug in satoshi's code, much earlier 01:33 < echeveria> I’m saying it’s not perfect, and you can’t attribute that to later development at all. I realise they’re 3 different, earlier bugs. 01:33 < booyah> we need better CVE / bug disclosure process guys 01:34 < echeveria> uh. this is ancient history. 01:34 < wumpus> yes, this is ancient history 01:34 < booyah> above information should be state in that BIP 50 imo. Which versions were affected (all), when it was introduced (in first version), by who (Satoshi) 01:34 < wumpus> both the BIP50 fork and satoshi's counting mistake :-) 01:34 < booyah> it is also the most known security event (or 1 of like 3) used NOW to prove that bitcoin core is incompetent 01:34 < booyah> "prove" 01:34 < wumpus> feel free to dig in history, someone must, but I focus on the future only 01:34 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 252 seconds] 01:35 < echeveria> booyah: feel free to write them up. 01:35 < booyah> [10:33] this is 0.8.0, which satoshi did not release 01:35 < echeveria> 0.8 *fixed* the bug. 01:35 < booyah> wumpus: I see. btw please provide such detailed info for any future (if any) then :) 01:35 < wumpus> if their point is that bitcoin core's contributors make mistakes, then they are right 01:35 < echeveria> no version before 0.7 was consensus complete due to berkeleydb not being deterministic. 01:36 < wumpus> find any person alive who writes bugless software FFS, we have a very thorough QA and testing process in place but it's impossible to guarantee that bugs won't happen 01:36 < echeveria> booyah: let’s take this to #bitcoin please. 01:36 < wumpus> most of that trolling comes from people supporting projects that publish code with virtually no review and QA at all 01:37 < wumpus> yes, take it somewhere else, it's not relevant to anything today 01:41 < wumpus> if you want to call me incompetent, go ahead and try to do better. I have more than 20 years of experience in development and computer security. But I'm not perfect. Open source hinges on having lots of eyes on the source code to catch mistakes, not any special person. 01:43 < esotericnonsense> :) 01:43 < wumpus> so: try to attack the code, that's good. Don't try to attack the developers, that just results in drama. 01:43 < esotericnonsense> bitcoin 0.8 was not 'bitcoin core' :D 01:44 < booyah> wumpus: speaking about the future, will the bitcoin wallet be returning to name "bitcoin" instead "bitcoin core"? 01:44 < wumpus> no 01:44 < wumpus> you can pry my project name from my cold dead hands 01:45 < booyah> hm? I was just asking about the name :) 01:45 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 255 seconds] 01:46 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 01:55 < phantomcircuit> booyah, fyi the people trying to blame someone for that stuff know they're lying 01:55 < wumpus> if you want a serious answer: some things (such as naming, branding) are too trivial to be concerned with here. There's as many opinions on it as bitcoin users. You can fork the source code today and change the name (it's a constant in configure.ac FWIW) or use luke-jr's Bitcoin Knots. If there is no agreement on changing something, the best thing is just to stick with what is there. 01:55 < phantomcircuit> pointing out that they're lying is mostly useless 01:57 < provoostenator> If the amount of discussion required to change a few words in a tooltip is any indication... changing the name of the app would eat up all of Core's resources for a year :-) There's more important things to work on. 01:57 < wumpus> And if you want to change the bitcoin logo to a purple elephant and denominate coins in 'fluppydoodleblurz' from now on, go ahead and release a wallet that does that, use that on your sites, make a BIP, etc. By nature, bitcoin is permissionless. 01:58 < wumpus> provoostenator: exactly, it's like a human DDoS attack :) 01:58 < provoostenator> Needs CVE? 02:01 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 255 seconds] 02:02 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-hjludugmglefftik] has joined #bitcoin-core-dev 02:02 < wumpus> CVE-0000-0000000 02:03 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 02:18 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 02:18 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:22 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 248 seconds] 03:10 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has joined #bitcoin-core-dev 03:11 < wumpus> poke: can anyone review https://github.com/bitcoin-core/bitcoincore.org/pull/513 , needs to be reviewed to allow merging, so that the site can be updated 03:25 < bitcoin-git> [bitcoin] laanwj pushed 1 new commit to master: https://github.com/bitcoin/bitcoin/commit/d3f4dd313e5fe58903caf2f4d04827e7f7944e17 03:25 < bitcoin-git> bitcoin/master d3f4dd3 Wladimir J. van der Laan: doc: Add historical release notes for 0.16.0... 03:27 -!- Deinogalerix21 [~Deinogale@185.169.255.9] has joined #bitcoin-core-dev 03:30 -!- AriseChikun [Arise@gateway/vpn/privateinternetaccess/arisechikun] has joined #bitcoin-core-dev 03:48 -!- echonaut [~echonaut@46.101.192.134] has joined #bitcoin-core-dev 03:55 -!- AriseChikun [Arise@gateway/vpn/privateinternetaccess/arisechikun] has quit [Remote host closed the connection] 03:57 -!- andytoshi [~apoelstra@wpsoftware.net] has joined #bitcoin-core-dev 03:59 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 04:02 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has quit [Remote host closed the connection] 04:11 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-hjludugmglefftik] has quit [Quit: Connection closed for inactivity] 04:13 -!- cncr04s [~cncr04s@unaffiliated/cncr04s] has joined #bitcoin-core-dev 04:14 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 04:22 -!- harrymm [~harrymm@104.207.83.11] has joined #bitcoin-core-dev 04:39 < provoostenator> laanwj: does this need a blog entry too? 04:39 < provoostenator> wumpus 04:40 -!- kallewoof [~karl@fp96f94c66.tkyc515.ap.nuro.jp] has quit [Ping timeout: 276 seconds] 04:40 -!- kallewoof [~karl@240d:1a:759:6000:a7b1:451a:8874:e1ac] has joined #bitcoin-core-dev 04:47 < jonasschnelli> provoostenator: yes. We should do one. Do you want to do it provoostenator? 04:47 < jonasschnelli> Just the "Recent Posts" thing 04:49 < provoostenator> It would be nice if it had pretty pictures like 0.15: https://bitcoincore.org/en/2017/09/01/release-0.15.0/ 04:50 < wumpus> David Harding usually does that, don't know if he has time, might want to ping him 04:50 < provoostenator> I'm happy to review it. 04:52 < jonasschnelli> Okay. Let me ping him. 04:53 < wumpus> he's not here is he 04:54 < jonasschnelli> Just aked him on twitter... :/ 04:55 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer] 04:55 < wumpus> https://bitcoin.org/en/download is not updating even though I updated the git repository at https://github.com/bitcoin-dot-org/bitcoin.org, might be that someone needs to push a button there too 04:56 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 04:57 < jonasschnelli> wumpus: I have 0.16.0 at https://bitcoin.org/en/download 04:59 < jonasschnelli> Dave said he is going to do it 05:00 < wumpus> jonasschnelli: oh, apparently needed an explicit request, my browser was caching the old page. Phew. 05:00 < wumpus> jonasschnelli: awesome 05:01 < wumpus> I'll add him to the cc-list for RCs next time 05:02 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 05:04 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 05:06 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-zolrpsqgtcsdrcif] has quit [Quit: Connection closed for inactivity] 05:44 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 05:46 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 05:53 -!- aruns__ [~indistylo@119.82.105.106] has joined #bitcoin-core-dev 05:56 -!- indistylo [~indistylo@119.82.105.106] has quit [Ping timeout: 276 seconds] 06:00 -!- doo-dah [2f2ae8cc@gateway/web/freenode/ip.47.42.232.204] has joined #bitcoin-core-dev 06:01 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Ping timeout: 255 seconds] 06:05 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 06:06 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 06:28 -!- leeholim [d53d620a@gateway/web/freenode/ip.213.61.98.10] has joined #bitcoin-core-dev 06:34 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Quit: WeeChat 1.9.1] 06:34 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 06:35 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer] 06:35 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 06:35 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 06:36 < promag> #12083 should be ready 06:36 < gribble> https://github.com/bitcoin/bitcoin/issues/12083 | Improve getchaintxstats test coverage by promag · Pull Request #12083 · bitcoin/bitcoin · GitHub 06:49 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection] 06:54 -!- denis2342 [~denis@77.14.52.236] has joined #bitcoin-core-dev 06:54 < denis2342> is this worth a pull request?: https://github.com/denis2342/bitcoin/commit/89d961ed274b42fb8ee01f5e79f59ba6fd078d1c 07:01 < sipa> denis2342: the style guide favors include_hex over fIncludeHez 07:01 < sipa> *x 07:02 < denis2342> sipa: ok, there were both and I took the wrong one ;) 07:02 < denis2342> I can change that 07:03 < sipa> denis2342: the style guide also says not to create patches purely to improve style 07:03 < sipa> (the overhead of the review process is just not worth it for does) 07:03 -!- flokie [~flokie@unaffiliated/flokie] has joined #bitcoin-core-dev 07:03 < denis2342> sipa: it is not purely style 07:04 < sipa> oh, i see! 07:04 -!- mdrollette [~mdrollett@feynman.drollette.com] has quit [Quit: ZNC 1.6.5 - http://znc.in] 07:07 < denis2342> changed to include_hex https://github.com/denis2342/bitcoin/commit/c8a34e51ad06a1a6f3d82925bb17da34e5766173 07:08 -!- echeveria [~echeveria@unaffiliated/echeveria] has quit [Quit: ZNC 1.6.5+deb1 - http://znc.in] 07:12 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 07:16 < bitcoin-git> [bitcoin] nopara73 opened pull request #12540: Remove suggestion "getinfo" (master...patch-2) https://github.com/bitcoin/bitcoin/pull/12540 07:20 -!- flokie [~flokie@unaffiliated/flokie] has quit [Quit: Leaving] 07:23 -!- nullptr| [~nullptr|@ip-94-113-103-134.net.upcbroadband.cz] has quit [Quit: ZNC - http://znc.in] 07:26 -!- nullptr| [~nullptr|@ip-94-113-103-134.net.upcbroadband.cz] has joined #bitcoin-core-dev 07:28 < bitcoin-git> [bitcoin] denis2342 opened pull request #12541: streamlined the use of include_hex (master...master) https://github.com/bitcoin/bitcoin/pull/12541 07:28 -!- aruns__ [~indistylo@119.82.105.106] has quit [Ping timeout: 256 seconds] 07:31 < bitcoin-git> [bitcoin] laanwj closed pull request #12540: Remove suggestion "getinfo" (master...patch-2) https://github.com/bitcoin/bitcoin/pull/12540 07:31 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 248 seconds] 07:38 < bitcoin-git> [bitcoin] luke-jr closed pull request #11802: RPC/Wallet: Refuse to dumpprivkey for derived addresses (master...dumpprivkey_noderived) https://github.com/bitcoin/bitcoin/pull/11802 07:40 < promag> denis2342: should have a test there no? 07:40 -!- ccook [~ccook@208.66.192.142] has quit [Ping timeout: 268 seconds] 07:41 < denis2342> promag: ? 07:47 < promag> denis2342: for instance, decoderawtransactions calls TxToUniv with include_hex=false, so it would be nice to have some test checking that hex field isn't there 07:50 -!- RubenSomsen [~RubenSoms@1.217.138.142] has joined #bitcoin-core-dev 07:51 < promag> denis2342: furthermore, this change is breaking change, and requires release note 07:51 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/d3f4dd313e5f...228b086b9a3d 07:51 < bitcoin-git> bitcoin/master 501b439 João Barbosa: rpc: Refactor blockhash parse in getchaintxstats 07:51 < bitcoin-git> bitcoin/master 57e6786 João Barbosa: qa: Improve getchaintxstats functional test 07:51 < bitcoin-git> bitcoin/master 228b086 Wladimir J. van der Laan: Merge #12083: Improve getchaintxstats test coverage... 07:52 < bitcoin-git> [bitcoin] laanwj closed pull request #12083: Improve getchaintxstats test coverage (master...2018-01-getchaintxstats) https://github.com/bitcoin/bitcoin/pull/12083 07:54 < promag> gmaxwell: regarding #12080, should we just remove the address book instead? :) 07:54 < gribble> https://github.com/bitcoin/bitcoin/issues/12080 | Add support to search the address book by promag · Pull Request #12080 · bitcoin/bitcoin · GitHub 07:59 -!- michal__ [uid284087@gateway/web/irccloud.com/x-ifynafgmkipymjqe] has joined #bitcoin-core-dev 07:59 -!- contrapumpkin [~copumpkin@haskell/developer/copumpkin] has quit [Ping timeout: 240 seconds] 07:59 -!- propumpkin [~copumpkin@haskell/developer/copumpkin] has joined #bitcoin-core-dev 08:05 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 08:06 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 08:10 -!- Giszmo [~leo@ip-234-233.219.201.nextelmovil.cl] has joined #bitcoin-core-dev 08:13 -!- rongze [~rongze@124.64.163.14] has joined #bitcoin-core-dev 08:23 -!- michal__ [uid284087@gateway/web/irccloud.com/x-ifynafgmkipymjqe] has quit [] 08:25 -!- ken2812221 [~User@133-203.dorm.ncu.edu.tw] has quit [Ping timeout: 256 seconds] 08:32 -!- CubicEarths [~cubiceart@50-0-95-188.dsl.dynamic.fusionbroadband.com] has joined #bitcoin-core-dev 08:32 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 08:32 -!- jb55 [~jb55@70-36-49-138.dyn.novuscom.net] has joined #bitcoin-core-dev 08:32 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Ping timeout: 255 seconds] 08:33 -!- Deinogalerix21 [~Deinogale@185.169.255.9] has quit [Quit: WeeChat 2.0.1] 08:35 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 08:35 -!- MrPaz [~PazPazPaz@c-71-57-73-68.hsd1.il.comcast.net] has joined #bitcoin-core-dev 08:55 -!- MrPaz [~PazPazPaz@c-71-57-73-68.hsd1.il.comcast.net] has quit [Ping timeout: 256 seconds] 08:56 -!- JackH [~laptop@212.78.169.180] has quit [Ping timeout: 245 seconds] 08:56 -!- MrPaz [~PazPazPaz@c-71-57-73-68.hsd1.il.comcast.net] has joined #bitcoin-core-dev 08:56 -!- jb55 [~jb55@70-36-49-138.dyn.novuscom.net] has quit [Ping timeout: 240 seconds] 09:04 -!- mehdi0x61 [~mehdi0x61@OGMX1.ad.office.ber.gpp.ag] has joined #bitcoin-core-dev 09:05 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds] 09:11 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 256 seconds] 09:11 -!- Giszmo [~leo@ip-234-233.219.201.nextelmovil.cl] has quit [Quit: Leaving.] 09:13 -!- MrPaz [~PazPazPaz@c-71-57-73-68.hsd1.il.comcast.net] has quit [Ping timeout: 252 seconds] 09:17 -!- CubicEarths [~cubiceart@50-0-95-188.dsl.dynamic.fusionbroadband.com] has quit [Remote host closed the connection] 09:21 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-vtommwjffmdectwl] has joined #bitcoin-core-dev 09:23 -!- rongze_ [~rongze@223.104.3.185] has joined #bitcoin-core-dev 09:26 -!- MrPaz [~PazPazPaz@c-71-57-73-68.hsd1.il.comcast.net] has joined #bitcoin-core-dev 09:27 -!- rongze [~rongze@124.64.163.14] has quit [Ping timeout: 256 seconds] 09:27 -!- MisterPaz [~PazPazPaz@c-71-57-73-68.hsd1.il.comcast.net] has joined #bitcoin-core-dev 09:29 -!- CubicEarths [~cubiceart@50-0-95-188.dsl.dynamic.fusionbroadband.com] has joined #bitcoin-core-dev 09:31 -!- MrPaz [~PazPazPaz@c-71-57-73-68.hsd1.il.comcast.net] has quit [Ping timeout: 248 seconds] 09:32 -!- grafcaps [~haroldbr@104.137.194.255] has joined #bitcoin-core-dev 09:32 -!- MrPaz [~PazPazPaz@c-71-57-73-68.hsd1.il.comcast.net] has joined #bitcoin-core-dev 09:32 -!- MisterPaz [~PazPazPaz@c-71-57-73-68.hsd1.il.comcast.net] has quit [Ping timeout: 245 seconds] 09:37 < provoostenator> Where does QT serialize its (OptionsModel) settings and do I clear them? 09:40 < provoostenator> http://doc.qt.io/qt-5/qsettings.html#clear 09:41 < provoostenator> Which is what the Reset settings feature uses. 09:46 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 09:47 -!- Foster17Will [~Foster17W@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 245 seconds] 09:47 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 09:49 -!- mehdi0x61 [~mehdi0x61@OGMX1.ad.office.ber.gpp.ag] has quit [Quit: Textual IRC Client: www.textualapp.com] 09:50 -!- RubenSomsen [~RubenSoms@1.217.138.142] has quit [Quit: Leaving] 09:51 < provoostenator> I was thinking of using a (much) higher dbcache in QT if physical memory size is known (e.g. https://msdn.microsoft.com/en-us/library/cc300158(v=VS.85).aspx) and large enough. In that case we could remove the setting from the UI, and only honor -dbcache if set. Thoughts? 10:01 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 10:08 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 10:10 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection] 10:12 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has quit [Read error: Connection reset by peer] 10:14 -!- rongze_ [~rongze@223.104.3.185] has quit [Remote host closed the connection] 10:14 -!- rongze [~rongze@223.104.3.185] has joined #bitcoin-core-dev 10:14 -!- rongze [~rongze@223.104.3.185] has quit [Remote host closed the connection] 10:15 -!- rongze [~rongze@223.104.3.185] has joined #bitcoin-core-dev 10:15 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has joined #bitcoin-core-dev 10:15 -!- rongze [~rongze@223.104.3.185] has quit [Remote host closed the connection] 10:15 -!- rongze [~rongze@223.104.3.185] has joined #bitcoin-core-dev 10:16 -!- rongze [~rongze@223.104.3.185] has quit [Remote host closed the connection] 10:16 < esotericnonsense> i'd be in favour of automatic dbcache / mempool / etc sizing. it seems obvious/useful enough that there's probably a reason we're not doing it though. 10:17 < esotericnonsense> e.g. on a 1GB machine it's really common for bitcoind to get oomkilled and it seems to me that anyone that really wanted it to use ~all of the system ram could set that. 10:18 -!- JackH [~laptop@i25091.upc-i.chello.nl] has joined #bitcoin-core-dev 10:20 < bitcoin-git> [bitcoin] practicalswift opened pull request #12542: Remove redundant includes. Conform to header include guidelines. (master...include-guidelines) https://github.com/bitcoin/bitcoin/pull/12542 10:21 -!- JackH [~laptop@i25091.upc-i.chello.nl] has quit [Max SendQ exceeded] 10:21 -!- leeholim [d53d620a@gateway/web/freenode/ip.213.61.98.10] has quit [Ping timeout: 260 seconds] 10:23 -!- JackH [~laptop@i25091.upc-i.chello.nl] has joined #bitcoin-core-dev 10:25 -!- propumpkin is now known as contrapumpkin 10:32 -!- Ezra27Upton [~Ezra27Upt@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 10:37 -!- jb55 [~jb55@64.114.30.74] has joined #bitcoin-core-dev 10:39 -!- HFRadical [~none@103.254.153.99] has joined #bitcoin-core-dev 10:40 < provoostenator> I think the case for QT is stronger than bitcoind. GUI's are usually not on all the time. We may also want to flush if there's no activity for a while. I think this is especially useful during IBD, where the progress bar should make it obvious to users that this process can be a drain on their system. 10:41 < provoostenator> I also don't think many GUI users will feel comfortable touching these settings. 10:41 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev 10:45 -!- denis2342 [~denis@77.14.52.236] has quit [Quit: denis2342] 10:45 < CubicEarths> provoostenator: GUI users include many technical people 11:07 < doo-dah> bitcoin.org seems to be down... 11:08 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Remote host closed the connection] 11:09 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 11:09 -!- MrPaz [~PazPazPaz@c-71-57-73-68.hsd1.il.comcast.net] has quit [Ping timeout: 240 seconds] 11:16 < doo-dah> ...and it's back. 11:17 -!- rongze [~rongze@124.64.163.14] has joined #bitcoin-core-dev 11:18 * luke-jr is a GUI user. 11:20 < bitcoin-git> [bitcoin] practicalswift opened pull request #12543: Fix typos (master...typos-201802) https://github.com/bitcoin/bitcoin/pull/12543 11:22 -!- rongze [~rongze@124.64.163.14] has quit [Ping timeout: 252 seconds] 11:27 -!- MrPaz [~PazPazPaz@c-71-57-73-68.hsd1.il.comcast.net] has joined #bitcoin-core-dev 11:29 -!- btcdrak [uid236341@gateway/web/irccloud.com/x-hwrwdpidwmidbjzo] has joined #bitcoin-core-dev 11:31 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-kfelopzwthnrworp] has joined #bitcoin-core-dev 11:32 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 11:33 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has quit [Quit: Snoozing.] 11:34 < bitcoin-git> [bitcoin] Empact opened pull request #12545: test: Extend wait time by .1 seconds to ensure ping goes out (master...ping-timing) https://github.com/bitcoin/bitcoin/pull/12545 11:41 -!- nuke_bloodaxe [~nuke_bloo@101.100.144.170] has quit [] 11:53 -!- Giszmo [~leo@ip-101-233.219.201.nextelmovil.cl] has joined #bitcoin-core-dev 11:59 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 12:02 -!- Cogito_Ergo_Sum [~Myself@ppp-94-64-157-186.home.otenet.gr] has joined #bitcoin-core-dev 12:02 -!- Cogito_Ergo_Sum [~Myself@ppp-94-64-157-186.home.otenet.gr] has quit [Changing host] 12:02 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has joined #bitcoin-core-dev 12:08 -!- j0hnson2412 [ae2d902d@gateway/web/freenode/ip.174.45.144.45] has quit [Quit: Page closed] 12:15 -!- laurentmt [~Thunderbi@104.254.92.61] has joined #bitcoin-core-dev 12:18 -!- jb55 [~jb55@64.114.30.74] has quit [Read error: Connection reset by peer] 12:20 -!- farmerwampum [~farmerwam@88.202.178.102] has quit [Quit: farmerwampum] 12:25 -!- farmerwampum_ [~farmerwam@209.95.51.102] has joined #bitcoin-core-dev 12:28 -!- shesek [~shesek@bzq-84-110-235-179.red.bezeqint.net] has joined #bitcoin-core-dev 12:28 -!- shesek [~shesek@bzq-84-110-235-179.red.bezeqint.net] has quit [Changing host] 12:28 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 12:29 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection] 12:42 -!- tr4vis220202 [ae2d902d@gateway/web/freenode/ip.174.45.144.45] has joined #bitcoin-core-dev 12:44 -!- laurentmt [~Thunderbi@104.254.92.61] has quit [Quit: laurentmt] 12:44 < tr4vis220202> When sending a bip-70 payment, bitcoin core sent to regular address instead of p2sh, hexdump of script is 76A9142AFD057FD359FC1C180B177D05F1B4191867471A88AC 12:46 -!- Ezra27Upton [~Ezra27Upt@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 268 seconds] 12:47 -!- ccook [~ccook@208.66.192.142] has joined #bitcoin-core-dev 12:48 -!- rongze [~rongze@124.64.163.14] has joined #bitcoin-core-dev 12:52 -!- rongze [~rongze@124.64.163.14] has quit [Ping timeout: 240 seconds] 12:53 -!- RoyceX [Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has joined #bitcoin-core-dev 12:56 -!- cheese_ [~Cheeseo@unaffiliated/cheeseo] has quit [Ping timeout: 252 seconds] 12:57 -!- mehdi0x61 [~mehdi0x61@95.91.244.234] has joined #bitcoin-core-dev 12:58 < sipa> tr4vis220202: are you sure the BIP70 request didn't contain a regular output? 12:58 -!- Giszmo [~leo@ip-101-233.219.201.nextelmovil.cl] has quit [Ping timeout: 256 seconds] 12:59 < sipa> as far as i can see in the code, it just uses the exact script requested in the BIP70 payment request - regardless of what type of output it is 12:59 -!- sdaftuar_ is now known as sdaftuar 13:02 -!- sdaftuar [~sdaftuar@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Changing host] 13:02 -!- sdaftuar [~sdaftuar@unaffiliated/sdaftuar] has joined #bitcoin-core-dev 13:04 -!- jojeyh [~delphi@2602:306:b8b6:b970:41cc:8d6f:4e2b:2830] has quit [Quit: Ex-Chat] 13:10 < tr4vis220202> when i decode it, there is an address, and a p2sh 13:12 < sipa> can you share the URI and the payment request? 13:12 < sipa> (perhaps privately) 13:13 -!- Giszmo [~leo@ip-117-237-219-201.nextelmovil.cl] has joined #bitcoin-core-dev 13:15 -!- HFRadical [~none@103.254.153.99] has quit [Quit: Leaving] 13:16 -!- HFRadical [~none@103.254.153.99] has joined #bitcoin-core-dev 13:30 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 13:32 -!- Bradford41Metz [~Bradford4@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 13:33 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 13:34 -!- Giszmo [~leo@ip-117-237-219-201.nextelmovil.cl] has quit [Ping timeout: 248 seconds] 13:35 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has quit [Quit: (https://github.com/mmgen) leaving] 13:35 -!- ula [~ula@b2b-78-94-11-194.unitymedia.biz] has joined #bitcoin-core-dev 13:41 -!- Bradford41Metz [~Bradford4@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 268 seconds] 13:43 < michagogo> Quick question about the release notes 13:44 < michagogo> “Bitcoin Core is extensively tested on multiple operating systems using the Linux kernel, macOS 10.8+, and Windows Vista and later.” 13:44 < michagogo> Is there actually anyone testing extensively on Vista? 13:44 * Randolf laughs 13:45 < sipa> I hope some people are testing the RCs on windows? 13:45 < michagogo> Yeah, but Vista? 13:45 < Randolf> I have been running RC3 and then RC4 on Windows 10 (64-bit). 13:45 < Randolf> Haven't had any problems with it. 13:45 < Chris_Stewart_5> doesn't microsoft even support vista anymore? 13:45 < Chris_Stewart_5> does* 13:46 < michagogo> Yeah, IIRC it EoL’d about a year ago 13:46 < sipa> oh, i'm not up to date on windows versions 13:46 < Randolf> There probably are people using Bitcoin on Windows 7. Windows Vista, I suspect, likely isn't used for much these days. 13:46 < sipa> but we still support vista, no? 13:46 < michagogo> And as far as I know, it’s not even like XP, which tons of people stuck with for way too long 13:47 < michagogo> sipa: that’s the question 13:47 < Randolf> I have extra hardware and a Windows Vista license I could throw together to see if Bitcoin works on it. 13:47 < michagogo> Do we really, or did that just never get updated? 13:47 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev 13:47 < michagogo> And also, does it actually not work on XP, or do we just say we don’t support it? 13:48 < michagogo> If the latter, we should drop Vista too imho 13:49 < Randolf> I'd suggest we move it up to Windows 7. 13:49 < Randolf> I can put a Pull Request in easily for that now. 13:53 < bitcoin-git> [bitcoin] randolf opened pull request #12546: [docs] Minor improvements to Compatibility notes (master...patch-3) https://github.com/bitcoin/bitcoin/pull/12546 13:53 < Randolf> See PR #12546 for this change. 13:53 < gribble> https://github.com/bitcoin/bitcoin/issues/12546 | [docs] Minor improvements to Compatibility notes by randolf · Pull Request #12546 · bitcoin/bitcoin · GitHub 13:56 < esotericnonsense> as far as I'm aware XP is used _more_ than vista 13:56 < Randolf> esotericnonsense++ 13:57 < Randolf> Windows Vista was so horrible that most people seem to want to forget it even existed. 13:58 < sipa> Sounds like Windows ME to me. 13:58 < sipa> (coincidentally the last windows version I used...) 13:58 < Randolf> That's pre-WindowsXP stuff there. 13:58 < michagogo> esotericnonsense: right, that’s my impression too 13:58 < Randolf> Vista came after XP. 13:59 < michagogo> Randolf: I don’t think sipa was saying he thought we were talking about me 13:59 < michagogo> Rather, comparing the situation and the badness 13:59 < esotericnonsense> according to wikipedia, vista has consistently had about 1/5th the usage of XP for the past few years. according to their trackers anyway. 13:59 < Randolf> Oh, okay. :) 14:00 < esotericnonsense> statcounter has it as 0.41% in march 2017 vs 2% for XP (of the overall total, desktop, mobile, everything included) 14:00 < rabidus> mobile xp .. 14:00 < michagogo> Randolf: I’m not sure MacOS is right 14:00 < michagogo> I don’t think it was ever called that 14:01 < esotericnonsense> rabidus: no, as in, all browser stats. approx 45% desktop and 55% mobile for whatever sites they're tracking. so XP is 4% of desktops in that stat 14:01 < Randolf> Oh? I merely changed "macOS" to "MacOS" because I do remember supporting some MacOS computers at a help desk job many years ago. 14:01 -!- mehdi0x61 [~mehdi0x61@95.91.244.234] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 14:01 < Randolf> Maybe they've changed it since then? 14:01 < michagogo> It was Mac OS until over a decade ago, then Mac OS X. A while back they dropped the Mac and made it just OS X 14:02 < michagogo> In the last year or two (IIRC), it was renamed to macOS 14:03 < Randolf> Oh. I'll have to fix that then. 14:03 < Randolf> That new version looks like a mistake. Oh well. :) 14:03 < michagogo> 10.8 was still OS X (no Mac) if I’m not mistaken, but 1. I’m not sure if the renaming was retroactive or not, and 2. I feel like macOS is more understandable 14:04 < michagogo> They changed it in order to make their various OSes consistent 14:05 < michagogo> iOS, watchOS, tvOS, etc 14:05 < Randolf> Well, I see that "macOS" is indeed how they're marketing it on their web site nowadays, so you're obviously correct that the name should begin with a lower-case "m." 14:05 < michagogo> Don’t know what the HomePod runs 14:05 < esotericnonsense> this is kind of a bitcoin question but kind of not. what's the trick to make bitcoin-qt not appear as a postage stamp on ubuntu with high dpi screens? 14:06 < esotericnonsense> is there a 'qt-tweaker' or something? 14:14 -!- jb55 [~jb55@S01067cb21bc956ba.vc.shawcable.net] has joined #bitcoin-core-dev 14:18 -!- rongze [~rongze@124.64.163.14] has joined #bitcoin-core-dev 14:20 -!- mehdi0x61 [~mehdi0x61@ip5f5bf4ea.dynamic.kabel-deutschland.de] has joined #bitcoin-core-dev 14:20 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 14:21 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Read error: Connection reset by peer] 14:22 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 14:23 -!- rongze [~rongze@124.64.163.14] has quit [Ping timeout: 256 seconds] 14:23 -!- jb55 [~jb55@S01067cb21bc956ba.vc.shawcable.net] has quit [Ping timeout: 256 seconds] 14:24 < mlz> i've been testing the RCs on windows for a while now but ofc I don't check everything 14:28 < mlz> one thing i'm wondering if can be improved: cross-compiling for windonws on ubuntu 14 Trusty starting fresh from beginning to finishing takes about 4-5 hours, I wish this could be shorter 14:28 -!- btcdrak [uid236341@gateway/web/irccloud.com/x-hwrwdpidwmidbjzo] has quit [Quit: Connection closed for inactivity] 14:32 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 240 seconds] 14:32 -!- Thad34Watsica [~Thad34Wat@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 14:39 -!- Dizzle [~dizzle@108.171.182.16] has joined #bitcoin-core-dev 14:40 -!- rex_4539 [~textual@2a02:587:3508:900:61e2:ed6d:3830:fc9c] has quit [Ping timeout: 252 seconds] 14:57 -!- mehdi0x61 [~mehdi0x61@ip5f5bf4ea.dynamic.kabel-deutschland.de] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 14:58 -!- Dizzle [~dizzle@108.171.182.16] has quit [Quit: Leaving...] 14:58 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 245 seconds] 15:13 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 15:16 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 15:17 -!- nullptr| [~nullptr|@ip-94-113-103-134.net.upcbroadband.cz] has quit [Ping timeout: 256 seconds] 15:18 -!- nullptr| [~nullptr|@ip-94-113-103-134.net.upcbroadband.cz] has joined #bitcoin-core-dev 15:24 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has quit [Remote host closed the connection] 15:39 -!- Giszmo [~leo@ip-243-233.219.201.nextelmovil.cl] has joined #bitcoin-core-dev 15:47 -!- Giszmo [~leo@ip-243-233.219.201.nextelmovil.cl] has quit [Ping timeout: 256 seconds] 15:55 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 15:57 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 15:57 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 16:00 -!- weez17 [~isaac@unaffiliated/weez17] has quit [Remote host closed the connection] 16:00 -!- weez17 [~isaac@unaffiliated/weez17] has joined #bitcoin-core-dev 16:03 -!- MrPaz [~PazPazPaz@c-71-57-73-68.hsd1.il.comcast.net] has quit [Ping timeout: 240 seconds] 16:06 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 16:06 -!- CubicEarths [~cubiceart@50-0-95-188.dsl.dynamic.fusionbroadband.com] has quit [Remote host closed the connection] 16:12 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has quit [] 16:16 -!- MrPaz [~PazPazPaz@c-71-57-73-68.hsd1.il.comcast.net] has joined #bitcoin-core-dev 16:18 -!- CubicEarths [~cubiceart@50-0-95-188.dsl.dynamic.fusionbroadband.com] has joined #bitcoin-core-dev 16:26 -!- grafcaps [~haroldbr@104.137.194.255] has quit [Ping timeout: 240 seconds] 16:31 -!- delta__ [~none@103.254.153.99] has joined #bitcoin-core-dev 16:31 -!- HFRadical [~none@103.254.153.99] has quit [Quit: Leaving] 16:31 -!- delta__ [~none@103.254.153.99] has quit [Remote host closed the connection] 16:35 < bitcoin-git> [bitcoin] denis2342 closed pull request #12541: streamlined the use of include_hex (master...master) https://github.com/bitcoin/bitcoin/pull/12541 16:38 -!- grafcaps [~haroldbr@50.90.83.229] has joined #bitcoin-core-dev 16:43 < eklitzke> 31% of the time in ReadBlockFromDisk() is spent in prevector::resize 16:43 < eklitzke> smh 16:44 < eklitzke> actually that's just one of the code paths, altogether it's 37% if you count the other code paths 16:45 -!- Thad34Watsica [~Thad34Wat@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 240 seconds] 16:45 < sipa> that's remarkable 16:45 < sipa> oh, scriptSigs 16:46 < sipa> (for scriptPubKeys, prevector should almost never need an allocation) 16:46 < eklitzke> https://monad.io/readblockfromdisk.svg 16:48 < sipa> \o/ flame diagram 16:50 < sipa> and 44% in sse4_transform 16:50 < eklitzke> i don't quite get it, so when you call resize() on a prevector, if it grows the vector it calls operator new in a loop for the full new capacity? 16:51 < cfields> eklitzke: I assume it mallocs what's needed, then calls placement-new for each element 16:51 < sipa> eklitzke: those are just placement news, they don't allocate 16:52 < eklitzke> ah 16:52 < cfields> if that's the case and where it's spending its time, we could short-circuit that for the unsigned char case. 16:52 < sipa> eklitzke: it's filling the new space with objects (which should be trivial in the case the type is unsigned char) 16:52 < sipa> cfields: ack 16:52 < sipa> didn't you have a branch to do that? 16:53 < cfields> sipa: i did at one point, but I believe the main slow-down was in the dtor, which was fixed. so I didn't go any further with it 16:54 < cfields> eklitzke: grep for is_trivially_destructible. We could do the same for the ctor and is_trivially_default_constructible. 16:56 < cfields> (though it should be possible to skip the runtime check entirely with SFINAE) 16:56 < eklitzke> wait does this actually do the is_trivially_destructible check at runtime? 16:56 < eklitzke> yeah 16:56 < eklitzke> that's where i was going to go 16:57 < sipa> eklitzke: a smart compiler will do it at compile time 16:57 < cfields> eklitzke: hopefully the compiler optimizes it away 16:57 < cfields> heh 16:57 < eklitzke> right, looks strange to me though 16:57 < sipa> it's possible to write the code in a way that forces it at compile time 16:57 < eklitzke> yeah i'm used to doing this with std::enable_if 16:57 < eklitzke> i'll try to make the prevector code a little faster 16:58 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 17:00 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 17:01 -!- echeveria [~echeveria@138.68.41.181] has joined #bitcoin-core-dev 17:02 -!- echeveria is now known as Guest12590 17:02 -!- Guest12590 [~echeveria@138.68.41.181] has quit [Client Quit] 17:02 -!- echeveria_ [~echeveria@2604:a880:2:d0::28:f001] has joined #bitcoin-core-dev 17:02 -!- echeveria_ [~echeveria@2604:a880:2:d0::28:f001] has quit [Changing host] 17:02 -!- echeveria_ [~echeveria@unaffiliated/echeveria] has joined #bitcoin-core-dev 17:03 < cfields> eklitzke: you may find it helpful to add resize() to the existing prevector benches 17:03 < cfields> that'd make it trivial to demonstrate a speedup 17:03 < eklitzke> good advice, i wouldn't have thought of that 17:05 < sipa> also, given that the only instance of prevector today uses unsigned char, you could just unconditionally hack it in and remove that loop entirely (for the purpose of benchmarking it) 17:06 -!- echeveria_ [~echeveria@unaffiliated/echeveria] has quit [Client Quit] 17:06 -!- echeveria_ [~echeveria@2604:a880:2:d0::28:f001] has joined #bitcoin-core-dev 17:06 -!- echeveria_ [~echeveria@2604:a880:2:d0::28:f001] has quit [Changing host] 17:06 -!- echeveria_ [~echeveria@unaffiliated/echeveria] has joined #bitcoin-core-dev 17:10 -!- echeveria_ [~echeveria@unaffiliated/echeveria] has quit [Client Quit] 17:10 -!- echeveria_ [~echeveria@2604:a880:2:d0::28:f001] has joined #bitcoin-core-dev 17:10 -!- echeveria_ [~echeveria@2604:a880:2:d0::28:f001] has quit [Changing host] 17:10 -!- echeveria_ [~echeveria@unaffiliated/echeveria] has joined #bitcoin-core-dev 17:11 -!- rongze [~rongze@124.64.163.14] has joined #bitcoin-core-dev 17:11 -!- rongze [~rongze@124.64.163.14] has quit [Remote host closed the connection] 17:11 -!- rongze [~rongze@124.64.163.14] has joined #bitcoin-core-dev 17:15 -!- rongze_ [~rongze@124.64.163.14] has joined #bitcoin-core-dev 17:15 -!- rongze [~rongze@124.64.163.14] has quit [Read error: Connection reset by peer] 17:16 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev 17:25 < Randolf> I'm hoping someone can help me with this -- I tried to rebase PR #12546 down to a single commit, but it's just not showing up on GitHub, although "git log" shows me what I'm expecting to see. Is "git push -f" not synchronizing because the Travis CI build failed? Thanks in advance. 17:25 < gribble> https://github.com/bitcoin/bitcoin/issues/12546 | [docs] Minor improvements to Compatibility notes by randolf · Pull Request #12546 · bitcoin/bitcoin · GitHub 17:27 < esotericnonsense> Randolf: you pushed to randolf:master rather than randolf:patch-3 17:27 < esotericnonsense> Randolf: the PR is tracking patch-3, https://github.com/randolf/bitcoin looks to have the single commit on top of master I think? 17:29 -!- rongze_ [~rongze@124.64.163.14] has quit [Remote host closed the connection] 17:31 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 17:31 < Randolf> esotericnonsense: Oh, okay. I'll try to figure out what I've missed then. Thank you. 17:31 < Randolf> I did use this command prior to rebase: git reset --hard origin/patch-3 17:31 -!- rongze [~rongze@124.64.163.14] has joined #bitcoin-core-dev 17:31 < cfields> eklitzke: something else you may be interested in benching, our utxo decompressor decompresses to a std::vector rather than a prevec, forcing an unnecessary copy into the resulting prevec. 17:31 < cfields> (from my reading of the code, anyway) 17:32 < cfields> though I realize you're probably just looking at blocks atm 17:32 -!- Flo80Mills [~Flo80Mill@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 17:33 -!- rongze [~rongze@124.64.163.14] has quit [Remote host closed the connection] 17:33 < Randolf> Ah, yes, I see that "git push -f" is resulting in this: + 393545d85...b787a7fc6 master -> master (forced update) 17:33 -!- rongze [~rongze@124.64.163.14] has joined #bitcoin-core-dev 17:35 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 252 seconds] 17:39 < esotericnonsense> it sounds like you checked out master, reset it to origin/patch-3, then rebased and squashed, something like that. 17:39 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has joined #bitcoin-core-dev 17:41 < Randolf> I'm going to try again with a "git checkout patch-3" command. (I'm still new to git.) 17:43 < Randolf> That was it -- I missed the checkout step. It seems that I don't need to do the reset step then. 17:44 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 17:49 -!- echeveria_ is now known as echeveria 17:54 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 252 seconds] 18:10 -!- CubicEarths [~cubiceart@50-0-95-188.dsl.dynamic.fusionbroadband.com] has quit [Read error: Connection reset by peer] 18:26 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 268 seconds] 18:38 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 19:00 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 19:17 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 19:21 -!- Giszmo [~leo@ip-59-236-219-201.nextelmovil.cl] has joined #bitcoin-core-dev 19:21 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 240 seconds] 19:25 -!- Giszmo [~leo@ip-59-236-219-201.nextelmovil.cl] has quit [Ping timeout: 252 seconds] 19:38 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 19:40 -!- Giszmo [~leo@ip-12-233.219.201.nextelmovil.cl] has joined #bitcoin-core-dev 19:43 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 260 seconds] 19:47 -!- Giszmo [~leo@ip-12-233.219.201.nextelmovil.cl] has quit [Read error: Connection reset by peer] 19:48 -!- Danilo_ [~quassel@200-148-122-8.dsl.telesp.net.br] has joined #bitcoin-core-dev 19:53 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 19:58 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 248 seconds] 19:59 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has quit [Remote host closed the connection] 20:05 -!- Giszmo [~leo@ip-146-237-219-201.nextelmovil.cl] has joined #bitcoin-core-dev 20:06 -!- Danilo_ [~quassel@200-148-122-8.dsl.telesp.net.br] has quit [Remote host closed the connection] 20:16 < bitcoin-git> [bitcoin] eklitzke opened pull request #12549: Make prevector::resize() and other prevector operations much faster (master...prevector) https://github.com/bitcoin/bitcoin/pull/12549 20:18 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 20:23 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 240 seconds] 20:24 -!- Cheeseo [Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has joined #bitcoin-core-dev 20:24 -!- RoyceX [Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has quit [Read error: Connection reset by peer] 20:25 < sipa> eklitzke: nice! 20:25 -!- LumberCartel [~randolf@96.53.47.42] has joined #bitcoin-core-dev 20:25 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 20:26 -!- LumberCartel [~randolf@96.53.47.42] has quit [Client Quit] 20:26 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 252 seconds] 20:27 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev 20:28 < bitcoin-git> [bitcoin] bedri opened pull request #12550: Utils and libraries: Leveldb warning fixes (0.16...leveldbWarningFixes) https://github.com/bitcoin/bitcoin/pull/12550 20:35 < eklitzke> hmm, what version of gcc/libstdc++ does travis use? 20:35 < sipa> gcc 4.8 i believe 20:38 < bitcoin-git> [bitcoin] bedri closed pull request #12550: Utils and libraries: Leveldb warning fixes (0.16...leveldbWarningFixes) https://github.com/bitcoin/bitcoin/pull/12550 20:44 < bitcoin-git> [bitcoin] bedri opened pull request #12551: Leveldb warning fixes (master...leveldbWarningFixes) https://github.com/bitcoin/bitcoin/pull/12551 20:50 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 20:56 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 268 seconds] 21:02 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 21:07 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 245 seconds] 21:19 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has quit [Remote host closed the connection] 21:23 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 21:23 < esotericnonsense> hm. 21:27 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 256 seconds] 21:37 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 21:38 -!- d9b4bef9 [~d9b4bef9@207.38.94.106] has quit [Remote host closed the connection] 21:39 -!- d9b4bef9 [~d9b4bef9@207.38.94.106] has joined #bitcoin-core-dev 21:40 -!- aruns__ [~indistylo@119.82.105.106] has joined #bitcoin-core-dev 21:57 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 22:01 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 22:02 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 240 seconds] 22:02 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 22:08 -!- CubicEarths [~cubiceart@50-0-95-188.dsl.dynamic.fusionbroadband.com] has joined #bitcoin-core-dev 22:28 < bitcoin-git> [bitcoin] fanquake closed pull request #12551: Utils and libraries: Leveldb warning fixes (master...leveldbWarningFixes) https://github.com/bitcoin/bitcoin/pull/12551 22:28 -!- PaulCape_ [~PaulCapes@ip72-209-228-50.dc.dc.cox.net] has quit [Read error: Connection reset by peer] 22:28 -!- PaulCapestany [~PaulCapes@ip72-209-228-50.dc.dc.cox.net] has joined #bitcoin-core-dev 22:31 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-vtommwjffmdectwl] has quit [Quit: Connection closed for inactivity] 22:35 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 22:37 < bitcoin-git> [bitcoin] Empact opened pull request #12553: Prefer wait_until over polling with time.sleep (master...wait-until) https://github.com/bitcoin/bitcoin/pull/12553 22:40 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 245 seconds] 22:54 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 22:56 -!- MrPaz [~PazPazPaz@c-71-57-73-68.hsd1.il.comcast.net] has quit [Ping timeout: 240 seconds] 22:58 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 252 seconds] 23:15 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 23:19 -!- Strepsils [~textual@109.87.232.207] has joined #bitcoin-core-dev 23:20 -!- Strepsils [~textual@109.87.232.207] has quit [Remote host closed the connection] 23:20 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 260 seconds] 23:21 -!- whphhg [~whphhg@unaffiliated/whphhg] has quit [Quit: Leaving] 23:34 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has quit [Quit: Snoozing.] 23:43 -!- Sentineo [~Undefined@unaffiliated/sentineo] has quit [Ping timeout: 240 seconds] 23:44 -!- ken2812221 [~User@133-203.dorm.ncu.edu.tw] has joined #bitcoin-core-dev 23:52 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 23:54 -!- aruns [~indistylo@119.82.105.106] has joined #bitcoin-core-dev 23:56 -!- aruns__ [~indistylo@119.82.105.106] has quit [Ping timeout: 268 seconds] 23:58 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 245 seconds] 23:58 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has joined #bitcoin-core-dev