--- Day changed Thu Mar 01 2018 00:08 -!- aruns [~indistylo@119.82.105.106] has joined #bitcoin-core-dev 00:08 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 00:09 -!- jma01 [~jma@124.205.209.110] has quit [Remote host closed the connection] 00:09 -!- jma01 [~jma@124.205.209.110] has joined #bitcoin-core-dev 00:10 -!- timothy [~tredaelli@redhat/timothy] has quit [Client Quit] 00:10 -!- aruns__ [~indistylo@119.82.105.106] has quit [Ping timeout: 256 seconds] 00:11 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 00:12 -!- rantahu [~rantahu@216-165-95-168.NATPOOL.NYU.EDU] has joined #bitcoin-core-dev 00:13 -!- lnostdal [~lnostdal@gateway/tor-sasl/lnostdal] has joined #bitcoin-core-dev 00:16 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has joined #bitcoin-core-dev 00:18 -!- rantahu [~rantahu@216-165-95-168.NATPOOL.NYU.EDU] has quit [Remote host closed the connection] 00:18 -!- rantahu [~rantahu@216-165-95-168.NATPOOL.NYU.EDU] has joined #bitcoin-core-dev 00:21 -!- btcdrak [uid236341@gateway/web/irccloud.com/x-nhhblascbqbtspxw] has joined #bitcoin-core-dev 00:24 -!- rantahu [~rantahu@216-165-95-168.NATPOOL.NYU.EDU] has quit [Remote host closed the connection] 00:24 -!- rantahu [~rantahu@216-165-95-168.NATPOOL.NYU.EDU] has joined #bitcoin-core-dev 00:29 -!- rantahu [~rantahu@216-165-95-168.NATPOOL.NYU.EDU] has quit [Ping timeout: 248 seconds] 00:29 -!- rex_4539 [~textual@2a02:587:3513:b600:d91e:a2dd:bcf6:a02a] has joined #bitcoin-core-dev 00:37 -!- jma01 [~jma@124.205.209.110] has quit [Remote host closed the connection] 00:37 -!- jma01 [~jma@124.205.209.110] has joined #bitcoin-core-dev 00:38 -!- laurentmt [~Thunderbi@185.161.200.13] has joined #bitcoin-core-dev 00:40 -!- laurentmt [~Thunderbi@185.161.200.13] has quit [Client Quit] 00:50 -!- lightningbot [~supybot@2400:8901::f03c:91ff:febb:bbc1] has quit [Remote host closed the connection] 00:50 -!- lightningbot [~supybot@2400:8901::f03c:91ff:febb:bbc1] has joined #bitcoin-core-dev 00:55 -!- CubicEarths [~cubiceart@50-0-95-188.dsl.dynamic.fusionbroadband.com] has quit [Remote host closed the connection] 00:57 -!- CubicEarths [~cubiceart@50-0-95-188.dsl.dynamic.fusionbroadband.com] has joined #bitcoin-core-dev 00:58 -!- jma01 [~jma@124.205.209.110] has quit [Remote host closed the connection] 00:58 -!- jma01 [~jma@124.205.209.110] has joined #bitcoin-core-dev 01:01 -!- CubicEarths [~cubiceart@50-0-95-188.dsl.dynamic.fusionbroadband.com] has quit [Ping timeout: 240 seconds] 01:02 -!- murrayn [~dafuq@unaffiliated/murrayn] has quit [Ping timeout: 252 seconds] 01:03 -!- jimpo_ [~jimpo@ec2-52-42-179-84.us-west-2.compute.amazonaws.com] has quit [Ping timeout: 268 seconds] 01:10 -!- jma01 [~jma@124.205.209.110] has quit [Remote host closed the connection] 01:10 -!- jma01 [~jma@124.205.209.110] has joined #bitcoin-core-dev 01:16 -!- jma01 [~jma@124.205.209.110] has quit [] 01:19 -!- murrayn [~dafuq@S01061cabc0b054b3.ok.shawcable.net] has joined #bitcoin-core-dev 01:19 -!- murrayn [~dafuq@S01061cabc0b054b3.ok.shawcable.net] has quit [Changing host] 01:19 -!- murrayn [~dafuq@unaffiliated/murrayn] has joined #bitcoin-core-dev 01:23 < bitcoin-git> [bitcoin] 532479301 opened pull request #12573: Consensus: Fix bug when compiler do not support __builtin_clz* (master...vs2017) https://github.com/bitcoin/bitcoin/pull/12573 01:31 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has quit [Remote host closed the connection] 01:32 -!- CubicEarths [~cubiceart@50-0-95-188.dsl.dynamic.fusionbroadband.com] has joined #bitcoin-core-dev 01:36 -!- CubicEarths [~cubiceart@50-0-95-188.dsl.dynamic.fusionbroadband.com] has quit [Ping timeout: 240 seconds] 01:37 -!- rongze_ [~rongze@223.104.3.185] has joined #bitcoin-core-dev 01:40 -!- rongze [~rongze@106.38.57.250] has quit [Ping timeout: 248 seconds] 01:46 < pierre_rochard> Is there an equivalent to ScriptToAsmStr for an CTxIn’s scriptWitness? 01:46 < pierre_rochard> the current implementation of TxToUniv in core_write.cpp just uses HexStr 01:51 -!- Krellan [~Krellan@2601:640:4000:9258:3d1e:5ad:34d8:c4f9] has quit [Ping timeout: 240 seconds] 01:53 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 01:56 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 02:00 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Ping timeout: 260 seconds] 02:03 < wumpus> pierre_rochard: I don't think so 02:06 < pierre_rochard> Ok, I’ll settle for HexStr until I really need it, then I’ll try my hand at a PR :) 02:06 < pierre_rochard> Thank you for the quick response wumpus! 02:07 < wumpus> I'm not sure it's possible to unambigiously distinguish between data encodings there, so it's shown as just hex. But maybe something better could be done, not sure... 02:07 -!- Krellan [~Krellan@2601:640:4000:9258:3d1e:5ad:34d8:c4f9] has joined #bitcoin-core-dev 02:12 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has quit [Remote host closed the connection] 02:24 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 02:25 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 02:53 -!- Deinogalerix21 [~Deinogale@185.169.255.9] has joined #bitcoin-core-dev 02:56 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-rjhjdcfbepiawknl] has joined #bitcoin-core-dev 03:04 -!- aruns__ [~indistylo@119.82.105.106] has joined #bitcoin-core-dev 03:05 -!- aruns [~indistylo@119.82.105.106] has quit [Read error: Connection reset by peer] 03:06 -!- aruns [~indistylo@119.82.105.106] has joined #bitcoin-core-dev 03:09 -!- aruns__ [~indistylo@119.82.105.106] has quit [Ping timeout: 248 seconds] 03:09 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 03:13 < bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/9e2ed253f505...32987d5aebc4 03:13 < bitcoin-git> bitcoin/master f0e7aa7 Evan Klitzke: Add new prevector benchmarks.... 03:13 < bitcoin-git> bitcoin/master e46be25 Akio Nakamura: Reduce redundant code of prevector and speed it up... 03:13 < bitcoin-git> bitcoin/master 5aad635 Evan Klitzke: Use memset() to optimize prevector::resize()... 03:14 < bitcoin-git> [bitcoin] laanwj closed pull request #12549: Make prevector::resize() and other prevector operations much faster (master...prevector) https://github.com/bitcoin/bitcoin/pull/12549 03:18 -!- booyah [~bb@193.25.1.157] has quit [Read error: Connection reset by peer] 03:18 -!- lnostdal [~lnostdal@gateway/tor-sasl/lnostdal] has quit [Ping timeout: 255 seconds] 03:19 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 03:19 -!- booyah [~bb@193.25.1.157] has joined #bitcoin-core-dev 03:20 -!- ken2812221 [~User@133-203.dorm.ncu.edu.tw] has joined #bitcoin-core-dev 03:24 -!- CubicEarths [~cubiceart@50-0-95-188.dsl.dynamic.fusionbroadband.com] has joined #bitcoin-core-dev 03:27 -!- rongze_ [~rongze@223.104.3.185] has quit [Read error: Connection reset by peer] 03:29 -!- CubicEarths [~cubiceart@50-0-95-188.dsl.dynamic.fusionbroadband.com] has quit [Ping timeout: 252 seconds] 03:30 -!- rongze [~rongze@106.38.57.250] has joined #bitcoin-core-dev 03:32 -!- rex_4539 [~textual@2a02:587:3513:b600:d91e:a2dd:bcf6:a02a] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 03:33 -!- rongze_ [~rongze@223.104.3.185] has joined #bitcoin-core-dev 03:34 -!- rex_4539 [~textual@athedsl-128662.home.otenet.gr] has joined #bitcoin-core-dev 03:37 -!- rongze [~rongze@106.38.57.250] has quit [Ping timeout: 260 seconds] 03:37 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/32987d5aebc4...be263faf871f 03:37 < bitcoin-git> bitcoin/master e7d9fc5 Sjors Provoost: [qt] navigate to transaction history page after send... 03:37 < bitcoin-git> bitcoin/master be263fa Wladimir J. van der Laan: Merge #12421: [qt] navigate to transaction history page after send... 03:38 < bitcoin-git> [bitcoin] laanwj closed pull request #12421: [qt] navigate to transaction history page after send (master...2018/02/qt-goto-transactions-after-send) https://github.com/bitcoin/bitcoin/pull/12421 03:45 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection] 03:55 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 04:01 -!- lnostdal [~lnostdal@gateway/tor-sasl/lnostdal] has joined #bitcoin-core-dev 04:03 -!- Deinogalerix21 [~Deinogale@185.169.255.9] has quit [Quit: WeeChat 2.0.1] 04:05 -!- lnostdal [~lnostdal@gateway/tor-sasl/lnostdal] has quit [Remote host closed the connection] 04:05 -!- btcdrak [uid236341@gateway/web/irccloud.com/x-nhhblascbqbtspxw] has quit [Quit: Connection closed for inactivity] 04:07 -!- lnostdal [~lnostdal@gateway/tor-sasl/lnostdal] has joined #bitcoin-core-dev 04:13 -!- Krellan [~Krellan@2601:640:4000:9258:3d1e:5ad:34d8:c4f9] has quit [Read error: Connection reset by peer] 04:17 -!- Krellan [~Krellan@2601:640:4000:9258:3d1e:5ad:34d8:c4f9] has joined #bitcoin-core-dev 04:22 -!- Krellan [~Krellan@2601:640:4000:9258:3d1e:5ad:34d8:c4f9] has quit [Ping timeout: 245 seconds] 04:23 -!- Krellan [~Krellan@2601:640:4000:9258:3d1e:5ad:34d8:c4f9] has joined #bitcoin-core-dev 04:25 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 04:25 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-szaxntcyzblxvrqo] has quit [Quit: Connection closed for inactivity] 04:27 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 04:37 -!- rongze_ [~rongze@223.104.3.185] has quit [Remote host closed the connection] 04:39 -!- btcdrak [uid236341@gateway/web/irccloud.com/x-roftgvaoitggoesu] has joined #bitcoin-core-dev 04:49 -!- CubicEarths [~cubiceart@50-0-95-188.dsl.dynamic.fusionbroadband.com] has joined #bitcoin-core-dev 04:51 -!- ken2812221 [~User@133-203.dorm.ncu.edu.tw] has quit [Quit: Leaving] 04:51 -!- ken2812221 [~User@133-203.dorm.ncu.edu.tw] has joined #bitcoin-core-dev 04:53 -!- CubicEarths [~cubiceart@50-0-95-188.dsl.dynamic.fusionbroadband.com] has quit [Ping timeout: 245 seconds] 04:54 -!- ken2812221 [~User@133-203.dorm.ncu.edu.tw] has quit [Client Quit] 04:55 -!- ken2812221 [~ken281222@140.115.203.133] has joined #bitcoin-core-dev 04:59 -!- aruns__ [~indistylo@119.82.105.106] has joined #bitcoin-core-dev 04:59 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 256 seconds] 05:01 -!- aruns [~indistylo@119.82.105.106] has quit [Ping timeout: 248 seconds] 05:02 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 05:03 -!- lnostdal [~lnostdal@gateway/tor-sasl/lnostdal] has quit [Remote host closed the connection] 05:04 -!- lnostdal [~lnostdal@gateway/tor-sasl/lnostdal] has joined #bitcoin-core-dev 05:04 -!- aruns__ [~indistylo@119.82.105.106] has quit [Ping timeout: 260 seconds] 05:07 -!- Krellan [~Krellan@2601:640:4000:9258:3d1e:5ad:34d8:c4f9] has quit [Ping timeout: 265 seconds] 05:11 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/be263faf871f...39dcac27a1be 05:11 < bitcoin-git> bitcoin/master 90eac8c Kosta Zertsekel: Add tests for HexStr corner cases... 05:11 < bitcoin-git> bitcoin/master ac48861 Kosta Zertsekel: Add tests for HexStr std::reverse_iterator cases... 05:11 < bitcoin-git> bitcoin/master 39dcac2 Wladimir J. van der Laan: Merge #12570: Add test cases for HexStr (std::reverse_iterator and corner cases)... 05:11 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 05:12 < bitcoin-git> [bitcoin] laanwj closed pull request #12570: Add test cases for HexStr (std::reverse_iterator and corner cases) (master...master) https://github.com/bitcoin/bitcoin/pull/12570 05:12 -!- Krellan [~Krellan@2601:640:4000:9258:3d1e:5ad:34d8:c4f9] has joined #bitcoin-core-dev 05:12 -!- indistylo [~indistylo@119.82.105.106] has joined #bitcoin-core-dev 05:16 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-rjhjdcfbepiawknl] has quit [Quit: Connection closed for inactivity] 05:19 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 05:19 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 05:20 -!- CubicEarths [~cubiceart@50-0-95-188.dsl.dynamic.fusionbroadband.com] has joined #bitcoin-core-dev 05:24 -!- CubicEarths [~cubiceart@50-0-95-188.dsl.dynamic.fusionbroadband.com] has quit [Ping timeout: 240 seconds] 05:25 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 248 seconds] 05:26 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 05:39 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 05:42 -!- lnostdal [~lnostdal@gateway/tor-sasl/lnostdal] has quit [Ping timeout: 255 seconds] 05:42 -!- Davion25Cole [~Davion25C@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 245 seconds] 05:45 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 05:45 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 05:49 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-bhyiyjilryzavhwp] has joined #bitcoin-core-dev 05:56 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 05:57 -!- ken2812221 [~ken281222@140.115.203.133] has quit [Remote host closed the connection] 05:57 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 05:57 -!- ken2812221 [~User@133-203.dorm.ncu.edu.tw] has joined #bitcoin-core-dev 05:59 -!- hkjn0 [~hkjn@4.128.198.35.bc.googleusercontent.com] has quit [Ping timeout: 240 seconds] 06:00 -!- rongze [~rongze@124.64.163.14] has joined #bitcoin-core-dev 06:00 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has joined #bitcoin-core-dev 06:02 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Ping timeout: 256 seconds] 06:04 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev 06:05 -!- hkjn0 [~hkjn@4.128.198.35.bc.googleusercontent.com] has joined #bitcoin-core-dev 06:14 < promag> review request #12559 06:14 < gribble> https://github.com/bitcoin/bitcoin/issues/12559 | Avoid locking cs_main in some wallet RPC by promag · Pull Request #12559 · bitcoin/bitcoin · GitHub 06:19 -!- lnostdal [~lnostdal@gateway/tor-sasl/lnostdal] has joined #bitcoin-core-dev 06:21 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 245 seconds] 06:23 -!- ken2812221 [~User@133-203.dorm.ncu.edu.tw] has quit [Read error: Connection reset by peer] 06:25 -!- ken2812221 [~User@133-203.dorm.ncu.edu.tw] has joined #bitcoin-core-dev 06:31 < bitcoin-git> [bitcoin] laanwj pushed 7 new commits to master: https://github.com/bitcoin/bitcoin/compare/39dcac27a1be...5c2aff8d95a9 06:31 < bitcoin-git> bitcoin/master 31c45a9 Jonas Schnelli: Accept addresses with NODE_NETWORK_LIMITED flag 06:31 < bitcoin-git> bitcoin/master 6fe57bd Jonas Schnelli: Connect to peers signaling NODE_NETWORK_LIMITED when out-of-IBD 06:31 < provoostenator> Is bitcoind --daemon supposed to keep a macOS machine awake? 06:31 < bitcoin-git> bitcoin/master fa999af Jonas Schnelli: [QA] Allow addrman loopback tests (add debug option -addrmantest) 06:32 < bitcoin-git> [bitcoin] laanwj closed pull request #10387: Eventually connect to NODE_NETWORK_LIMITED peers (master...2017/05/node_network_limited) https://github.com/bitcoin/bitcoin/pull/10387 06:32 -!- Lloyd87Hudson [~Lloyd87Hu@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 06:32 -!- lnostdal [~lnostdal@gateway/tor-sasl/lnostdal] has quit [Ping timeout: 255 seconds] 06:34 -!- indistylo [~indistylo@119.82.105.106] has quit [Ping timeout: 248 seconds] 06:39 -!- rongze [~rongze@124.64.163.14] has quit [Remote host closed the connection] 06:46 < Randolf> provoostenator: Normally, when running any sort of a server daemon, sleep mode isn't typically wanted. After all, if the machine is in sleep mode, the daemon can't respond to any inbound queries. 06:48 < provoostenator> Right, that's what I would expect too... 06:48 < Randolf> provoostenator: There are some hardware configurations which can "wake up" the machine when network traffic is received, but since Bitcoin has a constant flow of data even this would in effect be pointless. 06:48 < Randolf> ...because the machine would constantly be waking up if ever it could get into sleep mode in the first place. 06:48 < provoostenator> Maybe we can add --caffeinate as a flag (for OSX, maybe Linux has a similar thing)? 06:50 < provoostenator> https://discussions.apple.com/thread/7858428 06:50 < Randolf> provoostenator: I think it's better to leave the power management to the OS. I also think it's reasonable to assume that someone running a server daemon should also have enough knowledge to manage their power settings according to their needs. 06:51 -!- CubicEarths [~cubiceart@50-0-95-188.dsl.dynamic.fusionbroadband.com] has joined #bitcoin-core-dev 06:51 < provoostenator> Yeah, that's what I thought to. But apparently I'm not not knowledgeable enough. :-) 06:52 < Randolf> If Bitcoin were to add options to manage power settings, then that would also be adding complexity to the project which I think would generally be beyond the scope of what Bitcoin is. 06:52 < Randolf> And then whenever a vendor changes their power management API, precious development time gets taken away from more important things. 06:53 < provoostenator> I probably made the mistake of logging out all users from the UI. It probably turned itself off once I closed the last SSH connection into the machine, despite bitcoind and a detached virtual box sessions. 06:54 < provoostenator> I tend to agree bitcoind shouldn't do that for the OS. Though we could add some installation instructions / hints. 06:55 < Randolf> provoostenator: I think that knowing how to change your system's power management configuration is something you'll have to master. 06:55 < Randolf> Again, power management is, in my view, beyond the scope of what Bitcoin does. 06:55 -!- reardencode [~reardenco@hank.reardencode.com] has quit [Ping timeout: 248 seconds] 06:55 < Randolf> It could be good for a Wiki page. 06:56 -!- CubicEarths [~cubiceart@50-0-95-188.dsl.dynamic.fusionbroadband.com] has quit [Ping timeout: 260 seconds] 06:57 -!- Lloyd87Hudson [~Lloyd87Hu@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 265 seconds] 06:58 < Randolf> provoostenator: Consider this: Windows 10 regulatly reboots to install updates without asking the user first. Should Bitcoin's instructions tell users how to change the settings in Windows 10 to stop this from happening? And then update those instructions every time Microsoft changes the way 06:59 < Randolf> And again, I think it's reasonable to assume that anyone who wants to run bitcoind is knowledgeable enough to manage their own OS accordingly. 06:59 < Randolf> those settings are configured? I think this would also be beyond the scope of what Bitcoin does. 07:06 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 07:12 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 07:13 < promag> wumpus: does this make sense https://github.com/bitcoin/bitcoin/blame/5c2aff8d95a932f82a9472975b1d183da6c99e5f/src/qt/transactionrecord.cpp#L140 ? 07:15 < promag> why is the fee added? fwiw rpc gettransaction separates amount and fee (in details field) 07:16 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has joined #bitcoin-core-dev 07:16 < promag> I wonder if we could remove that 07:18 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 260 seconds] 07:18 -!- Krellan [~Krellan@2601:640:4000:9258:3d1e:5ad:34d8:c4f9] has quit [Read error: Connection reset by peer] 07:20 -!- CubicEarths [~cubiceart@50-0-95-188.dsl.dynamic.fusionbroadband.com] has joined #bitcoin-core-dev 07:23 -!- Krellan [~Krellan@2601:640:4000:9258:3d1e:5ad:34d8:c4f9] has joined #bitcoin-core-dev 07:24 -!- harrymm [~harrymm@104.207.83.11] has quit [Ping timeout: 240 seconds] 07:30 -!- CubicEarths [~cubiceart@50-0-95-188.dsl.dynamic.fusionbroadband.com] has quit [Ping timeout: 276 seconds] 07:31 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 07:32 -!- Delmer63Stamm [~Delmer63S@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 07:34 -!- harrymm [~harrymm@104.207.83.30] has joined #bitcoin-core-dev 07:35 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Remote host closed the connection] 07:36 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 07:37 -!- grafcaps [~haroldbr@50.90.83.229] has quit [Ping timeout: 256 seconds] 07:37 -!- jimpo [~jimpo@ec2-52-42-179-84.us-west-2.compute.amazonaws.com] has joined #bitcoin-core-dev 07:38 -!- MrPaz [~PazPazPaz@c-71-57-73-68.hsd1.il.comcast.net] has joined #bitcoin-core-dev 07:38 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 07:47 -!- rongze [~rongze@124.64.163.14] has joined #bitcoin-core-dev 07:48 -!- Krellan [~Krellan@2601:640:4000:9258:3d1e:5ad:34d8:c4f9] has quit [Ping timeout: 245 seconds] 07:52 -!- kexkey [~kexkey@173.209.53.190] has quit [Ping timeout: 252 seconds] 07:54 -!- Krellan [~Krellan@2601:640:4000:9258:3d1e:5ad:34d8:c4f9] has joined #bitcoin-core-dev 07:56 -!- grafcaps [~haroldbr@50.90.26.145] has joined #bitcoin-core-dev 07:56 -!- Delmer63Stamm [~Delmer63S@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 256 seconds] 07:59 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 08:00 -!- Mrrt [~Mrrt@cpe-74-78-139-4.maine.res.rr.com] has joined #bitcoin-core-dev 08:00 -!- bule [~bule@gateway/tor-sasl/bule] has joined #bitcoin-core-dev 08:01 -!- grafcaps [~haroldbr@50.90.26.145] has quit [Ping timeout: 248 seconds] 08:04 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Ping timeout: 276 seconds] 08:04 -!- bule [~bule@gateway/tor-sasl/bule] has quit [Remote host closed the connection] 08:05 -!- bule [~bule@gateway/tor-sasl/bule] has joined #bitcoin-core-dev 08:07 -!- rongze [~rongze@124.64.163.14] has quit [Remote host closed the connection] 08:07 -!- rongze [~rongze@124.64.163.14] has joined #bitcoin-core-dev 08:08 -!- bule [~bule@gateway/tor-sasl/bule] has quit [Remote host closed the connection] 08:08 -!- bule [~bule@gateway/tor-sasl/bule] has joined #bitcoin-core-dev 08:10 -!- bule [~bule@gateway/tor-sasl/bule] has quit [Remote host closed the connection] 08:11 -!- bule [~bule@gateway/tor-sasl/bule] has joined #bitcoin-core-dev 08:11 -!- rongze [~rongze@124.64.163.14] has quit [Ping timeout: 245 seconds] 08:22 -!- grafcaps [~haroldbr@104.137.194.255] has joined #bitcoin-core-dev 08:32 -!- Reanna69Herzog [~Reanna69H@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 08:38 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has quit [Remote host closed the connection] 08:44 -!- lnostdal [~lnostdal@gateway/tor-sasl/lnostdal] has joined #bitcoin-core-dev 09:02 -!- ExtraCrispy [~ExtraCris@jh149.perfectdeals.xyz] has joined #bitcoin-core-dev 09:04 -!- lnostdal [~lnostdal@gateway/tor-sasl/lnostdal] has quit [Ping timeout: 255 seconds] 09:15 -!- bule [~bule@gateway/tor-sasl/bule] has quit [Remote host closed the connection] 09:15 -!- bule [~bule@gateway/tor-sasl/bule] has joined #bitcoin-core-dev 09:17 -!- bule [~bule@gateway/tor-sasl/bule] has quit [Remote host closed the connection] 09:18 -!- bule [~bule@gateway/tor-sasl/bule] has joined #bitcoin-core-dev 09:22 -!- promag [~promag@89.214.94.184] has joined #bitcoin-core-dev 09:26 -!- lnostdal [~lnostdal@gateway/tor-sasl/lnostdal] has joined #bitcoin-core-dev 09:35 -!- btcdrak [uid236341@gateway/web/irccloud.com/x-roftgvaoitggoesu] has quit [Quit: Connection closed for inactivity] 09:42 -!- jaranGoyang [~loop@112.215.174.143] has joined #bitcoin-core-dev 09:44 -!- lnostdal [~lnostdal@gateway/tor-sasl/lnostdal] has quit [Ping timeout: 255 seconds] 09:46 -!- d9b4bef9 [~d9b4bef9@207.38.94.106] has quit [Remote host closed the connection] 09:47 -!- d9b4bef9 [~d9b4bef9@207.38.94.106] has joined #bitcoin-core-dev 09:56 -!- zks_ [c25a8aea@gateway/web/freenode/ip.194.90.138.234] has joined #bitcoin-core-dev 09:59 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 10:02 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/5c2aff8d95a9...987a80995a69 10:02 < bitcoin-git> bitcoin/master 8222e05 Jonas Schnelli: Disable wallet fallbackfee by default on mainnet 10:02 < bitcoin-git> bitcoin/master 3f592b8 Jonas Schnelli: [QA] add wallet-rbf test 10:02 < bitcoin-git> bitcoin/master 987a809 Wladimir J. van der Laan: Merge #11882: Disable default fallbackfee on mainnet... 10:03 < bitcoin-git> [bitcoin] laanwj closed pull request #11882: Disable default fallbackfee on mainnet (master...2017/12/feeest_readyness) https://github.com/bitcoin/bitcoin/pull/11882 10:03 < zks_> Guys, I'm new to Bitcoin Core source code... and I have a question - why base_blob::GetHex() reverses the base_blob::data[WIDTH] array? 10:03 -!- bule [~bule@gateway/tor-sasl/bule] has quit [Remote host closed the connection] 10:03 < zks_> Hope it is an appropriate place to ask questions... 10:03 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Ping timeout: 240 seconds] 10:04 -!- bule [~bule@gateway/tor-sasl/bule] has joined #bitcoin-core-dev 10:06 -!- Reanna69Herzog [~Reanna69H@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 276 seconds] 10:06 < wumpus> zks_: that's an old tradition, to represent hashes in reversed order 10:06 < zks_> wumpus: Thanks for the answer! But why? 10:07 < wumpus> zks_: we inherited it from satoshi and it's not realistic to change the entire interface 10:07 < zks_> wumpus: Is it related to network byte order? 10:07 < wumpus> no, definitely not 10:07 < mmgen> zks_: possibly because it shows leading zeroes of the block header as *leading* zeroes 10:07 < zks_> wumpus: Ok. Got it. Historic reasons... 10:07 < mmgen> zks_: block header hash 10:07 < wumpus> hashes are just blobs of data, their 'network byte order' is simply their memory representation 10:07 < wumpus> there is no logic to it 10:08 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 10:09 < mmgen> zks_: that's my reasoning on why Satoshi did it that way 10:09 < zks_> mmgen: wumpus: If I get it right - there is no difference how to store the hashes (regular or reversed order). It just has to be this way or the other... 10:09 < wumpus> I'm not sure GetHex on blob is the best place to do that swap, as it precludes using it in a neutral fashion, should probably ave been an external function GetWackyExternalRepresentation() but meh... 10:09 < mmgen> zks_: this is how they're represented, not how they're stored 10:10 < wumpus> indeed, internally the data is in normal order, just for external representation it's swapped 10:11 < wumpus> makes sense to use the same conventions in your own software, swap it only for communication with bitcoind 10:11 < zks_> so, in the blockchain "database" the hashes are always in the natural order and only printed in reverse? 10:11 < wumpus> yep 10:12 < zks_> ok, ... moving on guys... thx! 10:12 < wumpus> satoshi's orignal vision: print hashes in reversed order :-) 10:13 -!- Scrat [~herp@unaffiliated/scrat] has joined #bitcoin-core-dev 10:13 < Chris_Stewart_5> *vein pulses in forehead* 10:14 < luke-jr> XD 10:22 -!- bule [~bule@gateway/tor-sasl/bule] has quit [Remote host closed the connection] 10:23 -!- bule [~bule@gateway/tor-sasl/bule] has joined #bitcoin-core-dev 10:27 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 268 seconds] 10:28 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection] 10:31 < bitcoin-git> [bitcoin] promag opened pull request #12578: Add transaction record type Fee (master...2018-03-fee-transaction-record) https://github.com/bitcoin/bitcoin/pull/12578 10:31 < promag> wumpus: not sure if this makes sense ^ but please comment since you wrote the origin code 10:32 < promag> *original 10:32 < wumpus> promag: no, I did not write that code, that came literally from the satoshi wxwindows code 10:32 < promag> I'll update the PR description and add a before image later 10:32 -!- Kirk51VonRueden [~Kirk51Von@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 10:32 < promag> oh :P 10:32 < wumpus> I think it's correct, though a bit weird 10:33 < promag> it's weird to see the fee as debit in the first output 10:33 < wumpus> the idea is that the total works out 10:33 < promag> we could "hide" fee records by default with a checkbox 10:33 < promag> right 10:34 < wumpus> so satoshi's reasoning there is that it doesn't matter which of the outputs the fee is added to, but it must be added to one, otherwise the total doesn't match 10:34 < wumpus> probably there's something similar in the RPC wallet 10:36 -!- reardencode [~reardenco@hank.reardencode.com] has joined #bitcoin-core-dev 10:39 -!- promag [~promag@89.214.94.184] has quit [Remote host closed the connection] 10:40 -!- promag [~promag@89.214.94.184] has joined #bitcoin-core-dev 10:43 < bitcoin-git> [bitcoin] laanwj closed pull request #12518: [0.16] Bump leveldb subtree (0.16...Mf1802-leveldbSubtreeBump) https://github.com/bitcoin/bitcoin/pull/12518 10:43 -!- MrPaz [~PazPazPaz@c-71-57-73-68.hsd1.il.comcast.net] has quit [Ping timeout: 260 seconds] 10:46 < promag> wumpus: maybe in listtransactions, I'll check later 10:47 < promag> btw, pr description updated 10:47 -!- promag [~promag@89.214.94.184] has quit [Remote host closed the connection] 10:47 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 10:52 -!- MrPaz [~PazPazPaz@c-71-57-73-68.hsd1.il.comcast.net] has joined #bitcoin-core-dev 10:55 -!- bule2 [~bule@gateway/tor-sasl/bule] has joined #bitcoin-core-dev 10:57 -!- bule [~bule@gateway/tor-sasl/bule] has quit [Ping timeout: 255 seconds] 10:58 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev 11:01 < Randolf> wumpus: Perhaps the "hashes in reverse" routine could be analogous to AMBULANCE written backward on ambulances? 11:02 -!- moneyball [41c8485a@gateway/web/freenode/ip.65.200.72.90] has joined #bitcoin-core-dev 11:02 < jcorgan> meeting? 11:03 < Randolf> jcorgan++ 11:03 < sipa> meetung 11:03 < jcorgan> not sure the world could handle two of me 11:03 < achow101> meeting. 11:04 < wumpus> #startmeeting 11:04 < lightningbot> Meeting started Thu Mar 1 19:04:02 2018 UTC. The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot. 11:04 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic. 11:04 < wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator 11:04 < wumpus> Randolf: yes, like that, hash mirroring (TM) 11:04 < wumpus> #topic high priority for review 11:04 * Randolf smiles 11:05 < wumpus> https://github.com/bitcoin/bitcoin/projects/8 11:05 < wumpus> a few of the PRs really need rebase 11:06 -!- bule2 [~bule@gateway/tor-sasl/bule] has quit [Remote host closed the connection] 11:06 -!- bule2 [~bule@gateway/tor-sasl/bule] has joined #bitcoin-core-dev 11:06 < wumpus> but we managed to merge a few this week, so if you have nothing on that list yet, proposals are welcome 11:06 < sipa> many people at FC18 right now, btw 11:06 < Randolf> I have purposely NOT rebased PR #12501 fully yet because it turned into some discussion about the "virtual size" of transactions. 11:06 < gribble> https://github.com/bitcoin/bitcoin/issues/12501 | [qt] Improved "custom fee" explanation in tooltip by randolf · Pull Request #12501 · bitcoin/bitcoin · GitHub 11:07 < Randolf> I hoped that last week it would be an easy one to complete, but turns out this wasn't so straight-forward. 11:07 < wumpus> there are certainly valid reasons to not rebase something 11:07 < Randolf> I think that PR #12567 can probably be closed, but a few more people might want to take a quick look at it first. 11:07 < gribble> https://github.com/bitcoin/bitcoin/issues/12567 | util: Print timestamp strings in logs using ISO 8601 formatting by practicalswift · Pull Request #12567 · bitcoin/bitcoin · GitHub 11:07 < Randolf> I think that PR #12546 should be merged. 11:07 < wumpus> on the other hand, if something runs out of sync with current master, then reviewing it in the current state makes less sense 11:07 < gribble> https://github.com/bitcoin/bitcoin/issues/12546 | [docs] Minor improvements to Compatibility Notes by randolf · Pull Request #12546 · bitcoin/bitcoin · GitHub 11:07 -!- ExtraCrispy [~ExtraCris@jh149.perfectdeals.xyz] has quit [Quit: ExtraCrispy] 11:07 < luke-jr> #11383 is probably ready for merge, just only one recent utACK 11:08 < gribble> https://github.com/bitcoin/bitcoin/issues/11383 | Basic Multiwallet GUI support by luke-jr · Pull Request #11383 · bitcoin/bitcoin · GitHub 11:08 < Randolf> (Sorry, I meant "merged" earlier rather than "closed.") 11:08 -!- rongze [~rongze@124.64.163.14] has joined #bitcoin-core-dev 11:08 < wumpus> 12501 isn't on that list, should it be? 11:08 < Randolf> I suspect that PR 12501 probably needs more peer-review and discussion. 11:09 < wumpus> luke-jr: great! 11:09 < wumpus> luke-jr: looks like jonasschnelli has some, unreplied to comments there 11:09 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 11:09 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 11:10 < wumpus> it's fine to say that you're leaving them for a later PR, but please do reply to ereview comments 11:10 < Randolf> Okay. 11:10 < kanzure> hi. 11:10 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 11:11 < promag> hi 11:11 < kanzure> btw i am still seeking topic suggestions (either stuff you want to talk about, or you want other people to talk about) for next week's event. 11:12 < kanzure> speaking of which, we should decide about next weekly meeting timing since i imagine some folks will be traveling 11:12 < wumpus> #action send kanzure further topic suggestions 11:12 -!- rongze [~rongze@124.64.163.14] has quit [Ping timeout: 240 seconds] 11:12 < wumpus> right, I'll definitely not be there next week 11:13 < wumpus> will be travellingback at that time 11:13 < kanzure> wasn't aware we'd lose a bunch of people to fc18 but makes sense. 11:13 < promag> regarding multiwallet, there are other details that can be left for other pulls 11:13 < wumpus> indeed, apparently same problem this week 11:13 < sipa> sorry! 11:13 < luke-jr> sipa: next time, schedule FC so it doesn't conflict. 11:13 < sipa> haha! 11:13 < luke-jr> :p 11:14 * Randolf laughs 11:14 < wumpus> so I think we should skip next week's IRC meeting 11:14 < achow101> ack 11:14 < Randolf> Ack. 11:14 < kanzure> we can move it forward if we want.. since a lot of folks in same room. but it's sort of redundant. 11:14 < wumpus> right 11:15 < sipa> sgtm 11:15 < luke-jr> I suggest we have kanzure transcribe RL stuff to #bitcoin-core-dev in real time 11:15 < kanzure> that's okay with me since roasbeef wont be there 11:15 -!- btcdrak [uid236341@gateway/web/irccloud.com/x-hfgyjxusaixlugsb] has joined #bitcoin-core-dev 11:15 < luke-jr> lol 11:15 < kanzure> (i love him tho) 11:15 < wumpus> hehe 11:15 < btcdrak> oh what did I miss? 11:16 < luke-jr> 1/4th of the meeting 11:16 < wumpus> I suggest we have kanzure transcribe RL stuff to #bitcoin-core-dev in real time 11:16 < wumpus> that's okay with me since roasbeef wont be there 11:16 < wumpus> not much is going on, everyone is at FC apparently 11:16 < luke-jr> end early and spend 45 minutes on #11383 ? :D 11:16 < gribble> https://github.com/bitcoin/bitcoin/issues/11383 | Basic Multiwallet GUI support by luke-jr · Pull Request #11383 · bitcoin/bitcoin · GitHub 11:16 < wumpus> but if anyone has a topic they like to discuss with the three of us, please mention 11:17 < Randolf> btcdrak: I suggested merging PRs 12567 and 12546 and luke-jr suggested merging PR 11383. 11:17 < luke-jr> wumpus, luke-jr, sipa, btcdrak, kanzure, achow101, Randolf, promag = 8 11:17 < sdaftuar> hi 11:17 < wumpus> 12546 is obvious / documentation only 11:17 < Randolf> Yes. 11:18 < luke-jr> Randolf: well, it'd be nice to get a few more utACKs first (although I've shipped 11383 in Knots so long that I doubt there's any problems to find left) 11:19 < achow101> I'll take a look at 11383 11:20 < promag> luke-jr: I'll review again 11:21 < Randolf> wumpus: In PR 12501 an issue arose about the "virtual size" of the transaction. I'm thinking that it would probably be best to not mention this so as not to confuse end-users, but there's one person who's in favour of specifying this. If there's a link to documentation that can get into the 11:22 < Randolf> "See also," not see all. :) 11:22 < Randolf> details of the virtual size of the transaction, then I'm also thinking that including the link in the tooltip as a "see all" item should keep everyone happy? 11:23 < luke-jr> Randolf: the value being configured is fundamentally tied to virtual size. I don't think it's avoidable. 11:23 < wumpus> it's most important to be correct / complete 11:23 < luke-jr> "adjusted size" might be more understandable in plain English 11:24 < luke-jr> but there's no precedent for calling it that yet 11:24 < wumpus> in general, even if certain terms might confuse users, it's better to mention something than leave it out and say the wrong thing 11:24 < wumpus> but yeah, virtual size is confusing 11:24 < Randolf> Okay. I want the tooltip to be correct without adding confusion. 11:24 < luke-jr> weight-adjusted size? 11:25 < wumpus> but calling it differently might be even worse 11:25 < wumpus> I don't know 11:25 < wumpus> (as you can't google it then!) 11:25 -!- jtimon [~quassel@41.31.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 11:26 < luke-jr> it's really a different way of speaking of the weight, not the size 11:26 < Randolf> From a plain-English perspective, "weight-adjusted size" is much nicer, but that point about it being a new term is an important one because then it needs to be in the full documentation too. 11:26 < luke-jr> I can't think up a nice way to call it 11:26 < Randolf> Originally, I didn't have the word "virtual" in there. 11:27 < luke-jr> I suggest we just stick to "virtual size" until some English genius thinks up a better name 11:27 < wumpus> if there are new terms there's a good rationale to only use a single term for it, not make up multiple terms just because they sound nicer 11:27 < Randolf> I agree. 11:27 < wumpus> so if it is virtual size, I think we need to bite the bullet and simply use that 11:28 < wumpus> any other topics? 11:28 < Randolf> Alright. So, if the current wording in most recent commit - https://github.com/bitcoin/bitcoin/pull/12501/commits/a6a800cc4b3c1cbc4e5199563e2de1b5228ff9e2 - looks fine, then I'll go ahead and rebase. 11:29 < luke-jr> lgtn 11:29 < luke-jr> lgtm* 11:29 < wumpus> yes 11:29 < wumpus> #endmeeting 11:29 < lightningbot> Meeting ended Thu Mar 1 19:29:53 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) 11:29 < lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-03-01-19.04.html 11:29 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-03-01-19.04.txt 11:29 < lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-03-01-19.04.log.html 11:29 < Randolf> Thanks. 11:30 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/987a80995a69...a4a5fc7c17cd 11:30 < bitcoin-git> bitcoin/master b22c289 Randolf Richardson: [docs] Minor improvements to Compatibility Notes... 11:31 < bitcoin-git> bitcoin/master a4a5fc7 Wladimir J. van der Laan: Merge #12546: [docs] Minor improvements to Compatibility Notes... 11:31 < bitcoin-git> [bitcoin] laanwj closed pull request #12546: [docs] Minor improvements to Compatibility Notes (master...patch-3) https://github.com/bitcoin/bitcoin/pull/12546 11:32 -!- moneyball [41c8485a@gateway/web/freenode/ip.65.200.72.90] has quit [Quit: Page closed] 11:33 < bitcoin-git> [bitcoin] achow101 closed pull request #12180: scripted-diff: change kB to kvB, kilobyte to kilovbyte for transaction fee rate things (master...use-vbytes) https://github.com/bitcoin/bitcoin/pull/12180 11:33 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 11:43 < jtimon> I guess "weight / 4" is more confusing than "virtual size" 11:48 < wumpus> yes 11:48 < wumpus> and even if you explain how it is computed, you'd still need to mention the term 11:48 < sipa> i wish we just everyone changed 'size' to mean vsize 11:48 < sipa> *everywhere 11:49 < sipa> but it's probably too late for that 11:50 -!- loop_ [~loop@112.215.245.63] has joined #bitcoin-core-dev 11:51 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a4a5fc7c17cd...90a0aed51194 11:51 < bitcoin-git> bitcoin/master 19ac86e Alin Rus: Remove useless string initialization. 11:51 < bitcoin-git> bitcoin/master 90a0aed Wladimir J. van der Laan: Merge #12182: Remove useless string initializations... 11:52 < bitcoin-git> [bitcoin] laanwj closed pull request #12182: Remove useless string initializations (master...remove_useless_string_init) https://github.com/bitcoin/bitcoin/pull/12182 11:54 < wumpus> sipa: that would be the neatest solution, just have 'size' interpreted as 'vsize' everywhere 11:54 -!- jaranGoyang [~loop@112.215.174.143] has quit [Ping timeout: 252 seconds] 11:54 < Randolf> wumpus and jtimon: PR #12501 has been rebased, and I wrote a comment to @dooglus explaining where we're at. 11:54 < gribble> https://github.com/bitcoin/bitcoin/issues/12501 | [qt] Improved "custom fee" explanation in tooltip by randolf · Pull Request #12501 · bitcoin/bitcoin · GitHub 11:55 < Randolf> sipa: I wonder if it might be helpful to have a glossary of terms included in a separate file. 11:59 < wumpus> it would be something to put in the UI user documentation, if we had any :) 12:00 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 12:03 < Randolf> I suppose bits and pieces could be put together at first, and then later formed into a proper document. 12:03 < Randolf> I guess there would be two documentation files -- one for bitcoind, and the other for the GUI. 12:04 < Randolf> Or perhaps they should just be separate chapters to avoid overlap. 12:04 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Ping timeout: 240 seconds] 12:06 < rex_4539> Are you interested in a PR about fixing all the potential typos in the source code? I could go through all the source code, fix all typos, and squash to a single commit. If you are interested, let me know if you want me to fix all typos (comments and readable messages) or just a particular type. I have already fixed them in Zcash and Monero projects. 12:10 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-wxyifzsntpbybltp] has joined #bitcoin-core-dev 12:11 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 12:12 -!- bule2 [~bule@gateway/tor-sasl/bule] has quit [Remote host closed the connection] 12:12 < Randolf> rex_4539: How does one fix "potential typos?" 12:12 < Randolf> Fixing existing typos is always welcome. 12:12 -!- bule2 [~bule@gateway/tor-sasl/bule] has joined #bitcoin-core-dev 12:13 < rex_4539> Very tedious work, I can assure you :) Not a developer but willing to help in any capacity I can. 12:13 < Randolf> That's fantastic. 12:13 < Randolf> My suggestion is this... 12:14 < Randolf> Do all the corrections in documentation in one PR, and do all the corrections in source code in another PR. 12:14 < Randolf> That is, if you want to keep the number of PRs down to a minimum. 12:14 < Randolf> You're also welcome to break them apart into smaller PRs if you like. 12:15 < Randolf> One of the advantages of smaller PRs is that it's easier to get them reviewed and merged. 12:18 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 12:20 < rex_4539> The good thing with typos is that they are extremely trivial to review. Shouldn't take more than 5 minutes for the whole Bitcoin project. 12:21 < Randolf> Your contributions are most certainly welcome. :) 12:21 < Randolf> Please feel free to connect with me on GitHub as well: https://www.github.com/randolf 12:21 -!- MrPaz [~PazPazPaz@c-71-57-73-68.hsd1.il.comcast.net] has quit [Quit: Leaving] 12:22 < rex_4539> Do you want me to fix also comments or just readable messages? 12:23 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 12:23 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has quit [Ping timeout: 240 seconds] 12:23 -!- Tennis [~Tennis@unaffiliated/tennis] has joined #bitcoin-core-dev 12:24 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 12:24 < Randolf> rex_4539: That's entirely up to you as this is a volunteer effort after all. 12:24 < jcorgan> PRs with changes that are scattered through the code, like typo fixes, can sometimes make other PRs need rebasing (if merged) 12:25 < rex_4539> I'm asking because each team works differently. Zcash team was happy to have all fixed, Monero wanted just readable comments. 12:25 < rex_4539> *messages 12:26 < Randolf> rex_4539: Oh, I see. All fixes are welcome. 12:26 -!- Kirk51VonRueden [~Kirk51Von@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 256 seconds] 12:26 < rex_4539> Don't worry, I will not touch typos in the actual code, just comments and readable messages. 12:27 < Randolf> jcorgan: Does it make a difference if the changes are in a very small number of very large PRs, or if the changes are in a lot of smaller PRs? 12:28 -!- loop_ [~loop@112.215.245.63] has quit [Remote host closed the connection] 12:28 -!- grafcaps [~haroldbr@104.137.194.255] has quit [Read error: Connection reset by peer] 12:28 < rex_4539> In my experience in the 2 previous projects, they wanted one big BR because each separate PR was using the CI machines all the time :P 12:28 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 260 seconds] 12:28 < jcorgan> i think there's a way to comment your PR so it gets ignored by CI, don't remember 12:29 < jcorgan> appropriate for doc only changes, but not for code comments, as you might accidentally break syntax 12:30 -!- grafcaps [~haroldbr@104.137.194.255] has joined #bitcoin-core-dev 12:31 < Randolf> Oh, I'd like to know how to comment my PR to prevent the CI checks. That would reduce system resource load then. 12:31 < jcorgan> but i wouldn't worry so much about it now, i'd focus on getting the work done and submit a single PR for it, then if it needs breaking into multiple ones it will come out in the review 12:32 < rex_4539> I think there is a rollup command for the bot. 12:32 < Chris_Stewart_5> isn't travis 'free' for open source projects? 12:32 < Randolf> I still think it would be good to separate documentation updates from code/comment updates into two PRs though, at least. 12:32 < jcorgan> free, but capacity limited and might only run one job at a time 12:32 -!- Adela50Torp [~Adela50To@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 12:32 < jcorgan> agree on code/comment and doc separation 12:33 < Randolf> Chris_Stewart_5: For doc-only PRs that I've been submitting, if I knew I could do something to prevent unnecessary resource usage, I would have been happy to do it. 12:33 < rex_4539> Sure, 2 separate PRs it is then. Will get to it in a couple of days. 12:33 < Randolf> rex_4539: Wow, thank you! 12:35 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 12:35 < jcorgan> another general purpose consideration for pull requests is that independent things don't get combined into one request, as the maintainer can't selectively merge one or the other 12:36 < jcorgan> anyway, just some thoughts from experience as a maintainer elsewhere, carry on :-) 12:36 < rex_4539> Yes, but maintainer can comment on the ones he disagrees and I can revert those commits. 12:36 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 12:37 < jcorgan> in general, the less work the maintainer and reviewers need to do, the more likely it is to get merged 12:37 < Randolf> That's why I suggested smaller PRs. 12:38 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has joined #bitcoin-core-dev 12:41 < eklitzke> I found a bug in GCC 8.0 (not yet stable) as a result of that prevector optimization, https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84656 12:43 < wumpus> I agree with jcorgan 12:43 < wumpus> eklitzke: congrats on finding a gcc bug 12:45 -!- Tennis [~Tennis@unaffiliated/tennis] has quit [Quit: Leaving] 12:46 < Randolf> Chris_Stewart_5: Apparently the [ci-skip]" 12:46 < Randolf> Chris_Stewart_5: Apparently, including the text "[ci-skip]" (without the quotation marks) in a PR's message will prevent Travis-CI from attempting a build. 12:46 -!- Tennis [~Tennis@unaffiliated/tennis] has joined #bitcoin-core-dev 12:47 < Randolf> rex_4539: You may want to include this text in your doc-only PRs to prevent the build process: [ci-skip] 12:47 < Randolf> rex_4539: When changing comments, you should still let the build occur. 12:48 -!- Tennis [~Tennis@unaffiliated/tennis] has quit [Remote host closed the connection] 12:50 < wumpus> I found a clang bug once: https://github.com/bitcoin-core/secp256k1/issues/445 12:51 < eklitzke> your bug is a lot more interesting than mine 12:54 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 260 seconds] 12:56 < rex_4539> Randolf, is it [ci-skip] [ci skip] or [skip ci]? Found all cases in GitHub :P 12:56 < rex_4539> https://github.com/bitcoin/bitcoin/commit/e3a820751f11b3b30ac19d8118df3e755132e470 12:56 < rex_4539> https://github.com/bitcoin/bitcoin/pull/7658 12:56 < Randolf> Someone in the #travis channel just indicated to me that it's this: [ci-skip] 12:57 < Randolf> If they all work (which would be good), then it doesn't matter. 12:59 < Randolf> I suggest using the in-comment style that in PR #7658 instead of including it in the PR's title -- keeping those titles simple is generally encouraged, and they're also limited in size anyway as far as I know. 12:59 < gribble> https://github.com/bitcoin/bitcoin/issues/7658 | Add curl to Gitian setup instructions by btcdrak · Pull Request #7658 · bitcoin/bitcoin · GitHub 13:04 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 260 seconds] 13:10 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 13:11 -!- laurentmt [~Thunderbi@95.215.61.164] has joined #bitcoin-core-dev 13:13 -!- Adela50Torp [~Adela50To@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 240 seconds] 13:13 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 13:15 -!- bule2 [~bule@gateway/tor-sasl/bule] has quit [Remote host closed the connection] 13:15 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 240 seconds] 13:16 -!- laurentmt1 [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 13:17 -!- bule2 [~bule@gateway/tor-sasl/bule] has joined #bitcoin-core-dev 13:19 -!- laurentmt [~Thunderbi@95.215.61.164] has quit [Ping timeout: 268 seconds] 13:19 -!- laurentmt1 is now known as laurentmt 13:32 -!- Efrain83Reichert [~Efrain83R@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 13:59 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 14:00 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 14:02 -!- mirese [~mirese@2a02:1205:507c:3710:d589:bb4a:abe4:f689] has joined #bitcoin-core-dev 14:04 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has quit [Quit: (https://github.com/mmgen) leaving] 14:05 -!- mirese_ [~mirese@2a02:1205:507c:3710:fde9:d9e5:60e:dccb] has quit [Ping timeout: 240 seconds] 14:05 -!- Efrain83Reichert [~Efrain83R@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 252 seconds] 14:06 < bitcoin-git> [bitcoin] dooglus opened pull request #12580: Show a transaction's virtual size in its details dialog (master...show_vsize) https://github.com/bitcoin/bitcoin/pull/12580 14:12 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has quit [Ping timeout: 248 seconds] 14:15 -!- droark [~droark@c-24-22-123-27.hsd1.or.comcast.net] has quit [Ping timeout: 245 seconds] 14:16 -!- Randolf [~randolf@S010668725181be68.vc.shawcable.net] has joined #bitcoin-core-dev 14:20 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-wxyifzsntpbybltp] has quit [Quit: Connection closed for inactivity] 14:21 -!- Randolf [~randolf@S010668725181be68.vc.shawcable.net] has quit [Ping timeout: 248 seconds] 14:22 -!- Randolf [~randolf@S010668725181be68.vc.shawcable.net] has joined #bitcoin-core-dev 14:32 -!- Frederic50Hermis [~Frederic5@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 14:32 -!- Randolf [~randolf@S010668725181be68.vc.shawcable.net] has quit [Ping timeout: 241 seconds] 14:37 -!- Giszmo [~leo@ip-23-226-107-190.nextelmovil.cl] has joined #bitcoin-core-dev 14:39 -!- rex_4539 [~textual@athedsl-128662.home.otenet.gr] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 14:45 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has joined #bitcoin-core-dev 14:54 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Remote host closed the connection] 14:55 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev 15:00 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 15:00 < bitcoin-git> [bitcoin] laanwj closed pull request #10040: wallet: use headers chain for anti fee sniping (master...patch) https://github.com/bitcoin/bitcoin/pull/10040 15:01 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 15:01 -!- ula [~ula@b2b-78-94-9-226.unitymedia.biz] has joined #bitcoin-core-dev 15:02 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 15:07 -!- StopAndDecrypt [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has joined #bitcoin-core-dev 15:08 -!- StopAndDecrypt [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has quit [Changing host] 15:08 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has joined #bitcoin-core-dev 15:08 -!- StopAndDecrypt_ [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has quit [Ping timeout: 268 seconds] 15:14 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has quit [Ping timeout: 252 seconds] 15:15 -!- btcdrak [uid236341@gateway/web/irccloud.com/x-hfgyjxusaixlugsb] has quit [Quit: Connection closed for inactivity] 15:15 -!- StopAndDecrypt [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has joined #bitcoin-core-dev 15:15 -!- StopAndDecrypt [~StopAndDe@c-73-248-248-9.hsd1.nj.comcast.net] has quit [Changing host] 15:15 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has joined #bitcoin-core-dev 15:15 -!- bule2 [~bule@gateway/tor-sasl/bule] has quit [Remote host closed the connection] 15:16 -!- bule2 [~bule@gateway/tor-sasl/bule] has joined #bitcoin-core-dev 15:17 -!- bule2 [~bule@gateway/tor-sasl/bule] has quit [Remote host closed the connection] 15:17 -!- bule2 [~bule@gateway/tor-sasl/bule] has joined #bitcoin-core-dev 15:22 -!- bule2 [~bule@gateway/tor-sasl/bule] has quit [Ping timeout: 255 seconds] 15:23 -!- Frederic50Hermis [~Frederic5@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 240 seconds] 15:31 -!- Randolf [~randolf@S010668725181be68.vc.shawcable.net] has joined #bitcoin-core-dev 15:32 -!- Hilton61Hoeger [~Hilton61H@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 15:39 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has quit [] 15:40 -!- Hilton61Hoeger [~Hilton61H@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 240 seconds] 15:43 -!- Randolf [~randolf@S010668725181be68.vc.shawcable.net] has quit [Ping timeout: 252 seconds] 16:00 -!- weez17 [~isaac@unaffiliated/weez17] has quit [Remote host closed the connection] 16:00 -!- weez17 [~isaac@unaffiliated/weez17] has joined #bitcoin-core-dev 16:02 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 16:02 -!- vicenteH [~user@35.233.15.37.dynamic.jazztel.es] has quit [Ping timeout: 245 seconds] 16:06 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Ping timeout: 240 seconds] 16:20 -!- Randolf [~randolf@69.166.112.240] has joined #bitcoin-core-dev 16:23 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has joined #bitcoin-core-dev 16:50 -!- ula [~ula@b2b-78-94-9-226.unitymedia.biz] has quit [Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/] 16:57 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has joined #bitcoin-core-dev 16:59 -!- Randolf [~randolf@69.166.112.240] has quit [Read error: Connection reset by peer] 17:00 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 17:00 -!- droark [~droark@c-24-22-123-27.hsd1.or.comcast.net] has joined #bitcoin-core-dev 17:02 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 17:04 -!- Randolf [~randolf@69.166.112.240] has joined #bitcoin-core-dev 17:08 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 17:10 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 17:16 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [] 17:21 -!- lnostdal [~lnostdal@gateway/tor-sasl/lnostdal] has joined #bitcoin-core-dev 17:30 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 17:30 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 17:35 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 260 seconds] 17:37 -!- Randolf [~randolf@69.166.112.240] has quit [Ping timeout: 240 seconds] 17:40 -!- wacawacawaca [~user@cpe-172-101-144-51.rochester.res.rr.com] has joined #bitcoin-core-dev 17:41 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [] 18:00 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Ping timeout: 255 seconds] 18:01 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 18:03 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 18:03 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 18:07 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Ping timeout: 256 seconds] 18:08 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 245 seconds] 18:09 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 18:13 -!- Giszmo [~leo@ip-23-226-107-190.nextelmovil.cl] has quit [Ping timeout: 240 seconds] 18:13 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 240 seconds] 18:13 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 18:17 -!- jbisch [~joseph@107.170.79.147] has joined #bitcoin-core-dev 18:17 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Ping timeout: 240 seconds] 18:23 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Remote host closed the connection] 18:25 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 18:25 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 18:26 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has quit [Read error: Connection reset by peer] 18:27 -!- Giszmo [~leo@pc-204-28-214-201.cm.vtr.net] has joined #bitcoin-core-dev 18:28 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has joined #bitcoin-core-dev 18:30 -!- rongze [~rongze@106.38.57.250] has joined #bitcoin-core-dev 18:34 -!- Krellan [~Krellan@2601:640:4000:9258:3d1e:5ad:34d8:c4f9] has quit [Read error: Connection reset by peer] 18:35 -!- Krellan [~Krellan@2601:640:4000:9258:3d1e:5ad:34d8:c4f9] has joined #bitcoin-core-dev 18:38 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 18:43 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 276 seconds] 18:48 -!- grafcaps [~haroldbr@104.137.194.255] has quit [Ping timeout: 245 seconds] 18:59 -!- grafcaps [~haroldbr@50.90.83.229] has joined #bitcoin-core-dev 19:20 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 19:24 -!- rongze_ [~rongze@117.136.0.235] has joined #bitcoin-core-dev 19:24 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 240 seconds] 19:26 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-bhyiyjilryzavhwp] has quit [Quit: Connection closed for inactivity] 19:27 -!- irk0in [~rissa@173.227.62.24] has left #bitcoin-core-dev [] 19:27 -!- rongze [~rongze@106.38.57.250] has quit [Ping timeout: 256 seconds] 19:31 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev 19:46 -!- kexkey [~kexkey@173.209.57.12] has joined #bitcoin-core-dev 19:49 < jonasschnelli> luke-jr: this signal seems unused, right? https://github.com/bitcoin/bitcoin/pull/11383/files#diff-744201ccb403526a4b5bf52d6e5367deR26 19:51 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 19:52 < luke-jr> jonasschnelli: no, it's used to resolve the wallet (JSONRPCRequestWalletResolver) 19:54 < jonasschnelli> Ah. I see it now 19:55 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 252 seconds] 19:57 -!- jcorgan [~jcorgan@unaffiliated/jcorgan] has quit [Ping timeout: 240 seconds] 20:02 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 20:06 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Remote host closed the connection] 20:07 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 240 seconds] 20:10 -!- pindarhk_ [sid105966@gateway/web/irccloud.com/x-pjidluoprhrqovmj] has quit [Read error: Connection reset by peer] 20:10 -!- Varunram [sid210151@gateway/web/irccloud.com/x-yoyoeacziyqaxsdt] has quit [Ping timeout: 255 seconds] 20:10 -!- ThisAsYou [sid214210@gateway/web/irccloud.com/x-mxjzullkumdhsbra] has quit [Ping timeout: 255 seconds] 20:10 -!- trotski2000 [sid206086@gateway/web/irccloud.com/x-mnkzxjmggjmnstyu] has quit [Ping timeout: 256 seconds] 20:11 -!- Muis [sid26074@gateway/web/irccloud.com/x-sjvztpatkpvfaytp] has quit [Read error: Connection reset by peer] 20:11 -!- sugarpuff [sid92283@gateway/web/irccloud.com/x-kqgaqsuiuqnwkiqe] has quit [Read error: Connection reset by peer] 20:11 -!- aspect_ [sid151486@gateway/web/irccloud.com/x-enkxonretwtysblu] has quit [Read error: Connection reset by peer] 20:11 -!- mariorz [sid490@gateway/web/irccloud.com/x-qdtcttaohpcilmju] has quit [Read error: Connection reset by peer] 20:11 -!- Jackielove4u [uid43977@gateway/web/irccloud.com/x-imrougaafjpntpkf] has quit [Read error: Connection reset by peer] 20:11 -!- BullShark [sid226214@gateway/web/irccloud.com/x-unbmrslkiqwweaiy] has quit [Write error: Connection reset by peer] 20:11 -!- udiWertheimer [sid190185@gateway/web/irccloud.com/x-ubcpzrugyykdkjql] has quit [Read error: Connection reset by peer] 20:11 -!- exit70 [sid231392@gateway/web/irccloud.com/x-raimakorelntucgu] has quit [Ping timeout: 256 seconds] 20:11 -!- rubensayshi [sid201751@gateway/web/irccloud.com/x-opaobuaqfevhimpw] has quit [Write error: Connection reset by peer] 20:11 -!- nejon [sid38993@gateway/web/irccloud.com/x-anokdajtnaaiblrx] has quit [Ping timeout: 256 seconds] 20:11 -!- NicolasDorier [sid129442@gateway/web/irccloud.com/x-cdtxuhbefkixhnua] has quit [Ping timeout: 256 seconds] 20:11 -!- eragmus [sid136308@gateway/web/irccloud.com/x-ehywxaykfciongys] has quit [Ping timeout: 256 seconds] 20:11 -!- profall [sid29922@gateway/web/irccloud.com/x-pznffpyslxbbwfgd] has quit [Read error: Connection reset by peer] 20:11 -!- sferrini [sid115350@gateway/web/irccloud.com/x-vpphwjambkipupkb] has quit [Read error: Connection reset by peer] 20:11 -!- nOgAnOo [sid146237@gateway/web/irccloud.com/x-juqsjeoerlrovmio] has quit [Write error: Connection reset by peer] 20:11 -!- epic [sid37137@gateway/web/irccloud.com/x-sgubypzjiplwyclm] has quit [Read error: Connection reset by peer] 20:11 -!- hsmiths [uid95325@gateway/web/irccloud.com/x-rkgsxjlwzdjkliqz] has quit [Read error: Network is unreachable] 20:11 -!- barq [sid103986@gateway/web/irccloud.com/x-ayuwvqzyuvaijoeu] has quit [Read error: Connection reset by peer] 20:11 -!- ChrisMorrisOrg [sid151627@gateway/web/irccloud.com/x-antwbgopagbywiaq] has quit [Write error: Connection reset by peer] 20:11 -!- Bosma [sid103570@gateway/web/irccloud.com/x-khcdxierrsrzdbms] has quit [Ping timeout: 245 seconds] 20:11 -!- wbnns [sid105317@21/bitcoin/binns] has quit [Ping timeout: 255 seconds] 20:11 -!- mappum [sid43795@gateway/web/irccloud.com/x-lshaeqlfdgtwejll] has quit [Ping timeout: 255 seconds] 20:11 -!- games_ [sid99242@gateway/web/irccloud.com/x-klbtuascvnjsldan] has quit [Ping timeout: 240 seconds] 20:12 -!- jl2012 [sid133844@gateway/web/irccloud.com/x-piwrikbqogxrkygm] has quit [Ping timeout: 255 seconds] 20:12 -!- robby938 [sid238281@gateway/web/irccloud.com/x-vkakrjxlwxkphien] has quit [Ping timeout: 255 seconds] 20:12 -!- CodeShark [sid126576@gateway/web/irccloud.com/x-blqwklbasxbbwebp] has quit [Ping timeout: 240 seconds] 20:12 -!- pindarhk_ [sid105966@gateway/web/irccloud.com/x-zswqurcpongrwvne] has joined #bitcoin-core-dev 20:12 -!- rodarmor [sid210835@gateway/web/irccloud.com/x-kouabmilfcelzufk] has quit [Ping timeout: 256 seconds] 20:12 -!- wallet42 [sid154231@gateway/web/irccloud.com/x-torznudwllbxpzxq] has quit [Ping timeout: 240 seconds] 20:12 -!- ibrightly [sid113387@gateway/web/irccloud.com/x-uvpqzdbocatoytaf] has quit [Ping timeout: 256 seconds] 20:13 -!- Bosma [sid103570@gateway/web/irccloud.com/x-yofgbqtxnkxwqsxd] has joined #bitcoin-core-dev 20:13 -!- jl2012 [sid133844@gateway/web/irccloud.com/x-gnjvbdftltehibdd] has joined #bitcoin-core-dev 20:13 -!- sugarpuff [sid92283@gateway/web/irccloud.com/x-psfelmtixsmxmcgl] has joined #bitcoin-core-dev 20:13 -!- udiWertheimer [sid190185@gateway/web/irccloud.com/x-vycvequsgtqwxscv] has joined #bitcoin-core-dev 20:13 -!- CodeShark [sid126576@gateway/web/irccloud.com/x-nuarunkeosuzxyze] has joined #bitcoin-core-dev 20:13 -!- Jackielove4u [uid43977@gateway/web/irccloud.com/x-stosrzyzjzsvnoqy] has joined #bitcoin-core-dev 20:14 -!- hsmiths [uid95325@gateway/web/irccloud.com/x-qfdfnesyxjorhyix] has joined #bitcoin-core-dev 20:14 -!- robby938 [sid238281@gateway/web/irccloud.com/x-ulwtssrenqlqlfnq] has joined #bitcoin-core-dev 20:15 -!- Varunram [sid210151@gateway/web/irccloud.com/x-sehivkcshlsincdc] has joined #bitcoin-core-dev 20:15 -!- mturquette [sid66043@gateway/web/irccloud.com/x-kgxhncpnquinmcuz] has quit [Ping timeout: 276 seconds] 20:15 -!- mariorz [sid490@gateway/web/irccloud.com/x-brdfijkxlcsivshr] has joined #bitcoin-core-dev 20:15 -!- eragmus [sid136308@gateway/web/irccloud.com/x-ltyabbdyukpokafi] has joined #bitcoin-core-dev 20:15 -!- rodarmor [sid210835@gateway/web/irccloud.com/x-syawefquppqlmftp] has joined #bitcoin-core-dev 20:16 -!- ChrisMorrisOrg [sid151627@gateway/web/irccloud.com/x-ydjalwfhvqvcumqm] has joined #bitcoin-core-dev 20:16 -!- profall [sid29922@gateway/web/irccloud.com/x-yziyafpwvusejodm] has joined #bitcoin-core-dev 20:17 -!- NicolasDorier [sid129442@gateway/web/irccloud.com/x-jbawfnktkzaxqiwv] has joined #bitcoin-core-dev 20:17 -!- mappum [sid43795@gateway/web/irccloud.com/x-jwqqzakblbvgqlxq] has joined #bitcoin-core-dev 20:17 -!- rubensayshi [sid201751@gateway/web/irccloud.com/x-uunadchhhvwekmgc] has joined #bitcoin-core-dev 20:17 -!- trotski2000 [sid206086@gateway/web/irccloud.com/x-hhkbkzaeksebgzto] has joined #bitcoin-core-dev 20:17 -!- ChrisMorrisOrg [sid151627@gateway/web/irccloud.com/x-ydjalwfhvqvcumqm] has quit [Max SendQ exceeded] 20:17 -!- ThisAsYou [sid214210@gateway/web/irccloud.com/x-qtshdwtfuryentix] has joined #bitcoin-core-dev 20:18 -!- aspect_ [sid151486@gateway/web/irccloud.com/x-olverplzwqcvhpcp] has joined #bitcoin-core-dev 20:18 -!- BullShark [sid226214@gateway/web/irccloud.com/x-qrklvwqzruyczvvi] has joined #bitcoin-core-dev 20:19 -!- ChrisMorrisOrg [sid151627@gateway/web/irccloud.com/x-enqtlztygjuwbkmc] has joined #bitcoin-core-dev 20:20 -!- dafunkizdiz [~dafunkizd@174.127.143.202] has joined #bitcoin-core-dev 20:21 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 20:21 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds] 20:22 -!- rongze_ [~rongze@117.136.0.235] has quit [Ping timeout: 256 seconds] 20:28 -!- mturquette [sid66043@gateway/web/irccloud.com/x-rnfbrvvnmmdcthob] has joined #bitcoin-core-dev 20:29 -!- ibrightly [sid113387@gateway/web/irccloud.com/x-fbrvjqfzgdqtsyau] has joined #bitcoin-core-dev 20:29 -!- wallet42 [sid154231@gateway/web/irccloud.com/x-xlidjjlmeklmqdsu] has joined #bitcoin-core-dev 20:29 -!- epic [sid37137@gateway/web/irccloud.com/x-dlvwyxlpbtsmubtq] has joined #bitcoin-core-dev 20:29 -!- Muis [sid26074@gateway/web/irccloud.com/x-yjvgcdnrcekoscgu] has joined #bitcoin-core-dev 20:30 -!- nOgAnOo [sid146237@gateway/web/irccloud.com/x-zzgpqkbxkbqxqunz] has joined #bitcoin-core-dev 20:30 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Remote host closed the connection] 20:33 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 20:34 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Client Quit] 20:39 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 20:39 -!- wbnns [sid105317@21/bitcoin/binns] has joined #bitcoin-core-dev 20:40 -!- barq [sid103986@gateway/web/irccloud.com/x-ylsjnoboyefngkhq] has joined #bitcoin-core-dev 20:44 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 260 seconds] 20:50 -!- games_ [sid99242@gateway/web/irccloud.com/x-vevcslopuvcynbtn] has joined #bitcoin-core-dev 20:50 -!- exit70 [sid231392@gateway/web/irccloud.com/x-zbmsbbljkrddkisn] has joined #bitcoin-core-dev 20:59 -!- rongze [~rongze@106.38.57.250] has joined #bitcoin-core-dev 21:01 -!- sferrini [sid115350@gateway/web/irccloud.com/x-wdvformdiaqgvmen] has joined #bitcoin-core-dev 21:06 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 21:07 -!- dafunkizdiz [~dafunkizd@174.127.143.202] has quit [Quit: probably someone interrupted me] 21:11 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 265 seconds] 21:15 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 21:15 -!- rex_4539 [~textual@2a02:587:3513:b600:2409:8276:8312:ca50] has joined #bitcoin-core-dev 21:19 -!- dafunkizdiz [~dafunkizd@174.127.143.202] has joined #bitcoin-core-dev 21:20 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Ping timeout: 268 seconds] 21:20 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 21:26 -!- fanquake_ [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 21:27 -!- rongze [~rongze@106.38.57.250] has quit [Remote host closed the connection] 21:28 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Ping timeout: 256 seconds] 21:34 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 21:36 -!- btcdrak [uid236341@gateway/web/irccloud.com/x-wbkmisybvjbvcehm] has joined #bitcoin-core-dev 21:37 -!- bule2 [~bule@gateway/tor-sasl/bule] has joined #bitcoin-core-dev 21:39 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 260 seconds] 21:44 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has quit [Quit: Snoozing.] 21:50 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 21:56 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 276 seconds] 21:59 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Remote host closed the connection] 22:00 -!- Lynne [d2980c13@gateway/web/freenode/ip.210.152.12.19] has joined #bitcoin-core-dev 22:01 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 22:02 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 22:06 -!- Lynne [d2980c13@gateway/web/freenode/ip.210.152.12.19] has quit [Quit: Page closed] 22:07 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 265 seconds] 22:14 -!- rongze [~rongze@106.38.57.250] has joined #bitcoin-core-dev 22:17 -!- dafunkizdiz [~dafunkizd@174.127.143.202] has quit [Quit: probably someone interrupted me] 22:17 -!- dafunkizdiz [~dafunkizd@174.127.143.202] has joined #bitcoin-core-dev 22:19 < bitcoin-git> [bitcoin] luke-jr closed pull request #11089: Enable various p2sh-p2wpkh functionality (master...p2shp2wpkhstuff) https://github.com/bitcoin/bitcoin/pull/11089 22:21 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 22:22 -!- dafunkizdiz [~dafunkizd@174.127.143.202] has quit [Client Quit] 22:27 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 260 seconds] 22:44 -!- bule2 [~bule@gateway/tor-sasl/bule] has quit [Ping timeout: 255 seconds] 22:51 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 22:56 < jonasschnelli> luke-jr: https://github.com/bitcoin/bitcoin/pull/11383#issuecomment-369828151 22:56 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 248 seconds] 22:56 < jonasschnelli> You disagree with the pass wallets as std::string instead CWallet or with my commit that removes the signal-approach? 23:05 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 23:07 -!- dafunkizdiz [~dafunkizd@2600:380:8051:e25d:95e4:96eb:453e:ffc6] has joined #bitcoin-core-dev 23:10 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 276 seconds] 23:17 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 23:17 -!- fanquake_ [~fanquake@unaffiliated/fanquake] has quit [] 23:17 -!- Krellan [~Krellan@2601:640:4000:9258:3d1e:5ad:34d8:c4f9] has quit [Read error: Connection reset by peer] 23:18 -!- Krellan [~Krellan@2601:640:4000:9258:3d1e:5ad:34d8:c4f9] has joined #bitcoin-core-dev 23:21 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 260 seconds] 23:32 -!- dafunkizdiz [~dafunkizd@2600:380:8051:e25d:95e4:96eb:453e:ffc6] has quit [Quit: probably someone interrupted me] 23:34 -!- dafunkizdiz [~dafunkizd@2600:380:8051:e25d:95e4:96eb:453e:ffc6] has joined #bitcoin-core-dev 23:36 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 23:38 -!- dafunkizdiz [~dafunkizd@2600:380:8051:e25d:95e4:96eb:453e:ffc6] has quit [Client Quit] 23:40 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 256 seconds] 23:44 -!- btcdrak [uid236341@gateway/web/irccloud.com/x-wbkmisybvjbvcehm] has quit [Quit: Connection closed for inactivity] 23:48 -!- rex_4539 [~textual@2a02:587:3513:b600:2409:8276:8312:ca50] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 23:55 -!- rongze [~rongze@106.38.57.250] has quit [Remote host closed the connection]