--- Day changed Tue Mar 13 2018 00:00 -!- CapitanRetardo [~CapitanRe@ipbcc23e7c.dynamic.kabel-deutschland.de] has joined #bitcoin-core-dev 00:08 -!- CapitanRetardo [~CapitanRe@ipbcc23e7c.dynamic.kabel-deutschland.de] has quit [Ping timeout: 264 seconds] 00:10 -!- CapitanRetardo [~CapitanRe@ipbcc23e7c.dynamic.kabel-deutschland.de] has joined #bitcoin-core-dev 00:11 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 00:12 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 00:16 -!- Guest65417 [~anon@112.133.236.158] has quit [Ping timeout: 276 seconds] 00:20 < Randolf> pierre_rochard: The folks on the #github channel have been helpful to me in the past. I suspect there's a good chance someone there might know of something like you describe if it exists. 00:21 < pierre_rochard> I’ll ask them, thanks Randolf! 00:21 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 00:24 < Randolf> You're welcome. 00:30 -!- CapitanRetardo [~CapitanRe@ipbcc23e7c.dynamic.kabel-deutschland.de] has quit [Ping timeout: 264 seconds] 00:37 -!- dafunkiz_ [~dafunkizd@174.127.143.202] has quit [Quit: probably someone interrupted me] 00:42 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has joined #bitcoin-core-dev 00:56 -!- djnicholson [23b0cff4@gateway/web/freenode/ip.35.176.207.244] has quit [Ping timeout: 260 seconds] 00:56 -!- CapitanRetardo [~CapitanRe@ipbcc23e7c.dynamic.kabel-deutschland.de] has joined #bitcoin-core-dev 01:00 -!- CapitanRetardo [~CapitanRe@ipbcc23e7c.dynamic.kabel-deutschland.de] has quit [Ping timeout: 256 seconds] 01:02 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has quit [Quit: that's all folks] 01:10 -!- CapitanRetardo [~CapitanRe@ipbcc23e7c.dynamic.kabel-deutschland.de] has joined #bitcoin-core-dev 01:36 -!- Alohaaaa [b95ff224@gateway/web/freenode/ip.185.95.242.36] has joined #bitcoin-core-dev 01:36 < Alohaaaa> Hello 01:36 -!- Alohaaaa [b95ff224@gateway/web/freenode/ip.185.95.242.36] has quit [Client Quit] 01:40 -!- CapitanRetardo [~CapitanRe@ipbcc23e7c.dynamic.kabel-deutschland.de] has quit [Ping timeout: 240 seconds] 01:49 -!- ProfMac-2 [~ProfMac@2001:470:b8ac:0:442d:e50b:3524:6afe] has quit [Ping timeout: 260 seconds] 01:52 -!- ProfMac-2 [~ProfMac@2001:470:b8ac:0:f83f:d9ce:e7c6:cf29] has joined #bitcoin-core-dev 01:59 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 02:03 -!- drizztbsd [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 02:04 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 248 seconds] 02:06 -!- CapitanRetardo [~CapitanRe@ipbcc23e7c.dynamic.kabel-deutschland.de] has joined #bitcoin-core-dev 02:11 -!- CapitanRetardo [~CapitanRe@ipbcc23e7c.dynamic.kabel-deutschland.de] has quit [Ping timeout: 264 seconds] 02:12 -!- CapitanRetardo [~CapitanRe@ipbcc23e7c.dynamic.kabel-deutschland.de] has joined #bitcoin-core-dev 02:27 -!- vicenteH [~user@195.235.96.150] has joined #bitcoin-core-dev 02:42 -!- wump is now known as wumpus 02:44 < wumpus> pierre_rochard: ajtowns[m] did some work in that direction (a script to figure out which PRs collide with which others) from what I remember 02:47 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 02:47 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 02:48 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 02:49 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 02:51 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Remote host closed the connection] 02:52 < pierre_rochard> wumpus: thanks, maybe https://github.com/ajtowns/bitcoin-prs is it and he hasn’t pushed the code up yet. ajtowns[m] I’m happy to help out 02:55 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Excess Flood] 02:55 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 03:00 -!- dabura667_ [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has quit [Remote host closed the connection] 03:14 < murrayn> argh. had an open PR, and made a mistake push. easy way to undo that? 03:14 < murrayn> https://github.com/bitcoin/bitcoin/pull/12630 03:21 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 03:25 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Ping timeout: 268 seconds] 03:26 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev 03:26 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 246 seconds] 03:32 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 03:32 -!- kryptopraxis [~krypto_pr@p200300C853CAD5004134110D5193557C.dip0.t-ipconnect.de] has quit [Remote host closed the connection] 03:34 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 03:35 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 03:40 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 256 seconds] 03:41 -!- kryptopraxis [~krypto_pr@p200300C853CAD500619D03F595CD839E.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 03:42 < wumpus> murrayn: yes, go to git reflog, find the old commit id 03:43 < wumpus> murrayn: force-push that to the branch 03:47 < murrayn> wumpus, will that undo the push? or create a new push that undoes the bad push? 03:47 < murrayn> just curious 03:47 < wumpus> isn't that the same? 03:47 < murrayn> well 03:47 < murrayn> i'd rather just go back in time obviously. 03:47 < murrayn> than to document fixing a fuckup 03:48 < wumpus> well by finding the old commit id you're going back in time 03:49 < murrayn> ok, we'll see 03:49 < wumpus> to me it seems entirely philosophical wehther you consider that a new push of an old state, or re-doing an old push, or restoring the previous push 03:50 < murrayn> hmm 03:51 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 03:52 < wumpus> also you can do git reset --hard (on the branch) first to do it locally, then force-push the branch to the remote branch, if that's easier to understand 03:53 -!- kryptopraxis [~krypto_pr@p200300C853CAD500619D03F595CD839E.dip0.t-ipconnect.de] has quit [Remote host closed the connection] 03:55 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 260 seconds] 03:56 < murrayn> wumpus, just trying to understand: so after the reset, is the --force necessary? 03:56 < murrayn> wumpus, or just git push 03:56 < wumpus> yes, the force is necessary as you're pushing a commit that is not a child of the current branch 03:57 < murrayn> ah 03:57 < wumpus> it doesn't change, from regard of github, what you do locally 03:58 < murrayn> wumpus, thank you sir. 03:58 < murrayn> seems to have worked. 03:58 < wumpus> cool 04:05 -!- CapitanRetardo [~CapitanRe@ipbcc23e7c.dynamic.kabel-deutschland.de] has quit [Ping timeout: 256 seconds] 04:05 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 04:08 -!- kryptopraxis [~kryptopra@p200300C853CAD50030651D941CD18B41.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 04:11 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 268 seconds] 04:17 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 04:19 -!- jojeyh [~delphi@2602:306:b8b6:b970:fc4e:a12:3352:1c1e] has quit [Ping timeout: 240 seconds] 04:21 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 246 seconds] 04:22 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 04:23 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Read error: Connection reset by peer] 04:25 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 04:25 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Remote host closed the connection] 04:26 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev 04:29 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 264 seconds] 04:32 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 04:32 -!- CapitanRetardo [~CapitanRe@ipbcc23e7c.dynamic.kabel-deutschland.de] has joined #bitcoin-core-dev 04:34 < wumpus> I've invited eklitzke (as frequent contributor) to the bitcoin and bitcoin-core orgs 04:37 -!- CapitanRetardo [~CapitanRe@ipbcc23e7c.dynamic.kabel-deutschland.de] has quit [Ping timeout: 256 seconds] 04:37 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 256 seconds] 04:37 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 04:43 -!- CapitanRetardo [~CapitanRe@ipbcc23e7c.dynamic.kabel-deutschland.de] has joined #bitcoin-core-dev 04:44 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 04:46 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 04:51 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 264 seconds] 04:54 -!- CapitanRetardo [~CapitanRe@ipbcc23e7c.dynamic.kabel-deutschland.de] has quit [Ping timeout: 264 seconds] 04:54 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 04:59 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 246 seconds] 05:04 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 05:08 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 260 seconds] 05:09 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 240 seconds] 05:10 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has joined #bitcoin-core-dev 05:15 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 05:19 -!- CapitanRetardo [~CapitanRe@ipbcc23e7c.dynamic.kabel-deutschland.de] has joined #bitcoin-core-dev 05:19 -!- kryptopraxis [~kryptopra@p200300C853CAD50030651D941CD18B41.dip0.t-ipconnect.de] has quit [Remote host closed the connection] 05:20 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 260 seconds] 05:23 -!- CapitanRetardo [~CapitanRe@ipbcc23e7c.dynamic.kabel-deutschland.de] has quit [Ping timeout: 256 seconds] 05:24 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [] 05:25 < kallewoof> if you literally want to go back to say '5 mins ago' you can also do: git reset --hard mynicebranch@{"5 minutes ago"} 05:27 -!- Samdney [~Samdney@37.58.58.246] has joined #bitcoin-core-dev 05:28 -!- unholymachine [~quassel@2601:8c:c003:9f16:a42f:773a:b82b:6285] has quit [Remote host closed the connection] 05:29 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has joined #bitcoin-core-dev 05:29 -!- unholymachine [~quassel@2601:8c:c003:9f16:bc02:f83:7b75:8523] has joined #bitcoin-core-dev 05:29 -!- CapitanRetardo [~CapitanRe@ipbcc23e7c.dynamic.kabel-deutschland.de] has joined #bitcoin-core-dev 05:29 < wumpus> kallewoof: ah yes, git understands time referencs, I forgot about that :) 05:31 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 05:34 -!- CapitanRetardo [~CapitanRe@ipbcc23e7c.dynamic.kabel-deutschland.de] has quit [Ping timeout: 268 seconds] 05:35 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 240 seconds] 05:35 < kallewoof> wumpus: I only learned about it a few weeks ago. I actually used it already, once. :) Very cool feature. 05:35 -!- CapitanRetardo [~CapitanRe@ipbcc23e7c.dynamic.kabel-deutschland.de] has joined #bitcoin-core-dev 05:39 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 246 seconds] 05:46 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 05:48 -!- CapitanRetardo [~CapitanRe@ipbcc23e7c.dynamic.kabel-deutschland.de] has quit [Ping timeout: 248 seconds] 05:49 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has joined #bitcoin-core-dev 05:51 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 260 seconds] 05:54 -!- unholymachine [~quassel@2601:8c:c003:9f16:bc02:f83:7b75:8523] has quit [Quit: http://quassel-irc.org - Chat comfortably. Anywhere.] 05:55 -!- unholymachine [~quassel@2601:8c:c003:9f16:bc02:f83:7b75:8523] has joined #bitcoin-core-dev 05:59 -!- atroxes [~atroxes@unaffiliated/atroxes] has quit [Quit: bye] 06:02 -!- PaulCapestany [~PaulCapes@ip72-209-228-50.dc.dc.cox.net] has quit [Quit: .] 06:02 -!- PaulCapestany [~PaulCapes@ip72-209-228-50.dc.dc.cox.net] has joined #bitcoin-core-dev 06:05 -!- PaulCapestany [~PaulCapes@ip72-209-228-50.dc.dc.cox.net] has quit [Remote host closed the connection] 06:06 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 06:08 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 06:09 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has quit [Quit: probably someone interrupted me] 06:09 -!- ram___ [a0ee4bba@gateway/web/freenode/ip.160.238.75.186] has joined #bitcoin-core-dev 06:12 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 06:14 -!- CapitanRetardo [~CapitanRe@ipbcc23e7c.dynamic.kabel-deutschland.de] has joined #bitcoin-core-dev 06:17 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 06:18 -!- CapitanRetardo [~CapitanRe@ipbcc23e7c.dynamic.kabel-deutschland.de] has quit [Ping timeout: 248 seconds] 06:21 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 248 seconds] 06:22 -!- ram___ [a0ee4bba@gateway/web/freenode/ip.160.238.75.186] has quit [Quit: Page closed] 06:23 -!- t3chn02IVTB6 [~tuaqbyf@195.200.64.7] has joined #bitcoin-core-dev 06:25 -!- t3chn02IVTB6 [~tuaqbyf@195.200.64.7] has quit [Remote host closed the connection] 06:26 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 06:28 -!- CapitanRetardo [~CapitanRe@ipbcc23e7c.dynamic.kabel-deutschland.de] has joined #bitcoin-core-dev 06:29 -!- karelb [~karelb@163.172.146.205] has quit [Quit: Ping timeout (120 seconds)] 06:29 -!- karelb [~karelb@163.172.146.205] has joined #bitcoin-core-dev 06:29 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 06:34 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 264 seconds] 06:38 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 06:39 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 06:42 -!- CapitanRetardo [~CapitanRe@ipbcc23e7c.dynamic.kabel-deutschland.de] has quit [Ping timeout: 240 seconds] 06:43 -!- kryptopraxis [~kryptopra@p200300C853CAD50094EF15C1087F83CC.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 06:45 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 06:48 -!- krypto-praxis [~kryptopra@p200300C853CAD50094EF15C1087F83CC.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 06:49 -!- krypto-praxis [~kryptopra@p200300C853CAD50094EF15C1087F83CC.dip0.t-ipconnect.de] has quit [Remote host closed the connection] 06:49 -!- kryptopraxis [~kryptopra@p200300C853CAD50094EF15C1087F83CC.dip0.t-ipconnect.de] has quit [Quit: Leaving] 06:50 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 240 seconds] 06:50 -!- kryptopraxis [~kryptopra@p200300C853CAD500AC5D63D2F7E633A8.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 06:53 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has quit [Remote host closed the connection] 06:53 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 06:58 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 246 seconds] 06:58 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 07:00 -!- mangoicedtea [~mangoiced@2601:583:c201:7520::3] has joined #bitcoin-core-dev 07:02 -!- lnostdal [~lnostdal@gateway/tor-sasl/lnostdal] has quit [Quit: https://quanto.ga/] 07:06 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 07:08 -!- CapitanRetardo [~CapitanRe@ipbcc23e7c.dynamic.kabel-deutschland.de] has joined #bitcoin-core-dev 07:11 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 245 seconds] 07:13 -!- CapitanRetardo [~CapitanRe@ipbcc23e7c.dynamic.kabel-deutschland.de] has quit [Ping timeout: 246 seconds] 07:13 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 07:18 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 240 seconds] 07:21 < contrapumpkin> esotericnonsense: hah, after a day of running -reindex, it popped up the exact same error message at the same place :P 07:22 -!- EpicBaldGuy [~EpicBaldG@2601:18d:77f:6dd8::3936] has joined #bitcoin-core-dev 07:22 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 07:24 -!- CapitanRetardo [~CapitanRe@ipbcc23e7c.dynamic.kabel-deutschland.de] has joined #bitcoin-core-dev 07:24 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 07:26 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 07:31 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 256 seconds] 07:38 -!- CapitanRetardo [~CapitanRe@ipbcc23e7c.dynamic.kabel-deutschland.de] has quit [Ping timeout: 256 seconds] 07:39 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-syspczbohxskpmau] has quit [Quit: Connection closed for inactivity] 07:41 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 07:46 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 264 seconds] 07:48 -!- mangoicedtea [~mangoiced@2601:583:c201:7520::3] has quit [Ping timeout: 245 seconds] 07:55 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 07:56 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 07:57 -!- mangoicedtea [~mangoiced@c-66-176-217-7.hsd1.fl.comcast.net] has joined #bitcoin-core-dev 07:57 -!- CapitanRetardo [~CapitanRe@ipbcc23e7c.dynamic.kabel-deutschland.de] has joined #bitcoin-core-dev 07:58 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 07:59 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 240 seconds] 08:01 -!- rex_4539 [~textual@2a02:587:3513:b600:34e4:37cd:df1a:5987] has joined #bitcoin-core-dev 08:04 < Randolf> contrapumpkin: Might there be a bad sector on your hard disk? 08:04 -!- HFRadical [~none@c-73-221-225-225.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 08:06 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 08:07 -!- Guest99 [9d617092@gateway/web/cgi-irc/kiwiirc.com/ip.157.97.112.146] has joined #bitcoin-core-dev 08:09 < Guest99> hey, looking through this reddit thread (https://www.reddit.com/r/CoinBase/comments/83syb6/warning_coinbase_merchant_segwit_implementation/) claiming the current Coinbase segwit implementation for merchants is broken, 08:10 < Guest99> can someone break down exactly what's wrong for me? 08:10 < Guest99> the poster said he confirmed it with bitcoin dev, but i cant find the chat logs 08:10 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 08:14 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 240 seconds] 08:18 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 240 seconds] 08:18 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to 0.16: https://github.com/bitcoin/bitcoin/compare/60086ddc34ee...46ca8f383e53 08:18 < bitcoin-git> bitcoin/0.16 faf316a Wladimir J. van der Laan: test: Update trust git root... 08:18 < bitcoin-git> bitcoin/0.16 46ca8f3 Wladimir J. van der Laan: Merge #12648: [0.16] test: Update trusted git root... 08:19 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 08:24 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 264 seconds] 08:26 < provoostenator> Gues99: that's a topic for #bitcoin, unless it's a bug in Bitcoin Core 08:26 < provoostenator> Guest99 ^ 08:28 < provoostenator> (there are Core devs on many IRC channels) 08:29 -!- Apex [~none@103.254.153.99] has joined #bitcoin-core-dev 08:31 -!- HFRadical [~none@c-73-221-225-225.hsd1.wa.comcast.net] has quit [Ping timeout: 240 seconds] 08:32 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 08:34 -!- Apex [~none@103.254.153.99] has quit [Client Quit] 08:37 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 256 seconds] 08:38 < Guest99> provoostenator thanks! 08:39 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 08:40 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 265 seconds] 08:43 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 240 seconds] 08:44 -!- Guest99 [9d617092@gateway/web/cgi-irc/kiwiirc.com/ip.157.97.112.146] has quit [Remote host closed the connection] 08:55 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 08:59 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 256 seconds] 09:00 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/66e91420ab23...ae5bcc7abb14 09:00 < bitcoin-git> bitcoin/master b1149ee practicalswift: Remove redundant code in MutateTxSign(CMutableTransaction&, const std::string&) 09:00 < bitcoin-git> bitcoin/master ae5bcc7 Wladimir J. van der Laan: Merge #10694: Remove redundant code in MutateTxSign(CMutableTransaction&, const std::string&)... 09:00 < bitcoin-git> [bitcoin] laanwj closed pull request #10694: Remove redundant code in MutateTxSign(CMutableTransaction&, const std::string&) (master...remove-redundant-code-in-MutateTxSign) https://github.com/bitcoin/bitcoin/pull/10694 09:01 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 09:04 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 09:04 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 09:06 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 09:09 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 264 seconds] 09:11 -!- Sinclair_ [sinclair6@gateway/vpn/privateinternetaccess/sinclair6] has quit [Ping timeout: 264 seconds] 09:11 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 09:12 -!- Sinclair6 [sinclair6@gateway/vpn/privateinternetaccess/sinclair6] has joined #bitcoin-core-dev 09:14 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev 09:16 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 246 seconds] 09:18 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ae5bcc7abb14...3d16f581538b 09:18 < bitcoin-git> bitcoin/master f4b68b3 Evan Klitzke: Log fatal LevelDB errors more verbosely 09:18 < bitcoin-git> bitcoin/master 3d16f58 MarcoFalke: Merge #12659: Improve Fatal LevelDB Log Messages... 09:19 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 09:19 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #12659: Improve Fatal LevelDB Log Messages (master...leveldb_errmsg) https://github.com/bitcoin/bitcoin/pull/12659 09:22 -!- grafcaps [~haroldbr@50.90.83.229] has joined #bitcoin-core-dev 09:23 -!- Murch [~murch@96.74.120.81] has joined #bitcoin-core-dev 09:23 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 240 seconds] 09:26 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 09:26 -!- grafcaps [~haroldbr@50.90.83.229] has quit [Ping timeout: 246 seconds] 09:28 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 09:28 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds] 09:32 -!- TheRec [~toto@drupal.org/user/146860/view] has quit [Read error: Connection reset by peer] 09:33 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 260 seconds] 09:33 -!- TheRec [~toto@84-75-205-212.dclient.hispeed.ch] has joined #bitcoin-core-dev 09:33 -!- TheRec [~toto@84-75-205-212.dclient.hispeed.ch] has quit [Changing host] 09:33 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev 09:33 -!- mangoicedtea [~mangoiced@c-66-176-217-7.hsd1.fl.comcast.net] has quit [Ping timeout: 265 seconds] 09:39 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 09:39 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/3d16f581538b...0f58d7f3d62f 09:39 < bitcoin-git> bitcoin/master fa44af5 MarcoFalke: travis: Full clone for git subtree check 09:39 < bitcoin-git> bitcoin/master 0f58d7f MarcoFalke: Merge #12405: travis: Full clone for git subtree check... 09:40 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #12405: travis: Full clone for git subtree check (master...Mf1802-travisSubtree) https://github.com/bitcoin/bitcoin/pull/12405 09:44 -!- grafcaps [~haroldbr@104.137.194.255] has joined #bitcoin-core-dev 09:44 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 264 seconds] 09:46 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0f58d7f3d62f...0f0229d0c363 09:46 < bitcoin-git> bitcoin/master fa1436c MarcoFalke: [qa] util: Remove unused sync_chain 09:46 < bitcoin-git> bitcoin/master 0f0229d Wladimir J. van der Laan: Merge #12643: [qa] util: Remove unused sync_chain... 09:46 < bitcoin-git> [bitcoin] laanwj closed pull request #12643: [qa] util: Remove unused sync_chain (master...Mf1803-qaUtilSyncChain) https://github.com/bitcoin/bitcoin/pull/12643 09:47 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 09:51 -!- Samdney [~Samdney@37.58.58.246] has quit [Read error: Connection reset by peer] 09:51 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 240 seconds] 09:53 -!- Samdney [~Samdney@37.58.58.246] has joined #bitcoin-core-dev 09:53 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has joined #bitcoin-core-dev 09:55 -!- ProfMac-2 [~ProfMac@2001:470:b8ac:0:f83f:d9ce:e7c6:cf29] has quit [Ping timeout: 260 seconds] 09:58 -!- ProfMac-2 [~ProfMac@2001:470:b8ac:0:d04d:841a:a130:245f] has joined #bitcoin-core-dev 10:00 < bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/0f0229d0c363...702e8b70bd87 10:00 < bitcoin-git> bitcoin/master 8acd25d MarcoFalke: rpc: Allow typeAny in RPCTypeCheck 10:00 < bitcoin-git> bitcoin/master fa06dfc MarcoFalke: [rpc] createrawtransaction: Accept sorted outputs 10:00 < bitcoin-git> bitcoin/master fac7013 MarcoFalke: rpc: Update createrawtransaction examples 10:01 < bitcoin-git> [bitcoin] laanwj closed pull request #11872: [rpc] createrawtransaction: Accept sorted outputs (master...Mf1712-rpcCreateRawSortedOuts) https://github.com/bitcoin/bitcoin/pull/11872 10:02 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 10:03 -!- mangoicedtea [~mangoiced@2601:583:c201:7520::3] has joined #bitcoin-core-dev 10:06 -!- Cogito_Ergo_Sum [~Myself@athedsl-314680.home.otenet.gr] has joined #bitcoin-core-dev 10:06 -!- Cogito_Ergo_Sum [~Myself@athedsl-314680.home.otenet.gr] has quit [Changing host] 10:06 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has joined #bitcoin-core-dev 10:07 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 256 seconds] 10:10 -!- qrest [~qrestlove@2605:6000:eb4a:ef00:454f:112b:9095:f0ea] has joined #bitcoin-core-dev 10:11 -!- qrestlove [~qrestlove@2605:6000:eb4a:ef00:454f:112b:9095:f0ea] has quit [Ping timeout: 245 seconds] 10:13 -!- Guest13163 [~schmidty@c-98-212-53-76.hsd1.il.comcast.net] has quit [Remote host closed the connection] 10:14 -!- schmidty [~schmidty@c-98-212-53-76.hsd1.il.comcast.net] has joined #bitcoin-core-dev 10:14 -!- schmidty is now known as Guest54850 10:16 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 10:16 < aj> pierre_rochard: that repo was just where i was playing around with a bot that autotags pull requests. https://gist.github.com/ajtowns/d0cf97678dc83efdf3f6cbf7083a35a0 was where i was playing around with autodetecting conflicts 10:17 -!- mangoicedtea [~mangoiced@2601:583:c201:7520::3] has quit [Ping timeout: 252 seconds] 10:19 -!- Guest54850 [~schmidty@c-98-212-53-76.hsd1.il.comcast.net] has quit [Ping timeout: 256 seconds] 10:20 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 260 seconds] 10:22 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Remote host closed the connection] 10:26 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 10:29 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 10:30 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 256 seconds] 10:34 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 260 seconds] 10:38 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 10:40 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/702e8b70bd87...af88094e4f71 10:40 < bitcoin-git> bitcoin/master 029ecac Pieter Wuille: Split up and sanitize CWalletTx serialization 10:40 < bitcoin-git> bitcoin/master 42343c7 Pieter Wuille: Split up and sanitize CAccountingEntry serialization 10:40 < bitcoin-git> bitcoin/master af88094 Wladimir J. van der Laan: Merge #12658: Sanitize some wallet serialization... 10:41 < bitcoin-git> [bitcoin] laanwj closed pull request #12658: Sanitize some wallet serialization (master...201803_crazywalletser) https://github.com/bitcoin/bitcoin/pull/12658 10:44 < mrannanay> wumpus : Could you review #12288 when you're free? 10:44 < gribble> https://github.com/bitcoin/bitcoin/issues/12288 | [WIP][NET] Add NATPMP support. by annanay25 · Pull Request #12288 · bitcoin/bitcoin · GitHub 10:51 < promag> candidate for merge #11041 10:51 < gribble> https://github.com/bitcoin/bitcoin/issues/11041 | Add LookupBlockIndex by promag · Pull Request #11041 · bitcoin/bitcoin · GitHub 10:56 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 11:00 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds] 11:05 < provoostenator> #12666 made me curious: when do we use packages like UniValue from the OS, vs. compiling it from the src dir? And why even bother with the former? 11:05 < gribble> https://github.com/bitcoin/bitcoin/issues/12666 | configure: UniValue 1.0.4 is required for pushKV(, bool) by luke-jr · Pull Request #12666 · bitcoin/bitcoin · GitHub 11:06 < sipa> provoostenator: becaause some people insist on being able to use OS packages 11:06 < provoostenator> Bonus question: how is this different from the Depends system? 11:07 < luke-jr> provoostenator: it is a bad practice to bundle libraries at all 11:07 < sipa> luke-jr: why? 11:07 < sipa> i buy that argument for large libraries that are outside of bitcoin core's development 11:07 < wumpus> mrannanay: will take a look at it again tomorrow 11:08 < luke-jr> sipa: https://wiki.gentoo.org/wiki/Why_not_bundle_dependencies https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Libraries 11:08 < wumpus> for libraries that are part of consensus (secp256k1,leveldb) there's a good reason to bundle it, for leveldb especially as we have some custom patches to it 11:08 < mrannanay> wumpus : Thanks! 11:09 < wumpus> for univalue the case is somewhat weaker, but based on it being a rarely-packaged library 11:09 < wumpus> not bundling it would give people a lot of pain 11:09 < sipa> luke-jr: none of that applies; univalue is effectively developed by us 11:09 < wumpus> finding it, building it, manually installing it. We save that for berkeleydb 4.8 :-) 11:09 < luke-jr> well, if we didn't depend on 1.0.4 specifically now, 1.0.2 is pretty widespreadly packaged 11:09 < wumpus> unilvalue is virtually only used by us 11:10 < wumpus> yes, bundling makes it possible to develop it in parallel 11:10 < wumpus> without having to support tons of combinations 11:10 < sipa> i think the arguments in those documents very much apply to not bundling bdb, boost, glibc, ... 11:12 < bitcoin-git> [bitcoin] laanwj pushed 6 new commits to master: https://github.com/bitcoin/bitcoin/compare/af88094e4f71...d42a4fe5aaae 11:13 < bitcoin-git> bitcoin/master 02de6a6 João Barbosa: Assert cs_main is held when accessing mapBlockIndex 11:13 < bitcoin-git> bitcoin/master c651df8 João Barbosa: Lock cs_main while loading block index in AppInitMain 11:13 < bitcoin-git> bitcoin/master f814a3e João Barbosa: Fix cs_main lock in LoadExternalBlockFile... 11:13 < luke-jr> we're also not the upstream for univalue. jgarzik is. 11:13 < provoostenator> But why aren't univalue, secp256k1, etc part of the Depends system? Maybe there should be a way to build /depends skipping installed packages? 11:13 < bitcoin-git> [bitcoin] laanwj closed pull request #11041: Add LookupBlockIndex (master...2017-08-lookup-block-index) https://github.com/bitcoin/bitcoin/pull/11041 11:13 < luke-jr> provoostenator: good idea 11:13 < luke-jr> (although even if leveldb is installed, we may still prefer to build our own) 11:14 < sipa> provoostenator: because they're subtrees 11:14 < provoostenator> Skipping installed packages if the version is acceptable. 11:14 < provoostenator> sipa: but they could be seperate repos under the bitcoin org? 11:14 < sipa> provoostenator: they are 11:14 < sipa> https://github.com/bitcoin-core/secp256k1 11:14 < wumpus> I'd really prefer not to change this - it works, people are used to it 11:15 < luke-jr> it's probably good enough as is; bumping the required version here and there is no big deal 11:15 < sipa> provoostenator: look up how subtrees work 11:15 < luke-jr> sipa: his point is that using depends would be superior to subtrees 11:15 < sipa> yes, and i disagree with that 11:16 < provoostenator> Subtrees as opposed to submodules? 11:16 < sipa> we want exact control over the source code used for some things 11:16 < luke-jr> sipa: we could have exact control over it with depends too 11:16 < sipa> yes, but we'd lose it for non-depends builds 11:16 < provoostenator> (I've had nothing but headaches dealing with git submodules, so not blaming anyone for not using them) 11:16 < luke-jr> not necessarily 11:16 < sipa> subtrees give us this property always 11:16 < luke-jr> anyhow, unless someone is going to put the work into migrating it over, no point wasting time discussing in depth IMO 11:16 < wumpus> also there is no special incantation needed to check things out 11:16 < wumpus> it's simply in one tree 11:17 < provoostenator> wumpus: I'm fine with not changing it even if it was better :-) 11:17 < wumpus> it's perfect like this IMO 11:19 -!- vicenteH [~user@195.235.96.150] has quit [Ping timeout: 264 seconds] 11:20 < provoostenator> I didn't realize "git subtree" was a command, that's nice. Is there a way to check if it matches the original repo (other than git diff)? 11:23 < sipa> provoostenator: yes, we have a script that does that :) 11:23 < sipa> you need access to the original repo, of course 11:23 < wumpus> ./contrib/devtools/git-subtree-check.sh 11:26 -!- Dizzle [~dizzle@108.171.182.16] has joined #bitcoin-core-dev 11:28 < provoostenator> "git-subtree-check.sh src/univalue" doesn't seem happy, I guess I need to add some hints to check the right fork? 11:28 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 11:30 < sipa> $ git remote add upstream-univalue https://github.com/bitcoin-core/univalue 11:30 < sipa> $ git fetch upstream-univalue 11:30 < sipa> $ contrib/devtools/git-subtree-check.sh src/univalue 11:30 < sipa> GOOD 11:31 < provoostenator> I missed the fetch bit, now it's happy. 11:56 -!- dafunkiz_ [~dafunkizd@174.127.143.202] has joined #bitcoin-core-dev 12:15 -!- schmidty [~schmidty@c-98-212-53-76.hsd1.il.comcast.net] has joined #bitcoin-core-dev 12:15 -!- schmidty is now known as Guest25645 12:19 -!- Guest25645 [~schmidty@c-98-212-53-76.hsd1.il.comcast.net] has quit [Ping timeout: 246 seconds] 12:20 -!- TheRec [~toto@drupal.org/user/146860/view] has quit [Read error: Connection reset by peer] 12:22 -!- TheRec [~toto@84-75-205-212.dclient.hispeed.ch] has joined #bitcoin-core-dev 12:22 -!- TheRec [~toto@84-75-205-212.dclient.hispeed.ch] has quit [Changing host] 12:22 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev 12:31 -!- drizztbsd [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 12:32 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Quit: Leaving] 12:33 < bitcoin-git> [bitcoin] vasild opened pull request #12680: Trivial: Add missing virtual destructor in PeerLogicValidation (master...master-add-missing-vdtor-in-PeerLogicValidation) https://github.com/bitcoin/bitcoin/pull/12680 12:37 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 12:38 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 12:43 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has quit [Remote host closed the connection] 12:44 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has joined #bitcoin-core-dev 12:44 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 12:48 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has quit [Ping timeout: 240 seconds] 12:48 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 12:53 -!- jojeyh [~delphi@2602:306:b8b6:b970:948c:4188:e8be:25e5] has joined #bitcoin-core-dev 13:04 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 13:06 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 13:23 -!- vicenteH [~user@35.233.15.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 13:35 -!- shesek [~shesek@bzq-84-110-235-58.red.bezeqint.net] has joined #bitcoin-core-dev 13:35 -!- shesek [~shesek@bzq-84-110-235-58.red.bezeqint.net] has quit [Changing host] 13:35 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 13:48 -!- dafunkiz_ [~dafunkizd@174.127.143.202] has quit [Quit: probably someone interrupted me] 13:49 < provoostenator> Re #12665 by practicalswift: are these thread safety checks done automatically when I run make, or do I need to configure something? 13:49 < gribble> https://github.com/bitcoin/bitcoin/issues/12665 | Add compile time checking for run time locking assertions by practicalswift · Pull Request #12665 · bitcoin/bitcoin · GitHub 13:55 < provoostenator> Looks like it's checked by default (I did some trial and error sabotage on my local machine). 13:57 < arubi> bip173 lists tc1qw508d6qejxtdg4y5r3zarvary0c5xw7kg3g4ty as being invalid due to "invalid human-readable part", is it just that "tc" is not one of "bc", "tb", or "bcrt" or is there anything else to it? seems that apart from that it does encode a valid p2wpkh 13:58 < sipa> arubi: yup 13:58 < arubi> cool, cheers 13:58 < sipa> invalid hrp 13:58 < arubi> right, in my mind hrp could be anything, but I see why it's not a "segwit address" 13:58 < sipa> BIP173 only specifies bc and tb, so anything else is invalid 13:59 < Chris_Stewart_5> arubi: I believe the lightning people repurpose it. Don't know how the author feels about that usage though :-) 13:59 < sipa> but it's certainly valid bech32... just not a valid segwit address 13:59 < sipa> Chris_Stewart_5: bech32 is designed to be generally useful :) 13:59 < arubi> right, so as long as some implementation keeps to its own hrp, we should all be fine 13:59 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 13:59 < sipa> (though they violate the spec by exceeding 90 characters) 14:01 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 14:03 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has joined #bitcoin-core-dev 14:08 < aj> sipa: did you get a chance to read the mail i sent about soft-fork compatible sig aggregation? see any obvious problems, or worth sending to bitcoin-dev do you think? 14:08 < sipa> aj: i haven't yet 14:13 < bitcoin-git> [bitcoin] MarcoFalke pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/d42a4fe5aaae...0630974647da 14:13 < bitcoin-git> bitcoin/master 54b8c58 Conor Scott: [test] Fix nits leftover from 11771... 14:13 < bitcoin-git> bitcoin/master 2b7064e John Newbery: [tests] Fix flake8 warnings in invalidblockrequest 14:13 < bitcoin-git> bitcoin/master e97b113 John Newbery: [tests] Change invalidblockrequest to use BitcoinTestFramework... 14:13 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #11772: [tests] Change invalidblockrequest to use BitcoinTestFramework (master...refactor_invalidblockrequest) https://github.com/bitcoin/bitcoin/pull/11772 14:14 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 14:15 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Remote host closed the connection] 14:16 -!- schmidty [~schmidty@c-98-212-53-76.hsd1.il.comcast.net] has joined #bitcoin-core-dev 14:16 -!- schmidty is now known as Guest51427 14:16 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 14:21 -!- Guest51427 [~schmidty@c-98-212-53-76.hsd1.il.comcast.net] has quit [Ping timeout: 248 seconds] 14:27 -!- promag_ [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 14:30 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has quit [] 14:30 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 260 seconds] 14:31 -!- ken2812221 [~User@133-203.dorm.ncu.edu.tw] has quit [Ping timeout: 260 seconds] 14:31 -!- ken2812221 [~User@133-203.dorm.ncu.edu.tw] has joined #bitcoin-core-dev 14:47 -!- rex_4539 [~textual@2a02:587:3513:b600:34e4:37cd:df1a:5987] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 14:53 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 246 seconds] 15:01 -!- Murch [~murch@96.74.120.81] has quit [Quit: Snoozing.] 15:02 -!- Murch [~murch@96.74.120.81] has joined #bitcoin-core-dev 15:03 -!- mrannanay [uid222022@gateway/web/irccloud.com/x-bbaazsnlqjmrmrmm] has quit [Quit: Connection closed for inactivity] 15:09 -!- schmidty [~schmidty@c-98-212-53-76.hsd1.il.comcast.net] has joined #bitcoin-core-dev 15:09 -!- schmidty is now known as Guest42527 15:10 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has quit [Remote host closed the connection] 15:11 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has joined #bitcoin-core-dev 15:11 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has quit [Remote host closed the connection] 15:11 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has joined #bitcoin-core-dev 15:12 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has quit [Remote host closed the connection] 15:12 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has joined #bitcoin-core-dev 15:12 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has quit [Remote host closed the connection] 15:13 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has joined #bitcoin-core-dev 15:13 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has quit [Remote host closed the connection] 15:14 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has joined #bitcoin-core-dev 15:14 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has quit [Remote host closed the connection] 15:18 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 260 seconds] 15:22 -!- Guest42527 [~schmidty@c-98-212-53-76.hsd1.il.comcast.net] has quit [Remote host closed the connection] 15:36 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev 15:44 -!- kobrabyte [5234179b@gateway/web/freenode/ip.82.52.23.155] has joined #bitcoin-core-dev 15:44 < kobrabyte> hello all 15:44 < bitcoin-git> [bitcoin] ryanofsky opened pull request #12681: Fix ComputeTimeSmart test failure with -DDEBUG_LOCKORDER (master...pr/locksmart) https://github.com/bitcoin/bitcoin/pull/12681 15:45 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #12682: travis: Clone depth 1 unless $CHECK_DOC (master...Mf1803-travisDepth1) https://github.com/bitcoin/bitcoin/pull/12682 15:47 -!- kobrabyte [5234179b@gateway/web/freenode/ip.82.52.23.155] has quit [Client Quit] 15:55 -!- nuke_bloodaxe [~davidck@101.100.144.170] has quit [Quit: Konversation terminated!] 15:55 -!- mangoicedtea [~mangoiced@2601:583:c201:7520::3] has joined #bitcoin-core-dev 15:56 -!- grafcaps [~haroldbr@104.137.194.255] has quit [Ping timeout: 264 seconds] 16:00 -!- Aaronvan_ is now known as AaronvanW 16:05 -!- Dizzle [~dizzle@108.171.182.16] has quit [Quit: Leaving...] 16:10 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 16:10 -!- Murch [~murch@96.74.120.81] has quit [Quit: Snoozing.] 16:13 -!- jimbouki [~jimbouki@98.227.189.229] has joined #bitcoin-core-dev 16:14 -!- grafcaps [~haroldbr@50.90.83.229] has joined #bitcoin-core-dev 16:19 -!- jimbouki [~jimbouki@98.227.189.229] has quit [] 16:19 -!- jimbouki [~jimbouki@98.227.189.229] has joined #bitcoin-core-dev 16:19 -!- schmidty [~schmidty@c-98-212-53-76.hsd1.il.comcast.net] has joined #bitcoin-core-dev 16:19 -!- schmidty [~schmidty@c-98-212-53-76.hsd1.il.comcast.net] has quit [Remote host closed the connection] 16:20 -!- schmidty [~schmidty@c-98-212-53-76.hsd1.il.comcast.net] has joined #bitcoin-core-dev 16:20 -!- schmidty is now known as Guest55632 16:21 -!- jimbouki [~jimbouki@98.227.189.229] has quit [Client Quit] 16:22 -!- jimbouki [~jimbouki@98.227.189.229] has joined #bitcoin-core-dev 16:23 -!- Murch [~murch@96.74.120.81] has joined #bitcoin-core-dev 16:24 -!- Guest55632 [~schmidty@c-98-212-53-76.hsd1.il.comcast.net] has quit [Ping timeout: 246 seconds] 16:29 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 264 seconds] 16:32 -!- jimbouki [~jimbouki@98.227.189.229] has quit [Quit: goodbye friends] 16:33 -!- jimbouki [~jimbouki@98.227.189.229] has joined #bitcoin-core-dev 16:38 -!- jimbouki [~jimbouki@98.227.189.229] has quit [Remote host closed the connection] 16:43 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev 17:00 -!- weez17 [~isaac@unaffiliated/weez17] has quit [Read error: Connection reset by peer] 17:00 -!- weez17 [~isaac@unaffiliated/weez17] has joined #bitcoin-core-dev 17:06 -!- dafunkiz_ [~dafunkizd@174.127.143.202] has joined #bitcoin-core-dev 17:15 -!- mangoicedtea [~mangoiced@2601:583:c201:7520::3] has quit [Ping timeout: 240 seconds] 17:17 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0630974647da...18462960c0f1 17:17 < bitcoin-git> bitcoin/master 33eb907 Russell Yanofsky: Fix ComputeTimeSmart test failure with -DDEBUG_LOCKORDER... 17:17 < bitcoin-git> bitcoin/master 1846296 MarcoFalke: Merge #12681: Fix ComputeTimeSmart test failure with -DDEBUG_LOCKORDER... 17:18 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #12681: Fix ComputeTimeSmart test failure with -DDEBUG_LOCKORDER (master...pr/locksmart) https://github.com/bitcoin/bitcoin/pull/12681 17:19 < bitcoin-git> [bitcoin] sipa opened pull request #12683: Fix more constness violations in serialization code (master...201803_moreser) https://github.com/bitcoin/bitcoin/pull/12683 17:22 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 240 seconds] 17:28 -!- jimbouki [~jimbouki@98.227.189.229] has joined #bitcoin-core-dev 17:28 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 17:29 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has quit [Ping timeout: 240 seconds] 17:31 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has joined #bitcoin-core-dev 17:33 -!- mangoicedtea [~mangoiced@2601:583:c201:7520::3] has joined #bitcoin-core-dev 17:35 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 17:39 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 240 seconds] 17:41 -!- jimbouki [~jimbouki@98.227.189.229] has quit [Remote host closed the connection] 17:52 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Quit: WeeChat 1.9.1] 17:54 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-dsjtpwndxysvveny] has joined #bitcoin-core-dev 17:54 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 17:54 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Client Quit] 17:54 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 17:54 -!- jimbouki [~jimbouki@98.227.189.229] has joined #bitcoin-core-dev 17:59 -!- mangoicedtea [~mangoiced@2601:583:c201:7520::3] has quit [Ping timeout: 245 seconds] 17:59 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Quit: WeeChat 2.0] 18:00 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 18:01 -!- CapitanRetardo [~CapitanRe@ipbcc23e7c.dynamic.kabel-deutschland.de] has quit [Ping timeout: 260 seconds] 18:01 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 18:14 -!- go1111111 [~go1111111@199.231.240.191] has quit [Ping timeout: 264 seconds] 18:14 -!- dafunkiz_ [~dafunkizd@174.127.143.202] has quit [Quit: probably someone interrupted me] 18:14 -!- EpicBaldGuy [~EpicBaldG@2601:18d:77f:6dd8::3936] has quit [Remote host closed the connection] 18:20 -!- schmidty [~schmidty@c-98-212-53-76.hsd1.il.comcast.net] has joined #bitcoin-core-dev 18:21 -!- schmidty is now known as Guest75173 18:22 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 260 seconds] 18:22 -!- dafunkiz_ [~dafunkizd@174.127.131.154] has joined #bitcoin-core-dev 18:23 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has quit [Ping timeout: 246 seconds] 18:25 -!- Guest75173 [~schmidty@c-98-212-53-76.hsd1.il.comcast.net] has quit [Ping timeout: 264 seconds] 18:28 -!- jimbouki [~jimbouki@98.227.189.229] has quit [Remote host closed the connection] 18:28 -!- Samdney [~Samdney@37.58.58.246] has quit [Quit: Verlassend] 18:28 -!- jimbouki [~jimbouki@98.227.189.229] has joined #bitcoin-core-dev 18:29 -!- tied2chainz [6364ddb3@gateway/web/freenode/ip.99.100.221.179] has joined #bitcoin-core-dev 18:30 < tied2chainz> hi 18:30 < tied2chainz> just have a really quick question about version 16. 18:31 -!- jimbouki_ [~jimbouki@98.227.189.229] has joined #bitcoin-core-dev 18:31 -!- BashCo_ [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 18:32 -!- jimbouki [~jimbouki@98.227.189.229] has quit [Read error: Connection reset by peer] 18:32 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 240 seconds] 18:32 < sipa> tied2chainz: shoot 18:33 < sipa> (and generally just ask, don't ask to ask) 18:34 < Randolf> (Slow questions are okay too.) 18:34 -!- dafunkiz_ [~dafunkizd@174.127.131.154] has quit [Read error: Connection reset by peer] 18:35 < tied2chainz> wanted to know can I also lookup transactions outside of send and receive transactions. 18:35 < sipa> no 18:35 < tied2chainz> only transactions that I've received or sent through my wallet 18:36 < sipa> unless you enable the transaction index (run with -txindex, or put txindex=1 in bitcoin.conf; that will enable the getrawtransaction txid RPC which works for all transactions, not just your own) 18:36 < sipa> it will require a full rebuild of the database though, and slows things down significantly 18:37 < tied2chainz> yeah thanks for the heads 18:37 < eklitzke> interesting, somehow i corrupted my chainstate directory 18:37 < tied2chainz> thanks for the heads up 18:38 < sipa> eklitzke: what did you do? 18:40 < kallewoof> tied2chainz: You can look them up if you know the block hash they're in. 18:41 -!- Giszmo [~leo@ip-45-233.219.201.nextelmovil.cl] has joined #bitcoin-core-dev 18:41 < kallewoof> tied2chainz: Even without -txindex. 18:41 < eklitzke> https://paste.fedoraproject.org/paste/QsExxEOQwQOAGqT1rvPkAw 18:41 < eklitzke> it looks like it shut down normally 18:41 < eklitzke> and then the next time i tried to start it 18:42 < eklitzke> corrupted database 18:42 -!- pyericz [~pyericz@117.30.146.190] has joined #bitcoin-core-dev 18:43 < sipa> eklitzke: wow, with a clean shutdown? :S 18:43 < eklitzke> this is actually on v0.16.0, not from my branches 18:43 < eklitzke> hmm 18:44 < eklitzke> interesting, well i had been asking users if they could give me corrupted database files, looks like i got what i was asking for 18:44 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Quit: WeeChat 2.0] 18:45 -!- pyericz [~pyericz@117.30.146.190] has quit [Client Quit] 18:45 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 18:45 -!- pyericz [~pyericz@117.30.146.190] has joined #bitcoin-core-dev 18:48 < kallewoof> Am I right that signmessage leaks the public key of in the resulting signature? 18:49 < kallewoof> s/leaks/exposes/ I guess. 18:49 -!- pyericz [~pyericz@117.30.146.190] has quit [Client Quit] 18:50 -!- pyericz [~textual@172.96.230.26.16clouds.com] has joined #bitcoin-core-dev 18:51 -!- pyericz [~textual@172.96.230.26.16clouds.com] has quit [Remote host closed the connection] 18:51 < eklitzke> actually i remember now what i was doing, the last thing i had been doing with this was running my python utxo scanning script on the data directory 18:51 < eklitzke> s/data directory/chainstate directory/ 18:51 < eklitzke> which uses the python leveldb bindings 18:52 < eklitzke> i thought i had the daemon stopped but i guess i could have had it running 18:52 < eklitzke> hopefully i can reproduce 18:55 -!- tecneecs [~tecneecs@ool-44c1c00f.dyn.optonline.net] has joined #bitcoin-core-dev 18:55 < tecneecs> sup bitcoin? 18:56 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Quit: WeeChat 2.0] 18:56 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 18:59 -!- pyericz [~pyericz@117.30.146.190] has joined #bitcoin-core-dev 19:01 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 19:02 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Quit: WeeChat 2.0] 19:03 -!- LeMiner [LeMiner@unaffiliated/leminer] has quit [Read error: Connection reset by peer] 19:03 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 19:03 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 19:03 -!- pyericz [~pyericz@117.30.146.190] has quit [Client Quit] 19:03 -!- jimbouki_ [~jimbouki@98.227.189.229] has quit [Quit: goodbye friends] 19:03 -!- pyericz [~textual@117.30.146.190] has joined #bitcoin-core-dev 19:04 -!- jimbouki [~jimbouki@98.227.189.229] has joined #bitcoin-core-dev 19:04 -!- jimbouki [~jimbouki@98.227.189.229] has quit [Client Quit] 19:06 < sipa> kallewoof: every ECDSA signature leaks the pubkey (almost) 19:09 -!- pyericz [~textual@117.30.146.190] has quit [Quit: Textual IRC Client: www.textualapp.com] 19:10 -!- pyericz [~pyericz@117.30.146.190] has joined #bitcoin-core-dev 19:14 -!- dabura667 [~dabura667@153.142.228.110] has joined #bitcoin-core-dev 19:16 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 19:17 < bitcoin-git> [bitcoin] sipa pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/18462960c0f1...6acd8700bc0e 19:17 < bitcoin-git> bitcoin/master a128bdc Russell Yanofsky: [wallet] Construct CWalletTx objects in CommitTransaction... 19:17 < bitcoin-git> bitcoin/master b4bc32a Russell Yanofsky: [wallet] Get rid of CWalletTx default constructor... 19:17 < bitcoin-git> bitcoin/master 6acd870 Pieter Wuille: Merge #9680: Unify CWalletTx construction... 19:17 < kallewoof> sipa: Well, it's sorta like spending an UTXO vs handing out the pubkey for its PKH. One seems worse than the other (though only a little). 19:18 -!- tied2chainz [6364ddb3@gateway/web/freenode/ip.99.100.221.179] has quit [Quit: Page closed] 19:18 < sipa> kallewoof: but regardless, you can't create a signature without revealing the public key 19:20 < kallewoof> Yeah, I was initially very confused about how verifymessage could pull it off with only an address, until I realized the signature had a recoverable pubkey in it. 19:21 < kallewoof> It struck me that people may not realize they are revealing the pubkey when they signmessage a utxo. Clearly as you say, you need the pubkey to verify the sig. 19:22 < kallewoof> Perhaps it doesn't really matter that you show the pubkey (long) before spending. 19:27 < luke-jr> kallewoof: hopefully when someone gets around to replacing signmessage, it can be MAST-based with a separate key for messages 19:32 < kallewoof> luke-jr: Interesting. I'll have to think about how that would work. 19:32 < sipa> kallewoof: well a decent replacement for signmessage would be something that just uses script 19:33 < sipa> (but signs something else than a tx) 19:33 < sipa> that would automatically support any kind of output type 19:41 -!- jimbouki [~jimbouki@98.227.189.229] has joined #bitcoin-core-dev 19:42 < kallewoof> sipa: That makes sense, yeah. 19:45 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 19:46 < meshcollider> Wasn't someone already working on a BIP draft for an improved signmessage, or am I imagining things 19:46 -!- jimbouki [~jimbouki@98.227.189.229] has quit [Remote host closed the connection] 19:46 < kallewoof> sipa: Presumably it would sign H(addr||message). Not sure if addr is strictly necessary though. 19:48 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Client Quit] 19:48 -!- kryptopraxis [~kryptopra@p200300C853CAD500AC5D63D2F7E633A8.dip0.t-ipconnect.de] has quit [Ping timeout: 256 seconds] 19:48 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 19:49 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 240 seconds] 19:59 < luke-jr> meshcollider: at one point, someone was talking about it at least 20:00 -!- kryptopraxis [~kryptopra@p200300C853C52700AC5D63D2F7E633A8.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 20:07 < sipa> kallewoof: yup, this is the way to fix it 20:13 -!- mrjenkins [bbb1bdee@gateway/web/freenode/ip.187.177.189.238] has joined #bitcoin-core-dev 20:13 < mrjenkins> hello! 20:14 < mrjenkins> why does github repo say that the build is failing? 20:14 < mrjenkins> does the build is really failing? 20:16 -!- jimbouki [~jimbouki@98.227.189.229] has joined #bitcoin-core-dev 20:18 -!- Murch [~murch@96.74.120.81] has quit [Quit: Snoozing.] 20:21 -!- schmidty [~schmidty@c-98-212-53-76.hsd1.il.comcast.net] has joined #bitcoin-core-dev 20:22 -!- pyericz [~pyericz@117.30.146.190] has quit [Remote host closed the connection] 20:22 -!- schmidty is now known as Guest3864 20:22 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has joined #bitcoin-core-dev 20:24 -!- pyericz [~pyericz@117.30.146.190] has joined #bitcoin-core-dev 20:26 -!- Guest3864 [~schmidty@c-98-212-53-76.hsd1.il.comcast.net] has quit [Ping timeout: 246 seconds] 20:26 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has quit [Ping timeout: 240 seconds] 20:31 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 20:32 -!- jimbouki [~jimbouki@98.227.189.229] has quit [Remote host closed the connection] 20:32 -!- mrjenkins [bbb1bdee@gateway/web/freenode/ip.187.177.189.238] has quit [Quit: Page closed] 20:35 -!- Giszmo [~leo@ip-45-233.219.201.nextelmovil.cl] has quit [Ping timeout: 260 seconds] 20:44 -!- mangoicedtea [~mangoiced@c-66-176-217-7.hsd1.fl.comcast.net] has joined #bitcoin-core-dev 20:49 -!- jimbouki [~jimbouki@98.227.189.229] has joined #bitcoin-core-dev 21:12 -!- User__ [~User@133-203.dorm.ncu.edu.tw] has joined #bitcoin-core-dev 21:14 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 21:15 -!- ken2812221 [~User@133-203.dorm.ncu.edu.tw] has quit [Ping timeout: 240 seconds] 21:15 -!- pyericz [~pyericz@117.30.146.190] has quit [Remote host closed the connection] 21:16 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 21:16 -!- jimbouki_ [~jimbouki@98.227.189.229] has joined #bitcoin-core-dev 21:16 -!- jimbouki [~jimbouki@98.227.189.229] has quit [Read error: Connection reset by peer] 21:21 -!- pyericz [~pyericz@117.30.146.190] has joined #bitcoin-core-dev 21:23 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has joined #bitcoin-core-dev 21:23 -!- jimbouki_ [~jimbouki@98.227.189.229] has quit [Remote host closed the connection] 21:24 -!- rex_4539 [~textual@athedsl-128662.home.otenet.gr] has joined #bitcoin-core-dev 21:24 -!- jimbouki [~jimbouki@98.227.189.229] has joined #bitcoin-core-dev 21:26 -!- pyericz [~pyericz@117.30.146.190] has quit [Ping timeout: 248 seconds] 21:27 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has quit [Ping timeout: 240 seconds] 21:42 -!- rex_4539 [~textual@athedsl-128662.home.otenet.gr] has quit [Read error: Connection reset by peer] 21:49 -!- tecneecs [~tecneecs@ool-44c1c00f.dyn.optonline.net] has quit [Quit: My Mac Pro has gone to sleep. ZZZzzz…] 21:55 -!- jimbouki [~jimbouki@98.227.189.229] has quit [Remote host closed the connection] 21:57 -!- jimbouki [~jimbouki@98.227.189.229] has joined #bitcoin-core-dev 22:01 -!- jimbouki [~jimbouki@98.227.189.229] has quit [Ping timeout: 240 seconds] 22:02 -!- harryTrout [~mangoiced@2601:583:c201:7520::3] has joined #bitcoin-core-dev 22:04 -!- mangoicedtea [~mangoiced@c-66-176-217-7.hsd1.fl.comcast.net] has quit [Ping timeout: 260 seconds] 22:09 -!- grafcaps [~haroldbr@50.90.83.229] has quit [Ping timeout: 240 seconds] 22:10 < pierre_rochard> mrjenkins https://github.com/bitcoin/bitcoin shows the build is passing 22:10 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has joined #bitcoin-core-dev 22:23 -!- schmidty [~schmidty@c-98-212-53-76.hsd1.il.comcast.net] has joined #bitcoin-core-dev 22:23 -!- schmidty is now known as Guest37915 22:24 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has joined #bitcoin-core-dev 22:27 -!- Guest37915 [~schmidty@c-98-212-53-76.hsd1.il.comcast.net] has quit [Ping timeout: 264 seconds] 22:28 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has quit [Ping timeout: 240 seconds] 22:33 -!- grafcaps [~haroldbr@50.90.83.229] has joined #bitcoin-core-dev 22:37 -!- pyericz [~pyericz@117.30.212.207] has joined #bitcoin-core-dev 22:38 -!- grafcaps [~haroldbr@50.90.83.229] has quit [Ping timeout: 248 seconds] 22:46 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has quit [Quit: probably someone interrupted me] 23:07 -!- harryTrout [~mangoiced@2601:583:c201:7520::3] has left #bitcoin-core-dev ["Leaving"] 23:13 -!- pyericz [~pyericz@117.30.212.207] has quit [Remote host closed the connection] 23:14 -!- pyericz [~pyericz@117.30.146.190] has joined #bitcoin-core-dev 23:23 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 23:24 -!- pyericz [~pyericz@117.30.146.190] has quit [] 23:24 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 23:24 -!- pyericz [~pyericz@117.30.146.190] has joined #bitcoin-core-dev 23:25 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has joined #bitcoin-core-dev 23:29 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has quit [Ping timeout: 240 seconds] 23:31 -!- jimbouki [~jimbouki@98.227.189.229] has joined #bitcoin-core-dev 23:35 -!- jimbouki [~jimbouki@98.227.189.229] has quit [Ping timeout: 246 seconds] 23:42 -!- jimbouki [~jimbouki@98.227.189.229] has joined #bitcoin-core-dev 23:43 -!- sanada` [~bitktn@36-2-119-80.chiba.ap.gmo-isp.jp] has joined #bitcoin-core-dev 23:45 -!- pyericz_ [~pyericz@117.30.146.190] has joined #bitcoin-core-dev 23:45 -!- sanada [~bitktn@36-2-119-80.chiba.ap.gmo-isp.jp] has quit [Ping timeout: 248 seconds] 23:46 -!- pyericz [~pyericz@117.30.146.190] has quit [Ping timeout: 248 seconds] 23:46 -!- jimbouki [~jimbouki@98.227.189.229] has quit [Ping timeout: 240 seconds] 23:56 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev