--- Day changed Wed Mar 14 2018 00:05 < fanquake> If you'd already looked at a PR 1 month ago; why wait until it's been squashed, rebased and has 3 ACKs to suddenly start nit-picking it to shreds? 00:16 -!- User__ [~User@133-203.dorm.ncu.edu.tw] has quit [Ping timeout: 240 seconds] 00:17 -!- User__ [~User@133-203.dorm.ncu.edu.tw] has joined #bitcoin-core-dev 00:21 < sipa> fanquake: what PR are you referring to? 00:22 < eklitzke> sipa: for #12683 did you do this manually or have a tool identify the temporary references? 00:22 < gribble> https://github.com/bitcoin/bitcoin/issues/12683 | Fix more constness violations in serialization code by sipa · Pull Request #12683 · bitcoin/bitcoin · GitHub 00:22 < eklitzke> this is an interesting change 00:24 < sipa> eklitzke: there are only 2 dozen calls of REF, some are there as arguments to one of the wrappers (which aren't fixed yet), and some are around the wrappers (which are fixed now) 00:24 < sipa> it's quite mechanical 00:24 -!- schmidty [~schmidty@c-98-212-53-76.hsd1.il.comcast.net] has joined #bitcoin-core-dev 00:24 -!- schmidty is now known as Guest10494 00:25 < sipa> eklitzke: #10785 has many more things like this 00:25 < gribble> https://github.com/bitcoin/bitcoin/issues/10785 | Serialization improvements by sipa · Pull Request #10785 · bitcoin/bitcoin · GitHub 00:25 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has joined #bitcoin-core-dev 00:25 < eklitzke> neat, i'll take a look at that too 00:27 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 00:28 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Remote host closed the connection] 00:28 -!- Guest10494 [~schmidty@c-98-212-53-76.hsd1.il.comcast.net] has quit [Ping timeout: 256 seconds] 00:28 -!- grafcaps [~haroldbr@50.90.83.229] has joined #bitcoin-core-dev 00:29 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 00:30 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has quit [Ping timeout: 240 seconds] 00:34 -!- grafcaps [~haroldbr@50.90.83.229] has quit [Ping timeout: 256 seconds] 00:34 < kallewoof> fanquake: Don't know if you're referring to me, but I may be guilty of doing that. I'll try to think of whether it's worth it with the amount of ACKs for current state in the future. 00:50 -!- CapitanRetardo [~CapitanRe@ipbcc23e7c.dynamic.kabel-deutschland.de] has joined #bitcoin-core-dev 00:51 -!- jimbouki [~jimbouki@98.227.189.229] has joined #bitcoin-core-dev 00:56 -!- jimbouki [~jimbouki@98.227.189.229] has quit [Ping timeout: 264 seconds] 01:10 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 01:15 -!- pyericz_ [~pyericz@117.30.146.190] has quit [] 01:17 -!- pyericz [~pyericz@117.30.146.190] has joined #bitcoin-core-dev 01:18 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:22 -!- drizztbsd [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:23 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 264 seconds] 01:25 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has quit [Remote host closed the connection] 01:26 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has joined #bitcoin-core-dev 01:29 -!- promag_ [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 01:30 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 01:30 -!- Bethany47Braun [~Bethany47@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 240 seconds] 01:30 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has quit [Ping timeout: 240 seconds] 01:34 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 248 seconds] 01:39 -!- Kayla75Wunsch [~Kayla75Wu@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 01:57 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 02:03 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 02:04 -!- jimbouki [~jimbouki@98.227.189.229] has joined #bitcoin-core-dev 02:08 -!- jimbouki [~jimbouki@98.227.189.229] has quit [Ping timeout: 246 seconds] 02:14 < pierre_rochard> achow101: I’m taking a look at #12375 - do you have a fix in the works? I just implemented Akio’s solution and it works, though I’d like to do more research before letting a platform-specific issue add what feels like cruft. 02:14 < gribble> https://github.com/bitcoin/bitcoin/issues/12375 | wallet_encryption.py fails on macos · Issue #12375 · bitcoin/bitcoin · GitHub 02:15 -!- adiabat [~adiabat@45.63.20.152] has quit [Ping timeout: 265 seconds] 02:24 < bitcoin-git> [bitcoin] bill-walker closed pull request #12599: [gui] Use base58 script hash address as example (master...master) https://github.com/bitcoin/bitcoin/pull/12599 02:24 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Remote host closed the connection] 02:25 -!- schmidty [~schmidty@c-98-212-53-76.hsd1.il.comcast.net] has joined #bitcoin-core-dev 02:25 -!- schmidty is now known as Guest44473 02:30 -!- Guest44473 [~schmidty@c-98-212-53-76.hsd1.il.comcast.net] has quit [Ping timeout: 256 seconds] 02:30 -!- adiabat [~adiabat@45.63.20.152] has joined #bitcoin-core-dev 02:31 -!- grafcaps [~haroldbr@50.90.83.229] has joined #bitcoin-core-dev 02:34 < bitcoin-git> [bitcoin] bill-walker opened pull request #12685: [gui] script addresses for sending, not signing (master...master) https://github.com/bitcoin/bitcoin/pull/12685 02:36 -!- grafcaps [~haroldbr@50.90.83.229] has quit [Ping timeout: 246 seconds] 02:37 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 02:38 -!- CapitanRetardo [~CapitanRe@ipbcc23e7c.dynamic.kabel-deutschland.de] has quit [Ping timeout: 240 seconds] 02:47 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6acd8700bc0e...c6fc6656299b 02:47 < bitcoin-git> bitcoin/master 2b3ea39 Vasil Dimov: Polish interfaces around PeerLogicValidation... 02:47 < bitcoin-git> bitcoin/master c6fc665 Wladimir J. van der Laan: Merge #12680: Add missing virtual destructor in PeerLogicValidation... 02:48 < bitcoin-git> [bitcoin] laanwj closed pull request #12680: Add missing virtual destructor in PeerLogicValidation (master...master-add-missing-vdtor-in-PeerLogicValidation) https://github.com/bitcoin/bitcoin/pull/12680 02:49 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 03:01 -!- zarez [~Thunderbi@fs-93-93-44-38.fullsave.info] has joined #bitcoin-core-dev 03:04 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 03:05 -!- CapitanRetardo [~CapitanRe@95-130-162-239.hsi.glasfaser-ostbayern.de] has joined #bitcoin-core-dev 03:07 -!- CapitanRetardo [~CapitanRe@95-130-162-239.hsi.glasfaser-ostbayern.de] has quit [Client Quit] 03:07 -!- CapitanRetardo [~CapitanRe@95-130-162-239.hsi.glasfaser-ostbayern.de] has joined #bitcoin-core-dev 03:08 -!- CapitanRetardo [~CapitanRe@95-130-162-239.hsi.glasfaser-ostbayern.de] has quit [Client Quit] 03:09 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c6fc6656299b...9f04c8e23118 03:09 < bitcoin-git> bitcoin/master fa79016 MarcoFalke: travis: Clone depth 1 unless $CHECK_DOC 03:09 < bitcoin-git> bitcoin/master 9f04c8e Wladimir J. van der Laan: Merge #12682: travis: Clone depth 1 unless $CHECK_DOC... 03:09 -!- CapitanRetardo [~CapitanRe@95-130-162-239.hsi.glasfaser-ostbayern.de] has joined #bitcoin-core-dev 03:09 -!- CapitanRetardo [~CapitanRe@95-130-162-239.hsi.glasfaser-ostbayern.de] has quit [Client Quit] 03:09 < bitcoin-git> [bitcoin] laanwj closed pull request #12682: travis: Clone depth 1 unless $CHECK_DOC (master...Mf1803-travisDepth1) https://github.com/bitcoin/bitcoin/pull/12682 03:10 -!- CapitanRetardo [~CapitanRe@95-130-162-239.hsi.glasfaser-ostbayern.de] has joined #bitcoin-core-dev 03:11 -!- CapitanRetardo [~CapitanRe@95-130-162-239.hsi.glasfaser-ostbayern.de] has quit [Client Quit] 03:12 -!- jimbouki [~jimbouki@98.227.189.229] has joined #bitcoin-core-dev 03:16 < wumpus> I'm confused re: 12685 03:16 -!- Megumiin [~Megumiin@unaffiliated/megumiin] has quit [Ping timeout: 256 seconds] 03:16 < wumpus> I don't remember the dummy address change getting merged 03:17 -!- jimbouki [~jimbouki@98.227.189.229] has quit [Ping timeout: 248 seconds] 03:17 -!- CapitanRetardo [~CapitanRe@95-130-162-239.hsi.glasfaser-ostbayern.de] has joined #bitcoin-core-dev 03:17 -!- Megumiin [~Megumiin@unaffiliated/megumiin] has joined #bitcoin-core-dev 03:17 < wumpus> oh it wasn't (#12599) 03:18 < gribble> https://github.com/bitcoin/bitcoin/issues/12599 | [gui] Use base58 script hash address as example by bill-walker · Pull Request #12599 · bitcoin/bitcoin · GitHub 03:19 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 03:26 -!- CapitanRetardo [~CapitanRe@95-130-162-239.hsi.glasfaser-ostbayern.de] has quit [Quit: WeeChat 2.0.1] 03:26 -!- CapitanRetardo [~CapitanRe@95-130-162-239.hsi.glasfaser-ostbayern.de] has joined #bitcoin-core-dev 03:27 -!- drizztbsd [~tredaelli@redhat/timothy] has quit [Ping timeout: 240 seconds] 03:27 -!- drizztbsd [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 03:27 -!- drizztbsd is now known as timothy 03:32 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Remote host closed the connection] 03:35 -!- drizztbsd [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 03:36 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 268 seconds] 03:42 < bitcoin-git> [bitcoin] practicalswift opened pull request #12686: travis: Generate a trap for signed arithmetic overflows (enable -ftrapv) (master...trapv) https://github.com/bitcoin/bitcoin/pull/12686 03:43 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 03:51 -!- drizztbsd is now known as timothy 03:56 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Remote host closed the connection] 04:04 -!- User__ is now known as ken2812221 04:04 -!- ken2812221 [~User@133-203.dorm.ncu.edu.tw] has quit [Quit: Leaving] 04:04 -!- ken2812221 [~User@133-203.dorm.ncu.edu.tw] has joined #bitcoin-core-dev 04:08 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 04:23 -!- opdenkamp [~opdenkamp@kodi/staff/dushmaniac] has quit [Ping timeout: 276 seconds] 04:26 -!- schmidty [~schmidty@c-98-212-53-76.hsd1.il.comcast.net] has joined #bitcoin-core-dev 04:27 -!- schmidty is now known as Guest98035 04:28 -!- harrymm [~harrymm@104.207.83.64] has joined #bitcoin-core-dev 04:29 -!- opdenkamp [~opdenkamp@kodi/staff/dushmaniac] has joined #bitcoin-core-dev 04:30 -!- Guest98035 [~schmidty@c-98-212-53-76.hsd1.il.comcast.net] has quit [Ping timeout: 246 seconds] 04:37 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Remote host closed the connection] 04:47 -!- pyericz [~pyericz@117.30.146.190] has quit [Quit: This computer has gone to sleep] 04:49 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 04:53 -!- Kayla75Wunsch [~Kayla75Wu@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 256 seconds] 04:56 -!- jimbouki [~jimbouki@98.227.189.229] has joined #bitcoin-core-dev 04:57 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Remote host closed the connection] 04:57 -!- dabura667 [~dabura667@153.142.228.110] has quit [Remote host closed the connection] 04:57 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 05:00 -!- Samdney [~Samdney@178.162.209.136] has joined #bitcoin-core-dev 05:01 -!- jimbouki [~jimbouki@98.227.189.229] has quit [Ping timeout: 246 seconds] 05:02 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 264 seconds] 05:02 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 05:05 -!- mrannanay [uid222022@gateway/web/irccloud.com/x-xsvwudtrcaxztnnn] has joined #bitcoin-core-dev 05:06 -!- CapitanRetardo [~CapitanRe@95-130-162-239.hsi.glasfaser-ostbayern.de] has quit [Ping timeout: 264 seconds] 05:07 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 05:07 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 05:08 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 05:11 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 248 seconds] 05:14 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 05:14 -!- grafcaps [~haroldbr@50.90.83.229] has joined #bitcoin-core-dev 05:14 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Remote host closed the connection] 05:15 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 05:17 -!- opdenkamp [~opdenkamp@kodi/staff/dushmaniac] has quit [Ping timeout: 240 seconds] 05:19 -!- grafcaps [~haroldbr@50.90.83.229] has quit [Ping timeout: 260 seconds] 05:19 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 05:21 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 05:21 -!- CapitanRetardo [~CapitanRe@95-130-162-239.hsi.glasfaser-ostbayern.de] has joined #bitcoin-core-dev 05:21 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [] 05:24 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 05:27 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 05:30 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 05:31 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 05:35 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 05:35 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 240 seconds] 05:39 < wumpus> If you'd already looked at a PR 1 month ago; why wait until it's been squashed, rebased and has 3 ACKs to suddenly start nit-picking it to shreds? <- yeah... 05:39 < wumpus> feel free to call me out when I do that 05:39 < wumpus> usually I add "but this doesn't have to be done in this PR" in that case 05:40 * luke-jr calls jonasschnelli out on doing it with multiwallet? XD 05:40 < wumpus> at this point I'd be happy to have *any* multiwallet GUI in, just so that work can proceed on it in the repository 05:41 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 05:42 < luke-jr> well, #11383 is ready besides a new conflict in wallet_tests I could easily resolve :x 05:42 < gribble> https://github.com/bitcoin/bitcoin/issues/11383 | Basic Multiwallet GUI support by luke-jr · Pull Request #11383 · bitcoin/bitcoin · GitHub 05:46 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has joined #bitcoin-core-dev 05:52 -!- opdenkamp [~opdenkamp@kodi/staff/dushmaniac] has joined #bitcoin-core-dev 05:55 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 05:56 -!- CapitanRetardo [~CapitanRe@95-130-162-239.hsi.glasfaser-ostbayern.de] has quit [Quit: WeeChat 2.0.1] 06:03 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 06:22 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9f04c8e23118...ce6ffe196e9b 06:22 < bitcoin-git> bitcoin/master fa23105 MarcoFalke: qa: Cache only chain and wallet for regtest datadir 06:22 < bitcoin-git> bitcoin/master ce6ffe1 Wladimir J. van der Laan: Merge #12638: qa: Cache only chain and wallet for regtest datadir... 06:23 < bitcoin-git> [bitcoin] laanwj closed pull request #12638: qa: Cache only chain and wallet for regtest datadir (master...Mf1803-qaMempoolCache) https://github.com/bitcoin/bitcoin/pull/12638 06:25 -!- schmidty [~schmidty@c-98-212-53-76.hsd1.il.comcast.net] has joined #bitcoin-core-dev 06:26 -!- schmidty is now known as Guest72256 06:29 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 06:29 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ce6ffe196e9b...c4219ff3786e 06:29 < bitcoin-git> bitcoin/master 4ef82f1 fanquake: depends: biplist 1.0.3 06:30 < bitcoin-git> bitcoin/master c4219ff Wladimir J. van der Laan: Merge #12625: depends: biplist 1.0.3... 06:30 < bitcoin-git> [bitcoin] laanwj closed pull request #12625: depends: biplist 1.0.3 (master...biplist-1-0-3) https://github.com/bitcoin/bitcoin/pull/12625 06:31 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has quit [Quit: probably someone interrupted me] 06:32 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 06:37 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 260 seconds] 06:38 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 06:39 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 06:40 < fanquake> wumpus I think we're meant to be excluding patches already: ":(exclude)depends/patches/" Maybe the script is broken? 06:40 < wumpus> fanquake: was that ever backported 06:40 < fanquake> wumpus Good point, probably not 06:41 < wumpus> :D 06:41 < wumpus> could include it in that PR I gues 06:42 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 246 seconds] 06:43 < wumpus> already had a bit of deja vu feeling about that patch exclusion 06:44 < fanquake> heh, get enough hassel from whitespace already without it complaining about things we know are "correct" 06:44 < fanquake> I'll add that commit in a minute 06:44 < wumpus> yes, agree 06:45 < fanquake> #12102 should be ready for merge 06:45 < gribble> https://github.com/bitcoin/bitcoin/issues/12102 | Apply hardening measures in bitcoind systemd service file by Flowdalic · Pull Request #12102 · bitcoin/bitcoin · GitHub 06:46 < wumpus> I'm still not convinced adding that whitespace check to travis was a good idea. On the other hand at least it avoids PRs to "fix" whitespace! 06:48 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c4219ff3786e...7fb8fb43a630 06:48 < bitcoin-git> bitcoin/master 79ddfad Florian Schmaus: Apply hardening measurements in bitcoind systemd service file... 06:48 < bitcoin-git> bitcoin/master 7fb8fb4 Wladimir J. van der Laan: Merge #12102: Apply hardening measures in bitcoind systemd service file... 06:49 < bitcoin-git> [bitcoin] laanwj closed pull request #12102: Apply hardening measures in bitcoind systemd service file (master...systemd-hardening) https://github.com/bitcoin/bitcoin/pull/12102 06:51 < bitcoin-git> [bitcoin] fanquake closed pull request #12685: [gui] script addresses for sending, not signing (master...master) https://github.com/bitcoin/bitcoin/pull/12685 06:53 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 06:54 -!- ken2812221 [~User@133-203.dorm.ncu.edu.tw] has quit [Quit: Leaving] 06:56 -!- ken2812221 [~User@133-203.dorm.ncu.edu.tw] has joined #bitcoin-core-dev 06:57 < fanquake> wumpus #12460 has a bunch of utACKs, requested a review from sipa 06:57 < gribble> https://github.com/bitcoin/bitcoin/issues/12460 | Assert CPubKey::ValidLength to the pubkeys header-relevant size by Empact · Pull Request #12460 · bitcoin/bitcoin · GitHub 06:58 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 240 seconds] 07:01 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 07:06 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 240 seconds] 07:06 < fanquake> #12316 started a QT bump, but hasn't really been followed up. 07:06 < gribble> https://github.com/bitcoin/bitcoin/issues/12316 | Upgrade depends/build system to use Qt 5.9.4 by thijstriemstra · Pull Request #12316 · bitcoin/bitcoin · GitHub 07:07 < fanquake> After discussing with theuni 5.9.x is the way to go for the next QT bump, however the changes should be more involved than what's been done in that PR so far. 07:07 < fanquake> I think I'll close it for now. I start work on an alternate pr last week. 07:08 < wumpus> agree, better to close it if it doesn't make progress, probably the author underestimated the work involved 07:08 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 07:08 < wumpus> it's kind of a long haul, for a first-time contributor to try to bump qt in the depends system 07:09 < wumpus> might learn a thing if he was really involved, but it's going slow 07:09 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 07:09 < bitcoin-git> [bitcoin] fanquake closed pull request #12316: Upgrade depends/build system to use Qt 5.9.4 (master...patch-1) https://github.com/bitcoin/bitcoin/pull/12316 07:11 < wumpus> let's try to credit him in the commit message when we do bump qt 07:12 -!- Guest72256 [~schmidty@c-98-212-53-76.hsd1.il.comcast.net] has quit [Remote host closed the connection] 07:12 -!- harrymm [~harrymm@104.207.83.64] has quit [Ping timeout: 240 seconds] 07:13 < bitcoin-git> [bitcoin] laanwj closed pull request #12510: test: Add rpc_bind test to default-run tests (master...2018_02_reinstate_rpcbind_test) https://github.com/bitcoin/bitcoin/pull/12510 07:13 < fanquake> wumpus How would like to follow up with issues like #12657 ? 07:13 < gribble> https://github.com/bitcoin/bitcoin/issues/12657 | Serbian Translation / Cyrillic and Latin - Needs better distinction on Transifex · Issue #12657 · bitcoin/bitcoin · GitHub 07:14 < fanquake> I'm not quite on top of how we are doing things on Transifex. 07:14 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 07:14 -!- HFRadical [~none@103.254.153.99] has joined #bitcoin-core-dev 07:14 < wumpus> I have no idea either 07:17 < setpill> has anyone tried to test #12656 ? currently running into some problems but not sure if it's an issue in my virtualbox install or in the PR 07:17 < gribble> https://github.com/bitcoin/bitcoin/issues/12656 | Add scripts for doing gitian builds on any platform using VirtualBox + Vagrant + Packer by maaku · Pull Request #12656 · bitcoin/bitcoin · GitHub 07:18 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 264 seconds] 07:19 < fanquake> setpill I'm planning on testing shortly. Report any issues your having to the PR. 07:19 < wumpus> I don't use virtualbox anymore (now use libvirt/virsh on my VM servers) so can't test 07:20 < fanquake> wumpus I was wondering if the /docs repo might be a better place for that PR ? 07:21 < wumpus> fanquake: at least the documentation for it should go into the docs repo, so that it's with the other menagerie of gitian building methods. If there are scripts that are more-or-less bound to the bitcoin core release schedule they can be in our repo. Not sure. 07:22 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has joined #bitcoin-core-dev 07:22 < wumpus> I think the other gitian building script is also in our repo 07:22 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/7fb8fb43a630...05042d38ba56 07:22 < bitcoin-git> bitcoin/master 8172d3a Luke Dashjr: configure: UniValue 1.0.4 is required for pushKV(, bool) 07:22 < bitcoin-git> bitcoin/master 05042d3 Wladimir J. van der Laan: Merge #12666: configure: UniValue 1.0.4 is required for pushKV(, bool)... 07:23 < bitcoin-git> [bitcoin] laanwj closed pull request #12666: configure: UniValue 1.0.4 is required for pushKV(, bool) (master...univalue-1.0.4-required) https://github.com/bitcoin/bitcoin/pull/12666 07:25 -!- harrymm [~harrymm@104.207.83.40] has joined #bitcoin-core-dev 07:25 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/05042d38ba56...56cc022112af 07:25 < bitcoin-git> bitcoin/master c316fdf João Barbosa: [qt] Add support to search the address book 07:25 < bitcoin-git> bitcoin/master 56cc022 Wladimir J. van der Laan: Merge #12080: Add support to search the address book... 07:26 < bitcoin-git> [bitcoin] laanwj closed pull request #12080: Add support to search the address book (master...2018-01-searchaddressbook) https://github.com/bitcoin/bitcoin/pull/12080 07:29 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 07:31 -!- grafcaps [~haroldbr@50.90.83.229] has joined #bitcoin-core-dev 07:31 -!- promag [~promag@46.50.115.20] has joined #bitcoin-core-dev 07:32 < fanquake> wumpus I think #12668 can just go in 07:32 < gribble> https://github.com/bitcoin/bitcoin/issues/12668 | Doc: Ubuntu xenial first dependencies by nvercamm · Pull Request #12668 · bitcoin/bitcoin · GitHub 07:32 < fanquake> If running apt update/upgrade is going to upset something, WSL is even more broken than we seem to think. 07:33 < fanquake> You could adjust the commit message though, as nothing Xenial specific. 07:34 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 256 seconds] 07:35 < promag> hi, I would like some feedback on #12507, ty 07:35 < gribble> https://github.com/bitcoin/bitcoin/issues/12507 | Interrupt rescan on shutdown request by promag · Pull Request #12507 · bitcoin/bitcoin · GitHub 07:35 < promag> in particular, if the rescan should resume or not 07:36 < instagibbs> wumpus, I must be the only one who gets triggered seeing extra whitespace on my git diff... 07:37 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 07:37 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 07:38 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Client Quit] 07:40 < wumpus> instagibbs: no, I don't think so, it's really easy to notice such things. I consciously have to push myself to ignore all kinds of small grievances while reviewing, to be able to focus at the real changes 07:43 < wumpus> and yes, sometimes I still fail at that 07:43 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-dsjtpwndxysvveny] has quit [Quit: Connection closed for inactivity] 07:44 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 07:46 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 07:48 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 264 seconds] 07:50 -!- grafcaps [~haroldbr@50.90.83.229] has quit [Ping timeout: 246 seconds] 07:53 < achow101> pierre_rochard: I haven't really looked at that issue yet. I can't reproduce it either; I don't have a mac 07:59 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [] 08:03 -!- Deinogalerix21 [~Deinogale@185.169.255.9] has joined #bitcoin-core-dev 08:06 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 08:11 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 264 seconds] 08:11 -!- Deinogalerix21 [~Deinogale@185.169.255.9] has quit [Quit: WeeChat 2.0.1] 08:16 -!- grafcaps [~haroldbr@50.90.26.145] has joined #bitcoin-core-dev 08:17 < bitcoin-git> [bitcoin] laanwj closed pull request #12636: backport: #11995 Fix Qt build with Xcode 9 (0.16...qt-fix-backport) https://github.com/bitcoin/bitcoin/pull/12636 08:20 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 246 seconds] 08:20 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 08:21 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 08:24 -!- promag [~promag@46.50.115.20] has quit [Remote host closed the connection] 08:25 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 08:25 -!- grafcaps [~haroldbr@50.90.26.145] has quit [Ping timeout: 264 seconds] 08:28 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 08:30 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/56cc022112af...de2fcaa89a61 08:30 < bitcoin-git> bitcoin/master e29c6c8 Nick Vercammen: Ubuntu xenial first dependencies... 08:30 < bitcoin-git> bitcoin/master de2fcaa Wladimir J. van der Laan: Merge #12668: Doc: do update before fetching packages in WSL build guide... 08:31 < bitcoin-git> [bitcoin] laanwj closed pull request #12668: Doc: do update before fetching packages in WSL build guide (master...patch-1) https://github.com/bitcoin/bitcoin/pull/12668 08:34 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 276 seconds] 08:35 -!- zarez [~Thunderbi@fs-93-93-44-38.fullsave.info] has quit [Ping timeout: 264 seconds] 08:36 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 08:40 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection] 08:41 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 264 seconds] 08:41 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 08:43 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Max SendQ exceeded] 08:43 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 08:45 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Max SendQ exceeded] 08:45 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 08:47 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 08:48 -!- zarez [~Thunderbi@fs-93-93-44-38.fullsave.info] has joined #bitcoin-core-dev 08:50 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 260 seconds] 08:52 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 246 seconds] 08:55 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 08:59 -!- kexkey [~textual@67.215.14.195] has joined #bitcoin-core-dev 09:00 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 264 seconds] 09:03 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 09:04 -!- dafunkiz_ [~dafunkizd@174.127.143.202] has joined #bitcoin-core-dev 09:07 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 240 seconds] 09:07 -!- grafcaps [~haroldbr@104.137.194.255] has joined #bitcoin-core-dev 09:09 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 09:11 -!- zarez [~Thunderbi@fs-93-93-44-38.fullsave.info] has quit [Quit: zarez] 09:11 -!- zarez [~Thunderbi@fs-93-93-44-38.fullsave.info] has joined #bitcoin-core-dev 09:12 < provoostenator> Does -testsafemode do anything other than display a warning in QT? 09:14 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev 09:15 < wumpus> no 09:15 < wumpus> safe mode never did anything in the GUI (well besides restrict use of RPC, through the debug console) 09:16 < wumpus> it's interesting that testsafemode is not used in any of the tests, though maybe that was removed already when safe mode was deprecated 09:17 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 09:17 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 09:22 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 246 seconds] 09:22 -!- Murch [~murch@96.74.120.81] has joined #bitcoin-core-dev 09:27 -!- schmidty [~schmidty@c-98-212-53-76.hsd1.il.comcast.net] has joined #bitcoin-core-dev 09:28 -!- schmidty is now known as Guest38422 09:28 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/de2fcaa89a61...e7721e667260 09:28 < bitcoin-git> bitcoin/master 59f4795 fanquake: docs: Update osx brew install instruction 09:29 < bitcoin-git> bitcoin/master e7721e6 Wladimir J. van der Laan: Merge #12586: docs: Update osx brew install instruction... 09:29 < bitcoin-git> [bitcoin] laanwj closed pull request #12586: docs: Update osx brew install instruction (master...homebrew-python3-python) https://github.com/bitcoin/bitcoin/pull/12586 09:35 -!- zarez [~Thunderbi@fs-93-93-44-38.fullsave.info] has quit [Quit: zarez] 09:39 < provoostenator> wumpus: should I make a PR to get rid of it then? 09:45 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has joined #bitcoin-core-dev 09:46 < wumpus> provoostenator: dunno, I don't think there's really a hurry 09:52 < provoostenator> I didn't specificy when :-) 09:53 < wumpus> I don't think anyone would be opposed to just removing safe mode and everything assosicated with it, but there's probably more important things, its existence isn't blocking any developments 09:56 < wumpus> otoh it was deprecated in 0.16 so removing it in 0.17 would be sensible 09:58 < provoostenator> Afaik the parameter literraly doesn't do anything except show that message. It's not setting any (global) variable. 09:59 < wumpus> so if you run with -disablesafemode=0 -testsafemode , you should be prevented from executing various RPCs 10:01 < wumpus> (to be precise, the ones that call ObserveSafeMode) 10:01 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection] 10:02 < bitcoin-git> [bitcoin] laanwj pushed 14 new commits to master: https://github.com/bitcoin/bitcoin/compare/e7721e667260...e057589dc67f 10:02 < bitcoin-git> bitcoin/master 12ec29d Andrew Chow: Calculate and store the number of bytes required to spend an input 10:02 < bitcoin-git> bitcoin/master f84fed8 Andrew Chow: Store effective value, fee, and long term fee in CInputCoin... 10:02 < bitcoin-git> bitcoin/master 0185939 Andrew Chow: Implement Branch and Bound coin selection in a new file... 10:02 < bitcoin-git> [bitcoin] laanwj closed pull request #10637: Coin Selection with Murch's algorithm (master...bnb-coin-select) https://github.com/bitcoin/bitcoin/pull/10637 10:03 < Murch> woohoooooo! :D 10:05 < wumpus> :D 10:06 < wumpus> congratulations, thanks for sticking with this 10:07 < provoostenator> Very nice! 10:12 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 10:14 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 10:14 < Murch> Thank you achow101, instagibbs, morcos, ryanofsky, eklitzke and everyone else! :D 10:14 < Murch> This makes me really happy! 10:14 < achow101> \O/ 10:15 < achow101> Time to start working on replacing the fallback strategy 10:16 < Murch> Yessir! 10:16 < Murch> Thanks wumpus 10:21 < bitcoin-git> [bitcoin] Sjors opened pull request #12687: Remove unused -testsafemode [AKA: why this PR is wrong] (master...2018-03/testsafemode) https://github.com/bitcoin/bitcoin/pull/12687 10:21 < provoostenator> wumpus: I figured out what I was missing... 10:21 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 10:22 -!- rex_4539 [~textual@2a02:587:3513:b600:782f:9585:f919:b4e] has joined #bitcoin-core-dev 10:22 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 260 seconds] 10:22 < bitcoin-git> [bitcoin] Sjors closed pull request #12687: Remove unused -testsafemode [AKA: why this PR is wrong] (master...2018-03/testsafemode) https://github.com/bitcoin/bitcoin/pull/12687 10:23 < instagibbs> gave a whoop at taco place when i saw the email. Thanks for all the heavy lifting achow101 :) 10:24 < Murch> instagibbs: Everybody was looking at my bewilderedly when I just whooped here at the office. Had to explain what happened. :D 10:26 < instagibbs> next: rip up knapsack and crazy transaction looping... 10:28 -!- dafunkiz_ [~dafunkizd@174.127.143.202] has quit [Quit: probably someone interrupted me] 10:29 < sipa> congrats all, and achow101 and Murch in particular 10:29 -!- Guest38422 [~schmidty@c-98-212-53-76.hsd1.il.comcast.net] has quit [Remote host closed the connection] 10:29 -!- schmidty [~schmidty@c-98-212-53-76.hsd1.il.comcast.net] has joined #bitcoin-core-dev 10:30 -!- schmidty is now known as Guest74669 10:32 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has joined #bitcoin-core-dev 10:34 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 10:35 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 10:35 -!- Guest74669 [~schmidty@c-98-212-53-76.hsd1.il.comcast.net] has quit [Ping timeout: 248 seconds] 10:44 -!- kexkey_ [~kexkey@68.168.122.228] has joined #bitcoin-core-dev 10:47 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 10:47 -!- kexkey [~textual@67.215.14.195] has quit [Ping timeout: 264 seconds] 10:49 -!- nullptr| [~nullptr|@ip-94-113-103-134.net.upcbroadband.cz] has quit [Quit: ZNC - http://znc.in] 10:50 -!- nullptr| [~nullptr|@ip-94-113-103-134.net.upcbroadband.cz] has joined #bitcoin-core-dev 10:52 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 260 seconds] 10:56 -!- iyahjeff [~jfdoucet@modemcable210.140-57-74.mc.videotron.ca] has joined #bitcoin-core-dev 10:56 < iyahjeff> Hi there. Anyone running a full BTC node on Linux that would be kind enough to paste me the output of “du -shm .bitcoin/blocks/” 10:57 < arubi> 191199 datadir/blocks/ 10:57 < arubi> oh this is #-core-dev 10:57 < iyahjeff> @arubi Thanks a lot. 10:59 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has quit [Quit: probably someone interrupted me] 11:01 -!- iyahjeff [~jfdoucet@modemcable210.140-57-74.mc.videotron.ca] has left #bitcoin-core-dev [] 11:03 -!- Strepsils [~textual@109.87.232.207] has joined #bitcoin-core-dev 11:20 -!- LeMiner [LeMiner@unaffiliated/leminer] has joined #bitcoin-core-dev 11:24 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 11:27 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 11:28 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 11:28 -!- jojeyh [~delphi@2602:306:b8b6:b970:948c:4188:e8be:25e5] has quit [Ping timeout: 245 seconds] 11:32 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection] 11:38 < pierre_rochard> ryanofsky I’m looking at the 0.17 wallet PRs to see what to review next, is #11536 the priority? It seems to precede the two other label PRs 11:38 < gribble> https://github.com/bitcoin/bitcoin/issues/11536 | Rename account to label where appropriate by ryanofsky · Pull Request #11536 · bitcoin/bitcoin · GitHub 11:39 < ryanofsky> yes, it is meant to be followed up by #7729, then #11497 11:39 < gribble> https://github.com/bitcoin/bitcoin/issues/7729 | rpc: introduce label API for wallet by laanwj · Pull Request #7729 · bitcoin/bitcoin · GitHub 11:39 < gribble> https://github.com/bitcoin/bitcoin/issues/11497 | Hide accounts system behind deprecation switch by achow101 · Pull Request #11497 · bitcoin/bitcoin · GitHub 11:40 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has quit [Remote host closed the connection] 11:41 -!- santiag0 [6db71b3f@gateway/web/freenode/ip.109.183.27.63] has joined #bitcoin-core-dev 11:48 -!- qu4ku [~qu4ku@affn183.neoplus.adsl.tpnet.pl] has joined #bitcoin-core-dev 11:50 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 11:52 -!- schmidty [~schmidty@c-98-212-53-76.hsd1.il.comcast.net] has joined #bitcoin-core-dev 11:53 -!- schmidty [~schmidty@c-98-212-53-76.hsd1.il.comcast.net] has quit [Changing host] 11:53 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev 11:54 -!- d_t [~d_t@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 11:58 -!- booyah [~bb@193.25.1.157] has quit [Read error: Connection reset by peer] 11:59 -!- booyah [~bb@193.25.1.157] has joined #bitcoin-core-dev 12:01 -!- dafunkiz_ [~dafunkizd@209.63.143.172] has joined #bitcoin-core-dev 12:01 -!- dafunkiz_ [~dafunkizd@209.63.143.172] has quit [Client Quit] 12:01 -!- Strepsils [~textual@109.87.232.207] has quit [Ping timeout: 276 seconds] 12:03 -!- dafunkiz_ [~dafunkizd@209.63.143.172] has joined #bitcoin-core-dev 12:05 -!- contrapumpkin [~copumpkin@haskell/developer/copumpkin] has quit [Quit: My MacBook Pro has gone to sleep. ZZZzzz…] 12:07 -!- contrapumpkin [~copumpkin@haskell/developer/copumpkin] has joined #bitcoin-core-dev 12:10 -!- qu4ku [~qu4ku@affn183.neoplus.adsl.tpnet.pl] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 12:11 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-jkoqtawqccnnvtfn] has joined #bitcoin-core-dev 12:17 -!- dafunkiz_ [~dafunkizd@209.63.143.172] has quit [Quit: probably someone interrupted me] 12:18 < meshcollider> Yay congrats on the coin selection merge finally achow101, Murch \o/ 12:27 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev 12:28 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 12:29 -!- dafunkiz_ [~dafunkizd@209.63.143.172] has joined #bitcoin-core-dev 12:34 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [] 12:36 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 246 seconds] 12:40 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 12:40 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 264 seconds] 12:41 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 12:43 -!- kexkey_ [~kexkey@68.168.122.228] has quit [Quit: Yawn] 12:45 -!- dafunkiz_ [~dafunkizd@209.63.143.172] has quit [Quit: probably someone interrupted me] 12:49 -!- HFRadical [~none@103.254.153.99] has quit [Read error: Connection reset by peer] 12:50 -!- HFRadical [~none@103.254.153.99] has joined #bitcoin-core-dev 12:53 -!- HFRadical [~none@103.254.153.99] has quit [Read error: Connection reset by peer] 12:53 -!- HFRadical [~none@103.254.153.99] has joined #bitcoin-core-dev 12:56 < bitcoin-git> [bitcoin] dooglus closed pull request #11085: Add 'sethdseed' RPC to initialize or replace HD seed. (master...set_hd_seed) https://github.com/bitcoin/bitcoin/pull/11085 12:56 -!- qu4ku [~qu4ku@affn183.neoplus.adsl.tpnet.pl] has joined #bitcoin-core-dev 12:59 -!- santiag0_ [~kuba@109-183-27-63.tmcz.cz] has joined #bitcoin-core-dev 13:00 -!- santiag0_ [~kuba@109-183-27-63.tmcz.cz] has quit [Client Quit] 13:03 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has quit [Remote host closed the connection] 13:09 -!- jojeyh [~delphi@99-59-126-62.lightspeed.irvnca.sbcglobal.net] has joined #bitcoin-core-dev 13:10 -!- santiag0_ [~kuba@109-183-27-63.tmcz.cz] has joined #bitcoin-core-dev 13:20 -!- dafunkiz_ [~dafunkizd@209.63.143.172] has joined #bitcoin-core-dev 13:21 -!- santiag0_ is now known as jajinkaz 13:22 -!- jajinkaz is now known as santiago0 13:24 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has joined #bitcoin-core-dev 13:26 < santiago0> hello 13:35 -!- jojeyh [~delphi@99-59-126-62.lightspeed.irvnca.sbcglobal.net] has quit [Ping timeout: 276 seconds] 13:36 < santiago0> I'm IT student. Never participated to bigger projects. How do you manage bitcoin source code? What IDE are you using? 13:38 < sipa> text editor 13:38 -!- santiag0 [6db71b3f@gateway/web/freenode/ip.109.183.27.63] has quit [Quit: Page closed] 13:39 < AndyS2> I guess most people just use vim and the command line. After trying a few IDEs, I settled for Eclipse CDT with a VIM plugin for better overview. I'm just fooling around, though. 13:39 < AndyS2> Mostly because their debugger has a nice overview and seperate interfaces weren't as nice to use. 13:40 < AndyS2> oops 13:42 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 13:42 -!- jojeyh [~delphi@99-59-126-62.lightspeed.irvnca.sbcglobal.net] has joined #bitcoin-core-dev 13:43 < santiago0> ok thanks. Until now I also used VIM for everything. 13:44 < AndyS2> It's easier to navigate unknown code with an IDE in my opinion. that said, there's probably some plugin that does just that for vim, too. 13:45 < AndyS2> I just got a vim plugin for eclipse. serves my purpose well 13:45 < jojeyh> AndyS2, grep -rnw . -e 'stuff to find' 13:46 < promag> I believe #12621 is ready to be merged 13:46 < gribble> https://github.com/bitcoin/bitcoin/issues/12621 | Avoid querying unnecessary model data when filtering transactions by promag · Pull Request #12621 · bitcoin/bitcoin · GitHub 13:48 -!- santiago0 [~kuba@109-183-27-63.tmcz.cz] has quit [Quit: leaving] 13:51 -!- goatpig [56f75164@gateway/web/freenode/ip.86.247.81.100] has joined #bitcoin-core-dev 14:05 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Read error: Connection reset by peer] 14:08 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 264 seconds] 14:08 -!- rex_4539 [~textual@2a02:587:3513:b600:782f:9585:f919:b4e] has quit [Quit: Textual IRC Client: www.textualapp.com] 14:12 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 14:16 -!- dafunkiz_ [~dafunkizd@209.63.143.172] has quit [Quit: probably someone interrupted me] 14:19 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 14:20 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Remote host closed the connection] 14:20 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 14:24 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 14:26 -!- jimbouki [~jimbouki@2600:1008:b061:dee2:7821:e186:2eb:ff9] has joined #bitcoin-core-dev 14:26 -!- Randolf [~randolf@nat-soc-241-249.tdbank.ca] has joined #bitcoin-core-dev 14:26 -!- dafunkiz_ [~dafunkizd@209.63.143.172] has joined #bitcoin-core-dev 14:28 -!- Dizzle [~dizzle@108.171.182.16] has joined #bitcoin-core-dev 14:31 -!- jimbouki [~jimbouki@2600:1008:b061:dee2:7821:e186:2eb:ff9] has quit [Ping timeout: 276 seconds] 14:38 < intcat> jojeyh: or without w 14:43 -!- jojeyh [~delphi@99-59-126-62.lightspeed.irvnca.sbcglobal.net] has quit [Ping timeout: 248 seconds] 14:49 -!- byteideas [9cc5aaf9@gateway/web/freenode/ip.156.197.170.249] has joined #bitcoin-core-dev 14:56 -!- pgupta [~pgupta@109.246.173.236] has joined #bitcoin-core-dev 15:00 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 15:00 -!- Randolf [~randolf@nat-soc-241-249.tdbank.ca] has quit [Ping timeout: 246 seconds] 15:09 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 15:12 -!- Randolf [~randolf@24.114.37.237] has joined #bitcoin-core-dev 15:14 -!- dafunkiz_ [~dafunkizd@209.63.143.172] has quit [Quit: probably someone interrupted me] 15:16 -!- Randolf [~randolf@24.114.37.237] has quit [Read error: Connection reset by peer] 15:17 < bitcoin-git> [bitcoin] eklitzke opened pull request #12689: Smarter default behavior for -printtoconsole (master...console) https://github.com/bitcoin/bitcoin/pull/12689 15:25 -!- tknp [~tknp@unaffiliated/tknp] has joined #bitcoin-core-dev 15:49 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has quit [Remote host closed the connection] 15:58 -!- pgupta [~pgupta@109.246.173.236] has quit [Remote host closed the connection] 16:01 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 16:01 -!- dafunkiz_ [~dafunkizd@209.63.143.172] has joined #bitcoin-core-dev 16:03 -!- Randolf [~randolf@24.114.39.28] has joined #bitcoin-core-dev 16:04 -!- mikgrt [~pgupta@109.246.173.236] has joined #bitcoin-core-dev 16:09 -!- mikgrt [~pgupta@109.246.173.236] has quit [Ping timeout: 276 seconds] 16:10 -!- jimbouki [~jimbouki@98.227.189.229] has joined #bitcoin-core-dev 16:11 -!- jimbouki [~jimbouki@98.227.189.229] has quit [Client Quit] 16:12 -!- tknp [~tknp@unaffiliated/tknp] has quit [Quit: tknp] 16:14 -!- Randolf [~randolf@24.114.39.28] has quit [Read error: Connection reset by peer] 16:14 < eklitzke> travis is so annoying, it looks like it doesn't properly handle bash arrays when setting up the build environment 16:16 -!- tecneecs [~tecneecs@ool-44c1c00f.dyn.optonline.net] has joined #bitcoin-core-dev 16:22 -!- mikgrt [~pgupta@109.246.173.236] has joined #bitcoin-core-dev 16:22 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Remote host closed the connection] 16:23 -!- schmidty [~schmidty@c-98-212-53-76.hsd1.il.comcast.net] has joined #bitcoin-core-dev 16:23 -!- schmidty is now known as Guest48698 16:27 -!- mikgrt [~pgupta@109.246.173.236] has quit [Ping timeout: 276 seconds] 16:27 -!- Guest48698 [~schmidty@c-98-212-53-76.hsd1.il.comcast.net] has quit [Ping timeout: 264 seconds] 16:33 -!- qu4ku [~qu4ku@affn183.neoplus.adsl.tpnet.pl] has quit [Read error: Connection reset by peer] 16:34 -!- dafunkiz_ [~dafunkizd@209.63.143.172] has quit [Quit: probably someone interrupted me] 16:38 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Read error: Connection reset by peer] 16:39 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 16:40 -!- mikgrt [~pgupta@109.246.173.236] has joined #bitcoin-core-dev 16:41 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev 16:45 -!- mikgrt [~pgupta@109.246.173.236] has quit [Ping timeout: 264 seconds] 16:47 < eklitzke> hmm, i got another corrupted chainstate database, this time on a different computer 16:47 < eklitzke> what's interesting is the crc on the block is correct 16:49 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Excess Flood] 16:49 -!- booyah [~bb@193.25.1.157] has quit [Read error: Connection reset by peer] 16:50 < eklitzke> it also thinks that snappy compression is enabled, which is definitely not the case 16:50 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 16:50 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has joined #bitcoin-core-dev 16:50 -!- booyah [~bb@193.25.1.157] has joined #bitcoin-core-dev 16:51 -!- qu4ku [~qu4ku@affn183.neoplus.adsl.tpnet.pl] has joined #bitcoin-core-dev 16:52 -!- promag_ [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 16:53 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 264 seconds] 16:54 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has quit [Ping timeout: 240 seconds] 16:57 -!- qu4ku [~qu4ku@affn183.neoplus.adsl.tpnet.pl] has quit [Read error: Connection reset by peer] 16:58 -!- mikgrt [~pgupta@109.246.173.236] has joined #bitcoin-core-dev 17:00 -!- weez17 [~isaac@unaffiliated/weez17] has quit [Remote host closed the connection] 17:00 -!- weez17 [~isaac@unaffiliated/weez17] has joined #bitcoin-core-dev 17:02 -!- jojeyh [~delphi@2602:306:b8b6:b970:61e9:9d9f:5d9b:d62c] has joined #bitcoin-core-dev 17:03 -!- mikgrt [~pgupta@109.246.173.236] has quit [Ping timeout: 276 seconds] 17:06 -!- dafunkiz_ [~dafunkizd@174.127.143.202] has joined #bitcoin-core-dev 17:14 -!- qu4ku [~qu4ku@affn183.neoplus.adsl.tpnet.pl] has joined #bitcoin-core-dev 17:16 -!- mikgrt [~pgupta@109.246.173.236] has joined #bitcoin-core-dev 17:22 -!- mikgrt [~pgupta@109.246.173.236] has quit [Ping timeout: 276 seconds] 17:27 -!- mrannanay [uid222022@gateway/web/irccloud.com/x-xsvwudtrcaxztnnn] has quit [Quit: Connection closed for inactivity] 17:28 -!- dafunkiz_ [~dafunkizd@174.127.143.202] has quit [Quit: probably someone interrupted me] 17:33 -!- murrayn [~dafuq@unaffiliated/murrayn] has quit [Quit: Adios mofos] 17:34 -!- mikgrt [~pgupta@109.246.173.236] has joined #bitcoin-core-dev 17:36 -!- Murch [~murch@96.74.120.81] has quit [Quit: Snoozing.] 17:39 -!- mikgrt [~pgupta@109.246.173.236] has quit [Ping timeout: 264 seconds] 17:43 -!- Samdney [~Samdney@178.162.209.136] has quit [Quit: Verlassend] 17:47 -!- grafcaps [~haroldbr@104.137.194.255] has quit [Ping timeout: 264 seconds] 17:50 < eklitzke> if you notice anyone on github opening issues about corrupted chainstate databases (i know this is a fairly common issue for people to open), direct them to #12690 and ask them to compile bitcoin with the new leveldb error log messages which are in master now 17:50 < gribble> https://github.com/bitcoin/bitcoin/issues/12690 | LevelDB "corrupted compressed block contents" errors · Issue #12690 · bitcoin/bitcoin · GitHub 17:51 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has joined #bitcoin-core-dev 17:53 -!- mikgrt [~pgupta@109.246.173.236] has joined #bitcoin-core-dev 17:54 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has quit [Ping timeout: 264 seconds] 17:55 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has quit [Ping timeout: 240 seconds] 17:57 -!- mikgrt [~pgupta@109.246.173.236] has quit [Ping timeout: 248 seconds] 18:00 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has joined #bitcoin-core-dev 18:01 -!- grafcaps [~haroldbr@50.90.83.229] has joined #bitcoin-core-dev 18:05 -!- promag_ [~promag@bl22-247-244.dsl.telepac.pt] has quit [Read error: Connection reset by peer] 18:05 -!- Dizzle [~dizzle@108.171.182.16] has quit [Ping timeout: 260 seconds] 18:07 -!- murrayn [~dafuq@unaffiliated/murrayn] has joined #bitcoin-core-dev 18:07 -!- murrayn [~dafuq@unaffiliated/murrayn] has quit [Client Quit] 18:07 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 18:07 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 18:10 -!- pyericz [~pyericz@117.30.146.190] has joined #bitcoin-core-dev 18:11 -!- mikgrt [~pgupta@109.246.173.236] has joined #bitcoin-core-dev 18:12 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [] 18:14 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 18:15 -!- murrayn [~dafuq@unaffiliated/murrayn] has joined #bitcoin-core-dev 18:15 -!- mikgrt [~pgupta@109.246.173.236] has quit [Ping timeout: 260 seconds] 18:19 < adiabat> not sure if this is a known bug: in the qt UI, the IBD window thing says "blocks left: unknown (syncing headers)" 18:19 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 18:19 < adiabat> but it's not; it's downloading blocks according to debug.log. Also the other fields in the UI seem fine and are updating 18:20 < adiabat> the bottom progress bar also says "syncing headers (99.9%)" but if I mouse-over the bar it pops up the actual height it's gotten to 18:23 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 18:24 -!- schmidty [~schmidty@c-98-212-53-76.hsd1.il.comcast.net] has joined #bitcoin-core-dev 18:24 -!- schmidty is now known as Guest51622 18:25 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds] 18:27 < adiabat> I clicked hide, then clicked the sync icon to bring it back up and it works normally, showing blocks left. so whatever... 18:29 -!- Guest51622 [~schmidty@c-98-212-53-76.hsd1.il.comcast.net] has quit [Ping timeout: 264 seconds] 18:29 -!- mikgrt [~pgupta@109.246.173.236] has joined #bitcoin-core-dev 18:31 -!- Black [92abf62c@gateway/web/freenode/ip.146.171.246.44] has joined #bitcoin-core-dev 18:33 -!- mikgrt [~pgupta@109.246.173.236] has quit [Ping timeout: 260 seconds] 18:33 -!- Black [92abf62c@gateway/web/freenode/ip.146.171.246.44] has quit [Client Quit] 18:34 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has quit [Quit: Snoozing.] 18:35 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Read error: Connection reset by peer] 18:36 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 18:40 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 18:43 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds] 18:47 -!- mikgrt [~pgupta@109.246.173.236] has joined #bitcoin-core-dev 18:47 -!- TheRec [~toto@drupal.org/user/146860/view] has quit [Read error: Connection reset by peer] 18:47 -!- dafunkiz_ [~dafunkizd@174.127.143.202] has joined #bitcoin-core-dev 18:48 -!- TheRec [~toto@84-75-205-212.dclient.hispeed.ch] has joined #bitcoin-core-dev 18:48 -!- TheRec [~toto@84-75-205-212.dclient.hispeed.ch] has quit [Changing host] 18:48 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev 18:49 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 18:51 -!- mikgrt [~pgupta@109.246.173.236] has quit [Ping timeout: 248 seconds] 18:52 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has joined #bitcoin-core-dev 18:54 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 276 seconds] 18:55 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 18:56 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has quit [Ping timeout: 240 seconds] 18:56 -!- lnostdal [~lnostdal@gateway/tor-sasl/lnostdal] has joined #bitcoin-core-dev 18:59 -!- mikgrt [~pgupta@109.246.173.236] has joined #bitcoin-core-dev 19:00 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 19:03 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 19:03 -!- mikgrt [~pgupta@109.246.173.236] has quit [Ping timeout: 264 seconds] 19:04 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 19:05 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 264 seconds] 19:09 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 276 seconds] 19:14 -!- mikgrt [~pgupta@109.246.173.236] has joined #bitcoin-core-dev 19:17 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 19:19 -!- mikgrt [~pgupta@109.246.173.236] has quit [Ping timeout: 256 seconds] 19:24 -!- pyericz [~pyericz@117.30.146.190] has quit [Quit: Leaving] 19:25 -!- pyericz [~pyericz@117.30.212.207] has joined #bitcoin-core-dev 19:28 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 19:31 < eklitzke> sipa: when you were doing the -fsanitize=address stuff, did you have to rebuild all of the libraries (boost, db4, etc.) with that flag enabled as well? 19:32 -!- ProfMac-2 [~ProfMac@2001:470:b8ac:0:d04d:841a:a130:245f] has quit [Quit: Leaving] 19:32 -!- mikgrt [~pgupta@109.246.173.236] has joined #bitcoin-core-dev 19:32 -!- ProfMac_ [~ProfMac@2001:470:b8ac:0:1836:8087:27b1:2fce] has joined #bitcoin-core-dev 19:33 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 276 seconds] 19:34 < eklitzke> asking because when i enable it all of the autoconf tests for the third party libs fail 19:35 < luke-jr> eklitzke: at least one of the sanitizers is documented to require it 19:36 -!- dafunkiz_ [~dafunkizd@174.127.143.202] has quit [Quit: probably someone interrupted me] 19:37 < sipa> eklitzke: i believe not 19:37 < sipa> i think only one of the sanitizes needs it 19:37 -!- mikgrt [~pgupta@109.246.173.236] has quit [Ping timeout: 276 seconds] 19:38 -!- dafunkiz_ [~dafunkizd@174.127.143.202] has joined #bitcoin-core-dev 19:38 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 264 seconds] 19:42 -!- pyericz [~pyericz@117.30.212.207] has quit [Quit: Leaving] 19:43 -!- pyericz [~pyericz@117.30.212.207] has joined #bitcoin-core-dev 19:43 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 19:43 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 19:46 -!- kryptopraxis [~kryptopra@p200300C853C52700AC5D63D2F7E633A8.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds] 19:48 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 19:51 -!- mikgrt [~pgupta@109.246.173.236] has joined #bitcoin-core-dev 19:52 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has joined #bitcoin-core-dev 19:53 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 19:55 -!- mikgrt [~pgupta@109.246.173.236] has quit [Ping timeout: 260 seconds] 19:57 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has quit [Ping timeout: 240 seconds] 19:59 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 263 seconds] 19:59 -!- kryptopraxis [~kryptopra@p200300C853C97E00556FEE6990F1CBFD.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 20:07 -!- goatpig [56f75164@gateway/web/freenode/ip.86.247.81.100] has quit [Quit: Page closed] 20:09 -!- mikgrt [~pgupta@109.246.173.236] has joined #bitcoin-core-dev 20:13 < bitcoin-git> [bitcoin] eklitzke opened pull request #12692: Add configure options for various -fsanitize flags (master...sanitize) https://github.com/bitcoin/bitcoin/pull/12692 20:13 -!- mikgrt [~pgupta@109.246.173.236] has quit [Ping timeout: 260 seconds] 20:16 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds] 20:17 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 20:18 -!- d_t [~d_t@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has quit [Ping timeout: 276 seconds] 20:23 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 20:25 -!- schmidty [~schmidty@c-98-212-53-76.hsd1.il.comcast.net] has joined #bitcoin-core-dev 20:25 -!- schmidty is now known as Guest44225 20:27 -!- mikgrt [~pgupta@109.246.173.236] has joined #bitcoin-core-dev 20:28 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 246 seconds] 20:29 -!- Guest44225 [~schmidty@c-98-212-53-76.hsd1.il.comcast.net] has quit [Ping timeout: 240 seconds] 20:32 -!- mikgrt [~pgupta@109.246.173.236] has quit [Ping timeout: 256 seconds] 20:34 -!- dafunkiz_ [~dafunkizd@174.127.143.202] has quit [Quit: probably someone interrupted me] 20:34 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds] 20:34 -!- tecneecs [~tecneecs@ool-44c1c00f.dyn.optonline.net] has quit [Quit: My Mac Pro has gone to sleep. ZZZzzz…] 20:53 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has joined #bitcoin-core-dev 20:55 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 20:57 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has quit [Ping timeout: 240 seconds] 21:00 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 260 seconds] 21:13 -!- pyericz [~pyericz@117.30.212.207] has quit [Quit: This computer has gone to sleep] 21:19 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 260 seconds] 21:28 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 21:32 -!- qu4ku [~qu4ku@affn183.neoplus.adsl.tpnet.pl] has quit [Quit: Textual IRC Client: www.textualapp.com] 21:34 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 276 seconds] 21:54 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has joined #bitcoin-core-dev 21:54 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 21:58 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has quit [Ping timeout: 240 seconds] 21:59 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 264 seconds] 22:15 -!- sanada` [~bitktn@36-2-119-80.chiba.ap.gmo-isp.jp] has quit [] 22:17 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has joined #bitcoin-core-dev 22:21 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 264 seconds] 22:22 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 22:23 -!- sanada [~bitktn@36-2-119-80.chiba.ap.gmo-isp.jp] has joined #bitcoin-core-dev 22:26 -!- schmidty [~schmidty@c-98-212-53-76.hsd1.il.comcast.net] has joined #bitcoin-core-dev 22:26 -!- schmidty is now known as Guest51146 22:27 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 260 seconds] 22:29 -!- grafcaps [~haroldbr@50.90.83.229] has quit [Ping timeout: 264 seconds] 22:30 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has quit [Quit: probably someone interrupted me] 22:31 -!- Guest51146 [~schmidty@c-98-212-53-76.hsd1.il.comcast.net] has quit [Ping timeout: 264 seconds] 22:35 -!- dafunkiz_ [~dafunkizd@174.127.143.202] has joined #bitcoin-core-dev 22:38 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 22:39 -!- pyericz [~pyericz@117.30.212.207] has joined #bitcoin-core-dev 22:43 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 276 seconds] 22:49 -!- SWXRU2cjac [~mnakdyqe@36.67.233.131] has joined #bitcoin-core-dev 22:49 < SWXRU2cjac> THIS IS A FREENODE BREAKING NEWS ALERT!! Hitechcg AND opal ARE GOING AT IT RIGHT NOW WITH A LOT OF FIGHTING AND ARGUING WOW YOU DON'T WANT TO MISS THIS!! TYPE /JOIN ## TO SEE THE ACTION...AGAIN TYPE /JOIN ## TO SEE THE ACTION!! 22:49 < SWXRU2cjac> THIS IS A FREENODE BREAKING NEWS ALERT!! Hitechcg AND opal ARE GOING AT IT RIGHT NOW WITH A LOT OF FIGHTING AND ARGUING WOW YOU DON'T WANT TO MISS THIS!! TYPE /JOIN ## TO SEE THE ACTION...AGAIN TYPE /JOIN ## TO SEE THE ACTION!! 22:49 < SWXRU2cjac> THIS IS A FREENODE BREAKING NEWS ALERT!! Hitechcg AND opal ARE GOING AT IT RIGHT NOW WITH A LOT OF FIGHTING AND ARGUING WOW YOU DON'T WANT TO MISS THIS!! TYPE /JOIN ## TO SEE THE ACTION...AGAIN TYPE /JOIN ## TO SEE THE ACTION!! 22:49 < SWXRU2cjac> pyericz Murch dafunkiz_ sanada justanotheruser kryptopraxis Victorsueca ProfMac_ lnostdal TheRec murrayn CubicEarths dabura667 jojeyh weez17 booyah rafalcpp byteideas ossifrage HFRadical owowo meshcollider contrapumpkin arbitrary_guy LeMiner nullptr| harrymm ken2812221 opdenkamp Megumiin adiabat BashCo_ Deacyde intcat vicenteH qrest Sinclair6 karelb unholymachine dermoth arowser Evel-Knievel sdaftuar jnewbery zivl arubi ghost43 mariorz BGL rya 22:49 -!- SWXRU2cjac [~mnakdyqe@36.67.233.131] has quit [Client Quit] 22:50 < jojeyh> wtf 22:55 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has joined #bitcoin-core-dev 22:57 -!- shesek [~shesek@bzq-84-110-235-58.cablep.bezeqint.net] has joined #bitcoin-core-dev 22:57 -!- shesek [~shesek@bzq-84-110-235-58.cablep.bezeqint.net] has quit [Changing host] 22:57 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 22:58 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 22:59 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has quit [Ping timeout: 240 seconds] 23:02 -!- dabura667 [~dabura667@p98110-ipngnfx01marunouchi.tokyo.ocn.ne.jp] has quit [Quit: Leaving] 23:02 -!- umaso [7d064535@gateway/web/freenode/ip.125.6.69.53] has joined #bitcoin-core-dev 23:02 -!- grafcaps [~haroldbr@50.90.83.229] has joined #bitcoin-core-dev 23:03 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 264 seconds] 23:07 -!- grafcaps [~haroldbr@50.90.83.229] has quit [Ping timeout: 276 seconds] 23:09 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 268 seconds] 23:10 < dafunkiz_> ? 23:15 < bitcoin-git> [bitcoin] drewx2 opened pull request #12693: Remove unused variable in SortForBlock (master...unused-sort-for-block-param) https://github.com/bitcoin/bitcoin/pull/12693 23:26 -!- umaso [7d064535@gateway/web/freenode/ip.125.6.69.53] has quit [Ping timeout: 260 seconds] 23:34 -!- pyericz [~pyericz@117.30.212.207] has quit [Quit: This computer has gone to sleep] 23:36 -!- pyericz [~pyericz@117.30.212.207] has joined #bitcoin-core-dev 23:41 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Remote host closed the connection] 23:45 -!- grafcaps [~haroldbr@50.90.83.229] has joined #bitcoin-core-dev 23:45 < bitcoin-git> [bitcoin] achow101 opened pull request #12694: Actually disable BnB when there are preset inputs (master...fix-preset-coins-bnb) https://github.com/bitcoin/bitcoin/pull/12694 23:45 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has quit [Quit: Snoozing.] 23:52 -!- mrannanay [uid222022@gateway/web/irccloud.com/x-luwjlsewvvpboycv] has joined #bitcoin-core-dev 23:53 < achow101> eklitzke: I'll write a test for that later. It's 3 AM for me right now and I kinda want to sleep 23:55 < eklitzke> fair 23:56 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has joined #bitcoin-core-dev