--- Day changed Sun Apr 08 2018 00:02 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has quit [Quit: probably someone interrupted me] 00:12 -!- mr_burdell [~mr_burdel@unaffiliated/mr-burdell/x-7609603] has quit [Ping timeout: 264 seconds] 00:13 -!- mr_burdell [~mr_burdel@unaffiliated/mr-burdell/x-7609603] has joined #bitcoin-core-dev 00:15 -!- pyericz_ [~pyericz@117.30.166.149] has quit [Quit: This computer has gone to sleep] 00:21 -!- zautomata [~zautomata@41.232.216.233] has quit [Ping timeout: 265 seconds] 00:30 -!- ula [~ula@b2b-78-94-11-194.unitymedia.biz] has quit [Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/] 00:33 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev 00:41 -!- kanexxz [~kanexxz@p57A778AB.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 00:44 -!- CubicEarths [~cubiceart@239.11.24.31.ftth.as8758.net] has joined #bitcoin-core-dev 00:44 -!- CubicEarths [~cubiceart@239.11.24.31.ftth.as8758.net] has quit [Remote host closed the connection] 00:45 -!- CubicEarths [~cubiceart@239.11.24.31.ftth.as8758.net] has joined #bitcoin-core-dev 00:49 -!- CubicEarths [~cubiceart@239.11.24.31.ftth.as8758.net] has quit [Ping timeout: 256 seconds] 01:01 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 01:02 -!- ken2812221 [~User@133-203.dorm.ncu.edu.tw] has joined #bitcoin-core-dev 01:02 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 01:25 -!- kingmyst [~kanexxz@p54A199E3.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 01:26 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:27 -!- kanexxz [~kanexxz@p57A778AB.dip0.t-ipconnect.de] has quit [Ping timeout: 264 seconds] 01:28 -!- kingmyst is now known as kanexxz 01:31 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 01:42 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Ping timeout: 276 seconds] 01:44 -!- zautomata [~zautomata@41.232.220.105] has joined #bitcoin-core-dev 01:49 < bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/048ac8326b69...d6f10b248a58 01:49 < bitcoin-git> bitcoin/master 3ebfb2d MarcoFalke: tests: Avoid test suite name collision in wallet crypto_tests 01:49 < bitcoin-git> bitcoin/master dc8067b practicalswift: tests: Add note about uniqueness requirement for test suite names 01:49 < bitcoin-git> bitcoin/master d1b622b practicalswift: tests: Add check for test suite name uniqueness in lint-tests.sh 01:50 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 01:50 < bitcoin-git> [bitcoin] laanwj closed pull request #12895: tests: Add note about test suite name uniqueness requirement to developer notes (master...check-uniqueness-of-test-suite-names) https://github.com/bitcoin/bitcoin/pull/12895 01:50 -!- pyericz_ [~pyericz@117.30.166.149] has joined #bitcoin-core-dev 01:51 -!- kingmyst [~kanexxz@p54A197F3.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 01:53 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:54 -!- kanexxz [~kanexxz@p54A199E3.dip0.t-ipconnect.de] has quit [Ping timeout: 260 seconds] 01:54 -!- kingmyst is now known as kanexxz 01:57 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 02:05 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/d6f10b248a58...3190785c11f7 02:05 < bitcoin-git> bitcoin/master 5c21e6c John Newbery: [logging] Comment all continuing logs.... 02:05 < bitcoin-git> bitcoin/master d207207 John Newbery: [logging] add lint-logs.sh to check for newline termination.... 02:05 < bitcoin-git> bitcoin/master 3190785 Wladimir J. van der Laan: Merge #12891: [logging] add lint-logs.sh to check for newline termination.... 02:06 < bitcoin-git> [bitcoin] laanwj closed pull request #12891: [logging] add lint-logs.sh to check for newline termination. (master...log_lint) https://github.com/bitcoin/bitcoin/pull/12891 02:09 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/3190785c11f7...24133b177a85 02:09 < bitcoin-git> bitcoin/master 0e7c52d Suhas Daftuar: Shut down if trying to connect a corrupted block... 02:09 < bitcoin-git> bitcoin/master 24133b1 Wladimir J. van der Laan: Merge #12561: Check for block corruption in ConnectBlock()... 02:09 < bitcoin-git> [bitcoin] laanwj closed pull request #12561: Check for block corruption in ConnectBlock() (master...2018-02-improve-checkblock-failure) https://github.com/bitcoin/bitcoin/pull/12561 02:16 -!- Krellan [~Krellan@2601:640:4000:9258:6d80:85a8:b4cd:5123] has quit [Read error: Connection reset by peer] 02:17 -!- Krellan [~Krellan@2601:640:4000:9258:79f8:267c:e8b4:5a19] has joined #bitcoin-core-dev 02:20 -!- zautomata [~zautomata@41.232.220.105] has quit [Ping timeout: 264 seconds] 02:34 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-qeqondiczjbekfhb] has quit [Quit: Connection closed for inactivity] 02:39 -!- jtimon [~quassel@142.29.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 02:39 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 02:42 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 02:43 -!- pyericz_ [~pyericz@117.30.166.149] has quit [Quit: This computer has gone to sleep] 02:55 -!- lnostdal [~lnostdal@85-118-92-44.mtel.net] has joined #bitcoin-core-dev 03:05 -!- zautomata [~zautomata@41.232.202.79] has joined #bitcoin-core-dev 03:09 -!- zautomata [~zautomata@41.232.202.79] has quit [Changing host] 03:09 -!- zautomata [~zautomata@unaffiliated/zautomata] has joined #bitcoin-core-dev 03:10 < bitcoin-git> [bitcoin] murrayn opened pull request #12912: Minor readability/maintainability changes to warnings.cpp (master...warnings) https://github.com/bitcoin/bitcoin/pull/12912 03:11 -!- pyericz_ [~pyericz@120.36.202.187] has joined #bitcoin-core-dev 03:17 -!- booyah [~bb@193.25.1.157] has quit [Ping timeout: 255 seconds] 03:19 -!- booyah [~bb@193.25.1.157] has joined #bitcoin-core-dev 03:28 -!- booyah_ [~bb@193.25.1.157] has joined #bitcoin-core-dev 03:29 -!- booyah [~bb@193.25.1.157] has quit [Read error: Connection reset by peer] 03:30 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 240 seconds] 03:33 -!- zautomata [~zautomata@unaffiliated/zautomata] has quit [Quit: WeeChat 1.9.1] 03:33 -!- zautomata [~zautomata@41.232.202.79] has joined #bitcoin-core-dev 03:35 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 03:37 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-bhyzkmfrrebisikj] has joined #bitcoin-core-dev 03:38 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Read error: Connection reset by peer] 03:39 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 03:45 -!- pyericz_ [~pyericz@120.36.202.187] has quit [Quit: This computer has gone to sleep] 03:53 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:55 -!- lnostdal [~lnostdal@85-118-92-44.mtel.net] has quit [Ping timeout: 256 seconds] 03:58 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 276 seconds] 04:02 -!- wxss [~user@5.254.86.221] has joined #bitcoin-core-dev 04:05 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 04:14 -!- laurentmt [~Thunderbi@ip124.67-202-83.static.steadfastdns.net] has joined #bitcoin-core-dev 04:23 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has quit [Ping timeout: 240 seconds] 04:26 -!- zautomata1 [~zautomata@41.233.234.170] has joined #bitcoin-core-dev 04:27 -!- zautomata [~zautomata@41.232.202.79] has quit [Ping timeout: 245 seconds] 04:29 -!- rls [~rls@2600:8800:1e00:9e1:dc6a:bf77:7fd0:bcaa] has quit [Ping timeout: 276 seconds] 04:38 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has joined #bitcoin-core-dev 04:41 -!- qu4ku [~qu4ku@2a01:110f:f73:1b00:5ab:108:baf8:3ed4] has joined #bitcoin-core-dev 04:41 -!- qu4ku [~qu4ku@2a01:110f:f73:1b00:5ab:108:baf8:3ed4] has quit [Client Quit] 04:50 -!- d9b4bef9 [~d9b4bef9@207.38.94.106] has quit [Remote host closed the connection] 04:51 -!- d9b4bef9 [~d9b4bef9@207.38.94.106] has joined #bitcoin-core-dev 04:53 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 05:00 < wumpus> I think https://github.com/bitcoin-core/bitcoin-incubator should be removed, it was never used for the purpose it was created for 05:38 < bitcoin-git> [bitcoin] practicalswift opened pull request #12914: scripted-diff: Remove redundant license reference (HTTP URL). Update copyright year. (master...copyright-headers) https://github.com/bitcoin/bitcoin/pull/12914 05:43 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 05:43 < fanquake> wumpus ack 05:44 < bitcoin-git> [bitcoin] fanquake closed pull request #12192: Trivial: Update http URL of MIT license to use https (master...12190-UPDATE_MIT_LINK_TO_HTTPS) https://github.com/bitcoin/bitcoin/pull/12192 05:52 < sipa> wumpus: agree; we can always revive it when there is a need 05:54 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 05:54 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection] 05:58 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 06:01 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [] 06:07 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Remote host closed the connection] 06:10 -!- treeeee [6ac1eb2f@gateway/web/freenode/ip.106.193.235.47] has joined #bitcoin-core-dev 06:13 -!- Arokh [~Arokh@extknot.com] has quit [Ping timeout: 256 seconds] 06:14 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 06:16 -!- treeeee [6ac1eb2f@gateway/web/freenode/ip.106.193.235.47] has quit [Ping timeout: 260 seconds] 06:19 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 06:26 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 06:27 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Ping timeout: 245 seconds] 06:27 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 06:28 -!- Sinclair6 [sinclair6@gateway/vpn/privateinternetaccess/sinclair6] has quit [Ping timeout: 260 seconds] 06:29 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 06:32 < wumpus> sipa: right - it still seems like a good idea, but it hasn't turned out to become the actual way of working :) 06:48 -!- nullptr| [~nullptr|@ip-94-113-103-134.net.upcbroadband.cz] has quit [Ping timeout: 256 seconds] 06:48 -!- Arokh [~Arokh@extknot.com] has joined #bitcoin-core-dev 06:52 -!- nullptr| [~nullptr|@ip-94-113-103-134.net.upcbroadband.cz] has joined #bitcoin-core-dev 06:52 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/24133b177a85...7e23972d1f71 06:52 < bitcoin-git> bitcoin/master 01189ab practicalswift: build: Show enabled sanitizers in configure output 06:52 < bitcoin-git> bitcoin/master 7e23972 MarcoFalke: Merge #12901: build: Show enabled sanitizers in configure output... 06:53 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #12901: build: Show enabled sanitizers in configure output (master...print-enabled-sanitizers-in-configure-output) https://github.com/bitcoin/bitcoin/pull/12901 06:59 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 07:17 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 07:18 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 07:18 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 07:21 -!- Arokh [~Arokh@extknot.com] has quit [Ping timeout: 256 seconds] 07:24 < bitcoin-git> [bitcoin] jonasschnelli pushed 8 new commits to master: https://github.com/bitcoin/bitcoin/compare/7e23972d1f71...25c56cdbe748 07:24 < bitcoin-git> bitcoin/master 11b6b5b Anthony Towns: Move ChainNameFromCommandLine into ArgsManager and rename to GetChainName 07:24 < bitcoin-git> bitcoin/master 834d303 Anthony Towns: [tests] Add unit tests for GetChainName 07:24 < bitcoin-git> bitcoin/master 6d5815a Anthony Towns: Separate out ReadConfigStream from ReadConfigFile 07:25 < bitcoin-git> [bitcoin] jonasschnelli closed pull request #12878: [refactor] Config handling refactoring in preparation for network-specific sections (master...netconf-refactor) https://github.com/bitcoin/bitcoin/pull/12878 07:26 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-bhyzkmfrrebisikj] has quit [Quit: Connection closed for inactivity] 07:29 -!- kanexxz [~kanexxz@p54A197F3.dip0.t-ipconnect.de] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 07:35 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 07:39 < bitcoin-git> [bitcoin] jonasschnelli closed pull request #12587: Introduce g_wallet_manager, prepare for better dynamic wallet loading/unloading (master...2018/03/dyn_wallet) https://github.com/bitcoin/bitcoin/pull/12587 07:50 -!- lnostdal [~lnostdal@85-118-92-44.mtel.net] has joined #bitcoin-core-dev 08:00 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 240 seconds] 08:03 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 08:04 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 08:04 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 08:30 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 08:38 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 08:40 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/25c56cdbe748...15c3bb4268f3 08:40 < bitcoin-git> bitcoin/master e36a0c0 Suhas Daftuar: [qa] Ensure bitcoind processes are cleaned up when tests end 08:40 < bitcoin-git> bitcoin/master 15c3bb4 Wladimir J. van der Laan: Merge #12904: [qa] Ensure bitcoind processes are cleaned up when tests end... 08:41 < bitcoin-git> [bitcoin] laanwj closed pull request #12904: [qa] Ensure bitcoind processes are cleaned up when tests end (master...2018-04-always-kill-bitcoind) https://github.com/bitcoin/bitcoin/pull/12904 08:41 < MarcoFalke> wumpus: ACK on removing "incubator" 08:47 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 08:51 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Quit: WeeChat 1.9.1] 08:51 -!- lnostdal [~lnostdal@85-118-92-44.mtel.net] has quit [Ping timeout: 260 seconds] 08:51 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 08:55 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 08:57 -!- lnostdal_ [~lnostdal@85-118-92-44.mtel.net] has joined #bitcoin-core-dev 08:57 -!- Arokh [~Arokh@extknot.com] has joined #bitcoin-core-dev 09:03 < wumpus> /home/orion/projects/bitcoin/bitcoin/src/interfaces/wallet.cpp:427:18: warning: lambda capture 'this' is not used [-Wunused-lambda-capture] 09:03 < wumpus> [fn, this](CWallet*, const uint256& txid, ChangeType status) { fn(txid, status); })); 09:05 < wumpus> MarcoFalke: sipa: fanquake: Your repository "bitcoin-core/bitcoin-incubator" was successfully deleted. 09:06 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 09:13 -!- Krellan [~Krellan@2601:640:4000:9258:79f8:267c:e8b4:5a19] has quit [Read error: Connection reset by peer] 09:13 -!- Krellan [~Krellan@2601:640:4000:9258:79f8:267c:e8b4:5a19] has joined #bitcoin-core-dev 09:14 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/15c3bb4268f3...97785863e2fa 09:14 < bitcoin-git> bitcoin/master 833bc08 Pieter Wuille: Add Slice: a (pointer, size) array view that acts like a container 09:14 < bitcoin-git> bitcoin/master 9272d70 Pieter Wuille: Support serializing Span and use that instead of FLATDATA 09:14 < bitcoin-git> bitcoin/master 9778586 Wladimir J. van der Laan: Merge #12886: Introduce Span type and use it instead of FLATDATA... 09:15 < bitcoin-git> [bitcoin] laanwj closed pull request #12886: Introduce Span type and use it instead of FLATDATA (master...201803_slice) https://github.com/bitcoin/bitcoin/pull/12886 09:16 -!- kanexxz [~kanexxz@p54A197F3.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 09:17 -!- lnostdal_ [~lnostdal@85-118-92-44.mtel.net] has quit [Ping timeout: 264 seconds] 09:18 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 256 seconds] 09:18 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 09:20 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-kiymhnxxaqfidnbg] has joined #bitcoin-core-dev 09:23 -!- rabidus [~rabidus@91-145-120-64.bb.dnainternet.fi] has quit [Ping timeout: 256 seconds] 09:23 -!- Sinclair6 [sinclair6@gateway/vpn/privateinternetaccess/sinclair6] has joined #bitcoin-core-dev 09:32 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 264 seconds] 09:33 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 09:34 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 264 seconds] 09:40 < bitcoin-git> [bitcoin] sipa opened pull request #12916: Introduce BigEndian wrapper and use it for netaddress ports (master...201804_beport) https://github.com/bitcoin/bitcoin/pull/12916 09:42 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 09:46 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 09:47 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Remote host closed the connection] 09:47 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Remote host closed the connection] 09:47 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 09:48 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 09:48 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #12917: qa: Windows fixups for functional tests (master...Mf1804-qaWinFixups) https://github.com/bitcoin/bitcoin/pull/12917 09:48 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev 09:49 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 09:53 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 09:53 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 09:54 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 09:55 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 09:55 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 09:57 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 09:59 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/97785863e2fa...bd42b85e8b42 09:59 < bitcoin-git> bitcoin/master 662d19f Suhas Daftuar: [rpcwallet] Clamp walletpassphrase value at 100M seconds... 09:59 < bitcoin-git> bitcoin/master 2b2b96c Suhas Daftuar: Use std::bind instead of boost::bind to re-lock the wallet... 09:59 < bitcoin-git> bitcoin/master bd42b85 MarcoFalke: Merge #12905: [rpcwallet] Clamp walletpassphrase value at 100M seconds... 10:00 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #12905: [rpcwallet] Clamp walletpassphrase value at 100M seconds (master...2018-04-wallet-encryption-timeout) https://github.com/bitcoin/bitcoin/pull/12905 10:06 -!- rabidus [~rabidus@91-145-120-64.bb.dnainternet.fi] has joined #bitcoin-core-dev 10:08 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 10:10 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 10:13 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 10:14 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 10:22 -!- CubicEarths [~cubiceart@239.11.24.31.ftth.as8758.net] has joined #bitcoin-core-dev 10:22 -!- dafunkiz_ [~dafunkizd@174.127.143.202] has joined #bitcoin-core-dev 10:24 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 10:27 -!- CubicEarths [~cubiceart@239.11.24.31.ftth.as8758.net] has quit [Remote host closed the connection] 10:32 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection] 10:32 -!- dafunkiz_ [~dafunkizd@174.127.143.202] has quit [Quit: probably someone interrupted me] 10:38 -!- dafunkiz_ [~dafunkizd@174.127.143.202] has joined #bitcoin-core-dev 10:47 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/bd42b85e8b42...27278dffe877 10:47 < bitcoin-git> bitcoin/master c9cce0a Will Ayd: Tests: Add Metaclass for BitcoinTestFramework... 10:47 < bitcoin-git> bitcoin/master 27278df Wladimir J. van der Laan: Merge #12856: Tests: Add Metaclass for BitcoinTestFramework... 10:48 < bitcoin-git> [bitcoin] laanwj closed pull request #12856: Tests: Add Metaclass for BitcoinTestFramework (master...meta-tst) https://github.com/bitcoin/bitcoin/pull/12856 10:51 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 10:58 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 11:00 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 11:04 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds] 11:09 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 11:11 -!- goatpig [56f75164@gateway/web/freenode/ip.86.247.81.100] has quit [Ping timeout: 260 seconds] 11:14 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has quit [Remote host closed the connection] 11:21 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has quit [Quit: Snoozing.] 11:31 -!- Krellan [~Krellan@2601:640:4000:9258:79f8:267c:e8b4:5a19] has quit [Read error: Connection reset by peer] 11:31 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has joined #bitcoin-core-dev 11:32 -!- Krellan [~Krellan@2601:640:4000:9258:79f8:267c:e8b4:5a19] has joined #bitcoin-core-dev 11:39 -!- dafunkiz_ [~dafunkizd@174.127.143.202] has quit [Quit: probably someone interrupted me] 11:39 -!- dafunkiz_ [~dafunkizd@174.127.143.202] has joined #bitcoin-core-dev 11:43 -!- dafunkiz_ [~dafunkizd@174.127.143.202] has quit [Client Quit] 11:44 -!- dafunkiz_ [~dafunkizd@174.127.143.202] has joined #bitcoin-core-dev 11:46 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 11:46 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 11:47 -!- dafunkiz_ [~dafunkizd@174.127.143.202] has quit [Client Quit] 11:47 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 11:49 -!- satwo [~textual@2602:306:378a:6fb0:acca:5852:c4c3:fd32] has joined #bitcoin-core-dev 11:49 -!- dafunkiz_ [~dafunkizd@174.127.143.202] has joined #bitcoin-core-dev 11:49 -!- laurentmt [~Thunderbi@ip124.67-202-83.static.steadfastdns.net] has quit [Quit: laurentmt] 11:50 -!- satwo [~textual@2602:306:378a:6fb0:acca:5852:c4c3:fd32] has quit [Client Quit] 11:50 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev 11:50 -!- satwo [~textual@2602:306:378a:6fb0:acca:5852:c4c3:fd32] has joined #bitcoin-core-dev 11:51 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 11:51 -!- wxss [~user@5.254.86.221] has quit [Quit: leaving] 11:59 -!- kanexxz [~kanexxz@p54A197F3.dip0.t-ipconnect.de] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 12:18 -!- Samdney [~Samdney@37.58.58.243] has quit [Quit: Verlassend] 12:22 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer] 12:23 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Remote host closed the connection] 12:27 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Quit: Leaving] 12:28 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 12:30 < luke-jr> wumpus: (re 0.17.0 relnotes issue) well, it did solicit newbie devs.. ;) 12:35 -!- dafunkiz_ [~dafunkizd@174.127.143.202] has quit [Quit: that's all folks] 12:36 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 12:50 -!- CubicEarths [~cubiceart@239.11.24.31.ftth.as8758.net] has joined #bitcoin-core-dev 12:51 -!- dafunkiz_ [~dafunkizd@174.127.143.202] has joined #bitcoin-core-dev 12:53 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 12:59 -!- CubicEarths [~cubiceart@239.11.24.31.ftth.as8758.net] has quit [Remote host closed the connection] 13:01 -!- CubicEarths [~cubiceart@239.11.24.31.ftth.as8758.net] has joined #bitcoin-core-dev 13:06 -!- dafunkiz_ [~dafunkizd@174.127.143.202] has quit [Quit: probably someone interrupted me] 13:06 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 240 seconds] 13:09 -!- booyah_ is now known as booyah 13:22 -!- r251d [~r251d@2600:1700:e350:37f0:ac24:4c91:5647:1fbe] has quit [Quit: WeeChat 2.1] 13:28 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 13:28 -!- CubicEarths [~cubiceart@239.11.24.31.ftth.as8758.net] has quit [Remote host closed the connection] 13:31 -!- satwo [~textual@2602:306:378a:6fb0:acca:5852:c4c3:fd32] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 13:32 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 13:36 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Ping timeout: 260 seconds] 13:38 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has quit [Read error: Connection reset by peer] 13:38 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has joined #bitcoin-core-dev 13:40 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 13:41 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 13:47 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 260 seconds] 13:52 -!- zautomata1 [~zautomata@41.233.234.170] has quit [Ping timeout: 255 seconds] 13:52 -!- zautomata3 [~zautomata@41.232.208.223] has joined #bitcoin-core-dev 13:53 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev 13:54 -!- d9b4bef9 [~d9b4bef9@207.38.94.106] has quit [Remote host closed the connection] 13:54 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Remote host closed the connection] 13:55 -!- d9b4bef9 [~d9b4bef9@207.38.94.106] has joined #bitcoin-core-dev 13:57 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 14:07 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-ocnvgbuhsqqnutix] has joined #bitcoin-core-dev 14:09 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has quit [Quit: Snoozing.] 14:14 -!- JackH [~laptop@host-80-47-80-55.as13285.net] has quit [Quit: Leaving] 14:14 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 14:21 -!- JackH [~laptop@host-80-47-80-55.as13285.net] has joined #bitcoin-core-dev 14:39 -!- Guest34 [5dc339e3@gateway/web/cgi-irc/kiwiirc.com/ip.93.195.57.227] has joined #bitcoin-core-dev 14:40 < Guest34> that was me :-) 14:40 < Guest34> I don't want to spam the ticket, but I really don't understand the "good first issue to read" logic 14:41 < Guest34> I mean, the tricky part is getting your code merged, whether it'll bee released 2 months later or 6 months later is secondary 14:42 < Guest34> you might as well make a ticket called "read the developer notes" and tag it as "good first issue" if the intention is to provide recommended reading material 14:42 < Guest34> anyways, just my two cents, feel free to ignore 14:48 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 14:54 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 15:05 -!- opdenkamp [~opdenkamp@kodi/staff/dushmaniac] has joined #bitcoin-core-dev 15:07 -!- tester2 [~tester@37.19.109.197] has joined #bitcoin-core-dev 15:18 -!- tester2 [~tester@37.19.109.197] has quit [] 15:19 -!- tester2 [~tester@37.19.109.197] has joined #bitcoin-core-dev 15:19 -!- vicenteH [~user@35.233.15.37.dynamic.jazztel.es] has quit [Ping timeout: 240 seconds] 15:43 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 15:44 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has quit [Client Quit] 15:56 -!- satwo [~textual@2602:306:378a:6fb0:acca:5852:c4c3:fd32] has joined #bitcoin-core-dev 15:59 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 16:10 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 256 seconds] 16:15 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 16:15 -!- Krellan [~Krellan@2601:640:4000:9258:79f8:267c:e8b4:5a19] has quit [Read error: Connection reset by peer] 16:16 -!- Krellan [~Krellan@2601:640:4000:9258:79f8:267c:e8b4:5a19] has joined #bitcoin-core-dev 16:16 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-ocnvgbuhsqqnutix] has quit [Quit: Connection closed for inactivity] 16:17 -!- satwo [~textual@2602:306:378a:6fb0:acca:5852:c4c3:fd32] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 16:18 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 16:19 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 16:23 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds] 16:23 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has quit [Remote host closed the connection] 16:28 -!- tester2 [~tester@37.19.109.197] has quit [Read error: Connection reset by peer] 16:29 -!- tester2 [~tester@77.243.25.136] has joined #bitcoin-core-dev 16:32 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 256 seconds] 16:38 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 16:41 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 16:48 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 16:48 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has quit [Quit: Snoozing.] 16:51 < bitcoin-git> [bitcoin] kallewoof opened pull request #12918: test: Assert on correct variable (master...test-typo-rpcrawtx) https://github.com/bitcoin/bitcoin/pull/12918 17:00 -!- weez17 [~isaac@unaffiliated/weez17] has quit [Remote host closed the connection] 17:00 -!- weez17 [~isaac@unaffiliated/weez17] has joined #bitcoin-core-dev 17:02 -!- d9b4bef9 [~d9b4bef9@207.38.94.106] has quit [Remote host closed the connection] 17:03 -!- d9b4bef9 [~d9b4bef9@207.38.94.106] has joined #bitcoin-core-dev 17:04 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 17:05 -!- tester2 [~tester@77.243.25.136] has quit [Ping timeout: 260 seconds] 17:06 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 17:06 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 17:06 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 17:06 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 17:09 -!- rls [~rls@2600:8800:1e00:9e1:a885:6066:6f77:c599] has joined #bitcoin-core-dev 17:15 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 17:43 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 17:47 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 240 seconds] 17:54 -!- pyericz_ [~pyericz@117.30.166.149] has joined #bitcoin-core-dev 18:00 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has joined #bitcoin-core-dev 18:04 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 18:04 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev 18:09 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 260 seconds] 18:10 -!- lifeofguenter [~lifeofgue@bnc.pro.to.co.ls] has quit [Ping timeout: 276 seconds] 18:11 -!- lifeofguenter [~lifeofgue@bnc.pro.to.co.ls] has joined #bitcoin-core-dev 18:12 -!- dafunkiz_ [~dafunkizd@172.92.143.143] has quit [Quit: probably someone interrupted me] 18:30 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-kiymhnxxaqfidnbg] has quit [Quit: Connection closed for inactivity] 18:34 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev 18:34 -!- satwo [~textual@2602:306:378a:6fb0:acca:5852:c4c3:fd32] has joined #bitcoin-core-dev 18:34 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev 18:37 -!- Krellan [~Krellan@2601:640:4000:9258:79f8:267c:e8b4:5a19] has quit [Read error: Connection reset by peer] 18:38 -!- Krellan [~Krellan@2601:640:4000:9258:79f8:267c:e8b4:5a19] has joined #bitcoin-core-dev 18:52 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net] 18:56 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 18:56 -!- satwo [~textual@2602:306:378a:6fb0:acca:5852:c4c3:fd32] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 19:06 -!- moneyball [~moneyball@c-73-223-73-149.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 19:22 -!- rev_strangehope [~revstrang@ec2-13-115-230-7.ap-northeast-1.compute.amazonaws.com] has joined #bitcoin-core-dev 19:29 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 19:29 -!- moneyball [~moneyball@c-73-223-73-149.hsd1.ca.comcast.net] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…] 19:41 -!- lifeofguenter [~lifeofgue@bnc.pro.to.co.ls] has quit [Ping timeout: 265 seconds] 19:42 -!- lifeofguenter [~lifeofgue@bnc.pro.to.co.ls] has joined #bitcoin-core-dev 19:47 -!- moneyball [~moneyball@c-73-223-73-149.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 19:53 -!- moneyball [~moneyball@c-73-223-73-149.hsd1.ca.comcast.net] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…] 19:53 -!- moneyball [~moneyball@c-73-223-73-149.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 19:54 -!- grafcaps [~haroldbr@50.90.83.229] has quit [Ping timeout: 265 seconds] 19:55 -!- moneyball [~moneyball@c-73-223-73-149.hsd1.ca.comcast.net] has quit [Client Quit] 19:58 < kallewoof> I'm a little confused about coinbase transactions and 'is all from me'. Currently, CWallet::IsAllFromMe will say no to a coinbase transaction, even (it appears) if it's the miner's wallet. The check itself tries to find the prevout in the wallet, but prevout is 0000..., so it obviously won't be there. This causes issues with the IsAllFromMe PR (#12508), which I patched by explicitly saying 'true' 19:58 < kallewoof> for coinbase txs in CWallet::IsAllFromMe, but I wonder if this will cause everyone to think they own all coinbase transactions... 19:58 < gribble> https://github.com/bitcoin/bitcoin/issues/12508 | IsAllFromMe by kallewoof · Pull Request #12508 · bitcoin/bitcoin · GitHub 19:59 -!- moneyball [~moneyball@c-73-223-73-149.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 20:00 < kallewoof> Then again, if it's a coinbase tx, it will have 100+ confirmations, so in all cases where IsAllFromMe matters (mostly unconfirmed, or low confirm count), it's irrelevant. 20:00 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds] 20:00 -!- grafcaps [~haroldbr@50.90.83.229] has joined #bitcoin-core-dev 20:00 < wumpus> hmm interesting 20:01 < kallewoof> Or is there a case where a 100+ confirm input being mine or not mine makes a difference? I guess in spending it someone could double spend, so ^ is probably not right.. 20:02 < wumpus> for 100+ confirms there is no difference. The reason for the 100 depth is to make sure it's deep enough to avoid any realistic reorgs causing trouble. 20:03 < kallewoof> wumpus: Right. But I realized someone could spend a coinbase tx sending 12.5 btc to me, my node would think it was 'from me' and act accordingly, and then they would double spend it and I would risk losing 12.5 btc. 20:04 < luke-jr> huh? I don't understand what you're saying at all 20:04 < luke-jr> generated coins are from noone.. 20:04 < kallewoof> luke-jr: Me neither. I think I'm very confused. 20:05 < sipa> from me means that the inputs were coins treated as yours 20:05 < kallewoof> Right. So a coinbase input would not be considered yours even if you created the block? 20:05 < wumpus> it's impossible to double-spend a coinbase, by definition the coinbase can only be in the block where the reward is taken 20:05 < luke-jr> kallewoof: the coinbase isn't really an input at all, just dummy data 20:06 < kallewoof> A coinbase transaction has a coinbase input and an output. I was talking about double spending the output. 20:06 < kallewoof> luke-jr: The question is, should IsAllFromMe(a coinbase tx) say true or false, for the miner mining it? 20:06 < luke-jr> false obviously? 20:06 < luke-jr> it's TO the miner, not FROM him 20:08 < kallewoof> luke-jr: All right. That makes things a bit tricky, I guess, but I'll dig. 20:09 < kallewoof> luke-jr: It doesn't seem like morcos's initial idea in #9167 is compatible with your interpretation, though: "Created a new wallet and walletTx function IsAllFromMe which correctly computes whether all the inputs to a transaction match the requested IsMine filter. 20:09 < gribble> https://github.com/bitcoin/bitcoin/issues/9167 | IsAllFromMe by morcos · Pull Request #9167 · bitcoin/bitcoin · GitHub 20:09 < sipa> kallewoof: i don't understand why you're concerned about coinbase txn at all 20:10 < sipa> coinbases are by definition never from anything 20:10 < kallewoof> sipa: IsMine says true and IsAllFromMe says false for coinbase txs 20:10 < sipa> yes, as it should? 20:11 < kallewoof> Sorry, I meant, IsFromMe and IsAllFromMe say true/false for coinbase 20:11 < sipa> yes, why is that a problem? 20:11 -!- pyericz_ [~pyericz@117.30.166.149] has quit [Quit: This computer has gone to sleep] 20:12 -!- grafcaps [~haroldbr@50.90.83.229] has quit [Ping timeout: 256 seconds] 20:12 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Remote host closed the connection] 20:13 < kallewoof> Wait, are coinbase transactions from me or not from me? If IsFromMe says true and there's only a coinbase input why would IsAllFromMe say false? Shouldn't both say the same in this case? 20:13 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev 20:13 < kallewoof> luke-jr says false is correct. In which case IsFromMe is wrong, no? 20:13 < sipa> wait 20:13 < sipa> oh, IsFromMe is true? 20:13 < kallewoof> Yes 20:13 < sipa> that i don't understand! 20:13 -!- pyericz_ [~pyericz@117.30.166.149] has joined #bitcoin-core-dev 20:14 < sipa> maybe it's a special rule for foinbase tzn 20:14 < sipa> coinbase tzn 20:14 < kallewoof> All it does is check GetDebit(tx, ISMINE_ALL) > 0 20:14 < sipa> txn 20:14 < kallewoof> Right -- I'm saying I need to add that to CWallet::IsAllFromMe as well. 20:14 < kallewoof> that=the special rule for coinbase txs 20:14 < sipa> what is IsAllFromMe even used for? 20:15 < kallewoof> That's a great question. It seems to be used in feebumper, and in wallet.cpp in some places. 20:16 < kallewoof> Actually no it's only used in feebumper on master. 20:17 < sipa> yay 20:17 < kallewoof> So it seems completely fine to allow the special case. 20:17 < sipa> well, you can't feebump a coinbase! 20:17 * kallewoof nods 20:17 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Ping timeout: 260 seconds] 20:19 -!- jtimon [~quassel@142.29.134.37.dynamic.jazztel.es] has quit [Ping timeout: 264 seconds] 20:21 -!- ken2812221 [~User@133-203.dorm.ncu.edu.tw] has quit [Read error: Connection reset by peer] 20:22 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 264 seconds] 20:29 -!- ken2812221 [~User@133-203.dorm.ncu.edu.tw] has joined #bitcoin-core-dev 20:29 -!- ken2812221 [~User@133-203.dorm.ncu.edu.tw] has quit [Read error: Connection reset by peer] 20:32 -!- ken2812221 [~User@133-203.dorm.ncu.edu.tw] has joined #bitcoin-core-dev 20:37 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev 20:55 -!- Krellan [~Krellan@2601:640:4000:9258:79f8:267c:e8b4:5a19] has quit [Read error: Connection reset by peer] 20:56 -!- Krellan [~Krellan@2601:640:4000:9258:79f8:267c:e8b4:5a19] has joined #bitcoin-core-dev 20:57 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/27278dffe877...4781813b5617 20:57 < bitcoin-git> bitcoin/master 08b17de Karl-Johan Alm: [arith_uint256] Do not destroy *this content if passed-in operator may reference it 20:57 < bitcoin-git> bitcoin/master b120f7b Karl-Johan Alm: [test] Add tests for self usage in arith_uint256 20:57 < bitcoin-git> bitcoin/master 4781813 Wladimir J. van der Laan: Merge #12537: [arith_uint256] Make it safe to use "self" in operators... 20:58 < bitcoin-git> [bitcoin] laanwj closed pull request #12537: [arith_uint256] Make it safe to use "self" in operators (master...uint-safe-self-op) https://github.com/bitcoin/bitcoin/pull/12537 21:07 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev 21:10 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Client Quit] 21:13 -!- Michael___ [7ded2589@gateway/web/freenode/ip.125.237.37.137] has joined #bitcoin-core-dev 21:14 -!- moneyball [~moneyball@c-73-223-73-149.hsd1.ca.comcast.net] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…] 21:15 -!- pyericz_ [~pyericz@117.30.166.149] has quit [Quit: This computer has gone to sleep] 21:28 -!- grafcaps [~haroldbr@50.90.83.229] has joined #bitcoin-core-dev 21:43 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 21:48 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 263 seconds] 21:58 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev 21:59 -!- Michael___ [7ded2589@gateway/web/freenode/ip.125.237.37.137] has quit [Ping timeout: 260 seconds] 22:04 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Remote host closed the connection] 22:04 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev 22:05 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Remote host closed the connection] 22:05 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev 22:06 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Ping timeout: 240 seconds] 22:09 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev 22:15 -!- lnostdal_ [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev 22:16 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Ping timeout: 265 seconds] 22:17 -!- goatpig [56f75164@gateway/web/freenode/ip.86.247.81.100] has joined #bitcoin-core-dev 22:40 -!- zautomata3 [~zautomata@41.232.208.223] has quit [Ping timeout: 260 seconds] 22:45 -!- zautomata4 [~zautomata@41.232.217.163] has joined #bitcoin-core-dev 22:54 -!- grafcaps [~haroldbr@50.90.83.229] has quit [Ping timeout: 240 seconds] 22:56 < bitcoin-git> [bitcoin] VizXu opened pull request #12919: no message (0.8...master) https://github.com/bitcoin/bitcoin/pull/12919 22:57 < bitcoin-git> [bitcoin] fanquake closed pull request #12919: no message (0.8...master) https://github.com/bitcoin/bitcoin/pull/12919 23:02 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Remote host closed the connection] 23:02 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev 23:03 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Remote host closed the connection] 23:03 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev 23:09 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has quit [Quit: Snoozing.] 23:10 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 23:11 -!- kanexxz [~kanexxz@p54A197F3.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 23:11 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 23:11 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 23:15 -!- grafcaps [~haroldbr@50.90.83.229] has joined #bitcoin-core-dev 23:15 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 255 seconds] 23:16 -!- Krellan [~Krellan@2601:640:4000:9258:79f8:267c:e8b4:5a19] has quit [Read error: Connection reset by peer] 23:17 -!- Krellan [~Krellan@2601:640:4000:9258:4045:c6ec:ae70:b7a0] has joined #bitcoin-core-dev 23:19 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Remote host closed the connection] 23:19 -!- grafcaps [~haroldbr@50.90.83.229] has quit [Ping timeout: 245 seconds] 23:20 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev 23:23 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Remote host closed the connection] 23:23 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev 23:24 -!- Guest34 [5dc339e3@gateway/web/cgi-irc/kiwiirc.com/ip.93.195.57.227] has quit [Remote host closed the connection] 23:29 -!- benma [~benma@178.197.231.250] has joined #bitcoin-core-dev 23:29 -!- benma [~benma@178.197.231.250] has quit [Changing host] 23:29 -!- benma [~benma@unaffiliated/benma] has joined #bitcoin-core-dev 23:33 -!- RoyceX [~Cheeseo@unaffiliated/cheeseo] has joined #bitcoin-core-dev 23:36 -!- cheese_ [~Cheeseo@unaffiliated/cheeseo] has quit [Ping timeout: 252 seconds] 23:39 -!- harrymm_ [~harrymm@104.207.83.40] has joined #bitcoin-core-dev 23:41 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 260 seconds] 23:42 -!- harrymm [~harrymm@104.207.83.36] has quit [Ping timeout: 276 seconds] 23:51 -!- cheese_ [~Cheeseo@unaffiliated/cheeseo] has joined #bitcoin-core-dev 23:52 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Remote host closed the connection] 23:52 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev 23:53 -!- grafcaps [~haroldbr@50.90.83.229] has joined #bitcoin-core-dev 23:54 -!- RoyceX [~Cheeseo@unaffiliated/cheeseo] has quit [Ping timeout: 252 seconds] 23:57 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Remote host closed the connection] 23:57 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev 23:58 -!- grafcaps [~haroldbr@50.90.83.229] has quit [Ping timeout: 276 seconds]