--- Day changed Thu Apr 19 2018
00:01 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has quit [Remote host closed the connection]     
00:01 -!- Krellan [~Krellan@2601:640:4000:9258:3961:e3c3:17a:3332] has quit [Read error: Connection reset by peer]     
00:02 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev     
00:02 -!- Krellan [~Krellan@2601:640:4000:9258:c0d:262e:95c7:7104] has joined #bitcoin-core-dev     
00:15 -!- tylevine [~tylevine@li120-195.members.linode.com] has quit [Quit: The Lounge - https://thelounge.github.io]     
00:15 -!- tylevine [~tylevine@li120-195.members.linode.com] has joined #bitcoin-core-dev     
00:18 -!- bedo [~bedo@62-11-53-104.dialup.tiscali.it] has joined #bitcoin-core-dev     
00:21 <@wumpus> kallewoof: TX_CONF (0x03) has 8 bytes reserved for block height - it's good to plan ahead when designing formats, but 80000 years is maybe a bit much :)
00:22 <@wumpus> kallewoof: also please add some header magic, and a format version
00:23 -!- bedo is now known as bedotech     
00:23 <@wumpus> kallewoof: especially as the packet types have no framing information of themselves, this means the format is not forward compatible, so readers need to be able to reject newer files
00:24 <@wumpus> (e.g. no way to skip unknown records or fields)
00:24 <@wumpus> (which is a valid decision with regard to storage, but maybe needs to be documented)
00:26 -!- zarez [~Thunderbi@fs-93-93-44-38.fullsave.info] has joined #bitcoin-core-dev     
00:27 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Remote host closed the connection]     
00:30 -!- tylevine [~tylevine@li120-195.members.linode.com] has quit [Quit: The Lounge - https://thelounge.github.io]     
00:30 -!- tylevine [~tylevine@li120-195.members.linode.com] has joined #bitcoin-core-dev     
00:30 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has quit [Quit: Snoozing.]     
00:31 < bedotech> Hi all, currently bitcoin-core what kind of wallet derivation implement? (for example BIP44 and so on...)
00:32 <@wumpus> bip32 hierarchical deterministic wallet
00:32 <@wumpus> not bip44, you can find the implemented bips in doc/bips.md
00:33 < bedotech> wumpus: thanks a lot
00:34 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev     
00:39 < fanquake> wumpus looks like #12855 is ready to go now that sipa's nit has been fixed
00:39 < gribble> https://github.com/bitcoin/bitcoin/issues/12855 | net: Minor accumulated cleanups by tjps · Pull Request #12855 · bitcoin/bitcoin · GitHub
00:45 -!- grafcaps [~haroldbr@50.90.83.229] has joined #bitcoin-core-dev     
00:49 -!- grafcaps [~haroldbr@50.90.83.229] has quit [Ping timeout: 248 seconds]     
00:51 -!- crt4 [~hk@host217-35-240-133.range217-35.btcentralplus.com] has joined #bitcoin-core-dev     
00:59 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Remote host closed the connection]     
01:00 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev     
01:00 < bedotech> i want to build a online service that generate address from extended public key, is better to use backward compatibility P2SH-P2WPKH or i can use direct P2WPKH? 
01:01 < fanquake> bedotech ask in #bitcoin
01:01 < bedotech> fanquake: thanks!
01:01 < fanquake> or #bitcoin-dev
01:04 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Ping timeout: 240 seconds]     
01:04 -!- zarez [~Thunderbi@fs-93-93-44-38.fullsave.info] has quit [Remote host closed the connection]     
01:05 -!- zarez [~Thunderbi@fs-93-93-44-38.fullsave.info] has joined #bitcoin-core-dev     
01:08 -!- jtimon [~quassel@142.29.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev     
01:23 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev     
01:23 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev     
01:29 -!- drizztbsd [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev     
01:29 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 248 seconds]     
01:33 -!- drizztbsd [~tredaelli@redhat/timothy] has quit [Remote host closed the connection]     
01:39 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit []     
01:42 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev     
01:43 -!- anstaendig [~anstaendi@185.212.149.4] has quit [Ping timeout: 260 seconds]     
01:55 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev     
02:01 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection]     
02:02 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has joined #bitcoin-core-dev     
02:02 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev     
02:09 -!- anstaendig [~anstaendi@185.212.149.4] has joined #bitcoin-core-dev     
02:14 -!- Krellan [~Krellan@2601:640:4000:9258:c0d:262e:95c7:7104] has quit [Ping timeout: 265 seconds]     
02:15 -!- geezas [uid253218@gateway/web/irccloud.com/x-dmggjsxdejimvvro] has quit [Quit: Connection closed for inactivity]     
02:16 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Remote host closed the connection]     
02:16 -!- laurentmt [~Thunderbi@37.58.58.232] has joined #bitcoin-core-dev     
02:17 < bitcoin-git> [bitcoin] promag opened pull request #13026: Fix include comment in src/interfaces/wallet.h (master...2018-04-fixincludecomment) https://github.com/bitcoin/bitcoin/pull/13026
02:17 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev     
02:22 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-qkcfmuycmrfpsdjc] has joined #bitcoin-core-dev     
02:24 -!- laurentmt [~Thunderbi@37.58.58.232] has quit [Quit: laurentmt]     
02:28 -!- zautomata2 [~zautomata@41.232.208.168] has joined #bitcoin-core-dev     
02:31 -!- crt4 [~hk@host217-35-240-133.range217-35.btcentralplus.com] has quit [Quit: crt4]     
02:33 -!- grafcaps [~haroldbr@50.90.83.229] has joined #bitcoin-core-dev     
02:37 -!- grafcaps [~haroldbr@50.90.83.229] has quit [Ping timeout: 240 seconds]     
02:40 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has quit [Remote host closed the connection]     
02:41 -!- zautomata2 [~zautomata@41.232.208.168] has quit [Quit: WeeChat 1.9.1]     
02:41 -!- zautomata [~zautomata@41.232.208.168] has joined #bitcoin-core-dev     
02:44 -!- goatpig [56f75200@gateway/web/freenode/ip.86.247.82.0] has joined #bitcoin-core-dev     
02:47 -!- wxss [~user@185.117.118.224] has joined #bitcoin-core-dev     
03:07 -!- anstaendig [~anstaendi@185.212.149.4] has quit [Ping timeout: 256 seconds]     
03:11 -!- anstaendig [~anstaendi@185.212.149.4] has joined #bitcoin-core-dev     
03:23 -!- Samdney [~Samdney@80.255.10.196] has joined #bitcoin-core-dev     
03:24 -!- CubicEarths [~cubiceart@xdsl-188-155-63-9.adslplus.ch] has quit [Remote host closed the connection]     
03:27 -!- anstaendig [~anstaendi@185.212.149.4] has quit [Ping timeout: 264 seconds]     
03:28 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Remote host closed the connection]     
03:35 -!- pergaminho [~Cleber@201.47.91.172] has quit [Quit: This computer has gone to sleep]     
03:58 -!- anstaendig [~anstaendi@185.212.149.4] has joined #bitcoin-core-dev     
04:04 -!- pergaminho [~Cleber@201.47.91.172] has joined #bitcoin-core-dev     
04:23 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
04:24 -!- CubicEarths [~cubiceart@178.197.231.239] has joined #bitcoin-core-dev     
04:25 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
04:26 -!- jchysk [~yo@63.147.87.170] has quit [Ping timeout: 256 seconds]     
04:28 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 276 seconds]     
04:29 < jtimon> fixed nits on https://github.com/bitcoin/bitcoin/pull/10757 , in case anyone was waiting for that to review
04:37 -!- mistergold [~mistergol@37.19.109.49] has joined #bitcoin-core-dev     
04:39 -!- jchysk [~yo@63.147.87.170] has joined #bitcoin-core-dev     
04:45 -!- CubicEarths [~cubiceart@178.197.231.239] has quit [Remote host closed the connection]     
04:52 -!- jtimon [~quassel@142.29.134.37.dynamic.jazztel.es] has quit [Ping timeout: 260 seconds]     
04:53 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection]     
04:55 -!- Samdney [~Samdney@80.255.10.196] has quit [Ping timeout: 265 seconds]     
05:00 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/615f7c288414...39cf27faf324
05:00 < bitcoin-git> bitcoin/master b382004 Thomas Snider: benchmark: Removed bench/perf.cpp
05:00 < bitcoin-git> bitcoin/master 1bf3f33 Thomas Snider: node: Removed unused wallet-related methods from the Node interface.
05:00 < bitcoin-git> bitcoin/master 39cf27f MarcoFalke: Merge #13025: Dead code removal...
05:01 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #13025: Dead code removal (master...tjps_dead_code) https://github.com/bitcoin/bitcoin/pull/13025
05:18 -!- pergaminho [~Cleber@201.47.91.172] has quit [Quit: Saindo]     
05:19 <@wumpus> MarcoFalke: I don't get it, why are you removing perf.cpp/h?
05:20 <@wumpus> MarcoFalke: is counting cpu cycles no longer relevant?
05:21 <@wumpus> I really don't get this, without any discussion
05:24 < sipa> wumpus: it seems the code is actually unused
05:24 -!- shtirlic_ [~shtirlic@167.99.19.62] has quit [Quit: ZNC - http://znc.in]     
05:25 < sipa> only perf_init and perf_fini are invoked
05:25 < sipa> or is your point that we expect to use them again for another purpose soon?
05:25 -!- shtirlic_ [~shtirlic@Shtirlic-3-pt.tunnel.tserv11.ams1.ipv6.he.net] has joined #bitcoin-core-dev     
05:26 < sipa> (i don't have an opinion either way, just want to make sure it's clear what is happening)
05:30 < MarcoFalke> wumpus: The discussion was in the pull that removed the usage, IIRC
05:31 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev     
05:31 <@wumpus> it used to be that the benchmarks reported number of cycles too
05:31 <@wumpus> apparently that was changed, and now my code to measure cycles was removed too
05:31 <@wumpus> no one ever asked me about any of this
05:31 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-qkcfmuycmrfpsdjc] has quit [Quit: Connection closed for inactivity]     
05:32 <@wumpus> "I have removed the cycles statistics because I personally don't think it is necessary, and it simplifies the code. I could add it back though if others think its a helpful statistic" 
05:33 <@wumpus> wtf asked him :/
05:33 <@wumpus> apparently I even reviewed that and missed that
05:35 <@wumpus> but you can't say there really was any discussion
05:35 < MarcoFalke> fine
05:35 < MarcoFalke> Is there any evidence that this actually is a statistic that is not redundant?
05:36 <@wumpus> redundant compared to what?
05:36 < MarcoFalke> std::chrono
05:36 <@wumpus> well std::chrono counts time, not cycles
05:36 < MarcoFalke> (the clock we use right now)
05:37 <@wumpus> e.g. not when the cpu is actually idle
05:38 < MarcoFalke> I asssume the only difference would be in the deser block test?
05:39 <@wumpus> I don't know. It's entirely valid to have a discussion about whether it is redundent or not, but I think how this went is absurd
05:40 < MarcoFalke> It was unused for months now, and no one noticed. I don't think removing the code as it was unused is absurd.
05:40 < MarcoFalke> I am not saying we can't add it back in
05:40 <@wumpus> right I haven't been using the benchmarks the last months
05:41 < MarcoFalke> When added back, it should be an optional swich (clock/cycles), so the format doesn't change again
05:42 < sipa> FWIW, if we continue work on platform specific SHA256 implementations, itay be necessary to do a mini benchmark at startup to determine what is fastest... generally cpu cycles are the most accurate way of doing that
05:42 <@wumpus> well I"m not going to bother that's for sure
05:43 <@wumpus> if I need this again I'll just patch it in locally
05:43 < MarcoFalke> sipa: That means the fuction should be moved to util.cpp?
05:43 < sipa> wumpus: i think you're overreacting
05:43 -!- shtirlic_ [~shtirlic@Shtirlic-3-pt.tunnel.tserv11.ams1.ipv6.he.net] has quit [Quit: ZNC - http://znc.in]     
05:43 < sipa> people who reviewed this missed this, and acted in good faith
05:43 < sipa> we can trivially bring the code back
05:44 -!- shtirlic_ [~shtirlic@Shtirlic-3-pt.tunnel.tserv11.ams1.ipv6.he.net] has joined #bitcoin-core-dev     
05:44 <@wumpus> yes it was also my own dumb fault for not noticing it, on the other hand that PR changed so much in the format it was easy to miss
05:46 < sipa> if counting cpu cycles actually more reliable then counting time in benchmarks? i generally lock my cpu to a single frequency to do benchmarks, as noise complicates things otherwise, but i never botheres trying to look at cpu cycles
05:47 < MarcoFalke> sipa: That was my though. Only difference would be when cpu waits on io?
05:48 < sipa> MarcoFalke: waiting on IO does not directly reduce clock rate 
05:48 -!- anstaendig [~anstaendi@185.212.149.4] has quit [Ping timeout: 248 seconds]     
05:49 < sipa> it could cause a switch to a different process though (but then cpu time is not counted anymore, while cycles are!)
05:49 < MarcoFalke> oh, cycles are still counted?
05:50 < MarcoFalke> In which case it would be identical to clock
05:50 < sipa> yes, the cycle counter is per cpu thread
05:50 < sipa> which clock are we using?
05:50 < sipa> cpu time or wall time?
05:50 < MarcoFalke> Yeah, I think BlueMatt told me something that the clock might be using cycles internally
05:51 < MarcoFalke> std::chrono::steady_clock mostly
05:51 < MarcoFalke> fallback to std::chrono::high_resolution_clock
05:52 < MarcoFalke> other way round, sorry
05:53 < sipa> yup, sorry  those also keep ticking if a process if not executing
05:54 < sipa> though it's unclear what those clocks really dl
05:54 <@wumpus> it's one big stack of abstractions
05:54 < sipa> they may use system calls
05:55 < sipa> which are completely inappropriate if you want to measure very short running pieces of code (sub microsecond)
05:55 <@wumpus> at least cpu cycles is a clear, transparant metric, the only problem is that it's not available on all architectures, and on e.g. ARM it needs system calls to measure :-/
05:56 < MarcoFalke> sipa: I think that is why we loop a bit before taking the clock
05:56 < MarcoFalke> in fact the iterations are hardcoded
05:57 < sipa> that may be historical
05:57 < sipa> the benchmarks used to be entirely self-measuring (aiming to run for 1s)
05:58 -!- zautomata [~zautomata@41.232.208.168] has quit [Changing host]     
05:58 -!- zautomata [~zautomata@unaffiliated/zautomata] has joined #bitcoin-core-dev     
05:58 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 276 seconds]     
05:58  * sipa sleeps some more
05:58 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/39cf27faf324...c19986940869
05:58 < bitcoin-git> bitcoin/master 2c084a6 Thomas Snider: net: Minor accumulated cleanups
05:58 < bitcoin-git> bitcoin/master c199869 Wladimir J. van der Laan: Merge #12855: net: Minor accumulated cleanups...
05:59 < bitcoin-git> [bitcoin] laanwj closed pull request #12855: net: Minor accumulated cleanups (master...tjps_misc_cleans) https://github.com/bitcoin/bitcoin/pull/12855
06:00 -!- Prady [c760e1bd@gateway/web/freenode/ip.199.96.225.189] has joined #bitcoin-core-dev     
06:01 -!- Prady [c760e1bd@gateway/web/freenode/ip.199.96.225.189] has quit [Client Quit]     
06:02 <@wumpus> but yes I was overreacting, sorry MarcoFalke
06:04 < MarcoFalke> wumpus: no worries :)
06:09 -!- grafcaps [~haroldbr@50.90.83.229] has joined #bitcoin-core-dev     
06:11 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-vigylvdkfimojlwf] has joined #bitcoin-core-dev     
06:12 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev     
06:13 -!- grafcaps [~haroldbr@50.90.83.229] has quit [Ping timeout: 240 seconds]     
06:15 -!- anstaendig [~anstaendi@185.212.149.4] has joined #bitcoin-core-dev     
06:16 -!- Cogito_Ergo_Sum [~Myself@athedsl-314680.home.otenet.gr] has joined #bitcoin-core-dev     
06:16 -!- Cogito_Ergo_Sum [~Myself@athedsl-314680.home.otenet.gr] has quit [Changing host]     
06:16 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has joined #bitcoin-core-dev     
06:27 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev     
06:27 -!- jtimon [~quassel@142.29.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev     
06:35 -!- Dizzle [~dizzle@108.171.182.16] has joined #bitcoin-core-dev     
06:35 < promag> I would really appreciate some reviews in #13017, ty
06:35 < gribble> https://github.com/bitcoin/bitcoin/issues/13017 | Add wallets management functions by promag · Pull Request #13017 · bitcoin/bitcoin · GitHub
06:36 < promag> simple stuff
06:37 -!- crt4 [~hk@213.205.192.248] has joined #bitcoin-core-dev     
06:39 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 256 seconds]     
06:40 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev     
06:48 -!- mistergold [~mistergol@37.19.109.49] has quit [Quit: leaving]     
06:51 -!- CubicEarths [~cubiceart@178.197.231.116] has joined #bitcoin-core-dev     
06:52 < bitcoin-git> [bitcoin] promag opened pull request #13028: Make vpwallets usage thread safe (master...2018-04-cs_wallets) https://github.com/bitcoin/bitcoin/pull/13028
06:54 -!- CubicEarths [~cubiceart@178.197.231.116] has quit [Remote host closed the connection]     
07:13 -!- drizztbsd [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev     
07:13 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 248 seconds]     
07:14 -!- laurentmt [~Thunderbi@37.58.58.232] has joined #bitcoin-core-dev     
07:14 -!- akolen [59ce61e9@gateway/web/freenode/ip.89.206.97.233] has joined #bitcoin-core-dev     
07:16 -!- akolen [59ce61e9@gateway/web/freenode/ip.89.206.97.233] has quit [Client Quit]     
07:21 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev     
07:24 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 256 seconds]     
07:26 < BlueMatt> sipa: the reason the iteration count was hardcoded is cause the time measured changed a shitload depending on iteration counts
07:27 < BlueMatt> so hardcoding was easier to get more stable results than running it 20 times until you had a bunch of results for the iteration count you wanted
07:27 < bitcoin-git> [bitcoin] Sjors opened pull request #13029: Interpret absense of prune= as prune=1 if there are pruned blocks (master...2018/04/implicit_prune) https://github.com/bitcoin/bitcoin/pull/13029
07:43 -!- contrapumpkin [~copumpkin@haskell/developer/copumpkin] has joined #bitcoin-core-dev     
07:48 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]     
07:51 -!- grafcaps [~haroldbr@50.90.26.145] has joined #bitcoin-core-dev     
08:00 -!- grafcaps [~haroldbr@50.90.26.145] has quit [Ping timeout: 264 seconds]     
08:02 -!- Krellan [~Krellan@2601:640:4000:9258:c0d:262e:95c7:7104] has joined #bitcoin-core-dev     
08:03 -!- zarez [~Thunderbi@fs-93-93-44-38.fullsave.info] has quit [Ping timeout: 248 seconds]     
08:03 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev     
08:04 -!- drizztbsd [~tredaelli@redhat/timothy] has quit [Ping timeout: 248 seconds]     
08:06 -!- zarez [~Thunderbi@fs-93-93-44-38.fullsave.info] has joined #bitcoin-core-dev     
08:08 -!- drizztbsd [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev     
08:09 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 256 seconds]     
08:14 -!- grafcaps [~haroldbr@104.137.194.255] has joined #bitcoin-core-dev     
08:16 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev     
08:18 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has joined #bitcoin-core-dev     
08:21 < bitcoin-git> [bitcoin] jnewbery opened pull request #13030: [bugfix] [wallet] Fix zapwallettxes/multiwallet interaction. (master...fix_zapwallet_multiwallet_interaction) https://github.com/bitcoin/bitcoin/pull/13030
08:22 -!- lnostdal_ [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev     
08:24 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Ping timeout: 248 seconds]     
08:26 -!- jtimon [~quassel@142.29.134.37.dynamic.jazztel.es] has quit [Ping timeout: 276 seconds]     
08:28 -!- shesek [~shesek@bzq-84-110-56-13.cablep.bezeqint.net] has joined #bitcoin-core-dev     
08:28 -!- shesek [~shesek@bzq-84-110-56-13.cablep.bezeqint.net] has quit [Changing host]     
08:28 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev     
08:30 -!- drizztbsd is now known as timothy     
08:30 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has joined #bitcoin-core-dev     
08:32 -!- laurentmt [~Thunderbi@37.58.58.232] has quit [Quit: laurentmt]     
08:43 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 240 seconds]     
08:48 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev     
08:51 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-vigylvdkfimojlwf] has quit [Quit: Connection closed for inactivity]     
09:02 -!- isis is now known as isis_     
09:02 -!- isis_ is now known as isis     
09:02 -!- jamesob [~james@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Quit: leaving]     
09:02 -!- jtimon [~quassel@37.134.29.142] has joined #bitcoin-core-dev     
09:02 -!- jamesob [~james@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev     
09:04 -!- Murch [~murch@96.74.120.81] has joined #bitcoin-core-dev     
09:04 -!- isis is now known as isis_     
09:14 -!- zarez1 [~Thunderbi@fs-93-93-44-38.fullsave.info] has joined #bitcoin-core-dev     
09:14 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev     
09:14 -!- zarez [~Thunderbi@fs-93-93-44-38.fullsave.info] has quit [Ping timeout: 260 seconds]     
09:14 -!- zarez1 is now known as zarez     
09:15 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]     
09:16 -!- lnostdal_ is now known as lnostdal     
09:18 -!- Dizzle [~dizzle@108.171.182.16] has quit [Quit: Leaving...]     
09:31 -!- promag [~promag@83.223.235.34] has joined #bitcoin-core-dev     
09:34 -!- guest1456342 [46688030@gateway/web/freenode/ip.70.104.128.48] has joined #bitcoin-core-dev     
09:39 -!- promag [~promag@83.223.235.34] has quit [Remote host closed the connection]     
09:45 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has quit [Remote host closed the connection]     
09:46 -!- ProfMac [~ProfMac@2001:470:b8ac:0:c130:f3a3:af40:130c] has joined #bitcoin-core-dev     
10:02 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
10:04 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 240 seconds]     
10:05 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev     
10:05 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 276 seconds]     
10:14 -!- zarez [~Thunderbi@fs-93-93-44-38.fullsave.info] has quit [Quit: zarez]     
10:14 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer]     
10:14 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev     
10:27 -!- crt4 [~hk@213.205.192.248] has quit [Quit: crt4]     
10:28 < jnewbery> wumpus: I think #13024 can go on the high priority for review. It's blocking walletload, which a few people said they wanted for V0.17 in the last weekly meeting.
10:28 < gribble> https://github.com/bitcoin/bitcoin/issues/13024 | test: Add rpcauth pair that generated by rpcauth by ken2812221 · Pull Request #13024 · bitcoin/bitcoin · GitHub
10:28 < jnewbery> sorry, not 13024
10:29 < jnewbery> sorry, not #13017
10:29 -!- Krellan [~Krellan@2601:640:4000:9258:c0d:262e:95c7:7104] has quit [Remote host closed the connection]     
10:29 < gribble> https://github.com/bitcoin/bitcoin/issues/13017 | Add wallets management functions by promag · Pull Request #13017 · bitcoin/bitcoin · GitHub
10:29 < jnewbery> That one ^^ 13017
10:32 -!- Krellan_ [~Krellan@2601:640:4000:9258:54f6:70a2:358d:9d77] has joined #bitcoin-core-dev     
10:34 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!]     
10:37 -!- Krellan_ [~Krellan@2601:640:4000:9258:54f6:70a2:358d:9d77] has quit [Ping timeout: 265 seconds]     
10:44 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
10:44 -!- iwkse_ is now known as iwkse     
10:47 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 264 seconds]     
10:49 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev     
11:02 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]     
11:09 -!- instagibbs [~instagibb@pool-100-15-128-78.washdc.fios.verizon.net] has quit [Ping timeout: 240 seconds]     
11:10 -!- instagibbs [~instagibb@pool-100-15-128-78.washdc.fios.verizon.net] has joined #bitcoin-core-dev     
11:10 < BlueMatt> I'll probably miss the meeting, but, hey, I got through 3/4 of the high-priority PRs, even acked 2, and left blocking comments on the 3rd....how did *you* do this week?
11:11 < BlueMatt> someone should repeat that when meeting time comes ^ :p
11:13 < kanzure> will do
11:13 -!- goatpig [56f75200@gateway/web/freenode/ip.86.247.82.0] has quit [Ping timeout: 260 seconds]     
11:15 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev     
11:16 -!- Dizzle [~dizzle@108.171.182.16] has joined #bitcoin-core-dev     
11:17 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Ping timeout: 240 seconds]     
11:28 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
11:31 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 256 seconds]     
11:34 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev     
11:34 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c19986940869...9b3a67eb0861
11:34 < bitcoin-git> bitcoin/master defffb3 João Barbosa: trivial: Improve include comment in src/interfaces/wallet.h
11:34 < bitcoin-git> bitcoin/master 9b3a67e MarcoFalke: Merge #13026: Fix include comment in src/interfaces/wallet.h...
11:35 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #13026: Fix include comment in src/interfaces/wallet.h (master...2018-04-fixincludecomment) https://github.com/bitcoin/bitcoin/pull/13026
11:35 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has quit [Quit: Leaving.]     
11:38 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev     
11:38 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Ping timeout: 248 seconds]     
11:40 < bitcoin-git> [bitcoin] MarcoFalke pushed 6 new commits to master: https://github.com/bitcoin/bitcoin/compare/9b3a67eb0861...0a8b7b4b33c9
11:40 < bitcoin-git> bitcoin/master ce65018 Suhas Daftuar: Use P2SH consensus rules for all blocks...
11:40 < bitcoin-git> bitcoin/master 95749a5 Suhas Daftuar: Separate NULLDUMMY enforcement from SEGWIT enforcement...
11:40 < bitcoin-git> bitcoin/master 5c31b20 Suhas Daftuar: [qa] Remove some pre-activation segwit tests...
11:40 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #11739: Enforce SCRIPT_VERIFY_P2SH and SCRIPT_VERIFY_WITNESS from genesis (master...2017-09-p2sh-segwit-from-genesis) https://github.com/bitcoin/bitcoin/pull/11739
11:46 <@wumpus> jnewbery: 13017 already has lots of (ut)ACKs, I'm not sure it makes sense to add it to high priority for review anymore
11:51 < promag> yap, just merge it instead :)
11:51 < luke-jr> (not going to be on time for the meeting, but will try to join as soon as I can)
11:55 -!- clarkmoody [~clarkmood@47-218-248-206.bcstcmta04.res.dyn.suddenlink.net] has joined #bitcoin-core-dev     
11:56 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-dsrapxzkvwkukgnf] has joined #bitcoin-core-dev     
11:57 -!- moneyball [~moneyball@65.200.72.90] has joined #bitcoin-core-dev     
11:58 -!- mistergold [~mistergol@37.19.108.156] has joined #bitcoin-core-dev     
12:00 <@wumpus> #startmeeting
12:00 < lightningbot> Meeting started Thu Apr 19 19:00:09 2018 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
12:00 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
12:00 < sipa> ohai
12:00 < jonasschnelli> hi     
12:00 < promag> hi     
12:00 < achow101> hi     
12:00 < jnewbery> hi     
12:00 <@wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator
12:00 < kanzure> hi.     
12:00 < instagibbs> hi     
12:00 < aj> 'lo     
12:00 < cfields> hi     
12:01 < jonasschnelli> ;;seen gmaxwell
12:01 < gribble> gmaxwell was last seen in #bitcoin-core-dev 5 weeks, 0 days, 1 hour, and 59 seconds ago: <gmaxwell> it's not like you pay lower fees due to it.
12:01 < meshcollider> hi     
12:01 <@wumpus> any proposed topics?
12:01 < jonasschnelli> I'd like to touch the light client mode design
12:02 <@wumpus> ok     
12:02 < promag> check high priority review first?
12:02 < kanzure> 11:10 < BlueMatt> I'll probably miss the meeting, but, hey, I got through 3/4 of the high-priority PRs, even acked 2, and left blocking comments on the 3rd....how did *you* do this week?
12:02 < jonasschnelli> ack     
12:02 <@wumpus> promag: yes, that's always the first topic
12:02 < jonasschnelli> we can't view jimpos txindex PR
12:02 < jonasschnelli> github issue... can we reopen the PR in a new #?
12:02 < sipa> I'd like #13002 on the high-priority list
12:02 < gribble> https://github.com/bitcoin/bitcoin/issues/13002 | Do not treat bare multisig outputs as IsMine unless watched by sipa · Pull Request #13002 · bitcoin/bitcoin · GitHub
12:02 <@wumpus> #topic high priority for review
12:02 <@wumpus> https://github.com/bitcoin/bitcoin/projects/8
12:03 < Murch> hi     
12:03 < sipa> Also, I can't open #11857
12:03 < gribble> https://github.com/bitcoin/bitcoin/issues/11857 | Build tx index in parallel with validation by jimpo · Pull Request #11857 · bitcoin/bitcoin · GitHub
12:03 < jonasschnelli> added 13002
12:03 < sipa> Do we at some point just close the PR and open a new one, to flush all historical discussion?
12:03 -!- laurentmt [~Thunderbi@37.58.58.232] has joined #bitcoin-core-dev     
12:03 < jonasschnelli> sipa: yes
12:03 < sipa> (assuming that's the reason for the sad unicorn)
12:03 < jonasschnelli> jimpo should do it though...
12:03 < sipa> yes     
12:03 < kanzure> has someone reported the unicorn to support@github.com
12:03 < jonasschnelli> I could not get hold of him in. the last days
12:03 < achow101> maybe telling github would help...
12:03 < jonasschnelli> kanzure: please do
12:04 < sipa> probably better if a repo owner does so
12:04 < sipa> i'll send a mail
12:04 < jonasschnelli> I doubt it would help in a resonable timeframe
12:04 < meshcollider> I don't get the unicorn, I can see it fine
12:04 < jonasschnelli> it's wired
12:04 < promag> me to, but in incognito
12:04 < instagibbs> kanzure, i did
12:04 <@wumpus> I see the unicorn
12:04 < jonasschnelli> I can't. But i can in mobile view
12:04 < instagibbs> incognito works reliably for me
12:04 < jnewbery> instagibbs reported it
12:04 < kanzure> instagibbs: thanks. i'll refrain.
12:05 < sipa> instagibbs: when?
12:05 < instagibbs> couple days ago
12:05 < sipa> any response?
12:05 < instagibbs> no     
12:05 < achow101> I've reported it just now
12:05 < achow101> also works in private browsing (firefox)
12:06 < jonasschnelli> logged out state works
12:06 < jonasschnelli> however, jimpo should just open a new PR
12:07 < jamesob> I can view it in lynx just fine
12:07 < sipa> suggested tiny topic: cyclic dependency
12:07 < jonasschnelli> hah jamesob
12:07 < jamesob> ;)     
12:08 <@wumpus> #topic cyclic dependency
12:08 -!- jcohen [~jcohen@rrcs-67-251-193-154.nyc.biz.rr.com] has joined #bitcoin-core-dev     
12:09 -!- laurentmt [~Thunderbi@37.58.58.232] has quit [Quit: laurentmt]     
12:09 < sipa> i was wondering if we should have a policy against the type of cyclic dependency where the .cpp files include eachother's .h files (but not .h files include eachother)
12:09 <@wumpus> do we have that problem?
12:09 < sipa> that's not a cyclic dependency for the compiler, but it does mean those two modules can't really be used independently and is generally a sign of bad separation
12:09 < kanzure> do we have many of that
12:09 < cfields> sipa: example?
12:09 < sipa> there are a few open PRs that introduce them
12:10 <@wumpus> I do agree cyclic dependency should be avoided in general
12:10 < sipa> so i wanted to bring it up here to see if that should be a PR merging blocker
12:10 < sipa> or just a "try to fix it up afterwards if introduced"
12:10 < sipa> i'm fine with either
12:11 < cfields> indeed sounds like likely bad design that should at least be justified in the PR
12:11 -!- votefrac [~votef@185.60.147.79] has joined #bitcoin-core-dev     
12:11 < sdaftuar> cfields: +1
12:11 < jonasschnelli> Yes. And maybe mention it in the developer guidelines?
12:11 <@wumpus> right, might make sense to discuss this in the PR
12:11 < meshcollider> Sounds like it'd be a painful thing to fix up afterwards in some cases
12:11 < aj> seems good to fix it before merge, but not sure it should be added as a lint check or similar
12:11 < sdaftuar> i can imagine that in some contexts we'd merge anyway
12:11 < sdaftuar> but might be blocking in others
12:12 < meshcollider> ^     
12:12 < sipa> #12954 introduces one for example
12:12 < gribble> https://github.com/bitcoin/bitcoin/issues/12954 | util: Refactor logging code into a global object by jimpo · Pull Request #12954 · bitcoin/bitcoin · GitHub
12:12 <@wumpus> for a refactor it should definitely be avoided
12:12 <@wumpus> refactoring is supposed to make the code better
12:12 <@wumpus> not introduce further bad design
12:12 < sdaftuar> that might be an example of an improvement that just doens't go far enough though?
12:13 < sipa> well one way of looking at it is that the current util.cpp there has two subcomponents that already have a cyclic dependency
12:13 < sipa> within the same .cpp file
12:13 < sipa> and forcing people to fix it before they can separate it is maybe counterproductive
12:13 < sipa> or not ;)
12:13 <@wumpus> maybe...
12:13 -!- laurentmt [~Thunderbi@37.58.58.232] has joined #bitcoin-core-dev     
12:13 -!- laurentmt [~Thunderbi@37.58.58.232] has quit [Client Quit]     
12:14 < sipa> enough on the topic i guess
12:14 < jcohen> one "quick" solution to avoiding that circular dep would be to jam it all into a single file - which i think would be even less desireable
12:14 <@wumpus> it is already in a single file
12:14 < jcohen> the alternative would be to split util up even further, which would lengthen the diff
12:15 < sipa> this is just an example, it's relatively easy to fix in this case
12:15 < cfields> sipa: right. Since the point of this one is to break up a big blob anyway, requiring it to solve the circular issue in one go would be pretty burdensome. But if it's moving in the right direction, imo maintaining the status quo is ok.
12:15 < cfields> we could go back to main.cpp :p
12:15 < sipa> cat *.cpp | gcc -
12:15 <@wumpus> cfields: true...
12:15 < achow101> "just put everything into one big file and call it main.cpp"
12:15 <@wumpus> I don't think I feel strong enough about this one to put it in the guidelines
12:15 -!- dx25 [~dx25@67-3-137-174.omah.qwest.net] has quit [Remote host closed the connection]     
12:15 < jtimon> well, perhaps breaking util as needed first makes sense
12:16 <@wumpus> though commenting on it where relevant is a good idea
12:16 < sipa> sgtm
12:16 <@wumpus> if there's an obvious solution to avoid it that's better, but we cannot enumerate every single software design compromise
12:17 <@wumpus> #topic light client mode design (jonasschnelli)
12:17 < aj> #13021 does the "break util as needed first" by the looks - logging.cpp includes util.h, util.h includes logging.h
12:17 < gribble> https://github.com/bitcoin/bitcoin/issues/13021 | MOVEONLY: Move logging code from util.{h,cpp} to new files. by jimpo · Pull Request #13021 · bitcoin/bitcoin · GitHub
12:17 -!- dx25 [~dx25@67-3-137-174.omah.qwest.net] has joined #bitcoin-core-dev     
12:17 < jonasschnelli> I'd like to get some feedback about the light client mode... particular the "requestblock" design
12:17 < jonasschnelli> #10794
12:17 < gribble> https://github.com/bitcoin/bitcoin/issues/10794 | Add simple light-client mode (RPC only) by jonasschnelli · Pull Request #10794 · bitcoin/bitcoin · GitHub
12:17 < jonasschnelli> if that is something we should follow or drop
12:18 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]     
12:18 < jonasschnelli> I know the use-cases with 10794 are limited, but a stepping stone towards hybrid and BIP158 light validation
12:18 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev     
12:19 < sipa> jonasschnelli: will review
12:19 < jonasschnelli> maybe first check for a concept ACK/NACK
12:19 < jtimon> aj: yeah, and it seems moveonly, so perhaps just rebasing 12954 on top of 13021 solves the issue in this case? sipa
12:19 -!- LukeJr [~quassel@75.113.216.246] has joined #bitcoin-core-dev     
12:20 < sipa> jonasschnelli: yes, makes sense - it's a bit too much to look at right now in the meeting though, i think
12:20 < jonasschnelli> sure...
12:20 < jonasschnelli> I'm only interested to know if the concept make sense for you guys
12:21 < jonasschnelli> (of having a light client mode)
12:21 <@wumpus> they have been open for a long time, probably should et around to at least concept-acking them
12:21 < sipa> yes     
12:21 < jonasschnelli> Great. Thanks
12:21 < sipa> jonasschnelli: oh, the idea of having a client mode - that makes absolutely sense to me
12:21 < sipa> but it heavily depends on how and what :)
12:22 < meshcollider> Having a light client mode is definitely a concept ACK for me
12:22 < LukeJr> jonasschnelli: only as a temporary stage
12:22 < sipa> LukeJr: how so?
12:22 < jonasschnelli> right... I wasn't sure if the PR is the right place to discuss that or if we want to do it in a meeting
12:22 < LukeJr> sipa: it should always be building up to a full node in the bg
12:23 < sipa> LukeJr: i disagree - it's a perfectly valid usecase to have one full node you run yourself, and then have multiple client nodes connect exclusively to it
12:23 < LukeJr> (even if that bg process is paused for a time)
12:23 < LukeJr> sipa: hmm
12:23 < cfields> jonasschnelli: I realize this is really unhelpful feedback, but I find the current download logic nearly impossible to follow as-is. I remember giving up on review of this last time for that reason. Imo it's due for a bit of a cleanup/encapsulation before piling more on :(
12:24 < sipa> LukeJr: but lightweight upgrading to full in the background is also an very good usecase, imho
12:24 < cfields> (feel free to ignore that, maybe it's just my issue reading the code)
12:24 < sdaftuar> cfields: you are not the only person who finds the download logic confusing :)
12:25 < sipa> i believe those who (helped) write it agree :)
12:25 < jonasschnelli> heh. Yes. The open PR is not the first try to make this with a possible very small impact on the code...
12:25 < sipa> jonasschnelli: thanks for stickin with it, though
12:25 < cfields> yes, I was hesitant to mention that because I didn't want to de-motivate at all.
12:26 < LukeJr> sipa: as soon as the wallet is split, your use case just works
12:26 < sipa> LukeJr: this is how i imagine the wallet being split :)
12:27 < jamesob> *cough* #10973 *cough*
12:27 < gribble> https://github.com/bitcoin/bitcoin/issues/10973 | Refactor: separate wallet from node by ryanofsky · Pull Request #10973 · bitcoin/bitcoin · GitHub
12:27 < jonasschnelli> It's still unclear though how fee estimations and mempool checks would be done "in that way"
12:27 < sipa> jamesob: that's modularizing the code better, which is independently useful
12:29 < sipa> i don't think the goal should be separating the wallet from the node into different processes, and then inventing a protocol between the two... instead of just making the wallet run as a light client
12:29 < jamesob> the two sound very similar to me
12:29 < LukeJr> I don't agree. There's no reason the wallet and node should be in the same process.
12:30 < jonasschnelli> sipa: I agree. For me its just unclear how to transport fee estimations and mempool checks between light client and the fullnode.
12:31 <@wumpus> LukeJr: that's not what sipa is saying, in his case the node and wallet would also be in different processes, but without custom protocol
12:31 < sipa> jamesob: the advantage of using P2P as communication between node and wallet (which is what you get if you see wallets as just lightweight nodes) is that it actually modularizing things: you can run _any_ wallet software or _any_ node software
12:31 < jamesob> wumpus sipa: but then using what protocol? a more fleshed out rpc interface?
12:31 < sipa> jamesob: P2P
12:31 < instagibbs> p2p messages
12:31 < instagibbs> with whitelisted fee estimation type messages, i assume
12:31 <@wumpus> right
12:32 < jonasschnelli> instagibbs: but not before we have BIP150/151
12:32 <@wumpus> I think for localhost it's fine without?
12:32 < jonasschnelli> I don't want MITMled fees
12:32 < jonasschnelli> yes. sure
12:32 < sipa> oh, short topic: update on private authentication protocols
12:32 <@wumpus> but yes, in general that's correct
12:32 < jnewbery> I don't think doing process separation with IPC precludes later doing a p2p-based wallet
12:32 < jamesob> sipa: thanks for the explanation; will noodle on that
12:33 < jnewbery> p2p-based wallet seems like a very large project
12:33 < sipa> jnewbery: i agree, but i think it's a bit overkill
12:33 < sipa> jnewbery: however, i don't think that's a choice that needs to be made
12:33 < jonasschnelli> jnewbery: we are not too far away from a p2p based wallet IMO
12:33 < sipa> encapsulating the communication between node and wallet is an objective improvement to the code
12:34 < sipa> even if it does not lead to also a process separation along that interface
12:34 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev     
12:34 < jnewbery> jonasschnelli: really? Maybe I overestimate the difficulty, but it seems like we'd need a lot of new logic in the wallet to understand p2p
12:34 < sipa> jnewbery: you misunderstand!
12:34 < sipa> jnewbery: it would reuse all the existing full node code
12:35 < sipa> and p2p implementation
12:35 < sipa> just don't do validation
12:35 < instagibbs> turn off full validation, ofc
12:35 < ryanofsky> just catching up, but yeah, i think two approaches are not exclusive, and work done to support ipc will be useful anyway for making wallet more independent and better able to do async p2p stuff
12:35 < jonasschnelli> jnewbery: it needs BIP158 light client mode (or fullblock), fee and mempool checks. Done
12:35 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection]     
12:35 < sipa> ryanofsky: yes, fully agree
12:35 < jonasschnelli> You just start two instances of Core. One as a full node, one with disabled validation pointing to the full node
12:36 < LukeJr> does it simplify or complicate the internal code? (ignoring the present level of complexity in itself)
12:36 < jonasschnelli> --> <sipa>	oh, short topic: update on private authentication protocols
12:37 < jnewbery> ok, I understand. How much work is it to make core work in --disablevalidation mode?
12:37 < sipa> jnewbery: that's the current topic :)
12:37 < jonasschnelli> jnewbery: 10794
12:37 < jonasschnelli> (does it)
12:37 < jnewbery> ok, I'll shut up and read the PR
12:37 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 248 seconds]     
12:38 < jonasschnelli> although 10794 leads out the wallet
12:38 < jonasschnelli> (to make it reviewable)
12:38 < jonasschnelli> *lefts out
12:38 <@wumpus> #topic update on private authentication protocols (sipa)
12:38 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev     
12:39 < sipa> so, as some know gmaxwell and i have been thinking about authentication protocols that have better privacy than bip150
12:40 < jonasschnelli> privacy in the sense of fingerprinting?
12:40 < sipa> yes     
12:40 < sipa> the goal is to have a design where one node has 1 or more private keys, and the other node has 1 or more public keys
12:40 < sipa> and the second node learns whether one of the other node's private keys matches one of your public keys
12:40 < sipa> but _nothing_ else
12:40 < sipa> the node with the private keys does not even learn if authentication was succesful
12:41 < sipa> or doesn't learn which keys it was being queried for
12:41 < jonasschnelli> the use case is then wide deploey authentication sheme rather then the more client-server-ish approach?
12:41 < sipa> it's still client-server
12:42 < sipa> the cool thing about this is that you can always run the authentication protocol
12:42 < LukeJr> sounds hard to give an "authentication failiure" error?
12:42 < sipa> LukeJr: the idea is that most of our connections are unauthentication anyway (and should be)... so whatever privileges you give to authenticated nodes, you just don't give if auth fails
12:42 < sipa> this has a very cool property
12:42 < sipa> you can _always_ run this authentication protocol
12:43 < sipa> even if you don't care who the other party is
12:43 < jonasschnelli> sipa: but, if you have node A and node B's pubkeys and you want connect to A, how can you be sure you'r not connecting to B?
12:43 < LukeJr> sipa: but if the authenticating node doesn't know if it failed, then it doesn't know if it has an authentication connection it expects
12:43 < sipa> LukeJr: it can run the same protocol in the other direction to find out
12:43 < LukeJr> hmm     
12:43 < sipa> jonasschnelli: you just query for who you want the other party to be
12:43 < phantomcircuit> or just ask for something that requires authentication
12:44 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection]     
12:44 < sipa> the cool thing is that if you always run the authentication protocol, but if you're not interested in authentication do it with just a randomly generated pubkey, a MitM can't find out what you're doing
12:44 < sipa> they have to assume you're trying to authenticate
12:45 < sipa> anyway, turns out... this is difficult
12:45 < cfields> sipa: i'm not sure if this has evolved from when we discussed last... does your peer learn how many pubkeys you'd accept?
12:45 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev     
12:45 < sipa> cfields: yes, but you can stuff your request with a number of random ones
12:45 < cfields> right, ok
12:45 < sipa> just pad to 256 keys or whatever, always
12:45 < instagibbs> so, did you fix it? :)
12:45 < jonasschnelli> sounds interesting.. are there written specs already?
12:46 < sipa> we have a protocol that works with 1 privkey and 1 pubkey - which means you need to run in many times sometimes which doesn't lead to great fingerprinting properties
12:46 < sipa> and i'm talking to some people to extend it :)
12:46 < jonasschnelli> Great. Thanks!
12:46 < sipa> jonasschnelli: https://gist.github.com/sipa/d7dcaae0419f10e5be0270fada84c20b
12:46 < sipa> note that that protocol linked to is broken
12:47 < sipa> but it does explain the rationale pretty well, i think
12:47 < sipa> end topic
12:47 < jonasschnelli> I guess this protocol would require more cryptoanalysis then the exiting BIP150
12:48 < sipa> jonasschnelli: that's ok, i'm talking to dan boneh about it
12:48 < jonasschnelli> Good!
12:48 < meshcollider> Dan is the solution to all crypto problems
12:48 < jonasschnelli> heh     
12:49 <@wumpus> it'd be good as a future successor to BIP150 - though I guess this research shouldn't discourage anyone from implementing BIP150 and having something working on more short term
12:49 < sipa> right
12:49 <@wumpus> (maybe that's obvious, but just to be clear)
12:49 < jonasschnelli> Implementing BIP151/150 is still hold back due to the network refactor, right?
12:50 < jonasschnelli> If not, I can continue on BIP150
12:50 < jonasschnelli> sry. 1541
12:50 < jonasschnelli> sry. 151
12:50 < cfields> sipa: I'm still a bit confused as to the use-case. Is the intent to be able to explicitly find a known peer, or more generally to build up a list of tofu-ish nodes that aren't known to misbehave, and look for them first when creating outbound connections?
12:50 < jnewbery> cfields: what's the state of network refactor? Any PRs awaiting review?
12:50 < sipa> cfields: you can't do TOFU, you don't learn who you're connecting to
12:50 < sipa> cfields: the whole point is avoiding having discoverable identities for things that should be identityless
12:51 < sipa> but sometimes you have a node you trust already (due to external reasons, for example you run it yourself)
12:51 < sipa> in which case you'd configure an addnode with a known pubkey or so
12:51 < cfields> sipa: got it, thanks.
12:51 < cfields> jnewbery: #11457 still, looks like it needs rebase again
12:51 < sipa> yes, BIP150 can continue independently
12:51 < gribble> https://github.com/bitcoin/bitcoin/issues/11457 | Introduce BanMan by theuni · Pull Request #11457 · bitcoin/bitcoin · GitHub
12:51 < cfields> doing now, thanks for the reminder
12:51 < sipa> eh, BIP151
12:52 < Murch> cfields: In the case that you for example want to connect with a thin client to your own node, the only valid key you query for is your home node's. If you want to defend against Sybil, you may query a list of known friends and accept any of them. If you just want to scare off a MITM, you query for random keys.
12:52 -!- niska [~niska@68.ip-149-56-14.net] has quit [Quit: Leaving]     
12:52 < sipa> this is just a replacement for the authentication part; it needs an existing encrypted connection to run over anyway
12:52  * jonasschnelli will continue with 151
12:53 < LukeJr> how does one authenticate the encryption key?
12:53 < sipa> you don't
12:53 < jonasschnelli> bip151 does not protect from MITM
12:53 < sipa> encryption is done with ephemeral keys, and is completely unauthenticated
12:53 < sipa> it does not protect against MitM
12:53 < jonasschnelli> Only from passible observing and undetectable interception
12:53 < jonasschnelli> *passive
12:54 < sipa> but then you run an authentication protocol which can determine if the party you are talking to (possibly the MitM) is who you think it is
12:54 < sipa> anyway, enough on the topic
12:54 < sipa> just wanted to give an update that there are some cool ideas
12:54 <@wumpus> yes, thanks!
12:54  * sipa lunch
12:55 < jonasschnelli> thanks sipa for working on this!
12:55 <@wumpus> unless someone has a very quick last-minutet topic I think that was the last topic for today 
12:56 <@wumpus> clear :)
12:56 <@wumpus> #endmeeting
12:56 < lightningbot> Meeting ended Thu Apr 19 19:56:03 2018 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
12:56 < lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-04-19-19.00.html
12:56 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-04-19-19.00.txt
12:56 < lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-04-19-19.00.log.html
12:56 -!- LukeJr [~quassel@75.113.216.246] has quit [Remote host closed the connection]     
12:57 < promag> jtimon: sorry, forgot about #10757
12:57 -!- niska [~niska@68.ip-149-56-14.net] has joined #bitcoin-core-dev     
12:57 < gribble> https://github.com/bitcoin/bitcoin/issues/10757 | RPC: Introduce getblockstats to plot things by jtimon · Pull Request #10757 · bitcoin/bitcoin · GitHub
12:57 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]     
13:04 < phantomcircuit> sipa, separating encryption and authentication like that has the potential for an obvious mistake
13:05 < phantomcircuit> mitm encryption and then fail to authenticate the shared secret used for encryption
13:08 -!- isis_ is now known as isis     
13:08 -!- Murch [~murch@96.74.120.81] has quit [Quit: Plugging out.]     
13:09 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev     
13:13 -!- wxss [~user@185.117.118.224] has quit [Quit: leaving]     
13:13 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev     
13:15 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]     
13:16 -!- moneyball [~moneyball@65.200.72.90] has quit [Quit: Textual IRC Client: www.textualapp.com]     
13:21 < achow101> question about wallet hd upgrade path (#12560): is it preferable to warn that a new backup is needed for -upgradewallet or just use a new option entirely?
13:21 < gribble> https://github.com/bitcoin/bitcoin/issues/12560 | [wallet] Upgrade path for non-HD wallets to HD by achow101 · Pull Request #12560 · bitcoin/bitcoin · GitHub
13:24 -!- Murch [~murch@96.74.120.81] has joined #bitcoin-core-dev     
13:25 -!- clarkmoody [~clarkmood@47-218-248-206.bcstcmta04.res.dyn.suddenlink.net] has quit [Remote host closed the connection]     
13:29 -!- Murch [~murch@96.74.120.81] has quit [Read error: Connection reset by peer]     
13:30 -!- Murch [~murch@96.74.120.81] has joined #bitcoin-core-dev     
13:33 < sipa> phantomcircuit: then you just have an unauthenticated connection that's still safe from passive attackers
13:34 -!- clarkmoody [~clarkmood@47-218-248-206.bcstcmta04.res.dyn.suddenlink.net] has joined #bitcoin-core-dev     
13:38 -!- votefrac [~votef@185.60.147.79] has quit [Ping timeout: 240 seconds]     
13:40 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer]     
13:41 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev     
13:42 -!- AndroUser [~androirc@41.212.103.24] has joined #bitcoin-core-dev     
13:47 -!- votefrac [~votef@185.60.147.79] has joined #bitcoin-core-dev     
13:49 -!- isis is now known as isis_     
13:50 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 256 seconds]     
13:53 -!- Murch [~murch@96.74.120.81] has quit [Quit: Snoozing.]     
13:55 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Ping timeout: 260 seconds]     
13:58 -!- Murch [~murch@96.74.120.81] has joined #bitcoin-core-dev     
14:00 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-zuhrbgbjyzeuktls] has joined #bitcoin-core-dev     
14:20 -!- votefrac [~votef@185.60.147.79] has quit [Ping timeout: 264 seconds]     
14:22 -!- TheCharlatan [~TheCharla@109.236.87.57] has joined #bitcoin-core-dev     
14:23 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 260 seconds]     
14:29 -!- Dizzle [~dizzle@108.171.182.16] has quit [Quit: Leaving...]     
14:30 < phantomcircuit> sipa, yeah but you get what im saying im sure
14:35 < jimpo> Sorry, I missed meeting. So I should open a new PR for #11857? It also loads for me, but I can do that if people want...
14:35 < gribble> https://github.com/bitcoin/bitcoin/issues/11857 | Build tx index in parallel with validation by jimpo · Pull Request #11857 · bitcoin/bitcoin · GitHub
14:35 -!- dongcarl [~dongcarl@c-24-5-70-69.hsd1.ca.comcast.net] has quit [Quit: ZNC 1.6.5 - http://znc.in]     
14:38 -!- Randolf [~randolf@205.250.80.42] has joined #bitcoin-core-dev     
14:38 < jimpo> Also, I'd really like to get #13021 in before I have to rebase it again
14:38 < gribble> https://github.com/bitcoin/bitcoin/issues/13021 | MOVEONLY: Move logging code from util.{h,cpp} to new files. by jimpo · Pull Request #13021 · bitcoin/bitcoin · GitHub
14:38 -!- clarkmoody [~clarkmood@47-218-248-206.bcstcmta04.res.dyn.suddenlink.net] has quit []     
14:39 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has joined #bitcoin-core-dev     
14:39 -!- AndroUser [~androirc@41.212.103.24] has quit [Ping timeout: 256 seconds]     
14:48 -!- Randolf [~randolf@205.250.80.42] has quit [Ping timeout: 268 seconds]     
14:49 -!- LeMiner [LeMiner@unaffiliated/leminer] has quit [Read error: Connection reset by peer]     
14:50 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has joined #bitcoin-core-dev     
14:51 -!- jcohen [~jcohen@rrcs-67-251-193-154.nyc.biz.rr.com] has quit [Ping timeout: 256 seconds]     
14:56 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-dsrapxzkvwkukgnf] has quit [Quit: Connection closed for inactivity]     
14:57 -!- isis_ is now known as isis     
15:01 -!- spinza [~spin@196.212.164.26] has quit [Quit: Coyote finally caught up with me...]     
15:20 -!- echonaut [~echonaut@46.101.192.134] has quit [Read error: Connection reset by peer]     
15:20 -!- echonaut2 [~echonaut@46.101.192.134] has joined #bitcoin-core-dev     
15:25 -!- bedotech [~bedo@62-11-53-104.dialup.tiscali.it] has quit [Ping timeout: 276 seconds]     
15:28 -!- spinza [~spin@196.212.164.26] has joined #bitcoin-core-dev     
15:31 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev     
15:39 -!- ProfMac [~ProfMac@2001:470:b8ac:0:c130:f3a3:af40:130c] has quit [Ping timeout: 240 seconds]     
15:46 < bitcoin-git> [bitcoin] sipsorcery opened pull request #13031: Fix for utiltime to compile with msvc. (master...msvc_gmtime) https://github.com/bitcoin/bitcoin/pull/13031
15:52 -!- ProfMac [~ProfMac@2001:470:b8ac:0:ed90:9220:86d8:28e6] has joined #bitcoin-core-dev     
15:59 -!- bzb [~bzb@135-23-193-53.cpe.pppoe.ca] has joined #bitcoin-core-dev     
16:10 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has quit [Remote host closed the connection]     
16:11 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has joined #bitcoin-core-dev     
16:17 -!- isis is now known as isis_     
16:28 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has quit []     
16:34 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev     
16:40 < achow101> BlueMatt: what's your idea for detecting old keypool keys?
16:41 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection]     
16:42 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev     
16:43 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection]     
16:44 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev     
16:55 < bitcoin-git> [bitcoin] kristapsk opened pull request #13032: Output values for "min relay fee not met" error (master...min-relay-fee-not-met-debug) https://github.com/bitcoin/bitcoin/pull/13032
17:00 -!- weez17 [~isaac@unaffiliated/weez17] has quit [Remote host closed the connection]     
17:00 -!- weez17 [~isaac@unaffiliated/weez17] has joined #bitcoin-core-dev     
17:11 < bitcoin-git> [bitcoin] jimpo opened pull request #13033: Build txindex in parallel with validation (master...txindex-refactor-take2) https://github.com/bitcoin/bitcoin/pull/13033
17:12 < bitcoin-git> [bitcoin] jimpo closed pull request #11857: Build tx index in parallel with validation (master...txindex-refactor) https://github.com/bitcoin/bitcoin/pull/11857
17:18 -!- grafcaps [~haroldbr@104.137.194.255] has quit [Ping timeout: 240 seconds]     
17:21 -!- bzb [~bzb@135-23-193-53.cpe.pppoe.ca] has quit [Remote host closed the connection]     
17:26 -!- Murch [~murch@96.74.120.81] has quit [Quit: Snoozing.]     
17:33 -!- grafcaps [~haroldbr@50.90.83.229] has joined #bitcoin-core-dev     
17:41 -!- CubicEarths [~cubiceart@xdsl-188-155-63-9.adslplus.ch] has joined #bitcoin-core-dev     
17:47 -!- mistergold [~mistergol@37.19.108.156] has quit [Quit: leaving]     
17:52 -!- ProfMac [~ProfMac@2001:470:b8ac:0:ed90:9220:86d8:28e6] has quit [Ping timeout: 240 seconds]     
17:55 -!- Murch [~murch@96.74.120.81] has joined #bitcoin-core-dev     
17:55 < achow101> github responded to me about 11857 and they told me that they're looking into it. apparently some other PRs in other projects are seeing similar issues
17:57 -!- Murch [~murch@96.74.120.81] has quit [Client Quit]     
18:13 -!- harrymm [~harrymm@104.207.83.18] has quit [Remote host closed the connection]     
18:14 -!- harrymm [~harrymm@104.207.83.63] has joined #bitcoin-core-dev     
18:18 -!- grafcaps [~haroldbr@50.90.83.229] has quit [Ping timeout: 248 seconds]     
18:18 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev     
18:27 -!- grafcaps [~haroldbr@50.90.83.229] has joined #bitcoin-core-dev     
18:30 -!- jtimon [~quassel@37.134.29.142] has quit [Ping timeout: 256 seconds]     
18:30 -!- ProfMac [~ProfMac@2001:470:b8ac:0:ed90:9220:86d8:28e6] has joined #bitcoin-core-dev     
18:35 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev     
18:41 -!- isis_ is now known as isis     
18:53 < bitcoin-git> [bitcoin] promag opened pull request #13034: Introduce WalletManager (master...2018-04-walletmanager) https://github.com/bitcoin/bitcoin/pull/13034
19:12 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection]     
19:17 -!- helo_ is now known as helo     
19:19 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 256 seconds]     
19:20 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev     
19:21 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Remote host closed the connection]     
19:22 -!- grafcaps [~haroldbr@50.90.83.229] has quit [Ping timeout: 248 seconds]     
19:25 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]     
19:32 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev     
19:34 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Remote host closed the connection]     
19:37 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev     
19:42 -!- Murch [~murch@96.74.120.81] has joined #bitcoin-core-dev     
19:49 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit []     
19:49 -!- Murch [~murch@96.74.120.81] has quit [Quit: Snoozing.]     
19:50 -!- wxiwsu [~eolcyokh@117.65.43.64] has joined #bitcoin-core-dev     
19:54 -!- jojeyh [~delphi@2602:306:b8b6:b970:d508:a1ab:fc70:e998] has quit [Ping timeout: 240 seconds]     
19:54 -!- grafcaps [~haroldbr@50.90.83.229] has joined #bitcoin-core-dev     
19:56 -!- wxiwsu [~eolcyokh@117.65.43.64] has quit [Ping timeout: 256 seconds]     
19:58 -!- ProfMac [~ProfMac@2001:470:b8ac:0:ed90:9220:86d8:28e6] has quit [Ping timeout: 240 seconds]     
20:01 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Remote host closed the connection]     
20:01 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev     
20:04 -!- Sinclair6 [sinclair6@gateway/vpn/privateinternetaccess/sinclair6] has quit []     
20:06 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Ping timeout: 240 seconds]     
20:10 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit []     
20:13 -!- jojeyh [~delphi@2602:306:b8b6:b970:480d:4d9:1a02:1755] has joined #bitcoin-core-dev     
20:45 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection]     
20:46 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev     
20:48 -!- ProfMac [~ProfMac@2001:470:b8ac:0:ed90:9220:86d8:28e6] has joined #bitcoin-core-dev     
20:50 -!- zautomata1 [~zautomata@41.232.212.92] has joined #bitcoin-core-dev     
20:50 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-zuhrbgbjyzeuktls] has quit [Quit: Connection closed for inactivity]     
20:52 -!- zautomata [~zautomata@unaffiliated/zautomata] has quit [Ping timeout: 256 seconds]     
20:58 -!- grafcaps [~haroldbr@50.90.83.229] has quit [Ping timeout: 240 seconds]     
21:16 -!- grafcaps [~haroldbr@50.90.83.229] has joined #bitcoin-core-dev     
21:23 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev     
21:31 -!- ProfMac [~ProfMac@2001:470:b8ac:0:ed90:9220:86d8:28e6] has quit [Ping timeout: 240 seconds]     
21:32 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has joined #bitcoin-core-dev     
21:36 -!- ohnx [notohnx@unaffiliated/ohnx] has quit [Remote host closed the connection]     
21:37 -!- ohnx [notohnx@unaffiliated/ohnx] has joined #bitcoin-core-dev     
21:41 -!- anstaendig [~anstaendi@185.212.149.4] has quit [Ping timeout: 264 seconds]     
21:53 < jimpo> ajtown: Nice tip on --color-moved. TIL.
21:55 < aj> jimpo: pfft, old news. i've known about it for days!
22:00 < sipa> what is --color-moved?!
22:00 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Write error: Broken pipe]     
22:00 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]     
22:00 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Remote host closed the connection]     
22:00 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection]     
22:00 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev     
22:00 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev     
22:01 < jimpo> aj: hahaha
22:01 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev     
22:06 < aj> sipa: "git diff HEAD^ --color-moved=zebra" 
22:07 -!- arbitrary_guy [~arbitrary@c-67-183-30-122.hsd1.wa.comcast.net] has quit [Remote host closed the connection]     
22:07 < sipa> doesn't work here
22:07 < aj> sipa: i found it while looking for easier ways to review #12885
22:07 < gribble> https://github.com/bitcoin/bitcoin/issues/12885 | Reduce implementation code inside CScript by sipa · Pull Request #12885 · bitcoin/bitcoin · GitHub
22:07 < aj> sipa: needs to be run on a moveonly-type commit, it uses colours so might depend on your terminal
22:07 < kallewoof> Oooh, neat
22:07 < sipa> i use git diff --patience HEAD~:src/file.cpp HEAD:src/newfile.cpp
22:08 < bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0a8b7b4b33c9...8b262eb2d80b
22:08 < bitcoin-git> bitcoin/master b77b6e2 Jim Posen: MOVEONLY: Move logging code from util.{h,cpp} to new files.
22:08 < bitcoin-git> bitcoin/master 8b262eb Pieter Wuille: Merge #13021: MOVEONLY: Move logging code from util.{h,cpp} to new files....
22:09 < bitcoin-git> [bitcoin] sipa closed pull request #13021: MOVEONLY: Move logging code from util.{h,cpp} to new files. (master...logging-files) https://github.com/bitcoin/bitcoin/pull/13021
22:11 < aj> ah, needs git 2.15 which came out octoberish 2017
22:11 < sipa> seems i have 2.14
22:16 -!- anstaendig [~anstaendi@185.212.149.4] has joined #bitcoin-core-dev     
22:20 -!- anstaendig [~anstaendi@185.212.149.4] has quit [Ping timeout: 265 seconds]     
22:23 < bitcoin-git> [bitcoin] macraix opened pull request #13036: PicoStocks 100TH problem (master...master) https://github.com/bitcoin/bitcoin/pull/13036
22:24 < bitcoin-git> [bitcoin] fanquake closed pull request #13036: PicoStocks 100TH problem (master...master) https://github.com/bitcoin/bitcoin/pull/13036
22:31 -!- d_t [~d_t@108-65-78-188.lightspeed.sntcca.sbcglobal.net] has quit [Read error: No route to host]     
22:35 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Remote host closed the connection]     
22:36 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev     
22:38 -!- zigen_ [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev     
22:38 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Read error: Connection reset by peer]     
22:42 -!- zigen_ [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Remote host closed the connection]     
22:43 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev     
22:50 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has quit [Quit: Snoozing.]     
22:59 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has quit [Ping timeout: 256 seconds]     
23:09 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has joined #bitcoin-core-dev     
23:09 <@wumpus> --color-moved=zebra? can we pick other animals too?
23:10  * wumpus looks at his git version... 2.7.4.. oh alright, maybe in a few years
23:12 -!- RoBz [~RoBz@unaffiliated/robz] has quit [Ping timeout: 255 seconds]     
23:15 -!- Krellan [~Krellan@2601:640:4000:9258:9d1a:c750:f243:f0b5] has joined #bitcoin-core-dev     
23:20 -!- crt4 [~hk@host86-170-218-34.range86-170.btcentralplus.com] has joined #bitcoin-core-dev     
23:33 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev     
23:37 -!- Krellan [~Krellan@2601:640:4000:9258:9d1a:c750:f243:f0b5] has quit [Ping timeout: 240 seconds]     
23:45 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev     
23:46 -!- Krellan [~Krellan@2601:640:4000:9258:9d1a:c750:f243:f0b5] has joined #bitcoin-core-dev     
23:46 < promag> wumpus: hi, do you think you can check #13017?
23:46 < gribble> https://github.com/bitcoin/bitcoin/issues/13017 | Add wallets management functions by promag · Pull Request #13017 · bitcoin/bitcoin · GitHub
23:48 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]     
23:52 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 268 seconds]     
23:54 -!- bedotech [~bedo@62-11-53-104.dialup.tiscali.it] has joined #bitcoin-core-dev     
23:56 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev     
23:57 -!- tylevine [~tylevine@li120-195.members.linode.com] has quit [Quit: The Lounge - https://thelounge.github.io]