--- Day changed Mon Apr 23 2018 00:00 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 00:29 -!- Sedrick80Bernier [~Sedrick80@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 00:29 < bitcoin-git> [bitcoin] laanwj opened pull request #13055: qt: Don't log to console by default (master...2018_04_gui_console) https://github.com/bitcoin/bitcoin/pull/13055 00:32 -!- CubicEarths [~cubiceart@xdsl-188-155-63-9.adslplus.ch] has joined #bitcoin-core-dev 00:32 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-lnqefyurumwedxha] has quit [Quit: Connection closed for inactivity] 00:37 -!- zarez [~Thunderbi@fs-93-93-44-38.fullsave.info] has joined #bitcoin-core-dev 00:47 <@wumpus> this weekend I recovered a node that was crashing with database corruption errors (after, I think, a hard poweroff corrupted it - the log was padded with sudden \0\0\0\0\0\0) simply by deleting leveldb's .log file. 00:48 <@wumpus> after that and restarted, the node succesfully picked up verification again, phew, no reindex 00:48 < bitcoin-git> [bitcoin] nixbox opened pull request #13056: [tests] Make rpcauth.py testable and add unit tests (master...rpcauth) https://github.com/bitcoin/bitcoin/pull/13056 00:50 <@wumpus> error was "error in middle of record" in log_reader 00:56 <@wumpus> maybe such an automatic recovery would be possible in some cases, when only the log is corrupt and not any ldb files, it'd just amount to a rollback 00:59 -!- rex4539 [~textual@2a02:587:3514:8600:e4c2:8885:e969:4db2] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 01:05 -!- laurentmt [~Thunderbi@37.58.58.232] has joined #bitcoin-core-dev 01:05 -!- laurentmt [~Thunderbi@37.58.58.232] has quit [Client Quit] 01:07 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 01:09 -!- jtimon [~quassel@142.29.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 01:15 -!- stevenroose_ is now known as stevenroose 01:35 -!- Sedrick80Bernier [~Sedrick80@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 256 seconds] 01:36 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 01:36 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/65d7083f152e...e2746db66fd5 01:36 < bitcoin-git> bitcoin/master 3cc9094 Ben Woosley: scripted-diff: Rename CChainState::g_failed_blocks to m_failed_blocks... 01:36 < bitcoin-git> bitcoin/master e2746db Wladimir J. van der Laan: Merge #13016: scripted-diff: Rename CChainState::g_failed_blocks to m_failed_blocks... 01:36 < bitcoin-git> [bitcoin] laanwj closed pull request #13016: scripted-diff: Rename CChainState::g_failed_blocks to m_failed_blocks (master...g-failed-blocks) https://github.com/bitcoin/bitcoin/pull/13016 01:45 -!- zarez [~Thunderbi@fs-93-93-44-38.fullsave.info] has quit [Ping timeout: 276 seconds] 01:53 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has joined #bitcoin-core-dev 02:00 -!- rex4539 [~textual@2a02:587:3900:d000:9cc5:90e3:f0c3:af56] has joined #bitcoin-core-dev 02:01 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 02:01 -!- rex4539 [~textual@2a02:587:3900:d000:9cc5:90e3:f0c3:af56] has quit [Client Quit] 02:09 -!- Krellan [~Krellan@2601:640:4000:9258:85d:d2a9:3b49:8a39] has quit [Read error: Connection reset by peer] 02:10 -!- Krellan [~Krellan@2601:640:4000:9258:85d:d2a9:3b49:8a39] has joined #bitcoin-core-dev 02:14 -!- jtimon [~quassel@142.29.134.37.dynamic.jazztel.es] has quit [Ping timeout: 268 seconds] 02:28 -!- zautomata2 [~zautomata@41.232.217.225] has joined #bitcoin-core-dev 02:30 -!- zautomata1 [~zautomata@41.232.195.86] has quit [Ping timeout: 265 seconds] 02:32 -!- zarez [~Thunderbi@fs-93-93-44-38.fullsave.info] has joined #bitcoin-core-dev 02:59 -!- Cogito_Ergo_Sum [~Myself@athedsl-244236.home.otenet.gr] has joined #bitcoin-core-dev 02:59 -!- Cogito_Ergo_Sum [~Myself@athedsl-244236.home.otenet.gr] has quit [Changing host] 02:59 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has joined #bitcoin-core-dev 03:26 -!- zautomata3 [~zautomata@41.232.198.124] has joined #bitcoin-core-dev 03:29 -!- zautomata2 [~zautomata@41.232.217.225] has quit [Ping timeout: 276 seconds] 03:32 -!- goatpig [56f75200@gateway/web/freenode/ip.86.247.82.0] has joined #bitcoin-core-dev 03:36 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Read error: Connection reset by peer] 03:36 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev 03:36 -!- zautomata4 [~zautomata@41.43.174.73] has joined #bitcoin-core-dev 03:37 -!- Samdney [~Samdney@81.95.5.39] has joined #bitcoin-core-dev 03:37 -!- zautomata3 [~zautomata@41.232.198.124] has quit [Ping timeout: 240 seconds] 03:40 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-shongzyaavoeoucq] has joined #bitcoin-core-dev 03:41 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Ping timeout: 276 seconds] 03:43 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 03:44 -!- jtimon [~quassel@142.29.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 03:45 -!- CubicEarths [~cubiceart@xdsl-188-155-63-9.adslplus.ch] has quit [Remote host closed the connection] 03:46 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 03:49 -!- Dyaheon [~Dya@dsl-trebng21-58c19c-197.dhcp.inet.fi] has quit [Ping timeout: 268 seconds] 03:50 -!- Soligor [~Soligor@unaffiliated/soligor] has quit [Remote host closed the connection] 03:51 -!- BashCo_ [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 263 seconds] 03:52 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has joined #bitcoin-core-dev 03:52 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 03:54 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 03:54 -!- Soligor [~Soligor@unaffiliated/soligor] has joined #bitcoin-core-dev 03:55 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 04:10 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev 04:14 -!- CubicEar_ [~cubiceart@xdsl-188-155-63-9.adslplus.ch] has joined #bitcoin-core-dev 04:18 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 276 seconds] 04:33 -!- CubicEar_ [~cubiceart@xdsl-188-155-63-9.adslplus.ch] has quit [Remote host closed the connection] 04:36 -!- Dyaheon [~Dya@dsl-trebng21-58c19c-197.dhcp.inet.fi] has joined #bitcoin-core-dev 04:42 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has quit [Quit: May the Shwartz be with you] 05:00 -!- BashCo_ [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 05:01 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 248 seconds] 05:05 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 264 seconds] 05:08 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 05:13 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 05:17 -!- Tralfaz [~none@103.254.153.99] has joined #bitcoin-core-dev 05:17 -!- Tralfaz [~none@103.254.153.99] has quit [Max SendQ exceeded] 05:17 -!- Tralfaz [~none@103.254.153.99] has joined #bitcoin-core-dev 05:19 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 05:22 -!- zautomata [~zautomata@41.232.205.157] has joined #bitcoin-core-dev 05:23 -!- zautomata4 [~zautomata@41.43.174.73] has quit [Ping timeout: 265 seconds] 05:25 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 05:27 -!- zautomata1 [~zautomata@41.232.212.80] has joined #bitcoin-core-dev 05:27 -!- CubicEarths [~cubiceart@178.197.231.224] has joined #bitcoin-core-dev 05:27 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Read error: Connection reset by peer] 05:28 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 05:28 -!- zautomata [~zautomata@41.232.205.157] has quit [Ping timeout: 248 seconds] 05:28 -!- CubicEarths [~cubiceart@178.197.231.224] has quit [Read error: Connection reset by peer] 05:29 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 05:30 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Read error: Connection reset by peer] 05:30 -!- jtimon [~quassel@142.29.134.37.dynamic.jazztel.es] has quit [Ping timeout: 265 seconds] 05:30 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 05:30 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e2746db66fd5...8b4081a889b3 05:30 < bitcoin-git> bitcoin/master cf02779 Wladimir J. van der Laan: Add logging and error handling for file syncing... 05:30 < bitcoin-git> bitcoin/master 8b4081a Wladimir J. van der Laan: Merge #13039: Add logging and error handling for file syncing... 05:31 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Read error: Connection reset by peer] 05:31 < bitcoin-git> [bitcoin] laanwj closed pull request #13039: Add logging and error handling for file syncing (master...2018_04_fsync_noignore) https://github.com/bitcoin/bitcoin/pull/13039 05:32 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 05:33 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Read error: Connection reset by peer] 05:35 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 05:36 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Read error: No route to host] 05:37 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 05:38 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev 05:38 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8b4081a889b3...4741ca5dc8fd 05:38 < bitcoin-git> bitcoin/master e4d0b44 Ben Woosley: Consistently log CValidationState on failure... 05:38 < bitcoin-git> bitcoin/master 4741ca5 Wladimir J. van der Laan: Merge #13020: Consistently log CValidationState on call failure... 05:38 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Read error: Connection reset by peer] 05:39 < bitcoin-git> [bitcoin] laanwj closed pull request #13020: Consistently log CValidationState on call failure (master...log-cvalidation-state) https://github.com/bitcoin/bitcoin/pull/13020 05:39 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 05:40 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Remote host closed the connection] 05:40 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Read error: Connection reset by peer] 05:41 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 05:42 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Ping timeout: 248 seconds] 05:42 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Read error: Connection reset by peer] 05:42 -!- CubicEarths [~cubiceart@178.197.231.224] has joined #bitcoin-core-dev 05:43 -!- jtimon [~quassel@142.29.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 05:43 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 05:45 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Read error: Connection reset by peer] 05:45 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 05:47 -!- CubicEarths [~cubiceart@178.197.231.224] has quit [Client Quit] 05:49 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Read error: Connection reset by peer] 05:50 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-shongzyaavoeoucq] has quit [Quit: Connection closed for inactivity] 05:51 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 05:54 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Read error: Connection reset by peer] 05:54 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 05:56 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Read error: No route to host] 05:58 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 06:00 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Read error: Connection reset by peer] 06:01 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 06:05 -!- Tralfaz [~none@103.254.153.99] has quit [Quit: Leaving] 06:06 -!- Tralfaz [~none@103.254.153.99] has joined #bitcoin-core-dev 06:06 -!- Tralfaz [~none@103.254.153.99] has quit [Remote host closed the connection] 06:06 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 06:07 -!- tralfaz [67fe9963@gateway/web/freenode/ip.103.254.153.99] has joined #bitcoin-core-dev 06:08 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 06:12 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 276 seconds] 06:19 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 06:20 -!- HFRadical [~none@103.254.153.99] has joined #bitcoin-core-dev 06:20 -!- HFRadical [~none@103.254.153.99] has quit [Max SendQ exceeded] 06:21 -!- HFRadical [~none@103.254.153.99] has joined #bitcoin-core-dev 06:21 -!- HFRadical [~none@103.254.153.99] has quit [Remote host closed the connection] 06:28 -!- TheCharlatan [~TheCharla@109.236.87.57] has quit [Quit: WeeChat 2.1] 06:47 < bitcoin-git> [bitcoin] instagibbs opened pull request #13057: remove redundant pre-selected coin code (master...selectedcoins) https://github.com/bitcoin/bitcoin/pull/13057 06:58 -!- grafcaps [~haroldbr@50.90.83.229] has quit [Ping timeout: 264 seconds] 07:07 -!- jb55 [~jb55@S010660e327dca171.vc.shawcable.net] has joined #bitcoin-core-dev 07:07 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4741ca5dc8fd...d5b2e98250f6 07:07 < bitcoin-git> bitcoin/master e87fefc Wladimir J. van der Laan: test: Add rpc_bind test to default-run tests... 07:07 < bitcoin-git> bitcoin/master d5b2e98 Wladimir J. van der Laan: Merge #12510: test: Add rpc_bind test to default-run tests... 07:08 < bitcoin-git> [bitcoin] laanwj closed pull request #12510: test: Add rpc_bind test to default-run tests (master...2018_02_reinstate_rpcbind_test) https://github.com/bitcoin/bitcoin/pull/12510 07:08 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 07:09 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 07:19 -!- laurentmt [~Thunderbi@37.58.58.232] has joined #bitcoin-core-dev 07:19 -!- laurentmt [~Thunderbi@37.58.58.232] has quit [Client Quit] 07:30 -!- grafcaps [~haroldbr@50.90.26.145] has joined #bitcoin-core-dev 07:38 -!- grafcaps [~haroldbr@50.90.26.145] has quit [Ping timeout: 248 seconds] 07:40 -!- grafcaps [~haroldbr@50.90.26.145] has joined #bitcoin-core-dev 07:48 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d5b2e98250f6...5713994de98e 07:48 < bitcoin-git> bitcoin/master 6ad47b0 practicalswift: trivial: Fix relevent typo 07:48 < bitcoin-git> bitcoin/master 5713994 MarcoFalke: Merge #13052: trivial: Fix relevent typo... 07:48 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #13052: trivial: Fix relevent typo (master...relevent) https://github.com/bitcoin/bitcoin/pull/13052 07:49 -!- grafcaps [~haroldbr@50.90.26.145] has quit [Ping timeout: 240 seconds] 07:55 -!- tralfaz [67fe9963@gateway/web/freenode/ip.103.254.153.99] has quit [Ping timeout: 260 seconds] 07:56 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 07:56 -!- jb55 [~jb55@S010660e327dca171.vc.shawcable.net] has quit [Ping timeout: 264 seconds] 08:00 -!- sanada` [~bitktn@36-2-119-80.chiba.ap.gmo-isp.jp] has joined #bitcoin-core-dev 08:01 -!- sanada [~bitktn@36-2-119-80.chiba.ap.gmo-isp.jp] has quit [Ping timeout: 268 seconds] 08:02 -!- jb55 [~jb55@S010660e327dca171.vc.shawcable.net] has joined #bitcoin-core-dev 08:05 -!- Murch [~murch@96.74.120.81] has joined #bitcoin-core-dev 08:14 -!- tralfaz [67fe9963@gateway/web/freenode/ip.103.254.153.99] has joined #bitcoin-core-dev 08:15 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 08:16 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5713994de98e...d1e3c5e73cfc 08:16 < bitcoin-git> bitcoin/master 18326ae James O'Beirne: [doc] Add comments for chainparams.h, validation.cpp 08:16 < bitcoin-git> bitcoin/master d1e3c5e Wladimir J. van der Laan: Merge #13012: [doc] Add comments for chainparams.h, validation.cpp... 08:16 < bitcoin-git> [bitcoin] laanwj closed pull request #13012: [doc] Add comments for chainparams.h, validation.cpp (master...2018-04-17-doc-chainparams-validation) https://github.com/bitcoin/bitcoin/pull/13012 08:18 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 08:19 -!- grafcaps [~haroldbr@104.137.194.255] has joined #bitcoin-core-dev 08:20 -!- reardencode [~reardenco@hank.reardencode.com] has joined #bitcoin-core-dev 08:34 < jnewbery> provoostenator: Yes, agree that 4000 lines is probably too much log. I'd ACK a PR to reduce it. (counter argument is that this is only printed when a script fails, so we want as much logging as possible) 08:46 -!- achow101 [~achow101@unaffiliated/achow101] has left #bitcoin-core-dev ["Leaving"] 08:46 -!- achow101 [~achow101@unaffiliated/achow101] has joined #bitcoin-core-dev 08:52 < jonasschnelli> hmm... localhost p2p getblocks transfer rate up to block 250000 is roughly 70MB/s (SSD with usual rate of 300MB/s). Reasonable overhead. 09:00 <@wumpus> jonasschnelli: any idea where the overhead is? the deserialize->serialize round trip? 09:00 <@wumpus> or just 'random seeking and reading' wrt i/o, because this concerns such small blocks 09:02 -!- zarez [~Thunderbi@fs-93-93-44-38.fullsave.info] has quit [Quit: zarez] 09:05 -!- Krellan [~Krellan@2601:640:4000:9258:85d:d2a9:3b49:8a39] has quit [Ping timeout: 276 seconds] 09:05 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d1e3c5e73cfc...84efa9a0f752 09:05 < bitcoin-git> bitcoin/master 0851a75 João Barbosa: rpc: Interrupt block generation on shutdown request 09:05 < bitcoin-git> bitcoin/master 84efa9a Wladimir J. van der Laan: Merge #12448: Interrupt block generation on shutdown request... 09:05 < bitcoin-git> [bitcoin] laanwj closed pull request #12448: Interrupt block generation on shutdown request (master...2018-02-interrupt-generate-blocks) https://github.com/bitcoin/bitcoin/pull/12448 09:09 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 248 seconds] 09:11 < promag> wumpus: that was unexpected 09:12 <@wumpus> promag: :-) 09:12 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Ping timeout: 248 seconds] 09:16 -!- setpill [~setpill@unaffiliated/setpill] has quit [Ping timeout: 246 seconds] 09:16 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 09:20 -!- setpill [~setpill@unaffiliated/setpill] has quit [Ping timeout: 255 seconds] 09:21 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 09:21 -!- Krellan [~Krellan@2601:640:4000:9258:85d:d2a9:3b49:8a39] has joined #bitcoin-core-dev 09:25 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 09:32 -!- Dizzle [~dizzle@108.171.182.16] has joined #bitcoin-core-dev 09:38 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Remote host closed the connection] 09:39 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev 09:41 -!- reardencode [~reardenco@hank.reardencode.com] has quit [Quit: Lost terminal] 09:43 < jonasschnelli> wumpus: not sure where the bottleneck is. need to analyze more. I first need the make sure it's not the client (pure C p2p client) 09:43 -!- vicenteH [~user@35.233.15.37.dynamic.jazztel.es] has quit [Read error: Connection reset by peer] 09:43 -!- vicenteH [~user@35.233.15.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 09:44 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Ping timeout: 240 seconds] 09:45 -!- reardencode [~reardenco@hank.reardencode.com] has joined #bitcoin-core-dev 09:48 -!- mistergold [~mistergol@37.19.109.121] has joined #bitcoin-core-dev 09:51 -!- isis is now known as isis_ 09:54 -!- shesek [~shesek@bzq-84-110-55-93.cablep.bezeqint.net] has joined #bitcoin-core-dev 09:54 -!- shesek [~shesek@bzq-84-110-55-93.cablep.bezeqint.net] has quit [Changing host] 09:54 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 09:55 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 09:58 -!- zautomata1 [~zautomata@41.232.212.80] has quit [Ping timeout: 248 seconds] 09:59 -!- Krellan [~Krellan@2601:640:4000:9258:85d:d2a9:3b49:8a39] has quit [Remote host closed the connection] 09:59 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 240 seconds] 10:01 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 10:02 -!- goatpig [56f75200@gateway/web/freenode/ip.86.247.82.0] has quit [Ping timeout: 260 seconds] 10:03 -!- eklitzke [~evan@fsf/member/eck] has quit [Quit: bye] 10:05 -!- eklitzke [~evan@fsf/member/eck] has joined #bitcoin-core-dev 10:05 -!- zautomata4 [~zautomata@41.232.198.134] has joined #bitcoin-core-dev 10:05 -!- eklitzke [~evan@fsf/member/eck] has quit [Client Quit] 10:07 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 10:08 -!- Aaronva__ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 10:10 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 10:10 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 248 seconds] 10:12 -!- Aaronva__ is now known as AaronvanW 10:12 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 264 seconds] 10:15 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has joined #bitcoin-core-dev 10:24 < bitcoin-git> [bitcoin] jnewbery opened pull request #13058: [wallet] `createwallet` RPC - create new wallet at runtime (master...create_wallet) https://github.com/bitcoin/bitcoin/pull/13058 10:24 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has quit [Quit: drexl] 10:28 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 248 seconds] 10:30 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 10:32 -!- Murch [~murch@96.74.120.81] has quit [Quit: Snoozing.] 10:33 -!- Murch [~murch@96.74.120.81] has joined #bitcoin-core-dev 10:34 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 265 seconds] 10:41 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 260 seconds] 10:49 -!- GoldenBear [gb@2600:3c03::f03c:91ff:fed5:ebbc] has joined #bitcoin-core-dev 11:00 -!- ProfMac [~ProfMac@2001:470:b8ac:0:c40a:76ce:c72c:b4c1] has quit [Ping timeout: 265 seconds] 11:03 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has quit [Ping timeout: 240 seconds] 11:04 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 11:08 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 11:08 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 11:11 -!- cubancorona [cubancoron@gateway/vpn/privateinternetaccess/cubancorona] has quit [Remote host closed the connection] 11:11 -!- isis_ is now known as isis 11:11 -!- cubancorona [cubancoron@gateway/vpn/privateinternetaccess/cubancorona] has joined #bitcoin-core-dev 11:13 -!- ProfMac [~ProfMac@2001:470:b8ac:0:b119:1eb4:f790:e317] has joined #bitcoin-core-dev 11:15 -!- Murch [~murch@96.74.120.81] has quit [Quit: Snoozing.] 11:21 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 11:22 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 11:22 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev 11:23 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 11:24 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/84efa9a0f752...d3f04c0e81a6 11:24 < bitcoin-git> bitcoin/master 3476e3c John Newbery: [wallet] Fix zapwallettxes/multiwallet interaction.... 11:24 < bitcoin-git> bitcoin/master 1f83839 John Newbery: [wallet] [tests] Test disallowed multiwallet params... 11:24 < bitcoin-git> bitcoin/master d3f04c0 Wladimir J. van der Laan: Merge #13030: [bugfix] [wallet] Fix zapwallettxes/multiwallet interaction.... 11:25 < bitcoin-git> [bitcoin] laanwj closed pull request #13030: [bugfix] [wallet] Fix zapwallettxes/multiwallet interaction. (master...fix_zapwallet_multiwallet_interaction) https://github.com/bitcoin/bitcoin/pull/13030 11:25 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Max SendQ exceeded] 11:25 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev 11:34 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 11:35 -!- StopAndDecrypt [~StopAndDe@c-73-215-253-208.hsd1.nj.comcast.net] has joined #bitcoin-core-dev 11:35 -!- StopAndDecrypt [~StopAndDe@c-73-215-253-208.hsd1.nj.comcast.net] has quit [Changing host] 11:35 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has joined #bitcoin-core-dev 11:36 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 11:38 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 11:43 -!- Murch [~murch@96.74.120.81] has joined #bitcoin-core-dev 11:49 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 11:50 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-gsgutswjfetvixbr] has joined #bitcoin-core-dev 12:01 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d3f04c0e81a6...8609ddb36821 12:01 < bitcoin-git> bitcoin/master 67bf2aa Chun Kuan Lee: qt:Show the entire Window when double clicking on taskbar 12:01 < bitcoin-git> bitcoin/master 8609ddb Wladimir J. van der Laan: Merge #12999: qt: Show the Window when double clicking the taskbar icon... 12:02 < bitcoin-git> [bitcoin] laanwj closed pull request #12999: qt: Show the Window when double clicking the taskbar icon (master...qt-fix) https://github.com/bitcoin/bitcoin/pull/12999 12:03 -!- jcohen [~jcohen@rrcs-67-251-193-154.nyc.biz.rr.com] has quit [Ping timeout: 256 seconds] 12:06 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has joined #bitcoin-core-dev 12:09 < bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/8609ddb36821...a49381dfa3ee 12:09 < bitcoin-git> bitcoin/master 2fb168b Pieter Wuille: Make iterators in CScript::FindAndDelete const 12:09 < bitcoin-git> bitcoin/master 33a8ecf Pieter Wuille: Delete unused non-const-iterator CSCript::GetOp overloads 12:09 < bitcoin-git> bitcoin/master 6a7456a Pieter Wuille: [MOVEONLY] Move CSCript::FindAndDelete to interpreter 12:10 < bitcoin-git> [bitcoin] laanwj closed pull request #12885: Reduce implementation code inside CScript (master...201803_reducescript) https://github.com/bitcoin/bitcoin/pull/12885 12:15 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Ping timeout: 264 seconds] 12:16 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 12:17 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection] 12:17 -!- ProfMac [~ProfMac@2001:470:b8ac:0:b119:1eb4:f790:e317] has quit [Ping timeout: 260 seconds] 12:18 < jonasschnelli> wumpus: here is the flamgraph during 3.8GB blockserving on localhost: https://bitcoin.jonasschnelli.ch/perf-heavy-blockserving.svg 12:18 -!- cheese_ [Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has joined #bitcoin-core-dev 12:19 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 12:19 < jonasschnelli> Not sure why I can't untangle the callstack in msghandler 37.68% is spent in "Lloop1_26" 12:20 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 12:20 -!- isis is now known as isis_ 12:21 -!- RoyceX [~Cheeseo@unaffiliated/cheeseo] has quit [Ping timeout: 240 seconds] 12:21 < bitcoin-git> [bitcoin] jnewbery opened pull request #13060: [wallet] [rpc] Remove getlabeladdress RPC (master...remove_getlabeladdress) https://github.com/bitcoin/bitcoin/pull/13060 12:24 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 276 seconds] 12:29 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has quit [Remote host closed the connection] 12:30 -!- ProfMac [~ProfMac@2001:470:1f0f:a5f:b119:1eb4:f790:e317] has joined #bitcoin-core-dev 12:30 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has joined #bitcoin-core-dev 12:44 -!- moneyball [~moneyball@65.200.72.90] has joined #bitcoin-core-dev 12:47 < Chris_Stewart_5> If a node receives blocks in an order like: 1,2,4,3 (where 4 references previous block hash of 3) on the p2p network, will zmq relay 4 after it has successfully connected it with 3? 12:47 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 12:49 -!- moneyball [~moneyball@65.200.72.90] has quit [Client Quit] 12:51 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has quit [Ping timeout: 260 seconds] 12:51 < sipa> Chris_Stewart_5: no, it just notifies for new tips 12:53 < sipa> as ZMQ is not reliable, you shouldn't use it as more than a notification service anyway 12:54 -!- drexl [~drexl@62.112.9.166] has joined #bitcoin-core-dev 12:55 < sipa> Chris_Stewart_5: actually, i think that can't happen 12:55 < sipa> as we always fetch blocks in order 12:55 < Chris_Stewart_5> sipa: Wouldn't 4 end up as the cannonical tip? 12:55 < sipa> but a similar scenario can occur during a reorg 12:56 < sipa> in which case ZMQ will just report the new tip after the reorg, and not the intermediary blocks (afaik, not entirely sure) 12:57 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 12:58 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 13:00 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 13:01 < Chris_Stewart_5> so basically if there is a reorg that is like 6 blocks deep, you will just be notified of the new tip of that reorg, *not* all the intermittent blocks that happened in the reorg correct? 13:02 < skeees> In the current state you'll be notified after every ActivateBestChainStep() 13:02 < skeees> which will definitely give you the new tip 13:02 < skeees> possibly some of the block in between, but not guaranteed every single one 13:03 < skeees> the notifications will be pushed to zmq in order (i don't know what ordering guarantees zmq gives you though) 13:03 -!- BashCo_ [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 268 seconds] 13:07 < Chris_Stewart_5> skeees: Thanks! :-) 13:08 < sipa> Chris_Stewart_5: you basically can't rely on ZMQ to relay you everything regardless 13:08 < sipa> you can use it as a notification that there are new things you should look at (through rpc or rest) 13:09 < sipa> (and IMHO it was a mistake to make it relay full blocks in the first place, as it confusingly gives you the impression it will give you everything) 13:15 -!- Diki [727d3c6d@gateway/web/freenode/ip.114.125.60.109] has joined #bitcoin-core-dev 13:16 -!- Diki [727d3c6d@gateway/web/freenode/ip.114.125.60.109] has quit [Client Quit] 13:17 -!- moneyball [~moneyball@65.200.72.90] has joined #bitcoin-core-dev 13:26 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 13:28 -!- votefrac [~votef@185.60.147.79] has joined #bitcoin-core-dev 13:31 -!- isis_ is now known as isis 13:35 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 248 seconds] 13:38 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 13:39 -!- votefrac [~votef@185.60.147.79] has quit [Ping timeout: 264 seconds] 13:41 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev 13:42 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 13:43 -!- niftynei [~niftynei@135.84.132.224] has joined #bitcoin-core-dev 13:45 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Ping timeout: 248 seconds] 13:52 -!- moneyball [~moneyball@65.200.72.90] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 14:03 -!- moneyball [~moneyball@65.200.72.90] has joined #bitcoin-core-dev 14:13 -!- moneyball [~moneyball@65.200.72.90] has quit [Quit: Textual IRC Client: www.textualapp.com] 14:31 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 248 seconds] 14:32 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 14:41 -!- Murch [~murch@96.74.120.81] has quit [Quit: Plugging out.] 15:01 < bitcoin-git> [bitcoin] jnewbery closed pull request #9806: txoutsbyaddress index (take 3) (master...gettxoutsbyaddress) https://github.com/bitcoin/bitcoin/pull/9806 15:07 -!- isis is now known as isis_ 15:10 < bitcoin-git> [bitcoin] bmwiedemann opened pull request #13061: Make tests pass after 2020 (master...ftbfs-2020) https://github.com/bitcoin/bitcoin/pull/13061 15:10 < midnightmagic> w 80 15:18 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 15:20 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has quit [] 15:24 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 15:25 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 15:27 -!- Aaronvan_ is now known as AaronvanW 15:28 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has quit [Remote host closed the connection] 15:28 -!- laurentmt [~Thunderbi@37.58.58.232] has joined #bitcoin-core-dev 15:29 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has joined #bitcoin-core-dev 15:30 -!- laurentmt [~Thunderbi@37.58.58.232] has quit [Client Quit] 15:33 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 15:33 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has quit [Ping timeout: 240 seconds] 15:41 -!- Dizzle [~dizzle@108.171.182.16] has quit [Quit: Leaving...] 15:45 -!- votefrac [~votef@185.60.147.79] has joined #bitcoin-core-dev 15:50 -!- votefrac [~votef@185.60.147.79] has quit [Ping timeout: 248 seconds] 15:50 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-gsgutswjfetvixbr] has quit [Quit: Connection closed for inactivity] 15:53 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 15:57 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 16:01 -!- vicenteH [~user@35.233.15.37.dynamic.jazztel.es] has quit [Ping timeout: 260 seconds] 16:08 -!- bedotech [~bedo@62-11-53-104.dialup.tiscali.it] has quit [Ping timeout: 240 seconds] 16:10 < aj> jtimon: can still drop "assert_contains" from rpc_getblockstats.py 16:11 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-asttonusinvunljf] has joined #bitcoin-core-dev 16:11 < jtimon> yeah, unused, thanks 16:11 < jtimon> aj: also I just noticed I forgot this nit: https://github.com/bitcoin/bitcoin/pull/10757/files#r181616478 16:11 < bitcoin-git> [bitcoin] sipa opened pull request #13062: Make script interpreter independent from storage type CScript (master...201804_spaninterpret) https://github.com/bitcoin/bitcoin/pull/13062 16:15 < bitcoin-git> [bitcoin] promag closed pull request #11402: Use shared pointer for wallet instances (master...2017-09-wallet-shared-pointer) https://github.com/bitcoin/bitcoin/pull/11402 16:16 < promag> jnewbery: you might want to rebase on top of #13063 16:16 < gribble> https://github.com/bitcoin/bitcoin/issues/13063 | Use shared pointer to retain wallet instance by promag · Pull Request #13063 · bitcoin/bitcoin · GitHub 16:16 < aj> jtimon: there was https://github.com/bitcoin/bitcoin/pull/10757#discussion_r181617123 too 16:23 < jtimon> aj: right, thanks 16:25 -!- drexl [~drexl@62.112.9.166] has quit [Remote host closed the connection] 16:31 < bitcoin-git> [bitcoin] sipa opened pull request #13064: List support for BIP173 in bips.md (master...201804_docbip173) https://github.com/bitcoin/bitcoin/pull/13064 16:32 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a49381dfa3ee...bdda14d1c01c 16:32 < bitcoin-git> bitcoin/master aee80b0 Wladimir J. van der Laan: qt: Don't log to console by default... 16:32 < bitcoin-git> bitcoin/master bdda14d MarcoFalke: Merge #13055: qt: Don't log to console by default... 16:33 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #13055: qt: Don't log to console by default (master...2018_04_gui_console) https://github.com/bitcoin/bitcoin/pull/13055 16:34 -!- Murch [~murch@96.74.120.81] has joined #bitcoin-core-dev 16:35 -!- mistergold [~mistergol@37.19.109.121] has quit [Quit: leaving] 16:41 -!- grafcaps [~haroldbr@104.137.194.255] has quit [Ping timeout: 264 seconds] 16:46 -!- opdenkamp [~opdenkamp@kodi/staff/dushmaniac] has quit [Ping timeout: 256 seconds] 16:49 -!- CubicEarths [~cubiceart@xdsl-188-155-63-9.adslplus.ch] has joined #bitcoin-core-dev 16:49 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 256 seconds] 16:51 -!- grafcaps [~haroldbr@50.90.83.229] has joined #bitcoin-core-dev 16:59 < bitcoin-git> [bitcoin] ken2812221 opened pull request #13065: Let travis to run verify-commits.sh without errors (master...verify-commits) https://github.com/bitcoin/bitcoin/pull/13065 17:00 -!- weez17 [~isaac@unaffiliated/weez17] has quit [Read error: Connection reset by peer] 17:01 -!- weez17 [~isaac@unaffiliated/weez17] has joined #bitcoin-core-dev 17:06 -!- niftynei [~niftynei@135.84.132.224] has quit [Remote host closed the connection] 17:20 -!- opdenkamp [~opdenkamp@kodi/staff/dushmaniac] has joined #bitcoin-core-dev 17:21 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has quit [Ping timeout: 248 seconds] 17:31 -!- Murch [~murch@96.74.120.81] has quit [Quit: Snoozing.] 17:39 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 17:40 -!- Giszmo [~leo@ip-234-237-219-201.nextelmovil.cl] has joined #bitcoin-core-dev 17:42 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev 17:45 -!- murrayn [~dafuq@unaffiliated/murrayn] has quit [Ping timeout: 264 seconds] 17:46 -!- rfree_irc [~rfree_irc@172.86.120.144] has quit [Ping timeout: 245 seconds] 17:46 -!- Giszmo [~leo@ip-234-237-219-201.nextelmovil.cl] has quit [Ping timeout: 255 seconds] 17:47 -!- marsadm [~marsadm@172.86.120.144] has quit [Ping timeout: 264 seconds] 17:47 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Ping timeout: 268 seconds] 17:52 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 17:53 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 17:56 -!- cubancorona [cubancoron@gateway/vpn/privateinternetaccess/cubancorona] has quit [Quit: Leaving] 18:00 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 18:03 -!- Giszmo [~leo@ip-141-237-219-201.nextelmovil.cl] has joined #bitcoin-core-dev 18:05 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 264 seconds] 18:06 -!- harrymm [~harrymm@104.207.83.63] has quit [Ping timeout: 248 seconds] 18:15 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 264 seconds] 18:15 -!- LeMiner2 [LeMiner@5ED1AFBF.cm-7-2c.dynamic.ziggo.nl] has joined #bitcoin-core-dev 18:15 -!- LeMiner2 [LeMiner@5ED1AFBF.cm-7-2c.dynamic.ziggo.nl] has quit [Read error: Connection reset by peer] 18:16 -!- LeMiner2 [LeMiner@5ED1AFBF.cm-7-2c.dynamic.ziggo.nl] has joined #bitcoin-core-dev 18:17 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 18:17 -!- LeMiner [LeMiner@5ED1AFBF.cm-7-2c.dynamic.ziggo.nl] has quit [Ping timeout: 264 seconds] 18:17 -!- LeMiner2 is now known as LeMiner 18:19 -!- harrymm [~harrymm@104.207.83.63] has joined #bitcoin-core-dev 18:25 -!- adiabat [~adiabat@45.63.20.152] has quit [Ping timeout: 256 seconds] 18:34 -!- jtimon [~quassel@142.29.134.37.dynamic.jazztel.es] has quit [Ping timeout: 240 seconds] 18:39 -!- isis_ is now known as isis 18:40 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-asttonusinvunljf] has quit [Quit: Connection closed for inactivity] 18:41 -!- LeMiner [LeMiner@5ED1AFBF.cm-7-2c.dynamic.ziggo.nl] has quit [Read error: Connection reset by peer] 18:42 -!- LeMiner [LeMiner@unaffiliated/leminer] has joined #bitcoin-core-dev 18:44 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 276 seconds] 18:48 -!- jtimon [~quassel@142.29.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 18:57 -!- jtimon [~quassel@142.29.134.37.dynamic.jazztel.es] has quit [Ping timeout: 255 seconds] 18:58 < jimpo> wumpus: You're having trouble viewing #13033? 18:58 < gribble> https://github.com/bitcoin/bitcoin/issues/13033 | Build txindex in parallel with validation by jimpo · Pull Request #13033 · bitcoin/bitcoin · GitHub 18:58 < jimpo> That is the PR reopened. It has only like 3 comments. 19:03 < sipa> Yes, i'm confused too. It opens perfectly here. 19:11 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 19:12 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 19:14 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-mufhrmtgythvqyok] has joined #bitcoin-core-dev 19:16 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 19:24 -!- murrayn [~dafuq@unaffiliated/murrayn] has joined #bitcoin-core-dev 19:28 -!- yoshi [d30e08f8@gateway/web/freenode/ip.211.14.8.248] has joined #bitcoin-core-dev 19:28 -!- yoshi is now known as Guest19800 19:33 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 19:57 -!- jb55 [~jb55@S010660e327dca171.vc.shawcable.net] has quit [Quit: WeeChat 2.0] 19:57 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 20:17 -!- Guest19800 [d30e08f8@gateway/web/freenode/ip.211.14.8.248] has quit [Ping timeout: 260 seconds] 20:17 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 20:18 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 20:18 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-hxovxpowmckpdgnw] has joined #bitcoin-core-dev 20:21 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 20:29 < roasbeef> odd that a PR would stop loading, just due to the # of comments it has I guess? 20:30 < roasbeef> guess the solution is to Download More RAM 20:31 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 248 seconds] 20:33 < sipa> roasbeef: i believe it's the github html renderer that times out 20:33 < sipa> as mobile github clients etc work fine 20:50 -!- Giszmo [~leo@ip-141-237-219-201.nextelmovil.cl] has quit [Quit: Leaving.] 20:59 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 20:59 -!- zautomata [~zautomata@41.232.211.99] has joined #bitcoin-core-dev 21:01 -!- zautomata4 [~zautomata@41.232.198.134] has quit [Ping timeout: 256 seconds] 21:03 -!- mlz [~IRCIdent@unaffiliated/molly] has quit [Quit: ZNC 1.6.5 - http://znc.in] 21:03 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 21:05 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 21:07 < jimpo> It's pretty bizarry though that it would load reliably for some accounts and in incognito mode, but not others 21:08 < jimpo> I wouldn't think that there's so much rendering logic that differs between accounts 21:08 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 21:13 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 260 seconds] 21:44 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev 21:46 < sipa> jimpo: i wonder if it's geographical 21:47 < sipa> maybe the render servers are distributed and not the same load/sprcs for people in europe vs north america etc 21:48 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Ping timeout: 263 seconds] 21:54 -!- grafcaps [~haroldbr@50.90.83.229] has quit [Ping timeout: 248 seconds] 22:00 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection] 22:00 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Remote host closed the connection] 22:00 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Write error: Broken pipe] 22:01 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 22:02 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 22:06 -!- Samdney [~Samdney@81.95.5.39] has quit [Quit: Verlassend] 22:17 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 264 seconds] 22:18 -!- mol [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 22:19 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 260 seconds] 22:21 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 22:25 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 22:26 -!- grafcaps [~haroldbr@50.90.83.229] has joined #bitcoin-core-dev 22:35 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 22:35 < bitcoin-git> [bitcoin] ken2812221 closed pull request #13065: Let travis run verify-commits.sh without errors (master...verify-commits) https://github.com/bitcoin/bitcoin/pull/13065 22:36 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 22:37 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-hxovxpowmckpdgnw] has quit [Quit: Connection closed for inactivity] 22:38 -!- rfree_irc [~rfree_irc@172.86.120.144] has joined #bitcoin-core-dev 22:39 -!- marsadm [~marsadm@172.86.120.144] has joined #bitcoin-core-dev 22:43 -!- bedotech [~bedo@62-11-53-104.dialup.tiscali.it] has joined #bitcoin-core-dev 22:54 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/bdda14d1c01c...569e3817e000 22:54 < bitcoin-git> bitcoin/master 4d33039 Pieter Wuille: List support for BIP173 in bips.md 22:54 < bitcoin-git> bitcoin/master 569e381 Wladimir J. van der Laan: Merge #13064: List support for BIP173 in bips.md... 22:55 < bitcoin-git> [bitcoin] laanwj closed pull request #13064: List support for BIP173 in bips.md (master...201804_docbip173) https://github.com/bitcoin/bitcoin/pull/13064 23:02 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 23:08 < fanquake> Looking forward to Bionic tomorrow. Hopefully we can start using it on WSL soon after.. 23:14 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-mufhrmtgythvqyok] has quit [Quit: Connection closed for inactivity] 23:18 -!- molly [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 23:20 < kallewoof> How are READWRITE(REF(CFlatData(ob))) done these days? I got barfed at when rebasing something. 23:20 * kallewoof does git log serialize.h to find clues 23:20 -!- molz_ [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 23:20 < sipa> kallewoof: depends, what type is ob? 23:21 < kallewoof> sipa: std::vector 23:21 < kallewoof> Wait, no.. 23:21 < kallewoof> Sorry. Yes. std::vector 23:22 < sipa> with compile-time known length? 23:22 < kallewoof> No, it's a merkle proof skip list 23:22 -!- mol [~molly@unaffiliated/molly] has quit [Ping timeout: 256 seconds] 23:22 < sipa> then what do you need the flatdata for? 23:23 * kallewoof headscratch 23:23 < sipa> just READWRITE(the_vector) will work fine 23:23 < kallewoof> Is CFlatData only used for fixed length stuff? 23:24 < sipa> CFlatData was historically used to write things as raw bytes, as opposed to the object's serializer 23:24 < sipa> it's been replaced with native support for arrays 23:24 -!- molly [~molly@unaffiliated/molly] has quit [Ping timeout: 248 seconds] 23:24 < sipa> so you can READWRITE(blah) if blah is 'unsigned char blah[4]' for example, and it will just write 4 bytes 23:24 < sipa> and with Span 23:25 < sipa> but uint256 has a serializer that just writes 32 bytes 23:25 < kallewoof> Okay, so actually reading the comment above, it seems Mark wanted to avoid using the Satoshi-defined compact size format as it was less efficient than the internal varint. 23:26 < kallewoof> Hence why he wrote the length of the vector and the vector as CFlatData 23:26 < sipa> i see 23:26 < sipa> seems overkill to me 23:26 < kallewoof> Yes, seems unnecessary. 23:26 < sipa> as the native varint's aren't used anywhere in the p2p protocol already 23:27 < kallewoof> *nod* 23:28 < sipa> the same issue came up around bip152 23:29 < kallewoof> How much more efficient are the varints compared to the compactsize version anyway? 23:29 < sipa> it depends on the distribution 23:29 < kallewoof> Right. Of course it does. 23:29 < sipa> for some distributions the compactsize ones are better 23:30 < kallewoof> But for a skip list in a merkle proof, I kind of don't think you'll ever have more than 10. 23:30 < kallewoof> Or very seldom anyway. I could be wrong though. 23:30 < sipa> then both serializations will give you just 1 byte anyway 23:30 < kallewoof> Yeah 23:30 < sipa> compactsize uses 1 byte up to (iirc) 252 23:31 < sipa> varint only up to 127 23:31 < sipa> but after that compactsize immediately jumps to 3 bytes 23:31 < sipa> while varint only uses 2 up to 16000 ish 23:32 < kallewoof> Oh, they're that different? I thought they were tweaks of the same thing. 23:34 < ossifrage> Does bitcoin core do some sort of io maintenance task that gobbles up a bunch of disk IO? 23:34 < kallewoof> Either way, the size of the size of the skip lists is a fraction of the size of the skip lists themselves which are 32 bytes per entry, so I doubt this matters. With 253 entries there are 8096 bytes of data aside from the size. 3 or 2 bytes isn't really gonna make a difference. 23:35 < ossifrage> QThread just started generating a bunch of disk io without any large corresponding newtwork IO 23:35 -!- Krellan [~Krellan@2601:640:4000:9258:856d:99ae:d6e5:3710] has joined #bitcoin-core-dev 23:38 -!- he1io5 [~chris@78.157.211.236] has joined #bitcoin-core-dev 23:45 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [] 23:45 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev 23:50 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Ping timeout: 255 seconds]