--- Day changed Wed May 02 2018 00:06 -!- moneyball [~moneyball@c-73-223-73-149.hsd1.ca.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 00:18 -!- jpe [~jpe@gb-r9-01.pixelpark.net] has joined #bitcoin-core-dev 00:38 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 00:38 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 00:39 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 256 seconds] 00:42 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 00:51 -!- shesek [~shesek@bzq-84-110-53-50.cablep.bezeqint.net] has joined #bitcoin-core-dev 00:51 -!- shesek [~shesek@bzq-84-110-53-50.cablep.bezeqint.net] has quit [Changing host] 00:51 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 01:04 -!- mistergold [~mistergol@37.19.109.253] has joined #bitcoin-core-dev 01:08 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 01:18 -!- ajtowns[m] [ajtownsmat@gateway/shell/matrix.org/x-lakeodvzmvcgyfqv] has quit [Ping timeout: 245 seconds] 01:18 -!- squarfed[m] [squarfedma@gateway/shell/matrix.org/x-ntregtlxwrjakbxg] has quit [Ping timeout: 245 seconds] 01:19 -!- joshb[m] [joshbmatri@gateway/shell/matrix.org/x-fzzqinommccztymf] has quit [Ping timeout: 245 seconds] 01:23 -!- squarfed[m] [squarfedma@gateway/shell/matrix.org/x-wjugzbuwiewikxzs] has joined #bitcoin-core-dev 01:24 -!- joshb[m] [joshbmatri@gateway/shell/matrix.org/x-zuiyyhqorzgzbdzh] has joined #bitcoin-core-dev 01:24 -!- ajtowns[m] [ajtownsmat@gateway/shell/matrix.org/x-mhppiwhyswnnbtpo] has joined #bitcoin-core-dev 01:31 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has joined #bitcoin-core-dev 01:32 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 01:45 < bitcoin-git> [bitcoin] practicalswift opened pull request #13148: logging: Fix potential use-after-free in LogPrintStr(...) (master...logprintstr-uaf) https://github.com/bitcoin/bitcoin/pull/13148 01:49 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 02:04 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection] 02:38 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 02:59 -!- vicenteH [~user@195.235.96.150] has joined #bitcoin-core-dev 03:10 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 03:11 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 03:15 < bitcoin-git> [bitcoin] practicalswift opened pull request #13149: Handle unsuccessful fseek(...):s (master...fseek) https://github.com/bitcoin/bitcoin/pull/13149 03:16 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/57c57df86f14...0bc980b1f65f 03:16 < bitcoin-git> bitcoin/master 2a89b0c Wladimir J. van der Laan: rpcauth: Make it possible to provide a custom password... 03:16 < bitcoin-git> bitcoin/master 0bc980b Wladimir J. van der Laan: Merge #13146: rpcauth: Make it possible to provide a custom password... 03:16 < bitcoin-git> [bitcoin] laanwj closed pull request #13146: rpcauth: Make it possible to provide a custom password (master...2018_05_rpcauth_custom_password) https://github.com/bitcoin/bitcoin/pull/13146 03:17 -!- mistergold [~mistergol@37.19.109.253] has quit [Ping timeout: 264 seconds] 03:17 -!- mistergold [~mistergol@37.19.109.253] has joined #bitcoin-core-dev 03:18 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 03:29 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Remote host closed the connection] 03:38 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 03:39 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-vxptanzxxpskxlis] has joined #bitcoin-core-dev 03:42 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 240 seconds] 03:43 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 03:44 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 03:45 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:48 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 248 seconds] 03:48 -!- drizztbsd [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 03:55 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 03:59 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Ping timeout: 240 seconds] 04:00 < promag> I would like to know if #13034 is something we want, or if I should remove that from other PR's related to dynamic wallets 04:00 < gribble> https://github.com/bitcoin/bitcoin/issues/13034 | Introduce WalletManager by promag · Pull Request #13034 · bitcoin/bitcoin · GitHub 04:00 < promag> so please ACK/NACK there 04:12 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/0bc980b1f65f...598db389c33e 04:12 < bitcoin-git> bitcoin/master 50b6533 Matt Corallo: scripted-diff: Rename SetBestChain callback ChainStateFlushed... 04:12 < bitcoin-git> bitcoin/master 9cb6cdc Matt Corallo: Simplify semantics of ChainStateFlushed callback... 04:12 < bitcoin-git> bitcoin/master 598db38 Wladimir J. van der Laan: Merge #13106: Simplify semantics of ChainStateFlushed callback... 04:12 -!- votefrac [~votef@185.60.147.79] has joined #bitcoin-core-dev 04:13 < bitcoin-git> [bitcoin] laanwj closed pull request #13106: Simplify semantics of ChainStateFlushed callback (master...2018-04-wallet-flush-better-criteria) https://github.com/bitcoin/bitcoin/pull/13106 04:15 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 256 seconds] 04:17 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 04:17 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Ping timeout: 248 seconds] 04:21 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev 04:24 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-tmoehlcteufvnjzf] has quit [Quit: Connection closed for inactivity] 04:30 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 04:38 -!- votefrac [~votef@185.60.147.79] has quit [Ping timeout: 276 seconds] 04:42 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 04:43 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 04:58 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [] 05:03 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 264 seconds] 05:07 -!- gwillen [~gwillen@unaffiliated/gwillen] has quit [Remote host closed the connection] 05:13 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 05:17 < bitcoin-git> [bitcoin] laanwj opened pull request #13151: WIP: net: Serve blocks directly from disk when possible (master...2018_05_direct_from_disk) https://github.com/bitcoin/bitcoin/pull/13151 05:27 -!- jtimon [~quassel@142.29.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 05:34 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 05:35 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 05:39 -!- Guyver2_ [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 05:39 -!- Guyver2_ [AdiIRC@guyver2.xs4all.nl] has quit [Read error: Connection reset by peer] 05:39 -!- Guyver2_ [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 05:41 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Ping timeout: 260 seconds] 05:41 -!- Guyver2_ is now known as Guyver2 05:43 < bitcoin-git> [bitcoin] chris-belcher opened pull request #13152: [WIP] [rpc] Add getaddress RPC command (master...2018-04-rpc-getaddress) https://github.com/bitcoin/bitcoin/pull/13152 05:44 -!- Cogito_Ergo_Sum [~Myself@athedsl-244236.home.otenet.gr] has joined #bitcoin-core-dev 05:44 -!- Cogito_Ergo_Sum [~Myself@athedsl-244236.home.otenet.gr] has quit [Changing host] 05:44 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has joined #bitcoin-core-dev 05:46 -!- fuss [a37d7e9f@gateway/web/freenode/ip.163.125.126.159] has joined #bitcoin-core-dev 05:48 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-vxptanzxxpskxlis] has quit [Quit: Connection closed for inactivity] 05:50 -!- adiabat [~adiabat@63.209.32.102] has quit [Remote host closed the connection] 05:51 -!- adiabat [~adiabat@63.209.32.102] has joined #bitcoin-core-dev 05:52 < bitcoin-git> [bitcoin] laanwj opened pull request #13153: net: Add missing newlines to debug logging (master...2018_05_log_newlines) https://github.com/bitcoin/bitcoin/pull/13153 05:53 -!- fuss [a37d7e9f@gateway/web/freenode/ip.163.125.126.159] has quit [Quit: Page closed] 05:53 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 05:54 < fanquake> wumpus new linter inbound.. 05:54 < wumpus> fanquake: there is a linter for that, but somehow it didn't catch these! 05:56 < fanquake> indeed, didn't realise we were checking that https://github.com/bitcoin/bitcoin/blob/master/contrib/devtools/lint-logs.sh 05:56 < fanquake> Also, any suggestions for testing #13151 performance improvements? 05:56 < gribble> https://github.com/bitcoin/bitcoin/issues/13151 | WIP: net: Serve blocks directly from disk when possible by laanwj · Pull Request #13151 · bitcoin/bitcoin · GitHub 05:58 < wumpus> ideally we'd have some tool or script that simply pulls blocks through P2P 05:58 < wumpus> just to measure raw download throughput 05:59 < wumpus> I vaguely remember someone mentioning this but I'm not sure where or who 06:00 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Ping timeout: 255 seconds] 06:01 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 255 seconds] 06:01 < wumpus> I mean you could try to benchmark by making a node sync from another node locally, but verification at the client side would distort the results 06:02 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 06:06 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 06:06 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 06:17 -!- huh [7a3c62c6@gateway/web/freenode/ip.122.60.98.198] has joined #bitcoin-core-dev 06:29 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has quit [Ping timeout: 240 seconds] 06:29 < jonasschnelli> hmmm... LMDB seems to consume ~274 bytes for a txindex entry (32byte hash txid, 32byte blockhash). I wonder where to overhead comes from. 06:32 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 06:32 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 06:34 -!- huh [7a3c62c6@gateway/web/freenode/ip.122.60.98.198] has quit [Quit: Page closed] 06:41 -!- ryanofsky [~russ@jumpy.yanofsky.org] has joined #bitcoin-core-dev 06:44 < promag> CBlockIndex::nStatus is protected by cs_main? 06:49 -!- Giszmo [~leo@ip-70-237-219-201.nextelmovil.cl] has joined #bitcoin-core-dev 06:53 < jonasschnelli> promag: Yeah. Seams like. Its definitively mutable. 06:53 < promag> ty 06:54 -!- Giszmo [~leo@ip-70-237-219-201.nextelmovil.cl] has quit [Ping timeout: 255 seconds] 06:57 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/598db389c33e...ef46c9904b80 06:57 < bitcoin-git> bitcoin/master ff2ad2d Wladimir J. van der Laan: Add missing newlines to LogPrint debug logging... 06:57 < bitcoin-git> bitcoin/master 4b75dcf MarcoFalke: devtools: Make linter check LogPrint calls 06:57 < bitcoin-git> bitcoin/master ef46c99 Wladimir J. van der Laan: Merge #13153: Add missing newlines to debug logging... 06:58 < bitcoin-git> [bitcoin] laanwj closed pull request #13153: Add missing newlines to debug logging (master...2018_05_log_newlines) https://github.com/bitcoin/bitcoin/pull/13153 06:58 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 07:00 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 07:05 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 265 seconds] 07:07 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 07:08 -!- grafcaps [~haroldbr@50.90.83.229] has quit [Ping timeout: 264 seconds] 07:08 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has joined #bitcoin-core-dev 07:09 < bitcoin-git> [bitcoin] ryanofsky opened pull request #13154: Trivial: s/SetBestChain/ChainStateFlushed in comments after #13106 (master...pr/flushed) https://github.com/bitcoin/bitcoin/pull/13154 07:16 < fanquake> Do you get spammed with emails/notifications if your @ mentioned in a commit body, same as what was happening in PRs? 07:19 < ryanofsky> what's the difference between https://github.com/bitcoin and https://github.com/bitcoin-core? 07:22 < fanquake> ryanofsky In what regard? 07:22 -!- grafcaps [~haroldbr@104.137.194.255] has joined #bitcoin-core-dev 07:24 < fanquake> /bitcoin was where bitcoin was migrated to from SF. /bitcoin-core houses some core specific repos such as the website, docs etc 07:25 < wumpus> right - bitcoin is the legacy organization, bitcoin-core is where most of the repositories have been moved 07:26 < ryanofsky> oh ok, so it's just a legacy thing. i didn't know if they two orgs were supposed to have different purposes, or were run by different people or something 07:26 < wumpus> it was originally the plan to move the bitcoin repository too, however since the 'bitcoin core' as currency name bullshit from BCHers, that's probably a bad idea and will only contribute towards user confusion 07:26 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has quit [Ping timeout: 260 seconds] 07:26 < BlueMatt> well except bips, which will probably always stay in bitcoin 07:27 < wumpus> yes, or a 'bips' organization 07:28 < fanquake> The crossover between the "teams" in the two orgs is pretty high. Probably just a few more inactive/older users in /bitcoin 07:29 -!- kexkey [~kexkey@173.209.48.155] has joined #bitcoin-core-dev 07:33 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [] 07:37 < wumpus> yes, if you're in bitcoin but not in bitcoin-core or vice versa, let me know, invites are supposed to go out for both at the same time 07:44 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Read error: Connection reset by peer] 07:47 -!- mistergold [~mistergol@37.19.109.253] has quit [Read error: Connection reset by peer] 07:47 -!- Giszmo [~leo@ip-227-237-219-201.nextelmovil.cl] has joined #bitcoin-core-dev 07:50 < bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/ef46c9904b80...ef006d92845a 07:50 < bitcoin-git> bitcoin/master 73bc1b7 practicalswift: Initialize editStatus and autoCompleter. Previously not initialized where defined or in constructor. 07:50 < bitcoin-git> bitcoin/master f131872 practicalswift: Initialize non-static class members where they are defined 07:50 < bitcoin-git> bitcoin/master 1e7813e practicalswift: Remove redundant initializations from the constructor 07:51 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 07:51 < bitcoin-git> [bitcoin] laanwj closed pull request #12928: qt: Initialize non-static class members that were previously neither initialized where defined nor in constructor (master...qt-constructors) https://github.com/bitcoin/bitcoin/pull/12928 07:56 < rafalcpp> hm is this expected that v0.16.0 crashes on start with built with --with-incompatible-bdb ? this issues are closed #6775 (and #12047). System always had libdb5.3 never had libdb4.x (Debian testing 10 from installation) 07:56 < gribble> https://github.com/bitcoin/bitcoin/issues/6775 | Bitcoind v0.11.0 segfaults on startup trying to read wallet. · Issue #6775 · bitcoin/bitcoin · GitHub 07:56 < gribble> https://github.com/bitcoin/bitcoin/issues/12047 | Segmentation fault if configured with incompatible BDB · Issue #12047 · bitcoin/bitcoin · GitHub 08:04 < wumpus> rafalcpp: usually that means that you have multiple versions of berkeleydb installed, and it's compiling against a different one than it's dynamically linking at runtime 08:05 < wumpus> but no, that's not normal, I've been compilng with --with-incompaible-bdb for years, and many others do 08:09 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 08:11 < rafalcpp> wumpus: I seen that today on debian 10 and debian 9. so reopen? 08:12 < wumpus> better to open a new issue, it's not clear this is the same problem 08:13 < wumpus> if it's the same problem then reopening doesn't help - it was a local issue (ABI conflict) 08:14 < wumpus> see e.g. https://github.com/bitcoin/bitcoin/issues/12047#issuecomment-357022687 08:20 -!- Giszmo [~leo@ip-227-237-219-201.nextelmovil.cl] has quit [Ping timeout: 256 seconds] 08:35 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has joined #bitcoin-core-dev 08:41 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Remote host closed the connection] 08:47 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 240 seconds] 08:50 -!- promag [~promag@a89-152-20-96.cpe.netcabo.pt] has joined #bitcoin-core-dev 08:54 -!- ExtraCrispy [~ExtraCris@185.9.18.150] has joined #bitcoin-core-dev 09:09 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 09:09 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 09:09 -!- thelox95 [baa7f4de@gateway/web/freenode/ip.186.167.244.222] has joined #bitcoin-core-dev 09:10 -!- thelox95 [baa7f4de@gateway/web/freenode/ip.186.167.244.222] has quit [Client Quit] 09:11 -!- laurentmt [~Thunderbi@37.58.58.232] has joined #bitcoin-core-dev 09:11 -!- thelox95 [baa7f4de@gateway/web/freenode/ip.186.167.244.222] has joined #bitcoin-core-dev 09:13 < thelox95> hi? 09:14 -!- laurentmt [~Thunderbi@37.58.58.232] has quit [Client Quit] 09:15 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 09:16 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 09:16 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 09:22 -!- kexkey [~kexkey@173.209.48.155] has quit [Quit: Yup] 09:26 -!- thelox95 [baa7f4de@gateway/web/freenode/ip.186.167.244.222] has quit [Quit: Page closed] 09:27 -!- moneyball [~moneyball@c-73-223-73-149.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 09:28 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 09:29 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 09:34 -!- promag [~promag@a89-152-20-96.cpe.netcabo.pt] has quit [Remote host closed the connection] 09:37 -!- vicenteH [~user@195.235.96.150] has quit [Read error: Connection reset by peer] 09:37 -!- vicenteH [~user@195.235.96.150] has joined #bitcoin-core-dev 09:51 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 09:51 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 10:01 -!- drizztbsd [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 10:21 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds] 10:29 -!- ExtraCrispy [~ExtraCris@185.9.18.150] has quit [Remote host closed the connection] 10:31 -!- vicenteH [~user@195.235.96.150] has quit [Ping timeout: 240 seconds] 10:34 -!- brianhoffman [~brianhoff@pool-96-255-225-209.washdc.fios.verizon.net] has joined #bitcoin-core-dev 10:35 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 10:35 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 10:37 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 10:37 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 10:39 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 10:40 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 10:57 -!- Randolf [~randolf@24.244.23.233] has joined #bitcoin-core-dev 11:01 -!- gwillen [~gwillen@unaffiliated/gwillen] has joined #bitcoin-core-dev 11:02 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 11:04 -!- Randolf [~randolf@24.244.23.233] has quit [Ping timeout: 240 seconds] 11:05 -!- GoldenBear [gb@2600:3c03::f03c:91ff:fed5:ebbc] has joined #bitcoin-core-dev 11:05 -!- timothy [~tredaelli@redhat/timothy] has quit [Client Quit] 11:11 -!- Arokh [~Arokh@extknot.com] has quit [Quit: This should never happen] 11:11 -!- Arokh [~Arokh@extknot.com] has joined #bitcoin-core-dev 11:23 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 11:23 < bitcoin-git> [bitcoin] practicalswift closed pull request #12665: Add compile time checking for run time locking assertions (master...compile-time-checking-of-runtime-assertions) https://github.com/bitcoin/bitcoin/pull/12665 11:24 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 11:28 -!- LeMiner [~LeMiner@unaffiliated/leminer] has joined #bitcoin-core-dev 11:46 < jamesob> are there any caveats we know of re: usage of std::mutex/std::lock_guard on windows? I'm seeing some weird unhandled page faults only on windows with pretty vanilla usage of these constructs 11:57 < sipa> jamesob: care to create a minimal reproduction? 11:58 < jamesob> sipa: yeah, I might have to go down that road 12:03 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection] 12:17 -!- isis is now known as isis_ 12:28 -!- LeMiner2 [~LeMiner@ip-213-127-111-3.ip.prioritytelecom.net] has joined #bitcoin-core-dev 12:32 -!- LeMiner [~LeMiner@unaffiliated/leminer] has quit [Ping timeout: 264 seconds] 12:32 -!- LeMiner2 is now known as LeMiner 12:42 -!- moneyball [~moneyball@c-73-223-73-149.hsd1.ca.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 12:52 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 12:55 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-kjbhlqfevfuaieyp] has joined #bitcoin-core-dev 12:57 -!- jimpo [~jimpo@ec2-52-42-179-84.us-west-2.compute.amazonaws.com] has quit [Quit: ZNC 1.6.5 - http://znc.in] 12:57 -!- votefrac [~votef@185.60.147.79] has joined #bitcoin-core-dev 13:01 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 13:13 < jamesob> sipa: this is as concise as I've gotten it so far https://gist.github.com/jamesob/fe9a872051a88b2025b1aa37bfa98605 13:13 -!- votefrac [~votef@185.60.147.79] has quit [Ping timeout: 255 seconds] 13:15 < jamesob> updated with something simpler yet 13:16 < jamesob> hm, seems to have to do with thread_local usage 13:17 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 13:17 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-kagxycjlfheqoffl] has joined #bitcoin-core-dev 13:18 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 13:24 < jamesob> either windows c++11 compiler is subtly busted or I don't understand c++; updated the gist with a patch that makes it work: https://gist.github.com/jamesob/fe9a872051a88b2025b1aa37bfa98605#file-works-cpp-L13 13:27 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has joined #bitcoin-core-dev 13:29 -!- LeMiner2 [~LeMiner@ip-213-127-111-3.ip.prioritytelecom.net] has joined #bitcoin-core-dev 13:32 -!- LeMiner [~LeMiner@ip-213-127-111-3.ip.prioritytelecom.net] has quit [Ping timeout: 264 seconds] 13:32 -!- LeMiner2 is now known as LeMiner 13:33 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 13:39 -!- jimpo [~jimpo@ec2-34-211-143-113.us-west-2.compute.amazonaws.com] has joined #bitcoin-core-dev 13:39 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Quit: WeeChat 1.4] 13:44 -!- go1111111 [~go1111111@199.231.240.191] has joined #bitcoin-core-dev 13:44 -!- dbt001 [d5cdc211@gateway/web/freenode/ip.213.205.194.17] has joined #bitcoin-core-dev 13:53 -!- dbt001 [d5cdc211@gateway/web/freenode/ip.213.205.194.17] has quit [Ping timeout: 260 seconds] 13:55 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has quit [Ping timeout: 240 seconds] 14:13 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:14 -!- DrFeelGood [~DrFeelGoo@unaffiliated/olufunmilayo] has joined #bitcoin-core-dev 14:15 < booyah> jamesob: why this_id would need to be static? instead of simple std::string local variable? 14:15 -!- Giszmo [~leo@ip-54-237-219-201.nextelmovil.cl] has joined #bitcoin-core-dev 14:20 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 14:22 < jamesob> booyah: in the real usecase, we're trying to establish a unique ID per thread on a one-time basis 14:24 < sipa> jamesob: wouldn't surprise me if thread_local is broken in some mingw versions 14:25 < jamesob> sipa: certainly appears so. I'm just gonna avoid using it altogether on WIN32 14:26 < booyah> jamesob: would you report a bug to compiler devels? 14:26 < jamesob> booyah: yeah probably 14:27 < booyah> jamesob: ##c++ both are working fine on msvc 14:28 < jamesob> as sipa says, it may be a mingw32-specific thing 14:29 -!- LeMiner2 [~LeMiner@ip-213-127-111-3.ip.prioritytelecom.net] has joined #bitcoin-core-dev 14:30 < booyah> jamesob: maybe this bug? https://gcc.gnu.org/bugzilla/show_bug.cgi?id=83562 14:31 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Quit: Konversation terminated!] 14:32 -!- cryptapus [~cryptapus@jupiter.osmus.org] has joined #bitcoin-core-dev 14:32 -!- cryptapus [~cryptapus@jupiter.osmus.org] has quit [Changing host] 14:32 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev 14:32 < jamesob> booyah: I can't repro that 14:32 -!- LeMiner [~LeMiner@ip-213-127-111-3.ip.prioritytelecom.net] has quit [Ping timeout: 264 seconds] 14:32 -!- LeMiner2 is now known as LeMiner 14:44 < sipa> jamesob: wouldn't it be easier to just always use std::this_thread::get_id() ? 14:44 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Read error: Connection reset by peer] 14:45 < jamesob> sipa: I'd love to do that provided we can assume it's always compatible with boost threads 14:45 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 14:45 < sipa> do we use boost threads anywhere? 14:46 < sipa> seems we do. 14:47 < jamesob> yeah, seems like it: https://github.com/bitcoin/bitcoin/blob/66fcbdcc4cbf5a99fad3ef6b4c953474c92af1be/src/init.cpp#L173 14:48 < sipa> alternatively, i expect boost::this_thread::native_handle to always work 14:49 < sipa> oh, that may not exist 14:50 < jamesob> sipa: even if it did, wouldn't we have to have a bunch of platform-specific cases? 14:50 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has quit [] 14:51 < sipa> if std::this_thread::get_id works everywhere, could we try that? 14:52 -!- dx25 [~dx25@97.119.180.105] has quit [Quit: ZNC 1.6.3+deb1 - http://znc.in] 14:53 < jamesob> sure thing 14:53 < sipa> also, no need to convert to std::string; you can use std::thread::id as a map key 14:53 < jamesob> willdo 15:02 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 15:03 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 15:05 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-kjbhlqfevfuaieyp] has quit [Quit: Connection closed for inactivity] 15:11 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 15:12 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 15:21 -!- LeMiner [~LeMiner@ip-213-127-111-3.ip.prioritytelecom.net] has quit [Ping timeout: 264 seconds] 15:23 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has quit [Ping timeout: 248 seconds] 15:24 < promag> jnewbery: re #10740, should it be possible to specify an absolute path if it's in the walletdir? 15:24 < gribble> https://github.com/bitcoin/bitcoin/issues/10740 | [wallet] `loadwallet` RPC - load wallet at runtime by jnewbery · Pull Request #10740 · bitcoin/bitcoin · GitHub 15:24 -!- laurentmt [~Thunderbi@37.58.58.232] has joined #bitcoin-core-dev 15:25 -!- laurentmt [~Thunderbi@37.58.58.232] has quit [Client Quit] 15:33 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 15:33 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 15:34 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 276 seconds] 15:38 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 256 seconds] 15:40 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 15:45 -!- dx25 [~dx25@97.119.180.105] has joined #bitcoin-core-dev 15:47 -!- davec_ [~davec@cpe-24-243-249-218.hot.res.rr.com] has joined #bitcoin-core-dev 15:58 -!- grafcaps [~haroldbr@104.137.194.255] has quit [Ping timeout: 248 seconds] 16:09 -!- moneyball [~moneyball@c-73-223-73-149.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 16:12 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has quit [Read error: Connection reset by peer] 16:12 -!- grafcaps [~haroldbr@50.90.83.229] has joined #bitcoin-core-dev 16:13 < promag> BlueMatt: mind revisit #12151? 16:13 < gribble> https://github.com/bitcoin/bitcoin/issues/12151 | Remove cs_main lock from blockToJSON and blockheaderToJSON by promag · Pull Request #12151 · bitcoin/bitcoin · GitHub 16:14 -!- larafale [~larafale@ax213-1-82-66-157-194.fbx.proxad.net] has quit [Remote host closed the connection] 16:15 -!- Pat_Boy [xyz@192.99.249.194] has joined #bitcoin-core-dev 16:15 -!- TheV01d_ [thev01d@btc.mining.ga] has joined #bitcoin-core-dev 16:16 -!- Pat_Boy is now known as PatBoy 16:16 -!- TheV01d_ is now known as TheV01d 16:17 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 16:19 -!- nullptr| [~nullptr|@ip-94-113-103-134.net.upcbroadband.cz] has quit [Ping timeout: 240 seconds] 16:22 -!- nullptr| [~nullptr|@ip-94-113-103-134.net.upcbroadband.cz] has joined #bitcoin-core-dev 16:22 -!- infernix [nix@unaffiliated/infernix] has joined #bitcoin-core-dev 16:44 -!- moneyball [~moneyball@c-73-223-73-149.hsd1.ca.comcast.net] has quit [Quit: Textual IRC Client: www.textualapp.com] 17:30 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 17:44 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 17:45 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 17:49 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 264 seconds] 17:50 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 18:00 -!- harding [quassel@2600:3c03::f03c:91ff:fe7b:78d1] has quit [Remote host closed the connection] 18:05 -!- boblee [~boblee@unaffiliated/boblee] has quit [Quit: leaving] 18:05 -!- victorSN [~victorSN@ipc-hosting.de] has quit [Quit: Ping timeout (120 seconds)] 18:05 -!- victorSN [~victorSN@ipc-hosting.de] has joined #bitcoin-core-dev 18:16 -!- harding [~quassel@li1228-87.members.linode.com] has joined #bitcoin-core-dev 18:20 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 18:21 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 18:26 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 256 seconds] 19:26 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 19:31 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 268 seconds] 19:35 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 19:40 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 248 seconds] 20:01 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [] 20:03 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 20:04 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 20:19 -!- tralfaz [67fe9963@gateway/web/freenode/ip.103.254.153.99] has quit [Ping timeout: 260 seconds] 20:25 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 20:30 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 260 seconds] 20:53 -!- Giszmo [~leo@ip-54-237-219-201.nextelmovil.cl] has quit [Read error: Connection reset by peer] 21:13 -!- Giszmo [~leo@pc-37-38-86-200.cm.vtr.net] has joined #bitcoin-core-dev 21:14 -!- jtimon [~quassel@142.29.134.37.dynamic.jazztel.es] has quit [Ping timeout: 264 seconds] 21:27 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-kagxycjlfheqoffl] has quit [Quit: Connection closed for inactivity] 22:40 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 22:40 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 22:41 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 22:45 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 240 seconds] 23:09 < wumpus> MarcoFalke: nice, since #13051 it's possible to run individual functional tests in an out-of-tree build without having to manually provide BITCOIND=... 23:09 < gribble> https://github.com/bitcoin/bitcoin/issues/13051 | qa: Normalize executable location by MarcoFalke · Pull Request #13051 · bitcoin/bitcoin · GitHub 23:15 < wumpus> though I'm confused how that manages to work, does it store the ini in the source directory? 23:16 -!- grafcaps [~haroldbr@50.90.83.229] has quit [Ping timeout: 268 seconds] 23:21 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 23:21 -!- isis_ is now known as isis 23:26 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 264 seconds] 23:40 -!- skt [6f76f82e@gateway/web/freenode/ip.111.118.248.46] has joined #bitcoin-core-dev 23:40 -!- skt [6f76f82e@gateway/web/freenode/ip.111.118.248.46] has left #bitcoin-core-dev [] 23:42 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-biiuthamilfbgatk] has joined #bitcoin-core-dev