--- Day changed Mon May 07 2018 00:09 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 240 seconds] 00:14 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-khokyzenykrlfpee] has joined #bitcoin-core-dev 00:30 -!- zautomata3 [~zautomata@41.232.221.192] has quit [Ping timeout: 240 seconds] 00:33 -!- zautomata3 [~zautomata@41.232.221.192] has joined #bitcoin-core-dev 00:36 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 00:37 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 00:41 -!- ken2812221 [~User@133-203.dorm.ncu.edu.tw] has quit [Quit: Leaving] 00:42 -!- ken2812221 [~User@140.115.203.133] has joined #bitcoin-core-dev 00:50 -!- Randolf [~randolf@209.205.87.205.core.cipherkey.net] has joined #bitcoin-core-dev 01:09 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 01:10 -!- Krellan [~Krellan@2601:640:4000:9258:1954:bd88:753b:f14c] has quit [Remote host closed the connection] 01:12 -!- Randolf [~randolf@209.205.87.205.core.cipherkey.net] has quit [Ping timeout: 240 seconds] 01:17 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 01:18 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 01:19 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:21 -!- dafuq_ [~dafuq@S01061cabc0b054b3.ok.shawcable.net] has joined #bitcoin-core-dev 01:22 -!- murrayn [~dafuq@unaffiliated/murrayn] has quit [Ping timeout: 248 seconds] 01:23 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 240 seconds] 01:23 -!- drizztbsd [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:23 -!- drizztbsd is now known as timothy 01:23 -!- mistergold [~mistergol@77.243.24.204] has joined #bitcoin-core-dev 01:26 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 01:39 -!- harrymm [~harrymm@223.204.114.149] has quit [Ping timeout: 260 seconds] 01:43 -!- Krellan [~Krellan@2601:640:4000:9258:ccfe:4154:25b0:bd8e] has joined #bitcoin-core-dev 01:48 -!- Krellan [~Krellan@2601:640:4000:9258:ccfe:4154:25b0:bd8e] has quit [Ping timeout: 276 seconds] 01:48 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev 01:51 -!- harrymm [~harrymm@223.204.114.149] has joined #bitcoin-core-dev 02:01 -!- Beatrice46Champl [~Beatrice4@ns334669.ip-5-196-64.eu] has quit [Remote host closed the connection] 02:10 < provoostenator> TL&DR: 3:00 hours on t2.2xlarge, c5.2xlarge, 3:50 hours on m5.2xlarge. I ran out of ideas to make it run faster, see logs in #blockchain-sync. 02:22 -!- dafuq_ [~dafuq@S01061cabc0b054b3.ok.shawcable.net] has quit [Quit: Adios mofos] 02:22 -!- murrayn [~dafuq@unaffiliated/murrayn] has joined #bitcoin-core-dev 02:40 -!- Krellan [~Krellan@2601:640:4000:9258:458c:649:ed6c:2ac5] has joined #bitcoin-core-dev 02:43 -!- Krellan [~Krellan@2601:640:4000:9258:458c:649:ed6c:2ac5] has quit [Remote host closed the connection] 02:43 -!- Krellan [~Krellan@2601:640:4000:9258:458c:649:ed6c:2ac5] has joined #bitcoin-core-dev 02:53 -!- jtimon [~quassel@50-200-142-46.pool.kielnet.net] has joined #bitcoin-core-dev 02:55 -!- Brant73Grady [~Brant73Gr@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 03:00 -!- jtimon [~quassel@50-200-142-46.pool.kielnet.net] has quit [Ping timeout: 260 seconds] 03:08 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 03:09 -!- jtimon [~quassel@50-200-142-46.pool.kielnet.net] has joined #bitcoin-core-dev 03:09 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 03:11 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 03:22 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:27 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds] 03:28 < bitcoin-git> [bitcoin] glaksmono opened pull request #13183: [WIP][bitcoin-11004] New Travis job for CHECK_DOCS steps (master...bitcoin-11004) https://github.com/bitcoin/bitcoin/pull/13183 03:42 -!- dafuq[m] [~dafuqm]@unaffiliated/dafuq-m/x-8291849] has quit [Quit: Quit] 03:44 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has joined #bitcoin-core-dev 03:49 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/66cc47be982a...a174702bad1c 03:49 < bitcoin-git> bitcoin/master fad63eb John Newbery: [logging] Don't incorrectly log that REJECT messages are unknown.... 03:49 < bitcoin-git> bitcoin/master a174702 Wladimir J. van der Laan: Merge #13162: [net] Don't incorrectly log that REJECT messages are unknown.... 03:50 < bitcoin-git> [bitcoin] laanwj closed pull request #13162: [net] Don't incorrectly log that REJECT messages are unknown. (master...fix_reject_logging) https://github.com/bitcoin/bitcoin/pull/13162 03:55 < jtimon> sorry, I forgot to fix BlueMatt's latest nits on https://github.com/bitcoin/bitcoin/pull/10757 fixed now 03:56 < jtimon> btw, I'm confused about what "matt was here" means in this context. I thought it was mostly for refactors and meant something like "I don't see the value of this refactor but it doesn't break things and I don't care, so I won't nack", but this is adding new functionality 03:57 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 03:57 < jtimon> can someone clarify what's that supposed to mean, perhaps we can put that on the documentation like we have ACK, utACK, etc ? 03:57 < luke-jr> jtimon: the impression I got (but I never asked him) was that it was a kind of "I looked at this, but I didn't review it sufficiently to ACK" 03:58 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 04:00 < jtimon> luke-jr: I was under the impression he had reviewed it enough, but perhaps that's it 04:01 < luke-jr> well, sounds like BlueMatt should clarify ;) 04:02 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Remote host closed the connection] 04:12 -!- jtimon [~quassel@50-200-142-46.pool.kielnet.net] has quit [Ping timeout: 240 seconds] 04:16 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 04:17 -!- mistergold [~mistergol@77.243.24.204] has quit [Quit: leaving] 04:21 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds] 04:25 -!- zautomata3 [~zautomata@41.232.221.192] has quit [Quit: WeeChat 1.9.1] 04:28 -!- zautomata [~zautomata@41.232.221.192] has joined #bitcoin-core-dev 04:28 < bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a174702bad1c...6a01a50f4906 04:28 < bitcoin-git> bitcoin/master 43f3dec donaloconnor: Remove enum specifier (to avoid re-declare scoped enum as unscoped) 04:28 < bitcoin-git> bitcoin/master 6a01a50 Jonas Schnelli: Merge #13180: Fix re-declared scoped enum as unscoped (Causes issues with some compilers)... 04:29 < bitcoin-git> [bitcoin] jonasschnelli closed pull request #13180: Fix re-declared scoped enum as unscoped (Causes issues with some compilers) (master...06052018_unscoped_enum) https://github.com/bitcoin/bitcoin/pull/13180 04:33 -!- Krellan [~Krellan@2601:640:4000:9258:458c:649:ed6c:2ac5] has quit [Ping timeout: 265 seconds] 04:33 -!- murrayn [~dafuq@unaffiliated/murrayn] has quit [Read error: Connection reset by peer] 04:33 -!- Krellan [~Krellan@2601:640:4000:9258:458c:649:ed6c:2ac5] has joined #bitcoin-core-dev 04:33 -!- murrayn [~dafuq@S01061cabc0b054b3.ok.shawcable.net] has joined #bitcoin-core-dev 04:33 -!- murrayn [~dafuq@S01061cabc0b054b3.ok.shawcable.net] has quit [Changing host] 04:33 -!- murrayn [~dafuq@unaffiliated/murrayn] has joined #bitcoin-core-dev 04:39 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/6a01a50f4906...bd83704ec6fa 04:39 < bitcoin-git> bitcoin/master 29c9bdc practicalswift: Handle unsuccessful fseek(...):s 04:39 < bitcoin-git> bitcoin/master 20ce5af practicalswift: Print a log message if we fail to shrink the debug log file 04:40 < bitcoin-git> bitcoin/master bd83704 Wladimir J. van der Laan: Merge #13149: Handle unsuccessful fseek(...):s... 04:40 < bitcoin-git> [bitcoin] laanwj closed pull request #13149: Handle unsuccessful fseek(...):s (master...fseek) https://github.com/bitcoin/bitcoin/pull/13149 04:50 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 05:07 -!- infernix [nix@unaffiliated/infernix] has quit [Ping timeout: 276 seconds] 05:12 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 05:16 -!- Cory [~Cory@unaffiliated/cory] has quit [Ping timeout: 276 seconds] 05:18 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 05:22 -!- jtimon [~quassel@50-200-142-46.pool.kielnet.net] has joined #bitcoin-core-dev 05:23 -!- Cory [~Cory@unaffiliated/cory] has joined #bitcoin-core-dev 05:33 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/bd83704ec6fa...57aae632e288 05:33 < bitcoin-git> bitcoin/master ddebde7 Chun Kuan Lee: Add Windows shutdown handler 05:33 < bitcoin-git> bitcoin/master 57aae63 Wladimir J. van der Laan: Merge #13131: Add Windows shutdown handler... 05:34 < bitcoin-git> [bitcoin] laanwj closed pull request #13131: Add Windows shutdown handler (master...win-quit) https://github.com/bitcoin/bitcoin/pull/13131 05:52 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 05:53 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 05:54 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer] 05:54 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 05:55 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 240 seconds] 05:55 -!- Anduck [~Anduck@unaffiliated/anduck] has quit [Quit: leaving] 05:56 -!- vicenteH [~user@195.235.96.150] has joined #bitcoin-core-dev 05:56 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 06:01 -!- dafuq_ [~dafuq@S01061cabc0b054b3.ok.shawcable.net] has joined #bitcoin-core-dev 06:04 < bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/57aae632e288...5778d44aa857 06:04 < bitcoin-git> bitcoin/master 16be133 Ben Woosley: Fix rescanblockchain rpc to property report progress... 06:04 -!- BCBot_ [~BCBot@46.101.246.115] has joined #bitcoin-core-dev 06:04 < bitcoin-git> bitcoin/master 5778d44 Jonas Schnelli: Merge #13079: Fix rescanblockchain rpc to properly report progress... 06:04 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 06:04 < bitcoin-git> [bitcoin] jonasschnelli closed pull request #13079: Fix rescanblockchain rpc to properly report progress (master...scan-for-wallet-stopblock-progress) https://github.com/bitcoin/bitcoin/pull/13079 06:05 -!- roasbeef_ [~root@104.131.26.124] has joined #bitcoin-core-dev 06:05 -!- karl [~karl@fp96f94c66.tkyc515.ap.nuro.jp] has joined #bitcoin-core-dev 06:06 -!- Sentineo_ [~Undefined@unaffiliated/sentineo] has joined #bitcoin-core-dev 06:06 -!- dongcarl_ [~dongcarl@c-24-5-70-69.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 06:08 -!- chainhead_ [~chainhead@108.61.159.53] has joined #bitcoin-core-dev 06:08 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 06:09 -!- instagibbs_ [~instagibb@pool-100-15-128-78.washdc.fios.verizon.net] has joined #bitcoin-core-dev 06:09 -!- gaf__ [~fag@12.smos-linux.org] has joined #bitcoin-core-dev 06:09 -!- lysobit_ [~musalbas@algebra.musalbas.com] has joined #bitcoin-core-dev 06:10 -!- wraithm_ [~wraithm@unaffiliated/wraithm] has joined #bitcoin-core-dev 06:11 -!- lysobit_ is now known as musalbas 06:12 -!- Netsplit over, joins: [b__b] 06:13 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 240 seconds] 06:13 -!- infernix [nix@unaffiliated/infernix] has joined #bitcoin-core-dev 06:15 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev 06:15 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5778d44aa857...bf9b03ddcc65 06:15 < bitcoin-git> bitcoin/master ab3f4dd Chun Kuan Lee: tests: Add test for 64-bit PE, modify 32-bit test results... 06:15 < bitcoin-git> bitcoin/master bf9b03d Wladimir J. van der Laan: Merge #13094: tests: Add test for 64-bit Windows PE, modify 32-bit test results... 06:15 -!- cphrmky [~cphrmky@ec2-107-23-237-131.compute-1.amazonaws.com] has quit [Quit: leaving] 06:16 < bitcoin-git> [bitcoin] laanwj closed pull request #13094: tests: Add test for 64-bit Windows PE, modify 32-bit test results (master...patch-1) https://github.com/bitcoin/bitcoin/pull/13094 06:19 -!- Netsplit over, joins: harrymm 06:21 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 06:23 <@wumpus> #10267 gives me an unicorn 06:23 < gribble> https://github.com/bitcoin/bitcoin/issues/10267 | New -includeconf argument for including external configuration files by kallewoof · Pull Request #10267 · bitcoin/bitcoin · GitHub 06:24 -!- Anduck [~Anduck@unaffiliated/anduck] has joined #bitcoin-core-dev 06:29 <@wumpus> I'll complain to github 06:29 -!- nullptr| [~nullptr|@ip-94-113-103-134.net.upcbroadband.cz] has quit [Ping timeout: 265 seconds] 06:34 -!- jouke [~jouke@a80-100-203-151.adsl.xs4all.nl] has quit [Ping timeout: 255 seconds] 06:34 -!- jouke [~jouke@a80-100-203-151.adsl.xs4all.nl] has joined #bitcoin-core-dev 06:35 -!- nullptr| [~nullptr|@ip-94-113-103-134.net.upcbroadband.cz] has joined #bitcoin-core-dev 06:35 < aj> wumpus: tried clearing your cookies? 06:36 <@wumpus> yeah I can try that again... 06:37 < jonasschnelli> Also getting a unicorn 06:37 <@wumpus> though I have a hard time believing my browser's handling of cookies is at fault here 06:38 <@wumpus> contacted github anyhow 06:38 -!- Oldnewbie [6b4df103@gateway/web/freenode/ip.107.77.241.3] has joined #bitcoin-core-dev 06:39 -!- jouke [~jouke@a80-100-203-151.adsl.xs4all.nl] has quit [Ping timeout: 268 seconds] 06:42 -!- zivl [~zivl@2601:19a:837f:e4e1:24d9:8e03:820f:2fd7] has joined #bitcoin-core-dev 06:43 < Oldnewbie> Quit 06:43 -!- Oldnewbie [6b4df103@gateway/web/freenode/ip.107.77.241.3] has quit [Client Quit] 06:45 < promag> unicorn too 06:45 -!- m8tion [~Agence@abo-87-113-68.mrs.modulonet.fr] has joined #bitcoin-core-dev 06:46 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 06:46 <@wumpus> jonasschnelli: btw - what is the process for importing a new libbtc into bitcoincore-indexd? I need MSG_WITNESS_BLOCK 06:47 <@wumpus> is it a subtree? 06:47 -!- Krellan [~Krellan@2601:640:4000:9258:458c:649:ed6c:2ac5] has quit [Read error: Connection reset by peer] 06:47 < jonasschnelli> wumpus: I think I have added it as subtree 06:47 < jonasschnelli> wumpus: BTW: I'm currently running a script that runs 10 times block fetching from 490000 till 500000 and measures times 06:47 < jonasschnelli> Currently running on master... will compare than against your PR and report. 06:48 -!- jouke [~jouke@a80-100-203-151.adsl.xs4all.nl] has joined #bitcoin-core-dev 06:48 < jonasschnelli> Since this is on SSD, may result may be even more promissing then yours 06:48 <@wumpus> I hope so :) 06:48 <@wumpus> though 10% gain is already somewhat neat 06:49 -!- Krellan [~Krellan@2601:640:4000:9258:458c:649:ed6c:2ac5] has joined #bitcoin-core-dev 06:49 < jonasschnelli> wumpus: Yes! 10% is already great! 06:50 < BlueMatt> jtimon: in this case it means what you thought - "I dont care about this feature, so I'm not gonna ack it, but it seems like some folks want it, so certainly wont oppose. Aside from the comments left, I see no other bugs, and so am fine with it advancing, but do not wish to in any way imply a concept ack" 06:50 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 06:54 -!- BCBot_ [~BCBot@46.101.246.115] has quit [Remote host closed the connection] 06:55 -!- Kaylin69Doyle [~Kaylin69D@ns334669.ip-5-196-64.eu] has joined #bitcoin-core-dev 06:55 -!- BCBot [~BCBot@46.101.246.115] has joined #bitcoin-core-dev 06:55 -!- satwo [~textual@2602:306:378a:6fb0:d191:8d6f:8ca9:6897] has joined #bitcoin-core-dev 06:55 < BlueMatt> luke-jr: plz2rebase #12208? Trying to whip 0.16.1 :p 06:55 < gribble> https://github.com/bitcoin/bitcoin/issues/12208 | GUI: Rephrase Bech32 checkbox texts, and enable it with legacy address default by luke-jr · Pull Request #12208 · bitcoin/bitcoin · GitHub 06:57 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 06:58 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 07:00 < jtimon> BlueMatt: thanks for claryfing 07:02 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 07:02 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 07:03 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 07:04 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 07:07 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 07:07 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 07:09 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 07:09 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 07:11 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 07:11 -!- glaksmono [~glaksmono@158.140.182.56] has joined #bitcoin-core-dev 07:11 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 264 seconds] 07:11 < bitcoin-git> [bitcoin] harding opened pull request #13184: RPC Docs: gettxout*: clarify bestblock and unspent counts (master...2018-05-rpc-help-bestblock) https://github.com/bitcoin/bitcoin/pull/13184 07:11 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 07:12 < jonasschnelli> How do I only allow connection from 127.0.0.1? 07:12 < glaksmono> hi guys, i'm trying to find a reviewer for this: https://github.com/bitcoin/bitcoin/pull/13183 07:12 < glaksmono> can someone help? 07:12 < jonasschnelli> Seems like whitelist=127.0.0.1 and connect=0 won't work 07:12 < jonasschnelli> glaksmono: have some patience 07:12 < glaksmono> alright @jonasschnelli 07:12 < glaksmono> i'm a newbie contributor :) 07:12 < jonasschnelli> glaksmono: also, maybe write some pull request description (not only refere to the issue) 07:13 < jonasschnelli> NM: whitebind=127.0.0.1:8333 fixed my issue 07:13 -!- grafcaps [~haroldbr@50.90.83.229] has quit [Ping timeout: 248 seconds] 07:14 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 07:19 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 07:20 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 07:20 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 07:25 -!- rex4539 [~textual@2a02:587:3516:1600:148b:833f:30cb:5531] has joined #bitcoin-core-dev 07:26 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 260 seconds] 07:28 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has joined #bitcoin-core-dev 07:28 <@wumpus> jonasschnelli: subtree merge from libbtc/libbtc gives me tons of conflicts 07:29 -!- Dizzle [~dizzle@108.171.182.16] has joined #bitcoin-core-dev 07:29 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 07:29 < jonasschnelli> wumpus: try rm -rf src/libbtc and then a fresh git subtree add? 07:30 < jonasschnelli> I'm pretty sure I haven't done local changes 07:30 <@wumpus> or I'll resolve the conflicts to 'theirs' 07:30 < jonasschnelli> yeah 07:30 <@wumpus> let's see if it still builds at all 07:31 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection] 07:32 < jonasschnelli> I don't know why I had to manually add a LDADD+=-lpthread in the bitcoincore-indexd project... seems that lpthread will not auto-added via Makefile.leveldb.am 07:32 -!- grafcaps [~haroldbr@104.137.194.255] has joined #bitcoin-core-dev 07:40 < jonasschnelli> hmm... master is quicker then PR 13151?! let me double check... 07:40 <@wumpus> jonasschnelli: eh whoops libbbtc serialize.h has two LIBBTC_END_DECL 07:41 < jonasschnelli> wumpus: hmm.. that was a recent change by promag... 07:41 < jonasschnelli> should this not have been detected by travis.. 07:45 <@wumpus> jonasschnelli: if that header is used in one of the tests, which I assume, yes :) 07:48 <@wumpus> jonasschnelli: I think I know why travis passed with it: in C, the macros are defined as nothing 07:48 <@wumpus> this problem is only apparent when the lib is used from C++ 07:49 < jonasschnelli> ah.. right! 07:50 < jonasschnelli> wumpus: any reason why your PR 13151 preforms ~6% slower then master? 07:51 < jonasschnelli> I just reverted back to 598db389c33e5e90783ef1223df2eeab095ed622 from 13151 head to make sure im comparing the right things 07:51 <@wumpus> jonasschnelli: you do request MSG_WITNESS_BLOCK at all? 07:51 < jonasschnelli> let me dbl check 07:52 <@wumpus> if so, I'm confused, I don't see how this can be *slower* 07:52 <@wumpus> maybe add back the LogPrintf to make sure it's hitting the new fast path at all 07:52 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 07:52 < jonasschnelli> wumpus: ser_u32(inv_msg_cstr, 2 | (1 << 30)); 07:52 < jonasschnelli> seems correct 07:53 <@wumpus> yes 07:53 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer] 07:54 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 07:56 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 07:57 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 07:57 < jonasschnelli> wumpus: you mean that one: https://github.com/bitcoin/bitcoin/pull/13151/commits/4c790dff7481d1464a906ad6b17a3179a7da3431#diff-eff7adeaec73a769788bb78858815c91R1149? 08:00 -!- grafcaps [~haroldbr@104.137.194.255] has quit [Quit: Lost terminal] 08:00 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 255 seconds] 08:00 <@wumpus> yes the ""debug: Serving raw block directly from disk" 08:01 <@wumpus> although remove it when performance benchmarking, as all the log messages will again make it slower... 08:01 < jonasschnelli> Yes. Sure 08:02 < jonasschnelli> jup.. its firing... 08:02 -!- tryphe_000 [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 08:02 < jonasschnelli> I do now disable the logprintf and test again... 08:04 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 08:05 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 08:05 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 268 seconds] 08:06 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 08:07 -!- tryphe_000 [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 260 seconds] 08:08 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 08:10 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 08:13 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 08:14 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 08:14 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 08:16 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 08:16 -!- jb55 [~jb55@node-1w7jr9qkydhiku0jsgcb1oc8y.ipv6.telus.net] has joined #bitcoin-core-dev 08:18 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 08:19 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 08:19 -!- spudowiar [~u0_a69@unaffiliated/saleemrashid] has joined #bitcoin-core-dev 08:19 -!- spudowiar [~u0_a69@unaffiliated/saleemrashid] has quit [Remote host closed the connection] 08:22 -!- spudowiar [~u0_a69@unaffiliated/saleemrashid] has joined #bitcoin-core-dev 08:29 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 08:30 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 08:31 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 08:33 < promag> wumpus: regarding block.resize(blk_size); 08:34 < promag> filein.read((char*)block.data(), blk_size) will overwrite those zeros.. so I really don't get it 08:34 <@wumpus> what if it somehow fails 08:35 <@wumpus> my point is defense in depth here 08:35 -!- ula [~ula@b2b-78-94-9-226.unitymedia.biz] has quit [Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/] 08:35 -!- glaksmono [~glaksmono@158.140.182.56] has quit [Remote host closed the connection] 08:35 < promag> you mean read fails? 08:35 <@wumpus> yes 08:36 -!- glaksmono [~glaksmono@158.140.182.56] has joined #bitcoin-core-dev 08:36 < promag> then it shouldn't serve, it should fail? 08:36 <@wumpus> it should, but a bug might prevent that 08:36 <@wumpus> either a kernel bug or something else 08:38 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 08:38 < promag> ok, I wounder if it has performance impact regarding jonas bench 08:38 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 08:38 <@wumpus> only if you can measure a significant improvement of not zeroing I'm willing to argue about this further 08:39 <@wumpus> otherwise it seems pointless shed painting... 08:39 < jamesob> hm. If I'm gonna implement a threadsafe ring buffer for use with the async logging stuff, better to do that as a general module (a util sort of thing) or within a logging-specific module? 08:40 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 08:40 <@wumpus> jamesob: depends on how much work it is to make it general instead of specific, and how much extra code that brings. If not much, making it general is preferable of course. 08:40 -!- glaksmono [~glaksmono@158.140.182.56] has quit [Ping timeout: 268 seconds] 08:41 < jamesob> wumpus: good advice, thanks 08:43 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 08:43 < sipa> wumpus, promag: is there even a way to resize a vector _without_ initializing the chars to 0? 08:43 <@wumpus> jonasschnelli: seems you merged https://github.com/jonasschnelli/bitcoincore-indexd/pull/1, I think we had to update it to include https://github.com/libbtc/libbtc/pull/127 08:43 <@wumpus> sipa: no :/ 08:44 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 08:45 <@wumpus> so indeed, I don't know what the c++11 "nice" way to do that is, could use a unique_ptr to a new [] array instead of a vector, or something else, but nothing seems really elegant 08:45 < sipa> std::array :) 08:45 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 08:45 < sipa> which does not seem to require initializing the elements 08:45 <@wumpus> does that work for variable lengths? 08:45 < sipa> no 08:48 < spudowiar> How is someone actually supposed to say they know C++ when you might blink and we'll suddenly be on C++18428 and it'll look like some dialect of Python 08:51 < spudowiar> https://github.com/facebook/folly/blob/master/folly/memory/UninitializedMemoryHacks.h 08:52 < spudowiar> That looks perfectly safe and not at all a terrible hack 08:57 < cfields> sipa: I believe a std::vector with a custom allocator can 09:01 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 09:05 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 09:05 <@wumpus> spudowiar: yeah... language evolution is not a bad thing, and c++11 brings a lot of useful things, but c++ is alread such a crazy complex language, it's increasingly impossible to say you really know it. 09:06 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 09:09 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 09:09 < sipa> spudowiar: "folly" i would say 09:09 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 09:10 -!- Krellan [~Krellan@2601:640:4000:9258:458c:649:ed6c:2ac5] has quit [Read error: Connection reset by peer] 09:10 <@wumpus> yes it scares me, let's just zero the vector ok 09:12 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 09:13 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 09:14 -!- Krellan [~Krellan@2601:640:4000:9258:458c:649:ed6c:2ac5] has joined #bitcoin-core-dev 09:17 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 09:17 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 09:17 < sipa> wumpus: ack 09:18 < jonasschnelli> wumpus: meh. yes. Let me push a subtree update then. 09:20 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 09:20 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 09:20 < promag> jonasschnelli: wumpus: should libbtc have a c++ job in travis? 09:22 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 09:23 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 09:24 < jonasschnelli> promag: yes. a little c++ test would be great. 09:27 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 09:27 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 09:29 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 09:29 -!- spudowiar is now known as x123456789 09:29 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 09:30 -!- x123456789 is now known as spudowiar 09:31 -!- meshcollider [uid246294@gateway/web/irccloud.com/x-khokyzenykrlfpee] has quit [Quit: Connection closed for inactivity] 09:33 <@wumpus> promag: I think for most intents and purposes it doesn't matter, for a C library, except the specific thing (`extern "C" {` in headers) you were changing 09:34 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 09:35 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 09:36 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 09:37 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 09:39 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 09:39 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 09:40 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 09:40 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 09:42 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 09:43 -!- Krellan [~Krellan@2601:640:4000:9258:458c:649:ed6c:2ac5] has quit [Ping timeout: 255 seconds] 09:44 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 09:44 -!- Krellan [~Krellan@2601:640:4000:9258:458c:649:ed6c:2ac5] has joined #bitcoin-core-dev 09:44 -!- isis is now known as isis_ 09:47 < promag> BlueMatt: I can rebase #13063 on master and leave walletmanager out for now 09:47 < gribble> https://github.com/bitcoin/bitcoin/issues/13063 | Use shared pointer to retain wallet instance by promag · Pull Request #13063 · bitcoin/bitcoin · GitHub 09:48 < BlueMatt> I mean I presume given the annoyance of moving forward with the loadwallet stuff we should do a minimal fix to get that through, and then we can clean it up as all that stuff matures 09:48 -!- m8tion [~Agence@abo-87-113-68.mrs.modulonet.fr] has quit [Read error: Connection reset by peer] 09:50 < promag> so you suggest to reopen #12647? 09:50 < gribble> https://github.com/bitcoin/bitcoin/issues/12647 | wallet: Fix possible memory leak in CreateWalletFromFile. by jimpo · Pull Request #12647 · bitcoin/bitcoin · GitHub 09:50 < promag> BlueMatt: annoyance? :) 09:50 -!- jtimon [~quassel@50-200-142-46.pool.kielnet.net] has quit [Remote host closed the connection] 09:52 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 09:52 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 09:53 -!- Krellan [~Krellan@2601:640:4000:9258:458c:649:ed6c:2ac5] has quit [Ping timeout: 240 seconds] 09:54 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 09:54 -!- Krellan [~Krellan@2601:640:4000:9258:458c:649:ed6c:2ac5] has joined #bitcoin-core-dev 09:56 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 265 seconds] 09:58 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 10:05 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 10:11 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 255 seconds] 10:13 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 10:14 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer] 10:18 -!- glaksmono [~glaksmono@158.140.182.56] has joined #bitcoin-core-dev 10:18 -!- CubicEarths [~cubiceart@c-66-30-214-9.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 10:18 -!- Krellan [~Krellan@2601:640:4000:9258:458c:649:ed6c:2ac5] has quit [Ping timeout: 255 seconds] 10:19 -!- Krellan [~Krellan@2601:640:4000:9258:458c:649:ed6c:2ac5] has joined #bitcoin-core-dev 10:20 -!- spudowiar [~u0_a69@unaffiliated/saleemrashid] has quit [Quit: WeeChat 2.1] 10:21 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Remote host closed the connection] 10:22 -!- glaksmono [~glaksmono@158.140.182.56] has quit [Ping timeout: 264 seconds] 10:27 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 10:30 -!- zivl [~zivl@2601:19a:837f:e4e1:24d9:8e03:820f:2fd7] has quit [Ping timeout: 276 seconds] 10:31 -!- mol [~m@unaffiliated/molly] has quit [Read error: Connection reset by peer] 10:31 -!- lnostdal [~lnostdal@85.118.82.43] has joined #bitcoin-core-dev 10:32 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 10:33 -!- Krellan [~Krellan@2601:640:4000:9258:458c:649:ed6c:2ac5] has quit [Ping timeout: 240 seconds] 10:35 -!- glaksmono [~glaksmono@158.140.182.56] has joined #bitcoin-core-dev 10:38 -!- molz [~m@unaffiliated/molly] has joined #bitcoin-core-dev 10:39 -!- glaksmono [~glaksmono@158.140.182.56] has quit [Ping timeout: 240 seconds] 10:41 -!- vicenteH [~user@195.235.96.150] has quit [Ping timeout: 248 seconds] 10:56 -!- zivl [~zivl@2601:19a:837f:e4e1:24d9:8e03:820f:2fd7] has joined #bitcoin-core-dev 11:01 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 248 seconds] 11:16 -!- roasbeef_ is now known as roasbeef 11:22 < bitcoin-git> [bitcoin] sipa opened pull request #13185: Bugfix: the end of a reorged chain is invalid when connect fails (master...201805_bugfix_invalidchain_end) https://github.com/bitcoin/bitcoin/pull/13185 11:35 -!- pierre_rochard [~pierre@unaffiliated/pierre-rochard/x-3593157] has joined #bitcoin-core-dev 11:37 -!- bsm1175321 [~mcelrath@173-9-124-61-NewEngland.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 11:38 -!- moneyball [~moneyball@65.200.72.90] has joined #bitcoin-core-dev 11:49 -!- Randolf [~randolf@69.166.112.240] has joined #bitcoin-core-dev 11:50 < bitcoin-git> [bitcoin] skeees opened pull request #13186: Use a semaphore to trigger shutdown procedures (master...shutdown-cv) https://github.com/bitcoin/bitcoin/pull/13186 11:53 -!- glaksmono [~glaksmono@158.140.182.56] has joined #bitcoin-core-dev 11:55 -!- DrDraake [48e02ad8@gateway/web/freenode/ip.72.224.42.216] has joined #bitcoin-core-dev 11:55 < DrDraake> hey guys 11:58 -!- glaksmono [~glaksmono@158.140.182.56] has quit [Ping timeout: 268 seconds] 12:01 < DrDraake> Don't know if this is the right channel. If someone has a offline bitcoin core wallet showing a balance and you can do not see the corresponding wallet on chain. If they send you a core to core transaction offline and you bring your core wallet online can that transaction confirm and previously they have sent the same amount of BTC to someone else who gets the BTC? Will it show in my wallet and when I go to spend it wil 12:02 -!- lnostdal [~lnostdal@85.118.82.43] has quit [Ping timeout: 240 seconds] 12:02 < BlueMatt> DrDraake: you probably want #bitcoin, but, if a transaction is not mine-able and your node is synced, it will be displayed as "conflicted" 12:02 < BlueMatt> (probably) 12:03 < DrDraake> I'm trying to figure out how can this wallet send me BTC if I can not verify they have the coin to begin with.... 12:03 < BlueMatt> you probably want #bitcoin, way more people there to help you out if you clarify what you want to do 12:03 < DrDraake> Thanks 12:03 -!- glaksmono [~glaksmono@158.140.182.56] has joined #bitcoin-core-dev 12:05 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 12:05 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 12:07 -!- glaksmono [~glaksmono@158.140.182.56] has quit [Ping timeout: 240 seconds] 12:09 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 12:09 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 12:11 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 12:12 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 12:13 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 12:13 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 12:13 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 12:14 -!- pierre_rochard [~pierre@unaffiliated/pierre-rochard/x-3593157] has quit [Quit: pierre_rochard] 12:15 -!- lnostdal [~lnostdal@85.118.82.149] has joined #bitcoin-core-dev 12:17 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 12:21 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 12:21 -!- CubicEarths [~cubiceart@c-66-30-214-9.hsd1.ma.comcast.net] has quit [Remote host closed the connection] 12:23 -!- pierre_rochard [~pierre@unaffiliated/pierre-rochard/x-3593157] has joined #bitcoin-core-dev 12:24 -!- CubicEarths [~cubiceart@c-66-30-214-9.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 12:25 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 12:25 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 12:42 -!- pierre_rochard [~pierre@unaffiliated/pierre-rochard/x-3593157] has quit [Quit: pierre_rochard] 12:43 -!- pierre_rochard [~pierre@unaffiliated/pierre-rochard/x-3593157] has joined #bitcoin-core-dev 12:49 -!- Randolf [~randolf@69.166.112.240] has quit [Ping timeout: 240 seconds] 12:59 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 13:00 -!- isis_ [~isis@abulafia.patternsinthevoid.net] has quit [Ping timeout: 264 seconds] 13:02 -!- RoyceX [Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has joined #bitcoin-core-dev 13:03 -!- isis_ [~isis@abulafia.patternsinthevoid.net] has joined #bitcoin-core-dev 13:05 -!- cheese_ [~Cheeseo@unaffiliated/cheeseo] has quit [Ping timeout: 255 seconds] 13:15 -!- Sinclair_ [sinclair6@gateway/vpn/privateinternetaccess/sinclair6] has quit [Ping timeout: 268 seconds] 13:21 -!- rex4539 [~textual@2a02:587:3516:1600:148b:833f:30cb:5531] has quit [Quit: Textual IRC Client: www.textualapp.com] 13:27 -!- Sinclair_ [sinclair6@gateway/vpn/privateinternetaccess/sinclair6] has joined #bitcoin-core-dev 13:27 -!- cheese_ [~Cheeseo@unaffiliated/cheeseo] has joined #bitcoin-core-dev 13:30 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 13:31 -!- RoyceX [Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has quit [Ping timeout: 255 seconds] 13:36 < jnewbery> I think we should consider putting #10973 on high priority for review. So far it has full review from jamesob and me, and partial review from jeremyrubin. 13:36 < gribble> https://github.com/bitcoin/bitcoin/issues/10973 | Refactor: separate wallet from node by ryanofsky · Pull Request #10973 · bitcoin/bitcoin · GitHub 13:38 < jnewbery> It's a large changeset (+1526,-670), so it's quite an involved review. I don't know if it makes sense to chop it up into smaller PRs (although logically, the intermediate commits don't really make sense unless we take the whole lot) 13:38 < jnewbery> Perhaps something to discuss at the next meeting 13:40 < promag> BlueMatt: could you take a look at #13063? ty 13:40 < gribble> https://github.com/bitcoin/bitcoin/issues/13063 | Use shared pointer to retain wallet instance by promag · Pull Request #13063 · bitcoin/bitcoin · GitHub 13:41 < promag> jnewbery: I was planning to see that one too 13:43 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev 13:44 -!- Cheeseo [~Cheeseo@unaffiliated/cheeseo] has joined #bitcoin-core-dev 13:45 -!- Dizzle [~dizzle@108.171.182.16] has quit [Ping timeout: 240 seconds] 13:45 -!- laurentmt1 [~Thunderbi@37.58.58.232] has joined #bitcoin-core-dev 13:45 -!- CodeShark_ [sid126576@gateway/web/irccloud.com/x-boaqclfuaxurumfy] has joined #bitcoin-core-dev 13:46 -!- robby938__ [sid238281@gateway/web/irccloud.com/x-alcdlvldkbgplkci] has joined #bitcoin-core-dev 13:46 -!- NicolasDorier_ [sid129442@gateway/web/irccloud.com/x-pptglydoyqicaryj] has joined #bitcoin-core-dev 13:46 -!- epic_ [sid37137@gateway/web/irccloud.com/x-xbpicypsvnkjtpdu] has joined #bitcoin-core-dev 13:47 -!- games__ [sid99242@gateway/web/irccloud.com/x-juwestjyktldibsw] has joined #bitcoin-core-dev 13:48 -!- wump [~quassel@pdpc/supporter/professional/wumpus] has joined #bitcoin-core-dev 13:48 -!- nickler_ [~nickler@185.12.46.130] has joined #bitcoin-core-dev 13:50 -!- brianhoffman [~brianhoff@pool-96-255-225-209.washdc.fios.verizon.net] has quit [Ping timeout: 248 seconds] 13:51 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/bf9b03ddcc65...6b824c090f53 13:51 < bitcoin-git> bitcoin/master f30e9be David A. Harding: RPC Docs: gettxout*: clarify bestblock and unspent counts 13:51 < bitcoin-git> bitcoin/master 6b824c0 MarcoFalke: Merge #13184: RPC Docs: gettxout*: clarify bestblock and unspent counts... 13:51 -!- kakobreklaa [~kako@163-172-8-69.rev.poneytelecom.eu] has joined #bitcoin-core-dev 13:51 -!- dx25_ [~dx25@97.119.180.105] has joined #bitcoin-core-dev 13:52 -!- mryandao- [~mryandao@unaffiliated/mryandao] has joined #bitcoin-core-dev 13:52 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #13184: RPC Docs: gettxout*: clarify bestblock and unspent counts (master...2018-05-rpc-help-bestblock) https://github.com/bitcoin/bitcoin/pull/13184 13:52 -!- nullptr_ [~nullptr|@ip-94-113-103-134.net.upcbroadband.cz] has joined #bitcoin-core-dev 13:53 -!- robby938__ is now known as robby938_ 13:53 -!- laurentmt1 is now known as laurentmt 13:53 -!- mryandao- is now known as mryandao 13:53 -!- CodeShark_ is now known as CodeShark 13:53 -!- games__ is now known as games_ 13:53 -!- NicolasDorier_ is now known as NicolasDorier 13:54 -!- epic_ is now known as epic 13:54 -!- ProfMac [~ProfMac@2001:470:1f0f:226:e596:e360:4876:ddc2] has joined #bitcoin-core-dev 13:55 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 240 seconds] 13:56 < jamesob> when writing a class that mimics a vector, should our naming conventions take precedence over interface imitation? e.g. PushBack vs. push_back 13:57 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 13:57 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev 13:57 -!- _flow__ [~none@2001:638:a000:4140::ff10:844c] has joined #bitcoin-core-dev 13:58 -!- jb55 [~jb55@node-1w7jr9qkydhiku0jsgcb1oc8y.ipv6.telus.net] has quit [Ping timeout: 240 seconds] 13:59 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 14:01 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 14:01 < skeees> if you're just adding something that exists in a future std (e.g. c++17) then preference is to maintain api compatibility 14:02 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 14:06 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 14:08 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 14:08 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:08 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 14:09 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 14:10 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 14:12 -!- rex4539 [~textual@2a02:587:3516:1600:4c7:235f:b163:a4a6] has joined #bitcoin-core-dev 14:13 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 14:14 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 14:15 -!- glaksmono [~glaksmono@158.140.182.56] has joined #bitcoin-core-dev 14:17 -!- arowser [~arowser@45.32.248.113] has quit [Remote host closed the connection] 14:17 -!- arowser [~arowser@45.32.248.113] has joined #bitcoin-core-dev 14:19 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 14:20 -!- glaksmono [~glaksmono@158.140.182.56] has quit [Ping timeout: 264 seconds] 14:22 -!- pierre_rochard [~pierre@unaffiliated/pierre-rochard/x-3593157] has quit [Quit: pierre_rochard] 14:23 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 14:26 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 14:27 -!- pierre_rochard [~pierre@unaffiliated/pierre-rochard/x-3593157] has joined #bitcoin-core-dev 14:27 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 14:27 -!- promag_ [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 14:29 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 14:30 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 14:31 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 14:32 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 14:32 -!- wraithm_ is now known as wraithm 14:33 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 260 seconds] 14:36 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 14:38 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 14:39 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 14:39 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 14:39 -!- moneyball [~moneyball@65.200.72.90] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 14:40 -!- promag_ [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 14:42 -!- _flow__ [~none@2001:638:a000:4140::ff10:844c] has joined #bitcoin-core-dev 14:43 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 14:43 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 14:45 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 14:46 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 14:46 -!- moneyball [~moneyball@65.200.72.90] has joined #bitcoin-core-dev 14:48 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 14:48 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 14:53 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 14:53 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 14:55 -!- moneyball [~moneyball@65.200.72.90] has quit [Quit: Textual IRC Client: www.textualapp.com] 14:56 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 14:58 -!- spinza [~spin@102.177.145.17] has quit [Ping timeout: 256 seconds] 14:59 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 15:03 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 276 seconds] 15:04 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 15:04 -!- pierre_rochard [~pierre@unaffiliated/pierre-rochard/x-3593157] has quit [Quit: pierre_rochard] 15:06 -!- spinza [~spin@102.177.145.17] has joined #bitcoin-core-dev 15:06 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 15:06 -!- pierre_rochard [~pierre@unaffiliated/pierre-rochard/x-3593157] has joined #bitcoin-core-dev 15:16 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection] 15:17 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 15:18 -!- pierre_rochard [~pierre@unaffiliated/pierre-rochard/x-3593157] has quit [Quit: pierre_rochard] 15:23 < jimpo> Friendly reminder: #12254 is still ready for review 15:23 < gribble> https://github.com/bitcoin/bitcoin/issues/12254 | BIP 158: Compact Block Filters for Light Clients by jimpo · Pull Request #12254 · bitcoin/bitcoin · GitHub 15:32 < luke-jr> BlueMatt: what timeframe do you need it in? been meaning to rebase/address stuff for a week or so now.. 15:32 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 15:33 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 15:37 -!- spinza [~spin@102.177.145.17] has quit [Quit: Coyote finally caught up with me...] 15:39 -!- laurentmt [~Thunderbi@37.58.58.232] has quit [Quit: laurentmt] 15:41 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 15:44 < satwo> Hi all, wasn't able to get a clear answer in #bitcoin, so thought I'd ask here: Why is nSequence an input-level field while nLockTime is transaction-level, and what happens when there are multiple inputs with different nSequence values? 15:44 -!- spinza [~spin@102.177.145.17] has joined #bitcoin-core-dev 15:49 -!- Dizzle [~dizzle@108.171.182.16] has joined #bitcoin-core-dev 15:51 < luke-jr> satwo: originally, or today? 15:53 < satwo> luke-jr Today, though if evolution of the protocol would shed light on it I'd be interested in that too. 15:53 -!- Randolf [~randolf@24.244.23.235] has joined #bitcoin-core-dev 15:54 -!- Randolf [~randolf@24.244.23.235] has quit [Excess Flood] 15:55 -!- glaksmono [~glaksmono@158.140.182.56] has joined #bitcoin-core-dev 15:55 -!- Randolf [~randolf@24.244.23.235] has joined #bitcoin-core-dev 15:57 -!- laurentmt [~Thunderbi@37.58.58.232] has joined #bitcoin-core-dev 15:58 -!- rex4539 [~textual@2a02:587:3516:1600:4c7:235f:b163:a4a6] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 16:00 -!- glaksmono [~glaksmono@158.140.182.56] has quit [Ping timeout: 240 seconds] 16:02 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 16:02 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 16:02 -!- CubicEarths [~cubiceart@c-66-30-214-9.hsd1.ma.comcast.net] has quit [Remote host closed the connection] 16:03 -!- CubicEarths [~cubiceart@c-66-30-214-9.hsd1.ma.comcast.net] has joined #bitcoin-core-dev 16:04 -!- laurentmt [~Thunderbi@37.58.58.232] has quit [Quit: laurentmt] 16:04 < fanquake> eklitzke Any chance you can rebase #12744 ? 16:04 < gribble> https://github.com/bitcoin/bitcoin/issues/12744 | WIP: eliminate dependency on boost::program_options by eklitzke · Pull Request #12744 · bitcoin/bitcoin · GitHub 16:09 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 16:10 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 16:13 -!- Randolf [~randolf@24.244.23.235] has quit [Ping timeout: 240 seconds] 16:44 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has quit [Remote host closed the connection] 16:45 -!- m8tion [~user@88.190.249.49] has joined #bitcoin-core-dev 16:47 -!- moneyball [~moneyball@65.200.72.90] has joined #bitcoin-core-dev --- Log closed Mon May 07 17:00:39 2018 --- Log opened Mon May 07 17:10:58 2018 17:10 -!- kanzure [~kanzure@unaffiliated/kanzure] has joined #bitcoin-core-dev 17:10 -!- Irssi: #bitcoin-core-dev: Total of 238 nicks [0 ops, 0 halfops, 0 voices, 238 normal] 17:17 -!- moneyball [~moneyball@65.200.72.90] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 17:17 -!- ken2812221 [~User@140.115.203.133] has quit [Ping timeout: 268 seconds] 17:18 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 17:18 -!- ken2812221 [~User@140.115.203.133] has joined #bitcoin-core-dev 17:18 -!- felco [~felco@unaffiliated/felco] has quit [Quit: All your IRC are belong to ZNC] 17:19 -!- Irssi: Join to #bitcoin-core-dev was synced in 523 secs 17:21 -!- satwo [~textual@2602:306:378a:6fb0:d191:8d6f:8ca9:6897] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 17:21 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 17:23 -!- moneyball [~moneyball@65.200.72.90] has joined #bitcoin-core-dev 17:23 < booyah> ... why a goal is to get rid of boost? 17:28 -!- glaksmono [~glaksmono@158.140.182.56] has joined #bitcoin-core-dev 17:33 -!- brianhoffman [~brianhoff@mobile-166-170-28-25.mycingular.net] has quit [Ping timeout: 264 seconds] 17:36 -!- moneyball [~moneyball@65.200.72.90] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 17:36 -!- m8tion [~user@88.190.249.49] has quit [Quit: Leaving] 17:51 -!- ken2812221 [~User@140.115.203.133] has quit [Ping timeout: 268 seconds] 17:52 -!- murrayn [~dafuq@24.70.128.40] has joined #bitcoin-core-dev 17:52 -!- murrayn [~dafuq@24.70.128.40] has quit [Changing host] 17:52 -!- murrayn [~dafuq@unaffiliated/murrayn] has joined #bitcoin-core-dev 17:52 -!- ken2812221 [~User@140.115.203.133] has joined #bitcoin-core-dev 17:53 -!- ken2812221 [~User@140.115.203.133] has quit [Remote host closed the connection] 17:53 -!- ken2812221 [~User@133-203.dorm.ncu.edu.tw] has joined #bitcoin-core-dev 17:53 -!- dafuq_ [~dafuq@S01061cabc0b054b3.ok.shawcable.net] has quit [Ping timeout: 260 seconds] 17:58 -!- brianhoffman [~brianhoff@mobile-166-170-29-33.mycingular.net] has joined #bitcoin-core-dev 18:00 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 18:00 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 256 seconds] 18:04 -!- glaksmono [~glaksmono@158.140.182.56] has quit [Remote host closed the connection] 18:07 -!- halfroastedbone [43a4bdfc@gateway/web/freenode/ip.67.164.189.252] has joined #bitcoin-core-dev 18:16 < halfroastedbone> ? 18:16 -!- halfroastedbone [43a4bdfc@gateway/web/freenode/ip.67.164.189.252] has quit [Quit: Page closed] 18:16 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 18:17 -!- lerfod [43a4bdfc@gateway/web/freenode/ip.67.164.189.252] has joined #bitcoin-core-dev 18:17 -!- lerfod [43a4bdfc@gateway/web/freenode/ip.67.164.189.252] has quit [Client Quit] 18:18 -!- brianhoffman [~brianhoff@mobile-166-170-29-33.mycingular.net] has quit [Ping timeout: 268 seconds] 18:21 -!- isis_ is now known as isis 18:23 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 18:24 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds] 18:28 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Ping timeout: 248 seconds] 18:30 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 18:42 -!- BullShark [uid226214@gateway/web/irccloud.com/x-yjzlwbmvhcdbqfxe] has quit [Quit: Connection closed for inactivity] 18:55 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 18:56 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 19:03 < Randolf> booyah: Boost is a horrible library. Its updates sometimes break backward compatibility. 19:04 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds] 19:04 < Randolf> booyah: I don't know what the specific reasons are for removing it from the Bitcoin project, but due to the various problems I've had with it conflicting with itself in the past, I'm glad it's on the way out. 19:05 < Randolf> I had packages on NetBSD, for instance, that each required different versions of Boost. At first I thought "okay, no problem, I'll just use the most recent version." That, of course, failed. And I couldn't run multiple versions on the same system. 19:05 < Randolf> Eventually I either had to find different versions of the library to use, or chroot/jail the few packages that needed different versions of Boost, or set them up on separate machines. 19:06 < Randolf> Sorry, I meant to write this... 19:06 < Randolf> Eventually I either had to find different (alternative) packages to use that don't rely on Boost, or chroot/jail the few packages that needed different versions of Boost, or set them up on separate machines. 19:07 < Randolf> It really wasn't a fun problem at all. 19:07 -!- glaksmono [~glaksmono@119.10.176.150] has joined #bitcoin-core-dev 19:07 < Randolf> So, that's why I'm glad Boost is on its way out -- so that I won't have those problems with Bitcoin in the future. 19:08 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 19:09 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 19:12 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev 19:16 -!- DrDraake [48e02ad8@gateway/web/freenode/ip.72.224.42.216] has quit [Quit: Page closed] 19:17 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 19:18 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 19:21 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 19:22 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 19:23 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 19:23 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 255 seconds] 19:24 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 19:26 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 19:27 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 19:28 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 19:28 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 19:28 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 19:41 -!- satwo [~textual@99-120-166-251.lightspeed.nsvltn.sbcglobal.net] has joined #bitcoin-core-dev 20:02 -!- tylevine [~tylevine@li120-195.members.linode.com] has quit [Quit: The Lounge - https://thelounge.github.io] 20:13 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 20:14 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 20:16 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 20:16 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 20:17 -!- cryptojanitor [uid278088@gateway/web/irccloud.com/x-uggcwgnhyjlydxsv] has quit [Quit: Connection closed for inactivity] 20:21 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Remote host closed the connection] 20:21 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev 20:25 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 20:25 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 20:26 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Ping timeout: 268 seconds] 20:32 -!- wump is now known as wumpus 20:33 -!- glaksmono [~glaksmono@119.10.176.150] has quit [Remote host closed the connection] 20:34 -!- glaksmono [~glaksmono@112.78.141.26] has joined #bitcoin-core-dev 20:38 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 20:38 -!- glaksmono [~glaksmono@112.78.141.26] has quit [Ping timeout: 240 seconds] 20:38 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 20:41 -!- glaksmono [~glaksmono@119.10.176.150] has joined #bitcoin-core-dev 20:46 -!- rex4539 [~textual@ppp-2-87-179-137.home.otenet.gr] has joined #bitcoin-core-dev 21:01 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev 21:10 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Ping timeout: 260 seconds] 21:11 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 21:12 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 21:18 -!- satwo [~textual@99-120-166-251.lightspeed.nsvltn.sbcglobal.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 21:21 -!- glaksmono [~glaksmono@119.10.176.150] has quit [Remote host closed the connection] 21:24 -!- glaksmono [~glaksmono@112.78.141.26] has joined #bitcoin-core-dev 21:36 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 21:37 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 21:41 -!- glaksmono [~glaksmono@112.78.141.26] has quit [Remote host closed the connection] 21:42 -!- glaksmono [~glaksmono@119.10.176.150] has joined #bitcoin-core-dev 21:43 -!- karl is now known as kallewoof 21:47 -!- glaksmono [~glaksmono@119.10.176.150] has quit [Ping timeout: 268 seconds] 22:02 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev 22:10 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has quit [Remote host closed the connection] 22:21 -!- zigen [~zigen@fs276ed17b.tkyc008.ap.nuro.jp] has joined #bitcoin-core-dev 22:21 -!- glaksmono [~glaksmono@112.78.141.26] has joined #bitcoin-core-dev 22:28 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 22:29 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 22:31 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 22:31 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 22:33 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 22:33 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 22:38 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 22:38 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 22:42 -!- qrestlove [~qrestlove@2605:6000:eb4a:ef00:454f:112b:9095:f0ea] has quit [Ping timeout: 276 seconds] 22:44 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 22:45 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 22:50 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 22:50 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 22:50 < wumpus> so I got word back from github "We're currently investigating similar reports regarding this issue, and I've added your report to our list." "If you need to merge that pull request soon, we recommend using git merge locally on the command line as a workaround. We apologize for any inconvenience, and thank you for your patience." 22:52 -!- qrestlove [~qrestlove@2605:6000:eb4a:ef00:454f:112b:9095:f0ea] has joined #bitcoin-core-dev 22:57 < fanquake> wumpus annoying 22:58 < wumpus> yes. it's disappointing. I'm not sure I want to merge it *because* I want to look at the discussion, that's why we use github in the first place. 22:59 -!- Krellan [~Krellan@2601:640:4000:9258:1046:ea74:eb27:a153] has joined #bitcoin-core-dev 22:59 -!- Krellan [~Krellan@2601:640:4000:9258:1046:ea74:eb27:a153] has quit [Remote host closed the connection] 23:00 -!- Krellan [~Krellan@2601:640:4000:9258:40d5:d3bf:99e5:94c0] has joined #bitcoin-core-dev 23:15 -!- BashCo_ [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 23:16 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 240 seconds] 23:16 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Quit: Leaving] 23:19 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 23:19 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 23:24 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 23:25 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 23:28 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 23:29 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 23:29 < jonasschnelli> "If you need to merge that pull request soon, we recommend using git merge locally [...]" ... :{ 23:32 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 23:32 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 23:33 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 23:34 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 23:35 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 23:37 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 23:37 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 23:37 < wumpus> jonasschnelli: right, as if that's the problem in the first place. I wonder if we have the messages as json from the API so we can at least look at the tread 23:37 < wumpus> ah yes https://github.com/zw/bitcoin-gh-meta/blob/master/issues/102xx/10267-comments.json 23:39 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 23:39 < jonasschnelli> wumpus: reminds me of a project I'd like to do since years. A custom webinterface that allows better interaction with github. Mark pulls, highlight comments that are relevant to you after some rules. 23:39 -!- BashCo_ [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 240 seconds] 23:40 < wumpus> jonasschnelli: https://bitcoinacks.com/ might be a good start 23:40 < jonasschnelli> AH! I almost forgot about that. 23:40 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 23:40 < jonasschnelli> They should mirror the comment history 23:42 < wumpus> so from what I understand, reading the comments in raw json format, is that 10267 should be ready for merge 23:44 < wumpus> the comment history is in that bitcoin-gh-meta already - just need a better way to format it in the terminal than reading very long lines scrolling horizontally 23:45 < fanquake> yea bitcoinacks has been improving quite a lot over the past week or two 23:45 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 23:52 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 23:58 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 23:58 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev