--- Day changed Wed May 30 2018 00:07 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 00:08 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 00:08 < GitHub159> [bitcoin-detached-sigs] theuni closed pull request #6: 0.16.1: osx signatures for 0.16.1rc (0.16...0.16) https://github.com/bitcoin-core/bitcoin-detached-sigs/pull/6 00:08 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 00:08 < cfields> gitian builders: detached sigs for v0.16.1rc1 are pushed 00:11 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection] 00:15 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev 00:21 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 00:21 -!- Krellan [~Krellan@2601:640:4000:9258:ec29:b128:9f50:93bd] has joined #bitcoin-core-dev 00:28 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 00:31 < fanquake> cfields pushed some signed sigs up https://github.com/bitcoin-core/gitian.sigs/pull/712 00:42 -!- nekotribal [~nekotriba@host-89-230-96-42.dynamic.mm.pl] has quit [Quit: Leaving] 00:59 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 01:01 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 01:01 < jonasschnelli> fanquake: cfields sigs matches with mine (https://bitcoin.jonasschnelli.ch/build/634).. will push asap 01:01 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 01:03 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 01:03 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 01:05 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 01:05 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 01:07 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 01:08 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 01:10 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 01:10 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 01:11 -!- lxer [~lx@ip5f5bd657.dynamic.kabel-deutschland.de] has quit [Ping timeout: 268 seconds] 01:12 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 01:12 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 01:12 -!- lxer [~lx@ip5f5bd657.dynamic.kabel-deutschland.de] has joined #bitcoin-core-dev 01:14 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 01:14 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 01:16 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 01:17 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 01:17 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:18 < fanquake> jonasschnelli: What are your thoughts on moving to macOS 10.10 as a minimum required version for 0.17.0 ? 01:19 < fanquake> qt5.9.x supports > 10.10 01:19 < jonasschnelli> fanquake: 10.10 is pretty "newish"... not sure. 01:19 < jonasschnelli> That is a point. 01:19 < jonasschnelli> qt5.9 is LTR (long term release), right? 01:19 < fanquake> Correct, which is also why I thought a macOS bump might be ok 01:20 < jonasschnelli> We use 10.8 as min right now, right? 01:20 < fanquake> Qt seems to be getting more aggressive with dropping macOS support as well. 01:20 < fanquake> Yep, 10.8 is the current minimum 01:20 < fanquake> qt 5.10, 5.11 is macOS 10.11 + 01:20 < jonasschnelli> I think it would be worth to do sooner then later – IF – there are clear gains (features, stability, etc.) 01:21 < jonasschnelli> If not, we should probably wait ~1yr before upgrading to Qt5.9 01:21 < fanquake> There is some code for supporting 10.8, fonts stuff I think, that might be able to be dropped. 01:21 < fanquake> So for 0.17 we should just bump the 5.7.x, if there is an upgrade available? 01:22 -!- drizztbsd [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:22 < fanquake> I'm going to put something together about a bump, might wrap it up in an issue for discussion. 01:22 < jonasschnelli> We could bump to 5.7.x (if one is willing to work on that PR). 01:22 < fanquake> Layout any benefits/downsides etc. 01:22 < jonasschnelli> Upgrading Qt via depends was always pretty painful. 01:22 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 268 seconds] 01:23 < jonasschnelli> Yes. I think minimal system requirements are important (to keep as low as possible). Only increase if necessary 01:23 < jonasschnelli> necessary == clear gains in UX or other area 01:24 < fanquake> We are currently using 5.7.1, and there doesn't seem to be any more point releases for the 5.7 branch. So if we stuck to 5.7 we wouldn't need any changes for 0.17 01:24 < fanquake> It's only compatibility patches, such as for Xcode etc 01:24 < jonasschnelli> Okay. That makes sense... should also be not to complicated. 01:25 < jonasschnelli> Did someone mention in the Qt5.9 PR that this will increase minimal system requieremnts for OSX? 01:25 < fanquake> Here are the qt5.9 "features". Anything stick out to you that would be nice to have? https://wiki.qt.io/New_Features_in_Qt_5.9 01:25 < jonasschnelli> And I know of a lot of OSX users stuck below 10.10 01:25 < fanquake> I don't think anyone has mentioned yet, I'll make a comment now. 01:25 < jonasschnelli> Thanks! I think this is a show stopper for that Qt5.9 PR 01:26 < jonasschnelli> I looked through the RN of QT5.9,... nothing that we really would need. 01:26 < jonasschnelli> We use only the very basics of QT 01:26 < jonasschnelli> AFAIK the biggest problem we should make progress is HiDPI on Win/Linux. I'm not sure if this is a Qt upstream issue or something we can do better 01:27 < jonasschnelli> Last time I checked, Bitcoin-Core looks pretty bad on Linux/Win HIDPI 01:27 < jonasschnelli> And I have not read anything about HiDPI improvements in the last RNs,... so very likely something we can do better. 01:29 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 01:29 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 01:31 < fanquake> mmm. Single mention of High-DPI on Windows in the Qt5.11 Release notes 01:31 < fanquake> Will have to investigate if we can do better with 5.7 01:33 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 01:33 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 01:35 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 01:35 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 01:37 -!- vicenteH [~user@204.red-83-58-238.dynamicip.rima-tde.net] has joined #bitcoin-core-dev 01:38 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 01:39 -!- drizztbsd [~tredaelli@redhat/timothy] has quit [Ping timeout: 256 seconds] 01:39 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 01:40 -!- drizztbsd [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:41 -!- CubicEarths [~cubiceart@c-73-157-2-231.hsd1.wa.comcast.net] has quit [Remote host closed the connection] 01:43 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 01:43 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 01:44 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:45 -!- drizztbsd [~tredaelli@redhat/timothy] has quit [Ping timeout: 260 seconds] 01:47 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 01:47 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 01:49 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 01:49 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 01:50 < jonasschnelli> fanquake: That would be great. Maybe – if you can – test on HiDPI on Linux (Ubuntu?) and Windows... see if there is something we do wrong in our application that prevents those platforms from correctly rendering on HiDPI 01:50 < jonasschnelli> It works flawless on macOS 01:50 < jonasschnelli> (that is what me make think it is an upstream issue) 01:51 < fanquake> jonasschnelli Yea I'll have a look. 01:51 < fanquake> Merged all the sigs as well. 01:52 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 01:53 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 01:55 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 01:55 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 01:55 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 01:57 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 01:57 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 01:59 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 01:59 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 02:01 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 02:01 < wumpus> jonasschnelli: I think qt5 was supposed to have better support for HiDPI, but not sure whether that's only on macosx 02:02 < wumpus> maybe there's something that has to be enabled, it's always tricky 02:02 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 02:03 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 02:04 < jonasschnelli> wumpus: Yes. it's on my list since month (figure out the reasons why HiDPI looks bad on Win/Linux). 02:04 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 02:04 < jonasschnelli> *months 02:05 -!- drizztbsd [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 02:06 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 260 seconds] 02:06 -!- drizztbsd is now known as timothy 02:08 < wumpus> jonasschnelli: FWIW on linux I always have DPI issues and have to tune things (such as display DPI) manually, and some programs ignore it, it's not very well coordinated. Wouldn't surprise me if windows is similar. 02:09 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 02:09 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 02:11 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 02:11 < wumpus> jonasschnelli: then again, if other qt5 applications work and bitcoin core doesn't, yes it's something we forget to do 02:11 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 02:13 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 02:14 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 02:14 < fanquake> The debug console on Windows looks particularly bad 02:14 < fanquake> https://0bin.net/paste/zWwN4zEeHJejfj5j#ZCLGsPtKSdXzUt-qTREORO2koOH2frCcvE9vvzu+xS6 02:16 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 02:16 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Ping timeout: 250 seconds] 02:17 < wumpus> that's terrible, looks like a bitmap font that was zoomed out?! 02:17 < fanquake> wumpus Yea I'm not sure, none of the other fonts in the client look that bad, basically just the debug console. 02:18 < jonasschnelli> I just fail to understand why the HiDPI concept (which practically is a x2 scale) works flawless on OSX and looks so bad on Win 02:19 < jonasschnelli> which leads me to thinks, Qt needs to fix some things internally 02:19 < jonasschnelli> but would be great to know how other Qt5 apps behave 02:20 < wumpus> OSX has a neat and well-organized graphics layer, all things considered, compared to the other OSes 02:20 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 02:20 -!- BGL [fourty@75-149-171-58-Washington.hfc.comcastbusiness.net] has quit [Ping timeout: 256 seconds] 02:20 < fanquake> Couple other trivial issues on Windows as well, like this box https://0bin.net/paste/6nRFsooj5Y3ludG7#DrYmyEK86QNzE240PzcKhwOlrFWYuid9iPdQRb3Sr+d 02:21 < wumpus> screen dpi and scaling is simply handled. On Linux/X11 it's also reported to the application / widget toolkit but in a few conflicting ways, which they usually tend to ignore... 02:21 < fanquake> Things just seem to "break" slightly on Windows. 02:21 < wumpus> fanquake: probably just a matter of the wrong font 02:22 < wumpus> I vaguely remember that Wayland, the new Linux graphics stack, improved/standardized handling for screens with different DPI and such, but that's not of much use yet to most users 02:23 -!- dongcarl [~dongcarl@c-24-5-70-69.hsd1.ca.comcast.net] has quit [Ping timeout: 260 seconds] 02:24 < wumpus> didnt' know 0bin handled images, by the way :o 02:25 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 02:25 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 02:27 -!- dongcarl [~dongcarl@c-24-5-70-69.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 02:28 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 02:28 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 02:30 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 02:30 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 02:32 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 02:33 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 02:35 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 02:35 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 02:37 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 02:37 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 02:39 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 02:39 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 02:41 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 02:41 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 02:43 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 02:44 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 02:46 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 02:46 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 02:47 < wumpus> arowser_: looks like you have connection issues 02:49 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 02:49 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 02:51 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 02:51 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 02:53 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 02:54 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 02:56 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 02:56 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 02:58 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 02:58 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 03:00 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 03:00 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 03:02 < wumpus> rc1 executables up: https://bitcoincore.org/bin/bitcoin-core-0.16.1/test.rc1/ 03:03 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 03:04 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 03:06 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 03:06 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 03:06 < wumpus> arowser_: please fix your connection, or I'll have to ban you 03:08 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 03:08 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 03:09 -!- berndj [~berndj@mail.azna.co.za] has quit [Read error: Connection reset by peer] 03:10 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 03:10 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 03:10 -!- mode/#bitcoin-core-dev [+o wumpus] by ChanServ 03:10 -!- berndj [~berndj@mail.azna.co.za] has joined #bitcoin-core-dev 03:11 -!- mode/#bitcoin-core-dev [+b *!~arowser@45.32.248.113] by wumpus 03:12 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 03:33 -!- berndj [~berndj@mail.azna.co.za] has quit [Read error: Connection reset by peer] 03:35 -!- berndj [~berndj@197.242.93.84] has joined #bitcoin-core-dev 03:38 < fanquake> What are any changes in master that might stop you opening a wallet with 0.16.1? 03:39 < fanquake> Managed to generate a wallet that wont open with 0.16.1rc1, but opens with master fine. Can't seen to recreate going either way if I nuke the data dir. 03:40 < fanquake> Sure I've never seen https://0bin.net/paste/PTTpyv0yB6Mthc9X#QMNg0CvL-/mWbuEnlvjZROaXrlYdu41nqA3FL9MSYp5 before. 03:54 -!- berndj [~berndj@197.242.93.84] has quit [Read error: Connection reset by peer] 03:55 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:55 < provoostenator> fanquake not an incompatible-bdb issue? 03:56 -!- berndj [~berndj@197.242.93.84] has joined #bitcoin-core-dev 03:57 <@wumpus> creating a wallet with master that can't be opened in 0.16.1 is ok, we don't generally support opening wallets created with newer versions in older ones 03:57 < fanquake> provoostenator Shouldn't be. Using 0.16.rc1 binary, and WSL depends build with master. Both report 4.8.30 in debug log. 03:57 <@wumpus> (the other way around would be bad, or if you open it with master once and then can't use it with 0.16.1 anymore) 03:58 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:58 <@wumpus> but wallets *created* with master, well they are at the newest version, which might not be supported with older versions 03:58 -!- BGL [fourty@75-149-171-58-Washington.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 03:59 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 255 seconds] 04:01 < provoostenator> Would this version change be the reason? https://github.com/bitcoin/bitcoin/commit/a8da482a8bc87ff26194612727d4a7b86b2fb60d 04:04 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 248 seconds] 04:18 -!- berndj [~berndj@197.242.93.84] has quit [Read error: Connection reset by peer] 04:21 -!- berndj [~berndj@mail.azna.co.za] has joined #bitcoin-core-dev 04:25 <@wumpus> provoostenator: yes I think so 04:33 < fanquake> wumpus can you block Michelle155 from GH 04:35 -!- Arvidt [~Arvidt@p5DE6AB4D.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 04:35 < Arvidt> The release notes for 0.16.1rc1 linked in the announcement email is pretty empty / in draft state (e.g. "0.16.x Example item"). I think it would be interesting for someone considering running RC version to have an overview what's new. https://github.com/bitcoin/bitcoin/blob/0.16/doc/release-notes.md 04:38 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 04:40 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 04:42 -!- laurentmt [~Thunderbi@77.247.178.186] has joined #bitcoin-core-dev 04:42 < fanquake> Arvidt Looks like a bit of an oversight, will get some release notes PR'd shortly. 04:43 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 276 seconds] 04:46 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 04:49 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 04:49 <@wumpus> I don't think any work has been done on the release notes yet, I considered not mentioning them at all, a list of commits would have been more useful 04:52 <@wumpus> I'll add that to the branch today 04:52 < fanquake> wumpus ^ see above re spammer 04:53 <@wumpus> fanquake: ah overlooked that, yes 04:54 <@wumpus> blocked from bitcoin and bitcoin-core orgs 04:55 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 256 seconds] 04:59 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 276 seconds] 05:00 -!- berndj [~berndj@mail.azna.co.za] has quit [Read error: Connection reset by peer] 05:02 -!- berndj [~berndj@mail.azna.co.za] has joined #bitcoin-core-dev 05:02 < bitcoin-git> [bitcoin] laanwj pushed 1 new commit to 0.16: https://github.com/bitcoin/bitcoin/commit/afc115d7535986f6c2bec3c3ad4ed0fe90d31f01 05:02 < bitcoin-git> bitcoin/0.16 afc115d Wladimir J. van der Laan: doc: Add commits and authors to release notes for rc1... 05:02 <@wumpus> Arvidt: basic info is there now https://github.com/bitcoin/bitcoin/blob/0.16/doc/release-notes.md 05:03 -!- nekotribal [~nekotriba@host-89-230-96-42.dynamic.mm.pl] has joined #bitcoin-core-dev 05:04 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 05:08 -!- Arvidt [~Arvidt@p5DE6AB4D.dip0.t-ipconnect.de] has left #bitcoin-core-dev [] 05:09 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 240 seconds] 05:12 -!- ula [~ula@b2b-78-94-11-194.unitymedia.biz] has joined #bitcoin-core-dev 05:14 < bitcoin-git> [bitcoin] fanquake opened pull request #13346: doc: update bitcoin-dot-org links in release-process.md (master...release-process-links) https://github.com/bitcoin/bitcoin/pull/13346 05:16 < fanquake> Be good to get some more macOS testers for https://github.com/bitcoin/bitcoin/pull/12783 05:18 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 05:19 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 05:25 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 245 seconds] 05:25 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 245 seconds] 05:30 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 05:34 -!- Kvaciral [~Kvaciral@5ED6B9A2.cm-7-7c.dynamic.ziggo.nl] has quit [Quit: Lost terminal] 05:35 -!- berndj [~berndj@mail.azna.co.za] has quit [Read error: Connection reset by peer] 05:35 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 256 seconds] 05:37 -!- berndj [~berndj@mail.azna.co.za] has joined #bitcoin-core-dev 05:41 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f8a29ca823fb...60f0358b4a1e 05:41 < bitcoin-git> bitcoin/master 8310238 fanquake: doc: update bitcoin-dot-org links in release-process.md 05:41 < bitcoin-git> bitcoin/master 60f0358 MarcoFalke: Merge #13346: doc: update bitcoin-dot-org links in release-process.md... 05:42 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 05:42 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #13346: doc: update bitcoin-dot-org links in release-process.md (master...release-process-links) https://github.com/bitcoin/bitcoin/pull/13346 05:47 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 260 seconds] 05:53 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 05:58 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 245 seconds] 06:05 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 06:05 -!- ken2812221 [~User@133-203.dorm.ncu.edu.tw] has quit [Ping timeout: 240 seconds] 06:06 -!- ken2812221 [~User@133-203.dorm.ncu.edu.tw] has joined #bitcoin-core-dev 06:07 <@wumpus> should we put the 0.16.1 release notes in the wiki? or is that not useful for aminor release, I don't expect much editing to be necessary 06:09 < fanquake> wumpus As in have the WIP notes in the wiki? I don't think it'd be necessary 06:10 <@wumpus> yes-- 06:10 <@wumpus> I don't think so either, but just asking 06:10 <@wumpus> I see some minor fixups are needed such as the version numbers, but not sure if anyone wants to add any more "notable changes" 06:10 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 276 seconds] 06:11 < fanquake> The only one might be for the Windows assert? But the release-notes can be edited as part of that PR if it happens 06:11 <@wumpus> re: macOS testing for 12783, jonasschnelli can you do a build please? 06:12 -!- mode/#bitcoin-core-dev [-b *!~arowser@45.32.248.113] by wumpus 06:12 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 06:12 <@wumpus> (hopes he fixed his connection by now...) 06:13 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 06:14 < fanquake> wumpus Maybe not heh 06:14 <@wumpus> (apparently not) 06:14 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 06:14 -!- mode/#bitcoin-core-dev [+b *!~arowser@45.32.248.113] by wumpus 06:16 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 06:17 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 06:18 < jonasschnelli> wumpus: https://bitcoin.jonasschnelli.ch/build/635 06:19 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 06:20 -!- Sinclair_ [sinclair6@gateway/vpn/privateinternetaccess/sinclair6] has joined #bitcoin-core-dev 06:22 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 260 seconds] 06:23 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 06:23 < provoostenator> Maybe edit the 0.16 release notes to reflect 0.16.1 rather than 0.16.0? 06:24 < fanquake> provoostenator Yes, that is left to do. See above ^ 06:30 <@wumpus> provoostenator: they do, though the version numbers need bumping in some places 06:30 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 06:30 <@wumpus> but the content of the release notes is for 0.16.1 06:33 -!- ken2812221 [~User@133-203.dorm.ncu.edu.tw] has quit [Read error: Connection reset by peer] 06:34 -!- laurentmt [~Thunderbi@77.247.178.186] has quit [Quit: laurentmt] 06:34 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 06:34 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #13347: travis: Skip cache for lint stage (master...Mf1806-travisLintNoCache) https://github.com/bitcoin/bitcoin/pull/13347 06:35 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 256 seconds] 06:36 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has joined #bitcoin-core-dev 06:38 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 06:41 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/60f0358b4a1e...25d2df2aa988 06:41 < bitcoin-git> bitcoin/master 3d4fa83 Wladimir J. van der Laan: Stop translating command line options... 06:41 < bitcoin-git> bitcoin/master 25d2df2 MarcoFalke: Merge #13341: Stop translating command line options... 06:42 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #13341: Stop translating command line options (master...2018_05_notranslate_options) https://github.com/bitcoin/bitcoin/pull/13341 06:44 -!- ken2812221 [~User@133-203.dorm.ncu.edu.tw] has joined #bitcoin-core-dev 06:46 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 256 seconds] 06:48 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 06:49 -!- berndj [~berndj@mail.azna.co.za] has quit [Read error: Connection reset by peer] 06:50 -!- mistergold [~mistergol@77.243.25.130] has joined #bitcoin-core-dev 06:50 -!- berndj [~berndj@mail.azna.co.za] has joined #bitcoin-core-dev 06:53 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 260 seconds] 07:03 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 07:09 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 256 seconds] 07:09 -!- berndj [~berndj@mail.azna.co.za] has quit [Read error: Connection reset by peer] 07:12 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 07:12 -!- Lauda [~quassel@unaffiliated/lauda] has quit [Ping timeout: 240 seconds] 07:15 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [] 07:15 -!- berndj [~berndj@mail.azna.co.za] has joined #bitcoin-core-dev 07:16 -!- Lauda [~quassel@unaffiliated/lauda] has joined #bitcoin-core-dev 07:20 -!- Lauda [~quassel@unaffiliated/lauda] has quit [Ping timeout: 256 seconds] 07:21 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 245 seconds] 07:23 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 07:27 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 260 seconds] 07:35 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 07:36 -!- Lauda [~quassel@unaffiliated/lauda] has joined #bitcoin-core-dev 07:39 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 240 seconds] 07:41 -!- Lauda [~quassel@unaffiliated/lauda] has quit [Ping timeout: 256 seconds] 07:41 -!- David82Fritsch [~David82Fr@ns334669.ip-5-196-64.eu] has quit [Ping timeout: 256 seconds] 07:46 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 07:48 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 07:51 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/25d2df2aa988...fd96d54f39cf 07:51 < bitcoin-git> bitcoin/master c814e2e Pieter Wuille: Remove template matching and pseudo opcodes... 07:51 < bitcoin-git> bitcoin/master fd96d54 Wladimir J. van der Laan: Merge #13194: Remove template matching and pseudo opcodes... 07:51 < bitcoin-git> [bitcoin] laanwj closed pull request #13194: Remove template matching and pseudo opcodes (master...201805_noscriptpattern) https://github.com/bitcoin/bitcoin/pull/13194 07:52 -!- Lauda [~quassel@unaffiliated/lauda] has joined #bitcoin-core-dev 07:52 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 240 seconds] 07:57 < kallewoof> I've addressed jimpo's concerns in #12634 and would like to re-add it to high pri list. If you don't wanna do that outside of meetings, consider this my spiritual presence at next meeting asking to have it added as I usually can't make it for 4 am. Btw why isn't #12136 on there? 07:58 < gribble> https://github.com/bitcoin/bitcoin/issues/12634 | [refactor] Make TransactionWithinChainLimit more flexible by kallewoof · Pull Request #12634 · bitcoin/bitcoin · GitHub 07:58 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 07:58 < gribble> https://github.com/bitcoin/bitcoin/issues/12136 | Implement BIP 174 Partially Signed Bitcoin Transactions by achow101 · Pull Request #12136 · bitcoin/bitcoin · GitHub 07:59 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 07:59 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 08:00 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 08:04 -!- rhsejr [~urshxf@213.233.108.186] has joined #bitcoin-core-dev 08:04 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 268 seconds] 08:04 < instagibbs> the author was busy with other stuff until recently i presume 08:05 -!- rhsejr [~urshxf@213.233.108.186] has quit [Remote host closed the connection] 08:12 < kallewoof> instagibbs: Since wumpus promoted it on twitter I flat out presumed it was on that list tbh. 08:12 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 08:12 < instagibbs> high priority... in our hearts 08:13 < achow101> I asked wumpus to add it to the list a week or two ago but I didn't actually check if it got added 08:13 < gmaxwell> The specification still probably needs work, since it unfortunately hasn't had a lot of attention since it was written. 08:14 < gmaxwell> One of the challenges for high priority is .. like does it mean the feature is high priority or the implementation of it. 08:14 -!- games__ is now known as games_ 08:17 -!- andy__ [4b9ba72f@gateway/web/freenode/ip.75.155.167.47] has joined #bitcoin-core-dev 08:17 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 256 seconds] 08:17 < achow101> gmaxwell: a few people have been looking at it and have sent me comments. I have made some changes to the spec since the original was added to the bips repo 08:18 -!- laurentmt [~Thunderbi@77.247.178.186] has joined #bitcoin-core-dev 08:18 < gmaxwell> oh good. 08:21 -!- Cogito_Ergo_Sum [~Myself@athedsl-314623.home.otenet.gr] has joined #bitcoin-core-dev 08:21 -!- Cogito_Ergo_Sum [~Myself@athedsl-314623.home.otenet.gr] has quit [Changing host] 08:21 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has joined #bitcoin-core-dev 08:22 -!- ken2812221 [~User@133-203.dorm.ncu.edu.tw] has quit [Quit: Leaving] 08:23 -!- Giszmo [~leo@pc-72-54-46-190.cm.vtr.net] has quit [Ping timeout: 240 seconds] 08:28 -!- jhfrontz [~Adium@165.171.225.5] has joined #bitcoin-core-dev 08:33 -!- Giszmo [~leo@pc-72-54-46-190.cm.vtr.net] has joined #bitcoin-core-dev 08:34 -!- ken2812221 [~User@140.115.203.133] has joined #bitcoin-core-dev 08:36 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 08:42 <@wumpus> it's high priority to me personally 08:44 -!- jtimon [~quassel@226.110.132.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 08:46 <@wumpus> the meaning of the "high priority for review" project is to get people to look at it, it does not necessarily imply the change itself has high priority, although it does mean at least the author would like to see it merged (because it blocks further work, for example) 08:47 -!- laurentmt [~Thunderbi@77.247.178.186] has quit [Quit: laurentmt] 08:47 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 265 seconds] 08:50 <@wumpus> anyhow -- added them both to the project 08:52 -!- Krellan [~Krellan@2601:640:4000:9258:ec29:b128:9f50:93bd] has quit [Read error: Connection reset by peer] 08:53 -!- Krellan [~Krellan@2601:640:4000:9258:ec29:b128:9f50:93bd] has joined #bitcoin-core-dev 08:57 -!- jhfrontz [~Adium@165.171.225.5] has quit [Quit: Leaving.] --- Log closed Wed May 30 08:58:17 2018 --- Log opened Wed May 30 08:58:28 2018 08:58 -!- kanzure [~kanzure@unaffiliated/kanzure] has joined #bitcoin-core-dev 08:58 -!- Irssi: #bitcoin-core-dev: Total of 247 nicks [1 ops, 0 halfops, 0 voices, 246 normal] 09:07 -!- Irssi: Join to #bitcoin-core-dev was synced in 525 secs 09:07 < ken2812221> Is it a good idea to clear the caches for all PR? 09:07 < ken2812221> on travis 09:13 -!- Varunram_ [sid210151@gateway/web/irccloud.com/x-zxdcbvgvqskoswtx] has quit [Changing host] 09:13 -!- Varunram_ [sid210151@unaffiliated/varunram] has joined #bitcoin-core-dev 09:13 -!- Varunram_ [sid210151@unaffiliated/varunram] has quit [Changing host] 09:13 -!- Varunram_ [sid210151@gateway/web/irccloud.com/x-zxdcbvgvqskoswtx] has joined #bitcoin-core-dev 09:14 -!- Varunram_ is now known as Varunram 09:14 -!- jhfrontz [~Adium@165.171.225.5] has joined #bitcoin-core-dev 09:18 <@wumpus> ken2812221: you mean after the 18.04 change? 09:18 <@wumpus> cfields ^^ 09:21 -!- jhfrontz [~Adium@165.171.225.5] has quit [Quit: Leaving.] 09:21 < ken2812221> Yes, it seems there are a lot of PR tests timed out. 09:24 <@wumpus> I don't think cleaning the caches will help for timeouts 09:27 < mryandao> what C++ version is core currently on? do we only support C++17 and beyond? 09:27 < Varunram> the code is on C++11 afaik 09:28 -!- Giszmo [~leo@pc-72-54-46-190.cm.vtr.net] has quit [Ping timeout: 256 seconds] 09:29 < gmaxwell> mryandao: C++17 is a couple months old and isn't completely supported by any compiler... 09:29 < ken2812221> wunpus: Travis will fetch caches from master if there is no cache linked to the PR. 09:29 < cfields> wumpus: I don't think clearing caches would help at all. Each PR is going to rebuild all depends the next time it's pushed-to no matter what 09:30 < cfields> ken2812221: ah, that's a good point though 09:31 < sipa> mryandao: we were on c++03 until 2016, when we switched to c++11 09:31 < sipa> as gmaxwell says, c++17 is super new, and even c++14 support is pretty novel in compilers 09:33 < sipa> i guess gcc 5 (first with full support for c++14) is 3 years old now 09:33 -!- andy__ [4b9ba72f@gateway/web/freenode/ip.75.155.167.47] has quit [Ping timeout: 260 seconds] 09:34 < mryandao> gcc support still experimental for 17 :/ 09:34 -!- jchysk [~yo@63.147.87.170] has quit [Ping timeout: 248 seconds] 09:35 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 276 seconds] 09:35 < sipa> mryandao: yes, it'll be years before we can adopt c++17 09:38 -!- goatpig [56f75200@gateway/web/freenode/ip.86.247.82.0] has joined #bitcoin-core-dev 09:39 < gmaxwell> mryandao: even once there is support we can't use it until distributions pick it up. 09:40 -!- jhfrontz [~Adium@165.171.225.5] has joined #bitcoin-core-dev 09:42 -!- Giszmo [~leo@ip-237-234-219-201.nextelmovil.cl] has joined #bitcoin-core-dev 09:44 < sipa> any reason why we can't adopt c++14 in the near future? gcc5 is in ubuntu 16.04 lts and up 09:45 < mryandao> C++14 enables the removal of boost::chrono 09:47 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 09:47 -!- jchysk [~yo@63.147.87.170] has joined #bitcoin-core-dev 09:49 < bitcoin-git> [bitcoin] jl2012 opened pull request #13348: Standard template for CHECKMULTISIG with 17~20 keys (master...20multisig) https://github.com/bitcoin/bitcoin/pull/13348 09:50 < goatpig> std::chrono is in c++11, unless it's doing something different than boost's 09:55 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 276 seconds] 10:08 -!- ProfMac [~ProfMac@2001:470:1f0f:226:f4c8:3785:1313:edca] has quit [Ping timeout: 245 seconds] 10:10 <@wumpus> yes, std::chrono is c++11 10:12 < sipa> what is the blocker to doing an s/boost::/std::/ for all of chrono and thread? 10:12 <@wumpus> just work 10:13 <@wumpus> though I wouldn't be surprised if cfields already has all of that somewhere 10:13 < sipa> i remember something with interruption points 10:14 <@wumpus> cfields: so clear all PR caches but not the branches? 10:16 -!- ken2812221 [~User@140.115.203.133] has quit [Read error: Connection reset by peer] 10:17 -!- retrop99 [~retrop99@213.152.161.5] has joined #bitcoin-core-dev 10:19 <@wumpus> sipa: yes, interruption points are one thing that would have to be implemented on our side 10:21 < sipa> i thought we had done so though, or at least partially 10:21 <@wumpus> I think for chrono there were no issues at all, our use of time could even easily be implemented using the C API 10:23 <@wumpus> there's DecodeDumpTime in src/wallet/rpcdump which does some boost-related time parsing, but that's not chrono 10:24 < cfields> wumpus: i'm not sure what 'the branches' are in that context? 10:24 <@wumpus> cfields: 0.16, master 10:24 < cfields> wumpus: ah yes, leave those 10:25 < cfields> as ken2812221 mentioned, it first tries to find the per-pr cache, and resorts to the generic master cache if that one can't be found... 10:25 < cfields> I'm not 100% if it will try to re-pull from master on a non-new PR, but the cache is useless in that case anyway, so I don't think it could hurt 10:26 <@wumpus> thought so, all PR caches are gone now 10:28 -!- mode/#bitcoin-core-dev [-b *!~arowser@45.32.248.113] by wumpus 10:29 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 10:31 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 10:31 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 10:31 -!- mode/#bitcoin-core-dev [+b *!~arowser@45.32.248.113] by wumpus 10:32 <@wumpus> apparently still hasn't fixed their connection 10:33 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 10:35 <@wumpus> https://travis-ci.org/bitcoin/bitcoin/builds/385749445?utm_source=github_status&utm_medium=notification travis doesn't even load this site here 10:36 <@wumpus> might be more than just a cache issue 10:37 -!- Giszmo [~leo@ip-237-234-219-201.nextelmovil.cl] has quit [Ping timeout: 276 seconds] 10:39 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 268 seconds] 10:39 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/fd96d54f39cf...c4cc8d9930ec 10:39 < bitcoin-git> bitcoin/master 4b62bdf Ben Woosley: Wallet: Refactor ReserveKeyFromKeyPool for safety... 10:39 < bitcoin-git> bitcoin/master c4cc8d9 Wladimir J. van der Laan: Merge #13252: Wallet: Refactor ReserveKeyFromKeyPool for safety... 10:40 -!- ken2812221 [~User@133-203.dorm.ncu.edu.tw] has joined #bitcoin-core-dev 10:40 < bitcoin-git> [bitcoin] laanwj closed pull request #13252: Wallet: Refactor ReserveKeyFromKeyPool for safety (master...refactor_wallet_RKFKP) https://github.com/bitcoin/bitcoin/pull/13252 10:43 -!- ExtraCrispy [~ExtraCris@185.9.18.150] has quit [Remote host closed the connection] 10:44 -!- ProfMac [~ProfMac@2001:470:1f0f:226:440f:7ccc:4155:52ef] has joined #bitcoin-core-dev 10:45 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 10:46 < bitcoin-git> [bitcoin] MarcoFalke pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/c4cc8d9930ec...61fcef0f89c4 10:46 < bitcoin-git> bitcoin/master 174f7c8 Andrew Chow: Use a struct for arguments and nested map for categories... 10:46 < bitcoin-git> bitcoin/master 4f8704d Andrew Chow: Give an error and exit if there are unknown parameters... 10:46 < bitcoin-git> bitcoin/master 9030557 Andrew Chow: Test gArgs erroring on unknown args 10:46 -!- ProfMac [~ProfMac@2001:470:1f0f:226:440f:7ccc:4155:52ef] has quit [Max SendQ exceeded] 10:47 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #13112: Throw an error for unknown args (master...gargs-know-args) https://github.com/bitcoin/bitcoin/pull/13112 10:47 -!- booyah [~bb@193.25.1.157] has quit [Read error: Connection reset by peer] 10:47 -!- ProfMac [~ProfMac@2001:470:1f0f:226:440f:7ccc:4155:52ef] has joined #bitcoin-core-dev 10:48 -!- booyah [~bb@193.25.1.157] has joined #bitcoin-core-dev 10:51 -!- Giszmo [~leo@pc-72-54-46-190.cm.vtr.net] has joined #bitcoin-core-dev 10:51 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 10:52 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 10:54 -!- CubicEarths [~cubiceart@c-73-157-2-231.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 11:00 -!- Krellan [~Krellan@2601:640:4000:9258:ec29:b128:9f50:93bd] has quit [Read error: Connection reset by peer] 11:00 -!- Krellan [~Krellan@2601:640:4000:9258:ec29:b128:9f50:93bd] has joined #bitcoin-core-dev 11:07 -!- karimofthecrop [454bfdca@gateway/web/freenode/ip.69.75.253.202] has joined #bitcoin-core-dev 11:09 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 11:10 -!- CubicEarths [~cubiceart@c-73-157-2-231.hsd1.wa.comcast.net] has quit [Read error: Connection reset by peer] 11:10 -!- contrapumpkin [~copumpkin@haskell/developer/copumpkin] has quit [Read error: Connection reset by peer] 11:13 -!- CubicEarths [~cubiceart@c-73-157-2-231.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 11:15 -!- Randolf [~randolf@205.250.80.42] has joined #bitcoin-core-dev 11:16 -!- contrapumpkin [~copumpkin@haskell/developer/copumpkin] has joined #bitcoin-core-dev 11:18 -!- rex4539 [~textual@2a02:587:3501:ea00:394e:48c2:90ba:418a] has joined #bitcoin-core-dev 11:24 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has joined #bitcoin-core-dev 11:25 -!- mistergo1d [~mistergol@77.243.27.162] has joined #bitcoin-core-dev 11:28 -!- mistergold [~mistergol@77.243.25.130] has quit [Read error: Connection reset by peer] 11:30 < jonasschnelli> My testnet seed – after a report from an lnd dev – does report a high amount of ABC and BCash and classic peers. 11:31 < jonasschnelli> They all have protocol number 80002 and may disconnect on requesting a block 11:31 < jonasschnelli> Not sure if they are on a different chain or it they are just dishonest, spy-peers. 11:32 < jonasschnelli> It is maybe a cat and mouse game, but eventually we should add more checks to sipa seeds, Like requesting a block around the current best known tip (would require a bitcoind on the seeder) 11:32 < jonasschnelli> *sipas seed software 11:34 -!- jhfrontz [~Adium@165.171.225.5] has quit [Quit: Leaving.] 11:34 -!- jhfrontz [~Adium@165.171.225.5] has joined #bitcoin-core-dev 11:37 -!- rex4539 [~textual@2a02:587:3501:ea00:394e:48c2:90ba:418a] has quit [Quit: Textual IRC Client: www.textualapp.com] 11:38 -!- Aliencorpse [~Aliencorp@2605:a601:b024:600:3040:b069:94e0:e16a] has quit [Ping timeout: 260 seconds] 11:42 <@wumpus> jonasschnelli: yes... 11:43 < jonasschnelli> Maybe the only solutions are enough honest peers that will reduce the amount of served dishnoest peers 11:46 < bitcoin-git> [bitcoin] laanwj opened pull request #13349: bench: Don't return a bool from main (master...2017_05_bench_warning) https://github.com/bitcoin/bitcoin/pull/13349 11:50 -!- Aliencorpse [~Aliencorp@2605:a601:b024:600:5825:d2d7:4b21:87b7] has joined #bitcoin-core-dev 11:51 < sipa> TIL C++11 contains regex matching, and we're even using it in bench_bitcoin 11:58 < sipa> wumpus: are we moving away from trusty in gitian as well? 11:59 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has quit [] 12:01 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 268 seconds] 12:03 -!- nmnkgl [~nmnkgl@c-73-189-35-88.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 12:04 -!- nmnkgl [~nmnkgl@c-73-189-35-88.hsd1.ca.comcast.net] has quit [Client Quit] 12:05 -!- ken2812221 [~User@133-203.dorm.ncu.edu.tw] has quit [Read error: Connection reset by peer] 12:06 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 12:07 -!- rex4539 [~textual@2a02:587:3501:ea00:3800:2dd9:7da:cf1c] has joined #bitcoin-core-dev 12:07 -!- ken2812221 [~User@133-203.dorm.ncu.edu.tw] has joined #bitcoin-core-dev 12:12 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Ping timeout: 256 seconds] 12:18 -!- jhfrontz [~Adium@165.171.225.5] has quit [Quit: Leaving.] 12:21 -!- jhfrontz [~Adium@165.171.225.5] has joined #bitcoin-core-dev 12:29 -!- jhfrontz [~Adium@165.171.225.5] has quit [Quit: Leaving.] 12:33 < bitcoin-git> [bitcoin] lmanners opened pull request #13350: [tests] Add logging to provide anchor points when debugging failures. (master...testlogging) https://github.com/bitcoin/bitcoin/pull/13350 12:36 -!- Randolf [~randolf@205.250.80.42] has quit [Ping timeout: 255 seconds] 12:41 -!- unknown-os [~irssi@206.189.224.29] has quit [Quit: Lost terminal] 12:50 -!- jhfrontz [~Adium@165.171.225.5] has joined #bitcoin-core-dev 12:51 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #13351: wallet: Prevent segfault when sending to unspendable witness (master...Mf1806-walletUnspendableWitnessIsMine) https://github.com/bitcoin/bitcoin/pull/13351 12:57 -!- LeMiner [~LeMiner@unaffiliated/leminer] has joined #bitcoin-core-dev 12:57 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 12:59 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 13:05 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/61fcef0f89c4...472fe8a2ce9f 13:05 < bitcoin-git> bitcoin/master d8c4998 practicalswift: Fix typos 13:05 < bitcoin-git> bitcoin/master 472fe8a MarcoFalke: Merge #13069: docs: Fix typos... 13:06 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #13069: docs: Fix typos (master...typos-201804) https://github.com/bitcoin/bitcoin/pull/13069 13:31 -!- mistergo1d [~mistergol@77.243.27.162] has quit [Read error: Connection reset by peer] 13:35 -!- Giszmo [~leo@pc-72-54-46-190.cm.vtr.net] has quit [Ping timeout: 240 seconds] 13:50 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #13352: qa: Avoid checking reject code for now (master...Mf1806-qaRejectCode) https://github.com/bitcoin/bitcoin/pull/13352 13:52 -!- dcousens [~dcousens@110.140.174.10] has quit [Ping timeout: 268 seconds] 13:54 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #13353: qa: Fixup setting of PATH env var (master...Mf1806-qaPathBitcoind) https://github.com/bitcoin/bitcoin/pull/13353 13:55 -!- jchysk [~yo@63.147.87.170] has quit [Ping timeout: 276 seconds] 13:57 -!- dcousens [~dcousens@110.140.174.10] has joined #bitcoin-core-dev 14:01 -!- dcousens [~dcousens@110.140.174.10] has quit [Ping timeout: 240 seconds] 14:03 -!- Giszmo [~leo@168.196.201.87] has joined #bitcoin-core-dev 14:03 -!- dcousens [~dcousens@110.140.174.10] has joined #bitcoin-core-dev 14:10 -!- CubicEarths [~cubiceart@c-73-157-2-231.hsd1.wa.comcast.net] has quit [Remote host closed the connection] 14:10 -!- bitconner [~conner@64-71-8-130.static.wiline.com] has joined #bitcoin-core-dev 14:14 -!- jchysk [~yo@63.147.87.170] has joined #bitcoin-core-dev 14:25 -!- BashCo_ [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 14:26 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 264 seconds] 14:30 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 14:30 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev 14:31 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 14:35 -!- mistergold [~mistergol@77.243.27.162] has joined #bitcoin-core-dev 14:40 -!- Chris_Stewart_5 [chris@gateway/vpn/privateinternetaccess/chrisstewart5/x-62865615] has quit [Ping timeout: 240 seconds] 14:40 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:44 -!- Giszmo [~leo@168.196.201.87] has quit [Ping timeout: 244 seconds] 14:49 -!- mistergold [~mistergol@77.243.27.162] has quit [Quit: leaving] 14:58 -!- Lauda_ [~quassel@unaffiliated/lauda] has joined #bitcoin-core-dev 15:01 -!- Lauda [~quassel@unaffiliated/lauda] has quit [Ping timeout: 256 seconds] 15:02 -!- jhfrontz [~Adium@165.171.225.5] has quit [Quit: Leaving.] 15:03 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Remote host closed the connection] 15:04 -!- isis [~isis@abulafia.patternsinthevoid.net] has quit [Quit: Lost terminal] 15:06 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has quit [Quit: drexl] 15:06 -!- isis [~isis@abulafia.patternsinthevoid.net] has joined #bitcoin-core-dev 15:06 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has joined #bitcoin-core-dev 15:10 -!- lxer [~lx@ip5f5bd657.dynamic.kabel-deutschland.de] has quit [Ping timeout: 256 seconds] 15:11 -!- Krellan [~Krellan@2601:640:4000:9258:ec29:b128:9f50:93bd] has quit [Read error: Connection reset by peer] 15:12 -!- Krellan [~Krellan@2601:640:4000:9258:ec29:b128:9f50:93bd] has joined #bitcoin-core-dev 15:19 -!- LeMiner [~LeMiner@unaffiliated/leminer] has quit [Read error: Connection reset by peer] 15:24 -!- Cory [~Cory@unaffiliated/cory] has quit [Ping timeout: 260 seconds] 15:31 -!- Cory [~Cory@unaffiliated/cory] has joined #bitcoin-core-dev 15:50 -!- TheRec [~toto@drupal.org/user/146860/view] has quit [Ping timeout: 260 seconds] 15:53 -!- CubicEarths [~cubiceart@2600:100f:b027:9855:b083:7ca:3903:c269] has joined #bitcoin-core-dev 15:53 -!- CubicEarths [~cubiceart@2600:100f:b027:9855:b083:7ca:3903:c269] has quit [Remote host closed the connection] 15:55 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 16:00 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 16:03 -!- nekotribal [~nekotriba@host-89-230-96-42.dynamic.mm.pl] has quit [Remote host closed the connection] 16:05 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has quit [Read error: Connection reset by peer] 16:05 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has joined #bitcoin-core-dev 16:09 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 260 seconds] 16:13 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev 16:20 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 16:21 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer] 16:25 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has quit [Quit: drexl] 16:27 -!- Randolf [~randolf@24.244.23.8] has joined #bitcoin-core-dev 16:28 -!- nekotribal [~nekotriba@host-89-230-96-42.dynamic.mm.pl] has joined #bitcoin-core-dev 16:31 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Quit: https://quanto.ga/] 16:32 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev 16:39 -!- Randolf [~randolf@24.244.23.8] has quit [Ping timeout: 240 seconds] 16:41 -!- jhfrontz [~Adium@cpe-184-57-118-36.columbus.res.rr.com] has joined #bitcoin-core-dev 16:48 -!- retrop99 [~retrop99@213.152.161.5] has quit [Ping timeout: 240 seconds] 16:50 -!- Randolf [~randolf@24.244.23.8] has joined #bitcoin-core-dev 16:55 -!- goatpig [56f75200@gateway/web/freenode/ip.86.247.82.0] has quit [Ping timeout: 260 seconds] 16:58 -!- Randolf [~randolf@24.244.23.8] has quit [Ping timeout: 268 seconds] 17:04 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev 17:16 -!- karimofthecrop [454bfdca@gateway/web/freenode/ip.69.75.253.202] has quit [Ping timeout: 260 seconds] 17:28 -!- jhfrontz1 [~Adium@cpe-184-57-118-36.columbus.res.rr.com] has joined #bitcoin-core-dev 17:32 -!- jhfrontz [~Adium@cpe-184-57-118-36.columbus.res.rr.com] has quit [Ping timeout: 256 seconds] 17:37 < MarcoFalke> sipa: Yes, see #13171 17:37 < gribble> https://github.com/bitcoin/bitcoin/issues/13171 | [WIP] Change gitian-descriptors to use bionic instead by ken2812221 · Pull Request #13171 · bitcoin/bitcoin · GitHub 17:38 < sipa> ah, yes! 17:38 < sipa> thanks 17:38 < sipa> so, c++14 soon? ;) 17:38 < sipa> i'll bring it up in the meeting 17:43 -!- rex4539 [~textual@2a02:587:3501:ea00:3800:2dd9:7da:cf1c] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 17:47 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev 17:50 -!- murrayn [~dafuq@unaffiliated/murrayn] has quit [Read error: Connection reset by peer] 17:50 -!- murrayn [~dafuq@unaffiliated/murrayn] has joined #bitcoin-core-dev 17:56 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 18:01 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 268 seconds] 18:34 -!- ula [~ula@b2b-78-94-11-194.unitymedia.biz] has quit [Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/] 18:59 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 19:00 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 19:52 -!- ken2812221 [~User@133-203.dorm.ncu.edu.tw] has quit [Read error: Connection reset by peer] 19:53 -!- ken2812221 [~User@133-203.dorm.ncu.edu.tw] has joined #bitcoin-core-dev 19:53 -!- zivl [~zivl@2601:19a:837f:e4e1:3c61:99c2:c08:a488] has quit [Ping timeout: 240 seconds] 19:57 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 20:02 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 248 seconds] 20:25 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 20:30 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 244 seconds] 20:36 -!- Randolf [~randolf@96.53.47.42] has quit [Ping timeout: 240 seconds] 20:37 -!- Randolf [~randolf@96.53.47.38] has joined #bitcoin-core-dev 20:57 -!- berndj [~berndj@mail.azna.co.za] has quit [Quit: ZNC - http://znc.in] 20:58 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 240 seconds] 21:03 -!- drizztbsd [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 21:06 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 240 seconds] 21:11 -!- bitconner [~conner@64-71-8-130.static.wiline.com] has quit [Ping timeout: 260 seconds] 21:11 -!- zivl [~zivl@2601:19a:837f:e4e1:9048:ca91:b1ac:55f9] has joined #bitcoin-core-dev 21:11 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 21:14 -!- berndj [~berndj@197.242.93.82] has joined #bitcoin-core-dev 21:43 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 21:45 * kallewoof feels the need to to read up on what's new in c++14 21:57 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 244 seconds] 21:58 < mryandao> looking at removing boost::chronos, would there be any downsides to unifying all the usage of GetTimeMillis/Micros to just std::chronos::nanoseconds instead? 21:59 < mryandao> and also changing int64_t types for time to std::chronos::nanoseconds for better semantics 22:01 < mryandao> in the TODO, it did ask for a typesafe type, so I'm guessing the usage of chronos::nanoseconds would kill all birds in 1 stone? 22:04 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 22:09 -!- zivl [~zivl@2601:19a:837f:e4e1:9048:ca91:b1ac:55f9] has quit [Ping timeout: 260 seconds] 22:11 < sipa> kallewoof: not all that much; c++14 is mostly seen as a small fixup/extension of the things added in 11 22:11 < sipa> better constexpr, better auto, better lambdas 22:12 -!- Sinclair_ [sinclair6@gateway/vpn/privateinternetaccess/sinclair6] has quit [Ping timeout: 260 seconds] 22:25 < kallewoof> sipa: Yeah I just read through a summary. Not really important but 0b is nice :) 22:25 < kallewoof> And better auto/lambda looks nice yeah. 22:26 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 22:30 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 22:51 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 22:54 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 268 seconds] 22:57 -!- rex4539 [~textual@2a02:587:3501:ea00:d0d5:81ca:db7f:2cf9] has joined #bitcoin-core-dev 23:01 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 23:03 < fanquake> mryandao If you haven't see already cfields has been working on that as well https://github.com/bitcoin/bitcoin/pull/9566 23:06 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 240 seconds] 23:06 < fanquake> wumpus very trendy code :p 23:08 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 23:11 -!- jtimon [~quassel@226.110.132.37.dynamic.jazztel.es] has quit [Ping timeout: 256 seconds] 23:13 <@wumpus> fanquake: thanks :p 23:14 -!- mode/#bitcoin-core-dev [-b *!~arowser@45.32.248.113] by wumpus 23:14 <@wumpus> (let's try again...) 23:16 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 23:18 <@wumpus> #13337 is strange, did OpenBSD 5.3 really break grep somehow? 23:18 < gribble> https://github.com/bitcoin/bitcoin/issues/13337 | OpenBSD 6.3 build: test/arith_uint256_tests.cpp complains about missing argument · Issue #13337 · bitcoin/bitcoin · GitHub 23:18 <@wumpus> s/5.3/6.3 23:19 <@wumpus> kallewoof feels the need to to read up on what's new in c++14 <- I'm not over the c++11 future-shock yet 23:20 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 23:20 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 23:21 < sipa> wumpus: ha 23:21 <@wumpus> sipa: to be serious, I guess the main thing I'd like to know is - how does this shift the set of linux distributions it's possible to build on. The embedded developer in me balks a bit at requiring ever more recent compilers. 23:21 < fanquake> wumpus I thought practicalswift had tested on 6.3, #13294, thought they might have picked that up? 23:21 < gribble> https://github.com/bitcoin/bitcoin/issues/13294 | Fix compiler warnings emitted when compiling under stock OpenBSD 6.3 by practicalswift · Pull Request #13294 · bitcoin/bitcoin · GitHub 23:21 < fanquake> Also looks like arowser_ still needs blocking 23:22 < sipa> wumpus: gcc 5 or clang 3.4, which is in ubuntu 16.04 23:22 < mryandao> there's a ##fix_your_connection ban redirection so the user gets informed to fix their connection 23:22 < mryandao> the mods in #bitcoin do that. 23:22 <@wumpus> sipa: but what about debian :( 23:22 < sipa> wumpus: on the other hand - c++14 doesn't add all that much either 23:23 <@wumpus> sipa: something we could do that is almost completely uncontroversial is: use c++14 features when avilable, fall back to something else otherwise 23:23 < sipa> sigh... debian only has gcc 5 in unstande :( 23:23 < sipa> *unstable 23:23 <@wumpus> not *require* it 23:24 <@wumpus> could always drop support for c++11 only compilers at some point later 23:24 < sipa> debian jessie has clang 3.4 though 23:24 <@wumpus> and could be as simple as removing some ifdef-ed code 23:25 <@wumpus> fanquake: we should ask him if he ran 'gmake check' 23:25 < sipa> wumpus: seems almost not worth it 23:25 < fanquake> wumpus Can do 23:27 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 23:28 -!- arowser_ [~arowser@45.32.248.113] has joined #bitcoin-core-dev 23:28 <@wumpus> bumping the required compiler versions should have a very good motivation, such as 'clearly safer, easier to review code', 'potential better perfromance'. for c++11 this was clear at least. 23:28 < sipa> yes, i agree - i didn't expect it would hurt debian so much 23:28 -!- mode/#bitcoin-core-dev [+b *!~arowser@45.32.248.113] by wumpus 23:28 < fanquake> Have we ever bumped before. I think we've just defined minimums? 23:29 < fanquake> *fairly recently 23:29 < sipa> the switch to c++11 made us require gcc 4.7 23:30 <@wumpus> yep, and there were complaints about users about that 23:30 < fanquake> 4.8+ i think? 23:30 <@wumpus> from users 23:30 < fanquake> #11732 23:30 < gribble> https://github.com/bitcoin/bitcoin/issues/11732 | RFC: bump GCC requirement to 4.8 · Issue #11732 · bitcoin/bitcoin · GitHub 23:31 < sipa> i think the most useful things in c++14 for us may be support for shared_lock 23:32 < sipa> oh, no, that's c++17 23:32 < sipa> pff :) 23:33 < sipa> wikipedia is wrong! 23:34 -!- arowser_ [~arowser@45.32.248.113] has quit [Remote host closed the connection] 23:34 < jonasschnelli> sipa: re https://github.com/bitcoin/bitcoin/pull/12196#discussion_r189396442, did you accidentally left away pubkeys for the API? We have to derive various script types anyways with xpubs, right? 23:35 < sipa> jonasschnelli: pubkeys are not scripts 23:35 < sipa> so no 23:35 < jonasschnelli> But how would xpubs be different? 23:35 < jonasschnelli> If we accept xpubs, whats the rational not not accept pubkeys? 23:36 < sipa> ah, sorry 23:36 < jonasschnelli> Either we derive different script types or not I guess 23:36 < sipa> you could have xpub+derivation type, or pub+derivation type, or script, or address 23:36 < jonasschnelli> so avoid to derive various types,... yeah. makes sense. 23:36 < jonasschnelli> Could accept n derivation types per pubkey 23:36 < sipa> jonasschnelli: you want me to write up a prototype of what that could look like? 23:36 < sipa> i've been wanting to do that for a while 23:37 < jonasschnelli> sipa: Please do if you want,.. i'm currently rewriting the API 23:39 < sipa> wumpus: ah, i'm wrong... c++14 has shared_lock and shared_timed_mutex; c++17 adds shared_mutex 23:39 < jonasschnelli> I would say [ {"address": , "pubkey" : { "pubkey" : , "derivation": ["P2PKH", "P2SH-P2WPKH", ...]}, "script" :