--- Day changed Thu Jun 07 2018 00:00 < bitcoin-git> [bitcoin] laanwj closed pull request #13394: cli: Ignore libevent warnings (master...cli-event) https://github.com/bitcoin/bitcoin/pull/13394 00:03 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 00:14 < kallewoof> cfields: are you able to debug using lldb on mac? even with ./configure --enable-debug and make clean I get 'optimized', which is because it puts in -O2. Despite --enable-debug. 00:20 < wumpus> anyhow, going to tag rc2 00:21 < wumpus> * [new tag] v0.16.1rc2 -> v0.16.1rc2 00:23 -!- vicenteH [~user@35.233.15.37.dynamic.jazztel.es] has quit [Ping timeout: 240 seconds] 00:25 -!- harrymm [~harrymm@104.207.83.58] has joined #bitcoin-core-dev 00:29 -!- vicenteH [~user@35.233.15.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 00:57 -!- Dyaheon [~Dya@dsl-trebng21-58c19c-197.dhcp.inet.fi] has quit [Ping timeout: 260 seconds] 01:03 -!- achow101 [~achow101@unaffiliated/achow101] has quit [Ping timeout: 240 seconds] 01:07 -!- Dyaheon [~Dya@dsl-trebng21-58c19c-197.dhcp.inet.fi] has joined #bitcoin-core-dev 01:10 -!- achow101 [~achow101@unaffiliated/achow101] has joined #bitcoin-core-dev 01:24 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 01:35 < sipa> w00t 01:35 -!- vicenteH [~user@35.233.15.37.dynamic.jazztel.es] has quit [Ping timeout: 240 seconds] 01:41 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 01:42 -!- vicenteH [~user@35.233.15.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 01:42 < fanquake> wumpus If you're still here, #13369 can go in 01:42 < gribble> https://github.com/bitcoin/bitcoin/issues/13369 | [docs] update transifex doc link by mess110 · Pull Request #13369 · bitcoin/bitcoin · GitHub 01:53 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 01:54 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 02:35 -!- zhrek` [~user@c-8189e355.021-158-73746f34.bbcust.telenor.se] has quit [Read error: Connection reset by peer] 02:37 < wumpus> fanquake: ack 02:39 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e1f8dce9939a...f8bcef38fb9b 02:39 < bitcoin-git> bitcoin/master 2b30ccc Cristian Mircea Messel: [docs] update transifex doc link 02:39 < bitcoin-git> bitcoin/master f8bcef3 Wladimir J. van der Laan: Merge #13369: [docs] update transifex doc link... 02:39 < bitcoin-git> [bitcoin] laanwj closed pull request #13369: [docs] update transifex doc link (master...fix_transifex_doc_link) https://github.com/bitcoin/bitcoin/pull/13369 03:03 -!- sturles [~sturles@unaffiliated/sturles] has quit [Ping timeout: 240 seconds] 03:08 -!- vicenteH [~user@35.233.15.37.dynamic.jazztel.es] has quit [Ping timeout: 256 seconds] 03:10 -!- vicenteH [~user@35.233.15.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 03:10 -!- sturles [~sturles@ulrik.uio.no] has joined #bitcoin-core-dev 03:10 -!- sturles [~sturles@ulrik.uio.no] has quit [Changing host] 03:10 -!- sturles [~sturles@unaffiliated/sturles] has joined #bitcoin-core-dev 03:15 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:19 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:22 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds] 03:24 -!- Krellan [~Krellan@2601:640:4000:9258:391e:51b4:8ced:33c9] has quit [Read error: Connection reset by peer] 03:25 -!- Krellan [~Krellan@2601:640:4000:9258:784b:a0f5:5b2d:8545] has joined #bitcoin-core-dev 03:31 -!- snickerfritz [~snickerfr@104.254.92.61] has quit [Ping timeout: 268 seconds] 03:36 < rafalcpp> no one ported the github-merge.py script to support gitlab? 03:39 < wumpus> not that I know 03:40 < wumpus> i'd guess that they have similar APIs, and it's just a matter of tweaking some things 03:41 < wumpus> huh, test_runner stopped printing progress dots here 03:43 < rafalcpp> API differs, and they do not want to write compatiblity layer. But probably allows same needed functions 03:46 < wumpus> oh it still prints ".", but it looks like it takes a lot longer to initially generate the cache 03:56 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 04:00 -!- Sinclair6 [sinclair6@gateway/vpn/privateinternetaccess/sinclair6] has quit [Ping timeout: 240 seconds] 04:01 < wumpus> (ok, can't bisect it either, must be something that changed locally in the environment here) 04:03 -!- vicenteH [~user@35.233.15.37.dynamic.jazztel.es] has quit [Read error: Connection reset by peer] 04:03 -!- vicenteH [~user@35.233.15.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 04:07 < wumpus> rafalcpp: yes, I did not mean to imply it would be an exact mapping 04:08 < wumpus> rafalcpp: looking at it, it does only use one call from the gh api, the one to get PR information 04:08 < rafalcpp> wumpus: yeap, perhaps it will be written tomorrow 04:09 < wumpus> and from that, it only uses the title, body and branch base ref 04:09 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has quit [Ping timeout: 245 seconds] 04:19 -!- rongze [~rongze@107.150.118.71] has joined #bitcoin-core-dev 04:20 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 04:47 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has joined #bitcoin-core-dev 05:05 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 264 seconds] 05:06 -!- laurentmt [~Thunderbi@195.181.167.149] has joined #bitcoin-core-dev 05:06 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 05:08 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 05:08 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 05:09 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 05:09 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 05:25 < bitcoin-git> [bitcoin] marcoagner opened pull request #13410: Qt: removes html tags from tr calls (master...refactor_remove_tr_html_tags) https://github.com/bitcoin/bitcoin/pull/13410 05:34 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 05:34 -!- Krellan [~Krellan@2601:640:4000:9258:784b:a0f5:5b2d:8545] has quit [Read error: Connection reset by peer] 05:34 -!- Krellan [~Krellan@2601:640:4000:9258:784b:a0f5:5b2d:8545] has joined #bitcoin-core-dev 05:35 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Quit: Leaving] 05:59 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 06:06 -!- ren0v0 [~ren0v0@host213-122-101-73.range213-122.btcentralplus.com] has joined #bitcoin-core-dev 06:13 -!- jnewshoes [~jodie@24.215.123.241] has quit [Quit: WeeChat 1.0.1] 06:20 -!- jnewshoes [~jodie@24.215.123.241] has joined #bitcoin-core-dev 06:32 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 06:35 -!- jhfrontz [~Adium@c-73-23-68-28.hsd1.fl.comcast.net] has quit [Quit: Leaving.] 06:41 -!- jhfrontz [~Adium@c-73-23-68-28.hsd1.fl.comcast.net] has joined #bitcoin-core-dev 06:53 -!- rongze [~rongze@107.150.118.71] has quit [] 07:04 < rafalcpp> wumpus: any idea how "refs/heads/pull/1/merge" is created, because it seems to not exist on github.com repo for PR 1, and yet the script wants it 07:07 -!- grafcaps [~haroldbr@50.90.83.229] has quit [Ping timeout: 260 seconds] 07:10 < harding> rafalcpp: it's a special GitHub endpoint for PRs. I don't know how they generate it. You can see some instructions for one way to use it here that may be helpful (or not): https://gist.github.com/harding/1a99b0bad37f9498709f#opening-a-pr-for-a-pr 07:11 < ryanofsky> you may need a line like "fetch = +refs/pull/*/merge:refs/remotes/origin/pull/*/merge" in your .git/config file 07:12 < rafalcpp> hmm actually that /head etc might be created by script itself. checking 07:18 -!- grafcaps [~haroldbr@50.90.83.229] has joined #bitcoin-core-dev 07:21 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f8bcef38fb9b...3d3d8ae3a0a9 07:21 < bitcoin-git> bitcoin/master ebebedc lucash.dev@gmail.com: speed up of tx_validationcache_tests by reusing of CTransaction.... 07:21 < bitcoin-git> bitcoin/master 3d3d8ae MarcoFalke: Merge #13404: [tests] speed up of tx_validationcache_tests by reusing of CTransaction.... 07:21 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #13404: [tests] speed up of tx_validationcache_tests by reusing of CTransaction. (master...speedup-tx_validationcache_tests) https://github.com/bitcoin/bitcoin/pull/13404 07:32 -!- laurentmt [~Thunderbi@195.181.167.149] has quit [Quit: laurentmt] 07:32 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 07:39 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [] 07:41 -!- Krellan [~Krellan@2601:640:4000:9258:784b:a0f5:5b2d:8545] has quit [Read error: Connection reset by peer] 07:42 -!- Krellan [~Krellan@2601:640:4000:9258:784b:a0f5:5b2d:8545] has joined #bitcoin-core-dev 07:42 -!- jcohen [~jcohen@rrcs-67-251-193-154.nyc.biz.rr.com] has joined #bitcoin-core-dev 07:43 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 07:53 -!- Sinclair6 [sinclair6@gateway/vpn/privateinternetaccess/sinclair6] has joined #bitcoin-core-dev 07:55 -!- grubles [~grubles@unaffiliated/grubles] has quit [Quit: Leaving] 07:57 -!- jcohen [~jcohen@rrcs-67-251-193-154.nyc.biz.rr.com] has quit [Ping timeout: 245 seconds] 07:57 -!- zivl [~zivl@2601:19a:837f:e4e1:3155:acf:f4e1:d2ee] has quit [Ping timeout: 260 seconds] 07:58 -!- jcohen [~jcohen@rrcs-67-251-193-154.nyc.biz.rr.com] has joined #bitcoin-core-dev 08:10 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #13412: Make ReceivedBlockTransactions return void (master...Mf1806-refactorReturnCodeValidation) https://github.com/bitcoin/bitcoin/pull/13412 08:12 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 08:14 -!- grubles [~grubles@unaffiliated/grubles] has joined #bitcoin-core-dev 08:21 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #13384: qa: Remove polling loop from test_runner (master...Mf1806-qaTestRunnerConcurrentFuture) https://github.com/bitcoin/bitcoin/pull/13384 08:23 < bitcoin-git> [bitcoin] skeees opened pull request #13413: [net,mempool] Call AcceptToMemoryPool() asynchronously in p2p (master...mempool-async) https://github.com/bitcoin/bitcoin/pull/13413 08:23 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 08:24 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 08:30 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 08:31 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 08:35 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev 08:35 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 268 seconds] 08:36 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 276 seconds] 08:38 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 08:41 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Ping timeout: 250 seconds] 08:43 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 08:52 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 08:59 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 09:01 < bitcoin-git> [bitcoin] laanwj pushed 8 new commits to master: https://github.com/bitcoin/bitcoin/compare/3d3d8ae3a0a9...ea263e1eb030 09:01 < bitcoin-git> bitcoin/master 9b0ec1a Jim Posen: db: Remove obsolete methods from CBlockTreeDB. 09:01 < bitcoin-git> bitcoin/master e5af5fc Jim Posen: db: Make reusable base class for index databases. 09:01 < bitcoin-git> bitcoin/master 61a1226 Jim Posen: index: Extract logic from TxIndex into reusable base class. 09:02 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 256 seconds] 09:02 < bitcoin-git> [bitcoin] laanwj closed pull request #13243: Make reusable base class for auxiliary indices (master...index-abstraction) https://github.com/bitcoin/bitcoin/pull/13243 09:02 < jamesob> nice change, congrats jimpo 09:05 < wumpus> I think we should invite jimpo / Jim Posen to the organizations, he's certainly a frequent contributor 09:06 < sipa> ack 09:15 -!- jcohen [~jcohen@rrcs-67-251-193-154.nyc.biz.rr.com] has quit [Ping timeout: 260 seconds] 09:18 < luke-jr> is there some reason we went from single-value args + multi-value args to override-args + config-args? the former seems a lot better.. 09:31 -!- promag [~promag@83.223.248.201] has joined #bitcoin-core-dev 09:38 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 09:41 -!- jcohen [~jcohen@rrcs-67-251-193-154.nyc.biz.rr.com] has joined #bitcoin-core-dev 09:42 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Ping timeout: 250 seconds] 09:44 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 09:45 -!- gaf_ [~fag@12.smos-linux.org] has quit [Ping timeout: 276 seconds] 09:46 -!- jcohen [~jcohen@rrcs-67-251-193-154.nyc.biz.rr.com] has quit [Ping timeout: 240 seconds] 09:50 -!- gaf_ [~fag@12.smos-linux.org] has joined #bitcoin-core-dev 09:54 < rafalcpp> wumpus: gitlab support is added probably. Though I see git submodules are not supported at all. Ok to add support for it? maybe just convert them to text of the sha1 commit? 10:04 -!- Sinclair6 [sinclair6@gateway/vpn/privateinternetaccess/sinclair6] has quit [Ping timeout: 245 seconds] 10:04 -!- GoldenBear [~gb@104.223.31.252] has quit [Quit: ZNC 1.6.3+deb1 - http://znc.in] 10:09 -!- Krellan [~Krellan@2601:640:4000:9258:784b:a0f5:5b2d:8545] has quit [Remote host closed the connection] 10:10 -!- EpicBaldGuy [~EpicBaldG@2601:18d:77f:6dd8:c951:1333:7b43:52c1] has quit [Remote host closed the connection] 10:14 -!- jcohen [~jcohen@rrcs-67-251-193-154.nyc.biz.rr.com] has joined #bitcoin-core-dev 10:17 < wumpus> rafalcpp: in bitcoin we use subtrees, not submodules, that's why there's no support for them 10:17 < sipa> support for submodules where? 10:19 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 255 seconds] 10:20 < sipa> ah, in github-merge 10:21 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ea263e1eb030...97073f8837f3 10:21 < bitcoin-git> bitcoin/master 2acd1d6 Ben Woosley: Drop uint 256 not operator... 10:21 < bitcoin-git> bitcoin/master 97073f8 Wladimir J. van der Laan: Merge #13396: Drop unused arith_uint256 ! operator... 10:22 < bitcoin-git> [bitcoin] laanwj closed pull request #13388: util: Implement boolean conversion and !operator for uint* (master...uint_bool) https://github.com/bitcoin/bitcoin/pull/13388 10:22 < bitcoin-git> [bitcoin] laanwj closed pull request #13396: Drop unused arith_uint256 ! operator (master...drop-bool-not) https://github.com/bitcoin/bitcoin/pull/13396 10:25 < bitcoin-git> [bitcoin] rfree-d opened pull request #13414: Support gitlab API in github-merge.py (master...githubmerge_support_gitlab) https://github.com/bitcoin/bitcoin/pull/13414 10:35 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 264 seconds] 10:39 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has joined #bitcoin-core-dev 10:50 -!- EpicBaldGuy [~EpicBaldG@2601:18d:77f:6dd8::3936] has joined #bitcoin-core-dev 10:57 -!- Giszmo [~leo@ip-213-233.219.201.nextelmovil.cl] has joined #bitcoin-core-dev 11:08 -!- Guest77272 is now known as wbnns 11:08 -!- wbnns [sid105317@gateway/web/irccloud.com/x-uwmvmiwlmcvbsggz] has quit [Changing host] 11:08 -!- wbnns [sid105317@21/bitcoin/binns] has joined #bitcoin-core-dev 11:12 -!- EpicBaldGuy [~EpicBaldG@2601:18d:77f:6dd8::3936] has quit [Remote host closed the connection] 11:17 -!- zivl [~zivl@2601:19a:837f:e4e1:7c31:f28f:990f:eac8] has joined #bitcoin-core-dev 11:18 < skeees> what would reaction / opinion be to defining a macro that allows a function to be static except in unit test builds 11:18 < skeees> something like #ifdef TEST "" #else static 11:19 < sipa> that would mean compiling the core objects separately for tests and for normal operation 11:20 < sipa> which may have performance advantages, but also downsides w.r.t. testability (you're not testing the exact same code as the one that goes in production) 11:31 -!- grafcaps [~haroldbr@50.90.83.229] has quit [Ping timeout: 240 seconds] 11:39 < cfields> skeees: for what purpose? 11:40 < skeees> basically, theres a bunch of stuff (e.g. in net_processing) that could become static (and a lot of which is only called from one place so probably even inlined at compile time) except that its unit tested somewhere. might have some perf benefits, and would also help readability because you can immediately assess that something is translation unit local 11:41 < skeees> but i imagine the work to configure separate builds is substantial 11:41 < sipa> the perf benefits we can get longer term through lto as well 11:41 < cfields> skeees: sounds like you're looking for lto? 11:42 < skeees> mostly actually, i'm trying to separate net_processing a bit more from validation, and its been somewhat of a manual exercise, but finding lots of these - so i would say primarily readability / modularization actually 11:42 < skeees> probably better static analysis tools would accomplish the same 11:44 < cfields> ah, I see 11:45 < gmaxwell> If we just want a cosmetic note for arch reasons, there could be a STATICBUTFORTESTS that turns into STATIC for a specific test build (to verify that its used correctly) but otherwise isn't. 11:46 < skeees> hmmm yeah, that would do it 11:47 < wumpus> skeees: yes, pretty much an alternative to this: https://github.com/bitcoin/bitcoin/pull/13301#issuecomment-391712408 11:47 < wumpus> skeees: there's some good reasons to be against including cpp files, but it's also useful for testing static functions :) 11:48 -!- DougieBot5000 [~DougieBot@unaffiliated/dougiebot5000] has quit [Read error: Connection reset by peer] 11:48 < skeees> ahhh, well you could have that linter not run on anything in test/* 11:48 -!- DougieBot5000 [~DougieBot@unaffiliated/dougiebot5000] has joined #bitcoin-core-dev 11:49 -!- zivl_ [~zivl@2601:19a:837f:e4e1:7c31:f28f:990f:eac8] has joined #bitcoin-core-dev 11:50 < gmaxwell> In other projects I've had okay success with including .c files for unit tests. I can get arguments against it though. 11:50 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has quit [Read error: Connection reset by peer] 11:50 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Quit: Leaving] 11:51 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev 11:52 -!- zivl [~zivl@2601:19a:837f:e4e1:7c31:f28f:990f:eac8] has quit [Ping timeout: 260 seconds] 11:52 < wumpus> well it still has sipa's problem that "you're not testing the exact same code as the one that goes in production", it avoids the macro magic, but has including c/cpp files 11:52 < wumpus> choosing between evils... 11:53 -!- nmnkgl [~nmnkgl@c-73-189-35-88.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 11:54 < wumpus> the advantage of "my" method is that it also works for anonymous namespaces 11:54 < wumpus> a macro to replace static, would just work for static 11:54 -!- grafcaps [~haroldbr@104.137.194.255] has joined #bitcoin-core-dev 11:55 < gmaxwell> Not testing the exact same code that goes into production is already pretty complicated. What the compiler is doing for inlinable functions already is inlining them where it can, potentially at every use in the file, and then the export is some other code. So the test may well already be testing code that is not used anywhere else. 11:55 < wumpus> gmaxwell: indeed 11:55 -!- clarkmoody [~clarkmood@47-218-248-206.bcstcmta04.res.dyn.suddenlink.net] has joined #bitcoin-core-dev 11:55 < gmaxwell> (obviously this doesn't matter if the code is all defined behavior and the compiler is bug free...) 11:55 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 11:56 < gmaxwell> I like to think of the "not testing the exact same code" as more of just a fundimental limitation of unit tests. 11:56 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #13415: rpc: Add testblocktemplatevalidity (master...Mf1806-rpcTestblocktemplatevalidity) https://github.com/bitcoin/bitcoin/pull/13415 11:56 < jcorgan> meeting? 11:57 < wumpus> I mean it's a good point - internal/static functions are very likely inlined, so it's impossible to test exactly the same assembly code as used in production functions 11:57 < wumpus> the point of the unit test would be to test the functionality of the code, not the compiler 11:57 < wumpus> jcorgan: still 3 minutes to go according to my clock 11:57 < jcorgan> ah, need to fix ntpd on my irc bouncer :) 11:58 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 11:59 < gmaxwell> wumpus: yes, point of the unit test is testing functionality of the code not the compiler-- though if the code executes undefined behavior you can't fully decouple those things. In any case, my point is that static vs not static doesn't differ in the functionality of the code... 12:00 < sipa> *GONG* 12:00 < wumpus> #startmeeting 12:00 < lightningbot> Meeting started Thu Jun 7 19:00:08 2018 UTC. The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot. 12:00 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic. 12:00 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Ping timeout: 256 seconds] 12:00 < achow101> hi 12:01 < sipa> hi 12:01 < wumpus> PSA: v0.16.1rc2 has been tagged, please start your gitian builders if you haven't yet, hopefully this can be a short rc, the only change is translations 12:01 < sipa> reasonable chance that rc2 will be final? 12:01 < sipa> (sorry, i haven't followed 0.16.1 much) 12:01 < achow101> yes 12:01 -!- GoldenBear [~gb@104.223.31.252] has joined #bitcoin-core-dev 12:01 < wumpus> well at least I haven't seen any other reports to it, except the Russian translation issue 12:01 < promag> hi 12:02 < wumpus> so yes I hope this can be final very quickly 12:02 < jimpo_> hi 12:03 < wumpus> topic proposals? 12:03 < wumpus> #topic High priority for review 12:03 < wumpus> #link https://github.com/bitcoin/bitcoin/projects/8 12:04 < wumpus> I don't understand why I added #13059 there last week, it's an issue, not a PR 12:04 < gribble> https://github.com/bitcoin/bitcoin/issues/13059 | Dynamic wallet load / create / unload · Issue #13059 · bitcoin/bitcoin · GitHub 12:05 < wumpus> at least we merged #13243 12:06 < gribble> https://github.com/bitcoin/bitcoin/issues/13243 | Make reusable base class for auxiliary indices by jimpo · Pull Request #13243 · bitcoin/bitcoin · GitHub 12:06 < sipa> yay 12:06 < promag> =) 12:06 < wumpus> so 6 PRs left, I'll remove the issue, surprised no one notified me about that 12:06 < promag> I saw that, didn't mind :P 12:07 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 240 seconds] 12:08 < wumpus> I had an attempt at reviewing and testing #12196, but seems I found a bug 12:08 < gribble> https://github.com/bitcoin/bitcoin/issues/12196 | Add scantxoutset RPC method by jonasschnelli · Pull Request #12196 · bitcoin/bitcoin · GitHub 12:08 < wumpus> it also needs rebase 12:08 < wumpus> @jonasschnelli 12:08 < jonasschnelli> hi 12:09 < sipa> i was going to follow up with some ideas for writing sets of scripts/addresses 12:09 < jonasschnelli> yes. will take care. had some busy days but will work on it next week 12:09 < wumpus> ok, thanks for letting me know 12:09 < jonasschnelli> please do sipa 12:09 < sipa> yeah, it's on my todo list 12:11 < wumpus> #13062 I already reviewed a while ago, though it's been needed to rebase since 12:11 < gribble> https://github.com/bitcoin/bitcoin/issues/13062 | Make script interpreter independent from storage type CScript by sipa · Pull Request #13062 · bitcoin/bitcoin · GitHub 12:11 < sipa> i'll happily keep rebasing it :) 12:11 < wumpus> luke-jr: #11082 needs rebase too 12:12 < gribble> https://github.com/bitcoin/bitcoin/issues/11082 | Add new bitcoin_rw.conf file that is used for settings modified by this software itself by luke-jr · Pull Request #11082 · bitcoin/bitcoin · GitHub 12:12 -!- jimpo_ [~jimpo@ec2-34-211-143-113.us-west-2.compute.amazonaws.com] has quit [Quit: ZNC 1.6.6 - http://znc.in] 12:12 < luke-jr> is there some reason we went from single-value args + multi-value args to override-args + config-args? the former seems a lot better.. 12:12 -!- jimpo [~jimpo@ec2-34-211-143-113.us-west-2.compute.amazonaws.com] has joined #bitcoin-core-dev 12:12 < luke-jr> (this is blocking me on 11082 rebasing) 12:12 < wumpus> I'll take that as a topic suggestion 12:12 < sipa> i'm not sure what you mean by that 12:13 < wumpus> (for later) 12:13 < wumpus> #12136 still has lots of active discussion 12:13 < gribble> https://github.com/bitcoin/bitcoin/issues/12136 | Implement BIP 174 Partially Signed Bitcoin Transactions by achow101 · Pull Request #12136 · bitcoin/bitcoin · GitHub 12:13 < wumpus> achow101: any idea what's needed to move forward there? 12:14 < gmaxwell> Is 13191 waiting on my review and testing? 12:14 < achow101> wumpus: more review 12:14 < wumpus> achow101: just review? ok 12:14 < achow101> wumpus: perhaps on the bip itself too 12:14 < sipa> i've also been discussion some ideas for splitting part of it up 12:15 < wumpus> gmaxwell: #13191 is already merged, but you're very welcome to test and review it anyhow 12:15 < gribble> https://github.com/bitcoin/bitcoin/issues/13191 | Specialized double-SHA256 with 64 byte inputs with SSE4.1 and AVX2 by sipa · Pull Request #13191 · bitcoin/bitcoin · GitHub 12:15 < wumpus> sipa: that's a good idea, I think, just to have progress 12:15 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 12:16 < wumpus> better to make sure as many as possible non-controversial things already merged 12:16 < gmaxwell> wumpus: lol. sorry, I had an old page up and on reload the post merge discussion caused me to miss that it was merged. :P 12:16 < gmaxwell> So I was confused as to why it wasn't merged yet. 12:16 < wumpus> gmaxwell: hehe 12:17 < sipa> there are a few more specialized-instructions-optimized-code PRs open 12:17 < sipa> we discovered yesterday that compiling the sse4 intrinsics code with -mavx gives a 30% speedup 12:18 < wumpus> #13111 should be pretty close, I guess it's just a boring thing to manually test because it unloads 12:18 < gribble> https://github.com/bitcoin/bitcoin/issues/13111 | Add unloadwallet RPC by promag · Pull Request #13111 · bitcoin/bitcoin · GitHub 12:18 < cfields> sipa: how much work do you think it would be to switch the sse41 to intrinsics? 12:18 < promag> reviews are welcome 12:18 < wumpus> promag: I will 12:18 < promag> i think it's almost there 12:18 < sipa> cfields: that would be neat 12:19 < sipa> cfields: i can try, but it's low priority for me 12:19 < wumpus> sipa: yes, that was really neat 12:19 < gmaxwell> I'll put money on it being a boatload slower. :P 12:19 < sipa> gmaxwell: define "boatload" please 12:19 < gmaxwell> (based on the mavx result suggests to me that the compiler is failing to achieve a good register allocation that doesn't kill performance) 12:19 < gmaxwell> 30%. 12:19 < sipa> (so i know whether to take the bet or not) 12:19 < sipa> nah, no way it's 30% slower with intrinsics :) 12:20 < wumpus> I supose it's only boatloads slower on my stupid AMD system :) 12:20 < cfields> sipa: ok, I'll look around for an impl on the net to copy from. I doubt I'd fare well myself, though :( 12:20 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Ping timeout: 264 seconds] 12:21 < sipa> cfields: the asm code we have is derived from nasm code that's more readable 12:21 < sipa> that may help 12:21 < wumpus> but anyhow if anyone needs benchmarking of anything on AMD, just let me know 12:21 < cfields> ok 12:21 < cfields> wumpus: I'd prefer to merge before getting the AMD numbers :p 12:21 < wumpus> cfields: I understand :p 12:22 < gmaxwell> wumpus: have you seen if the mavx compiled SSE4 code is slower on your system? I wouldn't expect it to be. 12:22 < wumpus> too bad I seem to collect them 12:23 < cfields> gmaxwell: iirc he benched those and it was ~the same. 12:23 < wumpus> gmaxwell: there was almost no difference with avx here 12:23 < wumpus> it was very slightly faster 12:23 < gmaxwell> odd. 12:23 -!- Giszmo [~leo@ip-213-233.219.201.nextelmovil.cl] has quit [Read error: Connection reset by peer] 12:24 < wumpus> looks like they go in to some emulation mode 12:24 < cfields> right: https://0bin.net/paste/ReThQTAAWhKYfH7x#K99wDsZBBbtqEnc1N44e9UWz2E-t1y2jDhByhD8BBZe 12:24 < gmaxwell> (odd because my understanding was that the 30% speedup from getting better register space, not from using any AVX instructions...) 12:24 < sipa> gmaxwell: in AVX mode there literally is 2x more register space 12:25 < sipa> but maybe that's not the reason for the speedup, i haven't analysed 12:25 < sipa> still, i would be very surprised if equivalent code with intrinsics rather than asm is more than a few % slower 12:25 < gmaxwell> We can take this discussion offline, but I don't completely agree. :) 12:25 < sipa> ok! 12:25 < wumpus> intrinsics should do very well, with modern SIMD instruction sets 12:26 < wumpus> (they're pretty much designed to work well with them) 12:26 < wumpus> but yes, it's getting a bit off topic 12:26 < wumpus> #topic single-value args + multi-value args to override-args + config-args? (luke-jr) 12:26 < sipa> luke-jr: elaborate 12:27 < gmaxwell> I have cached skeptcisism mostly because compilers used to be VERY bad with register allocations for SIMD, resulting in a lot of code that is more complex than 'run this code 4x in parallel' not getting a speedup when hand asm hapily got a 3x speedup. I know they're much better now. So perhaps ignore me. :) 12:27 < luke-jr> we used to have a map of arg name -> single value and arg name -> multiple values 12:28 < luke-jr> it's been changed to arg name-> multiple values, but with two maps, one for config file, and one for command line options 12:28 < luke-jr> it seems better to have config/commandline share maps 12:28 < wumpus> gmaxwell: compilers seem to have become better with that, but I understand your skepticism 12:29 < wumpus> gmaxwell: there's also the *optimizing for a specific CPU type* versus *optimizing it to be, on average, fast, for many families of CPUs* thing 12:29 < luke-jr> this comes up because the change complicates how to implement rwconf 12:30 < achow101> luke-jr: I think that change may be for qt settings interactions 12:30 < wumpus> luke-jr: I'm not sure I know enough about this to understand the implications of this in practice 12:30 < jnewbery> luke-jr: it was changed in #11862 12:31 < gribble> https://github.com/bitcoin/bitcoin/issues/11862 | Network specific conf sections by ajtowns · Pull Request #11862 · bitcoin/bitcoin · GitHub 12:31 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 12:31 < wumpus> whatever you do, please don't mess up the bitcoin-qt initialization order, the rest is fine with me :p 12:31 < sipa> i think it would also be useful to make the arg information know whether a particular argument is single-value or multi-value 12:32 < sipa> rather than have that information be at query time 12:32 -!- bitconner [~conner@64-71-8-130.static.wiline.com] has joined #bitcoin-core-dev 12:32 < sipa> but i also don't understand the interactions well enough 12:32 < sipa> aj: you here? 12:32 < luke-jr> sipa: yes, I was thinking about that too 12:32 < wumpus> #13389 kind of scared me 12:32 < gribble> https://github.com/bitcoin/bitcoin/issues/13389 | Utils and libraries: Fix #13371 - move umask operation earlier in AppInit() by n2yen · Pull Request #13389 · bitcoin/bitcoin · GitHub 12:33 < luke-jr> the reason they're split one way or the other, is because the last command line option overrides the former ones, and the earlier config file overrides the later ones 12:33 < wumpus> we don't have good tests for half of this stuff 12:33 < luke-jr> so now when we do Get*Arg, the code is going for the end of the command line list, then the start of the config file list 12:34 < luke-jr> (the altnerative being, to just parse into a single value at startup, and just access that map at runtime) 12:35 < sipa> i feel like the right people aren't here to discuss that 12:35 < wumpus> yes 12:35 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Ping timeout: 240 seconds] 12:35 < luke-jr> maybe 12:36 < sipa> it sounds reasonable what you're saying, but i don't know enough to really comment 12:36 < wumpus> I agree 12:37 < jnewbery> There's a lot of discussion and review in both #12878 and #11862. AJ also added really good code coverage in those PRs, so it should be pretty straightforward to follow 12:37 < wumpus> other topics? 12:37 < gribble> https://github.com/bitcoin/bitcoin/issues/12878 | [refactor] Config handling refactoring in preparation for network-specific sections by ajtowns · Pull Request #12878 · bitcoin/bitcoin · GitHub 12:37 < gribble> https://github.com/bitcoin/bitcoin/issues/11862 | Network specific conf sections by ajtowns · Pull Request #11862 · bitcoin/bitcoin · GitHub 12:37 < promag> it also sounds reasonable to encapsulate the arg chaining in a map lookup lookalike 12:38 < wumpus> meh 12:39 < luke-jr> sounds like either way I should start with tests 12:39 < wumpus> personally I prefer method calls to just look like method calls, not operator overrides, in the common case 12:40 < wumpus> luke-jr: yes! tests are always good 12:41 -!- Giszmo [~leo@ip-63-233.219.201.nextelmovil.cl] has joined #bitcoin-core-dev 12:41 < wumpus> other topics? 12:42 -!- ccdle12 [5eadef37@gateway/web/freenode/ip.94.173.239.55] has joined #bitcoin-core-dev 12:42 < promag> actually I have a question 12:43 < promag> #13374 and #13375 12:43 < gribble> https://github.com/bitcoin/bitcoin/issues/13374 | utils and libraries: checking for bitcoin address in translations by kaplanmaxe · Pull Request #13374 · bitcoin/bitcoin · GitHub 12:43 < gribble> https://github.com/bitcoin/bitcoin/issues/13375 | utils and libraries: address check in update-translations.py by undercoverGod · Pull Request #13375 · bitcoin/bitcoin · GitHub 12:43 < wumpus> if you have a topic, just propose it, there's no need to tell that you have a question 12:43 < promag> they are the same, why isn't one closed? 12:44 < wumpus> because no one told me (or fanquake, or anyone) to? 12:44 < wumpus> I do not have the capacity to pay attention to all PRs in parallel 12:44 < promag> really? :P 12:44 < sipa> we need to have an AVX2 wumpus 12:44 < wumpus> sipa: +1 12:45 < sipa> +8 12:45 < sipa> end of meeting, i assume? 12:45 < wumpus> yes 12:45 < wumpus> #endmeeting 12:45 < lightningbot> Meeting ended Thu Jun 7 19:45:28 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) 12:45 < lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-06-07-19.00.html 12:45 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-06-07-19.00.txt 12:45 < lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-06-07-19.00.log.html 12:47 < BlueMatt> oh, quick comment: if you have had ideas about things you want to fork into the protocol in the future, *please* read https://github.com/TheBlueMatt/bips/blob/betterhash/bip-XXXX.mediawiki and make sure that your ideas can be added without protocol modifications so that miners dont need firmware updates 12:47 < BlueMatt> and pools wouldnt need to change 12:47 < BlueMatt> obviously basic things like additional commitments especially via the witness reserved value are clearly supported 12:48 < wumpus> promag: if people open "competing PRs" for the same issue that makes things more difficult 12:49 < wumpus> instead of just reviewing code, you suddenly need to be judge of what is the best approach 12:49 < promag> what are the odds to open competing PRs at the "same time"? 12:49 < promag> right 12:49 < wumpus> promag: it luckily doesn't happen too much! 12:50 < promag> imo one of the authors (the last?) should review the other 12:50 < promag> and close his own 12:50 < wumpus> I like your approach, get them to cooporate intead of compete 12:50 * luke-jr goes through the PR list, rewrites them, and opens new PRs to compete. jk 12:51 < promag> luke-jr: in this case they are very very similar 12:51 < wumpus> luke-jr: I know it, I shouldn't have given away this obvious DoS strategy 12:52 < promag> it's not a rewrite like you say 12:52 < luke-jr> wumpus: actually, if someone does try to DoS with it, it may end up improving our flow quickly 12:52 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 12:52 < wumpus> I'm... not going to say more about this, not giving people ideas :) 12:53 < promag> wumpus: then feel free to review my PR 12:53 < wumpus> promag: which one? 12:53 < promag> all 12:53 < promag> :| 12:53 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds] 12:54 < promag> unloadwallet 12:54 < promag> in travis its failing with -with-incompatible-bdb i think 12:54 < wumpus> lets' first see why travis is failing on it 12:55 < promag> I'll 12:55 < promag> .. to reproduce locally 12:56 < wumpus> multiwallet failing on x86_64 linux platforms 12:57 < promag> hm 12:59 < wumpus> I'll try locally too, on AMD :p 13:00 < promag> ty 13:02 -!- bitconner [~conner@64-71-8-130.static.wiline.com] has quit [Ping timeout: 276 seconds] 13:05 -!- promag_ [~promag@83.223.248.201] has joined #bitcoin-core-dev 13:05 -!- promag [~promag@83.223.248.201] has quit [Ping timeout: 240 seconds] 13:09 < bitcoin-git> [bitcoin] wodry opened pull request #13416: More precise explanation of parameter onlynet (master...patch-1) https://github.com/bitcoin/bitcoin/pull/13416 13:16 < wumpus> promag_: /home/orion/projects/bitcoin/bitcoin/src/qt/bitcoingui.cpp:122:5: warning: field 'spinnerFrame' will be initialized after field 'm_wallet_selector_label' [-Wreorder] 13:17 < wumpus> (I think that's due to your change, I haven't seen it before) 13:19 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 13:21 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds] 13:23 -!- Tralfaz [~none@103.10.197.187] has joined #bitcoin-core-dev 13:23 -!- Tralfaz [~none@103.10.197.187] has quit [Max SendQ exceeded] 13:27 -!- nmnkgl [~nmnkgl@c-73-189-35-88.hsd1.ca.comcast.net] has quit [Remote host closed the connection] 13:27 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 13:28 -!- nmnkgl [~nmnkgl@c-73-189-35-88.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 13:31 -!- clarkmoody [~clarkmood@47-218-248-206.bcstcmta04.res.dyn.suddenlink.net] has quit [] 13:32 -!- nmnkgl [~nmnkgl@c-73-189-35-88.hsd1.ca.comcast.net] has quit [Ping timeout: 245 seconds] 13:33 < wumpus> promag_: I don't get the same crash locally 13:33 -!- promag_ is now known as promag 13:34 < promag> regarding the warning, i'll fix 13:35 < promag> strange 13:36 < promag> mtt bug? 13:37 < wumpus> mtt? 13:37 < promag> multithread 13:37 < promag> crash aside, a code review + concept ack would be nice 13:38 < bitcoin-git> [bitcoin] skeees opened pull request #13417: [net] Tighten scope in net_processing (master...net_processing-disentangle) https://github.com/bitcoin/bitcoin/pull/13417 13:43 -!- jhfrontz [~Adium@c-73-23-68-28.hsd1.fl.comcast.net] has quit [Quit: Leaving.] 13:45 -!- jhfrontz [~Adium@c-73-23-68-28.hsd1.fl.comcast.net] has joined #bitcoin-core-dev 13:45 -!- gkgkgk [~snickerfr@104.254.92.61] has joined #bitcoin-core-dev 13:47 -!- gkgkgk [~snickerfr@104.254.92.61] has quit [Client Quit] 13:48 -!- hfdtfsuaiwhaiwoe [~snickerfr@104.254.92.61] has joined #bitcoin-core-dev 13:48 -!- hfdtfsuaiwhaiwoe [~snickerfr@104.254.92.61] has quit [Remote host closed the connection] 13:49 -!- hfdtfsuaiwhaiwoe [~snickerfr@104.254.92.61] has joined #bitcoin-core-dev 14:00 < bitcoin-git> [bitcoin] wodry closed pull request #13416: More precise explanation of parameter onlynet (master...patch-1) https://github.com/bitcoin/bitcoin/pull/13416 14:06 -!- jcohen [~jcohen@rrcs-67-251-193-154.nyc.biz.rr.com] has quit [Ping timeout: 260 seconds] 14:06 < bitcoin-git> [bitcoin] wodry opened pull request #13418: More precise explanation of parameter onlynet (master...patch-2) https://github.com/bitcoin/bitcoin/pull/13418 14:13 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:19 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 14:22 -!- bitconner [~conner@64-71-8-130.static.wiline.com] has joined #bitcoin-core-dev 14:23 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Ping timeout: 240 seconds] 14:29 -!- Cheeseo [Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has joined #bitcoin-core-dev 14:29 < MarcoFalke> > MarcoFalke is your bot on GH somewhere? 14:30 < MarcoFalke> Not yet 14:32 -!- nmnkgl [~nmnkgl@c-73-189-35-88.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 14:34 -!- bitconner [~conner@64-71-8-130.static.wiline.com] has quit [Ping timeout: 268 seconds] 14:37 -!- nmnkgl [~nmnkgl@c-73-189-35-88.hsd1.ca.comcast.net] has quit [Ping timeout: 256 seconds] 14:39 -!- nmnkgl [~nmnkgl@c-73-189-35-88.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 14:48 < jimpo> Why in BIP 141 is the coinbase witness stack restricted to 1 item instead of making the reserved value the entire witness? 14:52 -!- Cheeseo [Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has quit [Read error: Connection reset by peer] 14:57 < sipa> jimpo: perhaps that was a mistake 14:57 < sipa> the reasoning was that you only need 1 reserved value in each level to 'chain' a new piece of data necessary for consensus 15:06 -!- Giszmo [~leo@ip-63-233.219.201.nextelmovil.cl] has quit [Ping timeout: 264 seconds] 15:09 -!- ccdle12 [5eadef37@gateway/web/freenode/ip.94.173.239.55] has quit [Ping timeout: 260 seconds] 15:11 < jimpo> OK, thanks. Yeah, seems like it would just require more hash operations if it's linear in the number of levels/commitments. 15:20 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 15:23 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 15:27 -!- bitconner [~conner@64-71-8-130.static.wiline.com] has joined #bitcoin-core-dev 15:29 -!- Giszmo [~leo@pc-72-54-46-190.cm.vtr.net] has joined #bitcoin-core-dev 15:32 -!- nmnkgl [~nmnkgl@c-73-189-35-88.hsd1.ca.comcast.net] has quit [Remote host closed the connection] 15:40 -!- hfdtfsuaiwhaiwoe [~snickerfr@104.254.92.61] has quit [Changing host] 15:40 -!- hfdtfsuaiwhaiwoe [~snickerfr@unaffiliated/snickerfritz] has joined #bitcoin-core-dev 15:45 -!- Sinclair_ [sinclair6@gateway/vpn/privateinternetaccess/sinclair6] has joined #bitcoin-core-dev 15:45 -!- bitconner [~conner@64-71-8-130.static.wiline.com] has quit [Ping timeout: 256 seconds] 15:49 -!- bitconner [~conner@64-71-8-130.static.wiline.com] has joined #bitcoin-core-dev 15:49 -!- hfdtfsuaiwhaiwoe [~snickerfr@unaffiliated/snickerfritz] has quit [Quit: Leaving] 15:50 -!- snickerfritz_ [~snickerfr@104.254.92.61] has joined #bitcoin-core-dev 15:51 -!- snickerfritz_ [~snickerfr@104.254.92.61] has quit [Changing host] 15:51 -!- snickerfritz_ [~snickerfr@unaffiliated/snickerfritz] has joined #bitcoin-core-dev 15:52 -!- snickerfritz_ is now known as snickerfritz 16:05 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 16:05 -!- nekotribal [~nekotriba@host-89-230-96-42.dynamic.mm.pl] has joined #bitcoin-core-dev 16:06 -!- Aaronva__ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 16:07 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 248 seconds] 16:08 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 264 seconds] 16:09 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 16:19 -!- snickerfritz [~snickerfr@unaffiliated/snickerfritz] has quit [Ping timeout: 276 seconds] 16:30 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 16:34 -!- promag [~promag@83.223.248.201] has quit [Remote host closed the connection] 16:36 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has quit [Remote host closed the connection] 16:52 -!- snickerfritz [~snickerfr@unaffiliated/snickerfritz] has joined #bitcoin-core-dev 16:52 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Ping timeout: 268 seconds] 16:56 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 17:04 -!- promag [~promag@83.223.248.201] has joined #bitcoin-core-dev 17:06 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Ping timeout: 264 seconds] 17:15 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 17:21 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 17:23 -!- promag_ [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 17:26 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Ping timeout: 264 seconds] 17:26 -!- promag [~promag@83.223.248.201] has quit [Ping timeout: 240 seconds] 17:40 -!- Giszmo [~leo@pc-72-54-46-190.cm.vtr.net] has quit [Ping timeout: 248 seconds] 17:48 -!- Aaronva__ is now known as AaronvanW 17:55 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 17:56 -!- Giszmo [~leo@ip-129-233.219.201.nextelmovil.cl] has joined #bitcoin-core-dev 18:00 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Ping timeout: 248 seconds] 18:03 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 18:05 -!- so [~so@unaffiliated/so] has joined #bitcoin-core-dev 18:08 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Ping timeout: 240 seconds] 18:18 -!- Cory [~Cory@unaffiliated/cory] has quit [Ping timeout: 240 seconds] 18:18 -!- nmnkgl [~nmnkgl@c-73-189-35-88.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 18:19 < jnewshoes> ‰/join #gentoo 18:19 < jnewshoes> quit 18:19 -!- jnewshoes [~jodie@24.215.123.241] has quit [Quit: WeeChat 1.0.1] 18:22 -!- grafcaps [~haroldbr@104.137.194.255] has quit [Ping timeout: 256 seconds] 18:24 -!- jwhoisthat [~jodie@24.215.123.241] has joined #bitcoin-core-dev 18:24 -!- Cory [~Cory@unaffiliated/cory] has joined #bitcoin-core-dev 18:26 -!- nmnkgl [~nmnkgl@c-73-189-35-88.hsd1.ca.comcast.net] has quit [] 18:40 -!- grafcaps [~haroldbr@50.90.83.229] has joined #bitcoin-core-dev 18:56 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 250 seconds] 18:56 -!- snickerfritz_ [~snickerfr@184.75.213.134] has joined #bitcoin-core-dev 18:56 -!- snickerfritz [~snickerfr@unaffiliated/snickerfritz] has quit [Ping timeout: 245 seconds] 18:58 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 19:11 -!- grafcaps [~haroldbr@50.90.83.229] has quit [Ping timeout: 256 seconds] 19:29 -!- snickerfritz_ [~snickerfr@184.75.213.134] has quit [Ping timeout: 256 seconds] 19:34 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 19:36 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 265 seconds] 19:37 -!- promag_ [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 248 seconds] 19:37 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 19:43 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [] 19:51 -!- grafcaps [~haroldbr@50.90.83.229] has joined #bitcoin-core-dev 19:59 < bitcoin-git> [bitcoin] lucash-dev opened pull request #13419: [tests] Speed up knapsack_solver_test by not recreating wallet 100 times. (master...speedup-knapsack-solver-test) https://github.com/bitcoin/bitcoin/pull/13419 20:01 -!- grafcaps [~haroldbr@50.90.83.229] has quit [Ping timeout: 260 seconds] 20:34 -!- Roybent [~Instantbi@49.124.24.80] has joined #bitcoin-core-dev 20:40 -!- Giszmo [~leo@ip-129-233.219.201.nextelmovil.cl] has quit [Ping timeout: 240 seconds] 20:55 -!- Giszmo [~leo@ip-41-234-219-201.nextelmovil.cl] has joined #bitcoin-core-dev 21:26 -!- bitconner [~conner@64-71-8-130.static.wiline.com] has quit [Ping timeout: 240 seconds] 21:46 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 22:40 -!- CubicEarths [~cubiceart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 22:52 -!- grafcaps [~haroldbr@50.90.83.229] has joined #bitcoin-core-dev 23:10 -!- vicenteH [~user@35.233.15.37.dynamic.jazztel.es] has quit [Read error: Connection reset by peer] 23:10 -!- vicenteH [~user@35.233.15.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 23:35 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 23:35 -!- grafcaps [~haroldbr@50.90.83.229] has quit [Ping timeout: 264 seconds] 23:45 < cfields> jonasschnelli: macOS codesign nudge :) 23:45 < jonasschnelli> jup 23:45 * jonasschnelli starting builder... :) 23:46 < cfields> jonasschnelli: I need to head to bed. If you're comfortable with your sig, feel free to tag as v0.16.1rc2 23:46 < fanquake> I'll push some sigs in a seconds 23:46 < cfields> er, push yours and tag that is 23:47 < jonasschnelli> Do I have push rights? 23:47 < cfields> jonasschnelli: I thought so? 23:47 < jonasschnelli> Okay. Will tag and push 23:48 < cfields> fanquake: thanks. I have a pile of your stuff to get to, btw. Sorry for getting so far behind. 23:49 < fanquake> cfields np. I have been a bit slack myself lately. I'm sure it's more interesting playing with the SHA Extensions stuff anyways :p 23:49 < cfields> fanquake: nah, that's a distraction from the other stuff I should be doing :( 23:50 < fanquake> cfields Sounds like you need to delegate. Is this p2p refactoring, or outside Core? 23:51 < cfields> fanquake: yea, something outside Core that I've been putting off 23:51 < cfields> no worries, I'll try to catch up over the weekend 23:51 < fanquake> cfields Better get some sleep then. Smash it out tomorrow. 23:52 < fanquake> No worries 23:52 < cfields> good plan. nnite.