--- Day changed Tue Jun 12 2018 00:09 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 00:17 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 00:23 -!- harrymm [~harrymm@104.207.83.8] has quit [Ping timeout: 265 seconds] 00:35 -!- harrymm [~harrymm@104.207.83.8] has joined #bitcoin-core-dev 00:41 < kallewoof> Maybe I missed it.. do we ask someone to remove the needs rebase tags after we rebase stuff or...? 00:42 < sipa> kallewoof: DrahtBot will remove them when it gets around 00:46 < kallewoof> Oh, it is delayed? Gotcha 00:56 < bitcoin-git> [bitcoin] ken2812221 opened pull request #13445: build: Reset default -g -O2 flags when enable debug (master...debug_cflags) https://github.com/bitcoin/bitcoin/pull/13445 00:59 < sipa> kallewoof: it's a bot, it goes through all PRs one by one, it takes a while 00:59 < sipa> MarcoFalke runs it 01:06 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:11 -!- drizztbsd [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:11 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 265 seconds] 01:14 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 01:20 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 01:26 < bitcoin-git> [bitcoin] ccdle12 closed pull request #13067: [WIP] Unit test sub-directories - Continued (master...PR-fixes-ccdle12) https://github.com/bitcoin/bitcoin/pull/13067 01:28 < jonasschnelli> wumpus: regarding https://github.com/bitcoin/bitcoin/pull/12196#issuecomment-394356035 ... 01:28 < jonasschnelli> Is that a pay to pubkey unspent? 01:34 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 01:35 < bitcoin-git> [bitcoin] murrayn opened pull request #13446: Build: remove non-distribution files/directories during make distclean. (master...distclean) https://github.com/bitcoin/bitcoin/pull/13446 01:40 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 248 seconds] 02:09 -!- cdecker [~cdecker@mail.snyke.net] has quit [Ping timeout: 245 seconds] 02:10 -!- cdecker [~cdecker@mail.snyke.net] has joined #bitcoin-core-dev 02:13 -!- Empact [~empact@192-195-80-238.PUBLIC.monkeybrains.net] has quit [Ping timeout: 245 seconds] 02:17 -!- Empact [~empact@192-195-80-238.PUBLIC.monkeybrains.net] has joined #bitcoin-core-dev 02:26 -!- f_ [7ccc431a@gateway/web/freenode/ip.124.204.67.26] has joined #bitcoin-core-dev 02:30 -!- f_ [7ccc431a@gateway/web/freenode/ip.124.204.67.26] has quit [Client Quit] 02:41 -!- ExtraCrispy [~ExtraCris@185.9.18.150] has joined #bitcoin-core-dev 02:50 -!- drizztbsd [~tredaelli@redhat/timothy] has quit [Ping timeout: 248 seconds] 02:51 -!- drizztbsd [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 02:53 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:56 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 02:58 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 03:03 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 240 seconds] 03:11 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 03:12 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 03:14 -!- bobques33 [7d10ec83@gateway/web/freenode/ip.125.16.236.131] has joined #bitcoin-core-dev 03:32 -!- laurentmt [~Thunderbi@185.94.189.189] has joined #bitcoin-core-dev 04:12 < rafalcpp> wumpus: hm, why are symlinks prohibited from being in Tree-SHA512? they seem to normally work, they are shown as blobs, their git-sha1 is identical for symlinks with same symlink target, and so is sha512 that we get from them 04:14 -!- nman999_ [~nman999@181.140.4.100] has joined #bitcoin-core-dev 04:15 -!- nman999_ [~nman999@181.140.4.100] has quit [Client Quit] 04:18 < rafalcpp> BlueMatt: why we disallow symlinks? (it's your commit be908a69 - Fail merge if there are any symlinks) 04:23 < rafalcpp> it was decided in #9871 to disable them because bitcoin doesn't need them so no need to wonder if we handle them correctly 04:23 < gribble> https://github.com/bitcoin/bitcoin/issues/9871 | Add a tree sha512 hash to merge commits by sipa · Pull Request #9871 · bitcoin/bitcoin · GitHub 04:23 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 04:28 -!- bobques33 [7d10ec83@gateway/web/freenode/ip.125.16.236.131] has quit [Ping timeout: 260 seconds] 04:33 < wumpus> rafalcpp: basic security precaution, we could go into detail analysing the consequences of symlinks (relative, absolute, inside tree, outside tree, etc) or just blanket disallow them. As we don't require them, just disallowing is safer. 04:33 < wumpus> jonasschnelli: could be! 04:34 < wumpus> we don't really *want* symlinks ending up in the repository 04:37 < wumpus> `(they're also not compatible with some OSes) 04:40 < rafalcpp> wumpus: perhaps support for them could exist with --allow-symlinks defaulting to false? Other projects besides bitcoin could benefit from tree sha512 04:40 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 04:41 < wumpus> yes- it could be a git setting that defaults to false. But I don't think it's urgent. 04:57 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 05:03 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/7c32b414b632...b22115d9a3b0 05:03 < bitcoin-git> bitcoin/master 419a198 practicalswift: docs: Add a note about the source code filename naming convention 05:03 < bitcoin-git> bitcoin/master e567713 practicalswift: Do not use uppercase characters in source code filenames 05:03 < bitcoin-git> bitcoin/master b22115d MarcoFalke: Merge #13312: docs: Add a note about the source code filename naming convention... 05:04 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #13312: docs: Add a note about the source code filename naming convention (master...lowercase-filenames) https://github.com/bitcoin/bitcoin/pull/13312 05:06 -!- laurentmt [~Thunderbi@185.94.189.189] has quit [Ping timeout: 256 seconds] 05:07 -!- indistylo [~indistylo@119.82.105.106] has joined #bitcoin-core-dev 05:09 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 05:28 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds] 05:45 < fanquake> I guess one slightly annoying limitation of the linters is that upstream changes can't be tested in /bitcoin 05:45 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Read error: Connection reset by peer] 05:45 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 05:53 < wumpus> yes 05:54 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b22115d9a3b0...5315660baef0 05:54 < bitcoin-git> bitcoin/master fa8071a MarcoFalke: qa: Log as utf-8 05:54 < bitcoin-git> bitcoin/master 5315660 Wladimir J. van der Laan: Merge #13440: qa: Log as utf-8... 05:55 < bitcoin-git> [bitcoin] laanwj closed pull request #13440: qa: Log as utf-8 (master...Mf1806-qaLogUtf8) https://github.com/bitcoin/bitcoin/pull/13440 05:57 < fanquake> wumpus See #13444, I don't think that's something we want to do? 05:57 < gribble> https://github.com/bitcoin/bitcoin/issues/13444 | depends: bump openssl to 1.0.2o by edsgerlin · Pull Request #13444 · bitcoin/bitcoin · GitHub 06:00 < wumpus> fanquake: will have a look 06:00 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 06:05 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 268 seconds] 06:07 < wumpus> fanquake: so the only thing affected by the OpenSSL version in depends is pretty much qt nowadays, right? 06:08 < wumpus> I tend to agree with you that it is unnecessary 06:08 < wumpus> (assuming that there has been no security issue that necessitates it) 06:09 < fanquake> wumpus Looking at the release notes, basically every major change in the 1.0.2 series is a CVE 06:12 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 06:12 < wumpus> seems like a nightmare to keep track of 06:12 -!- jouke [~jouke@a80-100-203-151.adsl.xs4all.nl] has quit [Remote host closed the connection] 06:13 -!- berndj [~berndj@197.242.93.82] has quit [Quit: ZNC - http://znc.in] 06:13 < wumpus> maybe "update to most recent version" isn't that bad an idea, periodically, I don't know... 06:13 < fanquake> tbh I prefer the "drop the requirement for OpenSSL entirely" idea :p 06:14 < fanquake> There have been a few shots at that in the past, but never merged for various reasons. 06:14 -!- berndj [~berndj@197.242.93.82] has joined #bitcoin-core-dev 06:16 < wumpus> for the core it's doable, but dropping the requirement from the GUI doesn't seem feasible to me, besides replacing it with some alternative SSL library (qt supports some) but I'm not sure that's better... 06:17 < wumpus> e.g. on windows, qt can use the native SSL support, so wouldn't strictly need OpenSSL - but that doesn't sound too great to me either... 06:17 < fanquake> Especially given the seeming lack of people we have testing anything on Windows 06:19 < wumpus> that, too 06:19 -!- m8tion [~Agence@abo-134-110-68.mrs.modulonet.fr] has joined #bitcoin-core-dev 06:19 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 06:19 < wumpus> also the GUI code does some juggling with certificates that doesn't go through the Qt crypto API, so is OpenSSL specific 06:19 < wumpus> it doesn't feel really worth working on 06:21 < wumpus> in a bizarre twist of fate, I was working on a deprecation plan for payment requests, which would have solved this problem once and for all, but then bitpay announced they will *only* support it from then on. 06:22 < fanquake> heh 06:22 < fanquake> I remember that 06:22 < fanquake> #11622 06:22 < gribble> https://github.com/bitcoin/bitcoin/issues/11622 | build: Add --disable-bip70 configure option by laanwj · Pull Request #11622 · bitcoin/bitcoin · GitHub 06:23 < wumpus> that took all of the wind out of my sails in that regard 06:23 < wumpus> yes that one 06:24 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 06:25 < fanquake> I noticed that currently 1/3 of all PRs "need a rebase" 06:30 -!- juX0 [81380c01@gateway/web/freenode/ip.129.56.12.1] has joined #bitcoin-core-dev 06:30 < wumpus> is:pr is:open -label:"needs rebase" 06:31 < fanquake> that indeed 06:31 < wumpus> or let's go nag some people, at least if it's PRs likely to be merged otherwise 06:33 < wumpus> it looks like most conflicts were caused by build system changes, as well as the txindex refactor 06:36 -!- juX0 [81380c01@gateway/web/freenode/ip.129.56.12.1] has quit [Ping timeout: 260 seconds] 06:37 < fanquake> wumpus: wouldn't dare nag anyone :p 06:38 < wumpus> :p 06:45 < wumpus> any opinions on when we should tag 0.16.1 final? 06:46 < fanquake> Did anything happen for the assert on Windows? 06:47 < wumpus> not that I know of - rc2 was just a translation fix 06:49 < wumpus> you mean #13358? that doesn't seem to be a regression in 0.16.1 06:49 < gribble> https://github.com/bitcoin/bitcoin/issues/13358 | Assertion failed Error file chain.cpp 102 · Issue #13358 · bitcoin/bitcoin · GitHub 06:54 < fanquake> wumpus I thought there was another one on shutdown, but have just installed rc2 onto Windows 10 and no longer see it 06:56 < fanquake> cfields You might be interested, some new output I'm seeing after upgrading to Command Line Tools 10.0 https://0bin.net/paste/2iaLr12c+Q-4rlmS#lexGszZqOKn07pwYKQvTKYGgCBTkDPKGnlCo5PjbGTV 06:57 < fanquake> wumpus #12337 06:57 < gribble> https://github.com/bitcoin/bitcoin/issues/12337 | 0.16 Shutdown assertion · Issue #12337 · bitcoin/bitcoin · GitHub 06:58 < fanquake> However seems like that doesn't need to hold up a 0.16.1 07:03 -!- drizztbsd is now known as timothy 07:06 -!- qrestlove [~qrestlove@2605:6000:eb4a:ef00:454f:112b:9095:f0ea] has quit [Ping timeout: 245 seconds] 07:15 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 07:16 -!- qrestlove [~qrestlove@2605:6000:eb4a:ef00:454f:112b:9095:f0ea] has joined #bitcoin-core-dev 07:17 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit] 07:37 < jnewbery> Review beg for #13066. We haven't run successfully run the extended tests or verify-commits in Travis for over two months and that would fix it 07:37 < gribble> https://github.com/bitcoin/bitcoin/issues/13066 | Migrate verify-commits script to python, run in travis by ken2812221 · Pull Request #13066 · bitcoin/bitcoin · GitHub 08:00 -!- jcohen [~jcohen@rrcs-67-251-193-154.nyc.biz.rr.com] has joined #bitcoin-core-dev 08:17 < wumpus> jnewbery: will take a look 08:19 < wumpus> kind of forgot about that one 08:19 < jnewbery> great. Thanks! 08:21 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/5315660baef0...ca2a23387be6 08:21 < bitcoin-git> bitcoin/master fa7a6cf MarcoFalke: policy: Treat segwit as always active 08:21 < bitcoin-git> bitcoin/master ca2a233 Wladimir J. van der Laan: Merge #13120: policy: Treat segwit as always active... 08:21 < bitcoin-git> [bitcoin] laanwj closed pull request #13120: policy: Treat segwit as always active (master...Mf1805-segwitGenesisPolicy) https://github.com/bitcoin/bitcoin/pull/13120 08:25 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/ca2a23387be6...fa4b9065a829 08:25 < bitcoin-git> bitcoin/master e5b2cd8 Chun Kuan Lee: Use python instead of slow shell script on verify-commits 08:25 < bitcoin-git> bitcoin/master fa4b906 Wladimir J. van der Laan: Merge #13066: Migrate verify-commits script to python, run in travis... 08:26 -!- satwo [~textual@2602:306:378a:6fb0:b0ae:4918:7bbb:fca9] has joined #bitcoin-core-dev 08:26 < bitcoin-git> [bitcoin] laanwj closed pull request #13066: Migrate verify-commits script to python, run in travis (master...verify-commits) https://github.com/bitcoin/bitcoin/pull/13066 08:28 < BlueMatt> wumpus: errr, did anyone else even review that? 08:28 < BlueMatt> else besides jnewbery, that is 08:28 < wumpus> yes, I reviewed it a long time ago 08:29 < BlueMatt> hmm, can you comment to that effect? I only see a concept ack from you on there 08:29 < wumpus> checked that it still was more or less the same 08:29 < wumpus> you didn't lookv ery well, there's an utACK from me in that topic too 08:30 < wumpus> apr 27 08:30 < BlueMatt> ah, ok, still wish we'd gotten more than 2 reviews with one pretty old on something thats designed to be usable to verify repo consistency 08:31 -!- satwo [~textual@2602:306:378a:6fb0:b0ae:4918:7bbb:fca9] has quit [Ping timeout: 255 seconds] 08:31 < wumpus> well at least it makes checking feasible again 08:31 < jnewbery> post-merge reviews welcome :) 08:31 < wumpus> no one was checking because the script was unusably slow 08:31 < BlueMatt> jnewbery: I dont feel comfortable reviewing security python, sadly 08:32 < BlueMatt> yes, indeed, better than it not getting run, which is apparently what was happening :( 08:32 < wumpus> FWIW, I'm 100% more comfortable reviewing python than shell script 08:32 < BlueMatt> heh, yes, I understand I'm like the only one left who prefers bash to python 08:32 < wumpus> there's just too much icky edge cases in shell script for me to be comfortable about it 08:32 < BlueMatt> lets just move everything to C :p 08:32 < wumpus> (like oh no, you forget to use the right quoting, now everything with spaces will escape.. and similar things) 08:33 < wumpus> feel free to rewrite it in C :p 08:33 < wumpus> it'd likely be even faster 08:33 < BlueMatt> lol, then it'd *actually* be usably fast 08:33 < BlueMatt> maybe I'll rewrite it in rust :p 08:33 < wumpus> hehe 08:33 < wumpus> yes that'd be cool 08:33 * BlueMatt has way too many rust projects now 08:33 < BlueMatt> I mean I've got a whole multi-daemon pool server and proxies in rust 08:34 < jnewbery> well, if anyone else knows python well enough to review #13066, I'm sure BlueMatt will appreciate your postmerge ACKs 08:34 < gribble> https://github.com/bitcoin/bitcoin/issues/13066 | Migrate verify-commits script to python, run in travis by ken2812221 · Pull Request #13066 · bitcoin/bitcoin · GitHub 08:35 < wumpus> yes, it's always good to have more review, also of code already merged 08:45 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [] 08:48 < bitcoin-git> [bitcoin] ken2812221 opened pull request #13447: travis: Increase travis_wait time while verifying commits (master...patch-1) https://github.com/bitcoin/bitcoin/pull/13447 08:50 -!- grafcaps [~haroldbr@50.90.83.229] has quit [Ping timeout: 240 seconds] 08:51 < bitcoin-git> [bitcoin] practicalswift opened pull request #13448: Add linter: Make sure we explicitly open all text files using UTF-8 encoding in Python (master...lint-python-utf8-encoding) https://github.com/bitcoin/bitcoin/pull/13448 08:53 < promag> #13111 is ready for review 08:53 < gribble> https://github.com/bitcoin/bitcoin/issues/13111 | Add unloadwallet RPC by promag · Pull Request #13111 · bitcoin/bitcoin · GitHub 08:56 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 09:07 -!- grafcaps [~haroldbr@104.137.194.255] has joined #bitcoin-core-dev 09:08 -!- joshb[m] [joshbmatri@gateway/shell/matrix.org/x-otqowxpbyjvwzgnj] has quit [Remote host closed the connection] 09:08 -!- squarfed[m] [squarfedma@gateway/shell/matrix.org/x-mhpbxniircspbqkv] has quit [Remote host closed the connection] 09:08 -!- herzmeister[m] [herzmeiste@gateway/shell/matrix.org/x-mdbszqmnrzmtfznz] has quit [Remote host closed the connection] 09:08 -!- stepa[m] [stepamatri@gateway/shell/matrix.org/x-xkcyrhrwadzcdwjw] has quit [Remote host closed the connection] 09:08 -!- ajtowns[m] [ajtownsmat@gateway/shell/matrix.org/x-hlcgxtxnghrzivcd] has quit [Read error: Connection reset by peer] 09:08 -!- kewde[m] [kewdematri@gateway/shell/matrix.org/x-smctrzmbmubdenxb] has quit [Write error: Connection reset by peer] 09:11 -!- schnerchi [~schnerchi@static.120.187.99.88.clients.your-server.de] has quit [Ping timeout: 268 seconds] 09:13 -!- schnerchi [~schnerchi@2a01:4f8:c0c:afe::2] has joined #bitcoin-core-dev 09:32 -!- kewde[m] [kewdematri@gateway/shell/matrix.org/x-hwwodtpquxokuqyn] has joined #bitcoin-core-dev 09:45 -!- goatpig [56f75200@gateway/web/freenode/ip.86.247.82.0] has joined #bitcoin-core-dev 09:46 -!- herzmeister[m] [herzmeiste@gateway/shell/matrix.org/x-kqmakwrpepypbyyd] has joined #bitcoin-core-dev 09:46 -!- ajtowns[m] [ajtownsmat@gateway/shell/matrix.org/x-gzrxesnwlthmpref] has joined #bitcoin-core-dev 09:46 -!- joshb[m] [joshbmatri@gateway/shell/matrix.org/x-qouqhaoicpruqylu] has joined #bitcoin-core-dev 09:46 -!- stepa[m] [stepamatri@gateway/shell/matrix.org/x-nsblcikxhiwiirzo] has joined #bitcoin-core-dev 09:46 -!- squarfed[m] [squarfedma@gateway/shell/matrix.org/x-kozuflulcphfqzyj] has joined #bitcoin-core-dev 09:49 -!- jtimon [~quassel@40.28.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 09:51 -!- rrrrr_ [d592d40f@gateway/web/freenode/ip.213.146.212.15] has joined #bitcoin-core-dev 09:52 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/fa4b9065a829...a607d23ae82e 09:52 < bitcoin-git> bitcoin/master 57ba401 Pieter Wuille: Enable double-SHA256-for-64-byte code on 32-bit x86 09:52 < bitcoin-git> bitcoin/master a607d23 Wladimir J. van der Laan: Merge #13393: Enable double-SHA256-for-64-byte code on 32-bit x86... 09:53 < bitcoin-git> [bitcoin] laanwj closed pull request #13393: Enable double-SHA256-for-64-byte code on 32-bit x86 (master...201806_dsha256_i386) https://github.com/bitcoin/bitcoin/pull/13393 10:01 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 10:05 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 245 seconds] 10:06 -!- nmnkgl [~nmnkgl@c-73-189-35-88.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 10:17 -!- rrrrr_ [d592d40f@gateway/web/freenode/ip.213.146.212.15] has quit [Quit: Page closed] 10:18 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 10:19 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 10:19 -!- promag [~promag@83.223.233.157] has joined #bitcoin-core-dev 10:25 -!- Sinclair6 [sinclair6@gateway/vpn/privateinternetaccess/sinclair6] has quit [Ping timeout: 276 seconds] 10:33 -!- m8tion [~Agence@abo-134-110-68.mrs.modulonet.fr] has quit [Read error: Connection reset by peer] 10:35 < promag> MarcoFalke: how about a "dormant" label, automatically added for something not updated for X days (either github or git)? 10:45 -!- nekotribal [~nekotriba@host-89-230-96-42.dynamic.mm.pl] has quit [Remote host closed the connection] 10:46 -!- nekotribal [~nekotriba@host-89-230-96-42.dynamic.mm.pl] has joined #bitcoin-core-dev 10:48 -!- ctrlbreak [~ctrlbreak@142.162.42.47] has quit [Ping timeout: 264 seconds] 10:49 -!- ctrlbreak [~ctrlbreak@142.162.42.47] has joined #bitcoin-core-dev 10:53 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has joined #bitcoin-core-dev 10:59 -!- indistylo [~indistylo@119.82.105.106] has quit [Ping timeout: 260 seconds] 11:03 -!- Cory [~Cory@unaffiliated/cory] has quit [Ping timeout: 276 seconds] 11:07 -!- promag [~promag@83.223.233.157] has quit [Remote host closed the connection] 11:08 -!- Pasha [~Cory@unaffiliated/cory] has joined #bitcoin-core-dev 11:11 -!- Pasha is now known as Cory 11:14 < bitcoin-git> [bitcoin] instagibbs opened pull request #13449: [WIP] support new multisig template in wallet for Solver, signing, and sign… (master...largemultisig) https://github.com/bitcoin/bitcoin/pull/13449 11:24 -!- Cory [~Cory@unaffiliated/cory] has quit [Ping timeout: 276 seconds] 11:29 -!- Pasha [~Cory@unaffiliated/cory] has joined #bitcoin-core-dev 11:30 < luke-jr> #12859 seems to not be in 0.16.1 rc2? 11:30 < gribble> https://github.com/bitcoin/bitcoin/issues/12859 | Bugfix: Include for std::unique_ptr by luke-jr · Pull Request #12859 · bitcoin/bitcoin · GitHub 11:32 -!- Pasha is now known as Cory 11:42 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 11:42 < luke-jr> wumpus: ^ 11:46 -!- nmnkgl [~nmnkgl@c-73-189-35-88.hsd1.ca.comcast.net] has quit [Remote host closed the connection] 11:47 -!- nmnkgl [~nmnkgl@c-73-189-35-88.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 11:51 -!- nmnkgl [~nmnkgl@c-73-189-35-88.hsd1.ca.comcast.net] has quit [Ping timeout: 264 seconds] 11:53 -!- Sinclair6 [sinclair6@gateway/vpn/privateinternetaccess/sinclair6] has joined #bitcoin-core-dev 11:56 -!- indistylo [~indistylo@106.51.31.174] has joined #bitcoin-core-dev 11:58 -!- nmnkgl [~nmnkgl@c-73-189-35-88.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 12:06 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 12:08 -!- cubancorona [cubancoron@gateway/vpn/privateinternetaccess/cubancorona] has joined #bitcoin-core-dev 12:11 -!- jcohen [~jcohen@rrcs-67-251-193-154.nyc.biz.rr.com] has quit [Ping timeout: 260 seconds] 12:15 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 12:15 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 12:19 -!- cubancorona [cubancoron@gateway/vpn/privateinternetaccess/cubancorona] has quit [Ping timeout: 240 seconds] 12:20 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 12:32 < wumpus> luke-jr: it was also not tagged as such 12:33 * luke-jr doesn't do the tagging XD 12:34 < wumpus> you could have mentioned it, at least 12:34 < luke-jr> just did 12:35 * luke-jr wonders how wide this affects 12:35 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 12:37 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 12:37 < luke-jr> seems like Ubuntu doesn't have Qt 5.10 yet, but Debian testing does 12:38 < luke-jr> dunno how to check Fedora 12:39 < luke-jr> Arch has 5.11 12:51 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 13:02 -!- indistylo [~indistylo@106.51.31.174] has quit [Ping timeout: 240 seconds] 13:03 < bitcoin-git> [bitcoin] practicalswift opened pull request #13450: Add linter: Enforce the source code file naming convention described in the developer notes (master...lint-filenames) https://github.com/bitcoin/bitcoin/pull/13450 13:09 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 13:19 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 13:32 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 13:34 -!- nmnkgl [~nmnkgl@c-73-189-35-88.hsd1.ca.comcast.net] has quit [Remote host closed the connection] 13:34 -!- nmnkgl [~nmnkgl@c-73-189-35-88.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 13:35 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 13:35 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 13:38 -!- nmnkgl [~nmnkgl@c-73-189-35-88.hsd1.ca.comcast.net] has quit [Ping timeout: 248 seconds] 13:39 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 245 seconds] 13:47 < bitcoin-git> [bitcoin] instagibbs opened pull request #13451: expose CBlockIndex::nTx in getblockheader (master...expose_nTx) https://github.com/bitcoin/bitcoin/pull/13451 13:49 -!- joshb[m] [joshbmatri@gateway/shell/matrix.org/x-qouqhaoicpruqylu] has quit [Remote host closed the connection] 13:49 -!- herzmeister[m] [herzmeiste@gateway/shell/matrix.org/x-kqmakwrpepypbyyd] has quit [Write error: Connection reset by peer] 13:49 -!- kewde[m] [kewdematri@gateway/shell/matrix.org/x-hwwodtpquxokuqyn] has quit [Read error: Connection reset by peer] 13:49 -!- ajtowns[m] [ajtownsmat@gateway/shell/matrix.org/x-gzrxesnwlthmpref] has quit [Read error: Connection reset by peer] 13:49 -!- squarfed[m] [squarfedma@gateway/shell/matrix.org/x-kozuflulcphfqzyj] has quit [Remote host closed the connection] 13:49 -!- stepa[m] [stepamatri@gateway/shell/matrix.org/x-nsblcikxhiwiirzo] has quit [Read error: Connection reset by peer] 13:49 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 13:52 < luke-jr> #13120 should probably be backported too 13:52 < gribble> https://github.com/bitcoin/bitcoin/issues/13120 | policy: Treat segwit as always active by MarcoFalke · Pull Request #13120 · bitcoin/bitcoin · GitHub 13:53 < luke-jr> perhaps simplified 14:03 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has quit [Quit: drexl] 14:06 -!- herzmeister[m] [herzmeiste@gateway/shell/matrix.org/x-cewjyysnjwufonas] has joined #bitcoin-core-dev 14:15 -!- nmnkgl [~nmnkgl@c-73-189-35-88.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 14:16 < bitcoin-git> [bitcoin] instagibbs opened pull request #13452: have verifytxoutproof check the number of txns in proof structure (master...actuallyverifytxoutproof) https://github.com/bitcoin/bitcoin/pull/13452 14:18 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has joined #bitcoin-core-dev 14:20 -!- nmnkgl [~nmnkgl@c-73-189-35-88.hsd1.ca.comcast.net] has quit [Ping timeout: 276 seconds] 14:22 -!- kewde[m] [kewdematri@gateway/shell/matrix.org/x-qtzrwdlqxfvxszfq] has joined #bitcoin-core-dev 14:22 -!- stepa[m] [stepamatri@gateway/shell/matrix.org/x-fyqloksfcktgwjmk] has joined #bitcoin-core-dev 14:22 -!- joshb[m] [joshbmatri@gateway/shell/matrix.org/x-mhykswxjzstnkiaf] has joined #bitcoin-core-dev 14:22 -!- ajtowns[m] [ajtownsmat@gateway/shell/matrix.org/x-cbizhjwzzpkxwlla] has joined #bitcoin-core-dev 14:22 -!- squarfed[m] [squarfedma@gateway/shell/matrix.org/x-cpzascjjsrvsdkoh] has joined #bitcoin-core-dev 14:23 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 255 seconds] 14:25 -!- Kevinho669 [acdd3da1@gateway/web/freenode/ip.172.221.61.161] has joined #bitcoin-core-dev 14:32 -!- Kevinho669 [acdd3da1@gateway/web/freenode/ip.172.221.61.161] has quit [Ping timeout: 260 seconds] 14:37 -!- bitconner [~conner@64-71-8-130.static.wiline.com] has joined #bitcoin-core-dev 14:41 -!- jcohen [~jcohen@pool-68-132-228-60.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 14:52 -!- bitconner [~conner@64-71-8-130.static.wiline.com] has quit [Ping timeout: 260 seconds] 14:52 -!- jcohen [~jcohen@pool-68-132-228-60.nycmny.fios.verizon.net] has quit [Ping timeout: 260 seconds] 14:54 -!- nmnkgl [~nmnkgl@c-73-189-35-88.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 15:01 -!- Cogito_Ergo_Sum [~Myself@athedsl-314623.home.otenet.gr] has joined #bitcoin-core-dev 15:01 -!- Cogito_Ergo_Sum [~Myself@athedsl-314623.home.otenet.gr] has quit [Changing host] 15:01 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has joined #bitcoin-core-dev 15:13 -!- jojeyh [~delphi@2602:306:b8b6:b970:49d7:a276:ad07:b8a7] has quit [Ping timeout: 276 seconds] 15:16 -!- Cogito_Ergo_Sum [~Myself@unaffiliated/cogito-ergo-sum/x-7399460] has quit [] 15:23 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 240 seconds] 15:35 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 15:38 -!- bitconner [~conner@64-71-8-130.static.wiline.com] has joined #bitcoin-core-dev 15:43 -!- Anduck [~Anduck@unaffiliated/anduck] has joined #bitcoin-core-dev 15:46 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 16:14 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 16:15 -!- herzmeister[m] [herzmeiste@gateway/shell/matrix.org/x-cewjyysnjwufonas] has quit [Remote host closed the connection] 16:15 -!- kewde[m] [kewdematri@gateway/shell/matrix.org/x-qtzrwdlqxfvxszfq] has quit [Read error: Connection reset by peer] 16:16 -!- stepa[m] [stepamatri@gateway/shell/matrix.org/x-fyqloksfcktgwjmk] has quit [Remote host closed the connection] 16:17 -!- squarfed[m] [squarfedma@gateway/shell/matrix.org/x-cpzascjjsrvsdkoh] has quit [Remote host closed the connection] 16:17 -!- joshb[m] [joshbmatri@gateway/shell/matrix.org/x-mhykswxjzstnkiaf] has quit [Remote host closed the connection] 16:17 -!- ajtowns[m] [ajtownsmat@gateway/shell/matrix.org/x-cbizhjwzzpkxwlla] has quit [Remote host closed the connection] 16:28 -!- evenzhou [~evenzhou@106.124.36.247] has joined #bitcoin-core-dev 16:30 -!- nekotribal [~nekotriba@host-89-230-96-42.dynamic.mm.pl] has quit [Ping timeout: 268 seconds] 16:32 -!- herzmeister[m] [herzmeiste@gateway/shell/matrix.org/x-zxgqgptsidvehhya] has joined #bitcoin-core-dev 16:35 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 16:36 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has quit [Quit: drexl] 16:40 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 16:47 -!- kewde[m] [kewdematri@gateway/shell/matrix.org/x-ggmzrtxoitvfqhpq] has joined #bitcoin-core-dev 16:47 -!- ajtowns[m] [ajtownsmat@gateway/shell/matrix.org/x-uuprxnivwjifctut] has joined #bitcoin-core-dev 16:47 -!- joshb[m] [joshbmatri@gateway/shell/matrix.org/x-cfiaerrvhttkopfv] has joined #bitcoin-core-dev 16:47 -!- stepa[m] [stepamatri@gateway/shell/matrix.org/x-yphrhrvlkyrckvzz] has joined #bitcoin-core-dev 16:47 -!- squarfed[m] [squarfedma@gateway/shell/matrix.org/x-sjzlpnegxqdujaop] has joined #bitcoin-core-dev 16:52 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 17:02 -!- Sinclair6 [sinclair6@gateway/vpn/privateinternetaccess/sinclair6] has quit [Ping timeout: 268 seconds] 17:07 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 276 seconds] 17:09 -!- indistylo [~indistylo@106.51.31.174] has joined #bitcoin-core-dev 17:15 -!- evenzhou [~evenzhou@106.124.36.247] has quit [Remote host closed the connection] 17:15 -!- evenzhou [~evenzhou@106.124.36.247] has joined #bitcoin-core-dev 17:23 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 276 seconds] 17:24 -!- evenzhou_ [~evenzhou@106.124.36.247] has joined #bitcoin-core-dev 17:27 -!- evenzhou [~evenzhou@106.124.36.247] has quit [Ping timeout: 256 seconds] 17:33 -!- snickerfritz [~snickerfr@unaffiliated/snickerfritz] has joined #bitcoin-core-dev 17:35 -!- grafcaps [~haroldbr@104.137.194.255] has quit [Ping timeout: 264 seconds] 17:46 -!- grafcaps [~haroldbr@50.90.83.229] has joined #bitcoin-core-dev 18:04 -!- nmnkgl [~nmnkgl@c-73-189-35-88.hsd1.ca.comcast.net] has quit [Remote host closed the connection] 18:04 -!- nmnkgl [~nmnkgl@c-73-189-35-88.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 18:09 -!- nmnkgl [~nmnkgl@c-73-189-35-88.hsd1.ca.comcast.net] has quit [Ping timeout: 248 seconds] 18:11 < bitcoin-git> [bitcoin] edsgerlin closed pull request #13444: depends: bump openssl to 1.0.2o (master...patch-1) https://github.com/bitcoin/bitcoin/pull/13444 18:23 < gmaxwell> man I dred reviewing openssl patches. 18:23 < gmaxwell> dread* 18:24 < gmaxwell> lol I see other people complaining on the PR. 18:32 -!- snickerfritz [~snickerfr@unaffiliated/snickerfritz] has quit [Remote host closed the connection] 18:39 -!- nmnkgl [~nmnkgl@c-73-189-35-88.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 18:43 -!- nmnkgl [~nmnkgl@c-73-189-35-88.hsd1.ca.comcast.net] has quit [Ping timeout: 240 seconds] 18:45 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Ping timeout: 265 seconds] 18:50 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 18:59 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 19:03 -!- cubancorona [cubancoron@gateway/vpn/privateinternetaccess/cubancorona] has joined #bitcoin-core-dev 19:03 -!- cubancorona [cubancoron@gateway/vpn/privateinternetaccess/cubancorona] has quit [Remote host closed the connection] 19:10 -!- booyah_ [~bb@193.25.1.157] has quit [Read error: Connection reset by peer] 19:26 -!- Krellan_ [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 19:30 -!- Krellan_ [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Ping timeout: 248 seconds] 19:30 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Ping timeout: 264 seconds] 19:43 -!- jcohen [~jcohen@pool-68-132-228-60.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 19:50 -!- satwo [~textual@2602:306:378a:6fb0:b0ae:4918:7bbb:fca9] has joined #bitcoin-core-dev 19:51 -!- satwo [~textual@2602:306:378a:6fb0:b0ae:4918:7bbb:fca9] has quit [Client Quit] 19:52 -!- twistedline [~quassel@unaffiliated/twistedline] has quit [Ping timeout: 245 seconds] 19:54 -!- jcohen [~jcohen@pool-68-132-228-60.nycmny.fios.verizon.net] has quit [Ping timeout: 268 seconds] 19:59 -!- twistedline [~quassel@unaffiliated/twistedline] has joined #bitcoin-core-dev 20:08 -!- delphi [~delphi@2602:306:b8b6:b970:49d7:a276:ad07:b8a7] has joined #bitcoin-core-dev 20:09 -!- delphi is now known as Guest57855 20:15 -!- nmnkgl [~nmnkgl@c-73-189-35-88.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 20:16 -!- ToURniQue [~ToURiQue@pool-72-90-249-67.nwrknj.east.verizon.net] has joined #bitcoin-core-dev 20:20 -!- nmnkgl [~nmnkgl@c-73-189-35-88.hsd1.ca.comcast.net] has quit [Ping timeout: 265 seconds] 20:21 -!- Guest57855 [~delphi@2602:306:b8b6:b970:49d7:a276:ad07:b8a7] has quit [Ping timeout: 276 seconds] 20:21 -!- twistedline [~quassel@unaffiliated/twistedline] has quit [Ping timeout: 260 seconds] 20:22 -!- indistylo [~indistylo@106.51.31.174] has quit [Ping timeout: 276 seconds] 20:24 -!- twistedline [~quassel@unaffiliated/twistedline] has joined #bitcoin-core-dev 20:46 -!- bitconner [~conner@64-71-8-130.static.wiline.com] has quit [Ping timeout: 260 seconds] 21:03 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 21:04 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 21:06 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 21:10 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 264 seconds] 21:14 -!- grafcaps [~haroldbr@50.90.83.229] has quit [Ping timeout: 256 seconds] 21:20 -!- jojeyh [~delphi@2602:306:b8b6:b970:f9b2:9de4:382b:3986] has joined #bitcoin-core-dev 21:27 -!- indistylo [~indistylo@119.82.105.106] has joined #bitcoin-core-dev 21:31 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev 22:04 -!- nmnkgl [~nmnkgl@c-73-189-35-88.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 22:08 -!- nmnkgl [~nmnkgl@c-73-189-35-88.hsd1.ca.comcast.net] has quit [Ping timeout: 256 seconds] 22:18 -!- grafcaps [~haroldbr@50.90.83.229] has joined #bitcoin-core-dev 22:50 -!- satwo [~textual@2602:306:378a:6fb0:91ad:d679:86c6:8ea1] has joined #bitcoin-core-dev 22:55 < bitcoin-git> [bitcoin] practicalswift opened pull request #13454: Add linter: Make sure LC_ALL=C is set when using grep range expressions (master...avoid-locale-dependent-range-expressions) https://github.com/bitcoin/bitcoin/pull/13454 23:02 -!- meng [dc98683e@gateway/web/freenode/ip.220.152.104.62] has joined #bitcoin-core-dev 23:06 -!- iwkse [~iwkse@unaffiliated/iwkse] has quit [Ping timeout: 240 seconds] 23:16 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 23:16 -!- satwo [~textual@2602:306:378a:6fb0:91ad:d679:86c6:8ea1] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 23:17 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 23:29 -!- nekotribal [~nekotriba@host-89-230-96-42.dynamic.mm.pl] has joined #bitcoin-core-dev 23:31 -!- Krellan [~Krellan@2600:1700:be50:3230:b020:5d59:3ac7:6c40] has joined #bitcoin-core-dev 23:35 -!- meng [dc98683e@gateway/web/freenode/ip.220.152.104.62] has quit [Quit: Page closed] 23:36 -!- Krellan [~Krellan@2600:1700:be50:3230:b020:5d59:3ac7:6c40] has quit [Ping timeout: 255 seconds] 23:52 -!- nmnkgl [~nmnkgl@c-73-189-35-88.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 23:56 -!- nmnkgl [~nmnkgl@c-73-189-35-88.hsd1.ca.comcast.net] has quit [Ping timeout: 260 seconds]