--- Log opened Wed Jul 18 00:00:14 2018
00:38 -!- grafcaps [~haroldbr@050-090-083-229.res.spectrum.com] has joined #bitcoin-core-dev
00:39 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev
00:42 -!- grafcaps [~haroldbr@050-090-083-229.res.spectrum.com] has quit [Ping timeout: 245 seconds]
00:46 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev
00:52 < wumpus> AHemlocksLie: for finding issues to start with, see https://github.com/bitcoin/bitcoin/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
00:54 < fanquake> wumpus #13692 Should be mergeable
00:54 < gribble> https://github.com/bitcoin/bitcoin/issues/13692 | contrib: Clone core repo in gitian-build by MarcoFalke · Pull Request #13692 · bitcoin/bitcoin · GitHub
00:56 < gmaxwell> kallewoof: if it's any consolation, it's better for a transaction to spend b,c  than it is for two different transactions to spend a and a,b     the 'merging' of coin paths is a lot less harmful to privacy than the splitting of it.
00:59 < kallewoof> gmaxwell: Yeah, I guess that's an improvement too.
01:05 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev
01:17 < provoostenator> sipa: thanks, I didn't realize gists don't do notifications. Maybe Microsoft can fix that :-)
01:21 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev
01:25 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection]
01:33 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev
01:34 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection]
01:47 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev
01:58 -!- Krellan [~Krellan@2601:640:4000:9258:1da5:3584:1e53:4e3a] has quit [Read error: Connection reset by peer]
01:59 -!- Krellan [~Krellan@2601:640:4000:9258:1da5:3584:1e53:4e3a] has joined #bitcoin-core-dev
02:15 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev
02:30 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection]
02:34 -!- ken2812221 [~ken281222@1.200.202.10] has quit [Remote host closed the connection]
02:35 -!- ken2812221 [~ken281222@1.200.202.10] has joined #bitcoin-core-dev
02:37 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev
02:45 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection]
02:53 -!- Deinogalerix21 [~Deinogale@185.169.255.9] has joined #bitcoin-core-dev
02:53 -!- Deinogalerix21 [~Deinogale@185.169.255.9] has quit [Client Quit]
02:54 -!- Deinogalerix21 [~Deinogale@185.169.255.9] has joined #bitcoin-core-dev
02:57 < wumpus> fanquake: looks like it, thanks
02:57 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c01ab133d7ae...f5d166acf909
02:57 < bitcoin-git> bitcoin/master fa7f8a7 MarcoFalke: contrib: Clone core repo in gitian-build
02:57 < bitcoin-git> bitcoin/master f5d166a Wladimir J. van der Laan: Merge #13692: contrib: Clone core repo in gitian-build...
02:58 -!- Deinogalerix21 [~Deinogale@185.169.255.9] has quit [Client Quit]
02:58 < bitcoin-git> [bitcoin] laanwj closed pull request #13692: contrib: Clone core repo in gitian-build (master...Mf1807-contribGitianBuild) https://github.com/bitcoin/bitcoin/pull/13692
03:01 < fanquake> wumpus also #13699 and I think 13672
03:01 < gribble> https://github.com/bitcoin/bitcoin/issues/13699 | contrib: correct version check by kallewoof · Pull Request #13699 · bitcoin/bitcoin · GitHubAsset 1Asset 1
03:08 -!- Deinogalerix21 [~Deinogale@185.169.255.9] has joined #bitcoin-core-dev
03:08 < fanquake> Also 13625 and 13633 heh
03:19 -!- Deinogalerix21 [~Deinogale@185.169.255.9] has quit [Quit: WeeChat 2.2]
03:22 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 260 seconds]
03:25 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev
03:36 < bitcoin-git> [bitcoin] Sjors opened pull request #13702: Update cross compilation dependencies for Bionic, clarify depends usage (master...2018/07/bionic-depends-docs) https://github.com/bitcoin/bitcoin/pull/13702
03:41 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection]
03:42 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev
03:47 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 240 seconds]
03:53 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
04:07 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev
04:08 -!- Krellan [~Krellan@2601:640:4000:9258:1da5:3584:1e53:4e3a] has quit [Read error: Connection reset by peer]
04:09 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev
04:09 -!- Krellan [~Krellan@2601:640:4000:9258:1da5:3584:1e53:4e3a] has joined #bitcoin-core-dev
04:09 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
04:09 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 264 seconds]
04:11 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
04:14 -!- grafcaps [~haroldbr@050-090-083-229.res.spectrum.com] has joined #bitcoin-core-dev
04:15 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 240 seconds]
04:16 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev
04:17 -!- ctrlbreak [~ctrlbreak@142.162.42.47] has quit [Ping timeout: 265 seconds]
04:19 -!- grafcaps [~haroldbr@050-090-083-229.res.spectrum.com] has quit [Ping timeout: 256 seconds]
04:21 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 256 seconds]
04:21 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev
04:29 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection]
04:29 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 244 seconds]
04:29 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev
04:34 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Ping timeout: 260 seconds]
04:43 -!- ctrlbreak [~ctrlbreak@142.162.42.47] has joined #bitcoin-core-dev
04:50 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev
04:57 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection]
04:58 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
05:03 < fanquake> Have added #13247 to the 0.17.0 milestone, it's doc additions and a test that was split out of #13023.
05:03 < gribble> https://github.com/bitcoin/bitcoin/issues/13023 | Fix some concurrency issues in ActivateBestChain() by skeees · Pull Request #13023 · bitcoin/bitcoin · GitHub
05:03 < gribble> https://github.com/bitcoin/bitcoin/issues/13247 | Add tests to SingleThreadedSchedulerClient() and document the memory model by skeees · Pull Request #13247 · bitcoin/bitcoin · GitHub
05:08 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 256 seconds]
05:27 -!- m8tion [~Agence@abo-134-110-68.mrs.modulonet.fr] has joined #bitcoin-core-dev
05:28 -!- ctrlbreak [~ctrlbreak@142.162.42.47] has quit [Ping timeout: 276 seconds]
05:42 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection]
05:49 < wumpus> okay
05:51 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f5d166acf909...4c6d1b9973c9
05:51 < bitcoin-git> bitcoin/master 066d297 Karl-Johan Alm: contrib: correct version check...
05:51 < bitcoin-git> bitcoin/master 4c6d1b9 Wladimir J. van der Laan: Merge #13699: contrib: correct version check...
05:52 < bitcoin-git> [bitcoin] laanwj closed pull request #13699: contrib: correct version check (master...contrib-py-zmq-version) https://github.com/bitcoin/bitcoin/pull/13699
06:04 < bitcoin-git> [bitcoin] laanwj closed pull request #13672: Modified in_addr6 cast in CConman class to work with msvc (master...ip6castfix) https://github.com/bitcoin/bitcoin/pull/13672
06:08 < wumpus> for 13672 I was afraid it would bring back some problems, I remember that part of the code being heavily patched and contended already, I hope it's finally ok now
06:08 < wumpus> palimpsest function
06:11 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
06:14 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev
06:18 < fanquake> heh. It always seems like the Windows builds/build tools can easily break, and just remain that way for some time
06:22 -!- Krellan [~Krellan@2601:640:4000:9258:1da5:3584:1e53:4e3a] has quit [Read error: Connection reset by peer]
06:23 -!- Krellan [~Krellan@2601:640:4000:9258:1da5:3584:1e53:4e3a] has joined #bitcoin-core-dev
06:24 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
06:24 < wumpus> I don't think many people are building using msvc
06:24 < wumpus> could be because there's not much interest in doing so, or because sipsorcery's guide is not well-known
06:25 < fanquake> yep that's most of the reason I reckon, just not many people building
06:26 < wumpus> at least openbsd and freebsd problems tend to be reported quickly nowadays
06:27 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/0d8d6be79119...9d26b690e758
06:27 < bitcoin-git> bitcoin/master 41a8c8d MarcoFalke: travis: Check that ~/.bitcoin is never created
06:27 < bitcoin-git> bitcoin/master fabe28a MarcoFalke: qa: Temporarily disable test that reads the default datadir location
06:27 < bitcoin-git> bitcoin/master 9d26b69 Wladimir J. van der Laan: Merge #13687: travis: Check that ~/.bitcoin is never created...
06:27 < bitcoin-git> [bitcoin] laanwj closed pull request #13687: travis: Check that ~/.bitcoin is never created (master...Mf1709-travisHomeDirBtc) https://github.com/bitcoin/bitcoin/pull/13687
06:29 -!- ctrlbreak [~ctrlbreak@142.162.20.53] has joined #bitcoin-core-dev
06:39 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]
06:51 < BlueMatt> gmaxwell: its no doubt long since time to implement prediction, though sadly I dont have time atm :(
07:14 -!- setpill [~setpill@unaffiliated/setpill] has quit [Ping timeout: 256 seconds]
07:15 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev
07:15 -!- goatpig [56eece80@gateway/web/freenode/ip.86.238.206.128] has joined #bitcoin-core-dev
07:30 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9d26b690e758...714667268713
07:30 < bitcoin-git> bitcoin/master 801cb30 Samuel B. Atwood: doc: Add release notes for -printtoconsole and -debuglogfile changes...
07:30 < bitcoin-git> bitcoin/master 7146672 Wladimir J. van der Laan: Merge #13625: doc: Add release notes for -printtoconsole and -debuglogfile changes...
07:31 < bitcoin-git> [bitcoin] laanwj closed pull request #13625: doc: Add release notes for -printtoconsole and -debuglogfile changes (master...printtoconsole_release_notes) https://github.com/bitcoin/bitcoin/pull/13625
07:31 -!- LEGENDARYOWLZ [18cdb83a@gateway/web/freenode/ip.24.205.184.58] has joined #bitcoin-core-dev
07:33 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection]
07:34 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev
07:53 -!- farmerwampum [~farmerwam@88.202.178.98] has quit [Ping timeout: 244 seconds]
07:54 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev
08:00 -!- narodnik [~kk@2a00:1508:1:f018:4c37:fc3c:b0fa:f386] has joined #bitcoin-core-dev
08:02 -!- narodnik [~kk@2a00:1508:1:f018:4c37:fc3c:b0fa:f386] has quit [Quit: Leaving]
08:10 -!- grafcaps [~haroldbr@104.137.194.255] has joined #bitcoin-core-dev
08:19 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/714667268713...585db54dd1ae
08:19 < bitcoin-git> bitcoin/master 417b6c1 Thomas Kerin: bitcoinconsensus: invalid flags should be set to bitcoinconsensus_error type, add test cases covering bitcoinconsensus error codes
08:19 < bitcoin-git> bitcoin/master 585db54 Wladimir J. van der Laan: Merge #13655: bitcoinconsensus: invalid flags error should be set to bitcoinconsensus_err...
08:31 -!- Krellan [~Krellan@2601:640:4000:9258:1da5:3584:1e53:4e3a] has quit [Read error: Connection reset by peer]
08:32 -!- Krellan [~Krellan@2601:640:4000:9258:1da5:3584:1e53:4e3a] has joined #bitcoin-core-dev
08:32 -!- someone235_ [~Simon@bzq-223-179.red.bezeqint.net] has quit [Ping timeout: 240 seconds]
08:39 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Remote host closed the connection]
08:48 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
08:49 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
08:51 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 244 seconds]
08:55 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
08:56 -!- LEGENDARYOWLZ [18cdb83a@gateway/web/freenode/ip.24.205.184.58] has quit [Quit: Page closed]
09:13 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev
09:17 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Ping timeout: 240 seconds]
09:21 < promag> is #13697 for 0.17?
09:21 < gribble> https://github.com/bitcoin/bitcoin/issues/13697 | Support output descriptors in scantxoutset by sipa · Pull Request #13697 · bitcoin/bitcoin · GitHub
09:26 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
09:27 -!- dqx_ [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev
09:27 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev
09:27 -!- harrymm [~harrymm@69.161.195.103] has quit [Remote host closed the connection]
09:29 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 245 seconds]
09:29 -!- harrymm [~harrymm@69.161.195.103] has joined #bitcoin-core-dev
09:34 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]
09:35 < sipa> promag: i would like it to be, but it is very late
09:35 < sipa> if it's not for 0.17, it'll need to be a separate interfacs rather than replacing the existing ones
09:38 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/]
09:44 < echeveria> > 2018-07-18 16:39:53.624243 Successfully reconstructed block 00000000000000000000a34548e4384fb22321382fb3d101f1c9281813440a28 with 1 txn prefilled, 0 txn from mempool (incl at least 0 from extra pool) and 2348 txn requested
09:44 < echeveria> hm. sort of feels like blocksonly=1 should unset compact blocks :)
09:46 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
09:49 < sipa> can anyone still access the BIP174 PR without getting a unicorn?
09:50 < echeveria> 12136?
09:52 < sipa> #13557
09:52 < gribble> https://github.com/bitcoin/bitcoin/issues/13557 | HTTP Error 502: Bad Gateway
09:57 < echeveria> that's an error
09:57 < echeveria> nope, now it loads.
09:57 < echeveria> #13557
09:58 < gribble> https://github.com/bitcoin/bitcoin/issues/13557 | BIP 174 PSBT Serializations and RPCs by achow101 · Pull Request #13557 · bitcoin/bitcoin · GitHub
10:00 < gmaxwell> echeveria: hm. I thought I changed it a while back to not use CB if your mempool is empty.
10:12 -!- c__ [~c@c-73-216-66-50.hsd1.va.comcast.net] has quit [Remote host closed the connection]
10:18 < wumpus> unicorns here while logged in, but not in private browsing
10:19 < wumpus> ?timeline_per_page=20
10:19 < wumpus> works
10:20 < sipa> wumpus: oh!
10:20 -!- Dizzle [~dizzle@108.171.182.16] has joined #bitcoin-core-dev
10:22 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Quit: WeeChat 1.4]
10:26 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
10:28 < gmaxwell> sipa: another alternative, though I'd like to see it go in too, would be to mark scantoutset expiremental so we can change the interface without surprising anyone.
10:30 < sipa> gmaxwell: yeah, that's an option
10:31 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
10:37 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
10:38 -!- jamesob_ [~james@50-255-21-177-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
10:41 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #13703: 0.16.2: [doc] Bump manpages (0.16...Mf1807-16man) https://github.com/bitcoin/bitcoin/pull/13703
10:41 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]
10:43 -!- vicenteH [~user@54.104.135.37.dynamic.jazztel.es] has quit [Read error: Connection reset by peer]
10:44 -!- vicenteH [~user@54.104.135.37.dynamic.jazztel.es] has joined #bitcoin-core-dev
10:47 -!- jamesob_ [~james@50-255-21-177-static.hfc.comcastbusiness.net] has quit [Ping timeout: 260 seconds]
10:48 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!]
10:49 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
10:52 -!- profmac [~ProfMac@2001:470:1f0f:226:5ea:4d97:bca4:5258] has joined #bitcoin-core-dev
10:52 -!- profmac_ [~ProfMac@2001:470:1f0f:226:5ea:4d97:bca4:5258] has joined #bitcoin-core-dev
10:53 -!- profmac_ [~ProfMac@2001:470:1f0f:226:5ea:4d97:bca4:5258] has quit [Client Quit]
11:02 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has joined #bitcoin-core-dev
11:07 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev
11:08 < promag> sipa: I'd rather merge your change for 0.17 and tag it experimental than changing API
11:10 -!- jamesob_ [~james@65.200.72.90] has joined #bitcoin-core-dev
11:15 < achow101> wumpus: is #13500 ready to be merged? has 3 utacks and is pretty simple
11:15 < gribble> https://github.com/bitcoin/bitcoin/issues/13500 | [wallet] Decouple wallet version from client version by achow101 · Pull Request #13500 · bitcoin/bitcoin · GitHub
11:16 < sipa> promag: ...?
11:16 < sipa> promag: merging my change would be changing the API
11:17 < promag> sipa: it wasn't released yet
11:19 < sipa> promag: oh, that's what you mean
11:19 < sipa> promag: yes, that's my preference too
11:19 -!- riemann_ [~riemann@217.96.154.56.ipv4.supernova.orange.pl] has joined #bitcoin-core-dev
11:19 < promag> sipa: right
11:19 < promag> :P
11:19 -!- Nebraskka_ [~Nebraskka@178.62.130.190] has quit [Quit: Good day, my fellow citizens!~]
11:20 -!- Nebraskka [~Nebraskka@178.62.130.190] has joined #bitcoin-core-dev
11:23 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]
11:26 < bitcoin-git> [bitcoin] laanwj pushed 9 new commits to master: https://github.com/bitcoin/bitcoin/compare/585db54dd1ae...b6547234616f
11:26 < bitcoin-git> bitcoin/master 41c607f Andrew Chow: Implement PSBT Structures and un/serialization methods per BIP 174
11:26 < bitcoin-git> bitcoin/master 12bcc64 Andrew Chow: Add pubkeys and whether input was witness to SignatureData...
11:26 < bitcoin-git> bitcoin/master e9d86a4 Andrew Chow: Methods for interacting with PSBT structs...
11:26 < sipa> \oooooo/
11:26 < achow101> yay!
11:27 < bitcoin-git> [bitcoin] laanwj closed pull request #13557: BIP 174 PSBT Serializations and RPCs (master...psbt) https://github.com/bitcoin/bitcoin/pull/13557
11:35 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection]
11:35 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]
11:35 -!- jamesob__ [~james@65.200.72.90] has joined #bitcoin-core-dev
11:36 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev
11:42 < jimpo> Updated #12254 PR description with updated BIP 158 filter size stats. Cumulative filter size / cumulative base block size = 1.98%.
11:42 < gribble> https://github.com/bitcoin/bitcoin/issues/12254 | BIP 158: Compact Block Filters for Light Clients by jimpo · Pull Request #12254 · bitcoin/bitcoin · GitHub
11:48 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev
11:53 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev
11:55 < wumpus> \\o//
11:55 < wumpus> achow101: will take a look
11:59 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 255 seconds]
11:59 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b6547234616f...4a3e8c5aa6a5
11:59 < bitcoin-git> bitcoin/master cd3f4aa Andrew Chow: Decouple wallet version from client version...
11:59 < bitcoin-git> bitcoin/master 4a3e8c5 Wladimir J. van der Laan: Merge #13500: [wallet] Decouple wallet version from client version...
12:00 < bitcoin-git> [bitcoin] laanwj closed pull request #13500: [wallet] Decouple wallet version from client version (master...decouple-wallet-version) https://github.com/bitcoin/bitcoin/pull/13500
12:01 < wumpus> gmaxwell,sipa: marking scantxoutset as experimental sounds good to me. People will initially be learning what to do with the method anyhow, there might be some other things that need to be changed based on that learning process
12:01 < wumpus> (independent on whether it gets merged)
12:02 -!- Tennis [~Tennis@unaffiliated/tennis] has joined #bitcoin-core-dev
12:03 -!- ovovo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 264 seconds]
12:08 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
12:14 < gmaxwell> I think in general we should be more agressive at marking new RPC features expiremental, more agressive at adding them, and more agressive at removing them or changing them. :)
12:22 -!- jamesob_ [~james@65.200.72.90] has quit [Ping timeout: 245 seconds]
12:23 -!- jamesob__ [~james@65.200.72.90] has quit [Ping timeout: 255 seconds]
12:26 < wumpus> yes, true
12:27 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev
12:31 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 245 seconds]
12:33 -!- ken2812221 [~ken281222@1.200.202.10] has quit [Ping timeout: 240 seconds]
12:37 -!- nmnkgl [uid306870@gateway/web/irccloud.com/x-ucytfypggvwviuui] has joined #bitcoin-core-dev
12:39 -!- someone235_ [~Simon@5.29.86.198] has joined #bitcoin-core-dev
12:40 -!- someone235_ [~Simon@5.29.86.198] has quit [Read error: Connection reset by peer]
12:40 -!- Tuna_Golem [~Tuna_Gole@bzq-82-81-88-212.red.bezeqint.net] has quit []
12:43 -!- bitconner [~conner@136.24.175.89] has quit [Ping timeout: 240 seconds]
12:48 -!- Krellan [~Krellan@2601:640:4000:9258:1da5:3584:1e53:4e3a] has quit [Read error: Connection reset by peer]
12:49 -!- Krellan [~Krellan@2601:640:4000:9258:1da5:3584:1e53:4e3a] has joined #bitcoin-core-dev
12:51 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
12:54 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev
12:59 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 268 seconds]
13:00 -!- bitconner [~conner@64-71-8-130.static.wiline.com] has joined #bitcoin-core-dev
13:13 -!- dqx_ [~dqx@unaffiliated/dqx] has quit [Remote host closed the connection]
13:16 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
13:21 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev
13:24 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev
13:24 -!- timothy [~tredaelli@redhat/timothy] has quit [Client Quit]
13:30 -!- dqx_ [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev
13:32 -!- jamesob_ [~james@65.200.72.90] has joined #bitcoin-core-dev
13:32 -!- jamesob__ [~james@65.200.72.90] has joined #bitcoin-core-dev
13:33 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
13:34 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Ping timeout: 245 seconds]
13:40 -!- marcinja [~marcin@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
13:46 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Plugging out.]
13:46 < bitcoin-git> [bitcoin] theuni closed pull request #12467: build: compile univalue as c++11 (master...fix-subconfigure-args) https://github.com/bitcoin/bitcoin/pull/12467
13:48 -!- marcinja [~marcin@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Quit: Leaving]
13:49 -!- marcinja [~marcin@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
13:58 -!- goatpig [56eece80@gateway/web/freenode/ip.86.238.206.128] has quit [Ping timeout: 252 seconds]
14:08 -!- jamesob__ [~james@65.200.72.90] has quit [Ping timeout: 244 seconds]
14:08 -!- jamesob_ [~james@65.200.72.90] has quit [Ping timeout: 244 seconds]
14:20 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]
14:40 < bitcoin-git> [bitcoin] practicalswift opened pull request #13705: build: Add format string linter (master...lint-format-strings) https://github.com/bitcoin/bitcoin/pull/13705
14:54 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
14:59 -!- Krellan [~Krellan@2601:640:4000:9258:1da5:3584:1e53:4e3a] has quit [Read error: Connection reset by peer]
15:00 -!- Krellan [~Krellan@2601:640:4000:9258:1da5:3584:1e53:4e3a] has joined #bitcoin-core-dev
15:00 -!- grubles [~grubles@unaffiliated/grubles] has quit [Remote host closed the connection]
15:05 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds]
15:07 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 250 seconds]
15:07 -!- radioops [68ec8481@gateway/web/freenode/ip.104.236.132.129] has joined #bitcoin-core-dev
15:10 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev
15:15 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection]
15:16 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev
15:16 -!- riemann_ [~riemann@217.96.154.56.ipv4.supernova.orange.pl] has quit [Ping timeout: 240 seconds]
15:20 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev
15:24 -!- xC0FFEE [~hendrik@46-59-166-23.lsn7.wtnet.de] has joined #bitcoin-core-dev
15:27 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]
15:31 -!- ElBuda [bab76cd5@gateway/web/freenode/ip.186.183.108.213] has joined #bitcoin-core-dev
15:32 -!- ElBuda [bab76cd5@gateway/web/freenode/ip.186.183.108.213] has quit [Client Quit]
15:35 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection]
15:36 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev
15:37 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection]
15:38 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev
15:43 -!- grubles [~grubles@unaffiliated/grubles] has joined #bitcoin-core-dev
15:50 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
15:59 -!- ryanofsky [~russ@jumpy.yanofsky.org] has quit [Ping timeout: 248 seconds]
15:59 -!- earlz [~earlz@earlz.net] has quit [Ping timeout: 265 seconds]
16:00 -!- |EHG| [|EHG|@gateway/vpn/privateinternetaccess/ehg/x-82069683] has quit [Ping timeout: 264 seconds]
16:00 -!- harding [quassel@2600:3c03::f03c:91ff:fe7b:78d1] has quit [Ping timeout: 260 seconds]
16:00 < bitcoin-git> [bitcoin] mitchellcash opened pull request #13706: doc: Minor improvements to release-process.md (master...release_process_doc) https://github.com/bitcoin/bitcoin/pull/13706
16:00 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
16:02 -!- m8tion [~Agence@abo-134-110-68.mrs.modulonet.fr] has quit [Read error: Connection reset by peer]
16:03 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev
16:03 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
16:05 < gmaxwell> someone is calling for wumpus to be opensourced.
16:06 < sipa> i believe wumpus is a physically unclonable function
16:07 < gmaxwell> There have been some recent advances in cloning PUFs.
16:17 -!- lontivero [~lontivero@186.183.108.213] has joined #bitcoin-core-dev
16:26 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev
16:28 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds]
16:30 -!- ryanofsky [russ@jumpy.yanofsky.org] has joined #bitcoin-core-dev
16:30 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 240 seconds]
16:32 -!- harding [quassel@2600:3c03::f03c:91ff:fe7b:78d1] has joined #bitcoin-core-dev
16:37 -!- pinhead [cfbd18ba@gateway/web/freenode/ip.207.189.24.186] has joined #bitcoin-core-dev
16:39 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has quit [Remote host closed the connection]
16:47 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has quit [Ping timeout: 268 seconds]
17:07 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Ping timeout: 256 seconds]
17:07 -!- Dizzle [~dizzle@108.171.182.16] has quit [Ping timeout: 240 seconds]
17:08 -!- Krellan [~Krellan@2601:640:4000:9258:1da5:3584:1e53:4e3a] has quit [Read error: Connection reset by peer]
17:09 -!- Krellan [~Krellan@2601:640:4000:9258:1da5:3584:1e53:4e3a] has joined #bitcoin-core-dev
17:24 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
17:27 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev
17:32 -!- pinhead [cfbd18ba@gateway/web/freenode/ip.207.189.24.186] has quit [Quit: Page closed]
17:41 -!- dqx_ [~dqx@unaffiliated/dqx] has quit [Ping timeout: 240 seconds]
17:42 -!- Tennis [~Tennis@unaffiliated/tennis] has quit [Ping timeout: 268 seconds]
17:46 -!- dqx_ [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev
17:49 < bitcoin-git> [bitcoin] masonicboom opened pull request #13707: Tests: add usage note to check-rpc-mappings.py (master...add-usage-note-to-check-rpc-mappings) https://github.com/bitcoin/bitcoin/pull/13707
17:51 < bitcoin-git> [bitcoin] masonicboom closed pull request #13698: doc: Document contributing a scripted diff (master...scripted-diff-docs) https://github.com/bitcoin/bitcoin/pull/13698
17:52 -!- dqx_ [~dqx@unaffiliated/dqx] has quit [Ping timeout: 255 seconds]
17:56 -!- dqx_ [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev
18:01 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
18:14 -!- |EHG| [|EHG|@gateway/vpn/privateinternetaccess/ehg/x-82069683] has joined #bitcoin-core-dev
18:29 -!- Urgo [~Urgo@cpe-107-15-142-254.nc.res.rr.com] has quit [Ping timeout: 276 seconds]
18:32 -!- Urgo [~Urgo@cpe-107-15-142-254.nc.res.rr.com] has joined #bitcoin-core-dev
18:50 < bitcoin-git> [bitcoin] masonicboom opened pull request #13708: docs: Document lint tests (master...document-lint-tests) https://github.com/bitcoin/bitcoin/pull/13708
19:16 -!- Krellan [~Krellan@2601:640:4000:9258:1da5:3584:1e53:4e3a] has quit [Read error: Connection reset by peer]
19:16 -!- grafcaps [~haroldbr@104.137.194.255] has quit [Ping timeout: 276 seconds]
19:17 -!- Krellan [~Krellan@2601:640:4000:9258:1da5:3584:1e53:4e3a] has joined #bitcoin-core-dev
19:25 -!- grafcaps [~haroldbr@050-090-083-229.res.spectrum.com] has joined #bitcoin-core-dev
19:25 -!- johnn2 [5ed7010f@gateway/web/freenode/ip.94.215.1.15] has joined #bitcoin-core-dev
19:26 -!- johnn2 [5ed7010f@gateway/web/freenode/ip.94.215.1.15] has quit [Client Quit]
19:27 -!- Urgo [~Urgo@cpe-107-15-142-254.nc.res.rr.com] has quit [Ping timeout: 260 seconds]
19:27 -!- bitconner [~conner@64-71-8-130.static.wiline.com] has quit [Ping timeout: 245 seconds]
19:27 -!- Urgo [~Urgo@cpe-107-15-142-254.nc.res.rr.com] has joined #bitcoin-core-dev
19:28 -!- radioops [68ec8481@gateway/web/freenode/ip.104.236.132.129] has quit [Quit: Page closed]
19:29 -!- grafcaps [~haroldbr@050-090-083-229.res.spectrum.com] has quit [Ping timeout: 255 seconds]
19:36 -!- farmerwampum [~farmerwam@88.202.178.98] has joined #bitcoin-core-dev
19:38 -!- farmerwampum [~farmerwam@88.202.178.98] has quit [Client Quit]
19:38 -!- farmerwampum [~farmerwam@88.202.178.98] has joined #bitcoin-core-dev
19:52 -!- dqx_ [~dqx@unaffiliated/dqx] has quit [Ping timeout: 268 seconds]
19:58 -!- hendrik_ [~hendrik@46-59-160-113.lsn7.wtnet.de] has joined #bitcoin-core-dev
20:01 -!- xC0FFEE [~hendrik@46-59-166-23.lsn7.wtnet.de] has quit [Ping timeout: 245 seconds]
20:13 -!- bitconner [~conner@136.24.175.89] has joined #bitcoin-core-dev
20:19 < gmaxwell> https://blog.bitmex.com/bitcoins-consensus-forks/ has anyone already pinged these folks and pointed out that stuff like the addition of NOPs was not a hardfork? (prior to that commit all unknown ops were nops)
20:37 -!- nico_ [~nico@190.18.155.139] has joined #bitcoin-core-dev
20:40 -!- nico_ is now known as un1c0d3r
20:42 < luke-jr> gmaxwell: nope, but it might be good to correct https://en.bitcoin.it/wiki/Consensus_versions in that case (I guess it'd be a softfork instead?)
20:43 < gmaxwell> Yes.
20:44 < gmaxwell> re that page, really anything that wants to say that the system has hardforked previously ought to be explaining why the very first release can validatate past their claimed hardfork.
20:44 < gmaxwell> because the traditional definition of a hardfork (as used on that article) doesn't really allow for that.
20:45 < bitcoin-git> [bitcoin] GerardoTaboada opened pull request #13709: Update nodes_main.txt (master...patch-2) https://github.com/bitcoin/bitcoin/pull/13709
20:45 < gmaxwell> e.g. on the script split, there is a conjectural hardfork there that AFAIK no one is completely sure of.
20:46 < gmaxwell> And if it does exist, it's never actually been triggered.
20:46 < gmaxwell> So it would, if the conjecture holds, be better to call that a latent hardfork.
20:50 < bitcoin-git> [bitcoin] fanquake closed pull request #13709: Update nodes_main.txt (master...patch-2) https://github.com/bitcoin/bitcoin/pull/13709
20:52 -!- meshcollider_ [uid246294@gateway/web/irccloud.com/x-vofeetxhunspfbmx] has joined #bitcoin-core-dev
20:52 -!- un1c0d3r [~nico@190.18.155.139] has quit [Ping timeout: 240 seconds]
20:54 < luke-jr> gmaxwell: most consensus rules are never triggered. that's immaterial to the change.
20:57 < gmaxwell> it's pretty material to the question of it being debatable if there was a hardfork or not!
20:57 < luke-jr> if the rules were relaxed, it was by definition a hardfork.
20:57 < gmaxwell> I mean we don't actually know if the script split was a hardfork because at most its a latent hardfork, no one has constructed a demonstration case.
20:57 < luke-jr> no demonstration case is needed
20:57 < gmaxwell> Sometimes it's really hard to tell if they were relaxed or not.
20:58 < luke-jr> which one are you referring to?
20:58 < gmaxwell> " I mean we don't actually know if the script split was a hardfork"
20:58 < luke-jr> oh, 0.3.7? I guess that's unclear.
20:58 < gmaxwell> for years we thought it wasn't then someone came up with a credible argument that it might have been.
20:59 < gmaxwell> But it's complicated enough that it probably won't be convincing without an example transaction.
20:59 < luke-jr> couldn't an OP_IF span the two scripts previously?
20:59 < luke-jr> hmm, can't think of a way to make that do invalid->valid, nm
21:00 < gmaxwell> I think the example required an invalid serialization whos bytes gobbled up the code seperator.
21:00 < gmaxwell> But AFAIK no one has ever tested it, and that might not work in the old code for some not immediately obvious reason.
21:01 < gmaxwell> e.g. you end the scriptsig with a multibyte push opcode and an invalid length on the script so when concatinated with the code sep the codesep becomes part of the push.
21:01 < gmaxwell> or something along those lines.
21:01 < luke-jr> right
21:01 < luke-jr> not sure it's worth the effort to prove either way, maybe it can just say "unclear"
21:02 < gmaxwell> in any case, when people talk about hardforks, they ususally believe it disrupted the network and split consensus, but a latent hardfork hasn't done that.
21:02 < gmaxwell> Which is why I think it would be useful to signal when they're latent or not and when (if ever) they materalized.
21:02 < luke-jr> only people who don't understand hardforks, since a real one wouldn't disrupt the network nor split consensus
21:03 < gmaxwell> luke-jr: yea, so only to 99.99999% of people on earth. :P
21:03 < luke-jr> most people don't have either a correct understanding NOR a misunderstanding ;)
21:03 < gmaxwell> So for example for the 2013 thing I'd say that it was a latent hardfork that became sensible in sept 2014 (or whenever old versions were actually reliably forked off).
21:04 < luke-jr> I'd say all hardforks are "latent"
21:04 < luke-jr> if the network splits, it would cease to be a hardfork, and become an altcoin like BCH instead
21:05 < gmaxwell> Even if the network hasn't split, the more permissiveness could have been used or not.
21:06 < gmaxwell> Imagine this, say the network rules change so that any coin with pubkey P could also be spent with pubkey P' = hash_to_point(P).  This is a hardfork, but unless ECC is broken it can never be anything but a latent hardfork.  It would be a dumb change for sure, but it wouldn't imply basically any of the risks of a hardfork.
21:07 < gmaxwell> in any case, for the list the NOP thing was just a softfork (AFAIK), I think a few other early softforks are missing.
21:08 < luke-jr> you want to fix it, or should I? ;)
21:09 < gmaxwell> The script split thing I'd describe as a "possible latent hardfork [1]"  "[1] The change wasn't believed to be a hardfork for years, but later some people conjectured some contrived transaction style which might be valid under the new rules but not the old, but it's complicated enough no one has bothered to check for sure, especially since any impacted software was long since no longer in use."
21:10 < luke-jr> actually, I'm not sure I see how the invalid script thing could be used to make something valid that was previously invalid.. seems the end result would be invalid after a split too
21:10 < luke-jr> because then you have a chopped opcode to execute
21:11 < gmaxwell> for the 2013 thing, it's a "hardfork kinda" because the old behavior was non-determinstic.  If you use your definition of a hardfork where a latent hardfork is a hardfork, then the 'time' of that hardfork was the initial release; since any given node could permit things others would forbid.
21:11 < luke-jr> afaik, the new rules after 2013 May permitted things that would never have been permitted previously, at least by any naturally functioning node
21:12 < gmaxwell> luke-jr: I dunno I'd have to find the discussion. I recall thinking that it was plausable. 
21:12 < luke-jr> maybe kanzure remembers XD
21:13 < gmaxwell> luke-jr: I'm not _totally_ sure of that. I've synced as far as sept 2014 but the place where it fails was different between different runs.  Maybe if I tried millions of times it would make it up to current.
21:13 < luke-jr> gmaxwell: even if it did, you could still construct a block that is valid under the new rules that it would reject
21:14 < gmaxwell> in any case, a change in behavior from highly non-deterministic to slightly more permissive determnistic is not your 'typical' hardfork. :P  e.g. "do nothing" wasn't an option. 
21:14 < gmaxwell> luke-jr: thats what I'm not sure of. I don't know if you actually can construct a block that the old code will _never_ accept, only that it's very unlikely to accept.
21:14 < luke-jr> the fix to the problem, in March, was to make the rules deterministically stricter ;)
21:15 < luke-jr> ie, semver 1.0.2 on the wiki page
21:15 < gmaxwell> luke-jr: I'm pretty confident that the temporary softfork wasn't actually enough to protect nodes from the non-determinism, FWIW.
21:15 < luke-jr> why not? wasn't it strictly more restrictive?
21:16 < gmaxwell> No, because the BDB behavior was more complicated than we understood at the time.
21:16 < luke-jr> >_<
21:17 < gmaxwell> I think, in fact, depending on what read activity was going on, it could have run out of locks for a block that only touched two txids (e.g. a single transaction).
21:17 < gmaxwell> at least in theory.
21:17 < luke-jr> you mean in the wallet bdb?
21:17 < luke-jr> or what else would cause reads going on?
21:17 < gmaxwell> indeed.
21:19 < luke-jr> well, the limits had to be strict enough that it could survive at least a minimal reorg, so I'd be surprised if the wallet could interfere too much in normal operation
21:20 < sipa> gmaxwell: addition of NOPs was at the same time as removal of VER
21:21 < gmaxwell> sipa: yes, and? removing ver was a softfork.
21:21 < gmaxwell> (I suppose luke should argue that every version _prior_ to that point was a hardfork, due to OP_VER. ...)
21:22 < gmaxwell> luke-jr: Another reason why latent vs non-latent hardforks matter: a latent one could still be softforked out. 
21:22 < sipa> gmaxwell: script split was a trivial hardfork; the sighash effect of codesep changed
21:23 < gmaxwell> e.g. say you did come up with a transaction pattern that split off 0.3.0, but yet was never used in the network so far. That pattern could be softforked out and then the 'hardfork' is undone.
21:24 < luke-jr> gmaxwell: any hardfork can be softforked out.
21:24 < gmaxwell> luke-jr: not in a way that prevents older software from going out of consensus.
21:25 < luke-jr> ?
21:25 < sipa> gmaxwell: did you see my comment on sighash and codesep?
21:26 < gmaxwell> sipa: yes, so you're saying that any transaction with a codesep in the scriptpubkey that is valid now wouldn't have been valid pre-0.3.0 ?
21:27 -!- baldur [~baldur@pool-100-2-154-254.nycmny.btas.verizon.net] has quit [Ping timeout: 256 seconds]
21:27 < gmaxwell> (well codesep and a valid signature, of course)
21:27 < sipa> gmaxwell: yes
21:28 < sipa> a signature with a checksig in the scriotsig
21:28 < gmaxwell> now I'm wondering if the point I was unable to get 0.1.0 ultimately past was really a codesep use and not related to the locks thing at all.
21:28 < sipa> it may be impossible to construct a valid one like that now...
21:28 < sipa> maybe when using sighash_single bug
21:29 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev
21:29 < gmaxwell> it would certantly make more sense, since the block in question wasn't even especially large.
21:31 -!- lontivero [~lontivero@186.183.108.213] has quit [Ping timeout: 276 seconds]
21:33 < gmaxwell> luke-jr: in any case there is also a big difference between intentionally adding a hardfork and accidentally adding one in a crazy corner case when trying to fix a bug that let anyone spend any coin. :P
21:33 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 245 seconds]
21:34 < luke-jr> gmaxwell: depends on why you're classifying
21:35 < kallewoof> Not sure how useful to you guys but I made a small bash script that iterates through a range of commits in a git branch and makes sure they all compile: https://gist.github.com/kallewoof/10ce05193e738b42517b565a2f9b22e6
21:38 -!- baldur [~baldur@pool-100-2-154-254.nycmny.btas.verizon.net] has joined #bitcoin-core-dev
21:39 < luke-jr> git checkout $a; while [ $(git log --pretty=oneline $b^.. | wc -l) -gt 0 ]; do make || break; git checkout HEAD^; done ?
21:39 < luke-jr> :p
21:42 < luke-jr> sipa: so you're sure that *at the time*, the script split was a HF?
21:43 < sipa> luke-jr: i believe it was possible at the time to construct a scriptSig that was not valid before the removal, and valid after
21:43 < aj> "make || break" -- love it
22:12 -!- grafcaps [~haroldbr@050-090-083-229.res.spectrum.com] has joined #bitcoin-core-dev
22:15 < bitcoin-git> [bitcoin] ken2812221 opened pull request #13710: [depends] Add riscv qt depends support for cross compiling bitcoin-qt (master...qt-riscv) https://github.com/bitcoin/bitcoin/pull/13710
22:17 -!- grafcaps [~haroldbr@050-090-083-229.res.spectrum.com] has quit [Ping timeout: 260 seconds]
22:28 -!- mariorz_ [sid490@gateway/web/irccloud.com/x-ucfgdnhlbezldwbl] has joined #bitcoin-core-dev
22:29 -!- mturquette_ [sid66043@gateway/web/irccloud.com/x-ucrqcyabjvlkqkav] has joined #bitcoin-core-dev
22:29 -!- trotski2000 [sid206086@gateway/web/irccloud.com/x-svyaslpdndziqelu] has quit [Ping timeout: 276 seconds]
22:29 -!- pindarhk_ [sid105966@gateway/web/irccloud.com/x-uepivlkwejswqavm] has quit [Ping timeout: 276 seconds]
22:29 -!- CryptAxe [~CryptAxe@2400:8902::f03c:91ff:fe92:b2bd] has quit [Ping timeout: 276 seconds]
22:29 -!- trotski2000 [sid206086@gateway/web/irccloud.com/x-eahofttudxynnean] has joined #bitcoin-core-dev
22:29 -!- pierre_rochard_ [uid299882@gateway/web/irccloud.com/x-dheywjnxekbeicej] has joined #bitcoin-core-dev
22:29 -!- meshcollider__ [uid246294@gateway/web/irccloud.com/x-zwoxgkmuvpgrppot] has joined #bitcoin-core-dev
22:29 -!- rodarmor_ [sid210835@gateway/web/irccloud.com/x-krkbvnoxitftwadx] has joined #bitcoin-core-dev
22:29 -!- epic [sid37137@gateway/web/irccloud.com/x-riczfqobazlfqpcv] has quit [Ping timeout: 276 seconds]
22:29 -!- bosma [sid103570@gateway/web/irccloud.com/x-wnwacwjseqwbrmss] has quit [Ping timeout: 276 seconds]
22:29 -!- wbnns [sid105317@21/bitcoin/binns] has quit [Ping timeout: 276 seconds]
22:29 -!- mturquette [sid66043@gateway/web/irccloud.com/x-dreqvvxtwmnlkdvj] has quit [Ping timeout: 276 seconds]
22:29 -!- mturquette_ is now known as mturquette
22:29 -!- mappum__ [sid43795@gateway/web/irccloud.com/x-djeekscppgnyltah] has joined #bitcoin-core-dev
22:30 -!- bosma [sid103570@gateway/web/irccloud.com/x-njsubodrovxkrxfd] has joined #bitcoin-core-dev
22:30 -!- epic [sid37137@gateway/web/irccloud.com/x-tmizarffqqbkagvp] has joined #bitcoin-core-dev
22:30 -!- wbnns [sid105317@gateway/web/irccloud.com/x-qutsukxosfkqktsz] has joined #bitcoin-core-dev
22:30 -!- mariorz [sid490@gateway/web/irccloud.com/x-vhwkeqgrkclijszv] has quit [Ping timeout: 276 seconds]
22:30 -!- pindarhk_ [sid105966@gateway/web/irccloud.com/x-ryxckbumkdeexekx] has joined #bitcoin-core-dev
22:31 -!- meshcollider_ [uid246294@gateway/web/irccloud.com/x-vofeetxhunspfbmx] has quit [Ping timeout: 276 seconds]
22:31 -!- rodarmor [sid210835@gateway/web/irccloud.com/x-xfwebrleqflziklj] has quit [Ping timeout: 276 seconds]
22:31 -!- mappum_ [sid43795@gateway/web/irccloud.com/x-iqzgeboqpcbilqva] has quit [Ping timeout: 276 seconds]
22:31 -!- pierre_rochard [uid299882@gateway/web/irccloud.com/x-ogyobqagmluintag] has quit [Ping timeout: 276 seconds]
22:31 -!- meshcollider__ is now known as meshcollider_
22:31 -!- pierre_rochard_ is now known as pierre_rochard
22:31 -!- wbnns [sid105317@gateway/web/irccloud.com/x-qutsukxosfkqktsz] has quit [Changing host]
22:31 -!- wbnns [sid105317@21/bitcoin/binns] has joined #bitcoin-core-dev
22:33 -!- pierre_rochard is now known as Guest26115
22:33 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit []
22:35 -!- CryptAxe [~CryptAxe@2400:8902::f03c:91ff:fe92:b2bd] has joined #bitcoin-core-dev
22:44 -!- meshcollider_ [uid246294@gateway/web/irccloud.com/x-zwoxgkmuvpgrppot] has quit []
22:53 -!- meshcollider_ [uid246294@gateway/web/irccloud.com/x-nyqiggosftdeoevt] has joined #bitcoin-core-dev
22:57 < kallewoof> luke-jr: lol! but mine will start a rebase based on the commit if you ask it to? :P
23:05 < luke-jr> kallewoof: ? why
23:06 < kallewoof> luke-jr: If code is breaking you may wanna fix it
23:08 < luke-jr> --fixup?
23:08 < kallewoof> Right, or you just rebase into the commit, reset "HEAD^", and recommit it during rebase.
23:25 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev
23:29 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 240 seconds]
23:34 -!- Krellan [~Krellan@2601:640:4000:9258:1da5:3584:1e53:4e3a] has quit [Read error: Connection reset by peer]
23:35 -!- nmnkgl [uid306870@gateway/web/irccloud.com/x-ucytfypggvwviuui] has quit [Quit: Connection closed for inactivity]
23:35 -!- Krellan [~Krellan@2601:640:4000:9258:e863:a2a8:8e:4f75] has joined #bitcoin-core-dev
23:46 -!- Dhiraj [2bf17493@gateway/web/freenode/ip.43.241.116.147] has joined #bitcoin-core-dev
23:46 < sipa> what's the difference between HEAD~ and HEAD^ ?
23:46 -!- vicenteH [~user@54.104.135.37.dynamic.jazztel.es] has quit [Read error: Connection reset by peer]
23:46 < Dhiraj> Could some one suggest where to submit sec-bug for https://github.com/bitcoin/bitcoin/ ?
23:46 -!- vicenteH [~user@54.104.135.37.dynamic.jazztel.es] has joined #bitcoin-core-dev
23:47 < Dhiraj> any leads please ?
23:48 < sipa> Dhiraj: either open an issue, or email security@bitcoincore.org
23:48 < Dhiraj> okay cool, thank you
23:49 < harding> sipa: the difference is which side of a two-way merge it follows.  ^ is the left side (main code side by default), ~ is the right side (merged-in side) IIRC.
23:50 < Dhiraj> Thanks mail sent too security@bitcoincore.org 
23:51 < sipa> harding: thanks
23:51 -!- Dhiraj [2bf17493@gateway/web/freenode/ip.43.241.116.147] has quit [Quit: Page closed]
23:51 < sipa> harding: just looked up it, not really
23:51 < sipa> they're the same
23:52 < sipa> ^i means the ith parent
23:52 < sipa> ~i means the i times 1st parent
23:52 < sipa> so HEAD~ and HEAD^ are the same; both refer to the first parent of HEAD
23:52 < sipa> but HEAD~2 is the first parent of the first parent
23:53 < sipa> while HeAD^2 is the second parent
--- Log closed Thu Jul 19 00:00:15 2018