--- Log opened Thu Aug 30 00:00:54 2018 00:10 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 240 seconds] 00:18 -!- vicnicius [~vicnicius@188.206.73.28] has joined #bitcoin-core-dev 00:18 < gmaxwell> he's saying the der format private key always wrote the embedded pubkey in compressed form. 00:18 < gmaxwell> I think. 00:18 < gmaxwell> Though considering thats just used inside the wallet and the compressed form is smaller, I think that the current behavior is desirable. 00:19 < gmaxwell> but perhaps he knows some reason why it isn't. 00:21 -!- vicnicius [~vicnicius@188.206.73.28] has quit [Quit: Mutter: www.mutterirc.com] 00:31 -!- kallewoof [~quassel@240d:1a:759:6000:a7b1:451a:8874:e1ac] has quit [Ping timeout: 264 seconds] 00:35 <@wumpus> let's hope they manage to explain 00:35 -!- mode/#bitcoin-core-dev [-o wumpus] by ChanServ 00:37 * wumpus feels like killing account system today, let's get some reviews on #13825 00:37 < gribble> https://github.com/bitcoin/bitcoin/issues/13825 | [wallet] Kill accounts by jnewbery · Pull Request #13825 · bitcoin/bitcoin · GitHub 00:40 < wumpus> that PR is pretty much dead code removal (the actual functionality was already removed in an earlier PR) so it should be a more or less easy review 00:45 -!- rhavar [uid237883@gateway/web/irccloud.com/x-enqglqjkusyhcjzz] has quit [Quit: Connection closed for inactivity] 00:47 -!- kallewoof [~quassel@fp96f94c66.tkyc515.ap.nuro.jp] has joined #bitcoin-core-dev 00:58 < jonasschnelli> wumpus: kill it! 00:59 -!- Krellan [~Krellan@2601:640:4000:9258:b457:151c:3069:cdfc] has quit [Read error: Connection reset by peer] 01:00 -!- Krellan [~Krellan@2601:640:4000:9258:b457:151c:3069:cdfc] has joined #bitcoin-core-dev 01:06 -!- nickler [~nickler@185.12.46.130] has quit [Ping timeout: 268 seconds] 01:07 -!- murchandamus [~murchghos@ghostdub.de] has quit [Ping timeout: 268 seconds] 01:10 -!- bitconner [~conner@c-67-188-149-218.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 01:10 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/session] has joined #bitcoin-core-dev 01:10 < bitcoin-git> [bitcoin] practicalswift opened pull request #14103: Fix broken Doxygen comments (master...doxygen-cleanups) https://github.com/bitcoin/bitcoin/pull/14103 01:10 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/session] has left #bitcoin-core-dev [] 01:10 -!- D00M [~D00M@49.146.42.51] has quit [Quit: Leaving] 01:10 -!- nickler_ [~nickler@185.12.46.130] has joined #bitcoin-core-dev 01:10 < wumpus> jonasschnelli: ack it please :) 01:10 < jonasschnelli> wumpus: I did my utACK (hope that is enought) 01:10 -!- murchandamus1 [~murchghos@ghostdub.de] has joined #bitcoin-core-dev 01:10 < wumpus> jonasschnelli: oh! hadn't seen yet 01:10 < jonasschnelli> Greg did also 01:12 -!- laurentmt [~Thunderbi@185.94.189.189] has joined #bitcoin-core-dev 01:26 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 01:37 -!- bitconner [~conner@c-67-188-149-218.hsd1.ca.comcast.net] has quit [Ping timeout: 252 seconds] 01:42 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 01:43 -!- kallewoof [~quassel@fp96f94c66.tkyc515.ap.nuro.jp] has quit [Ping timeout: 240 seconds] 01:44 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 01:47 -!- kallewoof [~quassel@fp96f94c66.tkyc515.ap.nuro.jp] has joined #bitcoin-core-dev 02:00 -!- laurentmt [~Thunderbi@185.94.189.189] has quit [Quit: laurentmt] 02:01 -!- Rootsudo [~textual@180.191.157.73] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 02:03 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:03 -!- Rootsudo [~textual@180.191.157.73] has joined #bitcoin-core-dev 02:04 -!- _flow_ [~none@salem.informatik.uni-erlangen.de] has quit [Quit: WeeChat 2.0.1] 02:06 -!- bitconner [~conner@c-67-188-149-218.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 02:49 -!- Rootsudo [~textual@180.191.157.73] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 02:56 -!- JackH [~laptop@host86-182-8-23.range86-182.btcentralplus.com] has quit [Quit: Leaving] 02:59 < wumpus> appveyor is doing its thing again (failing on every PR) 03:01 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ihtudmhkxbxhdqxm] has joined #bitcoin-core-dev 03:01 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4e9a6f87b7d2...be301a577776 03:01 < bitcoin-git> bitcoin/master 0e534d4 practicalswift: Fix incorrect Doxygen comments 03:01 < bitcoin-git> bitcoin/master be301a5 Wladimir J. van der Laan: Merge #14103: docs: Fix broken Doxygen comments... 03:01 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ihtudmhkxbxhdqxm] has left #bitcoin-core-dev [] 03:02 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-gpdromyurizsfnvz] has joined #bitcoin-core-dev 03:02 < bitcoin-git> [bitcoin] laanwj closed pull request #14103: docs: Fix broken Doxygen comments (master...doxygen-cleanups) https://github.com/bitcoin/bitcoin/pull/14103 03:02 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-gpdromyurizsfnvz] has left #bitcoin-core-dev [] 03:05 < wumpus> okay, we should definitely discuss -noX versus -X=0 in the meeting, this is driving me crazy 03:05 < wumpus> #14100 03:05 < gribble> https://github.com/bitcoin/bitcoin/issues/14100 | doc: Change documentation for =0 for non-boolean options by laanwj · Pull Request #14100 · bitcoin/bitcoin · GitHub 03:06 < wumpus> I still hold to my original belief at the beginning of that PR that -X=0 for *non-boolean* options is ambigious, and we should encourage -noX, but it seems the code base is moving in the other direction 03:07 < wumpus> does 03:07 < wumpus> "nodebuglogfile" work at all in bitcoin.conf? 03:10 < wumpus> (no, doesn't seem to work) 03:12 < wumpus> oh it does if you specify nodebuglogfile=1 03:12 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 03:16 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 03:24 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 240 seconds] 03:27 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 03:30 < ken2812221_> I am trying to switch from msvc to autotool on appveyor, hope that it won't fail with weird reason again. 03:33 < ken2812221_> But this would drop CI for MSVC. 03:33 < ken2812221_> I'm not sure if it is a good idea. 03:34 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 03:34 -!- kallewoof [~quassel@fp96f94c66.tkyc515.ap.nuro.jp] has quit [Read error: Connection reset by peer] 03:34 < wumpus> it's just, from a maintenance perspective, that two CI testing systems that can fail for seemingly random reasons is even more frustrating then one 03:35 -!- kallewoof [~quassel@fp96f94c66.tkyc515.ap.nuro.jp] has joined #bitcoin-core-dev 03:36 < wumpus> theoretically I agree testing with MSVC good, but in practice, I end up ignoring it because most of the time the failures make no sense 03:37 < wumpus> and it is another huge log file to scroll through :-( 03:37 < wumpus> ...slowly and sometimes crashing the browser 03:37 < wumpus> wish that CI tools were smart enough to simply report what the problem was 03:39 < ken2812221_> I believe we just have to clear the build cache. It will work again as well. 03:40 < ken2812221_> I clear the cache on my appveyor project, the build result turns out green. 03:42 < ken2812221_> Actually, we could add build matrix to both test mingw and msvc binaries. But it would be really slow. 03:42 < wumpus> we already test mingw in travis 03:42 < wumpus> I don't think it's necessary to do this in appveyor too 03:43 < ken2812221_> But no functional test. 03:43 < wumpus> that's simply because they don't pass at the moment 03:43 < wumpus> they were enabled at some point in the past 03:43 < wumpus> but they're flaky 03:44 < ken2812221_> I'm trying to solve this problem on #14007 03:44 < gribble> https://github.com/bitcoin/bitcoin/issues/14007 | tests: Run functional test on Windows by ken2812221 · Pull Request #14007 · bitcoin/bitcoin · GitHub 03:45 < wumpus> okay on travis they ran in wine, instead of windows 03:48 < ken2812221_> Yes, we should test it on real Windows. 03:48 < wumpus> but yes mingw on windows is really, really slow 03:49 < wumpus> (in compile time) 03:49 < wumpus> anyhow if clearing the cache works, let's do that 03:51 < ken2812221_> https://github.com/krlmlr/r-appveyor/issues/98#issuecomment-395123720 I believe that this is the easiest way to clear cache, appveyor does not have "clear cache" button. 03:52 < wumpus> ooh apparently I can log in as drahtbot into appveyor 03:52 < wumpus> maybe it means I can do things like clear the cache now 03:53 < wumpus> ok thank you 03:54 < wumpus> hehe the mozilla javascript console blocks pasting by default, with a warning about scams, makes sense 03:54 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 03:54 < wumpus> so in my case this would be https://ci.appveyor.com/api/projects/DrahtBot/bitcoin/buildcache , hope it worked 03:55 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 03:58 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-kpymbpbxmetzmxnp] has joined #bitcoin-core-dev 03:59 < ken2812221_> Seems it does not work, maybe it should be done by MarcoFalke 03:59 < wumpus> sigh-- 04:03 -!- zivl [~zivl@2601:19a:837f:e4e1:b8e7:bf0:2609:de60] has joined #bitcoin-core-dev 04:06 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 04:07 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-nbcycyznupmecywh] has joined #bitcoin-core-dev 04:07 < bitcoin-git> [bitcoin] laanwj opened pull request #14105: util: Report parse errors in configuration file (master...2018_08_parse_error_reporting) https://github.com/bitcoin/bitcoin/pull/14105 04:07 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-nbcycyznupmecywh] has left #bitcoin-core-dev [] 04:10 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Remote host closed the connection] 04:13 -!- Randolf [~randolf@96.53.47.42] has quit [Remote host closed the connection] 04:15 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev 04:23 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 04:35 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-vwlqersavaqdmphg] has joined #bitcoin-core-dev 04:35 < bitcoin-git> [bitcoin] mkjekk opened pull request #14106: 0.17 (master...0.17) https://github.com/bitcoin/bitcoin/pull/14106 04:35 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-vwlqersavaqdmphg] has left #bitcoin-core-dev [] 04:37 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-mgdchwgnyljqzkqc] has joined #bitcoin-core-dev 04:37 < bitcoin-git> [bitcoin] laanwj closed pull request #14106: 0.17 (master...0.17) https://github.com/bitcoin/bitcoin/pull/14106 04:37 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-mgdchwgnyljqzkqc] has left #bitcoin-core-dev [] 04:41 -!- roban [~roban@ptr-g0tztx6yxkh615lj6ol.18120a2.ip6.access.telenet.be] has joined #bitcoin-core-dev 04:45 -!- roban [~roban@ptr-g0tztx6yxkh615lj6ol.18120a2.ip6.access.telenet.be] has left #bitcoin-core-dev [] 04:54 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-rkqmtprwhaglkpxp] has joined #bitcoin-core-dev 04:54 < bitcoin-git> [bitcoin] MarcoFalke pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/be301a577776...6c7cfc8da68a 04:54 < bitcoin-git> bitcoin/master db5e9d3 practicalswift: Add missing locks (cs_args) 04:54 < bitcoin-git> bitcoin/master d58dc9f practicalswift: Add lock annotations (cs_args) 04:54 < bitcoin-git> bitcoin/master 1e29379 practicalswift: Fix potential deadlock 04:54 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-rkqmtprwhaglkpxp] has left #bitcoin-core-dev [] 04:55 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-wqbrfvpovwzhnwyi] has joined #bitcoin-core-dev 04:55 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #13126: util: Add Clang thread safety annotations for variables guarded by cs_args (master...guarded-by-cs_args) https://github.com/bitcoin/bitcoin/pull/13126 04:55 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-wqbrfvpovwzhnwyi] has left #bitcoin-core-dev [] 04:55 -!- IGHOR [~quassel@93.178.216.72] has quit [Quit: No Ping reply in 180 seconds.] 04:55 -!- Rootsudo [~textual@180.191.157.73] has joined #bitcoin-core-dev 04:58 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev 04:58 -!- _flow_ [~none@2001:638:a000:4140::ff10:844c] has joined #bitcoin-core-dev 05:05 -!- kallewoof [~quassel@fp96f94c66.tkyc515.ap.nuro.jp] has quit [Read error: Connection reset by peer] 05:18 -!- kallewoof [~quassel@240d:1a:759:6000:a7b1:451a:8874:e1ac] has joined #bitcoin-core-dev 05:24 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 05:34 -!- booyah [~bb@193.25.1.157] has quit [Quit: Konversation terminated!] 05:35 -!- Rootsudo [~textual@180.191.157.73] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 05:36 -!- Rootsudo [~textual@180.191.157.73] has joined #bitcoin-core-dev 05:36 -!- Rootsudo [~textual@180.191.157.73] has quit [Client Quit] 05:36 -!- phwalkr [~phwalkr@2001:1284:f016:19d7:ec47:564:3dba:abc0] has joined #bitcoin-core-dev 05:37 -!- Rootsudo [~textual@180.191.157.73] has joined #bitcoin-core-dev 05:37 -!- Rootsudo [~textual@180.191.157.73] has quit [Client Quit] 05:38 -!- Rootsudo [~textual@180.191.157.73] has joined #bitcoin-core-dev 05:38 -!- Rootsudo [~textual@180.191.157.73] has quit [Client Quit] 05:39 -!- Rootsudo [~textual@180.191.157.73] has joined #bitcoin-core-dev 05:39 -!- Rootsudo [~textual@180.191.157.73] has quit [Client Quit] 05:41 -!- thib [~thib@wikimedia/Thibaut120094] has quit [Quit: leaving] 05:43 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 05:45 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 05:47 -!- leishman [~leishman@2604:5500:c225:c500:e979:b47b:8eca:9767] has joined #bitcoin-core-dev 05:52 -!- leishman [~leishman@2604:5500:c225:c500:e979:b47b:8eca:9767] has quit [Ping timeout: 260 seconds] 05:53 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 06:01 < ken2812221_> OK, appveyor cache cleared. 06:04 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-rlptneulumtrmexo] has joined #bitcoin-core-dev 06:04 < bitcoin-git> [bitcoin] ken2812221 closed pull request #13515: travis: avoid timeout without saving caches, also enable all qt (master...travis_qt) https://github.com/bitcoin/bitcoin/pull/13515 06:04 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-rlptneulumtrmexo] has left #bitcoin-core-dev [] 06:07 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 06:08 -!- brianhoffman [~brianhoff@pool-108-31-201-103.washdc.fios.verizon.net] has left #bitcoin-core-dev [] 06:10 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 06:12 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Read error: Connection reset by peer] 06:12 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 06:12 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Remote host closed the connection] 06:13 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-neudpwzxqdyzyxbo] has joined #bitcoin-core-dev 06:13 < bitcoin-git> [bitcoin] practicalswift opened pull request #14107: wallet: Remove unused function GetLabelDestination (master...deadc0de) https://github.com/bitcoin/bitcoin/pull/14107 06:13 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-neudpwzxqdyzyxbo] has left #bitcoin-core-dev [] 06:18 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 06:23 -!- odk [~opdenkamp@D93F2BCF.cm-20.dynamic.ziggo.nl] has quit [Quit: ZNC 1.6.5+deb1 - http://znc.in] 06:26 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 06:53 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 06:54 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 06:54 -!- vexbuy [~vexbuy@147.red-83-47-212.dynamicip.rima-tde.net] has joined #bitcoin-core-dev 07:06 -!- shesek [~shesek@bzq-84-110-232-211.red.bezeqint.net] has joined #bitcoin-core-dev 07:06 -!- shesek [~shesek@bzq-84-110-232-211.red.bezeqint.net] has quit [Changing host] 07:06 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 07:11 -!- Krellan [~Krellan@2601:640:4000:9258:b457:151c:3069:cdfc] has quit [Ping timeout: 250 seconds] 07:11 -!- Krellan [~Krellan@2601:640:4000:9258:b457:151c:3069:cdfc] has joined #bitcoin-core-dev 07:11 -!- abrarisme [46304131@gateway/web/freenode/ip.70.48.65.49] has joined #bitcoin-core-dev 07:19 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-gshlswzkxyxhlxbv] has joined #bitcoin-core-dev 07:19 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/6c7cfc8da68a...07033a8f9197 07:19 < bitcoin-git> bitcoin/master c9c32e6 John Newbery: [wallet] Kill accounts... 07:19 < bitcoin-git> bitcoin/master 07033a8 Wladimir J. van der Laan: Merge #13825: [wallet] Kill accounts... 07:19 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-gshlswzkxyxhlxbv] has left #bitcoin-core-dev [] 07:19 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-snnzroigfzkaoiby] has joined #bitcoin-core-dev 07:19 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #14107: wallet: Remove unused function GetLabelDestination (master...deadc0de) https://github.com/bitcoin/bitcoin/pull/14107 07:19 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-snnzroigfzkaoiby] has left #bitcoin-core-dev [] 07:20 -!- peevsie [~peevsie@2604:2000:f18f:e300::5] has joined #bitcoin-core-dev 07:21 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-dsigzfjtjjockgoz] has joined #bitcoin-core-dev 07:21 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #13825: [wallet] Kill accounts (master...kill_accounts) https://github.com/bitcoin/bitcoin/pull/13825 07:21 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-dsigzfjtjjockgoz] has left #bitcoin-core-dev [] 07:23 < instagibbs> MarcoFalke, sorry for noob but why you close #14107 ? Doesn't say there's a merge conflict? 07:23 < gribble> https://github.com/bitcoin/bitcoin/issues/14107 | wallet: Remove unused function GetLabelDestination by practicalswift · Pull Request #14107 · bitcoin/bitcoin · GitHub 07:26 < wumpus> I think it's included in https://github.com/bitcoin/bitcoin/commit/c9c32e6b844fc79467b7e24c6c916142a0d08484 07:28 < instagibbs> ah ok 07:29 < wumpus> if a commit does exactly the same as a previous commit and is anchored at a point before the change was done, I don't think you get a merge conflict 07:30 < wumpus> it's still useless to do of course :) 07:32 -!- abrarisme [46304131@gateway/web/freenode/ip.70.48.65.49] has quit [Quit: Page closed] 07:34 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-qdudhavojgciphij] has joined #bitcoin-core-dev 07:34 < bitcoin-git> [bitcoin] practicalswift opened pull request #14108: tests: Add missing locking annotations and locks (master...mapOrphanTransactions-is-guarded-by-g_cs_orphans) https://github.com/bitcoin/bitcoin/pull/14108 07:34 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-qdudhavojgciphij] has left #bitcoin-core-dev [] 07:41 -!- hebasto [~hebasto@195.60.70.234] has joined #bitcoin-core-dev 07:43 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev 07:44 -!- phwalkr [~phwalkr@2001:1284:f016:19d7:ec47:564:3dba:abc0] has quit [Remote host closed the connection] 07:47 < hebasto> luke-jr: regarding PR#14037: I've received your review by email but can't see it on GitHub. 07:47 < gribble> https://github.com/bitcoin/bitcoin/issues/14037 | Add README.md to linux release tarballs by hebasto · Pull Request #14037 · bitcoin/bitcoin · GitHub 07:53 -!- vexbuy [~vexbuy@147.red-83-47-212.dynamicip.rima-tde.net] has quit [Remote host closed the connection] 07:53 -!- vexbuy [~vexbuy@89.39.107.191] has joined #bitcoin-core-dev 07:58 -!- Krellan [~Krellan@2601:640:4000:9258:b457:151c:3069:cdfc] has quit [Ping timeout: 240 seconds] 07:58 -!- vexbuy [~vexbuy@89.39.107.191] has quit [Client Quit] 07:59 -!- Krellan [~Krellan@2601:640:4000:9258:b457:151c:3069:cdfc] has joined #bitcoin-core-dev 08:08 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 246 seconds] 08:08 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 08:42 -!- diz23 [~diz@81.141.213.111] has joined #bitcoin-core-dev 08:42 < diz23> A fascinating blog where freenode staff member Matthew mst Trout recounts his experiences of eye-raping young children https://MattSTrout.com/ 08:42 < diz23> I thought you guys might be interested in this blog by freenode staff member Bryan kloeri Ostergaard https://bryanostergaard.com/ 08:42 < diz23> With our IRC ad service you can reach a global audience of entrepreneurs and fentanyl addicts with extraordinary engagement rates! https://williampitcock.com/ 08:42 < diz23> Read what IRC investigative journalists have uncovered on the freenode pedophilia scandal https://encyclopediadramatica.rs/Freenodegate 08:44 -!- mode/#bitcoin-core-dev [+o sipa] by ChanServ 08:44 -!- mode/#bitcoin-core-dev [+r] by sipa 08:44 -!- mode/#bitcoin-core-dev [-o sipa] by sipa 08:45 -!- diz23 [~diz@81.141.213.111] has quit [Remote host closed the connection] 08:46 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 08:48 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 09:11 < sipa> i won't attend the meeting today 09:12 < sipa> but as a topic, perhaps someone should go through the list of merged PRs in 0.17 to see if any are missing release notes 09:17 < gmaxwell> I was going to come up with a commandline people could run which would curl the list of merged PRs and run it through shuf and head and ask everyone to look at the top bunch to see if the need release notes, but the list of merged PRs isn't up yet. 09:19 -!- Randolf [~randolf@96.53.47.38] has joined #bitcoin-core-dev 09:36 < gmaxwell> here is an approximation: git log --since=2018-02-01 --merges | grep 'Merge #' | shuf | head 09:36 < gmaxwell> maybe we could ask everyone in the meeting to run that and check the results against the current release notes draft and see if they get anything they think needs notes. :) 09:39 -!- Randolf [~randolf@96.53.47.38] has quit [Quit: Leaving] 09:41 < echeveria> /query *otr 09:42 < echeveria> ffs. 09:43 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 09:46 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 09:54 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 09:55 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 10:14 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 10:16 -!- harrymm [~harrymm@69.161.195.103] has quit [Ping timeout: 252 seconds] 10:18 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 252 seconds] 10:25 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 10:27 < wumpus> there's still a few things in #12391 too that need release notes 10:27 < gribble> https://github.com/bitcoin/bitcoin/issues/12391 | TODO for release notes 0.17.0 · Issue #12391 · bitcoin/bitcoin · GitHub 10:29 -!- harrymm [~harrymm@69.161.195.103] has joined #bitcoin-core-dev 10:29 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds] 10:35 -!- sneakerhax [~sneakers@unaffiliated/sneakerhead] has joined #bitcoin-core-dev 10:42 -!- daouzo23 [~user@178.115.131.84.wireless.dyn.drei.com] has joined #bitcoin-core-dev 10:47 < midnightmagic> I know I've asked this before, but can anyone tell me if the meta-data in the github instance is being archived somewhere (still)? 10:53 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 10:54 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 11:05 < phantomcircuit> while implementing logic for poll() i've run into an interesting issue 11:05 < phantomcircuit> https://github.com/pstratem/bitcoin/commit/03fba51baf35824fb9e55caf2384bbd7626c5dc5#diff-9a82240fe7dfe86564178691cc57f2f1R319 11:05 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 11:05 < phantomcircuit> compile fails https://0bin.net/paste/M-ESIY-7HRgIM6qK#rCpHK4Oxjyy9aiuMIZ7Av28dp8QSD3CBORpKoyw4-wp 11:06 < phantomcircuit> with net.cpp:2188:39: error: no matching function for call to ‘CConnman::RegisterListenSocket(SOCKET&)’ 11:06 < phantomcircuit> but RegisterListenSocket(hListenSocket); hListenSocket is actually a struct ListenSocket 11:06 -!- Krellan [~Krellan@2601:640:4000:9258:b457:151c:3069:cdfc] has quit [Remote host closed the connection] 11:06 < wumpus> midnightmagic: yes, it is, at git@github.com:zw/bitcoin-gh-meta.git 11:08 < echeveria> midnightmagic: wumpus: the whole of github is archived in real time. 11:08 < echeveria> https://www.gharchive.org/ 11:09 < wumpus> echeveria: nice, that could be useful too I guess 11:10 < wumpus> the more mirrors the better 11:14 < midnightmagic> wumpus: thank you 11:14 < midnightmagic> echeveria: thank you 11:17 < midnightmagic> heh heh heh! 11:27 -!- leishman [~leishman@50.237.29.22] has joined #bitcoin-core-dev 11:27 < wumpus> and yes, I'll add the PR list and author list into the preliminary release notes soon 11:32 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 11:36 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 252 seconds] 11:43 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 11:44 -!- leishman [~leishman@50.237.29.22] has quit [Remote host closed the connection] 11:45 -!- phwalkr [~phwalkr@2001:1284:f016:19d7:dcac:99a5:6019:e183] has joined #bitcoin-core-dev 11:50 -!- daouzo23 [~user@178.115.131.84.wireless.dyn.drei.com] has quit [Quit: daouzo23] 11:57 -!- grubles_ [~grubles@gateway/tor-sasl/grubles] has joined #bitcoin-core-dev 11:57 -!- grubles [~grubles@gateway/tor-sasl/grubles] has quit [Remote host closed the connection] 12:01 < promag> meeting? 12:01 < wumpus> #startmeeting 12:01 < lightningbot> Meeting started Thu Aug 30 19:01:18 2018 UTC. The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot. 12:01 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic. 12:01 < jonasschnelli> \o 12:01 < jonasschnelli> \o 12:01 < promag> howdy 12:01 < jonasschnelli> o/ 12:01 < wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator 12:02 < kanzure> hi. 12:02 < achow101> hi 12:02 < meshcollider> hi 12:03 < wumpus> so re: 0.17.0 it seems we still have a few issues 12:03 < wumpus> https://github.com/bitcoin/bitcoin/milestone/33 12:03 < gmaxwell> Hi. 12:03 < kanzure> topic: i am collecting topics for coredevtech tokyo; please submit topic suggestions to me, things that you would like to speak about, or things that you would prefer others to speak about, could be anything from source code things to BIPs to mailing list stuff, or complaints about twitter. 12:03 < wumpus> looks like the most serious one is a possible incompatibility when going back to 0.16.2 12:03 < wumpus> #14048 12:03 < gribble> https://github.com/bitcoin/bitcoin/issues/14048 | 0.16.2 binary gives error after latest compiled client has run · Issue #14048 · bitcoin/bitcoin · GitHub 12:04 < instagibbs> hi 12:04 < achow101> wasn't there a change to how txindex is handled now? 12:04 < gmaxwell> I no longer think #14109 is blocking, it appears to be a measurement artifact. pages in the cache in read only mmaps show up in res. 12:04 < gribble> https://github.com/bitcoin/bitcoin/issues/14109 | ibd memory usage up in 0.17 · Issue #14109 · bitcoin/bitcoin · GitHub 12:04 < wumpus> there's also possible working memory use increase during IBD ( #14109) 12:04 < gribble> https://github.com/bitcoin/bitcoin/issues/14109 | ibd memory usage up in 0.17 · Issue #14109 · bitcoin/bitcoin · GitHub 12:04 < achow101> so that's probably what is causing the problem 12:04 < wumpus> gmaxwell: good to know! 12:04 < jonasschnelli> Also #14104 is eventually something we want to take a look (or at least mention in the RN) 12:04 < gribble> https://github.com/bitcoin/bitcoin/issues/14104 | 0.17.2rc issue (standardness change for bare multisig) · Issue #14104 · bitcoin/bitcoin · GitHub 12:05 < wumpus> ok tagging that with 0.17.0 12:05 < jonasschnelli> sipas script template remove (#13194) caused a tiny isStandard different for bare multisig 12:05 < gribble> https://github.com/bitcoin/bitcoin/issues/13194 | Remove template matching and pseudo opcodes by sipa · Pull Request #13194 · bitcoin/bitcoin · GitHub 12:05 < wumpus> hadn't seen that one but it looks like it is expected? 12:06 < wumpus> ah 12:06 < jonasschnelli> Invalid pubkeys with the right size was standard until 0.17 12:06 < jonasschnelli> Now, it checks the first byte (compress, uncompressed, etc.). Before it just had to be 33 or 65 bytes. 12:06 < gmaxwell> jonasschnelli: what does invalid here mean? the initial byte isn't ne of the right flags? 12:06 < gmaxwell> okay. 12:07 < wumpus> I'd say the new way is better then? 12:07 < gmaxwell> (just making sure we weren't doing the on-the-curve check, since thats slow) 12:07 < jonasschnelli> It looks like people have stuffed 33 bytes into a bare multisig for some unknown reason 12:07 < jonasschnelli> (probably to make some data public available ala OP_RETURN) 12:07 < wumpus> well you can't avoid people stuffing other things in them, but making sure they look like valid keys makes some sense 12:08 < gmaxwell> The new way is a reasonable behavior. it will inhibit some kind of non-op-return store-data-in-the-utxo set behavior. 12:08 < jonasschnelli> heh. Yes. I think we should just mention that in the release notes 12:08 < wumpus> right 12:08 < gmaxwell> yes, should be release noted. 12:09 < wumpus> posted it in #12391 12:09 < gribble> https://github.com/bitcoin/bitcoin/issues/12391 | TODO for release notes 0.17.0 · Issue #12391 · bitcoin/bitcoin · GitHub 12:10 < jonasschnelli> For #14048, I think its acceptable to require to create the txindex again when downgrade from 17 to 16... 12:10 < gribble> https://github.com/bitcoin/bitcoin/issues/14048 | 0.16.2 binary gives error after latest compiled client has run · Issue #14048 · bitcoin/bitcoin · GitHub 12:10 < gmaxwell> jonasschnelli: I agree, but it needs to be release noted. 12:10 < wumpus> oh this is because of the txindex update? of course, gah 12:10 < wumpus> what is the PR that changed the txindex? 12:10 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has joined #bitcoin-core-dev 12:11 < jonasschnelli> #13033 12:11 < gribble> https://github.com/bitcoin/bitcoin/issues/13033 | Build txindex in parallel with validation by jimpo · Pull Request #13033 · bitcoin/bitcoin · GitHub 12:11 < jonasschnelli> (i think) 12:11 < promag> also related #13243 12:11 < gribble> https://github.com/bitcoin/bitcoin/issues/13243 | Make reusable base class for auxiliary indices by jimpo · Pull Request #13243 · bitcoin/bitcoin · GitHub 12:12 -!- willyko_ [8700b846@gateway/web/freenode/ip.135.0.184.70] has joined #bitcoin-core-dev 12:12 < willyko_> yaas finally got my gitian build to work 12:13 < wumpus> ok added 12:14 < wumpus> for the rest there is some documentation confusion which I *try* to clear up in #14100 12:14 < gribble> https://github.com/bitcoin/bitcoin/issues/14100 | doc: Change documentation for =0 for non-boolean options by laanwj · Pull Request #14100 · bitcoin/bitcoin · GitHub 12:14 -!- plankers [~plank@c-98-238-141-78.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 12:14 < wumpus> at least if I do understand it correctly 12:15 < jonasschnelli> Added a new minor issue for 0.17 #14114 12:15 < gribble> https://github.com/bitcoin/bitcoin/issues/14114 | scantxoutset help about descriptors refers to TODO document · Issue #14114 · bitcoin/bitcoin · GitHubAsset 1Asset 1 12:17 < wumpus> oops 12:17 < gmaxwell> pieter opened a PR to fill in the docs. 12:17 < gmaxwell> #14096 12:17 < gribble> https://github.com/bitcoin/bitcoin/issues/14096 | Add reference documentation for descriptors language by sipa · Pull Request #14096 · bitcoin/bitcoin · GitHub 12:18 < wumpus> yes, that is already tagged 0.17.0 12:18 < gmaxwell> so it fixes 14114 12:18 < wumpus> right 12:19 < jonasschnelli> Oh. Wasn't aware 12:20 < wumpus> one topic I'd like to discuss is where to move tinyformat in the source tree, if we're going to do that at all, I hate it when there's two competing PRs open for something 12:20 * jonasschnelli is lost in PRs 12:20 < wumpus> #topic tinyformat move 12:20 < wumpus> e.g.: #13846, #13845, or keep as is 12:20 < gribble> https://github.com/bitcoin/bitcoin/issues/13846 | Move src/tinyformat.h to src/tinyformat/tinyformat.h by Empact · Pull Request #13846 · bitcoin/bitcoin · GitHub 12:20 < gribble> https://github.com/bitcoin/bitcoin/issues/13845 | Include tinyformat as a subtree by Empact · Pull Request #13845 · bitcoin/bitcoin · GitHubAsset 1Asset 1 12:21 < wumpus> I'm ok with all three options but not with leaving those PRs open forever 12:21 -!- GoldenBear [~gb@tilde.team] has quit [Quit: ZNC 1.6.6+deb1 - http://znc.in] 12:21 -!- GoldenBear [~gb@tilde.team] has joined #bitcoin-core-dev 12:22 < jonasschnelli> The subtree looked to me after an overkill,... I would prefer #13846 (no strong opinion) 12:22 < gribble> https://github.com/bitcoin/bitcoin/issues/13846 | Move src/tinyformat.h to src/tinyformat/tinyformat.h by Empact · Pull Request #13846 · bitcoin/bitcoin · GitHubAsset 1Asset 1 12:22 < wumpus> I guess MarcoFalke is not here? 12:23 < wumpus> I think he has the strongest opinion about it 12:23 < gmaxwell> would we really do a subtree for a single file? 12:23 < wumpus> no. 12:24 < wumpus> I think this is pretty much unnecessary, and certainly the subtree one contains lots of changes 12:24 < gmaxwell> seems like change for the sake of change to me. 12:24 < wumpus> too much of that 12:25 < achow101> I'm in favor of keeping it as is 12:26 < wumpus> ok, other proposed topics? 12:26 < wumpus> I guess we haven't had high prio for review yet 12:26 < wumpus> #topic high priority for review 12:26 < wumpus> https://github.com/bitcoin/bitcoin/projects/8 12:27 < jonasschnelli> I'd like to add #14046 12:27 < wumpus> we made quite a lot of progress there this week 12:27 < gribble> https://github.com/bitcoin/bitcoin/issues/14046 | net: Refactor message parsing (CNetMessage), adds flexibility by jonasschnelli · Pull Request #14046 · bitcoin/bitcoin · GitHub 12:27 < wumpus> only three left 12:27 < wumpus> added 12:28 < achow101> can I get #14019 for hi prio? 12:28 < gribble> https://github.com/bitcoin/bitcoin/issues/14019 | Import pubkeys when importing p2sh with importmulti by achow101 · Pull Request #14019 · bitcoin/bitcoin · GitHub 12:29 < wumpus> achow101: you already have one 12:29 < achow101> replace it with that one 12:29 < wumpus> ok 12:29 < wumpus> done 12:30 < ken2812221_> wumpus: I want to replace #13866 with #13878 12:30 < gribble> https://github.com/bitcoin/bitcoin/issues/13866 | utils: Use _wfopen and _wfreopen on Windows by ken2812221 · Pull Request #13866 · bitcoin/bitcoin · GitHubAsset 1Asset 1 12:30 < gribble> https://github.com/bitcoin/bitcoin/issues/13878 | utils: Add fstream wrapper to allow to pass unicode filename on Windows by ken2812221 · Pull Request #13878 · bitcoin/bitcoin · GitHubAsset 1Asset 1 12:30 < wumpus> ken2812221_: you really need to find someone that can review windows stuff :) 12:31 < wumpus> anyhow - replaced 12:31 < ken2812221_> I am not sure that who knows about Windows thing. 12:31 < wumpus> maybe sipsorcery (who contributed the MSVC build) 12:32 < wumpus> which reminds me of #14089 12:32 < gribble> https://github.com/bitcoin/bitcoin/issues/14089 | CryptGenRandom is deprecated by fingera · Pull Request #14089 · bitcoin/bitcoin · GitHub 12:32 < wumpus> I'd, personally, prefer to close that one 12:33 < wumpus> or what luke-jr says, add it as extra random source, that can't hurt 12:34 < jonasschnelli> deprecated PRNG may have less backdoors. :) 12:34 < wumpus> right, good to be very careful here 12:35 < ken2812221_> anyway, I don't have a strong opinion. 12:35 < gmaxwell> when we finally do move off of openssl as an input, we'll add additional randomness inputs, making that stuff slightly less critical. 12:35 < gmaxwell> ken2812221_: what caused you to be aware of the deprecation? 12:36 < wumpus> he only concept-ACKed it 12:36 < ken2812221_> Well, that is not my PR. 12:37 < wumpus> NicolasDorier NACKed it (with rationale) 12:37 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 12:37 < wumpus> he's another person that knows things about windows btw, you could maybe ping him in your other PRs ken2812221_ :) 12:38 < ken2812221_> Thank you, wumpus 12:38 < gmaxwell> ken2812221_: oh sorry, its fingera's PR. my mistake. 12:40 < wumpus> ok, any other topics? 12:41 < wumpus> ken2812221_: would be nice to get your PRs in for 0.18 and fix the windows unicode issues once and for all 12:42 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Ping timeout: 245 seconds] 12:42 < ken2812221_> I'm not sure if this fix all problems, it needs more and more tests. 12:42 < ken2812221_> But we have 6+ months to test it. 12:42 < wumpus> yes, better to merge it soon in that regard 12:43 -!- Rootsudo [~textual@180.191.157.73] has joined #bitcoin-core-dev 12:44 < wumpus> so if no other topics I'm going to close the meeting 12:45 < wumpus> #endmeeting 12:45 < lightningbot> Meeting ended Thu Aug 30 19:45:34 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) 12:45 < lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-08-30-19.01.html 12:45 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-08-30-19.01.txt 12:45 < lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-08-30-19.01.log.html 12:45 < phantomcircuit> while people are here 12:46 < gmaxwell> phantomcircuit has almost finished a patch to switch to poll but is stuck on some C++ confusion. 12:46 -!- phwalkr [~phwalkr@2001:1284:f016:19d7:dcac:99a5:6019:e183] has quit [Remote host closed the connection] 12:46 < phantomcircuit> https://github.com/pstratem/bitcoin/commit/03fba51baf35824fb9e55caf2384bbd7626c5dc5#diff-9a82240fe7dfe86564178691cc57f2f1R319 12:46 < phantomcircuit> https://0bin.net/paste/M-ESIY-7HRgIM6qK#rCpHK4Oxjyy9aiuMIZ7Av28dp8QSD3CBORpKoyw4-wp 12:46 < promag> wumpus: regarding min qt, shouldn't we just use the current qt lts? 12:46 < phantomcircuit> net.cpp:2188:39: error: no matching function for call to ‘CConnman::RegisterListenSocket(SOCKET&)’ 12:46 < gmaxwell> I looked at it, but must be a blonde day for me... 12:47 -!- phwalkr [~phwalkr@2001:1284:f016:19d7:dcac:99a5:6019:e183] has joined #bitcoin-core-dev 12:47 < promag> too bad if distributions use less than that? 12:47 < phantomcircuit> but im pretty clear that im calling RegisterListenSocket(hSocketListen) and hSocketListen is a const ListenSocket& 12:47 < phantomcircuit> any ideas? 12:49 < wumpus> promag: so that is 5.5? 12:49 < promag> 5.9 12:49 < wumpus> phantomcircuit: will have a look 12:50 < wumpus> phantomcircuit: the branch is 2018-08-29-poll? 12:50 < wumpus> I rather check locally instead of on gh 12:51 -!- phwalkr [~phwalkr@2001:1284:f016:19d7:dcac:99a5:6019:e183] has quit [Ping timeout: 252 seconds] 12:54 -!- willyko_ [8700b846@gateway/web/freenode/ip.135.0.184.70] has quit [Ping timeout: 252 seconds] 12:56 < wumpus> ok this is really strange 12:56 * wumpus wishes c++ had helpful warnings like rust 12:57 < promag> it's not strange 12:57 < midnightmagic> I thought clang having helpful warnings was one of the whole reasons for its existence 12:58 < promag> the correct line is https://github.com/bitcoin/bitcoin/blob/03fba51baf35824fb9e55caf2384bbd7626c5dc5/src/net.cpp#L2188 12:58 < promag> there type of hListenSocket is SOCKET 12:58 < wumpus> promag: yes! 12:58 < wumpus> was looking at the wrong caller function 12:59 < wumpus> the argument to RegisterListenSocket is a ListenSocket structure, which has a SOCKET and a whiltelisting flag 12:59 < promag> me too, but then I say the line.. 12:59 < promag> *saw 13:01 < wumpus> I only noticed it when I replaced the argument with a copy of the structure, then noticed the variable name in the compiler error didn't change 13:02 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 13:03 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 13:03 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 13:03 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 13:04 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 13:05 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Read error: Connection reset by peer] 13:05 -!- Krellan_ [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 13:08 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-kpymbpbxmetzmxnp] has quit [Quit: Connection closed for inactivity] 13:09 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 13:10 < wumpus> phantomcircuit: so on the line below it, 2189, a ListenSocket is actually constructed with ListenSocket(hListenSocket, fWhitelisted) 13:10 < wumpus> though I'm not sure you need to call it there at all, as RegisterListenSocket will already be called with everything in that vector it is added to 13:18 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 13:19 -!- Rootsudo [~textual@180.191.157.73] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 13:19 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection] 13:20 < luke-jr> sorry I missed the meeting 13:21 < luke-jr> would be nice if people look at and decide between the two ARM/RISC-V symbol check things - either one is a fine starting point IMO 13:21 < luke-jr> hebasto: I deleted it because I noticed it was the binary tarball, not sources 13:21 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Read error: Connection reset by peer] 13:21 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev 13:21 < wumpus> luke-jr: my vote would be little-endian only 13:22 < wumpus> luke-jr: oh, that's not what you mean 13:23 < hebasto> luke-jr: Thank you for clarification. 13:23 < wumpus> yes the symbol check thing is another thing with competing PRs 13:23 < wumpus> tbh for such scripts I care very little as long as they do what they should do 13:24 < promag> what is going on in #14090? :S 13:24 < gribble> https://github.com/bitcoin/bitcoin/issues/14090 | [windows] progress bar in task bar by alexeyneu · Pull Request #14090 · bitcoin/bitcoin · GitHub 13:25 < luke-jr> wumpus: I'm inclined to just close mine and rebase on the other one 13:25 < luke-jr> maybe clean it up slightly (grouping the arch configurations together) 13:26 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 13:26 < wumpus> yes, rebasing one on top of the other would be great and make it much easier to go ahead 13:26 < wumpus> promag: good question... 13:27 < wumpus> promag: I've unsubscribed from it, was kind of annoyed by the author 13:28 < phantomcircuit> wumpus, oh snap yeah i see what it is 13:28 < wumpus> didn't want to close it in case anyone else wanted to guide them toward getting the PR to a mergable state, as the functionality looks useful, but if it's a lost cause we probably should 13:29 < phantomcircuit> promag, ty 13:29 < luke-jr> I suspect a language barrier in that one 13:29 < phantomcircuit> gmaxwell, derp 13:29 < phantomcircuit> was the answer of course 13:29 < luke-jr> he thought I was trying to make a joke when I said to not touch unrelated whitespace O.o 13:30 < wumpus> yes he seems like an impossible person 13:30 < wumpus> goes to argue against all review comments 13:30 < promag> I guess I'll open a new one with the winextra 13:31 < luke-jr> :x 13:31 < promag> don't care? :D 13:31 < wumpus> looks like either a language barrier or at the least a strong misunderstanding how contributing to open source works, that was clear from the first post 13:32 < luke-jr> I would prefer fixing the communications and teaching him to do it right, so he doesn't think we're just a clique 13:32 < luke-jr> (and hopefully contributes more in the future) 13:32 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 13:32 < wumpus> yes, if you think there's any hope of that, that'd be preferable 13:33 < promag> ok then, my suggestion is there 13:34 -!- Rootsudo [~textual@180.191.157.73] has joined #bitcoin-core-dev 13:50 < phantomcircuit> if select() fails we're currently setting every fd in fdsetRecv so that the loop immediately after will call recv for every node 13:50 < phantomcircuit> that doesn't seem to make much sense 13:52 < phantomcircuit> this logic goes back to satoshi also so ? 13:53 < wumpus> yes, that doesn't sound very sensible to me either... 13:59 < phantomcircuit> seems like if select() fails we should sleep for a bit and continue the loop? 14:00 < phantomcircuit> actually it seems like every way this can fail except EINTR is basically catastrophic 14:03 -!- bitconner [~conner@c-67-188-149-218.hsd1.ca.comcast.net] has quit [Ping timeout: 240 seconds] 14:29 -!- Rootsudo [~textual@180.191.157.73] has quit [Ping timeout: 245 seconds] 14:39 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 14:43 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 14:47 < gmaxwell> Bustapay ftw. 14:48 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 245 seconds] 14:48 < gmaxwell> achow101: See https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2018-August/016340.html ? 14:49 < achow101> cool! 14:54 < instagibbs> Dr Maxwell makes his return 14:54 < instagibbs> I gave some technical feeback over hte last week; pretty cool to see it live :) 15:09 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection] 15:18 < grubles_> cool stuff 15:18 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 15:23 -!- peevsie [~peevsie@2604:2000:f18f:e300::5] has quit [Ping timeout: 250 seconds] 15:33 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 240 seconds] 15:33 -!- profmac [~ProfMac@2001:470:1f0f:226:59c1:92de:5e2b:4b8] has quit [Read error: Connection reset by peer] 15:34 -!- profmac [~ProfMac@2001:470:1f0f:226:dd7f:7f16:dc97:4746] has joined #bitcoin-core-dev 15:35 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 15:42 -!- plankers [~plank@c-98-238-141-78.hsd1.ca.comcast.net] has quit [Quit: Leaving.] 15:46 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Quit: WeeChat 2.0] 15:47 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 16:07 < echeveria> gmaxwell: I can see people doing this really badly. 16:08 -!- sneakerhax [~sneakers@unaffiliated/sneakerhead] has quit [Ping timeout: 252 seconds] 16:08 < echeveria> gmaxwell: it also requires that the sender can process the transaction before the HTTP request times out. 16:09 < echeveria> gmaxwell: you can also hammer the remote to enumerate their outputs, but never submit a result. 16:10 < gmaxwell> echeveria: hm? No. you can only learn one output from the remote per output you spend. 16:11 < gmaxwell> You connect to the merchant and give him a valid txn ready for broadcast. He responds with an updated version that includes his output. If you don't reply, he sends the original to the network. 16:12 < echeveria> "Doing so will invalidate the "template transaction"'s original input signatures, so the sender needs to return this "partial transaction" back to the receiver to sign. This is returned as a hex-encoded raw transaction a response to the original HTTP POST request." 16:12 < echeveria> "The receiver is responsible in making sure the "partial transaction" returned by the sender was changed correctly (it should assume the connection has been MITM'd and act accordingly), resign its original inputs and propagates this transaction over the bitcoin network. The client must be aware that the server can reorder inputs and outputs." 16:13 < echeveria> oh. 16:13 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 16:13 < echeveria> uh. I guess so. 16:18 -!- grubles_ [~grubles@gateway/tor-sasl/grubles] has quit [Ping timeout: 250 seconds] 16:18 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Ping timeout: 252 seconds] 16:19 < phantomcircuit> wumpus, seems like select can fail if a socket is closed or in some way broken 16:19 < phantomcircuit> so im guessing calling recv() on every socket was some attempt to handle that? 16:19 -!- Rootsudo [~textual@180.191.99.226] has joined #bitcoin-core-dev 16:23 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 16:31 -!- lnostdal [~lnostdal@85.118.80.192] has joined #bitcoin-core-dev 16:35 -!- lnostdal [~lnostdal@85.118.80.192] has quit [Ping timeout: 240 seconds] 16:40 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 16:51 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev 16:54 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has quit [Remote host closed the connection] 16:55 -!- grubles_ [~grubles@gateway/tor-sasl/grubles] has joined #bitcoin-core-dev 17:11 -!- hebasto [~hebasto@195.60.70.234] has quit [Remote host closed the connection] 17:33 -!- plankers [~plank@c-98-238-141-78.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 17:46 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 17:47 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 18:08 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 18:17 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds] 18:18 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 18:22 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 18:23 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 18:48 -!- zivl [~zivl@2601:19a:837f:e4e1:b8e7:bf0:2609:de60] has quit [Ping timeout: 250 seconds] 18:59 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 252 seconds] 19:09 -!- peevsie [~peevsie@2604:2000:f18f:e300::5] has joined #bitcoin-core-dev 19:20 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 19:26 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 252 seconds] 19:54 -!- peevsie [~peevsie@2604:2000:f18f:e300::5] has quit [Ping timeout: 260 seconds] 19:55 -!- peevsie [~peevsie@2604:2000:f18f:e300::5] has joined #bitcoin-core-dev 20:00 -!- Rootsudo [~textual@180.191.99.226] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 20:02 -!- Rootsudo [~textual@180.191.99.226] has joined #bitcoin-core-dev 20:02 -!- Rootsudo [~textual@180.191.99.226] has quit [Client Quit] 20:03 -!- Rootsudo [~textual@180.191.99.226] has joined #bitcoin-core-dev 20:03 -!- Rootsudo [~textual@180.191.99.226] has quit [Client Quit] 20:04 -!- plankers [~plank@c-98-238-141-78.hsd1.ca.comcast.net] has quit [Quit: Leaving.] 20:32 -!- Krellan_ [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 20:34 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 21:02 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has quit [Remote host closed the connection] 21:14 -!- ken2812221_ [~ken281222@180.217.161.139] has quit [Quit: Leaving] 21:22 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 21:27 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 21:31 -!- Guest26637 [~root@45.32.59.211] has joined #bitcoin-core-dev 21:48 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has quit [Remote host closed the connection] 21:48 < gmaxwell> Github's goal, to make people hate unicorns. 21:49 -!- d9b4bef9 [~d9b4bef9@web501.webfaction.com] has joined #bitcoin-core-dev 21:53 -!- ken2812221 [~ken281222@180.217.161.139] has joined #bitcoin-core-dev 21:59 -!- grubles_ [~grubles@gateway/tor-sasl/grubles] has quit [Remote host closed the connection] 22:00 -!- grubles_ [~grubles@gateway/tor-sasl/grubles] has joined #bitcoin-core-dev 22:11 < luke-jr> lol 22:29 -!- peevsie [~peevsie@2604:2000:f18f:e300::5] has quit [Ping timeout: 250 seconds] 22:33 -!- Krellan [~Krellan@2601:640:4000:9258:1591:b171:4b11:a228] has joined #bitcoin-core-dev 22:37 -!- Krellan [~Krellan@2601:640:4000:9258:1591:b171:4b11:a228] has quit [Remote host closed the connection] 22:38 -!- Krellan [~Krellan@2601:640:4000:9258:99af:c3e7:7599:86e9] has joined #bitcoin-core-dev 23:23 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 23:24 -!- Rootsudo [~textual@180.191.99.226] has joined #bitcoin-core-dev 23:28 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 252 seconds] 23:37 < dongcarl> Have there been any thoughts put into an identicon/visual hash representation of Bitcoin addresses for improved user experience? Would that be useful in any way? 23:38 < gmaxwell> dongcarl: prior work on visual hashes have suggested that they're easily forgable. Users also generally should not be reusing addresses, so 'remembering what the right one looks like' doesn't really apply. 23:39 < gmaxwell> (e.g. there is a paper that forges look-alike ssh visual hashes) 23:40 < gmaxwell> a long time back I did post something about bosting fingerprint comparison security via cut-and-choose: https://en.bitcoin.it/wiki/User:Gmaxwell/visual_fingerprint_comparison 23:40 < dongcarl> gmaxwell: Wouldn't there be other cases where one would want to easily verify that the typed in address is the one that is intended other than 'remembering what the right one looks like'? 23:41 * dongcarl reading 23:41 < luke-jr> why not just use a QR Code? <.< 23:41 < dongcarl> I mean something like this: http://identicon.net/ 23:41 < wumpus> phantomcircuit: there were terrible races around closing sockets in the past, wouldn't surprise me if satoshi had tried to hack around it that way 23:42 < dongcarl> Like what Github uses for default gravatars 23:42 < dongcarl> the color adds a dimension too 23:42 < gmaxwell> We know what identicons are. 23:42 < luke-jr> point is if you have a visual, you can just skip typing it in in the first place 23:42 < gmaxwell> dongcarl: you're going to have to be more specific about "Wouldn't there be other cases" ... like what, specifically? if you're worried about typos, the addresses have phenomially strong checksums that preclude typos. 23:43 < gmaxwell> phenomenally* 23:45 < dongcarl> You're right 23:49 < dongcarl> gmaxwell: the hexagonal cut-and-choose fingerprint you proposed isn't needed either because of checksums? --- Log closed Fri Aug 31 00:00:55 2018