--- Log opened Mon Sep 10 00:00:04 2018 00:11 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 00:17 -!- setpill [~setpill@unaffiliated/setpill] has quit [Ping timeout: 252 seconds] 00:17 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 00:22 -!- setpill [~setpill@unaffiliated/setpill] has quit [Ping timeout: 250 seconds] 00:22 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 00:30 < provoostenator> Not sure how much people rely on the "mark as resolved" feature on Github, but I've already seen it vandalized at least once by drive-by-resolvers. 00:34 < wumpus> I didn't even know such a feature existed, it's curious that it allows for drive-by-resolvers and not only the opener to resolve it as on most sites 00:43 -!- miknotauro [~miknotaur@187.207.79.62] has joined #bitcoin-core-dev 00:46 -!- Soligor [~Soligor@unaffiliated/soligor] has quit [Quit: Soligor] 00:46 -!- setpill [~setpill@unaffiliated/setpill] has quit [Ping timeout: 250 seconds] 00:48 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 00:55 < kallewoof> I was afraid to touch it. Anyone can resolve anything? That sounds broken 01:38 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev 01:44 -!- phwalkr [~phwalkr@210-84-32-251.dyn.iinet.net.au] has joined #bitcoin-core-dev 01:44 -!- phwalkr [~phwalkr@210-84-32-251.dyn.iinet.net.au] has quit [Remote host closed the connection] 01:54 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 01:55 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 01:56 < wumpus> cannot find anything about this feature online 01:57 < wumpus> provoostenator: how would one (hypothetically speaking) go and abuse this feature? 02:04 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 02:05 -!- cisba [d41fee72@gateway/web/freenode/ip.212.31.238.114] has joined #bitcoin-core-dev 02:52 < provoostenator> Marking a comment as resolved hides the thread for other reviewers by default. So basically you should always unfold them to see if you agree a comment was addressed. 02:53 < provoostenator> It's a rather stupid feature IMO, only the person raising an issue should be able to mark it as resolved, if anyone. 02:56 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 02:57 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 03:13 -!- ConTa [uid318112@gateway/web/irccloud.com/x-hgmwghjvldtxzwgm] has quit [Quit: Connection closed for inactivity] 03:31 < aj> provoostenator: repo owners being able to makes sense too... i keep getting worried about misclicking on those buttons when reading reviews now :( 03:46 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 04:02 -!- Krellan [~Krellan@2601:640:4000:9258:202a:3d56:849:3437] has quit [Read error: Connection reset by peer] 04:03 -!- Krellan [~Krellan@2601:640:4000:9258:202a:3d56:849:3437] has joined #bitcoin-core-dev 04:15 -!- hebasto [~hebasto@195.60.70.234] has joined #bitcoin-core-dev 04:29 -!- RubenSomsen [uid301948@gateway/web/irccloud.com/x-nbfoanvetcttebsk] has quit [Quit: Connection closed for inactivity] 04:35 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 04:38 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Client Quit] 04:41 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 04:43 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 05:18 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 252 seconds] 05:29 -!- prod_ [~prod@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 05:39 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 05:52 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 05:52 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 05:57 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 245 seconds] 05:59 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 06:00 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 06:01 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 06:02 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds] 06:18 -!- phwalkr [~phwalkr@210-84-32-251.dyn.iinet.net.au] has joined #bitcoin-core-dev 06:22 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 06:41 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 07:02 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Read error: Connection reset by peer] 07:02 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev 07:16 -!- Dizzle [~dizzle@108.171.182.16] has joined #bitcoin-core-dev 07:26 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 07:39 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 07:39 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 245 seconds] 07:40 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 07:42 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev 07:45 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 07:49 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 07:51 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 08:07 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 246 seconds] 08:17 -!- RubenSomsen [uid301948@gateway/web/irccloud.com/x-lbkisxrhbjmgcsff] has joined #bitcoin-core-dev 08:18 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 08:25 -!- farmerwampum [~farmerwam@104.129.28.114] has joined #bitcoin-core-dev 09:04 -!- phwalkr [~phwalkr@210-84-32-251.dyn.iinet.net.au] has quit [Ping timeout: 244 seconds] 09:07 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 10:11 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Read error: Connection reset by peer] 10:21 -!- grubles [~grubles@gateway/tor-sasl/grubles] has joined #bitcoin-core-dev 10:26 -!- Krellan [~Krellan@2601:640:4000:9258:202a:3d56:849:3437] has quit [Remote host closed the connection] 10:34 -!- miknotauro [~miknotaur@187.207.79.62] has quit [Ping timeout: 240 seconds] 10:36 -!- spinza [~spin@155.93.246.187] has quit [Ping timeout: 240 seconds] 10:37 -!- blackbaba [~blackbaba@223.180.176.109] has joined #bitcoin-core-dev 10:41 -!- blackbaba [~blackbaba@223.180.176.109] has quit [Client Quit] 10:42 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 252 seconds] 10:46 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 11:29 -!- grubles [~grubles@gateway/tor-sasl/grubles] has quit [Remote host closed the connection] 11:31 -!- grubles [~grubles@gateway/tor-sasl/grubles] has joined #bitcoin-core-dev 11:31 -!- grubles [~grubles@gateway/tor-sasl/grubles] has quit [Remote host closed the connection] 11:32 -!- grubles [~grubles@gateway/tor-sasl/grubles] has joined #bitcoin-core-dev 11:41 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 244 seconds] 11:42 < instagibbs> um am i the only person getting importmulti rpc test failure on master, "bytes_to_hex_str" not defined? 11:43 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 11:43 < instagibbs> ok fixed just a bit ago, nvm 11:44 -!- spinza [~spin@155.93.246.187] has quit [Ping timeout: 246 seconds] 11:48 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev 11:49 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection] 11:57 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 11:59 -!- jarthur_ [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 12:00 -!- jarthur_ [~jarthur@207.114.244.5] has quit [Client Quit] 12:02 -!- Dizzle [~dizzle@108.171.182.16] has quit [Ping timeout: 252 seconds] 12:02 -!- jarthur [~jarthur@207.114.244.5] has quit [Ping timeout: 245 seconds] 12:06 -!- grubles [~grubles@gateway/tor-sasl/grubles] has quit [Remote host closed the connection] 12:07 -!- grubles [~grubles@gateway/tor-sasl/grubles] has joined #bitcoin-core-dev 12:07 -!- grubles [~grubles@gateway/tor-sasl/grubles] has quit [Remote host closed the connection] 12:08 -!- nehan [~nehan@14.80.229.35.bc.googleusercontent.com] has joined #bitcoin-core-dev 12:10 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has quit [Read error: No route to host] 12:11 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has joined #bitcoin-core-dev 12:16 -!- Rootsudo [rootsudo@gateway/vpn/privateinternetaccess/rootsudo] has joined #bitcoin-core-dev 12:17 -!- jamesob [~james@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Quit: Lost terminal] 12:17 -!- jamesob [uid180710@gateway/web/irccloud.com/x-vwfafqwclvfigtow] has joined #bitcoin-core-dev 12:18 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has quit [Remote host closed the connection] 12:19 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has joined #bitcoin-core-dev 12:23 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 12:35 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev 13:01 -!- phwalkr [~phwalkr@210-84-32-251.dyn.iinet.net.au] has joined #bitcoin-core-dev 13:06 -!- phwalkr [~phwalkr@210-84-32-251.dyn.iinet.net.au] has quit [Ping timeout: 245 seconds] 13:41 -!- spinza [~spin@155.93.246.187] has quit [Ping timeout: 272 seconds] 13:44 -!- grubles [~grubles@gateway/tor-sasl/grubles] has joined #bitcoin-core-dev 14:03 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 14:08 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 272 seconds] 14:12 -!- brianhoffman [~brianhoff@pool-108-31-201-103.washdc.fios.verizon.net] has joined #bitcoin-core-dev 14:13 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 14:22 -!- spinza [~spin@155.93.246.187] has quit [Ping timeout: 240 seconds] 14:46 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 14:57 -!- phwalkr [~phwalkr@210-84-32-251.dyn.iinet.net.au] has joined #bitcoin-core-dev 15:00 -!- phwalkr [~phwalkr@210-84-32-251.dyn.iinet.net.au] has quit [Remote host closed the connection] 15:00 -!- phwalkr [~phwalkr@210-84-32-251.dyn.iinet.net.au] has joined #bitcoin-core-dev 15:04 -!- miknotauro [~miknotaur@187.207.79.62] has joined #bitcoin-core-dev 15:11 -!- spinza [~spin@155.93.246.187] has quit [Ping timeout: 245 seconds] 15:13 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 245 seconds] 15:17 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 15:18 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 15:26 -!- miknotauro [~miknotaur@187.207.79.62] has quit [Ping timeout: 246 seconds] 15:45 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection] 15:46 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 16:05 -!- hebasto [~hebasto@195.60.70.234] has quit [Remote host closed the connection] 16:28 -!- phwalkr [~phwalkr@210-84-32-251.dyn.iinet.net.au] has quit [Remote host closed the connection] 16:39 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 16:40 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 16:49 -!- miknotauro [~miknotaur@187.207.79.62] has joined #bitcoin-core-dev 17:00 -!- grubles [~grubles@gateway/tor-sasl/grubles] has quit [Remote host closed the connection] 17:01 -!- grubles [~grubles@gateway/tor-sasl/grubles] has joined #bitcoin-core-dev 17:08 -!- grubles [~grubles@gateway/tor-sasl/grubles] has quit [Ping timeout: 256 seconds] 17:12 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Quit: Leaving...] 17:28 -!- qrestlove [~qrestlove@2605:6000:eb4a:ef00:454f:112b:9095:f0ea] has joined #bitcoin-core-dev 17:32 -!- qrestlove [~qrestlove@2605:6000:eb4a:ef00:454f:112b:9095:f0ea] has quit [Client Quit] 17:33 -!- grubles [~grubles@gateway/tor-sasl/grubles] has joined #bitcoin-core-dev 17:33 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 17:57 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 17:58 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 18:00 -!- qrestlove [~qrestlove@2605:6000:eb4a:ef00:6004:f3c4:4f12:7a1d] has joined #bitcoin-core-dev 18:12 -!- unholymachine [~quassel@2601:8c:c003:9f16:d441:4196:4efa:431b] has quit [Remote host closed the connection] 18:19 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 18:25 -!- ken2812221 [~ken281222@180.217.128.66] has quit [Ping timeout: 252 seconds] 18:27 -!- phwalkr [~phwalkr@210-84-32-251.dyn.iinet.net.au] has joined #bitcoin-core-dev 18:30 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 18:34 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 18:38 < jamesob> I'm no great fan of azure but maybe we should consider using some of this free compute time for things like per-commit build validation: https://azure.microsoft.com/en-us/blog/announcing-azure-pipelines-with-unlimited-ci-cd-minutes-for-open-source/ 18:39 -!- grubles [~grubles@gateway/tor-sasl/grubles] has quit [Ping timeout: 256 seconds] 18:39 -!- gwillen [~gwillen@unaffiliated/gwillen] has joined #bitcoin-core-dev 18:44 -!- phwalkr [~phwalkr@210-84-32-251.dyn.iinet.net.au] has quit [Ping timeout: 245 seconds] 19:19 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Read error: Connection reset by peer] 19:20 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev 19:21 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 246 seconds] 19:24 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 19:31 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 19:35 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 252 seconds] 19:59 -!- miknotauro [~miknotaur@187.207.79.62] has quit [Ping timeout: 245 seconds] 20:01 < sipa> wumpus, achow101: so today i've used the PSBT implementation in 0.17.0rc2 for actual transactions, and noticed a bug or at least weird behaviour that seems fixed in master 20:03 < sipa> the workflow was using createrawtransaction + converttopsbt + walletprocesspsbt on an online system (which just had an importaddress of a P2SH segwit address, but not the full key), which as expected produced a PSBT with no scripts, and a non-witness UTXO (as it couldn't know whether the address was segwit or not) 20:04 < sipa> and then on an offline system i used walletprocesspsbt, which added scripts signed the transaction (as expected), but then produced a PSBT with still a non-witness UTXO is... which finalizepsbt *failed to deserialize* 20:05 < achow101> maybe one of the fixes wasn't backported? 20:05 < sipa> the workaround was to use walletprocesspsbt on the offline system with sign=false, move it back to an online system (which had master running), which converted the non-witness UTXO to a witness UTXO, then move it back to the online system for signing + finalizing 20:08 < sipa> i think this may have been inadvertently fixed by https://github.com/bitcoin/bitcoin/pull/13723 20:08 < sipa> i won't have time the coming week to look into this more, however 20:09 < achow101> sipa: I'll take a look at it 20:10 < achow101> sipa: I think it may have to do with the checking for witness utxo stuff you did in 13723 20:13 < sipa> yes, that seems plausible 20:17 < achow101> sipa: I see why it doesn't replace the non-witness psbt, but you said finalizepsbt couldn't deserialize it? 20:18 < sipa> achow101: sanity check in the deserializer fails 20:18 < achow101> ah 20:19 < sipa> i assume it's non-witness utxo with witness final signature? 20:19 < achow101> yeah 20:21 < achow101> sipa: does master replace it with the non-witness utxo with the witness one? 20:22 < sipa> yup 20:22 < sipa> i ran just walletprocesspsbt on master, and it converted the non-witness utxo to a witness utxo 20:22 < sipa> (after the scripts were filled in) 20:23 < achow101> was that with a wallet with the utxo? 20:24 < achow101> (i.e. online wallet) 20:24 < sipa> yes, i believe 20:24 < sipa> ah, so it may not have converted it, but instead replaced it 20:24 < achow101> yes 20:25 < sipa> hmm, so maybe it wasn't related to 0.17/master 20:25 < achow101> afaik, there is no conversion from non-witness to witness utxo that happens 20:26 < achow101> I think I know how to fix this, both in master and 0.17 20:54 < achow101> sipa: #14196 should fix that for the 0.17 branch 20:54 < gribble> https://github.com/bitcoin/bitcoin/issues/14196 | [0.17][psbt] always drop the unnecessary utxo and convert non-witness utxo to witness when necessary by achow101 · Pull Request #14196 · bitcoin/bitcoin · GitHubAsset 1Asset 1 21:12 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 252 seconds] 21:19 < kallewoof> Several people on https://github.com/bitcoin/bips/pull/725 (Generic Signed Message Format) are suggesting I use a fake tx that the prover simply signs. I'm not sure what the benefits of doing this are, though.. 21:20 < kallewoof> My approach: custom sighash. Suggested: custom sighash with transaction stuff. But why? 21:21 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Read error: Connection reset by peer] 21:21 -!- phwalkr [~phwalkr@210-84-32-251.dyn.iinet.net.au] has joined #bitcoin-core-dev 21:22 -!- copumpkin [~copumpkin@haskell/developer/copumpkin] has quit [Ping timeout: 272 seconds] 21:23 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 21:23 < achow101> kallewoof: easier to implement 21:23 -!- brianhoffman [~brianhoff@pool-108-31-201-103.washdc.fios.verizon.net] has quit [Ping timeout: 240 seconds] 21:23 < achow101> also hacking message signing into the transaction format is something that has been discussed in the past 21:24 -!- copumpkin [~copumpkin@haskell/developer/copumpkin] has joined #bitcoin-core-dev 21:25 < kallewoof> achow101: is it, really? (easier to implement) In bitcoin core, I would add a BaseSignatureChecker that took a sighash and that's all. Just call VerifyScript with the inputs from the SignatureProof container. 21:26 -!- phwalkr [~phwalkr@210-84-32-251.dyn.iinet.net.au] has quit [Ping timeout: 245 seconds] 21:26 -!- brianhoffman [~brianhoff@pool-108-31-201-103.washdc.fios.verizon.net] has joined #bitcoin-core-dev 21:26 < kallewoof> achow101: with a tx, you would have to create the two transactions, do the custom tweakeries to ensure it is not actually sendable, then sign it 21:26 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Client Quit] 21:28 -!- Jmabsd [~jmabsd@14.0.153.138] has joined #bitcoin-core-dev 21:29 < Jmabsd> What is the structure of Bitcoin Core's HD wallet now (derivation paths); it's not going with BIP 44/49 today is it? 21:29 < Jmabsd> does Bitcoin Core do BIP 44 "m / purpose' / coin_type' / account' / change / address_index" form at all? 21:29 < achow101> kallewoof: I'm not sure. I haven't really been following the discussion there 21:29 < achow101> Jmabsd: it uses m/0'/0'/i' 21:30 < achow101> Jmabsd: and m/0'/1'/i' 21:30 < Jmabsd> achow101: err, err, so purpose = 0 - or does it even call it purpose? 21:30 < Jmabsd> achow101: and.. second level is change or account? 21:30 < achow101> first level has no name. second is change 21:31 < achow101> well 'internal' (change) and 'external' (receiving) 21:31 < Jmabsd> achow101: aha so it's an ultrareduced form of BIP 44 ha 21:31 < achow101> no, bip44 uses unhardened derivation. Core uses all hardened 21:31 < Jmabsd> achow101: so Bitcoin Core cut away the "coin" and the "account" derivation, and set purpose to 0 - that's pretty much it yes? 21:31 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 21:32 < kallewoof> achow101: Gotcha. Thanks for the hints though. Perhaps I am overthinking the added complexity of requiring tx creation capabilities when you're just out to sign something using a privkey. 21:33 < Jmabsd> achow101: in other words, Bitcoin Core rolled it own thing. 21:33 < achow101> Jmabsd: or really bip44 is bip32 with stuff added onto it. the original description of suggested derivations paths is very similar to core: https://github.com/bitcoin/bips/blob/master/bip-0032.mediawiki#the-default-wallet-layout 21:36 < Jmabsd> achow101: did Bitcoin Core have any particular point with _not_ implementing an accounts abstraction - it's just Bitcoin Core wants to provide one single wallet balance, yes? 21:37 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 245 seconds] 21:38 < achow101> Jmabsd: accounts wouldn't have worked with Core's wallet structure. also, the existing accounts system (which could hmaybe ave been used) was being removed and naming would have been confusing 21:38 < achow101> in general, accounts don't fit into core's wallet model very well 21:48 -!- ken2812221 [~ken281222@180.217.128.66] has joined #bitcoin-core-dev 21:53 -!- profmac [~ProfMac@2001:470:1f0f:226:f433:7199:36a6:a67f] has joined #bitcoin-core-dev 22:08 -!- rex4539 [~rex4539@2a02:587:3500:8e00:bc80:defc:f63c:19de] has quit [Quit: Textual IRC Client: www.textualapp.com] 22:16 < sipa> kallewoof: advantage of hacking tx format: hw wallets may not need any changes to produce a signature. downside: hw wallets wouldn't know that they're actually signing a message rather than a tx 22:17 < kallewoof> sipa: right. Yeah, maaku convinced me in PR comments 22:17 < sipa> Jmabsd: the "accounts" feature as imagined by bip32/bip44 is more like what we now call multiwallet 22:17 < sipa> kallewoof: i'm not sure whether that's a good or a bad thing 22:17 < kallewoof> I think it's an OK downside that HW wallets don't realize they're not signing a tx 22:18 < kallewoof> given the benefits. 22:18 < sipa> kallewoof: i agree with luke as well that the signer actually ought to be aware that they're signing a message rather than a tx 22:19 < kallewoof> The HW firmware you mean? 22:19 < sipa> well, the human 22:19 < sipa> but the only way to guarantee that is having the HW be aware, so it can say 22:19 < kallewoof> *nods* 22:20 -!- DougieBot5000_ [~DougieBot@unaffiliated/dougiebot5000] has joined #bitcoin-core-dev 22:21 < kallewoof> I guess the question then becomes: is it bad to make it possible for people to HW sign a message even before HW wallets support it? 22:21 < kallewoof> maaku's point about proof of reserve and such sound useful 22:23 < sipa> oh he is suggesting to actually make it a full transaction, not just a signature 22:23 < sipa> that gosles even further 22:23 < sipa> *goes 22:24 -!- DougieBot5000 [~DougieBot@unaffiliated/dougiebot5000] has quit [Ping timeout: 252 seconds] 22:24 < kallewoof> Yeah 22:24 < kallewoof> 2 transactions. One input tx whose output takes the scriptPubKey and one output tx spending it 22:25 < sipa> right, but the first is constructed by the verifiedlr i suppose and not actually included in the proof 22:26 < sipa> it's true that it's a very straightforward way of building a forward compatible signing mechanism... but it also sounds scary that someone could be tricked into thinking they're creating a transaction, but they're really signing a message they don't want to 22:26 < kallewoof> I think the idea is that you provide the scriptPubKey, sigScript etc and then construct the two txs, and sign or verify them. 22:26 < kallewoof> Wouldn't the opposite be more scary? (Think you are signing a msg but creating a tx) 22:27 < sipa> oh absolutely, but there is no risk for that in either idea 22:27 < kallewoof> Right 22:29 < kallewoof> What if a tx version 0xffffffff was reserved for "message transactions"? 22:30 < kallewoof> Should be pretty straightforward to check and point out for a user. 22:30 < sipa> that's irrelevant 22:30 < sipa> there are many ways you can modify a tx to indicate it's really something else 22:31 < sipa> the question whethee you want it to be signable by a non-aware piece of software or hardware 22:31 < kallewoof> I have a hard time envisioning the situation where someone is fooled into signing a msg when they meant to sign a tx 22:31 < sipa> how so? 22:31 < sipa> your online machine is hacked, but you trust your hw devicw 22:31 < sipa> that is exactly the scenario it is designdd for 22:32 < kallewoof> Right, but what would they do with me proving I own funds X? 22:32 < kallewoof> Or proving that I am behind "msg=Hello World" 22:32 < sipa> signing a message can be far more than proving you have funds 22:32 < sipa> if you don't know what you're signing, you shouldn't sign it 22:33 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 22:33 < kallewoof> Fair enough. So you're saying, don't make it possible for HW wallets to sign these things unless the HW firmware gets an update to explicitly support it. 22:34 < sipa> right 22:34 < sipa> i also understand the argument that actually using a full tx structure gives a lot of compatibility options 22:34 < sipa> it also makes it bigger 22:34 < kallewoof> Well, not the proof per se. 22:34 < kallewoof> The temporary memory foot print, yes. 22:35 < sipa> well i believe maaku's idea is to actually use a tx as proof 22:35 < sipa> so that it automatically includes whatever future structures get added to it 22:36 < kallewoof> Maybe I misunderstood yeah. His talk about 'deterministic' made me assume it would recreate the tx both when signing and when verifying. 22:36 < sipa> perhaps 22:36 < sipa> it's unclear to me 22:37 < sipa> in any case, i agree it is very forward compatible, but i'd prefer something where the signers need to be aware 22:37 < sipa> i'm sure you can combine the two, by using a tx like structure, but changing the sighash algorithm, for example, so it can never be a valid transaction 22:38 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 22:38 < sipa> though than you also lose the ability for unaware signers to create message sigs... which i think is inevitable 22:38 -!- Krellan [~Krellan@2601:640:4000:9258:cd59:fa78:494:77ae] has joined #bitcoin-core-dev 22:40 < kallewoof> The whole idea behind using the transaction format is so you can drop it in as is, without doing custom stuff. Making a non-tx tx sounds like it defeats the purpose. 22:41 < sipa> it still maintains all forward compatibility 22:41 < sipa> just not backward compatibility 22:42 -!- miknotauro [~miknotaur@187.207.79.62] has joined #bitcoin-core-dev 22:42 < kallewoof> Hm.. 22:44 < sipa> my preference is still something simple that's just a single scriptSig/witness though 22:50 < wumpus> good to catch this in the rc phase at least! 22:52 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 22:52 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev 22:52 < sipa> wumpus: it's a weird case, and not exactly following the intended workflow... but still, ending up with a non-deserializable psbt string is definitely not acceptable 22:52 < wumpus> yes it shouldn't really happen 23:03 -!- Jmabsd [~jmabsd@14.0.153.138] has quit [Read error: Connection reset by peer] 23:14 -!- Apocalyptic [~Apocalypt@unaffiliated/apocalyptic] has quit [Ping timeout: 240 seconds] 23:16 -!- Apocalyptic [~Apocalypt@unaffiliated/apocalyptic] has joined #bitcoin-core-dev 23:27 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 23:27 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 23:34 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 23:39 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 244 seconds] 23:51 -!- phwalkr [~phwalkr@210-84-32-251.dyn.iinet.net.au] has joined #bitcoin-core-dev 23:54 -!- phwalkr [~phwalkr@210-84-32-251.dyn.iinet.net.au] has quit [Remote host closed the connection] --- Log closed Tue Sep 11 00:00:05 2018