--- Log opened Wed Sep 12 00:00:07 2018 00:01 < luke-jr> gmaxwell: re special opcodes, think of it as pay-to-contract, but with the contract separate and updatable? (and people can always opt not to use the special opcodes if they want to share a key) 00:02 < sipa_> what's the point? 00:03 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 00:03 < luke-jr> the whole purpose of (the current) signed messages is to verify the [future] recipient of a payment agrees to terms before making the payment 00:03 < luke-jr> I don't see how using a separate key hurts that at all 00:04 -!- setpill [~setpill@unaffiliated/setpill] has quit [Client Quit] 00:05 < sipa_> i must be missing something, but what is being proven, if it's not the same key? 00:05 < luke-jr> that the recipient agrees to some terms 00:06 < sipa_> but how do you know it's the recipient? 00:06 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 00:06 < luke-jr> because it's the address you're paying 00:07 < sipa_> i'm very confused 00:07 < sipa_> i'll read the ML posts later :) 00:07 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 00:07 < kallewoof> sipa_: No one is responding on the ML unfortunately, but there are comments on the PR 00:08 < kallewoof> To be honest, I get more confused as time passes. I didn't realize there were so many different opinions on so many aspects of this. 00:08 < luke-jr> :/ 00:09 < sipa_> kallewoof: yeah, don't bring works in progress to the ML, you'll just get bikeshedding and design by committee :) 00:10 < kallewoof> lol 00:11 < kallewoof> I think I'll make a section describing how to convert to/from transaction pair format and then let implementers choose whether they go the optional step. That would give them the ability to pass onto set-in-stone HSM:s. 00:12 < sipa_> also don't have optional features that you aren't sure when people would use them :_ 00:13 < sipa_> they don't know better than you 00:14 < kallewoof> Optional features, like the transaction pair conversion? It seems like it could be useful for some people, considering like... 4-5 people have already said they would prefer it to be IN that format. 00:14 < kallewoof> (and an equal amount of people have said they prefer it wasn't) 00:15 < sipa_> meh 00:15 < sipa_> make a choice 00:15 < kallewoof> Fair enough. 00:16 < sipa_> if you can't write explicit advice "in case A, you should use this, otherwise you should use that", it shouldn't be an optional feature 00:18 * sipa_ zZzZ 00:21 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 00:28 < aj> kallewoof: solvency proofs are "all my debts are in this merkle tree, whose total value is X; here's proof of funds of value Y; Y >= X" possibly with some zkp magic to avoid revealing X or Y. https://crypto.stanford.edu/~dabo/pubs/abstracts/provisions.html 00:29 < kallewoof> aj: Nice. Thanks, will read 00:33 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 00:35 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Read error: Connection reset by peer] 01:24 -!- contrapumpkin [~copumpkin@haskell/developer/copumpkin] has joined #bitcoin-core-dev 01:24 -!- copumpkin [~copumpkin@haskell/developer/copumpkin] has quit [Ping timeout: 244 seconds] 01:24 -!- miknotauro [~miknotaur@187.207.79.62] has joined #bitcoin-core-dev 01:32 < wumpus> c++ shouldn't need ? 1 : 0 for booleans, right? 01:34 < wumpus> e.g. a bool will always coerce to either 0 or 1 01:36 < aj> wumpus: yeah, https://en.cppreference.com/w/cpp/language/implicit_conversion ("Integral promotion" section) 01:37 < wumpus> ok there's some discussion about this in #14195 (which solves an actual issue as well, but also adds this confusion) 01:37 < gribble> https://github.com/bitcoin/bitcoin/issues/14195 | fix export privkey der always compressed by fingera · Pull Request #14195 · bitcoin/bitcoin · GitHub 01:37 < wumpus> but good to hear I didn't make this up :) 01:41 < aj> it's a clang readability warning... https://clang.llvm.org/extra/clang-tidy/checks/readability-implicit-bool-conversion.html 01:41 < wumpus> I don't think the added compexity really makes it more readable 01:42 < wumpus> let's type more to make the compiler happy 01:43 < wumpus> aanyhow I'll tell him to squash it and we can merge it, no need to get held up on this, though I do think practicalswift is kind of going too far here in seeding confusion 01:44 < aj> seems like ec_privkey_export_der should be accepting a bool rather than an int anyway? 01:45 < wumpus> unfortunately secp256k1 lives in 1989, booleans weren't invented back then 01:46 < aj> ... it's in src/key.cpp as well as secp256k1/ ? 01:46 < aj> i'm confused :( 01:46 < wumpus> it's calling a secp256k1 function right? or not? 01:47 < wumpus> no, I'm sure I'm confused 01:47 < aj> i think it's cut and pasted from secp256k1 into src/key.cpp and marked as static? 01:47 < wumpus> AhhhAHHhahHa 01:51 < wumpus> you're completely right: there is a ec_privkey_export_der function in secp256k1, but it is not used by us, we have our own version 01:52 < wumpus> which could, if we're willing to diverge from upstream take an ActuallyBool 01:54 < wumpus> (we have already diverged from upstream in some regards, in 63179d028347bf3e32c7ea61386df4c44307b4a7) 01:54 < aj> we've already diverged in a few trivial ways, more so for the _import_der version 01:54 < wumpus> yep ! 01:58 < wumpus> changing the argument to bool is the most sensible solution, suggested it in the PR 02:10 -!- timothy [tredaelli@redhat/timothy] has joined #bitcoin-core-dev 02:17 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 02:21 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Ping timeout: 256 seconds] 02:22 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 02:51 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 03:21 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 03:23 -!- RubenSomsen [uid301948@gateway/web/irccloud.com/x-phkadewxngjjqknl] has joined #bitcoin-core-dev 03:23 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 03:24 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 03:24 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 03:26 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 03:59 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 245 seconds] 04:05 -!- sipa_ [~pw@gateway/tor-sasl/sipa1024] has quit [Remote host closed the connection] 04:06 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev 04:08 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 04:08 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 04:17 < wumpus> - #12283 `1b06ed1` Fix typos (practicalswift) - #12393 `108af52` Fix a-vs-an typos (practicalswift) - #12543 `480f426` Fix typos (practicalswift) - #12747 `2b1c50b` Fix typos (practicalswift) - #13069 `472fe8a` Fix typos (practicalswift) - #13052 `5713994` Fix relevent typo (practicalswift) 04:17 < gribble> https://github.com/bitcoin/bitcoin/issues/12283 | Fix typos by practicalswift · Pull Request #12283 · bitcoin/bitcoin · GitHub 04:17 < gribble> https://github.com/bitcoin/bitcoin/issues/12393 | Fix a-vs-an typos by practicalswift · Pull Request #12393 · bitcoin/bitcoin · GitHub 04:17 < gribble> https://github.com/bitcoin/bitcoin/issues/12543 | Fix typos by practicalswift · Pull Request #12543 · bitcoin/bitcoin · GitHub 04:17 < gribble> https://github.com/bitcoin/bitcoin/issues/13069 | docs: Fix typos by practicalswift · Pull Request #13069 · bitcoin/bitcoin · GitHub 04:17 < gribble> https://github.com/bitcoin/bitcoin/issues/12747 | Fix typos by practicalswift · Pull Request #12747 · bitcoin/bitcoin · GitHub 04:17 < gribble> https://github.com/bitcoin/bitcoin/issues/13052 | trivial: Fix relevent typo by practicalswift · Pull Request #13052 · bitcoin/bitcoin · GitHub 04:17 < wumpus> how many typos fixes do we nee din a release, sigh 04:18 < wumpus> whoops didn't mean to trigger the bot 04:36 < wumpus> I've added the list of pulls and authors to: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.17.0-Release-notes 04:37 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 04:39 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 240 seconds] 04:45 -!- Fuzzbawls [~Fuzz@fuzzbawls.pw] has quit [Ping timeout: 250 seconds] 04:45 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 05:07 -!- da2ce7 [~da2ce7@opentransactions/dev/da2ce7] has quit [Remote host closed the connection] 05:09 -!- Jmabsd [~jmabsd@210-84-32-251.dyn.iinet.net.au] has joined #bitcoin-core-dev 05:10 < Jmabsd> Where in Bitcoin's source code is the TxFee estimation logics for when planning to make a transaction? 05:12 < wumpus> src/policy/fees.cpp mainly 05:14 < Jmabsd> Thanks! 05:19 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds] 05:19 -!- Krellan [~Krellan@2601:640:4000:9258:50ec:2f20:5554:695b] has quit [Read error: Connection reset by peer] 05:20 -!- Krellan [~Krellan@2601:640:4000:9258:50ec:2f20:5554:695b] has joined #bitcoin-core-dev 05:25 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 05:26 -!- molz [~molly@unaffiliated/molly] has quit [Remote host closed the connection] 05:27 -!- molz [~molly@unaffiliated/molly] has joined #bitcoin-core-dev 05:43 -!- wumpus [~wumpus@pdpc/supporter/professional/wumpus] has quit [Quit: leaving] 05:43 -!- wumpus [~wumpus@pdpc/supporter/professional/wumpus] has joined #bitcoin-core-dev 05:44 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 06:00 < echeveria> 06:00 < Jmabsd> wumpus: do you know how the fee estimations are estimated? the code goes something like ""a 60% threshold required at target / 2, an 85% threshold required at target and a 95% threshold required at 2 * target ... Conservative estimates, however, required the 95% threshold at 2 * target", so, there are three different algorithms running, i don't understand the sense 06:09 < wumpus> fee estimation is indeed very complicated 06:09 < wumpus> I don't know all the details either 06:18 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 06:23 < wumpus> this is the right place to ask specific questions about the code though, though I'll likely not be able to answer them, someone else might... 06:25 < aj> https://bitcointechtalk.com/an-introduction-to-bitcoin-core-fee-estimation-27920880ad0 might be a good place to start 06:50 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-xaxsnuldccxyqmcy] has joined #bitcoin-core-dev 06:51 -!- promag [~promag@119.70.114.89.rev.vodafone.pt] has joined #bitcoin-core-dev 07:01 -!- contrapumpkin [~copumpkin@haskell/developer/copumpkin] has quit [Quit: My MacBook Pro has gone to sleep. ZZZzzz…] 07:02 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Quit: Leaving] 07:02 -!- copumpkin [~copumpkin@haskell/developer/copumpkin] has joined #bitcoin-core-dev 07:07 -!- itaseski [~itaseski@213.135.179.129] has joined #bitcoin-core-dev 07:30 -!- Krellan [~Krellan@2601:640:4000:9258:50ec:2f20:5554:695b] has quit [Read error: Connection reset by peer] 07:30 -!- Krellan [~Krellan@2601:640:4000:9258:50ec:2f20:5554:695b] has joined #bitcoin-core-dev 07:31 -!- phwalkr [~phwalkr@210-84-32-251.dyn.iinet.net.au] has joined #bitcoin-core-dev 07:32 -!- phwalkr [~phwalkr@210-84-32-251.dyn.iinet.net.au] has quit [Remote host closed the connection] 07:44 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev 08:11 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 08:12 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 08:58 < wumpus> yes that's a good overview 08:59 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 09:04 -!- jarthur [~jarthur@207.114.244.5] has quit [Client Quit] 09:04 -!- Jmabsd [~jmabsd@210-84-32-251.dyn.iinet.net.au] has quit [Ping timeout: 252 seconds] 09:04 -!- rex4539 [~rex4539@2a02:587:3500:8e00:e16a:1f27:69ce:5acd] has joined #bitcoin-core-dev 09:15 -!- promag [~promag@119.70.114.89.rev.vodafone.pt] has quit [Remote host closed the connection] 09:24 -!- grubles [~grubles@gateway/tor-sasl/grubles] has quit [Ping timeout: 256 seconds] 09:28 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 244 seconds] 09:28 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev 09:34 -!- escrivner [~user@8.46.76.25] has joined #bitcoin-core-dev 09:35 -!- escrivner [~user@8.46.76.25] has quit [Remote host closed the connection] 09:35 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 09:35 -!- escrivner [~user@8.46.76.25] has joined #bitcoin-core-dev 09:36 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 09:36 -!- escrivner [~user@8.46.76.25] has left #bitcoin-core-dev [] 09:38 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 09:42 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 09:48 -!- nullptr| [~nullptr|@ip-94-113-103-134.net.upcbroadband.cz] has quit [Quit: ZNC - http://znc.in] 09:49 -!- nullptr| [~nullptr|@ip-94-113-103-134.net.upcbroadband.cz] has joined #bitcoin-core-dev 10:03 -!- str4d [~str4d@201.196.6.51.dyn.plus.net] has joined #bitcoin-core-dev 10:03 -!- grubles [~grubles@gateway/tor-sasl/grubles] has joined #bitcoin-core-dev 10:11 -!- grubles [~grubles@gateway/tor-sasl/grubles] has quit [Remote host closed the connection] 10:11 -!- grubles [~grubles@gateway/tor-sasl/grubles] has joined #bitcoin-core-dev 10:29 -!- rex4539 [~rex4539@2a02:587:3500:8e00:e16a:1f27:69ce:5acd] has quit [Quit: Textual IRC Client: www.textualapp.com] 10:30 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has joined #bitcoin-core-dev 10:37 -!- Tennis [~Tennis@unaffiliated/tennis] has joined #bitcoin-core-dev 10:38 -!- Tennis [~Tennis@unaffiliated/tennis] has quit [Remote host closed the connection] 10:39 -!- Tennis [~Tennis@unaffiliated/tennis] has joined #bitcoin-core-dev 10:43 -!- timothy [tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 11:17 -!- opdenkamp [~opdenkamp@kodi/staff/dushmaniac] has joined #bitcoin-core-dev 11:18 -!- nullptr| [~nullptr|@ip-94-113-103-134.net.upcbroadband.cz] has quit [Ping timeout: 252 seconds] 11:23 -!- nullptr| [~nullptr|@ip-94-113-103-134.net.upcbroadband.cz] has joined #bitcoin-core-dev 11:28 -!- str4d [~str4d@201.196.6.51.dyn.plus.net] has quit [Ping timeout: 252 seconds] 11:39 -!- harrigan [~harrigan@skynet.skynet.ie] has joined #bitcoin-core-dev 11:46 -!- Krellan [~Krellan@2601:640:4000:9258:50ec:2f20:5554:695b] has quit [Read error: Connection reset by peer] 11:46 -!- Krellan [~Krellan@2601:640:4000:9258:50ec:2f20:5554:695b] has joined #bitcoin-core-dev 11:50 -!- miknotauro [~miknotaur@187.207.79.62] has quit [Ping timeout: 252 seconds] 11:55 -!- jarthur [~jarthur@207.114.244.5] has quit [] 12:30 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 12:39 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 12:40 -!- rex4539 [~rex4539@2a02:587:3500:8e00:dc1e:aabd:b478:7723] has joined #bitcoin-core-dev 12:52 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection] 12:55 -!- RubenSomsen [uid301948@gateway/web/irccloud.com/x-phkadewxngjjqknl] has quit [Quit: Connection closed for inactivity] 12:59 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 13:05 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection] 13:06 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 13:20 < instagibbs> quick N(ACK)s please: hidden(?) RPC calls exposing compact blocks work flow. We have use in Elements/Liquid for passing blocks around the federation outside of p2p. 13:20 < instagibbs> (N)ACKs* :) 13:21 < gmaxwell> so you want basically a GETCOMPACTBLOCK and a SUBMITCOMPACTBLOCK? 13:21 < instagibbs> ~much yeah 13:21 < andytoshi> also a way to get tx indices 13:21 < andytoshi> missing tx indices* 13:21 < instagibbs> andytoshi, that message already exists 13:22 < andytoshi> oh ok ignore me 13:22 < instagibbs> and "consume" compact block, which returns the indices, then responding to getblocktxn, yada 13:23 < gmaxwell> I don't see any harm in it. I'm not sure if it would have much use, the json serialization/deserialization is going to be slow, perhaps slow enough that this wouldn't be interesting for anyone to build alternative transports. Might it be more interesting to have a hidden generic RPC that lets you send any P2P message? 13:23 < instagibbs> I'll take that as 0+ :P 13:24 < gmaxwell> yea, it's a 0+ 13:24 < andytoshi> hmm actually a hidden generic RPC would be better imho 13:24 < instagibbs> andytoshi, seems useful overall, I'd have to think about our application a bit more 13:24 < instagibbs> i'll take a swing at it 13:24 < gmaxwell> I'm not opposed it it but skeptical that its all that useful for bitcoin in general. I suggested the generic because I could imagine more uses for that. (even if just test shims) 13:25 < andytoshi> this isn't the first time i've considered connecting to p2p alongside rpc to get extra stuff 13:25 < instagibbs> one * is that we're passing unsigned blocks(kalle's signet may also want something like this) 13:25 < instagibbs> which means it'll fail PoW checks 13:25 < gmaxwell> Oh I see, you actually want to use compact blocks for pre-pow blocks. 13:25 < gmaxwell> BlueMatt: ^ this might be relevant to your interests too. 13:26 < gmaxwell> (as matt's mining protocol work also exchanges not-pow-valid-blocks) 13:26 < sipa> andytoshi: there may be good reasons to do so; p2p is far more optimized than rpc 13:26 < gmaxwell> in general passing through the json is going to hurt performance alone. 13:29 < BlueMatt> instagibbs: I dont think the compact block protocol makes sense for low-bandwidth relay outside of p2p 13:30 < BlueMatt> oh, wait, scratch that, I was thinking the wrong direction 13:32 < BlueMatt> that said, I'm with gmaxwell, I'm skeptical anyone would use it, because its round-trip-required its not really gonna be all that much better for most use-cases 13:33 < BlueMatt> eg if you're in a protocol where one side is pushing out to multiple clients it doesnt make any sense, and doesn't make any sense for unidirectional things ala blocksat 13:34 < gmaxwell> BlueMatt: well in the one side pushing, much more efficient things are possible but compact blocks already exists and is at least a large constant factor better than sending out the whole block. 13:35 < BlueMatt> you misunderstood my point there, by "one side pushing" i meant any unidirectional comms 13:35 < BlueMatt> eg blocksat, betterhash effecient block relay, etc 13:35 < BlueMatt> or weak block style things 13:37 < gmaxwell> yea, okay, sure, but unidirectional is kind of a special case. The betterhash thing could support round trips, no? 13:38 < BlueMatt> well round trips means bad performance if you're mega-latency-sensitive 13:39 < BlueMatt> so betterhash *could* (with more complication of an already-overcomplicated-protocol imo), but then you'd break anything like running betterhash over quic to get low-latency 13:39 < gmaxwell> fair point. Right your current weak block thing still gets guarenteed no RT. 13:39 < gmaxwell> BlueMatt: s/latency sensitive/latency sensitive OR on very high latency links/ 13:39 < BlueMatt> yea 13:40 -!- Giszmo [~leo@pc-72-54-46-190.cm.vtr.net] has joined #bitcoin-core-dev 13:41 < jarthur> Would Lightning Network watchtowers have such a use-case? 13:42 < gmaxwell> I'm not aware of lightning watchtowers relaying bitcoin blocks. 13:42 < BlueMatt> yea, I dont see why that would be needed? 13:42 < jarthur> Yea, n/m, my mind is in the pre-conf realm. 13:43 < BlueMatt> I'm not aware of any lightning watchtowers. 13:43 < BlueMatt> but, yea, instagibbs, I cant say I'm a fan of putting it in the rpc, just seems like vaguely-useless-features that no one will use 13:43 < BlueMatt> but otoh I'd doubt its *much* code, so whatever 13:44 < gmaxwell> ^ yea my view too. 13:44 < BlueMatt> I do plan on putting some able-to-support-compact-encodings-ala-betterhash into core prs soonish, though, cause betterhash needs it 13:44 < gmaxwell> alternatively, if there are refactors that would make it easier for you to carry a patch, those would probably be more interesting. 13:44 < BlueMatt> but I dont think thats really that related 13:44 < instagibbs> alright im -0 it myself, we'll just carry it 13:45 < instagibbs> no biggie, thanks for the input 13:45 < jarthur> There has been a trend of "personal stratum daemon"s recently, that don't use txindex, might they benefit from such an RPC call? 13:45 < gmaxwell> again same question as watchtowers, why would they be relaying blocks to other nodes? 13:50 < jarthur> No, but if you took out the stratum daemon, and wanted to just use Core for this purpose, and your light-wallet spoke the language, might there be some benefit from you getting your tx history knowledge in this fashion? 13:50 < gmaxwell> No. 13:50 < jarthur> I guess making the light wallet speak p2p is just as good? 13:55 -!- Krellan [~Krellan@2601:640:4000:9258:50ec:2f20:5554:695b] has quit [Read error: Connection reset by peer] 13:56 -!- Krellan [~Krellan@2601:640:4000:9258:50ec:2f20:5554:695b] has joined #bitcoin-core-dev 13:57 < gmaxwell> jarthur: I'm not sure about what parts of the above we read, but we were talking about compact blocks which are _utterly_ useless to litewallets. 13:57 < gmaxwell> They're only potentially useful to full nodes. 14:05 < jarthur> Cool, sorry, didn't think it through. 14:14 < phantomcircuit> i cant decide between setting up Register/Unregister calls for poll/select or replicating the existing logic and setting up the structures every call 14:15 < phantomcircuit> the event(ish) based thing is easier to make a mistake with but setting up all the structures is potentially expensive with many peers 14:21 < gmaxwell> phantomcircuit: what is easier for people to review and get merged? 14:21 < gmaxwell> even if we go with something slower, it can be optimized later. 14:22 < gmaxwell> and I doubt anything 'slow' is going to matter with just 125 peers... 14:23 < phantomcircuit> rebuilding the structure... maybe? 14:24 < phantomcircuit> the logic about whether to set the send/recv flag is surprisingly not trivial so that kind of makes it harder 14:24 * phantomcircuit goes off to see 14:29 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 252 seconds] 14:33 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:40 -!- contrapumpkin [~copumpkin@haskell/developer/copumpkin] has joined #bitcoin-core-dev 14:43 -!- copumpkin [~copumpkin@haskell/developer/copumpkin] has quit [Ping timeout: 244 seconds] 15:12 -!- phwalkr [~phwalkr@210-84-32-251.dyn.iinet.net.au] has joined #bitcoin-core-dev 15:18 -!- jhfrontz [~Adium@205.250.91.156] has joined #bitcoin-core-dev 15:23 -!- jhfrontz [~Adium@205.250.91.156] has quit [Client Quit] 15:23 -!- jhfrontz [~Adium@205.250.91.156] has joined #bitcoin-core-dev 15:24 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection] 15:28 -!- Krellan [~Krellan@2601:640:4000:9258:50ec:2f20:5554:695b] has quit [Ping timeout: 252 seconds] 15:37 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-xaxsnuldccxyqmcy] has quit [Quit: Connection closed for inactivity] 15:44 -!- Krellan [~Krellan@2601:640:4000:9258:50ec:2f20:5554:695b] has joined #bitcoin-core-dev 15:46 -!- grubles [~grubles@gateway/tor-sasl/grubles] has quit [Remote host closed the connection] 15:46 -!- grubles [~grubles@gateway/tor-sasl/grubles] has joined #bitcoin-core-dev 15:54 -!- jhfrontz [~Adium@205.250.91.156] has quit [Quit: Leaving.] 15:54 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 15:55 -!- jhfrontz [~Adium@205.250.91.156] has joined #bitcoin-core-dev 15:57 -!- jhfrontz [~Adium@205.250.91.156] has quit [Client Quit] 16:04 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 16:17 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 246 seconds] 16:33 -!- murrayn [~murrayn@unaffiliated/murrayn] has quit [Quit: Leaving] 16:41 -!- jarthur [~jarthur@207.114.244.5] has quit [] 16:42 -!- murrayn [~murrayn@unaffiliated/murrayn] has joined #bitcoin-core-dev 16:43 -!- Tennis [~Tennis@unaffiliated/tennis] has quit [Read error: Connection reset by peer] 17:05 -!- grubles [~grubles@gateway/tor-sasl/grubles] has quit [Ping timeout: 256 seconds] 17:07 -!- grubles [~grubles@gateway/tor-sasl/grubles] has joined #bitcoin-core-dev 17:14 -!- grubles [~grubles@gateway/tor-sasl/grubles] has quit [Remote host closed the connection] 17:35 -!- Kvaciral [~Kvaciral@5ED6B9A2.cm-7-7c.dynamic.ziggo.nl] has quit [Ping timeout: 264 seconds] 17:42 < pierre_rochard> ken2812221: I took a look at #14007 in bitcoinacks.com, I wasn't picking up "tack" or "re-ack" in my parser, that's fixed now. Please don't hesitate to file an issue or PM me if you notice inconsistencies, I do want this to be a reliable tool 17:42 < gribble> https://github.com/bitcoin/bitcoin/issues/14007 | tests: Run functional test on Windows and enable it on Appveyor by ken2812221 · Pull Request #14007 · bitcoin/bitcoin · GitHub 17:44 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 17:49 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 272 seconds] 17:51 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 17:51 -!- Kvaciral [~Kvaciral@5ED6B9A2.cm-7-7c.dynamic.ziggo.nl] has joined #bitcoin-core-dev 17:52 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 17:53 -!- dqx [~dqx@unaffiliated/dqx] has quit [Ping timeout: 272 seconds] 17:53 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has quit [Quit: drexl] 17:54 -!- Krellan [~Krellan@2601:640:4000:9258:50ec:2f20:5554:695b] has quit [Read error: Connection reset by peer] 17:55 -!- Krellan [~Krellan@2601:640:4000:9258:50ec:2f20:5554:695b] has joined #bitcoin-core-dev 17:55 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 240 seconds] 17:59 -!- grubles [~grubles@gateway/tor-sasl/grubles] has joined #bitcoin-core-dev 18:14 -!- jarthur [~jarthur@2605:6000:1019:41ab:c826:7707:5ac4:344d] has joined #bitcoin-core-dev 18:19 -!- farmerwampum_ [~farmerwam@167.160.174.26] has joined #bitcoin-core-dev 18:21 -!- farmerwampum [~farmerwam@88.202.178.98] has quit [Ping timeout: 245 seconds] 18:21 -!- farmerwampum_ is now known as farmerwampum 18:34 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 18:38 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 244 seconds] 18:46 -!- phwalkr [~phwalkr@210-84-32-251.dyn.iinet.net.au] has quit [Remote host closed the connection] 18:52 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 18:57 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 246 seconds] 19:00 -!- grubles [~grubles@gateway/tor-sasl/grubles] has quit [Remote host closed the connection] 19:08 -!- RubenSomsen [uid301948@gateway/web/irccloud.com/x-gdsnzyhxkgwygcdg] has joined #bitcoin-core-dev 19:21 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 244 seconds] 19:21 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 19:26 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 252 seconds] 19:32 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 19:36 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 246 seconds] 19:51 -!- phwalkr [~phwalkr@210-84-32-251.dyn.iinet.net.au] has joined #bitcoin-core-dev 19:52 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 19:55 -!- phwalkr [~phwalkr@210-84-32-251.dyn.iinet.net.au] has quit [Ping timeout: 252 seconds] 19:59 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 252 seconds] 20:02 -!- Krellan [~Krellan@2601:640:4000:9258:50ec:2f20:5554:695b] has quit [Read error: Connection reset by peer] 20:03 -!- Krellan [~Krellan@2601:640:4000:9258:50ec:2f20:5554:695b] has joined #bitcoin-core-dev 20:29 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 20:34 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 245 seconds] 20:52 -!- miknotauro [~miknotaur@187.207.79.62] has joined #bitcoin-core-dev 20:54 -!- itaseski [~itaseski@213.135.179.129] has quit [Quit: Leaving] 21:08 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 21:12 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 245 seconds] 21:12 < kallewoof> jimpo: reading https://github.com/bitcoin/bips/pull/725#pullrequestreview-154741923 it looks like you're suggesting the proof of funds should be a (fakeish) transaction, and the messsage signing should not be. Am I understanding that right? If so, it seems like you could just do transaction in both cases to simplify the spec. I.e. for signing message, craft two txs with the latter spending the former and former using 21:12 < kallewoof> scriptPubKey of proof 21:17 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 21:22 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 252 seconds] 21:40 -!- jrayhawk [~jrayhawk@unaffiliated/jrayhawk] has quit [Ping timeout: 245 seconds] 21:40 -!- jrayhawk [~jrayhawk@unaffiliated/jrayhawk] has joined #bitcoin-core-dev 21:48 -!- dongcarl [~dongcarl@c-24-5-70-69.hsd1.ca.comcast.net] has quit [Ping timeout: 264 seconds] 22:08 -!- Krellan [~Krellan@2601:640:4000:9258:50ec:2f20:5554:695b] has quit [Read error: Connection reset by peer] 22:15 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 22:19 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 246 seconds] 22:23 -!- YLuRIE9 [~YLuRIE9@dazzlepod.com] has joined #bitcoin-core-dev 22:25 -!- YLuRIE9 [~YLuRIE9@dazzlepod.com] has quit [Remote host closed the connection] 22:28 -!- Krellan [~Krellan@2601:640:4000:9258:50ec:2f20:5554:695b] has joined #bitcoin-core-dev 23:08 < jimpo> kallewoof: What about the data being signed? If I wanted you to sign an arbitrary message, would it be in an OP_RETURN or something? 23:09 < kallewoof> jimpo: for proof of funds? I am thinking there'd be a txin with prevout= and n=0 or something (where includes the message) 23:09 < kallewoof> you meant for signmessage, actually. same thing though. 23:09 < jimpo> Yeah, I think you're understanding me right. But I'm suggesting using the fake transaction to generate the sighash, but as for as actual RPC messages and payloads and stuff, end users would just interact with the proof container, not the transaction itself. 23:10 < kallewoof> right 23:10 < jimpo> :-/ For sign message, that just seems overcomplicated 23:10 < kallewoof> I have already had people object to signmessage being a transaction for UI reasons (e.g. the trezor people). 23:11 < jimpo> manufacturing a tx for proof of funds makes sense to me because you are saying that this transaction with these already exiting UTXOs could actually exist 23:11 < kallewoof> Right. 23:11 < jimpo> but for sign message, manufacturing two dummy transactions seems very artificial and I don't see the benefit 23:12 -!- Krellan [~Krellan@2601:640:4000:9258:50ec:2f20:5554:695b] has quit [Ping timeout: 240 seconds] 23:12 < kallewoof> The only benefit would be in that the two protocols "meet up" after the custom tx creation point. It's not a big deal IMO. 23:13 < jimpo> Yeah, I see them meeting up at the sighash point :-) 23:14 < kallewoof> I should probably write the code for this to geta better idea for what is actually necessary. 23:27 -!- Guest26637 [~root@45.32.59.211] has quit [Read error: Connection reset by peer] 23:28 -!- jarthur [~jarthur@2605:6000:1019:41ab:c826:7707:5ac4:344d] has quit [] 23:31 -!- Krellan [~Krellan@2601:640:4000:9258:1d5e:da14:d577:395c] has joined #bitcoin-core-dev 23:53 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 23:57 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 244 seconds] --- Log closed Thu Sep 13 00:00:08 2018