--- Log opened Thu Sep 13 00:00:08 2018 00:01 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 00:03 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 00:05 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 246 seconds] 00:05 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection] 00:06 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 00:11 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 00:15 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 245 seconds] 00:35 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 00:35 -!- rex4539 [~rex4539@2a02:587:3500:8e00:dc1e:aabd:b478:7723] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 00:37 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Remote host closed the connection] 00:37 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev 00:49 -!- Krellan [~Krellan@2601:640:4000:9258:1d5e:da14:d577:395c] has quit [Ping timeout: 252 seconds] 01:09 < wumpus> oh noo another linter 01:10 < wumpus> so tired of this https://github.com/bitcoin/bitcoin/pull/14205#issuecomment-420921267 01:14 < wumpus> can you all please start working on user-facing, or network-facing issues, not this endless fluffing of the source cdoe 01:18 < wumpus> "oh no, someone used the wrong word for NULL, we must make sure this NEVER happens again" 01:22 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-tleanvnrexiepava] has joined #bitcoin-core-dev 01:24 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:25 -!- phwalkr [~phwalkr@210-84-32-251.dyn.iinet.net.au] has joined #bitcoin-core-dev 01:26 -!- phwalkr [~phwalkr@210-84-32-251.dyn.iinet.net.au] has quit [Remote host closed the connection] 01:26 -!- phwalkr [~phwalkr@210-84-32-251.dyn.iinet.net.au] has joined #bitcoin-core-dev 01:32 < wumpus> while issues that people report pretty much go ignored: say, #14200 01:32 < gribble> https://github.com/bitcoin/bitcoin/issues/14200 | bitcoind aborts with boost exception · Issue #14200 · bitcoin/bitcoin · GitHub 01:33 -!- rex4539 [~rex4539@ppp-94-66-56-170.home.otenet.gr] has joined #bitcoin-core-dev 01:34 -!- phwalkr [~phwalkr@210-84-32-251.dyn.iinet.net.au] has quit [Remote host closed the connection] 01:45 < wumpus> sorry :-( 01:54 -!- RubenSomsen [uid301948@gateway/web/irccloud.com/x-gdsnzyhxkgwygcdg] has quit [Quit: Connection closed for inactivity] 01:55 < luke-jr> wumpus: you're not wrong 01:57 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev 01:59 < luke-jr> wumpus: my manpage has EINVAL as a possible return value.. 01:59 < wumpus> luke-jr: can you pastebin it please 02:00 < luke-jr> just posted here https://github.com/bitcoin/bitcoin/issues/14200#issuecomment-420935509 02:00 < wumpus> oh! great 02:00 < wumpus> apparently you have a much more extensive manpage 02:00 < luke-jr> IEEE/The Open Group 2013 PTHREAD_COND_TIMEDWAIT(3P) 02:01 < wumpus> LinuxThreads PTHREAD_COND(3) 02:01 < luke-jr> interesting 02:01 < luke-jr> sys-apps/man-pages-posix has a non-standard license; maybe Debian considers it non-free 02:02 < luke-jr> (it requires deviations from the POSIX standard to be explicitly noted) 02:02 -!- echonaut [~echonaut@46.101.192.134] has quit [Remote host closed the connection] 02:03 -!- echonaut [~echonaut@46.101.192.134] has joined #bitcoin-core-dev 02:03 < wumpus> so I guess mine describes linux's specific behavior, and the one you have the standard, which is more useful in this case 02:03 < luke-jr> well, this EINVAL sounds pretty implementation-specific 02:03 < luke-jr> unless there's a standard limit on the abstime param 02:04 < luke-jr> http://pubs.opengroup.org/onlinepubs/009695399/functions/pthread_cond_timedwait.html says [EINVAL] The value specified by abstime is invalid. 02:05 < luke-jr> following the "this version is outdated" link at the top has the explicit limits 02:06 < luke-jr> Change history has Issue 6: IEEE Std 1003.1-2001/Cor 2-2004, item XSH/TC2/D6/91 is applied, updating the ERRORS section to remove the error case related to abstime from the pthread_cond_wait() function, and to make the error case related to abstime mandatory for pthread_cond_timedwait() for consistency with other functions. 02:06 < luke-jr> so I guess this was to make the failure deterministic? 02:06 < wumpus> yes, makes sense 02:07 < wumpus> an invalid *absolute* time passed in would be really strange 02:08 < wumpus> I can see relative times ending up all over the place, including negative, but absolute ones 02:08 < luke-jr> yes, an absolute max is silly here :/ 02:09 < luke-jr> oh, the nanosecond value is a *part* 02:09 < luke-jr> ie, the 1000mil should overflow into seconds 02:10 < wumpus> yes, nanoseconds field ending up >= 1000 million would be unequivocally wrong 02:10 < luke-jr> What's this boost::exception_detail::clone_impl maybe there's an invalid object somewhere? 02:11 < wumpus> I don't know; if this was simple C code we'd probably already have found the problem, all this c++/boost exception verboseness adds nothing 02:12 < wumpus> all those conversions between time formats, too 02:12 < wumpus> what is a boost::chrono::system_clock::time_point, even 02:13 < luke-jr> does GDB work on WSL? 02:13 < wumpus> it's not a simple object wrapping seconds and nano/microseconds at least... 02:13 < luke-jr> maybe he can get a backtrace and/or run some print commands 02:14 < wumpus> I don't know 02:16 < wumpus> so it is likely that timeToWaitFor passed to wait_unti is invalid, it would probably help trying to print that 02:16 < wumpus> assuming this uses the BOOST_VERSION >= 105000 arm, of course 02:17 < luke-jr> I figure a backtrace will help find out what we're actually using for the timeout object on our end 02:17 < wumpus> if it uses the other one with toPosixTime, well here be dragons... 02:17 < luke-jr> no point looking at the post-conversions value, since we can already guess it's invalid 02:18 < wumpus> timeToWaitFor is the pre-conversion value 02:26 < wumpus> we could ask what was the last version that did work, and see if there's been changes to that code since 02:26 < wumpus> appaarently 0.16.x is all broken, but they don't say whether 0.15.x worked 02:29 < luke-jr> has WSL been around that long? O.o 02:29 < wumpus> it's been around for a while (as beta feature) 02:30 < wumpus> even years ago when I still had at least one windows computer 02:54 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 03:07 -!- Giszmo [~leo@pc-72-54-46-190.cm.vtr.net] has quit [Ping timeout: 252 seconds] 03:07 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 256 seconds] 03:14 -!- Giszmo [~leo@pc-72-54-46-190.cm.vtr.net] has joined #bitcoin-core-dev 03:21 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 03:27 -!- phwalkr [~phwalkr@210-84-32-251.dyn.iinet.net.au] has joined #bitcoin-core-dev 03:29 -!- phwalkr [~phwalkr@210-84-32-251.dyn.iinet.net.au] has quit [Remote host closed the connection] 03:35 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 04:16 -!- setpill [~setpill@unaffiliated/setpill] has quit [Ping timeout: 240 seconds] 04:18 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 04:30 -!- RubenSomsen [uid301948@gateway/web/irccloud.com/x-gxbpvixeigthogxs] has joined #bitcoin-core-dev 04:32 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 04:33 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Quit: Leaving] 04:50 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has joined #bitcoin-core-dev 05:01 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 05:04 -!- da2ce7 [~da2ce7@opentransactions/dev/da2ce7] has joined #bitcoin-core-dev 05:13 -!- rex4539 [~rex4539@ppp-94-66-56-170.home.otenet.gr] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 05:18 -!- da2ce7 [~da2ce7@opentransactions/dev/da2ce7] has quit [Quit: ZNC 1.7.0 - https://znc.in] 05:20 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 05:38 -!- profmac [~ProfMac@2001:470:1f0f:226:f433:7199:36a6:a67f] has quit [Read error: Connection reset by peer] 05:48 < ken2812221> pierre_rochard: thanks!! 05:49 -!- rex4539 [~rex4539@2a02:587:a11:3000:70b8:c5b1:f3f1:47d] has joined #bitcoin-core-dev 05:56 -!- rex4539 [~rex4539@2a02:587:a11:3000:70b8:c5b1:f3f1:47d] has quit [Ping timeout: 252 seconds] 05:57 -!- rex4539 [~rex4539@154.57.7.43] has joined #bitcoin-core-dev 06:08 -!- rex4539 [~rex4539@154.57.7.43] has quit [Ping timeout: 240 seconds] 06:26 -!- Mrrt [~Mrrt@cpe-74-78-139-4.maine.res.rr.com] has joined #bitcoin-core-dev 06:35 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 07:14 -!- hebasto [~hebasto@195.60.70.234] has joined #bitcoin-core-dev 07:15 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 07:26 -!- promag [~promag@119.70.114.89.rev.vodafone.pt] has joined #bitcoin-core-dev 07:35 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev 07:55 -!- nullptr| [~nullptr|@ip-94-113-103-134.net.upcbroadband.cz] has quit [Ping timeout: 252 seconds] 07:57 -!- nullptr| [~nullptr|@ip-94-113-103-134.net.upcbroadband.cz] has joined #bitcoin-core-dev 08:04 -!- ExtraCrispy [~ExtraCris@67.215.11.12] has joined #bitcoin-core-dev 09:00 -!- promag [~promag@119.70.114.89.rev.vodafone.pt] has quit [Remote host closed the connection] 09:30 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has quit [Ping timeout: 252 seconds] 09:30 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 09:31 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has joined #bitcoin-core-dev 09:42 -!- jhfrontz [~Adium@205.250.91.156] has joined #bitcoin-core-dev 09:44 -!- jhfrontz [~Adium@205.250.91.156] has quit [Read error: Connection reset by peer] 09:44 -!- jhfrontz [~Adium@205.250.91.156] has joined #bitcoin-core-dev 09:46 -!- Krellan [~Krellan@2601:640:4000:9258:1d5e:da14:d577:395c] has joined #bitcoin-core-dev 10:03 -!- Krellan [~Krellan@2601:640:4000:9258:1d5e:da14:d577:395c] has quit [Remote host closed the connection] 10:08 -!- jhfrontz [~Adium@205.250.91.156] has quit [Quit: Leaving.] 10:10 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Quit: Leaving] 10:11 < wumpus> MarcoFalke: interesting, it looks like we have no direct dependency on LIBSSL at all anymore 10:12 -!- jhfrontz [~Adium@205.250.91.156] has joined #bitcoin-core-dev 10:12 < wumpus> (doing a gitian build just to be sure) 10:13 < wumpus> paymentrequestplus.cpp does some manipulation of certificates, but that appears to be part of crypto, not ssl 10:18 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 10:22 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 10:25 < gmaxwell> \O/ 10:28 -!- grubles [~grubles@gateway/tor-sasl/grubles] has joined #bitcoin-core-dev 10:31 -!- jhfrontz [~Adium@205.250.91.156] has quit [Ping timeout: 240 seconds] 10:31 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 10:38 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 10:47 -!- masonicboom [~masonicbo@2600:8802:5501:17c0:5c5c:8b90:e9ef:e0fb] has joined #bitcoin-core-dev 10:49 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 250 seconds] 11:00 -!- jarthur [~jarthur@207.114.244.5] has quit [Read error: Connection reset by peer] 11:00 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 11:10 -!- jarthur [~jarthur@207.114.244.5] has quit [Read error: Connection reset by peer] 11:10 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 11:19 -!- grubles [~grubles@gateway/tor-sasl/grubles] has quit [Ping timeout: 256 seconds] 11:21 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 11:22 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 11:24 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-tleanvnrexiepava] has quit [Quit: Connection closed for inactivity] 11:24 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 11:24 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 11:26 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 11:30 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [] 11:30 -!- d_t [~d_t@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 11:30 -!- queip [~queip@unaffiliated/rezurus] has quit [Quit: bye, freenode] 11:30 -!- contrapumpkin [~copumpkin@haskell/developer/copumpkin] has quit [Quit: My MacBook Pro has gone to sleep. ZZZzzz…] 11:31 -!- copumpkin [~copumpkin@haskell/developer/copumpkin] has joined #bitcoin-core-dev 11:34 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Ping timeout: 252 seconds] 11:56 -!- clarkmoody [~clarkmood@47-218-248-206.bcstcmta04.res.dyn.suddenlink.net] has joined #bitcoin-core-dev 11:57 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 12:00 < wumpus> #startmeeting 12:00 < lightningbot> Meeting started Thu Sep 13 19:00:05 2018 UTC. The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot. 12:00 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic. 12:00 < MarcoFalke> Would have to remove the #include of libssl as well? 12:00 < MarcoFalke> oh meeting 12:00 < wumpus> MarcoFalke: yep 12:00 < provoostenator> hi 12:00 < promag> hi 12:00 < MarcoFalke> I wonder if it is possible to build openssl with just libcrypto and not libssl 12:01 < jnewbery> hi 12:01 < wumpus> any proposed topics? 12:01 < jonasschnelli> hi 12:02 < meshcollider> Hi 12:02 < MarcoFalke> Have we had issues reported for rc3 of 0.17.0? 12:02 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 12:02 < provoostenator> MarcoFalke: probably not: https://github.com/openssl/openssl/issues/4597 12:02 < wumpus> MarcoFalke: I don't think so 12:02 < achow101> hi 12:03 < achow101> MarcoFalke: there was that thing sipa pointed out 12:03 < achow101> with psbt 12:03 < achow101> #14196 12:03 < gribble> https://github.com/bitcoin/bitcoin/issues/14196 | [0.17][psbt] always drop the unnecessary utxo and convert non-witness utxo to witness when necessary by achow101 · Pull Request #14196 · bitcoin/bitcoin · GitHubAsset 1Asset 1 12:03 < achow101> I'm not sure if it is necessarily a bug, it is annoying though when encountered 12:04 < promag> regarding missing pieces for multi wallets, hope to get #13100 and #13339 done shortly 12:04 < gribble> https://github.com/bitcoin/bitcoin/issues/13100 | gui: Add dynamic wallets support by promag · Pull Request #13100 · bitcoin/bitcoin · GitHub 12:04 < gribble> https://github.com/bitcoin/bitcoin/issues/13339 | wallet: Replace %w by wallet name in -walletnotify script by promag · Pull Request #13339 · bitcoin/bitcoin · GitHub 12:04 < MarcoFalke> Ok, we should put that up as high priority and then target rc4 end of next week? 12:05 < wumpus> yes, good idea 12:05 < sipa> i encountered this issue while actually trying to use psbt btw :) 12:05 < MarcoFalke> Also I'd like to see the release notes amended with the list of merged changes. wumpus mind doing that or sharing the script :) ? 12:05 < wumpus> MarcoFalke: huh didn't I add those? 12:05 < wumpus> last week was like a blur 12:06 < sipa> still too busy this week, but if someone could add scantxoutset to the release notes? 12:06 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Ping timeout: 240 seconds] 12:06 < wumpus> yes I actually added the PRs and authors: https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.17.0-Release-notes 12:06 < MarcoFalke> wumpus: Thx. I've misssed yesterdays commit 12:08 < jonasschnelli> Anyone up for writing a short part about scantxoutset for the 0.17 release notes? 12:08 < wumpus> as for sharing the script, if you don't mind it's a mess, will push it into devtools soon 12:09 < promag> I can give a try to scantxoutset release notes 12:09 < wumpus> promag: thanks! 12:10 < jnewbery> some quick proposed topics: refactor/linter PRs , wallet maintainer , archiving meeting notes 12:10 < jonasschnelli> promag: thanks! 12:11 < wumpus> added 14197 to high prio 12:11 < promag> #14197 12:11 < gribble> https://github.com/bitcoin/bitcoin/issues/14197 | [psbt] Convert non-witness UTXOs to witness if witness sig created by achow101 · Pull Request #14197 · bitcoin/bitcoin · GitHub 12:11 < wumpus> #topic refactor/linter PRs 12:11 < wumpus> stop it stop it stop it stop it stop it stop it stop it stop it 12:11 < wumpus> thx :p 12:12 < jnewbery> I think a lot of people get the sense that there are a lot of refactor/linter PRs these days 12:12 < wumpus> yes, it's too often 12:12 < jnewbery> I'd hate to discourage any contributions, but I think it would be a better use of reviewer time and people would enjoy working on the project more if more PRs were focused on features/bugfixes :) 12:12 < achow101> wumpus: unfortunately practicalswift isn't here to hear that 12:13 < meshcollider> Lol 12:13 < promag> we can write a lint to prevent new linters with grep 12:13 < gmaxwell> I would describe the concern more broadly as there is a significant fraction of all PRs (maybe a majority) with basically no articulable direct or near term benefit to users... or even just exciting changes. In any project there is going to be some amount of house keeping for sure, and I'm super happy people want to work on bits of cleanup. 12:14 < wumpus> I've told him a few times that tcleanups are okay, but not too often, say once a month or so, but they just keep coming, it's oversnowing the useful PRs 12:14 < provoostenator> I like linters and other techniques to produce code consistentency, but obviously it shouldn't be become an obsession. 12:14 < wumpus> it's becoming an obsession for me (in the negative sense) 12:14 < gmaxwell> I feel really bad about finding myself in a position of saying "NAK. Your code is probably fine, but it's not worth anyones time to review it because it doesn't improve things enough." 12:14 < wumpus> if this keeps up, I'll close them blindly 12:14 < ryanofsky> i don't understand why you can't just tag them and look at the tag once a month 12:14 < provoostenator> Maybe someone should just combine them all in one giant lint PR and come back in a few months? 12:15 < wumpus> who doesn't he do that himself though? 12:15 < gmaxwell> ryanofsky: because 'when you look' doesn't change the fact that there is a review/correctness burden. 12:15 < wumpus> because some of us actually have to look at the list of allPRs and this is really discouraging 12:15 < jnewbery> I don't think any more needs to be said about any individual contributor, but if we can all rate limit own own refactor PRs, I think we'd appreciate it 12:16 < wumpus> yes, please 12:16 < MarcoFalke> ryanofsky: They show up in the list of pulls by default 12:16 < promag> however those monthly cleanups can be bigger and harder to merge 12:17 < gmaxwell> Also it's a lot easier to churn out 'safe' refactor/cleanup changes and it's also easier to review/comment on them, so it changes the balance of activity in the project in general. 12:17 < MarcoFalke> Can we add a pull request GitHub template that asks for clear motivation of the changes? 12:18 < wumpus> the problem is that our proojct is one big bottleneck, I think if it was divided into hierarchical subsystems like Linux it'd be better, but it's not really possible to have that workflow with github 12:18 < wumpus> all proposed changes end up in one big list 12:18 < MarcoFalke> I.e. The changes need to improve user experience or significantly improve developer experience 12:18 < gmaxwell> wumpus: dunno there, I mean, even if its subsystems, all of them need to be free of exploitable crashes. :) (okay maybe a few subsystems would really be isolated from any possible hostile input...) 12:19 < wumpus> e.g. https://blog.ffwll.ch/2017/08/github-why-cant-host-the-kernel.html 12:19 < jnewbery> wumpus: is that true? If wallet and node were better separated, would it be possible to have a master branch and a wallet dev branch for example? 12:19 < jonasschnelli> should we submodule the test system? 12:19 < gmaxwell> MarcoFalke: I also was thinking about articulate the benefit. 12:19 < meshcollider> wumpus: that's the point of GitHub "projects" isn't it 12:19 < gmaxwell> er, directing people to articulate the benefit. 12:19 < MarcoFalke> yeah ^ 12:19 < wumpus> ideally I don't want to have to look at every PR individually anymore, in the case of Linux there's subsystem maintainers that make their own tree of updates and it can be merged (or rejected) at one 12:20 < gmaxwell> I do think we do want general code tidying some too... but those shouldn't be a signficant fraction of the PR flow. 12:20 < wumpus> jnewbery: this is not a technical issue about separation in the source tree, Linux is also one big tree 12:20 < jnewbery> wumpus: I'll read the danvet post 12:20 < wumpus> it's just that top-level PRs don't really scale 12:21 < wumpus> I can't manually, humanly, handle 200+ PRs, sorry 12:21 < jnewbery> proposed topic: wallet maintainer 12:22 < MarcoFalke> I have seen that practicalswift also runs a bot(?) to comment on pull request directly with feedback harvested from clang-tidy 12:22 < wumpus> and if it keeps going like this, at some point it's going to break down 12:22 < MarcoFalke> I think these are more useful than linters 12:22 < sipa> i plan to do more wallet work soon, to push descriptors and other things forward 12:22 < wumpus> so we need a different way of woring 12:22 < sipa> now i have to run, sorry; will be back next week 12:23 < wumpus> later sipa 12:23 < promag> o/ 12:23 < promag> MarcoFalke: agree ^ 12:24 < wumpus> #topic wallet maintainer 12:25 < wumpus> MarcoFalke> I.e. The changes need to improve user experience or significantly improve developer experience <- yes 12:25 < MarcoFalke> ok, will write up something today 12:25 < MarcoFalke> sipa is gone, so let's assign him to be wallet maintainer? 12:25 < gmaxwell> ACK. 12:25 < achow101> +1 12:25 < sdaftuar> i thought we already did that 12:25 < jnewbery> I think wumpus has wanted a wallet maintainer for a while, and sipa is probably too busy to take that role. I wonder if there are any actions we can take to find someone to be wallet maintainer in, say, the next six months 12:25 < meshcollider> I feel like he has already been assigned that role many times 12:26 < wumpus> best if it fixes a reported issue, or something that is clearly either a problem from a user perspective, a performance or security issue, etc 12:26 < promag> vote jnewbery for wallet maintainer :P 12:26 < jnewbery> promag: -1 12:26 < provoostenator> What is the wallet maintainer job description? 12:26 < wumpus> it's like a game of hot potato 12:26 < MarcoFalke> jnewbery: I am not aware of any single person that really knows what is going on in the wallet 12:26 < pierre_rochard> ryanofsky? 12:26 < jnewbery> MarcoFalke: that makes everyone equally qualified 12:26 < wumpus> provoostenator: review and merge wallet changes 12:26 < gmaxwell> sipa is closest, mostly as a side effect of knowing everything. 12:27 < wumpus> provoostenator: (most importantly, understand them) 12:27 < jonasschnelli> I think sipa is kinda the wallet maintainer... or am I wrong? 12:27 < jnewbery> but seriuosly, I think it's more important to have a sensitivity to what they don't know rather than have an encyclopedic knowledge of everything 12:27 < provoostenator> Well, some degree of not understanding can be compensated by not merging without ACK's from people who do. 12:27 < wumpus> yes, exactly jnewbery 12:27 < jnewbery> and it's only 15k lines of code. How difficult can it be? 12:27 < wumpus> it's a matter of judgement I guess 12:28 < gmaxwell> jnewbery: tada, disqualified. :P 12:28 < achow101> jnewbery: I think it's a bit cleaner now with accounts gone 12:28 < achow101> less idiotic to understand 12:28 < wumpus> it's not even that bad if you dn't fully understand it now, if you're willing to learn it 12:29 < MarcoFalke> So I believe the closest to a wallet maintainer would be the people that worked most on it in the last two releases 12:29 < jnewbery> my point in raising this topic is not "let's find a wallet maintainer today", but "can we take steps now to identify someone who might be a good wallet maintainer in a few months" 12:29 < wumpus> yes, getting rid of accounts did make it less crazy 12:29 < jnewbery> It seems that waiting around for someone to volunteer or step up hasn't really worked 12:29 < gmaxwell> having to support old stuff is just a pain. It's hard to do without having had a lot of exposure to the history as there are many poorly documented properties that the existing stuff obeys. 12:29 < wumpus> I wonder how Linus picks subsystem maintainers 12:29 < wumpus> though, I guess, people actually volunteer 12:29 < gmaxwell> jnewbery: I dunno, I think things are working in the sense that its becoming simpler and more people are contributing to that part actively than were in the past. 12:30 < jnewbery> gmaxwell: we're still too bottlenecked on wumpus 12:30 < meshcollider> Make a large wallet PR and the first person GitHub picks as a "suggested reviewer" is the new maintainer 12:30 < wumpus> jnewbery: yes 12:30 < jnewbery> so we need to make a wumpus bot or delegate to maintainers 12:30 < gmaxwell> Github just doesn't really directly facilitate that kind of workflow. 12:30 < wumpus> ideally I could just leave for a bit and things would continue 12:30 < promag> honestly I think jnewbery has done a great job cleaning and maintaining and improving wallet code 12:31 < achow101> the solution is to just upload wumpus's mind and then start 20 instances of him :p 12:31 < gmaxwell> like why are we actually bottlenecked on wumpus? perhaps wumpus needs to start tagging things with "I'm not going to merge this PR" 12:31 < wumpus> achow101: yes! 12:31 < provoostenator> I'd be fine with jnewbery doing this as well. 12:31 < meshcollider> jnewbery: in all honesty, would you not want the role 12:31 < wumpus> me too 12:31 < jamesob> instagibbs seems to know wallet pretty well 12:31 < gmaxwell> it's not like there is an actual technical physical bottleneck on wumpus. 12:31 < jnewbery> I'm flattered, honestly, but already too busy with bitcoin optech, residency stuff, etc 12:32 < jnewbery> perhaps something for discussion in tokyo 12:32 < MarcoFalke> I think the bottleneck is not clicking the merge button (any of the 4 maintainers can do this) 12:32 < MarcoFalke> The bottleneck is review and signing off on the merge 12:32 < MarcoFalke> (when ready) 12:33 < wumpus> yes, which is not always an easy judgement, but still 12:33 < provoostenator> So it's more like a "sudo ACK"? 12:33 < gmaxwell> well if we're concerned about review cycles then we need to talk about focusing resources on whats important. So perhaps more than 'foo maintainer' we need someone curating the priority list for a subsystem. 12:33 < wumpus> if you know a certain part of the code well enough you could be maintainer of it 12:33 < wumpus> like, in Linux, if you wrote a certain driver, you're pretty much maintainer of it by default 12:34 < gmaxwell> the high priority PRs things helps, at least as we close for a release... 12:34 -!- masonicboom [~masonicbo@2600:8802:5501:17c0:5c5c:8b90:e9ef:e0fb] has quit [Ping timeout: 250 seconds] 12:34 < MarcoFalke> We could assign jnewbery and ryanofsky and other contributors the right to sign off on wallet changes and then some maintainer merges the changes. 12:34 < MarcoFalke> So have more than one wallet maintainer 12:34 < wumpus> well the maintainer of a subsystem would also curate prioriteit 12:34 < wumpus> the problems seems to be finding people, *NOT* finding things for them to do :) 12:34 < achow101> MarcoFalke: isn't that the point of ACK's though? 12:34 < meshcollider> MarcoFalke: isn't that basically just an ACK then 12:35 < promag> right achow101 12:35 < MarcoFalke> Not every ACK means merge 12:35 < gmaxwell> wumpus: well curating priority projects for a subsystem is less risky task, probably more people willing to do it, and fewer concerns about whos doing it. 12:35 < MarcoFalke> more like the "sudo ACK" (provoostenator) 12:35 < wumpus> well it's more subtle than that, otherwise it could jsut be a bot 12:36 < MarcoFalke> In the future I want it to be done by a bot, but thats a differnt topic 12:36 < wumpus> you also have to have a feeling who is the right person to ACK something 12:36 < wumpus> which would be possible if someone was a maintainer of that subsystem 12:36 < provoostenator> Does Github allow putting a "maintainer" badge on someone so it's more obvious for people that these maintainer ACK's are required / strongly recommended. 12:36 < wumpus> but we're circling around 12:36 < gmaxwell> like who would actually understand if this is broken or will cause problems down the road, vs who just looked at it and went yep no undefined behavior! 12:36 < meshcollider> provoostenator: mo 12:36 < meshcollider> No* 12:36 < wumpus> gmaxwell: righ 12:37 < wumpus> anyhow, if someone wants to be wallet maintainer, or maintainer of some other subsystem, let me know 12:37 < clarkmoody> provoostenator: maintainers.md 12:37 < wumpus> clarkmoody: yep 12:37 < provoostenator> Ok, that works. 12:38 < wumpus> you can define a path there, and who is maintainer, I think github even parses it somehow 12:38 < promag> and what should a maintainer do? :P 12:38 < meshcollider> So in terms of steps, be more active I'm looking for someone to push into the role? What else is possible 12:38 -!- miknotauro [~miknotaur@187.207.79.62] has quit [Ping timeout: 252 seconds] 12:38 < meshcollider> In* 12:38 < provoostenator> https://blog.github.com/2017-07-06-introducing-code-owners/ 12:38 < gmaxwell> I think we should all act as though we were the maintainers of things more. 12:39 < jnewbery> meshcollider: yes, I think so 12:39 < wumpus> promag: just be very active in maintaining a piece of code, like, review all PRs that change it, judge when a change is good, etc 12:39 < gmaxwell> not only does this potentially reduce work for others, but it helps identify people who are organically doing the job anyways. Which is, for the most part, what other projects do. 12:39 < gmaxwell> I think the issue wumpus struggles with is in part because no one is doing the job already. 12:40 < gmaxwell> :) 12:40 < gmaxwell> If someone were, it would be both less of an issue, and an easier thing to decide. 12:41 < wumpus> I mean I could pull a Guido van Rossum and just stop merging things and let you figure it out for yourself, but I'd prefer to have a saner path forward 12:41 < provoostenator> So we can just mark a bunch of people as Code Owners (as well maintainers.md) for the wallet and require review from at least one of them, as a step in the right direction? 12:41 < wumpus> but it's not given that I will be doing this forever 12:41 < promag> anyhow, if someone wants to be wallet maintainer, or maintainer of some other subsystem, let me know <-- wumpus: they should just step up? 12:42 < promag> like, ken2812221 looks like windows maintainer? 12:42 < meshcollider> provoostenator: that's effectively how RTM is judged anyway 12:42 < wumpus> promag: good idea! 12:43 < wumpus> he's doing a great job with the windows unicode support 12:43 < gmaxwell> The important thing is actually doing the work, meaning taking a concerted effort to review and understand changes, their short and long term implications-- their impact on the users, network, rest of the code base, their historical context... along with sheparding things along to make sure the required stuff gets done (if not actually doing it themselves) 12:43 < wumpus> I'm—somewhat disappointed—that windows still needs so much platform-specific code, but it's better than breaking on non-english people's PCs 12:44 < gmaxwell> These are things that almost everyone can do more of. 12:44 < wumpus> gmaxwell: agree 12:45 < wumpus> if someone was doing the work then assigning someone a maintainer label was easy 12:45 < wumpus> that's how jonasschnelli became GUI maintainer, for ex. 12:45 < gmaxwell> So I think thats really an action item people can take from this discussion, look for oppturnityies do to more of that yourself, and to help others do the same. 12:46 < wumpus> yes 12:47 < gmaxwell> opportunities* 12:47 < gmaxwell> Were there any other topics? kind of a bummer of a meeting. :) 12:48 < meshcollider> John had a third 12:48 < jnewbery> I had one more quick one on archiving meeting notes (sorry - didn't mean to take up all the time. Thought they'd all be quick) 12:48 < wumpus> #topic archiving meeting notes 12:48 < jnewbery> Botbotme is shutting down. not sure if anyone uses it 12:48 < jnewbery> https://lincolnloop.com/blog/saying-goodbye-botbotme/ 12:48 < wumpus> jnewbery: well it needed to be said, Ithink 12:49 -!- Mrrt [~Mrrt@cpe-74-78-139-4.maine.res.rr.com] has quit [Ping timeout: 244 seconds] 12:49 < jnewbery> I know that the bitcoincore.org meeting notes summaries linked there at least 12:49 < jnewbery> meeting notes also link to http://www.erisian.com.au/meetbot/bitcoin-core-dev/ , which I think is maintained by aj 12:49 < jnewbery> it'd be a shame if that went away at some point. I wonder if it makes sense to keep a mirror of the meeting notes somewher in the project 12:50 < achow101> we could have our own logger that publishes to bitcoincore.org? 12:50 < meshcollider> Meeting notes or full channel log? 12:50 < wumpus> we have aj's logger right? 12:50 < gmaxwell> Both would be nice, but seperately. 12:50 < jnewbery> meeting notes are most important I think, but yeah both 12:50 < wumpus> the meetingbot logs to www.erisian.com.au 12:51 < wumpus> as for summaries those should be part of the bitcoincore.org site itself not linked externally 12:51 < jnewbery> yes, summaries are at bitcoincore.org 12:51 < meshcollider> provoostenator: am I right in thinking you ran a logger at some point? 12:51 < wumpus> could also copy the logs there, I gues 12:52 < wumpus> would be good to have everything self-contained 12:52 < provoostenator> meshcollider: I did, but no longer do 12:52 < meshcollider> Ok 12:52 < achow101> could we migrate aj's meetbot to bitcoincore.org? 12:52 < provoostenator> BotBot server was fairly easy to deploy, so sounds like a good tool for this. 12:53 < wumpus> achow101: dunno, but could auto-copy the logs after a meeting 12:53 < wumpus> it'll print something like 12:53 < wumpus> 21:52 < lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-09-06-19.00.html 12:53 < wumpus> 21:52 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-09-06-19.00.txt 12:53 < wumpus> 21:52 < lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-09-06-19.00.log.html 12:53 < wumpus> so just a matter of copying those to bitcoincore.org and voila 12:54 < meshcollider> Ideally could run both botbot and the meetbot on the bitcoincore.org server directly ? 12:54 < provoostenator> Perhaps irc.bitcoincore.org could run such an instance? It's a much nicer format imo. 12:54 < wumpus> it needs to be checked into git so I don't think it can happen fully automatically 12:54 < provoostenator> Different subdomain means you can skip the Github flow (initially). 12:54 < achow101> wumpus: it could run in a sub domain 12:54 < MarcoFalke> provoostenator: I would want to host random irc logs on the bitcoincore domain 12:55 < MarcoFalke> Can be a completely separate trash.bitcoin-core-dev-logs.domain 12:55 < wumpus> these are only logs of the meeting 12:55 < provoostenator> You can pick which channel(s) to log. Or are you worried even about what could end up in this channel? 12:55 < jamesob> re: cutting down on refactoring PRs: one option might be to add a policy that forces refactoring-only PRs to document how each changed git hunk is covered by tests. If no test exists, obviously the proposing contributor would have to write one. 12:55 < wumpus> oh you want to log the entire channel? 12:56 < MarcoFalke> Yeah, I think it makes sense 12:56 < meshcollider> BotBot currently does and I think that's worth keeping up 12:56 < achow101> I think it currently makes more sense to log the entire channel with botbot going down 12:56 < provoostenator> I've linked to botbot logs in Github tickets more than once. Whatever tool we use, being able to deep-link to a specific message is very nice. 12:56 < wumpus> jamesob: I think that's good policy for any change, yes 12:56 < meshcollider> Agree 12:57 < MarcoFalke> Can botbot be hosted on GitHub (or at least the assets?) 12:58 < jamesob> wumpus: my only reservation is that that's a pretty high burden for large changes from established contributors... but maybe that makes it even more worthwhile :) 12:58 < wumpus> it can't run from github 12:58 < wumpus> jamesob: the biggest issue here is the volume, not so much the changes themselves, many don't even change the compiled code or are obviously correct like removing an argument 12:59 < MarcoFalke> Can it store the logs in a git repo? 12:59 < wumpus> jamesob: whichi s okay, but not of 5 of such PRs are opened every day 12:59 < meshcollider> MarcoFalke: I'm sure you could turn the log directory into a git repo either way 12:59 < wumpus> MarcoFalke: sure, though if commits need to be signed :) 12:59 < provoostenator> OTS? 13:00 < jamesob> wumpus: very much agreed. I was just thinking that such a policy (plainly advertised in a PR template, say) would filter out half-baked or lazy refactors (or at least allow a justified quick close) 13:00 < wumpus> when commigint to bitcoincore.org, really a human needs to be invovled 13:00 < meshcollider> Don't need to sign the commits if they're just pushed to a separate meeting-log repo 13:00 < MarcoFalke> If it is a binary blob (db) it might not work with git (or GitHub at least) 13:00 < wumpus> oh, no it's just text files 13:00 < MarcoFalke> kewl 13:00 < wumpus> #endmeeting 13:00 < lightningbot> Meeting ended Thu Sep 13 20:00:58 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) 13:00 < lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-09-13-19.00.html 13:00 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-09-13-19.00.txt 13:00 < lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-09-13-19.00.log.html 13:01 < promag> jamesob: we already ask to split such pulls to ease review 13:01 -!- phwalkr [~phwalkr@210-84-32-251.dyn.iinet.net.au] has joined #bitcoin-core-dev 13:01 < MarcoFalke> So (1) contact lincolnloop to fetcht the text logs of BotBot (2) put them on GitHub (3) Run a bot somewhere that keeps them up to date and hosts them on some domain? 13:01 < promag> jamesob: and how can we enforce that policy? 13:02 < MarcoFalke> DrahtBot can close prs that are refactoring that is not covered by tests ;) 13:02 < MarcoFalke> Though, that would close almost all refactoring prs 13:02 < jamesob> if the author didn't provide a coverage list and the PR is marked refactoring, it's an immediate close 13:03 < achow101> MarcoFalke: Is it necessary to get the logs from lincolnloop? We have the logs on at least two other sites as text files 13:03 < promag> how can DrathBot know if it's covered or not? 13:03 < MarcoFalke> achow101: If they are complete, then I guess not 13:03 < MarcoFalke> promag: make cov 13:04 < achow101> MarcoFalke: they look complete. they're in the topic 13:05 < meshcollider> So make a new repo in bitcoin-core called irc-logs or something and upload them ? 13:05 < promag> regarding scantxoutset release notes, should create separate file or append to release-notes.md? 13:05 < achow101> promag: use the wiki? 13:05 < achow101> or did that get merged in? 13:06 -!- phwalkr [~phwalkr@210-84-32-251.dyn.iinet.net.au] has quit [Ping timeout: 252 seconds] 13:06 < MarcoFalke> achow101: They don't have html anchors, so hard to link to them for reference 13:06 < MarcoFalke> So I'd prefer them in a botbot-html-format 13:06 < MarcoFalke> The wiki is not yet merged in 13:06 < meshcollider> Yeah ideally all the logs are easily viewable from a botbot-like site 13:06 < promag> achow101: this https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.17.0-Release-notes ? 13:07 < achow101> yes 13:07 < promag> thanks 13:07 -!- clarkmoody [~clarkmood@47-218-248-206.bcstcmta04.res.dyn.suddenlink.net] has quit [] 13:07 < provoostenator> It might be easier to just get the logs in SQL format and then load them into a fresh server? 13:08 * aj waves 13:08 < wumpus> o/ aj 13:08 < aj> fwiw, i've been keeping non meeting channel logs at http://www.erisian.com.au/bitcoin-core-dev/ 13:10 < provoostenator> aj: if you add anchor links to each timestamp, it makes it easier to link directly to one line of text 13:10 < aj> moving the meetbot stuff to bitcoincore.org domain sounds like a good idea, add it to the tokyo todo? 13:11 < provoostenator> Then it's just a question what's easier to maintain, aj's solution or a BotBot server. 13:11 < wumpus> that'd be awesome 13:11 < jnewbery> aj: fantastic! Didn't know about http://www.erisian.com.au/bitcoin-core-dev/ 13:11 < achow101> jnewbery: it's in the topic of this channel 13:12 < aj> jnewbery: it is pretty horrible, but better than nothing :-/ 13:12 < achow101> along with http://gnusha.org/bitcoin-core-dev/ 13:13 < jnewbery> achow101: oh yeah. Thanks 13:14 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 272 seconds] 13:17 < aj> provoostenator: http://www.erisian.com.au/bitcoin-core-dev/log-2018-09-13.html#l-544 might work fwiw 13:18 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 13:18 < wumpus> yep that works 13:19 < wumpus> does take viewing the source to find it, though :) 13:23 < aj> oh, i can fix that 13:26 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 13:31 < aj> oh, no i can't, at least not the documented way :( 13:36 < aj> oh well, it includes line numbers visibly now so it should be easy-ish, but not point and click 14:08 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 245 seconds] 14:11 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 14:12 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 14:18 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev 14:19 < gmaxwell> damn, never thought I'd see the day... windows 10 has a networking feature that I wish linux had. 14:20 < gmaxwell> Apparently you can set a socket option to make a TCP connection use LEDBAT congestion control, on a per socket basis. 14:23 < gmaxwell> but fortunately, MS has ways of making me not feel too bad.. apparently only "approved software" can use the socket option. 14:25 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Ping timeout: 256 seconds] 14:26 < gmaxwell> Thats too bad, it would make for a meaningful improvement in bitcoin node usability for many users if we could use that. 14:29 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev 14:51 < TD-Linux> if it's really useful you could do a userspace implementation a la uTP 14:59 < gmaxwell> TD-Linux: utility vs sheer mass of OMG RCE VULNERABLE CODE... 14:59 < gmaxwell> the utility of it is that peers pulling many old blocks from us utterly slams the network connections of people with bufferbloated links. 14:59 < gmaxwell> And short of LEDBAT there isn't really a good fix for it. 15:00 < gmaxwell> But I don't know that the problem is severe enough that we'd want to ship a userspace network stack... 15:00 < TD-Linux> fair. also those people can prune 15:02 < gmaxwell> TD-Linux: they don't need to prune, they can just turn off service old blocks (set the upload limiter to zero) 15:02 < gmaxwell> serving* 15:02 -!- phwalkr [~phwalkr@210-84-32-251.dyn.iinet.net.au] has joined #bitcoin-core-dev 15:02 < gmaxwell> But indeed, unfortunately having to have them configure stuff is kinda lame... since only a small portion of people who should do it actually will. 15:03 < gmaxwell> the rest will just have a bad time, and turn it off. 15:06 -!- masonicboom [~masonicbo@2600:8802:5501:17c0:edfc:9ad6:5822:1b6c] has joined #bitcoin-core-dev 15:07 -!- phwalkr [~phwalkr@210-84-32-251.dyn.iinet.net.au] has quit [Ping timeout: 272 seconds] 15:08 -!- RubenSomsen [uid301948@gateway/web/irccloud.com/x-gxbpvixeigthogxs] has quit [Quit: Connection closed for inactivity] 15:19 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 15:21 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 15:22 -!- hebasto [~hebasto@195.60.70.234] has quit [Remote host closed the connection] 15:36 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection] 15:38 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 15:59 -!- jarthur [~jarthur@207.114.244.5] has quit [] 16:19 < achow101> wumpus: is #12493 ready to be merged? it has several acks 16:19 < gribble> https://github.com/bitcoin/bitcoin/issues/12493 | [wallet] Reopen CDBEnv after encryption instead of shutting down by achow101 · Pull Request #12493 · bitcoin/bitcoin · GitHub 16:22 -!- masonicboom [~masonicbo@2600:8802:5501:17c0:edfc:9ad6:5822:1b6c] has quit [Ping timeout: 240 seconds] 16:23 -!- masonicboom [~masonicbo@2600:8802:5501:17c0:edfc:9ad6:5822:1b6c] has joined #bitcoin-core-dev 16:37 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Remote host closed the connection] 16:39 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 16:45 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 16:46 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 16:46 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 16:47 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 16:48 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 16:48 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 16:49 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 16:50 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 17:00 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 17:23 -!- masonicboom [~masonicbo@2600:8802:5501:17c0:edfc:9ad6:5822:1b6c] has quit [Remote host closed the connection] 17:23 -!- Giszmo [~leo@pc-72-54-46-190.cm.vtr.net] has quit [Ping timeout: 252 seconds] 17:58 -!- phwalkr [~phwalkr@210-84-32-251.dyn.iinet.net.au] has joined #bitcoin-core-dev 17:59 -!- phwalkr [~phwalkr@210-84-32-251.dyn.iinet.net.au] has quit [Remote host closed the connection] 18:00 -!- Netsplit *.net <-> *.split quits: prod_, victorSN, warren, Nebraskka, hkjn0 18:02 -!- warren [~warren@fedora/wombat/warren] has joined #bitcoin-core-dev 18:03 -!- Nebraskka [~Nebraskka@178.62.130.190] has joined #bitcoin-core-dev 18:03 -!- victorSN [~victorSN@unaffiliated/victorsn] has joined #bitcoin-core-dev 18:10 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has quit [Quit: drexl] 18:28 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 18:29 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 18:41 -!- captjakk [~captjakk@174-29-24-81.hlrn.qwest.net] has joined #bitcoin-core-dev 18:42 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 18:45 -!- da2ce7 [~da2ce7@opentransactions/dev/da2ce7] has joined #bitcoin-core-dev 18:49 -!- captjakk [~captjakk@174-29-24-81.hlrn.qwest.net] has quit [Ping timeout: 244 seconds] 18:51 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Ping timeout: 272 seconds] 18:56 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Remote host closed the connection] 19:00 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev 19:02 -!- lnostdal [~lnostdal@85-118-68-243.mtel.net] has joined #bitcoin-core-dev 19:09 -!- lnostdal [~lnostdal@85-118-68-243.mtel.net] has quit [Ping timeout: 240 seconds] 19:21 -!- lnostdal [~lnostdal@85-118-68-243.mtel.net] has joined #bitcoin-core-dev 19:26 -!- lnostdal [~lnostdal@85-118-68-243.mtel.net] has quit [Ping timeout: 240 seconds] 19:39 -!- lnostdal [~lnostdal@85-118-68-243.mtel.net] has joined #bitcoin-core-dev 19:45 -!- lnostdal [~lnostdal@85-118-68-243.mtel.net] has quit [Ping timeout: 245 seconds] 19:47 -!- masonicboom [~masonicbo@2600:8802:5501:17c0:e8c5:bea8:57de:90ad] has joined #bitcoin-core-dev 20:00 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev 20:02 -!- Netsplit *.net <-> *.split quits: cfields, sdaftuar, so, kanzure, vxe, qinfengling, chjj, BCBot 20:04 -!- BCBot [~BCBot@46.101.246.115] has joined #bitcoin-core-dev 20:05 -!- cfields [~cfields@unaffiliated/cfields] has joined #bitcoin-core-dev 20:06 -!- BCBot [~BCBot@46.101.246.115] has quit [Remote host closed the connection] 20:06 -!- chjj [~chjj@unaffiliated/chjj] has joined #bitcoin-core-dev 20:06 -!- BCBot [~BCBot@46.101.246.115] has joined #bitcoin-core-dev 20:06 -!- masonicboom [~masonicbo@2600:8802:5501:17c0:e8c5:bea8:57de:90ad] has quit [Ping timeout: 250 seconds] 20:07 -!- kanzure [~kanzure@unaffiliated/kanzure] has joined #bitcoin-core-dev 20:17 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Ping timeout: 252 seconds] 20:32 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev 20:55 -!- meshcollider_ [uid246294@gateway/web/irccloud.com/x-wifaqflysqgajhwa] has joined #bitcoin-core-dev 20:59 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection] 21:00 -!- miknotauro [~miknotaur@187.207.79.62] has joined #bitcoin-core-dev 21:07 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev 21:26 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection] 21:26 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 21:43 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Remote host closed the connection] 21:43 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev 22:05 -!- grubles [~grubles@gateway/tor-sasl/grubles] has joined #bitcoin-core-dev 22:50 < kallewoof> Sigh. Why would the wallet_avoidreuse.py get a 'method not found' in travis when it works locally? I don't even know where to begin debugging that. 22:51 < kallewoof> Could be an OS thing I guess. *tries on linux* 22:56 -!- RubenSomsen [uid301948@gateway/web/irccloud.com/x-hvkkfcbfrxcftdkm] has joined #bitcoin-core-dev 23:07 -!- ken2812221_ [~ken281222@61-230-5-60.dynamic-ip.hinet.net] has joined #bitcoin-core-dev 23:09 < ken2812221_> kallewoof: You should skip it if wallet disabled. 23:11 < kallewoof> I think you're right on. It says $ export DEP_OPTS="NO_WALLET=1" 23:11 -!- miknotauro [~miknotaur@187.207.79.62] has quit [Ping timeout: 245 seconds] 23:12 < kallewoof> I'm confused why other tests are working though 23:13 < ken2812221_> See #14180 23:13 < kallewoof> OK I see it now. It's the skip_test_if_missing_module thingie that is in other tests but not in mine. Adding it. Thanks for the hint! 23:13 < gribble> https://github.com/bitcoin/bitcoin/issues/14180 | qa: Run all tests even if wallet is not compiled by MarcoFalke · Pull Request #14180 · bitcoin/bitcoin · GitHubAsset 1Asset 1 23:16 -!- Jmabsd [~jmabsd@210-84-32-251.dyn.iinet.net.au] has joined #bitcoin-core-dev 23:17 < Jmabsd> where again is the code that validates the signature for a segwit input? (as in, generates the signtext for a segwit input, either to validate an input or to generate a transaction) 23:38 -!- booyah [~bb@193.25.1.157] has joined #bitcoin-core-dev 23:43 < sipa> Jmabsd: script/interpreter.cpp, SignatureHash 23:46 -!- ppaqmj [~ppaqmj@u-251-c005.eap.uni-tuebingen.de] has joined #bitcoin-core-dev 23:47 -!- hebasto [~hebasto@195.60.70.234] has joined #bitcoin-core-dev 23:51 < hebasto> wumpus: MarcoFalke: may I ask you to add missed #13844 to the https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.17.0-Release-notes 23:51 < gribble> https://github.com/bitcoin/bitcoin/issues/13844 | doc: correct the help output for -prune by hebasto · Pull Request #13844 · bitcoin/bitcoin · GitHub 23:53 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 23:56 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] --- Log closed Fri Sep 14 00:00:11 2018