--- Log opened Fri Sep 21 00:00:15 2018 00:01 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has quit [Quit: Snoozing.] 00:04 -!- ken2812221_ [~ken281222@36-226-68-170.dynamic-ip.hinet.net] has joined #bitcoin-core-dev 00:06 < ken2812221_> MarcoFalke: Your gpg signing key has expired 00:07 -!- nullptr| [~nullptr|@ip-94-113-103-134.net.upcbroadband.cz] has quit [Ping timeout: 245 seconds] 00:15 -!- nullptr| [~nullptr|@ip-94-113-103-134.net.upcbroadband.cz] has joined #bitcoin-core-dev 00:16 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 00:18 -!- harrymm_ [~harrymm@69.161.195.103] has quit [Ping timeout: 244 seconds] 00:20 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds] 00:21 -!- go1111111 [go1111111@gateway/vpn/privateinternetaccess/go1111111] has joined #bitcoin-core-dev 00:45 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 00:45 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 00:46 -!- hebasto [~hebasto@195.60.70.234] has quit [Remote host closed the connection] 00:48 -!- ishvarts [~User@188.113.19.180] has joined #bitcoin-core-dev 00:55 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 01:02 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 01:07 -!- games_ [sid99242@gateway/web/irccloud.com/x-vefnlqhjyljubnai] has quit [] 01:13 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 01:33 -!- promag [~promag@83.223.251.106] has joined #bitcoin-core-dev 01:45 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 01:45 -!- promag [~promag@83.223.251.106] has quit [Remote host closed the connection] 01:45 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 01:46 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:49 -!- bralyclow [~bralyclow@76-202-84-204.lightspeed.tukrga.sbcglobal.net] has joined #bitcoin-core-dev 01:49 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Remote host closed the connection] 01:51 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds] 01:52 -!- promag [~promag@83.223.251.106] has joined #bitcoin-core-dev 02:22 -!- rex4539 [~rex4539@tor-exit-node.pie-coop.net] has quit [Ping timeout: 272 seconds] 02:26 -!- rex4539 [~rex4539@tor4e1.digitale-gesellschaft.ch] has joined #bitcoin-core-dev 02:42 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 02:45 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 02:45 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 02:56 -!- promag [~promag@83.223.251.106] has quit [Ping timeout: 260 seconds] 03:14 -!- harrymm [~harrymm@69.161.195.103] has joined #bitcoin-core-dev 03:45 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 03:45 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 04:01 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has joined #bitcoin-core-dev 04:05 -!- rex4539 [~rex4539@tor4e1.digitale-gesellschaft.ch] has quit [Quit: rex4539] 04:15 -!- ishvarts [~User@188.113.19.180] has quit [Read error: Connection reset by peer] 04:22 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 04:23 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 04:45 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 04:45 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 04:50 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 05:01 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 05:04 -!- Jmabsd [~jmabsd@124-148-165-161.dyn.iinet.net.au] has joined #bitcoin-core-dev 05:05 < Jmabsd> the code that qualifies and validates a segwit transaction starts on what code locations? 05:10 < Jmabsd> mostly validation.cpp's AcceptToMemoryPoolWorker 05:21 < Jmabsd> Where is the code that checks the witness merkle root in the coinbase transaction? 05:23 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Quit: Leaving] 05:34 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 05:36 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 05:36 -!- rex4539 [~rex4539@chulak.enn.lu] has joined #bitcoin-core-dev 05:45 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 05:45 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 245 seconds] 05:45 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 05:48 -!- rex4539 [~rex4539@chulak.enn.lu] has quit [Quit: rex4539] 05:50 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 06:04 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 06:07 -!- csknk [~csknk@unaffiliated/csknk] has joined #bitcoin-core-dev 06:12 -!- games_ [sid99242@gateway/web/irccloud.com/x-xjjfwmbgaodzcpaf] has joined #bitcoin-core-dev 06:13 -!- Sentineo [~Undefined@unaffiliated/sentineo] has joined #bitcoin-core-dev 06:24 -!- grubles_ [~grubles@gateway/tor-sasl/grubles] has joined #bitcoin-core-dev 06:24 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 06:27 -!- grubles [~grubles@gateway/tor-sasl/grubles] has quit [Ping timeout: 256 seconds] 06:45 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 06:45 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 06:48 -!- voltron [~voltron@103.226.140.220] has joined #bitcoin-core-dev 06:54 -!- hebasto [~hebasto@195.60.70.234] has joined #bitcoin-core-dev 06:56 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 246 seconds] 07:00 -!- Krellan [~Krellan@2601:640:4000:9258:cde1:1d24:d39a:9398] has joined #bitcoin-core-dev 07:01 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 07:02 -!- bralyclow [~bralyclow@76-202-84-204.lightspeed.tukrga.sbcglobal.net] has quit [Remote host closed the connection] 07:03 -!- bralyclow [~bralyclow@76-202-84-204.lightspeed.tukrga.sbcglobal.net] has joined #bitcoin-core-dev 07:05 -!- Krellan [~Krellan@2601:640:4000:9258:cde1:1d24:d39a:9398] has quit [Ping timeout: 240 seconds] 07:06 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 07:07 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 240 seconds] 07:13 -!- qinfengling [~qinfengli@45.32.53.207] has joined #bitcoin-core-dev 07:19 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 07:21 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 07:25 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 07:26 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 07:38 -!- grubles_ [~grubles@gateway/tor-sasl/grubles] has quit [Quit: Leaving] 07:45 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 07:45 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 07:49 -!- grubles [~grubles@gateway/tor-sasl/grubles] has joined #bitcoin-core-dev 07:56 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 260 seconds] 08:00 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev 08:05 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 08:09 -!- rex4539 [~rex4539@manipogo.relay.coldhak.com] has joined #bitcoin-core-dev 08:18 -!- grubles [~grubles@gateway/tor-sasl/grubles] has quit [Remote host closed the connection] 08:18 -!- grubles [~grubles@gateway/tor-sasl/grubles] has joined #bitcoin-core-dev 08:29 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 240 seconds] 08:31 -!- emilengler [~emil@ip4d145229.dynamic.kabel-deutschland.de] has joined #bitcoin-core-dev 08:33 < emilengler> If I download the linux tarball, will I be able to select a download path for the blockchain ? 08:33 < luke-jr> yes, if you know how or use the GUI 08:34 < luke-jr> better topic for #Bitcoin 08:34 < emilengler> Ok I will keep this in mind excuse me 08:34 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 08:40 -!- emilengler [~emil@ip4d145229.dynamic.kabel-deutschland.de] has quit [Quit: Konversation terminated!] 08:40 -!- ExtraCrispy [~ExtraCris@67.215.11.12] has joined #bitcoin-core-dev 08:45 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 08:45 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 09:04 -!- Jmabsd [~jmabsd@124-148-165-161.dyn.iinet.net.au] has quit [Ping timeout: 246 seconds] 09:11 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 09:14 -!- rex4539 [~rex4539@manipogo.relay.coldhak.com] has quit [Quit: rex4539] 09:16 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 09:18 -!- mr_paz [~paz@c-71-57-73-68.hsd1.il.comcast.net] has joined #bitcoin-core-dev 09:23 -!- jarthur [~jarthur@207.114.244.5] has quit [Quit: presentation mode] 09:27 -!- mr_paz_ [~mr_paz@c-71-57-73-68.hsd1.il.comcast.net] has joined #bitcoin-core-dev 09:28 -!- mr_paz [~paz@c-71-57-73-68.hsd1.il.comcast.net] has quit [Quit: Leaving] 09:29 -!- emilengler [~emil@ip4d145229.dynamic.kabel-deutschland.de] has joined #bitcoin-core-dev 09:35 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 09:36 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 09:45 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 09:45 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 10:18 -!- voltron [~voltron@103.226.140.220] has quit [Quit: WeeChat 1.9.1] 10:29 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 10:31 < provoostenator> I used invalidateblock on a remote node to go back to ~ 475000, but lost the connection after a few hours. The last debug message is from an hour ago, an updatetip down to 508954. It's in a weird state. 10:32 < provoostenator> Memory usage was swinging between 5GB and 8GB. I was able to shut it down via rpc, though the last message was "net thread exit" which sounds like an unclean exit. 10:32 -!- treebeardd [~treebeard@50-241-115-219-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 10:34 < provoostenator> Restarting the node, now it's "Replaying blocks", "Rolling back ... 542229" and down from there. 10:34 -!- Sinclair_ [sinclair6@gateway/vpn/privateinternetaccess/sinclair6] has joined #bitcoin-core-dev 10:34 -!- Sinclair6 [sinclair6@gateway/vpn/privateinternetaccess/sinclair6] has quit [Read error: Connection reset by peer] 10:38 -!- jnewbery [~john@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 10:45 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 10:45 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 10:47 -!- hebasto [~hebasto@195.60.70.234] has quit [Remote host closed the connection] 10:59 < sdaftuar> provoostenator: what version bitcoind was it? 11:00 < provoostenator> sdaftuar: v0.17.0rc2 (I was actually dumb enough to not upgrade it before doing this) 11:01 < provoostenator> I also don't know if invalidateblock is supposed to work for such a huge rollback. Though if not, then perhaps the documentation should warn against that. 11:02 < sdaftuar> well, i think we do want it to work 11:02 < provoostenator> Also, the RPC call is blocking. Does getting disconnected have any bearing on that? 11:02 < sdaftuar> no, the invalidateblock function should continue even after the rpc client disconnects, i think 11:03 < sdaftuar> i believe if you had waited long enough, it probably would have finished? 11:03 < sdaftuar> but it might be several hours 11:03 < provoostenator> The logs also suggest it continued for about 30 minutes after disconnecting. 11:04 < sdaftuar> disconnecting blocks is heavily disk-bound. when i last looked at it (on different hardware than i use today), i think i noticed i could disconnect on the order of 3-5 blocks/second, on average 11:04 < provoostenator> It got about halfway in 2-3 hours, so indeed it looked like it would have made it. 11:04 < provoostenator> This is an iMac with SSD and plenty of memory. 11:05 < sdaftuar> we used to have an issue where the memory usage could grow sort of unbounded, as disconnected blocks would have their transactions added to the mempool 11:05 < sdaftuar> but that was fixed 11:05 < provoostenator> Yeah the weird thing I noticed is how dbcache kept growing as it was disconnecting. 11:05 < sdaftuar> but your comment about 5-8GB of memory has me slightly concerned 11:05 < provoostenator> The machine has 64 GB so it didn't run out. 11:05 < sdaftuar> what is -dbcache set to? 11:06 < provoostenator> 5000, so that's bad 11:06 -!- itaseski [~itaseski@213.135.179.187] has joined #bitcoin-core-dev 11:07 < provoostenator> The mempool is just the default, so that shouldn't have grown so much, right? 11:07 < sdaftuar> yeah assuming the code works correctly, the mempool's memory usage would have been bounded pretty well 11:08 < provoostenator> Last log entry had cache=4650.7MiB 11:09 < sdaftuar> oh so that seems good then 11:10 < provoostenator> The 5-8 GB RAM usage was an hour after the last log entry, when I reconnected, found through "top". 11:14 < sdaftuar> alright well maybe this is all expected (crappy) behavior. i don't know of any clever ideas to speed up block disconnection, unfortunately. 11:14 < sdaftuar> maybe someone could implement https://github.com/bitcoin/bitcoin/issues/8037 11:17 < provoostenator> Maybe invalidateblock could have a "don't bother adding to the mempool" option? 11:19 < provoostenator> I just noticed I have txindex=1, so that could be another issue. 11:19 < sdaftuar> provoostenator: yeah that's fair but i suspect it would still take hours 11:19 < gmaxwell> provoostenator: it's not clear to me what you're saying you saw 11:19 < gmaxwell> provoostenator: was it still rolling back when you stopped it? 11:20 < gmaxwell> if it was then it just sounds like expected behavior. 11:20 < provoostenator> gmaxwell: rolling back was after I restarted (it's still doing that now). 11:20 < gmaxwell> I've rolled back all the way to block 0 many times, though not recently. 11:21 < gmaxwell> provoostenator: yea, it'll keep going until it finishes. 11:21 < kanzure> mailing list bug has been reoslved; can someone send the post mortem link to the mailing list subscribers plzkthx? like https://bitcoincore.org/en/2018/09/20/notice/ 11:21 < sipa> kanzure: didn't BlueMatt send one? 11:21 < provoostenator> Before I disconnected (a few hours ago) it was doing "UpdateTip: new best ..." in reverse order, as expcted from doing invalidateblock 11:21 < kanzure> i don't see one in the mod queue 11:22 < kanzure> and i don't see it on https://lists.linuxfoundation.org/pipermail/bitcoin-dev/2018-September/thread.html 11:22 < provoostenator> The logs shows it kept doing that for 30 mins after I disconnected from the machine. 11:23 < provoostenator> When I logged back into the machine, bitcoind was still running, using 5-8 GB of RAM (it was actually going up and down in the space of minutes), but log wasn't updating. I then stopped it via rpc and restarted. 11:23 < provoostenator> So it seems it was still doing _something_, despite not logging. 11:23 < luke-jr> FYI, I still didn't get anything for 0.6.3/CVE from https://bitcoincore.org/en/list/announcements/join/ yet 11:24 < gmaxwell> provoostenator: what you're seeing without the logs is the atomic flush roll forward probably. 11:24 < luke-jr> sipa: ^ since you are one of the 3 who can apparently send those 11:24 < sdaftuar> provoostenator: gmaxwell: it does seem surprising i guess that an unclean shutdown happened? 11:24 < sdaftuar> how would that be possible if you just use rpc to stop the node? 11:25 < provoostenator> gmaxwell: what is a "atomic flush roll forward"? 11:25 < sdaftuar> provoostenator: on startup, we detect if the utxo state wasn't finished being written as of what we think our tip is. 11:26 < sdaftuar> in that situation, we have a rollback / rollforward mechanism to fix the utxo 11:26 < sdaftuar> by disconnecting blocks that are no longer on our chain, and replaying the blocks that might need applying to the utxo state 11:27 < sdaftuar> that should only happen after an unclean shutdown though 11:27 < gmaxwell> not to change subject but anyone know what this is? https://www.reddit.com/r/Bitcoin/comments/9hrusk/orhpan_blocks/e6e4zhk/?context=3 11:28 < gmaxwell> sdaftuar: indeed. I missed that the shutdown was supposted to be clean. 11:33 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 11:38 < provoostenator> gmaxwell: that warning is triggered here: https://github.com/bitcoinj/bitcoinj/blob/master/core/src/main/java/org/bitcoinj/core/AbstractBlockChain.java#L584 11:45 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 11:45 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 11:45 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 11:45 < provoostenator> "duplicate block" seems to mean that it already processed it, nothing to do with orphans. 11:46 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 272 seconds] 11:46 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 11:48 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 11:53 < kanzure> *poke* postmortem email plzkthx 12:01 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Read error: Connection reset by peer] 12:06 -!- rex4539 [~rex4539@this-is-a-tor-exit-node-hviv120.hviv.nl] has joined #bitcoin-core-dev 12:09 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 12:12 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 12:12 < provoostenator> Ok, so roll back made it to 509650 and all seems well. Except the node seems to have forgotten I invalidated block 485000, because it jumped right into IBD and is moving forward again. 12:16 < provoostenator> I guess that's because the node doesn't check the full block index at launch. 12:19 < provoostenator> Restarted, now using v0.17.0rc4, doing nanother invalidateblock. Memory usage is almost 2GB higher than cache= shown in the logs, and seems to outpace it. 12:19 < provoostenator> I've also turned off the index. 12:21 < gmaxwell> what are the actual dirty page counts? 12:21 < gmaxwell> we recently realized that OS cached pages in mmaped files show up in res. 12:22 < provoostenator> Also, it's still going even though bitcoin-cli stop said it would stop. I'll look at the dirty page counts... 12:22 < provoostenator> (note to self: do not google "top dirty pages") 12:23 < sipa> lol 12:23 < gmaxwell> oh sorry, pmap -x $(pidof bitcoind) | tail -n 1 | tr -s ' ' | cut -d' ' -f 4 12:26 < provoostenator> macOS doesn't have pmap, but vmmap gives me this summary: https://gist.github.com/Sjors/6b01711ccd0f96128c7db5230c85ae8f 12:27 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection] 12:28 < provoostenator> Also a long list of "mapped file", e.g. many "locks/index/*.ldb" 12:29 < gmaxwell> k, so ~2GB of your resident size is mapped files. 12:29 < gmaxwell> whats your dbcache setting? 12:30 < provoostenator> dbcache=5000 MB, the log currently says cache=2300 MiB, so that part makes sense? 12:30 < provoostenator> It's the just the other 6 GB that needs explaining. Memory usage is now 10 GB. 38 more and the machine is going to OOM, which I'm not going to allow. 12:32 < provoostenator> MALLOC_TINY is now at 8.7, so that seems to be the thing that's mooning. 12:36 < provoostenator> (actually this is still v0.17.0rc2, sorry, though hopefully that doesn't matter here) 12:36 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 260 seconds] 12:36 < provoostenator> (no, it is v0.17.0rc4) 12:37 < provoostenator> kill has no effect, kill -9 did 12:45 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 12:45 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 12:46 < provoostenator> Getting fairly consistent behavior now, even with disablewallet=1. bitcoin-cli stop seems to stop the RPC server, but not the invalidation process. Curious if anyone can reproduce. I'll let it sync to the tip before trying again. 12:47 < sipa> if invalidateblock does not succeed, its state isn't writte 12:48 < sipa> it first disconnects the blocks, and then marks them as invalid 12:48 < sipa> so at startup they will be connected again if bitcoind was killed in the middle 12:50 < provoostenator> That makes sense. I wonder if it matter that I was essentially interrupting IBD with that invalidateblock call. Memory usage seemed way worse than what I saw earlier today. 12:50 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 12:50 < sipa> invalidateblock also keeps a list of transactions to re-add to the mempool after the invalidation completes 12:51 < sipa> i assume that's the memory usage you see 12:51 < provoostenator> Is it also not abortable once in progress? 12:52 < sipa> no 12:53 < provoostenator> Ok, so in that case the way to roll back a long way would be to do it in smaller increments. 12:54 < sipa> right 12:54 < sipa> that should work 12:55 < gmaxwell> sipa: the mempool usage is limited. 12:55 < sipa> gmaxwell: how? 12:58 < gmaxwell> https://github.com/bitcoin/bitcoin/pull/9208 13:01 < sipa> gmaxwell: it doesn't look like DisconnectedBlockTransactions enforces any memory limits 13:01 < gmaxwell> MAX_DISCONNECTED_TX_POOL_SIZE 13:02 < sipa> oh 13:02 < provoostenator> There's also this open issue: #9027 13:02 < gribble> https://github.com/bitcoin/bitcoin/issues/9027 | Unbounded reorg memory usage · Issue #9027 · bitcoin/bitcoin · GitHub 13:02 < sipa> yup 13:03 < sipa> i was expecting the code to be elsewhere, my bad 13:05 < provoostenator> I take great pride in doing stupid things that lead to a new release candidate, so hopefully you'll find something :-) 13:08 < gmaxwell> provoostenator: are you running txindex? 13:08 < provoostenator> No, I did the first time today, but turned that off in more recent attempts. 13:10 -!- rex4539 [~rex4539@this-is-a-tor-exit-node-hviv120.hviv.nl] has quit [Quit: rex4539] 13:11 -!- rex4539 [~rex4539@185.220.101.27] has joined #bitcoin-core-dev 13:13 < provoostenator> Re incremental approach: I rolled back ~10,000 blocks using about 13GB of RAM, cache=2200 at the peak. Sounds like it's holding all transactions in memory. 13:16 < provoostenator> But then it gets weird. ERROR: AcceptToMemoryPoolWorker: Consensus::CheckTxInputs: ... bad-txns-premature-spend-of-coinbase, tried to spend coinbase at depth 92 13:17 < provoostenator> InvalidChainFound: invalid block [the block I invalidated] 13:17 < gmaxwell> thats normal. 13:17 < provoostenator> Yeah, but then it starts syncing again. 13:19 -!- rex4539 [~rex4539@185.220.101.27] has quit [Quit: rex4539] 13:19 -!- rex4539 [~rex4539@tor-exit1.netnik.xyz] has joined #bitcoin-core-dev 13:22 < provoostenator> Ok, now I think I destroyed my chain :-) At boot: "assertion failed: (!setBlockIndexCandidates.empty()), function PruneBlockIndexCandidates, file validation.cpp, line 2547" 13:32 < sipa> provoostenator: i found the issue 13:33 < sipa> it's specific to InvalidateBlock 13:33 < provoostenator> sipa: nice! 13:38 -!- emilengler [~emil@ip4d145229.dynamic.kabel-deutschland.de] has quit [Quit: Konversation terminated!] 13:41 < provoostenator> sipa: is it because disconnectpool holds on to transactions which reference a shared_ptr pblock, so those don't get deallocated? 13:41 < sipa> provoostenator: no 13:42 -!- JackH [~laptop@host86-182-8-23.range86-182.btcentralplus.com] has joined #bitcoin-core-dev 13:44 < sipa> the event queue holds on to the shared_ptr objects in callbacks to DisconnectedBlock 13:44 < sipa> and InvalidateBlock doesn't limit the size of the queue 13:46 < sipa> provoostenator: could you check whether this issue also occurs when Rewinding? 13:47 < sipa> create a 0.13.0 node, sync it to tip, and then upgrade to 0.17+ 13:47 < sipa> i suspect it is, and if that's the case, i would consider it a release blocker 13:48 < provoostenator> That's the rewind that happens if you upgrade a non-segwit node to a segwit node? 13:48 < sipa> yup 13:49 < provoostenator> I'll give it a try this weekend or early next week. Getting a bit late here. Maybe someone else gets to it first. 13:49 < sipa> thanks! 13:50 < provoostenator> I'm not looking forward to doing another release notes for 0.14 and 0.15 backports :-) 14:03 -!- treebeardd [~treebeard@50-241-115-219-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 14:23 -!- rafaeltokyo [~keynote@2804:14d:ba86:8900:d0ba:33d4:42fc:3b42] has joined #bitcoin-core-dev 14:24 -!- rafaeltokyo [~keynote@2804:14d:ba86:8900:d0ba:33d4:42fc:3b42] has left #bitcoin-core-dev [] 14:28 -!- rafaeltokyo [~keynote@2804:14d:ba86:8900:d0ba:33d4:42fc:3b42] has joined #bitcoin-core-dev 14:28 -!- rafaeltokyo [~keynote@2804:14d:ba86:8900:d0ba:33d4:42fc:3b42] has left #bitcoin-core-dev ["WeeChat 1.9.1"] 14:40 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 14:42 < MarcoFalke> About #14289, was it ever supported to call invalidateblock on a block very far back? 14:42 < gribble> https://github.com/bitcoin/bitcoin/issues/14289 | Unbounded growth of scheduler queue · Issue #14289 · bitcoin/bitcoin · GitHub 14:43 < sipa> MarcoFalke: i would say no, but it'd be a nice-to-have if it worked 14:43 < sipa> having invalidateblock 100000 blocks deep use a massive amount of memory is not a blocker, i think 14:43 < MarcoFalke> Ok, that was my impression because every time I tried that it would deadlock the node a bit until I got impatient and CTRL+C out 14:44 < MarcoFalke> If that is supported with reasonable memory gurantees, we should add a test/benchmark so it doesn't randomly regress 14:45 < MarcoFalke> Also my key is de-expired, but I am having issues uploading it to keyservers. 14:45 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 14:45 < MarcoFalke> All of them return some obscure proxy error or timeout or ... 14:45 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 14:46 < gmaxwell> MarcoFalke: yes worked fine since 9208. 14:46 < gmaxwell> the rpc will disconnect, because the rpc timeout isn't long enough for it to finish, but a node will happly work its way back to block 0. 14:48 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 14:50 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 15:02 < Murch> MarcoFalke: Luckily Keyservers may soonish be a thing of the past: https://wiki.gnupg.org/WKD 15:27 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection] 15:37 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 15:45 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 15:45 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 15:47 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Read error: Connection reset by peer] 15:49 -!- JackH [~laptop@host86-182-8-23.range86-182.btcentralplus.com] has quit [Quit: Leaving] 15:55 -!- csknk [~csknk@unaffiliated/csknk] has quit [Remote host closed the connection] 16:14 -!- jarthur [~jarthur@207.114.244.5] has quit [] 16:32 -!- ken2812221__ [~ken281222@36-226-68-170.dynamic-ip.hinet.net] has joined #bitcoin-core-dev 16:33 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection] 16:33 -!- adam3us [~adam3us@unaffiliated/adam3us] has quit [Ping timeout: 252 seconds] 16:35 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 252 seconds] 16:35 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 252 seconds] 16:35 -!- ken2812221_ [~ken281222@36-226-68-170.dynamic-ip.hinet.net] has quit [Ping timeout: 252 seconds] 16:35 -!- rafalcpp [~racalcppp@84.10.11.234] has joined #bitcoin-core-dev 16:36 -!- adam3us [~adam3us@unaffiliated/adam3us] has joined #bitcoin-core-dev 16:39 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev 16:45 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 16:45 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 16:45 -!- r8921039 [~r8921039@173.239.65.123] has joined #bitcoin-core-dev 16:49 -!- r8921039 [~r8921039@173.239.65.123] has quit [Quit: leaving] 17:04 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 17:13 -!- r8921039 [~r8921039@173.239.65.123] has joined #bitcoin-core-dev 17:15 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 17:20 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 272 seconds] 17:24 -!- r8921039 [~r8921039@173.239.65.123] has quit [Ping timeout: 246 seconds] 17:30 -!- IGHOR [~quassel@93.178.216.72] has quit [Quit: http://quassel-irc.org ? ??????????? ?????????. ????-??.] 17:35 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev 17:40 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has quit [Read error: Connection reset by peer] 17:45 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 17:45 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 17:48 -!- Mrrt [~Mrrt@cpe-74-78-139-4.maine.res.rr.com] has joined #bitcoin-core-dev 17:52 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 18:15 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 18:20 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 252 seconds] 18:45 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 18:45 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 19:01 -!- profmac [~ProfMac@2001:470:1f0f:226:5091:3d40:c9ab:d702] has quit [Ping timeout: 264 seconds] 19:32 -!- profmac [~ProfMac@72-48-98-98.dyn.grandenetworks.net] has joined #bitcoin-core-dev 19:40 -!- harrymm_ [~harrymm@223.205.76.195] has joined #bitcoin-core-dev 19:40 -!- harrymm [~harrymm@69.161.195.103] has quit [Ping timeout: 245 seconds] 19:41 -!- harrymm [~harrymm@69.161.195.103] has joined #bitcoin-core-dev 19:44 -!- harrymm_ [~harrymm@223.205.76.195] has quit [Ping timeout: 260 seconds] 19:45 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 19:45 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 20:11 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 272 seconds] 20:16 -!- itaseski [~itaseski@213.135.179.187] has quit [Quit: Leaving] 20:16 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 20:22 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds] 20:42 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 20:45 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 20:45 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 20:45 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 20:56 -!- bralyclow [~bralyclow@76-202-84-204.lightspeed.tukrga.sbcglobal.net] has quit [Remote host closed the connection] 20:57 -!- bralyclow [~bralyclow@76-202-84-204.lightspeed.tukrga.sbcglobal.net] has joined #bitcoin-core-dev 21:07 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Read error: Connection reset by peer] 21:09 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 21:18 -!- mr_paz_ [~mr_paz@c-71-57-73-68.hsd1.il.comcast.net] has quit [Remote host closed the connection] 21:20 -!- rafaeltokyo [~keynote@189.4.73.80] has joined #bitcoin-core-dev 21:27 -!- profmac [~ProfMac@72-48-98-98.dyn.grandenetworks.net] has quit [Remote host closed the connection] 21:28 < rafaeltokyo> hi 21:29 -!- rafaeltokyo [~keynote@189.4.73.80] has left #bitcoin-core-dev ["WeeChat 1.9.1"] 21:35 -!- profmac [~ProfMac@72-48-98-98.dyn.grandenetworks.net] has joined #bitcoin-core-dev 21:44 -!- harrymm [~harrymm@69.161.195.103] has quit [Ping timeout: 240 seconds] 21:45 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 21:45 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 21:57 -!- harrymm [~harrymm@69.161.195.103] has joined #bitcoin-core-dev 22:35 -!- harrymm [~harrymm@69.161.195.103] has quit [Ping timeout: 252 seconds] 22:35 -!- Sinclair_ [sinclair6@gateway/vpn/privateinternetaccess/sinclair6] has quit [] 22:45 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 22:45 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 22:48 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Read error: Connection reset by peer] 22:49 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 23:42 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Read error: Connection reset by peer] 23:44 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 23:45 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 23:45 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 23:54 -!- BashCo [~BashCo@unaffiliated/bashco] has quit [Read error: Connection reset by peer] 23:55 -!- BashCo [~BashCo@unaffiliated/bashco] has joined #bitcoin-core-dev 23:59 -!- hebasto [~hebasto@195.60.70.234] has joined #bitcoin-core-dev --- Log closed Sat Sep 22 00:00:16 2018