--- Log opened Sat Oct 06 00:00:29 2018
00:02 -!- escrivner [~user@cpe-76-175-74-114.socal.res.rr.com] has joined #bitcoin-core-dev
00:03 -!- jarthur [~jarthur@2605:6000:1019:41ab:8451:6be6:3872:9077] has quit []
00:06 < gwillen> is there a good way to ask the wallet to do coin selection including watch-only coins (for offline signing)?
00:07 -!- escrivner [~user@cpe-76-175-74-114.socal.res.rr.com] has quit [Ping timeout: 252 seconds]
00:09 < gwillen> I tried just setting the fAllowWatchOnly flag on CCoinControl
00:09 < gwillen> but various bits of machinery do not want to include watch-only coins even with that flag set
00:11 < gwillen> in particular in CWallet::GetAvailableBalance we check COutput::fSpendable on the coins before we count them, even if the fAllowWatchOnly flag is set
00:21 < luke-jr> gwillen: I thought fundrawtransaction could do it
00:26 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
00:26 < achow101> gwillen: fundrawtransaction should be able to select watch only coins
00:28 < achow101> gwillen: spendable in that case means solvable. the private key does not necessarily need to be in the wallet, but the pubkey and any related scripts do
00:29 < gwillen> hmmmmmmmm
00:30 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has quit [Client Quit]
00:32 < gwillen> I feel dumb asking this but why is solvability necessary 
00:32 < jnewbery> phantomcircuit: do you have a log from a failing rpc_zmq.py test for #14336? Or a link to travis for a failing build?
00:32 < gribble> https://github.com/bitcoin/bitcoin/issues/14336 | net: implement poll by pstratem · Pull Request #14336 · bitcoin/bitcoin · GitHub
00:32 < gwillen> it's enough to be able to find the utxos in order to build a transaction, right? as long as the offline signer can solve it?
00:32 < achow101> gwillen: solvability is required for fee estimation
00:33 < gwillen> ahhhhhhh hmmm
00:33 < gwillen> ok, then I have another dumb question
00:34 < gwillen> assuming that using importpubkey instead of importaddress will get me a solvable watch-only key, how do I _get_ a pubkey that I can import with importpubkey?
00:34 < gwillen> validateaddress only gives the scriptpubkey
00:34 < gwillen> (I mean, starting from a wallet that does know the privkey, how do I export the pubkey so I can then import it elsewhere)
00:34 < sipa> use getaddressinfo
00:35 < sipa> validateaddress is turning into a non-wallet RPC
00:35 < gwillen> aha, thanks
00:35 -!- escrivner [~user@cpe-76-175-74-114.socal.res.rr.com] has joined #bitcoin-core-dev
00:36 < midnightmagic> gwillen: consider writing up a howto after getting your offline signing going..?
00:36 < gwillen> midnightmagic: the goal here is not merely to write a howto, it's to write a GUI :-)
00:37 < gwillen> but a howto is not a bad idea as an intermediate step
00:37 < midnightmagic> including the offline component?
00:37 < gwillen> yeah
00:37 < midnightmagic> oh, nice.
00:37 < midnightmagic> nvm me then.
00:37 < gwillen> I mean, a gui will take awhile to get in, a real offline signing howto isn't a bad idea at all, I keep referring to greg's version but it doesn't use the wallet for coin selection, it just does it by hand
00:40 -!- escrivner [~user@cpe-76-175-74-114.socal.res.rr.com] has quit [Ping timeout: 252 seconds]
00:48 -!- escrivner [~user@cpe-76-175-74-114.socal.res.rr.com] has joined #bitcoin-core-dev
00:53 -!- escrivner [~user@cpe-76-175-74-114.socal.res.rr.com] has quit [Ping timeout: 272 seconds]
00:54 < gwillen> ah, dangit, I'm hitting https://github.com/bitcoin/bitcoin/issues/12253
00:54 < gwillen> you can't actually do this
00:55 < gmaxwell> well, thats a recently introduced bug unfortunately.
00:56 < gmaxwell> oh no
00:57 < gwillen> it seems like importing a segwit address solvably was just not yet implemented
00:58 < achow101> gwillen: if you import the pubkey using importmulti, you will get all of the segwit stuff too
00:58 < gwillen> no, see the bug, doesn't work
00:58 < gwillen> unless I'm misunderstanding what's happening, you cannot get "solvable": true for a segwit address
00:58 < gmaxwell> gwillen: I think 12253 is just outdated, and doesn't reflect the full segwit support or 0.16.
00:58 < achow101> gwillen: you specify the p2pkh address, then give a pubkey array with the pubkey
00:58 < gwillen> oh hm okay
00:59 < gwillen> I already did that though, I provided the redeemscript and the pubkey
00:59 < achow101> you end up with the pubkey being imported. the address is ignored
00:59 < gwillen> but it's still not solvable
00:59 < gwillen> I may be doing it wrong, it did accept it
00:59 < achow101> don't give the redeemScript
00:59 < achow101> also don't give a bech32 address or p2sh address
00:59 < gwillen> erm, how do I get a p2pkh address
01:00 < achow101> there's a way using getaddressinfo and then decodescript
01:00 -!- escrivner [~user@cpe-76-175-74-114.socal.res.rr.com] has joined #bitcoin-core-dev
01:01 < gmaxwell> gwillen: for testing purpose, lol http://gobittest.appspot.com/Address
01:02 < gwillen> hahaha
01:02 < gwillen> I need testnet though
01:03 < gwillen> also it feels a little bad to me that there's no permutation of the stuff that comes out of getaddressinfo that can go into importmulti and work :-P
01:03 < sipa> gwillen: yeah, importmulti and segwit is only accidental to the extent that it works
01:03 < achow101> there was some method I found a while ago, but I can't remember it
01:04 < sipa> we should have prioritized that for 0.17...
01:04 < gwillen> sipa: is https://github.com/bitcoin/bitcoin/issues/12253 still current? gmaxwell was saying he thought it was outdated.
01:04 < sipa> i think it's current?
01:04 < sipa> it was a known missing part in 0.16
01:04 < sipa> and we didn't improve upon it in 0.17 afaik
01:05 -!- escrivner [~user@cpe-76-175-74-114.socal.res.rr.com] has quit [Ping timeout: 260 seconds]
01:05 < gwillen> does the crazy shit achow101 proposed above function as a workaround to get a segwit address imported, or does it just import it as a non-segwit address and happen to work?
01:09 < gmaxwell> The wallet works much more like "bag of pubkeys which get interperted many ways" than we'd like, but changing it is slow going due to compatbility needs.
01:10 < gwillen> will just doing importpubkey do the right thing, and interpret the pubkey many ways?
01:10 < gwillen> I had thought I couldn't do that because of rescanning but achow pointed out that I can just rescan manually
01:11 -!- bralyclow [~bralyclow@76-202-84-204.lightspeed.tukrga.sbcglobal.net] has quit [Ping timeout: 252 seconds]
01:13 -!- escrivner [~user@cpe-76-175-74-114.socal.res.rr.com] has joined #bitcoin-core-dev
01:14 -!- phwalkr [~phwalkr@194.210.91.110] has joined #bitcoin-core-dev
01:15 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev
01:16 < gwillen> yesss okay that works
01:18 -!- thedrs [4d8b5bd9@gateway/web/freenode/ip.77.139.91.217] has joined #bitcoin-core-dev
01:18 -!- phwalkr [~phwalkr@194.210.91.110] has quit [Ping timeout: 252 seconds]
01:18 -!- escrivner [~user@cpe-76-175-74-114.socal.res.rr.com] has quit [Ping timeout: 272 seconds]
01:19 < thedrs> hi, sorry to bug you guys, bitcoin 0.17 installer is identified as maleware by MBAM, is this known ?
01:25 -!- escrivner [~user@cpe-76-175-74-114.socal.res.rr.com] has joined #bitcoin-core-dev
01:27 < Lauda> ^false positive. #bitcoin
01:28 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection]
01:28 < thedrs> yep though so
01:28 < thedrs> but no google info about it. i reported it to MBAM
01:29 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev
01:29 < luke-jr> thedrs: check the PGP signatures
01:30 -!- escrivner [~user@cpe-76-175-74-114.socal.res.rr.com] has quit [Ping timeout: 244 seconds]
01:31 -!- csknk [~csknk@unaffiliated/csknk] has joined #bitcoin-core-dev
01:36 -!- phwalkr [~phwalkr@194.210.91.110] has joined #bitcoin-core-dev
01:38 -!- escrivner [~user@cpe-76-175-74-114.socal.res.rr.com] has joined #bitcoin-core-dev
01:43 -!- JackH [~laptop@host86-182-8-23.range86-182.btcentralplus.com] has joined #bitcoin-core-dev
01:43 -!- escrivner [~user@cpe-76-175-74-114.socal.res.rr.com] has quit [Ping timeout: 260 seconds]
01:50 -!- escrivner [~user@cpe-76-175-74-114.socal.res.rr.com] has joined #bitcoin-core-dev
01:55 -!- escrivner [~user@cpe-76-175-74-114.socal.res.rr.com] has quit [Ping timeout: 272 seconds]
02:03 -!- nullptr| [~nullptr|@ip-94-113-103-134.net.upcbroadband.cz] has quit [Ping timeout: 252 seconds]
02:10 -!- nullptr| [~nullptr|@ip-94-113-103-134.net.upcbroadband.cz] has joined #bitcoin-core-dev
02:15 -!- escrivner [~user@cpe-76-175-74-114.socal.res.rr.com] has joined #bitcoin-core-dev
02:20 -!- escrivner [~user@cpe-76-175-74-114.socal.res.rr.com] has quit [Ping timeout: 245 seconds]
02:20 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Ping timeout: 256 seconds]
02:22 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev
02:28 -!- escrivner [~user@cpe-76-175-74-114.socal.res.rr.com] has joined #bitcoin-core-dev
02:29 -!- booyah_ is now known as booyah
02:32 -!- escrivner [~user@cpe-76-175-74-114.socal.res.rr.com] has quit [Ping timeout: 240 seconds]
02:32 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev
02:40 -!- escrivner [~user@cpe-76-175-74-114.socal.res.rr.com] has joined #bitcoin-core-dev
02:44 -!- escrivner [~user@cpe-76-175-74-114.socal.res.rr.com] has quit [Ping timeout: 244 seconds]
02:46 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]
02:52 -!- escrivner [~user@cpe-76-175-74-114.socal.res.rr.com] has joined #bitcoin-core-dev
02:58 -!- escrivner [~user@cpe-76-175-74-114.socal.res.rr.com] has quit [Ping timeout: 272 seconds]
03:05 < jonasschnelli> The wallets watch-only capabilities is a mess!
03:05 -!- escrivner [~user@cpe-76-175-74-114.socal.res.rr.com] has joined #bitcoin-core-dev
03:06 < jonasschnelli> The only way how to import a watch only multisig is by importing the outer script, the readme-script and all it's pubkeys (via importpubkey)
03:06 < sipa> you don't need the pubkeys for multisig
03:06 < sipa> only for p2pkh
03:06 < jonasschnelli> sipa:If you don't import the pubkey they are non-solvable and not useable in fundraw
03:07 < jonasschnelli> So you need to import via importpubkey (and import all possible scripts!)
03:07 < sipa> jonasschnelli: that makes no sense
03:07 < jonasschnelli> GetScriptForRawPubKey will then lead to extract the pubKey and place them mapWatchKeys
03:07 < jonasschnelli> Agree it makes no sense...
03:07 < sipa> importing a pubkey is so that the signing code can find the pubkey based on the hash of the key
03:08 < sipa> in a multisig there are no key hashes involved
03:08 < sipa> just the redeemscript should be enough for multisig
03:08 < sipa> plus importaddress of the toplevel thing
03:08 < jonasschnelli> Yes. But following isSolvable, it will require to find the pubkey in oder to flag it solveable
03:09 < sipa> it has the pubkey; it's in the redeemscript
03:09 < sipa> i'm very skeptical :)
03:09 < jonasschnelli> but it won't find it...
03:09 < sipa> have you tried this?
03:09 < jonasschnelli> Yes
03:09 < sipa> i find this very hard to believe
03:09 < jonasschnelli> mapWatchKeys gets only touched by AddWatchOnly
03:09 < jonasschnelli> Try yourself... with the following steps:
03:09 < jonasschnelli> 1. createwallet "dummy" true
03:09 < sipa> what do you need mapWatchKeys for in multisig?
03:09 -!- escrivner [~user@cpe-76-175-74-114.socal.res.rr.com] has quit [Ping timeout: 252 seconds]
03:10 < jonasschnelli> sipa: pure watching no,.. but if you want to use them for watchOnly coinselection via fundraw, yes, you need it with the corrent code
03:10 < sipa> that makes no sense :)
03:10 < sipa> if you say so, i believe you
03:11 < sipa> bit i don't know what that is the case
03:11 < jonasschnelli> Try it youself. :)
03:11 < sipa> i can't right now
03:11 < jonasschnelli> Sure. No hurry...
03:11 < jonasschnelli> the use case: decouple the keys from the wallet
03:11 < jonasschnelli> (via importing scripts and using fundrawtransaction)
03:11 < sipa> yes not claiming this isn't important!
03:11 < sipa> i'm just not understanding why you need to import the pubkeys
03:12 < sipa> they are in the redeemscript
03:12 < sipa> the signing code doesn't need to look up any pubkeys
03:12 < jonasschnelli> Because: fundraw takes only solvable imputs. isSolveable requires to find the pubKey in the keystore.
03:12 < jonasschnelli> But it's fixable IMO
03:12 < sipa> why?
03:13 < jonasschnelli> isSolveable _currently_ requires to find the pubKey... its just coded that way...
03:13 < sipa> can you point me to the code?
03:14 < jonasschnelli> 1s..
03:14 < jonasschnelli> code part 1: https://github.com/bitcoin/bitcoin/blob/master/src/script/sign.cpp#L141
03:15 < sipa> sure, but that doesn't need the pubkey imported, only the redeemscript
03:16 < jonasschnelli> code part 2: https://github.com/bitcoin/bitcoin/blob/aa39ca764578a9017e03796b554955796022eb0d/src/script/sign.cpp#L84
03:16 < jonasschnelli> (GetPubKey(provider, sigdata, keyid, pubkey);)
03:16 < jonasschnelli> Goes into: bool CCryptoKeyStore::GetPubKey(const CKeyID &address, CPubKey& vchPubKeyOut) const
03:16 < sipa> oh
03:16 < sipa> you're right
03:16 -!- phwalkr [~phwalkr@194.210.91.110] has quit [Remote host closed the connection]
03:17 < sipa> that's stupid :)
03:17 < jonasschnelli> yes... it's a mess
03:17  * sipa quietly mentions descriptors again
03:17 < jonasschnelli> Indeed!
03:17 -!- escrivner [~user@cpe-76-175-74-114.socal.res.rr.com] has joined #bitcoin-core-dev
03:18 < jonasschnelli> You can bypass that problem by importpubkey all the multisigs pubkeys because it will generate a RawPubKeyScript where the pubkeys gets extracted and added to the keystore. :/
03:18 < jonasschnelli> (with an overhead of a couple of unused scripts)
03:18 < sipa> yeah
03:18 < sipa> but that's pretty ridiculous
03:19 < jonasschnelli> Which you have to do anyways for P2SH(P2WPKH) scripts to flag them solvable since importmulti can't handle it...
03:19 < jonasschnelli> or for native P2WPKH
03:20 < jonasschnelli> because importmulti compare the scriptPubKey with the P2PKH(pubkey) and refuse to insert the pubkey if no match. :/
03:22 -!- escrivner [~user@cpe-76-175-74-114.socal.res.rr.com] has quit [Ping timeout: 244 seconds]
03:26 < sipa> jonasschnelli: fixing
03:27 < jonasschnelli> sipa: \o/
03:27 -!- phwalkr [~phwalkr@194.210.91.110] has joined #bitcoin-core-dev
03:30 < sipa> jonasschnelli: i wonder if this was a regression in 0.17?
03:30 -!- escrivner [~user@cpe-76-175-74-114.socal.res.rr.com] has joined #bitcoin-core-dev
03:30 < jonasschnelli> sipa: possible... I haven't checked that.
03:30 < jonasschnelli> (will do now)
03:32 < sipa> jonasschnelli: thanks!
03:34 < sipa> jonasschnelli: i need to run, but this may fix it: https://github.com/sipa/bitcoin/tree/201810_importpubkeylol (it fails a bip174 test, need to investigate)
03:34 < jonasschnelli> thanks.. no hurry
03:34 -!- escrivner [~user@cpe-76-175-74-114.socal.res.rr.com] has quit [Ping timeout: 252 seconds]
03:36 -!- rex4539 [~rex4539@ppp-2-84-165-183.home.otenet.gr] has quit [Quit: rex4539]
03:42 -!- escrivner [~user@cpe-76-175-74-114.socal.res.rr.com] has joined #bitcoin-core-dev
03:47 -!- escrivner [~user@cpe-76-175-74-114.socal.res.rr.com] has quit [Ping timeout: 260 seconds]
03:47 < jonasschnelli> sipa: looks like a 0.17 regression
03:54 < thedrs> luke-jr, i verified it
03:54 < thedrs>  >sha256sum /c/bitcoin-0.17.0-win64-setup.exe b37f738ab17a93e24028fa74280b74c353653cf03fc2fb7da6ead8669e440b1a */c/bitcoin-0.17.0-win64-setup.exe /c/Users/ichi >certUtil -hashfile /c/bitcoin-0.17.0-win64-setup.exe SHA256 SHA256 hash of file C:/bitcoin-0.17.0-win64-setup.exe: b3 7f 73 8a b1 7a 93 e2 40 28 fa 74 28 0b 74 c3 53 65 3c f0 3f c2 fb 7d a6 ea d8 66 9e 44 0b 1a
03:55 < thedrs> looks ok
03:55 -!- escrivner [~user@cpe-76-175-74-114.socal.res.rr.com] has joined #bitcoin-core-dev
03:56 < thedrs> ran it via virustotal, and strangley, MBAM passes it there. Although i 7/67 negativ results
03:59 -!- escrivner [~user@cpe-76-175-74-114.socal.res.rr.com] has quit [Ping timeout: 252 seconds]
04:07 -!- escrivner [~user@cpe-76-175-74-114.socal.res.rr.com] has joined #bitcoin-core-dev
04:12 -!- escrivner [~user@cpe-76-175-74-114.socal.res.rr.com] has quit [Ping timeout: 252 seconds]
04:14 < echeveria> thedrs: virustotal tells you literally nothing about the safety of running a binary, sorry.
04:20 -!- escrivner [~user@cpe-76-175-74-114.socal.res.rr.com] has joined #bitcoin-core-dev
04:25 -!- escrivner [~user@cpe-76-175-74-114.socal.res.rr.com] has quit [Ping timeout: 268 seconds]
04:32 -!- escrivner [~user@cpe-76-175-74-114.socal.res.rr.com] has joined #bitcoin-core-dev
04:33 -!- thedrs [4d8b5bd9@gateway/web/freenode/ip.77.139.91.217] has quit [Quit: Page closed]
04:37 -!- rex4539 [~rex4539@ppp-2-84-165-183.home.otenet.gr] has joined #bitcoin-core-dev
04:37 -!- escrivner [~user@cpe-76-175-74-114.socal.res.rr.com] has quit [Ping timeout: 260 seconds]
04:44 -!- escrivner [~user@cpe-76-175-74-114.socal.res.rr.com] has joined #bitcoin-core-dev
04:49 -!- escrivner [~user@cpe-76-175-74-114.socal.res.rr.com] has quit [Ping timeout: 272 seconds]
04:57 -!- escrivner [~user@cpe-76-175-74-114.socal.res.rr.com] has joined #bitcoin-core-dev
05:00 -!- phwalkr [~phwalkr@194.210.91.110] has quit [Remote host closed the connection]
05:02 -!- escrivner [~user@cpe-76-175-74-114.socal.res.rr.com] has quit [Ping timeout: 264 seconds]
05:09 -!- escrivner [~user@cpe-76-175-74-114.socal.res.rr.com] has joined #bitcoin-core-dev
05:14 -!- escrivner [~user@cpe-76-175-74-114.socal.res.rr.com] has quit [Ping timeout: 245 seconds]
05:26 -!- ken2812221 [~ken281222@110.50.135.178] has quit [Remote host closed the connection]
05:26 -!- ken2812221 [~ken281222@110.50.135.178] has joined #bitcoin-core-dev
05:30 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection]
05:31 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev
05:37 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]
05:39 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
06:04 -!- reallll [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
06:05 -!- no_input_found [no_input_f@gateway/vpn/privateinternetaccess/noinputfound/x-24977668] has quit [Ping timeout: 245 seconds]
06:06 -!- no_input_found [no_input_f@gateway/vpn/privateinternetaccess/noinputfound/x-24977668] has joined #bitcoin-core-dev
06:07 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Ping timeout: 252 seconds]
06:16 < gwillen> jonasschnelli: sipa: so it seems kind of weird to me actually that you need keys to be solvable for fundraw and such to work
06:17 < gwillen> achow101 said it was for fee estimation (I guess so you know the signature size), which makes sense, but ... the various signatures are not that different in size, you could easily make a conservative estimate without needing issolvable to be true
06:17 < gwillen> you might overpay a little but in a lot of cases that's fine
06:17 < jonasschnelli> gwillen: Yes. probably. for P2PKH, you could assume key is always compressed...
06:18 < jonasschnelli> or overpay always by assuming its uncompressed
06:18 < jonasschnelli> maybe make it even configurable
06:23 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev
06:27 < gwillen> *nods*
06:27 < gwillen> better to overpay I think, if you're being sloppy 
06:27 < gwillen> although I guess with RBF it's not so bad anymore
06:33 < jonasschnelli> yes. better overpay.
06:33 < jonasschnelli> but who uses uncompressed keys anymore?!
06:34 -!- unifiedh [~unifiedh@ec2-13-125-219-99.ap-northeast-2.compute.amazonaws.com] has joined #bitcoin-core-dev
06:50 -!- Krellan [~Krellan@2601:640:4000:9258:540e:835b:b344:b457] has quit [Read error: Connection reset by peer]
06:50 -!- Krellan [~Krellan@2601:640:4000:9258:71a3:eea3:fa92:9eb4] has joined #bitcoin-core-dev
06:59 < sipa> jonasschnelli: gemini
07:02 < jonasschnelli> I need to test later, but do we even require the pubkey for fee estimation with P2WPKH inputs?
07:02 < jonasschnelli> I hope not but fear we do
07:02 < sipa> yes i'm sure we do
07:03 < sipa> solvability is defined as "can you sign, ignoring lack of private keys"
07:03 < sipa> you can't sign for a P2WPKH without knowing the pubkey
07:21 < jonasschnelli> shouldn't we split solvability from signability?
07:26 < sipa> i don't think so
07:27 < sipa> it's an interesting special case that indeed for P2WPKH you don't actually need to know the pubkey
07:27 < sipa> but i think that the fact that you don't have it now is more a side effect of it being annoying to pass in, rather than not knowing it at all
07:43 < jonasschnelli> but in order to run fundraw with watch-only, you only want to calculate the fee. If you use P2WPKS or P2SH(P2WPKH) or P2WSH(multisig)... you can calculate the fee when you have the scriptPubKey and optionally the redeem script.. right?
07:44 < jonasschnelli> Maybe I get it wrong, but IMHO, the dummysigner is for fee calculation
07:45 -!- ken2812221 [~ken281222@110.50.135.178] has quit [Remote host closed the connection]
07:45 -!- ken2812221 [~ken281222@110.50.135.178] has joined #bitcoin-core-dev
07:56 < sipa> jonasschnelli: yes, my point is that generally when you need to use fundraw, you know the redeemScript/pubkeys involved
07:57 < sipa> and it's only because it's annoying to import them that we're talkijg about the few edge cases (like p2wpkh) where you can indeed estimate the fee correctly without knowing the pubkey
08:25 -!- bralyclow [~bralyclow@76-202-84-204.lightspeed.tukrga.sbcglobal.net] has joined #bitcoin-core-dev
09:17 -!- unifiedh [~unifiedh@ec2-13-125-219-99.ap-northeast-2.compute.amazonaws.com] has quit [Quit: Leaving]
09:23 -!- harding [quassel@2600:3c03::f03c:91ff:fe7b:78d1] has quit [Remote host closed the connection]
09:24 -!- harding [~quassel@li1228-87.members.linode.com] has joined #bitcoin-core-dev
09:31 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 252 seconds]
09:39 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev
09:48 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection]
09:49 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
10:07 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
10:12 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 252 seconds]
10:13 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
10:28 -!- a5m0_ [~a5m0@unaffiliated/a5m0] has quit [Ping timeout: 268 seconds]
10:30 -!- a5m0 [~a5m0@unaffiliated/a5m0] has joined #bitcoin-core-dev
10:33 -!- reallll is now known as belcher_
10:35 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has quit [Remote host closed the connection]
10:38 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev
10:39 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has quit [Remote host closed the connection]
10:42 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev
10:45 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has quit [Read error: Connection reset by peer]
11:04 -!- smaho [~smaho@2601:40a:8003:71a5:245b:dfc4:4862:1bc4] has joined #bitcoin-core-dev
11:05 -!- ExtraCrispy [~ExtraCris@gateway/tor-sasl/extracrispy] has quit [Remote host closed the connection]
11:08 -!- smaho [~smaho@2601:40a:8003:71a5:245b:dfc4:4862:1bc4] has quit [Client Quit]
11:14 -!- ExtraCrispy [~ExtraCris@gateway/tor-sasl/extracrispy] has joined #bitcoin-core-dev
11:14 -!- ExtraCrispy [~ExtraCris@gateway/tor-sasl/extracrispy] has quit [Remote host closed the connection]
11:21 -!- Krellan [~Krellan@2601:640:4000:9258:71a3:eea3:fa92:9eb4] has quit [Read error: Connection reset by peer]
11:21 -!- Krellan [~Krellan@2601:640:4000:9258:71a3:eea3:fa92:9eb4] has joined #bitcoin-core-dev
11:23 -!- booyah [~bb@193.25.1.157] has quit [Read error: Connection reset by peer]
11:24 -!- booyah [~bb@193.25.1.157] has joined #bitcoin-core-dev
11:31 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev
11:35 -!- bitbee [~bitbee@138.197.209.248] has quit [Quit: Leaving.]
11:39 -!- cryptocat [~cryptocat@unaffiliated/cryptocat] has joined #bitcoin-core-dev
11:41 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Remote host closed the connection]
11:42 -!- schnerchi [~schnerchi@p3EE1C919.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
11:54 -!- ekrok [~ekrok@33.90-149-168.nextgentel.com] has joined #bitcoin-core-dev
11:58 < phantomcircuit> jnewbery, i do not
12:24 -!- ken2812221_ [~ken281222@110.50.135.178] has joined #bitcoin-core-dev
12:28 -!- ken2812221 [~ken281222@110.50.135.178] has quit [Ping timeout: 272 seconds]
12:40 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection]
13:08 -!- rex4539 [~rex4539@ppp-2-84-165-183.home.otenet.gr] has quit [Quit: rex4539]
13:11 -!- rex4539 [~rex4539@ppp-2-84-165-183.home.otenet.gr] has joined #bitcoin-core-dev
13:41 -!- csknk [~csknk@unaffiliated/csknk] has quit [Quit: leaving]
13:58 -!- ekrok [~ekrok@33.90-149-168.nextgentel.com] has quit [Quit: Leaving]
15:25 -!- booyah [~bb@193.25.1.157] has quit [Remote host closed the connection]
15:27 -!- booyah [~bb@193.25.1.157] has joined #bitcoin-core-dev
15:49 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
15:57 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection]
15:58 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev
16:03 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Read error: Connection reset by peer]
16:14 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
16:41 < jnewbery> ok, if you see the failure again, please paste logs/link into the PR and I'll try to work out why it's failing
16:41 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev
16:48 < jnewbery> If it's rpc_zmq.py L31 then I suspect some race between the ZMQNotificationInterface initialization and the test framework sending the getzmqnotifications RPC. Logs would prove that
16:52 < jnewbery> The ZMQ rpc test is pretty useless. I don't know why that rpc isn't just tested in the interface_zmq.py test
16:53 < phantomcircuit> jnewbery, it's the getzmqnotifications call on line 30/31
16:53 < phantomcircuit> im pretty sure it's just a race as you said
16:53 -!- no_input_found [no_input_f@gateway/vpn/privateinternetaccess/noinputfound/x-24977668] has quit [Remote host closed the connection]
16:54 -!- no_input_found [no_input_f@gateway/vpn/privateinternetaccess/noinputfound/x-24977668] has joined #bitcoin-core-dev
16:54 -!- ken2812221_ [~ken281222@110.50.135.178] has quit [Read error: Connection reset by peer]
17:04 < jnewbery> I think I'll just remove that test file and move the rpc test into interface_zmq.py
17:09 -!- dstadulis [~dstadulis@136.0.0.196] has joined #bitcoin-core-dev
17:09 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]
17:12 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Read error: Connection reset by peer]
17:12 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
17:21 < phantomcircuit> jnewbery, yeah the test is just fragile and really doesn't test much
17:24 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Read error: Connection reset by peer]
17:24 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
17:31 -!- dstadulis [~dstadulis@136.0.0.196] has quit [Quit: dstadulis]
17:33 < jnewbery> #14419
17:33 < gribble> https://github.com/bitcoin/bitcoin/issues/14419 | [tests] Remove rpc_zmq.py by jnewbery · Pull Request #14419 · bitcoin/bitcoin · GitHub
17:53 -!- dstadulis [~dstadulis@136.0.0.196] has joined #bitcoin-core-dev
18:01 -!- bralyclow [~bralyclow@76-202-84-204.lightspeed.tukrga.sbcglobal.net] has quit [Ping timeout: 252 seconds]
18:05 -!- Krellan [~Krellan@2601:640:4000:9258:71a3:eea3:fa92:9eb4] has quit [Read error: Connection reset by peer]
18:06 -!- dstadulis [~dstadulis@136.0.0.196] has quit [Quit: dstadulis]
18:09 -!- bralyclow [~bralyclow@76-202-84-204.lightspeed.tukrga.sbcglobal.net] has joined #bitcoin-core-dev
18:16 -!- dstadulis [~dstadulis@136.0.0.196] has joined #bitcoin-core-dev
18:18 -!- dstadulis [~dstadulis@136.0.0.196] has quit [Client Quit]
18:25 -!- no_input_found [no_input_f@gateway/vpn/privateinternetaccess/noinputfound/x-24977668] has quit [Remote host closed the connection]
18:25 -!- no_input_found [no_input_f@gateway/vpn/privateinternetaccess/noinputfound/x-24977668] has joined #bitcoin-core-dev
18:28 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has quit [Read error: Connection reset by peer]
18:54 < gwillen> is there a non-core PSBT software signer, and where do I find it? I thought it was maybe https://github.com/achow101/psbt-simple-signer but that appears to be unfinished.
18:55 < gwillen> achow101: ^
19:06 -!- Giszmo [~leo@pc-72-54-46-190.cm.vtr.net] has joined #bitcoin-core-dev
19:06 -!- Giszmo [~leo@pc-72-54-46-190.cm.vtr.net] has quit [Read error: Connection reset by peer]
19:07 -!- Giszmo [~leo@pc-72-54-46-190.cm.vtr.net] has joined #bitcoin-core-dev
19:49 < achow101> gwillen: yeah, i haven't finished that yet
19:50 < achow101> i don't know if there is one
20:15 -!- schnerchi [~schnerchi@p3EE1C919.dip0.t-ipconnect.de] has quit [Ping timeout: 245 seconds]
21:02 -!- dstadulis [~dstadulis@136.0.0.196] has joined #bitcoin-core-dev
21:14 -!- dstadulis [~dstadulis@136.0.0.196] has quit [Quit: dstadulis]
22:00 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]
22:01 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
22:09 -!- dstadulis [~dstadulis@136.0.0.196] has joined #bitcoin-core-dev
22:16 -!- murrayn [~murrayn@unaffiliated/murrayn] has quit [Ping timeout: 246 seconds]
22:25 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection]
22:26 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev
22:32 -!- dstadulis [~dstadulis@136.0.0.196] has quit [Quit: dstadulis]
22:51 -!- TheHoliestRoger [~TheHolies@unaffiliated/theholiestroger] has quit [Quit: Find me in #TheHolyRoger or https://theholyroger.com]
22:55 -!- TheHoliestRoger [~TheHolies@unaffiliated/theholiestroger] has joined #bitcoin-core-dev
22:59 -!- TheHoliestRoger [~TheHolies@unaffiliated/theholiestroger] has quit [Client Quit]
23:00 -!- Krellan [~Krellan@2601:640:4000:9258:71a3:eea3:fa92:9eb4] has joined #bitcoin-core-dev
23:02 -!- TheHoliestRoger [~TheHolies@unaffiliated/theholiestroger] has joined #bitcoin-core-dev
23:22 -!- dstadulis [~dstadulis@141.255.164.68.adsl.inet-telecom.org] has joined #bitcoin-core-dev
23:31 -!- dstadulis [~dstadulis@141.255.164.68.adsl.inet-telecom.org] has quit [Quit: dstadulis]
23:40 -!- dstadulis [~dstadulis@141.255.166.195] has joined #bitcoin-core-dev
--- Log closed Sun Oct 07 00:00:30 2018