--- Log opened Mon Oct 15 00:00:37 2018
00:00 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
00:03 -!- leishman [~leishman@136.24.189.159] has joined #bitcoin-core-dev
00:05 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 244 seconds]
00:08 -!- leishman [~leishman@136.24.189.159] has quit [Ping timeout: 250 seconds]
00:14 -!- Krellan [~Krellan@2601:640:4000:9258:c57d:4b67:ade4:603b] has quit [Read error: Connection reset by peer]
00:15 -!- Krellan [~Krellan@2601:640:4000:9258:c5e1:e75f:5c47:7990] has joined #bitcoin-core-dev
00:52 -!- schnerch_ [~schnerchi@p3EE1C5CF.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
00:54 -!- jungly [~quassel@79.8.200.97] has joined #bitcoin-core-dev
00:56 -!- schnerchi [~schnerchi@p3EE1C5CF.dip0.t-ipconnect.de] has quit [Ping timeout: 252 seconds]
00:57 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev
01:01 -!- Timmy [ac3a21c4@gateway/web/freenode/ip.172.58.33.196] has joined #bitcoin-core-dev
01:04 -!- harrymurata [6aab2d6c@gateway/web/freenode/ip.106.171.45.108] has joined #bitcoin-core-dev
01:05 -!- harrymurata [6aab2d6c@gateway/web/freenode/ip.106.171.45.108] has quit [Client Quit]
01:05 -!- harrymurata [6aab2d6c@gateway/web/freenode/ip.106.171.45.108] has joined #bitcoin-core-dev
01:06 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev
01:07 -!- harrymurata [6aab2d6c@gateway/web/freenode/ip.106.171.45.108] has quit [Client Quit]
01:10 -!- Timmy [ac3a21c4@gateway/web/freenode/ip.172.58.33.196] has quit [Quit: Page closed]
01:12 -!- bralyclo_ [~bralyclow@76-202-84-204.lightspeed.tukrga.sbcglobal.net] has joined #bitcoin-core-dev
01:14 -!- bralyclow [~bralyclow@76-202-84-204.lightspeed.tukrga.sbcglobal.net] has quit [Ping timeout: 246 seconds]
01:30 -!- proletesseract [~proletess@219.88.232.29] has quit [Remote host closed the connection]
01:35 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
01:44 -!- ExtraCrispy [~ExtraCris@gateway/tor-sasl/extracrispy] has quit [Ping timeout: 256 seconds]
01:53 -!- vah13 [c30d29dc@gateway/web/freenode/ip.195.13.41.220] has joined #bitcoin-core-dev
01:53 -!- ExtraCrispy [~ExtraCris@gateway/tor-sasl/extracrispy] has joined #bitcoin-core-dev
01:55 -!- vah13 [c30d29dc@gateway/web/freenode/ip.195.13.41.220] has quit [Client Quit]
01:56 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Read error: Connection reset by peer]
02:01 < karelb> Is there some linter on bitcoin core that looks for line length?
02:01 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
02:02 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev
02:02 < luke-jr> karelb: hopefully not, as there is no line length limit? :p
02:03 < karelb> :) ok. Some linters say "ok lines should not be longer than 80 characters" etc
02:03 < karelb> s/some linters/some best practices/
02:03 < luke-jr> in practice, we do have some hard wrapping in the codebase, but IMO it's a bad idea
02:03 < sipa> we have plenty of lines that are longer :)
02:03 < luke-jr> everyone's editor is a different width, and can soft-wrap as needed
02:04 < sipa> and we do have a suggested coding style defined by the clang formatter config in the repo
02:04 < karelb> ok, just asking. :D I am now refactoring the RPC doc stuff in this vein - https://gist.github.com/karel-3d/5847ea0172350368dead323211893faa#file-rpc_doc-cpp-L244 - so I am thinking if I should also add some line length limit
02:04 < sipa> but it's not really possible to enforce a strict style without making people waste time dealing with every tiny nit
02:05 < sipa> karelb: make sure you follow conventions for variable/class/... names in new code
02:06 < meshcollider> karelb: is this related/the same/similar to what  achow101 is working on
02:06 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 252 seconds]
02:06 < sipa> (see developer-notes.md)
02:06 < meshcollider> that is, do both of you know what the other is working on to make sure it doesn't overlap
02:07 < karelb> meshcollider: I think it is slightly different. I have saw his repo and I did not really understand it all that much, but it seemed complementary
02:07 < meshcollider> ok, as long as you're aware of it :)
02:08 < karelb> I am, I just don't really understand the code :(
02:08 < karelb> https://github.com/achow101/bitcoin/commit/e7dcff0a571866a9487111dc087b4a6e0e9ad5b6
02:08 < meshcollider> achow101: ping
02:08 < karelb> Hm it seems it is actually similar to what I did, but using univalue
02:13 < karelb> sipa: thanks for the link to dev-notes. I will use that
02:15 < karelb> (I did not write any big c++ code in years, I am surprised it works)
02:18 < meshcollider> lol
02:22  * sipa learned c++ from the bitcoin codebase
02:22 < sipa> i guess it explains some things...
02:23 < karelb> :D
02:23 < karelb> "Class member variables have a m_ prefix" - I don't see that in many class variables in bitcoin codebase?
02:24 < luke-jr> karelb: old code isn't changed, just new code is expected to follow these
02:24 < karelb> oh ok
02:24 < karelb> so it's not a good idea to look at existing code for reference
02:25 < meshcollider> no there are so many styles everywhere it is very inconsistent
02:26 < karelb> ooooh ok
02:27 < meshcollider> e.g. new class naming convention is to not start the class name with C iirc, but most existing classes start with C like CWallet
02:27 < sipa> karelb: read the first parafraph
02:27 < sipa> *paragraph
02:28 < karelb> Oooooh ok. Hmm, looking in github on src/ history, it's interesting how little is there new classes added and mostly it's fixes of existing code. Well not that surprising actually.
02:29 < sipa> yeah :)
02:29 < sipa> karelb: also, new code is often written in new files
02:34 < karelb> Also - how much does bitcoin (at least new code) use all the const correctness stuff? I never know how to write it correctly and where to add `const`
02:34 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
02:50 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-wmnanfyheqitbxeh] has joined #bitcoin-core-dev
02:50 < bitcoin-git> [bitcoin] HatboyWonder opened pull request #14484: changed request payment button text and tab description (master...master) https://github.com/bitcoin/bitcoin/pull/14484
02:50 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-wmnanfyheqitbxeh] has left #bitcoin-core-dev []
03:00 < sipa> karelb: const correctness is easy, never add a const cast
03:00 < sipa> if it compiles, you're good
03:00 < sipa> :)
03:00 < sipa> and there are some small parts of the code that are not const correct, but mostly, yes
03:03 < sipa> (in particular the serialization code does some hairy stuff)
03:07 -!- proletesseract [~proletess@219.88.232.29] has joined #bitcoin-core-dev
03:14 < meshcollider> sipa: I was thinking about the import descriptor thing internally converting to old structures
03:14 < meshcollider> for ranges, how would that work
03:15 < meshcollider> surely not cover the whole 2^31-1 range or whatever?
03:15 < meshcollider> or is that ok
03:17 < meshcollider> or just not support ranges for now
03:22 < sipa> meshcollider: you'd specify the range along with the import
03:23 < sipa> if you specify a billion, you're importing a billion addresses, and the wallet file will likely catch fire and explode
03:24 < meshcollider> only one wildcard is allowed in the path eh? No ambiguity if only a single number is used to specify the range?
03:26 < sipa> you can have multiple hd paths that end with * in a descriptor
03:26 < sipa> but they're always combined pairwise
03:27 < sipa> or in other words, all *s are replaced with the same number in an expansion
03:27 < meshcollider> ah I see, yep
03:28 < meshcollider> and does a range always start from 0
03:28 < meshcollider> or should it be a start, end pair
03:30 -!- ExtraCrispy [~ExtraCris@gateway/tor-sasl/extracrispy] has quit [Ping timeout: 256 seconds]
03:31 < sipa> that's up to the application
03:31 < sipa> the descriptor is really just a list of addresses
03:32 < sipa> the application chooses to evaluate it at certain positions of the list
03:38 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev
03:38 -!- Guyver2_ [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev
03:39 -!- Guyver2_ [AdiIRC@guyver2.xs4all.nl] has quit [Client Quit]
03:41 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 246 seconds]
03:41 -!- ExtraCrispy [~ExtraCris@gateway/tor-sasl/extracrispy] has joined #bitcoin-core-dev
03:46 -!- xHire is now known as SunbeamMajesty
03:50 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-pzuxzisjqhxsenau] has joined #bitcoin-core-dev
03:50 < bitcoin-git> [bitcoin] jonasschnelli pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/be992701b018...2a2cac787360
03:50 < bitcoin-git> bitcoin/master 2f6b466 Pieter Wuille: Stop requiring imported pubkey to sign non-PKH schemes
03:50 < bitcoin-git> bitcoin/master 2a2cac7 Jonas Schnelli: Merge #14424: Stop requiring imported pubkey to sign non-PKH schemes...
03:50 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-pzuxzisjqhxsenau] has left #bitcoin-core-dev []
03:51 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-djymzdaannuqswrk] has joined #bitcoin-core-dev
03:51 < bitcoin-git> [bitcoin] jonasschnelli closed pull request #14424: Stop requiring imported pubkey to sign non-PKH schemes (master...201810_importpubkeylol) https://github.com/bitcoin/bitcoin/pull/14424
03:51 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-djymzdaannuqswrk] has left #bitcoin-core-dev []
03:54 -!- SunbeamMajesty is now known as xHire
04:03 -!- rex4539 [~rex4539@ppp-94-67-5-19.home.otenet.gr] has joined #bitcoin-core-dev
04:06 -!- reallll [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
04:09 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Ping timeout: 244 seconds]
04:36 < luke-jr> MarcoFalke: why'd you close #14080 ?
04:36 < gribble> https://github.com/bitcoin/bitcoin/issues/14080 | travis: Run unit tests --with-sanitizers=thread by MarcoFalke · Pull Request #14080 · bitcoin/bitcoin · GitHub
04:41 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has quit [Read error: Connection reset by peer]
04:41 -!- Deacyde [~Deacyde@unaffiliated/deacyde] has joined #bitcoin-core-dev
04:44 -!- proletesseract [~proletess@219.88.232.29] has quit [Remote host closed the connection]
04:45 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection]
05:01 < jonasschnelli> sipa: what is the status of Bech32X (26 char checksum BCH)?
05:08 -!- reallll is now known as belcher
05:13 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection]
05:14 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev
05:20 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ozqwvkzhttqlhqfn] has joined #bitcoin-core-dev
05:20 < bitcoin-git> [bitcoin] luke-jr opened pull request #14485: Try to use posix_fadvise with CBufferedFile (master...fadvise) https://github.com/bitcoin/bitcoin/pull/14485
05:20 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ozqwvkzhttqlhqfn] has left #bitcoin-core-dev []
05:27 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev
05:39 -!- promag [~promag@83.223.234.229] has joined #bitcoin-core-dev
05:44 -!- rex4539 [~rex4539@ppp-94-67-5-19.home.otenet.gr] has quit [Quit: rex4539]
05:50 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-awbljrrcwmnzhphg] has joined #bitcoin-core-dev
05:50 < bitcoin-git> [bitcoin] mrwhythat closed pull request #14476: RPC method 'encodescript' (master...encodescript-rpc) https://github.com/bitcoin/bitcoin/pull/14476
05:50 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-awbljrrcwmnzhphg] has left #bitcoin-core-dev []
05:57 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
05:59 -!- rex4539 [~rex4539@ppp141237119093.access.hol.gr] has joined #bitcoin-core-dev
06:00 -!- rex4539 [~rex4539@ppp141237119093.access.hol.gr] has quit [Client Quit]
06:03 -!- leishman [~leishman@136.24.189.159] has joined #bitcoin-core-dev
06:08 -!- leishman [~leishman@136.24.189.159] has quit [Ping timeout: 252 seconds]
06:10 -!- vamp111 [4e8294da@gateway/web/freenode/ip.78.130.148.218] has joined #bitcoin-core-dev
06:10 < vamp111> Hi, where can i write to support, i have some issues with my full node
06:11 < belcher> vamp111 #bitcoin is best
06:11 < meshcollider> vamp111: either #bitcoin or use the stack exchange, bitcoin.stackexchange.com
06:11 -!- vamp111 [4e8294da@gateway/web/freenode/ip.78.130.148.218] has left #bitcoin-core-dev []
06:21 -!- promag [~promag@83.223.234.229] has quit [Remote host closed the connection]
06:26 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit []
06:28 < meshcollider> sipa: how does something like this look https://github.com/MeshCollider/bitcoin/tree/201810_importmulti_desc
06:29 < meshcollider> Maybe just look at the test case rather than the whole diff for a concept ack
06:29 < meshcollider> I'll open a PR
06:42 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has quit [Ping timeout: 268 seconds]
06:45 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has joined #bitcoin-core-dev
06:48 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.2]
06:48 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-oxcyxxvdhjbupxpm] has joined #bitcoin-core-dev
06:48 < bitcoin-git> [bitcoin] DesWurstes opened pull request #14486: Add explicit cast to base58 and bech32 string constants in order to silence GCC warning (master...patch-4) https://github.com/bitcoin/bitcoin/pull/14486
06:48 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-oxcyxxvdhjbupxpm] has left #bitcoin-core-dev []
07:00 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/]
07:01 -!- Krellan [~Krellan@2601:640:4000:9258:c5e1:e75f:5c47:7990] has quit [Read error: Connection reset by peer]
07:02 -!- Krellan [~Krellan@2601:640:4000:9258:c5e1:e75f:5c47:7990] has joined #bitcoin-core-dev
07:05 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
07:10 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-wyboqpqrlicglrmb] has joined #bitcoin-core-dev
07:10 < bitcoin-git> [bitcoin] DesWurstes opened pull request #14487: Constexpr Everything Part 1: Constants (master...patch-3) https://github.com/bitcoin/bitcoin/pull/14487
07:10 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-wyboqpqrlicglrmb] has left #bitcoin-core-dev []
07:12 -!- pkx1 [~pkx@unaffiliated/pkx] has joined #bitcoin-core-dev
07:13 < instagibbs> meshcollider, oh did you start on the importmulti for descriptors? I already had, but feel free to do it :)
07:26 -!- pkx1 [~pkx@unaffiliated/pkx] has quit [Remote host closed the connection]
07:27 -!- windsok_ [~windsok@rarepepe.cash] has quit [Quit: No Ping reply in 180 seconds.]
07:27 -!- windsok [~windsok@rarepepe.cash] has joined #bitcoin-core-dev
07:27 -!- windsok [~windsok@rarepepe.cash] has quit [Changing host]
07:27 -!- windsok [~windsok@unaffiliated/windsok] has joined #bitcoin-core-dev
07:27 -!- jrayhawk [~jrayhawk@unaffiliated/jrayhawk] has quit [Ping timeout: 260 seconds]
07:29 -!- jrayhawk [~jrayhawk@unaffiliated/jrayhawk] has joined #bitcoin-core-dev
07:40 -!- leishman [~leishman@96.76.219.177] has joined #bitcoin-core-dev
07:42 -!- rex4539 [~rex4539@ppp-94-67-5-19.home.otenet.gr] has joined #bitcoin-core-dev
07:43 -!- shesek [~shesek@188.120.153.212] has joined #bitcoin-core-dev
07:43 -!- shesek [~shesek@188.120.153.212] has quit [Changing host]
07:43 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
07:45 < echeveria> that's binance out of tether.
07:45 < echeveria> they've disabled their tether wallet. 
07:50 -!- leishman [~leishman@96.76.219.177] has quit [Remote host closed the connection]
07:53 -!- Giszmo [~leo@45.232.32.254] has quit [Ping timeout: 268 seconds]
07:54 -!- leishman [~leishman@96.76.219.177] has joined #bitcoin-core-dev
07:54 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev
07:56 < waxwing> sipa, is this comment actually valid as of now? https://github.com/bitcoin/bitcoin/blob/0.17/src/script/sign.cpp#L252-L255
07:56 < waxwing> i ask because FillPSBT won't allow both as per https://github.com/bitcoin/bitcoin/blob/0.17/src/wallet/rpcwallet.cpp#L4528-L4534
07:57 < waxwing> and non-wallet inputs would be covered by the deserialization checking sanity (as i think it says in the comment)
08:01 < promag> jnewbery: can you review #14291?
08:01 < gribble> https://github.com/bitcoin/bitcoin/issues/14291 | wallet: Add ListWalletDir utility function by promag · Pull Request #14291 · bitcoin/bitcoin · GitHub
08:02 -!- kabaum_ [~kabaum@h-13-35.A163.priv.bahnhof.se] has joined #bitcoin-core-dev
08:03 < sipa> waxwing: not valid anymore, right
08:03 < sipa> the code in rpcwallet you quote is more recent
08:06 < waxwing> sipa, thx
08:10 -!- Giszmo [~leo@190.46.54.72] has joined #bitcoin-core-dev
08:11 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.2]
08:27 -!- leishman [~leishman@96.76.219.177] has quit [Remote host closed the connection]
08:32 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Remote host closed the connection]
08:35 -!- windsok [~windsok@unaffiliated/windsok] has quit [Quit: No Ping reply in 180 seconds.]
08:36 -!- windsok [~windsok@rarepepe.cash] has joined #bitcoin-core-dev
08:36 -!- windsok [~windsok@rarepepe.cash] has quit [Changing host]
08:36 -!- windsok [~windsok@unaffiliated/windsok] has joined #bitcoin-core-dev
08:43 -!- leishman [~leishman@50.237.29.22] has joined #bitcoin-core-dev
08:46 -!- leishman [~leishman@50.237.29.22] has quit [Remote host closed the connection]
08:47 -!- leishman [~leishman@50.237.29.22] has joined #bitcoin-core-dev
08:49 -!- bralyclo_ [~bralyclow@76-202-84-204.lightspeed.tukrga.sbcglobal.net] has quit []
08:49 -!- bralyclow [~bralyclow@76-202-84-204.lightspeed.tukrga.sbcglobal.net] has joined #bitcoin-core-dev
08:52 -!- leishman [~leishman@50.237.29.22] has quit [Remote host closed the connection]
08:54 -!- leishman [~leishman@50.237.29.22] has joined #bitcoin-core-dev
08:58 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has quit [Ping timeout: 272 seconds]
09:01 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]
09:04 -!- Krellan [~Krellan@2601:640:4000:9258:c5e1:e75f:5c47:7990] has quit [Ping timeout: 276 seconds]
09:05 -!- rex4539 [~rex4539@ppp-94-67-5-19.home.otenet.gr] has quit [Quit: rex4539]
09:09 -!- leishman [~leishman@50.237.29.22] has quit [Remote host closed the connection]
09:10 -!- irc_viewer_test [irc_viewer@gateway/vpn/privateinternetaccess/ircviewertest/x-06412631] has joined #bitcoin-core-dev
09:12 -!- leishman [~leishman@50.237.29.22] has joined #bitcoin-core-dev
09:13 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 246 seconds]
09:15 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
09:16 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
09:17 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
09:25 -!- Krellan [~Krellan@2601:640:4000:9258:c5e1:e75f:5c47:7990] has joined #bitcoin-core-dev
09:35 -!- irc_viewer_test1 [irc_viewer@gateway/vpn/privateinternetaccess/ircviewertest/x-06412631] has joined #bitcoin-core-dev
09:37 -!- irc_viewer_test [irc_viewer@gateway/vpn/privateinternetaccess/ircviewertest/x-06412631] has quit [Ping timeout: 244 seconds]
09:39 -!- irc_viewer_test1 [irc_viewer@gateway/vpn/privateinternetaccess/ircviewertest/x-06412631] has quit [Client Quit]
09:40 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev
09:42 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has quit [Read error: Connection reset by peer]
09:44 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has joined #bitcoin-core-dev
09:45 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Ping timeout: 246 seconds]
09:50 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev
09:53 -!- leishman [~leishman@50.237.29.22] has quit [Remote host closed the connection]
09:55 -!- leishman [~leishman@50.237.29.22] has joined #bitcoin-core-dev
09:55 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
09:57 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev
09:59 -!- leishman [~leishman@50.237.29.22] has quit [Ping timeout: 245 seconds]
10:00 -!- leishman [~leishman@50.237.29.22] has joined #bitcoin-core-dev
10:02 -!- leishman [~leishman@50.237.29.22] has quit [Remote host closed the connection]
10:04 -!- leishman [~leishman@50.237.29.22] has joined #bitcoin-core-dev
10:30 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection]
10:30 -!- meshcollider_ [uid246294@gateway/web/irccloud.com/x-iaeihkgdlmmskdhm] has joined #bitcoin-core-dev
10:31 -!- jarthur [~jarthur@207.114.244.5] has quit [Ping timeout: 272 seconds]
10:33 -!- jungly [~quassel@79.8.200.97] has quit [Remote host closed the connection]
10:33 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 245 seconds]
10:41 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 272 seconds]
10:42 -!- Krellan [~Krellan@2601:640:4000:9258:c5e1:e75f:5c47:7990] has quit [Remote host closed the connection]
10:53 -!- str4d [~str4d@169.243.9.51.dyn.plus.net] has joined #bitcoin-core-dev
11:02 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has quit [Ping timeout: 246 seconds]
11:11 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 250 seconds]
11:16 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
11:29 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has joined #bitcoin-core-dev
11:33 -!- leishman [~leishman@50.237.29.22] has quit [Remote host closed the connection]
11:35 -!- leishman [~leishman@50.237.29.22] has joined #bitcoin-core-dev
11:40 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Quit: Leaving]
11:43 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
11:43 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
11:55 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
12:21 -!- leishman [~leishman@50.237.29.22] has quit [Remote host closed the connection]
12:21 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 250 seconds]
12:22 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
12:23 -!- leishman [~leishman@50.237.29.22] has joined #bitcoin-core-dev
12:27 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
12:30 -!- leishman [~leishman@50.237.29.22] has quit [Remote host closed the connection]
12:35 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
12:40 -!- meshcollider_ [uid246294@gateway/web/irccloud.com/x-iaeihkgdlmmskdhm] has quit [Quit: Connection closed for inactivity]
12:43 -!- rex4539 [~rex4539@ppp-2-84-165-183.home.otenet.gr] has joined #bitcoin-core-dev
12:56 -!- leishman [~leishman@50.237.29.22] has joined #bitcoin-core-dev
13:11 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
13:28 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev
13:32 -!- draptomano4 [c9d8f07b@gateway/web/freenode/ip.201.216.240.123] has joined #bitcoin-core-dev
13:32 -!- leishman [~leishman@50.237.29.22] has quit [Remote host closed the connection]
13:33 -!- draptomano4 [c9d8f07b@gateway/web/freenode/ip.201.216.240.123] has quit [Client Quit]
13:39 -!- leishman [~leishman@50.237.29.22] has joined #bitcoin-core-dev
13:50 < sipa> achow101, meshcollider: looking back at your PRs #14454 and #14019, i'm confused why we need to import the raw pubkey scripts when doing an importmulti
13:50 < gribble> https://github.com/bitcoin/bitcoin/issues/14454 | Add SegWit support to importmulti by MeshCollider · Pull Request #14454 · bitcoin/bitcoin · GitHub
13:50 < gribble> https://github.com/bitcoin/bitcoin/issues/14019 | Import pubkeys when importing p2sh with importmulti by achow101 · Pull Request #14019 · bitcoin/bitcoin · GitHub
13:50 < sipa> i understand you may want to add a key to mapKeyMetaData in order to have hd path information etc, but that's not what's happening
13:51 < sipa> and since #14424 having the pubkey itself imported should only be needed to P2PKH and P2WPKH
13:51 < gribble> https://github.com/bitcoin/bitcoin/issues/14424 | Stop requiring imported pubkey to sign non-PKH schemes by sipa · Pull Request #14424 · bitcoin/bitcoin · GitHub
13:54 < achow101> sipa: 14019 as needed as a precursor to #14021 which does the hd path import stuff.
13:54 < gribble> https://github.com/bitcoin/bitcoin/issues/14021 | Import key origin data through importmulti by achow101 · Pull Request #14021 · bitcoin/bitcoin · GitHub
13:55 < achow101> I separated that into 2 PRs because the importing of pubkeys in a p2sh seemed to be orthogonal to the end goal
13:56 < sipa> but why do you need the pubkey itself imported?
13:56 < sipa> i think you just need a mapKeyMetadata entry
13:57 < achow101> so that GetPubKey and/or CreateSig work
13:57 < sipa> GetPubKey should only be needed for PKH schemes
13:57 < sipa> since 14424
13:58 < sipa> i'd really like to avoid making unrelated things watched; for multisig that's even dangerous as someone can trick you into thinking you're being paid by paying to one of the constituent pubkeys rather than the multisig script
13:59 < sipa> oh, CreateSig also takes a CKeyID as input?
14:01 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]
14:01 < sipa> oh, no
14:01 < sipa> not anymore
14:01 < sipa> achow101: can you please test if this is still needed since 14424?
14:02 < achow101> with 14424, I don't think that importing pubkeys with p2sh is necessary anymore
14:02 < sipa> okay!
14:02 < achow101> unless we support signing with arbitrary scripts which may contain pubkey hashes
14:02 < achow101> (this has been requested by someone and I said I would look into it)
14:03 < sipa> that's not supported anyway right now
14:03 < sipa> and with descriptors that would become possible without making payments to those pubkeys themselves treated as ismine
14:03 < achow101> eh, the request was actually signing arbitrary scripts in a psbt, so importing pubkeys probably wouldn't be necessary
14:04 < achow101> It could probably be done by bypassing ProduceSignature and doing a simple signer instead for psbts
14:04 < sipa> right
14:06 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-kmyrlnpdkpkmddfi] has joined #bitcoin-core-dev
14:06 < bitcoin-git> [bitcoin] achow101 closed pull request #14019: Import pubkeys when importing p2sh with importmulti (master...import-multi-pubkeys) https://github.com/bitcoin/bitcoin/pull/14019
14:06 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-kmyrlnpdkpkmddfi] has left #bitcoin-core-dev []
14:08 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
14:17 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…]
14:21 -!- ExtraCrispy [~ExtraCris@gateway/tor-sasl/extracrispy] has quit [Ping timeout: 256 seconds]
14:24 -!- leishman [~leishman@50.237.29.22] has quit [Remote host closed the connection]
14:24 -!- ExtraCrispy [~ExtraCris@gateway/tor-sasl/extracrispy] has joined #bitcoin-core-dev
14:24 -!- leishman [~leishman@50.237.29.22] has joined #bitcoin-core-dev
14:32 -!- leishman [~leishman@50.237.29.22] has quit [Remote host closed the connection]
14:37 -!- leishman [~leishman@50.237.29.22] has joined #bitcoin-core-dev
14:45 < meshcollider> sipa: in that case, it looks like I can just delete the entire "// Import public keys." block of code?
14:45 < meshcollider> Because the case of single key addresses P2PK, P2PKH, P2WPKH is already covered above
14:46 < meshcollider> Well, I just need to move the actual import to there
14:46 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev
14:51 < sipa> meshcollider: i haven't looked in detail at the implementation
14:52 < meshcollider> I mean, is the only case where we need to import a public key is for a P2PKH/P2WPKH without the private key?
14:52 < sipa> right, and P2SH-P2WPKH
14:54 -!- bitconner [~conner@136.24.75.121] has joined #bitcoin-core-dev
14:54 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Quit: https://www.Quanto.ga/]
14:56 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev
15:00 -!- newhere1111 [68ae706c@gateway/web/freenode/ip.104.174.112.108] has joined #bitcoin-core-dev
15:02 -!- newhere1111 [68ae706c@gateway/web/freenode/ip.104.174.112.108] has quit [Client Quit]
15:09 -!- proletesseract [~proletess@2403:4d00:300:5:f5eb:2ad7:c67a:3c36] has joined #bitcoin-core-dev
15:29 -!- proletesseract [~proletess@2403:4d00:300:5:f5eb:2ad7:c67a:3c36] has quit [Remote host closed the connection]
15:33 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
15:36 -!- proletesseract [~proletess@103.247.155.68] has joined #bitcoin-core-dev
15:38 -!- jb55 [~jb55@S010660e327dca171.vc.shawcable.net] has quit [Quit: WeeChat 2.2]
15:41 -!- proletesseract [~proletess@103.247.155.68] has quit [Ping timeout: 250 seconds]
15:46 -!- laurentmt [~Thunderbi@37.58.58.232] has joined #bitcoin-core-dev
15:54 -!- ExtraCrispy_ [~ExtraCris@gateway/tor-sasl/extracrispy] has joined #bitcoin-core-dev
15:56 -!- leishman [~leishman@50.237.29.22] has quit [Remote host closed the connection]
15:58 -!- ExtraCrispy [~ExtraCris@gateway/tor-sasl/extracrispy] has quit [Ping timeout: 256 seconds]
16:00 -!- leishman [~leishman@50.237.29.22] has joined #bitcoin-core-dev
16:02 -!- proletesseract [~proletess@103.247.155.68] has joined #bitcoin-core-dev
16:04 -!- laurentmt [~Thunderbi@37.58.58.232] has quit [Quit: laurentmt]
16:04 -!- leishman [~leishman@50.237.29.22] has quit [Remote host closed the connection]
16:06 -!- leishman [~leishman@50.237.29.22] has joined #bitcoin-core-dev
16:07 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-xyennklvoszaqzzy] has joined #bitcoin-core-dev
16:07 < bitcoin-git> [bitcoin] ken2812221 opened pull request #14489: refactor: Drop boost::thread and boost::chrono (master...interruptible-thread) https://github.com/bitcoin/bitcoin/pull/14489
16:07 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-xyennklvoszaqzzy] has left #bitcoin-core-dev []
16:20 -!- unholymachine [~quassel@38.132.115.211] has joined #bitcoin-core-dev
16:20 -!- jarthur [~jarthur@207.114.244.5] has quit []
16:39 -!- qrestlove [~qrestlove@2605:6000:eb4a:ef00:557e:66f:7d13:5f84] has quit [Ping timeout: 252 seconds]
16:43 -!- dongcarl_ [~dongcarl@c-24-5-70-69.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
16:49 -!- qrestlove [~qrestlove@2605:6000:eb4a:ef00:43b:bedc:dcd:92c3] has joined #bitcoin-core-dev
16:50 -!- leishman [~leishman@50.237.29.22] has quit [Remote host closed the connection]
16:59 -!- dongcarl_ [~dongcarl@c-24-5-70-69.hsd1.ca.comcast.net] has quit [Quit: ZNC 1.6.6 - http://znc.in]
17:14 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 245 seconds]
17:16 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
17:17 -!- dongcarl_ [~dongcarl@c-24-5-70-69.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
17:18 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]
17:20 -!- dongcarl_ [~dongcarl@c-24-5-70-69.hsd1.ca.comcast.net] has quit [Client Quit]
17:25 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 250 seconds]
17:31 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Ping timeout: 256 seconds]
17:33 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev
17:36 -!- proletesseract [~proletess@103.247.155.68] has quit [Remote host closed the connection]
17:40 -!- dongcarl_ [~dongcarl@c-24-5-70-69.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
17:49 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]
17:51 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
17:56 -!- proletesseract [~proletess@103.247.155.68] has joined #bitcoin-core-dev
18:00 -!- MrPaz [~MrPaz@84.39.112.87] has joined #bitcoin-core-dev
18:01 -!- dongcarl_ [~dongcarl@c-24-5-70-69.hsd1.ca.comcast.net] has quit [Quit: ZNC 1.6.6 - http://znc.in]
18:05 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev
18:12 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit []
18:13 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
18:13 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
18:17 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 250 seconds]
18:22 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has quit [Quit: drexl]
18:23 -!- str4d [~str4d@169.243.9.51.dyn.plus.net] has quit [Ping timeout: 276 seconds]
18:31 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.]
18:39 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection]
18:40 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev
18:47 -!- dongcarl_ [~dongcarl@c-24-5-70-69.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
18:49 -!- dongcarl_ [~dongcarl@c-24-5-70-69.hsd1.ca.comcast.net] has quit [Client Quit]
19:24 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
19:31 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Quit: Leaving]
19:31 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has quit [Quit: Snoozing.]
19:32 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection]
19:34 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Ping timeout: 256 seconds]
19:35 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev
19:39 -!- bitconner [~conner@136.24.75.121] has quit [Ping timeout: 244 seconds]
19:42 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
19:46 -!- leishman [~leishman@136.24.189.159] has joined #bitcoin-core-dev
19:47 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev
19:50 -!- leishman [~leishman@136.24.189.159] has quit [Ping timeout: 244 seconds]
19:55 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
19:57 < kallewoof> How does bitcoin core track bip9 activation states? I have odd cases where a copied chain state will result in all bip9 soft forks turning up as "failed" rather than "activated". If I disable the timeout, they show up as 'started', but with 'possible: false'.
19:59 -!- bitconner [~conner@c-67-188-149-218.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
20:00 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 256 seconds]
20:01 < sipa> kallewoof: versionbits.cpp
20:02 -!- schnerchi [~schnerchi@p54A0EE14.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
20:02 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 268 seconds]
20:02 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
20:02 < kallewoof> sipa: Yeah, I've been staring at that file for awhile now. Will stare some more.
20:03 < sipa> kallewoof: it should be implementing bip9 exactly
20:04 -!- bitconner [~conner@c-67-188-149-218.hsd1.ca.comcast.net] has quit [Ping timeout: 252 seconds]
20:04 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev
20:05 < kallewoof> Yeah, I think I'm confused over what I'm confused over tbh. Will do some debugging.
20:05 -!- schnerch_ [~schnerchi@p3EE1C5CF.dip0.t-ipconnect.de] has quit [Ping timeout: 272 seconds]
20:07 < achow101> kallewoof: those errors you mention sound like mtp isn't being computed correctly
20:07 < kallewoof> achow101: Huh.. I haven't really touched that part of the code.
20:09 < sipa> but everything should be recomputed at runtime
20:10 < achow101> kallewoof: sipa: is it possible that pruned chainstates cannot compute bip9 status?
20:10 < kallewoof> They only rely on block headers so I think they should be able to
20:11 < sipa> indeed
20:16 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-dfhkjxznthttuffh] has joined #bitcoin-core-dev
20:16 < bitcoin-git> [bitcoin] MeshCollider opened pull request #14491: Allow descriptor imports with importmulti (master...201810_importmulti_desc_2) https://github.com/bitcoin/bitcoin/pull/14491
20:16 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-dfhkjxznthttuffh] has left #bitcoin-core-dev []
20:19 -!- jack [2d4d10f3@gateway/web/freenode/ip.45.77.16.243] has joined #bitcoin-core-dev
20:20 -!- jack [2d4d10f3@gateway/web/freenode/ip.45.77.16.243] has quit [Client Quit]
20:21 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has quit [Quit: Snoozing.]
20:52 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-fggsepctwmhckefi] has joined #bitcoin-core-dev
20:52 < bitcoin-git> [bitcoin] kallewoof opened pull request #14492: autoconf: add 'test' alias for 'tests' to configure (master...ac-test-arg-alias) https://github.com/bitcoin/bitcoin/pull/14492
20:52 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-fggsepctwmhckefi] has left #bitcoin-core-dev []
21:00 -!- schnerch_ [~schnerchi@p54A0E28F.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
21:02 -!- MrPaz [~MrPaz@84.39.112.87] has quit [Ping timeout: 272 seconds]
21:03 -!- schnerchi [~schnerchi@p54A0EE14.dip0.t-ipconnect.de] has quit [Ping timeout: 252 seconds]
21:24 -!- rex4539 [~rex4539@ppp-2-84-165-183.home.otenet.gr] has quit [Quit: rex4539]
21:42 -!- geezas [uid253218@gateway/web/irccloud.com/x-rnertbrwmcdrtiiv] has joined #bitcoin-core-dev
21:55 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-nfoucbonilcwspcu] has joined #bitcoin-core-dev
21:55 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2a2cac787360...9bd3ff430b4e
21:55 < bitcoin-git> bitcoin/master 36323e2 Hennadii Stepanov: Clean systray icon menu for -disablewallet mode...
21:55 < bitcoin-git> bitcoin/master 9bd3ff4 Wladimir J. van der Laan: Merge #14383: qt: Clean system tray icon menu for '-disablewallet' mode...
21:55 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-nfoucbonilcwspcu] has left #bitcoin-core-dev []
21:56 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-yntaojpyuuumjxjw] has joined #bitcoin-core-dev
21:56 < bitcoin-git> [bitcoin] laanwj closed pull request #14383: qt: Clean system tray icon menu for '-disablewallet' mode (master...20181003-disablewallet-systray) https://github.com/bitcoin/bitcoin/pull/14383
21:56 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-yntaojpyuuumjxjw] has left #bitcoin-core-dev []
21:59 -!- bitconner [~conner@c-67-188-149-218.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
22:04 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ojwthgpkdqiwhoet] has joined #bitcoin-core-dev
22:04 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9bd3ff430b4e...2468471e1398
22:04 < bitcoin-git> bitcoin/master 7d173c4 Tim Ruffing: qt: Revert "Force TLS1.0+ for SSL connections"...
22:04 < bitcoin-git> bitcoin/master 2468471 Wladimir J. van der Laan: Merge #14403: qt: Revert "Force TLS1.0+ for SSL connections"...
22:04 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ojwthgpkdqiwhoet] has left #bitcoin-core-dev []
22:04 -!- bitconner [~conner@c-67-188-149-218.hsd1.ca.comcast.net] has quit [Ping timeout: 268 seconds]
22:05 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-qubxglijgqwqdbal] has joined #bitcoin-core-dev
22:05 < bitcoin-git> [bitcoin] laanwj closed pull request #14403: qt: Revert "Force TLS1.0+ for SSL connections" (master...sslv3) https://github.com/bitcoin/bitcoin/pull/14403
22:05 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-qubxglijgqwqdbal] has left #bitcoin-core-dev []
22:10 < hebasto> wumpus: regarding #14370, should I add a modified unit test to the same PR or it should be another PR?
22:10 < gribble> https://github.com/bitcoin/bitcoin/issues/14370 | utils and libraries: Allow values quoting in config files by hebasto · Pull Request #14370 · bitcoin/bitcoin · GitHub
22:13 -!- unholymachine [~quassel@38.132.115.211] has quit [Remote host closed the connection]
22:18 -!- murrayn [~murrayn@S0106f8a097f16608.ok.shawcable.net] has joined #bitcoin-core-dev
22:18 -!- murrayn [~murrayn@S0106f8a097f16608.ok.shawcable.net] has quit [Changing host]
22:18 -!- murrayn [~murrayn@unaffiliated/murrayn] has joined #bitcoin-core-dev
22:27 < meshcollider> wumpus: #14291 is also RTM I think
22:27 < gribble> https://github.com/bitcoin/bitcoin/issues/14291 | wallet: Add ListWalletDir utility function by promag · Pull Request #14291 · bitcoin/bitcoin · GitHub
22:27 < meshcollider> and can we please add #14454 to high priority
22:27 < gribble> https://github.com/bitcoin/bitcoin/issues/14454 | Add SegWit support to importmulti by MeshCollider · Pull Request #14454 · bitcoin/bitcoin · GitHub
22:27 -!- kallewoof [~quassel@240d:1a:759:6000:a7b1:451a:8874:e1ac] has quit [Read error: Connection reset by peer]
22:28 < sipa> meshcollider: that's growing into a painful amount of code :)
22:28 < wumpus> meshcollider: thanks, will have a look
22:28 < sipa> will review in detail soon
22:28 -!- kallewoof [~quassel@240d:1a:759:6000:a7b1:451a:8874:e1ac] has joined #bitcoin-core-dev
22:29 < meshcollider> sipa: the segwit one?
22:29 < sipa> and thanks for quickly addressing my comments so far
22:29 < meshcollider> sipa: it still removes more than it adds ;)
22:29 < meshcollider> thanks for giving comments so quickly
22:31 < meshcollider> and 14303 removes all the duplicated pwallet->MarkDirty() calls which will tidy it up a bit more too
22:33 < wumpus> habasto: would rather close 14370, don't think it is a necessary change
22:34 < hebasto> wumpus: thanks for your quick review; I'll think about it.
22:35 < wumpus> if something can be solved by better documentation, please work on documentation!
22:35 < wumpus> don't change the code instead
22:36 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-daenkdefofkbrtwu] has joined #bitcoin-core-dev
22:36 < bitcoin-git> [bitcoin] MeshCollider opened pull request #14494: Error if # is used in rpcpassword in conf (master...201810_hash_in_rpcpassword_error) https://github.com/bitcoin/bitcoin/pull/14494
22:36 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-daenkdefofkbrtwu] has left #bitcoin-core-dev []
22:39 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection]
22:41 < wumpus> habasto: huh so does #13143 provide an actual use-case for quoting functionality?
22:41 < gribble> https://github.com/bitcoin/bitcoin/issues/13143 | `#` cannot be used rpcpassword (or bitcoin.conf in general) · Issue #13143 · bitcoin/bitcoin · GitHub
22:42 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev
22:42 < meshcollider> wumpus: I would say it makes it even more confusing lol
22:43 < wumpus> hehe
22:43 < wumpus> well I remember because windows .ini format has no way to insert #'s, that's also why I know they have no quoting...
22:44 < wumpus> all this is kind of terrible edge-case stuff
22:45 < meshcollider> I agree
22:46 < meshcollider> we should just disallow same-line comments and only exclude lines from the conf if they *start* with a #
22:47 < wumpus> yes, I think that's a fair option, I remember seeing that in other software (but don't remember which one, right now); though,also a breaking change
22:47 < wumpus> people might already be using # to comment their .ini files lines... so would create the *opposite* issue :(
22:48 < meshcollider> yeah I think its too hard to change now
22:48 < wumpus> anyhow I think 14494 is good, just don't have "illegal hash character" in the error message that's terrible :-)
22:48 < meshcollider> haha ok what should I change it to
22:49 < wumpus> well what I said in the PR, it's at most ambigious, it's rejected because it's probably a mistake
22:49 < meshcollider> " do not use hash characters in rpcpassword" ?
22:50 < wumpus> if it's an actual comment it is actually okay, in principle
22:50 < wumpus> well a friendlier message, not something about 'do not use' but just explain to the user why this is a problem
22:50 < meshcollider> ok
22:50 < wumpus> illegal hash characer sounds like the cops will show up any time :)
22:51 < kallewoof> wumpus: I think iptables will happily try to parse # chars unless they are the first on the line
22:51 -!- proletesseract [~proletess@103.247.155.68] has quit [Remote host closed the connection]
22:51 < meshcollider> "using hash in rpcpassword can be ambiguous and should be avoided"
22:52 < wumpus> yes, that would be better
22:52 < wumpus> or maybe don't call it hash but simply mention '#'
22:53 < wumpus> that's more direct for non-english speaking people
22:53 -!- proletesseract [~proletess@103.247.155.68] has joined #bitcoin-core-dev
22:54 < hebasto> ^
22:54 < meshcollider> true, and even english speakers sometimes call it pound or octothorpe 
22:54 -!- proletesseract [~proletess@103.247.155.68] has quit [Read error: Connection reset by peer]
22:58 < sipa> meshcollider: probably only antipodians
22:59 < meshcollider> sipa: lol
22:59 < meshcollider> sipa: achow used "pound", so it must be you all who are upside down
23:01 -!- proletesseract [~proletess@219.88.232.29] has joined #bitcoin-core-dev
23:06 -!- proletesseract [~proletess@219.88.232.29] has quit [Ping timeout: 268 seconds]
23:18 < luke-jr> meshcollider: but if we can't hash over RPC, how will people mine? /s
23:19 < sipa> clearly we need to rename it 'pounders'
23:21 < luke-jr> sipa: also, what are these 'podes' that people are protesting? :p
23:29 < karelb> I am trying to run my fork of bitcoind on travis.... and travis stops with this
23:29 < karelb> src/threadinterrupt.cpp:25: mut  ==> must, mutt, moot
23:29 < karelb> Warning: codespell identified likely spelling errors
23:29 < karelb> failure generated from test/lint/lint-spelling.sh
23:29 -!- ExtraCrispy_ [~ExtraCris@gateway/tor-sasl/extracrispy] has quit [Ping timeout: 256 seconds]
23:29 < karelb> .....ummmmm, ok?
23:30 < karelb> I did no change in threadinterrupt, and that "mut" is just some mutex
23:32 -!- ExtraCrispy_ [~ExtraCris@gateway/tor-sasl/extracrispy] has joined #bitcoin-core-dev
23:39 < karelb> well whatever, one commit that renamed "mut" to "mutex" fixed that, I just wonder why I needed to do that...
23:40 < gwillen> karelb: your travis instance is stupid
23:40 < gwillen> if you make it less stupid you will have fewer problems
23:40 < gwillen> it is trying to spell-correct your code, and doing it moronically
23:40 < karelb> :D
23:40 < gwillen> and seems to be set to warnings-as-errors.
23:40 < karelb> I use travis-ci.org
23:41 < gwillen> well, apparently they are stupid
23:41 < gwillen> but I imagine there is an option not to make codespell warnings errors
23:41 < karelb> the same config as bitcoin core
23:41 < gwillen> which they absolutely should not be
23:41 < gwillen> oh, hm
23:41 < gwillen> I mean, seemingly not
23:42 < karelb> well let's see what happens when I make a PR, if that `mut` stuff is still there
23:52 -!- geezas [uid253218@gateway/web/irccloud.com/x-rnertbrwmcdrtiiv] has quit [Quit: Connection closed for inactivity]
23:54 -!- proletesseract [~proletess@219.88.232.29] has joined #bitcoin-core-dev
--- Log closed Tue Oct 16 00:00:38 2018