--- Log opened Fri Oct 19 00:00:41 2018 00:02 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 00:06 -!- jungly [~quassel@host97-200-static.8-79-b.business.telecomitalia.it] has joined #bitcoin-core-dev 00:19 < jonasschnelli> sipa, gmaxwell: ping for final review #14046 (to close/finailize your earlier review) 00:19 < gribble> https://github.com/bitcoin/bitcoin/issues/14046 | net: Refactor message parsing (CNetMessage), adds flexibility by jonasschnelli · Pull Request #14046 · bitcoin/bitcoin · GitHub 00:24 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Ping timeout: 256 seconds] 00:26 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 00:53 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-jksyhstpjjmlzhgg] has joined #bitcoin-core-dev 00:53 < bitcoin-git> [bitcoin] hebasto opened pull request #14517: qt: Fix start with the `-min` option (master...20181019-start-minimized-to-tray) https://github.com/bitcoin/bitcoin/pull/14517 00:53 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-jksyhstpjjmlzhgg] has left #bitcoin-core-dev [] 01:07 -!- lnostdal_ [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev 01:07 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Quit: https://www.Quanto.ga/] 01:12 -!- lnostdal_ [~lnostdal@77.70.119.51] has quit [Read error: Connection reset by peer] 01:12 -!- lnostdal_ [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev 01:17 < hebasto> meshcollider: gmaxwell: wumpus: MarcoFalke: ryanofsky: #14514 is it worth? 01:17 < gribble> https://github.com/bitcoin/bitcoin/issues/14514 | Version number for `bitcoin.conf` · Issue #14514 · bitcoin/bitcoin · GitHub 01:20 -!- lnostdal_ [~lnostdal@77.70.119.51] has quit [Ping timeout: 252 seconds] 01:29 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 01:29 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 01:29 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 01:36 -!- harrymm [~harrymm@mx-ll-223.204.113-194.dynamic.3bb.co.th] has quit [Ping timeout: 250 seconds] 01:47 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:47 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev 01:49 -!- harrymm [~harrymm@69.161.195.103] has joined #bitcoin-core-dev 01:51 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds] 02:01 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has joined #bitcoin-core-dev 02:38 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 02:39 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 02:40 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 02:41 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 02:42 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 02:43 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 02:46 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 02:51 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 268 seconds] 03:08 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:25 < meshcollider> hebasto: in my opinion not really :) 03:26 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has joined #bitcoin-core-dev 03:27 -!- schmidty is now known as Guest20006 03:38 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 03:38 -!- grubles [~grubles@unaffiliated/grubles] has quit [Ping timeout: 246 seconds] 03:39 -!- grubles [~grubles@unaffiliated/grubles] has joined #bitcoin-core-dev 03:40 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 03:44 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Remote host closed the connection] 03:44 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev 03:54 < wumpus> ooh time to upgrade OpenBSD 04:06 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 04:07 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 244 seconds] 04:15 -!- infernix [nix@unaffiliated/infernix] has quit [Ping timeout: 272 seconds] 04:20 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 04:27 -!- infernix [nix@unaffiliated/infernix] has joined #bitcoin-core-dev 04:46 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 04:49 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 04:51 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 252 seconds] 04:52 -!- Cheeseo [Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has joined #bitcoin-core-dev 05:14 < meshcollider> sipa: still trying to figure out why the P2WSH address is not IsMine, I've confirmed both private keys and the witness script were imported into the wallet successfully, and it works for P2SH-P2WSH, so I'm very confused 05:15 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 05:16 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 05:17 < meshcollider> Its solvable, and both private keys are there, so what more does it need :( 05:17 < meshcollider> I'm either missing something really dumb, or there's a bug in the IsMine logic 05:21 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has joined #bitcoin-core-dev 05:22 < meshcollider> actually I think I know the issue, let me test something 05:24 -!- RoyceX [~Cheeseo@unaffiliated/cheeseo] has joined #bitcoin-core-dev 05:27 -!- Cheeseo [Cheeseo@gateway/vpn/privateinternetaccess/cheeseo] has quit [Ping timeout: 276 seconds] 05:34 < meshcollider> sipa: yes, the scriptPubKey also needs to be added to the wallet scripts as well for it to be IsMine, not just the witnessScript so it works now 05:39 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 05:40 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 05:42 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 260 seconds] 05:51 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Remote host closed the connection] 06:06 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Remote host closed the connection] 06:08 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 06:08 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 06:13 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 252 seconds] 06:17 -!- RoyceX [~Cheeseo@unaffiliated/cheeseo] has quit [Read error: Connection reset by peer] 06:24 < harding> Re: possibly removing the GUI addressbook, I just wanted to note that I use that with my cold wallet setup so that I can import a handful of watch-only pubkeys at a time using the RPC (labeling them as, e.g., "cold-2019-10-19") and then use the GUI addressbook to hand them out as necessary over the next few weeks (relabeling them as I use them to both track payments and prevent address reuse). I could probably do the same thing 06:24 < harding> just as easily using a text file, so I wouldn't mourn the loss of the addressbook, but it is something that's currently a part of what I think is a reasonable workflow. The Receive tab doesn't currently show imported stuff until you receive payment to it. 06:25 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 06:25 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 06:27 < wumpus> harding: I think that's a reasonable workflow, too 06:29 < wumpus> gah openbsd 6.4 upgrade failed here, some error at startup of the kernel, might have to do with the specific qemu config 06:35 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 06:40 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 07:02 -!- SigmaOC [~Sigma@host86-185-147-252.range86-185.btcentralplus.com] has joined #bitcoin-core-dev 07:02 < SigmaOC> REPLY isn't just a zsh thing. Works in any shell; it's just the convention (dunno where it started). 07:02 < SigmaOC> PuppyNews_, I'm afraid no one from wikipedia can hear you right now, this channel is moderated (+m) 07:02 < SigmaOC> unyu: what are dynamicsl systems? 07:02 < SigmaOC> better ask ur question. 07:06 -!- SigmaOC [~Sigma@host86-185-147-252.range86-185.btcentralplus.com] has quit [Remote host closed the connection] 07:06 -!- soahccc [~soahccc@157-131-72-17.fiber.dynamic.sonic.net] has joined #bitcoin-core-dev 07:06 < soahccc> actually lets call it a_i 07:06 < soahccc> han-solo: etc... ( http://ix.io/1mtz ) 07:06 < soahccc> malloc/realloc/free is just a mistake while dealing with C++ code 07:09 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 07:12 -!- soahccc [~soahccc@157-131-72-17.fiber.dynamic.sonic.net] has quit [Remote host closed the connection] 07:15 -!- kexkey [~kexkey@192.230.35.138] has joined #bitcoin-core-dev 07:21 -!- madeng [b6e8bbaf@gateway/web/freenode/ip.182.232.187.175] has joined #bitcoin-core-dev 07:24 -!- madeng [b6e8bbaf@gateway/web/freenode/ip.182.232.187.175] has quit [Client Quit] 07:27 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 07:28 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 07:30 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 07:31 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-tytmlrqwpiaoivkv] has joined #bitcoin-core-dev 07:31 < bitcoin-git> [bitcoin] promag opened pull request #14518: rpc: Always throw in getblockstats if -txindex is required (master...2018-10-getblockstats) https://github.com/bitcoin/bitcoin/pull/14518 07:31 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-tytmlrqwpiaoivkv] has left #bitcoin-core-dev [] 07:32 < promag> gmaxwell: ^ 07:34 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-qfogqgengozxoexq] has joined #bitcoin-core-dev 07:34 < bitcoin-git> [bitcoin] practicalswift closed pull request #14254: build: Add address sanitizer (ASan) Travis job (master...asan) https://github.com/bitcoin/bitcoin/pull/14254 07:34 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-qfogqgengozxoexq] has left #bitcoin-core-dev [] 07:35 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-mrlytbuuqgfzbqjw] has joined #bitcoin-core-dev 07:35 < bitcoin-git> [bitcoin] practicalswift closed pull request #14010: tests: Setup chain parameters (globalChainParams) when performing fuzzing initialization (master...SelectParams-when-fuzzing) https://github.com/bitcoin/bitcoin/pull/14010 07:35 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-mrlytbuuqgfzbqjw] has left #bitcoin-core-dev [] 07:35 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-fhwylqvbwabyskwf] has joined #bitcoin-core-dev 07:35 < bitcoin-git> [bitcoin] practicalswift closed pull request #13971: Add tests and error handling to DecodeExtPubKey/DecodeExtKey. Add [[nodiscard]]. (master...DecodeExtKey) https://github.com/bitcoin/bitcoin/pull/13971 07:35 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-fhwylqvbwabyskwf] has left #bitcoin-core-dev [] 07:36 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-xywwqwnpxjdhzadg] has joined #bitcoin-core-dev 07:36 < bitcoin-git> [bitcoin] practicalswift closed pull request #13969: Make sure all callers of LookupBlockIndex(...) check for nullptr before dereferencing (CBlockIndex*) (master...LookupBlockIndex) https://github.com/bitcoin/bitcoin/pull/13969 07:36 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-xywwqwnpxjdhzadg] has left #bitcoin-core-dev [] 07:37 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-rodzushihyruhggu] has joined #bitcoin-core-dev 07:37 < bitcoin-git> [bitcoin] practicalswift closed pull request #13909: validation: Pass chainparams in AcceptToMemoryPoolWorker(...) (master...remove-chainparams-argument-to-AcceptToMemoryPoolWorker) https://github.com/bitcoin/bitcoin/pull/13909 07:37 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-rodzushihyruhggu] has left #bitcoin-core-dev [] 07:38 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [] 07:39 -!- queip [~queip@unaffiliated/rezurus] has quit [Quit: bye, freenode] 07:45 -!- michaelsdunn1 [~michaelsd@208.59.170.5] has joined #bitcoin-core-dev 07:45 -!- michaelsdunn1 [~michaelsd@208.59.170.5] has quit [Changing host] 07:45 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev 07:52 -!- copumpkin [~copumpkin@haskell/developer/copumpkin] has joined #bitcoin-core-dev 07:53 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-gqqimptcwscyetaq] has joined #bitcoin-core-dev 07:53 < bitcoin-git> [bitcoin] practicalswift closed pull request #14475: serialize: Document integer width assumptions we are making when calculating compact sizes (master...integer-width-assumptions) https://github.com/bitcoin/bitcoin/pull/14475 07:53 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-gqqimptcwscyetaq] has left #bitcoin-core-dev [] 07:57 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Quit: Leaving] 08:17 -!- ExtraCrispy [~ExtraCris@gateway/tor-sasl/extracrispy] has joined #bitcoin-core-dev 08:36 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 08:39 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 245 seconds] 08:41 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 252 seconds] 08:48 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev 09:01 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 09:01 < promag> imo is ready to merge #14453 09:01 < gribble> https://github.com/bitcoin/bitcoin/issues/14453 | rpc: Fix wallet unload during walletpassphrase timeout by promag · Pull Request #14453 · bitcoin/bitcoin · GitHub 09:03 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 09:08 < jonasschnelli> promag: is it possible to add a test for 14453? 09:45 -!- cryptocat is now known as bitbee 09:49 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-yjrityflnnrciqcl] has joined #bitcoin-core-dev 09:49 < bitcoin-git> [bitcoin] jamesob opened pull request #14519: test: add utility to easily profile node performance with perf (master...2018-10-func-test-profiling) https://github.com/bitcoin/bitcoin/pull/14519 09:49 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-yjrityflnnrciqcl] has left #bitcoin-core-dev [] 09:52 -!- jungly [~quassel@host97-200-static.8-79-b.business.telecomitalia.it] has quit [Remote host closed the connection] 10:07 < midnightmagic> wumpus: I didn't know you were into OpenBSD. Bitcoin builds work okay on it still? There was a guy who was persistently building on OpenBSD for quite some time. 10:09 -!- kexkey [~kexkey@192.230.35.138] has quit [Ping timeout: 252 seconds] 10:13 -!- jarthur [~jarthur@2605:6000:1019:41ab:90d0:e43d:1bd3:b93e] has joined #bitcoin-core-dev 10:22 < sipa> meshcollider: argh, indeed, i should have known 10:23 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev 10:24 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-tgdjabkhtjffzquu] has joined #bitcoin-core-dev 10:24 < bitcoin-git> [bitcoin] hebasto opened pull request #14521: qt, docs: Fix `bitcoin-qt -version` output formatting (master...20181019-qt-cli-license) https://github.com/bitcoin/bitcoin/pull/14521 10:24 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-tgdjabkhtjffzquu] has left #bitcoin-core-dev [] 10:27 -!- jarthur [~jarthur@2605:6000:1019:41ab:90d0:e43d:1bd3:b93e] has quit [Remote host closed the connection] 10:28 -!- jarthur [~jarthur@2605:6000:1019:41ab:90d0:e43d:1bd3:b93e] has joined #bitcoin-core-dev 10:31 -!- bralyclow2 [~bralyclow@195.242.213.121] has joined #bitcoin-core-dev 10:33 -!- bralyclow2 [~bralyclow@195.242.213.121] has quit [Client Quit] 10:39 -!- jarthur [~jarthur@2605:6000:1019:41ab:90d0:e43d:1bd3:b93e] has quit [Remote host closed the connection] 10:41 -!- jarthur [~jarthur@cpe-66-68-134-212.austin.res.rr.com] has joined #bitcoin-core-dev 10:46 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-amodgpxdafzvifma] has joined #bitcoin-core-dev 10:46 < bitcoin-git> [bitcoin] jamesob opened pull request #14522: tests: add invalid P2P message tests (master...2018-10-invalid-msgs-test) https://github.com/bitcoin/bitcoin/pull/14522 10:46 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-amodgpxdafzvifma] has left #bitcoin-core-dev [] 10:49 -!- jarthur [~jarthur@cpe-66-68-134-212.austin.res.rr.com] has quit [Remote host closed the connection] 10:52 -!- jarthur [~jarthur@cpe-66-68-134-212.austin.res.rr.com] has joined #bitcoin-core-dev 11:04 -!- jarthur [~jarthur@cpe-66-68-134-212.austin.res.rr.com] has quit [Remote host closed the connection] 11:14 -!- dqx_ [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev 11:18 -!- jarthur [~jarthur@2605:6000:1019:41ab:90d0:e43d:1bd3:b93e] has joined #bitcoin-core-dev 11:29 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 11:30 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 11:34 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev 11:48 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Read error: Connection reset by peer] 11:48 -!- satwo [~textual@2601:483:4e00:26ce:1de8:752a:fbc:daac] has joined #bitcoin-core-dev 11:48 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev 11:50 -!- bralyclow [~bralyclow@76-202-84-204.lightspeed.tukrga.sbcglobal.net] has joined #bitcoin-core-dev 11:51 -!- bralyclo_ [~bralyclow@64.120.52.211] has joined #bitcoin-core-dev 11:53 -!- bralyc___ [~bralyclow@76-202-84-204.lightspeed.tukrga.sbcglobal.net] has joined #bitcoin-core-dev 11:53 -!- bralycl__ [~bralyclow@195.242.213.119] has quit [Ping timeout: 252 seconds] 11:54 -!- bralycl__ [~bralyclow@195.242.213.119] has joined #bitcoin-core-dev 11:55 -!- bralyclow [~bralyclow@76-202-84-204.lightspeed.tukrga.sbcglobal.net] has quit [Ping timeout: 272 seconds] 11:56 -!- bralyclo_ [~bralyclow@64.120.52.211] has quit [Ping timeout: 252 seconds] 11:57 -!- bralyc___ [~bralyclow@76-202-84-204.lightspeed.tukrga.sbcglobal.net] has quit [Ping timeout: 252 seconds] 12:00 -!- jarthur [~jarthur@2605:6000:1019:41ab:90d0:e43d:1bd3:b93e] has quit [Remote host closed the connection] 12:01 < meshcollider> Wallet meeting? 12:02 < sipa> oops, indeed! 12:03 < gmaxwell> Hi. 12:04 < gmaxwell> sipa: start meeting? 12:04 -!- cold_wallet [~cold_wall@193.25.1.157] has joined #bitcoin-core-dev 12:04 < sipa> #startmeeting 12:04 < lightningbot> Meeting started Fri Oct 19 19:04:56 2018 UTC. The chair is sipa. Information about MeetBot at http://wiki.debian.org/MeetBot. 12:04 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic. 12:05 -!- paper_wallet [~paper_wal@193.25.1.157] has joined #bitcoin-core-dev 12:05 < sipa> welcome to the first bitcoin core wallet meeting! 12:05 < meshcollider> \o/ 12:05 -!- nestorOfWallets [~nestor_of@193.25.1.157] has joined #bitcoin-core-dev 12:05 < sipa> i think it would be good to start with listing what people are working on 12:06 -!- hardware_wallet [~hardware_@193.25.1.157] has joined #bitcoin-core-dev 12:07 < gmaxwell> I am working on nothing wallet related. (there, now everyone doesn't have to worry, since you can't be doing worse than nothing) 12:08 < meshcollider> I've been working on getting importmulti working with all the segwit address types and everything recently, and trying to get through most of sipa's descriptor PRs for review :) 12:08 < gwillen> oh hm, I am glad I happened to see this but I am interested in how one finds out about these meetings and their topics :-) 12:08 < sipa> gwillen: discussed yesterday in the bitcoin core meeting :) 12:08 < sipa> i'm working on a number of smaller descriptor related improvements, before digging into fully importing descriptors into the wallet 12:09 < meshcollider> Should we ping the list of Devs from the main meeting in case anyone who wanted to be here forgot 12:09 -!- wallet_dat [~wallet_da@193.25.1.157] has joined #bitcoin-core-dev 12:10 < sipa> meshcollider: sgtm 12:11 < meshcollider> #bitcoin-core-dev Wallet meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator 12:11 < jonasschnelli> hi 12:12 < kanzure> hi. 12:12 < gwillen> Wallet-wise: I am still working on the offline signing usecase, modeled after the flow armory uses with gui interfaces for create-sign-broadcast. 12:12 < kanzure> gwillen: also it was discussed in tokyo. you were there. 12:13 < gwillen> kanzure: like I remember things people say. 12:13 < luke-jr> lol 12:13 < jamesob> anyone know of an easy way to clear the sig/script caches of a running bitcoind process? 12:13 < achow101> hi 12:13 < sipa> jamesob: i'm not sure it's possible 12:13 < jamesob> oops! sorry to interrupt the meeting :) 12:13 < sipa> jamesob: but meeting now :) 12:13 < luke-jr> btw, not wallet related, but: my node stats are b0rked for a bit :x 12:13 < sipa> yay, we have some people 12:13 -!- copumpkin [~copumpkin@haskell/developer/copumpkin] has quit [Quit: My MacBook Pro has gone to sleep. ZZZzzz…] 12:14 < kanzure> are descriptors going to be renamed (or descript?) 12:14 < luke-jr> sorry, gtg 12:14 < meshcollider> kanzure: why would they be renamed? 12:14 < sipa> kanzure: we've sort of settled on the name miniscript instead of descript; descriptors are descriptors :) 12:15 < achow101> meshcollider: because it's confusing 12:15 < sipa> (they're much less related to eachother than the name seemed to imply anyway) 12:15 < kanzure> miniscript because it's yer subset of script. alright. 12:15 -!- reallll [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 12:15 < kanzure> i would have also accepted sipascript 12:15 < meshcollider> achow101: descriptors is a good name? Only "descript" might have been a little ;) 12:16 < kanzure> http://diyhpl.us/wiki/transcripts/bitcoin-core-dev-tech/2018-10-08-script-descriptors/ 12:16 < sipa> so i think my most important blocker is #14150 12:16 < gribble> https://github.com/bitcoin/bitcoin/issues/14150 | Add key origin support to descriptors by sipa · Pull Request #14150 · bitcoin/bitcoin · GitHub 12:16 < achow101> so what steps do we need to do to get the wallet to be descriptor based? 12:17 < gwillen> kanzure: I have also been pushing for "output descriptors" rather than "script descriptors" given the choice of both, the latter being a bit of a tongue twister :-) 12:17 < sipa> after that a number of things become possible, including #14477, the ability to add origin info to scantxoutset (which would solve #14503), and it would also allow writing a descriptor/utxoset based PSBT updater 12:17 < gribble> https://github.com/bitcoin/bitcoin/issues/14477 | Add ability to convert solvability info to descriptor by sipa · Pull Request #14477 · bitcoin/bitcoin · GitHub 12:17 < gribble> https://github.com/bitcoin/bitcoin/issues/14503 | scantxoutset does not identify UTXO origins · Issue #14503 · bitcoin/bitcoin · GitHub 12:17 < achow101> gwillen: output script descriptors ;p 12:17 < sipa> achow101: yeah, that's the big question :) 12:18 < sipa> i think the first step is abstracting out IsMine 12:18 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Ping timeout: 272 seconds] 12:18 < gmaxwell> scanutxoset based psbt updater would be a major win. 12:18 < kanzure> need to keep old ismine things? 12:19 < sipa> kanzure: i would prefer that, and i also don't think it's that much extra work 12:19 < sipa> IsMine is really simple to add things too - just OR the result 12:19 < meshcollider> Long term, is making the wallet descriptor-based enough to solve all the existing concerns with same keys being used for different address types and which keys we treat as IsMine, etc? 12:19 < sipa> meshcollider: yup 12:21 < achow101> sipa: isn't IsMine already separated from the wallet? 12:21 < sipa> so one way of seeing it i think is that a wallet will consist of a number of records, each of which has one descriptor plus some metadata (birthdate, change or not, explored how far, gap limit, ...), and one record is designated "here is where you draw payment addresses from" and "here is where you draw change from" 12:22 < sipa> and then there can be - for now - a 'legacy' record that corresponds to the behaviour of the existing keypool/mapkeys/mapwatchonly/mapscripts 12:23 < sipa> achow101: so the goal would be that there can be multiple implementations of the ismine logic, and one (the legacy one) needs to encapsulate the keypool logic... which is a nontrivial change 12:23 < sipa> right now IsMine is just something that operates based on a KeyStore, and that's not enough 12:23 < meshcollider> For the payment and change addresses sources, they would just be ranged descriptors too right? 12:24 < sipa> yup 12:24 < sipa> another missing piece is an "evaluation cache" for descriptors, which would e.g. store pubkeys for hd keys which have hardened steps in them 12:25 < meshcollider> Store pubkeys for solvabilty while the wallet is locked, or? 12:25 < sipa> meshcollider: well, and to compute the scriptPubKeys to watch for 12:26 -!- WalletIncmpatBdb [~wallet_in@193.25.1.157] has joined #bitcoin-core-dev 12:26 < sipa> for efficiency maybe it shoud store all pubkeys involved in descriptors, even the ones from unhardened paths 12:26 < sipa> or we'd need to rederive them at startup 12:27 < sipa> probably the first step is creating an interface for IsMine; just like SigningProvider is an interface for solving/signing 12:28 < sipa> initially the wallet itself can implement that, by calling the old IsMine code, but that code can then be moved into one instance of that logic 12:28 < sipa> after that, it should be easy to create another descriptor based implementation 12:29 < sipa> 12:29 < sipa> other topics? 12:31 < meshcollider> Upgrade wise, descriptor based wallets aren't backwards compatible with old versions, or we are going to allow some more magic not-touching-the-wallet derivation of descriptors at startup every time? 12:31 -!- bitconner [~conner@136.24.75.121] has joined #bitcoin-core-dev 12:31 < sipa> yeah, that's a different question; i think there are a number of ways 12:31 < sipa> one is to keep them completely separate, and old wallet remains compatible with old versions as long as you don't import anything descriptor based 12:32 < sipa> another is to convert the existing stuff to descriptors at startup every time - which would allow removing the existing IsMine logic from the runtime, but not gain us much otherwise (and the conversion is pretty complicated) 12:33 < achow101> it also wouldn't work for encrypted wallets 12:33 < sipa> and i guess another is to just have 2 types of wallets, and you need an explicit conversion between them 12:33 < sipa> achow101: i think it would 12:33 < sipa> we know the xpub we derived keys from, no? 12:33 < achow101> no 12:34 < achow101> xpub and xprv are derived from the seed on the for whenever they are needed 12:34 < sipa> no? 12:34 < sipa> ah 12:34 < achow101> alao hardened derivation, so no xpub 12:35 < sipa> that's ok 12:35 < sipa> but yeah 12:35 < sipa> i think it's actually best to at least initially have the two live side by side 12:36 < meshcollider> Can we deprecate the old version and in a future release only accept wallets if they've been upgraded? 12:36 -!- adiabat [~adiabat@63.209.32.102] has quit [Remote host closed the connection] 12:36 < sipa> perhaps 12:37 < achow101> I'm afraid that if we have to keep the old one around that it will never go away because people don't upgrade 12:37 < meshcollider> That's what I mean 12:37 < sipa> i think a bigger question is what to do with things like addmultisigaddress etc 12:38 < achow101> can't it construct a descriptor based on what was given? 12:38 < meshcollider> Isn't that ok to just make a new multisig descriptor record with the public keys of whatever was specified? 12:38 < gmaxwell> that was my thought 12:39 < sipa> achow101: yeah, with slightly different (but far more reasonable, actuallly) semantics 12:39 -!- adiabat [~adiabat@63.209.32.102] has joined #bitcoin-core-dev 12:39 < sipa> meshcollider: same with importmulti, actually 12:39 < sipa> anything specified there can be converted to a descriptor 12:40 < andytoshi> meshcollider: people today show up with 2012 wallets on #bitcoin, and it's a pretty impressive show of backward-compatibility that i can always say "just import it into the latest core" 12:40 < andytoshi> even if it's got e.g. p2pk outputs 12:40 -!- jarthur [~jarthur@2605:6000:1019:41ab:90d0:e43d:1bd3:b93e] has joined #bitcoin-core-dev 12:41 < booyah> andytoshi: yeap, I think it's safe to assume people will expect that basically forever. Wallets in some deep storate boxes, inherited, burried in backyard 12:41 < meshcollider> andytoshi: you could still import it, but it would upgrade it for you I think 12:42 < meshcollider> So you just can't import it and then go back and use it on the 2012 software 12:43 < sipa> i think that the burden of maintaining compatibility with the old wallet format actually won't be too hard, as due to the necessary refactoring for descriptors in the first place, it will become pretty standalone and not entangled with everything else 12:43 < sipa> and i shouldn't say "old format", it's just adding some new fields 12:44 < jonasschnelli> I still sometimes have the feeling we should clone the wallet code (make it run with the existing wallet code) and remove everything that is legacy,.. don't promise backward comp. for 1-2 yrs. 12:44 < jonasschnelli> All the fancy stuff could go there... 12:44 < jonasschnelli> API can break during that 1-2yr period 12:45 < sipa> jonasschnelli: maybe, but i think that's not the right granularity 12:45 < sipa> you'd be duplicating a lot of things that are perfectly compatible 12:45 < sipa> like coin selection 12:45 < jonasschnelli> We still can "backport" to the stable wallet 12:45 < jonasschnelli> You can factor out the coin selection 12:45 < sipa> exactly. 12:45 < jonasschnelli> But I agree, some parts would. be duplicated 12:45 < sipa> just like you can factor out the ismine logic. 12:45 < sipa> :) 12:45 < gmaxwell> I don't think we get enough testing/review for one wallet, having two doesn't sound better. :) if it were narrowed down to a pretty small thing, then sure. 12:46 < gmaxwell> Being able to _import_ old wallets should always be relatively straight forward though, so it may make sense to not support old wallets except being able to import them at some point. 12:46 < sipa> yeah, agree 12:46 < jonasschnelli> I think we test less if we go with the two-wallets approach since backward compatibility and the edge-cases that come up with it consumes a major part of the review and fix time 12:47 < sipa> i feel that "meh just create a new wallet" is a knee jerk response when facing the complexity of the existing system 12:47 < jonasschnelli> At some point in time, you have to abandon old wallets (maybe thats not within the next 10 yrs) 12:47 < sipa> it's always appealing to rewrite things you don't understand 12:47 < sipa> but that doesn't make it the right choice 12:48 < jonasschnelli> Yes. Maybe. 12:48 < gmaxwell> And usually a bad idea, since the complexity was almost always there for a reason. :) 12:48 < sipa> it is certainly true that _some_ of the complexity can be dropped if we don't need backward compatibility 12:48 < sipa> but identifying that is perhaps less work than making a new implementation actually production ready 12:48 < jonasschnelli> I don't think its about complexity... more about progress we can't make otherwise. And dragging around legacy stuff like the account system. 12:49 < sipa> i think we can make progress fine 12:49 < jonasschnelli> Yes. That indeed true. 12:50 < sipa> especially with a number of people pulling in the same direction - which is something that hopefully these meetings contribute to 12:50 < jonasschnelli> As said, somethimes I think it would be worth do the 2nd wallet... but you guys always convince me the single-wallet approach is more future proof 12:50 < meshcollider> Is #8369 in any way helpful to this discussion 12:50 < gribble> https://github.com/bitcoin/bitcoin/issues/8369 | [FOR LATER USE][WIP][Wallet] add support for a flexible "set of features" by jonasschnelli · Pull Request #8369 · bitcoin/bitcoin · GitHub 12:51 < jonasschnelli> meshcollider: oh. I think we implemented that in a way,.. not? 12:51 < jonasschnelli> With the disableprivatekey function 12:51 < jonasschnelli> The disableprivatekey function introduced a 64bit bitmap 12:52 < sipa> jonasschnelli: very old but relevant blog post: https://www.joelonsoftware.com/2000/04/06/things-you-should-never-do-part-i/ 12:52 < jonasschnelli> Oh. I smell that this is a good read. Thanks sipa 12:53 < jonasschnelli> meshcollider: with that 64bit features flag bitmap, the upper 32 are mandatory (wallet needs those features) where the lower32 bits are optional. 12:53 -!- MtgoxColdWallet [~mtgoxcold@193.25.1.157] has joined #bitcoin-core-dev 12:54 < sipa> jonasschnelli: i'm in favor of something like that, though we shouldn't overuse it as it may lead to an explosion of combinations to test 12:54 < jonasschnelli> https://github.com/bitcoin/bitcoin/pull/9662/commits/9995a602a639b64a749545b7c3bafbf67f97324f 12:54 < sipa> (which is less of a concern when when the features don't interact, and another argument for abstracting out things, so that it becomes clear they can't interact) 12:56 < sipa> oh, i didn't realize the disableprivatekey introduced that already 12:56 < meshcollider> A descriptor wallet could just be a mandatory flag then right 12:56 < jonasschnelli> Yes. I smuggled it in 12:56 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection] 12:57 < sipa> meshcollider: right 12:57 < jonasschnelli> Things like disableprivatekeys is optional and needs a such facility 12:57 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 12:59 < sipa> i guess that's it? 12:59 < meshcollider> Alright this has been a good meeting IMO, last couple minutes anything else? 12:59 < meshcollider> Maybe it's just been good because I've been asking lots of questions lol 12:59 < jonasschnelli> We should use the meetingbot I guess? 12:59 < jonasschnelli> (next time) 12:59 -!- satwo [~textual@2601:483:4e00:26ce:1de8:752a:fbc:daac] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 12:59 < meshcollider> Well, it's running 12:59 < jonasschnelli> Oh. We did. 12:59 < meshcollider> Just no explicit actions or topics 12:59 < jonasschnelli> I see. Sure. 13:00 < sipa> #endmeeting 13:00 < lightningbot> Meeting ended Fri Oct 19 20:00:03 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) 13:00 < lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-10-19-19.04.html 13:00 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-10-19-19.04.txt 13:00 < lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-10-19-19.04.log.html 13:00 < nestorOfWallets> thanks o/ 13:00 < sipa> thanks all! 13:00 < MtgoxColdWallet> see you in future 13:00 < meshcollider> Thank you :) 13:00 < paper_wallet> bb 13:00 -!- cold_wallet [~cold_wall@193.25.1.157] has left #bitcoin-core-dev [] 13:00 -!- paper_wallet [~paper_wal@193.25.1.157] has quit [Quit: Lost terminal] 13:00 -!- MtgoxColdWallet [~mtgoxcold@193.25.1.157] has quit [Quit: Lost terminal] 13:00 -!- WalletIncmpatBdb [~wallet_in@193.25.1.157] has quit [Quit: Lost terminal] 13:00 -!- nestorOfWallets [~nestor_of@193.25.1.157] has quit [Quit: Lost terminal] 13:00 -!- hardware_wallet [~hardware_@193.25.1.157] has quit [Quit: Lost terminal] 13:00 -!- wallet_dat [~wallet_da@193.25.1.157] has quit [Quit: Lost terminal] 13:01 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection] 13:02 < sipa> booyah: lol 13:06 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 13:06 -!- Krellan_ [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 13:09 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 13:14 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 13:17 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 245 seconds] 13:25 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Read error: Connection reset by peer] 13:31 -!- satwo [~textual@2601:483:4e00:26ce:3133:63f8:21a2:7ec2] has joined #bitcoin-core-dev 13:41 -!- satwo [~textual@2601:483:4e00:26ce:3133:63f8:21a2:7ec2] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 13:43 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev 13:45 -!- satwo [~textual@2601:483:4e00:26ce:90d6:8c27:9095:5b78] has joined #bitcoin-core-dev 13:46 -!- satwo [~textual@2601:483:4e00:26ce:90d6:8c27:9095:5b78] has quit [Client Quit] 13:54 -!- ula [~ula@b2b-78-94-9-226.unitymedia.biz] has joined #bitcoin-core-dev 14:00 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 14:07 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection] 14:08 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev 14:09 -!- michaels_ [~michaelsd@208.59.170.5] has joined #bitcoin-core-dev 14:21 -!- michaels_ [~michaelsd@208.59.170.5] has quit [Remote host closed the connection] 14:27 -!- dqx__ [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev 14:29 -!- dqx__ [~dqx@unaffiliated/dqx] has quit [Remote host closed the connection] 14:30 -!- dqx_ [~dqx@unaffiliated/dqx] has quit [Ping timeout: 252 seconds] 14:31 -!- dqx_ [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev 14:31 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 252 seconds] 14:41 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 14:41 < jarthur> jnewbery wumpus any known issues with the new wallet and walletdir behaviors in 0.17? Someone in #bitcoin is saying the backwards compatibility with prior behavior mentioned in release notes isn't working for them. 14:48 < sipa> details? 14:48 < sipa> i'll join 14:50 -!- dqx_ [~dqx@unaffiliated/dqx] has quit [Remote host closed the connection] 14:51 < jarthur> Thanks, sipa 14:58 -!- Guyver2 [~Guyver@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 15:02 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 15:02 -!- dqx_ [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev 15:03 -!- dqx_ [~dqx@unaffiliated/dqx] has quit [Remote host closed the connection] 15:03 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 252 seconds] 15:16 -!- laurentmt [~Thunderbi@185.242.6.5] has joined #bitcoin-core-dev 15:18 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 15:31 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 15:32 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 15:36 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 15:41 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 15:47 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has quit [Ping timeout: 244 seconds] 15:57 -!- laurentmt [~Thunderbi@185.242.6.5] has quit [Quit: laurentmt] 15:59 -!- michaels_ [~michaelsd@208.59.170.5] has joined #bitcoin-core-dev 16:02 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has joined #bitcoin-core-dev 16:10 -!- michaels_ [~michaelsd@208.59.170.5] has quit [Remote host closed the connection] 16:27 -!- copumpkin [~copumpkin@haskell/developer/copumpkin] has joined #bitcoin-core-dev 16:30 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 16:33 -!- copumpkin [~copumpkin@haskell/developer/copumpkin] has quit [Quit: My MacBook Pro has gone to sleep. ZZZzzz…] 16:37 -!- jarthur [~jarthur@2605:6000:1019:41ab:90d0:e43d:1bd3:b93e] has quit [] 16:49 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 16:57 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-gkxmwcnhfhokjkpv] has joined #bitcoin-core-dev 16:57 < bitcoin-git> [bitcoin] kristapsk opened pull request #14524: Trivial: fix typo (master...typos) https://github.com/bitcoin/bitcoin/pull/14524 16:57 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-gkxmwcnhfhokjkpv] has left #bitcoin-core-dev [] 17:04 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 272 seconds] 17:05 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 17:05 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 17:15 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 17:15 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 17:26 -!- bralyclow3 [~bralyclow@195.242.213.120] has joined #bitcoin-core-dev 17:27 -!- bralyclow3 [~bralyclow@195.242.213.120] has quit [Client Quit] 17:28 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 17:30 -!- IGHOR [~quassel@93.178.216.72] has quit [Quit: http://quassel-irc.org ? ??????????? ?????????. ????-??.] 17:34 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Remote host closed the connection] 17:35 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 245 seconds] 17:36 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 17:39 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev 17:41 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 17:44 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev 17:55 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 17:56 -!- jcorgan [~jcorgan@64-142-68-61.dsl.static.sonic.net] has joined #bitcoin-core-dev 17:59 < gwillen> achow101: can you explain the comment "Get all of the previous transactions" in rawtransaction.cpp (in finalizepsbt)? 17:59 < gwillen> it appears to be just using SignPSBTInput to check if inputs are signed -- is it also intentionally mutating the transaction in some way or something? 17:59 < gwillen> or is it safe to replace with "is PSBT input signed"? 18:00 < achow101> that's very likely to be the result of copy-paste from some other rpc 18:00 * sipa guesses: the comment was copied from rpcwallet.cpp 18:04 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.2] 18:05 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 18:11 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 18:12 -!- j|l [9440023c@gateway/web/freenode/ip.148.64.2.60] has joined #bitcoin-core-dev 18:13 -!- kexkey [~kexkey@173.209.63.134] has joined #bitcoin-core-dev 18:13 -!- proletesseract [~proletess@33.213.224.49.dyn.cust.vf.net.nz] has joined #bitcoin-core-dev 18:13 -!- jpe_ [~jpe@2001:16b8:4884:4300:b902:6c99:6da1:74ba] has joined #bitcoin-core-dev 18:16 -!- jpe__ [~jpe@2001:16b8:4840:b300:1a90:8c48:4352:4903] has quit [Ping timeout: 260 seconds] 18:19 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 18:23 -!- proletesseract [~proletess@33.213.224.49.dyn.cust.vf.net.nz] has quit [Remote host closed the connection] 18:26 -!- j|l [9440023c@gateway/web/freenode/ip.148.64.2.60] has quit [Ping timeout: 256 seconds] 18:40 -!- Krellan_ [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 18:45 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-zvlyakubwubohijr] has joined #bitcoin-core-dev 18:45 < bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d387507aeca6...8010ded6da56 18:45 < bitcoin-git> bitcoin/master 7e18673 Kristaps Kaupe: Fix typo 18:45 < bitcoin-git> bitcoin/master 8010ded Pieter Wuille: Merge #14524: Trivial: fix typo... 18:45 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-zvlyakubwubohijr] has left #bitcoin-core-dev [] 18:46 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-icmioilmcodkxmdt] has joined #bitcoin-core-dev 18:46 < bitcoin-git> [bitcoin] sipa closed pull request #14524: Trivial: fix typo (master...typos) https://github.com/bitcoin/bitcoin/pull/14524 18:46 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-icmioilmcodkxmdt] has left #bitcoin-core-dev [] 18:48 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 18:53 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-vvwdftvotqvbjkjn] has joined #bitcoin-core-dev 18:53 < bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/8010ded6da56...b14db5abab40 18:53 < bitcoin-git> bitcoin/master bc60c61 practicalswift: Avoid 1 << 31 (UB) in calculation of SEQUENCE_LOCKTIME_DISABLE_FLAG 18:53 < bitcoin-git> bitcoin/master b14db5a Pieter Wuille: Merge #14513: Avoid 1 << 31 (UB) in calculation of SEQUENCE_LOCKTIME_DISABLE_FLAG... 18:53 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-vvwdftvotqvbjkjn] has left #bitcoin-core-dev [] 18:54 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-zbnnunxbnxnlkics] has joined #bitcoin-core-dev 18:54 < bitcoin-git> [bitcoin] sipa closed pull request #14513: Avoid 1 << 31 (UB) in calculation of SEQUENCE_LOCKTIME_DISABLE_FLAG (master...1<<31-again) https://github.com/bitcoin/bitcoin/pull/14513 18:54 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-zbnnunxbnxnlkics] has left #bitcoin-core-dev [] 18:57 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev 19:00 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-wbuwlhpjsnrprizu] has joined #bitcoin-core-dev 19:00 < bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b14db5abab40...b2863c0685a5 19:00 < bitcoin-git> bitcoin/master 369244f Chun Kuan Lee: utils: Fix broken Windows filelock 19:00 < bitcoin-git> bitcoin/master b2863c0 Pieter Wuille: Merge #14426: utils: Fix broken Windows filelock... 19:00 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-wbuwlhpjsnrprizu] has left #bitcoin-core-dev [] 19:01 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-bgowsfuujdadjtst] has joined #bitcoin-core-dev 19:01 < bitcoin-git> [bitcoin] sipa closed pull request #14426: utils: Fix broken Windows filelock (master...filelock-test) https://github.com/bitcoin/bitcoin/pull/14426 19:01 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-bgowsfuujdadjtst] has left #bitcoin-core-dev [] 19:02 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 252 seconds] 19:03 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-vsyuicgdhujgcjqo] has joined #bitcoin-core-dev 19:03 < bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/b2863c0685a5...dc1e54206d76 19:03 < bitcoin-git> bitcoin/master 1f01fe0 Antoine Le Calvez: bitcoin-tx: Use constant for n pubkeys check... 19:03 < bitcoin-git> bitcoin/master dc1e542 Pieter Wuille: Merge #14474: bitcoin-tx: Use constant for n pubkeys check... 19:03 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-vsyuicgdhujgcjqo] has left #bitcoin-core-dev [] 19:04 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-nnevoskmgaoyrjkc] has joined #bitcoin-core-dev 19:04 < bitcoin-git> [bitcoin] sipa closed pull request #14474: bitcoin-tx: Use constant for n pubkeys check (master...bitcoin_tx_use_constant) https://github.com/bitcoin/bitcoin/pull/14474 19:04 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-nnevoskmgaoyrjkc] has left #bitcoin-core-dev [] 19:05 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-dtxbivitfviazlvo] has joined #bitcoin-core-dev 19:05 < bitcoin-git> [bitcoin] sipa pushed 2 new commits to 0.17: https://github.com/bitcoin/bitcoin/compare/5b47b8efd48d...1b5af2c177ee 19:05 < bitcoin-git> bitcoin/0.17 f7dbcaa Sjors Provoost: [doc] getblocktemplate: use SegWit in example 19:05 < bitcoin-git> bitcoin/0.17 1b5af2c Pieter Wuille: Merge #14509: [0.17] doc: use SegWit in getblocktemplate example... 19:05 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-dtxbivitfviazlvo] has left #bitcoin-core-dev [] 19:08 < fanquake> sipa It'd be great if you could also merged #14011 19:09 < gribble> https://github.com/bitcoin/bitcoin/issues/14011 | Disable wallet and address book Qt tests on macOS minimal platform by ryanofsky · Pull Request #14011 · bitcoin/bitcoin · GitHub 19:12 < sipa> fanquake: sgtm 19:13 -!- ula [~ula@b2b-78-94-9-226.unitymedia.biz] has quit [Quit: KVIrc 5.0.0 Aria http://www.kvirc.net/] 19:14 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-qnbihnaobhvrdynt] has joined #bitcoin-core-dev 19:14 < bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/dc1e54206d76...e754c6e33194 19:14 < bitcoin-git> bitcoin/master a3197c5 Russell Yanofsky: Disable wallet and address book Qt tests on macOS minimal platform... 19:14 < bitcoin-git> bitcoin/master e754c6e Pieter Wuille: Merge #14011: Disable wallet and address book Qt tests on macOS minimal platform... 19:14 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-qnbihnaobhvrdynt] has left #bitcoin-core-dev [] 19:15 < sipa> anything else? 19:15 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-kbsjorrdoxgsyilq] has joined #bitcoin-core-dev 19:15 < bitcoin-git> [bitcoin] sipa closed pull request #14011: Disable wallet and address book Qt tests on macOS minimal platform (master...pr/fuqtmac) https://github.com/bitcoin/bitcoin/pull/14011 19:15 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-kbsjorrdoxgsyilq] has left #bitcoin-core-dev [] 19:15 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Read error: Connection reset by peer] 19:15 -!- ExtraCrispy [~ExtraCris@gateway/tor-sasl/extracrispy] has quit [Read error: Connection reset by peer] 19:15 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Read error: Connection reset by peer] 19:15 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Read error: Connection reset by peer] 19:15 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Write error: Connection reset by peer] 19:15 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 19:15 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev 19:15 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev 19:15 < fanquake> sipa cheers. #14512 is also a trivial merge. 19:15 < gribble> https://github.com/bitcoin/bitcoin/issues/14512 | docs: Textual improvements in README.md by merland · Pull Request #14512 · bitcoin/bitcoin · GitHub 19:20 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 19:24 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-zsscmvryyvskqajv] has joined #bitcoin-core-dev 19:24 < bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e754c6e33194...91482e5bf22d 19:24 < bitcoin-git> bitcoin/master 29ed2d6 Hennadii Stepanov: Improve CAmount tests... 19:24 < bitcoin-git> bitcoin/master 91482e5 Pieter Wuille: Merge #14460: tests: Improve 'CAmount' tests... 19:24 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-zsscmvryyvskqajv] has left #bitcoin-core-dev [] 19:25 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-eoaqlsokpjwilffa] has joined #bitcoin-core-dev 19:25 < bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/91482e5bf22d...544f3234384b 19:25 < bitcoin-git> bitcoin/master b6b9915 Martin Erlandsson: Textual improvements 19:25 < bitcoin-git> bitcoin/master 544f323 Pieter Wuille: Merge #14512: docs: Textual improvements in README.md... 19:25 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-eoaqlsokpjwilffa] has left #bitcoin-core-dev [] 19:33 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 19:34 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 19:46 -!- proletesseract [~proletess@33.213.224.49.dyn.cust.vf.net.nz] has joined #bitcoin-core-dev 19:48 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.2] 19:56 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 20:03 -!- proletesseract [~proletess@33.213.224.49.dyn.cust.vf.net.nz] has quit [Remote host closed the connection] 20:23 -!- polydin [~delphi@2602:306:b8b6:b970:ed2f:fd05:f6bc:da48] has joined #bitcoin-core-dev 20:26 -!- polydin [~delphi@2602:306:b8b6:b970:ed2f:fd05:f6bc:da48] has quit [Client Quit] 20:33 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…] 20:45 -!- bitconner [~conner@136.24.75.121] has quit [Ping timeout: 276 seconds] 20:55 -!- schnerch_ [~schnerchi@p54A0EDCC.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 20:58 -!- schnerchi [~schnerchi@p3EE1C414.dip0.t-ipconnect.de] has quit [Ping timeout: 252 seconds] 20:59 -!- copumpkin [~copumpkin@haskell/developer/copumpkin] has joined #bitcoin-core-dev 21:28 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 21:28 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 21:37 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 252 seconds] 21:42 -!- Tralfaz [~none@185.156.175.59] has quit [Read error: Connection reset by peer] 21:42 -!- copumpkin [~copumpkin@haskell/developer/copumpkin] has quit [Read error: Connection reset by peer] 21:43 -!- Tralfaz [~none@185.156.175.59] has joined #bitcoin-core-dev 21:43 -!- copumpkin [~copumpkin@haskell/developer/copumpkin] has joined #bitcoin-core-dev 21:44 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 22:11 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-axagannhymuuiuvx] has joined #bitcoin-core-dev 22:11 < bitcoin-git> [bitcoin] fanquake opened pull request #14526: docs: Document lint tests (master...revive-document-lint-tests) https://github.com/bitcoin/bitcoin/pull/14526 22:11 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-axagannhymuuiuvx] has left #bitcoin-core-dev [] 22:11 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ncjeaxawbaibfhfg] has joined #bitcoin-core-dev 22:11 < bitcoin-git> [bitcoin] fanquake closed pull request #13708: docs: Document lint tests (master...document-lint-tests) https://github.com/bitcoin/bitcoin/pull/13708 22:11 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ncjeaxawbaibfhfg] has left #bitcoin-core-dev [] 22:24 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-hzfplvpdaikbwhlb] has joined #bitcoin-core-dev 22:24 < bitcoin-git> [bitcoin] fanquake closed pull request #13542: Adding Docker/docker-compose files (master...docker) https://github.com/bitcoin/bitcoin/pull/13542 22:24 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-hzfplvpdaikbwhlb] has left #bitcoin-core-dev [] 22:30 -!- proletesseract [~proletess@219.88.232.29] has joined #bitcoin-core-dev 22:31 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-etkdxprmxclotajc] has joined #bitcoin-core-dev 22:31 < bitcoin-git> [bitcoin] fanquake closed pull request #14014: Scripts and tools: fix gitian-build.py --verify option (master...gitian-verify) https://github.com/bitcoin/bitcoin/pull/14014 22:31 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-etkdxprmxclotajc] has left #bitcoin-core-dev [] 22:37 -!- Tralfaz [~none@185.156.175.59] has quit [Remote host closed the connection] 22:37 -!- Tralfaz [~none@185.156.175.59] has joined #bitcoin-core-dev 22:37 -!- Tralfaz [~none@185.156.175.59] has quit [Client Quit] 22:44 -!- Tralfaz [~none@192.30.89.142] has joined #bitcoin-core-dev 22:44 -!- Squidicuz [~squid@pool-72-74-34-120.bstnma.fios.verizon.net] has quit [Read error: Connection reset by peer] 22:45 -!- Squidicuz [~squid@pool-72-74-34-120.bstnma.fios.verizon.net] has joined #bitcoin-core-dev 22:46 -!- keymone [~keymone@ip1f109c7a.dynamic.kabel-deutschland.de] has quit [Ping timeout: 252 seconds] 22:47 -!- Tralfaz [~none@192.30.89.142] has quit [Client Quit] 22:47 -!- Tralfaz [~none@192.30.89.142] has joined #bitcoin-core-dev 22:48 -!- Tralfaz [~none@192.30.89.142] has quit [Client Quit] 22:49 -!- keymone [~keymone@ip1f109c7a.dynamic.kabel-deutschland.de] has joined #bitcoin-core-dev 22:56 < wumpus> midnightmagic: well... currently only run OpenBSD in VM; and yes, bitcoin builds fine on OpenBSD, there's special instructions for that, which fanquake updated for 6.4 and I'l like to test out but couldn't yet 22:56 -!- jpe [~jpe@2001:16b8:48a0:ac00:dfb1:1f3b:fe48:a3f6] has joined #bitcoin-core-dev 22:59 -!- jpe_ [~jpe@2001:16b8:4884:4300:b902:6c99:6da1:74ba] has quit [Ping timeout: 276 seconds] 22:59 < fanquake> wumpus I've looked at the BSD configure issue a bit more. Looks like a bug fix in 1.16 might have broken something we do, https://github.com/bitcoin/bitcoin/issues/14404#issuecomment-431542526 22:59 < fanquake> Still need to get an actual fix. 23:00 -!- Tuna_Golem [~Tuna_Gole@bzq-82-81-88-212.red.bezeqint.net] has joined #bitcoin-core-dev 23:01 < fanquake> *automake 1.16 23:01 < midnightmagic> nice 23:02 < midnightmagic> if I could get netbsd into my talos somehow, I'd be testing in there. 23:02 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev 23:03 -!- Krellan [~Krellan@2600:1700:be50:3230:14c1:1987:da52:4c1a] has joined #bitcoin-core-dev 23:03 -!- Krellan [~Krellan@2600:1700:be50:3230:14c1:1987:da52:4c1a] has quit [Read error: Connection reset by peer] 23:05 < wumpus> fanquake: thanks for investigating; glad you could narrow it down to a specific automake change 23:06 -!- Krellan [~Krellan@2601:640:4000:9258:b599:1b44:eafd:539b] has joined #bitcoin-core-dev 23:07 < wumpus> midnightmagic: yeah would love to run *BSD on my SiFive board, but that's a pipe dream for now, even a linux kernel that works is hard to find :) 23:08 < midnightmagic> you mean the hifive unleashed? 23:08 < midnightmagic> did you get the expansion board too? 23:09 < wumpus> it's the first time I bothered with fedora as that seems to be the best supported distro for it 23:09 < wumpus> yes that one 23:09 < midnightmagic> i wonder if that page-fault-computing usenix method can be used on the sifive stuff 23:09 < wumpus> FWIW it runs a bitcoin + lightning node + tor fine :D 23:09 < midnightmagic> wow, nice. 23:11 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 23:11 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 23:12 < wumpus> yes it's kind of cool; I do use nbd for storage, though—no expansion board was too late for that 23:12 < midnightmagic> still unavailable, too, apparently. 23:12 < wumpus> I got one of the last unleashed boards, literally a week later the option to order them was closed :) 23:12 < midnightmagic> This kind of hardware, I don't mind learning new assembly for. 23:13 < sipa> that's risc-v? 23:13 < midnightmagic> yeah 23:13 < sipa> nice 23:13 < wumpus> midnightmagic: yeah it's not much work either, the instruction set is super straightforward 23:14 < midnightmagic> runs bitcoin okay? how long did it take to sync with nbd..? 23:14 < midnightmagic> (Also, why not nfs?) 23:14 < wumpus> midnightmagic: this lists all of them: https://github.com/michaeljclark/riscv-meta/blob/master/opcode-fullnames 23:14 < wumpus> (including extensions) 23:15 < midnightmagic> whoah, short. 23:15 < midnightmagic> did you ever see the power9 instruction set? 23:16 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 23:16 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 23:16 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-bbicsawrobhoewcy] has joined #bitcoin-core-dev 23:16 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/544f3234384b...d433239a8d54 23:16 < bitcoin-git> bitcoin/master 94e21c1 James O'Beirne: test: forward timeouts properly in send_blocks_and_test 23:16 < bitcoin-git> bitcoin/master d433239 MarcoFalke: Merge #14456: test: forward timeouts properly in send_blocks_and_test... 23:16 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-bbicsawrobhoewcy] has left #bitcoin-core-dev [] 23:16 < wumpus> the only thing I really had to get used to, is that loading longer immediates is split over multiple instructions instead of in-line (such as auipc and jlr for jump) 23:17 < wumpus> midnightmagic: I don't think so! 23:17 < midnightmagic> you have to do weird things like load in addresses in four pieces, carefully shifting them and arranging them.. 23:17 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-urzqqkdsfezwliuf] has joined #bitcoin-core-dev 23:17 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #14456: test: forward timeouts properly in send_blocks_and_test (master...2018-10-test-forward-timeouts) https://github.com/bitcoin/bitcoin/pull/14456 23:17 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-urzqqkdsfezwliuf] has left #bitcoin-core-dev [] 23:18 < wumpus> at least I hope risc-v is the last assembly language I ever have to learn and it will take over everything xD 23:19 < wumpus> yes, bitcoin runs ok, syncing doesn't go super fast but it was a bit faster than most ARM boards from a few years ago I've tried on 23:20 < midnightmagic> wumpus: it's *huge*. The PowerISA reference manual is 1240 pages. 23:20 < wumpus> the SD card driver was kind of broken so that's why I'm using nbd, nbd in contrast to nfs is very easy to set up, no need to bother with username mappings, rpc servers, and horrible stuff like that 23:22 < midnightmagic> "Appendix F. Power ISA Instruction Set Sorted by Mnemonic" => 17 pages is tiny little writing. 23:22 < wumpus> that's kind of much for a *reduced* instruction set platform 23:22 < wumpus> though it's still less than Intel's multi-volume bibles 23:22 < midnightmagic> 56 opcodes per page. 23:23 < midnightmagic> What the hell does "Transaction Abort Doubleword Conditional Immediate & record" even mean lol and yet, after discovering the weird futureAlienTech IBM put into it. Dude. 23:25 < wumpus> heh those pages are either scribbled with occult markings or ▓███▒▓█-censored ... nah, sounds like some combinatorial complexity blowup 23:26 < wumpus> 'let's make 2^n variants of instruction and all document them separately, that's a way to fill a book' 23:27 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev 23:27 < midnightmagic> If a pcie card tries to twiddle ram without a dma properly setup, the power chips intercept it and helpfully fire off an OS handler do you can decide what to do about it yourself. I guess on normal hardware it just lets it get away with it. 23:28 < wumpus> anyhow, risc-v is nice and clean, though if it really catches on with many vendors i'd expect ehere might be a cambrian explosion of (even proprietary) extensions at some point though 23:28 < midnightmagic> I have a supermicro sas card here that tried to munge main memory *on boot* and had to be disabled by the pre-OS checks. wtf. 23:28 < sipa> wumpus: i just learned from wikipedia that the r in risc does not refer to the size of the instruction set, but to how complex operations per instruction can be (in particular, how many memory accesses) 23:28 < midnightmagic> well I sure hope so. 23:28 < wumpus> sipa: oh! TIL too 23:29 < sipa> and there have been CISC platforms with just 8 instructions 23:29 < wumpus> midnightmagic: I agree, it'd be a form of open competition which is good 23:30 < ossifrage> I thought early RISC was along the lines of what can be done in an cycle (with most instructions being register to register) 23:31 < midnightmagic> still burns me atmel dropped avr for arm. wumpus: well if it does anything interesting with the bitcoin node, I know I at least would love to hear about it. 23:33 < ossifrage> I always found it cleaner to decouple memory to register instructions from register to alu to register instructions 23:33 < wumpus> ossifrage: apparently yes that's what it means 23:35 < wumpus> definitely, having, all the addressing modes for every instruction is a lot of complexity, and then you end up with things like 'MOV is turing-complete' 23:36 < ossifrage> If you don't have a pipeline writing a RISC CPU in verilog is surprisingly simple. 23:36 < wumpus> yes handling timing and pipelines is where it gets complex 23:37 < fanquake> MarcoFalke If you want to merge #14497 I think that's ready to go. 23:37 < gribble> https://github.com/bitcoin/bitcoin/issues/14497 | docs: Add doc/bitcoin-conf.md by hebasto · Pull Request #14497 · bitcoin/bitcoin · GitHub 23:37 < wumpus> e.g. this is a whole rv32 CPU https://github.com/cliffordwolf/picorv32/blob/master/picorv32.v 23:37 < ossifrage> wumpus, the bugs in the chip I worked on where in the hazard logic and the pipeline bypass. Stuff that managed to get past verification 23:38 < ossifrage> I can't imagine how painful it is to verify a CISC processor 23:38 < wumpus> it can fit in the small FPGAs supported by the open source yosys toolchain 23:40 < wumpus> fanquake: will merge 23:42 < wumpus> but yes it's kind of sad i missed the expansion board, would have been neat to connect a GPU and keyboard and have an actual RISC-V PC 23:44 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-znpuondewshbgupw] has joined #bitcoin-core-dev 23:44 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d433239a8d54...6746a8951923 23:44 < bitcoin-git> bitcoin/master 1fb3c16 Hennadii Stepanov: Add `doc/bitcoin-conf.md` 23:44 < bitcoin-git> bitcoin/master 6746a89 Wladimir J. van der Laan: Merge #14497: docs: Add doc/bitcoin-conf.md... 23:44 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-znpuondewshbgupw] has left #bitcoin-core-dev [] 23:45 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-yzcwtptglrydepjy] has joined #bitcoin-core-dev 23:45 < bitcoin-git> [bitcoin] laanwj closed pull request #14497: docs: Add doc/bitcoin-conf.md (master...20181016-bitcoin-conf-md) https://github.com/bitcoin/bitcoin/pull/14497 23:45 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-yzcwtptglrydepjy] has left #bitcoin-core-dev [] 23:47 < wumpus> maybe they'll re-open production at some point! at least the unleashed board, despite the outrageous price, were popular enough for a new batch 23:53 < wumpus> midnightmagic: it's reassuring that the IOMMU on that board is consistent and doesn't make an exception for boot-time memory twiddling 23:55 < wumpus> midnightmagic: btw re: POWER cna you weigh in on #14066 please 23:55 < gribble> https://github.com/bitcoin/bitcoin/issues/14066 | gitian-linux: Build binaries for 64-bit POWER by luke-jr · Pull Request #14066 · bitcoin/bitcoin · GitHub 23:55 -!- ken2812221 [~ken281222@110.50.135.178] has joined #bitcoin-core-dev 23:55 < fanquake> wumpus Would we be able to fork emil-e/rapidcheck to github.com/bitcoin-core/? 23:55 < midnightmagic> sure 23:55 < fanquake> Marco has a fork that we currently use for depends, however it'd be good to move to a newer version for some bug fixes and a potentially simpler build. 23:55 < fanquake> We need the fork so we can create our own archive, because emil-e/rapidcheck isn’t tagging releases yet. 23:56 < wumpus> fanquake: yep; do we need our own fork of that? 23:56 < wumpus> yes, sure --- Log closed Sat Oct 20 00:00:42 2018