--- Log opened Mon Oct 22 00:00:37 2018
--- Day changed Mon Oct 22 2018
00:00 -!- sanket1729 [62d49a0a@gateway/web/freenode/ip.98.212.154.10] has joined #bitcoin-core-dev
00:01 -!- klot [~klot@188.113.35.204] has joined #bitcoin-core-dev
00:01 -!- sanket1729 [62d49a0a@gateway/web/freenode/ip.98.212.154.10] has quit [Client Quit]
00:02 -!- klot [~klot@188.113.35.204] has quit [Remote host closed the connection]
00:02 -!- klot [~klot@188.113.35.204] has joined #bitcoin-core-dev
00:03 -!- klot [~klot@188.113.35.204] has quit [Remote host closed the connection]
00:04 -!- klot [~klot@188.113.35.204] has joined #bitcoin-core-dev
00:05 -!- klot [~klot@188.113.35.204] has quit [Remote host closed the connection]
00:05 < provoostenator> Github is still in a bad mood. Seeing "You can't comment at this time", unicorns all over the place and "Start Review" doesn't work.
00:05 -!- klot [~klot@188.113.35.204] has joined #bitcoin-core-dev
00:06 < sipa> phantomcircuit: status.github.com
00:06 < sipa> eh provoostenator ^
00:07 -!- ken2812221 [~ken281222@2001-b011-4010-3676-442d-70fb-efb2-e33e.dynamic-ip6.hinet.net] has joined #bitcoin-core-dev
00:08 < provoostenator> Accurate status page, that's new :-)
00:17 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]
00:20 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev
00:36 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection]
00:37 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev
00:45 -!- rhavar [uid237883@gateway/web/irccloud.com/x-poznjshimuagjjrx] has quit [Quit: Connection closed for inactivity]
00:49 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood]
00:49 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
00:55 -!- jungly_ [~quassel@host97-200-static.8-79-b.business.telecomitalia.it] has joined #bitcoin-core-dev
00:57 < wumpus> hehe yes that's a new one,typically no one even bothers to check status pages because they tend to be only updated when a problem is already fixed
01:03 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev
01:04 -!- setpill [~setpill@unaffiliated/setpill] has quit [Client Quit]
01:07 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev
01:08 < wumpus> it's taking long though must be a serious issue
01:09 < jonasschnelli> sipa: with the CNetMessageSerializer, that would be an instance per peer?
01:10 < jonasschnelli> Maybe even a global instance for v1 / v2(enc.) protocol?
01:13 -!- setpill [~setpill@unaffiliated/setpill] has quit [Ping timeout: 250 seconds]
01:14 < kallewoof> https://blog.github.com/2018-10-21-october21-incident-report/
01:15 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev
01:15 < kallewoof> "multiple services on GitHub.com were affected by a network partition and subsequent database failure resulting in inconsistent information being presented on our website"
01:25 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev
01:29 < echeveria> a little unclear what happened there. smart tools being dumb?
01:30 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
01:31 -!- martinus_ [53a499e2@gateway/web/freenode/ip.83.164.153.226] has joined #bitcoin-core-dev
01:34 -!- ken2812221 [~ken281222@2001-b011-4010-3676-442d-70fb-efb2-e33e.dynamic-ip6.hinet.net] has quit [Ping timeout: 252 seconds]
01:35 -!- josephnicholas [~josephnic@110.54.242.207] has joined #bitcoin-core-dev
01:35 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 276 seconds]
01:40 -!- josephnicholas [~josephnic@110.54.242.207] has quit [Ping timeout: 240 seconds]
01:44 < hebasto> how can I get blocks/ and chainstate/ folders as if the node was offline some blocks (for testnet)?
01:46 -!- ken2812221 [~ken281222@2001-b011-4010-3676-24af-e008-2140-f01e.dynamic-ip6.hinet.net] has joined #bitcoin-core-dev
01:50 -!- promag [~promag@83.223.248.43] has joined #bitcoin-core-dev
01:51 -!- josephnicholas [~josephnic@110.54.242.207] has joined #bitcoin-core-dev
01:51 < promag> kallewoof: thanks
01:53 < kallewoof> promag: NP! What is end()? :o
01:53 < kallewoof> Or, where, rather.
01:54 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood]
01:54 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
01:54 < promag> std::end
01:58 < promag> i think for (auto it : fs::recursive_directory_iterator(wallet_dir)) should work
01:58 < promag> I'll try in a bit
02:06 < promag> kallewoof: actually must be fs::end() 
02:07 < kallewoof> But you're not "using" any namespaces and it doesn't have a namespace prefix in the code. I'm so confused why this compiles.
02:12 -!- berndj-blackout [~berndj@197.242.93.82] has joined #bitcoin-core-dev
02:12 -!- berndj [~berndj@azna.co.za] has quit [Ping timeout: 268 seconds]
02:14 -!- berndj-blackout is now known as berndj
02:15 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]
02:16 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
02:21 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev
02:21 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 252 seconds]
02:23 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
02:30 < promag> kallewoof: can you try replacing with "    for (auto it = fs::recursive_directory_iterator(wallet_dir); it != fs::recursive_directory_iterator(); ++it) { " ?
02:30 < kallewoof> sure thing, one sec
02:32 < kallewoof> That compiles (but still having the relative not a part of fs errors)
02:32 < promag> ty
02:32 < promag> right
02:32 < promag> that was identified earlier
02:32 < kallewoof> *nod*
02:33 < promag> it turns out that fs::relative is doing something that we don't want
02:33 < promag> see this comment https://github.com/bitcoin/bitcoin/pull/14291/files#r226843422
02:42 -!- afsd [53a499e2@gateway/web/freenode/ip.83.164.153.226] has joined #bitcoin-core-dev
02:47 -!- afsd [53a499e2@gateway/web/freenode/ip.83.164.153.226] has quit [Ping timeout: 256 seconds]
02:52 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 252 seconds]
02:53 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Remote host closed the connection]
02:53 < promag> I guess better not comment on gh for now
02:58 < echeveria> yeah they backed off on their estimates. back to an hour and a half.
03:01 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has quit [Ping timeout: 268 seconds]
03:02 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has joined #bitcoin-core-dev
03:09 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
03:12 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 246 seconds]
03:17 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
03:18 -!- promag [~promag@83.223.248.43] has quit [Remote host closed the connection]
03:36 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
03:38 -!- promag [~promag@83.223.235.110] has joined #bitcoin-core-dev
03:42 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has quit [Quit: Leaving...]
03:45 < promag> kallewoof: can you try https://github.com/promag/bitcoin/tree/2018-10-getrelativepath?
03:46 < promag> it should fix listwalletdir behavior and building with boost 1.47
03:54 -!- josephnicholas [~josephnic@110.54.242.207] has quit [Ping timeout: 244 seconds]
03:54 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
03:55 -!- josephnicholas [~josephnic@110.54.242.207] has joined #bitcoin-core-dev
03:56 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
04:05 < wumpus> huh looks like my comment did go through a zillion times, wtf
04:06 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection]
04:07 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev
04:07 -!- infernix [nix@unaffiliated/infernix] has quit [Ping timeout: 252 seconds]
04:08 < promag> wumpus: I thought you wrote it multiple times :P
04:08 -!- promag [~promag@83.223.235.110] has quit [Remote host closed the connection]
04:09 < wumpus> I only wrote it two times
04:09 < wumpus> first time I thought I'd lost it
04:09  * wumpus really unhappy with github right now
04:13 < echeveria> they cooked something really well, and sadly the way they didn't take down the site means lots of things got massive duplicate submissions (see the number of issue emails in my inbox, derp)
04:25 -!- josephnicholas [~josephnic@110.54.242.207] has quit [Ping timeout: 252 seconds]
04:35 -!- klot_ [~klot@188.113.48.142] has joined #bitcoin-core-dev
04:36 -!- klot_ [~klot@188.113.48.142] has quit [Remote host closed the connection]
04:36 -!- klot_ [~klot@188.113.48.142] has joined #bitcoin-core-dev
04:37 -!- klot_ [~klot@188.113.48.142] has quit [Remote host closed the connection]
04:38 -!- klot_ [~klot@188.113.48.142] has joined #bitcoin-core-dev
04:38 -!- klot [~klot@188.113.35.204] has quit [Ping timeout: 252 seconds]
04:42 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
04:43 -!- ken2812221_ [~ken281222@110.50.135.178] has joined #bitcoin-core-dev
04:44 -!- josephnicholas [~josephnic@110.54.242.207] has joined #bitcoin-core-dev
04:47 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 245 seconds]
04:55 -!- ken2812221 [~ken281222@2001-b011-4010-3676-24af-e008-2140-f01e.dynamic-ip6.hinet.net] has quit [Ping timeout: 252 seconds]
05:01 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has joined #bitcoin-core-dev
05:01 -!- schmidty is now known as Guest19314
05:03 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has joined #bitcoin-core-dev
05:06 -!- infernix [nix@unaffiliated/infernix] has joined #bitcoin-core-dev
05:07 -!- josephnicholas [~josephnic@110.54.242.207] has quit [Ping timeout: 264 seconds]
05:10 < wumpus> yess sorry for the spams
05:21 < luke-jr> >_<
05:29 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev
05:49 -!- OzPac [~OzPac@cpc110789-lewi20-2-0-cust636.2-4.cable.virginm.net] has joined #bitcoin-core-dev
05:52 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit []
05:52 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev
05:56 < promag> are we there yet?
05:59 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has quit [Remote host closed the connection]
06:00 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has joined #bitcoin-core-dev
06:34 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
07:02 -!- ExtraCrispy [~ExtraCris@gateway/tor-sasl/extracrispy] has quit [Remote host closed the connection]
07:03 -!- ExtraCrispy [~ExtraCris@gateway/tor-sasl/extracrispy] has joined #bitcoin-core-dev
07:08 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!]
07:10 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/]
07:12 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev
07:18 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 246 seconds]
07:18 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev
07:21 < cdecker> ccccccfnijgituclltkdgdvkejjhrbdeevrhrkefibun
07:26 < BlueMatt> cdecker: ffs
07:26 < instagibbs> grief or yubikey press, you decide
07:26 < BlueMatt> why do people use that yubikey print shit anyway
07:29 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev
07:31 -!- Wadexs [7cb1e9b2@gateway/web/freenode/ip.124.177.233.178] has joined #bitcoin-core-dev
07:32 < luke-jr> instagibbs: IMO cat on keyboard
07:32 < luke-jr> (should be an option()
07:33 < Wadexs> Bitcoin testnet exchange
07:37 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
07:38 -!- Wadexs [7cb1e9b2@gateway/web/freenode/ip.124.177.233.178] has quit [Quit: Page closed]
07:46 -!- jcorgan [~jcorgan@64-142-68-61.dsl.static.sonic.net] has quit [Changing host]
07:46 -!- jcorgan [~jcorgan@unaffiliated/jcorgan] has joined #bitcoin-core-dev
07:48 -!- jungly_ [~quassel@host97-200-static.8-79-b.business.telecomitalia.it] has quit [Remote host closed the connection]
07:50 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
07:52 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
07:57 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 272 seconds]
07:59 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]
08:01 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
08:07 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
08:10 -!- michagogo [uid14316@wikia/Michagogo] has joined #bitcoin-core-dev
08:25 -!- booyah [~bb@193.25.1.157] has joined #bitcoin-core-dev
08:29 -!- bralyclo_ [~bralyclow@76-202-84-204.lightspeed.tukrga.sbcglobal.net] has joined #bitcoin-core-dev
08:33 -!- bralyclow [~bralyclow@195.242.213.119] has quit [Ping timeout: 272 seconds]
08:34 < phantomcircuit> BlueMatt, because it was the only thing that actually worked for a while
08:35 < phantomcircuit> now you can do the totp stuff over nfc
08:40 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
09:02 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
09:02 < gwillen> also because it's on by default even if you only use your yubikey for other stuff
09:02 < gwillen> and at least on my usb C yubikeys there's some kind of problem that prevents me from turning it off
09:02 < gwillen> they both came in a state where my copy of the yubikey personalization tool claims they are locked and cannot be reconfigured
09:06 -!- Krellan [~Krellan@2601:640:4000:9258:70f7:e790:7f06:4250] has quit [Ping timeout: 252 seconds]
09:12 -!- jungly [~quassel@host97-200-static.8-79-b.business.telecomitalia.it] has joined #bitcoin-core-dev
09:12 -!- michaelfolkson [~textual@85.211.226.228] has joined #bitcoin-core-dev
09:14 < phantomcircuit> gwillen, iirc there's a default pin
09:14 < phantomcircuit> gwillen, if not then that's mega suspicious
09:15 -!- michaelfolkson [~textual@85.211.226.228] has quit [Client Quit]
09:16 < gwillen> oh, is there? What's the default pin? My USB-A ones came with no PIN set.
09:17 < gwillen> in some sense it's mega-suspicious, I guess, but ... the subsystem that uses the PIN does not interact in any way with the U2F subsystem as far as I know
09:17 < gwillen> so if someone were going to mess with my yubikeys, which I use for U2F, it would be unimaginably sloppy to mess with the PIJ
09:17 < gwillen> PIN*
09:19 -!- michaelfolkson [~textual@85.211.226.228] has joined #bitcoin-core-dev
09:19 -!- michaelfolkson [~textual@85.211.226.228] has quit [Client Quit]
09:19 < phantomcircuit> gwillen, and yet...
09:19 < phantomcircuit> 123456 maybe?
09:26 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
09:30 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
09:49 -!- Krellan [~Krellan@2601:640:4000:9258:70f7:e790:7f06:4250] has joined #bitcoin-core-dev
09:49 -!- bralyclow [~bralyclow@195.242.213.119] has joined #bitcoin-core-dev
09:50 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection]
09:51 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev
09:53 -!- bralyclo_ [~bralyclow@76-202-84-204.lightspeed.tukrga.sbcglobal.net] has quit [Ping timeout: 246 seconds]
09:53 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
10:06 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
10:07 -!- pope__ [~pope@2a01:e35:8a36:a1c0:2539:8dd6:664f:c13e] has quit [Ping timeout: 252 seconds]
10:15 -!- jungly [~quassel@host97-200-static.8-79-b.business.telecomitalia.it] has quit [Remote host closed the connection]
10:25 < andytoshi> BlueMatt: on a yubikey 4 you can't turn it off if you want to use both ssh and u2f
10:25 -!- Zorbak [b9f4d586@gateway/web/freenode/ip.185.244.213.134] has joined #bitcoin-core-dev
10:26 < andytoshi> because the apparently did not have time to test their new closed-source software on all possible enable/disable combinations. i guess 8 is a pretty big number.
10:26 < BlueMatt> andytoshi: uhhh, its definitely off for my yubikey 4
10:26 < BlueMatt> ohoh, i guess i dont have u2f on my 4
10:26 < BlueMatt> only ssh
10:26 < BlueMatt> well, pgp
10:26 -!- Zorbak [b9f4d586@gateway/web/freenode/ip.185.244.213.134] has quit [Client Quit]
10:26 < andytoshi> yep, if you try to turn on u2f it'll just fail with a mysterious error
10:26 < andytoshi> or succeed but not actually turn on? i forget now
10:26 < BlueMatt> i have u2f off
10:26 < BlueMatt> i only have pgp on, though
10:27 < BlueMatt> not u2f + the native yubikey bullshit
10:29 < andytoshi> well, if you want u2f the native bullshit is gonna come along for the ride.
10:29 < andytoshi> so try to avoid wanting u2f
10:30 < BlueMatt> well I have the native bullshit turned off on my non-4 yubikey
10:30 < BlueMatt> the one that only does u2f+native
10:30 < BlueMatt> so just get you one of those
10:36 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 240 seconds]
10:37 < phantomcircuit> sipa, cant say i understand the logic for the send/recv stuff really
10:38 < phantomcircuit> but whatever
10:38 < sipa> phantomcircuit: i think part of it is historical
10:39 < sipa> at some point there was 'eager sending', where we'd send directly from the message handler if the send queue was empty, rather than putting it in the queue and waiting for the send handler
10:39 < sipa> i think the 'don't processing incoming when send buffer full' also dates from that time
10:42 < sipa> seems totally reasonable to get rid of that logic, imho
10:43 < gmaxwell> So what happens if the send buffer is full, and you process some more messages and thus need to send more?
10:43 < sipa> ah right, it's when it's *full*, not just when it's non-empty
10:44 < phantomcircuit> sipa, we still do eager sending
10:45 -!- Guest19314 [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has quit [Ping timeout: 264 seconds]
10:45 < sipa> oh, right!
10:45 < sipa> seems i'm out of touch with the network logic
10:45 < phantomcircuit> indeed not calling recv() when the send buffer is full makes sense
10:45 < sipa> it's called optimistic send
10:45 < phantomcircuit> but currently we dont call it unless it's empty
10:46 < phantomcircuit> which doesn't seem to make sense
10:46 < sipa> gmaxwell: ah, there's a distinction between not calling recv when the send buffer is full, and not processing messages in the recv buffer when the send buffer is full
10:46 < phantomcircuit> otoh we disconnect peers when either buffer is full iirc
10:48 < sipa> phantomcircuit: glad to have someone look at this stuff again
10:49 < phantomcircuit> it seems like we're probably just wasting time not processing stuff when we have an asymetric connection
10:50 -!- Krellan [~Krellan@2601:640:4000:9258:70f7:e790:7f06:4250] has quit [Ping timeout: 276 seconds]
10:50 < phantomcircuit> (and making the logic here way more complicted than it needs to be)
10:50 -!- michaelfolkson [~textual@82-132-223-219.dab.02.net] has joined #bitcoin-core-dev
10:51 < sipa> phantomcircuit: i think we should (a) always listen for receives unless the recc buffer is full (b) always process messages in the recv buffer unless the send buffer is full
10:51 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has joined #bitcoin-core-dev
10:51 < sipa> (where full means over threshold, not just nonempty)
10:52 < gmaxwell> what sipa says
10:52 -!- schmidty is now known as Guest18904
10:52 < gmaxwell> we can't process a recv message if the send is actually full, since virtually all recieves msg will require us to send.
10:53 -!- Krellan [~Krellan@2601:640:4000:9258:70f7:e790:7f06:4250] has joined #bitcoin-core-dev
10:53 -!- michaelfolkson [~textual@82-132-223-219.dab.02.net] has quit [Client Quit]
10:54 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
10:56 -!- michaelfolkson [~textual@82-132-223-219.dab.02.net] has joined #bitcoin-core-dev
10:57 < phantomcircuit> gmaxwell, but we disconnect peers when we're actually full right?
10:58 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
10:59 < sipa> phantomcircuit: i think we shouldn't
10:59 < sipa> and i think it's also very hard currently to trigger that logic
11:02 -!- michaelfolkson [~textual@82-132-223-219.dab.02.net] has quit [Quit: Sleep mode]
11:03 < gwillen>   
11:03 < phantomcircuit> sipa, i think it's basically impossible because of the select logic
11:06 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
11:08 -!- michaelfolkson [~textual@82-132-223-219.dab.02.net] has joined #bitcoin-core-dev
11:09 -!- michaelfolkson [~textual@82-132-223-219.dab.02.net] has quit [Client Quit]
11:10 -!- SopaXorzTaker [~SopaXorzT@unaffiliated/sopaxorztaker] has quit [Quit: Leaving]
11:13 < phantomcircuit> sipa, you'd need to fill the queue with inv messages i think
11:13 < phantomcircuit> which is pretty unlikely unless the remote is actually gone
11:15 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!]
11:17 < phantomcircuit> BlueMatt, MATTTT
11:17 -!- Zorbak [b9f4d586@gateway/web/freenode/ip.185.244.213.134] has joined #bitcoin-core-dev
11:19 < phantomcircuit> part of the issue is that the send queue is relatively small (for good reason) versus the largest possible message
11:19 < phantomcircuit> asking for even a single block could potentially be most of the queue iirc
11:19 < gmaxwell> well for not that good a reason, :P
11:20 < sipa> i think the logic should be "the send buffer can contain one message worth in excess of the limit"
11:20 < phantomcircuit> gmaxwell, if it's too small then it's a dos risk
11:21 < phantomcircuit> it could be shared but that's the same thing
11:22 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]
11:23 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
11:25 < gmaxwell> phantomcircuit: there are more options than that... e.g. every peer could be allowed to buffer one message on its own, plus access to one of a couple shared queues.
11:25 < gmaxwell> just maing a point that we don't have to have really small send buffers.
11:35 -!- Zorbak [b9f4d586@gateway/web/freenode/ip.185.244.213.134] has quit [Quit: Page closed]
11:35 -!- Krellan [~Krellan@2601:640:4000:9258:70f7:e790:7f06:4250] has quit [Remote host closed the connection]
11:36 < phantomcircuit> gmaxwell, hmm
11:36 < phantomcircuit> we have sort of two classes of traffic really
11:37 < phantomcircuit> theres (vaguely) broadcast traffic and there's req/res type traffic
11:37 < phantomcircuit> which have different priority really
11:42 < phantomcircuit> actually iono
11:52 -!- Guest18904 [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has quit [Changing host]
11:52 -!- Guest18904 [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
11:52 -!- Guest18904 is now known as schmidty
11:55 -!- bitconner [~conner@136.24.75.121] has joined #bitcoin-core-dev
11:56 -!- csknk [~csknk@unaffiliated/csknk] has joined #bitcoin-core-dev
12:03 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.]
12:15 -!- belcher_ [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
12:18 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 252 seconds]
12:24 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
12:30 -!- ken2812221_ [~ken281222@110.50.135.178] has quit [Ping timeout: 240 seconds]
12:33 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
12:34 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
12:34 -!- csknk [~csknk@unaffiliated/csknk] has quit [Quit: leaving]
12:38 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]
12:39 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-brjlrtnwcxdpouxt] has joined #bitcoin-core-dev
12:39 < bitcoin-git> [bitcoin] practicalswift closed pull request #12984: logs: Make the columns in subsequent UpdateTip log entries horizontally aligned (master...attention-to-detail) https://github.com/bitcoin/bitcoin/pull/12984
12:39 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-brjlrtnwcxdpouxt] has left #bitcoin-core-dev []
12:40 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-rwmpuckplslgourt] has joined #bitcoin-core-dev
12:40 < bitcoin-git> [bitcoin] practicalswift closed pull request #13766: Prefer initialization to assignment in constructors. Prefer in-class initializers to member initializers in constructors for constant initializers. (master...initialize-members-in-initialization-list) https://github.com/bitcoin/bitcoin/pull/13766
12:40 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-rwmpuckplslgourt] has left #bitcoin-core-dev []
12:41 -!- bralyclow [~bralyclow@195.242.213.119] has quit [Remote host closed the connection]
12:43 -!- bralyclow [~bralyclow@195.242.213.119] has joined #bitcoin-core-dev
12:45 -!- ponyo [05e28bae@gateway/web/freenode/ip.5.226.139.174] has joined #bitcoin-core-dev
12:48 -!- qrestlove [~qrestlove@2605:6000:eb4a:ef00:43b:bedc:dcd:92c3] has quit [Ping timeout: 250 seconds]
12:52 -!- ponyo [05e28bae@gateway/web/freenode/ip.5.226.139.174] has quit [Ping timeout: 256 seconds]
12:54 -!- klot_ [~klot@188.113.48.142] has quit [Read error: Connection reset by peer]
12:59 -!- ExtraCrispy [~ExtraCris@gateway/tor-sasl/extracrispy] has quit [Remote host closed the connection]
13:01 -!- qrestlove [~qrestlove@2605:6000:eb4a:ef00:f2de:f1ff:fe01:2ec2] has joined #bitcoin-core-dev
13:03 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
13:13 -!- molz [~molly@unaffiliated/molly] has quit [Quit: ZNC 1.7.0 - https://znc.in]
13:35 -!- molz [~molly@unaffiliated/molly] has joined #bitcoin-core-dev
13:35 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
13:43 -!- iphelix [~iphelix@unaffiliated/iphelix] has quit [Quit: Goodbye]
13:47 -!- iphelix [~iphelix@iphelix.powered.by.lunarbnc.net] has joined #bitcoin-core-dev
13:47 -!- iphelix is now known as Guest37734
13:48 -!- Guest37734 [~iphelix@iphelix.powered.by.lunarbnc.net] has quit [Client Quit]
13:52 -!- iphelix- [~iphelix@iphelix.powered.by.lunarbnc.net] has joined #bitcoin-core-dev
14:00 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection]
14:00 -!- hebasto_ [~hebasto@95.164.65.194] has joined #bitcoin-core-dev
14:07 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Ping timeout: 252 seconds]
14:10 -!- hebasto__ [~hebasto@95.164.65.194] has joined #bitcoin-core-dev
14:10 -!- hebasto_ [~hebasto@95.164.65.194] has quit [Remote host closed the connection]
14:10 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev
14:11 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]
14:12 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
14:19 -!- hebasto_ [~hebasto@95.164.65.194] has joined #bitcoin-core-dev
14:19 -!- hebasto__ [~hebasto@95.164.65.194] has quit [Remote host closed the connection]
14:26 -!- michaelfolkson [~textual@85.211.226.228] has joined #bitcoin-core-dev
14:27 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-dcsanzflzgefeltz] has joined #bitcoin-core-dev
14:27 < bitcoin-git> [bitcoin] instagibbs opened pull request #14543: [QA] minor p2p_sendheaders fix of height in coinbase (master...p2p_sendheaders_height) https://github.com/bitcoin/bitcoin/pull/14543
14:27 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-dcsanzflzgefeltz] has left #bitcoin-core-dev []
14:37 -!- OzPac [~OzPac@cpc110789-lewi20-2-0-cust636.2-4.cable.virginm.net] has quit [Quit: OzPac]
14:37 -!- iphelix- is now known as iphelix
14:38 -!- iphelix is now known as Guest74867
14:42 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.2]
14:58 -!- michaelfolkson [~textual@85.211.226.228] has quit [Quit: Textual IRC Client: www.textualapp.com]
15:00 -!- michaelfolkson [~textual@85.211.226.228] has joined #bitcoin-core-dev
15:12 -!- michaelfolkson [~textual@85.211.226.228] has quit [Quit: Sleep mode]
15:14 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection]
15:15 -!- michaelfolkson [~textual@85.211.226.228] has joined #bitcoin-core-dev
15:19 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
15:23 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-tsgekxvalrgtlarn] has joined #bitcoin-core-dev
15:23 < bitcoin-git> [bitcoin] sipa pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/5c25409d6851...0a8f519a0626
15:23 < bitcoin-git> bitcoin/master 2c6281f Pieter Wuille: Add key origin support to descriptors
15:23 < bitcoin-git> bitcoin/master ff37459 Pieter Wuille: Add tests for key origin support
15:23 < bitcoin-git> bitcoin/master 8afb166 Pieter Wuille: Update documentation to incude origin information
15:23 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-tsgekxvalrgtlarn] has left #bitcoin-core-dev []
15:24 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-pziazcviglamprpx] has joined #bitcoin-core-dev
15:24 < bitcoin-git> [bitcoin] sipa closed pull request #14150: Add key origin support to descriptors (master...201807_minedesc_origin) https://github.com/bitcoin/bitcoin/pull/14150
15:24 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-pziazcviglamprpx] has left #bitcoin-core-dev []
15:30 -!- michaelfolkson [~textual@85.211.226.228] has quit [Quit: Textual IRC Client: www.textualapp.com]
15:30 -!- michaelfolkson [~textual@85.211.226.228] has joined #bitcoin-core-dev
15:31 -!- michaelfolkson [~textual@85.211.226.228] has quit [Client Quit]
15:32 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
15:33 -!- laurentmt [~Thunderbi@185.242.6.5] has joined #bitcoin-core-dev
15:51 -!- jarthur [~jarthur@207.114.244.5] has quit []
15:51 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev
16:00 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Read error: Connection reset by peer]
16:01 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
16:29 -!- laurentmt [~Thunderbi@185.242.6.5] has quit [Quit: laurentmt]
16:29 -!- anonkun [9e45a0b2@gateway/web/freenode/ip.158.69.160.178] has joined #bitcoin-core-dev
16:33 -!- anonkun [9e45a0b2@gateway/web/freenode/ip.158.69.160.178] has quit [Quit: Page closed]
16:49 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Ping timeout: 272 seconds]
16:54 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit []
17:17 -!- hebasto_ [~hebasto@95.164.65.194] has quit [Remote host closed the connection]
17:18 -!- hebasto_ [~hebasto@95.164.65.194] has joined #bitcoin-core-dev
17:37 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-pdsvkzpftcqlwyuu] has joined #bitcoin-core-dev
17:37 < bitcoin-git> [bitcoin] charlesrocket closed pull request #14539: add Apple SDK download to gitian-build.py (master...gitian-build-sdk) https://github.com/bitcoin/bitcoin/pull/14539
17:37 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-pdsvkzpftcqlwyuu] has left #bitcoin-core-dev []
17:40 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
17:51 -!- ken2812221 [~ken281222@110.50.135.178] has joined #bitcoin-core-dev
18:01 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection]
18:02 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev
18:13 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
18:17 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
18:21 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
18:27 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
18:30 -!- cubancorona [cubancoron@gateway/vpn/privateinternetaccess/cubancorona] has joined #bitcoin-core-dev
18:30 -!- cubancorona [cubancoron@gateway/vpn/privateinternetaccess/cubancorona] has quit [Client Quit]
18:32 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection]
18:32 -!- Randolf [~randolf@96.53.47.38] has joined #bitcoin-core-dev
18:34 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Read error: Connection reset by peer]
18:34 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
18:43 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-wcwvnaiwoihgphod] has joined #bitcoin-core-dev
18:43 < bitcoin-git> [bitcoin] sipa pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0a8f519a0626...b3f377daaa86
18:43 < bitcoin-git> bitcoin/master 5918204 Martin Erlandsson: Removed explicit mention of storage requirement (squashed)...
18:43 < bitcoin-git> bitcoin/master b3f377d Pieter Wuille: Merge #14511: doc: Remove explicit storage requirement from README.md...
18:43 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-wcwvnaiwoihgphod] has left #bitcoin-core-dev []
18:44 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-jopwqxufhcnxldcj] has joined #bitcoin-core-dev
18:44 < bitcoin-git> [bitcoin] sipa closed pull request #14511: doc: Remove explicit storage requirement from README.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/14511
18:44 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-jopwqxufhcnxldcj] has left #bitcoin-core-dev []
19:05 -!- mr_paz [~mr_paz@c-71-57-73-68.hsd1.il.comcast.net] has joined #bitcoin-core-dev
19:25 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.]
19:33 -!- ken2812221 [~ken281222@110.50.135.178] has quit [Ping timeout: 272 seconds]
19:33 -!- sanket1729_ [62d49a0a@gateway/web/freenode/ip.98.212.154.10] has joined #bitcoin-core-dev
19:37 -!- sanket1729_ [62d49a0a@gateway/web/freenode/ip.98.212.154.10] has quit [Client Quit]
20:00 < sipa> status.github.com reports everything operating normally again, since 4 hours ago
20:00 < sipa> the whole incident lasted 23h54m ...
20:12 -!- spinza [~spin@155.93.246.187] has quit [Ping timeout: 252 seconds]
20:17 -!- Guest74867 is now known as iphelix
20:17 -!- iphelix [~iphelix@iphelix.powered.by.lunarbnc.net] has quit [Changing host]
20:17 -!- iphelix [~iphelix@unaffiliated/iphelix] has joined #bitcoin-core-dev
20:26 < meshcollider> Ouch
20:40 -!- Randolf [~randolf@96.53.47.38] has quit [Ping timeout: 240 seconds]
20:41 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev
20:53 -!- schnerchi [~schnerchi@p3EE1C27D.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
20:56 -!- schnerch_ [~schnerchi@p3EE1C69B.dip0.t-ipconnect.de] has quit [Ping timeout: 272 seconds]
21:16 -!- sanket1729 [62d49a0a@gateway/web/freenode/ip.98.212.154.10] has joined #bitcoin-core-dev
21:19 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
21:26 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
21:31 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 244 seconds]
21:55 -!- Tralfaz [~none@185.156.175.59] has quit [Quit: Leaving]
21:58 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-imkjhdoutxydttnn] has joined #bitcoin-core-dev
21:58 < bitcoin-git> [bitcoin] preserveddarnell opened pull request #14547: Update README.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/14547
21:58 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-imkjhdoutxydttnn] has left #bitcoin-core-dev []
22:01 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-nlpazbzeiowamlfm] has joined #bitcoin-core-dev
22:01 < bitcoin-git> [bitcoin] fanquake closed pull request #14547: Update README.md (master...patch-1) https://github.com/bitcoin/bitcoin/pull/14547
22:01 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-nlpazbzeiowamlfm] has left #bitcoin-core-dev []
22:05 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-unpywedbgqxrtfnn] has joined #bitcoin-core-dev
22:05 < bitcoin-git> [bitcoin] preserveddarnell opened pull request #14549: Update README.md (master...patch-2) https://github.com/bitcoin/bitcoin/pull/14549
22:05 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-unpywedbgqxrtfnn] has left #bitcoin-core-dev []
22:22 -!- bitconner [~conner@136.24.75.121] has quit [Ping timeout: 264 seconds]
22:49 -!- Tralfaz [~none@185.156.175.59] has joined #bitcoin-core-dev
22:57 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
22:57 -!- Tralfaz [~none@185.156.175.59] has quit [Quit: Leaving]
23:00 -!- Tralfaz [~none@185.156.175.59] has joined #bitcoin-core-dev
23:08 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection]
23:09 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev
23:32 -!- panako [uid322619@gateway/web/irccloud.com/x-wyxuxiadndxcdgbe] has joined #bitcoin-core-dev
23:40 -!- martinus__ [53a499e2@gateway/web/freenode/ip.83.164.153.226] has joined #bitcoin-core-dev
23:40 -!- martinus__ [53a499e2@gateway/web/freenode/ip.83.164.153.226] has quit [Client Quit]
23:44 -!- martinus_ [53a499e2@gateway/web/freenode/ip.83.164.153.226] has quit [Ping timeout: 256 seconds]
23:46 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
23:56 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
23:58 -!- josephnicholas [~josephnic@110.54.242.207] has joined #bitcoin-core-dev
--- Log closed Tue Oct 23 00:00:45 2018