--- Log opened Wed Oct 24 00:00:46 2018 00:03 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 00:06 -!- setpill [~setpill@unaffiliated/setpill] has quit [Client Quit] 00:06 -!- TheRec [~toto@84-72-172-174.dclient.hispeed.ch] has joined #bitcoin-core-dev 00:06 -!- TheRec [~toto@84-72-172-174.dclient.hispeed.ch] has quit [Changing host] 00:06 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev 00:07 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 00:09 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 00:09 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 00:13 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-qvisgmtxioytbtcl] has joined #bitcoin-core-dev 00:13 < bitcoin-git> [bitcoin] ken2812221 opened pull request #14559: appveyor: Enable multiwallet tests (master...appveyor-test-multiwallet) https://github.com/bitcoin/bitcoin/pull/14559 00:13 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-qvisgmtxioytbtcl] has left #bitcoin-core-dev [] 00:13 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 240 seconds] 01:09 -!- panako [uid322619@gateway/web/irccloud.com/x-koyrushfcvylimdo] has joined #bitcoin-core-dev 01:13 -!- martinus_ [53a499e2@gateway/web/freenode/ip.83.164.153.226] has joined #bitcoin-core-dev 01:28 -!- jungly [~quassel@host97-200-static.8-79-b.business.telecomitalia.it] has joined #bitcoin-core-dev 01:38 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 01:41 < promag> ken2812221: I don't understand what you mean here https://github.com/bitcoin/bitcoin/pull/14552#issuecomment-432409103 01:58 < ken2812221> Sorry, my English is not good. I'll try to explain. 01:59 < promag> I have the same problem :P but I don't understand the lazy part 02:00 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 02:03 < ken2812221> @promag Can you take a look again? 02:03 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ydzphsvssyvcwgfd] has joined #bitcoin-core-dev 02:03 < bitcoin-git> [bitcoin] MarcoFalke pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/5473e255f687...e895fdc9fc83 02:03 < bitcoin-git> bitcoin/master 1c7e25d practicalswift: wallet: Add missing locks 02:03 < bitcoin-git> bitcoin/master dee4292 practicalswift: wallet: Add Clang thread safety analysis annotations 02:03 < bitcoin-git> bitcoin/master 37b2538 practicalswift: Add GUARDED_BY(cs_wallet) for encrypted_batch, nWalletMaxVersion, m_max_keypool_index and nOrderPosNext... 02:03 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ydzphsvssyvcwgfd] has left #bitcoin-core-dev [] 02:03 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ofjbbqvqxzwruhcu] has joined #bitcoin-core-dev 02:03 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #11634: wallet: Add missing cs_wallet/cs_KeyStore locks to wallet (master...missing-wallet-locks) https://github.com/bitcoin/bitcoin/pull/11634 02:03 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ofjbbqvqxzwruhcu] has left #bitcoin-core-dev [] 02:04 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 250 seconds] 02:11 < promag> ken2812221: ah now I understand :) ty 02:13 < promag> ken2812221: I wonder if it's still possible to abstract "wallet.dat" in db.{cpp,h} 02:23 < ken2812221> Maybe we should add add m_file in CWallet? 02:25 < ken2812221> To store the exact wallet filename. Then we can get rid of all "wallet.dat" in db.{cpp,h} hopefully. 02:34 < promag> FWIW in #14350, I was planning to add WalletLocation::GetEnvironmentPath and WalletLocation::GetDatabasePath 02:34 < gribble> https://github.com/bitcoin/bitcoin/issues/14350 | Add WalletLocation class by promag · Pull Request #14350 · bitcoin/bitcoin · GitHub 02:41 -!- Mutter [~Mutter@37.120.155.2] has joined #bitcoin-core-dev 02:43 -!- Mutter [~Mutter@37.120.155.2] has quit [Client Quit] 02:43 < promag> ken2812221: should we support -wallet=sub/w5 in windows? 02:44 < ken2812221> It's a valid path on Windows, but it is equal to sub\w5 02:45 < promag> so in listwallets we honor the supplied value 02:47 < wumpus> sounds like a no-brainer to have the wallet object know its own filename 02:47 < promag> wumpus: you mean the database file path? 02:47 < wumpus> even if it is only or display/UI purposes 02:48 < wumpus> yes, whatever the particular database has as a concept of database idenitifier I guess 02:48 < wumpus> I mean the user needs to be able to tell databases apart from it, that's the point 02:53 < promag> ken2812221: wumpus: BTW you could review #14531 02:53 < gribble> https://github.com/bitcoin/bitcoin/issues/14531 | Replace fs::relative call with custom GetRelativePath by promag · Pull Request #14531 · bitcoin/bitcoin · GitHub 02:53 < wumpus> yess I will thanks 02:55 < wumpus> ohh you added a unit test great 02:56 -!- iphelix [~iphelix@unaffiliated/iphelix] has quit [Read error: Connection reset by peer] 02:57 -!- iphelix [~iphelix@iphelix.powered.by.lunarbnc.net] has joined #bitcoin-core-dev 02:58 -!- iphelix is now known as Guest11672 03:02 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 03:05 < promag> wumpus: yes let me know if it can be improved 03:05 -!- martinus_ [53a499e2@gateway/web/freenode/ip.83.164.153.226] has quit [Ping timeout: 256 seconds] 03:07 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 03:13 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-yudzuqsczvxxswma] has joined #bitcoin-core-dev 03:13 < bitcoin-git> [bitcoin] practicalswift opened pull request #14560: wallet: Avoid calling uiInterface.LoadWallet(...) with cs_wallet held (master...uiInterface.LoadWallet-without-cs_wallet) https://github.com/bitcoin/bitcoin/pull/14560 03:13 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-yudzuqsczvxxswma] has left #bitcoin-core-dev [] 03:13 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 264 seconds] 03:15 -!- Mutter [~Mutter@37.120.155.10] has joined #bitcoin-core-dev 03:16 -!- OzPac [~OzPac@cpc110789-lewi20-2-0-cust636.2-4.cable.virginm.net] has joined #bitcoin-core-dev 03:19 -!- panako [uid322619@gateway/web/irccloud.com/x-koyrushfcvylimdo] has quit [Quit: Connection closed for inactivity] 03:22 < promag> ken2812221: I'll rebase mine on #14559 instead 03:22 < gribble> https://github.com/bitcoin/bitcoin/issues/14559 | appveyor: Enable multiwallet tests by ken2812221 · Pull Request #14559 · bitcoin/bitcoin · GitHub 03:22 -!- Mutter [~Mutter@37.120.155.10] has quit [Quit: Mutter: www.mutterirc.com] 03:23 -!- michaelfolkson [~textual@host86-170-183-225.range86-170.btcentralplus.com] has joined #bitcoin-core-dev 03:24 -!- Mutter [~Mutter@37.120.155.10] has joined #bitcoin-core-dev 03:24 -!- Mutter [~Mutter@37.120.155.10] has quit [Client Quit] 03:24 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:26 -!- michaelfolkson [~textual@host86-170-183-225.range86-170.btcentralplus.com] has quit [Client Quit] 03:39 < ken2812221> promag: Thank you 03:39 < promag> wumpus: sorry going to force push 14531 because of rebase 03:42 < ken2812221> promag: Better to make sure that all folders used in 14531 are exist. 03:42 < ken2812221> I mean in unit test 03:42 < promag> ken2812221: why? 03:43 < promag> shouldn't hit the filesystem? 03:49 < ken2812221> It would actually open files and compare file descriptor. 03:50 < ken2812221> It's using temp folder, so it would not hurt. 03:50 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Read error: Connection reset by peer] 03:50 < ken2812221> https://github.com/boostorg/filesystem/blob/develop/src/operations.cpp#L1186 03:52 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:52 < promag> hmm 03:53 < promag> ken2812221: is it too bad to just remove the substr(0, base.size()) from the absolute path? 03:54 -!- dqx_ [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev 03:54 -!- dqx_ [~dqx@unaffiliated/dqx] has quit [Remote host closed the connection] 03:55 < promag> ken2812221: what is the best way to convert fs::path to string? 04:00 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 04:00 < ken2812221> promag: Does substr(0, base.size()) work on case insensitive filesystem? 04:01 < ken2812221> .string()? 04:06 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 264 seconds] 04:17 -!- michaelfolkson [~textual@host86-170-183-225.range86-170.btcentralplus.com] has joined #bitcoin-core-dev 04:23 -!- hebasto_ [~hebasto@95.164.65.194] has joined #bitcoin-core-dev 04:23 -!- hebasto [~hebasto@95.164.65.194] has quit [Ping timeout: 252 seconds] 04:30 -!- laurentmt [~Thunderbi@185.242.6.5] has joined #bitcoin-core-dev 04:30 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-xnbypamdeasqszeb] has joined #bitcoin-core-dev 04:30 < bitcoin-git> [bitcoin] promag opened pull request #14561: Remove fs::relative call and fix listwalletdir tests (master...2018-10-fix-listwalletdir) https://github.com/bitcoin/bitcoin/pull/14561 04:30 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-xnbypamdeasqszeb] has left #bitcoin-core-dev [] 04:31 < promag> ken2812221: please take a look at https://github.com/bitcoin/bitcoin/pull/14561/commits/be120e35d15220c65a08583ff774bb324ffe7fb4 04:33 < promag> ken2812221: instead of adding a generic GetRelativePath (just because we have to support boost 1.47), and since we need the relative path in the recursive_directory_iterator loop, I've removed the walletdir there 04:39 -!- michaelfolkson [~textual@host86-170-183-225.range86-170.btcentralplus.com] has quit [Quit: Sleep mode] 04:41 -!- michaelfolkson [~textual@host86-170-183-225.range86-170.btcentralplus.com] has joined #bitcoin-core-dev 04:47 -!- michaelfolkson [~textual@host86-170-183-225.range86-170.btcentralplus.com] has quit [Quit: Sleep mode] 04:50 -!- laurentmt [~Thunderbi@185.242.6.5] has quit [Quit: laurentmt] 04:53 -!- michaelfolkson [~textual@host86-170-183-225.range86-170.btcentralplus.com] has joined #bitcoin-core-dev 04:56 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 05:03 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-jjrznyxjmeusiqgo] has joined #bitcoin-core-dev 05:03 < bitcoin-git> [bitcoin] practicalswift closed pull request #14560: wallet: Avoid calling uiInterface.LoadWallet(...) with cs_wallet held (master...uiInterface.LoadWallet-without-cs_wallet) https://github.com/bitcoin/bitcoin/pull/14560 05:03 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-jjrznyxjmeusiqgo] has left #bitcoin-core-dev [] 05:11 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-dnmkibbbortfuels] has joined #bitcoin-core-dev 05:11 < bitcoin-git> [bitcoin] MarcoFalke pushed 9 new commits to master: https://github.com/bitcoin/bitcoin/compare/e895fdc9fc83...9dda5fdf64ca 05:11 < bitcoin-git> bitcoin/master 67d7d67 John Newbery: [test] Fix flake8 warnings in tests... 05:11 < bitcoin-git> bitcoin/master bdefc97 John Newbery: [tests] Remove deprecated addwitnessaddress call from feature_nulldummy... 05:11 < bitcoin-git> bitcoin/master 3cf77f0 John Newbery: [tests] Remove deprecated addwitnessaddress call from wallet_dump.py... 05:11 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-dnmkibbbortfuels] has left #bitcoin-core-dev [] 05:12 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-lpvpenzwkmubjgbe] has joined #bitcoin-core-dev 05:12 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #14296: [wallet] Remove addwitnessaddress (master...remove_addwitnessaddress) https://github.com/bitcoin/bitcoin/pull/14296 05:12 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-lpvpenzwkmubjgbe] has left #bitcoin-core-dev [] 05:24 -!- IGHOR [~quassel@93.178.216.72] has quit [Ping timeout: 240 seconds] 05:32 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-hjeafplsebdailrn] has joined #bitcoin-core-dev 05:32 < bitcoin-git> [bitcoin] karel-3d closed pull request #14502: Rpc help helper class (master...rpc_helper_class) https://github.com/bitcoin/bitcoin/pull/14502 05:32 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-hjeafplsebdailrn] has left #bitcoin-core-dev [] 05:45 -!- dqx [~dqx@unaffiliated/dqx] has quit [Quit: Lost terminal] 05:47 -!- michaelfolkson [~textual@host86-170-183-225.range86-170.btcentralplus.com] has quit [Quit: Sleep mode] 05:51 -!- ap4lmtree [~ap4lmtree@unaffiliated/ap4lmtree] has quit [Remote host closed the connection] 05:55 -!- ap4lmtree [~ap4lmtree@unaffiliated/ap4lmtree] has joined #bitcoin-core-dev 06:02 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 06:07 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 244 seconds] 06:16 -!- Krellan [~Krellan@2600:1700:be50:323f:55b0:5cb9:8203:6ae5] has quit [Read error: Connection reset by peer] 06:17 -!- Krellan [~Krellan@2600:1700:be50:323f:55b0:5cb9:8203:6ae5] has joined #bitcoin-core-dev 06:20 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev 06:21 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ibbzifinzievrxtd] has joined #bitcoin-core-dev 06:21 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/9dda5fdf64ca...2e15fa16cd3b 06:21 < bitcoin-git> bitcoin/master 585b47c João Barbosa: rpc: Prevent concurrent savemempool 06:21 < bitcoin-git> bitcoin/master 2e15fa1 Wladimir J. van der Laan: Merge #12842: Prevent concurrent savemempool... 06:21 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ibbzifinzievrxtd] has left #bitcoin-core-dev [] 06:21 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-bovbjrplxecthxln] has joined #bitcoin-core-dev 06:21 < bitcoin-git> [bitcoin] laanwj closed pull request #12842: Prevent concurrent savemempool (master...2018-03-concurrent-savemempool) https://github.com/bitcoin/bitcoin/pull/12842 06:21 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-bovbjrplxecthxln] has left #bitcoin-core-dev [] 06:29 < wumpus> loool https://github.com/bitcoin/bitcoin/pull/14504#issuecomment-431169025 apparently a spinner makes for a "boring user experience" of the tests, happy that running the tests is so exciting now 06:30 -!- Randolf [~randolf@96.53.47.42] has quit [Quit: Leaving] 06:36 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 06:41 < sipa> wumpus: development goals :) 06:42 < promag> so much excitement 06:42 < sipa> wow 06:42 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 06:50 < wumpus> :D 06:50 < promag> merge_queue.push(#14453) 06:50 < gribble> https://github.com/bitcoin/bitcoin/issues/14453 | rpc: Fix wallet unload during walletpassphrase timeout by promag · Pull Request #14453 · bitcoin/bitcoin · GitHub 07:08 -!- nodweber [~nodweber@unaffiliated/nodweber] has quit [Ping timeout: 272 seconds] 07:08 -!- thib [~thib@wikimedia/Thibaut120094] has quit [Ping timeout: 272 seconds] 07:09 -!- thib [~thib@wikimedia/Thibaut120094] has joined #bitcoin-core-dev 07:09 -!- nodweber [~nodweber@unaffiliated/nodweber] has joined #bitcoin-core-dev 07:15 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Quit: Leaving] 07:16 -!- Mutter [~Mutter@pool-74-96-248-115.washdc.fios.verizon.net] has joined #bitcoin-core-dev 07:17 -!- Mutter [~Mutter@pool-74-96-248-115.washdc.fios.verizon.net] has quit [Client Quit] 07:18 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-wiintdccgjkdlcyk] has joined #bitcoin-core-dev 07:18 < bitcoin-git> [bitcoin] promag closed pull request #14531: Replace fs::relative call with custom GetRelativePath (master...2018-10-getrelativepath) https://github.com/bitcoin/bitcoin/pull/14531 07:18 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-wiintdccgjkdlcyk] has left #bitcoin-core-dev [] 07:23 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev 07:30 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-nrnglbdivorgmzma] has joined #bitcoin-core-dev 07:30 < bitcoin-git> [bitcoin] laanwj pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/2e15fa16cd3b...9886590116b1 07:30 < bitcoin-git> bitcoin/master 9dcf6c0 Wladimir J. van der Laan: build: Add --disable-bip70 configure option... 07:30 < bitcoin-git> bitcoin/master 38b9850 Wladimir J. van der Laan: qt: cleanup: Move BIP70 functions together in paymentserver... 07:30 < bitcoin-git> bitcoin/master fbb643d James Hilliard: Add BIP70 deprecation warning 07:30 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-nrnglbdivorgmzma] has left #bitcoin-core-dev [] 07:31 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 07:31 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-kxcosajemsbafjgc] has joined #bitcoin-core-dev 07:31 < bitcoin-git> [bitcoin] laanwj closed pull request #14451: Add BIP70 deprecation warning and allow building GUI without BIP70 support (master...deprecate-bip70) https://github.com/bitcoin/bitcoin/pull/14451 07:31 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-kxcosajemsbafjgc] has left #bitcoin-core-dev [] 07:34 < fanquake> wumpus are we meant to be able to build bitcoin-qt without protobuf after #14451? 07:34 < gribble> https://github.com/bitcoin/bitcoin/issues/14451 | Add BIP70 deprecation warning and allow building GUI without BIP70 support by jameshilliard · Pull Request #14451 · bitcoin/bitcoin · GitHub 07:35 < fanquake> I'm unable to, and commented about 30s to late.. Although might be misunderstanding. 07:37 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev 07:40 < fanquake> np, cleared up by Marco 07:40 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [] 07:41 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 07:43 < luke-jr> not building bitcoin-qt seems a bit extreme though; might make sense to refactor configure to just change the bip70 option 07:44 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 252 seconds] 07:45 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-blbunsflxzrpvtgm] has joined #bitcoin-core-dev 07:45 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/9886590116b1...a74ed3a05b27 07:45 < bitcoin-git> bitcoin/master 321decf João Barbosa: rpc: Fix wallet unload during walletpassphrase timeout 07:45 < bitcoin-git> bitcoin/master 8907df9 João Barbosa: qa: Ensure wallet unload during walletpassphrase timeout 07:45 < bitcoin-git> bitcoin/master a74ed3a Wladimir J. van der Laan: Merge #14453: rpc: Fix wallet unload during walletpassphrase timeout... 07:45 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-blbunsflxzrpvtgm] has left #bitcoin-core-dev [] 07:45 < promag> ken2812221: https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/19758459 07:45 < promag> ken2812221: there's a bunch of `Error: Specified -walletdir "wallets" is a relative path` 07:46 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-yzfouddqshhctmfv] has joined #bitcoin-core-dev 07:46 < bitcoin-git> [bitcoin] laanwj closed pull request #14453: rpc: Fix wallet unload during walletpassphrase timeout (master...2018-10-unload-unlocked-wallet) https://github.com/bitcoin/bitcoin/pull/14453 07:46 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-yzfouddqshhctmfv] has left #bitcoin-core-dev [] 07:51 < ken2812221> promag: See https://github.com/bitcoin/bitcoin/pull/14146#issuecomment-421099412 07:54 < promag> thanks 07:55 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 268 seconds] 07:56 < promag> wumpus: sorry, could you replace 14531 with 14561 in HP? also 14350 should not be there. 08:02 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has quit [Read error: Connection reset by peer] 08:04 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has joined #bitcoin-core-dev 08:14 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 08:17 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-avfymchunhwsspfm] has joined #bitcoin-core-dev 08:17 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a74ed3a05b27...6241eb3224d9 08:17 < bitcoin-git> bitcoin/master 96c509e Isidoro Ghezzi: show the progress of functional test... 08:17 < bitcoin-git> bitcoin/master 6241eb3 MarcoFalke: Merge #14504: tests: show the progress of functional tests... 08:17 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-avfymchunhwsspfm] has left #bitcoin-core-dev [] 08:18 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 08:19 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-rpbhatztbybzsgvm] has joined #bitcoin-core-dev 08:19 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #14504: tests: show the progress of functional tests (master...functional_test_progress) https://github.com/bitcoin/bitcoin/pull/14504 08:19 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-rpbhatztbybzsgvm] has left #bitcoin-core-dev [] 08:26 -!- Krellan [~Krellan@2600:1700:be50:323f:55b0:5cb9:8203:6ae5] has quit [Read error: Connection reset by peer] 08:27 -!- Krellan [~Krellan@2600:1700:be50:323f:55b0:5cb9:8203:6ae5] has joined #bitcoin-core-dev 08:31 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 08:33 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 08:38 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ovvjxnvpwfgytdqu] has joined #bitcoin-core-dev 08:38 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/6241eb3224d9...2b88f67e0bcc 08:38 < bitcoin-git> bitcoin/master 2d796fa Chun Kuan Lee: wallet: Fix duplicate fileid 08:38 < bitcoin-git> bitcoin/master 4ea7732 Chun Kuan Lee: tests: add test case for loading copied wallet twice 08:38 < bitcoin-git> bitcoin/master 2b88f67 Wladimir J. van der Laan: Merge #14320: [bugfix] wallet: Fix duplicate fileid detection... 08:38 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ovvjxnvpwfgytdqu] has left #bitcoin-core-dev [] 08:39 -!- irc_viewer_test [irc_viewer@gateway/vpn/privateinternetaccess/ircviewertest/x-06412631] has joined #bitcoin-core-dev 08:39 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-cyifkftjxvjmeawc] has joined #bitcoin-core-dev 08:39 < bitcoin-git> [bitcoin] laanwj closed pull request #14320: [bugfix] wallet: Fix duplicate fileid detection (master...2018-09-25-wallet-duplicate-fileid-fix) https://github.com/bitcoin/bitcoin/pull/14320 08:39 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-cyifkftjxvjmeawc] has left #bitcoin-core-dev [] 08:41 -!- irc_viewer_test [irc_viewer@gateway/vpn/privateinternetaccess/ircviewertest/x-06412631] has quit [Client Quit] 08:53 -!- Guest11672 is now known as iphelix 08:53 -!- iphelix [~iphelix@iphelix.powered.by.lunarbnc.net] has quit [Changing host] 08:53 -!- iphelix [~iphelix@unaffiliated/iphelix] has joined #bitcoin-core-dev 08:57 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ybdjierzplgjfuov] has joined #bitcoin-core-dev 08:57 < bitcoin-git> [bitcoin] promag closed pull request #12929: Remove CWallet dependency from CWalletTx (master...2018-04-wallettx) https://github.com/bitcoin/bitcoin/pull/12929 08:57 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ybdjierzplgjfuov] has left #bitcoin-core-dev [] 08:59 < promag> wumpus: I'd like to have #13501 as soon as possible so it gets really tested by other pulls and travis/appveyor before 0.18 08:59 < gribble> https://github.com/bitcoin/bitcoin/issues/13501 | Correctly terminate HTTP server by promag · Pull Request #13501 · bitcoin/bitcoin · GitHub 09:03 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 09:03 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-diylydpftlmvsbog] has joined #bitcoin-core-dev 09:03 < bitcoin-git> [bitcoin] promag closed pull request #13637: wallet: Add GetBalances to calculate all balances (master...2018-06-wallet-getbalance) https://github.com/bitcoin/bitcoin/pull/13637 09:03 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-diylydpftlmvsbog] has left #bitcoin-core-dev [] 09:03 < wumpus> promag: I'm a bit scared of that one, let me see again 09:06 < promag> wumpus: thanks 09:09 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 264 seconds] 09:09 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 09:14 < wumpus> it's one of those things that have been 'fixed' too many times 09:15 < luke-jr> is there a reason we distribute tar.gz instead of tar.xz? 09:16 -!- jarthur [~jarthur@207.114.244.5] has quit [Remote host closed the connection] 09:17 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 09:28 -!- michaelfolkson [~textual@82-132-224-236.dab.02.net] has joined #bitcoin-core-dev 09:47 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 09:47 < luke-jr> is a 10 GB blockchain benchmark significant? 09:48 < luke-jr> or do I need to get real storage involved? 09:48 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 09:49 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds] 09:51 < gmaxwell> luke-jr: tar.xz is probably a PITA to open on windows/mac/openbsd. and who cares if the download is a couple MB bigger when the sync going to be 250GB... 09:55 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 10:06 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-yqxnwwghmgdpynhj] has joined #bitcoin-core-dev 10:06 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/2b88f67e0bcc...613fc95ee4ea 10:06 < bitcoin-git> bitcoin/master 4dca7d0 Chun Kuan Lee: appveyor: Enable multiwallet test 10:06 < bitcoin-git> bitcoin/master 613fc95 MarcoFalke: Merge #14559: appveyor: Enable multiwallet tests... 10:06 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-yqxnwwghmgdpynhj] has left #bitcoin-core-dev [] 10:07 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-txvuptueraitocvg] has joined #bitcoin-core-dev 10:07 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #14559: appveyor: Enable multiwallet tests (master...appveyor-test-multiwallet) https://github.com/bitcoin/bitcoin/pull/14559 10:07 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-txvuptueraitocvg] has left #bitcoin-core-dev [] 10:11 < luke-jr> gmaxwell: well, they're Linux binaries inside 10:11 < gmaxwell> there is also source inside. 10:12 -!- jungly [~quassel@host97-200-static.8-79-b.business.telecomitalia.it] has quit [Remote host closed the connection] 10:14 -!- michaelfolkson [~textual@82-132-224-236.dab.02.net] has quit [Quit: Sleep mode] 10:19 < luke-jr> a different tarball 10:20 < luke-jr> anyway, I see 2.2% performance gain over the first 10 GB of blocks using BlueMatt's POWER8 optimisation stuff (on binaries built for POWER7) 10:20 < luke-jr> is that significant? 10:20 * luke-jr has no idea why -mcpu=power7 performs better than -mcpu=power9 on POWER9.. 10:21 < sipa> there may be a larger benefit to larger blocks 10:22 < gmaxwell> luke-jr: the interesting question is did something break the speedup of sse4/avx over plain C. 10:23 < gmaxwell> The microbenchmark on that power8 optimized sha2 is a comparable speedup to sse4 on x86. 10:23 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-afuwbulcsxtvthcs] has joined #bitcoin-core-dev 10:23 < bitcoin-git> [bitcoin] Neeshmacpaul opened pull request #14562: Update CONTRIBUTING.md (master...master) https://github.com/bitcoin/bitcoin/pull/14562 10:23 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-afuwbulcsxtvthcs] has left #bitcoin-core-dev [] 10:23 < BlueMatt> luke-jr: yea, I closed it cause 2.2% is wayyyy lower than it should be based on the microbenchmar 10:23 < BlueMatt> k 10:23 < BlueMatt> it may be that it doesnt actually help cause the limit is cache or something like that 10:24 < gmaxwell> s/cache/malloc/ :P 10:24 < BlueMatt> yea..... 10:24 < BlueMatt> ffs 10:25 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-jeoclwylogjhqiji] has joined #bitcoin-core-dev 10:25 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #14562: Update CONTRIBUTING.md (master...master) https://github.com/bitcoin/bitcoin/pull/14562 10:25 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-jeoclwylogjhqiji] has left #bitcoin-core-dev [] 10:25 < luke-jr> well, even if there's another bottleneck, it probably helps free up CPU resources for other processes? 10:26 < BlueMatt> heh could try running ibd with some other cpu-but-not-memory-intensive process running on the same core on another thread and see if you see a difference lol 10:35 < luke-jr> hmm, interesting idea. 10:36 < gmaxwell> or just profile an figure out why its not speeding things up. :P 10:37 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 272 seconds] 10:38 -!- Krellan [~Krellan@2600:1700:be50:323f:55b0:5cb9:8203:6ae5] has quit [Read error: Connection reset by peer] 10:40 -!- Krellan [~Krellan@2600:1700:be50:323f:55b0:5cb9:8203:6ae5] has joined #bitcoin-core-dev 10:59 -!- michaelfolkson [~textual@82-132-224-236.dab.02.net] has joined #bitcoin-core-dev 11:13 -!- michaelfolkson [~textual@82-132-224-236.dab.02.net] has quit [Quit: Sleep mode] 11:18 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 11:19 -!- cubancorona [cubancoron@gateway/vpn/privateinternetaccess/cubancorona] has joined #bitcoin-core-dev 11:24 -!- satwo [~textual@c-73-58-177-197.hsd1.tn.comcast.net] has joined #bitcoin-core-dev 11:30 -!- cubancorona [cubancoron@gateway/vpn/privateinternetaccess/cubancorona] has quit [Quit: Leaving] 11:37 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 11:44 -!- gnusha_ [~gnusha@unaffiliated/kanzure/bot/gnusha] has joined #bitcoin-core-dev 11:44 -!- Topic for #bitcoin-core-dev: Bitcoin Core development discussion and commit log | This is the channel for developing Bitcoin Core. Feel free to watch, but please take commentary and usage questions to #bitcoin | Channel logs: https://botbot.me/freenode/bitcoin-core-dev, http://www.erisian.com.au/bitcoin-core-dev/, http://gnusha.org/bitcoin-core-dev/ 11:44 -!- Topic set by luke-jr [~luke-jr@unaffiliated/luke-jr] [Thu Jul 12 09:08:35 2018] 11:44 [Users #bitcoin-core-dev] 11:44 [ [b__b] ] [ Cory ] [ JackH ] [ murrayn ] [ sdaftuar_ ] 11:44 [ _flow_ ] [ cryptapus ] [ Jackielove4u ] [ nanotube ] [ Sentineo ] 11:44 [ a5m0 ] [ CubicEarth ] [ jamesob ] [ Nebraskka ] [ shesek ] 11:44 [ Aaronvan_ ] [ da2ce7_ ] [ jarthur ] [ nehan ] [ shinohai ] 11:44 [ achow101 ] [ davec ] [ Jbaczuk ] [ newbie-- ] [ Sinclair6 ] 11:44 [ adam3us ] [ dcousens ] [ jcorgan ] [ nickler ] [ sipa ] 11:44 [ adiabat ] [ dgenr8 ] [ jcorgan_ ] [ niftynei ] [ so ] 11:44 [ aj ] [ dlb76 ] [ jimpo ] [ niska ] [ Soligor ] 11:44 [ Anduck ] [ dongcarl ] [ jl2012 ] [ niska` ] [ spinza ] 11:44 [ andytosh1 ] [ DougieBot5000 ] [ jnewbery ] [ nodweber ] [ Squidicuz ] 11:44 [ andytoshi ] [ drexl ] [ jonasschnelli ] [ noganoo ] [ stevenroose ] 11:44 [ ap4lmtree ] [ e4xit ] [ jrayhawk ] [ nsh ] [ StopAndDecrypt ] 11:44 [ ap4lmtree- ] [ earlz ] [ justanotheruser] [ nullptr| ] [ sturles ] 11:44 [ Apocalyptic ] [ echeveria ] [ kabaum_ ] [ opdenkamp ] [ Taek ] 11:44 [ arubi ] [ echonaut ] [ kakobrekla ] [ ossifrage ] [ takinbo ] 11:44 [ asoltys ] [ echonaut14 ] [ kallewoof ] [ osue ] [ TD-Linux ] 11:44 [ atroxes ] [ elichai2 ] [ kanzure ] [ otoburb ] [ thaumavorio ] 11:44 [ baldur ] [ Emcy ] [ karelb ] [ owowo ] [ TheCharlatan ] 11:44 [ BashCo ] [ emzy ] [ ken2812221 ] [ OzPac ] [ TheHoliestRoger ] 11:44 [ BCBot ] [ esotericnonsense] [ keymone ] [ paracyst ] [ TheHoliestRoger_] 11:44 [ belcher_ ] [ frenchy ] [ kinlo ] [ PatBoy ] [ TheRec ] 11:44 [ berndj ] [ GAit ] [ Krellan ] [ petertodd ] [ thib ] 11:44 [ berndj-blackout] [ ghost43 ] [ Lauda ] [ phantomcircuit ] [ Tralfaz ] 11:44 [ BGL ] [ gleb ] [ laurentmt ] [ pierre_rochard ] [ treyzania ] 11:44 [ bitbee ] [ gmaxwell ] [ lesderid ] [ profmac ] [ tripleslash ] 11:44 [ BlueMatt ] [ gnusha ] [ lightningbot ] [ promag ] [ trotski2000 ] 11:44 [ booyah ] [ gnusha_ ] [ Lightsword ] [ provoostenator ] [ tryphe ] 11:44 [ bosma ] [ go1111111 ] [ lio17 ] [ qinfengling ] [ twistedline ] 11:44 [ bralyclow ] [ GoldenBear ] [ luke-jr ] [ qrestlove ] [ Varunram ] 11:44 [ brianhoffman ] [ gribble ] [ marcinja ] [ queip ] [ Victor_sueca ] 11:44 [ brianhoffman_ ] [ Guest77842 ] [ MarcoFalke ] [ rafalcpp ] [ victorSN ] 11:44 [ Bullit ] [ gwillen ] [ mariorz ] [ rev_strangehope] [ Victorsueca ] 11:44 [ ccook_ ] [ harding ] [ meshcollider ] [ rh0nj ] [ warren ] 11:44 [ cdecker ] [ harrigan ] [ michaelsdunn1 ] [ roasbeef ] [ waxwing ] 11:44 [ cfields ] [ harrymm ] [ michagogo ] [ rockhouse ] [ windsok ] 11:44 [ chainhead ] [ hebasto_ ] [ midnightmagic ] [ rodarmor ] [ wolfspraul ] 11:44 [ chjj ] [ helo ] [ molz ] [ RubenSomsen ] [ wpaulino ] 11:44 [ Chris_Stewart_5] [ hirish ] [ moneyball ] [ ryanofsky ] [ wraithm ] 11:44 [ cncr04s ] [ IGHOR ] [ morcos ] [ satwo ] [ wumpus ] 11:44 [ commavir ] [ infernix ] [ mr_burdell ] [ savil ] [ xHire ] 11:44 [ commavir_ ] [ instagibbs ] [ mr_paz_ ] [ schmidty ] [ z3231 ] 11:44 [ coolpup ] [ intcat ] [ mryandao ] [ schnerch_ ] [ Zenton ] 11:44 [ cornfeedhobo ] [ iphelix ] [ Murch ] [ sdaftuar ] [ zxzzt ] 11:44 -!- Irssi: #bitcoin-core-dev: Total of 215 nicks [0 ops, 0 halfops, 0 voices, 215 normal] 11:44 -!- Channel #bitcoin-core-dev created Mon Nov 17 07:08:12 2014 11:44 -!- gwollon [~gwillen@unaffiliated/gwillen] has joined #bitcoin-core-dev 11:45 -!- e4xit_ [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has joined #bitcoin-core-dev 11:45 -!- Irssi: Join to #bitcoin-core-dev was synced in 42 secs 11:46 -!- shinohai_ [btcinfo@gateway/shell/xshellz/x-bxirtqkltqbmpuwm] has joined #bitcoin-core-dev 11:46 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 11:47 -!- odk [~opdenkamp@D93F2BCF.cm-20.dynamic.ziggo.nl] has joined #bitcoin-core-dev 11:47 -!- ccook [~ccook@208.66.192.142] has joined #bitcoin-core-dev 11:47 -!- CubicEarth_ [~CubicEart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 11:48 -!- brianhoffman_ is now known as brianhoffman 11:49 -!- Netsplit *.net <-> *.split quits: jcorgan, andytoshi, keymone, newbie--, niska`, e4xit, sdaftuar, TheHoliestRoger, so, Victorsueca, (+11 more, use /NETSPLIT to show all of them) 11:49 -!- murchandamus1 [~murchghos@ghostdub.de] has joined #bitcoin-core-dev 11:49 -!- Netsplit over, joins: Soligor 11:49 -!- odk is now known as opdenkamp 11:49 -!- Netsplit over, joins: so 11:50 -!- Netsplit over, joins: keymone 11:50 -!- opdenkamp [~opdenkamp@D93F2BCF.cm-20.dynamic.ziggo.nl] has quit [Client Quit] 11:51 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 240 seconds] 11:51 -!- opdenkamp [~opdenkamp@kodi/staff/dushmaniac] has joined #bitcoin-core-dev 11:52 -!- berndj-blackout is now known as berndj 12:05 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 245 seconds] 12:07 < jnewbery> Just running test_runner and the new progress output is thrilling. Glad we didn't go for the boring spinner option. 12:11 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 12:12 -!- laurentmt [~Thunderbi@185.242.6.5] has quit [Quit: laurentmt] 12:13 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 12:15 -!- reallll [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 12:19 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Disconnected by services] 12:19 -!- reallll is now known as belcher_ 12:22 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 12:23 < instagibbs> it should make some sort of progressive ascii art 12:25 -!- sdaftuar_ is now known as sdaftuar 12:27 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 276 seconds] 12:30 -!- sdaftuar [~sdaftuar@238.90.227.35.bc.googleusercontent.com] has quit [Changing host] 12:30 -!- sdaftuar [~sdaftuar@unaffiliated/sdaftuar] has joined #bitcoin-core-dev 12:57 -!- michaelfolkson [~textual@host86-170-183-225.range86-170.btcentralplus.com] has joined #bitcoin-core-dev 13:08 -!- gwollon is now known as gwillen 13:08 < instagibbs> https://travis-ci.org/bitcoin/bitcoin/builds/445823485?utm_source=github_status&utm_medium=notification looks like linter is broke on master/0.17 13:09 < instagibbs> ubuntu flake update apparently 13:14 < instagibbs> hmm that one is giving some other error, but here's tip of 0.17 https://travis-ci.org/bitcoin/bitcoin/jobs/443960300 13:17 < instagibbs> looks like pyflakes update causing it https://gitlab.com/pycqa/flake8/commit/527af5c214ef0eccfde3dd58d7ea15e09c483bd3 13:23 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 13:23 < michagogo> Hm. I just tried fixing https://github.com/bitcoin-core/gitian.sigs/issues/658 13:23 < michagogo> And it broke even more 13:24 < michagogo> Anyone have any idea wy? 13:24 < michagogo> why* 13:36 -!- bitconner [~conner@136.24.75.121] has joined #bitcoin-core-dev 13:53 -!- e4xit_ is now known as e4xit 13:55 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-uclbxyiaqyvncrsr] has joined #bitcoin-core-dev 13:55 < bitcoin-git> [bitcoin] instagibbs opened pull request #14563: Pin flake8 version to earlier version to avoid pyflakes update (master...fix_flake) https://github.com/bitcoin/bitcoin/pull/14563 13:55 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-uclbxyiaqyvncrsr] has left #bitcoin-core-dev [] 14:00 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 252 seconds] 14:05 -!- jarthur [~jarthur@207.114.244.5] has quit [] 14:12 -!- Krellan [~Krellan@2600:1700:be50:323f:55b0:5cb9:8203:6ae5] has quit [Ping timeout: 250 seconds] 14:12 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 240 seconds] 14:15 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 14:15 -!- jarthur [~jarthur@207.114.244.5] has quit [Client Quit] 14:18 -!- ctrlbreak [~ctrlbreak@142.162.20.53] has joined #bitcoin-core-dev 14:22 -!- irc_viewer_test [irc_viewer@gateway/vpn/privateinternetaccess/ircviewertest/x-06412631] has joined #bitcoin-core-dev 14:23 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has joined #bitcoin-core-dev 14:23 -!- schmidty is now known as Guest12812 14:29 -!- michaelfolkson [~textual@host86-170-183-225.range86-170.btcentralplus.com] has quit [Quit: Sleep mode] 14:30 -!- irc_viewer_test [irc_viewer@gateway/vpn/privateinternetaccess/ircviewertest/x-06412631] has quit [Quit: irc_viewer_test] 14:34 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-vxpugrtzzqimqyof] has joined #bitcoin-core-dev 14:34 < bitcoin-git> [bitcoin] instagibbs closed pull request #14563: Pin flake8 version to earlier version to avoid pyflakes update (master...fix_flake) https://github.com/bitcoin/bitcoin/pull/14563 14:34 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-vxpugrtzzqimqyof] has left #bitcoin-core-dev [] 14:36 -!- michaelfolkson [~textual@host86-170-183-225.range86-170.btcentralplus.com] has joined #bitcoin-core-dev 14:39 -!- dqx [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev 14:39 -!- Krellan [~Krellan@2600:1700:be50:323f:55b0:5cb9:8203:6ae5] has joined #bitcoin-core-dev 14:47 -!- OzPac [~OzPac@cpc110789-lewi20-2-0-cust636.2-4.cable.virginm.net] has quit [Quit: OzPac] 14:51 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 14:52 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 14:52 -!- treyzania [~treyzania@paphos.tr3y.io] has quit [Ping timeout: 245 seconds] 14:54 -!- treyzania [~treyzania@paphos.tr3y.io] has joined #bitcoin-core-dev 15:05 -!- satwo [~textual@c-73-58-177-197.hsd1.tn.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 15:31 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 15:33 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 15:33 -!- profmac [~ProfMac@2001:470:1f0f:226:3077:c0f:7e15:6ec3] has quit [Ping timeout: 260 seconds] 15:40 -!- jcorgan_ [~jcorgan@64-142-68-61.dsl.static.sonic.net] has quit [Changing host] 15:40 -!- jcorgan_ [~jcorgan@unaffiliated/jcorgan] has joined #bitcoin-core-dev 15:40 -!- jcorgan_ is now known as jcorgan 15:43 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 15:43 -!- michaelfolkson [~textual@host86-170-183-225.range86-170.btcentralplus.com] has quit [Quit: Sleep mode] 15:44 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection] 15:46 -!- profmac [~ProfMac@2001:470:1f0f:226:b05c:6a94:bd71:665a] has joined #bitcoin-core-dev 16:02 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 16:03 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 16:47 -!- Krellan [~Krellan@2600:1700:be50:323f:55b0:5cb9:8203:6ae5] has quit [Read error: Connection reset by peer] 16:49 -!- Krellan [~Krellan@2600:1700:be50:323f:55b0:5cb9:8203:6ae5] has joined #bitcoin-core-dev 16:54 -!- proletesseract [~proletess@219.88.232.29] has joined #bitcoin-core-dev 16:57 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 17:00 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Remote host closed the connection] 17:00 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev 17:16 -!- proletesseract [~proletess@219.88.232.29] has quit [Remote host closed the connection] 17:16 -!- bralyclo_ [~bralyclow@76-202-84-204.lightspeed.tukrga.sbcglobal.net] has joined #bitcoin-core-dev 17:17 -!- proletesseract [~proletess@219.88.232.29] has joined #bitcoin-core-dev 17:17 -!- proletesseract [~proletess@219.88.232.29] has quit [Remote host closed the connection] 17:17 -!- grubles [~grubles@unaffiliated/grubles] has joined #bitcoin-core-dev 17:18 -!- bralycl__ [~bralyclow@195.242.213.119] has joined #bitcoin-core-dev 17:19 -!- bralycl__ [~bralyclow@195.242.213.119] has quit [Remote host closed the connection] 17:19 -!- bralyclow [~bralyclow@195.242.213.119] has quit [Ping timeout: 240 seconds] 17:20 -!- bralyclow [~bralyclow@76-202-84-204.lightspeed.tukrga.sbcglobal.net] has joined #bitcoin-core-dev 17:22 -!- bralyclo_ [~bralyclow@76-202-84-204.lightspeed.tukrga.sbcglobal.net] has quit [Ping timeout: 252 seconds] 17:22 -!- bralyclo_ [~bralyclow@195.242.213.119] has joined #bitcoin-core-dev 17:25 -!- bralyclow [~bralyclow@76-202-84-204.lightspeed.tukrga.sbcglobal.net] has quit [Ping timeout: 252 seconds] 17:29 -!- Tralfaz [~none@185.156.175.59] has quit [Read error: Connection reset by peer] 17:34 -!- Mutter [~Mutter@37.120.155.18] has joined #bitcoin-core-dev 17:35 -!- Mutter [~Mutter@37.120.155.18] has quit [Client Quit] 17:37 -!- proletesseract [~proletess@2403:4d00:300:5:c558:8264:23f9:d4bf] has joined #bitcoin-core-dev 17:40 -!- prole [~proletess@2403:4d00:300:5:656a:298b:5509:421d] has joined #bitcoin-core-dev 17:42 -!- dqx [~dqx@unaffiliated/dqx] has quit [Remote host closed the connection] 17:42 -!- proletesseract [~proletess@2403:4d00:300:5:c558:8264:23f9:d4bf] has quit [Ping timeout: 264 seconds] 17:42 -!- dqx [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev 17:43 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-djugdztcfaprbvxg] has joined #bitcoin-core-dev 17:43 < bitcoin-git> [bitcoin] jameshilliard opened pull request #14564: Adjust configure so that only bip70 is disabled when protobuf is missing instead of the GUI (master...bip70-disable-check) https://github.com/bitcoin/bitcoin/pull/14564 17:43 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-djugdztcfaprbvxg] has left #bitcoin-core-dev [] 17:45 -!- prole [~proletess@2403:4d00:300:5:656a:298b:5509:421d] has quit [Ping timeout: 264 seconds] 17:54 -!- Tralfaz [~none@185.156.175.59] has joined #bitcoin-core-dev 17:57 -!- dqx [~dqx@unaffiliated/dqx] has quit [Remote host closed the connection] 17:58 -!- dqx [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev 18:00 -!- dqx [~dqx@unaffiliated/dqx] has quit [Remote host closed the connection] 18:01 -!- dqx [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev 18:02 -!- dqx [~dqx@unaffiliated/dqx] has quit [Read error: Connection reset by peer] 18:04 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 18:20 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev 18:24 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Client Quit] 18:31 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has quit [Read error: Connection reset by peer] 18:31 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has joined #bitcoin-core-dev 18:32 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev 18:37 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 244 seconds] 18:40 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-fjlydjvqcevltxue] has joined #bitcoin-core-dev 18:40 < bitcoin-git> [bitcoin] sipa opened pull request #14565: Overhaul importmulti logic (master...201810_refactor_importmulti) https://github.com/bitcoin/bitcoin/pull/14565 18:40 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-fjlydjvqcevltxue] has left #bitcoin-core-dev [] 18:44 < sipa> achow101: see #14565... i tried implementing importmulti by recursing into all scripts and pattern matching, and it seems more concise than the special signer logic approach 18:44 < gribble> https://github.com/bitcoin/bitcoin/issues/14565 | Overhaul importmulti logic by sipa · Pull Request #14565 · bitcoin/bitcoin · GitHub 18:55 -!- Krellan [~Krellan@2600:1700:be50:323f:55b0:5cb9:8203:6ae5] has quit [Read error: Connection reset by peer] 18:56 -!- Krellan [~Krellan@2600:1700:be50:323f:55b0:5cb9:8203:6ae5] has joined #bitcoin-core-dev 18:56 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 19:04 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-enxvidfsnhrjqoej] has joined #bitcoin-core-dev 19:04 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #14566: 0.17: qa backports (0.17...Mf1810-qaBackports) https://github.com/bitcoin/bitcoin/pull/14566 19:04 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-enxvidfsnhrjqoej] has left #bitcoin-core-dev [] 19:20 -!- Bullit [~Bullit01@037-230-158-163.dynamic.caiway.nl] has quit [Quit: Leaving] 19:22 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 19:23 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 19:24 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 19:25 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 19:43 -!- dqx [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev 20:00 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 20:00 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 20:00 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 20:20 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 246 seconds] 20:48 -!- mr_paz_ [~mr_paz@c-71-57-73-68.hsd1.il.comcast.net] has quit [Remote host closed the connection] 20:50 -!- schnerchi [~schnerchi@p3EE1C6F7.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 20:52 -!- dqx [~dqx@unaffiliated/dqx] has quit [Remote host closed the connection] 20:53 -!- schnerch_ [~schnerchi@p3EE1C233.dip0.t-ipconnect.de] has quit [Ping timeout: 244 seconds] 21:01 -!- satwo [~textual@c-73-58-177-197.hsd1.tn.comcast.net] has joined #bitcoin-core-dev 21:02 -!- satwo [~textual@c-73-58-177-197.hsd1.tn.comcast.net] has quit [Client Quit] 21:19 < meshcollider> sipa: I really like your importmulti cleanup 21:45 -!- murrayn [~murrayn@unaffiliated/murrayn] has quit [Quit: Leaving] 21:45 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-nlbtsgpjdoqxneit] has joined #bitcoin-core-dev 21:45 < bitcoin-git> [bitcoin] kallewoof closed pull request #14507: net: avoid being disconnected from pruned nodes when syncing up (master...net-pruned-limit-requests) https://github.com/bitcoin/bitcoin/pull/14507 21:45 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-nlbtsgpjdoqxneit] has left #bitcoin-core-dev [] 21:47 -!- jarthur [~jarthur@2605:6000:1019:41ab:b090:f46e:fd5b:3030] has joined #bitcoin-core-dev 22:01 -!- klot [~klot@188.113.58.239] has joined #bitcoin-core-dev 22:02 -!- klot [~klot@188.113.58.239] has quit [Remote host closed the connection] 22:02 -!- klot [~klot@188.113.58.239] has joined #bitcoin-core-dev 22:03 -!- klot [~klot@188.113.58.239] has quit [Remote host closed the connection] 22:04 -!- klot [~klot@188.113.58.239] has joined #bitcoin-core-dev 22:07 -!- murrayn [~murrayn@S0106f8a097f16608.ok.shawcable.net] has joined #bitcoin-core-dev 22:07 -!- murrayn [~murrayn@S0106f8a097f16608.ok.shawcable.net] has quit [Changing host] 22:07 -!- murrayn [~murrayn@unaffiliated/murrayn] has joined #bitcoin-core-dev 22:47 -!- bitconner [~conner@136.24.75.121] has quit [Ping timeout: 252 seconds] 22:52 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Read error: Connection reset by peer] 23:29 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 23:31 -!- jarthur [~jarthur@2605:6000:1019:41ab:b090:f46e:fd5b:3030] has quit [] 23:32 -!- ap4lmtree- [~ap4lmtree@unaffiliated/ap4lmtree] has quit [Read error: Connection reset by peer] 23:33 -!- ap4lmtree- [~ap4lmtree@unaffiliated/ap4lmtree] has joined #bitcoin-core-dev 23:36 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 23:52 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Remote host closed the connection] 23:53 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev 23:59 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has joined #bitcoin-core-dev --- Log closed Thu Oct 25 00:00:47 2018