--- Log opened Tue Oct 30 00:00:03 2018 --- Day changed Tue Oct 30 2018 00:00 -!- Bullit [~Bullit01@037-230-158-163.dynamic.caiway.nl] has quit [Read error: Connection reset by peer] 00:00 -!- Bullit [~Bullit01@037-230-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev 00:06 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev 00:09 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 256 seconds] 00:12 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 00:28 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Ping timeout: 256 seconds] 00:29 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 00:30 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 00:31 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev 00:35 -!- drexl__ [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has quit [Ping timeout: 246 seconds] 00:42 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev 01:02 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 244 seconds] 01:04 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 01:05 -!- ezzzy [~ezzzy@unaffiliated/ezzzy] has joined #bitcoin-core-dev 01:08 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 01:12 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 01:15 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 01:16 -!- jungly [~quassel@host97-200-static.8-79-b.business.telecomitalia.it] has joined #bitcoin-core-dev 01:30 -!- jungly [~quassel@host97-200-static.8-79-b.business.telecomitalia.it] has quit [Remote host closed the connection] 01:31 -!- jungly [~quassel@host97-200-static.8-79-b.business.telecomitalia.it] has joined #bitcoin-core-dev 01:36 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Ping timeout: 256 seconds] 01:37 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Ping timeout: 256 seconds] 01:38 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:38 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev 01:43 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 252 seconds] 01:51 -!- Sentineo [~Undefined@unaffiliated/sentineo] has quit [Quit: do not take my a->a] 02:01 -!- forathorn [~fatecheck@92.40.248.213.threembb.co.uk] has joined #bitcoin-core-dev 02:02 -!- forathorn [~fatecheck@92.40.248.213.threembb.co.uk] has quit [Read error: Connection reset by peer] 02:02 -!- forathorn [~fatecheck@92.40.248.213.threembb.co.uk] has joined #bitcoin-core-dev 02:03 -!- forathorn [~fatecheck@92.40.248.213.threembb.co.uk] has quit [Read error: Connection reset by peer] 02:03 -!- forathorn [~fatecheck@92.40.248.213.threembb.co.uk] has joined #bitcoin-core-dev 02:04 -!- forathorn [~fatecheck@92.40.248.213.threembb.co.uk] has quit [Read error: Connection reset by peer] 02:13 -!- Sentineo [~Undefined@unaffiliated/sentineo] has joined #bitcoin-core-dev 02:14 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 02:14 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 02:18 -!- setpill [~setpill@unaffiliated/setpill] has quit [Client Quit] 02:18 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 02:18 -!- murrayn [~murrayn@unaffiliated/murrayn] has quit [Quit: Leaving] 02:20 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection] 02:25 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-avevsstblmlijeee] has joined #bitcoin-core-dev 02:25 < bitcoin-git> [bitcoin] fanquake closed pull request #13280: [qt] Removed "Pay only the required fee" checkbox (master...custom-fee) https://github.com/bitcoin/bitcoin/pull/13280 02:25 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-avevsstblmlijeee] has left #bitcoin-core-dev [] 02:25 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 02:27 -!- chubao_ [cbba0da2@gateway/web/freenode/ip.203.186.13.162] has quit [Ping timeout: 256 seconds] 02:28 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 02:34 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev 02:34 -!- rex4539 [~rex4539@ppp-2-84-165-183.home.otenet.gr] has quit [Quit: rex4539] 02:38 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has joined #bitcoin-core-dev 02:38 -!- schmidty is now known as Guest38022 02:46 < phwalkr> Hey. I'm trying to build a testnet transaction according to an example, and I am getting Error validating transaction: Rejected script for input 0 referencing . Can someone help me? 02:46 < phwalkr> This is the transaction I'm trying to broadcast https://0bin.net/paste/-3maB0rGk6fq3eE0#X7reA5XCqZYwzeu+YACcmEV7YXNAdkKFq3C6I2ci7XZ 03:01 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 252 seconds] 03:04 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 03:16 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 03:19 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 03:25 -!- kallewoof [~quassel@240d:1a:759:6000:a7b1:451a:8874:e1ac] has quit [Read error: Connection reset by peer] 03:27 -!- kallewoof [~quassel@fp96f94c66.tkyc515.ap.nuro.jp] has joined #bitcoin-core-dev 03:28 -!- zautomata [~zautomata@unaffiliated/zautomata] has quit [Quit: WeeChat 1.9.1] 03:30 -!- zautomata [~zautomata@41.43.110.148] has joined #bitcoin-core-dev 03:31 -!- zautomata [~zautomata@41.43.110.148] has quit [Changing host] 03:31 -!- zautomata [~zautomata@unaffiliated/zautomata] has joined #bitcoin-core-dev 03:36 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 03:36 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev 03:36 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 03:40 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-reoshsztacqazosi] has joined #bitcoin-core-dev 03:40 < bitcoin-git> [bitcoin] fridokus opened pull request #14606: Tests: Consistency changes in comments (master...master) https://github.com/bitcoin/bitcoin/pull/14606 03:40 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-reoshsztacqazosi] has left #bitcoin-core-dev [] 03:42 -!- drizztbsd [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 03:44 -!- promag [~promag@193.126.224.118] has joined #bitcoin-core-dev 03:45 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 246 seconds] 03:46 -!- laurentmt [~Thunderbi@77.247.178.186] has joined #bitcoin-core-dev 03:47 -!- drizztbsd is now known as timothy 03:50 -!- Guest38609 [~dell@105.156.2.240] has joined #bitcoin-core-dev 03:51 -!- Guest38609 [~dell@105.156.2.240] has quit [Client Quit] 03:56 -!- kallewoof [~quassel@fp96f94c66.tkyc515.ap.nuro.jp] has quit [Read error: Connection reset by peer] 03:58 -!- kallewoof [~quassel@240d:1a:759:6000:a7b1:451a:8874:e1ac] has joined #bitcoin-core-dev 04:02 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 256 seconds] 04:03 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 04:03 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 04:26 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has quit [Ping timeout: 244 seconds] 04:28 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has joined #bitcoin-core-dev 04:31 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 04:35 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 04:38 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has quit [Remote host closed the connection] 04:39 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev 04:42 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 04:43 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has quit [Ping timeout: 250 seconds] 04:43 < Sentineo> phwalkr: one of its inputs is already spent ... 04:43 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection] 04:44 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 04:52 -!- ken2812221 [~ken281222@110.50.135.178] has quit [Remote host closed the connection] 04:53 -!- ken2812221 [~ken281222@110.50.135.178] has joined #bitcoin-core-dev 04:57 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 04:58 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 05:01 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 256 seconds] 05:02 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 05:03 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 05:03 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 05:06 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 05:07 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has quit [Ping timeout: 250 seconds] 05:07 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 05:08 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has joined #bitcoin-core-dev 05:29 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 250 seconds] 05:30 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 05:53 -!- michaelfolkson [~textual@host86-132-64-1.range86-132.btcentralplus.com] has joined #bitcoin-core-dev 05:54 -!- laurentmt [~Thunderbi@77.247.178.186] has quit [Quit: laurentmt] 05:54 -!- IGHOR [~quassel@93.178.216.72] has quit [Read error: No route to host] 05:55 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev 05:58 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has quit [Ping timeout: 244 seconds] 05:59 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has joined #bitcoin-core-dev 06:01 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has joined #bitcoin-core-dev 06:08 -!- promag [~promag@193.126.224.118] has quit [Remote host closed the connection] 06:10 < wumpus> 0.17.0.1 binaries up https://bitcoincore.org/bin/bitcoin-core-0.17.0.1/ 06:13 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev 06:18 -!- rex4539 [~rex4539@boo--1.static.otenet.gr] has joined #bitcoin-core-dev 06:23 -!- Deinogalerix21 [~Deinogale@89.238.176.150] has joined #bitcoin-core-dev 06:31 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 06:39 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 06:40 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 06:42 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 06:43 -!- shesek [~shesek@141.226.218.23] has joined #bitcoin-core-dev 06:43 -!- shesek [~shesek@141.226.218.23] has quit [Changing host] 06:43 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 06:44 -!- cu-olly20 [~cu-olly@181.21.186.108] has joined #bitcoin-core-dev 06:44 < cu-olly20> /ⵑ\ AᎢTΝ: Thіs cһannеⅼ һas mоvеԁ tഠ irc.freᥱᥒoԁe.ᥒᥱt ﹟⧸ϳoіᥒ /!\ 06:44 -!- cu-olly20 [~cu-olly@181.21.186.108] has quit [Remote host closed the connection] 06:57 -!- michaelfolkson [~textual@host86-132-64-1.range86-132.btcentralplus.com] has quit [Quit: Sleep mode] 06:58 < wumpus> whuh 07:03 -!- cubancorona [cubancoron@gateway/vpn/privateinternetaccess/cubancorona] has joined #bitcoin-core-dev 07:08 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 07:09 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Quit: Leaving] 07:09 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 07:28 -!- bralyclow [~bralyclow@195.242.213.119] has quit [Remote host closed the connection] 07:32 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 07:35 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev 07:41 -!- michaelfolkson [~textual@host86-132-64-1.range86-132.btcentralplus.com] has joined #bitcoin-core-dev 07:43 -!- Deinogalerix21 [~Deinogale@89.238.176.150] has quit [Quit: WeeChat 2.3] 07:47 -!- bralyclow [~bralyclow@195.242.213.119] has joined #bitcoin-core-dev 07:49 -!- rex4539 [~rex4539@boo--1.static.otenet.gr] has quit [Ping timeout: 264 seconds] 07:52 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-injmuzesdrtrqmew] has joined #bitcoin-core-dev 07:52 < bitcoin-git> [bitcoin] hebasto opened pull request #14608: qt: Remove the "Pay only required fee..." checkbox (master...20181030-remove-payonlyrequiredfee) https://github.com/bitcoin/bitcoin/pull/14608 07:52 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-injmuzesdrtrqmew] has left #bitcoin-core-dev [] 07:59 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-yvragptsqfxmdtkv] has joined #bitcoin-core-dev 07:59 < bitcoin-git> [bitcoin] sp4ke opened pull request #14609: Less confusing documentation for `torpassword` (master...patch-1) https://github.com/bitcoin/bitcoin/pull/14609 07:59 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-yvragptsqfxmdtkv] has left #bitcoin-core-dev [] 08:05 < provoostenator> Gitian for v0.17.0.1 Windows is presenting me with "cp: cannot stat 'inputs/bitcoin-0.17.0.1-win-unsigned.tar.gz': No such file or directory" 08:06 < provoostenator> Same Bionic machine that I signed v0.17.0(rc*) with. 08:06 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 08:06 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 08:07 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 08:17 < hebasto> provoostenator: with gitian-build.py? 08:18 < provoostenator> hebasto yes: python3 gitian-build.py --detach-sign --no-commit -B sjors 0.17.0.1 08:19 < provoostenator> The non-signed builds (-b) work fine, but the signed builds (-s and -B) don't. 08:19 < hebasto> provoostenator: script expects 'inputs/bitcoin-0.17.0-win-unsigned.tar.gz', which is wrong. 08:20 < provoostenator> wumpus: did you use the old bash version by any chance? https://github.com/bitcoin-core/gitian.sigs/commit/484902bd74d4d80b91fe1d8b0ec8db622e9c66fc 08:20 < hebasto> provoostenator: I've modified two lines in the script on this purpose. 08:24 < hebasto> provoostenator: in lines 95 and 103 replace args.version with "0.17.0.1" 08:24 -!- michaelfolkson [~textual@host86-132-64-1.range86-132.btcentralplus.com] has quit [Quit: Sleep mode] 08:24 -!- bralyclow [~bralyclow@195.242.213.119] has quit [Remote host closed the connection] 08:25 < hebasto> err 08:25 < provoostenator> hebasto: thanks, can you make a PR for that? I'll ACK it if those changes work. 08:25 < hebasto> with 0.17.0 08:25 < hebasto> provoostenator: sure 08:25 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection] 08:26 < provoostenator> Though I think it's the unsigned version that's not named right. 08:26 < hebasto> yes 08:26 < provoostenator> So your version would be incompatible with wuppus' commit: 0.17.0.1-win-signed/laanwj/bitcoin-win-signer-build.assert 08:27 < provoostenator> Oh no nvm 08:28 < provoostenator> Oh no nvm, it's the file name: "bitcoin-0.17.0-win64-setup.exe" 08:28 < hebasto> ^ 08:32 < achow101> provoostenator: there was a change to gitian-build.py that may not exist in 0.17.0.1 08:34 < achow101> provoostenator: the change was that the unsigned version that goes into gitian-builder/inputs would be versioned, instead of generically named 08:34 < achow101> that's probably what is causing your problem. 08:34 < provoostenator> achow101 I'm using gitian-build.py from the latest master 08:35 < provoostenator> It's versioned, but it ignored the 4th decimal: bitcoin-0.17.0-win-unsigned.tar.gz 08:36 < achow101> oh, i see. 08:37 < provoostenator> I would say that's the bug; no reason to leave out the 4th digit for an internal file name. 08:37 < provoostenator> (though I'm happy to ignore the bug for this release and just stick to 0.17.0-win, otherwise everyone would have to rebuild. 08:38 < achow101> that seems like a bug in gitian itself though, not with the build script. the resulting unsigned.tar.gz file is versioned incorrectly 08:38 < achow101> unless the version number wasn't bumped again 08:40 < provoostenator> achow101: it was bumped: https://github.com/bitcoin/bitcoin/commit/dc4923a71bf64bd48708c7e4bd33765cdae68fdf 08:42 < achow101> so gitian is making binaries with the version number 0.17.0? or is it making them wiht 0.17.0.1 except for the win unsigned tar? 08:48 < provoostenator> macOS has the same naming issue 08:49 < provoostenator> Linux binaries have 3 digits: bitcoin-0.17.0-arm-linux-gnueabihf.tar.gz 08:49 < achow101> provoostenator: I see the problem now, investigating a fix 08:49 < achow101> (something to do with 'make dist') 08:49 < provoostenator> achow101: great, I'm too jetlagged to make sense of this, but happy to test your fix :-) 08:52 < provoostenator> Also at some point we should rename osx to macos in the file name 09:00 -!- ezzzy [~ezzzy@unaffiliated/ezzzy] has quit [Ping timeout: 252 seconds] 09:02 < wumpus> provoostenator: could be, my base image is pretty old at this point 09:02 < wumpus> is this a regression for 0.17.0.1? it looked to me that there were plenty of succesful builders 09:05 < hebasto> wumpus: yes, it's a regression for 0.17.0.1 09:06 < achow101> wumpus: hebasto: it isn't really a regression 09:07 < achow101> it has been broken for a while I think. we see the same thing happend with 0.15.0.1 09:07 < achow101> all that has changed is that the build script does versioning, which is what is causing problems. the versioning is slightly broken in make or configure 09:07 -!- Tralfaz [~none@185.156.175.59] has joined #bitcoin-core-dev 09:08 < achow101> provoostenator: can you try https://github.com/achow101/bitcoin/tree/fix-4-version-gitian ? I think that should fix this problem 09:10 -!- Arvidt [~Arvidt@p5DE6A9E2.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 09:11 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 09:13 < Arvidt> When doing tar -xzf bitcoin-0.17.0.1-x86_64-linux-gnu.tar.gz it extracts to the folder bitcoin-0.17.0/ . I would suggest that it extracts to the folder bitcoin-0.17.0.1/ because I have a symlink "current" to the newest version, and now, my old binary tree of 0.17.0 got simply overwritten with the 0.17.0.1 version, while I was still running 0.17.0 with that binary tree :-( But it looks 09:13 < Arvidt> like 0.17.0 could cleanly shutdown anyway... 09:14 < achow101> Arvidt: I believe that is part of the problem that I am investigating with gitian producing binaries without the 4th build number 09:15 < Arvidt> achow101: Great :-) 09:17 -!- michaelfolkson [~textual@host86-132-64-1.range86-132.btcentralplus.com] has joined #bitcoin-core-dev 09:25 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 09:25 -!- Arvidt [~Arvidt@p5DE6A9E2.dip0.t-ipconnect.de] has quit [Quit: leaving] 09:28 -!- Arvidt [~Arvidt@p5DE6A9E2.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 09:30 < Arvidt> Maybe for quality assurance a check could be added to a release process script that checks if the tar ball extracts to the exact version? 09:31 < Arvidt> I am not sure if also the RC versions should extract to the RC version named folders, e.g. 0.17.0rc1 09:32 < Arvidt> With the RC versions I had the same problem with the symlink as stated above 09:33 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has quit [Remote host closed the connection] 09:34 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev 09:34 -!- bralyclow [~bralyclow@195.242.213.119] has joined #bitcoin-core-dev 09:39 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has quit [Ping timeout: 264 seconds] 09:41 -!- michaelfolkson [~textual@host86-132-64-1.range86-132.btcentralplus.com] has quit [Quit: Sleep mode] 09:42 < esotericnonsense> Arvidt: non-specific to bitcoin, the binary changing out from underneath it shouldn't matter 09:43 < esotericnonsense> the running process will continue to hold a file descriptor to the "deleted" other version 09:56 -!- michaelfolkson [~textual@host86-132-64-1.range86-132.btcentralplus.com] has joined #bitcoin-core-dev 09:57 < sipa> esotericnonsense: for some upgrades (though not 4th digit changes...) you may end up with difference in version between bitcoind and bitcoin-cli 09:57 -!- michaelfolkson [~textual@host86-132-64-1.range86-132.btcentralplus.com] has quit [Client Quit] 09:58 -!- Arvidt [~Arvidt@p5DE6A9E2.dip0.t-ipconnect.de] has quit [Quit: leaving] 10:00 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-kbggctiyhcfkduao] has joined #bitcoin-core-dev 10:00 < bitcoin-git> [bitcoin] JBaczuk opened pull request #14610: Docs: correction to test readme compile instructions (master...fix_test_readme_compile_instructions) https://github.com/bitcoin/bitcoin/pull/14610 10:00 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-kbggctiyhcfkduao] has left #bitcoin-core-dev [] 10:02 -!- bralyclow [~bralyclow@195.242.213.119] has quit [Remote host closed the connection] 10:02 -!- bralyclow [~bralyclow@195.242.213.119] has joined #bitcoin-core-dev 10:04 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 10:05 -!- grubles [~grubles@unaffiliated/grubles] has quit [Ping timeout: 252 seconds] 10:07 < esotericnonsense> i suppose that's true 10:12 -!- grubles [~grubles@unaffiliated/grubles] has joined #bitcoin-core-dev 10:12 -!- michaelfolkson [~textual@host86-132-64-1.range86-132.btcentralplus.com] has joined #bitcoin-core-dev 10:13 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 245 seconds] 10:22 -!- michaelfolkson [~textual@host86-132-64-1.range86-132.btcentralplus.com] has quit [Quit: Sleep mode] 10:33 -!- promag [~promag@83.223.249.184] has joined #bitcoin-core-dev 10:39 -!- bralyclow [~bralyclow@195.242.213.119] has quit [Remote host closed the connection] 10:41 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 10:42 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 10:58 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 240 seconds] 11:00 -!- shesek [~shesek@141.226.218.23] has joined #bitcoin-core-dev 11:00 -!- shesek [~shesek@141.226.218.23] has quit [Changing host] 11:00 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 11:06 -!- bralyclow [~bralyclow@195.242.213.119] has joined #bitcoin-core-dev 11:13 -!- promag [~promag@83.223.249.184] has quit [Remote host closed the connection] 11:17 -!- laurentmt [~Thunderbi@77.247.178.186] has joined #bitcoin-core-dev 11:20 < provoostenator> achow101: if I use your commit, would my gitian build be incompatible with others? If so I'll push my sigs first using some manual workaround 11:21 < provoostenator> Unfortutely it's a bit of a pain because some of my commands break: https://github.com/bitcoin-core/docs/issues/18 11:21 < achow101> provoostenator: it probably would be incompatible 11:21 < achow101> provoostenator: if you use an older version of gitian-build.py, it should be fine 11:30 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-tfgovpaudkmvosec] has joined #bitcoin-core-dev 11:30 < bitcoin-git> [bitcoin] morenoh149 opened pull request #14611: align items in contrib init (master...morenoh149-patch-1) https://github.com/bitcoin/bitcoin/pull/14611 11:30 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-tfgovpaudkmvosec] has left #bitcoin-core-dev [] 11:30 < provoostenator> hebasto: I think your workaround is causing my gitian to checksum the v0.17.0 binary instead of the new one. 11:30 < provoostenator> Maybe I applied it on the wrong lines though. 11:31 < provoostenator> Oh wait, that was macOS. 11:31 < provoostenator> Windows works for me. 11:31 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev 11:32 -!- rhavar [uid237883@gateway/web/irccloud.com/x-pxmyrtjdnpojndtn] has joined #bitcoin-core-dev 11:36 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has quit [Ping timeout: 252 seconds] 11:37 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 11:46 -!- laurentmt [~Thunderbi@77.247.178.186] has quit [Quit: laurentmt] 11:47 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 11:48 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 11:49 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 11:49 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 11:59 -!- ezzzy [~ezzzy@unaffiliated/ezzzy] has joined #bitcoin-core-dev 12:04 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-iwaqismsxnzaqepo] has joined #bitcoin-core-dev 12:04 < bitcoin-git> [bitcoin] achow101 opened pull request #14612: Include full version number in released file names (master...fix-make-build-version) https://github.com/bitcoin/bitcoin/pull/14612 12:04 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-iwaqismsxnzaqepo] has left #bitcoin-core-dev [] 12:04 < achow101> provoostenator: Arvidt: ^ that should resolve these version number/filename problems for the future 12:06 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 12:09 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 12:11 -!- shesek [~shesek@141.226.218.23] has joined #bitcoin-core-dev 12:11 -!- shesek [~shesek@141.226.218.23] has quit [Changing host] 12:11 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 12:16 -!- reallll [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 12:19 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Ping timeout: 244 seconds] 12:25 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 12:25 -!- shesek [~shesek@141.226.218.23] has joined #bitcoin-core-dev 12:25 -!- shesek [~shesek@141.226.218.23] has quit [Changing host] 12:25 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 12:34 -!- irc_viewer_test [irc_viewer@gateway/vpn/privateinternetaccess/ircviewertest/x-06412631] has joined #bitcoin-core-dev 12:35 -!- irc_viewer_test [irc_viewer@gateway/vpn/privateinternetaccess/ircviewertest/x-06412631] has quit [Client Quit] 12:36 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 12:36 -!- shesek [~shesek@141.226.218.23] has joined #bitcoin-core-dev 12:36 -!- shesek [~shesek@141.226.218.23] has quit [Changing host] 12:36 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 12:37 -!- ezzzy [~ezzzy@unaffiliated/ezzzy] has quit [Remote host closed the connection] 12:41 -!- ezzzy [~ezzzy@unaffiliated/ezzzy] has joined #bitcoin-core-dev 12:58 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 13:02 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 13:03 -!- shesek [~shesek@141.226.218.23] has joined #bitcoin-core-dev 13:03 -!- shesek [~shesek@141.226.218.23] has quit [Changing host] 13:03 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 13:13 -!- jarthur [~jarthur@207.114.244.5] has quit [Quit: gotta focus] 13:15 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 13:16 < phantomcircuit> so uh 13:16 < phantomcircuit> how can i get something in build-aux/m4 to actually be used? 13:22 -!- gertjaap [uid322815@gateway/web/irccloud.com/x-mlsdkwtfgfbkvgmj] has joined #bitcoin-core-dev 13:22 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 13:34 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Quit: Leaving...] 13:42 -!- reallll is now known as belcher_ 13:43 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection] 13:56 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev 13:56 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 246 seconds] 14:05 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 14:27 -!- ezzzy [~ezzzy@unaffiliated/ezzzy] has quit [Remote host closed the connection] 14:30 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 268 seconds] 14:32 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 14:35 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 14:38 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 14:41 -!- bitconner [~conner@136.24.75.121] has joined #bitcoin-core-dev 14:43 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 14:44 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 14:47 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 14:57 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 250 seconds] 14:57 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 15:01 < phantomcircuit> seems the windows functional tests are still kind of buggy 15:01 < phantomcircuit> https://github.com/bitcoin/bitcoin/pull/14336/commits/9bd0e58ea04e3dad506fcb6113eef0a75c154ca2 15:01 < phantomcircuit> https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/19927186 15:01 < sipa> yes :( 15:02 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 15:07 < sipa> MarcoFalke: how is appveyor set up? there is a webhook from the bitcoin/bitcoin repo to appveyor, but how does appveyor get to report a CI status back? 15:09 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 268 seconds] 15:10 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 15:20 < phantomcircuit> sipa, it's unfortunate 15:54 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 15:58 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has quit [Remote host closed the connection] 15:59 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev 16:01 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 16:05 -!- rex4539 [~rex4539@ppp-2-84-165-183.home.otenet.gr] has joined #bitcoin-core-dev 16:06 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has quit [Ping timeout: 268 seconds] 16:08 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 252 seconds] 16:22 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev 16:25 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 16:27 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has quit [Ping timeout: 272 seconds] 16:41 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 16:42 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 17:08 -!- belcher_ [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 17:13 -!- bralyclow [~bralyclow@195.242.213.119] has quit [] 17:20 -!- bitbee is now known as Golgotha 17:20 -!- Golgotha is now known as bitbee 17:23 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev 17:24 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 17:28 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 17:29 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 18:09 -!- bsm117532 [~mcelrath@c-24-61-184-150.hsd1.ma.comcast.net] has quit [Ping timeout: 240 seconds] 18:15 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 244 seconds] 18:20 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 18:28 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 240 seconds] 18:29 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection] 18:45 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 18:46 < dongcarl> Is there naming convention for function parameters? I'm seeing snake_case and CamelCase both 18:48 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 18:53 < sipa> dongcarl: developer_notes.md 18:54 < sipa> those are variables, so snake case 18:55 < dongcarl> sipa: ah okay, didn't know if there was differentiation in terms of convention for parameters vs. other variables since I saw inconsistencies 18:55 < sipa> ah, no 18:56 < sipa> parameters are just local variables in the scope of the callee 18:56 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 18:57 < dongcarl> right right 18:57 < dongcarl> and it would be snake case even in the case of method declarations I would assume 19:13 < sipa> right 19:18 -!- bralyclow [~bralyclow@76-202-84-204.lightspeed.tukrga.sbcglobal.net] has joined #bitcoin-core-dev 19:19 -!- bralyclo_ [~bralyclow@195.242.213.119] has joined #bitcoin-core-dev 19:23 -!- bralyclow [~bralyclow@76-202-84-204.lightspeed.tukrga.sbcglobal.net] has quit [Ping timeout: 272 seconds] 19:29 -!- ap4lmtree [~ap4lmtree@unaffiliated/ap4lmtree] has quit [Remote host closed the connection] 19:29 -!- ap4lmtree [~ap4lmtree@unaffiliated/ap4lmtree] has joined #bitcoin-core-dev 19:31 -!- ap4lmtree [~ap4lmtree@unaffiliated/ap4lmtree] has quit [Read error: Connection reset by peer] 19:34 -!- ap4lmtree [~ap4lmtree@unaffiliated/ap4lmtree] has joined #bitcoin-core-dev 20:08 -!- god_ [9d07c3bb@gateway/web/freenode/ip.157.7.195.187] has joined #bitcoin-core-dev 20:08 -!- god_ [9d07c3bb@gateway/web/freenode/ip.157.7.195.187] has quit [Client Quit] 20:17 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection] 20:20 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev 20:25 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Ping timeout: 250 seconds] 20:29 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev 20:34 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Ping timeout: 252 seconds] 20:36 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-pmkurwuaxntodbue] has joined #bitcoin-core-dev 20:36 < bitcoin-git> [bitcoin] Peppernrino opened pull request #14615: Image File Compression (master...image-file-compression) https://github.com/bitcoin/bitcoin/pull/14615 20:36 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-pmkurwuaxntodbue] has left #bitcoin-core-dev [] 20:36 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 20:38 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 20:42 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 20:43 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 20:48 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 268 seconds] 21:04 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 268 seconds] 21:05 -!- XtuDe [~Edet@118.127.103.254] has joined #bitcoin-core-dev 21:08 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 21:15 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev 21:36 -!- bralyclo_ [~bralyclow@195.242.213.119] has quit [Remote host closed the connection] 21:36 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has quit [Remote host closed the connection] 21:42 < dongcarl> Any way to have `test/lint/commit-script-check.sh` only run on one commit? Even when I specify the particular commit it seems to want to run through everything... 21:44 -!- schnerchi [~schnerchi@p3EE1CB58.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 21:47 -!- schnerch_ [~schnerchi@p3EE1C97D.dip0.t-ipconnect.de] has quit [Ping timeout: 244 seconds] 21:54 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 21:59 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 244 seconds] 22:47 -!- cubancorona [cubancoron@gateway/vpn/privateinternetaccess/cubancorona] has quit [Quit: Leaving] 22:49 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 22:50 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 23:08 -!- bitconner [~conner@136.24.75.121] has quit [Ping timeout: 244 seconds] 23:16 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev 23:19 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection] 23:27 -!- murrayn [~murrayn@unaffiliated/murrayn] has joined #bitcoin-core-dev 23:27 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 23:29 -!- ccook [~ccook@208.66.192.142] has quit [Ping timeout: 246 seconds] 23:29 -!- ccook [~ccook@208.66.192.142] has joined #bitcoin-core-dev 23:39 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 250 seconds] 23:40 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 23:42 -!- rhavar [uid237883@gateway/web/irccloud.com/x-pxmyrtjdnpojndtn] has quit [Quit: Connection closed for inactivity] 23:46 -!- Deinogalerix21 [~Deinogale@89.238.176.150] has joined #bitcoin-core-dev 23:51 -!- zrc [~zrc@221.219.13.160.dy.iij4u.or.jp] has joined #bitcoin-core-dev 23:52 -!- Deinogalerix21 [~Deinogale@89.238.176.150] has quit [Quit: WeeChat 2.3] 23:55 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 23:55 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Ping timeout: 244 seconds] --- Log closed Wed Oct 31 00:00:45 2018