--- Log opened Sat Nov 10 00:00:17 2018 00:03 -!- leishman [~leishman@2604:5500:c225:c500:6471:d4c:1cd5:8f6] has joined #bitcoin-core-dev 00:04 -!- CodeBlue1776 [~CodeBlue1@107-215-134-60.lightspeed.cicril.sbcglobal.net] has quit [Ping timeout: 252 seconds] 00:06 -!- CodeBlue1776 [~CodeBlue1@107-215-134-60.lightspeed.cicril.sbcglobal.net] has joined #bitcoin-core-dev 00:07 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 00:08 -!- leishman [~leishman@2604:5500:c225:c500:6471:d4c:1cd5:8f6] has quit [Ping timeout: 252 seconds] 00:08 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev 00:08 -!- shesek [~shesek@185.3.147.193] has quit [Changing host] 00:08 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 00:10 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 00:12 -!- Krellan [~Krellan@2601:640:4000:a876:d0e2:dc41:93ee:b128] has joined #bitcoin-core-dev 00:13 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 00:17 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 00:18 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev 00:18 -!- shesek [~shesek@185.3.147.193] has quit [Changing host] 00:18 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 00:28 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 00:28 -!- leishman [~leishman@2604:5500:c225:c500:18ac:3b33:91c1:619c] has joined #bitcoin-core-dev 00:29 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev 00:29 -!- shesek [~shesek@185.3.147.193] has quit [Changing host] 00:29 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 00:33 -!- leishman [~leishman@2604:5500:c225:c500:18ac:3b33:91c1:619c] has quit [Ping timeout: 260 seconds] 00:39 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 00:44 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev 00:44 -!- shesek [~shesek@185.3.147.193] has quit [Changing host] 00:44 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 00:46 -!- leishman [~leishman@2604:5500:c225:c500:39e9:1000:e46b:9131] has joined #bitcoin-core-dev 00:51 -!- leishman [~leishman@2604:5500:c225:c500:39e9:1000:e46b:9131] has quit [Ping timeout: 250 seconds] 01:05 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 01:05 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 01:10 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 01:13 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev 01:13 -!- shesek [~shesek@185.3.147.193] has quit [Changing host] 01:13 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 01:13 < provoostenator> Review shout out to #12783 which prevents macOS from going into app nap during initial sync. 01:13 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: No route to host] 01:13 < gribble> https://github.com/bitcoin/bitcoin/issues/12783 | macOS: disable AppNap during sync by krab · Pull Request #12783 · bitcoin/bitcoin · GitHub 01:15 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 01:23 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 01:24 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 01:25 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 01:26 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 01:27 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 01:28 < wumpus> currently it's prevented from going into app nap completely 01:28 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 01:28 < wumpus> but yes it makes sense to only prevent so during sync 01:28 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 01:29 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev 01:29 -!- shesek [~shesek@185.3.147.193] has quit [Changing host] 01:29 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 01:29 -!- ezzzy [~ezzzy@unaffiliated/ezzzy] has joined #bitcoin-core-dev 01:31 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 01:32 -!- Krellan [~Krellan@2601:640:4000:a876:d0e2:dc41:93ee:b128] has quit [Ping timeout: 252 seconds] 01:33 < fanquake> wumpus the app-nap prevention is currently broken on master, and likely recent versions. Apple seems to have killed the plist flag we were using to disable it. 01:34 < wumpus> ohhh wonderful 01:34 < fanquake> All documentation about the flag seems to have also disappeared at some point 01:35 < wumpus> memory holes 01:35 < fanquake> *worm holes 01:36 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev 01:36 -!- shesek [~shesek@185.3.147.193] has quit [Changing host] 01:36 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 01:38 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-aeyshybmifsotumd] has joined #bitcoin-core-dev 01:38 < bitcoin-git> [bitcoin] laanwj closed pull request #12783: macOS: disable AppNap during sync (master...macos-disable-appnap) https://github.com/bitcoin/bitcoin/pull/12783 01:38 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-aeyshybmifsotumd] has left #bitcoin-core-dev [] 01:43 -!- ken2812221 [~ken281222@110.50.135.219] has quit [Read error: Connection reset by peer] 01:43 -!- ken2812221_ [~ken281222@110.50.135.219] has joined #bitcoin-core-dev 01:49 -!- CodeBlue1776 [~CodeBlue1@107-215-134-60.lightspeed.cicril.sbcglobal.net] has quit [Read error: Connection reset by peer] 01:49 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 01:49 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev 01:49 -!- shesek [~shesek@185.3.147.193] has quit [Changing host] 01:49 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 01:51 -!- wxss [~user@181.214.38.17] has joined #bitcoin-core-dev 01:54 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-avzysbmqemgnaqou] has joined #bitcoin-core-dev 01:54 < bitcoin-git> [bitcoin] fanquake opened pull request #14701: build: Add CLIENT_VERSION_BUILD to CFBundleGetInfoString (master...add-build-version-to-info-plist) https://github.com/bitcoin/bitcoin/pull/14701 01:54 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-avzysbmqemgnaqou] has left #bitcoin-core-dev [] 01:54 -!- CodeBlue1776 [~CodeBlue1@107-215-134-60.lightspeed.cicril.sbcglobal.net] has joined #bitcoin-core-dev 02:07 < wumpus> wonder how long it will take Apple to blackhole this functionality too 02:09 < fanquake> If anything, Apple seems to have a thing for conserving/reducing resource & power usage 02:10 -!- ezzzy [~ezzzy@unaffiliated/ezzzy] has quit [Remote host closed the connection] 02:10 -!- ezzzy [~ezzzy@unaffiliated/ezzzy] has joined #bitcoin-core-dev 02:10 < wumpus> that makes sense, it's just that it seems they offer the least amount of API stability 02:11 < fanquake> We'll probably be able to go down the "more properly optimise the macOS resource usage path", although hopefully without introducing lots of macOS specific IBD weirdness/issues etc. 02:12 < fanquake> heh, btw, did you see jamesob's write up here: https://github.com/bitcoin/bitcoin/pull/14336#issuecomment-437384408 02:12 < wumpus> it's too bad that standards are a thing of the past, or we'd be able to do it for all OSes at the same time... 02:12 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 02:13 < wumpus> AHHH poll broken too on MacOS? 02:14 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev 02:14 -!- shesek [~shesek@185.3.147.193] has quit [Changing host] 02:14 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 02:15 < fanquake> supposedly, I was going to get a newer version of the darwin-xnu source and see if anything had changed 02:16 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 02:16 * wumpus wonders how libevent handles this, but… I suspect they use kqueue directly where available 02:16 < wumpus> this is what you get for trying to reinvent the wheel :/ 02:17 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev 02:17 -!- shesek [~shesek@185.3.147.193] has quit [Changing host] 02:17 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 02:17 < wumpus> oh... it was easy to switch to poll,wasn't it 02:17 < wumpus> just a few lines! 02:17 < wumpus> they said... 02:18 < wumpus> now we're finding bugs in operating systems 02:20 < fanquake> definitely not a first for bitcoin core 02:20 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 02:21 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev 02:21 -!- shesek [~shesek@185.3.147.193] has quit [Changing host] 02:21 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 02:22 < wumpus> apparent conclusion: if you want to implement asynchronous I/O, implementing all the different methodologies of different operating systems is not *optional* but a requirement, not just for performance but for basic functionaltiy 02:22 < wumpus> everything is broken somewhere 02:24 < wumpus> anyhow good investigation jamesob! 02:25 < fanquake> ^ 02:25 < wumpus> fanquake: in any case with regard to resource, I/O, scheduling, power optimization, I think we need some kind of abstraction behind which we can put the various OS-specific methods 02:26 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 02:26 < wumpus> just littering the code with #ifdef MacOSX is not a nice way forward 02:26 < fanquake> I agree. The macOS stuff is also likely to be Objective-C 02:27 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 02:28 -!- wxss_ [~user@185.203.122.4] has joined #bitcoin-core-dev 02:28 < wumpus> and similar things exist for all operating systems, e.g. for linux there's #9245 02:28 < gribble> https://github.com/bitcoin/bitcoin/issues/9245 | Drop IO priority to idle while reading blocks for peer requests and startup verification by luke-jr · Pull Request #9245 · bitcoin/bitcoin · GitHub 02:31 < wumpus> fanquake: or swift! 02:31 -!- wxss [~user@181.214.38.17] has quit [Ping timeout: 264 seconds] 02:32 < fanquake> wumpus heh I've been investigating that. I'm writing a fair bit of Swift at the moment (iOS), and would happily swap out all Objective-C for it. 02:34 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: No route to host] 02:35 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev 02:35 -!- shesek [~shesek@185.3.147.193] has quit [Changing host] 02:35 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 02:41 -!- rex4539 [~rex4539@ppp-2-84-165-183.home.otenet.gr] has quit [Ping timeout: 252 seconds] 02:44 -!- ezzzy [~ezzzy@unaffiliated/ezzzy] has quit [] 02:45 < wumpus> fanquake: I think at the moment that would complicate things because objc is part of the standard toolchains and swift is not, but might be wrong 02:53 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 02:56 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 02:59 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 03:00 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev 03:00 -!- shesek [~shesek@185.3.147.193] has quit [Changing host] 03:00 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 03:07 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: No route to host] 03:08 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev 03:08 -!- shesek [~shesek@185.3.147.193] has quit [Changing host] 03:08 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 03:10 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 03:11 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev 03:11 -!- shesek [~shesek@185.3.147.193] has quit [Changing host] 03:11 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 03:12 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 03:14 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 03:15 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 03:24 -!- wxss [~user@185.216.35.121] has joined #bitcoin-core-dev 03:25 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 03:26 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 03:27 -!- wxss_ [~user@185.203.122.4] has quit [Ping timeout: 260 seconds] 03:34 -!- rex4539 [~rex4539@ppp-2-84-165-183.home.otenet.gr] has joined #bitcoin-core-dev 03:42 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 03:44 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 03:46 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-sckgzudgmpsvchay] has joined #bitcoin-core-dev 03:46 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to 0.17: https://github.com/bitcoin/bitcoin/compare/1e49fe450dbb...5150accdd2a7 03:46 < bitcoin-git> bitcoin/0.17 89306ab Russell Yanofsky: [wallet] Restore ability to list incoming transactions by label... 03:46 < bitcoin-git> bitcoin/0.17 5150acc Wladimir J. van der Laan: Merge #14441: [wallet] Backport(0.17): Restore ability to list incoming transactions by label... 03:46 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-sckgzudgmpsvchay] has left #bitcoin-core-dev [] 03:47 -!- TheFuzzStone [~TheFuzzSt@185.242.6.4] has joined #bitcoin-core-dev 03:52 -!- TheFuzzStone [~TheFuzzSt@185.242.6.4] has quit [Quit: Konversation terminated!] 03:52 -!- TheFuzzStone [~TheFuzzSt@185.242.6.4] has joined #bitcoin-core-dev 03:53 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 03:55 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 03:58 -!- TheFuzzStone [~TheFuzzSt@185.242.6.4] has quit [Quit: Konversation terminated!] 04:07 -!- TheFuzzStone [~TheFuzzSt@185.242.6.4] has joined #bitcoin-core-dev 04:08 -!- TheFuzzStone [~TheFuzzSt@185.242.6.4] has quit [Client Quit] 04:11 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 04:12 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 04:14 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 04:15 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev 04:15 -!- shesek [~shesek@185.3.147.193] has quit [Changing host] 04:15 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 04:23 -!- TheFuzzStone [~TheFuzzSt@185.242.6.4] has joined #bitcoin-core-dev 04:25 -!- TheFuzzStone [~TheFuzzSt@185.242.6.4] has quit [Client Quit] 04:28 -!- TheFuzzStone [~TheFuzzSt@185.242.6.4] has joined #bitcoin-core-dev 04:31 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 04:32 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev 04:32 -!- shesek [~shesek@185.3.147.193] has quit [Changing host] 04:32 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 04:40 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 04:41 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 04:49 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 04:49 < meshcollider> IMO #13100 should be tagged for 0.18 04:49 < gribble> https://github.com/bitcoin/bitcoin/issues/13100 | gui: Add dynamic wallets support by promag · Pull Request #13100 · bitcoin/bitcoin · GitHub 04:49 < meshcollider> it does need a rebase though 04:51 -!- rex4539 [~rex4539@ppp-2-84-165-183.home.otenet.gr] has quit [Quit: rex4539] 04:52 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev 04:52 -!- shesek [~shesek@185.3.147.193] has quit [Changing host] 04:52 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 04:52 < meshcollider> promag: do you want me to rebase #13339 for you or will you have time to do it yourself 04:52 < gribble> https://github.com/bitcoin/bitcoin/issues/13339 | wallet: Replace %w by wallet name in -walletnotify script by promag · Pull Request #13339 · bitcoin/bitcoin · GitHub 04:59 < fanquake> promag added 05:00 < fanquake> eh, meant meshcollider 05:00 < meshcollider> thanks :P 05:08 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 05:08 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev 05:08 -!- shesek [~shesek@185.3.147.193] has quit [Changing host] 05:08 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 05:09 -!- RiskNerd [48eaf57b@gateway/web/freenode/ip.72.234.245.123] has quit [Ping timeout: 256 seconds] 05:31 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 05:31 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev 05:31 -!- shesek [~shesek@185.3.147.193] has quit [Changing host] 05:31 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 05:42 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 05:42 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 06:06 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 06:07 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev 06:07 -!- shesek [~shesek@185.3.147.193] has quit [Changing host] 06:07 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 06:11 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has joined #bitcoin-core-dev 06:13 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 06:32 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 06:33 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 06:37 -!- mehr [05752ec2@gateway/web/freenode/ip.5.117.46.194] has joined #bitcoin-core-dev 06:38 -!- mehr [05752ec2@gateway/web/freenode/ip.5.117.46.194] has quit [Client Quit] 06:41 -!- rex4539 [~rex4539@ppp-2-84-165-183.home.otenet.gr] has joined #bitcoin-core-dev 06:48 -!- wxss [~user@185.216.35.121] has quit [Quit: leaving] 06:52 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: No route to host] 06:52 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev 06:52 -!- shesek [~shesek@185.3.147.193] has quit [Changing host] 06:52 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 06:59 -!- klot [~klot@188.113.44.221] has joined #bitcoin-core-dev 07:00 -!- klot [~klot@188.113.44.221] has quit [Remote host closed the connection] 07:00 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 07:00 -!- klot [~klot@188.113.44.221] has joined #bitcoin-core-dev 07:02 -!- klot [~klot@188.113.44.221] has quit [Remote host closed the connection] 07:02 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev 07:02 -!- shesek [~shesek@185.3.147.193] has quit [Changing host] 07:02 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 07:02 -!- klot [~klot@188.113.44.221] has joined #bitcoin-core-dev 07:03 -!- klot [~klot@188.113.44.221] has quit [Remote host closed the connection] 07:04 -!- klot [~klot@188.113.44.221] has joined #bitcoin-core-dev 07:15 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 07:16 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev 07:16 -!- shesek [~shesek@185.3.147.193] has quit [Changing host] 07:16 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 07:16 -!- jupaname [~jupaname@admn248.neoplus.adsl.tpnet.pl] has joined #bitcoin-core-dev 07:16 -!- jupaname [~jupaname@admn248.neoplus.adsl.tpnet.pl] has quit [Remote host closed the connection] 07:27 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-idplzqboralrbyfi] has joined #bitcoin-core-dev 07:27 < bitcoin-git> [bitcoin] mruddy opened pull request #14704: doc: add detached release notes for #14060 (master...zmq-release-notes) https://github.com/bitcoin/bitcoin/pull/14704 07:27 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-idplzqboralrbyfi] has left #bitcoin-core-dev [] 07:38 -!- ken2812221_ [~ken281222@110.50.135.219] has quit [Ping timeout: 240 seconds] 07:40 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 07:40 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev 07:40 -!- shesek [~shesek@185.3.147.193] has quit [Changing host] 07:40 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 07:45 -!- TheFuzzStone [~TheFuzzSt@185.242.6.4] has quit [Quit: Konversation terminated!] 07:57 -!- TheFuzzStone [~TheFuzzSt@185.242.6.4] has joined #bitcoin-core-dev 08:05 -!- TheFuzzStone [~TheFuzzSt@185.242.6.4] has quit [Quit: Konversation terminated!] 08:08 -!- egeltje_ [~egeltje_@ppp-171-96-229-160.revip8.asianet.co.th] has joined #bitcoin-core-dev 08:08 -!- egeltje_ [~egeltje_@ppp-171-96-229-160.revip8.asianet.co.th] has quit [Read error: Connection reset by peer] 08:15 -!- TheFuzzStone [~TheFuzzSt@185.242.6.4] has joined #bitcoin-core-dev 08:15 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 08:16 -!- bralyclow [~bralyclow@2600:1700:3d70:93b0:247c:52d4:e787:97c] has joined #bitcoin-core-dev 08:17 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 08:23 -!- TheFuzzStone [~TheFuzzSt@185.242.6.4] has quit [Quit: Konversation terminated!] 08:24 -!- TheFuzzStone [~TheFuzzSt@185.242.6.4] has joined #bitcoin-core-dev 08:26 -!- TheFuzzStone [~TheFuzzSt@185.242.6.4] has quit [Client Quit] 08:27 -!- TheFuzzStone [~TheFuzzSt@185.242.6.4] has joined #bitcoin-core-dev 08:29 -!- TheFuzzStone [~TheFuzzSt@185.242.6.4] has quit [Client Quit] 08:29 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 08:29 -!- TheFuzzStone [~TheFuzzSt@185.242.6.4] has joined #bitcoin-core-dev 08:30 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev 08:30 -!- shesek [~shesek@185.3.147.193] has quit [Changing host] 08:30 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 08:31 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 08:31 -!- TheFuzzStone [~TheFuzzSt@185.242.6.4] has quit [Client Quit] 08:32 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 08:35 -!- ctrlbreak_MAD [~ctrlbreak@142.162.20.53] has quit [Quit: Leaving] 08:35 -!- ctrlbreak [~ctrlbreak@142.162.20.53] has joined #bitcoin-core-dev 08:38 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 08:38 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev 08:38 -!- shesek [~shesek@185.3.147.193] has quit [Changing host] 08:38 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 08:39 -!- ctrlbreak [~ctrlbreak@142.162.20.53] has quit [Client Quit] 08:39 -!- ctrlbreak [~ctrlbreak@142.162.20.53] has joined #bitcoin-core-dev 08:40 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 08:41 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 08:41 -!- TheFuzzStone [~TheFuzzSt@185.242.6.4] has joined #bitcoin-core-dev 08:42 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 08:42 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 08:46 -!- leishman [~leishman@136.24.189.159] has joined #bitcoin-core-dev 08:49 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has quit [Read error: Connection reset by peer] 08:49 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has joined #bitcoin-core-dev 08:51 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has quit [Remote host closed the connection] 08:51 -!- leishman [~leishman@136.24.189.159] has quit [Ping timeout: 272 seconds] 08:53 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has joined #bitcoin-core-dev 08:56 < provoostenator> #14608 seems ready to merge, perhaps with a final concept ACK from wumpus? 08:56 < gribble> https://github.com/bitcoin/bitcoin/issues/14608 | qt: Remove the "Pay only required fee..." checkbox by hebasto · Pull Request #14608 · bitcoin/bitcoin · GitHub 08:57 -!- TheFuzzStone [~TheFuzzSt@185.242.6.4] has quit [Quit: Konversation terminated!] 08:58 -!- gabridome [~textual@host148-201-dynamic.45-213-r.retail.telecomitalia.it] has joined #bitcoin-core-dev 09:00 -!- Krellan [~Krellan@2601:640:4000:a876:d0e2:dc41:93ee:b128] has joined #bitcoin-core-dev 09:01 -!- bralyclo_ [~bralyclow@195.242.213.119] has joined #bitcoin-core-dev 09:03 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: No route to host] 09:04 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 09:04 -!- bralyclow [~bralyclow@2600:1700:3d70:93b0:247c:52d4:e787:97c] has quit [Ping timeout: 260 seconds] 09:07 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has quit [Remote host closed the connection] 09:07 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev 09:09 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 09:10 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has joined #bitcoin-core-dev 09:14 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-rfuvxblrlnwjtdka] has joined #bitcoin-core-dev 09:14 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #14705: travis: Avoid timeout on verify-commits check (master...Mf1811-travisVerifyCommits) https://github.com/bitcoin/bitcoin/pull/14705 09:14 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-rfuvxblrlnwjtdka] has left #bitcoin-core-dev [] 09:15 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 09:17 -!- hebasto [~hebasto@95.164.65.194] has quit [Ping timeout: 244 seconds] 09:18 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev 09:19 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 252 seconds] 09:23 -!- cubancorona [cubancoron@gateway/vpn/privateinternetaccess/cubancorona] has joined #bitcoin-core-dev 09:24 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: No route to host] 09:25 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev 09:25 -!- shesek [~shesek@185.3.147.193] has quit [Changing host] 09:25 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 09:49 < phantomcircuit> wumpus, libevent uses kqueue is the answer to avoiding this issue 10:01 -!- ExtraCrispy [~ExtraCris@gateway/tor-sasl/extracrispy] has quit [Ping timeout: 256 seconds] 10:09 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: No route to host] 10:10 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 10:12 < phantomcircuit> wumpus, i could also switch the USE_POLL macro to a whitelist of working systems (ie linux) 10:15 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 10:16 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 10:18 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 10:19 -!- bralyclo_ [~bralyclow@195.242.213.119] has quit [Remote host closed the connection] 10:20 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 10:22 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: No route to host] 10:24 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 10:26 < wumpus> phantomcircuit: yes I think whitelisting is the only option for now 10:26 < wumpus> phantomcircuit: it's disappointing that this is needed but not your fault 10:28 < wumpus> phantomcircuit: you could have no idea that this was such a bottomless pit of horror 10:32 < sipa> wumpus: it's almost as if someone did realize that, and then decided to write libevent :) 10:32 < phantomcircuit> at this point i think it would have been easier to move to libevent honestly 10:32 < phantomcircuit> but oh well 10:32 < sipa> phantomcircuit: the refactorings are useful, it's not wasted work 10:32 < sipa> even if we eventually get libevent 10:33 -!- TheFuzzStone [~TheFuzzSt@185.244.212.59] has joined #bitcoin-core-dev 10:34 -!- TheFuzzStone [~TheFuzzSt@185.244.212.59] has quit [Client Quit] 10:35 < sipa> phantomcircuit: also, in practice, i expect that most many-connection nodes run linux 10:35 < phantomcircuit> sipa, agreed 10:36 < phantomcircuit> sipa, well poll doesn't work on windows (actually it would how we're using it...) 10:36 < phantomcircuit> so it's windows using select and linux using poll and then ...? freebsd and osx? 10:37 < sipa> but select also doesn't have the same 1024-low-fds-only restriction on windows 10:37 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 10:41 -!- gabridome [~textual@host148-201-dynamic.45-213-r.retail.telecomitalia.it] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 10:42 < phantomcircuit> sipa, exactly 10:43 < phantomcircuit> so uh what's the right macro to check for linux systems? 10:47 < sipa> __linux__ exists, apparently 10:53 -!- klot [~klot@188.113.44.221] has quit [Read error: Connection reset by peer] 10:53 < phantomcircuit> wumpus, switched to whitelisting 10:54 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: No route to host] 11:07 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 11:09 < luke-jr> wumpus: should we use QtNetwork? :P 11:09 < luke-jr> jk 11:09 < luke-jr> re #9245, note that I have Mac/Windows ports too ready for once it gets merged :/ 11:09 < gribble> https://github.com/bitcoin/bitcoin/issues/9245 | Drop IO priority to idle while reading blocks for peer requests and startup verification by luke-jr · Pull Request #9245 · bitcoin/bitcoin · GitHub 11:17 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 11:22 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 245 seconds] 11:41 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 11:42 -!- gabridome [~textual@host148-201-dynamic.45-213-r.retail.telecomitalia.it] has joined #bitcoin-core-dev 11:53 -!- ekrok [~ekrok@33.90-149-168.nextgentel.com] has joined #bitcoin-core-dev 11:55 -!- ekrok [~ekrok@33.90-149-168.nextgentel.com] has quit [Remote host closed the connection] 11:58 -!- Krellan [~Krellan@2601:640:4000:a876:d0e2:dc41:93ee:b128] has quit [Ping timeout: 250 seconds] 12:05 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Remote host closed the connection] 12:13 -!- gabridome [~textual@host148-201-dynamic.45-213-r.retail.telecomitalia.it] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 12:18 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 12:20 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 12:23 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 272 seconds] 12:26 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 12:30 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 252 seconds] 12:40 -!- Krellan [~Krellan@2601:640:4000:a876:d0e2:dc41:93ee:b128] has joined #bitcoin-core-dev 13:00 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev 13:00 -!- shesek [~shesek@185.3.147.193] has quit [Changing host] 13:00 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 13:04 -!- leishman [~leishman@50.237.29.22] has joined #bitcoin-core-dev 13:05 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 13:06 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev 13:06 -!- shesek [~shesek@185.3.147.193] has quit [Changing host] 13:06 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 13:22 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 13:25 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev 13:35 < sipa> gmaxwell: feel like having a look at #14624 ? 13:35 < gribble> https://github.com/bitcoin/bitcoin/issues/14624 | Some simple improvements to the RNG code by sipa · Pull Request #14624 · bitcoin/bitcoin · GitHub 13:35 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 13:36 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 13:37 < phantomcircuit> sipa, ty for review 13:41 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 272 seconds] 13:43 < phantomcircuit> sipa, not sure what to use other than hSocket really cause socket is obviously not available 13:43 < phantomcircuit> _socket ? 13:43 < sipa> socket_id ? 13:44 < phantomcircuit> ok 13:50 < phantomcircuit> sipa, also i think you misread ifndef as ifdef for the win32 stuff 13:51 < sipa> phantomcircuit: yes, i commented that :) 13:51 < sipa> https://github.com/bitcoin/bitcoin/pull/14336#discussion_r232466883 13:51 < phantomcircuit> sipa, ah page didn't update 13:52 < phantomcircuit> i think i've fixed the style nits too exept in the select code where it's just a move 13:52 < phantomcircuit> i guess the loops could use socket_id instead of hSocket, but it's using the moved hSocketMax so that might be less clear 13:52 < sipa> makes sense 13:54 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Remote host closed the connection] 13:54 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev 13:55 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: No route to host] 13:56 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 13:56 < sipa> phantomcircuit: going to try running 13:57 < phantomcircuit> missed braces in SocketEvents commit actually 13:58 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 14:01 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 14:01 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 14:01 < phantomcircuit> sipa, ok fixed 14:02 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev 14:02 -!- shesek [~shesek@185.3.147.193] has quit [Changing host] 14:02 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 14:13 < sipa> net.cpp:1355:10: warning: types may not be defined in a for-range-declaration 14:13 < sipa> for (struct pollfd pollfd : vpollfds) { 14:13 < sipa> ^~~~~~ 14:16 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 14:18 < sipa> phantomcircuit: i'm benchmarking the time to construct the input to poll()... looks like around 10 microseconds for 15 connections 14:18 < Lightsword> is there a reason we require pkg-config on non-windows builds? 14:20 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 14:21 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 14:22 < sipa> phantomcircuit: that does mean around 0.6 ms to start a poll every 50 ms with 1000 connections, which is a nontrivial cpu load 14:22 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: No route to host] 14:23 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev 14:23 -!- shesek [~shesek@185.3.147.193] has quit [Changing host] 14:23 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 14:25 < gmaxwell> to be fair, handling more connections really shouldn't be a goal for this change right now... goal should be not running into the 1024 FD limit, while handling the same number of connections. 14:25 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 14:25 < gmaxwell> poll itself is not really the most optimal approach for large numbers of connections inherently. 14:26 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 14:29 < sipa> phantomcircuit: you should update this line in init.cpp: 14:29 < sipa> nMaxConnections = std::max(std::min(nMaxConnections, FD_SETSIZE - nBind - MIN_CORE_FILEDESCRIPTORS - MAX_ADDNODE_CONNECTIONS), 0); 14:30 < sipa> maybe we want another max connections hard limit, but it shouldn't be dependent on FD_SETSIZE anymore 14:31 < gmaxwell> yea, 1000 or something? it should be some level that we've actually tested the code at. 14:32 < gmaxwell> lest we end up with users who've already set that value to 10,000 for inexplicable reasons finding themselve easily OOMed by random internet jerks. 14:36 < sipa> please to do DoS my bitcoin.sipa.be node :) 14:36 < sipa> it's running the poll PR 14:37 < sipa> *try to 14:37 < sipa> but i don't get more than ~100 connections organically 14:47 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection] 14:50 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 14:51 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 14:54 -!- gabridome [~textual@host148-201-dynamic.45-213-r.retail.telecomitalia.it] has joined #bitcoin-core-dev 14:55 -!- gabridome [~textual@host148-201-dynamic.45-213-r.retail.telecomitalia.it] has quit [Client Quit] 14:57 -!- leishman [~leishman@50.237.29.22] has quit [Remote host closed the connection] 14:58 -!- leishman [~leishman@50.237.29.22] has joined #bitcoin-core-dev 14:58 -!- leishman [~leishman@50.237.29.22] has quit [Remote host closed the connection] 14:58 -!- leishman [~leishman@50.237.29.22] has joined #bitcoin-core-dev 15:01 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 15:02 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 15:06 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: No route to host] 15:07 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 15:22 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 15:32 -!- ken2812221 [~ken281222@110.50.135.219] has joined #bitcoin-core-dev 15:45 -!- bitconner [~conner@203-213-106-45.static.tpgi.com.au] has joined #bitcoin-core-dev 15:52 -!- ken2812221 [~ken281222@110.50.135.219] has quit [Ping timeout: 268 seconds] 16:07 -!- leishman [~leishman@50.237.29.22] has quit [Remote host closed the connection] 16:07 -!- leishman [~leishman@50.237.29.22] has joined #bitcoin-core-dev 16:12 -!- leishman [~leishman@50.237.29.22] has quit [Remote host closed the connection] 16:12 -!- leishman [~leishman@50.237.29.22] has joined #bitcoin-core-dev 16:26 -!- Ga1aCt1Cz00_ [~Ga1aCt1Cz@p2003005F6E1F7C83346384DDAD6DBAF5.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 16:29 -!- Ga1aCt1Cz00__ [~Ga1aCt1Cz@p2003005F6E1F7C51710AE79902082B78.dip0.t-ipconnect.de] has quit [Ping timeout: 252 seconds] 16:31 -!- rex4539 [~rex4539@ppp-2-84-165-183.home.otenet.gr] has quit [Quit: rex4539] 16:47 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 16:52 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 245 seconds] 16:53 -!- dviola [~diego@unaffiliated/dviola] has quit [Ping timeout: 245 seconds] 17:12 -!- _cryptosignal_me [~John@91.245.74.93] has joined #bitcoin-core-dev 17:13 -!- leishman [~leishman@50.237.29.22] has quit [Remote host closed the connection] 17:14 -!- leishman [~leishman@50.237.29.22] has joined #bitcoin-core-dev 17:15 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 17:17 -!- leishman [~leishman@50.237.29.22] has quit [Remote host closed the connection] 17:17 -!- leishman [~leishman@50.237.29.22] has joined #bitcoin-core-dev 17:19 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Read error: Connection reset by peer] 17:19 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev 17:20 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection] 17:26 -!- bitconner [~conner@203-213-106-45.static.tpgi.com.au] has quit [Ping timeout: 272 seconds] 17:29 -!- bitconner [~conner@203.221.127.245] has joined #bitcoin-core-dev 17:46 -!- _cryptosignal_me [~John@91.245.74.93] has quit [Ping timeout: 240 seconds] 17:49 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 244 seconds] 17:52 -!- ap4lmtree [~ap4lmtree@unaffiliated/ap4lmtree] has quit [Read error: Connection reset by peer] 17:52 -!- bralyclow [~bralyclow@195.242.213.119] has joined #bitcoin-core-dev 17:56 -!- ap4lmtree [~ap4lmtree@unaffiliated/ap4lmtree] has joined #bitcoin-core-dev 18:04 -!- grubles [~grubles@unaffiliated/grubles] has quit [Remote host closed the connection] 18:07 -!- deaunapaul [~recover@180.190.52.175] has joined #bitcoin-core-dev 18:12 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 18:12 -!- deaunapaul [~recover@180.190.52.175] has quit [Remote host closed the connection] 18:12 -!- deaunapaul [~recover@180.190.52.175] has joined #bitcoin-core-dev 18:15 -!- grubles [~grubles@unaffiliated/grubles] has joined #bitcoin-core-dev 18:18 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 268 seconds] 18:28 -!- leishman [~leishman@50.237.29.22] has quit [Remote host closed the connection] 18:29 -!- leishman [~leishman@50.237.29.22] has joined #bitcoin-core-dev 18:30 -!- Nexpulse [6b4dc88c@gateway/web/freenode/ip.107.77.200.140] has joined #bitcoin-core-dev 18:31 -!- Nexpulse [6b4dc88c@gateway/web/freenode/ip.107.77.200.140] has quit [Client Quit] 18:33 -!- leishman [~leishman@50.237.29.22] has quit [Ping timeout: 244 seconds] 18:44 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 18:55 -!- CodeBlue1776 [~CodeBlue1@107-215-134-60.lightspeed.cicril.sbcglobal.net] has quit [Read error: Connection reset by peer] 18:55 -!- CodeBlue1776 [~CodeBlue1@107-215-134-60.lightspeed.cicril.sbcglobal.net] has joined #bitcoin-core-dev 19:24 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 19:25 -!- instagibbs [~instagibb@pool-100-15-135-248.washdc.fios.verizon.net] has quit [Ping timeout: 268 seconds] 19:28 < fanquake> sipa how long will your node be running the poll PR for? 19:29 < sipa> fanquake: until you kill it 19:29 < sipa> :) 19:32 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 19:35 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 268 seconds] 19:35 -!- lukedashjr is now known as luke-jr 19:36 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 244 seconds] 19:38 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 19:55 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 246 seconds] 19:59 < phantomcircuit> sipa, but it's not defining type? 20:01 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 20:02 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev 20:02 -!- shesek [~shesek@185.3.147.193] has quit [Changing host] 20:02 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 20:04 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 20:08 < sipa> phantomcircuit: my guess is that in C++ you can't have the "struct" keyword there 20:08 < sipa> which is optional otherwise anyway 20:09 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 20:09 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 20:11 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 252 seconds] 20:14 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 20:15 < phantomcircuit> sipa, oh which means i probably am aliasing it or something 20:16 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 20:17 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev 20:17 -!- shesek [~shesek@185.3.147.193] has quit [Changing host] 20:17 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 20:18 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 252 seconds] 20:19 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 20:21 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 20:26 < phantomcircuit> sipa, it's definitely not an efficient way of getting fd updates, but it follows the same pattern as select 20:26 < phantomcircuit> the changes should also make it easier to switch to another pattern 20:39 -!- booyah [~bb@193.25.1.157] has quit [Read error: Connection reset by peer] 20:39 -!- echonaut [~echonaut@46.101.192.134] has quit [Read error: Connection reset by peer] 20:39 -!- echonaut17 [~echonaut@46.101.192.134] has joined #bitcoin-core-dev 20:40 -!- booyah [~bb@193.25.1.157] has joined #bitcoin-core-dev 20:46 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 20:51 < phantomcircuit> sipa, introduced a constant to init.cpp MAX_FILE_DESCRIPTORS and set it to 1024 20:51 < phantomcircuit> although technically it's not fixed basically anywhere afaik 20:52 < gmaxwell> thats not a good name for it though, max sockets or something, since it's only going to limit the poll usage, not leveldb and whatnot. 20:53 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 20:53 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev 20:53 -!- shesek [~shesek@185.3.147.193] has quit [Changing host] 20:53 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 20:55 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 20:55 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 20:56 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 21:00 -!- CodeBlue1776 [~CodeBlue1@107-215-134-60.lightspeed.cicril.sbcglobal.net] has quit [Read error: Connection reset by peer] 21:00 -!- CodeBlue1776 [~CodeBlue1@107-215-134-60.lightspeed.cicril.sbcglobal.net] has joined #bitcoin-core-dev 21:05 < phantomcircuit> gmaxwell, estimated max file descriptors? 21:05 < gmaxwell> noo because we can use many more FDs for leveldb than sockets already... 21:05 < gmaxwell> just MAX_MAX_CONNECTIONS? :P 21:06 < phantomcircuit> i was doing 21:06 < phantomcircuit> MAX_FILE_DESCRIPTORS - nBind - MIN_CORE_FILEDESCRIPTORS - MAX_ADDNODE_CONNECTIONS 21:07 < phantomcircuit> for reference on linux systems the max number of fd's is typically 1024 21:10 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 21:15 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 252 seconds] 21:17 -!- gabridome [~textual@host148-201-dynamic.45-213-r.retail.telecomitalia.it] has joined #bitcoin-core-dev 21:17 -!- gabridome [~textual@host148-201-dynamic.45-213-r.retail.telecomitalia.it] has quit [Client Quit] 21:25 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 21:26 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev 21:26 -!- shesek [~shesek@185.3.147.193] has quit [Changing host] 21:26 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 21:29 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Remote host closed the connection] 21:29 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev 21:30 -!- instagibbs [~instagibb@pool-100-15-135-248.washdc.fios.verizon.net] has joined #bitcoin-core-dev 21:42 < sipa> phantomcircuit: we already have code for trying to raise the number of fds, if i remember 21:47 < phantomcircuit> return nMinFD; // getrlimit failed, assume it's fine 21:47 < phantomcircuit> lol 21:47 < phantomcircuit> sipa, yeah i see it 21:52 -!- bralyclow [~bralyclow@195.242.213.119] has quit [Remote host closed the connection] 22:08 < phantomcircuit> gmaxwell, opinions on changing the default max connections when using poll or on windows? 22:15 -!- rex4539 [~rex4539@ppp-2-84-165-183.home.otenet.gr] has joined #bitcoin-core-dev 22:15 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 22:19 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 244 seconds] 22:21 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 22:21 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 22:30 -!- ken2812221 [~ken281222@110.50.135.219] has joined #bitcoin-core-dev 22:41 -!- asdfjh [bd923aa7@gateway/web/freenode/ip.189.146.58.167] has joined #bitcoin-core-dev 22:42 -!- asdfjh [bd923aa7@gateway/web/freenode/ip.189.146.58.167] has quit [Client Quit] 22:51 -!- TheHoliestRoger [~TheHolies@unaffiliated/theholiestroger] has quit [Quit: Find me in #TheHolyRoger or https://theholyroger.com] 22:58 -!- TheHoliestRoger [~TheHolies@unaffiliated/theholiestroger] has joined #bitcoin-core-dev 23:15 -!- grubles [~grubles@unaffiliated/grubles] has quit [Remote host closed the connection] 23:16 -!- grubles [~grubles@unaffiliated/grubles] has joined #bitcoin-core-dev 23:17 -!- cornfeedhobo [~cornfeedh@unaffiliated/cornfeed] has quit [Ping timeout: 250 seconds] 23:22 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 23:23 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 23:30 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 23:30 -!- cornfeedhobo [~cornfeedh@unaffiliated/cornfeed] has joined #bitcoin-core-dev 23:31 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 23:32 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 23:38 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 23:39 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 23:39 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev 23:39 -!- shesek [~shesek@185.3.147.193] has quit [Changing host] 23:39 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 23:39 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 23:44 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood] 23:44 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 23:49 -!- bzb [~bzb@135-23-193-53.cpe.pppoe.ca] has joined #bitcoin-core-dev 23:50 -!- bzb [~bzb@135-23-193-53.cpe.pppoe.ca] has quit [Remote host closed the connection] 23:56 -!- bzb [~bzb@135-23-193-53.cpe.pppoe.ca] has joined #bitcoin-core-dev 23:56 -!- bzb [~bzb@135-23-193-53.cpe.pppoe.ca] has quit [Remote host closed the connection] --- Log closed Sun Nov 11 00:00:18 2018