--- Log opened Thu Nov 15 00:00:22 2018
00:01 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev
00:01 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 268 seconds]
00:04 -!- setpill [~setpill@unaffiliated/setpill] has quit [Client Quit]
00:04 -!- Skizzerz5 [~Skizzerz@198.200.51.180] has quit [Ping timeout: 272 seconds]
00:05 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
00:06 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev
00:06 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev
00:06 -!- shesek [~shesek@185.3.147.193] has quit [Changing host]
00:06 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
00:18 -!- wpaulino [~wpaulino@142.93.92.243] has quit [Changing host]
00:18 -!- wpaulino [~wpaulino@unaffiliated/wpaulino] has joined #bitcoin-core-dev
00:25 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
00:26 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
00:26 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
00:27 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
00:27 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev
00:32 -!- jungly [~quassel@host97-200-static.8-79-b.business.telecomitalia.it] has joined #bitcoin-core-dev
00:37 -!- Murch [~murch@82.192.35.10] has joined #bitcoin-core-dev
00:41 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
00:52 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
00:57 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
01:04 -!- nameeee [d94ddb05@gateway/web/freenode/ip.217.77.219.5] has joined #bitcoin-core-dev
01:04 -!- nameeee [d94ddb05@gateway/web/freenode/ip.217.77.219.5] has quit [Client Quit]
01:08 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
01:14 -!- booyah_ is now known as booyah
01:17 < esotericnonsense> sipa: thanks for the help earlier. i have it working now (ignoring the change address issues). think i'll deal with that later on since i don't care about bloating a testnet wallet
01:23 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has quit [Ping timeout: 240 seconds]
01:27 -!- Murch [~murch@82.192.35.10] has quit [Quit: Snoozing.]
01:28 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev
01:28 -!- cjd [~user@2a01:e0a:149:fcb0:f8c2:e9ff:fe25:a09f] has joined #bitcoin-core-dev
01:39 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev
01:42 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
01:47 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has quit [Remote host closed the connection]
01:47 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev
01:52 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has quit [Ping timeout: 245 seconds]
01:55 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
02:03 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev
02:05 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection]
02:05 -!- phwalkr [~phwalkr@48.75.166.178.rev.vodafone.pt] has joined #bitcoin-core-dev
02:05 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
02:06 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev
02:09 -!- JackH [~laptop@host86-133-255-215.range86-133.btcentralplus.com] has quit [Ping timeout: 250 seconds]
02:09 -!- phwalkr [~phwalkr@48.75.166.178.rev.vodafone.pt] has quit [Ping timeout: 250 seconds]
02:10 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev
02:10 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
02:11 -!- state_bits [~state_bit@2604:a880:2:d0::216b:7001] has quit [Ping timeout: 252 seconds]
02:13 -!- state_bits [~state_bit@2604:a880:2:d0::216b:7001] has joined #bitcoin-core-dev
02:21 -!- rhavar [uid237883@gateway/web/irccloud.com/x-misyahxxnppjiprm] has quit [Quit: Connection closed for inactivity]
02:24 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
02:27 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
02:42 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
02:47 -!- JackH [~laptop@62.232.170.181] has joined #bitcoin-core-dev
02:48 -!- zhangzf [~zhangzf@1.202.169.236] has quit [Remote host closed the connection]
02:48 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
02:51 < promag> does appveyor merges with master before build and test?
02:59 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
03:03 -!- dqx_ [~dqx@unaffiliated/dqx] has quit [Quit: .]
03:04 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 272 seconds]
03:10 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
03:13 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
03:14 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
03:27 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
03:28 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev
03:28 -!- shesek [~shesek@185.3.147.193] has quit [Changing host]
03:28 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
03:29 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]
03:30 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
03:37 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
03:37 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
03:38 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
03:39 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev
03:39 -!- shesek [~shesek@185.3.147.193] has quit [Changing host]
03:39 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
03:41 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
03:44 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]
03:45 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
03:54 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
03:54 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
03:55 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
03:56 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev
03:56 -!- shesek [~shesek@185.3.147.193] has quit [Changing host]
03:56 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
03:59 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
04:17 -!- fabianfabian [~fabianfab@D9656CCE.cm-27.dynamic.ziggo.nl] has joined #bitcoin-core-dev
04:21 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has joined #bitcoin-core-dev
04:42 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
04:43 -!- murr4y [ali@11.0.196.35.bc.googleusercontent.com] has joined #bitcoin-core-dev
04:52 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
04:59 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
05:03 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 244 seconds]
05:12 -!- riemann_ [~riemann@217.96.158.87.ipv4.supernova.orange.pl] has joined #bitcoin-core-dev
05:14 -!- riemann [~riemann@217.96.170.126.ipv4.supernova.orange.pl] has quit [Ping timeout: 245 seconds]
05:16 -!- cubancorona [cubancoron@gateway/vpn/privateinternetaccess/cubancorona] has joined #bitcoin-core-dev
05:19 -!- emilr [~emilr@unaffiliated/goregrind] has quit [Quit: Lost terminal]
05:21 -!- TX1683 [~TX1683@unaffiliated/tx1683] has joined #bitcoin-core-dev
05:35 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev
05:39 -!- Murch [~murch@185.81.138.21] has joined #bitcoin-core-dev
05:41 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
05:43 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: No route to host]
05:43 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev
05:43 -!- shesek [~shesek@185.3.147.193] has quit [Changing host]
05:43 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
05:46 -!- Murch [~murch@185.81.138.21] has quit [Quit: Snoozing.]
05:47 -!- Murch [~murch@185.81.138.21] has joined #bitcoin-core-dev
05:48 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
05:50 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
05:51 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev
05:51 -!- shesek [~shesek@185.3.147.193] has quit [Changing host]
05:51 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
05:52 -!- Murch [~murch@185.81.138.21] has quit [Client Quit]
05:53 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
05:54 -!- Murch [~murch@185.81.138.21] has joined #bitcoin-core-dev
05:54 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit []
05:54 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev
05:54 -!- shesek [~shesek@185.3.147.193] has quit [Changing host]
05:54 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
06:02 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 245 seconds]
06:04 -!- Murch [~murch@185.81.138.21] has quit [Quit: Snoozing.]
06:05 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]
06:07 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
06:20 < cjd> Does anybody happen to know what was the largest (in number of bytes) transaction ever created ?
06:28 < timothy> cjd: iirc https://blockstream.info/tx/bb41a757f405890fb0f5856228e23b715702d714d59bf2b1feb70d8b2b4e3e08
06:29 < cjd> oh wow, thank you
06:35 -!- zhangzf [~zhangzf@223.72.89.66] has joined #bitcoin-core-dev
06:41 < hebasto> promag: it seems so; https://github.com/bitcoin/bitcoin/commit/affc245f0199a9f7a2dadaa555024820a17ffc2a
06:49 -!- dady_ [c0c48e57@gateway/web/freenode/ip.192.196.142.87] has joined #bitcoin-core-dev
06:51 -!- dady_ [c0c48e57@gateway/web/freenode/ip.192.196.142.87] has quit [Client Quit]
06:59 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
06:59 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
07:00 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev
07:00 -!- shesek [~shesek@185.3.147.193] has quit [Changing host]
07:00 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
07:04 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 276 seconds]
07:23 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
07:27 -!- Murch [~murch@185.81.138.21] has joined #bitcoin-core-dev
07:36 -!- zhangzf_ [~zhangzf@223.72.61.72] has joined #bitcoin-core-dev
07:37 -!- zhangzf [~zhangzf@223.72.89.66] has quit [Ping timeout: 240 seconds]
07:41 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
07:48 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev
07:50 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
07:53 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Ping timeout: 252 seconds]
07:57 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev
08:02 -!- zhangzf_ [~zhangzf@223.72.61.72] has quit [Remote host closed the connection]
08:18 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
08:19 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev
08:19 -!- shesek [~shesek@185.3.147.193] has quit [Changing host]
08:19 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
08:24 -!- millerti [~millerti@cpe-66-24-91-119.stny.res.rr.com] has joined #bitcoin-core-dev
08:28 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/]
08:31 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
08:35 -!- Murch [~murch@185.81.138.21] has quit [Quit: Snoozing.]
08:37 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
08:40 -!- oneark [uid254801@gateway/web/irccloud.com/x-trdbeossllivipfc] has joined #bitcoin-core-dev
08:41 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
08:49 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: No route to host]
08:49 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
08:52 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
08:52 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-umdtcgexrsvzzsgk] has joined #bitcoin-core-dev
08:52 < bitcoin-git> [bitcoin] dongcarl opened pull request #14731: Improve scripted-diff developer docs (master...patch-4) https://github.com/bitcoin/bitcoin/pull/14731
08:52 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-umdtcgexrsvzzsgk] has left #bitcoin-core-dev []
08:59 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
09:00 -!- rhavar [uid237883@gateway/web/irccloud.com/x-cijwflmqqsvjaamr] has joined #bitcoin-core-dev
09:01 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 256 seconds]
09:13 -!- JackH [~laptop@62.232.170.181] has quit [Ping timeout: 240 seconds]
09:15 -!- ghost43_ is now known as ghost43
09:15 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
09:16 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
09:32 -!- promag [~promag@83.223.234.93] has joined #bitcoin-core-dev
09:41 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
09:43 -!- riemann [~riemann@217.96.158.87.ipv4.supernova.orange.pl] has joined #bitcoin-core-dev
09:45 -!- hbdgr__ [~riemann@217.96.137.240.ipv4.supernova.orange.pl] has joined #bitcoin-core-dev
09:45 -!- riemann_ [~riemann@217.96.158.87.ipv4.supernova.orange.pl] has quit [Ping timeout: 264 seconds]
09:46 < promag>  hebasto: thanks, I wonder if it's possible to rebase with a different branch
09:47 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
09:48 < esotericnonsense> sipa: in case you were interested, the results of the psbt stuff from yesterday...
09:48 < esotericnonsense> https://files.esotericnonsense.com/public/bitcoin-top-wallet-send.jpg
09:48 -!- riemann [~riemann@217.96.158.87.ipv4.supernova.orange.pl] has quit [Ping timeout: 272 seconds]
09:48 < esotericnonsense> (the gray box is a javascript QR scanner)\
09:48 < esotericnonsense> so this is all self hosted using bitcoind rpc, very much testnet stuff atm though
09:49 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
09:49 < promag> "omg send"? :D
09:49 < esotericnonsense> the gray box is using decodepsbt
09:49 < esotericnonsense> promag: i have a really bad habit of using stupid names for everything all over my code
09:49 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev
09:49 -!- shesek [~shesek@185.3.147.193] has quit [Changing host]
09:49 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
09:49 < promag> lgtm :D
09:49 < esotericnonsense> not "unsensible variable names", but rather stuff like panic!("omg it's all gone terribly wrong NOOOOOOOOOO")
09:55 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
09:56 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev
09:56 -!- shesek [~shesek@185.3.147.193] has quit [Changing host]
09:56 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
10:07 -!- JackH [~laptop@host86-133-255-215.range86-133.btcentralplus.com] has joined #bitcoin-core-dev
10:13 -!- promag [~promag@83.223.234.93] has quit [Remote host closed the connection]
10:17 < instagibbs> in functional tests how do i set up nodes with no connections to peers? 
10:18 -!- mistergold [~mistergol@185.37.26.18] has joined #bitcoin-core-dev
10:18 -!- ezzzy [~ezzzy@unaffiliated/ezzzy] has joined #bitcoin-core-dev
10:19 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]
10:21 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
10:25 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev
10:25 < instagibbs> got it, override setup_network
10:30 -!- hbdgr__ [~riemann@217.96.137.240.ipv4.supernova.orange.pl] has quit [Quit: Leaving]
10:31 -!- riemann [~riemann@217.96.137.240.ipv4.supernova.orange.pl] has joined #bitcoin-core-dev
10:38 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 264 seconds]
10:45 -!- niiil [~shizzler@2a02:aa13:e47f:2c00:9ddb:d116:b52b:125b] has joined #bitcoin-core-dev
10:52 -!- promag [~promag@83.223.233.51] has joined #bitcoin-core-dev
10:52 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.3]
10:56 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
10:57 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev
10:57 -!- shesek [~shesek@185.3.147.193] has quit [Changing host]
10:57 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
10:58 -!- Krellan [~Krellan@2601:640:4000:a876:5cb4:cd8b:14a6:8cfd] has quit [Remote host closed the connection]
10:59 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
10:59 < MarcoFalke> 6:59 PM
11:00 < wumpus> #startmeeting
11:00 < lightningbot> Meeting started Thu Nov 15 19:00:04 2018 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
11:00 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
11:00 < wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr btcdrak sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator
11:00 < provoostenator> hi
11:00 < meshcollider> hi
11:00 < promag> hi
11:00 < kanzure> hi.
11:00 < wumpus> proposed topics?
11:01 -!- ezzzy [~ezzzy@unaffiliated/ezzzy] has quit [Remote host closed the connection]
11:02 < wumpus> #topic high priority for review
11:02 < sipa> hi.
11:03 < phantomcircuit> hi
11:03 < wumpus> https://github.com/bitcoin/bitcoin/projects/8  current high priority PRs are by luke-jr promag achow101 phantomcircuit sipa 
11:03 < meshcollider> Maybe #14552
11:03 < wumpus> anything to add or remove for this week?
11:03 < gribble> https://github.com/bitcoin/bitcoin/issues/14552 | wallet: detecting duplicate wallet by comparing the db filename. by ken2812221 · Pull Request #14552 · bitcoin/bitcoin · GitHub
11:03 < instagibbs> hi
11:04 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 240 seconds]
11:04 < wumpus> meshcollider: added
11:04 < meshcollider> Thanks
11:04 < promag> regarding #14670, it is possible to have appveyor rebase on that instead of master?
11:04 < gribble> https://github.com/bitcoin/bitcoin/issues/14670 | http: Fix HTTP server shutdown by promag · Pull Request #14670 · bitcoin/bitcoin · GitHub
11:04 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
11:04 -!- ezzzy [~ezzzy@unaffiliated/ezzzy] has joined #bitcoin-core-dev
11:04 -!- clarkmoody [~clarkmood@47-218-248-206.bcstcmta04.res.dyn.suddenlink.net] has joined #bitcoin-core-dev
11:05 < wumpus> luke-jr: please rebase #14532
11:05 < gribble> https://github.com/bitcoin/bitcoin/issues/14532 | Never bind INADDR_ANY by default, and warn when doing so explicitly by luke-jr · Pull Request #14532 · bitcoin/bitcoin · GitHub
11:05 < wumpus> (should be a small change)
11:05 < provoostenator> I like to nominate #11082
11:05 < gribble> https://github.com/bitcoin/bitcoin/issues/11082 | Add new bitcoin_rw.conf file that is used for settings modified by this software itself by luke-jr · Pull Request #11082 · bitcoin/bitcoin · GitHub
11:05 < promag> I saw several connection problems in some PR's in appveyor and I think 14670 fixes that
11:05 < provoostenator> Since I have PR that depends on that.
11:05 < wumpus> provoostenator: I don't know anything about appveyor
11:06 < MarcoFalke> promag: You'd have to fixup the appveyor yaml, I'd presume
11:06 < wumpus> provoostenator: luke-jr already has a PR
11:06 < wumpus> really, let's try to get the INADDR_ANY in, it's silly that it takes so long
11:06 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: No route to host]
11:06 < wumpus> it's an important security issue in a way
11:07 < wumpus> buut I'm fine with adding the _rw one as well if others agree...
11:07 < promag> MarcoFalke: you mean manually rebase? because from https://www.appveyor.com/docs/appveyor-yml/ I don't see that's possible out of the box
11:08 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev
11:08 -!- shesek [~shesek@185.3.147.193] has quit [Changing host]
11:08 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
11:09 < MarcoFalke> Git should be installed on the machine, so you could do "git fetch https://github.com/promag/bitcoin branch && git merge FETCH_HEAD" before compiling?
11:10 < promag> MarcoFalke: do you think that could go to master temporally?
11:11 < provoostenator> wumpus: I'm fine with waiting until this more urgent PR is done, I'll try to help with review
11:11 < sipa> i think merging it is preferable
11:11 < sipa> (after review, of course)
11:12 < wumpus> merging it is certainly preferable, if we can be confident of it
11:12 < promag> ok then
11:13 < phantomcircuit> wumpus, im reviewing that one now 
11:13 < MarcoFalke> phantomcircuit: Thx
11:13 < wumpus> it's the so-manieth time that particular part of the code was fixed, so I certainly understand people are a bit skeptical, you'll need very good tests
11:13 < phantomcircuit> the IsBindAny looks wrong actually...
11:15 < phantomcircuit> unless GetByte does some magic
11:15 < wumpus> let's review in the PR :)
11:15 < wumpus> any other topics?
11:15 < phantomcircuit> true sorry
11:16 < sipa> short reminder: wallet meeting tomorrow, same time
11:16 < wumpus> #action wallet meeting tomorrow, same time (friday 19:00 UTC)
11:18 < wumpus> this is a short meeting I suppose!
11:19 < sipa> seems so
11:19 < wumpus> #endmeeting
11:19 < lightningbot> Meeting ended Thu Nov 15 19:19:58 2018 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
11:19 < lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-11-15-19.00.html
11:19 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-11-15-19.00.txt
11:19 < lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2018/bitcoin-core-dev.2018-11-15-19.00.log.html
11:20 < meshcollider> Very short :)
11:21 < provoostenator> Sorry, a bit distracted by a certain fork.
11:22 -!- laptop__ [~laptop@host86-133-255-215.range86-133.btcentralplus.com] has joined #bitcoin-core-dev
11:23 -!- laptop__ [~laptop@host86-133-255-215.range86-133.btcentralplus.com] has quit [Client Quit]
11:23 -!- laptop__ [~laptop@host86-133-255-215.range86-133.btcentralplus.com] has joined #bitcoin-core-dev
11:25 -!- clarkmoody [~clarkmood@47-218-248-206.bcstcmta04.res.dyn.suddenlink.net] has quit []
11:26 -!- JackH [~laptop@host86-133-255-215.range86-133.btcentralplus.com] has quit [Ping timeout: 240 seconds]
11:26 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
11:27 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev
11:27 -!- shesek [~shesek@185.3.147.193] has quit [Changing host]
11:27 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
11:27 -!- fabianfabian [~fabianfab@D9656CCE.cm-27.dynamic.ziggo.nl] has quit [Ping timeout: 250 seconds]
11:27 -!- atroxes [~atroxes@unaffiliated/atroxes] has quit [Quit: bye]
11:28 -!- atroxes [~atroxes@unaffiliated/atroxes] has joined #bitcoin-core-dev
11:29 -!- atroxes [~atroxes@unaffiliated/atroxes] has quit [Client Quit]
11:32 -!- GoatzMilk [~GoatzMilk@ip98-165-53-119.ph.ph.cox.net] has quit [Remote host closed the connection]
11:34 -!- promag [~promag@83.223.233.51] has quit [Remote host closed the connection]
11:36 -!- conekins13 [~conekins@186.104.175.102] has joined #bitcoin-core-dev
11:36 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
11:36 -!- conekins13 [~conekins@186.104.175.102] has quit [Remote host closed the connection]
11:37 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
11:39 -!- jarthur [~jarthur@207.114.244.5] has quit [Quit: Gotta focus]
11:40 -!- oneark [uid254801@gateway/web/irccloud.com/x-trdbeossllivipfc] has quit [Quit: Connection closed for inactivity]
11:40 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-aneclqjdygmeufaw] has joined #bitcoin-core-dev
11:40 < bitcoin-git> [bitcoin] MarcoFalke pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/e74649e95122...384967f311b4
11:40 < bitcoin-git> bitcoin/master 7c5bc2a practicalswift: miner: Default to DEFAULT_BLOCK_MIN_TX_FEE if unable to parse -blockmintxfee
11:40 < bitcoin-git> bitcoin/master 145fe95 practicalswift: tests: Check return value of ParseParameters(...)
11:40 < bitcoin-git> bitcoin/master 579497e practicalswift: tests: Explicitly ignore the return value of DecodeBase58(...)
11:40 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-aneclqjdygmeufaw] has left #bitcoin-core-dev []
11:41 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-twhpuhjzqjzhmyaw] has joined #bitcoin-core-dev
11:41 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #13815: util: Add [[nodiscard]] to all {Decode,Parse}[...](...) functions returning bool (master...check-return-values-from-parse) https://github.com/bitcoin/bitcoin/pull/13815
11:41 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-twhpuhjzqjzhmyaw] has left #bitcoin-core-dev []
11:41 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
11:48 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
11:49 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev
11:49 -!- shesek [~shesek@185.3.147.193] has quit [Changing host]
11:49 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
11:50 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev
11:51 -!- ezzzy [~ezzzy@unaffiliated/ezzzy] has quit [Remote host closed the connection]
11:52 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
11:54 -!- ezzzy [~ezzzy@unaffiliated/ezzzy] has joined #bitcoin-core-dev
11:57 < phantomcircuit> sipa, had any issues with the poll server?
11:58 < sipa> phantomcircuit: no
11:58 < sipa> currently running with 160 connections
12:00 < phantomcircuit> sipa, do we have anything that will exercise the performance?
12:00 < phantomcircuit> like try to do ibd or something
12:00 -!- Murch [~murch@46.183.103.8] has joined #bitcoin-core-dev
12:00 < phantomcircuit> but x100 nodes
12:00 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: No route to host]
12:01 < sipa> jamesob: ^
12:05 -!- ezzzy [~ezzzy@unaffiliated/ezzzy] has quit [Remote host closed the connection]
12:05 -!- grubles [~grubles@unaffiliated/grubles] has quit [Remote host closed the connection]
12:07 -!- ezzzy [~ezzzy@unaffiliated/ezzzy] has joined #bitcoin-core-dev
12:09 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev
12:09 -!- shesek [~shesek@185.3.147.193] has quit [Changing host]
12:09 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
12:11 -!- Murchone [~murch@172.56.13.6] has joined #bitcoin-core-dev
12:12 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: No route to host]
12:13 -!- Murch [~murch@46.183.103.8] has quit [Ping timeout: 268 seconds]
12:14 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
12:24 -!- Murchone [~murch@172.56.13.6] has quit [Quit: Snoozing.]
12:26 -!- ezzzy [~ezzzy@unaffiliated/ezzzy] has quit [Remote host closed the connection]
12:27 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!]
12:29 -!- rex4539 [~rex4539@ppp-2-84-165-183.home.otenet.gr] has quit [Read error: Connection reset by peer]
12:33 -!- Murch [~murch@172.56.13.6] has joined #bitcoin-core-dev
12:34 -!- fabianfabian [~fabianfab@D9656CCE.cm-27.dynamic.ziggo.nl] has joined #bitcoin-core-dev
12:36 -!- grubles [~grubles@unaffiliated/grubles] has joined #bitcoin-core-dev
12:41 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
12:42 -!- Murch [~murch@172.56.13.6] has quit [Quit: Snoozing.]
12:53 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
12:57 -!- Murch [~murch@172.56.12.90] has joined #bitcoin-core-dev
13:01 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection]
13:08 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 244 seconds]
13:08 -!- Murch [~murch@172.56.12.90] has quit [Quit: Snoozing.]
13:12 < stevenroose> who is maintaining the gnusha.org logs? Are they open to adding more channels? We were thinging we'd love one for #rust-bitcoin
13:12 < stevenroose> dongcarl: ^ there, I asked ;)
13:12 -!- mistergold [~mistergol@185.37.26.18] has quit [Quit: leaving]
13:12 < luke-jr> wumpus: unable to do so at the moment, and too tied up with other work to fix :/
13:12 < dongcarl> stevenroose: ah, I got the answer, it's kanzure 
13:13 < luke-jr> re bitcoin_rw, reminder that things *don't* have to be high-prio for review, to be reviewed
13:15 < stevenroose> dongcarl: ah oops
13:18 -!- jimmy [c0e62e8b@gateway/web/freenode/ip.192.230.46.139] has joined #bitcoin-core-dev
13:19 -!- jimmy [c0e62e8b@gateway/web/freenode/ip.192.230.46.139] has quit [Client Quit]
13:24 -!- rex4539 [~rex4539@ppp-2-84-165-183.home.otenet.gr] has joined #bitcoin-core-dev
13:27 -!- n1bor [~n1bor@185.9.34.66] has joined #bitcoin-core-dev
13:37 -!- Vita [5d6c9993@gateway/web/freenode/ip.93.108.153.147] has joined #bitcoin-core-dev
13:38 < Vita> Zk proof of identity + POS or PoW with a hashing/staking hardcap.
13:38 < Vita> 1 - Prevents recentralization
13:40 < Vita> 2 - Allows and motivates scalability (implement a variable cap with formula Cap(throughput))
13:40 < sipa> Vita: #bitcoin-wizards or so, off topic here
13:40 < Vita> 3 - Conserves security
13:41 -!- bralyclow [~bralyclow@195.242.213.119] has quit [Ping timeout: 250 seconds]
13:41 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
13:42 -!- Vita [5d6c9993@gateway/web/freenode/ip.93.108.153.147] has quit [Client Quit]
13:45 -!- bralyclow [~bralyclow@195.242.213.119] has joined #bitcoin-core-dev
13:46 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
13:54 -!- dqx_ [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev
13:57 -!- bitconner [~conner@136.24.75.121] has joined #bitcoin-core-dev
14:01 -!- michaelfolkson [~textual@host86-145-25-239.range86-145.btcentralplus.com] has joined #bitcoin-core-dev
14:07 -!- niiil [~shizzler@2a02:aa13:e47f:2c00:9ddb:d116:b52b:125b] has quit [Ping timeout: 252 seconds]
14:11 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has joined #bitcoin-core-dev
14:12 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
14:16 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev
14:16 -!- shesek [~shesek@185.3.147.193] has quit [Changing host]
14:16 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
14:19 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 252 seconds]
14:22 -!- Murch [~murch@p579488D7.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
14:24 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
14:25 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection]
14:27 -!- dqx_ [~dqx@unaffiliated/dqx] has quit [Ping timeout: 252 seconds]
14:27 -!- face [~face@80.72.82.160.coresnet.bg] has quit [Ping timeout: 240 seconds]
14:27 -!- dqx_ [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev
14:38 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
14:38 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
14:41 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
14:42 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
14:43 -!- instagibbs [~instagibb@pool-100-15-135-248.washdc.fios.verizon.net] has quit [Ping timeout: 245 seconds]
14:44 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Ping timeout: 256 seconds]
14:45 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
14:46 -!- millerti [~millerti@cpe-66-24-91-119.stny.res.rr.com] has quit [Ping timeout: 268 seconds]
14:47 -!- instagibbs [~instagibb@pool-100-15-135-248.washdc.fios.verizon.net] has joined #bitcoin-core-dev
14:48 < phantomcircuit> sipa, is there a sorted_vector class i can just use?
14:49 < phantomcircuit> i dont think the performance gain is worth making the code more complex
14:49 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev
14:49 < phantomcircuit> the only real solution to it is ultimately to register for and release events
14:49 < sipa> just add stuff to a vector, and call std::sort(v.begin(), v.end()); before returning it
14:49 < phantomcircuit> (which would make a switch to libevent easier)
14:50 < phantomcircuit> but that's way harder to get right
14:50 < sipa> but a wrapper would be neat, which exposes an efficient find
14:50 < sipa> like frozenset in python
14:50 -!- Emcy [~Emcy@unaffiliated/emcy] has left #bitcoin-core-dev ["Leaving"]
14:51 < phantomcircuit> hmm i guess that cant have duplicated entries either so it doesn't need to check for inclusion first
14:51 < sipa> indeed
14:51 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
14:52 < sipa> phantomcircuit: i think it's not worth the code complexity in your PR though
14:52 < phantomcircuit> with ~100 connections SocketEvents is using 15x the cpu time though
14:53 < phantomcircuit> so im not sure any change to the select set logic is worth it
14:53 < sipa> 15x compared to what?
14:53 -!- hex17or [~textual@2a02:8071:ba7:d300:75c6:2f1b:b295:cfb5] has joined #bitcoin-core-dev
14:54 < phantomcircuit> sipa, compared to GenerateSelectSets
15:04 -!- booyah [~bb@193.25.1.157] has quit [Read error: Connection reset by peer]
15:05 -!- booyah [~bb@193.25.1.157] has joined #bitcoin-core-dev
15:09 -!- fabianfabian [~fabianfab@D9656CCE.cm-27.dynamic.ziggo.nl] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
15:19 -!- hex17or [~textual@2a02:8071:ba7:d300:75c6:2f1b:b295:cfb5] has quit [Quit: Textual IRC Client: www.textualapp.com]
15:29 < phantomcircuit> sipa, im not sure how to make the socketevents method faster without having duplicate pollfd entries
15:30 < phantomcircuit> which seem to cause problems (at least on os x)
15:30 < sipa> phantomcircuit: how does allowing duplicates make it faster?
15:31 -!- cubancorona [cubancoron@gateway/vpn/privateinternetaccess/cubancorona] has quit [Quit: Leaving]
15:32 -!- promag [~promag@bl22-247-244.dsl.telepac.pt] has quit [Remote host closed the connection]
15:40 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]
15:41 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
15:41 < phantomcircuit> sipa, currently i have a map and that needs to be converted to a vector for the actual poll() call
15:41 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
15:42 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 276 seconds]
15:42 -!- michaelfolkson [~textual@host86-145-25-239.range86-145.btcentralplus.com] has quit [Quit: Sleep mode]
15:42 < phantomcircuit> the map lookup/change is slower than the vector push_back
15:42 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-rrhuytauitpgxiou] has joined #bitcoin-core-dev
15:42 < bitcoin-git> [bitcoin] zallarak opened pull request #14733: p2p: allow p2ptimeout to be configurable, speed up slow test (master...p2ptimeout) https://github.com/bitcoin/bitcoin/pull/14733
15:42 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-rrhuytauitpgxiou] has left #bitcoin-core-dev []
15:43 < phantomcircuit> there's some optimization i can do but i doubt it'll have a huge impact
15:43 < sipa> phantomcircuit: can you show me the code you have with the map?
15:43 < phantomcircuit> sipa, https://github.com/bitcoin/bitcoin/pull/14336/commits/47526062bae7af5309156ef4ab9c2b25310f5c35#diff-9a82240fe7dfe86564178691cc57f2f1R1324
15:45 < sipa> phantomcircuit: start by using an unordered_map ?
15:47 < phantomcircuit> sipa, will do
15:47 < phantomcircuit> i guess i'll do the rest to one sec
15:47 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
15:47 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 252 seconds]
15:48 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
15:48 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
15:48 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
15:49 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection]
15:50 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev
15:50 -!- hex17or [~hex17or@2a02:8071:ba7:d300:75c6:2f1b:b295:cfb5] has joined #bitcoin-core-dev
15:51 < phantomcircuit> sipa, actually the other one is super annoying
15:51 < phantomcircuit> setting the fd and the events bitfield that way does two lookups when i only have to do one
15:54 -!- murrayn [~murrayn@unaffiliated/murrayn] has quit [Ping timeout: 252 seconds]
15:55 < sipa> phantomcircuit: do you hate template magic?
15:56 < sipa> we could make GenerateSelectSets a templated function that takes as input a callback for each thing to listen to, which will be different for the select and the poll based implementation
15:56 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev
15:56 < sipa> and by using a template that won't be a runtime function pointer, but an inlinable piece of code
15:57 -!- hex17or [~hex17or@2a02:8071:ba7:d300:75c6:2f1b:b295:cfb5] has quit [Quit: Textual IRC Client: www.textualapp.com]
15:57 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
16:01 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Ping timeout: 244 seconds]
16:02 -!- jarthur [~jarthur@207.114.244.5] has quit []
16:02 -!- murrayn [~murrayn@unaffiliated/murrayn] has joined #bitcoin-core-dev
16:22 -!- rockstarjack [~admin@184.75.221.203] has joined #bitcoin-core-dev
16:29 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 256 seconds]
16:31 -!- michaelfolkson [~textual@host86-145-25-239.range86-145.btcentralplus.com] has joined #bitcoin-core-dev
16:34 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev
16:41 < phantomcircuit> sipa, sort of
16:41 -!- michaelfolkson [~textual@host86-145-25-239.range86-145.btcentralplus.com] has quit [Quit: Sleep mode]
16:41 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
16:44 -!- irc_viewer_test [irc_viewer@gateway/vpn/privateinternetaccess/ircviewertest/x-06412631] has joined #bitcoin-core-dev
16:45 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Ping timeout: 252 seconds]
16:45 -!- irc_viewer_test [irc_viewer@gateway/vpn/privateinternetaccess/ircviewertest/x-06412631] has quit [Client Quit]
16:51 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
17:00 < phantomcircuit> sipa, switching to unordered_map had basically no effect
17:01 -!- michaelsdunn1 [~michaelsd@208.59.170.5] has joined #bitcoin-core-dev
17:01 -!- michaelsdunn1 [~michaelsd@208.59.170.5] has quit [Changing host]
17:01 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev
17:13 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
17:14 -!- zhangzf [~zhangzf@1.202.169.235] has joined #bitcoin-core-dev
17:21 -!- dqx_ [~dqx@unaffiliated/dqx] has quit [Quit: .]
17:27 -!- Murch [~murch@p579488D7.dip0.t-ipconnect.de] has quit [Quit: Snoozing.]
17:27 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection]
17:28 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev
17:28 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection]
17:31 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev
17:38 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-abfsmqclscrffufx] has joined #bitcoin-core-dev
17:38 < bitcoin-git> [bitcoin] kazcw opened pull request #14734: fix an undefined behavior in uint::SetHex (master...SetHex-bad-ptr) https://github.com/bitcoin/bitcoin/pull/14734
17:38 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-abfsmqclscrffufx] has left #bitcoin-core-dev []
17:41 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
17:46 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection]
17:47 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev
17:48 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection]
17:50 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev
17:50 -!- shesek [~shesek@185.3.147.193] has quit [Changing host]
17:50 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
17:51 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
17:52 -!- instagibbs [~instagibb@pool-100-15-135-248.washdc.fios.verizon.net] has quit [Ping timeout: 260 seconds]
17:52 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
17:53 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 264 seconds]
17:53 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev
17:53 -!- shesek [~shesek@185.3.147.193] has quit [Changing host]
17:53 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
17:56 -!- rhavar [uid237883@gateway/web/irccloud.com/x-cijwflmqqsvjaamr] has quit [Quit: Connection closed for inactivity]
18:11 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
18:22 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 272 seconds]
18:26 -!- instagibbs [~instagibb@pool-100-15-135-248.washdc.fios.verizon.net] has joined #bitcoin-core-dev
18:30 < phantomcircuit> sipa, moving the buildpollfd logic into another method made the performance impact of socketevents disappear
18:30 < phantomcircuit> im confused
18:39 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: No route to host]
18:40 -!- shesek [~shesek@185.3.147.193] has joined #bitcoin-core-dev
18:40 -!- shesek [~shesek@185.3.147.193] has quit [Changing host]
18:40 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
18:42 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
18:42 -!- instagibbs [~instagibb@pool-100-15-135-248.washdc.fios.verizon.net] has quit [Ping timeout: 252 seconds]
18:44 -!- instagibbs [~instagibb@pool-100-15-135-248.washdc.fios.verizon.net] has joined #bitcoin-core-dev
18:52 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
18:53 -!- instagibbs [~instagibb@pool-100-15-135-248.washdc.fios.verizon.net] has quit [Quit: ZNC 1.6.3+deb1 - http://znc.in]
18:56 < phantomcircuit> sipa, oh the profile is messed up by importing mempool
19:03 -!- bitconner [~conner@136.24.75.121] has quit [Ping timeout: 246 seconds]
19:10 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection]
19:31 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has quit [Quit: leaving]
19:39 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
19:44 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 250 seconds]
19:51 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection]
19:52 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev
20:00 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
20:01 -!- niiil [~shizzler@2a02:aa13:e47f:2c00:9ddb:d116:b52b:125b] has joined #bitcoin-core-dev
20:06 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
20:08 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 252 seconds]
20:11 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
20:12 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 268 seconds]
20:21 -!- Sinclai__ [~sinclair6@108-75-18-87.lightspeed.clmboh.sbcglobal.net] has quit []
20:24 -!- Dizzle [~Dizzle@unaffiliated/dizzle] has joined #bitcoin-core-dev
20:26 < Dizzle> sipa or anyone that might know... does TestBlockValidity end up adding new valid blocks to the chain?
20:27 < Dizzle> It calls CChainState::ConnectBlock, but I couldn't figure out if that actually adds the new block to the chain
20:32 < Dizzle> Or morcos?
20:35 -!- ap4lmtree [~ap4lmtree@unaffiliated/ap4lmtree] has quit [Read error: Connection reset by peer]
20:36 < achow101> sipa: can you rebase #14565?
20:36 < gribble> https://github.com/bitcoin/bitcoin/issues/14565 | Overhaul importmulti logic by sipa · Pull Request #14565 · bitcoin/bitcoin · GitHub
20:36 < achow101> so we can rebase all the things on top of it
20:37 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
20:38 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
20:42 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
20:47 -!- niiil [~shizzler@2a02:aa13:e47f:2c00:9ddb:d116:b52b:125b] has quit [Ping timeout: 252 seconds]
20:49 < luke-jr> Dizzle: it doesn't, and generally isn't expected to be called with mined blocks
20:49 < luke-jr> Dizzle: note it does not perform the PoW check
20:50 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
20:57 -!- niiil [~shizzler@185.12.131.91] has joined #bitcoin-core-dev
20:58 -!- helo [~helo@unaffiliated/helo] has quit [Remote host closed the connection]
21:04 -!- niiil [~shizzler@185.12.131.91] has quit [Ping timeout: 268 seconds]
21:16 -!- Dizzle [~Dizzle@unaffiliated/dizzle] has quit [Remote host closed the connection]
21:22 -!- Victor_sueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
21:22 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]
21:23 -!- ap4lmtree [~ap4lmtree@unaffiliated/ap4lmtree] has joined #bitcoin-core-dev
21:26 -!- oneark [uid254801@gateway/web/irccloud.com/x-ugkmcmrjrwictzsi] has joined #bitcoin-core-dev
21:27 -!- Dizzle_ [~Dizzle@unaffiliated/dizzle] has joined #bitcoin-core-dev
21:28 < Dizzle_> luke-jr: if the mined block is proposed to Bitcoin Core via getblock template, it gets called, and I couldn't find an indication that a valid proposal gets submitted by Core.
21:28 < Dizzle_> *getblocktemplate
21:30 -!- Dizzle_ is now known as Dizzle
21:31 < Dizzle> I'm assuming a pool implementing gbt would submit a valid proposal to their p2p and fibre peers?
21:32 < luke-jr> Dizzle: mined blocks aren't supposed to be proposed in that manner, they're supposed to be fed to submitblock
21:32 < luke-jr> a pool could, but clients shouldn't assume they will
21:32 < luke-jr> Dizzle: proposals are for checking that the block is valid BEFORE mining it
21:32 -!- ap4lmtree [~ap4lmtree@unaffiliated/ap4lmtree] has quit [Read error: Connection reset by peer]
21:36 < Dizzle> luke-jr: ahhh, thanks! That was the missing piece of the puzzle for me. I was thinking it was like getwork(data)
21:36 -!- niiil [~shizzler@185.12.131.108] has joined #bitcoin-core-dev
21:37 < luke-jr> did you read the BIP? <.<
21:37 < luke-jr> https://github.com/bitcoin/bips/blob/master/bip-0022.mediawiki#Block_Submission
21:37 < Dizzle> I did. It didn't really define what a proposal was, just how to construct one
21:37 < luke-jr> hmm
21:39 -!- Ga1aCt1Cz00__ [~Ga1aCt1Cz@p2003005F6E1F7C3680CF4C900DB8AD43.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
21:41 < Dizzle> Not your fault. I didn't jump into this knowing mining especially well. So proposal is for something like, "If I were to change the coinbase to spend coins to myself, would you accept the mined block when I submit it?"?
21:41 -!- niiil [~shizzler@185.12.131.108] has quit [Ping timeout: 268 seconds]
21:42 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
21:43 < luke-jr> Dizzle: if the BIP is unclear, it is indeed my fault :P
21:43 -!- Ga1aCt1Cz00_ [~Ga1aCt1Cz@p2003005F6E1F7C991CE74F716B0A0EE4.dip0.t-ipconnect.de] has quit [Ping timeout: 276 seconds]
21:43 < luke-jr> Dizzle: in bitcoind's case, you have to make the coinbase from scratch, but otherwise yes
21:44 < Dizzle> Sweet. Thanks! Heading out for the night.
21:45 -!- Dizzle [~Dizzle@unaffiliated/dizzle] has quit [Quit: Leaving...]
21:48 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
21:51 -!- niiil [~shizzler@46.140.141.178] has joined #bitcoin-core-dev
21:53 -!- ap4lmtree [~ap4lmtree@unaffiliated/ap4lmtree] has joined #bitcoin-core-dev
22:11 -!- stone2018 [c6af6815@gateway/web/freenode/ip.198.175.104.21] has joined #bitcoin-core-dev
22:41 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
22:47 -!- niiil [~shizzler@46.140.141.178] has quit [Ping timeout: 245 seconds]
22:48 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
22:52 -!- niiil [~shizzler@46.140.141.178] has joined #bitcoin-core-dev
23:03 < gmaxwell> luke-jr: I guess it wouldn't be bad for it to actually accept it, if it turned out to be valid.
23:09 < luke-jr> no, other than setting up a false expectation
23:15 -!- face [~face@80.72.82.160.coresnet.bg] has joined #bitcoin-core-dev
23:21 -!- stone2018 [c6af6815@gateway/web/freenode/ip.198.175.104.21] has quit [Quit: Page closed]
23:30 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
23:35 -!- bitconner [~conner@c-73-170-56-77.hsd1.ca.comcast.net] has quit [Ping timeout: 260 seconds]
23:41 -!- queip [~queip@unaffiliated/rezurus] has quit [Read error: Connection reset by peer]
23:44 -!- niiil [~shizzler@46.140.141.178] has quit [Read error: Connection reset by peer]
23:46 -!- fabianfabian [~fabianfab@D9656CCE.cm-27.dynamic.ziggo.nl] has joined #bitcoin-core-dev
23:53 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
23:53 -!- niiil [~shizzler@46.140.141.178] has joined #bitcoin-core-dev
--- Log closed Fri Nov 16 00:00:22 2018