--- Log opened Wed Nov 28 00:00:13 2018 --- Day changed Wed Nov 28 2018 00:00 < NicolasDorier> ah indeed that would work 00:00 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 00:00 < aj> (which i assume is gettxoutsetinfo -> hash_serialized_2 ? 00:01 < NicolasDorier> aj: Another idea: They use my hash to sync a new node. Then they compare the utxoset to their own node 00:01 < aj> if they have their own node, why don't they just copy their utxo set across? 00:02 < NicolasDorier> because it is pain in the ass. I want a user friendly way to put a big UTXO set tar somewhere on the cloud that people starting a new raspberry pi can rely on to get synched quick 00:04 < aj> NicolasDorier: that sounds fine, seems odd to expect them to already have a node is all 00:05 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 00:09 < NicolasDorier> aj: At least for the reviewers. People running those "bitcoin core in a box" are already blindly trusting binaries anyway. 00:10 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection] 00:10 < NicolasDorier> but if somebody takes time to review the code, I want him at least to be able to check that the hash I hard coded is not malicious given he has his own indendant node. 00:13 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 00:14 < sipa> NicolasDorier: i fear "user friendly" and "auditable full node security without central point of trust" are not really compatible 00:14 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 00:14 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 268 seconds] 00:16 < aj> NicolasDorier: err? i was thinking in-a-box users blindly trust the hash, but the software automatically checks the utxo set they download matches the hash; that way reviewers don't generally have to download your utxo set at all (they just check the hash matches the one their node generates) 00:19 < NicolasDorier> aj: The problem is, if I ship the UTXO Set up to block 500.000 there is no way in Core that the hash of this UTXO set match their node. The only way is that they take my UTXO Set up to 500.000, then let it sync to the latest block, then check that the two nodes (the one they trust, and the one where they used this UTXO set) match. 00:19 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 00:19 < NicolasDorier> "there is no way to *check in core" I mean 00:20 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 00:20 < sipa> why do you need the utxo set? 00:20 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 00:21 < NicolasDorier> sipa: well to check the payments are real? :p 00:21 < sipa> NicolasDorier: why do you need the historical utxo set? 00:21 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 00:22 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 00:22 < NicolasDorier> So that raspberry pi user can sync fast. They would download it the utxo set at block 500.000 then sync up to the latest block. 00:23 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 00:24 < sipa> NicolasDorier: i feel that introducing a convenient way to run a "full nkde" that relies on too centralized ways of determining that set is far worse than using a loght client 00:24 < aj> NicolasDorier: if you're doing rc1 of your next release now, why wouldn't you pick a recent hash, say 200 blocks old like 551600? invalidateblock/txoutsetinfo only takes a couple of minutes to run to review that? 00:25 < NicolasDorier> aj: yep true, this would work 00:28 < aj> $ time (blk=$(bitcoin-cli getblockhash 551601); echo $blk; bitcoin-cli invalidateblock $blk; bitcoin-cli gettxoutsetinfo | grep hash_serial; bitcoin-cli reconsiderblock $blk) # --> 666550387c3f5fa8e9353ce561fcee2a164022d31b97affd7c982388f19a4904as the hash, took about 1m12 all up 00:28 < NicolasDorier> sipa: Given I trust my software and my software can check the tar shasum of the "historical utxoset at block 500.000", then it is fine. 00:28 < NicolasDorier> Now how do I trust the software? By reviewing the code. But by reviewing the code I see this shasum of historical utxoset. How can I review this hash? 00:28 < NicolasDorier> Either by doing what aj said (invalidateblock up to the height) or just using this UTXO set to sync up to now and cross check that UTXO set hash of this node is the same than another of my node that I fully synched from the beginning. 00:28 < NicolasDorier> aj: though the invalidateblock is not possible if the node you trust is pruned 00:29 < aj> NicolasDorier: going back a few hundred blocks should be fine even if it's pruned 00:29 < NicolasDorier> Yes true, this would work as well 00:31 < NicolasDorier> While I distribute the UTXO set centrally, and ship this hash in the product, anybody would be able to check against it. 00:31 < sipa> i don't like "anyone can check" 00:31 < sipa> people don't 00:32 < gmaxwell> the ethereum ecosystem shows this pretty perfectly... node falls behind, blindly accept the state. 00:33 < gmaxwell> people don't check. And any that did would just check some centeralized website. The security in that case is pure pretext. 00:33 < NicolasDorier> Well as people blindly run binaries shipped by core, and don't check they can reproduce the build. But at least checking this hash is easier than doign a gitian build. 00:34 < gmaxwell> a lot of people do check that they can reproduce the build, and publish attestations too. 00:34 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 00:34 < NicolasDorier> then why would they not do it for the hash? 00:34 < aj> sipa: the alternative to "don't check but can" that people will actually adopt is "don't check and can't" though, which seems worse... 00:35 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 00:35 < gmaxwell> I think it's not worse. 00:35 < sipa> aj: that's fair 00:35 < gmaxwell> a _dishonest_ security model is worse than being insecure in practice and lying to the whole world and yourself about it. 00:36 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 00:36 < gmaxwell> maybe more people should have given a shit since _2011_ that making it absurdly expensive to sync would be a problem. 00:36 < gmaxwell> and instead worked to prevent that instead of taking an unsustainable load and doubling it. 00:36 < gmaxwell> but whats past is past. 00:36 < NicolasDorier> well this would have happened one day or another 00:37 < sipa> NicolasDorier: just so we're talking about the same thing, i do not think it is inherently necessary that every full nkde forever validates all of history 00:38 < gmaxwell> not necessarily, e.g. the work by phantomcircuit and luke-jr that showed the maximum rate of blockchain increase that would have kept sync time constant under the assumption of some year over year percentage increase in sync performance. 00:38 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 00:38 < gmaxwell> in 2015 the figure for that would have been roughly 300kbyte blocks. 00:38 < gmaxwell> in any case, water under the bridge. 00:39 < gmaxwell> It sound like whats previously been proposed for utxo assumevalid would work fine for you, except it doesn't exist yet. 00:39 < sipa> there are perfectly reasonable solutions to avoid that, including a deeply buried infrequently updated assumevalid utxo set hash 00:39 < NicolasDorier> I would like at least that node which do not fully validate has a way to ring the bells if their utxo stop matching with other people, or with their own node on a different server which fully validated everything. 00:39 < gmaxwell> Please do not poison the well by proposing "check against a website"... all that is going to do is create a big fight over it and cause people to also fight against more reasonable measures. 00:40 < NicolasDorier> yeah no worry I won't do this 00:40 < gmaxwell> if their software is malicious then there is no way they can count on it to warn them... 00:42 < aj> gmaxwell: if their software isn't malicious but the utxo download site is, they could get a warning at least 00:43 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has quit [Ping timeout: 240 seconds] 00:44 < gmaxwell> aj: download site? it should be getting it from the network and checking it against the software. 00:46 < aj> gmaxwell: maybe, but there's a lot more implementation to do for that 00:46 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 00:47 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 00:47 < aj> gmaxwell: well, unless you're happy with "network" being "torrent of the utxo set at a point in time" 00:47 < gmaxwell> It's been implemented before. 00:48 < aj> gmaxwell: for a utxo set up to 6 or 8 months old, or just the current (rolling) utxo set? 00:48 < gmaxwell> I guess like actually improving the protocol might get in the way of five refactors a day. 00:48 < sipa> come on 00:48 < gmaxwell> aj: there was a snapshot one implemented previously. 00:50 < gmaxwell> It has been _years_ now since we've made a protocol improvement, and when an need gets brought up for one it seems like it's just a question of how fast we could enable trusting a website... 00:50 < gmaxwell> It's bad enough when people outside of regular development act helpless about limitations that could be improved. 00:50 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 00:51 < aj> gmaxwell: url or search term suggestion for the previous implementation? 00:52 < gmaxwell> some randos github repo-- they didn't hang around and keep trying to contribute when their efforts didn't make prompt progress, I'm searching 00:53 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 00:54 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev 01:04 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 01:05 -!- shesek [~shesek@5.22.134.237] has joined #bitcoin-core-dev 01:05 -!- shesek [~shesek@5.22.134.237] has quit [Changing host] 01:05 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 01:05 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-nyoendiquaxofjgb] has joined #bitcoin-core-dev 01:06 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev 01:08 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has quit [Quit: Snoozing.] 01:10 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 01:11 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has quit [Ping timeout: 246 seconds] 01:15 < cjd> I was quite impressed by Peter's work on UTXO proofs 01:17 < cjd> ( https://petertodd.org/2016/delayed-txo-commitments ) 01:17 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 01:17 < midnightmagic> holy crap cjd is talking \o 01:17 < cjd> hey midnight, long time no see :) 01:17 < midnightmagic> :-) 01:17 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-uwrtqblprzbmwxxn] has joined #bitcoin-core-dev 01:17 < bitcoin-git> [bitcoin] Mountains-and-rivers opened pull request #14825: 0.17 (master...0.17) https://github.com/bitcoin/bitcoin/pull/14825 01:17 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-uwrtqblprzbmwxxn] has left #bitcoin-core-dev [] 01:18 -!- shesek [~shesek@5.22.134.237] has joined #bitcoin-core-dev 01:18 -!- shesek [~shesek@5.22.134.237] has quit [Changing host] 01:18 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 01:18 < sipa> cjd: there has been more recent work around that too 01:18 < cjd> oh? link? 01:19 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-lfdviwtbvibsryfy] has joined #bitcoin-core-dev 01:19 < bitcoin-git> [bitcoin] laanwj closed pull request #14825: 0.17 (master...0.17) https://github.com/bitcoin/bitcoin/pull/14825 01:19 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-lfdviwtbvibsryfy] has left #bitcoin-core-dev [] 01:19 < sipa> cjd: at least bram cohen has come up with a hybrid nodes-still-keep-spentness-but-not-utxos-themselves (search for "utxo bitset") 01:19 < sipa> adiabat has been working on a practical merkle tree based system 01:20 < cjd> found this: https://diyhpl.us/wiki/transcripts/sf-bitcoin-meetup/2017-07-08-bram-cohen-merkle-sets/ 01:20 < sipa> latest scaling bitcoin had a talk on improvements to cryptographic accumulators to make them more usable for this kind of application 01:20 < sipa> yeah, it's in there; there is also a ml post 01:21 < sipa> i have written a post on rolling utxo hashes (which don't permit compact proofs, but may help comparing utxo sets) 01:22 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 01:22 < gmaxwell> aj: unfortunately the impl before came from someone who wasn't a regular so they didn't use our ordinary language to talk about it, so I'm having a damnd hard time grepping up the link. 01:23 < sipa> gmaxwell: it was a bitcointalk post afaik 01:24 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:24 < cjd> I'm kind of cold on anything that requires shor attackable crypto at the infrastructure level, but that said I think a lot of these things are still using hashes 01:24 < cjd> And I distinguish between infrastructure level (hashes, merkle trees etc) from the spending level (signing a transaction) 01:26 < dongcarl> A v0 WitnessProgram with a size that's not 20 nor 32 bytes is still a valid WitnessProgram, but will fail, is that a correct distinction? 01:26 < cjd> it would be nice to go all in on the wild crypto and be able to make everything anonymous, but I think that should be kept as an option to put your money into the black box and then take it out again, knowing that some major advancement in math or quantum computers might cause the black box to implode 01:26 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 01:26 < gmaxwell> sipa: ah, it was also several weeks of talk in IRC. 01:26 < gmaxwell> which is what I was trying to find. 01:27 < sipa> dongcarl: correct 01:27 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 01:27 < sipa> dongcarl: though i'm not sure that that distinction is observable 01:28 < dongcarl> sipa: `CScript::IsWitnessProgram` seems to not check that a v0 WitnessProgram is either 20 or 32bytes 01:28 < gmaxwell> as there is no input that will hash to match it. 01:28 < sipa> dongcarl: correct 01:28 < dongcarl> right right 01:28 < gmaxwell> dongcarl: a complicated thing with consensus rules is "which of the infinite set of implied consensus rules should be called consensus rules"? 01:29 < sipa> but the only effect of something being a witness output is that it means a witness can be present when spending it 01:29 < sipa> however, in the case of a v0 with not-20/32 size, there is no valid spend 01:30 < gmaxwell> like, yes maybe bitcoin core has a branch that checks the size and terminates... but without that branch it would still reject those cases because the hash function (a size triggered OR of two functions) will never match for inputs of other sizes. 01:30 < sipa> right, operational semantics can differ from the validaty rules... 01:31 < sipa> as in one (invalid) case we may check signatures and in another invalid case we reject before reaching that point 01:31 < gmaxwell> like it will also fail if your input is PUSH("RICK") OP_ROLL, but we wouldn't say that we have a consensus rule that the witness scripthash can't be PUSH("RICK") OP_ROLL. 01:31 < gmaxwell> Even if we were to add code to specifically catch that case because some clown was spamming with it and we thought it would be useful to fail faster. 01:32 < gmaxwell> (or more often, because being specific can make the semantics more clear) 01:32 < dongcarl> gmaxwell: ah... makes sense... some rules are stated, and some rules are the consequence of other rules 01:32 < sipa> dongcarl: in any case, by the terminology of the BIP and the source code, yes, a v0 21-byte output is a witness output 01:33 < gmaxwell> and sometimes we make implied rules concrete ... and then only later take them out again. 01:33 < sipa> however, whether it is or not has no effect (i think!) on any consensus observable effect 01:33 < gmaxwell> as which of the implied consensus rules we implement concretely is just an implementation choice... 01:34 < gmaxwell> sipa: that probably has some effect on RPC outputs. 01:34 < dongcarl> sipa: gotcha, I'm looking at the test case PR for `IsWitnessProgram`, so wanted to double check 01:35 < dongcarl> gmaxwell: Soo... consensus is really just implementation? 01:35 < sipa> dongcarl: ultimately, yes - but i don't think that's the conclusion here 01:36 < sipa> there is a set of intended rules, but there are still many ways of mapping those rules to code that are all identical in terms of observable behavior 01:37 < sipa> and the implentation may choose to make distinctions that don't exist in the observable rules 01:37 < sipa> for example, bitcoin core will use a very different codepath for an ecdsa signature that is too long vs one that is just invalid 01:37 < gmaxwell> I normally think of the consensus rules as the MINIMAL set of rules that implement the 'consensus functionality'. 01:38 < sipa> but the rules that people understand the system has doesn't make this distinction at all 01:39 < gmaxwell> For implementation reasons we don't implement "the consensus rules" we implement some isomorphic set of rules. They behave the same for consensus purposes, but have some implementation advantages. 01:40 < gmaxwell> E.g. cheap tests for expensive failure conditions... like checking the length of a witness hash, we don't have to-- a wrong length won't ever agree with the hasher, but perhaps the code is more obviously correct if the lengths are checked. 01:42 < cjd> This all reminds me of the recent(ish) work that was done at inria on modelling the SSL state machine 01:42 < cjd> Source of that handful of attacks which were published in the past 3 years 01:42 < dongcarl> Ahhhh okay I think I get it... Sometimes short-circuiting (even when consensus doesn't dictate it) can have advantages in terms of implementation 01:43 < sipa> dongcarl: exactly 01:43 < sipa> consensus only outputs "valid" or "invalid" 01:43 < sipa> it doesn't even report why something was invalid 01:44 < sipa> (though that may in some cases be obserable on the P2P protocol by bans and corruptionpossible flag) 01:45 < gmaxwell> though thats also one of the reasons I don't like having things like reject reasons visible... they're hard to make stable without really confining the specifics of the implementation. 01:46 < gmaxwell> "Your thing was wrong for 5 reasons, but we're only going to tell you one of them." 01:46 < sipa> and after a refactor, we'll tell you about another one instead 01:48 -!- Guest80 [5400cef8@gateway/web/cgi-irc/kiwiirc.com/ip.84.0.206.248] has joined #bitcoin-core-dev 01:49 < Guest80> Hello! 01:49 < Guest80> Anybody here? 01:49 < gmaxwell> nope 01:49 < Guest80> Funny... 01:50 < Guest80> ;-) 01:50 < dongcarl> gmaxwell: Huh... I was actually thinking that errors need error codes in Bitcoin... But perhaps that's a bad idea... 01:50 < Guest80> Anybody here experienced with bitcoin core build? 01:51 < Guest80> My simplified question is: Ho to build Windows installers? 01:51 < dongcarl> Guest80: https://github.com/bitcoin/bitcoin/blob/master/doc/build-windows.md 01:51 < Guest80> I can build Windows binaries but they all Stand Alone ones. 01:51 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 01:52 < Guest80> Thanks, I'm familiar with the document you linked. 01:52 < dongcarl> Guest80: you can build a Windows installer using other tools, it's not in the scope of the project I don't think 01:53 < Guest80> I'm here because that document is no help at all. 01:53 < Guest80> Thanks! 01:53 < sipa> dongcarl: libconsensus will give you error codes 01:53 < sipa> for script validity at least 01:54 < Guest80> Bitcoin.org has Windows installers. They build them somehow. 01:54 < sipa> Guest80: using a deterministic build environment 01:54 < sipa> which is fully scripted 01:54 < sipa> but runs in a linux vm 01:55 < dongcarl> sipa: Oh cool... So how does it decide what error to point out? 01:55 < Guest80> I build under Ubuntu 10.04.1 LTS 01:55 < Guest80> That Ubuntu runs as a VM. 01:55 < gmaxwell> dongcarl: well I don't like them, because either we don't keep them stable which maybe breaks things. ... or we have an implementation suicide pact where it's really hard to change stuff just due to preserving errors. 01:55 < dongcarl> Or does it suffer from the problem of pointing out the first problem it finds and probably will point out a different one if we refactor? 01:55 < gmaxwell> exactly 01:56 < sipa> thankfully, that part of the consensus code (script interpreter) does not need much changes 01:57 < dongcarl> Gotcha 01:58 < sipa> the types of failures around blkcks and transactions changs more often 02:04 < promag> sipa: GetAffectedKeys could be GetAffectedPubKeys? 02:04 < Guest80> Again, the link you linked is irrelevant. 02:04 < Guest80> I am building for Windows target under Ubuntu. 02:05 < Guest80> I am not building under Windows. 02:05 < Guest80> I can build "by the book". That's not the problem. 02:05 < sipa> Guest80: yes, follow the gitian guide 02:05 < sipa> promag: it returns key kds 02:05 < sipa> key ids 02:05 < sipa> key ids identify keypairs 02:06 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev 02:06 < Guest80> The problem is that the results of the build are Stand Alone Windows binaries, and not the Windows installer. 02:07 < sipa> gitian also produces the installer 02:07 < Guest80> And I need the Windows installer. 02:07 < Guest80> Well, it does not produce the installer. 02:07 < sipa> yes it does 02:08 < gmaxwell> I believe the gitian build makes the installer. You need to get the extracted signatures for it to produce a signed installer. 02:08 < Guest80> It collects everythin in one folder, but none of themis the installer. 02:09 < Guest80> If the Gitanian build makes the installer than it does it with a special switch or something. NOT by default. 02:09 < sipa> https://github.com/bitcoin-core/gitian.sigs/blob/master/0.17.0-win-unsigned/achow101/bitcoin-win-0.17-build.assert 02:09 < sipa> that's the build assertion for achow101's build of 0.17.0 02:10 < sipa> the output includes the installer 02:10 < Guest80> Thanks! 02:10 < Guest80> Thanks sipa 02:10 < sipa> so i believe you are wrong 02:10 < Guest80> Thanks gmaxwell 02:11 < sipa> but i have not run gitian builds in a while myself 02:22 < promag> sipa: does the branch comes from face/off movie? 201810_die_caffectedkeysvisitor_die 02:22 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 02:25 < Guest80> Again, the Bitcoin.org can have whatever build system, it doesn't help to see the result of their build. 02:25 -!- Soligor [~Soligor@unaffiliated/soligor] has quit [Quit: Soligor] 02:26 < Guest80> I'm still with the Gitanian build that does not produce installers. 02:27 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 02:30 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 02:32 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 02:35 -!- Guest80 [5400cef8@gateway/web/cgi-irc/kiwiirc.com/ip.84.0.206.248] has quit [Remote host closed the connection] 02:44 < sipa> promag: i believe it's been in a number of popular media works, including the simpsons 02:47 < promag> sipa: is this worth it https://github.com/promag/bitcoin/commit/59f62571bc09df01373295d9aac5a485a2ee2eaa ? 02:53 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 03:04 -!- booyah [~bb@193.25.1.157] has quit [Read error: Connection reset by peer] 03:05 -!- booyah [~bb@193.25.1.157] has joined #bitcoin-core-dev 03:15 -!- wxss [~user@81.92.206.123] has joined #bitcoin-core-dev 03:17 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-xnekluukryoxjuay] has joined #bitcoin-core-dev 03:17 < bitcoin-git> [bitcoin] promag opened pull request #14826: Avoid expanding descriptor scriptPubKeys (master...2018-11-faster-descriptor-expand) https://github.com/bitcoin/bitcoin/pull/14826 03:17 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-xnekluukryoxjuay] has left #bitcoin-core-dev [] 03:29 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-hbdbpdnlkzetvskb] has joined #bitcoin-core-dev 03:29 < bitcoin-git> [bitcoin] 3s3s opened pull request #14827: remove fCheckDuplicateInputs (master...master) https://github.com/bitcoin/bitcoin/pull/14827 03:29 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-hbdbpdnlkzetvskb] has left #bitcoin-core-dev [] 03:30 -!- CubicEarth [~CubicEart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 03:32 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection] 03:53 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 03:55 -!- shesek [~shesek@5.22.134.237] has joined #bitcoin-core-dev 03:55 -!- shesek [~shesek@5.22.134.237] has quit [Changing host] 03:55 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 04:01 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 04:09 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 04:10 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection] 04:20 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev 04:21 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 04:22 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 04:26 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-jvjfvariepswyffu] has joined #bitcoin-core-dev 04:26 < bitcoin-git> [bitcoin] promag opened pull request #14828: qt: Remove hidden columns in coin control dialog (master...2018-11-coincontroldialog) https://github.com/bitcoin/bitcoin/pull/14828 04:26 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-jvjfvariepswyffu] has left #bitcoin-core-dev [] 04:51 -!- zivl [~zivl@unaffiliated/zivl] has joined #bitcoin-core-dev 04:56 -!- chenpo [~chenpo@1-160-134-81.dynamic-ip.hinet.net] has joined #bitcoin-core-dev 04:57 -!- chenpo_ [~chenpo@111-241-129-9.dynamic-ip.hinet.net] has joined #bitcoin-core-dev 04:58 -!- indistylo [~indistylo@49.204.67.58] has joined #bitcoin-core-dev 05:01 -!- chenpo [~chenpo@1-160-134-81.dynamic-ip.hinet.net] has quit [Ping timeout: 246 seconds] 05:01 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 244 seconds] 05:09 -!- murchandamus [~murchghos@ghostdub.de] has quit [Ping timeout: 252 seconds] 05:10 -!- murchandamus [~murchghos@ghostdub.de] has joined #bitcoin-core-dev 05:12 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer] 05:13 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 05:16 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 05:25 -!- Ryan___ [73a43c8a@gateway/web/freenode/ip.115.164.60.138] has joined #bitcoin-core-dev 05:25 -!- Ryan___ [73a43c8a@gateway/web/freenode/ip.115.164.60.138] has quit [Client Quit] 05:43 -!- rex4539 [~rex4539@ppp-2-84-165-183.home.otenet.gr] has quit [Quit: rex4539] 05:51 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 06:03 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 268 seconds] 06:07 -!- jhfrontz [~Adium@cpe-184-57-118-36.columbus.res.rr.com] has joined #bitcoin-core-dev 06:10 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection] 06:12 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 06:15 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-gntajwjuybynxzyh] has joined #bitcoin-core-dev 06:15 < bitcoin-git> [bitcoin] fanquake closed pull request #14827: remove fCheckDuplicateInputs (master...master) https://github.com/bitcoin/bitcoin/pull/14827 06:15 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-gntajwjuybynxzyh] has left #bitcoin-core-dev [] 06:22 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 06:31 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-jhabqkcnntgccexb] has joined #bitcoin-core-dev 06:31 < bitcoin-git> [bitcoin] hebasto closed pull request #14817: qt: Remove unnecessary columns in Coin Selection window (#11811) (master...20181126-fix-hidden-columns) https://github.com/bitcoin/bitcoin/pull/14817 06:31 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-jhabqkcnntgccexb] has left #bitcoin-core-dev [] 06:33 -!- promag [~promag@83.223.251.161] has joined #bitcoin-core-dev 06:40 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 06:40 -!- promag [~promag@83.223.251.161] has quit [Remote host closed the connection] 06:44 -!- promag [~promag@83.223.251.161] has joined #bitcoin-core-dev 07:05 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 256 seconds] 07:05 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 07:06 -!- shesek [~shesek@5.102.217.79] has joined #bitcoin-core-dev 07:06 -!- shesek [~shesek@5.102.217.79] has quit [Changing host] 07:06 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 07:11 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 07:14 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 250 seconds] 07:14 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 07:22 -!- rex4539 [~rex4539@ppp-2-84-165-183.home.otenet.gr] has joined #bitcoin-core-dev 07:34 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 07:36 -!- promag_ [~promag@119.70.114.89.rev.vodafone.pt] has joined #bitcoin-core-dev 07:40 -!- promag [~promag@83.223.251.161] has quit [Ping timeout: 244 seconds] 07:40 -!- promag_ is now known as promag 07:42 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ijzdbggephotswha] has joined #bitcoin-core-dev 07:42 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/600b85bb4172...9ebfe0e92737 07:42 < bitcoin-git> bitcoin/master 29aeed1 Luke Dashjr: Bugfix: test/functional/mempool_accept: Ensure oversize transaction is actually oversize... 07:42 < bitcoin-git> bitcoin/master 9ebfe0e MarcoFalke: Merge #14819: Bugfix: test/functional/mempool_accept: Ensure oversize transaction is actually oversize... 07:42 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ijzdbggephotswha] has left #bitcoin-core-dev [] 07:42 -!- extnct24 [~extnct@095-096-210-172.static.chello.nl] has joined #bitcoin-core-dev 07:43 -!- extnct24 [~extnct@095-096-210-172.static.chello.nl] has quit [Remote host closed the connection] 07:44 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-iqkoceiroejigdvz] has joined #bitcoin-core-dev 07:44 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #14819: Bugfix: test/functional/mempool_accept: Ensure oversize transaction is actually oversize (master...bugfix_test_mempool_accept) https://github.com/bitcoin/bitcoin/pull/14819 07:44 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-iqkoceiroejigdvz] has left #bitcoin-core-dev [] 07:57 -!- bralyclow [~bralyclow@76-202-84-204.lightspeed.tukrga.sbcglobal.net] has joined #bitcoin-core-dev 08:02 -!- bralyclow [~bralyclow@76-202-84-204.lightspeed.tukrga.sbcglobal.net] has quit [Ping timeout: 250 seconds] 08:09 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-jmkslnojdgjwysrn] has joined #bitcoin-core-dev 08:09 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/9ebfe0e92737...0a452d02cebb 08:09 < bitcoin-git> bitcoin/master b312cd7 practicalswift: Add missing locking annotations 08:09 < bitcoin-git> bitcoin/master 4894133 practicalswift: Add missing lock in CNode::copyStats(...) 08:09 < bitcoin-git> bitcoin/master 0a452d0 MarcoFalke: Merge #13123: net: Add Clang thread safety annotations for guarded variables in the networking code... 08:09 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-jmkslnojdgjwysrn] has left #bitcoin-core-dev [] 08:09 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-sjkpbycdahhsazjp] has joined #bitcoin-core-dev 08:09 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #13123: net: Add Clang thread safety annotations for guarded variables in the networking code (master...net-guarded-by) https://github.com/bitcoin/bitcoin/pull/13123 08:09 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-sjkpbycdahhsazjp] has left #bitcoin-core-dev [] 08:12 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-hbzyaewkcndojxbh] has joined #bitcoin-core-dev 08:12 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #14487: Constexpr Everything Part 1: Constants (master...patch-3) https://github.com/bitcoin/bitcoin/pull/14487 08:12 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-hbzyaewkcndojxbh] has left #bitcoin-core-dev [] 08:15 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-prqvrzcwfcfpwsky] has joined #bitcoin-core-dev 08:15 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/0a452d02cebb...60b20c869f8d 08:15 < bitcoin-git> bitcoin/master fa5cef0 MarcoFalke: bench: Destroy wallet txs instead of leaking their memory 08:15 < bitcoin-git> bitcoin/master 60b20c8 MarcoFalke: Merge #14822: bench: Destroy wallet txs instead of leaking their memory... 08:15 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-prqvrzcwfcfpwsky] has left #bitcoin-core-dev [] 08:15 < promag> https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/20618902 08:16 < promag> yet another connection problem 08:16 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-tqadlljouhpoxoyz] has joined #bitcoin-core-dev 08:16 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #14822: bench: Destroy wallet txs instead of leaking their memory (master...Mf1811-benchWalletTxs) https://github.com/bitcoin/bitcoin/pull/14822 08:16 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-tqadlljouhpoxoyz] has left #bitcoin-core-dev [] 08:17 < promag> please consider #14670 08:17 < gribble> https://github.com/bitcoin/bitcoin/issues/14670 | http: Fix HTTP server shutdown by promag · Pull Request #14670 · bitcoin/bitcoin · GitHub 08:18 -!- indistylo [~indistylo@49.204.67.58] has quit [Ping timeout: 246 seconds] 08:36 -!- ada_ [60f6274f@gateway/web/freenode/ip.96.246.39.79] has quit [Quit: Page closed] 08:54 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev 08:55 -!- promag [~promag@119.70.114.89.rev.vodafone.pt] has quit [Remote host closed the connection] 08:57 -!- rex4539 [~rex4539@ppp-2-84-165-183.home.otenet.gr] has quit [Quit: rex4539] 08:59 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection] 08:59 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev 09:02 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 09:03 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 09:07 -!- wxss [~user@81.92.206.123] has quit [Quit: leaving] 09:09 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 246 seconds] 09:17 -!- jouke_ [~jouke@unaffiliated/komkommer] has joined #bitcoin-core-dev 09:19 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection] 09:26 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev 09:34 -!- jarthur [~jarthur@wsip-24-120-54-60.lv.lv.cox.net] has joined #bitcoin-core-dev 09:36 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection] 09:37 -!- fabianfabian [~fabianfab@D9656CCE.cm-27.dynamic.ziggo.nl] has joined #bitcoin-core-dev 09:44 -!- schnerchi [~schnerchi@p54A79CC5.dip0.t-ipconnect.de] has quit [Quit: Leaving...] 09:48 -!- rex4539 [~rex4539@ppp-2-84-165-183.home.otenet.gr] has joined #bitcoin-core-dev 09:50 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 10:11 -!- grubles_ [~grubles@unaffiliated/grubles] has joined #bitcoin-core-dev 10:14 -!- grubles [~grubles@unaffiliated/grubles] has quit [Ping timeout: 246 seconds] 10:16 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 250 seconds] 10:23 -!- jarthur [~jarthur@wsip-24-120-54-60.lv.lv.cox.net] has quit [] 10:39 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 10:41 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev 10:42 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has quit [Ping timeout: 252 seconds] 10:44 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has joined #bitcoin-core-dev 10:48 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has quit [Client Quit] 10:48 -!- jarthur [~jarthur@208.78.234.5] has joined #bitcoin-core-dev 10:50 -!- grubles_ is now known as grubles 11:06 -!- jarthur [~jarthur@208.78.234.5] has quit [Remote host closed the connection] 11:20 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 245 seconds] 11:28 -!- Madars [~null@unaffiliated/madars] has joined #bitcoin-core-dev 11:38 -!- spinza [~spin@155.93.246.187] has quit [Ping timeout: 250 seconds] 11:47 -!- jarthur [~jarthur@208.78.234.4] has joined #bitcoin-core-dev 11:58 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.3] 12:03 -!- xames [bc4d588a@gateway/web/freenode/ip.188.77.88.138] has joined #bitcoin-core-dev 12:07 -!- xames [bc4d588a@gateway/web/freenode/ip.188.77.88.138] has quit [Ping timeout: 256 seconds] 12:08 < arubi> ##hwi is invite only now? 12:14 < gwillen> arubi: I have registered a complaint 12:14 < arubi> cheers 12:14 < gwillen> I can't actually speak there so I registered it via other means :-P 12:14 < arubi> :) 12:15 < gwillen> provoostenator: actually I suppose pinging you here works too ^ 12:18 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev 12:22 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has joined #bitcoin-core-dev 12:28 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 12:32 -!- jarthur [~jarthur@208.78.234.4] has quit [Remote host closed the connection] 12:33 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-jifbirdswijxlxhd] has joined #bitcoin-core-dev 12:33 < bitcoin-git> [bitcoin] practicalswift opened pull request #14829: travis: Enable functional tests in the ThreadSanitizer (TSan) build job (master...tsan) https://github.com/bitcoin/bitcoin/pull/14829 12:33 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-jifbirdswijxlxhd] has left #bitcoin-core-dev [] 12:35 < promag> another "An established connection was aborted by the software in your host machine" https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/20621323 12:37 < instagibbs> huh, I'm not crazy, default debug flags were changed 9 months ago 12:37 < instagibbs> #13005 12:37 < gribble> https://github.com/bitcoin/bitcoin/issues/13005 | Make --enable-debug to pick better options by practicalswift · Pull Request #13005 · bitcoin/bitcoin · GitHub 12:37 < instagibbs> I find it *far* less useful for debugging 12:38 < instagibbs> --enable-super-serious-debug concept ACK ;P 12:40 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-nyoendiquaxofjgb] has quit [Quit: Connection closed for inactivity] 12:43 < instagibbs> I will shut up about it now, with an issue open. 12:47 < instagibbs> #14380 ready for merge? 12:47 < gribble> https://github.com/bitcoin/bitcoin/issues/14380 | fix assert crash when specified change output spend size is unknown by instagibbs · Pull Request #14380 · bitcoin/bitcoin · GitHub 12:49 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-oubtykldvamlckua] has joined #bitcoin-core-dev 12:49 < bitcoin-git> [bitcoin] vim88 opened pull request #14831: Scripts and tools: Use #!/usr/bin/env bash instead of #!/bin/bash. (master...proper_shebang) https://github.com/bitcoin/bitcoin/pull/14831 12:49 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-oubtykldvamlckua] has left #bitcoin-core-dev [] 12:50 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-qmrhtykppdnmljqc] has joined #bitcoin-core-dev 12:50 < bitcoin-git> [bitcoin] ch4ot1c opened pull request #14832: docs: Add more Doxygen information to Developer Notes (master...improvement/doxygen-docs) https://github.com/bitcoin/bitcoin/pull/14832 12:50 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-qmrhtykppdnmljqc] has left #bitcoin-core-dev [] 12:54 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection] 12:56 -!- jarthur [~jarthur@208.78.234.4] has joined #bitcoin-core-dev 12:58 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 12:58 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-iskbnqwodmzmgnzn] has joined #bitcoin-core-dev 12:58 < bitcoin-git> [bitcoin] MarcoFalke pushed 13 new commits to 0.17: https://github.com/bitcoin/bitcoin/compare/5150accdd2a7...9f556622c57d 12:58 < bitcoin-git> bitcoin/0.17 bb90695 gustavonalle: [wallet] Ensure wallet is unlocked before signing... 12:58 < bitcoin-git> bitcoin/0.17 85aacc4 Walter: Add autogen.sh in ARM Cross-compilation... 12:58 < bitcoin-git> bitcoin/0.17 9406502 Kaz Wesley: add a test demonstrating an overflow in a deserialization edge case... 12:58 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-iskbnqwodmzmgnzn] has left #bitcoin-core-dev [] 12:59 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 12:59 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 13:11 -!- grubles [~grubles@unaffiliated/grubles] has quit [Quit: Leaving] 13:14 < BlueMatt> #14380 looks merge-able + backport-able 13:14 < gribble> https://github.com/bitcoin/bitcoin/issues/14380 | fix assert crash when specified change output spend size is unknown by instagibbs · Pull Request #14380 · bitcoin/bitcoin · GitHub 13:15 < BlueMatt> #14196 also looks merge-able (its against 0.17 and the upstream forward-port was merged) 13:15 < gribble> https://github.com/bitcoin/bitcoin/issues/14196 | [0.17][psbt] always drop the unnecessary utxo and convert non-witness utxo to witness when necessary by achow101 · Pull Request #14196 · bitcoin/bitcoin · GitHub 13:22 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 13:31 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Remote host closed the connection] 13:32 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 13:32 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 13:32 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 13:32 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 13:37 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds] 13:37 -!- jarthur [~jarthur@208.78.234.4] has quit [] 13:42 -!- grubles [~grubles@unaffiliated/grubles] has joined #bitcoin-core-dev 13:53 -!- rex4539 [~rex4539@ppp-2-84-165-183.home.otenet.gr] has quit [Ping timeout: 268 seconds] 13:57 -!- BB_ [~Mutter@63.147.70.46] has joined #bitcoin-core-dev 14:00 -!- BB_ [~Mutter@63.147.70.46] has quit [Client Quit] 14:08 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has quit [Remote host closed the connection] 14:08 -!- phwalkr [~phwalkr@193.137.101.10] has joined #bitcoin-core-dev 14:10 -!- phwalkr_ [~phwalkr@192.32.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev 14:13 -!- phwalkr [~phwalkr@193.137.101.10] has quit [Ping timeout: 246 seconds] 14:17 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 14:18 < dongcarl> I see that kallewoof has posted a few clang static analyzer reports on the repo... Wondering if there's any effort to have a bot that does this automatically or have CI integration for this... 14:20 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 268 seconds] 14:24 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 14:27 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 272 seconds] 14:27 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 14:33 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 14:35 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 14:35 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 14:37 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 244 seconds] 14:49 -!- shesek [~shesek@5.22.134.237] has joined #bitcoin-core-dev 14:49 -!- shesek [~shesek@5.22.134.237] has quit [Changing host] 14:49 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 15:08 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 244 seconds] 15:19 -!- rex4539 [~rex4539@ppp-2-84-161-2.home.otenet.gr] has joined #bitcoin-core-dev 15:20 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 15:22 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 15:24 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 15:24 -!- grubles [~grubles@unaffiliated/grubles] has left #bitcoin-core-dev ["Leaving"] 15:26 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 244 seconds] 15:27 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds] 15:35 < kallewoof> I thought practicalswift was our clang static analyzer bot 15:35 < kallewoof> Almost a joke :) 15:37 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 16:21 < dongcarl> Lol... 16:23 < dongcarl> What are people's thoughts on having a static analyzer run by default on PRs? 16:24 < sipa> dongcarl: the question is how it will report, and what the policy would be around it 16:25 < sipa> for things that are reasonably false positives, you can't force contributors to avoid them 16:27 < dongcarl> sipa: I think that the workflow should be this: CI shouldn't fail if the static analyzer notices problems, instead, once the static analyzer is done, a bot (like DrahtBot) posts a link to the report summary on the PR. Reviewers can take a look at the report, or not, completely supplementary info. 16:28 < dongcarl> clang's static analyzer actually generates html for you, pretty convenient 16:29 < sipa> dongcarl: also spamming PRs with things that aren't actionable is very annoing 16:31 < dongcarl> Hmmmm... Okay. I think what's been happening currently is that every quarter or so kallewoof posts the static analyzer output as an Issue and people dig thru it... Perhaps that's less noisy? 16:31 < sipa> dongcarl: i think it would be useful to have some separate page where you can see an overview of various analysis tools run on the PRs 16:32 < sipa> but that's a lot more work obviously 16:33 < dongcarl> sipa: Hmmm... I remember seeing some site like this but for benchmarking? Can't remember who's it was... 16:34 < sipa> jamesob's ? 16:36 < aj> bitcoinperf.com ? 16:37 < dongcarl> Yup! 16:50 -!- keymone [~keymone@ip1f10c1a7.dynamic.kabel-deutschland.de] has quit [Ping timeout: 245 seconds] 17:01 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection] 17:01 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev 17:14 < gmaxwell> the FP rate for something like that has to be very low, --- otherwise you just getting people making goofy changes to silence the analyizer, and that behavior lowers software quality. 17:17 < sipa> agree; it's probably useful in combination with someone who is familiar with the code enough to determine which issues are relevant 17:27 -!- fabianfabian [~fabianfab@D9656CCE.cm-27.dynamic.ziggo.nl] has quit [Quit: Textual IRC Client: www.textualapp.com] 17:29 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 17:33 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.3] 17:38 -!- shigeya [~shigeya@203.178.128.12] has joined #bitcoin-core-dev 17:46 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ioxfcsbvavxcxkbk] has joined #bitcoin-core-dev 17:46 < bitcoin-git> [bitcoin] cryptosnail opened pull request #14833: 0.17 (master...0.17) https://github.com/bitcoin/bitcoin/pull/14833 17:46 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ioxfcsbvavxcxkbk] has left #bitcoin-core-dev [] 17:47 -!- shigeya [~shigeya@203.178.128.12] has quit [Quit: ZNC 1.7.1 - https://znc.in] 17:47 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-zrvzutdupjrwrbnb] has joined #bitcoin-core-dev 17:47 < bitcoin-git> [bitcoin] cryptosnail closed pull request #14833: 0.17 (master...0.17) https://github.com/bitcoin/bitcoin/pull/14833 17:47 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-zrvzutdupjrwrbnb] has left #bitcoin-core-dev [] 17:57 -!- shigeya [~shigeya@202.182.116.58] has joined #bitcoin-core-dev 17:59 -!- shigeya [~shigeya@202.182.116.58] has quit [Client Quit] 17:59 -!- shigeya [~shigeya@2001:19f0:7001:3486:5400:1ff:fe90:4da6] has joined #bitcoin-core-dev 17:59 -!- shigeya [~shigeya@2001:19f0:7001:3486:5400:1ff:fe90:4da6] has quit [Client Quit] 17:59 -!- shigeya [~shigeya@202.182.116.58] has joined #bitcoin-core-dev 18:05 -!- bralyclow2 [~bralyclow@195.242.213.121] has joined #bitcoin-core-dev 18:08 -!- bralyclow2 [~bralyclow@195.242.213.121] has quit [Client Quit] 18:13 -!- shigeya [~shigeya@202.182.116.58] has quit [Quit: ZNC 1.6.5+deb1+deb9u1 - http://znc.in] 18:14 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 244 seconds] 18:18 -!- shigeya [~shigeya@2001:19f0:7001:3486:5400:1ff:fe90:4da6] has joined #bitcoin-core-dev 18:20 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 18:23 -!- shigeya [~shigeya@2001:19f0:7001:3486:5400:1ff:fe90:4da6] has quit [Quit: ZNC 1.6.5+deb1+deb9u1 - http://znc.in] 18:25 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection] 18:25 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev 18:31 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 18:31 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Ping timeout: 256 seconds] 18:32 -!- shesek [~shesek@5.22.134.237] has joined #bitcoin-core-dev 18:32 -!- shesek [~shesek@5.22.134.237] has quit [Changing host] 18:32 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 18:33 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 268 seconds] 18:33 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 18:40 -!- Tralfaz [~none@104.248.145.220] has quit [Quit: Leaving] 18:41 -!- jb55 [~jb55@S010660e327dca171.vc.shawcable.net] has quit [Quit: WeeChat 2.2] 18:43 -!- shigeya [~shigeya@2001:19f0:7001:3486:5400:1ff:fe90:4da6] has joined #bitcoin-core-dev 18:49 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: No route to host] 18:50 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 18:57 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 19:09 -!- aijinsong [c60d38ce@gateway/web/freenode/ip.198.13.56.206] has joined #bitcoin-core-dev 19:13 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has quit [Remote host closed the connection] 19:16 -!- phwalkr_ [~phwalkr@192.32.61.94.rev.vodafone.pt] has quit [Ping timeout: 246 seconds] 19:17 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 19:18 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 19:32 -!- aijinsong [c60d38ce@gateway/web/freenode/ip.198.13.56.206] has quit [Ping timeout: 256 seconds] 19:33 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 19:34 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 19:37 < jamesob> dongcarl sipa: bitcoinperf's interface needs a lot of work (and there's some of that in progress atm). Down the road I plan on building in some kind of opt-in benchmarking per PR; not necessarily anything that reports back to Github, but that may have PR-specific page on bitcoinperf. Comments to the PR are potentially disruptive given the number of listeners (see drahtbot's quest for one comment per PR). 19:38 < dongcarl> Gotcha 19:38 < dongcarl> Maybe someone can comment “@benchbot plz bench” for opt-in benchmarking or something like that 19:38 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 250 seconds] 19:39 < jamesob> Could be, though that's another boilerplate comment. I dunno, haven't thought a ton about it. Think hooking into Github's commit status API a la Travis might be worth exploring too. 19:40 -!- indistylo [~indistylo@49.204.67.58] has joined #bitcoin-core-dev 19:41 -!- shigeya [~shigeya@2001:19f0:7001:3486:5400:1ff:fe90:4da6] has quit [Quit: ZNC 1.6.5+deb1+deb9u1 - http://znc.in] 19:42 -!- shigeya [~shigeya@2001:19f0:7001:3486:5400:1ff:fe90:4da6] has joined #bitcoin-core-dev 19:50 < gmaxwell> anything that runs per PR and dumps data somewhere is great 19:50 < gmaxwell> including crazy sanitizers and whatever 19:50 < gmaxwell> We just should avoid things causing notifications unless we actually want people to take action on the vast majority of to notifications 19:53 -!- _cryptosignal_me [~John@91.245.77.21] has joined #bitcoin-core-dev 19:55 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 20:00 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Quit: My MacBook Air has gone to sleep. ZZZzzz…] 20:01 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 20:08 < dongcarl> Yeah I agree notifications should be meaningful... 20:08 < dongcarl> Looking at the GitHub checks API here: https://developer.github.com/v3/checks/runs/ 20:09 < dongcarl> Looks like benchmarks and static analysis could be notices with links attached 20:09 < luke-jr> would be nice if GitHub let us add our own buttons to PRs :P 20:10 < dongcarl> luke-jr: well I think each check can have a details url 20:10 < luke-jr> yeah, I just mean if we want some things to run conditionally 20:10 < dongcarl> Oh right yeah 20:12 < dongcarl> Thinking off the top of my head: perhaps we can have tags that activate checks? As in... fanquake-driven development? 20:16 < luke-jr> eh, it might work if anyone could add tags 20:18 < dongcarl> True. 20:19 < dongcarl> Yeah I'm just thinking about developer/reviewer ergonomics... Looks like I need to take a harder look at Github API 20:20 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-jneshevhlkarment] has joined #bitcoin-core-dev 20:20 < bitcoin-git> [bitcoin] kallewoof opened pull request #14834: validation: do not break assumption that pindexPrev may be null (master...20181129-contextualcheckblock-pindexprev-nullness) https://github.com/bitcoin/bitcoin/pull/14834 20:20 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-jneshevhlkarment] has left #bitcoin-core-dev [] 20:20 < kallewoof> dongcarl: you reminded me to run analyzer again. Rewriting those reports was a big pain in the ass though, but I might get around to it. 20:21 < dongcarl> kallewoof: haha yeah I saw that PR and was like: I KNOW WHAT KALLE JUST DID 20:21 < kallewoof> lol! 20:21 < kallewoof> I figured I'd fix the obvious ones, to cut down on the report writing pain :P 20:22 < dongcarl> kallewoof: I'm gunna see if I can find a solution to have more automatic analysis for PRs without spamming useless notifications 20:22 < dongcarl> but yeah stopgap is you lol 20:22 -!- indistylo [~indistylo@49.204.67.58] has quit [Read error: Connection reset by peer] 20:23 < kallewoof> TBH I think keeping track of which issues have been reported and only reporting them once with a single location where everyone can review all of them would be good enough, presuming FPs are not overly bad. 20:24 < kallewoof> Like.. "This PR introduces a new warning in the Clang Analyzer toolset. Make sure this is a false positive before this is merged. (Note: this message only appears once for this PR.)" or something. 20:24 < dongcarl> True 20:27 -!- _cryptosignal_me [~John@91.245.77.21] has quit [Ping timeout: 250 seconds] 20:32 < gmaxwell> I think these PRs might also be candidates for 0.17.x backport 20:32 < gmaxwell> https://github.com/bitcoin/bitcoin/pull/14728 20:32 < gmaxwell> https://github.com/bitcoin/bitcoin/pull/14679 20:32 < gmaxwell> https://github.com/bitcoin/bitcoin/pull/14454 20:32 < gmaxwell> https://github.com/bitcoin/bitcoin/pull/14618 20:33 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-bqxcziyzeozcydgh] has joined #bitcoin-core-dev 20:33 < bitcoin-git> [bitcoin] fanquake opened pull request #14835: [0.17] Backport #14593, #14596 and #14690 (0.17...further-0-17-backports) https://github.com/bitcoin/bitcoin/pull/14835 20:33 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-bqxcziyzeozcydgh] has left #bitcoin-core-dev [] 20:34 < gmaxwell> Also this isn't merged yet, https://github.com/bitcoin/bitcoin/pull/14380 but looks done to me? and its a fix we should have in 0.17.1 20:36 -!- indistylo [~indistylo@49.204.67.58] has joined #bitcoin-core-dev 20:50 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 20:51 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 246 seconds] 20:51 -!- wolfspraul [~wolfsprau@bobbin.q-ag.de] has joined #bitcoin-core-dev 21:19 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 268 seconds] 21:24 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 21:27 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 21:28 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 22:06 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 22:07 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 22:26 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 245 seconds] 22:27 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 22:33 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 240 seconds] 22:34 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 23:07 -!- kabaum [~kabaum@h-13-35.A163.priv.bahnhof.se] has joined #bitcoin-core-dev 23:10 -!- chenpo_ [~chenpo@111-241-129-9.dynamic-ip.hinet.net] has quit [Remote host closed the connection] 23:11 -!- chenpo [~chenpo@140.109.239.177] has joined #bitcoin-core-dev 23:13 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-agimrsgemsbveemx] has joined #bitcoin-core-dev 23:13 < bitcoin-git> [bitcoin] JeremyRubin opened pull request #14836: Probabalistic Checker for Duplicate Inputs (master...faster-dedup-working-rebase) https://github.com/bitcoin/bitcoin/pull/14836 23:13 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-agimrsgemsbveemx] has left #bitcoin-core-dev [] 23:13 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-spdvjejyhvqotivo] has joined #bitcoin-core-dev 23:13 < bitcoin-git> [bitcoin] JeremyRubin closed pull request #14836: Probabalistic Checker for Duplicate Inputs (master...faster-dedup-working-rebase) https://github.com/bitcoin/bitcoin/pull/14836 23:13 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-spdvjejyhvqotivo] has left #bitcoin-core-dev [] 23:15 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 246 seconds] 23:21 -!- chenpo [~chenpo@140.109.239.177] has quit [Remote host closed the connection] 23:22 -!- chenpo [~chenpo@111-241-129-9.dynamic-ip.hinet.net] has joined #bitcoin-core-dev 23:26 -!- chenpo [~chenpo@111-241-129-9.dynamic-ip.hinet.net] has quit [Ping timeout: 268 seconds] 23:36 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: No route to host] 23:39 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 23:42 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer] 23:42 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 23:50 -!- go1111111 [~go1111111@104.156.98.86] has quit [Remote host closed the connection] 23:51 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev 23:55 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has quit [Ping timeout: 250 seconds] 23:58 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 23:59 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: No route to host] --- Log closed Thu Nov 29 00:00:35 2018