--- Log opened Wed Jan 02 00:00:09 2019
00:05 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection]
00:06 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev
00:14 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev
00:20 -!- rex4539 [~rex4539@hotelmir.static.otenet.gr] has joined #bitcoin-core-dev
00:35 -!- aqquadro [~name@unaffiliated/aqquadro] has joined #bitcoin-core-dev
00:47 -!- Murch [~murch@172.56.31.224] has joined #bitcoin-core-dev
00:50 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection]
00:50 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev
01:00 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
01:11 -!- rex4539 [~rex4539@hotelmir.static.otenet.gr] has quit [Quit: rex4539]
01:24 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
01:40 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving]
01:45 -!- jungly [~quassel@host97-200-static.8-79-b.business.telecomitalia.it] has joined #bitcoin-core-dev
01:50 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-yksyhpwwkwfnnpxg] has joined #bitcoin-core-dev
01:50 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #15077: rpc: List all message types in getpeerinfo recv/send stats (master...Mf1812-netStats0) https://github.com/bitcoin/bitcoin/pull/15077
01:50 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-yksyhpwwkwfnnpxg] has left #bitcoin-core-dev []
01:52 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-gtrcnqynbpcvrdsq] has joined #bitcoin-core-dev
01:52 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/4f041ba14f68...3ec4cc0a9e7c
01:52 < bitcoin-git> bitcoin/master de23739 Ben Woosley: test: Fix rpc_net.py "pong" race condition...
01:52 < bitcoin-git> bitcoin/master 3ec4cc0 MarcoFalke: Merge #15069: test: Fix rpc_net.py "pong" race condition...
01:52 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-gtrcnqynbpcvrdsq] has left #bitcoin-core-dev []
01:53 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-vybtgatupbozewbv] has joined #bitcoin-core-dev
01:53 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #15069: test: Fix rpc_net.py "pong" race condition (master...rpc_net-race) https://github.com/bitcoin/bitcoin/pull/15069
01:53 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-vybtgatupbozewbv] has left #bitcoin-core-dev []
02:04 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
02:06 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev
02:11 -!- Murch [~murch@172.56.31.224] has quit [Quit: Plugging out.]
02:11 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
02:16 -!- mistergold [~mistergol@77.243.19.198] has quit [Ping timeout: 272 seconds]
02:22 -!- Murch [~murch@172.56.31.224] has joined #bitcoin-core-dev
02:31 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
02:53 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
03:02 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev
03:03 < promag> happy 2019 everyone!
03:04 < wumpus> thank you promag, same to you!
03:04 < promag> ty
03:04 < promag> I'm going to clean up 14982
03:05 < promag> but then I'd like some review effort on #13100 after I update it
03:05 < gribble> https://github.com/bitcoin/bitcoin/issues/13100 | gui: Add dynamic wallets support by promag · Pull Request #13100 · bitcoin/bitcoin · GitHub
03:05 < promag> I think 0.18 _must_ have it
03:07 < luke-jr> there are no "_must_ have" features <.<
03:08 < wumpus> if it's ready by then then it should be merged...
03:08 < luke-jr> sure, same as anything else
03:09 < promag> true, but the "plan" as to have dynamic wallet via rpc on 0.17, then gui on 0.18
03:09 < promag> *was
03:10 < promag> but sure, if it's not ready..
03:10 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 250 seconds]
03:14 -!- rex4539 [~rex4539@hotelmir.static.otenet.gr] has joined #bitcoin-core-dev
03:26 -!- mistergold [~mistergol@77.243.19.198] has joined #bitcoin-core-dev
03:27 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
03:37 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev
03:40 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-fyziepcicmrrubap] has joined #bitcoin-core-dev
03:40 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #15078: rpc: Document bytessent_per_msg and bytesrecv_per_msg (master...Mf1901-docRpcGetPeerInfo) https://github.com/bitcoin/bitcoin/pull/15078
03:40 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-fyziepcicmrrubap] has left #bitcoin-core-dev []
03:40 -!- john__ [8b138550@gateway/web/freenode/ip.139.19.133.80] has joined #bitcoin-core-dev
03:41 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-woqkqedkczovmlnq] has joined #bitcoin-core-dev
03:41 < bitcoin-git> [bitcoin] laanwj closed pull request #15031: Removing unnecessary comparison of size_t maxConfirms  (master...maxConfirms) https://github.com/bitcoin/bitcoin/pull/15031
03:41 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-woqkqedkczovmlnq] has left #bitcoin-core-dev []
03:44 < fanquake> wumpus in 15028, it's not your file that has gone missing
03:44 < fanquake> it's the one at http://strateman.ninja/fuzzing.tar.xz
03:45 < wumpus> fanquake: I see, sorry, misread
03:45 < wumpus> tagged phantomcircuit now
03:45 < MarcoFalke> I'd prefer to move to target-based seeds instead
03:46 < MarcoFalke> It is just a hassle to have only one type of seed for all targets
03:46 < MarcoFalke> It is hard to fuzz just one subtarget without modifying the code
03:47 < MarcoFalke> And if the modification is done in the wrong way and the fuzzer is instructed to discard seeds that don't increase the coverage, they are incorrectly lost
03:48 < MarcoFalke> See #15043
03:48 < gribble> https://github.com/bitcoin/bitcoin/issues/15043 | test: Build fuzz targets into seperate executables by MarcoFalke · Pull Request #15043 · bitcoin/bitcoin · GitHub
03:48 < wumpus> yes
03:48 < fanquake> marco are you testing 15047 on fedora/some linux?
03:49 < MarcoFalke> #15047
03:49 < gribble> https://github.com/bitcoin/bitcoin/issues/15047 | build: Allow to configure --with-sanitizers=fuzzer by MarcoFalke · Pull Request #15047 · bitcoin/bitcoin · GitHub
03:49 < MarcoFalke> It should work on any linux that has clang installed
03:50 < MarcoFalke> Though, the binaries such as `bitcoind` obviously don't link with the fuzzer
03:52 < MarcoFalke> I plan to improve the documentation later on
03:52 < MarcoFalke> After #15043
03:52 < gribble> https://github.com/bitcoin/bitcoin/issues/15043 | test: Build fuzz targets into seperate executables by MarcoFalke · Pull Request #15043 · bitcoin/bitcoin · GitHub
03:53 < MarcoFalke> With separate targets people could also easily contribute coverage for a specific target (without having to run meaningless serialization fuzzers or modify the code)
03:55 < MarcoFalke> I will maintain a repo for our fuzz seed corpus for that
04:00 < wumpus> putting the corpuses into a (separate) repo sounds like a good idea
04:00 -!- Murch [~murch@172.56.31.224] has quit [Quit: Snoozing.]
04:01 < cjd> For cjdns, I used the first 4 bytes of the seed as the test id
04:02 < cjd> then I just made a bunch of files which were plausible data for each of the tests and started up AFL with all of them
04:02 -!- th3_wizard [~the-wizar@184.75.220.146] has quit [Quit: Leaving]
04:06 < cjd> I'm partial to the idea that every test which can plausibly make use of random data should use a fuzz api and then be reachable from AFL
04:12 < wumpus> we have the test id as part of the data now, the idea in 15043 is to move away from that as it's easier to manage
04:13 < wumpus> I don't have enough experience with fuzzing to have a strong opinion on that
04:15 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-lglhrjzohmxlqxsj] has joined #bitcoin-core-dev
04:15 < bitcoin-git> [bitcoin] laanwj pushed 6 new commits to master: https://github.com/bitcoin/bitcoin/compare/3ec4cc0a9e7c...62cf608e93f9
04:15 < bitcoin-git> bitcoin/master 1e6afd0 Patrick Strateman: Introduce and use constant SELECT_TIMEOUT_MILLISECONDS.
04:15 < bitcoin-git> bitcoin/master 7e403c0 Patrick Strateman: Move GenerateSelectSet logic to private method....
04:15 < bitcoin-git> bitcoin/master 28211a4 Patrick Strateman: Move SocketEvents logic to private method....
04:15 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-lglhrjzohmxlqxsj] has left #bitcoin-core-dev []
04:15 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ndwqjkuoixdxtkzt] has joined #bitcoin-core-dev
04:15 < bitcoin-git> [bitcoin] laanwj closed pull request #14336: net: implement poll (master...2018-09-24-socket-handler-poll) https://github.com/bitcoin/bitcoin/pull/14336
04:15 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ndwqjkuoixdxtkzt] has left #bitcoin-core-dev []
04:16 < cjd> #15043
04:16 < gribble> https://github.com/bitcoin/bitcoin/issues/15043 | test: Build fuzz targets into seperate executables by MarcoFalke · Pull Request #15043 · bitcoin/bitcoin · GitHub
04:16 -!- rex4539 [~rex4539@hotelmir.static.otenet.gr] has quit [Quit: rex4539]
04:20 < cjd> "the fuzzer needs to "learn" how the fuzz targets are organized"  I don't really understand this
04:22 < cjd> It seems that unless there is a significant cost to doing it this way (fuzzer has more difficulty finding new paths), the benefit of having one fuzz entry point for someone to point AFL at outweighs the cost of cross-test type pollution
04:22 -!- Murch [~murch@172.56.13.70] has joined #bitcoin-core-dev
04:23 < wumpus> that was something I've thought of mentioning too, it does seem easier to 'just fuzz' when there's one target
04:25 < wumpus> with separate executables it seems you need to have a specific target in mind
04:26 < cjd> I'll write my thoughts on github, as I am not in a position where I have to work with the bitcoin codebase every day so I don't want to impose, but I would like to raise a few questions as someone who does use this method
04:26 < wumpus> well it's good to have outside opionions on this imo
04:29 -!- Murch [~murch@172.56.13.70] has quit [Quit: Snoozing.]
04:35 -!- Murch [~murch@172.56.13.70] has joined #bitcoin-core-dev
04:37 < cjd> BTW: one type of fuzzing which could potentially be very valuable for bitcoin is difference fuzzing.. create a test function which takes input and produces output and then use some linker trickery to allow linking 2 versions of bitcoin and invoking the function from each, if the output is different between the two then you got trouble
04:40 < wumpus> yes, that sounds useful
04:40 < wumpus> for the consensus code
04:43 < cjd> This is the function prototype which I created: https://github.com/cjdelisle/cjdns/blob/crashey/test/FuzzTest.h
04:44 < cjd> and one example of it being used: https://github.com/cjdelisle/cjdns/blob/crashey/benc/serialization/json/test/JsonBencMessageReader_fuzz_test.c
04:44 < cjd> my strategy is more to try to fit a fuzz case wherever I can imagine to, looking at any code which makes me even the slightest bit nervous
04:49 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection]
04:52 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev
04:52 < promag> hebasto: hi, do you have the time to review #15065?
04:52 < gribble> https://github.com/bitcoin/bitcoin/issues/15065 | 0.17: GUI Backports #14123 #14133 #14383 #14597 by promag · Pull Request #15065 · bitcoin/bitcoin · GitHub
04:57 < fanquake> promag are those all clean backports?
04:58 < promag> there was only one change because of the SIGNAL/SLOT macros
04:59 < promag> here https://github.com/bitcoin/bitcoin/pull/15065/commits/27beb83
05:00 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
05:10 < fanquake> merged those changes ^ and qt wouldn't build
05:10 < fanquake> keep forgetting I'm unlinking protobuf now
05:16 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-fpcateqnpjiacygw] has joined #bitcoin-core-dev
05:16 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/62cf608e93f9...c3bb936a0f97
05:16 < bitcoin-git> bitcoin/master c9066f0 Kristaps Kaupe: Allow running rpc_bind.py --nonloopback test without IPv6
05:16 < bitcoin-git> bitcoin/master c3bb936 Wladimir J. van der Laan: Merge #14790: Tests: Allow running rpc_bind.py --nonloopback test without IPv6...
05:16 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-fpcateqnpjiacygw] has left #bitcoin-core-dev []
05:17 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-rfcfgritbaqjhcgi] has joined #bitcoin-core-dev
05:17 < bitcoin-git> [bitcoin] laanwj closed pull request #14790: Tests: Allow running rpc_bind.py --nonloopback test without IPv6 (master...testrpcbind) https://github.com/bitcoin/bitcoin/pull/14790
05:17 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-rfcfgritbaqjhcgi] has left #bitcoin-core-dev []
05:19 < hebasto> promag: sure
05:24 -!- bitbee [~bitbee@unaffiliated/cryptocat] has quit [Ping timeout: 246 seconds]
05:26 < fanquake> promag is there anything I'm forgetting to test? https://github.com/bitcoin/bitcoin/pull/15065#issuecomment-450862480
05:26 < fanquake> macOS only at the moment.
05:28 -!- bitbee [~bitbee@unaffiliated/cryptocat] has joined #bitcoin-core-dev
05:43 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit []
05:44 -!- sfhi [~sfhi@188.172.220.69] has joined #bitcoin-core-dev
05:44 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-nkozjdlycschhyry] has joined #bitcoin-core-dev
05:44 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c3bb936a0f97...df894fa69a09
05:44 < bitcoin-git> bitcoin/master 59e3877 James O'Beirne: test: add invalid tx templates for use in functional tests...
05:44 < bitcoin-git> bitcoin/master df894fa Wladimir J. van der Laan: Merge #14457: test: add invalid tx templates for use in functional tests...
05:44 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-nkozjdlycschhyry] has left #bitcoin-core-dev []
05:45 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-dmnjswdwilrgbxbp] has joined #bitcoin-core-dev
05:45 < bitcoin-git> [bitcoin] laanwj closed pull request #14457: test: add invalid tx templates for use in functional tests (master...2018-10-invalid-tx-tests) https://github.com/bitcoin/bitcoin/pull/14457
05:45 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-dmnjswdwilrgbxbp] has left #bitcoin-core-dev []
05:51 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has joined #bitcoin-core-dev
06:03 -!- Robin [bc6b0e87@gateway/web/freenode/ip.188.107.14.135] has joined #bitcoin-core-dev
06:05 -!- Robin [bc6b0e87@gateway/web/freenode/ip.188.107.14.135] has quit [Client Quit]
06:06 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection]
06:11 -!- dviola [~diego@unaffiliated/dviola] has quit [Ping timeout: 245 seconds]
06:13 -!- dviola [~diego@179.235.26.181] has joined #bitcoin-core-dev
06:13 -!- dviola [~diego@179.235.26.181] has quit [Changing host]
06:13 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
06:40 -!- mistergold [~mistergol@77.243.19.198] has quit [Ping timeout: 246 seconds]
06:43 -!- Tralfaz [~none@185.156.175.59] has joined #bitcoin-core-dev
06:53 < fanquake> Has anyone seen #15079 before? Bit of a weird bug
06:53 < gribble> https://github.com/bitcoin/bitcoin/issues/15079 | gui: Incorrect application name when passing -regtest on Fedora · Issue #15079 · bitcoin/bitcoin · GitHub
06:59 < wumpus> fanquake: see post; I don't think it's really a bug, we've never used a different app name for regtest
07:00 < wumpus> (this means it shares QSettings with testnet)
07:01 < fanquake> wumpus ah fair enough, surprised I never noticed earlier
07:05 < wumpus> there would be a point in changing it I guess especially if you're using bitcoin-qt regtest with the functional tests, wouldn't want to run it with the testnet settings
07:06 -!- promag [~promag@83.223.251.213] has joined #bitcoin-core-dev
07:06 < promag> ty hebasto
07:08 < fanquake> promag Could you have a look at #15000? It fixes the notification segfault on Fedora, but seems to break macOS notifications.
07:08 < gribble> https://github.com/bitcoin/bitcoin/issues/15000 | qt: Fix broken notificator on GNOME by hebasto · Pull Request #15000 · bitcoin/bitcoin · GitHub
07:09 < promag> fanquake: sure
07:09 < fanquake> Just want to confirm it's not a local issue of mine.
07:15 -!- aqquadro [~name@unaffiliated/aqquadro] has quit [Ping timeout: 250 seconds]
07:20 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev
07:22 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev
07:23 < promag> MarcoFalke: do you update the license year range on each touched file?
07:25 -!- sfhi [~sfhi@188.172.220.69] has quit [Quit: Leaving]
07:31 -!- john__ [8b138550@gateway/web/freenode/ip.139.19.133.80] has quit [Ping timeout: 256 seconds]
07:54 < wumpus> promag: that is the original idea behind the license years, touching the file updates the copyright to current year
07:55 < wumpus> usually people don't bother, which isn't bad, there's a script to update all of them at the end up the year
07:56 -!- aqquadro [~name@net-37-159-134-26.cust.vodafonedsl.it] has joined #bitcoin-core-dev
07:56 -!- aqquadro [~name@net-37-159-134-26.cust.vodafonedsl.it] has quit [Changing host]
07:56 -!- aqquadro [~name@unaffiliated/aqquadro] has joined #bitcoin-core-dev
07:56 < promag> contrib/devtools/copyright_header.py?
07:57 < wumpus> yes
07:58 < cjd> It seems to me that since normally all content it considered to belong to it's creator until the copyright expires (after whatever number of years), the year written in the notice is sort of a nod to older times when people used printing presses and there was no way to get dates from git blame
08:01 < wumpus> it's essentially redundant as the info is in git anyway, but yeah
08:03 < wumpus> there's been many discussions about this in the past, even about removing the years from the header, but there's no strong reason to, it's convention and it doesn't harm either
08:03 < promag> wumpus: 0.17.2 date is before 0.18?
08:03 < cjd> there are much worse conventions than that :)
08:05 -!- aqquadro [~name@unaffiliated/aqquadro] has quit [Ping timeout: 240 seconds]
08:05 < wumpus> cjd: it's true :)
08:05 < wumpus> promag: I guess?
08:07 < wumpus> promag: it's not sure of course but I would be surprised if there isn't a reason to do 0.17.2 before march/april
08:08 < promag> kk
08:19 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-fiphquslidavstfh] has joined #bitcoin-core-dev
08:19 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/df894fa69a09...fb52d0684e0f
08:19 < bitcoin-git> bitcoin/master c8d9d90 Hennadii Stepanov: Fix broken notificator on GNOME...
08:19 < bitcoin-git> bitcoin/master fb52d06 MarcoFalke: Merge #15000: qt: Fix broken notificator on GNOME...
08:19 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-fiphquslidavstfh] has left #bitcoin-core-dev []
08:20 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-mpsejmpusqrklxto] has joined #bitcoin-core-dev
08:20 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #15000: qt: Fix broken notificator on GNOME (master...20181218-fix-notificator) https://github.com/bitcoin/bitcoin/pull/15000
08:20 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-mpsejmpusqrklxto] has left #bitcoin-core-dev []
08:20 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has quit [Ping timeout: 250 seconds]
08:27 < promag> fanquake: re #15000, have you double checked?
08:27 < gribble> https://github.com/bitcoin/bitcoin/issues/15000 | qt: Fix broken notificator on GNOME by hebasto · Pull Request #15000 · bitcoin/bitcoin · GitHub
08:48 -!- Murch [~murch@172.56.13.70] has quit [Quit: Snoozing.]
08:53 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection]
08:54 -!- promag [~promag@83.223.251.213] has quit [Remote host closed the connection]
08:54 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev
08:56 -!- Murch [~murch@172.56.13.70] has joined #bitcoin-core-dev
08:58 -!- CodeBlue1776 [~CodeBlue1@107-215-134-60.lightspeed.cicril.sbcglobal.net] has quit [Read error: Connection reset by peer]
08:59 -!- dviola [~diego@unaffiliated/dviola] has quit [Ping timeout: 244 seconds]
08:59 -!- CodeBlue1776 [~CodeBlue1@107-215-134-60.lightspeed.cicril.sbcglobal.net] has joined #bitcoin-core-dev
09:03 -!- Guest36764 [~hirish@ip85.ip-137-74-20.eu] has quit [Ping timeout: 264 seconds]
09:08 -!- dviola [~diego@179.235.26.181] has joined #bitcoin-core-dev
09:09 -!- dviola [~diego@179.235.26.181] has quit [Changing host]
09:09 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
09:13 -!- MrPaz [~MrPaz@c-71-57-73-68.hsd1.il.comcast.net] has joined #bitcoin-core-dev
09:20 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/]
09:28 -!- aqquadro [~name@2001:b07:2ee:6c29:cf3c:6ac:6c50:4ce6] has joined #bitcoin-core-dev
09:28 -!- aqquadro [~name@2001:b07:2ee:6c29:cf3c:6ac:6c50:4ce6] has quit [Changing host]
09:28 -!- aqquadro [~name@unaffiliated/aqquadro] has joined #bitcoin-core-dev
09:33 < achow101> github dead :(
09:34 < spinza> yeah for me too
09:34 < aqquadro> achow101, spinza  thank you i was thinking is dead only for me
09:35 < achow101> check https://www.githubstatus.com/. the website part has a major outage
09:35 -!- brianhoffman [~brianhoff@pool-72-83-155-130.washdc.fios.verizon.net] has quit [Read error: Connection reset by peer]
09:37 < instagibbs> unicorns on various repos
09:38 -!- brianhoffman [~brianhoff@pool-72-83-155-130.washdc.fios.verizon.net] has joined #bitcoin-core-dev
09:47 -!- Skirmant [~Skirmant@213.197.171.57] has joined #bitcoin-core-dev
09:48 -!- Murch [~murch@172.56.13.70] has quit [Quit: Snoozing.]
09:50 -!- Murch [~murch@172.56.13.70] has joined #bitcoin-core-dev
09:53 -!- jungly [~quassel@host97-200-static.8-79-b.business.telecomitalia.it] has quit [Remote host closed the connection]
09:53 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
09:58 < spinza> unicorns gone for me
10:04 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
10:04 -!- jarthur [~jarthur@207.114.244.5] has quit [Read error: Connection reset by peer]
10:04 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
10:13 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-rrybrtruoxpdnddp] has joined #bitcoin-core-dev
10:18 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev
10:18 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has quit [Excess Flood]
10:19 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev
10:26 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev
10:42 -!- Murch [~murch@172.56.13.70] has quit [Quit: Snoozing.]
10:43 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection]
10:46 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has quit [Ping timeout: 246 seconds]
10:48 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has joined #bitcoin-core-dev
10:55 -!- Murch [~murch@172.56.13.70] has joined #bitcoin-core-dev
11:22 -!- Skirmant [~Skirmant@213.197.171.57] has quit [Ping timeout: 250 seconds]
11:25 -!- Skirmant [~Skirmant@213.197.171.57] has joined #bitcoin-core-dev
11:26 -!- Skirmant [~Skirmant@213.197.171.57] has quit [Max SendQ exceeded]
11:27 -!- Skirmant [~Skirmant@213.197.171.57] has joined #bitcoin-core-dev
11:39 -!- Skirmant [~Skirmant@213.197.171.57] has quit [Ping timeout: 245 seconds]
11:41 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
11:42 -!- Murch [~murch@172.56.13.70] has quit [Quit: Snoozing.]
11:42 -!- rex4539 [~rex4539@ppp-2-84-172-26.home.otenet.gr] has joined #bitcoin-core-dev
11:47 -!- Murch [~murch@172.56.12.87] has joined #bitcoin-core-dev
11:54 -!- evenom [~evenom@185.108.128.27] has joined #bitcoin-core-dev
11:54 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection]
11:56 -!- Murch [~murch@172.56.12.87] has quit [Quit: Snoozing.]
11:58 -!- michaelsdunn1 [~michaelsd@38.126.31.226] has joined #bitcoin-core-dev
11:58 -!- michaelsdunn1 [~michaelsd@38.126.31.226] has quit [Changing host]
11:58 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev
11:59 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
12:01 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has quit [Ping timeout: 246 seconds]
12:08 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
12:14 -!- aqquadro [~name@unaffiliated/aqquadro] has quit [Ping timeout: 250 seconds]
12:14 -!- evenom [~evenom@185.108.128.27] has quit [Quit: Leaving]
12:14 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has joined #bitcoin-core-dev
12:22 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has joined #bitcoin-core-dev
12:39 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev
12:45 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Ping timeout: 250 seconds]
12:50 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection]
12:51 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-njmxwwmnrkjnogue] has joined #bitcoin-core-dev
12:51 < bitcoin-git> [bitcoin] harding opened pull request #15081: Doc: Update release notes for master through to 2019-01-01 (master...2019-01-monthly-release-notes-update) https://github.com/bitcoin/bitcoin/pull/15081
12:51 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-njmxwwmnrkjnogue] has left #bitcoin-core-dev []
12:51 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev
12:57 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Remote host closed the connection]
13:01 -!- dviola [~diego@unaffiliated/dviola] has quit [Ping timeout: 250 seconds]
13:03 -!- cryptapus [~cryptapus@jupiter.osmus.org] has joined #bitcoin-core-dev
13:03 -!- cryptapus [~cryptapus@jupiter.osmus.org] has quit [Changing host]
13:03 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev
13:07 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
13:09 -!- cluelessperson [~cluelessp@unaffiliated/cluelessperson] has quit [Ping timeout: 252 seconds]
13:11 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has quit [Remote host closed the connection]
13:11 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has joined #bitcoin-core-dev
13:12 -!- dviola [~diego@179.235.26.181] has joined #bitcoin-core-dev
13:12 -!- dviola [~diego@179.235.26.181] has quit [Changing host]
13:12 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
13:16 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has quit [Ping timeout: 240 seconds]
13:31 -!- rex4539 [~rex4539@ppp-2-84-172-26.home.otenet.gr] has quit [Quit: rex4539]
13:35 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.3]
13:38 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-rrybrtruoxpdnddp] has quit [Quit: Connection closed for inactivity]
13:39 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection]
13:40 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has joined #bitcoin-core-dev
13:40 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev
13:41 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection]
13:42 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev
13:50 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Ping timeout: 240 seconds]
13:50 -!- cryptapus [~cryptapus@jupiter.osmus.org] has joined #bitcoin-core-dev
13:50 -!- cryptapus [~cryptapus@jupiter.osmus.org] has quit [Changing host]
13:50 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev
13:55 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
14:12 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection]
14:17 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
14:19 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has quit [Remote host closed the connection]
14:20 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has joined #bitcoin-core-dev
14:30 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
14:34 -!- jarthur_ [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
14:35 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
14:37 -!- jarthur_ [~jarthur@207.114.244.5] has quit [Remote host closed the connection]
14:37 -!- jarthur_ [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
14:38 -!- jarthur [~jarthur@207.114.244.5] has quit [Ping timeout: 272 seconds]
14:39 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Client Quit]
14:40 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
14:40 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
14:41 -!- jarthur_ [~jarthur@207.114.244.5] has quit [Ping timeout: 240 seconds]
14:41 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has quit [Remote host closed the connection]
14:43 -!- sfhi [~sfhi@30840-1-85ef2b-01.services.oktawave.com] has joined #bitcoin-core-dev
14:44 -!- jarthur [~jarthur@207.114.244.5] has quit [Ping timeout: 246 seconds]
14:48 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev
14:49 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Remote host closed the connection]
14:49 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev
14:56 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has joined #bitcoin-core-dev
14:58 -!- sfhi [~sfhi@30840-1-85ef2b-01.services.oktawave.com] has quit [Quit: Leaving]
15:04 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection]
15:05 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev
15:11 -!- hirish [~hirish@ip85.ip-137-74-20.eu] has joined #bitcoin-core-dev
15:12 -!- hirish is now known as Guest14638
15:18 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
15:19 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
15:30 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection]
15:35 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 240 seconds]
15:40 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection]
15:54 < fanquake> promag, when you are testing for notifications on macOS. Are you using src/qt/bitcoin-qt, or calling make-deploy and using the App in the .dmg?
15:55 < fanquake> Seems to make a difference for me. re hebasto's comment, I didn't get anything in the Notification center at all, not just missing popups. I'll check again.
15:58 -!- fabianfabian [~fabianfab@D9656CCE.cm-27.dynamic.ziggo.nl] has joined #bitcoin-core-dev
16:01 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
16:03 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
16:05 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 246 seconds]
16:26 < fanquake> Anyone have a PR for high-priority? Looking at bit empty at the moment -> https://github.com/bitcoin/bitcoin/projects/8
16:28 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
16:30 -!- yusuf [2ec49a3c@gateway/web/freenode/ip.46.196.154.60] has joined #bitcoin-core-dev
16:30 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
16:30 < yusuf> hello
16:34 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds]
16:41 -!- yusuf [2ec49a3c@gateway/web/freenode/ip.46.196.154.60] has quit [Quit: Page closed]
16:57 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has quit [Remote host closed the connection]
17:02 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
17:03 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has joined #bitcoin-core-dev
17:15 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 272 seconds]
17:16 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
17:34 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
17:55 -!- RATHARARE [6bc1e1d6@gateway/web/freenode/ip.107.193.225.214] has joined #bitcoin-core-dev
17:57 -!- mistergold [~mistergol@77.243.26.11] has joined #bitcoin-core-dev
17:59 -!- cluelessperson_ [~cluelessp@2604:4080:1326:83c5:604f:2ff:fe8e:c545] has joined #bitcoin-core-dev
18:02 -!- mistergold [~mistergol@77.243.26.11] has quit [Ping timeout: 246 seconds]
18:09 -!- mistergold [~mistergol@77.243.26.11] has joined #bitcoin-core-dev
18:09 -!- mistergold [~mistergol@77.243.26.11] has quit [Read error: Connection reset by peer]
18:12 -!- RATHARARE [6bc1e1d6@gateway/web/freenode/ip.107.193.225.214] has quit [Quit: Page closed]
18:12 -!- irc_viewer_test [irc_viewer@gateway/vpn/privateinternetaccess/ircviewertest/x-06412631] has joined #bitcoin-core-dev
18:15 -!- irc_viewer_test [irc_viewer@gateway/vpn/privateinternetaccess/ircviewertest/x-06412631] has quit [Client Quit]
18:22 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
18:41 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
19:04 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has quit [Ping timeout: 244 seconds]
19:08 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 250 seconds]
19:41 -!- cluelessperson_ [~cluelessp@2604:4080:1326:83c5:604f:2ff:fe8e:c545] has quit [Quit: Laters]
19:41 -!- cluelessperson_ [~cluelessp@unaffiliated/cluelessperson] has joined #bitcoin-core-dev
19:43 -!- cluelessperson_ [~cluelessp@unaffiliated/cluelessperson] has quit [Client Quit]
19:44 -!- cluelessperson [~cluelessp@unaffiliated/cluelessperson] has joined #bitcoin-core-dev
19:56 -!- bytting [~corebob@2a02:fe0:c130:6160:a966:37db:35e2:27d0] has joined #bitcoin-core-dev
20:04 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection]
20:05 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev
20:09 -!- tmc [17f34f5a@gateway/web/freenode/ip.23.243.79.90] has joined #bitcoin-core-dev
20:10 -!- tmc [17f34f5a@gateway/web/freenode/ip.23.243.79.90] has quit [Client Quit]
20:22 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 250 seconds]
20:25 < achow101> fanquake: #14491
20:25 < gribble> https://github.com/bitcoin/bitcoin/issues/14491 | Allow descriptor imports with importmulti by MeshCollider · Pull Request #14491 · bitcoin/bitcoin · GitHub
20:25 < fanquake> achow101 done
20:26 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-brctfqwkjklfpeco] has joined #bitcoin-core-dev
20:26 < bitcoin-git> [bitcoin] bytting opened pull request #15083: wallet: Fix a bug where memcmp takes a pointer address as second argument (master...20190103-fix-memcmp) https://github.com/bitcoin/bitcoin/pull/15083
20:26 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-brctfqwkjklfpeco] has left #bitcoin-core-dev []
20:34 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
20:38 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 250 seconds]
21:00 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has joined #bitcoin-core-dev
21:09 -!- bytting [~corebob@2a02:fe0:c130:6160:a966:37db:35e2:27d0] has quit [Remote host closed the connection]
21:42 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has quit [Remote host closed the connection]
21:42 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has joined #bitcoin-core-dev
22:32 -!- rex4539 [~rex4539@ppp-2-84-172-26.home.otenet.gr] has joined #bitcoin-core-dev
22:34 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
22:39 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 245 seconds]
22:43 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-rjggzcbaayjcuxgd] has joined #bitcoin-core-dev
22:43 < bitcoin-git> [bitcoin] benthecarman opened pull request #15084: gui: don't disable the sync overlay when wallet is disabled (master...sync_overlay_without_wallet) https://github.com/bitcoin/bitcoin/pull/15084
22:43 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-rjggzcbaayjcuxgd] has left #bitcoin-core-dev []
22:50 -!- rex4539 [~rex4539@ppp-2-84-172-26.home.otenet.gr] has quit [Quit: rex4539]
23:06 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-zueqrowlmimeejqw] has joined #bitcoin-core-dev
23:06 < bitcoin-git> [bitcoin] benthecarman opened pull request #15085: gui: Fix for Incorrect application name when passing -regtest (master...regest_window_name) https://github.com/bitcoin/bitcoin/pull/15085
23:06 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-zueqrowlmimeejqw] has left #bitcoin-core-dev []
23:08 -!- Initech [~Initech@177.9.146.12] has joined #bitcoin-core-dev
23:10 -!- chenpo [~chenpo@36-230-73-200.dynamic-ip.hinet.net] has joined #bitcoin-core-dev
23:16 -!- Initech [~Initech@177.9.146.12] has quit [Quit: Leaving]
23:19 -!- chenpo [~chenpo@36-230-73-200.dynamic-ip.hinet.net] has quit [Remote host closed the connection]
23:21 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev
23:21 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection]
23:24 -!- chenpo [~chenpo@36-230-73-200.dynamic-ip.hinet.net] has joined #bitcoin-core-dev
23:27 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev
23:40 -!- chenpo [~chenpo@36-230-73-200.dynamic-ip.hinet.net] has quit []
23:43 -!- fabianfabian [~fabianfab@D9656CCE.cm-27.dynamic.ziggo.nl] has quit [Quit: Textual IRC Client: www.textualapp.com]
23:45 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-onxurqmeblowirxo] has joined #bitcoin-core-dev
23:45 < bitcoin-git> [bitcoin] benthecarman opened pull request #15086: rpc: Fixing logical error in ListTransactions (master...fix_logical_error_in_ListTransactions) https://github.com/bitcoin/bitcoin/pull/15086
23:45 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-onxurqmeblowirxo] has left #bitcoin-core-dev []
23:59 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-rfdmnknqsbwelrcz] has joined #bitcoin-core-dev
23:59 < bitcoin-git> [bitcoin] benthecarman closed pull request #15086: rpc: Fixing logical error in ListTransactions (master...fix_logical_error_in_ListTransactions) https://github.com/bitcoin/bitcoin/pull/15086
23:59 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-rfdmnknqsbwelrcz] has left #bitcoin-core-dev []
--- Log closed Thu Jan 03 00:00:10 2019