--- Log opened Thu Jan 03 00:00:10 2019 00:04 -!- rex4539 [~rex4539@ppp-2-84-172-26.home.otenet.gr] has joined #bitcoin-core-dev 00:08 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 00:09 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 00:17 -!- ChA1NsAw [~ChA1NsAw@ptr-bwwzb6ok5sopvfgriio.18120a2.ip6.access.telenet.be] has joined #bitcoin-core-dev 00:35 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 00:37 < fanquake> wumpus: when you have time this arvo; #15065, 15081 & 15038 should be mergable. 00:37 < gribble> https://github.com/bitcoin/bitcoin/issues/15065 | 0.17: GUI Backports #14123 #14133 #14383 #14597 by promag · Pull Request #15065 · bitcoin/bitcoin · GitHub 00:39 -!- aqquadro [~name@net-37-159-134-26.cust.vodafonedsl.it] has joined #bitcoin-core-dev 00:39 -!- aqquadro [~name@net-37-159-134-26.cust.vodafonedsl.it] has quit [Changing host] 00:39 -!- aqquadro [~name@unaffiliated/aqquadro] has joined #bitcoin-core-dev 00:40 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 250 seconds] 00:41 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 00:51 -!- jungly [~quassel@79.8.200.97] has joined #bitcoin-core-dev 00:51 -!- e4xit_ [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has joined #bitcoin-core-dev 00:51 < wumpus> fanquake: thank you, will have a look 00:52 -!- qu4ku [~qu4ku@2a01:110f:d06:bd00:4032:42a8:dc9:6ad6] has joined #bitcoin-core-dev 00:53 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has quit [Ping timeout: 246 seconds] 00:55 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-tcqkohbbalhuekoz] has joined #bitcoin-core-dev 00:55 < bitcoin-git> [bitcoin] laanwj pushed 9 new commits to 0.17: https://github.com/bitcoin/bitcoin/compare/16521ce08676...5ff7b372cdbd 00:55 < bitcoin-git> bitcoin/0.17 298dc15 João Barbosa: gui: Favor macOS show / hide action in dock menu... 00:55 < bitcoin-git> bitcoin/0.17 d2ed162 Hennadii Stepanov: Clean systray icon menu for -disablewallet mode... 00:55 < bitcoin-git> bitcoin/0.17 4d4bc37 Hennadii Stepanov: Remove obj_c for macOS Dock icon setting... 00:55 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-tcqkohbbalhuekoz] has left #bitcoin-core-dev [] 00:57 < wumpus> fanquake: please approve #15081 it still shows as "fanquake requested changes" 00:57 < gribble> https://github.com/bitcoin/bitcoin/issues/15081 | Doc: Update release notes for master through to 2019-01-01 by harding · Pull Request #15081 · bitcoin/bitcoin · GitHub 00:59 < fanquake> wumpus: sorry, should be fixed now I think. 00:59 < wumpus> yep! 01:03 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 01:03 -!- Murch [~murch@119.42.201.77.rev.sfr.net] has joined #bitcoin-core-dev 01:08 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 272 seconds] 01:15 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Ping timeout: 256 seconds] 01:16 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev 01:18 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Remote host closed the connection] 01:23 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev 01:24 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-humjenjlsknnikxx] has joined #bitcoin-core-dev 01:24 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/fb52d0684e0f...031e3a32b245 01:24 < bitcoin-git> bitcoin/master 97fbe67 David A. Harding: Release notes: update notes through fb52d0684 01:24 < bitcoin-git> bitcoin/master f3d7d75 David A. Harding: Release notes: integrate detached release notes 01:24 < bitcoin-git> bitcoin/master 031e3a3 Wladimir J. van der Laan: Merge #15081: Doc: Update release notes for master through to 2019-01-01... 01:24 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-humjenjlsknnikxx] has left #bitcoin-core-dev [] 01:24 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-qlropstmqslawcys] has joined #bitcoin-core-dev 01:24 < bitcoin-git> [bitcoin] laanwj closed pull request #15081: Doc: Update release notes for master through to 2019-01-01 (master...2019-01-monthly-release-notes-update) https://github.com/bitcoin/bitcoin/pull/15081 01:24 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-qlropstmqslawcys] has left #bitcoin-core-dev [] 01:28 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 01:45 < hebasto> fanquake: hi, did your check macOS notifications after merging #15000? 01:45 < gribble> https://github.com/bitcoin/bitcoin/issues/15000 | qt: Fix broken notificator on GNOME by hebasto · Pull Request #15000 · bitcoin/bitcoin · GitHub 01:49 < hebasto> *you 01:54 < fanquake> hebasto I tested with #15007, but not with just master. Can have another look tonight. 01:54 < gribble> https://github.com/bitcoin/bitcoin/issues/15007 | qt: Notificator class refactoring by hebasto · Pull Request #15007 · bitcoin/bitcoin · GitHub 02:09 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-hlisypdqfbhdfihr] has joined #bitcoin-core-dev 02:09 -!- e4xit_ [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has left #bitcoin-core-dev ["WeeChat 1.9.1"] 02:10 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has joined #bitcoin-core-dev 02:20 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:24 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 250 seconds] 02:37 -!- Murch [~murch@119.42.201.77.rev.sfr.net] has quit [Quit: Snoozing.] 02:42 -!- Murch [~murch@119.42.201.77.rev.sfr.net] has joined #bitcoin-core-dev 02:43 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has quit [Quit: quit] 02:46 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has joined #bitcoin-core-dev 02:54 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 02:57 -!- jungly [~quassel@79.8.200.97] has quit [Ping timeout: 245 seconds] 02:59 -!- phyrexia [~phyrexia@193.110.251.88] has joined #bitcoin-core-dev 03:00 -!- phyrexia [~phyrexia@193.110.251.88] has quit [Client Quit] 03:01 -!- jungly [~quassel@host97-200-static.8-79-b.business.telecomitalia.it] has joined #bitcoin-core-dev 03:06 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 03:17 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-sevpzmcujwqcaytf] has joined #bitcoin-core-dev 03:17 < bitcoin-git> [bitcoin] MeshCollider opened pull request #15087: Error if rpcpassword contains hash in conf sections (master...201901_pass_hash_fix) https://github.com/bitcoin/bitcoin/pull/15087 03:17 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-sevpzmcujwqcaytf] has left #bitcoin-core-dev [] 03:30 -!- qu4ku [~qu4ku@2a01:110f:d06:bd00:4032:42a8:dc9:6ad6] has quit [Ping timeout: 252 seconds] 03:56 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-fugdozwzjlywpzna] has joined #bitcoin-core-dev 03:56 < bitcoin-git> [bitcoin] cyberknight01 opened pull request #15088: Revert 1 master (master...revert-1-master) https://github.com/bitcoin/bitcoin/pull/15088 03:56 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-fugdozwzjlywpzna] has left #bitcoin-core-dev [] 03:57 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-uunesiayuukrnrnu] has joined #bitcoin-core-dev 03:57 < bitcoin-git> [bitcoin] cyberknight01 closed pull request #15088: Revert 1 master (master...revert-1-master) https://github.com/bitcoin/bitcoin/pull/15088 03:57 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-uunesiayuukrnrnu] has left #bitcoin-core-dev [] 04:09 -!- Murch [~murch@119.42.201.77.rev.sfr.net] has quit [Read error: Connection reset by peer] 04:11 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 04:13 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 250 seconds] 04:17 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 268 seconds] 04:23 -!- Murch [~murch@119.42.201.77.rev.sfr.net] has joined #bitcoin-core-dev 04:40 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 04:41 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 05:20 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Read error: Connection reset by peer] 05:20 < fanquake> Is there a meeting tonight? 05:20 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 05:36 -!- aqquadro [~name@unaffiliated/aqquadro] has quit [Ping timeout: 246 seconds] 05:42 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev 05:43 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 05:46 -!- ExtraCrispy [~ExtraCris@gateway/tor-sasl/extracrispy] has joined #bitcoin-core-dev 05:54 < promag> fanquake: I have tested both versions: make and make deploy 05:55 < promag> for high priority I'd like #14941 there 05:55 < gribble> https://github.com/bitcoin/bitcoin/issues/14941 | rpc: Make unloadwallet wait for complete wallet unload by promag · Pull Request #14941 · bitcoin/bitcoin · GitHub 05:55 < promag> but can ask later in the meeting 05:55 < fanquake> promag I've added it anyways 05:55 < promag> reason: changes behavior and its for backport 05:55 < promag> oh thanks! 05:56 < fanquake> np. I think I'll miss the meeting anyways. 06:06 < fanquake> If we run out of topics, I'd suggest discussing minimum Qt. Seems to be some consensus around 5.6 for 0.18.0, and I think that would be a good target. 06:13 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection] 06:15 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 06:26 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 06:52 < wumpus> fanquake: yes, today there is a meeting 06:59 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection] 07:14 -!- aqquadro [~name@net-37-159-134-26.cust.vodafonedsl.it] has joined #bitcoin-core-dev 07:14 -!- aqquadro [~name@net-37-159-134-26.cust.vodafonedsl.it] has quit [Changing host] 07:14 -!- aqquadro [~name@unaffiliated/aqquadro] has joined #bitcoin-core-dev 07:17 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev 07:33 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-dntmuqljnsyuedwe] has joined #bitcoin-core-dev 07:33 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/031e3a32b245...d1effa11aded 07:33 < bitcoin-git> bitcoin/master 7514361 Hennadii Stepanov: Correct misleading "overridden options" label... 07:33 < bitcoin-git> bitcoin/master d1effa1 Wladimir J. van der Laan: Merge #14375: qt: Correct misleading "overridden options" label... 07:33 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-dntmuqljnsyuedwe] has left #bitcoin-core-dev [] 07:34 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-zeigljjcaewuxvqe] has joined #bitcoin-core-dev 07:34 < bitcoin-git> [bitcoin] laanwj closed pull request #14375: qt: Correct misleading "overridden options" label (master...20181002-gui-overridden-options) https://github.com/bitcoin/bitcoin/pull/14375 07:34 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-zeigljjcaewuxvqe] has left #bitcoin-core-dev [] 07:37 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection] 07:37 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 07:42 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 246 seconds] 07:44 -!- Murch [~murch@119.42.201.77.rev.sfr.net] has quit [Quit: Snoozing.] 07:44 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-dmutgsmqvktffzlt] has joined #bitcoin-core-dev 07:44 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d1effa11aded...06fabfa2878e 07:44 < bitcoin-git> bitcoin/master 1db71d4 Graham Krizek: Add names to Travis jobs... 07:44 < bitcoin-git> bitcoin/master 06fabfa MarcoFalke: Merge #15020: Build: add names to Travis jobs... 07:44 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-dmutgsmqvktffzlt] has left #bitcoin-core-dev [] 07:44 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-oiknqqfcaxtzjsmg] has joined #bitcoin-core-dev 07:44 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #15020: Build: add names to Travis jobs (master...travis-job-names) https://github.com/bitcoin/bitcoin/pull/15020 07:44 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-oiknqqfcaxtzjsmg] has left #bitcoin-core-dev [] 08:01 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-vmigdguabrfikjdx] has joined #bitcoin-core-dev 08:01 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/06fabfa2878e...1d73636fdf1e 08:01 < bitcoin-git> bitcoin/master 79f0a3f Hennadii Stepanov: Get more info about GUI-related issue on Linux 08:01 < bitcoin-git> bitcoin/master 1d73636 Wladimir J. van der Laan: Merge #15038: docs: Get more info about GUI-related issue on Linux... 08:01 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-vmigdguabrfikjdx] has left #bitcoin-core-dev [] 08:02 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-hlgoxxnwroekzxle] has joined #bitcoin-core-dev 08:02 < bitcoin-git> [bitcoin] laanwj closed pull request #15038: docs: Get more info about GUI-related issue on Linux (master...20181226-issue-template-gui-linux) https://github.com/bitcoin/bitcoin/pull/15038 08:02 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-hlgoxxnwroekzxle] has left #bitcoin-core-dev [] 08:03 -!- aqquadro [~name@unaffiliated/aqquadro] has quit [Ping timeout: 246 seconds] 08:05 -!- aqquadro [~name@unaffiliated/aqquadro] has joined #bitcoin-core-dev 08:11 -!- aqquadro [~name@unaffiliated/aqquadro] has quit [Ping timeout: 244 seconds] 08:11 -!- aqquadro [~name@unaffiliated/aqquadro] has joined #bitcoin-core-dev 08:14 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 08:19 -!- aqquadro [~name@unaffiliated/aqquadro] has quit [Ping timeout: 268 seconds] 08:29 -!- CodeBlue1776 [~CodeBlue1@107-215-134-60.lightspeed.cicril.sbcglobal.net] has quit [Read error: Connection reset by peer] 08:30 -!- CodeBlue1776 [~CodeBlue1@107-215-134-60.lightspeed.cicril.sbcglobal.net] has joined #bitcoin-core-dev 08:32 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection] 08:34 -!- aqquadro [~name@net-37-159-134-26.cust.vodafonedsl.it] has joined #bitcoin-core-dev 08:34 -!- aqquadro [~name@net-37-159-134-26.cust.vodafonedsl.it] has quit [Changing host] 08:34 -!- aqquadro [~name@unaffiliated/aqquadro] has joined #bitcoin-core-dev 08:35 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 08:36 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 08:42 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 08:43 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 08:43 < dongcarl> If anyone's familiar with the qt side of things, I'd really appreciate some help here: https://github.com/bitcoin/bitcoin/pull/14856#issuecomment-451200652 08:51 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 08:56 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 08:58 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-xyjowjlptboisimh] has joined #bitcoin-core-dev 08:58 < bitcoin-git> [bitcoin] DrahtBot closed pull request #12153: Avoid permanent cs_main lock in getblockheader (master...2018-01-getblockheader) https://github.com/bitcoin/bitcoin/pull/12153 08:58 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-xyjowjlptboisimh] has left #bitcoin-core-dev [] 09:13 < wumpus> dongcarl: maybe ask ryanofsky he'll probably know the most about the interface:: stuff 09:14 -!- aqquadro [~name@unaffiliated/aqquadro] has quit [Ping timeout: 244 seconds] 09:16 -!- aqquadro [~name@net-37-159-134-26.cust.vodafonedsl.it] has joined #bitcoin-core-dev 09:16 -!- aqquadro [~name@net-37-159-134-26.cust.vodafonedsl.it] has quit [Changing host] 09:16 -!- aqquadro [~name@unaffiliated/aqquadro] has joined #bitcoin-core-dev 09:19 < promag> MarcoFalke: maybe I should rebase #12151 to get a fresh travis build? 09:19 < gribble> https://github.com/bitcoin/bitcoin/issues/12151 | rpc: Remove cs_main lock from blockToJSON and blockheaderToJSON by promag · Pull Request #12151 · bitcoin/bitcoin · GitHub 09:22 < wumpus> promag: you want a fresh travis build? I can retrigger travis if you want 09:22 < promag> but does it rebase with master? 09:23 < wumpus> it should 09:24 < promag> ok then! 09:26 -!- aqquadro [~name@unaffiliated/aqquadro] has quit [Ping timeout: 250 seconds] 09:30 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 10:19 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 10:20 -!- jungly [~quassel@host97-200-static.8-79-b.business.telecomitalia.it] has quit [Remote host closed the connection] 10:32 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 246 seconds] 10:37 < moneyball> for today's meeting, there is one topic proposed ahead of time, which was discussed a bit after proposal, but achow101 may want to address further today: topic proposed by achow101: having users create their wallets instead of automatically creating a default wallet 10:38 < sipa> I will probably miss the meeting 10:51 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 10:53 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds] 11:01 < jonasschnelli> hi 11:01 < gleb> hi 11:01 < achow101> hi 11:01 < moneyball> hi 11:01 < wumpus> hi 11:01 < wumpus> #startmeeting 11:01 < lightningbot> Meeting started Thu Jan 3 19:01:48 2019 UTC. The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot. 11:01 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic. 11:01 < moneyball> happy 10 year genesis block 11:02 < meshcollider> hi 11:02 < jonasschnelli> \o/ 11:02 < wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb 11:02 < jamesob> hi 11:02 < promag> hi 11:02 < instagibbs> happy 10 years wumpus, who i assume is satoshi 11:02 < wumpus> yes \o/ 11:02 < instagibbs> hi 11:02 < wumpus> lol instagibbs 11:04 < wumpus> #topic high priority for review 11:05 < wumpus> #11082 #14491 #14941 11:05 < gribble> https://github.com/bitcoin/bitcoin/issues/11082 | Add new bitcoin_rw.conf file that is used for settings modified by this software itself by luke-jr · Pull Request #11082 · bitcoin/bitcoin · GitHub 11:05 < gribble> https://github.com/bitcoin/bitcoin/issues/14491 | Allow descriptor imports with importmulti by MeshCollider · Pull Request #14491 · bitcoin/bitcoin · GitHub 11:05 < wumpus> are the current PRs 11:05 < phantomcircuit> hi 11:05 < gribble> https://github.com/bitcoin/bitcoin/issues/14941 | rpc: Make unloadwallet wait for complete wallet unload by promag · Pull Request #14941 · bitcoin/bitcoin · GitHub 11:05 < wumpus> promag would like to add #14941 11:06 < gribble> https://github.com/bitcoin/bitcoin/issues/14941 | rpc: Make unloadwallet wait for complete wallet unload by promag · Pull Request #14941 · bitcoin/bitcoin · GitHub 11:06 < wumpus> eh wait, that's already on there? 11:06 < jamesob> can I nominate jimpo's BIP157/8-related PRs that've been hanging out for a while? maybe starting with #14111? 11:06 < gribble> https://github.com/bitcoin/bitcoin/issues/14111 | index: Create IndexRunner class for activing indexes. by jimpo · Pull Request #14111 · bitcoin/bitcoin · GitHub 11:06 < promag> fanquake added 11:06 < achow101> #15006 11:06 < gribble> https://github.com/bitcoin/bitcoin/issues/15006 | Add option to create an encrypted wallet by achow101 · Pull Request #15006 · bitcoin/bitcoin · GitHub 11:07 -!- Tralfaz [~none@185.156.175.59] has quit [Quit: Leaving] 11:07 < jamesob> also ryanofsky's next step in the process separation project, #14711 11:07 < gribble> https://github.com/bitcoin/bitcoin/issues/14711 | Remove uses of chainActive and mapBlockIndex in wallet code by ryanofsky · Pull Request #14711 · bitcoin/bitcoin · GitHub 11:07 < achow101> I guess #14938 should go first as 15006 depends on it 11:07 < gribble> https://github.com/bitcoin/bitcoin/issues/14938 | Support creating an empty wallet by Sjors · Pull Request #14938 · bitcoin/bitcoin · GitHub 11:09 < wumpus> #14938 first then? 11:09 < gribble> https://github.com/bitcoin/bitcoin/issues/14938 | Support creating an empty wallet by Sjors · Pull Request #14938 · bitcoin/bitcoin · GitHub 11:09 < wumpus> right 11:09 < jonasschnelli> yes 11:10 < jamesob> oops I'm sorry -- that jimpo PR isn't critical path for BIP157; I meant #14085 11:10 < gribble> https://github.com/bitcoin/bitcoin/issues/14085 | index: Fix for indexers skipping genesis block. by jimpo · Pull Request #14085 · bitcoin/bitcoin · GitHub 11:10 < wumpus> ok added the mentioned ones 11:10 < wumpus> jamesob: ok, will replace it then 11:11 < jamesob> wumpus: thanks. fwiw ultimately I'm after #14121, but that PR is a dep 11:11 < gribble> https://github.com/bitcoin/bitcoin/issues/14121 | Index for BIP 157 block filters by jimpo · Pull Request #14121 · bitcoin/bitcoin · GitHub 11:11 < wumpus> right, better to put that one then, the idea of high priority for review is PRs that are dependencies of others 11:12 < wumpus> https://github.com/bitcoin/bitcoin/projects/8 11:13 < wumpus> #topic having users create their wallets instead of automatically creating a default wallet (achow101) 11:13 < achow101> this was discussed briefly when I first mentioned it 11:13 < jonasschnelli> I like the concept 11:13 < achow101> the end goal is to make wallets that were "born encrypted" 11:14 < luke-jr> I suspect it may be confusing to some users 11:14 < wumpus> I think both should be possible 11:14 < jonasschnelli> I don't think it confuses users... we could still trigger the "create" wallet process at first launch in the GUI 11:15 < wumpus> ideally, if you want the default wallet, that's fine, if you want to create something customized and start with nothing, that should be possible 11:15 < jonasschnelli> but that sounds after a lot of configuration options.. do you mean a -nodefaultwallet options? 11:15 < wumpus> I think having to set an encryption key at first used has been argued against in the past though 11:16 < achow101> My idea is to get rid of the default wallet entirely. I don't think there really should be a default wallet 11:16 < meshcollider> Can't a default wallet setup box or something pop up like the datadir one on first launch 11:16 < achow101> and having the default wallet with createwallet can be confusing. users may mistakenly send things to the default wallet when they meant to use some other wallet 11:16 < wumpus> meshcollider: exactly; that could be skippable 11:16 < jonasschnelli> I agree... wallets should probably created intentionally since its an important data file 11:17 < gmaxwell> jonasschnelli: doing something automatically on first _launch_ would largely defeat the point. 11:17 < gmaxwell> jonasschnelli: the behavior I've been recommending is triggering it when the user attempts to get an address. 11:17 < jonasschnelli> gmaxwell: only in the GUI (wizzard) .... 11:17 < wumpus> I think changing this is too late for 0.18 11:17 < gmaxwell> jonasschnelli: yes, that still defeats the point. 11:17 < jonasschnelli> though I'm not convince... only if we "confuse" users with removing the default wallet 11:17 < achow101> gmaxwell: so I investigated the create wallet on use stuff before and I think it would be rather fragile or require a lot more refactoring 11:18 < jonasschnelli> But yeah,.. I agree with you gmaxwell 11:18 < gmaxwell> achow101: But do you not agree that it's the right behavior? 11:18 < promag> gmaxwell: also for rpc clients? 11:18 -!- irc_viewer_test [irc_viewer@gateway/vpn/privateinternetaccess/ircviewertest/x-06412631] has joined #bitcoin-core-dev 11:19 < achow101> gmaxwell: yes. but I think that having the user explicitly create the wallet is a suitable replacement too 11:19 < gmaxwell> promag: I have less strong opinions on that, I could go either way. The RPC can't prompt you to answer more questions (like encryption), while the gui can. 11:19 < wumpus> but for RPC the client could use createwallet explicitly to create the first wallet 11:19 < ryanofsky> Will add my +1 for Greg's idea. I think creating a default wallet when needed is more user friendly. 11:20 < gmaxwell> achow101: what exactly does that mean? do you mean getnewaddress should be missing from the UI otherwise, or it should silently fail? 11:20 < promag> gmaxwell: I'd love to remove the implicit wallet endpoint 11:20 < jonasschnelli> When the wallet is auto-creating when it's needed, there is (probably) no place for additional options 11:20 < achow101> gmaxwell: i mean that getnewaddress would give you an error saying "do createwallet first" 11:20 < gmaxwell> achow101: because if the GUI would offer the options but pop up a message, then that could simply start wallet creation: so I don't see where the additional refactoring comes in there for the gui. 11:21 < wumpus> this is similar to say, SQL servers, they don't usually create a default database either but assume the client will create one 11:21 < wumpus> for RPC that makes perfect sense, for the GUI, I don't know 11:22 < promag> achow101: not only that imo, all wallet methods 11:22 < achow101> gmaxwell: in the gui, i imagine it would be like the disablewallet ui but a button that says "click here to make a wallet" 11:22 < gmaxwell> promag: if the endpoint is gone, then users will just get a command not found. We can do that, but kinda lugly. 11:22 < jonasschnelli> I think the GUI with no wallet will require (decent) refactoring to show the receive tab in order to let the user click on "new address" 11:22 -!- hebasto [~hebasto@95.164.65.194] has quit [Read error: Connection reset by peer] 11:22 < gmaxwell> achow101: If it's made conspicious enough, thats fine with me I suppose. 11:23 < gmaxwell> We just need to be careful to not make the software unusable for new users. 11:23 < wumpus> gmaxwell: that is an implementation detail depending on how it's handled, it could just as well return a message to create a wallet first 11:23 < achow101> the point is that it's going to be totally obvious that you need to make a new wallet. there shouldn't be any magic in the background 11:23 < gmaxwell> like they shouldn't have to dig through menus to make expected options appear or anything like that. 11:23 < jonasschnelli> Why not do it like other wallets,... if the GUI detects no wallet, allow to load or create a wallet 11:23 < wumpus> jonasschnelli: exactly 11:23 < wumpus> that makes perfect sense for the GUI 11:24 < gmaxwell> jonasschnelli: when? 11:24 < wumpus> at start, when there's no wallet.dat 11:24 < luke-jr> maybe after the first-launch screen it should open some new wallet wizard with a Skip button 11:24 < jonasschnelli> When the GUI loads and no wallet has been detected (but was compiled with wallet support) 11:24 < jonasschnelli> Ask: new / open 11:24 < wumpus> and no -disablewallet or -nowallet or such was specified 11:24 < jonasschnelli> yes 11:24 < gmaxwell> The point of not creating the wallet on start is so that the wallet will not be created unencrypted, and also so that you don't end up with a lot of unusued wallet files laying around. 11:24 < wumpus> gmaxwell: right 11:24 < wumpus> that's one advantage of never creating wallet.dat without prompting 11:25 < gmaxwell> And you don't prompt for an encrypted key at initial start because users will set something random forget it, then months later send funds to it. 11:25 < achow101> gmaxwell: that would be part of the ui prompt 11:25 < jonasschnelli> That is a critical point 11:25 < achow101> gmaxwell: something like what electrum does on its first start 11:25 < gmaxwell> (Electrum insututed a complicated UI flow that forces users to write down a recovery code to address that issue) 11:25 < promag> gmaxwell: actually I'm working on "File -> Reopen Wallet -> ..." which requires saving a history.. if this is empty it could prompt the wizard 11:26 < jonasschnelli> Electrum is too much handholding IMO 11:26 < gmaxwell> Electrum's behavior was driven by massive amounts of funds loss that happened when prompting users for encryption keys months before using the wallet. 11:27 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has quit [Read error: Connection reset by peer] 11:27 < wumpus> it'd be possible to skip wallet creation completely 11:27 < jonasschnelli> That would speak for the create-on-first-new-address 11:27 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has joined #bitcoin-core-dev 11:27 < gmaxwell> jonasschnelli: or just having a clear create button. 11:27 < achow101> as I said earlier, I think the ideal solution would be to just have a button in the main ui that says "click here to make a wallet" 11:27 < gmaxwell> Or having error messages on use that tell you to create. 11:28 < wumpus> yes that was suggested, show the GUI in zero-wallet mode and have a 'create wallet' mode 11:28 < gmaxwell> Though if you are going to have an error message, it could just start the create dialog. 11:28 < wumpus> button 11:28 < luke-jr> use the webcam to make the user prove they wrote down the passphrase /s 11:28 < gmaxwell> That sounds okay to me, the implementation just needs to be conspicious. 11:28 < jonasschnelli> Ideally the GUI is completely usable (explore) without a wallet... and the wallet is created on first address 11:28 < promag> regarding the -wallet arg, should it stay "load or create"? 11:28 < wumpus> luke-jr: doesn't everyone have a sticker over those xD 11:28 < gmaxwell> luke-jr: electrum disables copy/paste and then makes you reenter on another screen. less computer vision required. :P 11:29 < gmaxwell> promag: probably load or create, maybe introduce a -walletfile that doesn't create? 11:29 < gmaxwell> and consider depricating the create version later? 11:30 < luke-jr> gmaxwell: I've always found that super annoying for network passwords (but haven't given it a lot of thought for wallet passphrases, or seeds) since it prevents password management 11:30 < achow101> promag: imo it should just be a load option. no create 11:30 < phantomcircuit> gmaxwell, i have so many completely empty wallet files backed up it's silly 11:30 < achow101> promag: maybe even error when the wallet file can't be found to load 11:31 < promag> achow101: maybe lazy creation - on actual usage? 11:31 < wumpus> I think we're starting to go in circles 11:31 < jonasschnelli> jup 11:31 < wumpus> any other topics? 11:32 < promag> anyway, too late for 0.18, and too many breaking changes 11:32 < wumpus> yes, let's aim to have the creat-with-password RPC in 0.18, but don't change any defaults 11:32 < jonasschnelli> ack 11:34 < promag> I'd like some feedback here #14941, so far only ryanofsky reviewed 11:34 < gribble> https://github.com/bitcoin/bitcoin/issues/14941 | rpc: Make unloadwallet wait for complete wallet unload by promag · Pull Request #14941 · bitcoin/bitcoin · GitHub 11:34 < wumpus> #action review #14941 11:35 < gribble> https://github.com/bitcoin/bitcoin/issues/14941 | rpc: Make unloadwallet wait for complete wallet unload by promag · Pull Request #14941 · bitcoin/bitcoin · GitHub 11:36 -!- irc_viewer_test [irc_viewer@gateway/vpn/privateinternetaccess/ircviewertest/x-06412631] has quit [Ping timeout: 244 seconds] 11:36 < wumpus> ok if there's no other topics, let's close the meeting early 11:36 < gmaxwell> achow101: error on failure is nice. 11:37 < promag> o/ 11:37 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 11:37 < wumpus> yes, having it wait for the unload before returning is certainly better conceptually, having it asynchronous only causes complexity 11:38 < wumpus> (and indeed, leaves no way to return errors) 11:39 < wumpus> #endmeeting 11:39 < lightningbot> Meeting ended Thu Jan 3 19:39:03 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) 11:39 < lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-01-03-19.01.html 11:39 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-01-03-19.01.txt 11:39 < lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-01-03-19.01.log.html 11:40 < luke-jr> O.o 11:45 < wumpus> o.O? 11:47 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 11:47 -!- irc_viewer_test1 [irc_viewer@gateway/vpn/privateinternetaccess/ircviewertest/x-06412631] has joined #bitcoin-core-dev 11:48 -!- irc_viewer_test1 [irc_viewer@gateway/vpn/privateinternetaccess/ircviewertest/x-06412631] has quit [Client Quit] 11:50 -!- Krellan [~Krellan@2601:640:4000:a876:e5b4:f7c8:a4ba:c52e] has quit [Remote host closed the connection] 11:56 < jl2012> what is the meaning of ~0 ? I read that in some github comments 11:58 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev 12:00 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection] 12:00 < BlueMatt> jl2012: 0xffffffff? 12:00 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-hlisypdqfbhdfihr] has quit [Quit: Connection closed for inactivity] 12:01 < BlueMatt> or ~= 0, ie the exact opposite, depending on the context 12:01 < jl2012> https://github.com/bitcoin/bitcoin/pull/14085#issuecomment-417782919 12:03 < achow101> jl2012: it means they are neither acking nor nacking the pr. they don't really support it, but aren't completely opposed to it. kind of like apathy 12:03 < BlueMatt> jl2012: oh, I think wumpus meant -0 12:04 < jl2012> ok, thanks! 12:06 < wumpus> "approximately zero", as in, I don't care about it 12:07 -!- jarthur [~jarthur@207.114.244.5] has quit [] 12:13 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 246 seconds] 12:13 < wumpus> but it looks a lot of people have utACKed it so doesn't matter 12:14 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev 12:14 < wumpus> could merge it, though the last post does make me doubt again? 12:19 < wumpus> I mean, if the BIP is changed, it doesn't need to be merged, right? 12:27 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection] 12:27 -!- aqquadro [~name@unaffiliated/aqquadro] has joined #bitcoin-core-dev 12:33 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev 12:33 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 12:37 -!- profmac [~ProfMac@2001:470:1f0f:226:3995:b56a:efcf:9f66] has quit [Ping timeout: 268 seconds] 12:41 -!- Tennis [~Tennis@unaffiliated/tennis] has joined #bitcoin-core-dev 12:50 -!- profmac [~ProfMac@2001:470:1f0f:226:b46a:e174:3d38:3b2e] has joined #bitcoin-core-dev 13:10 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 13:11 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection] 13:13 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev 13:15 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 13:23 -!- emilengler [~emil@2a02:8108:8240:4e4c:6d27:38d7:42b4:7037] has joined #bitcoin-core-dev 13:23 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection] 13:24 -!- emilengler [~emil@2a02:8108:8240:4e4c:6d27:38d7:42b4:7037] has left #bitcoin-core-dev ["Leaving"] 13:30 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 13:36 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection] 13:41 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Read error: Connection reset by peer] 13:41 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev 13:45 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-vrufarullzkozurm] has joined #bitcoin-core-dev 13:45 < bitcoin-git> [bitcoin] jonasschnelli opened pull request #15091: GUI: fix model overlay header sync (master...2019/01/qt_fix_modal) https://github.com/bitcoin/bitcoin/pull/15091 13:45 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-vrufarullzkozurm] has left #bitcoin-core-dev [] 13:46 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 13:51 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 13:58 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection] 14:06 < jonasschnelli> Thanks for reviewing #14353 (is a simple REST addition) 14:06 < gribble> https://github.com/bitcoin/bitcoin/issues/14353 | REST: add blockhash call, fetch blockhash by height by jonasschnelli · Pull Request #14353 · bitcoin/bitcoin · GitHub 14:06 < jonasschnelli> Its helpful for personal block explorers 14:09 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 14:09 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 268 seconds] 14:25 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection] 14:25 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 14:30 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 272 seconds] 14:31 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 14:43 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-kubpuacmtqrzppdd] has joined #bitcoin-core-dev 14:43 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1d73636fdf1e...d71d0d7b7f3f 14:43 < bitcoin-git> bitcoin/master 5bb0164 Chun Kuan Lee: depends: Enable unicode support on dbd for Windows 14:43 < bitcoin-git> bitcoin/master d71d0d7 MarcoFalke: Merge #13884: depends: Enable bdb unicode support for Windows... 14:43 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-kubpuacmtqrzppdd] has left #bitcoin-core-dev [] 14:44 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-okrimtwhmogbfkfr] has joined #bitcoin-core-dev 14:44 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #13884: depends: Enable bdb unicode support for Windows (master...bdb-utf8) https://github.com/bitcoin/bitcoin/pull/13884 14:44 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-okrimtwhmogbfkfr] has left #bitcoin-core-dev [] 14:44 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-tmfpbskkjxgruepc] has joined #bitcoin-core-dev 14:44 < bitcoin-git> [bitcoin] marcinja opened pull request #15093: rpc: Change importwallet to return additional errors (master...add-errors-to-importwallet) https://github.com/bitcoin/bitcoin/pull/15093 14:44 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-tmfpbskkjxgruepc] has left #bitcoin-core-dev [] 14:45 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 14:48 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:48 -!- ChA1NsAw [~ChA1NsAw@ptr-bwwzb6ok5sopvfgriio.18120a2.ip6.access.telenet.be] has quit [Quit: Leaving] 14:50 -!- aqquadro [~name@unaffiliated/aqquadro] has quit [Ping timeout: 250 seconds] 15:08 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Ping timeout: 245 seconds] 15:09 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-gpmvgxnxrettopvg] has joined #bitcoin-core-dev 15:09 < bitcoin-git> [bitcoin] benthecarman opened pull request #15094: 0.17: Backport for #15085 (0.17...0.17) https://github.com/bitcoin/bitcoin/pull/15094 15:09 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-gpmvgxnxrettopvg] has left #bitcoin-core-dev [] 15:10 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 15:18 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 15:18 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 15:20 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-hdnrxqhnhchvhneq] has joined #bitcoin-core-dev 15:20 < bitcoin-git> [bitcoin] benthecarman closed pull request #15094: 0.17: Backport for #15085 (0.17...0.17) https://github.com/bitcoin/bitcoin/pull/15094 15:20 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-hdnrxqhnhchvhneq] has left #bitcoin-core-dev [] 15:25 < fanquake> promag <.< 15:25 < promag> :) 15:26 < promag> thanks for pointing the script 15:28 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 15:36 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 15:36 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 15:40 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 15:59 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection] 16:03 -!- nolaan [~nolaan@95.173.114.78.rev.sfr.net] has joined #bitcoin-core-dev 16:06 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 16:09 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection] 16:15 -!- IGHOR [~quassel@93.178.216.72] has quit [Ping timeout: 240 seconds] 16:18 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev 16:22 -!- nolaan [~nolaan@95.173.114.78.rev.sfr.net] has quit [Quit: Konversation terminated!] 16:31 -!- peevsie [~peevsie@2604:2000:f184:9300::4] has joined #bitcoin-core-dev 16:38 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 16:43 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 244 seconds] 17:09 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 17:14 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 250 seconds] 17:39 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev 17:43 -!- IGHOR [~quassel@93.178.216.72] has quit [Ping timeout: 272 seconds] 17:45 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev 17:52 -!- Tennis [~Tennis@unaffiliated/tennis] has quit [Quit: Leaving] 17:56 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 18:08 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev 18:11 -!- IGHOR [~quassel@93.178.216.72] has quit [Ping timeout: 244 seconds] 18:11 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev 18:21 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 244 seconds] 18:30 -!- peevsie [~peevsie@2604:2000:f184:9300::4] has quit [Ping timeout: 252 seconds] 18:37 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.3] 18:43 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection] 18:52 -!- peevsie [~peevsie@2604:2000:f184:9300::4] has joined #bitcoin-core-dev 18:57 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 19:01 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection] 19:02 -!- peevsie [~peevsie@2604:2000:f184:9300::4] has quit [Ping timeout: 252 seconds] 19:10 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 19:15 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 268 seconds] 19:19 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 19:23 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Ping timeout: 250 seconds] 19:28 -!- bytting [~corebob@2a02:fe0:c130:6160:5590:27a3:7109:39b7] has joined #bitcoin-core-dev 19:52 -!- cluelessperson [~cluelessp@unaffiliated/cluelessperson] has quit [Ping timeout: 252 seconds] 19:57 -!- cluelessperson [~cluelessp@unaffiliated/cluelessperson] has joined #bitcoin-core-dev 20:00 -!- grubles [~grubles@unaffiliated/grubles] has quit [Ping timeout: 245 seconds] 20:00 -!- grubles_ [~grubles@unaffiliated/grubles] has joined #bitcoin-core-dev 20:11 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 20:16 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 20:17 -!- grubles_ is now known as grubles 20:21 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 272 seconds] 20:39 -!- bytting [~corebob@2a02:fe0:c130:6160:5590:27a3:7109:39b7] has quit [Quit: Leaving] 20:47 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 20:48 -!- IGHOR [~quassel@93.178.216.72] has quit [Ping timeout: 272 seconds] 20:50 -!- echonaut [~echonaut@46.101.192.134] has quit [Remote host closed the connection] 20:50 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev 20:50 -!- echonaut [~echonaut@46.101.192.134] has joined #bitcoin-core-dev 20:54 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 20:55 -!- IGHOR [~quassel@93.178.216.72] has quit [Ping timeout: 244 seconds] 20:57 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev 21:11 -!- IGHOR [~quassel@93.178.216.72] has quit [Ping timeout: 244 seconds] 21:12 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev 21:19 -!- ChA1NsAw [~ChA1NsAw@ptr-bwwzb6nzlsvnda6h9dh.18120a2.ip6.access.telenet.be] has joined #bitcoin-core-dev 21:26 -!- grubles_ [~grubles@unaffiliated/grubles] has joined #bitcoin-core-dev 21:28 -!- grubles [~grubles@unaffiliated/grubles] has quit [Ping timeout: 250 seconds] 21:32 -!- IGHOR [~quassel@93.178.216.72] has quit [Ping timeout: 240 seconds] 21:34 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev 21:38 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection] 21:42 -!- grubles [~grubles@unaffiliated/grubles] has joined #bitcoin-core-dev 21:42 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 21:44 -!- grubles_ [~grubles@unaffiliated/grubles] has quit [Ping timeout: 240 seconds] 21:50 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 22:00 -!- IGHOR [~quassel@93.178.216.72] has quit [Ping timeout: 258 seconds] 22:01 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 246 seconds] 22:02 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev 22:07 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 22:17 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 22:21 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds] 22:26 -!- CubicEarth [~CubicEart@c-73-181-185-197.hsd1.wa.comcast.net] has quit [Ping timeout: 272 seconds] 22:26 < fanquake> jonasschnelli Interesting GH stats. I wouldn't have thought we'd have nearly 5* more commenters/reviewers compared to code contributors. 22:29 -!- CubicEarth [~CubicEart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 23:09 < jonasschnelli> fanquake: yeah. indeed 23:15 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 23:24 -!- rex4539 [~rex4539@ppp-2-84-172-26.home.otenet.gr] has quit [Quit: rex4539] 23:26 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-leqcwfpbfookqhkt] has joined #bitcoin-core-dev 23:26 < bitcoin-git> [bitcoin] hebasto opened pull request #15098: qt: Show addresses for "SendToSelf" transactions (master...20190104-gui-self-payment) https://github.com/bitcoin/bitcoin/pull/15098 23:26 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-leqcwfpbfookqhkt] has left #bitcoin-core-dev [] 23:29 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 246 seconds] 23:32 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 23:34 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 23:39 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 23:46 -!- aqquadro [~name@unaffiliated/aqquadro] has joined #bitcoin-core-dev 23:49 -!- irc_viewer_test [irc_viewer@gateway/vpn/privateinternetaccess/ircviewertest/x-06412631] has joined #bitcoin-core-dev --- Log closed Fri Jan 04 00:00:11 2019