--- Log opened Wed Jan 09 00:00:15 2019 00:44 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 00:47 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 00:48 -!- jungly [~quassel@79.8.200.97] has joined #bitcoin-core-dev 00:56 -!- philgee [~user@37.44.7.149] has joined #bitcoin-core-dev 00:59 -!- TheRec [~toto@drupal.org/user/146860/view] has quit [] 01:00 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 01:01 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 01:04 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 01:07 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 01:09 -!- setpill [~setpill@unaffiliated/setpill] has quit [Client Quit] 01:12 -!- aqquadro [~name@unaffiliated/aqquadro] has joined #bitcoin-core-dev 01:12 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 01:16 -!- TheRec [~toto@84-72-172-174.dclient.hispeed.ch] has joined #bitcoin-core-dev 01:16 -!- TheRec [~toto@84-72-172-174.dclient.hispeed.ch] has quit [Changing host] 01:16 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev 01:19 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:28 -!- Xianglo [~Mutter@c-73-102-185-185.hsd1.in.comcast.net] has joined #bitcoin-core-dev 01:29 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 01:31 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 240 seconds] 01:37 -!- Xianglo [~Mutter@c-73-102-185-185.hsd1.in.comcast.net] has quit [Quit: Mutter: www.mutterirc.com] 01:41 -!- rex4539 [~rex4539@ppp-94-69-92-124.home.otenet.gr] has joined #bitcoin-core-dev 01:45 -!- Xianglo [~Mutter@c-73-102-185-185.hsd1.in.comcast.net] has joined #bitcoin-core-dev 01:49 -!- Xianglo [~Mutter@c-73-102-185-185.hsd1.in.comcast.net] has quit [Client Quit] 02:10 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 02:11 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 02:16 -!- Xianglo [~Mutter@c-73-102-185-185.hsd1.in.comcast.net] has joined #bitcoin-core-dev 02:18 -!- rex4539 [~rex4539@ppp-94-69-92-124.home.otenet.gr] has quit [Quit: rex4539] 02:19 -!- Xianglo [~Mutter@c-73-102-185-185.hsd1.in.comcast.net] has quit [Client Quit] 02:27 -!- rex4539 [~rex4539@ppp-94-69-92-124.home.otenet.gr] has joined #bitcoin-core-dev 02:30 -!- rex4539 [~rex4539@ppp-94-69-92-124.home.otenet.gr] has quit [Client Quit] 02:30 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 02:30 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 244 seconds] 02:33 -!- rx7a [~rx7a@154.126.101.214] has quit [] 02:36 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 02:38 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 02:45 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 02:54 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 03:05 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has quit [Ping timeout: 250 seconds] 03:07 -!- grubles__ [~grubles@unaffiliated/grubles] has quit [Remote host closed the connection] 03:12 -!- rex4539 [~rex4539@ppp-94-69-92-124.home.otenet.gr] has joined #bitcoin-core-dev 03:13 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 240 seconds] 03:18 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Remote host closed the connection] 03:19 -!- owowo [~ovovo@82.102.24.131] has joined #bitcoin-core-dev 03:19 -!- owowo [~ovovo@82.102.24.131] has quit [Changing host] 03:19 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 03:21 -!- Giszmo [~leo@pc-247-63-74-200.cm.vtr.net] has quit [Ping timeout: 252 seconds] 03:23 -!- aqquadro [~name@unaffiliated/aqquadro] has quit [Ping timeout: 250 seconds] 03:24 -!- rex4539 [~rex4539@ppp-94-69-92-124.home.otenet.gr] has quit [Quit: rex4539] 03:27 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 03:29 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Remote host closed the connection] 03:31 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 03:37 -!- Giszmo [~leo@ip-244-228-107-190.nextelmovil.cl] has joined #bitcoin-core-dev 04:02 -!- Sentineo [~Undefined@unaffiliated/sentineo] has quit [Ping timeout: 245 seconds] 04:07 -!- setpill [~setpill@unaffiliated/setpill] has quit [Read error: Connection reset by peer] 04:08 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 04:14 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 246 seconds] 04:20 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 04:23 -!- murrayn [~murrayn@unaffiliated/murrayn] has quit [Quit: Leaving] 04:34 -!- murrayn_ [~murrayn@S0106f8a097f16608.ok.shawcable.net] has joined #bitcoin-core-dev 04:34 -!- murrayn [~murrayn@unaffiliated/murrayn] has joined #bitcoin-core-dev 04:35 -!- murrayn_ [~murrayn@S0106f8a097f16608.ok.shawcable.net] has quit [Client Quit] 04:59 -!- Sentineo [~Undefined@unaffiliated/sentineo] has joined #bitcoin-core-dev 05:05 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 05:06 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 05:06 -!- aqquadro [~name@unaffiliated/aqquadro] has joined #bitcoin-core-dev 05:14 -!- anome [~anome@unaffiliated/anome] has joined #bitcoin-core-dev 05:18 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 05:34 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has joined #bitcoin-core-dev 06:14 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 06:19 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev 06:28 -!- jwhoisthat [~jodie@24.215.123.241] has quit [Quit: WeeChat 1.4] 06:36 -!- rex4539 [~rex4539@ppp-94-69-92-124.home.otenet.gr] has joined #bitcoin-core-dev 06:36 < wumpus> meshcollider: thanks! 06:37 -!- adiabat [~adiabat@63.209.32.102] has quit [Ping timeout: 250 seconds] 06:40 -!- rex4539 [~rex4539@ppp-94-69-92-124.home.otenet.gr] has quit [Client Quit] 06:47 -!- Giszmo [~leo@ip-244-228-107-190.nextelmovil.cl] has quit [Ping timeout: 244 seconds] 06:48 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 245 seconds] 06:50 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.3] 06:54 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 07:00 -!- promag [~promag@83.223.250.219] has joined #bitcoin-core-dev 07:02 -!- Giszmo [~leo@45.232.32.21] has joined #bitcoin-core-dev 07:16 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev 07:19 < wumpus> can we have some review on #14955 please? :$ 07:19 < gribble> https://github.com/bitcoin/bitcoin/issues/14955 | Switch all RNG code to the built-in PRNG by sipa · Pull Request #14955 · bitcoin/bitcoin · GitHub 07:22 -!- Guyver2 [~Guyver@2001:985:f3f:1:bda2:f02e:52bc:f60a] has joined #bitcoin-core-dev 07:25 < instagibbs> wumpus, it's kind of scary material to review imo 07:25 < instagibbs> but i can at least read it 07:26 < instagibbs> err wait, maybe this is different one, nvm 07:26 -!- anome [~anome@unaffiliated/anome] has quit [] 07:29 < wumpus> instagibbs: that's why I request reviews on it, the worst-case scenario to review for would be loss of randomness for wallet key generation 07:31 < wumpus> for the rest, randomness is used for DoS avoidance in P2P code and unordered_map hashing and such; would be bad if it breaks, but not as disastrous ast ehe ffect on the wallet 07:32 < sipa> as a reviewer you probably want to reason through what happens in a call to GetStrongRandBytes 07:32 < sipa> to see that all those randomness sources are actually affecting the output 07:33 < instagibbs> I've done that historically at least, I'll take a look 07:37 < wumpus> instagibbs: thanks! 07:40 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 07:42 -!- jungly [~quassel@79.8.200.97] has quit [Ping timeout: 260 seconds] 07:43 -!- jungly [~quassel@host97-200-static.8-79-b.business.telecomitalia.it] has joined #bitcoin-core-dev 07:46 -!- aqquadro [~name@unaffiliated/aqquadro] has quit [Ping timeout: 268 seconds] 07:46 -!- aqquadro [~name@net-37-159-134-26.cust.vodafonedsl.it] has joined #bitcoin-core-dev 07:46 -!- aqquadro [~name@net-37-159-134-26.cust.vodafonedsl.it] has quit [Changing host] 07:46 -!- aqquadro [~name@unaffiliated/aqquadro] has joined #bitcoin-core-dev 07:48 -!- rex4539 [~rex4539@ppp-94-69-92-124.home.otenet.gr] has joined #bitcoin-core-dev 07:49 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 07:50 -!- rex4539 [~rex4539@ppp-94-69-92-124.home.otenet.gr] has quit [Client Quit] 07:54 < promag> wumpus: nit, don't mind my nits 07:56 < wumpus> promag: I agree; we waited a few days for the author to update for it, but if they don't, let's just merge imo 07:59 < wumpus> especially as it's a new contributor 08:05 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 08:13 -!- promag [~promag@83.223.250.219] has quit [Remote host closed the connection] 08:17 -!- grubles__ [~grubles@unaffiliated/grubles] has joined #bitcoin-core-dev 08:17 -!- aqquadro [~name@unaffiliated/aqquadro] has quit [Ping timeout: 245 seconds] 08:19 -!- rex4539 [~rex4539@ppp-2-84-164-199.home.otenet.gr] has joined #bitcoin-core-dev 08:19 -!- aqquadro [~name@net-37-159-134-26.cust.vodafonedsl.it] has joined #bitcoin-core-dev 08:19 -!- aqquadro [~name@net-37-159-134-26.cust.vodafonedsl.it] has quit [Changing host] 08:19 -!- aqquadro [~name@unaffiliated/aqquadro] has joined #bitcoin-core-dev 08:21 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev 08:25 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 08:38 < wumpus> lol @ amount of bikeshedding in #15127 08:38 < gribble> https://github.com/bitcoin/bitcoin/issues/15127 | docs: Clarifying testing instructions by benthecarman · Pull Request #15127 · bitcoin/bitcoin · GitHub 08:38 < wumpus> (FWIW I think this is good, if you really have to file a single-line change to the documentation, be prepared to get a lot of review on it :-) ) 08:39 < sipa> yeah... 08:45 -!- zenogais [~zenogais1@cpe-76-175-74-114.socal.res.rr.com] has joined #bitcoin-core-dev 08:52 -!- benthecarman [~benthecar@ics133-250.icsincorporated.com] has quit [Remote host closed the connection] 09:02 -!- adiabat [~adiabat@63.209.32.102] has joined #bitcoin-core-dev 09:07 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 09:07 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 09:08 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 09:14 -!- jungly [~quassel@host97-200-static.8-79-b.business.telecomitalia.it] has quit [Remote host closed the connection] 09:26 -!- miknotauro [~miknotaur@187.214.238.139] has joined #bitcoin-core-dev 09:43 -!- emilr [~emilr@unaffiliated/goregrind] has quit [Read error: Connection reset by peer] 09:56 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 10:02 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has quit [Quit: pinheadmz] 10:03 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 10:22 -!- DougieBot5000 [~DougieBot@unaffiliated/dougiebot5000] has quit [Ping timeout: 245 seconds] 10:23 < provoostenator> sipa: sounds like a good opportunity to read up on some C++ concepts, added to my review list. At least it compiles on macOS and two new wallets don't get the same address :-) 10:24 < sipa> provoostenator: unfortunately, the class of likely bugs in a system like this will not result in duplicate randomness, but just predictable one (for example, the Debian OpenSSL bug from a few years ago resulted in randomness with a bit over 16 bits of entropy, meaning you'd still need to observe 1000s to observe anything bad) 10:25 < provoostenator> Indeed, touching this code is scary. But is waiting for the next OpenSSL drama I guess? 10:26 < provoostenator> *so is 10:26 -!- rex4539 [~rex4539@ppp-2-84-164-199.home.otenet.gr] has quit [Ping timeout: 272 seconds] 10:26 < sipa> i think at this point we're already not relying on openssl for much except belt and suspenders 10:28 -!- DougieBot5000 [~DougieBot@unaffiliated/dougiebot5000] has joined #bitcoin-core-dev 10:30 < gmaxwell> [ignoring BIP70] Now we're just stuck issuing new binaries the next time there is some zomg panic about openssl because we statically link to it. 10:31 < sipa> yup 10:31 < sipa> i think i would describe our openssl dependency as annoying, so we'd like to get rid of it - but there isn't any specific pressing reason to do so 10:36 < gmaxwell> via bip 70 though it could actually introduce vulnerabilities, though thats really a question about getting rid of bip70, not openssl. 10:36 < provoostenator> BIP70 is depreacted so depending on when disaster happens, we could then just ship a new binary with OpenSSL removed. 10:36 < gmaxwell> yea, if anyone has any funds left after. :) 10:42 < cjd> is it common to connect nodes holding money to the public network ? I assumed that by now everyone was using a guard node which relayed for their LAN 10:45 < gmaxwell> cjd: they should be but my expirence is that almost no one does... the resource usage of doing so is quite considerable. 10:45 < cjd> ahh ok 10:45 < gmaxwell> Also BIP70s implementation inherently had to be run from a wallet. 10:45 -!- Jackielove4u [uid43977@gateway/web/irccloud.com/x-agikxugjsgsmtzqy] has quit [Quit: Connection closed for inactivity] 10:46 < gmaxwell> My statement was mostly hyperbole, but had an underlying point that "wait until it fails" isn't a great move. :P 10:47 < cjd> hm, lightning network is going to create some pressure to run big money on network-connected servers 10:52 -!- miknotauro [~miknotaur@187.214.238.139] has quit [Ping timeout: 268 seconds] 10:57 -!- tcup [d8ff791e@gateway/web/freenode/ip.216.255.121.30] has joined #bitcoin-core-dev 10:57 -!- tcup [d8ff791e@gateway/web/freenode/ip.216.255.121.30] has quit [Client Quit] 11:01 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 11:01 -!- aqquadro [~name@unaffiliated/aqquadro] has quit [Ping timeout: 250 seconds] 11:04 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 11:06 -!- zenogais [~zenogais1@cpe-76-175-74-114.socal.res.rr.com] has quit [Ping timeout: 268 seconds] 11:20 -!- philgee [~user@37.44.7.149] has quit [Ping timeout: 244 seconds] 11:27 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has quit [Ping timeout: 250 seconds] 11:34 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 256 seconds] 11:35 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 11:36 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 11:39 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 11:53 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has quit [Quit: pinheadmz] 11:53 -!- BlockSovrin [6c514f2a@gateway/web/freenode/ip.108.81.79.42] has joined #bitcoin-core-dev 11:54 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection] 11:59 -!- BlockSovrin [6c514f2a@gateway/web/freenode/ip.108.81.79.42] has quit [Quit: Page closed] 12:02 -!- gekisai [~gekisai@125-239-46-196-fibre.sparkbb.co.nz] has joined #bitcoin-core-dev 12:04 -!- gekisai [~gekisai@125-239-46-196-fibre.sparkbb.co.nz] has quit [Remote host closed the connection] 12:04 -!- gekisai [~gekisai@125-239-46-196-fibre.sparkbb.co.nz] has joined #bitcoin-core-dev 12:05 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 12:05 -!- zenogais [~zenogais1@cpe-76-175-74-114.socal.res.rr.com] has joined #bitcoin-core-dev 12:10 -!- aqquadro [~name@2001:b07:2ee:6c29:35c8:3c5b:a713:ddc5] has joined #bitcoin-core-dev 12:10 -!- aqquadro [~name@2001:b07:2ee:6c29:35c8:3c5b:a713:ddc5] has quit [Changing host] 12:10 -!- aqquadro [~name@unaffiliated/aqquadro] has joined #bitcoin-core-dev 12:21 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.3] 12:23 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev 12:27 -!- Jackielove4u [uid43977@gateway/web/irccloud.com/x-nieuogffabneytcc] has joined #bitcoin-core-dev 12:29 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has quit [Quit: pinheadmz] 12:31 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 12:34 -!- rtyet [5d331227@gateway/web/freenode/ip.93.51.18.39] has joined #bitcoin-core-dev 12:39 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 12:45 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 12:48 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 13:16 -!- rex4539 [~rex4539@ppp-2-84-172-204.home.otenet.gr] has joined #bitcoin-core-dev 13:18 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection] 13:24 -!- Guyver2 [~Guyver@2001:985:f3f:1:bda2:f02e:52bc:f60a] has quit [Remote host closed the connection] 13:33 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 13:36 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Client Quit] 13:50 < gkrizek> wumpus: Are you able to still see the configuration for the IRC GitHub Service? I'm working on a replacement, but I'm not sure what the events were it would comment about in here . 13:55 < gkrizek> Seems like it was push to any branch, PR open, close, merge. 14:09 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 14:12 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 14:12 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Read error: Connection reset by peer] 14:13 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 14:13 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Read error: Connection reset by peer] 14:14 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 14:15 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Read error: Connection reset by peer] 14:15 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection] 14:15 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 14:15 -!- Giszmo [~leo@45.232.32.21] has quit [Ping timeout: 240 seconds] 14:16 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Read error: Connection reset by peer] 14:16 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 14:17 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Read error: Connection reset by peer] 14:17 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 14:17 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 14:17 -!- miknotauro [~miknotaur@187.214.238.139] has joined #bitcoin-core-dev 14:18 < echeveria> gmaxwell: sipa: bip70 could kinda be a different binary at this point, but I don't think it's level of use justifies any sort of investment in development. 14:20 < echeveria> if this was my software I'd be putting a bounty in the bip70 payment window to see if anybody notices it. you found the secret bit! send a letter to this address and we'll mail you a prize! 14:21 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 14:22 < gmaxwell> yea, I think bip70 as an external program would be nice, except no one cares about it... 14:22 < gmaxwell> it always should have been done that way. 14:23 < gmaxwell> I even went and tried to break it out at one point, but it was implemented with QT crap... (which is stupid, the external program could operate just as a commandline tool, ...) 14:25 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds] 14:27 < promag> provoostenator: not sure if I understand your comment https://github.com/bitcoin/bitcoin/pull/15084#pullrequestreview-190732482 14:27 < promag> provoostenator: you agree with what? 14:29 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 14:30 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 14:32 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 14:34 < promag> big lag with github emails? 14:36 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Client Quit] 14:36 -!- Giszmo [~leo@pc-247-63-74-200.cm.vtr.net] has joined #bitcoin-core-dev 14:39 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 14:44 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 14:48 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 14:57 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 15:11 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 15:12 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 15:17 -!- Giszmo [~leo@pc-247-63-74-200.cm.vtr.net] has quit [Ping timeout: 246 seconds] 15:18 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 15:19 < fanquake> yes 15:22 < phantomcircuit> gmaxwell, as far as i know literally only bitpay uses bip70 15:23 < phantomcircuit> i've never seen it used anywhere else 15:25 -!- Giszmo [~leo@pc-247-63-74-200.cm.vtr.net] has joined #bitcoin-core-dev 15:26 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 15:29 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 15:32 -!- rtyet [5d331227@gateway/web/freenode/ip.93.51.18.39] has quit [Quit: Page closed] 15:37 < roasbeef> coinbase too maybe? 15:38 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection] 15:41 < jarthur> Stripe had thrown its support in, prior to taking a break from Bitcoin point of sale. 15:47 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 15:53 < luke-jr> phantomcircuit: BitPay isn't even BIP70-compatible 15:54 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 15:55 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 245 seconds] 15:55 < gmaxwell> roasbeef: they support it but unclear how much they use it... 15:55 < gmaxwell> like they spent more than half a year with their cert expired... 15:55 < roasbeef> luke-jr: orly? iirc they enforce it and there's no other way to pay them other than via bip70 15:55 < roasbeef> heh 15:56 < gmaxwell> roasbeef: their bip70 violates the spec and can't be used with bitcoin core regardless. 15:56 < luke-jr> roasbeef: iirc it "works" but it violates spec 15:57 < luke-jr> gmaxwell: why can't it be? 15:57 < luke-jr> last time I used bitpay, it worked.. 15:57 < gmaxwell> luke-jr: because if they see the txn first they abort the payment, or at least they were a couple months ago. 15:57 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 15:57 < gmaxwell> Last time I tried they just aborted the payment. 15:57 < luke-jr> O.o 15:57 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection] 15:58 < gmaxwell> I guess it's hard to say exactly what they do because they can change... :) 15:58 < luke-jr> I think it's been over a year since I last used it, so.. 15:58 < gmaxwell> In any case they 'require' non-conforming behavior, and what they require introduces vulnerablities. :( 15:58 < gmaxwell> Which is just fucked, because the thing they _want_ is what sipa fought for with gavin and eventually burned out advocating. 15:59 < gmaxwell> Unfortunately, bitpay didn't think through the implications of just dumbly grafting it on. 16:02 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection] 16:02 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 16:06 -!- aqquadro [~name@unaffiliated/aqquadro] has quit [Ping timeout: 260 seconds] 16:07 < phantomcircuit> gmaxwell, wait they cancel a invoice if the transaction reaches them over the network first? 16:07 -!- Giszmo [~leo@pc-247-63-74-200.cm.vtr.net] has quit [Ping timeout: 268 seconds] 16:07 < gmaxwell> Yes, they did to me and other people at the time were reporting it too. 16:07 < gmaxwell> Maybe they since stopped? if so then I'm out of date. 16:08 < phantomcircuit> that's crazy 16:08 -!- Giszmo [~leo@pc-247-63-74-200.cm.vtr.net] has joined #bitcoin-core-dev 16:09 < echeveria> phantomcircuit: they want to be able to selectively abort client payments. 16:09 < echeveria> this is doable if they really wanted to within another protocol, but would need to have the client doing partial signatures, and them filling validity with another signature of their own input to the payment. 16:10 < gmaxwell> BIP70 could have been defined that way, varrious people advocated for it. 16:11 < gmaxwell> But doing that correctly is harder for the wallet, since it needs to track UTXO as 'I signed for this, but it hasn't been broadcast yet'. 16:11 < gmaxwell> At the time BIP70 was written, the only 'used' metric bitcoin core really had was "spent by the mempool" 16:11 < luke-jr> maybe someone should get this in the Bustapay stuff 16:11 < phantomcircuit> echeveria, oooh 16:12 < phantomcircuit> they want to be able to blacklist utxo entries 16:12 < phantomcircuit> got it 16:12 < echeveria> gmaxwell: I don't think it's very user friendly to have that as a system though. you end up with ambiguity, I've paid someone with this output, and they may actually spend it sometime in the future, or not. 16:13 < luke-jr> if you're not careful, it locks your change too 16:13 < echeveria> I guess have a timeout in the script that means your partial signature is only valid for x hours or something, but even so. with most wallets tending towards having absolutely no logic in them this seems like a non-starter. 16:13 < luke-jr> echeveria: Bitcoin intentionally doesn't support such timeouts 16:15 < gmaxwell> you 'time it out' by double spending it. 16:15 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 16:15 < gmaxwell> What I think the wallet should do is track pending spends, and eventually intentionally double spend them if they 'timeout' 16:15 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection] 16:15 < gmaxwell> probably by just including them in a future transaction post timeout. 16:16 < gmaxwell> and also show a 'pending balance', so it's clear that a wallet with pending spends isn't 'empty' 16:16 < gmaxwell> But... yea, it's a non-zero amount of work. 16:16 < luke-jr> especially when you consider Lightning, I bet :p 16:17 < gmaxwell> But what bitpay wants people to do is just busted. 16:17 < gmaxwell> like they want to be able to say 'payment rejected, try again with more fee' but then no effort at all to doublespend the prior payments. 16:17 < gmaxwell> and no indication in the wallet that you've potentially double paid them. 16:17 < luke-jr> those seem like wallet-side decisions 16:18 < gmaxwell> so days, months, or even years later, you might have a whole bunch of bitpay payments go through twice.. 16:18 < gmaxwell> They are but they need to be part of any BIP70 alternative that doesn't immediately broadcast txn. 16:18 < gmaxwell> As in the spec needs to advise sensible behavior, and wallets _must_ implement somethign sensible or they create security vulnerabilities. 16:19 < gmaxwell> at a minimum if a payment is rejected and needs to be reissued, the wallet must doublespend the original one. 16:20 < gmaxwell> (and since there is bidi communication, there is really no reason that a request couldn't be rejected before a signed copy is even sent... but thats another matter) 16:20 < echeveria> and handle when someone refuses to do the double spend with their hardware wallet. 16:21 < gmaxwell> the double spend can at least be avoided all togeather in the common case. 16:21 < gmaxwell> echeveria: right or with a third party anti-doublespend signer. 16:22 -!- jarthur [~jarthur@207.114.244.5] has quit [] 16:22 < echeveria> ends up being a rather unfortunate amount of logic in the wallet. 16:23 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 16:23 < gmaxwell> right and a bunch of it is tricky, which is why I think it's important that a spec that makes you do this tricky thing at least warn you about the stuff you need to consider. 16:23 < gmaxwell> otherwise it would be like a ecdsa spec that just said nothing about where you're supposted to get this nonce value. "Nonce? that means used once. I'll just use a counter." 16:29 < ap4lmtree-> any of you take free online classes, such as through coursera ? 16:30 < ap4lmtree-> they have some cs and every other field courses 16:38 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection] 16:46 < gwillen> ap4lmtree-: not sure how on-topic this is here, but fwiw the Coursera Crypto I class by Dan Boneh is very good 16:46 < phantomcircuit> wumpus, btw i dont have fuzzing.tar.xz anywhere so that can definitely be removed 16:49 -!- DeanGuss [~deanguss@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 17:00 < phantomcircuit> gmaxwell, the idea that the remote end is going to reject a payment is crazy town 17:01 < gmaxwell> phantomcircuit: I don't think it is? like at least it's not unreasonable for the remote end to ignore your unconfirmed payment unless it has some minimum feerate. 17:03 < phantomcircuit> gmaxwell, it's not unreasonable to ignore you until it confirms 17:03 < phantomcircuit> then what 17:04 < gmaxwell> right, sure, but assuming you wanted it to not be ignored until them, you would have appricated the oppturnity to make a different txn. 17:07 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 17:07 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has quit [Ping timeout: 268 seconds] 17:07 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds] 17:07 < phantomcircuit> gmaxwell, i guess what im saying is that rejecting an unsigned transaction makes sense, but rejecting one that's signed and broadcast? 17:08 < phantomcircuit> once it's confirmed it's confirmed 17:08 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has quit [Quit: pinheadmz] 17:08 < gmaxwell> well thats why they want you to submit the transaction directly instead of broadcasting. 17:11 < phantomcircuit> but it's signed why should you trust them not to broadcast it themselves 17:12 < gmaxwell> You shouldn't. They might. Which is why you need to handle it correctly. 17:13 < gmaxwell> E.g. if they reject it and your response is to resign e.g. with more fee, you need to make sure you doublespend it... e.g. same as if you'd feebumped in the UI. 17:13 < gmaxwell> which sounds obnoxious, but its not bad considering that feebumping is already an existing and pretty desirable feature. 17:15 < phantomcircuit> gmaxwell, it seems more like you want a list of "payments im trying to make" and have the wallet ensure any new transaction invalidates anything that doesn't pay to that set 17:15 < gmaxwell> Maybe, though you don't really want to invalidate a payment that the recipent is already trying to CPFP unless asked to do so. 17:16 < wumpus> phantomcircuit: no problem, that whole section can be removed, the fuzzing corpus is going to move to a separate repository 17:19 < wumpus> gkrizek: there's not that much configuration; server is chat.freenode.net port is 6697, room is "#bitcoin-commits,#bitcoin-core-dev", nick is "bitcoin-git", branches is "master,0.11,0.12,0.13,0.14,0.15,0.16,0.17" 17:20 < wumpus> gkrizek: password and nickserv password is not filled in, Ssl is checked, Long url is checked, the other checkboxes are not 17:25 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection] 17:26 < ap4lmtree-> gmaxwell, okay ill check it out 17:29 -!- gekisai [~gekisai@125-239-46-196-fibre.sparkbb.co.nz] has quit [Remote host closed the connection] 17:29 -!- gekisai [~gekisai@125-239-46-196-fibre.sparkbb.co.nz] has joined #bitcoin-core-dev 17:34 -!- gekisai [~gekisai@125-239-46-196-fibre.sparkbb.co.nz] has quit [Ping timeout: 250 seconds] 17:35 -!- gekisai [~gekisai@125-239-46-196-fibre.sparkbb.co.nz] has joined #bitcoin-core-dev 17:37 -!- DeanGuss [~deanguss@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection] 17:42 -!- jarthur [~jarthur@2605:6000:1019:41ab:51e7:47b4:376f:2e97] has joined #bitcoin-core-dev 17:46 -!- gekisai [~gekisai@125-239-46-196-fibre.sparkbb.co.nz] has quit [Remote host closed the connection] 17:46 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [] 17:48 -!- miknotauro [~miknotaur@187.214.238.139] has quit [Ping timeout: 246 seconds] 17:58 -!- gekisai [~gekisai@125-239-46-196-fibre.sparkbb.co.nz] has joined #bitcoin-core-dev 18:02 -!- gkrizek [~gkrizek@ip98-164-15-79.ks.ks.cox.net] has quit [Read error: Connection reset by peer] 18:03 -!- gekisai [~gekisai@125-239-46-196-fibre.sparkbb.co.nz] has quit [Remote host closed the connection] 18:03 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Read error: Connection reset by peer] 18:03 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev 18:05 -!- achow101 [~achow101@unaffiliated/achow101] has quit [Ping timeout: 250 seconds] 18:08 -!- gekisai [~gekisai@125-239-46-196-fibre.sparkbb.co.nz] has joined #bitcoin-core-dev 18:08 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 18:13 -!- gekisai [~gekisai@125-239-46-196-fibre.sparkbb.co.nz] has quit [Ping timeout: 240 seconds] 18:16 -!- achow101 [~achow101@unaffiliated/achow101] has joined #bitcoin-core-dev 18:17 -!- gkrizek [~gkrizek@ip98-164-15-79.ks.ks.cox.net] has joined #bitcoin-core-dev 18:19 < gkrizek> wumpus: Ok, thanks! Are we cool with keeping that the same? Send a message when pushes happen to those branches and when PRs are open/closed/merged/reopened? I can add or remove whatever we want 18:20 -!- gkrizek [~gkrizek@ip98-164-15-79.ks.ks.cox.net] has quit [Client Quit] 18:21 -!- gkrizek [~gkrizek@ip98-164-15-79.ks.ks.cox.net] has joined #bitcoin-core-dev 18:23 -!- gekisai [~gekisai@125-239-46-196-fibre.sparkbb.co.nz] has joined #bitcoin-core-dev 18:38 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Remote host closed the connection] 19:10 -!- Giszmo [~leo@pc-247-63-74-200.cm.vtr.net] has quit [Ping timeout: 268 seconds] 19:28 -!- Giszmo [~leo@ip-95-228-107-190.nextelmovil.cl] has joined #bitcoin-core-dev 19:42 -!- ap4lmtree- is now known as ap4lmtree 19:44 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection] 19:45 -!- rhavar_ [uid237883@gateway/web/irccloud.com/x-botsrafsdwpgqwzk] has joined #bitcoin-core-dev 19:54 -!- justan0theruser is now known as justanotheruser 20:38 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has quit [Ping timeout: 260 seconds] 20:39 -!- grubles__ is now known as grubles 20:41 -!- gekisai [~gekisai@125-239-46-196-fibre.sparkbb.co.nz] has quit [Remote host closed the connection] 20:49 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has joined #bitcoin-core-dev 20:50 -!- DougieBot5000_ [~DougieBot@unaffiliated/dougiebot5000] has joined #bitcoin-core-dev 20:53 -!- DougieBot5000 [~DougieBot@unaffiliated/dougiebot5000] has quit [Ping timeout: 268 seconds] 21:45 -!- zenogais [~zenogais1@cpe-76-175-74-114.socal.res.rr.com] has quit [Ping timeout: 250 seconds] 22:12 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Ping timeout: 268 seconds] 22:17 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 22:19 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has quit [Ping timeout: 264 seconds] 22:33 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has joined #bitcoin-core-dev 22:47 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 23:06 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 23:09 -!- DougieBot5000_ is now known as DougieBot5000 23:16 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 23:20 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 272 seconds] 23:33 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev 23:33 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 23:34 -!- miknotauro [~miknotaur@187.214.238.139] has joined #bitcoin-core-dev --- Log closed Thu Jan 10 00:00:16 2019