--- Log opened Tue Jan 15 00:00:19 2019 --- Day changed Tue Jan 15 2019 00:00 -!- wangkaixuan [de803cdb@gateway/web/freenode/ip.222.128.60.219] has quit [Client Quit] 00:21 < gmaxwell> Security warning: if you scp files from a malicious ssh server, it can overwrite arbritary files in/under your target directory. 00:27 < DeanGuss> so you're saying don't work with malicious ssh servers? 00:38 -!- karlos [~karlos@2001:8003:52eb:db00:48f4:44fe:3ab7:9920] has joined #bitcoin-core-dev 00:44 < booyah> gmaxwell: that seems like a serious bug. you are not controling the file name? scp foo@bar.org:/tmp/a.txt ./ can result in something else then ./a.txt ? 00:59 < cjd> that's what it sounds like 00:59 < cjd> or worse, a.txt as you expected plus also click_here_please.exe as well 01:00 < cjd> or .bashrc or any of a plethora of other nasties 01:03 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 01:10 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 01:12 -!- luc_ [~luc@2001:8003:24ae:8900:6c53:9b31:65c2:e573] has joined #bitcoin-core-dev 01:14 -!- mistergold [~mistergol@185.37.26.110] has joined #bitcoin-core-dev 01:16 -!- luc_ [~luc@2001:8003:24ae:8900:6c53:9b31:65c2:e573] has quit [Remote host closed the connection] 01:21 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 01:23 < wumpus> wonder if rsync has the same problem? that's what I usually yse 01:27 -!- ExtraCrispy [~ExtraCris@gateway/tor-sasl/extracrispy] has joined #bitcoin-core-dev 01:32 -!- murrayn [~murrayn@unaffiliated/murrayn] has quit [Quit: Leaving] 01:33 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection] 01:37 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 01:44 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 01:48 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Ping timeout: 245 seconds] 01:50 < cjd> hmm, my intuition is that ssh to malicious machines is a minefield 01:51 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 01:54 < promag> #14941 should be ready for last ack and merge 01:54 < gribble> https://github.com/bitcoin/bitcoin/issues/14941 | rpc: Make unloadwallet wait for complete wallet unload by promag · Pull Request #14941 · bitcoin/bitcoin · GitHub 02:00 -!- murrayn [~murrayn@unaffiliated/murrayn] has joined #bitcoin-core-dev 02:04 -!- kexkey [~kexkey@172.98.82.4] has quit [Ping timeout: 268 seconds] 02:14 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 02:16 -!- miknotauro [~miknotaur@187.207.15.113] has quit [Ping timeout: 250 seconds] 02:20 -!- philgee [~user@37.44.7.149] has joined #bitcoin-core-dev 02:21 -!- TheV01d_ [thev01d@btc.mining.ga] has quit [Ping timeout: 252 seconds] 02:21 -!- TheV01d_ [thev01d@btc.mining.ga] has joined #bitcoin-core-dev 02:35 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 02:40 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 02:43 -!- karlos [~karlos@2001:8003:52eb:db00:48f4:44fe:3ab7:9920] has quit [Quit: Leaving] 02:55 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 03:03 -!- rex4539 [~rex4539@ppp-2-84-172-204.home.otenet.gr] has quit [Quit: rex4539] 03:19 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 03:21 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:22 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 03:42 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 03:48 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 03:50 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 03:55 -!- rex4539 [~rex4539@ppp-2-87-226-218.home.otenet.gr] has joined #bitcoin-core-dev 04:07 -!- rex4539 [~rex4539@ppp-2-87-226-218.home.otenet.gr] has quit [Quit: rex4539] 04:21 -!- guga [~guga@p5B2D8F08.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 04:24 -!- sakalli_ [~Mutter@mobile-access-5d6a78-64.dhcp.inet.fi] has joined #bitcoin-core-dev 04:24 -!- sakalli_ [~Mutter@mobile-access-5d6a78-64.dhcp.inet.fi] has quit [Excess Flood] 04:25 -!- sakalli_ [~Mutter@mobile-access-5d6a78-64.dhcp.inet.fi] has joined #bitcoin-core-dev 04:29 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 04:29 -!- sakalli_ [~Mutter@mobile-access-5d6a78-64.dhcp.inet.fi] has quit [Client Quit] 04:30 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 04:38 -!- rex4539 [~rex4539@ppp-2-87-226-218.home.otenet.gr] has joined #bitcoin-core-dev 04:48 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 04:53 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [] 04:58 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev 05:07 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 244 seconds] 05:11 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 05:16 < wumpus> but do you ever know for sure that the machine you're sshing to is not 'malicious'? if exploits can easily travel from ssh servers to clients, this makes e.g. VMs mostly useless as an isolation mechanism 05:21 < wumpus> but yes, if you know you're sshing to a compromised machine it's good to be careful I guess 05:37 -!- jungly [~quassel@host97-200-static.8-79-b.business.telecomitalia.it] has joined #bitcoin-core-dev 05:38 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-kdagbpusquhudymu] has joined #bitcoin-core-dev 05:38 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/cf0c67b62c20...1b6fc3053045 05:38 < bitcoin-git> bitcoin/master c37851d João Barbosa: rpc: Make unloadwallet wait for complete wallet unload 05:38 < bitcoin-git> bitcoin/master 645e905 João Barbosa: doc: Add release notes for unloadwallet change to synchronous call 05:38 < bitcoin-git> bitcoin/master 1b6fc30 Wladimir J. van der Laan: Merge #14941: rpc: Make unloadwallet wait for complete wallet unload... 05:38 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-kdagbpusquhudymu] has left #bitcoin-core-dev [] 05:39 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-rcetslyqtagavall] has joined #bitcoin-core-dev 05:39 < bitcoin-git> [bitcoin] laanwj closed pull request #14941: rpc: Make unloadwallet wait for complete wallet unload (master...2018-12-sync-unloadwallet) https://github.com/bitcoin/bitcoin/pull/14941 05:39 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-rcetslyqtagavall] has left #bitcoin-core-dev [] 05:43 < wumpus> whoa, bitcoin-git is *working* again 05:44 -!- mistergo1d [~mistergol@37.19.110.193] has joined #bitcoin-core-dev 05:46 -!- mistergold [~mistergol@185.37.26.110] has quit [Read error: Connection reset by peer] 05:46 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 246 seconds] 05:47 < wumpus> gkrizek: is that your bot now? 06:02 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Read error: Connection reset by peer] 06:12 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 06:13 -!- promag [~promag@83.223.251.178] has joined #bitcoin-core-dev 06:21 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-iqduzgwawtzsbnlc] has joined #bitcoin-core-dev 06:21 < bitcoin-git> [bitcoin] Mr-Leshiy closed pull request #15160: Optimization improvements (master...MrLeshiy_Improvements) https://github.com/bitcoin/bitcoin/pull/15160 06:21 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-iqduzgwawtzsbnlc] has left #bitcoin-core-dev [] 06:21 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-qqypwxpusqmtexxz] has joined #bitcoin-core-dev 06:21 < bitcoin-git> [bitcoin] Mr-Leshiy reopened pull request #15160: Optimization improvements (master...MrLeshiy_Improvements) https://github.com/bitcoin/bitcoin/pull/15160 06:21 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-qqypwxpusqmtexxz] has left #bitcoin-core-dev [] 06:27 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-pwbnbovxyptcilgq] has joined #bitcoin-core-dev 06:27 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/1b6fc3053045...a5daf70ffb80 06:27 < bitcoin-git> bitcoin/master a88640e Hennadii Stepanov: Fix minimized window bug on Linux... 06:27 < bitcoin-git> bitcoin/master a5daf70 Wladimir J. van der Laan: Merge #14594: qt: Fix minimized window bug on Linux... 06:27 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-pwbnbovxyptcilgq] has left #bitcoin-core-dev [] 06:28 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ezxhqkbhzzebewrt] has joined #bitcoin-core-dev 06:28 < bitcoin-git> [bitcoin] laanwj closed pull request #14594: qt: Fix minimized window bug on Linux (master...20181028-restore-minimized) https://github.com/bitcoin/bitcoin/pull/14594 06:28 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ezxhqkbhzzebewrt] has left #bitcoin-core-dev [] 06:29 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-qpwykbuvecnrtjzd] has joined #bitcoin-core-dev 06:29 < bitcoin-git> [bitcoin] Mr-Leshiy closed pull request #15160: Optimization improvements (master...MrLeshiy_Improvements) https://github.com/bitcoin/bitcoin/pull/15160 06:29 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-qpwykbuvecnrtjzd] has left #bitcoin-core-dev [] 06:30 -!- miknotauro [~miknotaur@187.207.15.113] has joined #bitcoin-core-dev 06:30 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has joined #bitcoin-core-dev 06:33 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 06:34 < luke-jr> yikes re scp 06:34 < luke-jr> is there a CVE? 06:37 -!- Guest51719 [~mike@47.23.101.106] has joined #bitcoin-core-dev 06:41 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-dlldlleoipxiluaz] has joined #bitcoin-core-dev 06:41 < bitcoin-git> [bitcoin] laanwj closed pull request #14965: minor: fix extra "non" in source code comment (master...minor-comment-double-negation) https://github.com/bitcoin/bitcoin/pull/14965 06:41 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-dlldlleoipxiluaz] has left #bitcoin-core-dev [] 06:41 < timothy> luke-jr: yes, much CVE-s 06:42 < timothy> luke-jr: https://sintonen.fi/advisories/scp-client-multiple-vulnerabilities.txt 06:43 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 06:43 < wumpus> thanks timothy 06:44 < luke-jr> ^ 06:44 < luke-jr> wumpus: rsync supports wildcards, so I suspect it has the same problem :/ 06:44 < luke-jr> eg, rsync foo@bar:/path/to/\* ./ 06:45 < wumpus> hmm true, but if you use a wildcard you're kind of asking for the remote to be able to overwrite any file locally (unless you provide the flag not to) 06:46 < wumpus> well any file within the destination path obviously not outside it 06:46 < luke-jr> wumpus: yes, but that feature implies the local client needs to do its own globbing check 06:47 -!- qrestlove [~qrestlove@2605:6000:eb4a:ef00:bd98:ecdf:a4bc:977] has quit [Remote host closed the connection] 06:48 < wumpus> luke-jr: but the remote can always lie about which files are available, I'd think 06:48 < wumpus> oh you mean to match against the globs, of course 06:49 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 06:50 < wumpus> promag: please rebase #14458 06:50 < gribble> https://github.com/bitcoin/bitcoin/issues/14458 | WIP: Add JSON-RPC interface documentation by promag · Pull Request #14458 · bitcoin/bitcoin · GitHub 06:51 -!- qrestlove [~qrestlove@2605:6000:eb4a:ef00:5d8e:3f3a:89ce:6710] has joined #bitcoin-core-dev 06:54 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 246 seconds] 06:55 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-cgsbhmamijpannnb] has joined #bitcoin-core-dev 06:56 < gkrizek> wumpus: no, I commented about it when it started up yesterday. "GitHub IRC Service is out of its brown out until the 31st when it’s fully depreciated. I’m still working on a replacement and it’s close to done. Will def be done before the 31st." 06:56 -!- Guyver2 [~Guyver@2001:985:f3f:1:b5fc:4e29:25ac:da1f] has joined #bitcoin-core-dev 06:56 < gkrizek> So it's still GitHub back for a couple weeks before it's really really dead 06:57 < wumpus> gkrizek: okay ! thanks again for working on it 06:58 < wumpus> apparently missed that comment :) 06:58 < gkrizek> No problem, happy to do it! 06:59 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 07:00 < promag> wumpus: on it 07:01 < promag> wumpus: #14958 could also go 07:01 < gribble> https://github.com/bitcoin/bitcoin/issues/14958 | qa: Remove race between conneting and shutdown on separate connections by promag · Pull Request #14958 · bitcoin/bitcoin · GitHub 07:01 < wumpus> ook 07:02 < wumpus> would be nice if MarcoFalke could take a look at that one 07:09 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 07:10 -!- Guest51719 [~mike@47.23.101.106] has quit [Quit: Guest51719] 07:11 < promag> no problem 07:15 -!- muzaffer [4ebf5b3d@gateway/web/freenode/ip.78.191.91.61] has joined #bitcoin-core-dev 07:18 < promag> there's like 1 month until feature freeze? 07:20 -!- muzaffer [4ebf5b3d@gateway/web/freenode/ip.78.191.91.61] has quit [Client Quit] 07:31 < wumpus> 'for (uint64_t j = static_cast(1) << (i - 1); (j >> i) == 0; ++j) {' 07:32 < wumpus> isn't there a shorter way to do this? static_casting 1 to uint64_t seems... outrageous 07:32 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev 07:38 < wumpus> (concerning #14151) 07:38 < gribble> https://github.com/bitcoin/bitcoin/issues/14151 | windows: Fix remaining compiler warnings (MSVC) by practicalswift · Pull Request #14151 · bitcoin/bitcoin · GitHub 07:39 < wumpus> promag: yes exactly a month you're right ! (#14438) 07:39 < gribble> https://github.com/bitcoin/bitcoin/issues/14438 | Release schedule for 0.18.0 · Issue #14438 · bitcoin/bitcoin · GitHub 07:40 < luke-jr> at the very least it could be uint64_t(1) 07:40 < luke-jr> FWIW, I confirmed rsync IS vulnerable to the same 07:40 -!- zenogais [~zenogais1@cpe-76-175-74-114.socal.res.rr.com] has joined #bitcoin-core-dev 07:40 < wumpus> luke-jr: thanks for the suggestion, will try 07:40 < luke-jr> (to reproduce, make a dummy shell script that just does exec ${SSH_ORIGINAL_COMMAND/dummyA\/a/dummyA\/*}, and use SSH forced commands to call it) 07:44 < sipa> wumpus: so it's counting from 2**(i-1) to (2**i)-1 ? 07:48 < phantomcircuit> wumpus, remote can also send sym and hard links with rsync so like... yeah 07:49 < luke-jr> phantomcircuit: depends on client configuration in theory 07:49 < luke-jr> and that's expected behaviour at least 07:49 < phantomcircuit> luke-jr, iirc the flags just control what the client requests 07:50 < wumpus> sipa: it kind of confuses me, according to the test it's supposed to generate bit patterns in j with i bits set 07:50 < luke-jr> phantomcircuit: ugh 07:50 -!- rex4539 [~rex4539@ppp-2-87-226-218.home.otenet.gr] has quit [Quit: rex4539] 07:51 < phantomcircuit> luke-jr, tons of stuff works that way 07:51 < luke-jr> wumpus: actually, looking at that further looks .. dumb 07:52 * luke-jr wonders wtf that's *trying* to do 07:56 -!- promag [~promag@83.223.251.178] has quit [Ping timeout: 268 seconds] 07:58 -!- promag [~promag@83.223.235.139] has joined #bitcoin-core-dev 07:58 < luke-jr> for (unsigned j = 1U << (i - 1); (j >> i) == 0; ++j) { 07:59 < wumpus> that creates an 'unsigned int' which is probably 32 bit, won't the shift potentially shift out of the register or even create undefined behavior 08:03 < luke-jr> wumpus: unsigned int is guaranteed to be at least 16-bit, and this is only done when i is <10 08:04 < wumpus> hhmm okay 08:04 < wumpus> I... don't think adding that reliance is very nice 08:05 < luke-jr> it's gotta rely on some bit width regardless. no reason to do 64-bit when we know it won't be 64-bit :p 08:05 < wumpus> the input to that bitcounting function is 64-bit, and it's a test for that, so limiting it at that makes some sense 08:06 < luke-jr> and if the standards-required assumption of 16-bit ever fails, the test will just fail 08:06 < luke-jr> which we probably want anyway, considering other code currently assumes it's 32-bit :p 08:11 -!- philgee [~user@37.44.7.149] has quit [Ping timeout: 268 seconds] 08:12 < wumpus> true; I wish C++ had 1u64 like rust 08:13 -!- guga [~guga@p5B2D8F08.dip0.t-ipconnect.de] has quit [Quit: Leaving] 08:14 < sipa> e could define a user-defined literal for it 08:14 < sipa> c++11 feature :) 08:15 < wumpus> interesting 08:16 < luke-jr> sipa: ? 08:16 < wumpus> nice feature, I don't think that's used anywhere in the code yet 08:17 < wumpus> https://en.cppreference.com/w/cpp/language/user_literal 08:17 < sipa> luke-jr: in c++11 you can define compile-time code to evaluate expressions of the form 1234_u64 for example 08:18 < wumpus> kind of overkill for this, but still, nice :) 08:18 < sipa> kinda surprising they didn't include a few default instances of it in the std library for things like this 08:19 < luke-jr> wow 08:19 < wumpus> looks like they defined a few default instances for std::complex and std::chrono::* 08:19 < wumpus> but not this unfortunately yeh 08:19 < wumpus> oh wait that's *C++14* nm\ 08:19 < sipa> and only in c++14, and a few more in c++20 08:22 < wumpus> right 08:25 -!- miknotauro [~miknotaur@187.207.15.113] has quit [Read error: Connection reset by peer] 08:26 -!- miknotauro [~miknotaur@187.207.5.246] has joined #bitcoin-core-dev 08:30 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 08:31 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 08:32 -!- miknotauro [~miknotaur@187.207.5.246] has quit [Ping timeout: 268 seconds] 08:37 -!- drexl [~drexl@82.36.221.190] has joined #bitcoin-core-dev 08:39 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-swmeatzhtjzshrue] has joined #bitcoin-core-dev 08:39 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/a5daf70ffb80...e8ad580f5153 08:39 < bitcoin-git> bitcoin/master fb3ce75 Hennadii Stepanov: Don't label transactions "Open" while catching up... 08:39 < bitcoin-git> bitcoin/master e8ad580 Wladimir J. van der Laan: Merge #14556: qt: fix confirmed transaction labeled "open" (#13299)... 08:39 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-swmeatzhtjzshrue] has left #bitcoin-core-dev [] 08:40 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-cmiulgftdklumjau] has joined #bitcoin-core-dev 08:40 < bitcoin-git> [bitcoin] laanwj closed pull request #14556: qt: fix confirmed transaction labeled "open" (#13299) (master...20181023-fix13299) https://github.com/bitcoin/bitcoin/pull/14556 08:40 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-cmiulgftdklumjau] has left #bitcoin-core-dev [] 08:42 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-yvhhjqxmxkgtdjvh] has joined #bitcoin-core-dev 08:42 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/e8ad580f5153...eb2aecfb8066 08:42 < bitcoin-git> bitcoin/master 03b8596 TheCharlatan: Add checksum in gitian build scripts for ossl... 08:42 < bitcoin-git> bitcoin/master eb2aecf Wladimir J. van der Laan: Merge #14433: Add checksum in gitian build scripts for ossl... 08:42 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-yvhhjqxmxkgtdjvh] has left #bitcoin-core-dev [] 08:43 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-hksqcpdzalvfwqnn] has joined #bitcoin-core-dev 08:43 < bitcoin-git> [bitcoin] laanwj closed pull request #14433: Add checksum in gitian build scripts for ossl (master...osslChecksum) https://github.com/bitcoin/bitcoin/pull/14433 08:43 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-hksqcpdzalvfwqnn] has left #bitcoin-core-dev [] 08:48 -!- promag [~promag@83.223.235.139] has quit [Remote host closed the connection] 08:51 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 08:57 -!- rex4539 [~rex4539@ppp-2-84-172-204.home.otenet.gr] has joined #bitcoin-core-dev 09:16 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 09:21 -!- promag [~promag@83.223.235.139] has joined #bitcoin-core-dev 09:26 -!- promag [~promag@83.223.235.139] has quit [Ping timeout: 268 seconds] 09:32 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has quit [Quit: pinheadmz] 09:32 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 09:39 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Remote host closed the connection] 09:41 -!- jungly [~quassel@host97-200-static.8-79-b.business.telecomitalia.it] has quit [Remote host closed the connection] 09:42 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev 09:51 -!- promag [~promag@83.223.235.139] has joined #bitcoin-core-dev 09:58 -!- promag [~promag@83.223.235.139] has quit [Remote host closed the connection] 10:02 -!- Guest9_ [~textual@170.199.232.138] has joined #bitcoin-core-dev 10:02 -!- Guest9_ is now known as ThomasLuong 10:03 -!- jimmysong [~jimmysong@72-48-253-51.dyn.grandenetworks.net] has joined #bitcoin-core-dev 10:03 -!- ThomasLuong is now known as luongthomas_ 10:04 -!- luongthomas_ is now known as luongthomas 10:04 -!- luongthomas is now known as ThomasLuong 10:14 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 10:15 -!- ddustin_ [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 10:15 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 245 seconds] 10:16 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 258 seconds] 10:30 -!- soundsalad [47469472@gateway/web/freenode/ip.71.70.148.114] has joined #bitcoin-core-dev 10:35 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection] 10:37 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection] 10:37 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 10:39 < dongcarl> Anything else that needs doing for: https://github.com/bitcoin/bitcoin/pull/12255 10:42 < luke-jr> dongcarl: the release notes seem wrong 10:43 < dongcarl> luke-jr: Comment on the PR, happy to fix. 10:43 < luke-jr> yeah, will do 10:44 < luke-jr> (it's actually init.md) 10:44 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-bpgvgvpirxpzxrqp] has joined #bitcoin-core-dev 10:44 < bitcoin-git> [bitcoin] MarcoFalke pushed 5 new commits to master: https://github.com/bitcoin/bitcoin/compare/eb2aecfb8066...82ffd4d91832 10:44 < bitcoin-git> bitcoin/master fac4558 MarcoFalke: sync: Add RecursiveMutex type alias 10:44 < bitcoin-git> bitcoin/master fafe941 MarcoFalke: test: Add missing validation locks 10:44 < bitcoin-git> bitcoin/master fa5c346 MarcoFalke: doc: Add comment to cs_main and mempool::cs 10:44 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-bpgvgvpirxpzxrqp] has left #bitcoin-core-dev [] 10:44 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 10:44 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-hyyxvpeypesxioie] has joined #bitcoin-core-dev 10:44 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #14963: mempool, validation: Explain cs_main locking semantics (master...Mf1812-docValLocks) https://github.com/bitcoin/bitcoin/pull/14963 10:44 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-hyyxvpeypesxioie] has left #bitcoin-core-dev [] 10:46 < dongcarl> luke-jr: Thanks! 10:50 -!- ddustin_ [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection] 10:51 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 10:56 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 272 seconds] 10:58 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-fsnilraqvzxjguhy] has joined #bitcoin-core-dev 10:58 < bitcoin-git> [bitcoin] Sjors opened pull request #15173: [doc] explain what .python-version does (master...2019/01/pyenv_doc) https://github.com/bitcoin/bitcoin/pull/15173 10:58 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-fsnilraqvzxjguhy] has left #bitcoin-core-dev [] 11:01 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection] 11:02 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ysnjcfrirfrgpdwt] has joined #bitcoin-core-dev 11:02 < bitcoin-git> [bitcoin] jonasschnelli pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/82ffd4d91832...c7c84209bb0a 11:02 < bitcoin-git> bitcoin/master f411c8b João Barbosa: gui: Remove unused return type in some BitcoinGUI methods 11:02 < bitcoin-git> bitcoin/master 8a79261 João Barbosa: gui: Keep network style in BitcoinGUI 11:02 < bitcoin-git> bitcoin/master fe7048b João Barbosa: gui: Show current wallet name in window title 11:02 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ysnjcfrirfrgpdwt] has left #bitcoin-core-dev [] 11:02 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ftsqfsyrctzidbcr] has joined #bitcoin-core-dev 11:02 < bitcoin-git> [bitcoin] jonasschnelli closed pull request #15149: gui: Show current wallet name in window title (master...2019-01-updatewindowtitle) https://github.com/bitcoin/bitcoin/pull/15149 11:02 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ftsqfsyrctzidbcr] has left #bitcoin-core-dev [] 11:16 -!- soundsalad [47469472@gateway/web/freenode/ip.71.70.148.114] has quit [Quit: Page closed] 11:26 -!- Krellan [~Krellan@2601:640:4000:a876:802d:4df9:46f1:3e2e] has quit [Remote host closed the connection] 11:28 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has quit [Quit: pinheadmz] 11:30 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 11:34 -!- DougieBot5000_ [~DougieBot@unaffiliated/dougiebot5000] has joined #bitcoin-core-dev 11:34 < jamesob> is there any good reason that ofstream objects can't be used as a stream with the serialize functions? 11:35 < sipa> jamesob: i think it just diverged; they used to implement a similar interface, but nothing used stdlib stream objects, so changes over time broke the compatibility? 11:36 < sipa> what causes it? the GetVersion etc? 11:37 < jamesob> trying to figure that out atm but I don't think it's GetVersion; top line of the compiler barf is 11:37 < jamesob> ./compressor.h:55:15: error: invalid operands to binary expression ('std::basic_ofstream' and 'Span > >().data())>::type>' (aka 'Span')) 11:38 -!- DougieBot5000 [~DougieBot@unaffiliated/dougiebot5000] has quit [Ping timeout: 272 seconds] 11:38 < jamesob> in the meantime I can do a CDataStream intermediary I guess 11:40 < gwillen> heh, I just tried to do this the other day 11:40 < gwillen> and assumed it was just not meant to work 11:40 < gwillen> and wrote a little std::string returning wrapper around CDataStream nonsense instead 11:44 < jamesob> ah funny. I'm dealing with binary and so want to avoid string 11:44 -!- riemann [~riemann@217.96.141.14.ipv4.supernova.orange.pl] has joined #bitcoin-core-dev 11:54 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 11:57 -!- Aaronva__ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 11:57 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 258 seconds] 11:58 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Read error: Connection reset by peer] 12:00 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has quit [Quit: pinheadmz] 12:01 -!- Aaronva__ is now known as AaronvanW 12:22 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 12:27 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has joined #bitcoin-core-dev 12:32 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 12:37 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 12:38 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 12:42 < luke-jr> followup on the random_tests failure the other day, apparently some are seeing it with raii_tests instead: https://bugs.gentoo.org/675546 :/ 12:46 -!- DougieBot5000_ is now known as DougieBot5000 12:46 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 12:48 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Remote host closed the connection] 12:49 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev 12:51 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Ping timeout: 250 seconds] 12:53 -!- mistergold [~mistergol@37.19.110.193] has joined #bitcoin-core-dev 12:57 -!- mistergo1d [~mistergol@37.19.110.193] has quit [Ping timeout: 245 seconds] 12:58 -!- ThomasLuong [~textual@170.199.232.138] has quit [Ping timeout: 250 seconds] 13:00 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 13:05 -!- DougieBot5000 [~DougieBot@unaffiliated/dougiebot5000] has quit [Quit: Leaving] 13:07 -!- DougieBot5000 [~DougieBot@unaffiliated/dougiebot5000] has joined #bitcoin-core-dev 13:08 -!- achow101 [~achow101@unaffiliated/achow101] has quit [Ping timeout: 244 seconds] 13:08 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-caobauwglfqaimig] has joined #bitcoin-core-dev 13:08 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/c7c84209bb0a...391a27376b30 13:08 < bitcoin-git> bitcoin/master 04215eb Sjors Provoost: [doc] explain what .python-version does 13:08 < bitcoin-git> bitcoin/master 391a273 MarcoFalke: Merge #15173: [doc] explain what .python-version does... 13:08 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-caobauwglfqaimig] has left #bitcoin-core-dev [] 13:08 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ucixwgdhmvjwiuej] has joined #bitcoin-core-dev 13:08 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #15173: [doc] explain what .python-version does (master...2019/01/pyenv_doc) https://github.com/bitcoin/bitcoin/pull/15173 13:08 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ucixwgdhmvjwiuej] has left #bitcoin-core-dev [] 13:17 -!- jarthur [~jarthur@207.114.244.5] has quit [] 13:17 -!- achow101 [~achow101@unaffiliated/achow101] has joined #bitcoin-core-dev 13:28 -!- mistergold [~mistergol@37.19.110.193] has quit [Quit: leaving] 13:28 -!- mistergold [~mistergol@37.19.110.193] has joined #bitcoin-core-dev 13:37 -!- booyah is now known as booyah_ 13:39 -!- booyah_ is now known as booyah 13:41 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 14:00 < ryanofsky> jamesob, std::string is fine for binary data 14:05 < gwillen> I can confirm what ryanofsky 14:05 < gwillen> says* 14:06 < gwillen> I checked this very carefully before going that route, it was slightly surprising to me too 14:06 < gwillen> std::string will happily hold binary data as long as you do not like, call c_str and try to use the result as a zero-terminated string 14:06 < gwillen> but std::string itself is 100% binary safe 14:09 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 14:11 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 268 seconds] 14:13 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 14:28 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 14:29 -!- sfhi [~sfhi@178.255.154.106] has joined #bitcoin-core-dev 14:31 -!- miknotauro [~miknotaur@187.207.5.246] has joined #bitcoin-core-dev 14:32 -!- jarthur [~jarthur@207.114.244.5] has quit [Client Quit] 14:44 -!- ThomasLuong [~ThomasLuo@170.199.232.138] has joined #bitcoin-core-dev 14:44 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 14:44 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 14:48 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has quit [Quit: Leaving] 14:57 < luke-jr> gwillen: in standard or practice only? 14:58 < gwillen> in standard 15:00 < sipa> std::string is just a weirdly specialized vector of chars 15:02 < gwillen> and much to my chagrin, in Clang its iterator is interchangeable with one to a vector but in g++ it is not. 15:04 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-cgsbhmamijpannnb] has quit [Quit: Connection closed for inactivity] 15:06 < gmaxwell> but why not use a vector ? :) 15:08 < gwillen> in my case it was because there are other interfaces that use std::string 15:08 < gwillen> and converting back and forth is extra lines of code 15:26 -!- sfhi [~sfhi@178.255.154.106] has quit [Quit: Leaving] 15:37 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection] 15:55 -!- mistergold [~mistergol@37.19.110.193] has quit [Quit: leaving] 15:58 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 16:16 -!- miknotauro [~miknotaur@187.207.5.246] has quit [Ping timeout: 250 seconds] 16:21 < gwillen> promag: would you be interested in doing a full review of #14978 16:21 < gribble> https://github.com/bitcoin/bitcoin/issues/14978 | Factor out PSBT utilities from RPCs for use in GUI code; related refactoring. by gwillen · Pull Request #14978 · bitcoin/bitcoin · GitHub 16:21 < gwillen> (meshcollider mentioned your name but you weren't on at the time) 16:21 < gwillen> he was suggesting a couple more reviews 16:27 < sipa> gwillen: i will review soon 16:34 < promag> will do tomorrow 16:38 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 16:41 -!- Guyver2 [~Guyver@2001:985:f3f:1:b5fc:4e29:25ac:da1f] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 16:51 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 16:54 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has quit [Remote host closed the connection] 17:00 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has joined #bitcoin-core-dev 17:02 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection] 17:02 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has quit [Quit: pinheadmz] 17:03 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 17:10 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 245 seconds] 17:11 < gwillen> thanks sipa and promag! 17:30 -!- ThomasLuong [~ThomasLuo@170.199.232.138] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 18:44 -!- miknotauro [~miknotaur@154-28-149-201.ww-mx.com] has joined #bitcoin-core-dev 18:51 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 18:54 -!- miknotauro [~miknotaur@154-28-149-201.ww-mx.com] has quit [Ping timeout: 250 seconds] 18:56 -!- kexkey [~kexkey@172.98.82.10] has joined #bitcoin-core-dev 18:57 -!- kexkey_ [~kexkey@172.98.82.10] has joined #bitcoin-core-dev 19:01 -!- kexkey [~kexkey@172.98.82.10] has quit [Ping timeout: 268 seconds] 19:17 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 19:52 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 250 seconds] 19:52 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 19:53 -!- ThomasLuong [~ThomasLuo@c-71-193-183-116.hsd1.or.comcast.net] has joined #bitcoin-core-dev 19:56 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 19:56 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 20:00 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Ping timeout: 250 seconds] 20:05 -!- schnerchi [~schnerchi@p54A7956D.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 20:08 -!- schnerch_ [~schnerchi@p54A7911F.dip0.t-ipconnect.de] has quit [Ping timeout: 245 seconds] 20:11 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 20:26 -!- Cory [~Cory@unaffiliated/cory] has quit [Ping timeout: 240 seconds] 20:32 -!- Pasha [~Cory@unaffiliated/cory] has joined #bitcoin-core-dev 20:34 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 20:35 -!- Pasha is now known as Cory 20:39 -!- riemann_ [~riemann@217.96.131.107.ipv4.supernova.orange.pl] has joined #bitcoin-core-dev 20:42 -!- riemann [~riemann@217.96.141.14.ipv4.supernova.orange.pl] has quit [Ping timeout: 245 seconds] 20:49 -!- shesek [~shesek@141.226.218.90] has joined #bitcoin-core-dev 20:49 -!- shesek [~shesek@141.226.218.90] has quit [Changing host] 20:49 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 21:10 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has quit [Quit: Snoozing.] 21:56 -!- miknotauro [~miknotaur@187.207.5.246] has joined #bitcoin-core-dev 22:33 -!- brianhoffman_ [~brianhoff@pool-72-83-155-130.washdc.fios.verizon.net] has joined #bitcoin-core-dev 22:35 -!- brianhoffman [~brianhoff@pool-72-83-155-130.washdc.fios.verizon.net] has quit [Ping timeout: 260 seconds] 22:35 -!- brianhoffman_ is now known as brianhoffman 22:36 -!- Krellan [~Krellan@2601:640:4000:a876:8d86:bfca:9fe:7bd3] has joined #bitcoin-core-dev 22:48 -!- zenogais [~zenogais1@cpe-76-175-74-114.socal.res.rr.com] has quit [Ping timeout: 268 seconds] 23:09 -!- guga [~guga@p5B2D8F0F.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 23:09 -!- guga_ [~guga@p5B2D8F0F.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 23:09 -!- guga_ [~guga@p5B2D8F0F.dip0.t-ipconnect.de] has quit [Client Quit] 23:18 -!- miknotauro [~miknotaur@187.207.5.246] has quit [Ping timeout: 250 seconds] 23:21 -!- tronglx [1b4862f5@gateway/web/freenode/ip.27.72.98.245] has joined #bitcoin-core-dev 23:24 -!- a5m0 [~a5m0@unaffiliated/a5m0] has quit [Ping timeout: 250 seconds] 23:27 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 23:28 -!- ThomasLuong [~ThomasLuo@c-71-193-183-116.hsd1.or.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 23:30 -!- tronglx [1b4862f5@gateway/web/freenode/ip.27.72.98.245] has left #bitcoin-core-dev [] 23:30 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection] 23:36 < wumpus> yes, std::string is binary safe, it is string encoding agnostic and doesn't enforce, like rust's strings, UTF-8. That said, using it for arbitrary binary data is bad because it communicates to developers "this is a string!". 23:39 -!- a5m0 [~a5m0@unaffiliated/a5m0] has joined #bitcoin-core-dev 23:56 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev --- Log closed Wed Jan 16 00:00:02 2019