--- Log opened Wed Jan 16 00:00:02 2019 --- Day changed Wed Jan 16 2019 00:00 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection] 00:01 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Read error: Connection reset by peer] 00:01 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 00:13 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev 00:18 -!- luc___ [~luc@2001:8003:24ae:8900:d8da:d9cc:9387:60da] has joined #bitcoin-core-dev 00:20 -!- jungly_ [~quassel@host97-200-static.8-79-b.business.telecomitalia.it] has joined #bitcoin-core-dev 00:26 -!- luc___ [~luc@2001:8003:24ae:8900:d8da:d9cc:9387:60da] has quit [Remote host closed the connection] 00:36 -!- luc___ [~luc@2001:8003:24ae:8900:6c9b:69a:b3b7:f452] has joined #bitcoin-core-dev 00:37 -!- ThomasLuong [~ThomasLuo@c-71-193-183-116.hsd1.or.comcast.net] has joined #bitcoin-core-dev 00:41 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 00:55 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 01:07 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 01:10 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ssxbinzgxpgcdoan] has joined #bitcoin-core-dev 01:10 < bitcoin-git> [bitcoin] Empact opened pull request #15175: build: Drop macports support (master...drop-macports) https://github.com/bitcoin/bitcoin/pull/15175 01:10 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ssxbinzgxpgcdoan] has left #bitcoin-core-dev [] 01:12 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection] 01:13 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 01:16 < wumpus> std::vector would be the preferred type for 'arbitrary binary blob'-IMO 01:16 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 01:17 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 268 seconds] 01:34 -!- Deinogalerix21 [~Deinogale@89.238.176.150] has joined #bitcoin-core-dev 01:35 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 01:39 -!- Deinogalerix21 [~Deinogale@89.238.176.150] has quit [Client Quit] 01:40 -!- ExtraCrispy [~ExtraCris@gateway/tor-sasl/extracrispy] has quit [Remote host closed the connection] 01:45 < promag> can I have #15002 in HP->backport? 01:45 < gribble> https://github.com/bitcoin/bitcoin/issues/15002 | 0.17: Backport #14941 by promag · Pull Request #15002 · bitcoin/bitcoin · GitHub 01:46 < wumpus> sure! 01:46 < promag> and #15101 should be ready, I think after provoostenator review it could be merged 01:46 < gribble> https://github.com/bitcoin/bitcoin/issues/15101 | gui: Add WalletController by promag · Pull Request #15101 · bitcoin/bitcoin · GitHub 01:47 < promag> it would be great to avoid chaining prs 01:47 < provoostenator> Will review, but I'm going through the RNG stuff now :-) 01:47 < promag> provoostenator: cool, stay with that :D 01:47 < wumpus> 15002 already has the tag backport 01:48 < wumpus> it's impossible to avoid chaining PRs ,some work always depends on previous work that isn't merged yet 01:49 < promag> wumpus: sure 01:49 < wumpus> I agree it can be confusing, especially if the PR texts aren't clear on it, but in itself it's unavoidable; you can't expect people to keep working on something just because the precursor isn't merged yet 01:49 < wumpus> eh *stop working on something* 01:49 < promag> wumpus: I usually prefer that than big prs 01:51 < promag> btw 01:53 < promag> wdyt about https://github.com/bitcoin/bitcoin/pull/13339#discussion_r246725075? 01:59 -!- luc____ [~luc@2001:8003:24ae:8900:cf3:b55b:8050:6f59] has joined #bitcoin-core-dev 02:02 -!- luc___ [~luc@2001:8003:24ae:8900:6c9b:69a:b3b7:f452] has quit [Ping timeout: 268 seconds] 02:05 -!- kexkey_ [~kexkey@172.98.82.10] has quit [Ping timeout: 272 seconds] 02:05 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Ping timeout: 256 seconds] 02:09 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has quit [Ping timeout: 240 seconds] 02:10 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 02:10 < fanquake> evening 02:14 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 02:16 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has joined #bitcoin-core-dev 02:19 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 02:19 < wumpus> evening! 02:19 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev 02:23 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-gzabiytlxeammegy] has joined #bitcoin-core-dev 02:23 < bitcoin-git> [bitcoin] merland opened pull request #15176: Rename README_osx.md (master...rename-osx-readme) https://github.com/bitcoin/bitcoin/pull/15176 02:23 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-gzabiytlxeammegy] has left #bitcoin-core-dev [] 02:25 -!- luc____ [~luc@2001:8003:24ae:8900:cf3:b55b:8050:6f59] has quit [] 02:26 -!- luc___ [~luc@2001:8003:24ae:8900:cf3:b55b:8050:6f59] has joined #bitcoin-core-dev 02:27 -!- luc___ [~luc@2001:8003:24ae:8900:cf3:b55b:8050:6f59] has quit [Remote host closed the connection] 02:29 -!- ThomasLuong [~ThomasLuo@c-71-193-183-116.hsd1.or.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 02:33 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has quit [Ping timeout: 268 seconds] 02:35 -!- laurentmt [~Thunderbi@77.247.178.186] has joined #bitcoin-core-dev 02:39 -!- laurentmt [~Thunderbi@77.247.178.186] has quit [Read error: Connection reset by peer] 02:41 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 02:42 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 02:50 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has joined #bitcoin-core-dev 02:58 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:04 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-bkrhdncdtaxibwtx] has joined #bitcoin-core-dev 03:04 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/391a27376b30...16c4a5373b87 03:04 < bitcoin-git> bitcoin/master cbd9091 Vidar Holen: refactor/lint: Add ignored suggestions to an array... 03:04 < bitcoin-git> bitcoin/master 16c4a53 Wladimir J. van der Laan: Merge #15170: refactor/lint: Add ignored shellcheck suggestions to an array... 03:04 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-bkrhdncdtaxibwtx] has left #bitcoin-core-dev [] 03:04 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-jjbtqpxxcmhnuoho] has joined #bitcoin-core-dev 03:04 < bitcoin-git> [bitcoin] laanwj closed pull request #15170: refactor/lint: Add ignored shellcheck suggestions to an array (master...master) https://github.com/bitcoin/bitcoin/pull/15170 03:04 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-jjbtqpxxcmhnuoho] has left #bitcoin-core-dev [] 03:12 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-jdijilzqmgngafxs] has joined #bitcoin-core-dev 03:12 < bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/16c4a5373b87...bcdd31f26569 03:12 < bitcoin-git> bitcoin/master 059a3cf Wladimir J. van der Laan: contrib: Detailed reporting for http errors in github-merge... 03:12 < bitcoin-git> bitcoin/master a4c5bbf Wladimir J. van der Laan: contrib: Add support for http[s] URLs in github-merge... 03:12 < bitcoin-git> bitcoin/master f1bd219 Wladimir J. van der Laan: contrib: Allow use of github API authentication in github-merge... 03:12 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-jdijilzqmgngafxs] has left #bitcoin-core-dev [] 03:13 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-mbtthvgomthlyfwi] has joined #bitcoin-core-dev 03:13 < bitcoin-git> [bitcoin] laanwj closed pull request #15165: contrib: Allow use of github API authentication in github-merge (master...2019_01_ghmerge) https://github.com/bitcoin/bitcoin/pull/15165 03:13 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-mbtthvgomthlyfwi] has left #bitcoin-core-dev [] 03:15 < fanquake> +1 for 15170. Makes testing in random/temporary vms a bit easier 03:20 -!- mistergold [~mistergol@37.19.107.146] has joined #bitcoin-core-dev 03:24 < wumpus> pretty cool that the shellcheck author contributes himself 03:25 < fanquake> yes. I wonder if he just stumbled on/was watching the project and decided to jump in, or someone reached out. 03:25 -!- drexl [~drexl@82.36.221.190] has quit [Ping timeout: 258 seconds] 03:38 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ixbepxqufnoslwtt] has joined #bitcoin-core-dev 03:38 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/bcdd31f26569...acec9e45c6fb 03:38 < bitcoin-git> bitcoin/master b0037c5 Hennadii Stepanov: Improve Peers tab layout... 03:38 < bitcoin-git> bitcoin/master 3537c83 Hennadii Stepanov: Do not deselect peer when switching away from tab... 03:38 < bitcoin-git> bitcoin/master acec9e4 Wladimir J. van der Laan: Merge #15136: qt: "Peers" tab overhaul... 03:38 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ixbepxqufnoslwtt] has left #bitcoin-core-dev [] 03:39 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-nzujahtslwtwifmp] has joined #bitcoin-core-dev 03:39 < bitcoin-git> [bitcoin] laanwj closed pull request #15136: qt: "Peers" tab overhaul (master...20190109-peerstab-overhaul) https://github.com/bitcoin/bitcoin/pull/15136 03:39 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-nzujahtslwtwifmp] has left #bitcoin-core-dev [] 03:46 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 03:46 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-dlnmgpswfuyvonhc] has joined #bitcoin-core-dev 03:46 < bitcoin-git> [bitcoin] promag opened pull request #15177: doc: Explain empty result of /rest/headers (master...2019-01-restheadersdoc) https://github.com/bitcoin/bitcoin/pull/15177 03:46 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-dlnmgpswfuyvonhc] has left #bitcoin-core-dev [] 03:52 < promag> wumpus: Marco reviewed #14958 yesterday 03:52 < gribble> https://github.com/bitcoin/bitcoin/issues/14958 | qa: Remove race between conneting and shutdown on separate connections by promag · Pull Request #14958 · bitcoin/bitcoin · GitHub 03:52 < wumpus> promag: ok 04:00 < wumpus> promag: whoops in commit message "qa: Remove race between conneting and shutdown" 04:00 < promag> darn :D 04:04 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 250 seconds] 04:05 < promag> wumpus: pushed 04:05 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-wmtfpmxqcoyysyey] has joined #bitcoin-core-dev 04:05 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/acec9e45c6fb...3ae3748ce1bd 04:05 < bitcoin-git> bitcoin/master 4412a59 João Barbosa: qa: Remove race between connecting and shutdown on separate connections 04:05 < bitcoin-git> bitcoin/master 3ae3748 Wladimir J. van der Laan: Merge #14958: qa: Remove race between connecting and shutdown on separate connections... 04:05 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-wmtfpmxqcoyysyey] has left #bitcoin-core-dev [] 04:06 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-hiagovhewvumvgfc] has joined #bitcoin-core-dev 04:06 < bitcoin-git> [bitcoin] laanwj closed pull request #14958: qa: Remove race between connecting and shutdown on separate connections (master...2018-12-improve-shutdown-test) https://github.com/bitcoin/bitcoin/pull/14958 04:06 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-hiagovhewvumvgfc] has left #bitcoin-core-dev [] 04:07 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-qiinlqcqhzqyxaek] has joined #bitcoin-core-dev 04:07 < bitcoin-git> [bitcoin] hebasto opened pull request #15178: qt: Improve "help-console" message (master...20190116-improve-help-console) https://github.com/bitcoin/bitcoin/pull/15178 04:07 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-qiinlqcqhzqyxaek] has left #bitcoin-core-dev [] 04:21 < hebasto> promag: mind reviewing #14409? 04:21 < gribble> https://github.com/bitcoin/bitcoin/issues/14409 | utils and libraries: Make blocksdir always net specific by hebasto · Pull Request #14409 · bitcoin/bitcoin · GitHub 04:21 < promag> sure 04:23 < hebasto> promag: thanks 04:27 < promag> "Beside that, I'm considering EncodeBase64 the wallet name/path" is this shell friendly? 04:27 < wumpus> I think that's a bad idea honestly 04:28 < wumpus> WTF-github now hides utACKs as "one more similar comment" yeeh, thanks 04:29 < promag> where? ^ 04:29 < wumpus> happened in #14409 to me, missed Marco's utACK due to that 04:29 < gribble> https://github.com/bitcoin/bitcoin/issues/14409 | utils and libraries: Make blocksdir always net specific by hebasto · Pull Request #14409 · bitcoin/bitcoin · GitHub 04:29 < echeveria> now you need an ack nonce. 04:29 < wumpus> if you don't see it I can make a screenshot... 04:30 < wumpus> echeveria: hah, or signed ACKs again 04:37 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection] 04:38 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has joined #bitcoin-core-dev 04:40 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-tsovtznbnyakvljr] has joined #bitcoin-core-dev 04:40 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/3ae3748ce1bd...64ee94356fb4 04:40 < bitcoin-git> bitcoin/master c3f1821 Hennadii Stepanov: Make blockdir always net specific... 04:40 < bitcoin-git> bitcoin/master e4a0c35 Hennadii Stepanov: Improve blocksdir functional test.... 04:40 < bitcoin-git> bitcoin/master 64ee943 Wladimir J. van der Laan: Merge #14409: utils and libraries: Make 'blocksdir' always net specific... 04:40 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-tsovtznbnyakvljr] has left #bitcoin-core-dev [] 04:41 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-owfbexetjoqvdpzh] has joined #bitcoin-core-dev 04:41 < bitcoin-git> [bitcoin] laanwj closed pull request #14409: utils and libraries: Make 'blocksdir' always net specific (master...20181005-blockspath-always-netspecific) https://github.com/bitcoin/bitcoin/pull/14409 04:41 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-owfbexetjoqvdpzh] has left #bitcoin-core-dev [] 04:42 -!- tno23 [~tno23@62-178-163-89.cable.dynamic.surfer.at] has joined #bitcoin-core-dev 04:48 -!- tno23 [~tno23@62-178-163-89.cable.dynamic.surfer.at] has quit [] 04:50 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds] 04:51 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-amkbugabcpkdcocm] has joined #bitcoin-core-dev 04:51 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/64ee94356fb4...19c60ca4975d 04:51 < bitcoin-git> bitcoin/master b9dafe7 practicalswift: Fix remaining compiler warnings (MSVC). Move disabling of specific warnings from /nowarn to project file. 04:51 < bitcoin-git> bitcoin/master 19c60ca Wladimir J. van der Laan: Merge #14151: windows: Fix remaining compiler warnings (MSVC)... 04:51 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-amkbugabcpkdcocm] has left #bitcoin-core-dev [] 04:51 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-jstgktfrfhafpxpy] has joined #bitcoin-core-dev 04:51 < bitcoin-git> [bitcoin] laanwj closed pull request #14151: windows: Fix remaining compiler warnings (MSVC) (master...fix-remaining-compiler-warnings-msvc) https://github.com/bitcoin/bitcoin/pull/14151 04:51 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-jstgktfrfhafpxpy] has left #bitcoin-core-dev [] 05:09 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 05:11 -!- m8tion [~user@88.190.249.49] has joined #bitcoin-core-dev 05:12 < wumpus> let's try to get #14605 in finally 05:12 < gribble> https://github.com/bitcoin/bitcoin/issues/14605 | Return of the Banman by dongcarl · Pull Request #14605 · bitcoin/bitcoin · GitHub 05:12 < wumpus> it has been reviewed a lot but surprisingly little (ut)ACKs 05:17 -!- m8tion_ [~user@82.221.114.154] has joined #bitcoin-core-dev 05:20 -!- m8tion [~user@88.190.249.49] has quit [Ping timeout: 258 seconds] 05:20 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 246 seconds] 05:21 < wumpus> the original PR had three utACKs though 05:46 -!- mistergold [~mistergol@37.19.107.146] has quit [Ping timeout: 258 seconds] 05:47 -!- mistergold [~mistergol@185.37.26.187] has joined #bitcoin-core-dev 05:48 -!- mistergo1d [~mistergol@185.37.26.187] has joined #bitcoin-core-dev 05:52 -!- mistergold [~mistergol@185.37.26.187] has quit [Ping timeout: 246 seconds] 05:56 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-dthdbrsjnlsviwrs] has joined #bitcoin-core-dev 05:56 < bitcoin-git> [bitcoin] laanwj pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/19c60ca4975d...d44b01f028e2 05:56 < bitcoin-git> bitcoin/master 951a44e Ben Woosley: Drop unused setRange arg to BerkeleyBatch::ReadAtCursor 05:56 < bitcoin-git> bitcoin/master 1a9f9f7 Ben Woosley: Introduce SafeDbt to handle DB_DBT_MALLOC raii-style... 05:56 < bitcoin-git> bitcoin/master 4a86a0a Ben Woosley: Make SafeDbt DB_DBT_MALLOC on default initialization... 05:56 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-dthdbrsjnlsviwrs] has left #bitcoin-core-dev [] 05:57 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-hefzemdjhzhqdzkw] has joined #bitcoin-core-dev 05:57 < bitcoin-git> [bitcoin] laanwj closed pull request #14268: Introduce SafeDbt to handle Dbt with free or memory_cleanse raii-style (master...malloced-dbt) https://github.com/bitcoin/bitcoin/pull/14268 05:57 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-hefzemdjhzhqdzkw] has left #bitcoin-core-dev [] 06:11 -!- kexkey [~kexkey@172.98.82.10] has joined #bitcoin-core-dev 06:12 -!- mr9 [9eaece76@gateway/web/freenode/ip.158.174.206.118] has joined #bitcoin-core-dev 06:15 -!- merland [~merland@185.86.106.161] has joined #bitcoin-core-dev 06:26 -!- merland [~merland@185.86.106.161] has quit [] 06:36 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 06:43 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 06:44 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 06:52 < promag> wumpus: checking #14605 06:52 < gribble> https://github.com/bitcoin/bitcoin/issues/14605 | Return of the Banman by dongcarl · Pull Request #14605 · bitcoin/bitcoin · GitHub 06:52 < wumpus> thank you 07:00 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-kohghvdwdcukstwl] has joined #bitcoin-core-dev 07:00 < bitcoin-git> [bitcoin] lontivero closed pull request #14939: rpc: Allow testmempoolaccept to test unsigned transactions (master...TestAcceptanceForUnsignedTransactions) https://github.com/bitcoin/bitcoin/pull/14939 07:00 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-kohghvdwdcukstwl] has left #bitcoin-core-dev [] 07:04 < dongcarl> w/re the banman PR, I'm not 100% sure about this discussion: https://github.com/bitcoin/bitcoin/pull/14605#discussion_r248050771 07:04 < dongcarl> I don't know the intricacies of `static_cast` that well, and it seems like either there's something I'm not seeing or it was put there for no reason 07:05 < sipa> i think empact is confused here 07:06 < dongcarl> sipa: so no casting of any kind is needed there right? That would be cfields was also confused haha 07:11 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has joined #bitcoin-core-dev 07:13 -!- jhfrontz [~Adium@cpe-184-57-118-36.columbus.res.rr.com] has quit [Ping timeout: 246 seconds] 07:14 -!- guga [~guga@p5B2D8F0F.dip0.t-ipconnect.de] has quit [Quit: Leaving] 07:15 < promag> dongcarl: is this comment really correct https://github.com/bitcoin/bitcoin/pull/14605/commits/b4ca7e2933d9325728cee97f3de1438f330b124b#diff-eff7adeaec73a769788bb78858815c91R2969 ? 07:15 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-yovwkzqlzokxqsov] has joined #bitcoin-core-dev 07:15 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/d44b01f028e2...f71c2ea6620a 07:15 < bitcoin-git> bitcoin/master b745e14 John Newbery: [docs] Expand help text for importmulti changes 07:15 < bitcoin-git> bitcoin/master f71c2ea Wladimir J. van der Laan: Merge #15122: [RPC] Expand help text for importmulti changes... 07:15 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-yovwkzqlzokxqsov] has left #bitcoin-core-dev [] 07:16 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-zrkpzbpqvvigdldl] has joined #bitcoin-core-dev 07:16 < bitcoin-git> [bitcoin] laanwj closed pull request #15122: [RPC] Expand help text for importmulti changes (master...pr14565_release_notes) https://github.com/bitcoin/bitcoin/pull/15122 07:16 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-zrkpzbpqvvigdldl] has left #bitcoin-core-dev [] 07:16 < dongcarl> promag: perhaps I should omit the "disconnect" part of the comment since it's structured this way now 07:16 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 07:17 < promag> dongcarl: looks like "// Disconnect" comment could be just before pnode->fDisconnect = true; 07:17 < dongcarl> true 07:17 < promag> or that, just remove 07:17 < promag> anyway, isn't this changing behavior? 07:18 < promag> old CConnman::Ban would disconnect all matching nodes 07:19 < promag> disclaimer, I'm not familiar with net code 07:19 < promag> so looks like `pnode->fDisconnect = true;` should be `DisconnectNode(pnode->addr)`\ ? 07:22 < dongcarl> promag: I think what Cory meant by behavior is the behavior of the node, not the CConnman 07:23 < dongcarl> promag: see https://github.com/bitcoin/bitcoin/pull/14605#discussion_r248065847 07:23 -!- laurentmt [~Thunderbi@77.247.178.186] has joined #bitcoin-core-dev 07:28 < promag> note that the old behavior `connman->Ban(pnode->addr, BanReasonNodeMisbehaving)` would go thru all nodes to disconnect (code that was moved to CConnman::DisconnectNode) 07:29 < promag> in other words, iiuc, before SendRejectsAndCheckIfBanned could result in multiple disconnected nodes, now it only results in 1 one 07:29 < promag> .. 1 node 07:31 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-bjaxyayljvoboumo] has joined #bitcoin-core-dev 07:31 < bitcoin-git> [bitcoin] instagibbs opened pull request #15179: [trivial] Slight clarity boost to SEQUENCE_LOCKTIME_DISABLE_FLAG (master...rel_lock_lang) https://github.com/bitcoin/bitcoin/pull/15179 07:31 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-bjaxyayljvoboumo] has left #bitcoin-core-dev [] 07:32 < promag> dongcarl: or does this means that CSubNet(addr).Match() only returns true once? 07:34 -!- michaelsdunn1 [~michaelsd@38.126.31.226] has joined #bitcoin-core-dev 07:34 -!- michaelsdunn1 [~michaelsd@38.126.31.226] has quit [Changing host] 07:34 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev 07:42 < dongcarl> promag: The version of `Ban` that takes in a `CNetAddr` constructs a single ip subnet (/32 or /128) `CSubNet` from that `CNetAddr` 07:42 < promag> so only one node matches that? 07:43 < dongcarl> unless 2 pnodes share the same addr, which I don't think can be the case but I'm double checking here 07:44 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has quit [Ping timeout: 272 seconds] 07:45 < promag> dongcarl I think that very likely, if you have 2 nodes at home they share the same addr? 07:47 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev 07:49 < dongcarl> promag: You are right 07:52 -!- zenogais [~zenogais1@cpe-76-175-74-114.socal.res.rr.com] has joined #bitcoin-core-dev 07:53 < dongcarl> promag: So what I think I'll do is for the `IsLocal` case I'll use fDisconnect, and use the pnode->addr in the other case 07:55 < promag> you mean DisconnectNode(pnode->addr) in the else branch? 07:55 < dongcarl> promag: right 07:55 < promag> lgtm 07:57 < dongcarl> promag: thanks for the help, lmk if you spot anything else! 07:58 < promag> sure 08:00 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 08:05 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 258 seconds] 08:07 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-xolfhecmkgdvvrde] has joined #bitcoin-core-dev 08:07 < bitcoin-git> [bitcoin] domob1812 closed pull request #15158: Use real bind address in RPC help curl example (master...rpchelp-addr) https://github.com/bitcoin/bitcoin/pull/15158 08:07 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-xolfhecmkgdvvrde] has left #bitcoin-core-dev [] 08:09 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-mfefwbrkzvgldosw] has joined #bitcoin-core-dev 08:09 < bitcoin-git> [bitcoin] laanwj pushed 2 new commits to master: https://github.com/bitcoin/bitcoin/compare/f71c2ea6620a...fcb6694a9945 08:09 < bitcoin-git> bitcoin/master 8928237 Cory Fields: threads: fix unitialized members in sched_param... 08:09 < bitcoin-git> bitcoin/master fcb6694 Wladimir J. van der Laan: Merge #14839: [rebase] threads: fix unitialized members in sched_param... 08:09 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-mfefwbrkzvgldosw] has left #bitcoin-core-dev [] 08:10 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-zxmotbbsfrfrgkae] has joined #bitcoin-core-dev 08:10 < bitcoin-git> [bitcoin] laanwj closed pull request #14839: [rebase] threads: fix unitialized members in sched_param (master...rebased-fix-musl-sched) https://github.com/bitcoin/bitcoin/pull/14839 08:10 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-zxmotbbsfrfrgkae] has left #bitcoin-core-dev [] 08:11 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has quit [Ping timeout: 244 seconds] 08:30 -!- farmerwampum [~farmerwam@162.219.178.10] has joined #bitcoin-core-dev 08:33 -!- farmerwampum [~farmerwam@162.219.178.10] has quit [Client Quit] 08:33 -!- farmerwampum [~farmerwam@162.219.178.10] has joined #bitcoin-core-dev 08:34 -!- farmerwampum [~farmerwam@162.219.178.10] has quit [Client Quit] 08:35 -!- farmerwampum [~farmerwam@162.219.178.10] has joined #bitcoin-core-dev 08:43 -!- farmerwampum [~farmerwam@162.219.178.10] has quit [Quit: farmerwampum] 08:43 -!- farmerwampum [~farmerwam@162.219.178.10] has joined #bitcoin-core-dev 08:48 -!- farmerwampum [~farmerwam@162.219.178.10] has quit [Client Quit] 08:48 -!- farmerwampum [~farmerwam@162.219.178.10] has joined #bitcoin-core-dev 08:52 -!- farmerwampum_ [~wampum@162.219.178.10] has joined #bitcoin-core-dev 08:52 < promag> dongcarl: 7cc2b9f looks good, I'll continue tonight 08:53 < dongcarl> promag: thank you sir! 08:53 -!- mr9 [9eaece76@gateway/web/freenode/ip.158.174.206.118] has quit [Ping timeout: 256 seconds] 08:53 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 08:56 -!- mistergo1d [~mistergol@185.37.26.187] has quit [Quit: leaving] 08:57 -!- mistergold [~mistergol@185.37.26.187] has joined #bitcoin-core-dev 09:02 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Remote host closed the connection] 09:06 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 09:07 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ydiufxejtelguyim] has joined #bitcoin-core-dev 09:07 < bitcoin-git> [bitcoin] domob1812 opened pull request #15181: Use correct RPC port in help curl example (master...rpchelp-port) https://github.com/bitcoin/bitcoin/pull/15181 09:07 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ydiufxejtelguyim] has left #bitcoin-core-dev [] 09:09 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 09:14 -!- laurentmt [~Thunderbi@77.247.178.186] has quit [Quit: laurentmt] 09:15 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-yjqznxnecemaldkb] has joined #bitcoin-core-dev 09:15 < bitcoin-git> [bitcoin] shahzadlone opened pull request #15182: [Minor Performance Fix] - Reserve vectors, to save reallocation costs. (master...master) https://github.com/bitcoin/bitcoin/pull/15182 09:15 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-yjqznxnecemaldkb] has left #bitcoin-core-dev [] 09:15 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 09:18 -!- farmerwampum [~farmerwam@162.219.178.10] has quit [Quit: farmerwampum] 09:18 -!- farmerwampum [~farmerwam@162.219.178.10] has joined #bitcoin-core-dev 09:22 -!- zshlyk [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 09:23 -!- intcat [~zshlyk@gateway/tor-sasl/intcat] has quit [Ping timeout: 256 seconds] 09:25 -!- miknotauro [~miknotaur@187.207.5.246] has joined #bitcoin-core-dev 09:33 -!- farmerwampum [~farmerwam@162.219.178.10] has quit [Quit: farmerwampum] 09:33 -!- farmerwampum [~farmerwam@162.219.178.10] has joined #bitcoin-core-dev 09:37 -!- ThomasLuong [~ThomasLuo@c-71-193-183-116.hsd1.or.comcast.net] has joined #bitcoin-core-dev 09:43 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has joined #bitcoin-core-dev 09:44 -!- laurentmt [~Thunderbi@77.247.178.186] has joined #bitcoin-core-dev 09:45 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 09:45 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-qrmwauhyosypgjxm] has joined #bitcoin-core-dev 09:45 < bitcoin-git> [bitcoin] marcoagner opened pull request #15183: [Qt]: fixes m_assumed_blockchain_size variable value: (master...fix_m_assumed_blockchain_size) https://github.com/bitcoin/bitcoin/pull/15183 09:45 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-qrmwauhyosypgjxm] has left #bitcoin-core-dev [] 09:53 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 09:53 -!- farmerwampum [~farmerwam@162.219.178.10] has quit [Quit: farmerwampum] 09:53 -!- farmerwampum [~farmerwam@162.219.178.10] has joined #bitcoin-core-dev 09:58 -!- farmerwampum [~farmerwam@162.219.178.10] has quit [Client Quit] 09:58 -!- farmerwampum [~farmerwam@162.219.178.10] has joined #bitcoin-core-dev 10:07 -!- miknotauro [~miknotaur@187.207.5.246] has quit [Ping timeout: 250 seconds] 10:13 -!- ram_ [31ccdc72@gateway/web/freenode/ip.49.204.220.114] has joined #bitcoin-core-dev 10:14 -!- ram_ [31ccdc72@gateway/web/freenode/ip.49.204.220.114] has quit [Client Quit] 10:14 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev 10:16 -!- vicnicius [~vicnicius@2001:985:29d:1:84f0:76d4:302e:4648] has joined #bitcoin-core-dev 10:17 -!- vicnicius [~vicnicius@2001:985:29d:1:84f0:76d4:302e:4648] has quit [Client Quit] 10:23 -!- farmerwampum [~farmerwam@162.219.178.10] has quit [Quit: farmerwampum] 10:23 -!- farmerwampum [~farmerwam@162.219.178.10] has joined #bitcoin-core-dev 10:28 -!- farmerwampum [~farmerwam@162.219.178.10] has quit [Client Quit] 10:28 -!- rex4539 [~rex4539@ppp-2-84-172-204.home.otenet.gr] has quit [Quit: rex4539] 10:28 -!- farmerwampum [~farmerwam@162.219.178.10] has joined #bitcoin-core-dev 10:28 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has quit [Quit: pinheadmz] 10:28 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 268 seconds] 10:29 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 10:30 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Plugging out.] 10:35 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ulhvdeogvzshbzzk] has joined #bitcoin-core-dev 10:35 < bitcoin-git> [bitcoin] laanwj closed pull request #15182: [Minor Performance Fix] - Reserve vectors, to save reallocation costs. (master...master) https://github.com/bitcoin/bitcoin/pull/15182 10:35 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-ulhvdeogvzshbzzk] has left #bitcoin-core-dev [] 10:38 -!- farmerwampum [~farmerwam@162.219.178.10] has quit [Quit: farmerwampum] 10:38 -!- farmerwampum [~farmerwam@162.219.178.10] has joined #bitcoin-core-dev 10:42 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 10:43 -!- farmerwampum [~farmerwam@162.219.178.10] has quit [Client Quit] 10:43 -!- farmerwampum [~farmerwam@162.219.178.10] has joined #bitcoin-core-dev 10:44 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Client Quit] 10:45 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 10:45 -!- sfhi [~sfhi@178.255.154.106] has joined #bitcoin-core-dev 10:46 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 10:47 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 10:52 -!- jhfrontz [~Adium@cpe-184-57-118-36.columbus.res.rr.com] has joined #bitcoin-core-dev 10:54 -!- jungly_ [~quassel@host97-200-static.8-79-b.business.telecomitalia.it] has quit [Remote host closed the connection] 10:55 -!- rex4539 [~rex4539@ppp-2-84-172-204.home.otenet.gr] has joined #bitcoin-core-dev 11:03 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 11:12 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has quit [Quit: pinheadmz] 11:13 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 11:18 -!- farmerwampum [~farmerwam@162.219.178.10] has quit [Quit: farmerwampum] 11:18 -!- farmerwampum [~farmerwam@162.219.178.10] has joined #bitcoin-core-dev 11:19 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection] 11:23 -!- farmerwampum [~farmerwam@162.219.178.10] has quit [Client Quit] 11:23 -!- farmerwampum [~farmerwam@162.219.178.10] has joined #bitcoin-core-dev 11:29 -!- ThomasLuong [~ThomasLuo@c-71-193-183-116.hsd1.or.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 11:54 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection] 11:55 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 11:58 -!- farmerwampum [~farmerwam@162.219.178.10] has quit [Quit: farmerwampum] 11:58 -!- farmerwampum [~farmerwam@162.219.178.10] has joined #bitcoin-core-dev 12:00 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 272 seconds] 12:01 -!- ThomasLuong [~ThomasLuo@c-71-193-183-116.hsd1.or.comcast.net] has joined #bitcoin-core-dev 12:03 -!- farmerwampum [~farmerwam@162.219.178.10] has quit [Client Quit] 12:03 -!- farmerwampum [~farmerwam@162.219.178.10] has joined #bitcoin-core-dev 12:07 -!- schmidty [~schmidty@104.7.216.111] has joined #bitcoin-core-dev 12:07 -!- schmidty [~schmidty@104.7.216.111] has quit [Changing host] 12:07 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev 12:10 -!- irc_viewer_test [irc_viewer@gateway/vpn/privateinternetaccess/ircviewertest/x-06412631] has joined #bitcoin-core-dev 12:11 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has quit [Quit: pinheadmz] 12:12 -!- laurentmt [~Thunderbi@77.247.178.186] has quit [Quit: laurentmt] 12:17 -!- riemann_ [~riemann@217.96.131.107.ipv4.supernova.orange.pl] has quit [Ping timeout: 250 seconds] 12:17 < wumpus> travis is failing on master and I don't understand why: https://travis-ci.org/bitcoin/bitcoin/builds/480544455?utm_medium=notification&utm_source=email 12:19 < wumpus> https://travis-ci.org/bitcoin/bitcoin/jobs/480544456 the only visible warning is the one about a missspelling in fuzzing.md, however that's an old warning and also spelling errors don't cause the test to fail 12:23 -!- laurentmt [~Thunderbi@77.247.178.186] has joined #bitcoin-core-dev 12:25 -!- sfhi [~sfhi@178.255.154.106] has quit [Quit: Leaving] 12:28 -!- jarthur [~jarthur@207.114.244.5] has quit [] 12:31 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 12:31 -!- air_willy [~air@189-92-237-58.3g.claro.net.br] has joined #bitcoin-core-dev 12:31 -!- ThomasLuong [~ThomasLuo@c-71-193-183-116.hsd1.or.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 12:32 -!- irc_viewer_test [irc_viewer@gateway/vpn/privateinternetaccess/ircviewertest/x-06412631] has quit [Quit: irc_viewer_test] 12:38 -!- farmerwampum [~farmerwam@162.219.178.10] has quit [Quit: farmerwampum] 12:38 -!- farmerwampum [~farmerwam@162.219.178.10] has joined #bitcoin-core-dev 12:41 -!- mistergold [~mistergol@185.37.26.187] has quit [Quit: leaving] 12:41 -!- mistergold [~mistergol@185.37.26.187] has joined #bitcoin-core-dev 12:41 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 268 seconds] 12:43 -!- farmerwampum [~farmerwam@162.219.178.10] has quit [Client Quit] 12:43 -!- farmerwampum [~farmerwam@162.219.178.10] has joined #bitcoin-core-dev 12:43 -!- laurentmt [~Thunderbi@77.247.178.186] has quit [Quit: laurentmt] 12:44 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 12:58 -!- air_willy [~air@189-92-237-58.3g.claro.net.br] has quit [Remote host closed the connection] 12:58 -!- harrymm [~harrymm@69.161.195.103] has quit [Remote host closed the connection] 13:00 -!- ThomasLuong [~ThomasLuo@c-71-193-183-116.hsd1.or.comcast.net] has joined #bitcoin-core-dev 13:01 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 13:05 -!- harrymm [~harrymm@69.161.195.103] has joined #bitcoin-core-dev 13:09 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 13:12 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 13:23 -!- farmerwampum [~farmerwam@162.219.178.10] has quit [Quit: farmerwampum] 13:23 -!- farmerwampum [~farmerwam@162.219.178.10] has joined #bitcoin-core-dev 13:26 -!- kexkey [~kexkey@172.98.82.10] has quit [Ping timeout: 258 seconds] 13:28 -!- farmerwampum [~farmerwam@162.219.178.10] has quit [Client Quit] 13:28 -!- farmerwampum [~farmerwam@162.219.178.10] has joined #bitcoin-core-dev 13:28 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has quit [Ping timeout: 258 seconds] 13:36 < meshcollider> Is it the failing subtree checks above it? 13:39 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 13:43 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection] 13:53 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 268 seconds] 13:54 -!- emilr [~emilr@unaffiliated/goregrind] has quit [Ping timeout: 244 seconds] 13:54 -!- emilr [~emilr@unaffiliated/goregrind] has joined #bitcoin-core-dev 13:55 -!- dophe [bf2b0b46@gateway/web/freenode/ip.191.43.11.70] has joined #bitcoin-core-dev 13:58 -!- dophe [bf2b0b46@gateway/web/freenode/ip.191.43.11.70] has quit [Client Quit] 14:05 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 14:07 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 14:09 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:11 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 14:12 < gkrizek> I thought the same thing meshcollider but I can see those errors are still there in the last passing CI run 14:15 -!- miknotauro [~miknotaur@187.207.5.246] has joined #bitcoin-core-dev 14:17 < gkrizek> I think it's in contrib/verify-commits/verify-commits.py 14:20 < gkrizek> If you look at the raw log from Travis there is this line at the end "Still running (1 of 50): contrib/verify-commits/verify-commits.py --clean-merge=2" doesn't show up in the UI 14:22 -!- zshlyk [~zshlyk@gateway/tor-sasl/intcat] has quit [Remote host closed the connection] 14:23 -!- zshlyk [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 14:24 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 268 seconds] 14:26 < gkrizek> Seems like this if statement is the only thing in the script that could exit(1) without logging a message: https://github.com/bitcoin/bitcoin/blob/master/contrib/verify-commits/verify-commits.py#L110-L120 14:30 < gkrizek> Eh I'm not sure, maybe someone with more experience with that script can tell, but the issue definitely seems to be there. wumpus 14:35 < gkrizek> Now that I look, the Cron CI runs have been failing for a while now 14:40 < gkrizek> Found it! This commit broke the Cron CI runs. https://github.com/bitcoin/bitcoin/commit/74ce32683199b987e45eb16f0320ae392ff10edc 14:40 < gkrizek> So it seems the verify-commits.py script needs python 3.6 14:43 -!- farmerwampum [~farmerwam@162.219.178.10] has quit [Quit: farmerwampum] 14:44 -!- farmerwampum [~farmerwam@162.219.178.10] has joined #bitcoin-core-dev 14:47 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 14:48 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 14:48 -!- farmerwampum [~farmerwam@162.219.178.10] has quit [Client Quit] 14:48 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds] 14:48 -!- farmerwampum [~farmerwam@162.219.178.10] has joined #bitcoin-core-dev 14:55 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection] 14:58 -!- mistergo1d [~mistergol@185.37.26.187] has joined #bitcoin-core-dev 15:01 -!- mistergold [~mistergol@185.37.26.187] has quit [Ping timeout: 250 seconds] 15:03 -!- xor216 [~a1@ip-94-113-168-42.net.upcbroadband.cz] has joined #bitcoin-core-dev 15:08 -!- user__ [~user@88.190.249.49] has joined #bitcoin-core-dev 15:08 < wumpus> gkrizek: thanks for looking into it! I'm surprised if it is the python version though, that change went in more than a month ago right? 15:08 < wumpus> gkrizek: travis still passed earlier today 15:09 < gkrizek> Yes, and it's been failing every since. No only the Cron runs. 15:09 < gkrizek> See the "CRON" label next to the branch name 15:09 < wumpus> OHH 15:10 < gkrizek> https://github.com/bitcoin/bitcoin/blob/master/.travis/lint_06_script.sh#L21-L25 15:10 < gkrizek> Those scripts only run on the cron runs... 15:10 -!- m8tion_ [~user@82.221.114.154] has quit [Ping timeout: 258 seconds] 15:11 < gkrizek> I was trying to install 3.4.9 to try to find out what it is but now my pyenv isn't working 15:39 -!- xor216 [~a1@ip-94-113-168-42.net.upcbroadband.cz] has left #bitcoin-core-dev [] 15:40 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 16:20 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection] 16:20 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 16:25 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 250 seconds] 16:27 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has quit [Ping timeout: 264 seconds] 16:28 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has joined #bitcoin-core-dev 16:29 -!- m8tion [~user@82.221.114.149] has joined #bitcoin-core-dev 16:33 -!- user__ [~user@88.190.249.49] has quit [Ping timeout: 250 seconds] 16:38 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has quit [Ping timeout: 250 seconds] 16:40 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has joined #bitcoin-core-dev 16:41 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [] 16:46 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has quit [Quit: drexl] 16:57 -!- mistergo1d [~mistergol@185.37.26.187] has quit [Quit: leaving] 16:57 -!- jarthur [~jarthur@207.114.244.5] has quit [] 16:59 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Read error: Connection reset by peer] 16:59 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Ping timeout: 245 seconds] 17:01 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev 17:08 -!- twistedline_ [~quassel@unaffiliated/twistedline] has joined #bitcoin-core-dev 17:08 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has quit [Quit: pinheadmz] 17:09 -!- twistedline_ [~quassel@unaffiliated/twistedline] has quit [Remote host closed the connection] 17:10 -!- twistedline [~quassel@unaffiliated/twistedline] has quit [Ping timeout: 272 seconds] 17:20 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has quit [Ping timeout: 245 seconds] 17:22 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has joined #bitcoin-core-dev 17:23 -!- twistedline [~quassel@unaffiliated/twistedline] has joined #bitcoin-core-dev 17:36 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 17:39 -!- ThomasLuong [~ThomasLuo@c-71-193-183-116.hsd1.or.comcast.net] has quit [Ping timeout: 246 seconds] 17:39 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 17:40 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 17:42 -!- ThomasLuong [ThomasLuon@gateway/vpn/privateinternetaccess/thomasluong] has joined #bitcoin-core-dev 17:48 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 17:53 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 17:55 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Client Quit] 18:19 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has quit [Ping timeout: 268 seconds] 18:19 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has joined #bitcoin-core-dev 18:19 -!- victorSN [~victorSN@unaffiliated/victorsn] has quit [Ping timeout: 268 seconds] 18:20 -!- m8tion [~user@82.221.114.149] has quit [Ping timeout: 240 seconds] 18:21 -!- victorSN [~victorSN@unaffiliated/victorsn] has joined #bitcoin-core-dev 18:24 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 18:25 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 18:26 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-bhnnawikzzrnfqez] has joined #bitcoin-core-dev 18:26 < bitcoin-git> [bitcoin] benthecarman opened pull request #15185: docs: Spelling error fix on fuzzing.md (master...docs_fuzzing_spelling_mistake) https://github.com/bitcoin/bitcoin/pull/15185 18:26 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-bhnnawikzzrnfqez] has left #bitcoin-core-dev [] 18:35 -!- ThomasLuong [ThomasLuon@gateway/vpn/privateinternetaccess/thomasluong] has quit [Excess Flood] 18:37 -!- cfields_ [~cfields@unaffiliated/cfields] has joined #bitcoin-core-dev 18:37 -!- davec_ [~davec@cpe-24-243-249-218.hot.res.rr.com] has joined #bitcoin-core-dev 18:37 -!- ThomasLuong [ThomasLuon@gateway/vpn/privateinternetaccess/thomasluong] has joined #bitcoin-core-dev 18:41 -!- victorSN [~victorSN@unaffiliated/victorsn] has quit [Ping timeout: 268 seconds] 18:41 -!- a2 [~a4@142.177.73.13] has joined #bitcoin-core-dev 18:41 -!- aj__ [aj@cerulean.erisian.com.au] has joined #bitcoin-core-dev 18:42 -!- gwollon [~gwillen@unaffiliated/gwillen] has joined #bitcoin-core-dev 18:43 -!- [\\\] [~triplesla@unaffiliated/imsaguy] has joined #bitcoin-core-dev 18:45 -!- CubicEarth_ [~CubicEart@c-73-181-185-197.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 18:45 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Disconnected by services] 18:46 -!- Netsplit *.net <-> *.split quits: sdaftuar, cfields, tripleslash, gwillen, CubicEarth, asoltys, yxz, davec, aj, harrymm 18:49 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 258 seconds] 18:49 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 246 seconds] 18:49 -!- victorSN [~victorSN@unaffiliated/victorsn] has joined #bitcoin-core-dev 18:50 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev 18:50 -!- harrymm [~harrymm@69.161.195.103] has joined #bitcoin-core-dev 18:51 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 18:54 -!- ThomasLu_ [~ThomasLuo@c-71-193-183-116.hsd1.or.comcast.net] has joined #bitcoin-core-dev 18:55 -!- rhavar_ [uid237883@gateway/web/irccloud.com/x-gapuzocgirgzqdju] has joined #bitcoin-core-dev 18:57 -!- ThomasLuong [ThomasLuon@gateway/vpn/privateinternetaccess/thomasluong] has quit [Ping timeout: 272 seconds] 18:58 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 19:11 -!- asoltys [~adam@115.96.198.104.bc.googleusercontent.com] has joined #bitcoin-core-dev 19:11 -!- sdaftuar [~sdaftuar@238.90.227.35.bc.googleusercontent.com] has joined #bitcoin-core-dev 19:13 -!- gwollon is now known as gwillen 19:26 -!- benthecarman [~benthecar@ics133-250.icsincorporated.com] has joined #bitcoin-core-dev 19:34 < gkrizek> wumpus the problem is the 'encoding' arg to the subprocess.check_output function. That was introduced in 3.6. I don't really see a need for that parameter anyway, so I think it's safe to just remove it. I can open a PR for it 19:38 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 19:40 -!- aj__ is now known as aj 19:44 -!- miknotauro [~miknotaur@187.207.5.246] has quit [Ping timeout: 268 seconds] 19:54 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 20:03 -!- farmerwampum [~farmerwam@162.219.178.10] has quit [Quit: farmerwampum] 20:03 -!- farmerwampum [~farmerwam@162.219.178.10] has joined #bitcoin-core-dev 20:04 -!- schnerch_ [~schnerchi@p54A7947D.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 20:07 -!- schnerchi [~schnerchi@p54A7956D.dip0.t-ipconnect.de] has quit [Ping timeout: 250 seconds] 20:08 -!- farmerwampum [~farmerwam@162.219.178.10] has quit [Client Quit] 20:08 -!- farmerwampum [~farmerwam@162.219.178.10] has joined #bitcoin-core-dev 20:16 -!- benthecarman_ [~benthecar@46.166.142.219] has joined #bitcoin-core-dev 20:17 -!- benthecarman [~benthecar@ics133-250.icsincorporated.com] has quit [Read error: Connection reset by peer] 20:18 -!- bentheacarman__ [~benthecar@ics133-250.icsincorporated.com] has joined #bitcoin-core-dev 20:19 -!- bentheacarman__ is now known as bentheacarman 20:21 -!- benthecarman_ [~benthecar@46.166.142.219] has quit [Ping timeout: 258 seconds] 20:24 -!- bentheacarman [~benthecar@ics133-250.icsincorporated.com] has quit [Quit: Leaving] 20:32 -!- miknotauro [~miknotaur@187.207.5.246] has joined #bitcoin-core-dev 20:37 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev 21:01 -!- zshlyk [~zshlyk@gateway/tor-sasl/intcat] has quit [Remote host closed the connection] 21:02 -!- zshlyk [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev 21:14 -!- sakalli_ [~Mutter@mobile-access-5d6a82-17.dhcp.inet.fi] has joined #bitcoin-core-dev 21:16 -!- sakalli_ [~Mutter@mobile-access-5d6a82-17.dhcp.inet.fi] has quit [Client Quit] 21:22 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 21:23 -!- pinheadmz [~matthewzi@76.102.227.220] has joined #bitcoin-core-dev 21:24 -!- DougieBot5000_ [~DougieBot@unaffiliated/dougiebot5000] has joined #bitcoin-core-dev 21:25 -!- DougieBot5000 is now known as Guest50520 21:25 -!- Guest50520 [~DougieBot@unaffiliated/dougiebot5000] has quit [Killed (cherryh.freenode.net (Nickname regained by services))] 21:25 -!- DougieBot5000_ is now known as DougieBot5000 21:48 -!- pinheadmz [~matthewzi@76.102.227.220] has quit [Quit: pinheadmz] 21:55 -!- karelb [sid316741@gateway/web/irccloud.com/x-bimhxdkslfzsbkcy] has quit [] 21:57 -!- sakalli_ [~Mutter@mobile-access-5d6a82-17.dhcp.inet.fi] has joined #bitcoin-core-dev 21:57 -!- sakalli_ [~Mutter@mobile-access-5d6a82-17.dhcp.inet.fi] has quit [Excess Flood] 21:58 -!- sakalli_ [~Mutter@mobile-access-5d6a82-17.dhcp.inet.fi] has joined #bitcoin-core-dev 22:13 -!- farmerwampum [~farmerwam@162.219.178.10] has quit [Quit: farmerwampum] 22:13 -!- farmerwampum [~farmerwam@162.219.178.10] has joined #bitcoin-core-dev 22:18 -!- farmerwampum [~farmerwam@162.219.178.10] has quit [Client Quit] 22:18 -!- farmerwampum [~farmerwam@162.219.178.10] has joined #bitcoin-core-dev 22:19 -!- zenogais [~zenogais1@cpe-76-175-74-114.socal.res.rr.com] has quit [Ping timeout: 258 seconds] 22:24 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection] 22:26 -!- sakalli_ [~Mutter@mobile-access-5d6a82-17.dhcp.inet.fi] has quit [Quit: Mutter: www.mutterirc.com] 22:48 -!- rh0nj [~rh0nj@136.243.139.96] has quit [Remote host closed the connection] 22:48 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 22:49 -!- rh0nj [~rh0nj@136.243.139.96] has joined #bitcoin-core-dev 22:55 < wumpus> gkrizek: the encoding parameter is for operating systems such as FreeBSD which don't set the system locale to utf-8 by default, leaving it up to python to decide what the locale is. It'll then pick ASCII only which results in problems in some cases. 22:57 < wumpus> gkrizek: (for example when calling git, and any of the commit messages contains characters >=128) 23:13 -!- ThomasLu_ [~ThomasLuo@c-71-193-183-116.hsd1.or.comcast.net] has quit [Ping timeout: 246 seconds] 23:14 -!- rex4539 [~rex4539@ppp-2-84-172-204.home.otenet.gr] has quit [Quit: rex4539] 23:18 -!- rex4539 [~rex4539@ppp-2-84-172-204.home.otenet.gr] has joined #bitcoin-core-dev 23:19 -!- rex4539 [~rex4539@ppp-2-84-172-204.home.otenet.gr] has quit [Client Quit] 23:31 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-orqucdfadwzdaums] has joined #bitcoin-core-dev 23:31 < bitcoin-git> [bitcoin] fanquake opened pull request #15186: rpc: remove duplicate solvable field from getaddressinfo (master...duplicate-solvable-fields) https://github.com/bitcoin/bitcoin/pull/15186 23:31 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-orqucdfadwzdaums] has left #bitcoin-core-dev [] 23:37 -!- ThomasLuong [~ThomasLuo@c-71-193-183-116.hsd1.or.comcast.net] has joined #bitcoin-core-dev --- Log closed Thu Jan 17 00:00:24 2019