--- Log opened Tue Jan 22 00:00:00 2019
--- Day changed Tue Jan 22 2019
00:00 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
00:00 -!- ratonlaveur_ [~ratonlave@67.215.14.198] has quit [Ping timeout: 244 seconds]
00:05 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Ping timeout: 244 seconds]
00:18 -!- emilr [~emilr@unaffiliated/goregrind] has joined #bitcoin-core-dev
00:27 -!- jungly [~quassel@host97-200-static.8-79-b.business.telecomitalia.it] has joined #bitcoin-core-dev
00:31 -!- JackH [~laptop@host86-175-127-233.range86-175.btcentralplus.com] has quit [Ping timeout: 272 seconds]
00:47 -!- guga [~guga@p579D93D4.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
00:47 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 245 seconds]
00:48 -!- IZooo [~IzZzoOo@185.220.70.34] has joined #bitcoin-core-dev
00:51 -!- jb55 [~jb55@S010660e327dca171.vc.shawcable.net] has quit [Ping timeout: 250 seconds]
00:53 < IZooo> Hello !
01:03 -!- jb55 [~jb55@S010660e327dca171.vc.shawcable.net] has joined #bitcoin-core-dev
01:08 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev
01:08 -!- andytoshi [~apoelstra@wpsoftware.net] has joined #bitcoin-core-dev
01:08 -!- andytoshi [~apoelstra@wpsoftware.net] has quit [Changing host]
01:08 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has joined #bitcoin-core-dev
01:15 -!- JackH [~laptop@62.232.170.181] has joined #bitcoin-core-dev
01:24 < meshcollider> jonasschnelli: to rebuild appveyor, just make sure you're logged in with github and click Re-Build PR at the top of the page, next to Log
01:24 < meshcollider> https://usercontent.irccloud-cdn.com/file/pMKT5Pjm/screenshot.png
01:25 < jonasschnelli> meshcollider: I don't have a restart button (logged in via GitHub)
01:31 < meshcollider> jonasschnelli: weird, in your github settings on the Authorized OAuth Apps page, does AppVeyor have access to read org and team membership, and the bitcoin org?
01:33 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
01:39 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 268 seconds]
01:42 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev
02:05 -!- paracyst_ [paracyst@unaffiliated/paracyst] has joined #bitcoin-core-dev
02:06 -!- paracyst [paracyst@unaffiliated/paracyst] has quit [Ping timeout: 250 seconds]
02:07 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
02:16 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 250 seconds]
02:22 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
02:22 -!- rex4539 [~rex4539@ppp-2-86-202-147.home.otenet.gr] has quit [Quit: rex4539]
02:25 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-ttwjdcmyvvongndq] has joined #bitcoin-core-dev
02:31 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
02:35 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]
02:48 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection]
02:49 -!- miknotauro [~miknotaur@187.207.5.246] has joined #bitcoin-core-dev
02:51 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
02:57 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev
03:04 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
03:37 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 244 seconds]
03:38 -!- rex4539 [~rex4539@ppp-2-84-172-204.home.otenet.gr] has joined #bitcoin-core-dev
03:49 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev
03:54 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
03:58 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Read error: Connection timed out]
04:00 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
04:16 -!- nodweber2 [~nodweber@unaffiliated/nodweber] has quit [Quit: see ya]
04:17 -!- nodweber [~nodweber@unaffiliated/nodweber] has joined #bitcoin-core-dev
04:17 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Max SendQ exceeded]
04:18 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
04:19 < wumpus> #14711 seems almost ready for merge for a while, really just waiting for ryanofsky to respond to empact's comment on the test
04:20 < gribble> https://github.com/bitcoin/bitcoin/issues/14711 | Remove uses of chainActive and mapBlockIndex in wallet code by ryanofsky · Pull Request #14711 · bitcoin/bitcoin · GitHub
04:25 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 256 seconds]
04:25 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Ping timeout: 256 seconds]
04:25 < promag> jonasschnelli: what do you think of #15153, if it should open the wallet asynchronously to not block the UI?
04:25 < gribble> https://github.com/bitcoin/bitcoin/issues/15153 | gui: Add Open Wallet menu by promag · Pull Request #15153 · bitcoin/bitcoin · GitHub
04:27 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Quit: ZNC - http://znc.sourceforge.net]
04:29 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
04:31 < wumpus> promag: seems like something that can be done later, blocking the GUI a little bit when opening a file is more or less expecated
04:31 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev
04:31 < wumpus> (unless it takes so long it needs a progress indicator)
04:31 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev
04:32 < promag> wumpus: no, I kind of have that, it just doesn't show the progress
04:32 < promag> 0 -> 100%
04:32 < promag> it's a indeterminate progress dialog
04:32 < fanquake> promag I'll have a look again
04:32 < promag> fanquake: hi, I'll push the progress dialog in a bit
04:32 < promag> I'll let you know
04:32 < wumpus> the risk of blocking the GUI thread too long is that some operating systems (as well as users) will conclude that the program crashed and terminate it
04:33 < promag> or the user
04:33 < fanquake> wumpus yea, in the original PR, the gui would essentially freeze, and you'd get the macOS beach ball, so a user would conclude a crash.
04:33 < promag> someone should come up with a good text, like "Opening wallet foobar, please wait bla bla...2
04:33 < wumpus> fanquake: right
04:34 < promag> fanquake: I put some millisleep in the rescan loop and it is indeed bad
04:34 < promag> this doesn't happen when opening the wallet with loadwallet RPC in the RPC console
04:35 < promag> as the command is executed in a background thread
04:35 < promag> *RPC server thread
05:00 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!]
05:04 < promag> fanquake: provoostenator: added a progress indicator while the open is loading
05:05 < fanquake> promag cool, i'll try have a look tonight
05:41 -!- ezzzy [~ezzzy@agis-3rotrzi.ws.skroutz.gr] has joined #bitcoin-core-dev
05:46 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-mopyoacltztfhzin] has joined #bitcoin-core-dev
05:46 < bitcoin-git> [bitcoin] hebasto closed pull request #15220: Qt, Trivial: Refactor UI forms (master...20190120-form-ui-refactor) https://github.com/bitcoin/bitcoin/pull/15220
05:46 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-mopyoacltztfhzin] has left #bitcoin-core-dev []
06:01 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 272 seconds]
06:06 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
06:13 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection]
06:16 -!- promag_ [~promag@83.223.235.44] has joined #bitcoin-core-dev
06:20 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 268 seconds]
06:21 -!- promag_ [~promag@83.223.235.44] has quit [Ping timeout: 268 seconds]
06:22 -!- kexkey [~kexkey@173.209.48.131] has joined #bitcoin-core-dev
06:22 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
06:23 -!- promag [~promag@83.223.235.44] has joined #bitcoin-core-dev
06:25 -!- promag_ [~promag@83.223.235.44] has joined #bitcoin-core-dev
06:26 -!- promag [~promag@83.223.235.44] has quit [Remote host closed the connection]
06:26 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev
06:29 -!- mistergold [~mistergol@77.243.29.47] has joined #bitcoin-core-dev
06:32 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 246 seconds]
06:34 < provoostenator> promag: cool! Checking now.
06:38 -!- jhfrontz [~Adium@cpe-184-57-118-36.columbus.res.rr.com] has quit [Quit: Leaving.]
06:38 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
06:39 -!- jhfrontz [~Adium@cpe-184-57-118-36.columbus.res.rr.com] has joined #bitcoin-core-dev
06:41 < promag_> provoostenator: I think we should do as little as possible regarding fancy GUI and threading jiggling
06:41 -!- promag_ is now known as promag
06:46 < provoostenator> As little as ppossible yes, but a blocking UI and/or missing transactions without explanation is not acceptable either.
06:49 < provoostenator> See my new comment. However if it's too difficult, we could also just add a standard warning, if the wallet is more than N blocks old, that "this may take a while".
06:50 < provoostenator> A progress bar plus a way to abort seems way nicer though, and you've made good progress :-)
06:53 < promag> provoostenator: what you mean by "I don't think the progress bar actually works." ?
06:54 -!- qrestlove [~qrestlove@2605:6000:eb4a:ef00:5d8e:3f3a:89ce:6710] has quit [Ping timeout: 268 seconds]
06:54 < provoostenator> It just shows 100% all the time.
06:56 < wumpus> progess bar doesn't work for things that run in the GUI thread
06:56 < wumpus> to update the GUI it needs a running GUI event loop
06:58 < wumpus> a long time ago there was the same problem for initialization/shutdown, which is why it was moved to a separate thread
06:59 -!- kexkey_ [~kexkey@173.209.48.131] has joined #bitcoin-core-dev
06:59 -!- kexkey [~kexkey@173.209.48.131] has quit [Ping timeout: 246 seconds]
07:02 < promag> provoostenator: it's inderterminate
07:03 < promag> provoostenator: from http://doc.qt.io/qt-5/qprogressbar.html#details > If minimum and maximum both are set to 0, the bar shows a busy indicator instead of a percentage of steps. 
07:03 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has quit [Quit: Leaving]
07:04 < provoostenator> wumpus: rescan wallet has a pretty descent progress bar in the GUI though.
07:04 < provoostenator> (oh wait, you mean GUI thread, not GUI period)
07:05 < wumpus> I think that runs in a separate thread that sends progress notifications to the GUI event loop thread
07:05 < wumpus> yea
07:05 < provoostenator> Imo it should figure out which blocks the rescan covers, because it can take a *long* time.
07:06 < provoostenator> The logs do show this progress by the way, so it's "known" by something.
07:07 -!- ExtraCrispy [~ExtraCris@gateway/tor-sasl/extracrispy] has quit [Ping timeout: 256 seconds]
07:07 -!- qrestlove [~qrestlove@2605:6000:eb4a:ef00:a957:b4a3:e749:f719] has joined #bitcoin-core-dev
07:13 < promag> provoostenator: the problem is that the progress notification is a global notification
07:13 < promag> for instance, it would be problematic if there are 2 tasks reporting progress
07:14 < promag> and while that works for dumping progress to the log, for the GUI it should be more contained
07:17 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit []
07:17 < promag> what I mean is that interfaces::Node::loadWallet should probably return an interfaces::Activity, and this would allow to know the progress, errors etc and also to pause, cancel etc
07:22 < promag> provoostenator: pushed, let me know
07:29 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev
07:37 -!- wxss [~user@mail.deeplinkmedia.com] has quit [Quit: Changing server]
07:38 -!- mistergold [~mistergol@77.243.29.47] has quit [Quit: leaving]
07:41 -!- ExtraCrispy [~ExtraCris@gateway/tor-sasl/extracrispy] has joined #bitcoin-core-dev
07:51 -!- ExtraCrispy [~ExtraCris@gateway/tor-sasl/extracrispy] has quit [Ping timeout: 256 seconds]
07:54 -!- booyah [~bb@193.25.1.157] has quit [Read error: Connection reset by peer]
07:58 -!- ezzzy [~ezzzy@agis-3rotrzi.ws.skroutz.gr] has quit [Ping timeout: 252 seconds]
08:01 -!- Mohamed [~Mohamed@bb121-6-182-56.singnet.com.sg] has quit []
08:03 -!- guga [~guga@p579D93D4.dip0.t-ipconnect.de] has quit [Quit: Leaving]
08:04 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/]
08:04 < jamesob> do we prefer (i) more #ifdefs or (2) very light unnecessary header bloat?
08:06 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev
08:07 < jamesob> (in the context of https://github.com/bitcoin/bitcoin/pull/15205#discussion_r249681321)
08:08 -!- promag [~promag@83.223.235.44] has quit [Remote host closed the connection]
08:08 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev
08:09 < gmaxwell> :-/
08:12 < jamesob> gmaxwell:  what ails ye
08:12 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/]
08:12 -!- kexkey_ [~kexkey@173.209.48.131] has quit [Ping timeout: 268 seconds]
08:19 < sipa> jamesob: have you seen #14289 ?
08:19 < gribble> https://github.com/bitcoin/bitcoin/issues/14289 | Unbounded growth of scheduler queue · Issue #14289 · bitcoin/bitcoin · GitHub
08:20 < jamesob> sipa: missed that, will give it a read. thanks for the pointer
08:20 < sipa> one of the ideas i suggested there was to have a debug mode where the queue depth is 0, which would cause the deadlock detector to trigger on anything that would become a deadlock in case of queue overflow
08:20 < sipa> though there are existing violations in the code
08:25 < jamesob> sipa: so that would effectively collapse the scheduler thread into the caller's?
08:26 < sipa> yes
08:26 < sipa> and if that works, there should be no risk in having a limited (but bounded) queue depth to increase parallellism for taks that can meaningfully be done in the background
08:27 < jamesob> sipa: seems like that might make it harder to find races when the deadlock detector is enabled though, no?
08:27 < sipa> how so?
08:27 < jamesob> you're losing the asynchronicity of the scheduler
08:28 < sipa> it immediately causes every callsite of a scheduled task to not hold the locks that its background task will need
08:28 < sipa> and makes the deadlock detector notice these
08:29 < sipa> it's still possible to have two different modules with different locks that both post a background task that runs in the other module's locks... but that would be a circular dependency in the code anyway
08:30 < sipa> i'm not saying this should be the only way of testing the scheduler
08:30 < jamesob> sure
08:31 < sipa> it just feels that your PR is very specialized to one instance of a background task
08:31 < jamesob> yeah, agreed
08:31 < sipa> and with that approach i expect we'll miss future introductions
08:31 < sipa> hmm
08:32 < sipa> what if we require that all calls to scheduler posts are done with no locks held?
08:32 < jamesob> heh, that sounds like a huge refactor
08:32 < jamesob> well maybe not huge
08:32 < sipa> i don't think so
08:32 < sipa> it's almost the case already
08:32 < sipa> apart from invalidateblock 
08:34 -!- miknotauro [~miknotaur@187.207.5.246] has quit [Ping timeout: 245 seconds]
08:36 -!- twistedline [~quassel@unaffiliated/twistedline] has quit [Remote host closed the connection]
08:39 -!- promag [~promag@83.223.235.44] has joined #bitcoin-core-dev
08:41 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
08:44 -!- promag [~promag@83.223.235.44] has quit [Ping timeout: 250 seconds]
08:47 < jamesob> sipa: talked a bit with sdaftuar and ryanofsky offline; sounds like it'd be worth trying to write the depth=0 mode and seeing where it breaks down
08:48 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev
08:49 -!- booyah [~bb@193.25.1.157] has joined #bitcoin-core-dev
08:52 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
08:52 -!- promag [~promag@83.223.235.44] has joined #bitcoin-core-dev
08:55 < sipa> jamesob: i think now that trying to just enforce no locks when posting is better
08:56 < sipa> you could have two modules that bothbrequire different locks, and each posts a job that needs the other's lock
08:56 < sipa> which you don't detect with the deoth=0 thing
08:57 -!- promag [~promag@83.223.235.44] has quit [Ping timeout: 245 seconds]
08:57 < sipa> no locks at all is overkill, but just as easy to achieve (from my limited memory), and much more tight
08:59 < provoostenator> Is there an easy way to change the wallet height directly in a wallet.dat file (to trigger a rescan upon load)?
08:59 -!- twistedline [~quassel@unaffiliated/twistedline] has joined #bitcoin-core-dev
09:00 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
09:06 -!- laurentmt [~Thunderbi@78.157.211.237] has joined #bitcoin-core-dev
09:10 -!- laurentmt [~Thunderbi@78.157.211.237] has quit [Client Quit]
09:14 < wumpus> omg apt vulnerable to MITM attack https://lists.debian.org/debian-security-announce/2019/msg00010.html
09:15 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-pkaabbhtxithvnbv] has joined #bitcoin-core-dev
09:15 < bitcoin-git> [bitcoin] Sjors closed pull request #14938: Support creating an empty wallet (master...2018/12/create-empty-wallet) https://github.com/bitcoin/bitcoin/pull/14938
09:15 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-pkaabbhtxithvnbv] has left #bitcoin-core-dev []
09:20 -!- JackH [~laptop@62.232.170.181] has quit [Ping timeout: 268 seconds]
09:21 -!- dqx [~dqx@unaffiliated/dqx] has quit [Ping timeout: 250 seconds]
09:22 -!- dqx [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev
09:27 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-ttwjdcmyvvongndq] has quit [Quit: Connection closed for inactivity]
09:33 -!- laurentmt [~Thunderbi@78.157.211.237] has joined #bitcoin-core-dev
09:40 -!- promag [~promag@83.223.235.44] has joined #bitcoin-core-dev
09:43 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Read error: Connection reset by peer]
09:43 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
09:44 -!- zshlyk [~zshlyk@gateway/tor-sasl/intcat] has quit [Remote host closed the connection]
09:44 -!- ratonlaveur [~ratonlave@132.205.230.9] has joined #bitcoin-core-dev
09:45 -!- ratonlaveur_ [~ratonlave@67.215.14.198] has joined #bitcoin-core-dev
09:45 -!- zshlyk [~zshlyk@gateway/tor-sasl/intcat] has joined #bitcoin-core-dev
09:48 -!- ratonlaveur [~ratonlave@132.205.230.9] has quit [Ping timeout: 240 seconds]
09:53 -!- _luc_ [~luc@2001:8003:24ae:8900:dc32:a893:f4d1:1c68] has joined #bitcoin-core-dev
09:55 < phantomcircuit> sipa, wait openssl gutted a function and replaced it with a stub that didn't even try to do what the original did?
09:55 < phantomcircuit> the fuck
09:57 -!- _luc_ [~luc@2001:8003:24ae:8900:dc32:a893:f4d1:1c68] has quit [Ping timeout: 250 seconds]
10:03 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection]
10:03 -!- JackH [~laptop@host86-175-127-233.range86-175.btcentralplus.com] has joined #bitcoin-core-dev
10:04 -!- promag [~promag@83.223.235.44] has quit [Remote host closed the connection]
10:04 < wumpus> provoostenator: hmm maybe one of the db4.8_ tools can be used to change the concerning key/value directly?
10:05 < wumpus> (a very crude way would be to use db_dump, edit the output, then db_load that to a new database)
10:05 < provoostenator> The db_dump route sounds reasonable, if that's more readable then the .dat file itself. I only have to do it once, and then just keep a copy around.
10:07 < wumpus> well it's hex...
10:07 < jamesob> sipa: what would we do with all the GetMainSignals(). calls in, say ConnectTip, while we're holding cs_main (of which there are many per ABC call)?  buffer them up?
10:11 -!- dqx [~dqx@unaffiliated/dqx] has quit [Ping timeout: 268 seconds]
10:12 < jamesob> swapping out scheduler execution for an immediate blocking call sounds really easy compared to enforcing a no-lock push, and it seems like we'd get the same testing benefit
10:13 < sipa>    jamesob ok
10:17 -!- dqx [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev
10:19 < hebasto> bionic used for gitian builds has apt 1.6.6ubuntu0.1 with fixed CVE-2019-3462
10:22 -!- jungly [~quassel@host97-200-static.8-79-b.business.telecomitalia.it] has quit [Remote host closed the connection]
10:30 -!- jhfrontz [~Adium@cpe-184-57-118-36.columbus.res.rr.com] has quit [Quit: Leaving.]
10:31 -!- wxss [~user@mail.deeplinkmedia.com] has joined #bitcoin-core-dev
10:33 -!- wxss [~user@mail.deeplinkmedia.com] has quit [Client Quit]
10:33 -!- wxss [~user@mail.deeplinkmedia.com] has joined #bitcoin-core-dev
10:35 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
10:38 -!- wxss [~user@mail.deeplinkmedia.com] has quit [Quit: leaving]
10:38 -!- wxss [~user@mail.deeplinkmedia.com] has joined #bitcoin-core-dev
10:39 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 240 seconds]
10:40 < jamesob> sipa: but if you can think of an easyish way to do it, I'm happy to try
10:44 < sipa> jamesob: we can do one first and the other later
10:44 < sipa> both will require breaking up invalidateblock though
10:47 < wumpus> hebasto: I'm sure it will be widely patched now; what is kind of worrying to me is all the time that this issue did exist, people that knew about it could install arbitrary packages on every debian* system
10:47 -!- _luc_ [~luc@2001:8003:24ae:8900:41b4:a9a2:6c28:85f] has joined #bitcoin-core-dev
10:50 < wumpus> hebasto: MITMing a mirror is not trivial and requires access to someone's network, but say, open wifi networks or tor exit nodes would certainly be a vector
10:51 < harding> Don't apt packages require an approved signature in order to be installed?  The linked post doesn't describe how that protection is bypassed.
10:51 < wumpus> harding: I'm not sure either
10:52 -!- _luc_ [~luc@2001:8003:24ae:8900:41b4:a9a2:6c28:85f] has quit [Ping timeout: 250 seconds]
10:54 < jamesob> harding: see "Planting the malicious package" here: https://justi.cz/security/2019/01/22/apt-rce.html
10:55 < wumpus> you're right that signing *should* prevent this, I think that's what evryone expected
11:06 < harding> jamesob: ah, thanks!  "The parent process will trust the hashes returned in the injected 201 URI Done response, and compare them with the values from the signed package manifest. Since the attacker controls the reported hashes, they can use this vulnerability to convincingly forge any package."
11:06 -!- jhfrontz [~Adium@cpe-184-57-118-36.columbus.res.rr.com] has joined #bitcoin-core-dev
11:09 < hebasto> wow ^
11:10 -!- zivl [~zivl@unaffiliated/zivl] has quit [Quit: zivl]
11:11 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
11:12 < wumpus> ouch.
11:15 < sipa> ouch.
11:15 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 240 seconds]
11:17 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has quit [Quit: pinheadmz]
11:18 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev
11:19 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
11:19 -!- IZooo [~IzZzoOo@185.220.70.34] has quit [Ping timeout: 250 seconds]
11:26 -!- zivl [~zivl@unaffiliated/zivl] has joined #bitcoin-core-dev
11:29 < luke-jr> does apt-cacher prevent this?
11:33 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has quit [Quit: pinheadmz]
11:39 < wumpus> that's hard to say, depends on whether it simply dumbly caches and forwards the response, or does its own validation
11:42 -!- _luc_ [~luc@2001:8003:24ae:8900:4c28:3894:382:9a5a] has joined #bitcoin-core-dev
11:42 < wumpus> A *normal* http proxy at least is not going to stop this
11:43 < wumpus> I wonder if the apt packages are served over https
11:43 < luke-jr> apt ships without https support
11:44 < wumpus> bleh
11:44 < luke-jr> I do wonder how they expect people to patch this
11:44 < luke-jr> since updating apt implies exposing yourself
11:44 < wumpus> apparently the flag "apt -o Acquire::http::AllowRedirect=false" prevents the issue
11:44 < luke-jr> ah
11:45 < wumpus> the idea is that you need to use that once for both update and upgrade, then make sure it updates your apt
11:45 < luke-jr> -bash: apt: command not found
11:45 < luke-jr> XD
11:46 < luke-jr> aptitude seems to work the same
11:46 -!- _luc_ [~luc@2001:8003:24ae:8900:4c28:3894:382:9a5a] has quit [Ping timeout: 264 seconds]
11:46 < wumpus> that's another question, whether aptitude is affected
11:47 < luke-jr> W: Failed to fetch http://security.debian.org/dists/wheezy/updates/main/binary-amd64/Packages: 302  Found [IP: 2001:4f8:1:c::14 80]
11:47 < luke-jr> :|
11:47 < wumpus> I wouldn't be surprised if it shares the same code
11:47 < luke-jr> apparently, since the option broke it
11:48 < wumpus> why is it redirecting to some weird IPv6
11:49 < luke-jr> MITM?\
11:50 < wumpus> it is suspicious for sure
11:50 < luke-jr> I have bigger problems I guess "Wheezy also benefits from Long Term Support (LTS) until the end of May 2018."
11:50 < hebasto> luke-jr: Debian ha apt pkg since jessie: https://packages.debian.org/sid/apt
11:50 < hebasto> *has
11:51 < luke-jr> hebasto: probably not in the super-stripped-down-minimal installs?
11:52 < hebasto> luke-jr: are you using wheezy?
11:52 < wumpus> this mentions the specific IPv6 address: https://www.reddit.com/r/debian/comments/727ti9/issues_with_aptget_update/   I think it's debian's own
11:52 < luke-jr> hebasto: on that particular system
11:53 < hebasto> wheezy definitely has no apt pkg
11:53 < wumpus> $ host mirror-isc2.debian.org
11:53 < wumpus> mirror-isc2.debian.org has address 149.20.4.14
11:53 < wumpus> mirror-isc2.debian.org has IPv6 address 2001:4f8:1:c::14
11:54 < wumpus> still I don't understand why it would redirect but ok--
11:54 < booyah> maybe apt-based distro developers should consider keys compromised, reinstall and make new signing keys...
11:54 < luke-jr> why?
11:54 < booyah> luke-jr: above mentioned apt exploit. Everyone running Debian could easily be compromised (remote root)
11:55 < luke-jr> oh, including the people who have those keys
11:55 < booyah> oh I ment, maybe developers of Bitcoin, who use such vulnerable system
11:57 -!- ratonlaveur__ [~ratonlave@132.205.230.9] has joined #bitcoin-core-dev
11:58 -!- ratonlaveur [~ratonlave@67.215.14.198] has joined #bitcoin-core-dev
12:00 -!- ratonlaveur_ [~ratonlave@67.215.14.198] has quit [Ping timeout: 272 seconds]
12:00 < luke-jr> ah
12:00 < luke-jr> (FWIW, my keys are NOT on such a system)
12:01 < wumpus> mine are on a yubikey
12:01 -!- ratonlaveur__ [~ratonlave@132.205.230.9] has quit [Ping timeout: 250 seconds]
12:02 < wumpus> not that it helps much if the system is compromised it's easy enough to MITM that to sign something else than you expect
12:02 < wumpus> but to go completely scorched earth...
12:02 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev
12:03 < cjd> https://bgp.he.net/ip/2001:4f8:1:c::14#_ipinfo
12:04 < cjd> IMO that's highly sketchy, no actual whois for the address
12:04 < cjd> it looks like a bgp hijack
12:06 < cjd> on my system:
12:06 < cjd> $ curl -v http://security.debian.org/dists/wheezy/updates/mainry-amd64/Packages >/dev/null
12:06 < cjd> < Location: http://security-cdn.debian.org/dists/wheezy/updates/main/binary-amd64/Packages
12:06 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
12:06 < cjd> host security-cdn.debian.org
12:07 < cjd> prod.debian.map.fastly.net, 151.101.60.204, 2a04:4e42:f::204
12:07 < cjd> that's much more what I'd expect to see
12:07 < cjd> and `whois 2a04:4e42:f::204` gives you an actual company
12:08 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 250 seconds]
12:11 < jnewbery> #proposedmeetingtopic Chaincode summer residency
12:12 < jnewbery> ^^ looking for (remote) mentors and recommendations for residents
12:12 < wumpus> probably best to tag moneyball ^^
12:13 < jnewbery> thanks wumpus
12:14 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 268 seconds]
12:16 < jnewbery> I'm removing #15141 from high priority while sdaftuar reworks it
12:16 < gribble> https://github.com/bitcoin/bitcoin/issues/15141 | Rewrite DoS interface between validation and net_processing by sdaftuar · Pull Request #15141 · bitcoin/bitcoin · GitHub
12:16 < jnewbery> Also removing #14938 and replacing it with #15226
12:16 < gribble> https://github.com/bitcoin/bitcoin/issues/14938 | Support creating an empty wallet by Sjors · Pull Request #14938 · bitcoin/bitcoin · GitHub
12:16 < gribble> https://github.com/bitcoin/bitcoin/issues/15226 | Allow creating blank (empty) wallets (alternative) by achow101 · Pull Request #15226 · bitcoin/bitcoin · GitHub
12:17 -!- laurentmt [~Thunderbi@78.157.211.237] has quit [Quit: laurentmt]
12:21 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has quit [Quit: pinheadmz]
12:22 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection]
12:25 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev
12:32 < gkrizek> wumpus: I finally finished my GitHub IRC Service replacement. https://github.com/gkrizek/ghi  I had several others ask for it too so I made it really configurable, much like the original service.
12:32 < gkrizek> I'm more than happy to host the service myself, but can help you set it up elsewhere if you prefer.
12:32 < wumpus> gkrizek: awesome!
12:36 < wumpus> looks very neat
12:36 -!- _luc_ [~luc@2001:8003:24ae:8900:388e:e843:3141:af43] has joined #bitcoin-core-dev
12:37 -!- kexkey [~kexkey@199.229.249.116] has joined #bitcoin-core-dev
12:37 < gkrizek> Thanks!
12:41 < wumpus> and the documentation seems quite clear, I'll probably succeed in setting it up :)
12:41 -!- _luc_ [~luc@2001:8003:24ae:8900:388e:e843:3141:af43] has quit [Ping timeout: 268 seconds]
12:42 < gkrizek> wumpus: great, that was the goal! Don't hesitate to ask. I can give you an example '.ghi.yml' file to use if you would like as well. 
12:43 < gkrizek> I was thinking it might be nice to add it as a webhook now and have it post to the #bitcoin-commits channel. That way we can test it out and see how it compares to the GitHub Service before it's EOL.
12:43 < wumpus> good idea
12:44 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-uocuefxkhlojdrlv] has joined #bitcoin-core-dev
12:44 < bitcoin-git> [bitcoin] jamesob closed pull request #15205: validation: avoid potential deadlocks in ValidationInterface (master...2019-01-avoid-validationqueue-deadlock) https://github.com/bitcoin/bitcoin/pull/15205
12:44 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-uocuefxkhlojdrlv] has left #bitcoin-core-dev []
12:46 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
12:49 < wumpus> gkrizek: I've removed the github service from #bitcoin-commits, right setting up an account on my server to run ghi, and sure an example could be helpful :)
12:51 < gkrizek> Awesome, I'll create one
12:51 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
12:54 < gkrizek> wumpus is the bitcoin-git Nick registered (ie; needs a password)?
12:55 -!- promag [~promag@83.223.251.34] has joined #bitcoin-core-dev
13:00 -!- promag [~promag@83.223.251.34] has quit [Ping timeout: 245 seconds]
13:02 < wumpus> gkrizek: it's not registered, probably should be tho
13:02 < gkrizek> Yeah, I would suggest it. But it will work either way
13:05 < gkrizek> wumpus: Example config file: https://gist.github.com/gkrizek/8ff05e1dd3196d488a71510838fcac72
13:07 < gkrizek> I think that should match the current GitHub service from what iI understand of it.
13:07 < gkrizek> I*
13:09 < wumpus> I guess boto3 is not necessary when not running from amazon?
13:10 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
13:11 < wumpus> gkrizek: the secret is simply an API token without special permissions?
13:11 < gkrizek> wumpus: no it's not. I was meaning to create two separate `requirements.txt` files. One for server, one for AWS but I forgot
13:12 < gkrizek> wumpus No, the Secret is something you make up.  
13:12 < gkrizek> https://developer.github.com/webhooks/securing/#setting-your-secret-token
13:13 < wumpus> ohh right, it gets pushed events, it doesn't pull them
13:13 < gkrizek> Exactly. And that's how Ghi can validate that it actually came from GitHub and someone isn't trying to MITM/spoof/etc
13:14 < wumpus> makes sense!
13:15 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Remote host closed the connection]
13:15 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev
13:16 -!- ratonlaveur [~ratonlave@67.215.14.198] has quit [Ping timeout: 250 seconds]
13:24 < wumpus> hm "2019-01-22 22:23:51 [ghi] Received repository 'bitcoin/bitcoin', but no pool is configured for it."
13:25 < wumpus> (after running it and setting up the webhook)
13:25 < gkrizek> Did you setup the .ghi.yml file? I linked you to an example
13:26 < gkrizek> https://gist.github.com/gkrizek/8ff05e1dd3196d488a71510838fcac72
13:27 < wumpus> I use that, only filled in the secret and changed the nick (to not conflict with github), and it says "2019-01-22 22:23:51 [ghi] Found configuration file at '/home/ghi/ghi/.ghi.yml'"
13:27 < wumpus> oh! no, it's picking up the wrong file
13:28 < gkrizek> Where did you put your .ghi.yml that I sent you?  The repo contains a template that is in the root of the repo, so you should really edit that. Or delete it and put yours somewhere else
13:29 < wumpus> I've put it in the homedir, but it was picking up the one in the local directory, launching it from somewhere else now
13:29 < gkrizek> Good testing though! haha I didn't quiet think about that being confusing, but I can definitely see where that could cause problems
13:30 < gkrizek> I should probably just delete the template .ghi.yml from the root of the project. That way you are forced to create one on start and it doesn't use the template
13:30 -!- _luc_ [~luc@2001:8003:24ae:8900:388e:e843:3141:af43] has joined #bitcoin-core-dev
13:31 < wumpus> or maybe rename it to ghi.yml.example
13:31 < wumpus> I agree having a life configuration file in the repo is probably not a good idea, wouldn't want to accidentally check it in with the secret in it
13:31 < wumpus> (which is why I used a location outside the repo)
13:33 < gkrizek> Yep, I think you are exactly right. 
13:33 < gkrizek> Did the homedir file work now?
13:34 < wumpus> I don't know if I can make it re-send the initial event
13:34 < wumpus> should I recreate the webhook?
13:34 < gkrizek> You can, one sec
13:34 < gkrizek> I'll try to find Docs
13:34 < wumpus> oh I see, "redeliver" lol
13:35 < gkrizek> https://developer.github.com/webhooks/testing/
13:35 < gkrizek> Yep, that's it
13:35 < Lightsword> we should probably mark #15063 as a 0.18 milestone requirement right?
13:35 -!- _luc_ [~luc@2001:8003:24ae:8900:388e:e843:3141:af43] has quit [Ping timeout: 264 seconds]
13:35 < gribble> https://github.com/bitcoin/bitcoin/issues/15063 | GUI: If BIP70 is disabled, attempt to fall back to BIP21 parsing by luke-jr · Pull Request #15063 · bitcoin/bitcoin · GitHub
13:36 < wumpus> Lightsword: would be nice to have it in, yes, will add milestone
13:37 < wumpus> gkrizek: "ModuleNotFoundError: No module named 'ghi.index'" :-(
13:38 < gkrizek> wumpus how are you executing it? If you are not in the current dir of the repo, you should set `PYTHONPATH="/home/ghi/ghi/"`
13:38 < gkrizek> Like in this systemd example: https://github.com/gkrizek/ghi/blob/master/examples/ghi.service.md
13:40 < wumpus> ok!
13:41 < gkrizek> I'll probably try to iron this out a little better in the future so it installs globally and you can just do `$ ghi start` or something. But didn't get there yet!
13:41 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev
13:42 < wumpus> 2019-01-22 22:41:39 [ghi] Received the 'ping' event
13:42 < wumpus> 2019-01-22 22:41:39 [ghi] Sent 'pong
13:42 < wumpus> that looks better!
13:42 < wumpus> that's what I initially tried, python3 install.py --user, but that made an 'egg' file without a command to launch it :)
13:43 < gkrizek> Ah gotcha. Yeah sorry not there yet! But yes that looks like the correct response!
13:44 < wumpus> okay, now I should merge something I guess
13:45 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Ping timeout: 245 seconds]
13:46 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
13:48 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has quit [Quit: Leaving]
13:48 -!- jnewbery [~john@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Quit: leaving]
13:49 < achow101> jonasschnelli: should a wallet with disabled private keys be able to import a private key?
13:49 -!- jnewbery [~john@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
13:52 -!- jnewbery [~john@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Client Quit]
13:53 -!- jnewbery [~john@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
13:53 -!- jnewbery [~john@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Client Quit]
13:53 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-wmdnlfmkipprsdnb] has joined #bitcoin-core-dev
13:53 < bitcoin-git> [bitcoin] laanwj pushed 3 new commits to master: https://github.com/bitcoin/bitcoin/compare/9bad1e0b22c1...94167e2b5b7b
13:53 < bitcoin-git> bitcoin/master 516437a Jonas Schnelli: Qt: remove macOS launch-at-startup option when compiled with > macOS 10.11
13:53 < bitcoin-git> bitcoin/master da60118 Jonas Schnelli: Fix macOS launch-at-startup memory issue
13:53 < bitcoin-git> bitcoin/master 94167e2 Wladimir J. van der Laan: Merge #15208: Qt: remove macOS launch-at-startup when compiled with > macOS 10.11, fix memory missmanagement...
13:53 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-wmdnlfmkipprsdnb] has left #bitcoin-core-dev []
13:54 < wumpus> gkrizek: looks like it didn't trigger
13:54 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-iypvddiouxfmatpz] has joined #bitcoin-core-dev
13:54 < bitcoin-git> [bitcoin] laanwj closed pull request #15208: Qt: remove macOS launch-at-startup when compiled with > macOS 10.11, fix memory missmanagement (master...2019/01/macos_autostart) https://github.com/bitcoin/bitcoin/pull/15208
13:54 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-iypvddiouxfmatpz] has left #bitcoin-core-dev []
13:54 < wumpus> gkrizek: log shows "2019-01-22 22:53:33 [ghi] /bin/sh: 1: Syntax error: "(" unexpected"
13:55 < wumpus> is it supposed to be calling into a shell?
13:57 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds]
14:00 < gkrizek> Ah, yes. it does to execute the main function. The Server is essentially just an API endpoint that executed the main function. I haven't tested it with /bin/sh, only /bin/bash
14:01 < gkrizek> Are you running it with Python 3?
14:03 < gkrizek> https://github.com/gkrizek/ghi/blob/master/ghi/server.py#L40-L54
14:04 < gkrizek> Hmmm mine still works with /bin/sh
14:05 -!- jnewbery [~john@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
14:06 < wumpus> yep python3 ghi/ghi/server.py --port ...
14:07 < wumpus> where does it get the /bin/sh from? can I change it to /bin/bash?
14:07 < gkrizek> What OS are you running? I'll try to reproduce it
14:08 < wumpus> Ubuntu 18.04.1 LTS
14:08 < wumpus> I can give you access to the account if that helps
14:09 < gkrizek> Sure, that would be great.
14:10 < gkrizek> https://krizek.io/ssh
14:24 -!- IZooo [~IzZzoOo@46.165.228.100] has joined #bitcoin-core-dev
14:28 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 240 seconds]
14:36 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
14:37 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection]
14:45 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.3]
14:49 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
14:49 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
14:54 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
14:59 -!- ratonlaveur_ [~ratonlave@67.215.14.198] has joined #bitcoin-core-dev
15:01 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-mqqvyafyyhvltnew] has joined #bitcoin-core-dev
15:01 < bitcoin-git> [bitcoin] Empact opened pull request #15231: Drop defunct Windows LookupIntern exception (master...ai-addrconfig) https://github.com/bitcoin/bitcoin/pull/15231
15:01 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-mqqvyafyyhvltnew] has left #bitcoin-core-dev []
15:04 -!- miknotauro [~miknotaur@187.207.5.246] has joined #bitcoin-core-dev
15:10 -!- ratonlaveur_ [~ratonlave@67.215.14.198] has quit [Ping timeout: 240 seconds]
15:14 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has quit [Remote host closed the connection]
15:23 -!- ThomasLuong [~ThomasLuo@170.199.232.138] has joined #bitcoin-core-dev
15:29 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
15:34 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection]
15:40 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev
15:58 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection]
16:05 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
16:06 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
16:16 -!- miknotauro [~miknotaur@187.207.5.246] has quit [Ping timeout: 250 seconds]
16:16 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 250 seconds]
16:28 -!- miknotauro [~miknotaur@187.207.5.246] has joined #bitcoin-core-dev
16:39 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection]
16:39 -!- miknotauro [~miknotaur@187.207.5.246] has quit [Ping timeout: 246 seconds]
16:39 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
16:40 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection]
16:47 -!- ThomasLuong [~ThomasLuo@170.199.232.138] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
16:49 -!- ThomasLuong [~ThomasLuo@170.199.232.138] has joined #bitcoin-core-dev
16:50 -!- ThomasLuong [~ThomasLuo@170.199.232.138] has quit [Client Quit]
16:53 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
16:57 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 268 seconds]
17:32 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
17:36 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 245 seconds]
18:05 -!- TX1683 [~TX1683@unaffiliated/tx1683] has quit [Ping timeout: 250 seconds]
18:08 -!- TX1683 [~TX1683@unaffiliated/tx1683] has joined #bitcoin-core-dev
18:09 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
18:12 -!- _luc_ [~luc@2001:8003:24ae:8900:6477:5ab3:9d86:c539] has joined #bitcoin-core-dev
18:13 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 250 seconds]
18:15 -!- _luc_ [~luc@2001:8003:24ae:8900:6477:5ab3:9d86:c539] has quit [Remote host closed the connection]
18:15 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 245 seconds]
18:48 -!- _luc_ [~luc@2001:8003:24ae:8900:118e:7577:aaa4:4519] has joined #bitcoin-core-dev
18:53 -!- _luc_ [~luc@2001:8003:24ae:8900:118e:7577:aaa4:4519] has quit [Ping timeout: 268 seconds]
18:53 -!- jarthur [~jarthur@207.114.244.5] has quit []
18:54 -!- harrymm [~harrymm@69.161.195.103] has joined #bitcoin-core-dev
18:56 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
19:00 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
19:00 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev
19:01 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Client Quit]
19:01 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
19:03 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-lwvjetrfayqhuxkm] has joined #bitcoin-core-dev
19:03 < bitcoin-git> [bitcoin] AkioNak opened pull request #15233: Prevent mutex lock fail even if --enable-debug (master...fix_mutex_lock_fail) https://github.com/bitcoin/bitcoin/pull/15233
19:03 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-lwvjetrfayqhuxkm] has left #bitcoin-core-dev []
19:05 -!- _luc_ [~luc@101.180.101.236] has joined #bitcoin-core-dev
19:25 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.]
19:37 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
19:42 -!- _luc_ [~luc@101.180.101.236] has quit [Remote host closed the connection]
19:44 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.]
19:47 -!- miknotauro [~miknotaur@187.207.5.246] has joined #bitcoin-core-dev
19:52 -!- a2 [~a4@142.177.73.13] has quit [Ping timeout: 268 seconds]
19:53 -!- yxz [~a4@142.177.73.13] has joined #bitcoin-core-dev
20:06 -!- achow101 [~achow101@unaffiliated/achow101] has quit [Quit: ZNC 1.7.0+deb0+xenial1 - https://znc.in]
20:09 -!- achow101 [~achow101@unaffiliated/achow101] has joined #bitcoin-core-dev
20:13 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 245 seconds]
20:15 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
20:18 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
20:18 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Client Quit]
20:26 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
20:34 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.]
21:06 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 246 seconds]
21:11 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
21:18 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection]
21:27 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
21:27 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
21:55 < jonasschnelli> <achow101>	jonasschnelli: should a wallet with disabled private keys be able to import a private key?
21:56 < jonasschnelli> no
21:56 < jonasschnelli> The idea is that you have a sane option where you can be 100% sure its watch only
21:56 -!- miknotauro [~miknotaur@187.207.5.246] has quit [Ping timeout: 250 seconds]
21:56 < jonasschnelli> Ideal for combination with cold storage
21:57 < jonasschnelli> You can use fundrawtransaction and can not shoot in your own foot with – as example – create a new change address because you wrote "changeaddress" instead of "changeAddress".
21:58 < gmaxwell> I think they shouldn't be able to import a key.
21:59 < gmaxwell> and if thats a problem we should make more RPCs accept key arguments.
21:59 < gmaxwell> importing a private key in a key disabled wallet should convert the private key to pubkeys and import that, perhaps.
21:59 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-mfjyfbwfjrodctbj] has joined #bitcoin-core-dev
21:59 < bitcoin-git> [bitcoin] jonasschnelli pushed 4 new commits to master: https://github.com/bitcoin/bitcoin/compare/94167e2b5b7b...82cf6813a4ef
21:59 < bitcoin-git> bitcoin/master eb9ef04 Jonas Schnelli: REST: add "blockhashbyheight" call, fetch blockhash by height
21:59 < bitcoin-git> bitcoin/master 579d418 Jonas Schnelli: [QA] add rest tests for /rest/blockhashbyheight/<HEIGHT>.<FORMAT>
21:59 < bitcoin-git> bitcoin/master 42ff30e Jonas Schnelli: [Docs] add short documentation for /rest/blockhashbyheight
21:59 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-mfjyfbwfjrodctbj] has left #bitcoin-core-dev []
22:00 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-nrtrbjhinbvydjdq] has joined #bitcoin-core-dev
22:00 < bitcoin-git> [bitcoin] jonasschnelli closed pull request #14353: REST: add blockhash call, fetch blockhash by height (master...2018/09/rest_blockhash) https://github.com/bitcoin/bitcoin/pull/14353
22:00 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-nrtrbjhinbvydjdq] has left #bitcoin-core-dev []
22:02 < achow101> well it's currently possible to import a privkey to a private keys disabled wallet. it wasn't clear from the pr discussion whether this was intended
22:05 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev
22:06 < sipa>  i don't think it should convert to pubkey
22:06 < sipa> that could be very unexpected behaviour if someone thought they'd have access to that key
22:06 < sipa> failing sounds reasonable
22:10 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Ping timeout: 268 seconds]
22:11 -!- yxz [~a4@142.177.73.13] has quit []
22:13 -!- yxz [~a4@142.177.73.13] has joined #bitcoin-core-dev
22:16 -!- rex4539 [~rex4539@ppp-2-84-172-204.home.otenet.gr] has quit [Quit: rex4539]
22:18 -!- yxz [~a4@142.177.73.13] has quit [Ping timeout: 246 seconds]
22:25 -!- Krellan [~Krellan@2601:640:4000:a876:9582:4578:8f2:3075] has joined #bitcoin-core-dev
22:30 -!- Krellan [~Krellan@2601:640:4000:a876:9582:4578:8f2:3075] has quit [Ping timeout: 250 seconds]
22:34 -!- _luc_ [~luc@101.180.101.236] has joined #bitcoin-core-dev
22:36 -!- rex4539 [~rex4539@ppp-2-84-172-204.home.otenet.gr] has joined #bitcoin-core-dev
22:38 -!- _luc_ [~luc@101.180.101.236] has quit [Ping timeout: 268 seconds]
22:42 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-miurbexryhsdorgr] has joined #bitcoin-core-dev
22:42 < bitcoin-git> [bitcoin] achow101 opened pull request #15235: Do not import private keys to wallets with private keys disabled (master...fix-noprivs-import) https://github.com/bitcoin/bitcoin/pull/15235
22:42 -!- bitcoin-git [bitcoin-gi@gateway/service/github.com/x-miurbexryhsdorgr] has left #bitcoin-core-dev []
22:44 -!- _luc_ [~luc@2001:8003:24ae:8900:856a:2c77:a8d6:2db1] has joined #bitcoin-core-dev
23:24 -!- Krellan [~Krellan@2601:640:4000:a876:c976:2ef:a35b:4458] has joined #bitcoin-core-dev
23:45 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection]
23:46 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev
23:56 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection]
23:57 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
--- Log closed Wed Jan 23 00:00:28 2019