--- Log opened Wed Jan 30 00:00:36 2019 00:00 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 00:10 -!- hashist [~hashist@157.157.113.86] has quit [Ping timeout: 245 seconds] 00:20 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection] 00:48 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 00:52 -!- schmidty_ [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has joined #bitcoin-core-dev 00:52 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 245 seconds] 00:54 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev 00:54 -!- schmidty_ [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has quit [Read error: Connection reset by peer] 01:01 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 250 seconds] 01:04 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 01:06 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 01:10 -!- Krellan [~Krellan@2601:640:4000:a876:ac5e:6dfa:8077:7ec1] has joined #bitcoin-core-dev 01:12 -!- ThomasLuong [~ThomasLuo@c-71-193-183-116.hsd1.or.comcast.net] has quit [Quit: Textual IRC Client: www.textualapp.com] 01:12 -!- rhavar [uid237883@gateway/web/irccloud.com/x-lycbkttrhjnjyzqz] has quit [Quit: Connection closed for inactivity] 01:31 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev 01:47 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 01:48 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 01:52 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Ping timeout: 240 seconds] 02:03 -!- kexkey [~kexkey@172.98.82.4] has quit [Read error: Connection reset by peer] 02:07 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 02:09 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 02:09 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 02:11 -!- wpaulino [~wpaulino@unaffiliated/wpaulino] has quit [Quit: leaving] 02:20 -!- jungly [~quassel@79.8.200.97] has joined #bitcoin-core-dev 02:21 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 02:25 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 02:26 -!- root [~wpaulino@142.93.92.243] has joined #bitcoin-core-dev 02:27 -!- root is now known as Guest94198 02:28 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 02:28 -!- Guest94198 [~wpaulino@142.93.92.243] has quit [Client Quit] 02:29 -!- root__ [~wpaulino@142.93.92.243] has joined #bitcoin-core-dev 02:29 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Remote host closed the connection] 02:29 -!- root__ [~wpaulino@142.93.92.243] has quit [Client Quit] 02:31 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 02:33 -!- rex4539 [~rex4539@ppp-2-84-174-220.home.otenet.gr] has quit [Quit: rex4539] 02:37 -!- wpaulino [~wpaulino@unaffiliated/wpaulino] has joined #bitcoin-core-dev 02:51 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has quit [Quit: Snoozing.] 03:02 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection] 03:03 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev 03:13 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection] 03:13 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 03:17 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 245 seconds] 03:22 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 03:26 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 03:27 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection] 03:28 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 03:29 -!- rex4539 [~rex4539@ppp-2-86-202-147.home.otenet.gr] has joined #bitcoin-core-dev 03:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:39 < bitcoin-git> [bitcoin] hebasto opened pull request #15292: Remove 'boost::optional'-related gcc warnings (master...0190130-gcc-maybeuninitialized) https://github.com/bitcoin/bitcoin/pull/15292 03:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:42 -!- rex4539 [~rex4539@ppp-2-86-202-147.home.otenet.gr] has quit [Quit: rex4539] 03:46 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:49 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 03:50 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 03:53 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has quit [Read error: Connection reset by peer] 03:54 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has joined #bitcoin-core-dev 03:59 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 04:22 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds] 04:27 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 04:38 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 250 seconds] 04:43 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 04:47 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has joined #bitcoin-core-dev 04:53 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 04:53 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 04:58 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 05:09 < provoostenator> IsMine is thoroughly confusing :-) Can anyone confirm or debunk my reasoning in #15263? 05:09 < gribble> https://github.com/bitcoin/bitcoin/issues/15263 | Descriptor expansions only need pubkey entries for PKH/WPKH by sipa · Pull Request #15263 · bitcoin/bitcoin · GitHub 05:14 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 05:17 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 05:18 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 244 seconds] 05:22 < provoostenator> And so in a descriptor based wallet, we would want a Descriptor method which for a given transaction checks if it spends to/from it? 05:23 < provoostenator> And then AddToWalletIfInvolvingMe just calls that on all its descriptors in order to decide what to add. 05:27 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 246 seconds] 05:34 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 05:48 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 05:52 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Ping timeout: 244 seconds] 06:07 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [] 06:22 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 06:25 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 272 seconds] 06:32 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 06:49 < promag> jimpo: do you consider implementing support for concurrent calls to TxIndex::FindTx? 06:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:52 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/72ca72e6370e...29396bd66999 06:52 < bitcoin-git> bitcoin/master 4f2e6c8 MarcoFalke: Squashed 'src/leveldb/' changes from 524b7e36a8..f545dfabff 06:52 < bitcoin-git> bitcoin/master fa61801 MarcoFalke: Pull leveldb subtree 06:52 < bitcoin-git> bitcoin/master 29396bd Wladimir J. van der Laan: Merge #15270: Pull leveldb subtree 06:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:53 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15270: Pull leveldb subtree (master...Mf1901-subtreeLeveldb) https://github.com/bitcoin/bitcoin/pull/15270 06:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:55 < wumpus> gkrizek: oh thanks for restarting the bot! 06:55 < wumpus> gkrizek: "but not sure where logs are being sent" ~/ghi.log :) 06:58 < gkrizek> wumpus no problem. I saw that log but it looked like it didn’t have any logs for days. I’ll keep an eye on it though. 06:58 < wumpus> jonasschnelli: it was an intermittent error, happened exaxtly once, I haven't been able to reproduce it 06:59 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has joined #bitcoin-core-dev 07:00 < wumpus> MarcoFalke: adding dongcarl sounds good to me, will do 07:02 -!- lmk22 [a4@gateway/vpn/privateinternetaccess/lmk22] has quit [] 07:17 < wumpus> gkrizek: once we're sure the bot is stable I'll add it to crontab etc to automatically (re)start 07:32 < wumpus> does it run for merges to 0.17? just merged 15252 but nothing 07:43 < gkrizek> wumpus sounds good It should message about any PR merges. It only comments about pushes to specific branches, but 0.17 should be one of them. Looking at the logs 07:46 < gkrizek> I'm going to restart it with debug enabled to try to catch some of this. 07:49 -!- jtimon [~quassel@92.28.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 07:51 < gkrizek> wumpus you can resend those payloads if you want to test it out 07:52 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 07:54 < wumpus> gkrizek: yeh i'll rewind the 0.17 one 07:54 -!- rex4539 [~rex4539@ppp-2-84-174-220.home.otenet.gr] has joined #bitcoin-core-dev 07:56 < sipa> provoostenator: with my latest PR pubkey entries in the expansion are only created for "pkh", "wpkh" and "combo" descriptors 07:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:57 < bitcoin-git> [bitcoin] fanquake merged pull request #15252: [0.17] Backport: Update zmq to 4.3.1 (.17...17-backport-15188) https://github.com/bitcoin/bitcoin/pull/15252 07:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:59 -!- Deinogalerix21 [~Deinogale@89.238.176.150] has joined #bitcoin-core-dev 08:00 < gkrizek> wumpus so that worked sending the PR message, but I see the commit push messages failed. I'll go fix that now 08:00 -!- Deinogalerix21 [~Deinogale@89.238.176.150] has quit [Client Quit] 08:02 -!- MrPaz [~MrPaz@c-71-57-73-68.hsd1.il.comcast.net] has joined #bitcoin-core-dev 08:02 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev 08:03 < wumpus> gkrizek: any idea why it was missed the first time around? 08:04 < gkrizek> No, I could see that it connected to IRC successfully but just stalled after that. So something happened with the IRC server. I'll leave debug on for a while so I can catch little errors like this. 08:07 < wumpus> gkrizek: ohh okay thank you 08:09 < wumpus> no big deal github's own service was also not 100% reliable in delivery 08:12 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 08:12 < gkrizek> Good to know! haha. I'll make some updates to hopefully fix these issues. Then I'll monitor the logs throughout the day and try to catch any new problems and fix them. 08:14 < gkrizek> Thanks everyone for being patient with this! It's very hard for me to adequately mimic the bitcoin repo payloads and IRC stuff, so naturally the bugs happen in "production". 08:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:21 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bd8bda161e35...a47319dada2f 08:21 < bitcoin-git> bitcoin/master 04da9f4 Amiti Uttarwar: [RPC] Update getrawtransaction interface 08:21 < bitcoin-git> bitcoin/master a47319d MarcoFalke: Merge #15159: [RPC] Remove lookup to UTXO set from GetTransaction 08:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:21 < bitcoin-git> [bitcoin] amitiuttarwar merged pull request #15159: [RPC] Remove lookup to UTXO set from GetTransaction (master...3931_rebase) https://github.com/bitcoin/bitcoin/pull/15159 08:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:31 < promag> gkrizek: is the code available? 08:32 < gkrizek> promag https://github.com/gkrizek/ghi 08:33 < gkrizek> Finding a couple bugs already that I'm working on fixes for 08:34 < promag> is there a 0.17.2 date? still some work in https://github.com/bitcoin/bitcoin/milestone/40 08:34 < promag> thaumavorio: athanks gkrizek 08:34 < promag> ops :s thanks gkrizek 08:45 -!- rhavar [uid237883@gateway/web/irccloud.com/x-cvjvsdovgfmddtfq] has joined #bitcoin-core-dev 09:04 -!- nullptr| [~nullptr|@ip-94-112-134-45.net.upcbroadband.cz] has quit [Quit: ZNC - http://znc.in] 09:06 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 09:07 -!- nullptr| [~nullptr|@ip-94-112-134-45.net.upcbroadband.cz] has joined #bitcoin-core-dev 09:18 -!- brianhoffman [~brianhoff@pool-72-83-155-130.washdc.fios.verizon.net] has quit [Ping timeout: 240 seconds] 09:19 < hebasto> could someone restart Travis on #15163? 09:19 < gribble> https://github.com/bitcoin/bitcoin/issues/15163 | Correct units for "-dbcache" and "-prune" by hebasto · Pull Request #15163 · bitcoin/bitcoin · GitHub 09:20 < provoostenator> sipa: I know. I want to check that I understand _why_ correctly (see my comment on your PR). 09:22 < provoostenator> tl&dr iiuc it's to prevent e.g. with multisig A+B, when A redeems to an address wpkh(a) that suddenly B sees that as part of his wallet. 09:23 -!- brianhoffman [~brianhoff@pool-72-83-155-130.washdc.fios.verizon.net] has joined #bitcoin-core-dev 09:26 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 09:27 < sipa> provoostenator: it's more that you only happen to need pubkey entries in the signprovider when pubkeys need to be looked up by hash 09:28 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev 09:29 < sipa> provoostenator: it's a bit of a coincidence that that is exactly compatible with what's needed for importmulti 09:31 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 240 seconds] 09:32 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds] 09:33 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 09:34 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Read error: Connection reset by peer] 09:34 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 09:40 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 09:54 -!- nev_ [~nev_@95.174.67.156] has joined #bitcoin-core-dev 09:56 -!- jungly [~quassel@79.8.200.97] has quit [Remote host closed the connection] 10:03 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Read error: Connection reset by peer] 10:03 -!- miknotauro [~miknotaur@187.207.5.246] has quit [Ping timeout: 246 seconds] 10:04 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 10:09 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has quit [Ping timeout: 268 seconds] 10:13 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 10:13 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has joined #bitcoin-core-dev 10:16 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 10:17 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Client Quit] 10:18 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 250 seconds] 10:19 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev 10:20 < MarcoFalke> Anyone interested in trading reviews on #15043? 10:20 < gribble> https://github.com/bitcoin/bitcoin/issues/15043 | test: Build fuzz targets into seperate executables by MarcoFalke · Pull Request #15043 · bitcoin/bitcoin · GitHub 10:20 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 10:22 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 10:28 -!- pinheadmz [~matthewzi@198-27-221-97.fiber.dynamic.sonic.net] has joined #bitcoin-core-dev 10:33 -!- nullptr| [~nullptr|@ip-94-112-134-45.net.upcbroadband.cz] has quit [Ping timeout: 245 seconds] 10:40 -!- nullptr| [~nullptr|@ip-94-112-134-45.net.upcbroadband.cz] has joined #bitcoin-core-dev 10:51 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt] 10:54 -!- MrPaz [~MrPaz@c-71-57-73-68.hsd1.il.comcast.net] has quit [Quit: Leaving] 10:56 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 246 seconds] 11:04 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection] 11:05 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev 11:06 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 11:06 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 11:08 -!- emilr [~emilr@unaffiliated/goregrind] has quit [Read error: Connection reset by peer] 11:12 -!- Madars [~null@unaffiliated/madars] has quit [Quit: reboot] 11:14 -!- mildly_risky [~textual@14.0.153.140] has quit [Ping timeout: 250 seconds] 11:16 -!- hashist [~hashist@157.157.113.86] has joined #bitcoin-core-dev 11:19 -!- Madars [~null@unaffiliated/madars] has joined #bitcoin-core-dev 11:21 < wumpus> src/wallet/rpcwallet.cpp:1638:41: warning: ‘*((void*)& height +4)’ may be used uninitialized in this function [-Wmaybe-uninitialized] 11:21 < wumpus> src/wallet/wallet.cpp:1704:72: warning: ‘*((void*)& block_height +4)’ may be used uninitialized in this function [-Wmaybe-uninitialize]d 11:21 < wumpus> that's some scary warnings 11:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:21 < bitcoin-git> [bitcoin] Empact opened pull request #15294: [moveonly] Extract RipeMd160 (master...ripe-md) https://github.com/bitcoin/bitcoin/pull/15294 11:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:22 < hebasto> wumpus: could you look into #15292? 11:22 < gribble> https://github.com/bitcoin/bitcoin/issues/15292 | Remove boost::optional-related false positive -Wmaybe-uninitialized warnings on GCC compiler by hebasto · Pull Request #15292 · bitcoin/bitcoin · GitHub 11:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:23 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/04226f8706b5...77339e5c244b 11:23 < bitcoin-git> bitcoin/master 6f6514a Hennadii Stepanov: Correct units for "-dbcache" and "-prune" 11:23 < bitcoin-git> bitcoin/master 77339e5 Wladimir J. van der Laan: Merge #15163: Correct units for "-dbcache" and "-prune" 11:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:24 < bitcoin-git> [bitcoin] hebasto merged pull request #15163: Correct units for "-dbcache" and "-prune" (master...0190114-correct-info-units) https://github.com/bitcoin/bitcoin/pull/15163 11:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:25 < wumpus> hebasto: good point, will take a look 11:25 < wumpus> gkrizek: i think the merger name is wrong^^ 11:26 < gkrizek> Looking at the comments before it, I'm guessing you merged it? 11:26 < wumpus> the bot makes it look like everyone (even those without commit access) merge their own PRs :$ 11:26 < wumpus> yep! 11:26 -!- emilr [~emilr@unaffiliated/goregrind] has joined #bitcoin-core-dev 11:26 < gkrizek> Ok, yep. Fixing that now. 11:27 < gkrizek> I believe I have fix the other issues though! Found some bugs that were causing it to basically be inoperable. So should be working much better now, but I'll watch it today 11:33 < gwillen> win goto #cslounge-finance 11:33 < gwillen> whoops 11:34 -!- nev_ [~nev_@95.174.67.156] has quit [Quit: Leaving] 11:36 < gkrizek> wumpus username issue fixed so all known issues are fixed, but I'll keep an eye on it 11:36 < meshcollider> gkrizek: thanks! 11:37 < gkrizek> No problem! :D 11:37 < wumpus> gkrizek: yay ! 11:37 < wumpus> I'll set it up for secp256k1 too 11:39 < gkrizek> Awesome 11:45 < wumpus> gkrizek: ok I've added the webhook in the secp256k1 project and updated the ghi config to add a new 'pool' for it 11:45 < wumpus> i think this should do it 11:46 -!- nullptr| [~nullptr|@ip-94-112-134-45.net.upcbroadband.cz] has quit [Ping timeout: 246 seconds] 11:52 -!- nullptr| [~nullptr|@ip-94-112-134-45.net.upcbroadband.cz] has joined #bitcoin-core-dev 11:55 < gkrizek> Ok, great. I see in the logs: "Received repository 'bitcoin-core/secp256k1', but no pool is configured for it.", but I'm guessing you added the webhook before the update to the config? 11:57 < MarcoFalke> wumpus: Mind to create a https://github.com/new for bitcoin-core/qa-assets ? 11:58 < MarcoFalke> To hold Bitcoin Core related blobs used for quality assurance 11:59 < wumpus> gkrizek: yes; i also guess it needs to be restarted before the change to the config takes effect? 11:59 < wumpus> MarcoFalke: sure! 11:59 < MarcoFalke> kewl 11:59 < gkrizek> No it shouldn't actually. So I'm guessing it was just a timing mismatch 12:00 < wumpus> gkrizek: i'll resend the event just in case 12:01 < gkrizek> "Received the 'ping' event Sent 'pong'" 12:01 < gkrizek> It works! 12:01 < wumpus> woohoo! 12:02 < MarcoFalke> I think #15043 is ready for merge, since there is no substantial review and it is holding back my work on the fuzz test runner 12:02 < gribble> https://github.com/bitcoin/bitcoin/issues/15043 | test: Build fuzz targets into seperate executables by MarcoFalke · Pull Request #15043 · bitcoin/bitcoin · GitHub 12:05 < wumpus> MarcoFalke: https://github.com/bitcoin-core/qa-assets is live 12:06 < wumpus> MarcoFalke: yes, was kind of waiting to merge that 12:08 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has quit [Quit: Leaving] 12:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:10 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/77339e5c244b...9553102c38c0 12:10 < bitcoin-git> bitcoin/master fab4bed MarcoFalke: [test] fuzz: make test_one_input return void 12:10 < bitcoin-git> bitcoin/master 2ca632e MarcoFalke: test: Build fuzz targets into seperate executables 12:10 < bitcoin-git> bitcoin/master 9553102 Wladimir J. van der Laan: Merge #15043: test: Build fuzz targets into seperate executables 12:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:11 < bitcoin-git> [bitcoin] laanwj merged pull request #15043: test: Build fuzz targets into seperate executables (master...Mf1812-buildFuzzTargets) https://github.com/bitcoin/bitcoin/pull/15043 12:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:12 < MarcoFalke> \o/ 12:13 < wumpus> MarcoFalke: any additional people that should have commit access? 12:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:14 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/9553102c38c0...bb36f5e24b63 12:14 < bitcoin-git> bitcoin/master fa83999 MarcoFalke: travis: Compile once on trusty 12:14 < bitcoin-git> bitcoin/master fa5ce3f MarcoFalke: travis: Compile trusty with depends for now 12:14 < bitcoin-git> bitcoin/master bb36f5e MarcoFalke: Merge #15276: travis: Compile once on trusty 12:14 < MarcoFalke> Pretty much anyone who wants to and is a common contributor to Core 12:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:15 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15276: travis: Compile once on trusty (master...Mf1901-travisTrusty) https://github.com/bitcoin/bitcoin/pull/15276 12:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:15 < wumpus> ok 12:15 < wumpus> I created a qa developers team just in case we want to add people (who are not the usual) at some point 12:16 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev 12:16 < gkrizek> Can I get a few more eyes on #15255? 12:16 < gribble> https://github.com/bitcoin/bitcoin/issues/15255 | [tests] Remove travis_wait from lint script by gkrizek · Pull Request #15255 · bitcoin/bitcoin · GitHub 12:17 < gkrizek> Simple, but it's the thing that caused our master CI failures that we couldn't find the cause 12:21 < wumpus> I mean one great advantage of having split repositories is that we could spread the load of maintenance a bit 12:22 < MarcoFalke> Merging of fuzz seeds could even be automatic. I am going to write a script for that 12:23 < wumpus> cool! 12:23 < MarcoFalke> Only seeds that increase node-coverage are going to be merged 12:33 -!- pinheadmz [~matthewzi@198-27-221-97.fiber.dynamic.sonic.net] has quit [Quit: pinheadmz] 12:52 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 12:57 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 13:03 < wumpus> promag: "is there a 0.17.2 date?" → no, we never plan release dates for minor releases, usually they're motivated by some more serious bug 13:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:12 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #15295: fuzz: Add test/fuzz/test_runner.py and run it in travis (master...Mf1901-qaFuzz) https://github.com/bitcoin/bitcoin/pull/15295 13:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:18 -!- rex4539 [~rex4539@ppp-2-84-174-220.home.otenet.gr] has quit [Quit: rex4539] 13:19 -!- millerti [~millerti@cpe-66-24-91-119.stny.res.rr.com] has joined #bitcoin-core-dev 13:22 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has joined #bitcoin-core-dev 13:24 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 13:25 -!- niska [~niska@68.ip-149-56-14.net] has quit [Ping timeout: 240 seconds] 13:28 -!- niska [~niska@68.ip-149-56-14.net] has joined #bitcoin-core-dev 13:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:29 < bitcoin-git> [bitcoin] practicalswift opened pull request #15296: tests: Add script checking for deterministic line coverage in unit tests (master...test_deterministic_coverage) https://github.com/bitcoin/bitcoin/pull/15296 13:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:30 -!- rex4539 [~rex4539@ppp-2-84-174-220.home.otenet.gr] has joined #bitcoin-core-dev 13:30 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 13:34 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 13:38 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 240 seconds] 13:40 < hebasto> Could someone restart Travis on #15292? My build is ok: https://travis-ci.org/hebasto/bitcoin/builds/486611945 13:40 < gribble> https://github.com/bitcoin/bitcoin/issues/15292 | Remove boost::optional-related false positive -Wmaybe-uninitialized warnings on GCC compiler by hebasto · Pull Request #15292 · bitcoin/bitcoin · GitHub 13:42 < wumpus> hebasto: sure 13:42 < hebasto> wumpus: ty 13:48 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection] 13:49 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 13:49 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection] 13:53 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 268 seconds] 13:56 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 14:05 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 14:13 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 14:13 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 14:37 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 14:38 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 14:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:39 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bb36f5e24b63...cb77dc820f1b 14:39 < bitcoin-git> bitcoin/master 2d48314 Hennadii Stepanov: Remove 'boost::optional'-related gcc warnings 14:39 < bitcoin-git> bitcoin/master cb77dc8 Wladimir J. van der Laan: Merge #15292: Remove 'boost::optional'-related false positive -Wmaybe-unin... 14:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:40 < bitcoin-git> [bitcoin] laanwj merged pull request #15292: Remove 'boost::optional'-related false positive -Wmaybe-uninitialized warnings on GCC compiler (master...0190130-gcc-maybeuninitialized) https://github.com/bitcoin/bitcoin/pull/15292 14:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:41 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 14:43 -!- pinheadmz [~matthewzi@209.209.238.182] has joined #bitcoin-core-dev 14:49 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev 15:03 -!- pinheadmz [~matthewzi@209.209.238.182] has quit [Quit: pinheadmz] 15:05 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 15:07 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection] 15:13 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev 15:19 -!- hashistnd [~hashist@157.157.113.86] has joined #bitcoin-core-dev 15:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 15:21 < bitcoin-git> [bitcoin] Empact closed pull request #15171: test: Wait before cleanup on exit (master...test-wait-cleanup) https://github.com/bitcoin/bitcoin/pull/15171 15:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 15:21 -!- hashist [~hashist@157.157.113.86] has quit [Ping timeout: 240 seconds] 15:36 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection] 15:37 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev 15:39 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 15:57 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 15:58 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 16:07 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev 16:12 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Ping timeout: 245 seconds] 16:24 -!- miknotauro [~miknotaur@187.207.5.246] has joined #bitcoin-core-dev 16:29 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 16:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 16:33 < bitcoin-git> [bitcoin] promag opened pull request #15297: wallet: Releases dangling files on BerkeleyEnvironment::Close (master...019-01-close-dbenv-files) https://github.com/bitcoin/bitcoin/pull/15297 16:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 16:34 < promag> ryanofsky: ^ 16:40 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.3] 16:50 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 16:51 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 16:58 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection] 17:26 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 17:33 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 245 seconds] 17:34 -!- ap4lmtree- is now known as ap4lmtree 17:56 -!- miknotauro [~miknotaur@187.207.5.246] has quit [Ping timeout: 272 seconds] 18:06 -!- jarthur [~jarthur@207.114.244.5] has quit [] 18:09 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 18:12 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 18:15 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has quit [Quit: drexl] 18:33 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 18:35 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 18:38 -!- Squidicuz [~squid@pool-72-74-34-120.bstnma.fios.verizon.net] has quit [Ping timeout: 240 seconds] 18:49 -!- phwalkr_ [~phwalkr@192.32.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev 18:50 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has quit [Ping timeout: 268 seconds] 19:04 -!- Squidicuz [~squid@pool-72-74-34-120.bstnma.fios.verizon.net] has joined #bitcoin-core-dev 19:10 -!- phwalkr_ [~phwalkr@192.32.61.94.rev.vodafone.pt] has quit [Ping timeout: 245 seconds] 19:26 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds] 19:30 -!- millerti [~millerti@cpe-66-24-91-119.stny.res.rr.com] has quit [Ping timeout: 240 seconds] 19:31 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has quit [Ping timeout: 250 seconds] 19:36 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev 19:40 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Ping timeout: 240 seconds] 20:05 -!- rhavar [uid237883@gateway/web/irccloud.com/x-cvjvsdovgfmddtfq] has quit [Quit: Connection closed for inactivity] 20:48 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev 20:52 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Ping timeout: 246 seconds] 21:11 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 21:26 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 21:52 -!- jtimon [~quassel@92.28.134.37.dynamic.jazztel.es] has quit [Ping timeout: 246 seconds] 22:00 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 22:05 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 22:09 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Ping timeout: 240 seconds] 22:15 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 22:35 -!- rex4539 [~rex4539@ppp-2-84-174-220.home.otenet.gr] has quit [Quit: rex4539] 23:03 -!- benthecarman [~benthecar@ics133-225.icsincorporated.com] has joined #bitcoin-core-dev 23:03 -!- benthecarman [~benthecar@ics133-225.icsincorporated.com] has quit [Client Quit] 23:14 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection] 23:15 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev 23:22 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 23:31 -!- rex4539 [~rex4539@ppp-2-86-202-147.home.otenet.gr] has joined #bitcoin-core-dev 23:35 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 23:46 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection] --- Log closed Thu Jan 31 00:00:36 2019