--- Log opened Mon Feb 04 00:00:40 2019 00:14 -!- mistergold [~mistergol@185.37.27.122] has joined #bitcoin-core-dev 00:23 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 00:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:24 < bitcoin-git> [bitcoin] bvbfan opened pull request #15336: Enable moving of hashes, uints, outpoints (master...master) https://github.com/bitcoin/bitcoin/pull/15336 00:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:49 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 00:51 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 250 seconds] 00:58 -!- darosior [52ff9820@gateway/web/freenode/ip.82.255.152.32] has joined #bitcoin-core-dev 01:07 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 01:25 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Remote host closed the connection] 01:25 -!- queip [~queip@unaffiliated/rezurus] has quit [Quit: bye, freenode] 01:31 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev 01:34 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev 01:36 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev 01:42 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:51 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 02:07 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Ping timeout: 240 seconds] 02:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:10 < bitcoin-git> [bitcoin] laanwj pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/2fbf6a57d282...64127b3098a1 02:10 < bitcoin-git> bitcoin/master 60e190c João Barbosa: gui: Fix WalletController deletion 02:10 < bitcoin-git> bitcoin/master 07b9aad João Barbosa: gui: Expose BitcoinGUI::unsubscribeFromCoreSignals 02:10 < bitcoin-git> bitcoin/master fd6d499 João Barbosa: gui: Fix m_node.startShutdown() order 02:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:10 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev 02:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 02:11 < bitcoin-git> [bitcoin] laanwj merged pull request #15280: gui: Fix shutdown order (master...019-01-gui-shutdown) https://github.com/bitcoin/bitcoin/pull/15280 02:11 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 02:13 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 02:25 -!- Soligor [~soligor@unaffiliated/soligor] has quit [Remote host closed the connection] 02:25 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 02:28 -!- ExtraCrispy [~ExtraCris@gateway/tor-sasl/extracrispy] has quit [Remote host closed the connection] 02:40 -!- Soligor [~soligor@unaffiliated/soligor] has joined #bitcoin-core-dev 02:47 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has joined #bitcoin-core-dev 03:15 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 03:23 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 03:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:27 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/64127b3098a1...424327e1a8f5 03:27 < bitcoin-git> bitcoin/master fae169c MarcoFalke: test: Make bloom tests deterministic 03:27 < bitcoin-git> bitcoin/master 424327e Wladimir J. van der Laan: Merge #15324: test: Make bloom tests deterministic 03:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:28 < bitcoin-git> [bitcoin] laanwj merged pull request #15324: test: Make bloom tests deterministic (master...Mf1902-qaBloom) https://github.com/bitcoin/bitcoin/pull/15324 03:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:33 -!- znd [5669095c@gateway/web/freenode/ip.86.105.9.92] has joined #bitcoin-core-dev 03:33 < wumpus> #15140 confuses me a bit 03:34 < gribble> https://github.com/bitcoin/bitcoin/issues/15140 | test: fix script_p2sh_tests OP_PUSHBACK2/4 missing by kodslav · Pull Request #15140 · bitcoin/bitcoin · GitHub 03:34 < wumpus> does it fix an actual problem? 03:36 -!- darosior [52ff9820@gateway/web/freenode/ip.82.255.152.32] has quit [Ping timeout: 256 seconds] 03:42 < luke-jr> wumpus: I guess the test wasn't testing what it was supposed to? not sure 03:43 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:43 < wumpus> yea that's what it purports to do, the change itself is kind of strange though 03:47 < wumpus> it seems that a more minimal fix could solve it 03:47 < wumpus> but I might be wrong 03:47 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has quit [Ping timeout: 250 seconds] 03:49 -!- jungly [~quassel@host97-200-static.8-79-b.business.telecomitalia.it] has joined #bitcoin-core-dev 03:55 -!- marcoagner [~user@2001:8a0:fee8:9001:f21d:827f:7aa5:c011] has joined #bitcoin-core-dev 03:57 < promag> coffee break merge #15322 03:57 < gribble> https://github.com/bitcoin/bitcoin/issues/15322 | wallet: Add missing cs_db lock by promag · Pull Request #15322 · bitcoin/bitcoin · GitHub 04:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:03 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/424327e1a8f5...ebc6542d982c 04:03 < bitcoin-git> bitcoin/master 712d35b João Barbosa: wallet: Add missing cs_db lock 04:03 < bitcoin-git> bitcoin/master ebc6542 Wladimir J. van der Laan: Merge #15322: wallet: Add missing cs_db lock 04:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 04:03 < bitcoin-git> [bitcoin] laanwj merged pull request #15322: wallet: Add missing cs_db lock (master...019-01-cs_db) https://github.com/bitcoin/bitcoin/pull/15322 04:03 < promag> that was fast 04:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 04:04 < wumpus> promag: yep already intended to merge that one 04:04 < promag> ok ty 04:04 < wumpus> but you reminded me 04:05 < promag> I'm now with #15153 04:05 < gribble> https://github.com/bitcoin/bitcoin/issues/15153 | gui: Add Open Wallet menu by promag · Pull Request #15153 · bitcoin/bitcoin · GitHub 04:09 < fanquake> promag restarted all the tests in 15153 04:10 < fanquake> planning on testing that again 04:10 < promag> fanquake: I'll push shortly 04:10 < promag> I think it's good enough for 1st GUI support 04:12 < promag> in order to support "cancel open because it's rescanning" we have to do some refactors 04:12 < fanquake> promag, yes I think so. There are still edge cases/improvements that can be fixed/made later 04:12 < fanquake> i.e closing a modal after opening a wallet, then opening the same wallet again 04:13 < fanquake> You end up with the first completing, then the second opening failing because the same wallet is loaded already. 04:13 -!- mistergo1d [~mistergol@77.243.31.254] has joined #bitcoin-core-dev 04:13 < promag> fanquake: I think I can fix that, by disabling the close 04:13 -!- mistergold [~mistergol@185.37.27.122] has quit [Read error: Connection reset by peer] 04:13 < promag> fanquake: right 04:15 < fanquake> Disabling the close button could work, although that's probably not ideal if you are stuck with a long time to rescan wallet, and want to bail out. 04:15 < promag> fanquake: ryanofsky: I think Node::loadWallet should return the Wallet immediately, and the the GUI could add handlers and interact with the wallet asynchronously 04:16 < promag> fanquake: ah I see, then I it should not be modal, and if the same wallet is opened then it fails 04:28 < wumpus> hhmm translation process for adding new translations needs to be updated for the MSVC build system 04:28 < wumpus> translations are listed in three places now :( 04:32 < wumpus> (working on this) 04:34 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 04:44 -!- rabidus [~rabidus@85-23-137-40.bb.dnainternet.fi] has quit [Ping timeout: 268 seconds] 04:44 -!- jtimon [~quassel@92.28.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 04:45 -!- rabidus [~rabidus@85-23-137-40.bb.dnainternet.fi] has joined #bitcoin-core-dev 04:48 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection] 05:00 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 250 seconds] 05:01 -!- mistergo1d [~mistergol@77.243.31.254] has quit [Ping timeout: 244 seconds] 05:04 -!- mistergold [~mistergol@77.243.31.254] has joined #bitcoin-core-dev 05:06 -!- Skirmant [~Skirmant@217.117.25.58] has joined #bitcoin-core-dev 05:09 -!- Skirmant [~Skirmant@217.117.25.58] has quit [Client Quit] 05:15 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has quit [Remote host closed the connection] 05:16 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev 05:16 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has quit [Remote host closed the connection] 05:17 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev 05:17 -!- darosior [25ab9590@gateway/web/freenode/ip.37.171.149.144] has joined #bitcoin-core-dev 05:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:19 < bitcoin-git> [bitcoin] benthecarman opened pull request #15337: rpc: Fix for segfault if combinepsbt called with empty inputs (master...rpc_combinepbst_empty_fix) https://github.com/bitcoin/bitcoin/pull/15337 05:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 05:25 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has quit [Ping timeout: 240 seconds] 05:41 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 05:42 -!- thedevworks [~thedevwor@185.49.169.22] has joined #bitcoin-core-dev 05:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 05:48 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #15338: ci: Build and run tests once on freebsd (master...Mf1902-cirrusci) https://github.com/bitcoin/bitcoin/pull/15338 05:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:10 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 06:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:12 < bitcoin-git> [bitcoin] laanwj opened pull request #15339: qt: Pre-0.18 split-off translations update (master...019_02_translations) https://github.com/bitcoin/bitcoin/pull/15339 06:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:14 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Ping timeout: 244 seconds] 06:24 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 06:37 -!- phwalkr [~phwalkr@194.210.91.15] has joined #bitcoin-core-dev 06:41 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [] 06:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:59 < bitcoin-git> [bitcoin] hebasto opened pull request #15340: gui: Introduce bilingual GUI error messages (master...0190204-bilingual-initerror) https://github.com/bitcoin/bitcoin/pull/15340 06:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:01 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 07:04 -!- darosior [25ab9590@gateway/web/freenode/ip.37.171.149.144] has quit [Ping timeout: 256 seconds] 07:10 < dongcarl> Re #13865, wondering if people think this is a good idea. Pro: git bisectability, Con: travis will be even slower 07:10 < gribble> https://github.com/bitcoin/bitcoin/issues/13865 | Travis test for commit range · Issue #13865 · bitcoin/bitcoin · GitHub 07:17 < luke-jr> dongcarl: it shouldn't affect build times *too* much, so long as it uses the same build dir between commits 07:18 < dongcarl> Okay, I will PR to do `git --exec` then 07:18 < dongcarl> or rather `git rebase --exec` 07:18 < instagibbs> I don't have a lot of experience in this but how often has this been a problem 07:19 < dongcarl> instagibbs: You mean git bisectability? 07:19 < luke-jr> that's a good point too 07:20 < wumpus> I don't see a strong reason to do this either 07:20 < instagibbs> dongcarl, correct, how often has this been an issue 07:20 < luke-jr> AFAIK git bisect doesn't go inside merges unless the issue is part of that set of commits 07:20 < wumpus> testing the top commit of a PR should be enough, anything else is for certain going to confuse people, how many projects run the CI on every single commit even in merges? 07:21 < dongcarl> I guess I was thinking that if we had a long-standing bug we could use bisect to find where it started 07:21 < luke-jr> too bad there's no way to set priorities so Travis just runs everything on intermediate commits if it gets idle cycles 07:22 < luke-jr> dongcarl: you can do that regardless 07:22 < wumpus> bisect is already quite usable 07:22 < wumpus> never had problems really 07:22 < instagibbs> dongcarl, I believe luke is right in that it can still do it, regardless 07:22 < dongcarl> Okay cool 07:22 < instagibbs> as long as merge commits are properly passing 07:22 < wumpus> right 07:22 < dongcarl> luke-jr: wanna close #13865? 07:22 < gribble> https://github.com/bitcoin/bitcoin/issues/13865 | Travis test for commit range · Issue #13865 · bitcoin/bitcoin · GitHub 07:23 < instagibbs> You can also mark known-bad commits 07:23 < instagibbs> and skip them 07:24 * dongcarl of little faith in the Linus, repenting 07:24 < luke-jr> dongcarl: I don't have access to close it 07:24 < luke-jr> instagibbs: hm, I wonder if there's a way to make a permanent list of skip commits 07:25 < instagibbs> someone can grind through commits and build it :P 07:25 < instagibbs> then we can make a bisect wrapper script that allows bisection to skip 07:26 < luke-jr> no, I just mean, next time I'm bisecting, it'd be nice to be able to do `git bisect skip --remember` or something 07:27 < instagibbs> ah, not sure about that one 07:30 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 07:33 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 07:34 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Client Quit] 07:36 < promag> dongcarl: I like the idea and most branches have few commit. however travis already takes a lot of time.. 07:37 -!- michaelsdunn1 [~michaelsd@38.126.31.226] has joined #bitcoin-core-dev 07:37 -!- michaelsdunn1 [~michaelsd@38.126.31.226] has quit [Changing host] 07:37 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev 07:38 < promag> wumpus: if there was enough horsepower then you wouldn't mind it 07:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:39 < bitcoin-git> [bitcoin] promag opened pull request #15341: rpc: Support specifying change address in bumpfee (master...019-01-bumpfee-changeaddress) https://github.com/bitcoin/bitcoin/pull/15341 07:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:40 < luke-jr> kinda crazy to think how far CPUs have come, and still there is a question of horsepower for some things 07:41 < wumpus> c++ is crazy expensive to compile 07:42 < wumpus> both in memory as cpu 07:43 -!- phwalkr [~phwalkr@194.210.91.15] has quit [Remote host closed the connection] 07:44 -!- phwalkr [~phwalkr@194.210.91.15] has joined #bitcoin-core-dev 07:45 -!- znd [5669095c@gateway/web/freenode/ip.86.105.9.92] has quit [Quit: Page closed] 07:45 < wumpus> I don't know why that's the case, but pretty much every language does better in that regard 07:45 < promag> what is the motivation of #15340? is this something found elsewhere? 07:45 < gribble> https://github.com/bitcoin/bitcoin/issues/15340 | gui: Introduce bilingual GUI error messages by hebasto · Pull Request #15340 · bitcoin/bitcoin · GitHub 07:46 -!- phwalkr [~phwalkr@194.210.91.15] has quit [Read error: Connection reset by peer] 07:46 < wumpus> it was discussed on IRC at some point as a way to make googling errors easier 07:46 < hebasto> promag: ^ 07:46 < wumpus> but this is quite an ugly change :/ and it doesn't even really work like this 07:47 < hebasto> wumpus: yep ( 07:47 < sipa> wumpus: templates.. they essentially require recompiling for every instantiation 07:47 < wumpus> sipa: it's true but many other languages have parametrized types too 07:48 < luke-jr> wumpus: we had C++ in 2005 07:48 < luke-jr> maybe not C++11, but surely the feature additions aren't *that* big a difference 07:49 < sipa> wumpus: perhaps the pervasive use of templates in the standard library 07:49 < sipa> how many languages have a sort function instantiated for every call 07:49 < promag> another coffee break merge #15297 07:49 < gribble> https://github.com/bitcoin/bitcoin/issues/15297 | wallet: Releases dangling files on BerkeleyEnvironment::Close by promag · Pull Request #15297 · bitcoin/bitcoin · GitHub 07:50 < wumpus> luke-jr: maybe the source code compiled was smaller, on average, at the time :) 07:50 < promag> wumpus: do you want me to review any specific pr? 07:50 < wumpus> compilers certainly have improved since then 07:50 < promag> 0.18 or hp? 07:51 < wumpus> promag: that's really up to you 07:51 < wumpus> but it's a good point that so close to a release, having two lists to prioritize review isn't great 07:51 < wumpus> normally I'd say "high priority for review" takes precedence as it's blocking people 07:53 < wumpus> most things tagged 0.18 will be untagged anyway when it's time for the release and they haven't made it 07:53 < wumpus> promag: thanks! 07:54 < promag> no problem 07:55 < wumpus> luke-jr: of course our functional test suite takes significant time too, blaming the compiler only isn't fair :) 07:55 < wumpus> promag: that one has no (ut)ACKs at all 07:55 < promag> wumpus: I know :( 07:56 < promag> maybe next week coffee 07:57 < luke-jr> XD 07:57 < wumpus> hehe 07:57 < luke-jr> wumpus: I suppose in 2005, we didn't have CI 07:58 < luke-jr> but anyway, that wasn't really my point. :x 08:08 -!- bitcoin-git [~bitcoin-g@51.15.8.174] has joined #bitcoin-core-dev 08:08 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/ebc6542d982c...6a5feb7d821f 08:08 < bitcoin-git> bitcoin/master bef8fdd ken2812221: msvc: Fix silent merge conflict between #13926 and #14372 08:08 < bitcoin-git> bitcoin/master 6a5feb7 MarcoFalke: Merge #15325: msvc: Fix silent merge conflict between #13926 and #14372 08:08 -!- bitcoin-git [~bitcoin-g@51.15.8.174] has left #bitcoin-core-dev [] 08:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:09 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15325: msvc: Fix silent merge conflict between #13926 and #14372 (master...msvc-merge-conflict) https://github.com/bitcoin/bitcoin/pull/15325 08:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:15 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 08:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:16 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6a5feb7d821f...70d06eb857ce 08:16 < bitcoin-git> bitcoin/master fa6b7b9 MarcoFalke: travis: Revert "Run extended tests once daily" 08:16 < bitcoin-git> bitcoin/master 70d06eb MarcoFalke: Merge #15328: travis: Revert "Run extended tests once daily" 08:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:17 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15328: travis: Revert "Run extended tests once daily" (master...Mf1902-travisExt) https://github.com/bitcoin/bitcoin/pull/15328 08:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:18 -!- jarthur_ [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 08:20 -!- jarthur_ [~jarthur@207.114.244.5] has quit [Client Quit] 08:21 -!- jarthur [~jarthur@207.114.244.5] has quit [Ping timeout: 250 seconds] 08:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:23 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/70d06eb857ce...cf8aa5c76ad8 08:23 < bitcoin-git> bitcoin/master df8a7d3 Wladimir J. van der Laan: qt: Pre-0.18 split-off translations update 08:23 < bitcoin-git> bitcoin/master cf8aa5c Wladimir J. van der Laan: Merge #15339: qt: Pre-0.18 split-off translations update 08:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:24 < bitcoin-git> [bitcoin] laanwj merged pull request #15339: qt: Pre-0.18 split-off translations update (master...019_02_translations) https://github.com/bitcoin/bitcoin/pull/15339 08:24 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:25 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection] 08:28 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection] 08:33 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 08:35 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 08:41 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 08:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:49 < bitcoin-git> [bitcoin] dongcarl opened pull request #15343: netaddress: Make IPv4 loopback comment more descriptive (master...019-02-islocal-clarify) https://github.com/bitcoin/bitcoin/pull/15343 08:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:59 < bitcoin-git> [bitcoin] hebasto closed pull request #15340: gui: Introduce bilingual GUI error messages (master...0190204-bilingual-initerror) https://github.com/bitcoin/bitcoin/pull/15340 08:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:03 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection] 09:03 -!- jungly [~quassel@host97-200-static.8-79-b.business.telecomitalia.it] has quit [Remote host closed the connection] 09:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:03 < bitcoin-git> [bitcoin] Empact opened pull request #15344: travis: Enable functional tests against Trusty (master...trusty-functional) https://github.com/bitcoin/bitcoin/pull/15344 09:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:04 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev 09:14 -!- mistergold [~mistergol@77.243.31.254] has quit [Read error: Connection reset by peer] 09:16 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 09:26 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has quit [Quit: pinheadmz] 09:28 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 09:41 < dongcarl> Hey all, anyone got a good understanding of `mapLocalHost`? 09:42 < dongcarl> What does "local address for a particular peer" mean? 09:42 * dongcarl looking at `GetLocal` 09:43 < sipa> dongcarl: for a IPv4 peer your own address will likely be an IPv4 one 09:43 < sipa> i think 09:44 < sipa> this code has evolved a bit since i last worked on it 09:44 < dongcarl> sipa: So... `GetLocal` tries to find the best "local" address to give to a peer? 09:45 < dongcarl> Why would it matter to peers? I feel like I'm misunderstanding... 09:49 -!- ThomasLuong [~ThomasLuo@170.199.232.138] has joined #bitcoin-core-dev 09:55 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 10:00 < wumpus> it's used to determine what address to gossip IIRC 10:05 -!- Orion3k [~Orion3k@24-176-200-142.static.mtpk.ca.charter.com] has joined #bitcoin-core-dev 10:10 < dongcarl> Got the answer in `CNetAddr::GetReachabilityFrom` 10:11 < wumpus> okay! 10:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:15 < bitcoin-git> [bitcoin] dongcarl opened pull request #15345: net: Correct comparison of addr count (master...019-02-getnscore-fix) https://github.com/bitcoin/bitcoin/pull/15345 10:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:17 -!- ExtraCrispy [~ExtraCris@gateway/tor-sasl/extracrispy] has joined #bitcoin-core-dev 10:27 < dongcarl> wumpus: In situations like #15343, would it be okay for me to just fix the indentation for the function? 10:27 < gribble> https://github.com/bitcoin/bitcoin/issues/15343 | netaddress: Make IPv4 loopback comment more descriptive by dongcarl · Pull Request #15343 · bitcoin/bitcoin · GitHub 10:28 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection] 10:31 -!- nullptr| [~nullptr|@ip-94-112-134-45.net.upcbroadband.cz] has quit [Ping timeout: 246 seconds] 10:34 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has quit [Quit: pinheadmz] 10:35 < gkrizek> wumpus: I just pushed a fix for the leading digit problem on branch names. I updated the ghi instance on your server as well 10:37 -!- nullptr| [~nullptr|@ip-94-112-134-45.net.upcbroadband.cz] has joined #bitcoin-core-dev 10:41 < wumpus> dongcarl: how much of the indentation is broken? is it the case for other functions as well? 10:41 < wumpus> but sure, you certainly don't need to fix all the indentation, just don't introduce any new wrong one 10:42 < wumpus> gkrizek: oh great! thank you 10:42 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 10:42 -!- promag [~promag@83.223.251.76] has joined #bitcoin-core-dev 10:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:44 < bitcoin-git> [bitcoin] laanwj closed pull request #15274: remove redundant 'solved' from ProduceSignature (master...sign_redundant_solved) https://github.com/bitcoin/bitcoin/pull/15274 10:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:50 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 250 seconds] 10:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:51 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/cf8aa5c76ad8...76deb30550b2 10:51 < bitcoin-git> bitcoin/master b0c7b54 Carl Dong: init: Use systemd automatic directory creation 10:51 < bitcoin-git> bitcoin/master bad1716 Carl Dong: init: Modify docs and add release note for 12255 10:51 < bitcoin-git> bitcoin/master 76deb30 Wladimir J. van der Laan: Merge #12255: Update bitcoin.service to conform to init.md 10:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:52 < bitcoin-git> [bitcoin] laanwj merged pull request #12255: Update bitcoin.service to conform to init.md (master...patch-2) https://github.com/bitcoin/bitcoin/pull/12255 10:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:53 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 11:02 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 11:02 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 11:04 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 245 seconds] 11:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:06 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/76deb30550b2...bfbe42585e9b 11:06 < bitcoin-git> bitcoin/master 107623c Carl Dong: net: Correct comparison of addr count 11:06 < bitcoin-git> bitcoin/master bfbe425 Wladimir J. van der Laan: Merge #15345: net: Correct comparison of addr count 11:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:06 < bitcoin-git> [bitcoin] laanwj merged pull request #15345: net: Correct comparison of addr count (master...2019-02-getnscore-fix) https://github.com/bitcoin/bitcoin/pull/15345 11:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:12 < dongcarl> Can anyone tell me what the deprecated variable naming convention is? I see that `v*` is vector... `f*` seems to be booleans? There's also a `vf` in net.cpp, which is an array of booleans? 11:13 < sipa> dongcarl: v=vector, map=map, str=string, sz=c-style-string, f=flag 11:13 < sipa> vf=vector of flags 11:14 < dongcarl> sipa: Thank you! 11:15 -!- thedevworks [~thedevwor@185.49.169.22] has quit [Ping timeout: 250 seconds] 11:17 -!- thedevworks [~thedevwor@185.49.169.22] has joined #bitcoin-core-dev 11:17 < wumpus> don't use it in new code though 11:18 < dongcarl> wumpus: Haha yeah ofc 11:18 < dongcarl> I'm just reading thru net.cpp adding comments 11:19 < sipa> there are many variables whose type changed without the name changing accordingly 11:19 < sipa> there's probably some fun archaeology to do with that 11:19 < dongcarl> "fun" 11:19 -!- Krellan [~Krellan@2601:640:4000:a876:ac59:72ec:ed9b:59af] has quit [Remote host closed the connection] 11:22 < wumpus> dongcarl: btw if you intend to submit more comment changes to net code, that'd be very helpful, but it's probably better to group them into one PR instead of opening separate ones like #15343 11:22 < gribble> https://github.com/bitcoin/bitcoin/issues/15343 | [doc] netaddress: Make IPv4 loopback comment more descriptive by dongcarl · Pull Request #15343 · bitcoin/bitcoin · GitHub 11:23 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev 11:23 < dongcarl> wumpus: Okay will do, I guess I'll just separate them into different commits so that we can drop/modify them easily during review 11:24 < wumpus> yea multiple commits is fine! 11:27 -!- rex4539 [~rex4539@ppp-2-84-174-220.home.otenet.gr] has joined #bitcoin-core-dev 11:27 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has quit [Ping timeout: 250 seconds] 11:29 -!- jarthur_ [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 11:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:29 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/bfbe42585e9b...452acee4da20 11:29 < bitcoin-git> bitcoin/master 77777c5 MarcoFalke: log: Construct global logger on first use 11:29 < bitcoin-git> bitcoin/master 452acee MarcoFalke: Merge #15266: memory: Construct globals on first use 11:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:29 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15266: memory: Construct globals on first use (master...Mf1901-cofu) https://github.com/bitcoin/bitcoin/pull/15266 11:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:32 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 11:32 < dongcarl> Does anyone know what the "p" in "paddrPeer" in net.cpp might be referring to? 11:33 -!- jarthur [~jarthur@207.114.244.5] has quit [Ping timeout: 272 seconds] 11:33 < sipa> pointer 11:33 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 11:35 < promag> classic XD 11:35 < sipa> promag: that's hungarian style :) 11:35 * dongcarl facepalms 11:36 < dongcarl> Oh wow that's an actual thing 11:36 < dongcarl> TIL 11:37 < hebasto> jonasschnelli: thank you for your opinion about #15340 but this pr breaks translation process, unfortunately. 11:37 < gribble> https://github.com/bitcoin/bitcoin/issues/15340 | gui: Introduce bilingual GUI error messages by hebasto · Pull Request #15340 · bitcoin/bitcoin · GitHub 11:37 < promag> dongcarl: apologies for that, you were much happier before 11:38 < sipa> dongcarl: so psz is pointer-to-zero-terminated-string 11:38 < sipa> which used to occur frequently 11:40 < dongcarl> sipa: My mom warned me about nasty C-style zero-terminated strings! They hang out in all the bad stacks! 11:42 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Read error: Connection reset by peer] 11:43 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev 11:44 -!- ap4lmtree [~ap4lmtree@unaffiliated/ap4lmtree] has quit [Quit: Leaving] 11:53 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Quit: https://www.Quanto.ga/ -- Immutable state trading system in Clojure] 11:57 -!- jarthur_ [~jarthur@207.114.244.5] has quit [] 11:59 -!- ap4lmtree [~ap4lmtree@unaffiliated/ap4lmtree] has joined #bitcoin-core-dev 11:59 -!- promag [~promag@83.223.251.76] has quit [Remote host closed the connection] 11:59 < wumpus> hebasto: *conceptually* it's a good idea, it's just virtually impossible to implement correctly with gettext 12:01 -!- mn9495881 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev 12:01 < hebasto> wumpus: thanks 12:04 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Ping timeout: 250 seconds] 12:08 < wumpus> we've run into a similar issue in the past for the status bar, where we wanted to return the untranslated error on the RPC and the translated one on the GUI 12:08 < wumpus> ended up duplicating the text ... 12:09 < wumpus> would certainly *not* be nice to do for all errors 12:10 < wumpus> dongcarl: your mother is very wise 12:29 -!- thedevworks [~thedevwor@185.49.169.22] has quit [Ping timeout: 240 seconds] 12:31 -!- thedevworks [~thedevwor@185.49.169.22] has joined #bitcoin-core-dev 12:34 -!- ap4lmtree [~ap4lmtree@unaffiliated/ap4lmtree] has quit [Read error: Connection reset by peer] 12:44 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds] 12:45 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev 12:55 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev 12:57 -!- shesek [~shesek@141.226.217.238] has joined #bitcoin-core-dev 12:57 -!- shesek [~shesek@141.226.217.238] has quit [Changing host] 12:57 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 13:00 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has quit [Ping timeout: 246 seconds] 13:07 -!- darosior [52ff9820@gateway/web/freenode/ip.82.255.152.32] has joined #bitcoin-core-dev 13:16 -!- ap4lmtree [~ap4lmtree@unaffiliated/ap4lmtree] has joined #bitcoin-core-dev 13:24 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 13:32 -!- thedevworks [~thedevwor@185.49.169.22] has quit [Ping timeout: 250 seconds] 13:36 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has quit [Quit: pinheadmz] 13:42 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev 13:44 -!- macbroadcast [5d845041@gateway/web/freenode/ip.93.132.80.65] has joined #bitcoin-core-dev 13:47 -!- macbroadcast [5d845041@gateway/web/freenode/ip.93.132.80.65] has quit [Client Quit] 13:47 -!- macbroadcast_ [~macbroadc@x5d845041.dyn.telefonica.de] has joined #bitcoin-core-dev 13:48 -!- macbroadcast_ [~macbroadc@x5d845041.dyn.telefonica.de] has quit [Client Quit] 13:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:54 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #14169: add -debuglogsize= option (master...master) https://github.com/bitcoin/bitcoin/pull/14169 13:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:00 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 14:06 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev 14:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:10 < bitcoin-git> [bitcoin] darosior opened pull request #15346: cli: encryptwallet password entered from stdin. fixes #15318 (master...cli_encryptwallet_stdin) https://github.com/bitcoin/bitcoin/pull/15346 14:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:10 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has quit [Quit: Leaving...] 14:10 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:13 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 14:14 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 14:19 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 14:19 -!- rex4539 [~rex4539@ppp-2-84-174-220.home.otenet.gr] has quit [Ping timeout: 240 seconds] 14:26 -!- darosior [52ff9820@gateway/web/freenode/ip.82.255.152.32] has quit [Ping timeout: 256 seconds] 14:37 -!- Orion3k [~Orion3k@24-176-200-142.static.mtpk.ca.charter.com] has quit [Ping timeout: 244 seconds] 14:45 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 14:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:52 < bitcoin-git> [bitcoin] hebasto reopened pull request #15340: gui: Introduce bilingual GUI error messages (master...20190204-bilingual-initerror) https://github.com/bitcoin/bitcoin/pull/15340 14:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:52 -!- tryphe_ is now known as tryphe 14:55 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Ping timeout: 256 seconds] 14:59 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 15:03 -!- tyttor [251cd737@gateway/web/freenode/ip.37.28.215.55] has joined #bitcoin-core-dev 15:04 -!- tyttor [251cd737@gateway/web/freenode/ip.37.28.215.55] has left #bitcoin-core-dev [] 15:11 -!- thedevworks [~thedevwor@185.49.169.22] has joined #bitcoin-core-dev 15:12 -!- thedevworks [~thedevwor@185.49.169.22] has quit [Client Quit] 15:17 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 15:22 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds] 15:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 15:38 < bitcoin-git> [bitcoin] hebasto opened pull request #15347: Fix build after pr 15266 merged (master...20190205-fix15266) https://github.com/bitcoin/bitcoin/pull/15347 15:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 15:38 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection] 15:54 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has quit [Quit: pinheadmz] 15:54 -!- ThomasLuong [~ThomasLuo@170.199.232.138] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 16:01 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 16:11 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection] 16:12 -!- Murch [~murch@ip-173-132-80-240.atlnga.spcsdns.net] has joined #bitcoin-core-dev 16:12 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev 16:12 -!- jtimon [~quassel@92.28.134.37.dynamic.jazztel.es] has quit [Quit: gone] 16:14 -!- Krellan_ [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 16:15 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection] 16:17 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Ping timeout: 246 seconds] 16:23 -!- jtimon [~quassel@92.28.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 16:49 -!- miknotauro [~miknotaur@187.207.5.246] has joined #bitcoin-core-dev 17:00 -!- Murch [~murch@ip-173-132-80-240.atlnga.spcsdns.net] has quit [Quit: Snoozing.] 17:05 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Ping timeout: 256 seconds] 17:06 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev 17:14 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 17:21 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has quit [Quit: pinheadmz] 17:26 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 17:31 -!- IGHOR [~quassel@93.178.216.72] has quit [Quit: http://quassel-irc.org ? ??????????? ?????????. ????-??.] 17:33 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev 17:42 -!- Murch [~murch@64-71-8-130.static.wiline.com] has joined #bitcoin-core-dev 17:45 -!- Murch [~murch@64-71-8-130.static.wiline.com] has quit [Client Quit] 18:13 -!- miknotauro [~miknotaur@187.207.5.246] has quit [Ping timeout: 268 seconds] 18:15 -!- miknotauro [~miknotaur@201.114.244.101] has joined #bitcoin-core-dev 18:16 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [] 18:33 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 18:34 -!- miknotauro [~miknotaur@201.114.244.101] has quit [Remote host closed the connection] 18:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:37 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/452acee4da20...e50853501b79 18:37 < bitcoin-git> bitcoin/master e1b6436 Hennadii Stepanov: Fix build after pr 15266 merged 18:37 < bitcoin-git> bitcoin/master e508535 Wladimir J. van der Laan: Merge #15347: Fix build after pr 15266 merged 18:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:38 < bitcoin-git> [bitcoin] laanwj merged pull request #15347: Fix build after pr 15266 merged (master...20190205-fix15266) https://github.com/bitcoin/bitcoin/pull/15347 18:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 18:45 < bitcoin-git> [bitcoin] Empact closed pull request #15344: travis: Enable functional tests against Trusty (master...trusty-functional) https://github.com/bitcoin/bitcoin/pull/15344 18:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 18:48 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 18:53 -!- jarthur [~jarthur@207.114.244.5] has quit [Ping timeout: 246 seconds] 18:55 -!- Empact [~textual@2607:fb90:9c2d:b26d:29c1:21a7:daba:aacc] has joined #bitcoin-core-dev 18:55 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has joined #bitcoin-core-dev 19:04 -!- Empact [~textual@2607:fb90:9c2d:b26d:29c1:21a7:daba:aacc] has quit [Remote host closed the connection] 19:06 -!- Empact [~textual@38.104.224.174] has joined #bitcoin-core-dev 19:19 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 19:20 -!- Krellan_ [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 19:23 -!- Empact [~textual@38.104.224.174] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 19:26 -!- Empact [~textual@38.104.224.174] has joined #bitcoin-core-dev 19:27 -!- Empact [~textual@38.104.224.174] has quit [Client Quit] 19:28 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 19:31 -!- Empact [~textual@38.104.224.174] has joined #bitcoin-core-dev 19:43 -!- ThomasLuong [~ThomasLuo@c-71-193-183-116.hsd1.or.comcast.net] has joined #bitcoin-core-dev 19:48 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 19:50 -!- Empact [~textual@38.104.224.174] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 20:03 -!- achow101 [~achow101@unaffiliated/achow101] has quit [Ping timeout: 244 seconds] 20:11 -!- achow101 [~achow101@unaffiliated/achow101] has joined #bitcoin-core-dev 20:29 -!- skyikot [~skyikot@gateway/tor-sasl/skyikot] has joined #bitcoin-core-dev 20:42 -!- skyikot [~skyikot@gateway/tor-sasl/skyikot] has quit [Ping timeout: 256 seconds] 20:46 -!- skyikot [~skyikot@gateway/tor-sasl/skyikot] has joined #bitcoin-core-dev 20:48 -!- skyikot [~skyikot@gateway/tor-sasl/skyikot] has quit [Client Quit] 20:54 -!- skyikot [~skyikot@gateway/tor-sasl/skyikot] has joined #bitcoin-core-dev 21:06 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 21:23 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 21:26 -!- rex4539 [~rex4539@ppp-2-84-174-220.home.otenet.gr] has joined #bitcoin-core-dev 21:42 -!- nelsonhb [~Instantbi@49.125.12.54] has joined #bitcoin-core-dev 21:45 -!- skyikot [~skyikot@gateway/tor-sasl/skyikot] has quit [Quit: skyikot] 22:00 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 22:03 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 240 seconds] 22:06 -!- jtimon [~quassel@92.28.134.37.dynamic.jazztel.es] has quit [Ping timeout: 245 seconds] 22:07 -!- ThomasLuong [~ThomasLuo@c-71-193-183-116.hsd1.or.comcast.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 22:12 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 22:24 -!- skyikot [~skyikot@gateway/tor-sasl/skyikot] has joined #bitcoin-core-dev 22:26 -!- nelsonhb [~Instantbi@49.125.12.54] has quit [Quit: Instantbird 1.5 -- http://www.instantbird.com] 22:46 < meshcollider> provoostenator: I've just cleaned up #14491 now, feel free to rebase your stuff on top of it again :) 22:46 < gribble> https://github.com/bitcoin/bitcoin/issues/14491 | Allow descriptor imports with importmulti by MeshCollider · Pull Request #14491 · bitcoin/bitcoin · GitHub 23:16 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev 23:23 < meshcollider> whats up with the "Reading package lists... 23:23 < meshcollider> No output has been received in the last 10m0s" failures on travis atm 23:24 < meshcollider> https://travis-ci.org/bitcoin/bitcoin/builds/488891564 23:29 -!- skyikot [~skyikot@gateway/tor-sasl/skyikot] has quit [Ping timeout: 256 seconds] 23:43 -!- darosior [25ad0ef6@gateway/web/freenode/ip.37.173.14.246] has joined #bitcoin-core-dev 23:45 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 23:48 -!- jimmysong [~jimmysong@72-48-253-51.dyn.grandenetworks.net] has quit [Read error: Connection reset by peer] 23:49 -!- jimmysong [~jimmysong@72-48-253-51.dyn.grandenetworks.net] has joined #bitcoin-core-dev --- Log closed Tue Feb 05 00:00:41 2019