--- Log opened Wed Feb 06 00:00:42 2019
00:27 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-nxnscjygbipdjqno] has joined #bitcoin-core-dev
00:34 -!- Squidicuz [~squid@pool-72-74-34-120.bstnma.fios.verizon.net] has quit [Quit: Oh no, not again]
00:46 -!- Squidicuz [~squid@pool-72-74-34-120.bstnma.fios.verizon.net] has joined #bitcoin-core-dev
01:05 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev
01:28 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev
01:31 -!- mn9495882 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Ping timeout: 245 seconds]
01:33 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Ping timeout: 246 seconds]
01:35 -!- Randolf [~randolf@96.53.47.38] has quit [Ping timeout: 240 seconds]
01:35 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev
01:40 -!- Randolf [~randolf@96.53.47.38] has joined #bitcoin-core-dev
02:01 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
02:03 -!- kexkey [~kexkey@68.168.122.228] has quit [Read error: Connection reset by peer]
02:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:05 < bitcoin-git> [bitcoin] practicalswift opened pull request #15352: tests: Reduce noise level in test_bitcoin output (master...test_bitcoin-output-spam) https://github.com/bitcoin/bitcoin/pull/15352
02:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:06 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
02:06 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev
02:16 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
02:47 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
02:49 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has joined #bitcoin-core-dev
02:52 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has joined #bitcoin-core-dev
02:57 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev
03:03 -!- darosior [52ff9820@gateway/web/freenode/ip.82.255.152.32] has joined #bitcoin-core-dev
03:08 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection]
03:17 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
03:21 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has quit [Ping timeout: 264 seconds]
03:46 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has joined #bitcoin-core-dev
03:48 -!- rex4539 [~rex4539@ppp-2-84-174-220.home.otenet.gr] has quit [Quit: rex4539]
04:02 -!- darosior [52ff9820@gateway/web/freenode/ip.82.255.152.32] has quit [Ping timeout: 256 seconds]
04:03 < fanquake> jonasschnelli Are #7949 or #9502 Prs you'd still like to try and get into 0.18.0 ?  
04:03 < gribble> https://github.com/bitcoin/bitcoin/issues/7949 | [RPC] Add RPC long poll notifications by jonasschnelli · Pull Request #7949 · bitcoin/bitcoin · GitHub
04:03 < gribble> https://github.com/bitcoin/bitcoin/issues/9502 | [Qt] Add option to pause/resume block downloads by jonasschnelli · Pull Request #9502 · bitcoin/bitcoin · GitHub
04:05 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
04:14 -!- Deinogalerix21 [~Deinogale@89.238.176.150] has joined #bitcoin-core-dev
04:17 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has quit [Ping timeout: 244 seconds]
04:20 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has joined #bitcoin-core-dev
04:21 -!- Deinogalerix21 [~Deinogale@89.238.176.150] has quit [Quit: WeeChat 2.3]
04:26 -!- Jackielove4u [uid43977@gateway/web/irccloud.com/x-feahpfoxkewnmcgt] has quit [Quit: Connection closed for inactivity]
04:33 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
04:38 -!- rex4539 [~rex4539@ppp-2-84-174-220.home.otenet.gr] has joined #bitcoin-core-dev
04:47 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev
04:54 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection]
05:16 -!- Randolf [~randolf@96.53.47.38] has quit [Ping timeout: 268 seconds]
05:17 -!- promag [~promag@83.223.234.28] has joined #bitcoin-core-dev
05:30 -!- promag [~promag@83.223.234.28] has quit [Remote host closed the connection]
05:31 -!- darosior [25adb966@gateway/web/freenode/ip.37.173.185.102] has joined #bitcoin-core-dev
05:44 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev
05:51 -!- jtimon [~quassel@92.28.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev
05:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:55 < bitcoin-git> [bitcoin] merland opened pull request #15353: docs: Minor textual improvements in translation_strings_policy.md (master...patch-3) https://github.com/bitcoin/bitcoin/pull/15353
05:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:58 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has quit [Remote host closed the connection]
05:59 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has joined #bitcoin-core-dev
06:07 -!- Jackielove4u [uid43977@gateway/web/irccloud.com/x-iaxmmyzffhbxzweh] has joined #bitcoin-core-dev
06:10 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/]
06:16 < provoostenator> Two new RPC methods probably ready, but awaiting a little more review love #14667 & #15226
06:16 < gribble> https://github.com/bitcoin/bitcoin/issues/14667 | Add deriveaddresses RPC util method by Sjors · Pull Request #14667 · bitcoin/bitcoin · GitHub
06:16 < gribble> https://github.com/bitcoin/bitcoin/issues/15226 | Allow creating blank (empty) wallets (alternative) by achow101 · Pull Request #15226 · bitcoin/bitcoin · GitHub
06:17 < instagibbs> well, if we're letting a pure utility function in, I'll review...
06:23 < provoostenator> There was some general discussion about that. There's not really a safe alternative for deriveaddresses, because you'd have to implement descriptors. At least until we figure out how to properly library-ify the codebase. 
06:24 < provoostenator> Longer term though: #14671
06:24 < gribble> https://github.com/bitcoin/bitcoin/issues/14671 | Utility to replace RPC calls that dont need wallet or chain context · Issue #14671 · bitcoin/bitcoin · GitHub
06:35 < luke-jr> dunno if it's worth finishing up, but at least as an example of a way to do a non-fork blockchain feature: https://github.com/bitcoin/bitcoin/compare/v0.17.1…luke-jr:extra_weight
06:35 < luke-jr> ugh, elipsis collapsed..
06:36 < luke-jr> dunno if it's worth finishing up, but at least as an example of a way to do a non-fork blockchain feature: https://github.com/bitcoin/bitcoin/compare/v0.17.1...luke-jr:extra_weight
06:36 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has quit [Remote host closed the connection]
06:39 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has joined #bitcoin-core-dev
07:08 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit []
07:10 -!- darosior [25adb966@gateway/web/freenode/ip.37.173.185.102] has quit [Ping timeout: 256 seconds]
07:15 < wumpus> some of the PRs in the 0.18 tag haven't been active for ages (#7949, #9502), might be better to remove them?
07:15 < gribble> https://github.com/bitcoin/bitcoin/issues/7949 | [RPC] Add RPC long poll notifications by jonasschnelli · Pull Request #7949 · bitcoin/bitcoin · GitHub
07:15 < gribble> https://github.com/bitcoin/bitcoin/issues/9502 | [Qt] Add option to pause/resume block downloads by jonasschnelli · Pull Request #9502 · bitcoin/bitcoin · GitHub
07:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:21 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #15354: doc: Add missing bitcoin-wallet tool manpages (master...Mf1902-docWalletTool) https://github.com/bitcoin/bitcoin/pull/15354
07:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:22 < sdaftuar> does anyone look at appveyor failures?
07:22 < wumpus> you mean, in general?
07:22 < sdaftuar> yeah
07:22 < wumpus> we do try to have both appveyor and travis pass before merging
07:23 < sdaftuar> ok... i can try to debug then. seems like it fails randomly so wasn't sure how to treat failures on a PR
07:23 < wumpus> is there a problem with that at the moment?
07:23 < wumpus> yea two CI's is double the chance of random failures, unfortunately
07:24 < sdaftuar> i haven't tried to do any debugging yet, i'll see if i can track it down
07:24 -!- Randolf [~randolf@96.53.47.38] has joined #bitcoin-core-dev
07:28 < wumpus> ok let me know if you'd like me to have a look
07:29 < luke-jr> it'd be nice if a failure popped up a console on the dev's screen to debug :P
07:29 < wumpus> oh yes
07:30 < wumpus> interactive debug that would be a great feature
07:32 < instagibbs> I've previously tried to get travis to cough up a core dump on various kinds of errors, was unable to
07:32 < wumpus> much more efficient than trying to reproduce the exact environment locally (for appveyor that isn't even an option for me I don't have windows)
07:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:32 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/5029e94f855c...645a1264f336
07:32 < bitcoin-git> bitcoin/master 7fdb92e OverlordQ: Update linearize-hashes.py
07:33 < bitcoin-git> bitcoin/master 645a126 MarcoFalke: Merge #15351: Update linearize-hashes.py
07:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:33 < wumpus> "Update linearize-hashes.py" that's a terrible PR title
07:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:33 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15351: Update linearize-hashes.py (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15351
07:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:34 < luke-jr> wumpus: re status of #13339 there's quite a few unresolved issues; I have an older version I use in Knots that ignores the escaping issue entirely, but it seemed like people didn't like that
07:34 < gribble> https://github.com/bitcoin/bitcoin/issues/13339 | wallet: Replace %w by wallet name in -walletnotify script by promag · Pull Request #13339 · bitcoin/bitcoin · GitHub
07:34 -!- kexkey [~kexkey@68.168.122.228] has joined #bitcoin-core-dev
07:35 < luke-jr> (the current PR has copyrighted code that isn't licensed for redistribution)
07:36 < Randolf> That could be a big problem.  Whoops!
07:36 < wumpus> ok, removiing it from the tag then
07:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:37 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/645a1264f336...ddae781a0cc1
07:37 < bitcoin-git> bitcoin/master fa1db33 MarcoFalke: travis: Only exit early if compilation took longer than 30 min
07:37 < bitcoin-git> bitcoin/master ddae781 MarcoFalke: Merge #15349: travis: Only exit early if compilation took longer than 30 m...
07:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:37 < wumpus> (this doesn't mean it can't still make 0.18, but I don't think it makes sense to prioritize it for review as it is)
07:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:38 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15349: travis: Only exit early if compilation took longer than 30 min (master...Mf1902-travis30) https://github.com/bitcoin/bitcoin/pull/15349
07:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:38 < wumpus> luke-jr: I'm surprised and shocked that escaping turns out to be so difficult
07:40 < wumpus> I used to think it was simply replacing ' by '\''  and surrounding by single quotes
07:41 < wumpus> though usually it's preferable to avoid it entirely by not going through the shell and passing the arguments one-to-one directly to execv() etc
07:42 -!- michaelsdunn1 [~michaelsd@38.126.31.226] has joined #bitcoin-core-dev
07:42 -!- michaelsdunn1 [~michaelsd@38.126.31.226] has quit [Changing host]
07:42 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev
07:43 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
07:43 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Client Quit]
07:50 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
07:51 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Client Quit]
07:54 < luke-jr> wumpus: that works fine on *nix, just not Windows
07:54 < luke-jr> wumpus: on Windows, the command line is passed as one big string to the program, and the program decides how to parse it
07:55 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
07:58 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev
08:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:01 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/ddae781a0cc1...12a910c9435c
08:01 < bitcoin-git> bitcoin/master 7bb45e4 Jonas Schnelli: Qt: update header count regardless of update delay
08:01 < bitcoin-git> bitcoin/master e8db6b8 Jonas Schnelli: Qt: Fix update headers-count
08:01 < bitcoin-git> bitcoin/master 12a910c Wladimir J. van der Laan: Merge #15091: GUI: fix model overlay header sync
08:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:01 < bitcoin-git> [bitcoin] laanwj merged pull request #15091: GUI: fix model overlay header sync (master...2019/01/qt_fix_modal) https://github.com/bitcoin/bitcoin/pull/15091
08:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:04 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
08:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:21 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/12a910c9435c...1a6036978e9d
08:21 < bitcoin-git> bitcoin/master fa0fe3b MarcoFalke: contrib: Add missing wallet tool to gen-manpages.sh
08:21 < bitcoin-git> bitcoin/master fa1e281 MarcoFalke: doc: Add missing wallet-tool manpages
08:21 < bitcoin-git> bitcoin/master 1a60369 MarcoFalke: Merge #15354: doc: Add missing bitcoin-wallet tool manpages
08:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:22 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15354: doc: Add missing bitcoin-wallet tool manpages (master...Mf1902-docWalletTool) https://github.com/bitcoin/bitcoin/pull/15354
08:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:25 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection]
08:41 -!- Randolf [~randolf@96.53.47.38] has quit [Quit: Leaving]
09:12 -!- skyikot [~skyikot@gateway/tor-sasl/skyikot] has joined #bitcoin-core-dev
09:33 < sdaftuar> wumpus: fyi one of the appveyor test failures we regularly see is due to an actual test bug, i'll PR something soon
09:37 -!- iimatey [~iimatey@cpe-24-193-26-188.nyc.res.rr.com] has joined #bitcoin-core-dev
09:46 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
10:02 -!- volkov [~volkov@gateway/tor-sasl/volkov] has joined #bitcoin-core-dev
10:05 -!- kexkey [~kexkey@68.168.122.228] has quit [Quit: Scaling pentatonically]
10:07 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
10:10 -!- volkov [~volkov@gateway/tor-sasl/volkov] has quit [Remote host closed the connection]
10:16 < wumpus> sdaftuar: thanks !
10:21 -!- jtimon [~quassel@92.28.134.37.dynamic.jazztel.es] has quit [Ping timeout: 240 seconds]
10:27 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev
10:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:29 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/1a6036978e9d...5cdb82111cc1
10:29 < bitcoin-git> bitcoin/master fa2a69f practicalswift: doc: Add cs_main lock annotations for mapBlockIndex
10:29 < bitcoin-git> bitcoin/master 5cdb821 MarcoFalke: Merge #15321: doc: Add cs_main lock annotations for mapBlockIndex
10:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:30 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15321: doc: Add cs_main lock annotations for mapBlockIndex (master...Mf1902-docLoc) https://github.com/bitcoin/bitcoin/pull/15321
10:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:31 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Ping timeout: 240 seconds]
10:33 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
10:33 -!- ajonas_ [6baae9a8@gateway/web/freenode/ip.107.170.233.168] has joined #bitcoin-core-dev
10:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:47 < bitcoin-git> [bitcoin] JBaczuk opened pull request #15357: Move maxTxFee initialization to init.cpp (master...fix_maxtxfee) https://github.com/bitcoin/bitcoin/pull/15357
10:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:47 -!- iimatey [~iimatey@cpe-24-193-26-188.nyc.res.rr.com] has quit [Quit: iimatey]
10:48 -!- kexkey [~kexkey@68.168.122.228] has joined #bitcoin-core-dev
10:51 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
10:51 -!- kexkey [~kexkey@68.168.122.228] has quit [Read error: Connection reset by peer]
10:51 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
10:55 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 245 seconds]
10:57 -!- iimatey [~iimatey@207.41.188.213] has joined #bitcoin-core-dev
11:00 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.3]
11:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:02 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #15358: util: Add SetupHelpOptions() (master...Mf1902-Help) https://github.com/bitcoin/bitcoin/pull/15358
11:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:04 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.]
11:05 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
11:06 -!- diego4 [~diego@179.235.26.181] has joined #bitcoin-core-dev
11:06 -!- diego4 [~diego@179.235.26.181] has left #bitcoin-core-dev []
11:07 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-nxnscjygbipdjqno] has quit [Quit: Connection closed for inactivity]
11:07 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
11:13 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev
11:14 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit []
11:25 -!- twistedline [~quassel@unaffiliated/twistedline] has quit [Remote host closed the connection]
11:47 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection]
11:48 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev
11:48 -!- ajonas_ [6baae9a8@gateway/web/freenode/ip.107.170.233.168] has quit [Ping timeout: 256 seconds]
11:54 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
11:55 < promag> sdaftuar: please include #15350 in your branch and see if it fixes the slow down
11:55 < gribble> https://github.com/bitcoin/bitcoin/issues/15350 | qa: Drop RPC connection if --usecli by promag · Pull Request #15350 · bitcoin/bitcoin · GitHub
11:57 -!- riemann [~riemann@217.96.161.124.ipv4.supernova.orange.pl] has joined #bitcoin-core-dev
12:11 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Read error: Connection reset by peer]
12:12 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
12:28 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection]
12:29 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
12:30 -!- twistedline [~quassel@unaffiliated/twistedline] has joined #bitcoin-core-dev
12:30 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev
12:36 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection]
12:39 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.]
12:43 -!- jtimon [~quassel@92.28.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev
12:43 < kewde[m]> https://github.com/bitcoin/bitcoin/blob/6e6b3b944d12a252a0fd9a1d68fec9843dd5b4f8/src/random.h#L162
12:44 < kewde[m]> randrange(0) -> wraps around and caused our tests to hang for a while :P (found by @tecnovert)
12:47 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection]
12:47 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev
12:48 < kewde[m]> 0 is a nonsensical value to enter, but our test suite sometimes found itself in that situation and created some interesting fireworks..
12:48 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
12:52 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection]
12:52 < gmaxwell> kewde[m]: I'm not sure of the purpose of your report.
12:52 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Ping timeout: 240 seconds]
12:52 < gmaxwell> If there was any place in the codebase where it could be called with 0 that would be a bug.
12:52 < gmaxwell> But AFAIK there is not.
12:52 < gmaxwell> so it just sounds like your test suite is broken.
12:52 < sipa> we can document the precondition range>0
12:52 < sipa> but otherwise i don't see what needs to be done
12:53 < gmaxwell> hm. did we have clearer docs on another one? I thought we did.
12:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:53 < bitcoin-git> [bitcoin] kewde opened pull request #15359: Prevent undefined behavior of randrange() (@tecnovert) (master...patch-2) https://github.com/bitcoin/bitcoin/pull/15359
12:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:53 < gmaxwell> That isn't undefined behavior.
12:54 < sipa> does it go into an infinite loop? (if so, that's technically UB)
12:56 < gmaxwell> it's not an infinite loop, technically. :) 
12:56 < kewde[m]> It caused weird behavior when the value was used afterwards, anyways, it returned a value that was out of the max of the range became 0xFFFFFFFFFFFFFFFF.
12:58 < sipa> well you're using the function wrong
12:58 < gmaxwell> If it were to change at all, it should change to assert. But considering randrange gets used in innerloops and whatnot, I'm dubious of the value of that tradeoff.
12:58 < sipa> returning 0 is equally invalid, as it's outside of the range [0, 0)
13:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:02 < bitcoin-git> [bitcoin] kewde closed pull request #15359: Add zero check to randrange() (@tecnovert) (master...patch-2) https://github.com/bitcoin/bitcoin/pull/15359
13:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:03 < kewde[m]> Yeah makes sense, I didn't spot the ) bracket at the end. I just thought I'd make a note of it, it was interesting bug we had.
13:03 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
13:06 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev
13:08 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
13:09 -!- jtimon [~quassel@92.28.134.37.dynamic.jazztel.es] has quit [Quit: gone]
13:09 -!- jtimon [~quassel@92.28.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev
13:12 -!- iimatey [~iimatey@207.41.188.213] has quit [Quit: iimatey]
13:14 -!- iimatey [~iimatey@207.41.188.213] has joined #bitcoin-core-dev
13:14 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
13:16 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
13:17 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
13:18 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
13:21 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection]
13:23 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
13:29 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
13:33 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds]
13:36 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.3]
13:43 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
13:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:48 < bitcoin-git> [bitcoin] laanwj pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/5cdb82111cc1...72d34c0edc5a
13:48 < bitcoin-git> bitcoin/master 6180b5f Carl Dong: netaddress: Fix indentation in IsLocal
13:48 < bitcoin-git> bitcoin/master 87aa0b4 Carl Dong: netaddress: Make IPv4 loopback comment more descriptive
13:48 < bitcoin-git> bitcoin/master 72d34c0 Wladimir J. van der Laan: Merge #15343: [doc] netaddress: Make IPv4 loopback comment more descriptiv...
13:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:48 < bitcoin-git> [bitcoin] laanwj merged pull request #15343: [doc] netaddress: Make IPv4 loopback comment more descriptive (master...2019-02-islocal-clarify) https://github.com/bitcoin/bitcoin/pull/15343
13:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:04 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds]
14:18 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
14:23 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
14:27 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 245 seconds]
14:31 -!- iimatey [~iimatey@207.41.188.213] has quit [Quit: iimatey]
14:34 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
14:42 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.]
14:45 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
15:05 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.]
15:19 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!]
15:19 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 246 seconds]
15:25 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection]
15:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
15:29 < bitcoin-git> [bitcoin] sdaftuar opened pull request #15360: [qa] Create cached blocks with current timestamps (master...2019-01-debug-appveyor) https://github.com/bitcoin/bitcoin/pull/15360
15:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
15:32 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection]
16:06 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
16:16 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has left #bitcoin-core-dev []
16:17 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
16:23 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
16:24 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
16:24 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
16:59 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
17:03 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
17:13 -!- Jamesorty [~Jamesorty@136.0.0.156] has joined #bitcoin-core-dev
17:13 -!- Jamesorty [~Jamesorty@136.0.0.156] has left #bitcoin-core-dev []
17:19 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
17:38 -!- rhavar_ [uid237883@gateway/web/irccloud.com/x-fgjvcpdlzsympxmk] has joined #bitcoin-core-dev
17:47 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
17:53 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
17:53 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.]
17:54 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 250 seconds]
18:08 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
18:48 -!- skyikot [~skyikot@gateway/tor-sasl/skyikot] has quit [Quit: skyikot]
18:50 -!- ap4lmtree- [~ap4lmtree@unaffiliated/ap4lmtree] has joined #bitcoin-core-dev
18:53 -!- harrymm [~harrymm@69.161.195.103] has joined #bitcoin-core-dev
18:53 -!- ap4lmtree [~ap4lmtree@unaffiliated/ap4lmtree] has quit [Ping timeout: 245 seconds]
19:08 -!- ogru [~ogru@103.25.59.92] has joined #bitcoin-core-dev
19:08 -!- ogru [~ogru@103.25.59.92] has left #bitcoin-core-dev []
19:20 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has quit [Quit: drexl]
19:27 -!- skyikot [~skyikot@gateway/tor-sasl/skyikot] has joined #bitcoin-core-dev
19:28 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
19:34 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.]
19:35 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
19:36 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Client Quit]
19:39 -!- Dienqeall [~Dienqeall@103.25.59.94] has joined #bitcoin-core-dev
19:39 -!- Dienqeall [~Dienqeall@103.25.59.94] has left #bitcoin-core-dev []
19:42 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Ping timeout: 250 seconds]
19:49 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection]
19:50 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev
19:51 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
19:52 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
19:57 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 268 seconds]
19:58 -!- instagibbs [~instagibb@pool-100-15-135-248.washdc.fios.verizon.net] has quit [Ping timeout: 245 seconds]
19:59 -!- ap4lmtree- is now known as ap4lmtree
20:00 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Ping timeout: 240 seconds]
20:02 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
20:02 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has quit [Ping timeout: 272 seconds]
20:07 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 256 seconds]
20:08 -!- ddustin_ [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
20:11 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 250 seconds]
20:11 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
20:31 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
20:44 -!- volkov [~volkov@gateway/tor-sasl/volkov] has joined #bitcoin-core-dev
20:50 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
21:03 -!- ddustin_ [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection]
21:04 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
21:08 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 240 seconds]
21:37 -!- skyikot [~skyikot@gateway/tor-sasl/skyikot] has quit [Quit: skyikot]
21:45 -!- ap4lmtree [~ap4lmtree@unaffiliated/ap4lmtree] has quit [Read error: Connection reset by peer]
21:52 -!- ap4lmtree [~ap4lmtree@unaffiliated/ap4lmtree] has joined #bitcoin-core-dev
21:53 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
21:58 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 240 seconds]
21:59 -!- Xianglo [~Mutter@c-73-176-70-46.hsd1.in.comcast.net] has joined #bitcoin-core-dev
22:09 -!- Xianglo [~Mutter@c-73-176-70-46.hsd1.in.comcast.net] has quit [Quit: Mutter: www.mutterirc.com]
22:13 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has quit [Remote host closed the connection]
22:14 -!- StopAndDecrypt [~StopAndDe@pool-141-155-179-159.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
22:14 -!- StopAndDecrypt [~StopAndDe@pool-141-155-179-159.nycmny.fios.verizon.net] has quit [Changing host]
22:14 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has joined #bitcoin-core-dev
22:54 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
23:13 -!- Xianglo [~Mutter@c-73-176-70-46.hsd1.in.comcast.net] has joined #bitcoin-core-dev
23:14 -!- ctrlbreak [~ctrlbreak@142.162.20.53] has quit [Read error: Connection reset by peer]
23:14 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
23:14 -!- ctrlbreak [~ctrlbreak@142.162.20.53] has joined #bitcoin-core-dev
23:15 -!- Xianglo [~Mutter@c-73-176-70-46.hsd1.in.comcast.net] has quit [Client Quit]
23:16 -!- Jackielove4u [uid43977@gateway/web/irccloud.com/x-iaxmmyzffhbxzweh] has quit [Quit: Connection closed for inactivity]
23:17 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev
23:25 -!- Xianglo [~Mutter@c-73-176-70-46.hsd1.in.comcast.net] has joined #bitcoin-core-dev
23:25 -!- Xianglo [~Mutter@c-73-176-70-46.hsd1.in.comcast.net] has quit [Remote host closed the connection]
23:25 -!- Xianglo [~Mutter@104.200.153.113] has joined #bitcoin-core-dev
23:27 -!- Xianglo [~Mutter@104.200.153.113] has quit [Client Quit]
23:31 -!- darosior [25ab0419@gateway/web/freenode/ip.37.171.4.25] has joined #bitcoin-core-dev
23:37 -!- Jackielove4u [uid43977@gateway/web/irccloud.com/x-wneuwupisdglklys] has joined #bitcoin-core-dev
23:52 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has quit [Ping timeout: 264 seconds]
23:53 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
--- Log closed Thu Feb 07 00:00:42 2019