--- Log opened Thu Feb 07 00:00:42 2019 00:03 -!- ctrlbreak_MAD [~ctrlbreak@142.162.20.53] has joined #bitcoin-core-dev 00:07 -!- ctrlbreak [~ctrlbreak@142.162.20.53] has quit [Ping timeout: 245 seconds] 00:39 -!- niu [~Mutter@123.180.195.4] has joined #bitcoin-core-dev 00:44 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has joined #bitcoin-core-dev 00:46 -!- niu [~Mutter@123.180.195.4] has quit [Ping timeout: 250 seconds] 00:57 -!- darosior [25ab0419@gateway/web/freenode/ip.37.171.4.25] has quit [Ping timeout: 256 seconds] 00:59 -!- volkov [~volkov@gateway/tor-sasl/volkov] has quit [Quit: volkov] 01:00 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 01:06 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 01:10 -!- Murch [~murch@c-73-223-113-121.hsd1.ca.comcast.net] has quit [Quit: Snoozing.] 01:12 -!- darosior [25ab0419@gateway/web/freenode/ip.37.171.4.25] has joined #bitcoin-core-dev 01:14 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has quit [Ping timeout: 264 seconds] 01:16 -!- darosior [25ab0419@gateway/web/freenode/ip.37.171.4.25] has quit [Ping timeout: 256 seconds] 01:17 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection] 01:18 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 01:23 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 268 seconds] 01:36 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has joined #bitcoin-core-dev 01:37 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev 01:39 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev 01:41 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev 01:42 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:49 -!- jtimon [~quassel@92.28.134.37.dynamic.jazztel.es] has quit [Ping timeout: 272 seconds] 01:55 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 02:01 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds] 02:07 < gwillen> ... why does the test runner keep logs in files named "test_runner_鈧縚馃弮_...", with a unicode bitcoin sign and a unicode running-man emoji 02:13 < echeveria> gwillen: to check if your filesystem supports UTF characters. 02:27 -!- rhavar_ [uid237883@gateway/web/irccloud.com/x-fgjvcpdlzsympxmk] has quit [Quit: Connection closed for inactivity] 02:35 < phwalkr> Is it possible/common to build a transaction with inputs of different types? I mean, one p2sh input, one p2pkh input and so on 02:36 < echeveria> phwalkr: this is normal. more a question for #bitcoin. 02:37 < phwalkr> echeveria: Sorry about that. And thank you for answering it! 02:38 < warren> I've noticed in recent years that the download size savings of .drpm vs .rpm is only a small % these days. I wonder if something about builds containing randomization makes the delta between before and after much larger than it used to years ago. In most cases it's faster to turn off deltarpm entirely. 02:42 < Lauda> Has anyone encountered the following error during building depends for winx64 on Ubuntu 16 (0.17.1 tag)? 02:42 < Lauda> "qwin10helpers.cpp:60:37: fatal error: uiviewsettingsinterop.h: No such file or directory" 02:44 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer] 02:45 < warren> oops wrong channel sorry 02:46 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 02:50 -!- oneark [uid254801@gateway/web/irccloud.com/x-mxhqsablhpcmciwm] has joined #bitcoin-core-dev 02:54 < Lauda> qt 5.9.6 is where it fails if I'm reading this correctly 02:56 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 02:59 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 240 seconds] 03:02 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 03:17 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 03:30 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:30 < luke-jr> [10:13:01] gwillen: to check if your filesystem supports UTF characters. <-- rather, to check that the Bitcoin Core code correctly handles the unicode 03:45 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has joined #bitcoin-core-dev 03:59 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 04:09 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 04:34 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 250 seconds] 05:10 -!- shesek [~shesek@31.210.189.77] has joined #bitcoin-core-dev 05:10 -!- cubancorona [cubancoron@gateway/vpn/privateinternetaccess/cubancorona] has joined #bitcoin-core-dev 05:10 -!- shesek [~shesek@31.210.189.77] has quit [Changing host] 05:10 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 05:22 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [] 05:37 -!- brianhoffman [~brianhoff@pool-72-83-155-130.washdc.fios.verizon.net] has quit [Ping timeout: 240 seconds] 05:38 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection] 05:41 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 240 seconds] 05:48 -!- instagibbs [~instagibb@pool-100-15-135-248.washdc.fios.verizon.net] has joined #bitcoin-core-dev 06:04 -!- IGHOR [~quassel@93.178.216.72] has quit [Ping timeout: 268 seconds] 06:07 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 06:11 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Ping timeout: 244 seconds] 06:14 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev 06:16 -!- mistergold [~mistergol@37.19.107.136] has joined #bitcoin-core-dev 06:20 -!- riemann_ [~riemann@217.96.148.26.ipv4.supernova.orange.pl] has joined #bitcoin-core-dev 06:23 -!- riemann [~riemann@217.96.161.124.ipv4.supernova.orange.pl] has quit [Ping timeout: 250 seconds] 06:26 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 06:28 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has joined #bitcoin-core-dev 06:30 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 06:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:35 < bitcoin-git> [bitcoin] promag opened pull request #15363: http: Exit the event loop as soon as there are no active events (master...2019-01-loopexit) https://github.com/bitcoin/bitcoin/pull/15363 06:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:37 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds] 06:38 -!- bralyclow [bralyclow@gateway/vpn/protonvpn/bralyclow] has joined #bitcoin-core-dev 06:39 < promag> sdaftuar: with the above your new test runs in 3 sec 06:51 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 06:59 < promag> provoostenator: ping 07:06 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 07:07 < nsh> strange question but 07:08 < nsh> what's the minimum number of chars for a brain wallet passphrase for a btc privkey? 07:08 < nsh> ideally something that i can spell out with the pieces of a standard scrabble board 07:08 < nsh> (sorry meant to ask next-door) 07:16 -!- volkov [~volkov@gateway/tor-sasl/volkov] has joined #bitcoin-core-dev 07:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:18 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/72d34c0edc5a...d83d6079432c 07:18 < bitcoin-git> bitcoin/master 6440e61 Jo茫o Barbosa: qa: Drop RPC connection if --usecli 07:18 < bitcoin-git> bitcoin/master d83d607 MarcoFalke: Merge #15350: qa: Drop RPC connection if --usecli 07:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:19 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15350: qa: Drop RPC connection if --usecli (master...2019-01-fixusecli) https://github.com/bitcoin/bitcoin/pull/15350 07:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:19 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 07:25 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 07:30 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Client Quit] 07:31 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 07:39 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection] 07:40 -!- volkov [~volkov@gateway/tor-sasl/volkov] has quit [Remote host closed the connection] 07:41 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev 07:47 -!- hebasto [~hebasto@95.164.65.194] has quit [Ping timeout: 240 seconds] 07:54 -!- bralyclo_ [bralyclow@gateway/vpn/protonvpn/bralyclow] has joined #bitcoin-core-dev 07:58 -!- bralyclow [bralyclow@gateway/vpn/protonvpn/bralyclow] has quit [Ping timeout: 252 seconds] 08:04 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 08:21 -!- jtimon [~quassel@92.28.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 08:33 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has quit [Ping timeout: 244 seconds] 08:37 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 250 seconds] 08:40 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection] 08:43 -!- emilr [~emilr@unaffiliated/goregrind] has quit [Read error: Connection reset by peer] 08:43 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 08:57 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 08:59 -!- IGHOR [~quassel@93.178.216.72] has joined #bitcoin-core-dev 09:02 -!- fan_of_defi [d062ccda@gateway/web/freenode/ip.208.98.204.218] has joined #bitcoin-core-dev 09:09 -!- afk11 [~afk11@unaffiliated/afk11] has joined #bitcoin-core-dev 09:13 -!- bralyclo_ [bralyclow@gateway/vpn/protonvpn/bralyclow] has quit [] 09:15 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev 09:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:26 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #15364: qa: Fix race in feature_notifications (master...Mf1902-qaNotifRace) https://github.com/bitcoin/bitcoin/pull/15364 09:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:27 -!- fan_of_defi [d062ccda@gateway/web/freenode/ip.208.98.204.218] has quit [Quit: Page closed] 09:33 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 09:34 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 09:37 -!- oneark [uid254801@gateway/web/irccloud.com/x-mxhqsablhpcmciwm] has quit [Quit: Connection closed for inactivity] 09:44 -!- mistergold [~mistergol@37.19.107.136] has quit [Read error: Connection reset by peer] 09:59 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 10:00 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Ping timeout: 245 seconds] 10:01 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Ping timeout: 272 seconds] 10:02 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 10:05 -!- emilr [~emilr@unaffiliated/goregrind] has joined #bitcoin-core-dev 10:07 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 10:07 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Client Quit] 10:08 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 10:17 -!- riemann_ [~riemann@217.96.148.26.ipv4.supernova.orange.pl] has quit [Ping timeout: 245 seconds] 10:20 -!- kexkey [~kexkey@68.168.122.228] has joined #bitcoin-core-dev 10:24 -!- profmac [~ProfMac@2001:470:1f0f:226:a5b5:59ff:ca9e:e646] has quit [Ping timeout: 240 seconds] 10:28 -!- profmac [~ProfMac@2001:470:1f0f:226:21cb:a56c:746:977f] has joined #bitcoin-core-dev 10:29 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 10:30 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 10:31 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Client Quit] 10:32 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has joined #bitcoin-core-dev 10:33 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 10:33 -!- wale2r [~wale2r@196.188.191.6] has joined #bitcoin-core-dev 10:34 -!- wale2r [~wale2r@196.188.191.6] has quit [Client Quit] 10:43 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 10:45 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 240 seconds] 10:50 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 10:52 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 10:59 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [] 11:00 < achow101> meeting? 11:01 < luke-jr> .. 11:01 < wumpus> #startmeeting 11:01 < lightningbot> Meeting started Thu Feb 7 19:01:27 2019 UTC. The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot. 11:01 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic. 11:01 < jnewbery> hi 11:01 < jonasschnelli> hi 11:01 < wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb 11:01 < achow101> hi 11:01 < gkrizek> hi 11:02 < gwillen> buenos dias 11:02 < luke-jr> wat 11:02 < jamesob> hi 11:02 < wumpus> PSA feature freeze for 0.18 is next week #14438 11:02 < gribble> https://github.com/bitcoin/bitcoin/issues/14438 | Release schedule for 0.18.0 路 Issue #14438 路 bitcoin/bitcoin 路 GitHub 11:03 < wumpus> probably makes sense to discuss what will be ready for merge this week, as that should be prioritized for review 11:03 < promag> hi 11:03 < moneyball> hi - no proposedtopics from the week 11:03 < wumpus> moneyball: thanks 11:04 < instagibbs> hi 11:04 < dongcarl> #14856 has had lots of review 11:04 < wumpus> #topic 0.18 last-minute features 11:04 < gribble> https://github.com/bitcoin/bitcoin/issues/14856 | net: remove more CConnman globals (theuni) by dongcarl 路 Pull Request #14856 路 bitcoin/bitcoin 路 GitHub 11:04 < jtimon> hi 11:04 < wumpus> dongcarl: that's not a feature tho 11:04 * dongcarl ducks 11:04 < dongcarl> true 11:05 < wumpus> so there's some feature PRs both in the 0.18.0 tag and high priority for review 11:05 < wumpus> https://github.com/bitcoin/bitcoin/pulls?q=is%3Aopen+is%3Apr+project%3Abitcoin%2Fbitcoin%2F8 11:05 < wumpus> https://github.com/bitcoin/bitcoin/pulls?q=is%3Aopen+is%3Apr+milestone%3A0.18.0 11:06 < wumpus> I guess most are related to the wallet 11:06 < wumpus> and the importmulti descriptor imports 11:06 < wumpus> oh ofc that's wallet too :< 11:06 < luke-jr> XD 11:06 < achow101> it would be nice for that to be merged. and blank wallets 11:07 < wumpus> so yes, wallet, what will be ready for merge this week? maybe you can weigh in meshcollider? 11:08 < wumpus> i see #15153 has a tested ACK 11:08 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 11:08 < gribble> https://github.com/bitcoin/bitcoin/issues/15153 | gui: Add Open Wallet menu by promag 路 Pull Request #15153 路 bitcoin/bitcoin 路 GitHub 11:09 < wumpus> #15226 too 11:09 < gribble> https://github.com/bitcoin/bitcoin/issues/15226 | Allow creating blank (empty) wallets (alternative) by achow101 路 Pull Request #15226 路 bitcoin/bitcoin 路 GitHub 11:09 < wumpus> so I suppose they can be merged soon 11:10 < wumpus> #14491 even seems ready for merge 11:10 < phantomcircuit> hi 11:10 < gribble> https://github.com/bitcoin/bitcoin/issues/14491 | Allow descriptor imports with importmulti by MeshCollider 路 Pull Request #14491 路 bitcoin/bitcoin 路 GitHub 11:11 < wumpus> #action review last-minute wallet feature PRs for 0.18 11:12 < promag> if 15153 goes then #15195 and #15204 should probably go too - but these are simpler 11:12 < gribble> https://github.com/bitcoin/bitcoin/issues/15195 | gui: Add Close Wallet action by promag 路 Pull Request #15195 路 bitcoin/bitcoin 路 GitHub 11:13 < gribble> https://github.com/bitcoin/bitcoin/issues/15204 | gui: Add Open External Wallet action by promag 路 Pull Request #15204 路 bitcoin/bitcoin 路 GitHub 11:13 < wumpus> that's a lot for one week 11:14 < wumpus> but we'll see I guess... 11:14 < wumpus> any other topics? 11:14 < gmaxwell> (Hi) 11:15 < wumpus> (hi!) 11:15 < luke-jr> should I close https://github.com/bitcoin-core/bitcoincore.org/pull/637, or do we still want to do something for that? 11:15 < wumpus> #topic Advisory and full disclosure for CVE-2018-20587 on bitcoincore.org 11:16 < meshcollider> hi 11:16 < wumpus> looks like the PR is somewhat controversial 11:16 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 11:16 < gmaxwell> that seems weird to me. 11:17 < gmaxwell> it's an absurdly narrow corner case, not some major concern. it should get release notes. 11:17 < luke-jr> well, there's no fix in Core, so release notes don't really make sense 11:17 < luke-jr> some docs were updated tho 11:17 < wumpus> I tend to agree with harding though "I'm a fan of updating the documentation in the Bitcoin Core docs/ directory and putting something into the release notes instead of publishing a long blog post that basically says that using a computer not under your exclusive control is unsafe" 11:17 < sipa> hi! 11:17 < gmaxwell> requires an attacker on your local host, which 99.99999% of the time means you are boned anyways. 11:18 * jonasschnelli does also agree with harding 11:18 < luke-jr> gmaxwell: the attacker could be another unprivileged user 11:18 < gmaxwell> and it's also a 'vulnerablity' that is shared by virtually every other piece of software with an rpc on a non-privledged port. 11:18 < wumpus> gmaxwell: especially for the kind of environments that users that don't know this run 11:18 < luke-jr> (FWIW, #15223 is the doc/ updates) 11:18 < gribble> https://github.com/bitcoin/bitcoin/issues/15223 | Doc: add information about security to the JSON-RPC doc by harding 路 Pull Request #15223 路 bitcoin/bitcoin 路 GitHub 11:18 < wumpus> e.g. if you're on windows and run everything as the same user anyhow then someone can just as well install a keylogger 11:18 < gmaxwell> luke-jr: yes but almost all the time multiuser OSes are vulnerable to one priv esc vuln or another. 11:19 < luke-jr> gmaxwell: not really, many things fail if they can't bind 11:19 < luke-jr> (I haven't had any negative reports from the fix in Knots, maybe I should PR that) 11:19 < gmaxwell> luke-jr: failing if you don't bind doesn't actually eliminate the vulnerablity here, just makes you more likely to notice (esp after you're screwed). 11:20 < gmaxwell> (and 'more' but not by much) 11:20 < luke-jr> gmaxwell: if you don't notice prior to the attack, at most they can get the walletpassphrase, which isn't a big problem if the wallet file is inaccessible 11:20 < wumpus> using a unix socket would eliminate the vulnerability but I think we've been through this 11:20 < gmaxwell> A real fix would be mutual auth and or using a unix domain socket. 11:21 < luke-jr> (with a bind=>failure fix) 11:21 < luke-jr> gmaxwell: I'm not sure most JSON-RPC libraries can support those 11:22 < wumpus> which would be nice, but I don't think there's anything new to discuss in that regard, there's still the libevent server crap 11:22 < wumpus> +http 11:22 < gmaxwell> luke-jr: the way you'd do the attack is start a process that binds in a tight loop until it gets it. then when it gets it it listens for a walletpassphrase then shuts off. What the user will is is that their daemon crashed, and they'll restart it before digging through the logs with almost certanty. 11:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:22 < bitcoin-git> [bitcoin] MeshCollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/d83d6079432c...1933e38c1a08 11:22 < bitcoin-git> bitcoin/master 5952838 Sjors Provoost: [rpc] util: add deriveaddresses method 11:22 < bitcoin-git> bitcoin/master 1933e38 MeshCollider: Merge #14667: Add deriveaddresses RPC util method 11:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:22 < gmaxwell> luke-jr: indeed, which is another point that essentially everything off a privleged port is similarly 'vulnerable'. 11:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:23 < bitcoin-git> [bitcoin] MeshCollider merged pull request #14667: Add deriveaddresses RPC util method (master...2018/11/deriveaddress) https://github.com/bitcoin/bitcoin/pull/14667 11:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:23 < luke-jr> annoyingly, most OSs doesn't make it practical to reserve ports [privileged or otherwise] for specific users :/ 11:23 < luke-jr> anyway, main question is do we want to do some blog post alerting people to this? or just leave it at a doc/ probably nobody will notice? 11:24 < wumpus> it's possible on linux with iptables IIRC buut I'm not sure we really want to go into that rabbit hole for documentation 11:24 < gmaxwell> the blog post also won't be noticed, plus I'm concerned that its crying wolf -- increasing the profile of minutia. 11:24 < wumpus> I'm also worried of that. 11:24 < wumpus> most people will be able to do exactly nothing with this advisory 11:24 < luke-jr> wumpus: it is? 11:24 < gmaxwell> Like we don't have a blog post warning you about following links or whatever, which is a much greater risk to users than this. 11:25 < wumpus> luke-jr: yes, there's a uid filter 11:25 < luke-jr> okay, sounds like I should just close the PR then and leave it at that 11:25 < wumpus> at least there was back in the day I was still interested in using user ids for separation instead of VMs 11:25 < gmaxwell> If we really wanted a blog post ... maybe instead we should have a blog post about bitcoin wallet security best practices, and this port thing could be mentioned somewhere in it. that would make sense. But alerting on this? I don't think so. 11:25 < luke-jr> wumpus: but that can't block binding afaik? I guess if nobody can connect it's effectively the same.. 11:27 < wumpus> ok, any other topics? 11:27 < sipa> short topic: descriptor checksums 11:27 < wumpus> #topic Descriptor checksums (sipa) 11:27 < sipa> so, this was discussed in the wallet meeting 1 or 2 weeks ago 11:28 < sipa> the idea is that if descriptors are going to be used as import, and to generate addresses, we probably want to protect against typos (or due to length more commonly, copy-paste errors) 11:28 < sipa> and things like keypaths and public keys are quite vulnerable to that 11:28 < wumpus> makes sense 11:29 < luke-jr> I think it might be annoying to have to calculate checksums if you enter a keypath by hand..? 11:29 < jonasschnelli> it may be optional 11:29 < sipa> i have a PR almost ready to add these (will submit today), but since deriveaddress was just merged, i think it would make sense to have these in 0.18 (as it'd otherwise an incompatible change later; scantxoutset doesn't really require checksums) 11:29 < jtimon> oh, there's a wallet meeting? 11:29 < luke-jr> jtimon: same time Friday, every other week 11:29 < jtimon> thanks 11:30 < sipa> i'm just bringing it up as a heads up here; obviously if review doesn't let us get it in 0.18, so be it 11:30 < luke-jr> sipa: will they be optional? 11:30 -!- dqx [~dqx@unaffiliated/dqx] has quit [Ping timeout: 250 seconds] 11:30 < sipa> luke-jr: for RPCs where mistakes aren't critical, yes 11:30 < wumpus> it is very last minute considering there's many other wallet PRs that are tagged 0.18, but sure it'd be nice 11:30 -!- Krellan_ [~Krellan@2601:640:4000:a876:b069:431a:196b:f929] has quit [Ping timeout: 240 seconds] 11:30 < luke-jr> and can you (eg) have checksums on the keys, but not the paths? 11:31 < sipa> no, you'd need a tool or RPC to recompute the checksum 11:31 < luke-jr> :/ 11:31 < sipa> my thinking is that for most things where you're just "playing" with them, they're optional 11:31 < achow101> luke-jr: keys would still be checksummed becaused of base58 11:32 < meshcollider> sipa: how large of a PR is it? 11:32 -!- dqx [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev 11:32 < sipa> meshcollider: not big, very localized 11:32 < meshcollider> thats good, I think we could get it in then 11:32 < wumpus> good, at least it won't interfere with the others then 11:32 < sipa> but when importing (which isn't merged yet), the checksum would be mandatory (or there could be a flag to disable that, if people like that...) 11:33 < meshcollider> is it based on #14491 then? 11:33 < achow101> I think there should be a flag to make them optional 11:33 < gribble> https://github.com/bitcoin/bitcoin/issues/14491 | Allow descriptor imports with importmulti by MeshCollider 路 Pull Request #14491 路 bitcoin/bitcoin 路 GitHub 11:33 < jonasschnelli> skipping the checksum on RPC level is probably acceptable 11:33 < sipa> meshcollider: no, but it'd be a one-line change to integrate 11:33 < meshcollider> awesome 11:33 < luke-jr> almost certainly the response to mandatory checksum will probably be to just calculate it :x 11:33 < luke-jr> probably enough to just make sure if it is present and doesn't match, it fails 11:34 < sipa> luke-jr: that's perhaps true... but it's the best we can do 11:36 < sipa> end topic 11:36 < gwillen> we should avoid ever creating / displaying one without a checksum ourselves 11:36 < sipa> gwillen: yes, my PR adds the checksum in the text serialization code; it's optional just in the parser 11:36 < gwillen> :+1: 11:36 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev 11:37 < sipa> (no point in discussing this here; will open the PR as soon as a few tests are fixed) 11:37 < wumpus> more topics? 11:37 < jl2012> hi 11:38 < jonasschnelli> I have just a little reminder... 11:38 < jl2012> #13360 11:38 < gribble> https://github.com/bitcoin/bitcoin/issues/13360 | [Policy] Reject SIGHASH_SINGLE with output out of bound by jl2012 路 Pull Request #13360 路 bitcoin/bitcoin 路 GitHub 11:38 < jonasschnelli> we should finally add older wallet tests 11:38 < jonasschnelli> with growing states (blank wallets, disable private key, hd non hd) 11:38 < jonasschnelli> I mean function tests that test stuff with wallets from older bitcoin core versions 11:39 < wumpus> #topic old wallet tests 11:39 < jonasschnelli> Or we will certainly break stuff in the near future 11:39 -!- riemann_ [~riemann@217.96.148.26.ipv4.supernova.orange.pl] has joined #bitcoin-core-dev 11:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:39 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #15365: wallet: Add lock annotation for mapAddressBook (master...Mf1902-LockAnnotmapAddressBook) https://github.com/bitcoin/bitcoin/pull/15365 11:39 < jonasschnelli> I think MarcoFalke once made an issue: #14536 11:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 11:39 < gribble> https://github.com/bitcoin/bitcoin/issues/14536 | functional test with ancient wallet.dat (upgrade test) 路 Issue #14536 路 bitcoin/bitcoin 路 GitHub 11:40 -!- riemann_ [~riemann@217.96.148.26.ipv4.supernova.orange.pl] has quit [Remote host closed the connection] 11:41 < jonasschnelli> So if someone is interested to write some tests against older wallets and eventually just use static older wallet files,.... your welcome 11:41 < jonasschnelli> The other route would be compiling older Bitcoin Core versions and use that as base for file interoperability tests (including levelDb upgrades, etc.) 11:41 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 246 seconds] 11:42 < jonasschnelli> sorry,... I meant chainstate database upgrade (not levelDB upgrades) 11:42 < luke-jr> jonasschnelli: that complicates testing, which might be fine for extended tests, but I think wallet tests would be better as an "always run" 11:42 < MarcoFalke> The wallet file could be added to https://github.com/bitcoin-core/qa-assets in case core-repo-bloat is a concern 11:42 < jnewbery> Sjors has a PR for using older versions in testing: #12134 11:42 < gribble> https://github.com/bitcoin/bitcoin/issues/12134 | Build previous releases and run functional tests by Sjors 路 Pull Request #12134 路 bitcoin/bitcoin 路 GitHub 11:42 < luke-jr> I wouldn't think a simple old wallet would be that large 11:43 < jonasschnelli> Probably,... but a couple of older wallet.dats in as test statics would not be completely wrong IMO 11:43 < jnewbery> I think it's a nice idea, but the instability of the interfaces and testing framework means it'll be quite an effort to maintain going forward 11:43 < luke-jr> I guess an ideal test would make an old wallet, load it in a new version, do stuff, then make sure the old version still works 11:43 < luke-jr> but that's getting complex 11:43 < jonasschnelli> I don't care where they are stored but we should finally add tests 11:43 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Remote host closed the connection] 11:44 < jnewbery> I think the idea of having old wallet files in the tests is more maintainable 11:44 < jonasschnelli> luke-jr: thats another tests that would certenly required to compile older version of Core 11:45 < wumpus> I'm not too happy with the idea of adding wallet.dat's to the repository 11:45 -!- watchtower [~watchtowe@pool-96-239-24-37.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 11:45 < MarcoFalke> wumpus: seen my reply above? 11:45 < wumpus> MarcoFalke: no I missed that, :+1: to that 11:46 < jonasschnelli> wumpus: we could rename them to static.dump *duck* 11:46 < gwillen> one could manually construct wallet.dats without keypool for testing, yeah? So they don't need to be very large? 11:46 < gwillen> unless that itself would break or fail to test important stuff. 11:46 < MarcoFalke> I don't think there is anything to discuss here. It just needs someone to create some wallet.dats and write the test 11:46 < jonasschnelli> jup. agree 11:46 < jtimon> since this is for testing, can't we just download older versions from https://github.com/bitcoin/bitcoin/releases ? 11:46 < wumpus> yes- 11:46 < jonasschnelli> that's why I labeled it as "reminder". 11:46 < MarcoFalke> heh 11:46 < jonasschnelli> Create blank wallets will be merged soon 11:47 < luke-jr> jonasschnelli: or have it available anyway 11:47 < luke-jr> wumpus: what about Python maps of key/values that get shoved in a BDB db manually? :P 11:47 < jonasschnelli> luke-jr: thats not authentic enough IMO 11:48 < MarcoFalke> Jup, we really need a wallet.dat before every feature-bump in Bitcoin Core 11:48 < jtimon> well, that would still be better than nothing, I guess 11:49 < wumpus> any more topics? 11:50 < jl2012> I'd like to have some concept ACK and review for #13360, which makes out-of-bound SIGHASH_SINGLE non-standard. 11:50 < gribble> https://github.com/bitcoin/bitcoin/issues/13360 | [Policy] Reject SIGHASH_SINGLE with output out of bound by jl2012 路 Pull Request #13360 路 bitcoin/bitcoin 路 GitHub 11:50 < jl2012> this could become a softfork someday 11:50 < wumpus> #topic out-of-bound SIGHASH_SINGLE (jl2012) 11:50 < luke-jr> jl2012: ltns. What's the benefit though? 11:51 < jl2012> luke-jr: to avoid losing money by accident 11:51 < luke-jr> ah, so it's more for local sendrawtx than for relaying 11:52 < jl2012> in legacy script, signing with out-of-bound SINGLE is almost like revealing your private key 11:52 -!- afk11 [~afk11@unaffiliated/afk11] has quit [Quit: Leaving] 11:52 < luke-jr> (I'm not sure it makes sense to do a softfork for that reason though) 11:52 < luke-jr> it's like absurd fee 11:52 < jl2012> fee is a feature, but this thing is clearly a bug 11:53 < luke-jr> jl2012: IIRC, it has been proposed to use it, in the past 11:53 < wumpus> I'm also not sure it makes sense to do a softfork for this, if you're afraid of users doing this then it indeed makes sense to add it on submitrawtransaction 11:54 < luke-jr> I believe the feature in that case, was that the signature was smaller than a normal one 11:54 < luke-jr> (the goal was to clean dust UTXOs) 11:54 < instagibbs> luke-jr, only example I knpw of :P https://underhandedcrypto.com/2016/08/17/the-2016-backdoored-cryptocurrency-contest-winner/ 11:54 < jl2012> how smaller? It's still 72 bytes or so 11:54 < wumpus> I mean there's tons of ways to lose money with raw transactions, it is user friendly to try to protect this on RPC, but I'm not sure it merits changing the consensus rules... but that's just me 11:54 < luke-jr> or maybe it was compressability? I'm not sure 11:54 < jl2012> you can use SIGHASH_NONE for donating dust 11:55 < luke-jr> wumpus: +1 11:55 < gmaxwell> achow101: I don't think there should be a flag to make them optional, instead just have a command that adds/fixes them. 11:56 < gmaxwell> achow101: so then you're not peppering every interface with a flag, and also don't run into people just setting the flag all the time "because thats how you do it" 11:56 < luke-jr> gmaxwell: I think yuo had suggested some "privkey gets compromised" dust cleaning thing - was that this? 11:56 < gmaxwell> luke-jr: sorry, missing the context 11:57 < jl2012> luke-jr: I guess you mean that's cheaper to validate, as you don't need to hash it 11:57 < luke-jr> gmaxwell: [19:50:00] I'd like to have some concept ACK and review for #13360, which makes out-of-bound SIGHASH_SINGLE non-standard. 11:57 < gribble> https://github.com/bitcoin/bitcoin/issues/13360 | [Policy] Reject SIGHASH_SINGLE with output out of bound by jl2012 路 Pull Request #13360 路 bitcoin/bitcoin 路 GitHub 11:57 < jl2012> but using ANYONECANPAY|NONE would not be too bad 11:57 < gmaxwell> I think we should get rid of sighash single, not to protect users (the UI does that), but because it's a constant hazard in consensus rules. 11:58 < wumpus> get rid of SIGHASH_SINGLE completely? 11:58 < gmaxwell> Twice now I've gone through some horror of thinking some interaction of consensus rules/ecdsa would make all funds trivially stealable but only to be saved by dumb luck. 11:58 < gmaxwell> no, the bug. 11:58 < gmaxwell> Single itself is fine, sorry-- but the single bug is a hazard. 11:58 < gmaxwell> it's also not actually useful. 11:58 < gmaxwell> Nor used. 11:58 < luke-jr> gmaxwell: a few years ago, you had a way to reduce block space used in dust cleanup, but in a way that compromised the privkey - was that related to this? 11:59 < gmaxwell> luke-jr: It just used a nonce with an usually small nonce. Using the single bug didn't make the txn any smaller. 11:59 < luke-jr> k 11:59 < gmaxwell> (though may have made them somewhat more gzippable, but not more compressable with a format aware compressor) 12:00 < wumpus> #endmeeting 12:00 < lightningbot> Meeting ended Thu Feb 7 20:00:40 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) 12:00 < lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-02-07-19.01.html 12:00 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-02-07-19.01.txt 12:00 < lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-02-07-19.01.log.html 12:01 < gwillen> achow101: friendly poke on #13932 :-) 12:01 < gribble> https://github.com/bitcoin/bitcoin/issues/13932 | Additional utility RPCs for PSBT by achow101 路 Pull Request #13932 路 bitcoin/bitcoin 路 GitHub 12:01 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 12:01 < luke-jr> anyway, sounds like the policy change is a clear concept ACK, and softfork is at least something to consider later 12:01 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 12:02 < gmaxwell> An example, of one of the times I went through some horror. It's trivial to forge an ECDSA signature of the hash '0' with any pubkey... I realized this when I was AFK and thought single signed 0 instead of 1... if it did, every coin would have been stealable. 12:03 < gmaxwell> also, I think we already 'ruled' on the single bug being useful or not-- we didn't keep it in segwit. 12:03 < achow101> gwillen: what needs to be done on it? 12:03 < jl2012> gmaxwell: well, it's still in segwit, just not in a replayable style 12:03 < luke-jr> gmaxwell: saved by a bit ;) 12:04 < jl2012> in BIP143, out-of-bound SINGLE is treated like NONE 12:04 < gmaxwell> Right, it only signs that transaction. 12:04 < gmaxwell> And if by some cosmic wtf someone comes up with some application for it, it could always be introduced in a new script version. 12:05 < luke-jr> (yay script versions) 12:06 < gwillen> achow101: I left a few comments but I'd consider them nits -- should I be poking reviewers instead? 12:06 < gmaxwell> as far as concrete benefits beyond simplifying security analysis... it's one less case for a sighashcache to handle. (which I think was 95% of what caused it to come up) 12:06 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 12:06 < gwillen> achow101: or who do you think would ultimately be merging it? 12:07 < achow101> gwillen: right now it's waiting on reviewers 12:07 < achow101> i don't think there is much I can do 12:07 -!- watchtower [~watchtowe@pool-96-239-24-37.nycmny.fios.verizon.net] has quit [Quit: Leaving] 12:08 < gwillen> ok, I guess I can hassle people to review at the wallet meeting tomorrow 12:08 < gwillen> do take a look at my comments? 12:08 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 245 seconds] 12:08 < achow101> sure 12:08 < wumpus> probably a good idea!s 12:10 < jl2012> gmaxwell: I don't think the SINGLE bug would affect sighash caching? If it is out-of-bound, it's always out-of-bound for the same input 12:11 -!- benthecarman [~benthecar@2610:130:110:1406:1d5c:1d64:6798:877f] has joined #bitcoin-core-dev 12:12 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection] 12:12 < kanzure> late hi 12:13 < meshcollider> kanzure: you missed the whole meeting :p 12:15 < kanzure> time zones.. 12:15 < gmaxwell> jl2012: right, but it's still an extra case to branch on that has to be tested. 12:23 < jl2012> gmaxwell: the trick to make smaller signature is using R = G^0.5 ? 12:24 -!- jtimon [~quassel@92.28.134.37.dynamic.jazztel.es] has quit [Ping timeout: 246 seconds] 12:25 < benthecarman> Hey, so I am making a PR to add an option to give the user the ability to have commands run after Bitcoin Core is finished starting up, the idea is so someone could have things like lnd or electrum-personal-server automatically run when Bitcoin Core starts. Is this something desirable to add or could it be too unsafe? 12:25 < gmaxwell> jl2012: yes, it makes r serialize 10 bytes smaller. 12:25 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 12:26 < jl2012> related discussion: https://crypto.stackexchange.com/questions/60420/what-does-the-special-form-of-the-base-point-of-secp256k1-allow 12:26 < gmaxwell> benthecarman: that doesn't seem crazy (or at least not any more crazy than the 'notify' commands... But why not just start lnd or eps at the same time-- presumably they'll just keep trying to reconnect, no? 12:26 < jl2012> so G is clearly not a random choice. Who choose that and why? 12:27 < jl2012> it seems not answered 12:27 < benthecarman> gmaxwell: my thinking was that you don't need to add all those to your automatic startup or have to run anything extra and bitcoin core can set it up for you 12:28 < sipa> jl2012: there is a very old bct thread about that, from someone who contacted certicom about the origins of the curve 12:28 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds] 12:29 < gmaxwell> jl2012: it's not, (AFAIK, I'm the one who discovered that it isn't...) but it's largely irrelevant. e.g. its trivial to prove that any 'weak' point makes all points weak. 12:29 < gmaxwell> jl2012: I can tell you how I discovered it, which is suggestive as to how it might have been selected that way. 12:31 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection] 12:34 < gmaxwell> jl2012: We had theorized that libsecp256k1's generator was was the output of some hash, but had no luck at finding a match (somee standards had hashes of the designers kids dates of birth or similar for choosing g)... In unrelated work on libsecp256k1 we wanted an easily generated NUMS point for blinding some operations in libsecp256k1... so like take a dumb string or a hash and treat it as a 12:34 < gmaxwell> point. Then it seemed useful to perform some operation on it to randomize the bits. The only operation you can do with just a single point and nothing is double it... which does a pretty good job of making the resulting values look 'random'. 12:35 < gmaxwell> jl2012: so I thought maybe the designer of this curve had taken a hash as a point and doubled it... so I havled G and found a surprisingly small value. 12:36 < gmaxwell> FWIW secp224k1 uses the same constant. 12:39 < jl2012> oh, btw, I have a related idea: in the new schnorr sig checking, if the signature size is 32 bytes, we check if it is the correct private key. This should be the cheapest way to donate dust 12:41 < gmaxwell> I had that thought too, fwiw.-- during the above disussion, but ISTM it's such a corner case that I dunno if it's worth doing. 12:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:45 < bitcoin-git> [bitcoin] benthecarman opened pull request #15367: feature: Added ability for users to add a startup command (master...startup_commands) https://github.com/bitcoin/bitcoin/pull/15367 12:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:45 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has quit [Quit: pinheadmz] 12:45 < jl2012> if we will have some kind of EC MATH opcodes in the future, there is probably not much marginal cost to support this 12:47 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 12:48 -!- benthecarman [~benthecar@2610:130:110:1406:1d5c:1d64:6798:877f] has quit [Quit: Leaving] 12:49 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has quit [Client Quit] 12:52 -!- shesek [~shesek@141.226.217.238] has joined #bitcoin-core-dev 12:52 -!- shesek [~shesek@141.226.217.238] has quit [Changing host] 12:52 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 12:56 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 12:57 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 12:58 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 246 seconds] 13:02 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 13:03 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 13:05 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Remote host closed the connection] 13:08 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev 13:08 -!- jtimon [~quassel@92.28.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev 13:10 -!- ap4lmtree [~ap4lmtree@unaffiliated/ap4lmtree] has quit [Read error: Connection reset by peer] 13:25 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 13:27 -!- bralyclow [bralyclow@gateway/vpn/protonvpn/bralyclow] has joined #bitcoin-core-dev 13:30 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 245 seconds] 13:55 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has quit [Ping timeout: 268 seconds] 13:57 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 14:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:02 < bitcoin-git> [bitcoin] laanwj pushed 7 commits to master: https://github.com/bitcoin/bitcoin/compare/1933e38c1a08...9127bd7abaf8 14:02 < bitcoin-git> bitcoin/master a1b25e1 John Newbery: [wallet] Refactor ProcessImport() 14:02 < bitcoin-git> bitcoin/master 4cac0dd John Newbery: [wallet] Add ProcessImportLegacy() 14:02 < bitcoin-git> bitcoin/master d2b381c John Newbery: [wallet] Refactor ProcessImport() to call ProcessImportLegacy() 14:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:04 < instagibbs> \o/ 14:05 < instagibbs> Only a couple PRs away from running master again :P 14:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:05 < bitcoin-git> [bitcoin] laanwj merged pull request #14491: Allow descriptor imports with importmulti (master...201810_importmulti_desc_2) https://github.com/bitcoin/bitcoin/pull/14491 14:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:05 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 14:08 < achow101> \o/ 14:09 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-ggneuvuonzbqapyc] has joined #bitcoin-core-dev 14:18 -!- hyperion [~hyperion@2604:3d09:137f:d400:a907:2340:3215:f6a1] has joined #bitcoin-core-dev 14:18 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 14:19 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:28 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 14:32 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 14:36 -!- ap4lmtree [~ap4lmtree@unaffiliated/ap4lmtree] has joined #bitcoin-core-dev 14:40 -!- jimmysong [~jimmysong@72-48-253-51.dyn.grandenetworks.net] has quit [Read error: Connection reset by peer] 14:40 -!- jimmysong__ [~jimmysong@72-48-253-51.dyn.grandenetworks.net] has quit [Read error: Connection reset by peer] 14:44 -!- jimmysong [~jimmysong@72-48-253-51.dyn.grandenetworks.net] has joined #bitcoin-core-dev 14:44 -!- jimmysong_ [~jimmysong@72-48-253-51.dyn.grandenetworks.net] has joined #bitcoin-core-dev 15:05 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection] 15:07 -!- TX1683 [~TX1683@unaffiliated/tx1683] has quit [Read error: Connection reset by peer] 15:10 -!- ddustin_ [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 15:12 -!- michaels_ [~michaelsd@38.126.31.226] has joined #bitcoin-core-dev 15:12 -!- kexkey [~kexkey@68.168.122.228] has quit [Quit: Scaling pentatonically] 15:12 -!- michaels_ [~michaelsd@38.126.31.226] has quit [Client Quit] 15:14 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 244 seconds] 15:14 -!- Cory [~Cory@unaffiliated/cory] has quit [Ping timeout: 272 seconds] 15:16 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection] 15:16 -!- TX1683 [~TX1683@unaffiliated/tx1683] has joined #bitcoin-core-dev 15:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 15:16 < bitcoin-git> [bitcoin] sipa opened pull request #15368: Descriptor checksums (master...201902_descsum) https://github.com/bitcoin/bitcoin/pull/15368 15:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 15:17 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev 15:20 -!- Pasha [~Cory@unaffiliated/cory] has joined #bitcoin-core-dev 15:23 -!- Pasha is now known as Cory 15:27 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 15:27 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev 15:33 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 250 seconds] 15:40 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Quit: Leaving...] 15:47 -!- bralyclo_ [bralyclow@gateway/vpn/protonvpn/bralyclow] has joined #bitcoin-core-dev 15:50 -!- bralyclow [bralyclow@gateway/vpn/protonvpn/bralyclow] has quit [Ping timeout: 240 seconds] 16:04 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 16:07 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 246 seconds] 16:42 -!- hyperion [~hyperion@2604:3d09:137f:d400:a907:2340:3215:f6a1] has quit [Quit: Leaving] 16:42 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.] 16:49 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-ggneuvuonzbqapyc] has quit [Quit: Connection closed for inactivity] 17:00 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!] 17:11 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 17:16 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds] 17:47 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has quit [Ping timeout: 250 seconds] 17:49 -!- bralyclow [~bralyclow@2600:1700:3d70:93b0:f104:8a78:57d7:b19c] has joined #bitcoin-core-dev 17:50 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev 17:50 -!- bralyclow [~bralyclow@2600:1700:3d70:93b0:f104:8a78:57d7:b19c] has quit [Remote host closed the connection] 17:52 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has joined #bitcoin-core-dev 17:53 -!- bralyclo_ [bralyclow@gateway/vpn/protonvpn/bralyclow] has quit [Ping timeout: 268 seconds] 17:53 -!- ddustin_ [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 250 seconds] 18:03 -!- jarthur [~jarthur@2605:6000:1019:41ab:784a:575:4d6e:6cec] has joined #bitcoin-core-dev 18:49 -!- kexkey [~kexkey@68.168.122.228] has joined #bitcoin-core-dev 18:51 -!- kexkey [~kexkey@68.168.122.228] has quit [Read error: Connection reset by peer] 19:09 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has quit [Quit: drexl] 19:23 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 19:23 -!- murrayn [~murrayn@unaffiliated/murrayn] has quit [Read error: Connection reset by peer] 19:24 -!- murrayn [~murrayn@S0106f8a097f16608.ok.shawcable.net] has joined #bitcoin-core-dev 19:24 -!- murrayn [~murrayn@S0106f8a097f16608.ok.shawcable.net] has quit [Changing host] 19:24 -!- murrayn [~murrayn@unaffiliated/murrayn] has joined #bitcoin-core-dev 19:30 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 19:31 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 19:35 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 245 seconds] 19:50 -!- volkov [~volkov@gateway/tor-sasl/volkov] has joined #bitcoin-core-dev 20:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 20:12 < bitcoin-git> [bitcoin] sipa pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/9127bd7abaf8...b9b26d9c3615 20:12 < bitcoin-git> bitcoin/master 1cff3d6 Gleb Naumenko: Change in transaction pull scheduling to prevent InvBlock-related attacks 20:12 < bitcoin-git> bitcoin/master b9b26d9 Pieter Wuille: Merge #14897: randomize GETDATA(tx) request order and introduce bias towar... 20:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 20:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 20:13 < bitcoin-git> [bitcoin] sipa merged pull request #14897: randomize GETDATA(tx) request order and introduce bias toward outbound (master...master) https://github.com/bitcoin/bitcoin/pull/14897 20:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 20:25 -!- rex4539 [~rex4539@ppp-2-84-174-220.home.otenet.gr] has quit [Quit: rex4539] 20:29 < meshcollider> I've put a few wallet PRs that we could hope to get in on the milestone, maybe not all are feasible, depends how avid reviewers are this week :) 20:30 < meshcollider> Definitely the open wallet menu should go in, and it'd be nice to have the listuspent segwit PR since its the last unmerged on the segwit project 21:07 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 21:31 -!- volkov [~volkov@gateway/tor-sasl/volkov] has quit [Quit: volkov] 21:32 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 21:38 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 250 seconds] 21:54 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 21:59 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 250 seconds] 22:00 -!- jarthur [~jarthur@2605:6000:1019:41ab:784a:575:4d6e:6cec] has quit [] 22:42 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 22:55 < fanquake> promag think 15153 is good enough now. Still some behaviour that can be cleaned up later. Could you rebase 15195 ontop of the latest version of 15153, be good to get that into 0.18 too. 23:02 < sipa> #15153 23:02 < gribble> https://github.com/bitcoin/bitcoin/issues/15153 | gui: Add Open Wallet menu by promag 路 Pull Request #15153 路 bitcoin/bitcoin 路 GitHub 23:19 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 23:33 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection] 23:36 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev 23:44 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection] 23:55 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev --- Log closed Fri Feb 08 00:00:43 2019