--- Log opened Thu Feb 14 00:00:10 2019
--- Day changed Thu Feb 14 2019
00:00 -!- anonymous8587 [~Mutter@2a01:598:8988:37b1:1189:1565:4426:c1f9] has quit [Client Quit]
00:42 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev
00:43 < provoostenator> That may have my fault :-)
00:43 < provoostenator> I think AppVeyor works sequentally and I've had to restart it a few times and tried to bust the cache for my PR.
00:44 < provoostenator> I think busting the cache may worked, because this error is also why I get on AppVeyor on my own repo against master.
00:44 < provoostenator> "bitcoin-wallet.exe : fatal error LNK1120: 14 unresolved externals"
00:48 < provoostenator> In #15382 I added "C:\tools\vcpkg\installed -> appveyor.yml" to .appveyor.yml to bust the package cache whenever that file is modified.
00:49 < gribble> https://github.com/bitcoin/bitcoin/issues/15382 | WIP [util] add runCommandParseJSON by Sjors · Pull Request #15382 · bitcoin/bitcoin · GitHub
00:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:49 < bitcoin-git> [bitcoin] MeshCollider pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/9c93f5d9fc93...2452c6cc0a23
00:49 < bitcoin-git> bitcoin/master 162ffef Glenn Willen: Add pf_invalid arg to std::string DecodeBase{32,64}
00:49 < bitcoin-git> bitcoin/master c734aaa Glenn Willen: Split DecodePSBT into Base64 and Raw versions
00:49 < bitcoin-git> bitcoin/master 81cd958 Glenn Willen: Factor BroadcastTransaction out of sendrawtransaction
00:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:50 < bitcoin-git> [bitcoin] MeshCollider merged pull request #14978: Factor out PSBT utilities from RPCs for use in GUI code; related refactoring. (master...feature-refactor-psbt-rpcs) https://github.com/bitcoin/bitcoin/pull/14978
00:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:50 < provoostenator> ^ watching my rebase hell slowly come to an end, thanks MeshCollider :-)
00:51 < meshcollider> \o/
00:51 < meshcollider> we are nearly there yep
00:52 < meshcollider> just #14021 and #14075 to go
00:52 < gribble> https://github.com/bitcoin/bitcoin/issues/14021 | Import key origin data through descriptors in importmulti by achow101 · Pull Request #14021 · bitcoin/bitcoin · GitHub
00:52 < gribble> https://github.com/bitcoin/bitcoin/issues/14075 | Import watch only pubkeys to the keypool if private keys are disabled by achow101 · Pull Request #14075 · bitcoin/bitcoin · GitHub
00:54 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
00:58 < provoostenator> I'll try rebasing #15388 and see if that magically fixes AppVeyor. If not, someone who actually understands it should take a look...
00:58 < gribble> https://github.com/bitcoin/bitcoin/issues/15388 | [build] Makefile.am: add rule for src/bitcoin-wallet by Sjors · Pull Request #15388 · bitcoin/bitcoin · GitHub
01:05 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev
01:07 -!- jungly [~quassel@host97-200-static.8-79-b.business.telecomitalia.it] has joined #bitcoin-core-dev
01:39 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev
01:44 -!- a5m0 [~a5m0@unaffiliated/a5m0] has quit [Remote host closed the connection]
01:46 -!- a5m0 [~a5m0@unaffiliated/a5m0] has joined #bitcoin-core-dev
01:48 -!- rex4539 [~rex4539@ppp-2-84-161-162.home.otenet.gr] has quit [Quit: rex4539]
02:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:16 < bitcoin-git> [bitcoin] Sjors opened pull request #15405: [build] AppVeyor: clean cache when build configuration changes (master...2019/02/appveyor_cache) https://github.com/bitcoin/bitcoin/pull/15405
02:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:24 -!- rhavar [uid237883@gateway/web/irccloud.com/x-honrlkfrcjmplfyj] has quit [Quit: Connection closed for inactivity]
02:28 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has joined #bitcoin-core-dev
02:29 -!- thedevworks [~thedevwor@185.49.169.22] has joined #bitcoin-core-dev
02:30 -!- thedevworks [~thedevwor@185.49.169.22] has quit [Client Quit]
02:31 -!- thedevworks [~thedevwor@185.49.169.22] has joined #bitcoin-core-dev
02:32 < meshcollider> sipa: would you happen to have a little time to review #14021
02:32 < gribble> https://github.com/bitcoin/bitcoin/issues/14021 | Import key origin data through descriptors in importmulti by achow101 · Pull Request #14021 · bitcoin/bitcoin · GitHub
02:39 -!- rex4539 [~rex4539@ppp-2-84-161-162.home.otenet.gr] has joined #bitcoin-core-dev
02:40 < provoostenator> Update: I have no idea how to make the AppVeyor errors on master go away. There's probably some extra configuration needed for bitcoin-wallet, but #15388 doesn't do the trick.
02:40 < gribble> https://github.com/bitcoin/bitcoin/issues/15388 | [build] Makefile.am: add rule for src/bitcoin-wallet by Sjors · Pull Request #15388 · bitcoin/bitcoin · GitHub
02:45 -!- siom_ [~siom@31.13.191.152] has joined #bitcoin-core-dev
02:47 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-tkiubtfzhrrrgiqm] has joined #bitcoin-core-dev
02:56 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
02:58 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Remote host closed the connection]
02:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:59 < bitcoin-git> [bitcoin] marcuswin opened pull request #15406: Update links (master...master) https://github.com/bitcoin/bitcoin/pull/15406
02:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:09 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
03:11 -!- Karyon [~karyon@unaffiliated/karyon] has joined #bitcoin-core-dev
03:16 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
03:17 -!- zhangzf [~zhangzf@106.38.157.147] has quit [Remote host closed the connection]
03:31 -!- ovovo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 240 seconds]
03:31 -!- owowo [~ovovo@s91904425.blix.com] has joined #bitcoin-core-dev
03:31 -!- owowo [~ovovo@s91904425.blix.com] has quit [Changing host]
03:31 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
03:37 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
03:42 -!- thedevworks [~thedevwor@185.49.169.22] has quit [Ping timeout: 272 seconds]
03:52 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection]
03:53 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev
04:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:12 < bitcoin-git> [bitcoin] ken2812221 opened pull request #15407: msvc: Fix silent merge conflict between #13926 and #14372 part II (master...msvc-bitcoin-wallet-leveldb) https://github.com/bitcoin/bitcoin/pull/15407
04:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:19 -!- Karyon [~karyon@unaffiliated/karyon] has quit [Ping timeout: 250 seconds]
04:25 < provoostenator> I cancelled some ongoing AppVeyor builds to make room for ^
04:25 -!- rex4539 [~rex4539@ppp-2-84-161-162.home.otenet.gr] has quit [Quit: rex4539]
04:31 -!- Karyon [~karyon@unaffiliated/karyon] has joined #bitcoin-core-dev
04:47 -!- zhangzf [~zhangzf@223.72.44.185] has joined #bitcoin-core-dev
04:54 -!- thedevworks [~thedevwor@185.49.169.22] has joined #bitcoin-core-dev
05:05 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-tkiubtfzhrrrgiqm] has quit []
05:35 -!- indistylo [~aruns_@2406:7400:58:48d9:3552:b53f:f514:9626] has joined #bitcoin-core-dev
05:40 -!- jimmysong_ [~jimmysong@72-48-253-51.dyn.grandenetworks.net] has joined #bitcoin-core-dev
05:44 -!- jimmysong [~jimmysong@72-48-253-51.dyn.grandenetworks.net] has quit [Ping timeout: 272 seconds]
05:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:45 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2452c6cc0a23...38989ab03fb7
05:45 < bitcoin-git> bitcoin/master 8c3fdd3 marcoagner: fixes m_assumed_blockchain_size variables values:
05:45 < bitcoin-git> bitcoin/master 38989ab MarcoFalke: Merge #15183: [Qt]: fixes m_assumed_blockchain_size variable value
05:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:45 < luke-jr> hm, someone had a good idea: if nodes store their own UTXO hashes, they can safely recover from other nodes if something gets corrupt rather than a re-IBD
05:45 -!- bralyclo_ [bralyclow@gateway/vpn/protonvpn/bralyclow] has joined #bitcoin-core-dev
05:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:45 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15183: [Qt]: fixes m_assumed_blockchain_size variable value (master...fix_m_assumed_blockchain_size) https://github.com/bitcoin/bitcoin/pull/15183
05:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:46 < luke-jr> although it's a lot of data to download before you know if the other peer is being malicious or not
05:49 -!- bralyclow [bralyclow@gateway/vpn/protonvpn/bralyclow] has quit [Ping timeout: 244 seconds]
05:50  * luke-jr adds it to https://github.com/bitcoin/bitcoin/issues/8037#issuecomment-463633344
05:52 -!- zhangzf [~zhangzf@223.72.44.185] has quit [Remote host closed the connection]
05:53 -!- zhangzf [~zhangzf@223.72.37.68] has joined #bitcoin-core-dev
05:55 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev
05:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:59 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/38989ab03fb7...e3b1c7a9d6ae
05:59 < bitcoin-git> bitcoin/master 3c6ef03 Chun Kuan Lee: msvc: Fix silent merge conflict between #13926 and #14372 part II
05:59 < bitcoin-git> bitcoin/master e3b1c7a MarcoFalke: Merge #15407: msvc: Fix silent merge conflict between #13926 and #14372 pa...
05:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:00 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Ping timeout: 272 seconds]
06:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:00 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15407: msvc: Fix silent merge conflict between #13926 and #14372 part II (master...msvc-bitcoin-wallet-leveldb) https://github.com/bitcoin/bitcoin/pull/15407
06:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:05 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #15405: [build] AppVeyor: clean cache when build configuration changes (master...2019/02/appveyor_cache) https://github.com/bitcoin/bitcoin/pull/15405
06:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:06 < bitcoin-git> [bitcoin] MarcoFalke reopened pull request #15405: [build] AppVeyor: clean cache when build configuration changes (master...2019/02/appveyor_cache) https://github.com/bitcoin/bitcoin/pull/15405
06:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:30 -!- Karyon [~karyon@unaffiliated/karyon] has quit [Ping timeout: 250 seconds]
06:34 -!- Karyon [~karyon@unaffiliated/karyon] has joined #bitcoin-core-dev
06:34 -!- zhangzf [~zhangzf@223.72.37.68] has quit [Remote host closed the connection]
06:39 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev
06:41 -!- rhavar [uid237883@gateway/web/irccloud.com/x-sgswkdooyemwmiks] has joined #bitcoin-core-dev
06:47 -!- jtimon [~quassel@92.28.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev
06:51 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
06:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:55 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #15408: Remove unused TransactionError constants (master...Mf1902-TransactionErrorConst) https://github.com/bitcoin/bitcoin/pull/15408
06:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:59 -!- ap4lmtree [ap4lmtree@unaffiliated/ap4lmtree] has joined #bitcoin-core-dev
06:59 -!- ap4lmtree [ap4lmtree@unaffiliated/ap4lmtree] has quit [Remote host closed the connection]
07:08 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection]
07:16 -!- thedevworks_ [~thedevwor@185.49.169.22] has joined #bitcoin-core-dev
07:18 -!- thedevworks [~thedevwor@185.49.169.22] has quit [Ping timeout: 246 seconds]
07:19 -!- ArdeshirV [~Ardeshir@37.59.65.0] has joined #bitcoin-core-dev
07:20 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Excess Flood]
07:21 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
07:27 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
07:29 -!- ArdeshirV [~Ardeshir@37.59.65.0] has quit [Quit: Leaving]
07:32 -!- Karyon [~karyon@unaffiliated/karyon] has quit [Ping timeout: 250 seconds]
07:33 -!- indistylo [~aruns_@2406:7400:58:48d9:3552:b53f:f514:9626] has quit [Read error: Connection reset by peer]
07:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:34 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/e3b1c7a9d6ae...9b1df4ba0bec
07:34 < bitcoin-git> bitcoin/master 4a43eb8 Sjors Provoost: [build] Makefile.am: add rule for src/bitcoin-wallet
07:34 < bitcoin-git> bitcoin/master 9b1df4b MarcoFalke: Merge #15388: [build] Makefile.am: add rule for src/bitcoin-wallet
07:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:35 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15388: [build] Makefile.am: add rule for src/bitcoin-wallet (master...2019/02/wallet_tool_make) https://github.com/bitcoin/bitcoin/pull/15388
07:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:37 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/]
07:42 -!- Karyon [~karyon@unaffiliated/karyon] has joined #bitcoin-core-dev
07:44 -!- thedevworks_ [~thedevwor@185.49.169.22] has quit [Quit: Leaving]
07:52 -!- bralyclo_ [bralyclow@gateway/vpn/protonvpn/bralyclow] has quit []
08:10 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
08:30 -!- ZaiRoX [~ZaiRoX@cm-84.209.7.154.getinternet.no] has joined #bitcoin-core-dev
08:37 -!- Karyon [~karyon@unaffiliated/karyon] has quit [Ping timeout: 250 seconds]
08:51 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
08:52 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has joined #bitcoin-core-dev
08:59 -!- ap4lmtree- is now known as ap4lmtree
09:02 -!- spinza [~spin@155.93.246.187] has quit [Ping timeout: 250 seconds]
09:03 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
09:07 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
09:17 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev
09:32 -!- rex4539 [~rex4539@ppp-2-84-161-162.home.otenet.gr] has joined #bitcoin-core-dev
09:33 -!- Karyon [~karyon@unaffiliated/karyon] has joined #bitcoin-core-dev
09:37 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
09:40 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 250 seconds]
09:42 -!- siom_ [~siom@31.13.191.152] has quit [Remote host closed the connection]
09:46 -!- JackH [~laptop@host86-134-40-210.range86-134.btcentralplus.com] has quit [Quit: Leaving]
09:47 < sipa> meshcollider: wil do
09:47 -!- jungly [~quassel@host97-200-static.8-79-b.business.telecomitalia.it] has quit [Remote host closed the connection]
10:04 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has joined #bitcoin-core-dev
10:09 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev
10:19 -!- jonasschnelli_ [~jonasschn@bitcoinsrv.jonasschnelli.ch] has quit [Changing host]
10:19 -!- jonasschnelli_ [~jonasschn@unaffiliated/jonasschnelli] has joined #bitcoin-core-dev
10:19 -!- jonasschnelli_ is now known as jonasschnelli
10:20 -!- Karyon [~karyon@unaffiliated/karyon] has quit [Ping timeout: 264 seconds]
10:26 -!- Karyon [~karyon@unaffiliated/karyon] has joined #bitcoin-core-dev
10:27 -!- mistergold [~mistergol@77.243.22.147] has joined #bitcoin-core-dev
10:30 -!- ap4lmtree [ap4lmtree@unaffiliated/ap4lmtree] has quit [Read error: Connection reset by peer]
10:40 -!- ap4lmtree [ap4lmtree@unaffiliated/ap4lmtree] has joined #bitcoin-core-dev
10:42 -!- fabianfabian [~fabianfab@D9656CCE.cm-27.dynamic.ziggo.nl] has joined #bitcoin-core-dev
10:49 -!- schmidty_ [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has quit [Remote host closed the connection]
10:55 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
10:56 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Remote host closed the connection]
10:56 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
10:58 < jonasschnelli> luke-jr: a hardlink copy seems more efficient since you don't depend on other nodes
11:00 < wumpus> #startmeeting
11:00 < lightningbot> Meeting started Thu Feb 14 19:00:22 2019 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
11:00 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
11:00 < provoostenator> hi
11:00 < jamesob> hi
11:00 < instagibbs> hi
11:00 < wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb
11:00 < moneyball> topic proposed by provoostenator: minimum QT version for v0.18, see #13478
11:00 < gribble> https://github.com/bitcoin/bitcoin/issues/13478 | [RFC] gui: Minimum required Qt5 · Issue #13478 · bitcoin/bitcoin · GitHub
11:00 < promag> hi
11:00 < jonasschnelli> hi
11:00 < achow101> hi
11:01 < moneyball> happy valentine's day :) 
11:01 < luke-jr> St. Valentine's day*
11:01 < jamesob> <3
11:01 < provoostenator> Thanks! I spent it with AppVeyor mostly :-)
11:01 < luke-jr> lol
11:01 < jonasschnelli> heh
11:02 < wumpus> 💜
11:03 < luke-jr> Sjors pointed me to the issue when I asked what benefits there are, but I didn't see any there..
11:03 < luke-jr> I also don't see where/if anyone done a check for what versions come with current stable distros.
11:03 < wumpus> #topic 0.18 feature freeze
11:03 < phantomcircuit> hi
11:03 < phantomcircuit> luke-jr, happy halmark day
11:04 < provoostenator> luke-jr: the issue described the reasons for switching, but those reasons aren't benefits :-)
11:04 < sipa> will be there in 5-10 mi
11:04 < sipa> min
11:05 < wumpus> tomorrow (15th) is the 0.18 feature freeze
11:05 < wumpus> there's still quite a few PRs open on the 0.18 milestone https://github.com/bitcoin/bitcoin/pulls?q=is%3Aopen+is%3Apr+milestone%3A0.18.0 though not all are features of course
11:06 < wumpus> but it'd definitely help to get some more review there
11:06 < gleb> hi
11:07 < phantomcircuit> luke-jr, generally 4/5 are available in parallel
11:08 < gmaxwell> hi
11:08 < luke-jr> phantomcircuit: ?
11:08 < phantomcircuit> luke-jr, qt
11:08 < phantomcircuit> debian at least i have both installed
11:08 < wumpus> still open features are #15195 for the GUI and a few RPC ones
11:08 < gribble> https://github.com/bitcoin/bitcoin/issues/15195 | gui: Add Close Wallet action by promag · Pull Request #15195 · bitcoin/bitcoin · GitHub
11:08 < luke-jr> phantomcircuit: we already don't support Qt4
11:08 < wumpus> please, stick to the topic
11:08 < phantomcircuit> oh right
11:09 < wumpus> for RPC there's #14481 #14075 #14021 #13932 left that are really features
11:09 < gribble> https://github.com/bitcoin/bitcoin/issues/14481 | Add P2SH-P2WSH support to listunspent RPC by MeshCollider · Pull Request #14481 · bitcoin/bitcoin · GitHub
11:09 < gribble> https://github.com/bitcoin/bitcoin/issues/14075 | Import watch only pubkeys to the keypool if private keys are disabled by achow101 · Pull Request #14075 · bitcoin/bitcoin · GitHub
11:09 < gribble> https://github.com/bitcoin/bitcoin/issues/14021 | Import key origin data through descriptors in importmulti by achow101 · Pull Request #14021 · bitcoin/bitcoin · GitHub
11:10 < gribble> https://github.com/bitcoin/bitcoin/issues/13932 | Additional utility RPCs for PSBT by achow101 · Pull Request #13932 · bitcoin/bitcoin · GitHub
11:10 < kanzure> hi.
11:10 < instagibbs> key origin import seems camera-ready if others want to look
11:10 -!- VitorB [32d04929@gateway/web/freenode/ip.50.208.73.41] has joined #bitcoin-core-dev
11:11 < achow101> 14021 is pretty close
11:11 < wumpus> good!
11:12 < promag> I'm waiting for some feedback on 15195
11:12 < wumpus> ah there's also #15368 
11:12 < gribble> https://github.com/bitcoin/bitcoin/issues/15368 | Descriptor checksums by sipa · Pull Request #15368 · bitcoin/bitcoin · GitHub
11:12 < gmaxwell> luke-jr: do you have a 32-bit host with rdrand (modern intel/amd cpu running in 32bit mode)? would be nice to test #15250 on that. (doesn't block merge, I guess since it could be fixed before release if there were an issue)
11:12 < gribble> https://github.com/bitcoin/bitcoin/issues/15250 | Use RdSeed when available, and reduce RdRand load by sipa · Pull Request #15250 · bitcoin/bitcoin · GitHub
11:13 < wumpus> which already has some ACKs
11:13 < luke-jr> gmaxwell: my most recent x86 is Haswell, and it doesn't have a 32-bit chroot at the moment
11:13 < wumpus> gmaxwell: I consider the rdrand one a bugfix not a feature so it doesn't strictly need to be merged tomorrow
11:13 < gmaxwell> haswell is ducky and has both rdrand and rdseed IIRC.
11:14 < gmaxwell> (it certantly has rdrand)
11:14 < gmaxwell> wumpus: thanks, I agree.
11:14 < luke-jr> if our static binaries were actually portable, I could have probably tested with those, but.. :/
11:14 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev
11:15 < sipa> wumpus: would #15402 count as a bugfix?
11:15 < gribble> https://github.com/bitcoin/bitcoin/issues/15402 | Granular invalidateblock and RewindBlockIndex by sipa · Pull Request #15402 · bitcoin/bitcoin · GitHub
11:15 < wumpus> sipa: I guess so
11:15 < wumpus> sipa: it fixes that out of memory issue on reorg right?
11:15 < gmaxwell> It should, it's a pretty serious bug.
11:15 < provoostenator> It fixes an OOM
11:15 < sipa> hmm, not reorg
11:16 < gmaxwell> wumpus: on rewind/replay
11:16 < wumpus> so I mean it fixes  #14289
11:16 < gribble> https://github.com/bitcoin/bitcoin/issues/14289 | Unbounded growth of scheduler queue · Issue #14289 · bitcoin/bitcoin · GitHub
11:16 < wumpus> so it's a fix
11:16 < wumpus> added 0.18 milestone
11:17 < jamesob> it doesn't fix the general issue of #14289, just one specific instance right?
11:17 < gribble> https://github.com/bitcoin/bitcoin/issues/14289 | Unbounded growth of scheduler queue · Issue #14289 · bitcoin/bitcoin · GitHub
11:17 < sipa> jamesob: indeed
11:18 < jamesob> intend on building in a SERIAL_SCHEDULER_EXECUTION flag (or something) for use in CI in the next couple days 
11:18 < jamesob> (offtopic, sorry)
11:19 < wumpus> #topic minimum QT version for v0.18 (provoostenator)
11:19 < phantomcircuit> gmaxwell, that cant be checked in a vm?
11:19 < gmaxwell> phantomcircuit: absolutely can be
11:19 < luke-jr> [19:03:49] <luke-jr> I also don't see where/if anyone done a check for what versions come with current stable distros.
11:19 < luke-jr> I tried doing ^ myself, but I couldn't figure out what version RHEL 7 has
11:19 < provoostenator> I think we should either make Travis test older versions of QT or bump the min version.
11:19 < MarcoFalke> luke-jr: The benefit is that it is easier to just bump the minimum than to make it compile with 5.2
11:20 < provoostenator> Currently it doesn't even compile in 5.2
11:20 < MarcoFalke> ^
11:20 < wumpus> 5.2 is ancient anyway
11:20 < luke-jr> but who does this cut off?
11:20 < luke-jr> what version does RHEL 7 have?
11:20 < MarcoFalke> If someone wants to build on an acient system with an EOL qt, they are better off with depends
11:20 < provoostenator> As for stable distros: we can narrow that down to stable distros where the depends system doesn't work?
11:20 < luke-jr> RHEL 7 is current
11:20 < wumpus> didn't we have a discussion about this in a github issue?
11:20 < jonasschnelli> Yes
11:20 < luke-jr> provoostenator: depends should not be the norm
11:21 < MarcoFalke> luke-jr:  rhel7 can use depends
11:21 < wumpus> is there anything new to add to that or is this just another repeat of that?
11:21 < jonasschnelli> I think just updating Qt for the sake of updating seems pointless
11:21 < wumpus> this comes up too often
11:21 < jonasschnelli> What we need is advantages/disadvantage comparison 
11:21 < luke-jr> updating is fine. cutting off people who reasonably have an old version isn't.
11:21 < meshcollider> Hi, sorry im late
11:21 < wumpus> jonasschnelli: he isn't updating qt, only changing the minimum requirement in the build system to the actual minimum requirement IIRC
11:22 < provoostenator> jonasschnelli: it's not for the sake of updating, it's because we're constantly breaking old versions.
11:22 < wumpus> it doesn't work with qt 5.2, no one is testing it with that, so it's kind of a moot point
11:22 < gmaxwell> Just pushing to new versions for the sake of updating is a bad pattern.  If there is a problem or a new feature, then great.  Matching minimums to the actual minimums is also good (excepting in cases where we should fix the minimum because we're cutting something out people are currently using)
11:22 < wumpus> no one is updating qt !
11:22 < jonasschnelli> I see. Sorry for the confusion.
11:22 < wumpus> this isn't the point of tha pr
11:23 < wumpus> #15393 bumps the minimum version checked by the bulid system
11:23 < gribble> https://github.com/bitcoin/bitcoin/issues/15393 | build: Bump minimum Qt version to 5.5.1 by Sjors · Pull Request #15393 · bitcoin/bitcoin · GitHub
11:23 < wumpus> to the version that we actually require already
11:23 < wumpus> the only difference is that configure will show an error now
11:23 < jonasschnelli> Qt 5.6 LTS ends in 2 months... :/
11:23 < wumpus> instead of failing later in the build
11:23 < jonasschnelli> Whatever minimal Qt support we set, we should make sure its ran in our CI
11:23 < luke-jr> can someone with a reasonable internet connection download CentOS 7 and find out what version it has? :x
11:24 < wumpus> jonasschnelli: yes
11:24 < jonasschnelli> I'm not sure if we should look to deep into all distros...
11:24 < MarcoFalke> luke-jr: It is 5.9?
11:24 < MarcoFalke> http://mirror.centos.org/centos/7/os/x86_64/Packages/qt5-qtbase-5.9.2-3.el7.x86_64.rpm
11:24 < jonasschnelli> If CentOS uses Qt5.3 which its support has probably been stopped 2 years ago, it's not a pattern to follow
11:24 < jonasschnelli> (assuming)
11:24 < luke-jr> MarcoFalke: not sure why I couldn't find that.. thanks
11:24 < sipa> luke-jr: is 5.9.2 possible? http://mirror.centos.org/centos/7/os/x86_64/Packages/
11:25 < jonasschnelli> make sense... 5.9 is the one where LTS is at least 1 year
11:25 < MarcoFalke> Is rhel7 using the same as centos7?
11:25 < luke-jr> MarcoFalke: CentOS is just a free-of-charge RHEL
11:25 < provoostenator> luke-jr: CentOS 7 seems to have QT5.9.2: http://mirror.centos.org/centos/7/os/x86_64/Packages/
11:25 < luke-jr> sounds like this is a non-issue then
11:25 < provoostenator> (oh, sipa found it)
11:25 < MarcoFalke> Ok, so it seems we are not cutting off anyone with the bump?
11:26 < wumpus> ok
11:26 < jonasschnelli> We cut off debian 8 which is LTS till 2020
11:26 < provoostenator> Cool, let's merge it right now :-P
11:26 < jonasschnelli> but I guess thats okay
11:27 < wumpus> let's merge it or close it and not talk about this for two years or so
11:27 < jonasschnelli> hehe
11:27 < jonasschnelli> indeed
11:27 < luke-jr> Debian 8 is oldstable?
11:28 < luke-jr> yeah
11:28 < wumpus> Debian 8 ("jessie") — obsolete stable release 
11:28 < wumpus> obsolete
11:29 < MarcoFalke> Then, please someone add a debian_8 travis job. Otherwise this will be broken again
11:29 < jonasschnelli> yes... but we need to expect users run it close to the LTS end... but I'm fine with setting Qt 5.5.1 as min
11:29 < wumpus> I guess it's possible to build through depends still, but we can't support old versions of distributions that are already known to carry old packages forever
11:29 < luke-jr> MarcoFalke: we don't need to support oldstable IMO
11:29 < wumpus> no, we don't need a debian 8 travis job
11:29 < jonasschnelli> Yes. We have the depends build for those
11:29 < MarcoFalke> ok, action merge
11:30 < jonasschnelli> ack
11:30 < wumpus> ack
11:30 < wumpus> any other topics?
11:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:31 < bitcoin-git> [bitcoin] jonasschnelli pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/9b1df4ba0bec...758c6d784da0
11:31 < bitcoin-git> bitcoin/master 9975282 Luke Dashjr: GUI: If BIP70 is disabled, attempt to fall back to BIP21 parsing
11:31 < bitcoin-git> bitcoin/master 113f000 Luke Dashjr: GUI: If BIP70 is disabled, give a proper error when trying to open a payme...
11:31 < bitcoin-git> bitcoin/master 84f5315 Luke Dashjr: Travis: Add test without BIP70 (but still full wallet + tests)
11:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:32 < bitcoin-git> [bitcoin] jonasschnelli merged pull request #15063: GUI: If BIP70 is disabled, attempt to fall back to BIP21 parsing (master...bip70_fallback_to_bip21) https://github.com/bitcoin/bitcoin/pull/15063
11:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:33 < wumpus> I guess not
11:34 < wumpus> #endmeeting
11:34 < jonasschnelli> looks like
11:34 < lightningbot> Meeting ended Thu Feb 14 19:34:14 2019 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
11:34 < lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-02-14-19.00.html
11:34 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-02-14-19.00.txt
11:34 < lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-02-14-19.00.log.html
11:34 < instagibbs> When is 0.18 branch date again
11:34 < jonasschnelli> https://github.com/bitcoin/bitcoin/issues/14438
11:34 < wumpus> 2019-03-01
11:34 < instagibbs> thx
11:34 < instagibbs> feature freeze 15 kk
11:35 < wumpus> yes, I mentioned this earlier in the meeting, please pay attention :-)
11:35 < jonasschnelli> a lot to review and merge until tomorrow. :)
11:35 < instagibbs> wumpus, yes sensei
11:35 < wumpus> lol
11:42 < wumpus> please use the leftover meeting time to review feature PRs <3
11:43 < sipa> what is the deal with appveyor failures? (sorry if i missed that)
11:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:43 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #15410: test: txindex: interrupt threadGroup before calling destructor (master...Mf1902-testIndexInterr) https://github.com/bitcoin/bitcoin/pull/15410
11:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:44 -!- mistergo1d [~mistergol@77.243.22.147] has joined #bitcoin-core-dev
11:44 < meshcollider> Ooh github has a new "draft PR" feature
11:44 < meshcollider> Handy for WIP PRs
11:44 < achow101> meshcollider: what's it do?
11:44 -!- VitorB [32d04929@gateway/web/freenode/ip.50.208.73.41] has quit [Ping timeout: 256 seconds]
11:44 < meshcollider> Can't be merged until its marked as ready
11:44 < MarcoFalke> sipa: Appveyor should be fixed
11:45 < sipa> ah thanks
11:45 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.3]
11:45 < meshcollider> https://github.blog/2019-02-14-introducing-draft-pull-requests/
11:47 -!- mistergold [~mistergol@77.243.22.147] has quit [Ping timeout: 245 seconds]
11:48 -!- mistergo1d [~mistergol@77.243.22.147] has quit [Client Quit]
11:48 -!- Karyon [~karyon@unaffiliated/karyon] has quit [Quit: Leaving]
11:48 < instagibbs> ah, gitlab has similar(WIP is actually enforced)
11:48 -!- mistergold [~mistergol@77.243.22.147] has joined #bitcoin-core-dev
11:48 < aj> meshcollider: nifty
11:49 < instagibbs> if you have any fixup! commits it also marks it as WIP
11:53 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
11:55 -!- sschall [c43414e3@gateway/web/freenode/ip.196.52.20.227] has joined #bitcoin-core-dev
12:00 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection]
12:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:02 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #15411: travis: Combine --disable-bip70 into existing job (master...Mf1902-travisBIP70) https://github.com/bitcoin/bitcoin/pull/15411
12:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:03 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
12:15 -!- sschall [c43414e3@gateway/web/freenode/ip.196.52.20.227] has quit [Ping timeout: 256 seconds]
12:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:18 < bitcoin-git> [bitcoin] jonasschnelli pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/758c6d784da0...3b33cbc2b60d
12:18 < bitcoin-git> bitcoin/master fd46c4c Sjors Provoost: Bump minimum Qt version to 5.5.1
12:18 < bitcoin-git> bitcoin/master 3b33cbc Jonas Schnelli: Merge #15393: build: Bump minimum Qt version to 5.5.1
12:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:19 < bitcoin-git> [bitcoin] jonasschnelli merged pull request #15393: build: Bump minimum Qt version to 5.5.1 (master...2019/02/qt-5_5) https://github.com/bitcoin/bitcoin/pull/15393
12:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:30 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds]
12:41 < wumpus> meshcollider "Can't be merged until its marked as ready" -> heh, [wip] in the PR title works just as well in practice 
12:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:47 < bitcoin-git> [bitcoin] jonasschnelli pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/3b33cbc2b60d...b7456e6bf9d1
12:47 < bitcoin-git> bitcoin/master f6122ab João Barbosa: interfaces: Add remove to Wallet
12:47 < bitcoin-git> bitcoin/master f77ba34 João Barbosa: gui: Add closeWallet to WalletController
12:47 < bitcoin-git> bitcoin/master 94086fb João Barbosa: gui: Add close wallet action
12:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:47 < bitcoin-git> [bitcoin] jonasschnelli merged pull request #15195: gui: Add Close Wallet action (master...2019-01-closewallet) https://github.com/bitcoin/bitcoin/pull/15195
12:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:05 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has quit [Quit: (https://github.com/mmgen) leaving]
13:10 -!- phwalkr [~phwalkr@192.32.61.94.rev.vodafone.pt] has quit [Quit: Leaving...]
13:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:12 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b7456e6bf9d1...cd8ca8be31ab
13:12 < bitcoin-git> bitcoin/master 7257353 Pieter Wuille: Select orphan transaction uniformly for eviction
13:12 < bitcoin-git> bitcoin/master cd8ca8b MarcoFalke: Merge #14626: Select orphan transaction uniformly for eviction
13:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:12 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #14626: Select orphan transaction uniformly for eviction (master...201810_uniform_orphan_eviction) https://github.com/bitcoin/bitcoin/pull/14626
13:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:18 < bitcoin-git> [bitcoin] laanwj pushed 4 commits to master: https://github.com/bitcoin/bitcoin/compare/cd8ca8be31ab...3facd9fdc4dd
13:18 < bitcoin-git> bitcoin/master 314784a MeshCollider: Make listunspent and signrawtransaction RPCs support witnessScript
13:18 < bitcoin-git> bitcoin/master 928beae MeshCollider: Add test for P2SH-P2WSH in signrawtransactionwithkey and listunspent
13:18 < bitcoin-git> bitcoin/master 6ca836a MeshCollider: Add release note for listunspent P2WSH change
13:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:18 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection]
13:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:18 < bitcoin-git> [bitcoin] laanwj merged pull request #14481: Add P2SH-P2WSH support to listunspent RPC (master...201810_listunspent_wsh) https://github.com/bitcoin/bitcoin/pull/14481
13:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:22 -!- mistergo1d [~mistergol@77.243.22.147] has joined #bitcoin-core-dev
13:23 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Quit: ...time for reboot; brb/bbl'ish...]
13:26 -!- mistergold [~mistergol@77.243.22.147] has quit [Ping timeout: 240 seconds]
13:27 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev
13:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:28 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/3facd9fdc4dd...642bd7bbe747
13:28 < bitcoin-git> bitcoin/master eeeee58 MarcoFalke: travis: Combine --disable-bip70 into existing job
13:28 < bitcoin-git> bitcoin/master 642bd7b MarcoFalke: Merge #15411: travis: Combine --disable-bip70 into existing job
13:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:29 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15411: travis: Combine --disable-bip70 into existing job (master...Mf1902-travisBIP70) https://github.com/bitcoin/bitcoin/pull/15411
13:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:31 < phantomcircuit> gmaxwell, aight how to test that rdseed and rdrand are being used?
13:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:33 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/642bd7bbe747...31f7c6dd2152
13:33 < bitcoin-git> bitcoin/master fa7ca8e MarcoFalke: qa: Add test/fuzz/test_runner.py
13:33 < bitcoin-git> bitcoin/master fa535af MarcoFalke: fuzz: test_runner: Better error message when built with afl
13:33 < bitcoin-git> bitcoin/master 31f7c6d MarcoFalke: Merge #15295: fuzz: Add test/fuzz/test_runner.py and run it in travis
13:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:33 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15295: fuzz: Add test/fuzz/test_runner.py and run it in travis (master...Mf1901-qaFuzz) https://github.com/bitcoin/bitcoin/pull/15295
13:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:35 < phantomcircuit> oh i see
13:35 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection]
13:39 -!- fabianfabian [~fabianfab@D9656CCE.cm-27.dynamic.ziggo.nl] has quit [Quit: Textual IRC Client: www.textualapp.com]
13:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:43 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/31f7c6dd2152...33480c636658
13:43 < bitcoin-git> bitcoin/master 0890339 Sjors Provoost: build: prefer python3.4 even if newer versions are present on the system
13:43 < bitcoin-git> bitcoin/master 33480c6 MarcoFalke: Merge #15285: build: Prefer Python 3.4 even if newer versions are present ...
13:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:43 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15285: build: Prefer Python 3.4 even if newer versions are present on the system (master...2019/01/bitcoin-util-test-python) https://github.com/bitcoin/bitcoin/pull/15285
13:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:49 < achow101> meshcollider: do you think #14021 is RTM?
13:49 < gribble> https://github.com/bitcoin/bitcoin/issues/14021 | Import key origin data through descriptors in importmulti by achow101 · Pull Request #14021 · bitcoin/bitcoin · GitHub
13:51 -!- ap4lmtree- [~ap4lmtree@unaffiliated/ap4lmtree] has joined #bitcoin-core-dev
13:57 < meshcollider> achow101: sipa said he would review it, but I think its RTM if he is busy
13:57 -!- ap4lmtree- [~ap4lmtree@unaffiliated/ap4lmtree] has quit [Quit: Leaving]
13:57 < meshcollider> I was just going to wait for him
13:57 -!- ap4lmtree [ap4lmtree@unaffiliated/ap4lmtree] has quit [Read error: Connection reset by peer]
13:58 -!- ap4lmtree [ap4lmtree@unaffiliated/ap4lmtree] has joined #bitcoin-core-dev
14:03 < meshcollider> achow101: how trivial is the merge conflict between the two?
14:03 < achow101> meshcollider: pretty trivial
14:03 < meshcollider> sweet
14:03 < achow101> IIRC it's just a move in the tests
14:06 < sipa> achow101: on it right now
14:06 < achow101> cool, thanks
14:10 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Read error: Connection reset by peer]
14:10 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
14:12 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
14:33 < meshcollider> achow101: I'll merge 14075 first, then you can address sipa's nits in the rebase if you want to
14:33 < meshcollider> but im happy to merge as-is
14:34 < achow101> 14021 first is cleaner I think
14:34 < meshcollider> ok
14:34 < achow101> looking at the nits now
14:42 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
14:45 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Remote host closed the connection]
14:45 < meshcollider> achow101: are you going to push any nit-fixes or shall I merge now
14:46 < achow101> meshcollider: i'll be pushing fixes in a few minutes
14:46 < meshcollider> ok
14:46 < achow101> also found a bug, forgot a few braches
14:46 < achow101> *braces
14:50 < achow101> meshcollider: pushed
14:50 < achow101> wait, something went wrong
14:55 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev
14:55 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Remote host closed the connection]
15:00 -!- booyah [~bb@193.25.1.157] has quit [Read error: Connection reset by peer]
15:01 -!- booyah [~bb@193.25.1.157] has joined #bitcoin-core-dev
15:05 < achow101> meshcollider: ok, now it should be good to merge
15:08 < gmaxwell> phantomcircuit: check the logs, otherwise -- go instrument the code.
15:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
15:12 < bitcoin-git> [bitcoin] MeshCollider pushed 10 commits to master: https://github.com/bitcoin/bitcoin/compare/33480c636658...8d0ec74801f7
15:12 < bitcoin-git> bitcoin/master c45415f Andrew Chow: Refactor keymetadata writing to a separate method
15:12 < bitcoin-git> bitcoin/master e7652d3 Andrew Chow: Add WriteHDKeypath function and move *HDKeypath to util/bip32.{h,cpp}
15:12 < bitcoin-git> bitcoin/master bac8c67 Andrew Chow: Add a method to CWallet to write just CKeyMetadata
15:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
15:12 -!- cluelessperson [~cluelessp@unaffiliated/cluelessperson] has quit [Ping timeout: 258 seconds]
15:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
15:12 < bitcoin-git> [bitcoin] MeshCollider merged pull request #14021: Import key origin data through descriptors in importmulti (master...import-multi-hd) https://github.com/bitcoin/bitcoin/pull/14021
15:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
15:12 < meshcollider> ok achow101 please rebase #14075 :)
15:12 < gribble> https://github.com/bitcoin/bitcoin/issues/14075 | Import watch only pubkeys to the keypool if private keys are disabled by achow101 · Pull Request #14075 · bitcoin/bitcoin · GitHub
15:12 < achow101> wohoo
15:13 -!- rex4539 [~rex4539@ppp-2-84-161-162.home.otenet.gr] has quit [Quit: rex4539]
15:17 -!- cluelessperson [~cluelessp@unaffiliated/cluelessperson] has joined #bitcoin-core-dev
15:17 -!- Aequitas_ [447323bd@gateway/web/freenode/ip.68.115.35.189] has joined #bitcoin-core-dev
15:18 -!- jarthur [~jarthur@207.114.244.5] has quit []
15:19 < achow101> meshcollider: rebased. i'm gonna check it against hwi real quick to make sure I didn't screw up anything
15:20 < meshcollider> ok
15:20 < Aequitas_> Hello, is there a valid bitcoin core binary release signing key?  It looks like the key with fingerprint 01EA 5486 DE18 A882 D4C2 6845 90C8 019E 36C2 E964 expired today.
15:21 < meshcollider> Aequitas_: yes, wumpus bumped the key expiry a few days ago
15:22 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
15:27 -!- booyah [~bb@193.25.1.157] has quit [Read error: Connection reset by peer]
15:27 -!- mistergold [~mistergol@77.243.22.147] has joined #bitcoin-core-dev
15:28 -!- booyah [~bb@193.25.1.157] has joined #bitcoin-core-dev
15:30 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
15:31 -!- mistergo1d [~mistergol@77.243.22.147] has quit [Ping timeout: 250 seconds]
15:34 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
15:37 < achow101> meshcollider: it's good to go now
15:42 < Aequitas_> meshcollider: Thanks, is there a published location I can aquire the new key?  https://bitcoincore.org/keys/laanwj-releases.asc is still importing as expired
15:44 < meshcollider> Aequitas_: just use --refresh-keys
15:44 < meshcollider> its the same key, just a different date
15:44 < achow101> Aequitas_: you can get it from any key server
15:45 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev
15:47 -!- mistergo1d [~mistergol@37.19.108.50] has joined #bitcoin-core-dev
15:47 -!- mistergold [~mistergol@77.243.22.147] has quit [Read error: Connection reset by peer]
15:49 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit [Ping timeout: 244 seconds]
15:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
15:52 < bitcoin-git> [bitcoin] MeshCollider pushed 6 commits to master: https://github.com/bitcoin/bitcoin/compare/8d0ec74801f7...c576979b78b5
15:52 < bitcoin-git> bitcoin/master 99cccb9 Andrew Chow: Add a method to add a pubkey to the keypool
15:52 < bitcoin-git> bitcoin/master 9b81fd1 Andrew Chow: Fetch keys from keypool when private keys are disabled
15:52 < bitcoin-git> bitcoin/master 513719c Andrew Chow: Add option to importmulti add an imported pubkey to the keypool
15:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
15:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
15:53 < bitcoin-git> [bitcoin] MeshCollider merged pull request #14075: Import watch only pubkeys to the keypool if private keys are disabled (master...watch-only-keypool) https://github.com/bitcoin/bitcoin/pull/14075
15:53 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
15:54 < achow101> \o/
15:54 < meshcollider> \o/
15:54 < achow101> instagibbs: there's your keypool
15:54 < meshcollider> provoostenator, instagibbs ^
15:54 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 246 seconds]
16:15 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
16:16 -!- Aequitas_ [447323bd@gateway/web/freenode/ip.68.115.35.189] has quit [Quit: Page closed]
16:19 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 250 seconds]
16:20 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 250 seconds]
16:29 < meshcollider> The segwit project (https://github.com/bitcoin/bitcoin/projects/5) is now empty
16:29 < meshcollider> Time to close it?
16:35 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
16:38 < aj> meshcollider: makes sense to me
16:39 < instagibbs> \o/ 
16:39 < instagibbs> still would like descriptor checksums, one more day to get that more review
16:39 < aj> instagibbs: PR?
16:40 -!- schmidty_ [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has joined #bitcoin-core-dev
16:40 < sipa> #15368
16:40 < gribble> https://github.com/bitcoin/bitcoin/issues/15368 | Descriptor checksums by sipa · Pull Request #15368 · bitcoin/bitcoin · GitHub
16:41 -!- holmes [~holmes@66.114.38.58] has joined #bitcoin-core-dev
16:42 -!- jarthur [~jarthur@2605:6000:1019:41ab:7496:9f6a:4d4c:fe99] has joined #bitcoin-core-dev
16:43 < jb55> sipa: what do I have to read to understand the math behind the bech32-style checksums you come up with? looks generally useful...
16:43 < sipa> jb55: i learned most from https://en.wikipedia.org/wiki/BCH_code, plus latent algebra knowledge :)
16:44 < jb55> sipa: thx
16:44 < sipa> jb55: we came up with a bunch of algorithms to opimize searching for parameters, which we probably should make a writeup about
16:44 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 250 seconds]
16:44 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
16:44 -!- schmidty_ [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has quit [Read error: Connection reset by peer]
16:45 -!- holmes [~holmes@66.114.38.58] has quit [Quit: Leaving]
16:46 < jb55> sipa: why you chose this kinda of error correcting code in particular would be good to know as well. would be a great read if you get around to writing it up!
16:46 < aj> https://travis-ci.org/bitcoin/bitcoin/builds/492869085?utm_source=github_status&utm_medium=notification # travis job needs a kick (or maybe two kicks by now)
16:47 < sipa> aj: kicked
16:48 < meshcollider> aj should be in the org so he can do it himself, I thought he was :)
16:48 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Read error: No route to host]
16:49 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
16:49 < gmaxwell> jb55: why 'this kind' is a pretty easy answer: we use a cyclic linear code because after extensive research, it's the only class of code we know of that can achieve good guarentees for the "user makes random single character errors" channel.
16:49 < aj> meshcollider: curses, foiled again
16:50 < gmaxwell> jb55: other kinds of codes, like a simple CRC don't operate at the 5-bit-character level, and so can't guarentee e.g. that a bad input with 3 character errors will be detected.
16:53 < gmaxwell> jb55: and other kinds of codes (like ones constructed from arbritary non-linearities) are computationally intractable-- as far as anyone yet knows-- for detecting as many errors as bech32 does.
16:54 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 258 seconds]
16:54 < gmaxwell> (er, that was unclear, I mean -- for examples-- no one knows how to determine what the minimum distance of an arbritary quasigroup code is, except for the single error case other than by performing an test of all possible error patterns)
16:55 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
17:00 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 246 seconds]
17:02 -!- zhangzf [~zhangzf@106.38.157.147] has joined #bitcoin-core-dev
17:04 < jb55> gmaxwell: ah, interesting... thx.
17:07 < jb55> was wondering why I was dealing with 5bit words when working on a bech32 lib... 
17:07 < jb55> gmaxwell: is there a particular reason it's 5 bits?
17:11 < jb55> oh I see the extra 3 are for error correction
17:12 < gmaxwell> jb55: it's 5 bits because log2(32) is 5. -- the number of bits per character is a product of the character set size.  The character set size is chosen to be relatively small because it makes entering it easier.  Mixed case in base58, for example, makes it really hard to read addresses out loud (e.g. over the phone). 
17:14  * jb55 slowly getting it
17:14 < gmaxwell> The exact character set size could be another value, but (1) if it's a power of two its much easier to convert to and from bytes, since each character represents an integer number of bits.  and (2) for it to be feasable to design a linear error detection code over it, the size must be a prime or a prime raised to some power.  (so base58 is out)
17:14 < sipa> jb55: there are no bytes involved anywhere
17:15 < sipa> everything is 5-bit symbols; both the 'data' and the 'checksum' are 5-bit units
17:15 < jb55> ahh
17:15 < sipa> the reason for that is because we expect errors that are affecting groups of 5 bits simultaneously
17:15 < gmaxwell> Of the character set sizes that allow for easy conversion two and from bytes... 16 characters is overly restrictive (bigger addresses), and 64 is too many (requires using characters that are hard to distinguish/hard to type). 
17:15 < sipa> jb55: because 1 character in base32 = 5 bits
17:16 -!- mistergold [~mistergol@37.19.108.50] has joined #bitcoin-core-dev
17:17 < gmaxwell> A pretty good case could have been made for base-31, base-29, or base-27-- which would allow excluding some more visually similar characters without being much longer, but the code to convert from binary data into those bases is somewhat irritating. 
17:20 -!- mistergo1d [~mistergol@37.19.108.50] has quit [Ping timeout: 240 seconds]
17:21 < jb55> and 7 bits wouldn't work because the character set size would be too large... 3 would be too verbose. and the log of other bases are fractional so conversion is annoying, if I'm getting this right
17:21 < sipa> indeed
17:21 < sipa> 6 bits would work too; base64 is pretty common, but it means mixing upper and lowercase
17:22 < sipa> there are only 94 printable ascii characters, so 7 bits is kinda out
17:22 < sipa> unless you want to mix in things like poop emoji
17:27 < jb55> gotta capture that millenial market, should have went with basemoji
17:27 < gmaxwell> mixed case is hard to read, also irritating to type on mobile devices, also results in more similar character mistakes.
17:27 -!- jarthur [~jarthur@2605:6000:1019:41ab:7496:9f6a:4d4c:fe99] has quit [Remote host closed the connection]
17:28 -!- jarthur [~jarthur@2605:6000:1019:41ab:7496:9f6a:4d4c:fe99] has joined #bitcoin-core-dev
17:29 < gmaxwell> if your metric is "how long does it take to successfully transfer 200 bits of data between two humans, where one reads and speaks the other hears and types" a base somewhere between 25 and 32 is likely optimum. 
17:30 < gmaxwell> more than 32 and you're forced to use easily confused characters (and/or prefixing every letter with "upper" "lower" and causing a 2x slowdown) 
17:31 < jb55> base32 is my go-to, although I use a modified variant that replaces o,i with 8,9. I always thought that choice was kind of odd in the standard base32 encoding.
17:31 < gmaxwell> If your metric is copy and paste, the length/characters hardly matter except non-alphanum characters break the automatic copy boundary behavior in browsers.
17:32 < gmaxwell> jb55: there are like a half dozen different base32s that replace different characters. 
17:32 < jb55> although it's not optimized phonetically, would be interesting to see a character set that is ideal for voice transcription instead of visual.
17:32 -!- mistergo1d [~mistergol@37.19.108.50] has joined #bitcoin-core-dev
17:33 -!- Karyon [~karyon@unaffiliated/karyon] has joined #bitcoin-core-dev
17:33 < gmaxwell> Our ommited characters are basied on minimizing visual confusion according to some NIST data.  Though later a research paper came out and had confusion data generated from millions of password entry attempts and it gave essentially the same results.
17:34 < gmaxwell> At least my thinking was the the visual component is always there (for human based transcription), while speaking is not always used.  Also, speaking errors depend a lot on your accient and/or if you're using something like the NATO phonetic alphabet (alpha bravo charley delta echo foxtrot..)
17:35 < gmaxwell> I think if that password entry data were available we would have used it instead of the NIST data, but I reran the analysis using it and got essentially the same result.
17:35 -!- mistergold [~mistergol@37.19.108.50] has quit [Ping timeout: 245 seconds]
17:37 -!- cubancorona [cubancoron@gateway/vpn/privateinternetaccess/cubancorona] has joined #bitcoin-core-dev
17:40  * jb55 thinking about an address format encoded as poetry
17:41  * sipa mentions https://github.com/sipa/gramtropy
17:41 < jb55> sipa always with the one ups
17:43 < gmaxwell> (I think also if we had the password data I would have spent more time exploring e.g. base-27, since we actually would have had a good criteria to use to exclude more characters)
17:48 < gmaxwell> One thing we were able to do in base-32 was make it so that if you only made the most likely mistakes then we are guarenteed to detect one more error. (we did this by choosing a character permutation that mapped the most likely errors to single bit errors, and choosing the code to also support up to 6 one bit errors)... this would have likely worked even better in base-27
17:49 -!- mistergo1d [~mistergol@37.19.108.50] has quit [Quit: leaving]
17:49 < gmaxwell> (both because we could exclude more characters outright, and because the analog would be mapping them to a single-trit error out of three trits per symbol.)
17:53 < jb55> gmaxwell: sounds kind of like compression wrt. most common symbols assigned to shorter prefix bit sequences? in this case instead of most common symbols you're describing most common human error symbols?
17:53 < jb55> if I'm understanding correctly
17:54 < gmaxwell> jb55: https://github.com/bitcoin/bips/blob/master/bip-0173.mediawiki#Bech32  no, look at the table there.  Visually similar characters like q/g or q/p are arranged so that their value differes only by 1 bit.
17:54 < jb55> ohh
17:54 < gmaxwell> (the table is dimensioned so that it's relatively easy to see the 5 dimensional 1-bit-difference hypercube...)
17:56 < gmaxwell> r/t r/y 8/0 c/e 8/h  almost all of the easier mistakes map to one bit differences.
17:58 < jb55> gmaxwell: so the smaller bit difference the less ambiguity in detecting which symbol has the error?
17:58 < sipa> jb55: the checksum itself was optimized to be slightly better for low-bit-error
17:58 < sipa> this is not an inherent property; it was selected for
17:59 < gmaxwell> the bech32 checksum will always detect if there are no more than 5 characters wrong,  ... or if there are no more than 6 bits wrong.
17:59 < gmaxwell> we specifically designed it for this behavior.
18:00 < jb55> and by designed you're referring to which symbol is assigned to which 5 bit number?
18:00 < sipa> no, the BCH code
18:00 < jb55> ah
18:00 < sipa> the character set was designed so that common errors are 1 bit only
18:00 < gmaxwell> Picking the symbol ordering lets us map common mistakes to single bit errors.
18:00 < sipa> the BCH code was designed to that 1 bit errors are more frequently detected
18:00 < gmaxwell> Picking the error correcting code let us pick one that would detect 6-one bit errors.
18:01 < sipa> the two are designed for each other
18:01 < gmaxwell> there were many possible codes which have exactly equal performance for detecting whole character errors, but one of them also did better for bit errors.
18:01 < jb55> picking a BCH code involves what, picking constants?
18:02 < sipa> jb55: effectively, picking the generator
18:02 < sipa> every cyclic code is uniquely characterized by its field representation and generator
18:02 < gmaxwell> this line in the BIP:
18:02 < gmaxwell>   GEN = [0x3b6a57b2, 0x26508e6d, 0x1ea119fa, 0x3d4233dd, 0x2a1462b3]
18:02 < gmaxwell> mostly
18:03  * jb55 goes to learn about galois fields
18:04 < jb55> thx guys this makes a lot more sense now
18:12 -!- Mischa010 [4dadf2fe@gateway/web/freenode/ip.77.173.242.254] has joined #bitcoin-core-dev
18:13 < Mischa010> hi there, does anyone here know to how many peers bitcoin sends new blocks in general?
18:13 < sipa> all.
18:13 < Mischa010> i know 8 peers are connected to but how many can actually request and download a block at the same time?
18:13 < Mischa010> i forgot the 'at the same time' qualifier!
18:14 < gmaxwell> Mischa010: 8 peers are the number of outbound connections a node normally has, but they can have many more inbound. 70 inbound isn't uncommon.
18:14 < sipa> Mischa010: this sounds like a question for https://bitcoin.stackexchange.com
18:14 < gmaxwell> it's actually been answered in a number of forms on stack exchange before.
18:14 < Mischa010> so there could be 70 downloading a block from a node at the same time?
18:15 < gmaxwell> Mischa010: for the most part blocks aren't even transfered. because magic.
18:15 < Mischa010> yes compact blocks is great
18:16 < Mischa010> incidentally, thanks for all the great work!
18:16 < gmaxwell> but yes, 70... as many as 125 in the default config, in fact... could be transfered at the 'same time'. 
18:16 < gmaxwell> because of how tcp works you cannot generally achieve capacity without many concurrent streams in any case.
18:17 < Mischa010> yes that's true
18:17 < gmaxwell> as each one will only send one rwin worth before having to wait for an ack.
18:17 < Mischa010> although couldn't you just determine and set some maximum mtu per connection?
18:17 < gmaxwell> fwiw, node here with uptime of a week has not send a single whole block to any peer.
18:17 < Mischa010> nice
18:18 < Mischa010> but i guess starting with a big mtu has its own problems
18:18 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
18:18 < gmaxwell> Mischa010: depends on link speeds, packet loss rates, remote tcp stack rwin value, all of which aren't observable generally.
18:18 < Mischa010> yes
18:20 < gmaxwell> (or at least not very observable at the application layer without non-portable os specific code)
18:20 < gmaxwell> in any case, I know there is a stackexchange question on the "why doesn't it just send to one peer at a time?" question
18:21 < Mischa010> assuming an ideal network you should propagate to e nodes
18:21 < Mischa010> at a time
18:21 < Mischa010> i just came up with this so it might be very wrong
18:21 < Mischa010> so in practice 2
18:22 < sipa> https://bitcoin.stackexchange.com/questions/81531/did-bitcoin-core-relay-blocks-sequentially-or-in-parallel-to-peers-before-compac/81533#81533
18:22 < gribble> https://github.com/bitcoin/bitcoin/issues/81533 | HTTP Error 404: Not Found
18:22 < sipa> lol
18:23 < gmaxwell> thats too narrow thinking, e.g. assuming a homogeneous network (equal speeds, equal delays on all links), fibre shows that the optimal distribution pattern (shortest time to reach all nodes) is achieved by round robining packets one at a time equally to each peer.
18:24 < gmaxwell> because they'll each send the recieved packets to each of their peers. spreading more slowly than that fails to achieve the maximum bisection bandwidth of the network.
18:25 < gmaxwell> (on an inhomogeneous network it's more complicated)
18:26 < Mischa010> interesting, is there any literature on this?
18:27 < gmaxwell> bitcoin specific, not that I'm aware of. There is a lot of lit on 'network coding' though, which covers many of these things.
18:30 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
18:30 < Mischa010> great, im reading up on fibre now
18:31 < Mischa010> thanks
18:31 < gmaxwell> the writeup I made on stack exchange is probably one of the better ones.
18:31 < Mischa010> link?
18:31 < gmaxwell> https://bitcoin.stackexchange.com/questions/56485/can-someone-please-explain-fibre-to-me-like-im-5-and-why-is-it-useful/56494
18:32 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.]
18:33 < gmaxwell> fibre gets pretty close to the best possible performance (consistently within a couple ms of the one way link delays between nodes)... there are a long list of potential improvements, but most of them end up making it work worse because they take more cpu time than they save. :(
18:44 < Mischa010> ah yes i wasnt thinking at the packet level
18:45 < Mischa010> an interface only sends one packet at a time right?
18:46 < Mischa010> then my point is moot :p
18:48 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
18:49 -!- skyikot [~skyikot@gateway/tor-sasl/skyikot] has joined #bitcoin-core-dev
19:03 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
19:03 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 246 seconds]
19:08 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
19:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
19:10 < bitcoin-git> [bitcoin] yunchiri closed pull request #15396: docs: make it clearer that posix mode must be used in WSL (master...patch-1) https://github.com/bitcoin/bitcoin/pull/15396
19:10 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
19:12 -!- ap4lmtree [ap4lmtree@unaffiliated/ap4lmtree] has quit [Read error: Connection reset by peer]
19:13 -!- Mischa010 [4dadf2fe@gateway/web/freenode/ip.77.173.242.254] has quit [Quit: Page closed]
19:18 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
19:23 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 258 seconds]
19:25 -!- Karyon [~karyon@unaffiliated/karyon] has quit [Ping timeout: 250 seconds]
19:46 -!- ap4lmtree [ap4lmtree@unaffiliated/ap4lmtree] has joined #bitcoin-core-dev
19:52 -!- Guest36088 [7c418202@gateway/web/freenode/ip.124.65.130.2] has joined #bitcoin-core-dev
19:56 -!- Guest36088 [7c418202@gateway/web/freenode/ip.124.65.130.2] has quit [Quit: Page closed]
20:26 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev
20:28 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
20:37 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
20:39 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
20:40 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection]
20:47 -!- skyikot [~skyikot@gateway/tor-sasl/skyikot] has quit [Ping timeout: 256 seconds]
21:01 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
21:12 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 245 seconds]
21:40 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds]
21:51 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 258 seconds]
21:59 -!- stepa[m] [stepamatri@gateway/shell/matrix.org/x-eypjvudbwttoucom] has joined #bitcoin-core-dev
22:24 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
22:40 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
22:57 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 272 seconds]
23:05 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
23:45 -!- TheHoliestRoger [~TheHolies@unaffiliated/theholiestroger] has quit [Remote host closed the connection]
23:46 -!- TheHoliestRoger [~TheHolies@unaffiliated/theholiestroger] has joined #bitcoin-core-dev
23:48 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
--- Log closed Fri Feb 15 00:00:50 2019