--- Log opened Wed Feb 20 00:00:54 2019
00:38 -!- skyikot [~skyikot@gateway/tor-sasl/skyikot] has joined #bitcoin-core-dev
00:39 -!- skyikot [~skyikot@gateway/tor-sasl/skyikot] has quit [Client Quit]
00:39 -!- skyikot [~skyikot@gateway/tor-sasl/skyikot] has joined #bitcoin-core-dev
00:39 -!- skyikot [~skyikot@gateway/tor-sasl/skyikot] has quit [Client Quit]
00:48 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 246 seconds]
00:49 < provoostenator> Speaking of discouring address reuse, too late for v0.18 but otherwise pretty close to finish line: #13756
00:49 < gribble> https://github.com/bitcoin/bitcoin/issues/13756 | wallet: "avoid_reuse" wallet flag for improved privacy by kallewoof · Pull Request #13756 · bitcoin/bitcoin · GitHub
00:49 < provoostenator> *discouraging
00:53 -!- skyikot [~skyikot@gateway/tor-sasl/skyikot] has joined #bitcoin-core-dev
01:02 < provoostenator> It would help if more people, who work on functional tests, installed PyEnv. #14884 is only a partial solution to preventing too modern Python syntax from entering the codebase.  
01:02 < gribble> https://github.com/bitcoin/bitcoin/issues/14884 | Travis: enforce Python 3.4 support through linter by Sjors · Pull Request #14884 · bitcoin/bitcoin · GitHub
01:03 < provoostenator> Otherwise we should probably install PyEnv on one of the Travis machines which run the test suite.
01:11 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev
01:19 < provoostenator> #15439 fixes the exsting issues
01:19 < gribble> https://github.com/bitcoin/bitcoin/issues/15439 | tests: remove byte.hex() to keep compatibility by AkioNak · Pull Request #15439 · bitcoin/bitcoin · GitHub
01:31 -!- DougieBot5000_ [~DougieBot@unaffiliated/dougiebot5000] has joined #bitcoin-core-dev
01:31 -!- DougieBot5000 [~DougieBot@unaffiliated/dougiebot5000] has quit [Killed (verne.freenode.net (Nickname regained by services))]
01:31 -!- DougieBot5000_ is now known as DougieBot5000
01:40 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev
01:41 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
01:54 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has joined #bitcoin-core-dev
01:59 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has quit [Ping timeout: 255 seconds]
02:06 -!- emilr [~emilr@unaffiliated/goregrind] has joined #bitcoin-core-dev
02:08 -!- skyikot [~skyikot@gateway/tor-sasl/skyikot] has quit [Ping timeout: 256 seconds]
02:09 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
02:11 -!- trotski2000 [uid206086@gateway/web/irccloud.com/x-kjqfdeqqqbimsgcg] has joined #bitcoin-core-dev
02:25 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
02:32 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-sztoaakskooyefnq] has joined #bitcoin-core-dev
02:39 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has joined #bitcoin-core-dev
02:44 -!- booyah [~bb@193.25.1.157] has quit [Ping timeout: 246 seconds]
02:45 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
02:52 -!- zhangzf_ [~zhangzf@106.38.157.147] has quit [Remote host closed the connection]
02:53 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
02:59 -!- booyah [~bb@193.25.1.157] has joined #bitcoin-core-dev
03:02 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev
03:09 -!- hex17or [~hex17or@HSI-KBW-091-089-197-016.hsi2.kabel-badenwuerttemberg.de] has quit [Ping timeout: 246 seconds]
03:36 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 240 seconds]
03:37 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
03:44 < jl2012> luke-jr: which part do you not understand?
03:46 < jl2012> I think what you want is the ability to tell the payer not to reuse a specific address?
03:56 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 250 seconds]
03:58 < luke-jr> jl2012: no addresses should ever be reused
04:00 < luke-jr> jl2012: but there was a rather long convo here yesterday, not sure it's productive to go over again unless there's something new to add
04:00 < jl2012> alright, I'll read it first
04:03 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
04:15 -!- hex17or [~hex17or@HSI-KBW-091-089-197-016.hsi2.kabel-badenwuerttemberg.de] has joined #bitcoin-core-dev
04:21 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 244 seconds]
04:25 -!- zivl [~zivl@unaffiliated/zivl] has quit [Ping timeout: 264 seconds]
04:26 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 240 seconds]
04:33 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
04:38 -!- Empact [~empact@192-195-80-225.PUBLIC.monkeybrains.net] has quit [Remote host closed the connection]
04:39 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
04:40 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 250 seconds]
04:40 -!- Empact [~empact@192-195-80-225.PUBLIC.monkeybrains.net] has joined #bitcoin-core-dev
04:41 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 250 seconds]
04:42 -!- ppisati_ [~ppisati@uk.sesame.canonical.com] has joined #bitcoin-core-dev
04:44 -!- zhangzf [~zhangzf@223.72.47.218] has joined #bitcoin-core-dev
04:48 -!- siom [~siom@83.97.23.43] has joined #bitcoin-core-dev
04:50 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 245 seconds]
04:52 -!- zivl [~zivl@unaffiliated/zivl] has joined #bitcoin-core-dev
05:05 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
05:06 -!- Aaronvan_ is now known as AaronvanW
05:17 -!- promag [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection]
05:24 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
05:26 -!- m4 [~m4@188.147.111.236.nat.umts.dynamic.t-mobile.pl] has joined #bitcoin-core-dev
05:27 -!- trillhc [~trillhc@c-71-232-65-53.hsd1.ma.comcast.net] has quit [Ping timeout: 250 seconds]
05:29 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 255 seconds]
05:29 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
05:37 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
05:40 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
05:47 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev
06:09 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
06:12 -!- jtimon [~quassel@119.24.134.37.dynamic.jazztel.es] has joined #bitcoin-core-dev
06:13 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
06:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:19 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/38429c4b6228...f9775a865597
06:19 < bitcoin-git> bitcoin/master 1a062b8 Akio Nakamura: tests: remove byte.hex() to keep compatibility
06:19 < bitcoin-git> bitcoin/master f9775a8 MarcoFalke: Merge #15439: tests: remove byte.hex() to keep compatibility
06:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:20 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
06:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
06:20 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15439: tests: remove byte.hex() to keep compatibility (master...keep_compatiblity) https://github.com/bitcoin/bitcoin/pull/15439
06:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
06:25 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 268 seconds]
06:25 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 268 seconds]
06:25 -!- Soligor [~soligor@unaffiliated/soligor] has quit [Remote host closed the connection]
06:28 -!- millerti [~millerti@cpe-66-24-91-119.stny.res.rr.com] has joined #bitcoin-core-dev
06:29 -!- ap4lmtree [ap4lmtree@unaffiliated/ap4lmtree] has quit [Ping timeout: 255 seconds]
06:31 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev
06:35 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
06:41 -!- Soligor [~soligor@unaffiliated/soligor] has joined #bitcoin-core-dev
06:42 -!- promag_ [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev
06:48 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
06:51 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
06:54 -!- ppisati_ [~ppisati@uk.sesame.canonical.com] has quit [Quit: leaving]
06:56 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds]
07:06 -!- m4 [~m4@188.147.111.236.nat.umts.dynamic.t-mobile.pl] has quit [Quit: Leaving]
07:10 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
07:10 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
07:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:17 < bitcoin-git> [bitcoin] ryanofsky opened pull request #15448: bitcoin-cli: Eliminate "Error parsing JSON" errors (master...pr/unistr) https://github.com/bitcoin/bitcoin/pull/15448
07:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:32 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/]
07:32 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
07:32 -!- zhangzf [~zhangzf@223.72.47.218] has quit [Remote host closed the connection]
07:37 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
07:45 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
07:49 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
07:56 < promag_> sipa: could you see #15443?
07:56 < gribble> https://github.com/bitcoin/bitcoin/issues/15443 | qa: Add getdescriptorinfo functional test by promag · Pull Request #15443 · bitcoin/bitcoin · GitHub
07:58 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
08:03 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Remote host closed the connection]
08:12 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev
08:15 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has joined #bitcoin-core-dev
08:24 -!- ap4lmtree [ap4lmtree@unaffiliated/ap4lmtree] has joined #bitcoin-core-dev
08:39 -!- sfhi [~sfhi@178.255.154.107] has joined #bitcoin-core-dev
08:56 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev
09:01 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has joined #bitcoin-core-dev
09:01 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has quit [Remote host closed the connection]
09:02 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has joined #bitcoin-core-dev
09:02 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
09:09 -!- phwalkr [~phwalkr@fwalunos-vip.estig.ipb.pt] has joined #bitcoin-core-dev
09:14 -!- phwalkr [~phwalkr@fwalunos-vip.estig.ipb.pt] has quit [Client Quit]
09:15 -!- ap4lmtree [ap4lmtree@unaffiliated/ap4lmtree] has quit [Read error: Connection reset by peer]
09:17 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 246 seconds]
09:24 -!- ap4lmtree [ap4lmtree@unaffiliated/ap4lmtree] has joined #bitcoin-core-dev
09:31 -!- jtimon [~quassel@119.24.134.37.dynamic.jazztel.es] has quit [Quit: gone]
09:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:45 < bitcoin-git> [bitcoin] achow101 opened pull request #15450: [GUI] Create wallet menu option (master...gui-create-wallet) https://github.com/bitcoin/bitcoin/pull/15450
09:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:47 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
10:02 -!- jungly [~quassel@79.8.200.97] has quit [Remote host closed the connection]
10:16 -!- fabianfabian [~fabianfab@D9656CCE.cm-27.dynamic.ziggo.nl] has joined #bitcoin-core-dev
10:23 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Read error: Connection reset by peer]
10:30 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.3]
10:33 -!- sfhi [~sfhi@178.255.154.107] has quit [Quit: Leaving]
10:42 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
10:42 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev
10:49 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 255 seconds]
10:50 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Remote host closed the connection]
10:50 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
10:52 -!- Empact [~empact@192-195-80-225.PUBLIC.monkeybrains.net] has quit [Ping timeout: 272 seconds]
10:56 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 268 seconds]
10:57 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
11:02 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 246 seconds]
11:02 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
11:24 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
11:31 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
11:31 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
11:50 -!- trotski2000 [uid206086@gateway/web/irccloud.com/x-kjqfdeqqqbimsgcg] has quit [Quit: Connection closed for inactivity]
11:55 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
12:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:01 < bitcoin-git> [bitcoin] HashUnlimited opened pull request #15451: [doc] clarify getdata limit after #14897 (master...patch-2) https://github.com/bitcoin/bitcoin/pull/15451
12:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:21 -!- edwardmoncada [ac3828da@gateway/web/freenode/ip.172.56.40.218] has joined #bitcoin-core-dev
12:27 -!- Empact [~empact@192-195-80-225.PUBLIC.monkeybrains.net] has joined #bitcoin-core-dev
12:30 -!- edwardmoncada [ac3828da@gateway/web/freenode/ip.172.56.40.218] has quit [Ping timeout: 256 seconds]
12:41 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
12:56 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
13:09 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds]
13:21 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Remote host closed the connection]
13:25 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
13:26 -!- fabianfabian [~fabianfab@D9656CCE.cm-27.dynamic.ziggo.nl] has quit [Quit: Textual IRC Client: www.textualapp.com]
13:30 -!- fabianfabian [~fabianfab@D9656CCE.cm-27.dynamic.ziggo.nl] has joined #bitcoin-core-dev
13:34 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 246 seconds]
13:36 -!- fabianfabian [~fabianfab@D9656CCE.cm-27.dynamic.ziggo.nl] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
13:37 -!- fabianfabian [~fabianfab@D9656CCE.cm-27.dynamic.ziggo.nl] has joined #bitcoin-core-dev
13:38 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has quit [Quit: (https://github.com/mmgen) leaving]
13:51 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
14:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:01 < bitcoin-git> [bitcoin] instagibbs opened pull request #15452: Replace CScriptID and CKeyID in CTxDestination with dedicated types (master...key_script_dest) https://github.com/bitcoin/bitcoin/pull/15452
14:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:07 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.3]
14:13 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-sztoaakskooyefnq] has quit [Quit: Connection closed for inactivity]
14:22 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 245 seconds]
14:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
14:30 < bitcoin-git> [bitcoin] achow101 opened pull request #15454: Remove the automatic creation and loading of the default wallet (master...no-default-wallet) https://github.com/bitcoin/bitcoin/pull/15454
14:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
14:31 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
14:36 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection]
14:38 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has quit [Ping timeout: 268 seconds]
14:39 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
14:39 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
14:39 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
14:46 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev
14:49 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
14:50 -!- fabianfabian [~fabianfab@D9656CCE.cm-27.dynamic.ziggo.nl] has quit [Quit: Textual IRC Client: www.textualapp.com]
14:57 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
14:59 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
15:18 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 244 seconds]
15:20 -!- skyikot [~skyikot@gateway/tor-sasl/skyikot] has joined #bitcoin-core-dev
15:24 -!- siom [~siom@83.97.23.43] has quit [Remote host closed the connection]
15:32 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 268 seconds]
15:39 -!- jarthur [~jarthur@207.114.244.5] has quit []
16:01 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has quit [Remote host closed the connection]
16:17 -!- drexl [~drexl@cpc130676-camd16-2-0-cust445.know.cable.virginm.net] has quit [Quit: drexl]
16:22 -!- shesek`` is now known as shesek
16:22 -!- shesek [~shesek@5.22.134.245] has quit [Changing host]
16:22 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
16:28 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection]
16:28 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
16:33 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has quit [Ping timeout: 246 seconds]
16:33 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 264 seconds]
16:34 -!- DeanGuss [~deanguss@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
16:34 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Read error: Connection reset by peer]
16:35 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
16:36 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Read error: Connection reset by peer]
16:36 -!- Empact [~empact@192-195-80-225.PUBLIC.monkeybrains.net] has quit [Read error: Connection reset by peer]
16:37 -!- Empact [~empact@192-195-80-225.PUBLIC.monkeybrains.net] has joined #bitcoin-core-dev
16:37 < promag_> achow101: do you have a newer Qt version available 
16:37 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
16:37 < achow101> promag_: I can do a depends build
16:38 -!- promag [~promag@bl22-246-44.dsl.telepac.pt] has quit []
16:38 -!- promag_ is now known as promag
16:39 -!- Lauda [~quassel@unaffiliated/lauda] has quit [Remote host closed the connection]
16:39 < promag> achow101: when I was doing #15153 usually I tested with -nowallet
16:39 < gribble> https://github.com/bitcoin/bitcoin/issues/15153 | gui: Add Open Wallet menu by promag · Pull Request #15153 · bitcoin/bitcoin · GitHub
16:39 < promag> it is kind of a surprise to see your behavior
16:40 < promag> I don't see any reason to be different with Qt 5.7 to be honest
16:41 -!- Lauda [~quassel@unaffiliated/lauda] has joined #bitcoin-core-dev
16:42 < promag> is 5.7 what comes with debian
16:43 < promag> ?
16:43 < achow101> I think so
16:43 < promag> I'm downloading debian now to check it out
16:44 < promag> btw I'm working on top of your branch
16:44 < promag> gui-create-wallet
16:47 < achow101> originally I thought it was a problem with my branch, but i checked with my build of the master branch and it had the same problem
16:48 < promag> and there is nothing in .conf that could interfere?
16:49 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev
16:50 < achow101> hmm. there's a wallet specified in there
16:51 < achow101> well commenting that out didn't change anything
16:54 < promag> I'll let you know how my debian test went
16:54 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
16:55 < booyah> promag: https://packages.debian.org/stretch/qtbase5-dev
16:55 < booyah> 5.7.1 (plus custom patches)
17:00 < promag> booyah: ty
17:01 -!- shesek [~shesek@unaffiliated/shesek] has quit [Excess Flood]
17:01 -!- Empact [~empact@192-195-80-225.PUBLIC.monkeybrains.net] has quit [Ping timeout: 250 seconds]
17:01 -!- Empact_ [~empact@192-195-80-225.PUBLIC.monkeybrains.net] has joined #bitcoin-core-dev
17:01 -!- shesek [~shesek@5.22.134.245] has joined #bitcoin-core-dev
17:01 -!- shesek [~shesek@5.22.134.245] has quit [Changing host]
17:01 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
17:10 < achow101> promag: the depends build works. it doesn't have that issue
17:10 < achow101> so it must be some problem with 5.7.1
17:11 < promag> mother of god
17:13 < achow101> promag: when I was testing gui-create-wallet, if i used the create wallet option when -nowallet was set, it would create the wallet and load it
17:14 < achow101> the only difference between that and the open wallet option when it comes to loading the wallet is that open wallet uses a signal to call setCurrentWallet while create wallet called it directly
17:16 < achow101> and then open wallet works fine if used after create wallet
17:19 -!- millerti [~millerti@cpe-66-24-91-119.stny.res.rr.com] has quit [Ping timeout: 272 seconds]
17:20 < promag> achow101: there is currently a problem
17:21 < promag> this was already identified
17:21 < promag> https://github.com/achow101/bitcoin/blob/668aa51d2bbb1911ebc83b84fb8209c54e108a69/src/qt/walletframe.cpp#L81
17:21 -!- zhangzf [~zhangzf@106.38.157.147] has joined #bitcoin-core-dev
17:21 < promag> if that is called before WalletFrame::addWallet then it wouldn't show the wallet
17:22 < achow101> promag: but then why does different qt versions matter?
17:23 < promag> I'm guessing signal/slot ordering and because OpenWalletActivity is on a different thread
17:23 < promag> if that's the reason behind that problem I'm currently fixing it
17:25 -!- Murch [~murch@50-200-105-218-static.hfc.comcastbusiness.net] has quit [Quit: Snoozing.]
17:25 -!- pinheadmz [~matthewzi@104-56-112-203.lightspeed.sntcca.sbcglobal.net] has quit [Quit: pinheadmz]
17:26 < promag> I think you can call WalletFrame::addWallet in WalletFrame::setCurrentWallet to see if that's the problem
17:27 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 272 seconds]
17:27 < achow101> ah, so the problem is likely that addwallet isn't being called before setcurrentwallet
17:27 < promag> yap
17:29 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
17:30 < achow101> promag: that fixed that problem but introduced a whole new one
17:30 < achow101> none of the tabs work and the dropdown for the wallet selector isn't there (i tried to load multiple wallets)
17:31 < promag> I said "to see if that's the problem"
17:32 < achow101> yes that is the problem
17:33 < promag> I think that new issue is because "BitcoinGUI::addWallet" wasn't called or something
17:33 < promag> don't worry about this
17:33 < achow101> ok
17:34 < promag> I'll try to give instructions on how to reproduce and submit a fix
17:34 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
17:40 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 250 seconds]
17:41 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
17:43 -!- cacho [bab6f2bf@gateway/web/freenode/ip.186.182.242.191] has joined #bitcoin-core-dev
17:43 -!- cacho [bab6f2bf@gateway/web/freenode/ip.186.182.242.191] has quit [Client Quit]
17:44 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
18:11 -!- Empact [~empact@192-195-80-225.PUBLIC.monkeybrains.net] has joined #bitcoin-core-dev
18:11 -!- Empact_ [~empact@192-195-80-225.PUBLIC.monkeybrains.net] has quit [Ping timeout: 264 seconds]
18:15 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 255 seconds]
18:33 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has joined #bitcoin-core-dev
18:38 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has quit [Ping timeout: 246 seconds]
18:39 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
18:39 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
18:43 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 264 seconds]
18:50 -!- DeanGuss [~deanguss@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds]
18:52 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
19:08 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.3]
19:09 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
19:14 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 264 seconds]
19:16 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
19:26 -!- margk [~margk1@74-194-122-201.mthmcmta01.res.dyn.suddenlink.net] has joined #bitcoin-core-dev
19:44 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
20:17 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev
20:19 < fanquake> I can confirm achow101's problem with qt 5.7.1
20:19 < fanquake> spun up a debian vm and get the same behaviour
20:45 -!- benthecarman [~benthecar@ics133-225.icsincorporated.com] has joined #bitcoin-core-dev
20:46 -!- benthecarman [~benthecar@ics133-225.icsincorporated.com] has quit [Client Quit]
20:46 -!- benthecarman [~benthecar@ics133-225.icsincorporated.com] has joined #bitcoin-core-dev
20:46 < benthecarman> Hey what would be people's thought on adding rpc/cli commands to change config options 
20:48 < benthecarman> My thoughts were for specifically rpcalllowip because it'd be nice to give an ip permission without needing to restart the node everytime 
20:49 < sipa> that's a common suggestion
20:50 < sipa> and it certainly makes sense for a few things (rpcallowip is a good example)
20:50 < sipa> though it's very hard to do generically (because values of config options often affect how various derived variables are initialized stc)
20:56 -!- skyikot [~skyikot@gateway/tor-sasl/skyikot] has quit [Remote host closed the connection]
21:02 -!- mildly_risky [~~mildly_r@14.0.170.28] has joined #bitcoin-core-dev
21:02 < benthecarman> Yeah I imagine, need to write to file and change the permissions while running. If a PR was made, would it likely be approved however?
21:03 -!- benthecarman [~benthecar@ics133-225.icsincorporated.com] has quit [Quit: Mutter: www.mutterirc.com]
21:04 < gmaxwell> I'm unsure, the change would likely be highly disruptive and might not be justified for the benefit. :(
21:05 < gmaxwell> Sometimes we can't really tell if a change would be accepted until its done.
21:05 < gmaxwell> I think if you go read past discussions (which you absolutely should do before attempting or it probably won't be accepted!), you'll see that it's not really a simple question.
21:05 -!- benthecarman [~benthecar@ics133-225.icsincorporated.com] has joined #bitcoin-core-dev
21:07 -!- mildly_risky [~~mildly_r@14.0.170.28] has quit [Remote host closed the connection]
21:09 < sipa> benthecarman: oh, there is a PR to introduce a sepaeate writable config file for this purpose
21:09 -!- mildly_risky [~~mildly_r@14.0.170.28] has joined #bitcoin-core-dev
21:10 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
21:11 < tryphe> what about accepting a dns/alias in addition to a netmask/CIDR? then you would just depend on the system to resolve the alias, and avoid remote changes
21:12 < gmaxwell> from a programming perspective sticking a DNS query in is pretty awful... as you now have network interaction in an otherwise trivial code path.  DNS is also almost universally deployed in an insecure manner, so making your auth triggered by DNS usually immediately exposes it to attacks.
21:13 < gmaxwell> elsewhere where we've had dns resolution it's resulted in stupid bugs.
21:13 < tryphe> yeah, it would suck to switchover like 12 hours later because of dns caching, lol
21:13 < gmaxwell> (e.g. addnode)
21:13 -!- mildly_risky [~~mildly_r@14.0.170.28] has quit [Remote host closed the connection]
21:14 < gmaxwell> sooo I'd really prefer not to.  the rpc is really not intended to be used outside of a single host/vms/physically isolated lan/ etc.
21:15 < sipa> tryphe: if the expected behavior is that it is resolved once at startup time it is very easy to implement... but perhaps undesirable or at least unintuitive
21:15 < tryphe> yeah, or if you needed to, more practical to run a tunnel
21:15 < gmaxwell> yup which is also what we recommend.
21:22 -!- skyikot [~skyikot@gateway/tor-sasl/skyikot] has joined #bitcoin-core-dev
21:40 -!- margk [~margk1@74-194-122-201.mthmcmta01.res.dyn.suddenlink.net] has quit [Quit: Leaving]
21:42 -!- benthecarman [~benthecar@ics133-225.icsincorporated.com] has quit [Quit: Mutter: www.mutterirc.com]
22:04 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 255 seconds]
22:08 -!- skyikot [~skyikot@gateway/tor-sasl/skyikot] has quit [Ping timeout: 256 seconds]
22:10 -!- benthecarman [~benthecar@ics133-225.icsincorporated.com] has joined #bitcoin-core-dev
22:10 -!- benthecarman [~benthecar@ics133-225.icsincorporated.com] has quit [Client Quit]
22:14 -!- benthecarman [~benthecar@ics133-225.icsincorporated.com] has joined #bitcoin-core-dev
22:14 -!- benthecarman [~benthecar@ics133-225.icsincorporated.com] has quit [Client Quit]
22:16 -!- benthecarman [~benthecar@ics133-225.icsincorporated.com] has joined #bitcoin-core-dev
22:18 -!- benthecarman [~benthecar@ics133-225.icsincorporated.com] has quit [Client Quit]
23:02 -!- droark [~droark@c-24-21-203-195.hsd1.or.comcast.net] has joined #bitcoin-core-dev
23:10 -!- spinza [~spin@155.93.246.187] has quit [Ping timeout: 246 seconds]
23:27 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [Remote host closed the connection]
23:29 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev
23:31 < wumpus> yes tunneling is definitely the way to go for remote RPC, this is also what is suggested in `doc/JSON-RPC-interface.md`
23:31 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
23:39 < wumpus> it's cool that we're pretty much on schedule for 0.18 branch-off, two pulls to go for now https://github.com/bitcoin/bitcoin/pulls?q=is%3Aopen+is%3Apr+milestone%3A0.18.0
23:45 -!- IZooo [~IzZzoOo@78.192.31.65] has joined #bitcoin-core-dev
23:46 < IZooo> Hello :)
23:46 < wumpus> hi !
23:54 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
23:57 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
--- Log closed Thu Feb 21 00:00:55 2019