--- Log opened Thu Mar 21 00:00:21 2019
00:21 -!- jarthur [~jarthur@2605:6000:1019:41ab:ac6b:7907:f365:d106] has quit []
00:34 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #bitcoin-core-dev
00:37 < fanquake> sipa / wumpus can you block kevinschoen from GitHub
00:37 < fanquake> They are spamming a link to a website that is very likely malware
00:37 < fanquake> With an "official" looking URL.
00:40 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
00:41 < sipa> fanquake: done
00:41 < fanquake> sipa thanks.
00:42 < fanquake> I have removed all of the comments.
00:43 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Remote host closed the connection]
00:45 -!- rex4539 [~rex4539@ppp-2-84-169-44.home.otenet.gr] has quit [Quit: rex4539]
00:46 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #bitcoin-core-dev
00:47 < sipa> fanquake: great
00:48 < echeveria> fanquake: I can confirm that this is an attack site (as if it wasn't obvious). depending on the links you follow, you either get the legit binaries, or "bitcoin.exe". 
00:52 < fanquake> echeveria thanks
00:53 < gmaxwell> I wonder if its the same parties that have been attacking electrum users?
00:57 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has quit [Ping timeout: 245 seconds]
00:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:59 < bitcoin-git> [bitcoin] MeshCollider pushed 5 commits to master: https://github.com/bitcoin/bitcoin/compare/b3f82284ba90...2607d960a02e
00:59 < bitcoin-git> bitcoin/master 91868e6 Russell Yanofsky: Remove use CValidationInterface in wallet code
00:59 < bitcoin-git> bitcoin/master 4e4d9e9 Russell Yanofsky: Remove use of CRPCTable::appendCommand in wallet code
00:59 < bitcoin-git> bitcoin/master b1b2b23 Russell Yanofsky: Remove use of CCoinsViewMemPool::GetCoin in wallet code
00:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:59 < bitcoin-git> [bitcoin] MeshCollider merged pull request #10973: Refactor: separate wallet from node (master...pr/wipc-sep) https://github.com/bitcoin/bitcoin/pull/10973
00:59 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:00 < bitcoin-git> [bitcoin] MeshCollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/2607d960a02e...717fd58c4ba5
01:00 < bitcoin-git> bitcoin/master bb6195e practicalswift: refactor: Remove unused function
01:00 < bitcoin-git> bitcoin/master 717fd58 MeshCollider: Merge #15625: refactor: Remove unused function
01:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:01 < bitcoin-git> [bitcoin] MeshCollider merged pull request #15625: refactor: Remove unused function (master...remove-unused-function) https://github.com/bitcoin/bitcoin/pull/15625
01:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:01 < echeveria> gmaxwell: using NameCheap is within the Electrum malware's style. 
01:02 < gmaxwell> Fun fact, 82% of my banlist IPs are from 10 ASNs.
01:04 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has joined #bitcoin-core-dev
01:06 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit []
01:12 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 245 seconds]
01:16 -!- harrymm [~harrymm@69.161.195.103] has quit [Ping timeout: 246 seconds]
01:16 -!- harrymm [~harrymm@69.161.195.103] has joined #bitcoin-core-dev
01:24 -!- harrymm [~harrymm@69.161.195.103] has quit [Ping timeout: 255 seconds]
01:27 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
01:28 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Remote host closed the connection]
01:28 -!- mn94958821 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Remote host closed the connection]
01:28 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev
01:28 -!- mn94958822 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev
01:32 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 272 seconds]
01:33 -!- mn94958822 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Ping timeout: 244 seconds]
01:33 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Ping timeout: 244 seconds]
01:34 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev
01:35 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev
01:38 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Ping timeout: 244 seconds]
01:53 < wumpus> so apparently there's some funding initiative by Twitter/Square for core devs (I only learn of this through twitter now), https://twitter.com/jimmysong/status/1108500506106843137 - anyhow, if you're actively involved in Bitcoin Core's development and need this funding, and would like me to write a recommendation for you, let me know
01:54 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection]
01:55 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev
02:00 < fanquake> wumpus yea it looks interesting. Keen to see how the designer works with Qt & the project in general.
02:03 < wumpus> yeah
02:12 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev
02:12 < gmaxwell> mischa010: here is a pretty typical "time to first relay" for a 3k transation block on a not very fast host (2.2GHz, and no SIMD/asm SHA256): https://0bin.net/paste/mfZ2yV+QA6dwUoGl#9cUo-0q9z8QMzujMQb948phZuaW/mPwzPKSBpXwPMQ/  it shows 4.6ms from the time it first got the block until it sent it to another peer.
02:12 < gribble> https://github.com/bitcoin/bitcoin/issues/9 | Fix for GUI on Macs and latest wxWidgets by gavinandresen · Pull Request #9 · bitcoin/bitcoin · GitHub
02:12 -!- mn94958823 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev
02:12 < gmaxwell> gribble why do you traumatize me so?
02:12 < gribble> It just seems like what everyone else is doing.
02:16 -!- mn94958823 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Ping timeout: 250 seconds]
02:16 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Ping timeout: 245 seconds]
02:17 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev
02:17 -!- mn94958824 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev
02:22 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Ping timeout: 244 seconds]
02:22 -!- mn94958824 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Ping timeout: 246 seconds]
02:25 < gmaxwell> mischa010: actually here is a more complete log that also shows that it took 72ms to validate (hot cache). https://0bin.net/paste/-tXEltim85EBuCfv#84o+e5Uxv5IYu9LsQ-fLpBtog877N1PI5QsRCFpoRco  
02:25 < gribble> https://github.com/bitcoin/bitcoin/issues/84 | Transaction-less transfer of value · Issue #84 · bitcoin/bitcoin · GitHub
02:27 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev
02:27 -!- mn94958816 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev
02:31 < gmaxwell> thank you gribble, https://media1.tenor.com/images/2843fd374596fd548e8643a2eea4edf2/tenor.gif
02:32 -!- mn94958816 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Ping timeout: 252 seconds]
02:32 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Ping timeout: 252 seconds]
02:42 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has joined #bitcoin-core-dev
02:45 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev
02:54 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev
02:54 -!- mn94958817 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev
02:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:55 < bitcoin-git> [bitcoin] gmaxwell opened pull request #15633: Ignore BIP-152 HB requests from non-witness peers. (master...201803-nohbcbfornonwit) https://github.com/bitcoin/bitcoin/pull/15633
02:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:57 -!- mn94958817 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Remote host closed the connection]
02:57 -!- mn94958818 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev
03:02 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Ping timeout: 246 seconds]
03:02 -!- mn94958818 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Ping timeout: 244 seconds]
03:09 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
03:09 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
03:16 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Remote host closed the connection]
03:21 -!- harrymm [~harrymm@69.161.195.103] has joined #bitcoin-core-dev
03:29 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Remote host closed the connection]
03:30 -!- jonatack [d598a2a5@gateway/web/freenode/ip.213.152.162.165] has joined #bitcoin-core-dev
03:30 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has joined #bitcoin-core-dev
03:30 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has quit [Changing host]
03:30 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
03:31 < jonasschnelli> Is or should it be possible to reduce the dbcache size once the node has completed IBD,... without a restart?
03:32 < jonasschnelli> I guess if I run with a large DB cache and the node has done IBD a couple of hours ago, it will not write the state to the database expect hitting the cache (or a shutdown)?
03:33 < jonasschnelli> There is AFAIK no time constraint that makes the cache write to disk... (hopefully I'm wrong)
03:35 < jonasschnelli> *expect hitting the cache limit (or a shutdown)
03:37 < wumpus> jonasschnelli: I remember there was some PR recently that added a flush of the dbcache immediately after IBD
03:38 < jonasschnelli> wumpus: but that would still lead to consuming a lot of RAM over time (without significant performance benefits in most cases)?
03:39 < wumpus> well yes the dbcache would fill again after that, it's mostly to prevent loss of data
03:40 < wumpus> but don't underestimate, the cache still has 'significant performance benefits' for verifying incoming blocks/transactions
03:40 < wumpus> even after IBD
03:41 < wumpus> especially for miners (desire for as-fast-as-possible verification), or low-end hardware (slow i/o), this can be important
03:41 < jonasschnelli> I'm currently targeting low-end hardware (aarch64) where RAM is crucial and find a good balance between fast sync (where other stuff may be disabled due to RAM constraints).
03:42 < jonasschnelli> And once IBD has been done, switch to a lower dbcache to allow other processes to run seems desirable
03:42 < jonasschnelli> And since its using SSD, i/o is non-crucial IMO
03:42 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 268 seconds]
03:43 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev
03:43 -!- mn94958819 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev
03:48 -!- mn94958819 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Ping timeout: 246 seconds]
03:48 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Ping timeout: 250 seconds]
03:51 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
03:55 -!- zhangzf [~zhangzf@106.38.157.147] has quit [Remote host closed the connection]
04:01 < wumpus> if you have the database on a (real) SSD it is, but lots of ARM devices use either slow external HDD or some SD card
04:01 < wumpus> anyhow, could be a configuration option I guess
04:04 < jonasschnelli> wumpus: the Rock64pro has a PCI-e (m.2 NVME SSD) (for ~60USD)
04:05 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
04:05 < wumpus> :o
04:05 < emilr> not that much of an inconvenience restarting bitcoind after IBD, all this features create a lot of complexity and maintenance down the road
04:06 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Remote host closed the connection]
04:06 < emilr> I'm building bitcoin on a rpi, biggest hurdle thus far is the dependency tree, I had to give up on building boost-libs and use binaries
04:06 < wumpus> emilr: generally agree that trying to regulate things like this automatically results in an unpredictable mess
04:07 < wumpus> but, like, an RPC that allows changing settings such as dbcache at runtime wouldn't be that bad 
04:07 < wumpus> (I think that'd be just a matter of flushing the current cache if it's > newsize and setting the new bound)
04:07 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
04:08 < wumpus> the depends build should work on rpi
04:08 -!- rex4539 [~rex4539@ppp-2-84-169-44.home.otenet.gr] has joined #bitcoin-core-dev
04:08 < wumpus> (which will build boost, and optionally berkeleydb/qt/etc for you)
04:09 < wumpus> I think it's one of the most popular devices to run a bitcoin node on
04:09 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
04:11 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev
04:11 -!- mn94958820 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev
04:11 < emilr> not sure it will work without a restart given linux's memory management, I'm building it on freebsd from ports atm
04:12 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 255 seconds]
04:13 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has joined #bitcoin-core-dev
04:13 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has quit [Changing host]
04:13 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
04:13 < wumpus> linux's memory management is *definitely* able to give back freed memory to the OS, though things such as memory fragmentation can get in the way of course
04:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:16 < bitcoin-git> [bitcoin] gmaxwell closed pull request #15633: Ignore BIP-152 HB requests from non-witness peers. (master...201803-nohbcbfornonwit) https://github.com/bitcoin/bitcoin/pull/15633
04:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:16 -!- mn94958820 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Ping timeout: 250 seconds]
04:16 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Ping timeout: 272 seconds]
04:22 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds]
04:25 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit []
04:31 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has joined #bitcoin-core-dev
04:31 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has quit [Changing host]
04:31 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
04:48 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Remote host closed the connection]
04:49 -!- hsmiths [uid95325@gateway/web/irccloud.com/x-maglpbdelwcvqixx] has joined #bitcoin-core-dev
04:49 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev
04:49 -!- mn94958821 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev
04:51 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has joined #bitcoin-core-dev
04:51 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has quit [Changing host]
04:51 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
04:54 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Ping timeout: 245 seconds]
04:54 -!- mn94958821 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Ping timeout: 268 seconds]
04:56 -!- rex4539 [~rex4539@ppp-2-84-169-44.home.otenet.gr] has quit [Quit: rex4539]
05:01 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Remote host closed the connection]
05:08 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has joined #bitcoin-core-dev
05:08 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has quit [Changing host]
05:08 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
05:09 -!- zhangzf [~zhangzf@120.244.116.214] has joined #bitcoin-core-dev
05:12 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 246 seconds]
05:14 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
05:22 -!- zhangzf_ [~zhangzf@120.244.117.199] has joined #bitcoin-core-dev
05:22 -!- zhangzf [~zhangzf@120.244.116.214] has quit [Ping timeout: 245 seconds]
05:29 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has joined #bitcoin-core-dev
05:42 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev
05:42 -!- mn94958822 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev
05:47 -!- mn94958822 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Ping timeout: 245 seconds]
05:47 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Ping timeout: 268 seconds]
05:50 -!- jonatack [d598a2a5@gateway/web/freenode/ip.213.152.162.165] has quit [Ping timeout: 256 seconds]
06:01 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
06:06 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Ping timeout: 252 seconds]
06:29 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev
06:29 -!- mn94958823 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev
06:30 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
06:34 -!- mn94958823 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Ping timeout: 272 seconds]
06:35 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Ping timeout: 268 seconds]
06:40 -!- _Sam-- [~greybits@unaffiliated/greybits] has quit [Disconnected by services]
06:41 -!- mn94958825 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev
06:41 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev
06:44 -!- _Sam-- [~greybits@unaffiliated/greybits] has joined #bitcoin-core-dev
06:46 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Ping timeout: 245 seconds]
06:46 -!- mn94958825 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Ping timeout: 272 seconds]
06:51 -!- rex4539 [~rex4539@ppp-2-84-169-44.home.otenet.gr] has joined #bitcoin-core-dev
06:58 -!- Tralfaz [~none@178.128.106.205] has joined #bitcoin-core-dev
07:01 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev
07:05 -!- michaelfolkson [~textual@146.185.56.214] has joined #bitcoin-core-dev
07:10 -!- michaelfolkson [~textual@146.185.56.214] has quit [Quit: Textual IRC Client: www.textualapp.com]
07:10 -!- michaelfolkson [~textual@146.185.56.214] has joined #bitcoin-core-dev
07:11 -!- michaelfolkson [~textual@146.185.56.214] has quit [Client Quit]
07:11 -!- michaelfolkson [~textual@146.185.56.214] has joined #bitcoin-core-dev
07:11 -!- michaelfolkson [~textual@146.185.56.214] has quit [Client Quit]
07:11 -!- michaelfolkson [~textual@146.185.56.214] has joined #bitcoin-core-dev
07:12 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev
07:12 -!- mn94958826 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev
07:12 -!- michaelfolkson [~textual@146.185.56.214] has quit [Client Quit]
07:12 -!- michaelfolkson [~textual@146.185.56.214] has joined #bitcoin-core-dev
07:13 -!- michaelfolkson [~textual@146.185.56.214] has quit [Client Quit]
07:13 -!- michaelfolkson [~textual@146.185.56.214] has joined #bitcoin-core-dev
07:14 -!- michaelfolkson [~textual@146.185.56.214] has quit [Client Quit]
07:14 -!- michaelfolkson [~textual@146.185.56.214] has joined #bitcoin-core-dev
07:17 -!- mn94958826 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Ping timeout: 244 seconds]
07:17 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Ping timeout: 244 seconds]
07:23 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/]
07:25 -!- michaelfolkson [~textual@146.185.56.214] has quit [Quit: Textual IRC Client: www.textualapp.com]
07:25 -!- michaelfolkson [~textual@146.185.56.214] has joined #bitcoin-core-dev
07:27 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit [Remote host closed the connection]
07:30 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has joined #bitcoin-core-dev
07:30 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has quit [Changing host]
07:30 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
07:30 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
07:31 -!- m8tion [~user@lns-bzn-43-82-249-162-49.adsl.proxad.net] has joined #bitcoin-core-dev
07:33 -!- michaelfolkson [~textual@146.185.56.214] has quit [Quit: Textual IRC Client: www.textualapp.com]
07:34 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev
07:35 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer]
07:35 -!- michaelfolkson [~textual@146.185.56.214] has joined #bitcoin-core-dev
07:36 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev
07:36 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
07:38 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev
07:39 -!- mn94958827 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev
07:39 -!- michaelfolkson [~textual@146.185.56.214] has quit [Client Quit]
07:43 -!- mn94958827 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Ping timeout: 244 seconds]
07:44 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Ping timeout: 272 seconds]
07:48 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has joined #bitcoin-core-dev
07:48 -!- michaelfolkson [~michaelfo@146.185.56.214] has joined #bitcoin-core-dev
08:01 -!- michaelfolkson [~michaelfo@146.185.56.214] has quit []
08:01 -!- michaelfolkson [~textual@146.185.56.214] has joined #bitcoin-core-dev
08:05 -!- michaelf_ [~michaelfo@146.185.56.214] has joined #bitcoin-core-dev
08:05 -!- michaelf_ [~michaelfo@146.185.56.214] has quit [Client Quit]
08:22 -!- ExtraCrispy [~ExtraCris@gateway/tor-sasl/extracrispy] has joined #bitcoin-core-dev
08:24 -!- m8tion [~user@lns-bzn-43-82-249-162-49.adsl.proxad.net] has quit [Quit: Leaving]
08:24 -!- m8tion [~user@185.236.201.131] has joined #bitcoin-core-dev
08:33 -!- mn94958828 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev
08:33 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev
08:34 -!- zhangzf_ [~zhangzf@120.244.117.199] has quit [Remote host closed the connection]
08:35 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev
08:36 < BlueMatt> <gmaxwell> BlueMatt: I think we should drop v1 HB mode support. There is no point in sending blocks quickly to v1 peers. <-- ack
08:37 < BlueMatt> seems like more than enough time has passed for that
08:38 -!- mn94958828 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Ping timeout: 268 seconds]
08:38 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Ping timeout: 268 seconds]
08:40 -!- echonaut [~echonaut@46.101.192.134] has quit [Remote host closed the connection]
08:56 -!- michaelfolkson [~textual@146.185.56.214] has quit [Quit: Sleep mode]
09:01 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/]
09:07 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
09:20 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has quit [Ping timeout: 255 seconds]
09:21 -!- dgenr8 [~dgenr8@unaffiliated/dgenr8] has joined #bitcoin-core-dev
09:22 -!- michaelfolkson [~textual@146.185.56.214] has joined #bitcoin-core-dev
09:22 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
09:27 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev
09:27 -!- mn94958824 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev
09:33 -!- mn94958824 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Ping timeout: 272 seconds]
09:33 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Ping timeout: 272 seconds]
09:42 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
10:05 -!- dqx_ [~dqx@unaffiliated/dqx] has quit [Remote host closed the connection]
10:08 -!- michaelfolkson [~textual@146.185.56.214] has quit [Quit: Sleep mode]
10:15 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev
10:16 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Remote host closed the connection]
10:16 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #bitcoin-core-dev
10:18 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev
10:22 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev
10:22 -!- mn94958829 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev
10:23 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Ping timeout: 272 seconds]
10:27 -!- mn94958829 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Ping timeout: 252 seconds]
10:27 -!- dqx_ [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev
10:27 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Ping timeout: 268 seconds]
10:29 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev
10:29 -!- mn94958830 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev
10:35 -!- m8tion_ [~user@185.236.201.131] has joined #bitcoin-core-dev
10:38 -!- m8tion [~user@185.236.201.131] has quit [Ping timeout: 244 seconds]
10:41 -!- BlueMatt [~BlueMatt@unaffiliated/bluematt] has quit [Quit: Quit]
10:42 -!- mischa010 [4dadf2fe@gateway/web/freenode/ip.77.173.242.254] has quit [Ping timeout: 256 seconds]
10:44 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
10:46 -!- BlueMatt [~BlueMatt@unaffiliated/bluematt] has joined #bitcoin-core-dev
10:50 < gleb> Is core meeting in 10 minutes?
11:02 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer]
11:03 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
11:12 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection]
11:15 < wumpus> should be in 45 minutes
11:19 < gleb> I see, thanks.
11:26 -!- dqx_ [~dqx@unaffiliated/dqx] has quit [Remote host closed the connection]
11:27 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Remote host closed the connection]
11:30 < wumpus> it's 19:00 Reijkjavik time (UTC)
11:33 < phantomcircuit> wumpus, flushing the cache after ibd seems like a bad idea, that would vastly increase the latency of procssing blocks in the future
11:33 < phantomcircuit> processing*
11:34 < jamesob> I still don't get why we necessarily empty the cache upon flush
11:35 -!- user__ [~user@185.236.201.131] has joined #bitcoin-core-dev
11:36 -!- j [c0f19d1b@gateway/web/freenode/ip.192.241.157.27] has joined #bitcoin-core-dev
11:36 -!- j is now known as Guest40623
11:37 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #bitcoin-core-dev
11:38 -!- m8tion_ [~user@185.236.201.131] has quit [Ping timeout: 252 seconds]
11:44 -!- m8tion_ [~user@185.236.201.131] has joined #bitcoin-core-dev
11:46 -!- user__ [~user@185.236.201.131] has quit [Ping timeout: 245 seconds]
11:47 -!- dqx_ [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev
11:51 -!- dqx_ [~dqx@unaffiliated/dqx] has quit [Remote host closed the connection]
11:51 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev
11:58 < wumpus> phantomcircuit: it has some drawbacks as well, sure
11:58 < wumpus> jamesob: because there's that's the only eviction policy
11:59 -!- dqx_ [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev
11:59 < wumpus> cache is full → evict all, I remember some experiments were done with other ideas, but it didn't improve performance while it did make the code much more complex
12:00 < wumpus> #startmeeting
12:00 < lightningbot> Meeting started Thu Mar 21 19:00:15 2019 UTC.  The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot.
12:00 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
12:00 < provoostenator> hi
12:00 < jonasschnelli> hi
12:00 < jnewbery> hi
12:00 < MarcoFalke> yo
12:00 < kanzure> hi
12:00 < achow101> hi
12:01 < MarcoFalke> When rc3?
12:01 < wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb
12:01 < instagibbs> hi
12:01 < sipa> hi
12:01 < promag> hi
12:01 < luke-jr> hi
12:01 < gleb> hi
12:01 < meshcollider> hi
12:02 < wumpus> MarcoFalke: dunno, rc2 was only very short ago, might want to wait a bit for test results
12:02 < MarcoFalke> Early next week?
12:02 < jamesob> hi
12:02 < moneyball> hi
12:02 < wumpus> MarcoFalke: sgtm
12:02 < luke-jr> hi
12:02 < jonasschnelli> This #15310 needs probably a fix until rc3
12:02 < gribble> https://github.com/bitcoin/bitcoin/issues/15310 | gui: crash if encrypt / change passphrase window is open and wallet is unloaded · Issue #15310 · bitcoin/bitcoin · GitHub
12:03 -!- dqx_ [~dqx@unaffiliated/dqx] has quit [Remote host closed the connection]
12:03 < jonasschnelli> Where two proposal to fix it are available: #15313 and #15614 (though not enough review)
12:03 < gribble> https://github.com/bitcoin/bitcoin/issues/15313 | Qt: avoid AskPassphraseDialog synchronous QDialog.exec() calls by jonasschnelli · Pull Request #15313 · bitcoin/bitcoin · GitHub
12:03 < promag> jonasschnelli: maybe #15614
12:03 < gribble> https://github.com/bitcoin/bitcoin/issues/15614 | 0.18: gui: Defer removeAndDeleteWallet when no modal widget is active by promag · Pull Request #15614 · bitcoin/bitcoin · GitHub
12:03 < gribble> https://github.com/bitcoin/bitcoin/issues/15614 | 0.18: gui: Defer removeAndDeleteWallet when no modal widget is active by promag · Pull Request #15614 · bitcoin/bitcoin · GitHub
12:04 -!- dqx_ [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev
12:04 < provoostenator> I'll take a look at both
12:04 < wumpus> what is the different between the approaches?
12:04 < jonasschnelli> gmaxwell wanted to revert the PR that causes the issue (GUI load/unload)... though I think #15313 is fine
12:04 < gribble> https://github.com/bitcoin/bitcoin/issues/15313 | Qt: avoid AskPassphraseDialog synchronous QDialog.exec() calls by jonasschnelli · Pull Request #15313 · bitcoin/bitcoin · GitHub
12:05 < jonasschnelli> The #15614 fix delays the unload until all modal windows haven been closed
12:05 < gribble> https://github.com/bitcoin/bitcoin/issues/15614 | 0.18: gui: Defer removeAndDeleteWallet when no modal widget is active by promag · Pull Request #15614 · bitcoin/bitcoin · GitHub
12:05 < jonasschnelli> where #15313 does close them directly
12:05 < gribble> https://github.com/bitcoin/bitcoin/issues/15313 | Qt: avoid AskPassphraseDialog synchronous QDialog.exec() calls by jonasschnelli · Pull Request #15313 · bitcoin/bitcoin · GitHub
12:05 < wumpus> so is any one decidedly simpler for a last minute rc fix?
12:06 < jonasschnelli> IMO its an edge case (GUI unload wallet via RPC when -server is active)
12:06 < promag> right ^
12:06 < jonasschnelli> For a last minut fix, promag's 15313 is probably more sane
12:06 < promag> for 0.18 the shorter is 15614
12:06 < jonasschnelli> It just can make unloadwallet time out
12:06 < luke-jr> does RPC unload actually go through GUI walletmodel code like that?
12:06 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
12:06 < wumpus> still, someone apparently stumbled on it in the short testing duration
12:06 < wumpus> luke-jr: it should trigger the same notifications
12:07 < jonasschnelli> luke-jr: it does unload the wallet and there are synchonous dialog calls (the root cause) which leads to a crash
12:07  * jonasschnelli stabs synchronous modal dialog calls
12:07 < luke-jr> jonasschnelli: I get that, I just don't understand how #15614 works
12:07 < wumpus> ok I'll contingently tag 15313 for 0.18.0 then
12:07 < gribble> https://github.com/bitcoin/bitcoin/issues/15614 | 0.18: gui: Defer removeAndDeleteWallet when no modal widget is active by promag · Pull Request #15614 · bitcoin/bitcoin · GitHub
12:07 < promag> luke-jr: the issue comes from QDialog::exec, which spins another event loop
12:08 < jonasschnelli> 15313 will just wait until user closes it, which can lead to a timeout in RPC unloadwallet (probably okay)
12:08 < wumpus> oh, was already tagged
12:08 < jonasschnelli> Sry,... wrong. I meant 15614 is the one that waits
12:08 < jonasschnelli> 15313 does close it explicit and then unload the wallet
12:08 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Remote host closed the connection]
12:08 < jonasschnelli> but not all dialogs can be closed with the current code (needs major refactoring)
12:09 < jonasschnelli> lets just go with 15614...
12:09 < promag> yap, I've started it but its too much for 0.18
12:09 < jonasschnelli> yes
12:09 < luke-jr> ok, I think I see how it works basically
12:09 -!- mischa010 [4dadf2fe@gateway/web/freenode/ip.77.173.242.254] has joined #bitcoin-core-dev
12:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:09 < bitcoin-git> [bitcoin] jonasschnelli closed pull request #15313: Qt: avoid AskPassphraseDialog synchronous QDialog.exec() calls (master...2019/01/qt_exec) https://github.com/bitcoin/bitcoin/pull/15313
12:09 < wumpus> that's not really an option for 0.18.0, no, then I'd prefer the revert approach
12:09 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:10 < promag> luke-jr: 15614 delays the wallet model destruction after all dialogs are closed
12:10 < luke-jr> but does a focus change necessarily mean the GUI is done with it?
12:10 < luke-jr> specifically, isn't coin control non-modal?
12:10 < jonasschnelli> 15614 is a good fix for a case where someone unloads a wallet via RPC when using the GUI (probably rar use-cases)
12:11 < promag> luke-jr: afaik there is no signal to know the active window changed
12:11 < wumpus> jonasschnelli: ok good to know
12:11 < jonasschnelli> luke-jr: it just checks again... when the focus changes (since this is what happens if you close a Dialog)
12:11 < jonasschnelli> The long term fix is avoiding synchronous calls
12:12 < promag> jonasschnelli: luke-jr: actually now I remember there is QWindow::activeChanged since qt5
12:12 < promag> I'll recheck
12:12 < jonasschnelli> however, please review #15614 to merge it into 0.18 asap
12:12 < gribble> https://github.com/bitcoin/bitcoin/issues/15614 | 0.18: gui: Defer removeAndDeleteWallet when no modal widget is active by promag · Pull Request #15614 · bitcoin/bitcoin · GitHub
12:13 < jonasschnelli> we probably won't ship with known and fixable crashes
12:13 < MarcoFalke> #action review #15614
12:13 < gribble> https://github.com/bitcoin/bitcoin/issues/15614 | 0.18: gui: Defer removeAndDeleteWallet when no modal widget is active by promag · Pull Request #15614 · bitcoin/bitcoin · GitHub
12:13 < MarcoFalke> Should also do a forward-port to master?
12:13 < MarcoFalke> Or maybe open the pull against master?
12:14 < promag> MarcoFalke: I'll rather not, unless you prefer, cause the right fix is to remove qdialog::exec calls
12:14 < jonasschnelli> promag: regardless of the long term solution, we probably want this also in master
12:14 < promag> no strong opinion really
12:15 < luke-jr> things are supposed to go into master before backports (although I can think of cases where that's not viable, so maybe it should be a hard rule)
12:15 < jonasschnelli> what luke-jr says
12:15 < promag> MarcoFalke: I'll push it then
12:15 < luke-jr> shouldn't*
12:15 < wumpus> jonasschnelli: our usual strategy is to have everything in master first, so that no fixes get lost
12:15 < MarcoFalke> jup, agree with luke-jr
12:15 < promag> ok np
12:15 < jonasschnelli> wumpus: yes.
12:15 < wumpus> if something *only* applies to a branch there's of course an exception
12:16 < wumpus> butthat's not the case here
12:16 < promag> just note that it will be reverted
12:16 < wumpus> not reverted, replaced
12:16 < promag> right :)
12:16 < luke-jr> *shrug* reverts are fine when appropriate
12:16 < wumpus> reverts are fine if some change turns out to be bad
12:16 < wumpus> we could to that too …
12:16 < wumpus> that was gmaxwell's proposal right
12:17 < wumpus> though if other changes built on top since, it might be non-trivial now
12:17 < promag> reverting that brings other issues
12:17 < luke-jr> wumpus: we're talking about a revert of the bandaid fix
12:17 < luke-jr> eg, as part of a real fix
12:17 < wumpus> I think we shouldn't have merged those things so late, in retrspect
12:18 < promag> again, this is really very unlikely, you have to run bitcoin-qt -server
12:18 < wumpus> anyhow let's do the fix for rc3
12:18 < wumpus> any other topics?
12:18 < cfields> topic suggestion: win codesigning cert.
12:18 < luke-jr> would be nice to get getbalance fixed, but I need to run.. <.<
12:18 < wumpus> #topic win codesigning cert (cfields)
12:18 < cfields> I'm still trying to understand what's going on, but it seems as though the win cert has expired
12:19 < wumpus> oh?!?
12:19 < jonasschnelli> oh..
12:19 < cfields> But afacs it's not causing any problems.
12:19 < cfields> So I'm confused.
12:19 < jonasschnelli> cfields: should we register a new one via the Bitcoin Core Code Signing Association?
12:19 < cfields> I always do a test-install on Win7, and the cert should've been expired for rc2, but nothing complained.
12:19 < jonasschnelli> cfields: tolerance period? :-)
12:19 -!- DougieBot5000_ [~DougieBot@unaffiliated/dougiebot5000] has joined #bitcoin-core-dev
12:19 < cfields> jonasschnelli: I think yes, asap if possible.
12:20 < jonasschnelli> cfields: I have never done this. Glad if someone with Win experience wants to do it. I'm ready to support on the legal/address/payment side.
12:20 < cfields> jonasschnelli: If you're up for that, I'm happy to help.
12:20 < jonasschnelli> Okay. Lets do that together cfields.
12:20 < cfields> I haven't either, but I think I have a few records from the last cert.
12:20 < cfields> jonasschnelli: Thanks!
12:21 < wumpus> awesome, thanks jonasschnelli and cfields 
12:21 < cfields> sorry if this causes problems..
12:21 < wumpus> without you we'd probably have to drop windows support :)
12:21 < jonasschnelli> Would also be good to get a sponsor for the Bitcoin Core Code Signing Association at some point (raise your hand if your willing)
12:21 < cfields> wumpus: maybe we should discuss an async win release?
12:21 < cfields> wumpus: Hah, in that case I'll leave!
12:21 < wumpus> cfields: how do you mean?
12:22 < cfields> async win release just in case, that is.
12:22 < gwillen> jonasschnelli: sponsor in what sense?
12:22 < cfields> If there's a cert problem that would delay the win release, it'd be a shame to hold up everything.
12:22 < jonasschnelli> gwillen: There are litte costs (domain, macOS developer programm and now the win code signing cert)
12:22 < cfields> heh, I realize this is like the 10th time now that I've suggested that :)
12:23 < wumpus> you mean doing a release without windows binaries?
12:23 < wumpus> I… don't think I want to do that
12:23 -!- DougieBot5000 [~DougieBot@unaffiliated/dougiebot5000] has quit [Ping timeout: 268 seconds]
12:23 < wumpus> will get too many complaints
12:23 < cfields> wumpus: ok, no worries, just thinking of contingencies.
12:23 < luke-jr> jonasschnelli: I would prefer to see someone sponsor a neutral codesigning org
12:23 < gwillen> jonasschnelli: I am happy to pay little costs, I would assume there are plenty of people here willing but lmk 
12:23 < jonasschnelli> Indeed. Also, watch out, this is a discussion rabbit hole (windows yes/no)
12:24 < wumpus> cfields: for an RC it's okay, I think
12:24 < wumpus> cfields: but not for final
12:24 < cfields> I would be curious to know if rc2 is busted on win10, though.
12:24 < cfields> If it is and nobody noticed, that'd be noteworthy.
12:24 < wumpus> I don't think it is
12:24 < wumpus> someone would have told me
12:24 < jonasschnelli> I'll do some VM testing asap
12:25 < cfields> thanks all. </topic>
12:25 < jonasschnelli> gwillen: great to hear.. just need to find a good way how to do this
12:25 < wumpus> any other topics ?
12:26 < jnewbery> We didn't talk about high priority for review, but I guess high priority isn't high priority when we have an upcoming release
12:26 < sipa> yeah
12:27 < jnewbery> My only suggestion would be to add #14121 to the list, which has a few ACKs and seems close to being mergeable
12:27 < wumpus> oh sorry, yes
12:27 < gribble> https://github.com/bitcoin/bitcoin/issues/14121 | Index for BIP 157 block filters by jimpo · Pull Request #14121 · bitcoin/bitcoin · GitHub
12:27 < wumpus> #topic High priority for review
12:27 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #bitcoin-core-dev
12:27 < luke-jr> jonasschnelli, gwillen: (neutral as opposed to Core-only)
12:27 < jonasschnelli> luke-jr: makes little sense IMO
12:28 < wumpus> 14121 added to https://github.com/bitcoin/bitcoin/projects/8
12:28 < MarcoFalke> May I suggest #15596 for high prio?
12:28 < gribble> https://github.com/bitcoin/bitcoin/issues/15596 | rpc: Ignore sendmany::minconf as dummy value by MarcoFalke · Pull Request #15596 · bitcoin/bitcoin · GitHub
12:29 < wumpus> MarcoFalke: ok, added
12:30 < jnewbery> It was great to see #10973 merged yesterday. Thanks to ryanofsky for putting so much work into it!
12:30 < gribble> https://github.com/bitcoin/bitcoin/issues/10973 | Refactor: separate wallet from node by ryanofsky · Pull Request #10973 · bitcoin/bitcoin · GitHub
12:30 < jonasschnelli> indeed
12:30 < wumpus> jnewbery: and right, we skipped high priority review just before the branch / rc1 release, but now that that is done, I suppose enough people are focusing on things to get into 0.19.0 already
12:30 < gwillen> luke-jr: I'm happy to pay minor costs either way but who outside core would use it?
12:31 < cfields> woohoo!
12:31 < promag> MarcoFalke: didn't know you could change base! 
12:31 < jonasschnelli> me neither
12:32 < sipa> change base?
12:32 < jonasschnelli> switch a PR from 0.18 to master (as exampe)
12:32 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Remote host closed the connection]
12:32 < wumpus> and yes, congrats on #10973!
12:32  * MarcoFalke all you base belong to me
12:32 < gribble> https://github.com/bitcoin/bitcoin/issues/10973 | Refactor: separate wallet from node by ryanofsky · Pull Request #10973 · bitcoin/bitcoin · GitHub
12:32 < wumpus> sipa: change the target branch for a PR
12:32 < sipa> oh!
12:32 < ryanofsky> thanks all
12:34 < wumpus> any other topics?
12:35 < kanzure> mailing list update: migration still pending. linuxfoundation is in charge of this, and i don't get updates from them.
12:35 < kanzure> warren might have more info
12:35 < jonasschnelli> kanzure: thanks for the update
12:35 < kanzure> sorry it's not more helpful :)
12:36 < jonasschnelli> Maybe also write back that that email asking why it was so short notice
12:36 < wumpus> yes, he mentioned it, it's been delayed a bit
12:36 < warren> I'm writing a longer story of what led up to this for the list, and we have another delay due to one guy taking sick leave.
12:36 < kanzure> i suppose the reason for short notice is that we didn't inform everyone a year ago when linuxfoundation announced their intentions
12:37 < kanzure> although i do vaguely recall talking about it
12:37 < jonasschnelli> Yes. But the list doesn't know that
12:37 < jonasschnelli> Or I missed it
12:38 -!- DougieBot5000_ is now known as DougieBot5000
12:38 < warren> Late 2017 they notified us that mailman2 was unmaintainable and they had to eventually migrate all their lists onto a new platform. mailman2 had  a dead upstream for years and mailman3 they tried but determined was unusable. <then a long story of evaluating options follows>
12:38 < warren> <then how predictably people will try to step up to claim they can self-host it>
12:39 < warren> This is a long story and the list deserves to hear everything that happened and was considered.
12:39 < wumpus> yes, I remember that
12:40 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Quit: Leaving...]
12:40 < wumpus> it's increasingly difficult to do mailing lists, no one really cares anymore
12:41 -!- aqquadro [~name@unaffiliated/aqquadro] has joined #bitcoin-core-dev
12:41 < jonasschnelli> which is sad
12:41 < wumpus> (maybe except for the linux mailing list and freedesktop/mesa, everyone hates using them, let alone maintaining them)
12:41 < warren> <I did try to ping many of you over the past year for opinions, got very little, then one of you blamed me for not just forcing a decision, I did one more round of asking many of you for opinions, most of you replied you don't care, we considered self-hosting options evaluated by aj, settled on the least effort solution with self-hosted archives>  will explain all this on list.
12:41 < kanzure> alright alright, no need to assign blame
12:42 < wumpus> it's no one's responsibility so also no one's blame
12:42 < warren> The guy who blamed me was right. It was unrealstic of me to expect "the group" could make a decision when most people don't care, they just want it to work.
12:43 < wumpus> in principle it's even off topic in the bitcoin core meeting, the bitcoin-dev mailing list is outside it's scope, not that I mind
12:43 < jonasschnelli> Yes. It's not managed by the Core team
12:43 < wumpus> anyhow, I think we had this, any other topics?
12:44 < wumpus> right
12:44 < warren> right
12:44 < wumpus> don't ask who it should be managed by, but it's not core's thing
12:45 < wumpus> anyone who does care about the list should be happy that warren is doing this work at all, if not, it would just disappear
12:46 < jnewbery> ^ agree. Thanks warren!
12:46 < warren> It's worth noting despite trying to deprecate the old mailman2 server they've tried to keep it online for us and a few other dev communities who had a hard time moving, and most of their downtime trouble was due to DoS attacks targeting only bitcoin-dev.
12:46 < jonasschnelli> *sigh*
12:46 < warren> The new infrastructure they recommend they are not concerned about DoS attacks, it's expected and better maintained so it won't fall over so easily.
12:48 < wumpus> thanks to the Linux Foundation too, then! it wouldn't be crazy for them to drop bitcoin-dev if it's such a hot potato
12:48 < wumpus> going to end this meeting, I don't think there's any more topics
12:48 < wumpus> #endmeeting
12:48 < lightningbot> Meeting ended Thu Mar 21 19:48:58 2019 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
12:48 < lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-03-21-19.00.html
12:48 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-03-21-19.00.txt
12:48 < lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-03-21-19.00.log.html
12:49 < cfields> jonasschnelli: Arrgh, I see what happened. I checked a few weeks ago to see when the cert would expire, and it's March 5 2019. But for whatever reason it was displayed in european order as 5/3/2019, so I thought we had time.
12:49 < warren> I was afraid they would want to drop us because of these attacks but they see us as potentially important one day. Currently they don't understand us but "they stole some top kernel engineers ... might be important"
12:49 < wumpus> surprisingly much of the infrastructure and stuff around bitcoin is hanging together by a few threads, and single individuals that happily still care about it
12:50 < cfields> And maybe the signature only worked because we use osslsigncode rather than the official tool.
12:50 < cfields> That still doesn't explain why the installer worked, though.
12:50 < jonasschnelli> cfields: heh. No worries. Just tell me where to buy a new one (if you know that)
12:50 < warren> oh I missed the win signature discussion, will it be something other than Bitcoin Foundation in the future?
12:50 < jonasschnelli> gwillen eventually sponsors the cert (well,.. he doesn't know the costs yet)
12:50 < jonasschnelli> warren: yes
12:51 < cfields> jonasschnelli: I'll look up the old stuff and forward it to you. Gavin forwarded the previous registration stuff to me I think.
12:51 < jonasschnelli> Bitcoin Core Code Signing Association (based in Switzerland)
12:51 < jonasschnelli> (same as for macOS since a while)
12:52 < jnewbery> cfields: 'european order' lol
12:52 < gwillen> yes I am happy to formally donate to the Bitcoin Core Code Signing Association, someone should tell me an amount and where to mail a check :-)
12:52 < jonasschnelli> a check he said
12:52 < gwillen> ;-)
12:52 < cfields> jnewbery: Lol, wow. Can't believe it came out that way.
12:53 < jonasschnelli> BTW: https://github.com/bitcoincore-codesigning-association 
12:53 < jonasschnelli> https://bitcoincorecodesigning.org
12:53 < warren> gwillen: if only we had some kind of electronic bearer instrument
12:53 < jonasschnelli> haha
12:53 < wumpus> hehe
12:53 < gwillen> here in the united states of the 19th century, we do everything by check
12:57 < cfields> jnewbery: in case you're having trouble keeping up, that's 91sth century in european order.
12:58 < cfields> jonasschnelli: hmm, all I can tell really is that it came from Comodo.
12:59 < jonasschnelli> cfields: I guess using comodo then makes sense
12:59 < jonasschnelli> Are there any configuration parameters?
12:59 < jnewbery> Thanks cfields! Philippines and Solamalia also use your back-front-to middle-endian date format, so it's not just the US :)
12:59 < cfields> jonasschnelli: yea, I was looking for any kind of config/record/params and don't see any record :(
13:00 < cfields> jonasschnelli: the old cert is in git though if it helps to take a look at
13:00 < cfields> sec for a dump
13:00 < sipa> gwillen: i was very surprised when my first paycheck in the US was actually a piece of paper :p
13:00 < jonasschnelli> thanks...
13:01 < cfields> jonasschnelli: https://pastebin.com/raw/vCCimFVj
13:01 < gwillen> sipa: I pay my rent by instructing my bank to print a piece of paper and send it through the US Mail once a month
13:01 < cfields> jonasschnelli: sha256 for sure, sha1 caused a headache at one point. Though I assume it's not an option anymore.
13:02 < jonasschnelli> hopefully
13:02 < cfields> we didn't really discuss who would actually hold the cert...
13:02 < cfields> gmaxwell: did that threshold scheme ever get anywhere?
13:03 < cfields> s/cert/key/
13:03 < jonasschnelli> I think – because we can always re-issue – we should go with cfields holding it for now (to keep status quo)
13:04 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has quit [Remote host closed the connection]
13:04 < cfields> Fine by me. I'd also be completely fine with you holding both.
13:05 < jonasschnelli> cfields: I'd prefer if you hold the windows cert.
13:06 < cfields> np
13:06 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has joined #bitcoin-core-dev
13:06 < wumpus> jonasschnelli: https://bitcoincorecodesigning.org <- nice website
13:07 < cfields> Whoa, I had no idea. +1 :)
13:07 < jonasschnelli> Well... if someone questions the existence of the association... I haven had to get a D.U.N.S. number to walk though the apple process
13:08 < cfields> Ah, heh. Makes sense.
13:08 < jonasschnelli> cfields: Please provide gwillen your email address,.. so only you can then create / manage the certificate
13:08 < jonasschnelli> (he will buy it... if that works)
13:08 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has quit [Remote host closed the connection]
13:09 < jonasschnelli> I need to cut costs on my side,.. since Bitmain is in troubles
13:24 < warren> jonasschnelli: what is the structure of the association? surely we should spread these costs out to many members? how is the association chartered? I had been exploring with the Linux Foundation ways to charter non-profits in ways where funders are unable to interfere with the mission of an org for readingbitcoin.org
13:25 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has joined #bitcoin-core-dev
13:25 < jonasschnelli> warren: there is no real structure. :/ It has just been setup with minimal paperwork to get the certificates
13:26 < jonasschnelli> I think its probably not worth to do it...
13:27 < jonasschnelli> There is another association I'm currently building up (with a proper structure) called "Bitcoin Developer and Researcher Association" (BitDRA) which should aim to finance real work/projects
13:30 < warren> I think people have rightly been fearful of central orgs paying for developers, but we're increasingly seeing multiple orgs both for-profit and non-profit. Some common safety driven peer-review driven process between many contributing orgs seems to be de facto how this can work without creating new risks.
13:32 < gmaxwell> please thats unrelated to the signing thing. the signing thing should be single purpose and isolated.
13:32 < jonasschnelli> Yes. Indeed
13:32 < warren> I didn't suggest they be related.
13:41 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has quit [Remote host closed the connection]
13:46 < luke-jr> jonasschnelli: what makes little sense is Core-only. what good is it to pay the same costs more than once for no benefit?
13:47 < luke-jr> gwillen: Knots at least; I would think HWI stuff also, and probably Lightning wallets
13:47 < jonasschnelli> luke-jr: I see that point. Its just about risks, affiliation and key management
13:47 < jonasschnelli> Which is not worth for the costs of 200$/year
13:48 < jonasschnelli> (not worth to mix IMO)
13:48 < cfields> gmaxwell: see above about the threshold stuff. Any reason to hold off a day or two for something better than a single signer?
13:48 < gmaxwell> I've got nothing there. Sorry.
13:48 < cfields> Ok, np.
13:49 -!- Guest40623 [c0f19d1b@gateway/web/freenode/ip.192.241.157.27] has quit [Ping timeout: 256 seconds]
13:50 < luke-jr> jonasschnelli: what risks/affiliation?
13:51 < warren> luke-jr: it's hard enough to be responsible for one publication, if it costs $200/yr you're better off creating another org get to another key.
13:51 < jonasschnelli> luke-jr: Assume Core goes rouge, or Knots, ... or the key gets compromised by one of the ends
13:51 < luke-jr> jonasschnelli: multiple targets doesn't really change that?
13:52 < luke-jr> warren: plus time to research how to set it all up; once set up, signing multiple things doesn't really add difficulty
13:53 < jonasschnelli> luke-jr: well,... you could end up with a signing malicious binaries that tears down the other organisation (not technically)
13:53 < luke-jr> jonasschnelli: obviously there would have to be some reasonable policy on what gets signed (eg, gitian builds of Bitcoin-compatible software)
13:53 < warren> luke-jr: it's problematic that this signature essentially leads to users blindliy trusting it as almost nobody verifies gitian builds actually match up.
13:54 < luke-jr> warren: that's a problem regardless :/
13:54 < luke-jr> and if anything, signing more things would *reduce* that
13:55 -!- jb55 [~jb55@S010660e327dca171.vc.shawcable.net] has quit [Ping timeout: 245 seconds]
13:56 < sipa> what is the signatures provided by this org supposed to assert?
13:56 < sipa> "this binary is the gitian build of this git commit"?
13:56 < sipa> or "this is bitcoin core"
13:56 < luke-jr> "this binary is the gitian build of this git commit" sounds reasonable, if even that
13:57 < gwillen> "the bitcoin core code signing association thinks Windows should not yell when running this binary"
13:57 < luke-jr> "this is bitcoin core" *should* be meaningless really
13:57 < jonasschnelli> sipa: its just hocus pocus 
13:57 < luke-jr> gwillen: pretty much :P
13:57 < gwillen> the problem is that you will get your cert revoked if something goes bad with a binary you sign
13:57 < luke-jr> sipa: the problem is certain DRM-laden OSs seem to be moving more and more toward a permissioned model
13:57 < warren> although if that signature can't be threshold then it's really "this centralized signing association seems to have verified the gitian reproducibility of this binary and has enabled you to blindly trust this signing key"
13:57 < sipa> luke-jr: if it is meaningless, the concept of code signing is meaningless unfortunately
13:57 < jonasschnelli> It only tells users it was signed by an organisation called "Bitcoin Core Code Signing Association"
13:58 < jonasschnelli> Its only for UX (in macOS you can't start unsigned applications by default)
13:58 < luke-jr> sipa: it's to get into walled gardens
13:58 < jonasschnelli> IMO it provides near to 0 security
13:59 < luke-jr> gwillen: I would expect "goes bad" to have to be malicious?
14:00 < jonasschnelli> (An attacker could register "Bitcoin Core Code Shitting Association" and signing the malicious binary with that and nobody would recognise that)
14:00 < gwillen> I'm not sure what kind of problem it would take to get a cert revoked
14:00 < jonasschnelli> The only security is probably that one needs to pay for the cert... :)
14:02 < warren> The best we can do is 1) have orgs like this sign 2) have separate orgs verify the reproducibility of what is claimed to be signed and to sound off alarms if it doesn't match 3) peer-review process hopefully prevents malicious code from getting to publication
14:07 < cfields> sipa: I've always assumed your first definition. I've also been careful to never publish a full signed binary, only the detached part of the binary that _I built_. So it's useless unless reproducible.
14:08 < cfields> *detached sig for the binary
14:08 < gmaxwell> gwillen: they don't even revoke stuff that is signing malware. I think the only way to get a cert revoked is to directly piss off an executive at the related companies.
14:08 < luke-jr> lol >_<
14:11 < warren> Windows browsers, at least Microsoft Edge and Chrome seem to rely on centralized lookup of binary hashes. Known malicious binaries are flagged. If a binary is too new to be known by those lookup services then the browser warns the user. It seems they use this instead of certificate revocation.
14:12 < warren> (also yikes, who has access to the server seeing all the lookups?)
14:16 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has joined #bitcoin-core-dev
14:16 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has quit [Remote host closed the connection]
14:16 < sipa> cfields: so i think if all the signature itls intendes to convey is a correct build from some source code, it isn't really usable as codesigning thing for win/osx applications
14:17 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has joined #bitcoin-core-dev
14:19 < cfields> sipa: "isn't really usable" meaning it's not working as would be expected to users?
14:19 < sipa> cfields: there would at least be some implied understanding that the cert asserts the source code comes from a reliable repository with review practices
14:20 < sipa> or even that the source code is what people canonically understand to be bitcoin core
14:20 < cfields> sipa: yes, agreed. It doesn't function that way at all.
14:21 < cfields> Which will be pretty obvious when ~0 people notice that new releases are coming from a new developer cert :)
14:21 < warren> 3rd party verifiers checking and sounding alarms is the best we can do under current limitations
14:21 < sipa> i don't know what the solution is... i can see the use of a "this just asserts the build was created correctly!" service, but it isn't what people (and microsoft/apple) would understand a codesigning cert to correspond to
14:21 < cfields> We only codesign to make the stupid nag screens go away at install-time.
14:22 < gwillen> I don't think microsoft/apple understand the cert to mean anything in particular
14:22 < gwillen> it is really just a hoop to jump through so users will be permitted to run the binary
14:22 -!- randy-waterhouse [~kiwigb@163.47.164.213] has joined #bitcoin-core-dev
14:23 -!- jb55 [~jb55@S010660e327dca171.vc.shawcable.net] has joined #bitcoin-core-dev
14:23 -!- randy-waterhouse [~kiwigb@163.47.164.213] has quit [Changing host]
14:23 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has joined #bitcoin-core-dev
14:23 < warren> plenty of windows software isn't signed now, while Apple a few years ago locked down the UX where the user had to jump through hoops to run unsigned binaries
14:24 < cfields> sipa: agree that would be a neat service, independent of codesigning.
14:24 < cfields> warren: that's the case in Windows too.
14:24 < sipa> gwillen: i'm sure there is some sense of verifying that the binary was signed by the known developer of the software it claims
14:24 < gwillen> there really isn't
14:24 < gwillen> I mean, maybe some manager somewhere in the process has that mental model
14:25 < gwillen> but the implementation sure doesn't care
14:25 < sipa> haha
14:25 < gwillen> you can get EV certs
14:25 < warren> I didn't suggest a solution but I did mention above that Windows browsers already use a hash blacklist for known bad downloads. It sucks that we can't have additional checks in front of the signature but maybe we could add safeguards after.
14:25 < gwillen> but the regular certs run just fine
14:25 < gwillen> sipa: I just bought one of these using my own name and credit card and cfields' email address
14:25 < gwillen> they didn't verify anything other than that my money was green
14:26 < sipa> gwillen: say you're the developer of GwillenCalc, could I register as Glenn Willen from GwillenSoft and publish a backdoored version of GwillenCalc that way?
14:26 < gwillen> yes, 100%
14:26 < gwillen> at least as far as I can tell
14:26 < sipa> interesting
14:26 < gwillen> they are just like SSL certs
14:26 < gwillen> except with no domain to bind to
14:27 < warren> gwillen: windows cert, apple or both? The latter seems more strict?
14:28 < cfields> sipa: To that point, in another life, we had to squat on our app's name months before the android port was complete and actually ready for the App Store.
14:28 < cfields> I don't remember the details now, but I believe it was because there was very little in place to prevent what you're describing.
14:28 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Remote host closed the connection]
14:28 < gwillen> I think apple is a little stricter
14:29 < gwillen> you can only get an apple code signing cert directly from apple through your apple account, which they will presumably blacklist if you misuse it
14:29 < gwillen> the windows one I just bought from Comodo, which should tell you everything you need to know
14:31 < luke-jr> at the end of the day, if Jonas doesn't do a general codesigning thing, I'll probably need to eventually, and it would be nice to have the general one (whoever does it) sponsored :/
14:31 < cfields> gwillen: Microsoft isn't the gatekeeper, it's decentralized.... to the 3(?) whitelisted CA's :p.
14:33 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev
14:37 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Remote host closed the connection]
14:47 -!- trillhc [~trillhc@c-71-232-65-53.hsd1.ma.comcast.net] has joined #bitcoin-core-dev
14:53 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #bitcoin-core-dev
14:59 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
15:00 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
15:00 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
15:03 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has quit [Quit: quit]
15:04 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev
15:05 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has joined #bitcoin-core-dev
15:05 -!- user__ [~user@185.236.201.131] has joined #bitcoin-core-dev
15:09 -!- m8tion_ [~user@185.236.201.131] has quit [Ping timeout: 268 seconds]
15:11 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has quit [Quit: quit]
15:15 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has joined #bitcoin-core-dev
15:18 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
15:19 -!- aqquadro [~name@unaffiliated/aqquadro] has quit [Quit: Leaving]
15:20 -!- mmgen [~mmgen@gateway/tor-sasl/mmgen] has quit [Quit: (https://github.com/mmgen) leaving]
15:21 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has quit [Quit: quit]
15:22 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has joined #bitcoin-core-dev
15:30 -!- user__ [~user@185.236.201.131] has quit [Ping timeout: 252 seconds]
15:31 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
15:32 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Remote host closed the connection]
15:36 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 268 seconds]
15:42 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
15:47 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has quit [Quit: quit]
15:47 -!- TheRec [~toto@drupal.org/user/146860/view] has quit []
15:48 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has joined #bitcoin-core-dev
15:52 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
15:59 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has quit [Quit: quit]
16:01 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has joined #bitcoin-core-dev
16:04 < echeveria> wumpus: for the record, I reported the malicious versions of the bitcoin core website to the host. 
16:04 < echeveria> which sadly has a similar domain name.
16:05 < echeveria> warren: it's a bloom filter. 
16:05 < echeveria> for things like google safebrowsing, which catches a lot of things like some of the electrum malware. 
16:05 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Excess Flood]
16:06 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
16:06 < warren> echeveria: ahhh
16:06 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #bitcoin-core-dev
16:06 < warren> echeveria: it sucks when it flags non-malicious things as malicious, which sometimes happens
16:07 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
16:07 < echeveria> safebrowsing in particular seems to have crappy review. 
16:07 < echeveria> it's totally random if a report with a binary analysis of malware ends up in the list or not. 
16:08 -!- booyah_ [~bb@193.25.1.157] has joined #bitcoin-core-dev
16:09 -!- booyah [~bb@193.25.1.157] has quit [Read error: Connection reset by peer]
16:09 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev
16:11 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Ping timeout: 268 seconds]
16:12 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Remote host closed the connection]
16:12 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
16:12 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection]
16:13 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
16:30 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has quit [Remote host closed the connection]
16:30 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has joined #bitcoin-core-dev
16:35 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has quit [Ping timeout: 252 seconds]
16:36 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 272 seconds]
16:39 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 250 seconds]
16:40 -!- dqx_ [~dqx@unaffiliated/dqx] has quit [Remote host closed the connection]
16:42 < luke-jr> warren: what sucks most, is that there's literally no way to appeal it
16:43 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Remote host closed the connection]
16:48 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #bitcoin-core-dev
16:54 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
17:08 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev
17:21 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Ping timeout: 252 seconds]
17:22 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds]
17:25 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
17:28 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Read error: Connection reset by peer]
17:28 -!- mn94958830 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Read error: Connection reset by peer]
17:28 -!- mn94958831 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev
17:28 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev
17:29 -!- jarthur [~jarthur@207.114.244.5] has quit [Remote host closed the connection]
17:34 -!- mn94958831 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Ping timeout: 272 seconds]
17:34 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Ping timeout: 272 seconds]
17:52 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Remote host closed the connection]
18:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
18:02 < bitcoin-git> [bitcoin] fanquake opened pull request #15637: rpc: Rename size to vsize in mempool related calls (master...rebased-13008-rename-size-vsize) https://github.com/bitcoin/bitcoin/pull/15637
18:02 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
18:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
18:04 < bitcoin-git> [bitcoin] fanquake closed pull request #13008: rpc: Rename size to vsize in mempool related calls (master...rename-size-to-vsize) https://github.com/bitcoin/bitcoin/pull/13008
18:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
18:19 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
18:21 -!- zhangzf [~zhangzf@106.38.157.147] has joined #bitcoin-core-dev
18:23 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev
18:23 -!- mn94958825 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev
18:26 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Remote host closed the connection]
18:26 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev
18:30 -!- mn949588 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Ping timeout: 252 seconds]
18:30 -!- mn94958825 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has quit [Ping timeout: 244 seconds]
18:40 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
19:09 -!- 77FABRWV5 [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev
19:09 -!- 7GHAAJ5WO [~nodebot@cpe-67-243-201-127.nyc.res.rr.com] has joined #bitcoin-core-dev
19:12 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has joined #bitcoin-core-dev
19:18 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #bitcoin-core-dev
19:21 -!- e4xit [~e4xit@cpc123762-trow7-2-0-cust7.18-1.cable.virginm.net] has quit [Ping timeout: 244 seconds]
19:52 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Ping timeout: 244 seconds]
19:52 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev
19:57 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Ping timeout: 268 seconds]
20:02 -!- jimmysong [~jimmysong@72-48-253-51.dyn.grandenetworks.net] has quit [Remote host closed the connection]
20:03 -!- dqx_ [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev
20:09 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit []
20:20 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 245 seconds]
20:23 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
20:34 -!- randy-waterhouse [~kiwigb@opentransactions/dev/randy-waterhouse] has quit [Quit: Leaving.]
20:37 -!- jarthur [~jarthur@2605:6000:1019:41ab:543b:d3be:3d59:1293] has joined #bitcoin-core-dev
20:40 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has quit [Remote host closed the connection]
20:40 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has joined #bitcoin-core-dev
20:44 -!- jimmysong [~jimmysong@72-48-253-51.dyn.grandenetworks.net] has joined #bitcoin-core-dev
20:45 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has quit [Ping timeout: 272 seconds]
20:50 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has quit [Ping timeout: 252 seconds]
21:31 -!- Liliaceae [sid282374@gateway/web/irccloud.com/x-pgjhzetpwfgyoyax] has quit [Ping timeout: 240 seconds]
21:31 -!- moneyball [sid299869@gateway/web/irccloud.com/x-jjtkpqrrwnedlvjr] has quit [Ping timeout: 240 seconds]
21:31 -!- gertjaap [sid322815@gateway/web/irccloud.com/x-frzxikjgiwuvoyvy] has quit [Ping timeout: 240 seconds]
21:32 -!- gertjaap [sid322815@gateway/web/irccloud.com/x-xcewrgqsblwtugxg] has joined #bitcoin-core-dev
21:32 -!- moneyball [sid299869@gateway/web/irccloud.com/x-tesjqvrqrquivtab] has joined #bitcoin-core-dev
21:32 -!- wallet42 [sid154231@gateway/web/irccloud.com/x-qtccbjvovwysxxew] has quit [Ping timeout: 250 seconds]
21:33 -!- profmac [~ProfMac@2001:470:1f0f:226:f17f:7c88:dd21:684a] has quit [Ping timeout: 240 seconds]
21:33 -!- gleb [sid306870@gateway/web/irccloud.com/x-ndymmarbzfcghhgg] has quit [Ping timeout: 268 seconds]
21:33 -!- jamesob [sid180710@gateway/web/irccloud.com/x-yikedfrcghkqvvoi] has quit [Ping timeout: 240 seconds]
21:33 -!- zivl_ [~zivl@unaffiliated/zivl] has quit [Ping timeout: 250 seconds]
21:33 -!- nejon [sid38993@gateway/web/irccloud.com/x-vorysjzfdukpjbuh] has quit [Ping timeout: 268 seconds]
21:34 -!- zivl [~zivl@unaffiliated/zivl] has joined #bitcoin-core-dev
21:34 -!- Liliaceae [sid282374@gateway/web/irccloud.com/x-kmcdzbelcbucqwqf] has joined #bitcoin-core-dev
21:35 -!- wallet42 [sid154231@gateway/web/irccloud.com/x-xnxoryliskxrmlwp] has joined #bitcoin-core-dev
21:36 -!- Squidicc [~squid@pool-72-74-34-120.bstnma.fios.verizon.net] has joined #bitcoin-core-dev
21:36 -!- gleb [sid306870@gateway/web/irccloud.com/x-kpkwdyzteahkfnwh] has joined #bitcoin-core-dev
21:36 -!- nejon [sid38993@gateway/web/irccloud.com/x-wxazxrheakzqaext] has joined #bitcoin-core-dev
21:37 -!- Squidicuz [~squid@pool-72-74-34-120.bstnma.fios.verizon.net] has quit [Read error: Connection reset by peer]
21:39 -!- jamesob [sid180710@gateway/web/irccloud.com/x-lekguvwgevmaffes] has joined #bitcoin-core-dev
21:39 -!- profmac [~ProfMac@2001:470:1f0f:226:c52:ac47:bea2:bafd] has joined #bitcoin-core-dev
21:49 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #bitcoin-core-dev
21:51 -!- mischa010 [4dadf2fe@gateway/web/freenode/ip.77.173.242.254] has quit [Quit: Page closed]
22:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
22:00 < bitcoin-git> [bitcoin] ryanofsky opened pull request #15638: Move-only: Pull wallet code out of libbitcoin_server (master...pr/link) https://github.com/bitcoin/bitcoin/pull/15638
22:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
22:21 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit [Ping timeout: 252 seconds]
22:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
22:33 < bitcoin-git> [bitcoin] ryanofsky opened pull request #15639: bitcoin-wallet tool: Drop libbitcoin_server.a dependency (master...pr/link2) https://github.com/bitcoin/bitcoin/pull/15639
22:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
22:56 -!- Qualitat_ [5f998725@gateway/web/freenode/ip.95.153.135.37] has joined #bitcoin-core-dev
22:57 < Qualitat_> Helo
22:58 -!- Qualitat_ [5f998725@gateway/web/freenode/ip.95.153.135.37] has quit [Client Quit]
23:17 -!- dqx_ [~dqx@unaffiliated/dqx] has quit [Remote host closed the connection]
23:35 < wumpus> echeveria: thanks!
23:39 -!- jarthur [~jarthur@2605:6000:1019:41ab:543b:d3be:3d59:1293] has quit []
--- Log closed Fri Mar 22 00:00:22 2019