--- Log opened Tue Apr 02 00:00:33 2019
00:04 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Ping timeout: 246 seconds]
00:05 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
00:17 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has quit [Ping timeout: 256 seconds]
00:18 -!- dermoth [~dermoth@gateway/tor-sasl/dermoth] has joined #bitcoin-core-dev
00:18 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 256 seconds]
00:20 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev
00:22 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
00:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:39 < bitcoin-git> [bitcoin] laanwj closed pull request #15714: tests: Volkswagen (master...1904-testsVolkswagen) https://github.com/bitcoin/bitcoin/pull/15714
00:39 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:51 -!- shtirlic [~shtirlic@ec2-18-185-133-40.eu-central-1.compute.amazonaws.com] has quit [Quit: ZNC - http://znc.in]
00:59 -!- rex4539 [~rex4539@ppp-2-84-169-44.home.otenet.gr] has quit [Quit: rex4539]
00:59 -!- Krellan [~Krellan@2601:640:4000:a876:28ca:4827:bc13:8e2e] has joined #bitcoin-core-dev
01:02 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev
01:03 -!- Krellan [~Krellan@2601:640:4000:a876:28ca:4827:bc13:8e2e] has quit [Ping timeout: 250 seconds]
01:05 -!- shtirlic [~shtirlic@ec2-18-185-133-40.eu-central-1.compute.amazonaws.com] has joined #bitcoin-core-dev
01:14 -!- shtirlic [~shtirlic@ec2-18-185-133-40.eu-central-1.compute.amazonaws.com] has quit [Quit: ZNC - http://znc.in]
01:15 -!- shtirlic [~shtirlic@ec2-18-185-133-40.eu-central-1.compute.amazonaws.com] has joined #bitcoin-core-dev
01:18 -!- mn94958858 [~nodebot@cpe-67-243-195-224.nyc.res.rr.com] has quit [Remote host closed the connection]
01:18 -!- mn949588 [~nodebot@cpe-67-243-195-224.nyc.res.rr.com] has quit [Remote host closed the connection]
01:18 -!- mn94958862 [~nodebot@cpe-67-243-195-224.nyc.res.rr.com] has quit [Remote host closed the connection]
01:19 -!- mn9495885 [~nodebot@cpe-67-243-195-224.nyc.res.rr.com] has joined #bitcoin-core-dev
01:19 -!- mn94958863 [~nodebot@cpe-67-243-195-224.nyc.res.rr.com] has joined #bitcoin-core-dev
01:19 -!- mn949588 [~nodebot@cpe-67-243-195-224.nyc.res.rr.com] has joined #bitcoin-core-dev
01:24 -!- StopAndDecrypt_ [~StopAndDe@96.44.189.226] has quit [Ping timeout: 246 seconds]
01:30 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has joined #bitcoin-core-dev
01:55 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev
02:23 -!- rex4539 [~rex4539@ppp-2-84-169-44.home.otenet.gr] has joined #bitcoin-core-dev
02:31 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev
03:02 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
03:18 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
03:28 -!- shtirlic [~shtirlic@ec2-18-185-133-40.eu-central-1.compute.amazonaws.com] has quit [Quit: ZNC - http://znc.in]
03:29 -!- shtirlic [~shtirlic@ec2-18-185-133-40.eu-central-1.compute.amazonaws.com] has joined #bitcoin-core-dev
03:59 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
04:04 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has quit [Remote host closed the connection]
04:14 -!- jonatack [d598a1ea@gateway/web/freenode/ip.213.152.161.234] has joined #bitcoin-core-dev
04:34 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev
04:35 < fanquake> sipa / wumpus could you block Stivovo from GH. They are spamming nonsense in multiple threads.
04:36 -!- Aaronvan_ is now known as AaronvanW
04:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:38 < bitcoin-git> [bitcoin] scravy closed pull request #15715: Better support for mainframes and EBCDIC users in general (master...cater-mainframes-and-ebcdic-users) https://github.com/bitcoin/bitcoin/pull/15715
04:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:38 < wumpus> fanquake: yes, probably for the best
04:38 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-oslswfglxvkhcjen] has joined #bitcoin-core-dev
04:40 < fanquake> missed some discussion last week, but must be close to an rc3 post #15691.
04:40 < gribble> https://github.com/bitcoin/bitcoin/issues/15691 | 0.18: rc3 backports by MarcoFalke · Pull Request #15691 · bitcoin/bitcoin · GitHub
04:41 < wumpus> yes, looking at that one
04:42 < wumpus> I think you're right
04:43 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 246 seconds]
04:49 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.4]
05:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:03 < bitcoin-git> [bitcoin] laanwj pushed 9 commits to 0.18: https://github.com/bitcoin/bitcoin/compare/7bcf90cb01aa...32ec90085044
05:03 < bitcoin-git> bitcoin/0.18 6355214 Pieter Wuille: Simplify orphan processing in preparation for interruptibility
05:03 < bitcoin-git> bitcoin/0.18 bb60121 Pieter Wuille: [MOVEONLY] Move processing of orphan queue to ProcessOrphanTx
05:03 < bitcoin-git> bitcoin/0.18 50c56f2 Pieter Wuille: Interrupt orphan processing after every transaction
05:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:03 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:03 < bitcoin-git> [bitcoin] laanwj merged pull request #15691: 0.18: rc3 backports (0.18...1904-18B) https://github.com/bitcoin/bitcoin/pull/15691
05:04 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:04 < wumpus> going to tag rc3 in a bit
05:06 < fanquake> \o/
05:06 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
05:09 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
05:16 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
05:21 -!- rex4539 [~rex4539@ppp-2-84-169-44.home.otenet.gr] has quit [Quit: rex4539]
05:26 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has joined #bitcoin-core-dev
05:38 -!- shtirlic [~shtirlic@ec2-18-185-133-40.eu-central-1.compute.amazonaws.com] has quit [Quit: ZNC - http://znc.in]
05:39 -!- shtirlic [~shtirlic@ec2-18-185-133-40.eu-central-1.compute.amazonaws.com] has joined #bitcoin-core-dev
05:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
05:46 < bitcoin-git> [bitcoin] laanwj pushed tag v0.18.0rc3: https://github.com/bitcoin/bitcoin/compare/v0.18.0rc3
05:46 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
05:49 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 245 seconds]
05:49 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 244 seconds]
05:51 < wumpus> ^^
05:52 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev
05:56 -!- obsrver [~quassel@p5DC6B545.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
06:01 < fanquake> Am building. Having some connection issues with archive.ubuntu.com
06:01 -!- peter__ [c5f5a962@gateway/web/freenode/ip.197.245.169.98] has joined #bitcoin-core-dev
06:06 -!- peter__ [c5f5a962@gateway/web/freenode/ip.197.245.169.98] has quit [Ping timeout: 256 seconds]
06:11 < wumpus> hopefully this is the last major release that needs to rely on that
06:25 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Ping timeout: 258 seconds]
06:32 -!- schmidty [~schmidty@unaffiliated/schmidty] has quit []
06:35 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has joined #bitcoin-core-dev
06:35 -!- schmidty [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has quit [Changing host]
06:35 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
06:36 -!- Krellan [~Krellan@2601:640:4000:a876:703a:6e9d:c2a4:b28c] has joined #bitcoin-core-dev
06:41 -!- Krellan [~Krellan@2601:640:4000:a876:703a:6e9d:c2a4:b28c] has quit [Ping timeout: 250 seconds]
06:46 < Sentineo> g8, building, too
06:47 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
06:51 -!- promag [~promag@83.223.249.30] has joined #bitcoin-core-dev
06:52 -!- rex4539 [~rex4539@ppp-2-84-169-44.home.otenet.gr] has joined #bitcoin-core-dev
06:56 -!- promag [~promag@83.223.249.30] has quit [Ping timeout: 268 seconds]
07:15 -!- Tralfaz [49dde1e1@gateway/web/freenode/ip.73.221.225.225] has joined #bitcoin-core-dev
07:24 < jamesob> can we maybe consider putting something in the developer guide about line length? some of these >120 col lines make review in github a pain
07:24  * jamesob ducks
07:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:33 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/5a2a9b5b0603...8dbb2c5e6704
07:33 < bitcoin-git> bitcoin/master f516245 John Newbery: [rpc] remove resendwallettransactions RPC
07:33 < bitcoin-git> bitcoin/master ea1a2d8 John Newbery: [wallet] Remove ResendWalletTransactionsBefore
07:33 < bitcoin-git> bitcoin/master 8dbb2c5 MarcoFalke: Merge #15680: Remove resendwallettransactions RPC method
07:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:33 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15680: Remove resendwallettransactions RPC method (master...2019_03_remove_resendwallettransactions) https://github.com/bitcoin/bitcoin/pull/15680
07:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:34 < bitcoin-git> [bitcoin] practicalswift opened pull request #15721: validation: Check absence of locks at compile-time (LOCKS_EXCLUDED) in addition to the current run-time checking (AssertLockNotHeld) (master...negative-locking-annotations) https://github.com/bitcoin/bitcoin/pull/15721
07:34 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:39 -!- user_ [~user@185.181.17.193] has joined #bitcoin-core-dev
07:41 -!- user_ [~user@185.181.17.193] has left #bitcoin-core-dev []
07:42 -!- kljasdfvv [~flack@p200300D46F0FA5006524FD876651F2AE.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!]
07:42 -!- jonatack [d598a1ea@gateway/web/freenode/ip.213.152.161.234] has quit [Quit: Page closed]
07:43 -!- kljasdfvv [~flack@p200300D46F0FA500897A368518A3B6F3.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
07:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:47 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/8dbb2c5e6704...2c364fde423e
07:47 < bitcoin-git> bitcoin/master ac67582 fanquake: depends: latest rapidcheck, use INSTALL_ALL_EXTRAS
07:47 < bitcoin-git> bitcoin/master 2c364fd MarcoFalke: Merge #14853: depends: latest RapidCheck
07:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
07:47 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #14853: depends: latest RapidCheck (master...latest-rapidcheck) https://github.com/bitcoin/bitcoin/pull/14853
07:47 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
07:52 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has joined #bitcoin-core-dev
07:57 < wumpus> jamesob: 120 as max line length suggestion sounds fine to me
07:58 < wumpus> jamesob: though it will probably run into tons of discussion, which is why no one never did that
07:59 < jamesob> I think "causes the need to scroll horizontally on github" is a pretty good standard for too long, so I'll just measure whatever that amounts to in terms of column length
08:09 -!- conman [~con@2001:44b8:4154:d801:cd93:fa7d:88ff:158c] has joined #bitcoin-core-dev
08:19 < wumpus> depends on your screen width and font size
08:25 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
08:25 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Remote host closed the connection]
08:34 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev
08:44 -!- Shivendra [7bc9f1a0@gateway/web/freenode/ip.123.201.241.160] has joined #bitcoin-core-dev
08:48 -!- Randolf [~randolf@96.53.47.42] has quit [Quit: Leaving]
08:49 < emilr> even 120 seems a bit too much, it's not about screen or font size, our brains are used with reading books 80c width lenght for hundreds of years
08:50 < dongcarl> Looking at #15717, not too familiar with how licenses work but it seems that libnatpmp has this license: https://pastebin.com/a6umcv4s
08:50 < gribble> https://github.com/bitcoin/bitcoin/issues/15717 | Changes to support NAT-PMP by MishraShivendra · Pull Request #15717 · bitcoin/bitcoin · GitHub
08:51 < dongcarl> Not sure if this should be subtree'd, used as a dependency or something else, and how the LICENSE would affect that.
08:52 -!- Shivendra [7bc9f1a0@gateway/web/freenode/ip.123.201.241.160] has quit [Ping timeout: 256 seconds]
08:52 < dongcarl> Perhaps someone could comment on the issue
08:57 -!- d_t [~d_t@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has quit [Ping timeout: 245 seconds]
09:06 < Sentineo> fanquake: you mean the download is really slow? cause it takes ages to get anything from archive.ubuntu.com. 
09:30 < wumpus> emilr: sigh, this is why we don't bother
09:32 < wumpus> dongcarl: that's the 3-clause BSD license, should be compatible with the MIT one
09:32 < wumpus> though not 100% sure tbh
09:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:35 < bitcoin-git> [bitcoin] laanwj closed pull request #15712: Update Copyright -> 2019 (master...copyright-2019) https://github.com/bitcoin/bitcoin/pull/15712
09:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:40 < dongcarl> wumpus: I guess the question is if we should subtree it or use it as a dependency? Right now it seems like the PR author wants to subtree it
09:41 < sipa> it's not a subtree
09:41 < sipa> he's copying the code with some modifications
09:41 < wumpus> it's a minimal amount of code, I think it would make sense to subtree, though I'm sure this is going to give tons of discussion
09:41 < sipa> the upstream code hasn't been touched since 2011
09:41 < wumpus> whoa
09:42 < wumpus> that is a big red flag
09:42 < wumpus> this effectively means we're going to have to maintain it ourselves
09:42 < dongcarl> actual upstream: http://miniupnp.free.fr/files/
09:43 < dongcarl> changelog says haven't been touched since 2013
09:43 < wumpus> if we have that *and* potential license issues
09:44 < sipa> if it does what it's designed to do, there isn't much maintainanxe to be expected
09:45 < dongcarl> protocol seems quite minimal: http://miniupnp.free.fr/nat-pmp.html
09:45 < wumpus> it's still scope creep, but ok
09:45 < wumpus> if someone commits to maintaining it it's fine with me, I'm just not going to do it
09:45 < sipa> fair
09:46 < sipa> regarding licence issues... i think we just need to list it in asset-attributions
09:46 < sipa> but ianal
09:47 < sipa> i have no idea about the complexity of the protocol... if it's simple enough (or at least the parts we need are simple enough), reimplementing just that part may be preferable
09:47 < wumpus> I'm not sure...
09:48 < sipa> miniupnp has a history of vulnerabilities... is this written by the same authors?
09:48 < wumpus> yes
09:49 < wumpus> though it's easier to get right, at least there's no xml generation/parsing in here
09:49 < wumpus> though it's still quite a heap of C code
09:51 < wumpus> in any case that can be improved later, I guess
09:51 < dongcarl> Reading thru the libnatpmp repo... It seems extremely simple... 
09:51 < wumpus> it's great that someone is working on this
09:53 < dongcarl> I think we just need natpmp.{c,h} and getgateway.{c,h}
09:53 < dongcarl> Can someone explain to me what the difference between subtree-ing and just copying code is?
09:54 < jamesob> dongcarl: pulling in from upstream is way better with a subtree
09:54 < wumpus> subtreeing sets up git to easily update to newer versions of the tree, also it allows preserving commits (though we don't do this)
09:56 -!- dqx_ [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev
09:57 < sipa> subtree also only makes sense if upstream is a git repo
09:57 < wumpus> yes
09:59 < wumpus> I think mentioning the files in assets-attribution makes sense, though we've never before done this for code
10:00 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/]
10:01 < wumpus> this would nto be acceptable for a completely incompatible license such as (L)GPL, but MIT/BSD is close enough
10:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:01 < bitcoin-git> [bitcoin] emilengler opened pull request #15722: doc: Change block chain to blockchain in doc (master...fix-typos) https://github.com/bitcoin/bitcoin/pull/15722
10:01 < dongcarl> I see, so we should copy in the files then. Something like `src/libnatpmp`?
10:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:02 < wumpus> it doesn't 'infect' the project, nor the licensing of the binary
10:03 < wumpus> dongcarl: that's what they do right?
10:03 < dongcarl> Ah. Right.
10:14 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 244 seconds]
10:17 -!- Shivendra [af649512@gateway/web/freenode/ip.175.100.149.18] has joined #bitcoin-core-dev
10:41 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-oslswfglxvkhcjen] has quit [Quit: Connection closed for inactivity]
10:43 < luke-jr> something like libnatpmp should just be a dependency, not copied or subtree'd at all -.-
10:45 < luke-jr> jamesob: best not to review in github anyway
10:46 < jamesob> luke-jr: agree but inevitably you end up reading stuff in GH since we leave comments there
10:46 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
10:47 < gmaxwell> I don't think natpmp is worth taking a sketchy library dependency, it's only supported by a relatively small number of devices. It sounded attractive when I expected its implementation to be two structs and <50 loc.
10:48 < luke-jr> gmaxwell: is that certainly not possible?
10:48 < gmaxwell> no one seems interested in doing it.
10:50 < gmaxwell> esp with the bad history of miniupnpc...  taking /another/ dependency on code from there just seems kinda foolish.
10:53 < wumpus> especially one that hasn't been updated since 2013
10:53 < wumpus> either we merge it in and someone picks up maintenance of it, or it's dead in the water
10:54 < gmaxwell> that in and of itself isn't /necessarily/ a concern, it's a really simple protocol.  Unlike C++ in C the language isn't shifting out from under you. :P 
10:54 < wumpus> looks like the person maintaining it already cut it down a lot, btw
10:54 < gmaxwell> but its not not a concern either.
10:54 < wumpus> to only contain the parts that are needed for bitcoind and nothing else
10:54 < wumpus> s/maintaining/submitting
10:55 < gmaxwell> thats good there was a lot of stuff we didn't need in there before for sure.
10:55 < gmaxwell> (pmp is a small protocol and we only need a small subset of it)
10:55 < luke-jr> it looks like 2015 to me?
10:56 < gmaxwell> The ongoing sybil/eclipse attacks on the network highlight the need to get more ordinary users esp ones not on vpses listening. 
10:56 < sipa> it's still 1100 lines of imported code or so
10:57 < dongcarl> It seems like the GitHub is maintained: https://github.com/miniupnp/libnatpmp
11:03 < wumpus> I honestly don't think we're ever going to agree on this, I just want to encourage the PR author to continue this work tbh
11:04 < wumpus> I could see this being abandoned again because everyone wants something else
11:06 < gmaxwell> I don't want to stand in the way of it.  If we do go the library route I'll still go review the libraries code, even though I'm wary of it considering the source (and the surprisingly large size given how little we need).
11:08 < gmaxwell> (My (maybe bitrotted) understanding is that this protocol requires we send and recieve a single udp packet with a fixed layout struct. The only moderate complexity comes in via the fact that we need to get the default gateway IP, which needs some OS specific code)
11:08 < sipa> it seems finding the gateway is a significant portion of the code
11:10 -!- Karyon [~Karyon@unaffiliated/karyon] has quit [Ping timeout: 252 seconds]
11:11 < wumpus> well, currently the code is being imported, I think it should stay like that
11:11 < wumpus> sipa: that might well be the most difficult part
11:12 < wumpus> also, testing
11:13 < wumpus> this seems difficult to test without building a whole multi-VM network setup
11:14 < wumpus> though, everything considered, I don't think we test upnp functionality at all at the moment
11:14 < gmaxwell> I'd rather have it without tests than not have it.
11:15 < wumpus> (nor ever did)
11:16 < wumpus> I mean, if people with a router that support it test it that'd be something
11:20 -!- Shivendra [af649512@gateway/web/freenode/ip.175.100.149.18] has quit [Ping timeout: 256 seconds]
11:37 < dongcarl> I'd be happy to test it with a natpmp daemon on my gateway
11:38 -!- shesek [~shesek@185.3.144.77] has joined #bitcoin-core-dev
11:38 -!- shesek [~shesek@185.3.144.77] has quit [Changing host]
11:38 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
11:44 -!- Karyon [~Karyon@unaffiliated/karyon] has joined #bitcoin-core-dev
11:59 -!- jarthur [~jarthur@207.114.244.5] has quit [Remote host closed the connection]
12:00 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
12:27 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
12:28 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
12:34 -!- obsrver [~quassel@p5DC6B545.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
12:39 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Read error: Connection reset by peer]
12:54 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Ping timeout: 256 seconds]
13:01 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev
13:02 -!- jarthur [~jarthur@207.114.244.5] has quit [Remote host closed the connection]
13:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:22 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #15722: doc: Change block chain to blockchain in doc (master...fix-typos) https://github.com/bitcoin/bitcoin/pull/15722
13:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:29 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
13:31 -!- nanotube [~nanotube@unaffiliated/nanotube] has quit [Ping timeout: 260 seconds]
13:42 -!- omonk [~omonk@unaffiliated/omonk] has quit [Read error: Connection reset by peer]
13:43 < gwillen> achow101: review beg for #15508? :-)
13:43 < gribble> https://github.com/bitcoin/bitcoin/issues/15508 | Refactor analyzepsbt for use outside RPC code by gwillen · Pull Request #15508 · bitcoin/bitcoin · GitHub
13:43 < gwillen> (or does anybody else want to take a final look?)
13:45 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds]
13:45 -!- qrestlove [~qrestlove@2601:446:c201:f560:3013:7f1f:89c1:c7e1] has quit [Ping timeout: 250 seconds]
13:46 -!- omonk [~omonk@unaffiliated/omonk] has joined #bitcoin-core-dev
13:46 -!- somethinglittle [~nothingmu@68.183.99.173] has joined #bitcoin-core-dev
13:57 -!- qrestlove [~qrestlove@2601:446:c201:f560:fddd:c263:c47a:bd49] has joined #bitcoin-core-dev
14:19 < conman> I'm trying to find the code that prioritises block inclusion according to GetModifiedFee() in CreateNewBlock() and I can't see it. I've tried using prioritisetransaction and confirmed it's getting a fee increase way above any other transactions but not included in getblocktemplate
14:20 < conman> has this functionality been confirmed working in recent releases?
14:20 < conman> I've not tried it in a couple of years
14:20 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has quit [Ping timeout: 256 seconds]
14:26 -!- sipa [~pw@gateway/tor-sasl/sipa1024] has joined #bitcoin-core-dev
14:30 < gmaxwell> conman: there are tests for it, it appears to be working to me.
14:32 < gmaxwell> conman: its tested by mining_prioritisetransaction, mempool_persist, and mempool_packages
14:32 < gmaxwell> conman: is the transaction not being included for some other reason? (invalid, non-standard, too large?)
14:35 < conman> it's definitely in the mempool, I've tried editing the code to make sure it's included by manually setting bypass_limits in sendrawtransaction and that makes no difference, and it's a small regular sized tx
14:35 < conman> I'm baffled as to why it won't show up in a getblocktemplate though
14:36 < gmaxwell> conman: lol
14:36 < conman> :\
14:36 < conman> yulol
14:36 < gmaxwell> conman: is your problem that it uses segwit (or has unconfirmed parents that do) and you're not calling GBT with the segwit flag?
14:36 < conman> nah
14:36 < gmaxwell> darn
14:36 < conman> definitely using segwit
14:37 < gmaxwell> Are its parents confirmed?
14:37 < conman> yeah
14:37 < gmaxwell> What code are you running?
14:38 < conman> 0.17.1 vanilla
14:38 < conman> (without the hack above I tried)
14:40 < gmaxwell> You're using the fee_delta argument to prioritisetransaction? not the second argument which is now a dummy?
14:40 < conman> it won't let you set anything but 0 there anyway
14:40 < conman> it rejects any other value
14:41 < gmaxwell> zero or 'null' but yeah, okay. hm.
14:41 < conman> 2019-04-02T21:37:56Z PrioritiseTransaction: $txid feerate += 0.10
14:41 < conman> is in the debug log
14:42 < gmaxwell> I dunno what to say, I can see it reordering transactions for me. and the test looks reasonable (it's actually testing that it gets txn into the block that otherwise wouldn't)
14:42  * conman scratches head
14:42 < gmaxwell> sdaftuar: ^ any thoughts?
14:43 < gmaxwell> conman: does getmempoolentry  look sensible?
14:44 < conman> sec
14:44 -!- aitorjs [~aitorjs@2a02:2e02:29f6:ff00:b813:faa2:18d7:e51d] has joined #bitcoin-core-dev
14:45 < conman> yes
14:45 < conman> shows modifiedfee too
14:45  * gmaxwell puts on his good tech support hat
14:45 < gmaxwell> conman: are you querying the right node?
14:45 -!- aitorjs [~aitorjs@2a02:2e02:29f6:ff00:b813:faa2:18d7:e51d] has quit [Client Quit]
14:46 < gmaxwell> can you look at your template, grabe a txid from somewhere in the middle, and see that it looks worse in getmempoolentry?
14:46 < conman> heh
14:46 -!- zaka [~zaka@2a02:2e02:29f6:ff00:b813:faa2:18d7:e51d] has joined #bitcoin-core-dev
14:47 < gmaxwell> (sorry to ask a dumb question, but too often I've seen those solve problems. :) )
14:47 < conman> I assume you mean modified is lower, yes
14:47 < conman> even the top entry in the block template has a lower modified fee than this
14:48 < conman> should the wtxid be different to the txid in the mempoolentry ?
14:50 < gmaxwell> for non-segwit txn wtxid and txid are the same, for non-sw they're different.
14:50 < gmaxwell> er for sw they're different 
14:51 < gmaxwell> sorry, distratcted. :)
14:51 < conman> roger
14:51 < conman> well it's a segwit txn
14:51 < conman> that's the only thing that's different from when I did this 2 years ago
14:52 < conman> they were regular txns
14:52 < conman> can't imagine that's the reason but that's the only thing I've changed
14:52  * gmaxwell looks to see if the test use segwit txn, maybe its broken for those!
14:54 < conman> [08:32] <gmaxwell> conman: its tested by mining_prioritisetransaction, mempool_persist, and mempool_packages
14:54 < conman> I don't see a mining_prioritisetransaction anywhere
14:54 < conman> what function are you actually referring to?
14:55 < gmaxwell> the tests are in bitcoin/test/functional/mining_prioritisetransaction.py
14:56 < conman> oh I was looking in src/
14:56 < gmaxwell> you can run it by running ./test_runner.py mining_prioritisetransaction.py   it runs fine on a system already running a node.
14:57 < gmaxwell> looks to me like the test will use segwit (it'll use whatever address type the node returns by default)
14:57 < gmaxwell> But I could be misreading the test.
14:57 < conman> I see a fixed txid in the code
14:59 < gmaxwell> thats just testing an invalid value
14:59  * conman scratches head
15:00 < conman> I'll build and try the test
15:00 < gmaxwell> thanks.
15:04 < conman> says it passes, but I can't actually give it a transaction of my choice to see if that's okay
15:05 -!- zaka [~zaka@2a02:2e02:29f6:ff00:b813:faa2:18d7:e51d] has quit [Ping timeout: 259 seconds]
15:05 < conman> anyway got to run damnit, bbl to do some more debugging... really can't see why it won't show up in the template
15:05 < conman> thanks so far
15:05 < gmaxwell> are you perhaps confusing wtxid and txid in the template or something and it's there?  (sorry last ditch guess)
15:08 < conman> :O
15:08  * conman looks
15:09 < conman> nope, not there by either txid or wtxid
15:11 -!- makey40 [~jodie@24.215.123.241] has quit [Ping timeout: 246 seconds]
15:12 -!- makey40 [~jodie@24.215.123.241] has joined #bitcoin-core-dev
15:14 -!- zaka [~zaka@2a02:2e02:29f6:ff00:b813:faa2:18d7:e51d] has joined #bitcoin-core-dev
15:15 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has quit [Ping timeout: 244 seconds]
15:29 < gwillen> achow101: also, can you advise me on the intended way of using https://github.com/bitcoin/bitcoin/pull/14075
15:29 < gwillen> (watch-only-keypool)
15:31 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
15:35 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
15:40 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
15:41 -!- nanotube [~nanotube@unaffiliated/nanotube] has joined #bitcoin-core-dev
15:42 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 255 seconds]
15:55 < achow101> gwillen: make a wallet without private keys. import something using importmulti and set 'keypool': true
15:57 < gwillen> achow101: so I've been fiddling with it
15:58 < gwillen> it seems like the magic I was initially missing was that "internal": true is mandatory with "keypool": true, or it has no effect
15:58 < gwillen> which makes sense in retrospect
15:59 < gwillen> also, the address has to be unused
15:59 < gwillen> or it will go into the keypool but not be considered for use as a change address
16:02 -!- zaka [~zaka@2a02:2e02:29f6:ff00:b813:faa2:18d7:e51d] has quit [Ping timeout: 258 seconds]
16:07 -!- dqx [~dqx@unaffiliated/dqx] has quit [Ping timeout: 245 seconds]
16:10 -!- zaka [~zaka@2a02:2e02:29f6:ff00:b813:faa2:18d7:e51d] has joined #bitcoin-core-dev
16:13 -!- dqx [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev
16:17 -!- zaka [~zaka@2a02:2e02:29f6:ff00:b813:faa2:18d7:e51d] has quit [Ping timeout: 258 seconds]
16:26 < achow101> internal: true only makes it a change address
16:26 < achow101> it isn't mandatory
16:30 < conman> darn it confirmed, now I can't try it again
16:30 < gwillen> ... you know I was so focused on change addresses I actually forgot that they keypool is used for other stuff
16:30 < gwillen> like, receiving addresses
16:35 < gmaxwell> conman: try some other txn
16:36 < conman> yeah when I get a chance later
16:36 < conman> oh you mean someone else's transaction
16:36 < conman> but yeah when I have time
16:39 < conman> I do think there's something actually wrong
16:45 < gmaxwell> I'd believe it, the interface isn't used much anymore AFAIK, and so maybe there is some issue that the test happens to not trigger or maybe in some particular config.
16:47 < conman> nod
16:47 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
17:20 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit []
17:37 < gwillen> hmmm, can someone tell me why CoinControlDialog uses a static CoinControl object, instead of like, having the caller supply one
17:37 < gwillen> I expect the answer is "because it was easier"
18:06 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit []
18:08 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!]
18:09 -!- echonaut1 [~echonaut@46.101.192.134] has joined #bitcoin-core-dev
18:12 -!- achow101_ [~achow101@unaffiliated/achow101] has joined #bitcoin-core-dev
18:12 -!- echonaut [~echonaut@46.101.192.134] has quit [Remote host closed the connection]
18:12 -!- BGL [ninety@75-149-171-58-Washington.hfc.comcastbusiness.net] has quit [Read error: Connection reset by peer]
18:12 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has quit [Read error: Connection reset by peer]
18:12 -!- achow101 [~achow101@unaffiliated/achow101] has quit [Remote host closed the connection]
18:12 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 245 seconds]
18:13 -!- Evel-Knievel [~Evel-Knie@d5152f744.static.telenet.be] has joined #bitcoin-core-dev
18:13 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
18:14 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev
18:15 -!- phantomcircuit [~phantomci@192.241.205.97] has quit [Ping timeout: 246 seconds]
18:16 < fanquake> I assume this was accidental, rather than spam (as it was reverted right after). Just need to keep an eye on the wiki.. https://github.com/bitcoin-core/bitcoin-devwiki/wiki/0.18.0-Release-Notes-Draft/_compare/af6d617%5E...af6d617
18:17 -!- phantomcircuit [~phantomci@192.241.205.97] has joined #bitcoin-core-dev
18:22 -!- Krellan [~Krellan@50-242-94-241-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection]
18:49 < conman> gmaxwell: did some more testing
18:50 < conman> I picked a random transaction from the mempool
18:50 < conman> if it's a regular transaction I can prioritise it
18:50 < conman> if it's a segwit one I canNOT get it into the template
18:50 < conman> I picked a random txn (not mine) with the txid f8ac1bf739aace5c10fbde87d387e47a2536e897a738a65e1f153fe02ddabf01
18:50 < conman> see if you can prioritise it
18:51 < conman> its fee is 2590s
18:57 -!- nanotube [~nanotube@unaffiliated/nanotube] has quit [Read error: Connection reset by peer]
18:59 -!- achow101_ is now known as achow101
19:01 -!- nanotube [~nanotube@unaffiliated/nanotube] has joined #bitcoin-core-dev
19:02 -!- achow101 is now known as achow101_
19:02 -!- achow101_ is now known as achow101
19:09 -!- BGL [thirty@75-149-171-58-Washington.hfc.comcastbusiness.net] has joined #bitcoin-core-dev
19:53 < conman> yep I cannot successfully prioritise any segwit transactions into the block template
20:49 -!- tynes [~tynes@30.50.237.35.bc.googleusercontent.com] has joined #bitcoin-core-dev
21:03 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has quit [Remote host closed the connection]
21:04 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has joined #bitcoin-core-dev
21:46 < gmaxwell> conman: can you take a segwit txn that is already in the template and prioritize it so it goes from near the bottom to near the top?
21:46 -!- arubi [~ese168@gateway/tor-sasl/ese168] has quit [Remote host closed the connection]
21:46 -!- arubi [~ese168@gateway/tor-sasl/ese168] has joined #bitcoin-core-dev
22:08 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev
22:10 -!- Krellan_ [~Krellan@2601:640:4000:a876:a130:8a0a:4dc1:262f] has joined #bitcoin-core-dev
22:24 < conman> ok lemme try
22:29 < conman> of course all the ones low down are NOT segwit txns..
22:35 < conman> man just how few segwit txns are there...
22:39 < gmaxwell> do you have any?
22:39 < gmaxwell> ./bitcoin-cli getblocktemplate '{"rules": ["segwit"]}' | jq '.transactions | .[] | select(.hash != .txid)'
22:39 < gmaxwell> I see 1090 in my template...
22:39 < conman> thanks that's what I needed to help
22:40 < gmaxwell> so about 40% of them.
22:40 < conman> yeah I was just randomly picking them off the bottom and looking at them
22:40 < conman> silly me
22:40 < conman> since I know nought of this
22:41 < conman> ok I prioritised the lowest priority one I could find
22:41 < gmaxwell> FWIW, it worked for me (with 0.18rc) -- I picked the bottom segwit txn, prioritised it, and it's now the second transaction in my template.
22:42 < conman> and now it no longer appears in the block template at all
22:42 < conman> let's try again
22:42 < gmaxwell> OH how high is your priority? is it possible that there is an overflow somwhere?
22:42 < gmaxwell> I did: $ ./bitcoin-cli prioritisetransaction 35611cbad11967731aa122136bf90bd63c5224296c45c10a26885c3bb3fff6f6 0 100000
22:42 < gmaxwell> true
22:42 < conman> 0.1btc
22:42 < conman> so 10000000
22:43 < conman> again, same thing happened this time around
22:43 < conman> I'll try smaller then
22:43 < conman> but note that size priority worked fine on a regular transaction
22:43 < gmaxwell> I tried 10000000 ... now its the first one.
22:43 < conman> then wtf is going on here
22:44 < gmaxwell> bug in 0.17 that is fixed in 0.18? I just don't recall any such changes.
22:44 < conman> every prioritised one disappears instead of moving up
22:45 < conman> hang on, maybe I'm searching for it wrong in the template
22:47 < gmaxwell> I'm just ./bitcoin-cli getblocktemplate '{"rules": ["segwit"]}' | jq '.transactions | .[] | select(.hash != .txid)' |less  and hitting / and pasting in the txid.
22:47 < gmaxwell> and I successfully move something to the top, then undo the priority and it goes back down to near the bottom.
22:47 < conman> I'm not adding rules to getblocktemplate...
22:47 < conman> is that what I'm doing wrong?
22:48 < conman> doesn't explain how it's been generating templates with segwit txns all the time
22:48 < conman> I was just doing getblocktemplate | grep
22:49 < conman> or | less and then / searching
22:49 < gmaxwell> oh man..
22:49 < conman> :(
22:49  * conman hides
22:49 < gmaxwell> So I did ask...
22:49 < gmaxwell> in 0.18 this isn't a problem:
22:49 < gmaxwell> $ ./bitcoin-cli getblocktemplate
22:49 < gmaxwell> error code: -8
22:49 < gmaxwell> error message:
22:49 < gmaxwell> getblocktemplate must be called with the segwit rule set (call with {"rules": ["segwit"]})
22:49 < conman> I see
22:50 < gmaxwell> but for backwards compat reasons gbt won't include any segwit txn unless called with rules (and in 0.18 that functionality is disabled)
22:50 < conman> I'm just going to rock back and forth in the corner
22:50 < gmaxwell> I would have asked harder but I didn't remember when the backwards compat was turned off,  I kinda assumed 0.17 had it too, so I didn't ask more than once. Sorry.
22:51 < conman> don't be sorry, it's all my fault
22:51 < gmaxwell> this was a known footgun thus the new behavior in 0.18.
22:51 < conman> for some reason I thought the rules were on by default
22:51 < gmaxwell> yea, they aren't just because if you had non-segwit capable mining software you'd start silently mining invalid blocks.
22:51 < gmaxwell> And we'd rather it fail cleanly.
22:53 < conman> ok well that's been a big learning experience
22:53 < conman> for all the wrong reasons
22:53 < gmaxwell> thanks for the confirmation that 0.18's behavior change is a useful de-footgunning. :P
22:55 < conman> of course the pool software doesn't do that so no idea why I didn't think of it for the command line :s
22:55 < conman> I really have to get out of this game, it's bad for my health
22:56 -!- nanotube [~nanotube@unaffiliated/nanotube] has quit [Read error: Connection reset by peer]
22:57 < conman> thanks again
22:57 < gmaxwell> sorry, this interface was bad-- just an annoying consequence of backwards compatiblity. That much isn't your fault. :)
22:57 < gmaxwell> I'm glad it wasn't a weird bug though.
23:01 -!- nanotube [~nanotube@unaffiliated/nanotube] has joined #bitcoin-core-dev
23:12 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
23:24 -!- rex4539 [~rex4539@ppp-2-84-169-44.home.otenet.gr] has quit [Read error: Connection reset by peer]
23:25 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
23:25  * conman quietly disappears
23:25 -!- conman [~con@2001:44b8:4154:d801:cd93:fa7d:88ff:158c] has left #bitcoin-core-dev ["Konversation terminated!"]
23:27 < gmaxwell> Next Customer!
23:27  * gmaxwell is sad that he has still not learned the zen of tech support.
23:27 < gwillen> gmaxwell: can you help me with this terrible pain I have in all the diodes down my left side
23:28 < gmaxwell> gwillen: have you had them replaced?
23:30 < gmaxwell> When I worked for Juniper I was often amazed at how the really good tech support people managed to solve some feindishly hard problems that no one else could solve by being single mindedly consistent about asking all the dumb questions and carefully validating every claim and piece of information.
23:31 < gmaxwell> And yet, no matter how much I tell myself that I _must_ ask the 'dumb' questions to get compariable results, I still manage to fail.
23:36 -!- windsok [~windsok@unaffiliated/windsok] has quit [Remote host closed the connection]
23:45 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
23:47 -!- Soligor [~soligor@unaffiliated/soligor] has joined #bitcoin-core-dev
23:47 -!- rex4539 [~rex4539@ppp-2-84-169-44.home.otenet.gr] has joined #bitcoin-core-dev
23:48 < wumpus> gwillen: yes the global coin control object is kind of ugly, and very much different from how the rest of the GUI code works; basically because the original author wrote it like that, and people kind of wanted the functionality so didn't want to hold up the merge for it, it was expected that someone would improve it down the line
23:49 < wumpus> gwillen: I'm somewhat surprised it doesn't give trouble with multiple wallets
23:54 -!- windsok [~windsok@unaffiliated/windsok] has joined #bitcoin-core-dev
--- Log closed Wed Apr 03 00:00:34 2019