--- Log opened Fri Apr 12 00:00:42 2019
00:06 -!- gertjaap [sid322815@gateway/web/irccloud.com/x-nobbxpbcudzurmgz] has quit [Read error: Connection reset by peer]
00:06 -!- nsh [~lol@wikipedia/nsh] has quit [Ping timeout: 264 seconds]
00:06 -!- bosma [sid103570@gateway/web/irccloud.com/x-qtxdmslhsxkwbdph] has quit [Read error: Connection reset by peer]
00:06 -!- Liliaceae [sid282374@gateway/web/irccloud.com/x-rfkyybequrjpxvmp] has quit [Read error: Connection reset by peer]
00:06 -!- gertjaap [sid322815@gateway/web/irccloud.com/x-tcwpdxvhnjdmbcwh] has joined #bitcoin-core-dev
00:06 -!- Liliaceae [sid282374@gateway/web/irccloud.com/x-peaxvjrmudhhudaw] has joined #bitcoin-core-dev
00:06 -!- bosma [sid103570@gateway/web/irccloud.com/x-ypzdqjevnigvueng] has joined #bitcoin-core-dev
00:07 -!- Taek [~quassel@2001:41d0:1:472e::] has quit [Quit: No Ping reply in 180 seconds.]
00:07 -!- Taek [~quassel@2001:41d0:1:472e::] has joined #bitcoin-core-dev
00:24 -!- nsh [~lol@wikipedia/nsh] has joined #bitcoin-core-dev
01:00 -!- berndj [~berndj@azna.co.za] has quit [Read error: Connection reset by peer]
01:00 -!- berndj [~berndj@azna.co.za] has joined #bitcoin-core-dev
01:01 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev
01:06 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Ping timeout: 264 seconds]
01:10 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Remote host closed the connection]
01:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:23 < bitcoin-git> [bitcoin] practicalswift opened pull request #15805: log: Increase signal-to-noise in bitcoind standard output. Don't print debug output "Pre-allocating to position ..." and "Leaving block file ..." when running with -nodebug (default). (master...stdout-signal-to-noise) https://github.com/bitcoin/bitcoin/pull/15805
01:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:46 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
01:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:52 < bitcoin-git> [bitcoin] practicalswift opened pull request #15806: contrib: Remove SUSPICIOUS_HOSTS from makeseeds.py (master...remove-SUSPICIOUS_HOSTS) https://github.com/bitcoin/bitcoin/pull/15806
01:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:55 < gmaxwell> uh
01:58 -!- mnl [4fee7a3e@gateway/web/freenode/ip.79.238.122.62] has joined #bitcoin-core-dev
01:59 -!- promag [~promag@195.54.168.134] has joined #bitcoin-core-dev
02:02 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev
02:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
02:21 < bitcoin-git> [bitcoin] practicalswift closed pull request #15806: contrib: Remove SUSPICIOUS_HOSTS from makeseeds.py (master...remove-SUSPICIOUS_HOSTS) https://github.com/bitcoin/bitcoin/pull/15806
02:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
02:24 -!- rex4539 [~rex4539@athedsl-171280.home.otenet.gr] has quit [Quit: rex4539]
02:32 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev
02:44 -!- chriswang2019 [~Mutter@61.144.119.144] has joined #bitcoin-core-dev
02:49 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has joined #bitcoin-core-dev
02:53 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has quit [Ping timeout: 250 seconds]
03:05 -!- chriswang2019 [~Mutter@61.144.119.144] has quit [Quit: Mutter: www.mutterirc.com]
03:07 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
03:07 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 256 seconds]
03:11 -!- promag [~promag@195.54.168.134] has quit [Remote host closed the connection]
03:11 -!- ghost43_ [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 256 seconds]
03:12 -!- promag [~promag@195.54.168.134] has joined #bitcoin-core-dev
03:13 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
03:16 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev
03:17 < fanquake> Am looking forward to playing around with --enable-experimental-rust
03:21 -!- promag [~promag@195.54.168.134] has quit [Remote host closed the connection]
03:23 -!- jonatack [6d0d4c36@gateway/web/freenode/ip.109.13.76.54] has joined #bitcoin-core-dev
03:25 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 256 seconds]
03:31 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
03:33 -!- rex4539 [~rex4539@2a02:587:3511:5a00:cce:8627:9e76:2048] has joined #bitcoin-core-dev
03:48 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
03:58 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
04:03 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev
04:30 -!- laptop500 [~laptop@62.232.170.180] has joined #bitcoin-core-dev
04:54 -!- shesek [~shesek@5.22.134.182] has joined #bitcoin-core-dev
04:54 -!- shesek [~shesek@5.22.134.182] has quit [Changing host]
04:54 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
05:01 -!- jonatack [6d0d4c36@gateway/web/freenode/ip.109.13.76.54] has quit [Ping timeout: 256 seconds]
05:19 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has quit [Read error: Connection reset by peer]
05:20 -!- cryptapus [~cryptapus@jupiter.osmus.org] has joined #bitcoin-core-dev
05:20 -!- cryptapus [~cryptapus@jupiter.osmus.org] has quit [Changing host]
05:20 -!- cryptapus [~cryptapus@unaffiliated/cryptapus] has joined #bitcoin-core-dev
05:58 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
06:01 -!- qrestlove [~qrestlove@2601:446:c201:f560:9dc2:35e3:4b30:e398] has quit [Ping timeout: 252 seconds]
06:06 -!- bsm117532 [~bsm117532@unaffiliated/bsm117532] has joined #bitcoin-core-dev
06:07 < bsm117532> BlueMatt: ported your BetterHash mining server code to 0.18: https://github.com/mcelrath/bitcoin/tree/betterhash_bob
06:07 < bsm117532> Anyone using this?
06:08 < bsm117532> Will be pointing miners at it in the next few days.
06:25 -!- lio17 [~lio17@80.ip-145-239-89.eu] has quit [Quit: Ping timeout (120 seconds)]
06:26 -!- lio17 [~lio17@80.ip-145-239-89.eu] has joined #bitcoin-core-dev
06:26 -!- _Sam-- [~greybits@unaffiliated/greybits] has quit [Quit: ()]
06:40 -!- mnl [4fee7a3e@gateway/web/freenode/ip.79.238.122.62] has quit [Ping timeout: 256 seconds]
06:41 -!- chriswang2019 [~Mutter@2409:8955:688:3c31:941b:bd09:74c8:890a] has joined #bitcoin-core-dev
06:46 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
06:49 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds]
06:49 -!- chriswang2019 [~Mutter@2409:8955:688:3c31:941b:bd09:74c8:890a] has quit [Ping timeout: 264 seconds]
06:56 -!- rex4539 [~rex4539@2a02:587:3511:5a00:cce:8627:9e76:2048] has quit [Quit: rex4539]
07:00 -!- rex4539 [~rex4539@2a02:587:3511:5a00:4c99:e346:3305:71e6] has joined #bitcoin-core-dev
07:02 -!- Technoquake [ac53aeb0@gateway/web/cgi-irc/kiwiirc.com/ip.172.83.174.176] has joined #bitcoin-core-dev
07:02 -!- rex4539 [~rex4539@2a02:587:3511:5a00:4c99:e346:3305:71e6] has quit [Client Quit]
07:03 -!- rex4539 [~rex4539@2a02:587:3511:5a00:cce:8627:9e76:2048] has joined #bitcoin-core-dev
07:09 -!- laptop500 [~laptop@62.232.170.180] has quit [Quit: Leaving]
07:15 -!- ranefer [~ranefer@2601:281:c000:b92:b571:abdf:a9ba:36c9] has joined #bitcoin-core-dev
07:27 < BlueMatt> bsm117532: nice! I'll follow up over the weekend
07:29 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
07:47 -!- ranefer [~ranefer@2601:281:c000:b92:b571:abdf:a9ba:36c9] has quit [Quit: Leaving]
07:47 -!- ranefer [~ranefer@2601:281:c000:b92:b571:abdf:a9ba:36c9] has joined #bitcoin-core-dev
07:51 -!- ranefer [~ranefer@2601:281:c000:b92:b571:abdf:a9ba:36c9] has left #bitcoin-core-dev []
08:03 -!- asoltys_ [~adam@115.96.198.104.bc.googleusercontent.com] has left #bitcoin-core-dev []
08:34 -!- pinheadmz [~matthewzi@c-67-170-233-212.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
08:40 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/]
08:44 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev
08:47 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has joined #bitcoin-core-dev
09:28 -!- millerti [~millerti@cpe-66-24-91-119.stny.res.rr.com] has joined #bitcoin-core-dev
09:32 -!- ppisati [~ppisati@net-5-95-166-237.cust.vodafonedsl.it] has quit [Quit: leaving]
09:40 -!- ppisati [~ppisati@net-37-182-11-27.cust.vodafonedsl.it] has joined #bitcoin-core-dev
09:45 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
09:51 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has quit [Ping timeout: 252 seconds]
09:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:51 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0e9cb2d24dbf...66ce95a43400
09:51 < bitcoin-git> bitcoin/master fa2dfbf MarcoFalke: travis: Bump second timeout to 33 minutes, Add rationale
09:51 < bitcoin-git> bitcoin/master 66ce95a MarcoFalke: Merge #15797: travis: Bump second timeout to 33 minutes, Add rationale
09:51 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
09:52 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15797: travis: Bump second timeout to 33 minutes, Add rationale (master...1904-travisTime) https://github.com/bitcoin/bitcoin/pull/15797
09:52 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
09:54 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
10:01 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 264 seconds]
10:01 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has joined #bitcoin-core-dev
10:04 -!- captjakk_ [~captjakk@63-238-229-186.dia.static.qwest.net] has joined #bitcoin-core-dev
10:05 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
10:08 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has quit [Ping timeout: 268 seconds]
10:09 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 256 seconds]
10:12 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
10:18 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev
10:26 < instagibbs> MarcoFalke, re #15797 is this the "no output seen" timeout?
10:26 < gribble> https://github.com/bitcoin/bitcoin/issues/15797 | travis: Bump second timeout to 33 minutes, Add rationale by MarcoFalke · Pull Request #15797 · bitcoin/bitcoin · GitHub
10:26 < MarcoFalke> nah, the 50 min timeout
10:27 -!- captjakk_ [~captjakk@63-238-229-186.dia.static.qwest.net] has quit [Remote host closed the connection]
10:27 < MarcoFalke> All tests are busy printing at least every 10 minutes, so the "no output seen" should never be hit
10:29 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has joined #bitcoin-core-dev
10:29 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has quit [Remote host closed the connection]
10:29 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has joined #bitcoin-core-dev
10:31 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev
10:31 -!- Technoquake [ac53aeb0@gateway/web/cgi-irc/kiwiirc.com/ip.172.83.174.176] has quit [Remote host closed the connection]
10:32 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection]
10:32 -!- niska [~niska@68.ip-149-56-14.net] has quit [Quit: Leaving]
10:34 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has quit [Ping timeout: 264 seconds]
10:37 -!- niska [~niska@68.ip-149-56-14.net] has joined #bitcoin-core-dev
10:41 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 252 seconds]
10:41 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Remote host closed the connection]
10:47 < jnewbery> I think there's a wallet meeting in just over an hour today. If so, I have one #proposedmeetingtopic : Upgrade wallet (#15761). There's already been some discussion in the PR
10:47 < gribble> https://github.com/bitcoin/bitcoin/issues/15761 | Replace -upgradewallet startup option with upgradewallet RPC by achow101 · Pull Request #15761 · bitcoin/bitcoin · GitHub
10:51 -!- pinheadmz [~matthewzi@c-67-170-233-212.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
10:52 -!- pinheadmz [~matthewzi@c-67-170-233-212.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
10:54 -!- schmidty_ [~schmidty@104-7-216-111.lightspeed.austtx.sbcglobal.net] has quit []
10:54 -!- schmidty [~schmidty@unaffiliated/schmidty] has joined #bitcoin-core-dev
10:59 -!- jonatack [d598a1a5@gateway/web/freenode/ip.213.152.161.165] has joined #bitcoin-core-dev
10:59 -!- chriswang2019 [~Mutter@117.136.32.57] has joined #bitcoin-core-dev
11:19 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has joined #bitcoin-core-dev
11:20 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has quit [Remote host closed the connection]
11:20 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has joined #bitcoin-core-dev
11:26 -!- chriswang2019 [~Mutter@117.136.32.57] has quit [Remote host closed the connection]
11:29 -!- chriswang2019 [~Mutter@2409:8955:688:3c31:941b:bd09:74c8:890a] has joined #bitcoin-core-dev
11:44 -!- millerti [~millerti@cpe-66-24-91-119.stny.res.rr.com] has quit [Read error: Connection reset by peer]
11:46 -!- chriswang2019 [~Mutter@2409:8955:688:3c31:941b:bd09:74c8:890a] has quit [Read error: Connection reset by peer]
11:50 < achow101> #proposedmeetingtopic native descriptor wallets (#15761)
11:50 < gribble> https://github.com/bitcoin/bitcoin/issues/15761 | Replace -upgradewallet startup option with upgradewallet RPC by achow101 · Pull Request #15761 · bitcoin/bitcoin · GitHub
11:50 < achow101> ehh, #15764
11:50 < gribble> https://github.com/bitcoin/bitcoin/issues/15764 | Native descriptor wallets by achow101 · Pull Request #15764 · bitcoin/bitcoin · GitHub
12:00 < meshcollider> #startmeeting
12:00 < lightningbot> Meeting started Fri Apr 12 19:00:04 2019 UTC.  The chair is meshcollider. Information about MeetBot at http://wiki.debian.org/MeetBot.
12:00 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
12:00 < meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb
12:00 < jnewbery> hi
12:01 < achow101> hi
12:01 < meshcollider> #topic : Upgrade wallet (#15761) (jnewbery)
12:01 < gribble> https://github.com/bitcoin/bitcoin/issues/15761 | Replace -upgradewallet startup option with upgradewallet RPC by achow101 · Pull Request #15761 · bitcoin/bitcoin · GitHub
12:02 < kanzure> hi
12:02 < jnewbery> This PR is to replace the -upgradewallet startup option, which is great news
12:03 < jnewbery> achow is proposing to replace it with an RPC. There were a couple of other suggestions on what to replace it with in the PR and I wanted to poll for opinions
12:03 < achow101> I think the primary question is RPC, wallet-tool command, or both
12:03 < achow101> I prefer both
12:03 < jnewbery> I'm slightly concerned about having an RPC that can upgrade at any time. I just feel that it might introduce subtle corner cases if the wallet is doing something else at the time
12:04 < jnewbery> but I might be wrong. Perhaps it's fine
12:04 < achow101> the whole operation is locked, and any operations on the wallet are also locked, so I don't think that's really a problem
12:04 < jnewbery> (I'm definitely a big concept ACK on moving away from startup option)
12:05 < kanzure> does upgradewallet replace the wallet or does it create an upgraded wallet only?
12:05 < achow101> kanzure: it just upgrades the wallet file
12:05 < luke-jr> could be only allowed when loading
12:06 < meshcollider> I'm in favour of both too
12:06 < jnewbery> luke-jr: that's one suggestion in the PR. Another option would be to only allow it on wallets that aren't currently loaded.
12:07 < jnewbery> (ie separate upgrade from running entirely)
12:07 < achow101> jnewbery: what if upgradewallet unloads it, upgrades, then reloads it
12:07 < achow101> that would disconnect all of the signals and stuff that would cause issues
12:07 < kanzure> need lock during upgrade
12:07 < kanzure> so that they don't reopen
12:07 < kanzure> in achow101's flow.
12:08 < jnewbery> Should we encourage users to backup before they upgrade?
12:08 < meshcollider> kanzure: I think thats the current behavior anyway
12:08 < kanzure> meshcollider: ok, i thought the lock only applies to loaded wallets. nevermind.
12:09 < achow101> kanzure: meshcollider: in the idea I just proposed, you would have to lock something to prevent loading the wallet during upgarde
12:09 < luke-jr> jnewbery: at least after
12:09 < harding> Wallet files are generally small.  If you think a backup is important, it's probably better to just make one automatically and stuff it somewhere in ~/.bitcoin/
12:10 < achow101> jnewbery: probably. the help text for the RPC does say that backups after are required
12:10 < achow101> I can change it to also say before too
12:10 < meshcollider> backup before can be done automatically like harding suggests
12:10 < meshcollider> Make a wallet.old or something
12:10 < harding> (Backup after is a different thing, since that's talking about off-disk backups.)
12:11 < luke-jr> achow101: well, only after is *required*..
12:12 < achow101> right
12:14 < achow101> I think it's possible to make both an upgradewallet RPC and wallet-tool command work safely
12:15 < meshcollider> It doesn't seem like theres any real objection to that
12:16 < meshcollider> jnewbery: anything else to discuss on this topic?
12:17 < jnewbery> nothing from me
12:17 < meshcollider> #topic native descriptor wallets (achow101)
12:18 < achow101> So i finished up an implementation of native descriptor wallets last weekend: #15764
12:18 < gribble> https://github.com/bitcoin/bitcoin/issues/15764 | Native descriptor wallets by achow101 · Pull Request #15764 · bitcoin/bitcoin · GitHub
12:18 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
12:18 < achow101> the only question I really have is what to do with the tests for the old wallet stuff
12:18 < jnewbery> I think it's pretty important to keep those tests
12:18 < achow101> currently I have a bunch of tests removed or changed because they don't work with descriptor wallets
12:19 < jnewbery> Most users will still be using non-descriptor wallets for some time. We can't just stop testing those and hope there are no regressions
12:19 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
12:19 < ryanofsky> you can add descriptors as an optional feature, there's no need to remove old code or old tests
12:22 < achow101> ryanofsky: that's an option, but I feel like descriptors and its new definitions is such a departure from current wallet stuff that it should have better distinction than just a wallet flag
12:23 < ryanofsky> you are referring to the practical downside of having to keep more code around?
12:23 < achow101> e.g. it's possible for someone to write code which accidentally unsets the wallet flag. it's much harder to accidentally downgrade the version
12:24 < meshcollider> Does your PR remove the ability to generate new "old" wallets
12:24 < achow101> meshcollider: yes
12:24 < achow101> (it's a wallet version bump)
12:26 < sipa>  achow101: i think, even for just testing purposes, we'll need to retain the ability to create old wallets
12:26 < jnewbery> The main downside of it being a flag rather than a version is that it becomes combinatorially more difficult to test everything
12:26 < sipa> as this is a very invasive change, and i don't think we want to lose the ability to test old logic
12:26 < jnewbery> I think that the default should be that newly created wallets are old-style, and users need to explicitly upgrade
12:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:26 < bitcoin-git> [bitcoin] jamesob opened pull request #15809: gitignore: plist and dat (master...2019-04-gitignore) https://github.com/bitcoin/bitcoin/pull/15809
12:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:27 < achow101> jnewbery: how come?
12:27 < achow101> I think an explicit upgrade is actually far more dangerous than creating a new descriptor wallet
12:27 < jnewbery> because like you say, it's a big departure from the current wallet design
12:28 < jnewbery> we need to support both for some time to come, so why not take the conservative approach for now
12:28 < meshcollider> I think thats sensible for now, old wallet generation can be "deprecated" later on
12:29 < ryanofsky> yeah, i just think you don't need to add descriptors as this big one time change
12:29 < jnewbery> > I think an explicit upgrade is actually far more dangerous...
12:29 < ryanofsky> you can add new functionality alongside existing functionality, you will get better review better testing
12:30 < jnewbery> We definitely shouldn't be releasing wallet code that we think is *in any way* dangerous
12:30 -!- tripleslash [~triplesla@unaffiliated/imsaguy] has quit [Remote host closed the connection]
12:30 < achow101> ok
12:30 -!- provoostenator [~vwDZ2BYsc@2a05:d014:5f:e100:fd30:8af7:2d6a:cbb1] has left #bitcoin-core-dev []
12:30 -!- provoostenator [~vwDZ2BYsc@2a05:d014:5f:e100:fd30:8af7:2d6a:cbb1] has joined #bitcoin-core-dev
12:31 < achow101> jnewbery: the upgrade stuff I think will be inherently dangerous. shoehorning the old ismine logic into the new ismine logic is not trivial and they are incompatible in many different ways
12:31 < ryanofsky> achow101, you don't even need to add upgrade in the initial pr
12:32 < ryanofsky> we can add support for just creating new descriptor wallets, or just importing descriptors first
12:32 < jnewbery> i don't agree that it's inherently dangerous. We just need to do lots of testing until we're satisfied that it's no longer dangerous
12:32 < meshcollider> provoostenator is having IRC issues and can't send messages here atm but would like to point out he also has a slightly different (and perhaps less complete) PR open: https://github.com/bitcoin/bitcoin/pull/15487
12:32 < jnewbery> and roll it out slowly, with warnings to backup, etc
12:32 < achow101> ryanofsky: right
12:33 < jnewbery> Everything ryanofsky is suggesting is still possible by using wallet versions and not flags
12:33 < achow101> ryanofsky: we shouldn't allow people to create mixed descriptor and non-descriptor wllets though. so no importing descriptors
12:34 < achow101> jnewbery: making it optional is not
12:34 < achow101> that should only be done with flags
12:34 < jnewbery> why not? Add a new parameter to createwallet
12:34 < ryanofsky> yeah, i'm not sure you actually need a version or a flag
12:34 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
12:35 < jnewbery> if descriptorwallet=false create an old-style wallet, if true create a descriptor wallet
12:35 < achow101> the last time we did optional version was hd wallet and that was a headache to reconcile with upgrades in the future. I would rather not go through that excercise again
12:35 < jnewbery> default to false
12:35 < jnewbery> we need to handle upgrades anyway. You already have code to do that
12:36 < provoostenator> hi?
12:36 < harding> provoostenator: hi
12:36 < provoostenator> YES!
12:36 < meshcollider> provoostenator: hi \o/
12:36 < jnewbery> hi sjors!
12:36 < provoostenator> That was weird, I've been talking into a void for a day or so :-)
12:37 < provoostenator> In my version of descriptor wallets it's a feature flag and opt-in. Obviously this sort of thing is easy to tweak.
12:37 < achow101> jnewbery: I think we should maintain the separation of wallet flags for optional, wallet version for mandatory
12:37 < provoostenator> I'll do a more thorough comparison later.
12:37 < jnewbery> wallet version is optional. Upgrading from an old version to new is optional
12:37 < meshcollider> achow101: but why not just allow the wallet to be created with either version number
12:38 < jnewbery> right
12:38 < ryanofsky> jnewbery, i think version numbers are just confusing and should never be used again
12:38 < jnewbery> They are confusing, but they at least cut down on the number of combinations of options
12:38 < ryanofsky> your concern about testing and flag combinations is easily addressed by just refusing to load / support wallets with whatever combinations of flags you want to rule out
12:39 < jnewbery> I think that's effectively the same thing, no?
12:39 < meshcollider> IIRC in lightning, when exchanging feature lists, there are some optional features and some mandatory features based on bit positions
12:39 < ryanofsky> yes, exactly
12:39 < achow101> meshcollider: jnewbery: the problem with optional wallet versions is that any future wallet version becomes optional as well. You can't e.g. skip descriptor wallets and go to the version after that which introduces something completely unrelated to descriptors
12:39 < ryanofsky> anything you want to do with version numbers is possible with flags, but flags are more readable and easier to think about
12:40 < achow101> reconciling the two becomes a pain, as it was for hd wallets
12:40 < jnewbery> achow101 that's always the case with version numbers
12:40 < meshcollider> We dont have to add any new features to old style wallets from now on
12:40 < meshcollider> Force a descriptor upgrade before any other upgrade
12:40 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 246 seconds]
12:40 < ryanofsky> because you don't have to mentally load the whole project history to figure out what conditions are possible, it's just written explicitly in code
12:41 < provoostenator> I'd rather not force upgrades anytime soon. That most likely will lead to endless delays in shipping.
12:41 < jnewbery> even if you don't make the version 'optional', there are still users of old wallets who would have to upgrade through descriptor wallets if they wanted a later version
12:41 < jnewbery> provoostenator: definitely. No forced upgrades
12:42 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev
12:42 < achow101> i agree with ryanofsky 
12:42 < achow101> anyways, this is bikeshedding
12:42 < jnewbery> ?
12:42 < meshcollider> I think this is important for the approach
12:43 < provoostenator> What's more important I think is to decide if we want to support a hybrid with descriptors and regular stuff (I prefer not).
12:43 < achow101> provoostenator: definitely no
12:43 < meshcollider> No, we shouldnt
12:44 < provoostenator> Ok, so that can be supported both with versioning and with feature flags I think. We can revisit that later?
12:45 < provoostenator> Or is there something where this choice does matter more urgently?
12:45 < achow101> meshcollider: jnewbery: consider the case where we introduce descriptor wallets as a new optional version. Sometime later down the road, we introduce a new wallet version because a new field is introduced in the wallet that is inherently not backwards compatible so it needs a version bump to prevent old software from loading, e.g. several more wallet flags
12:45 < meshcollider> I think it just affects how to deal with transitioning tests
12:46 < achow101> in order for users to upgrade to that version with more wallet flags, they first have to upgrade to descriptors, which they may not want to. that new version provides new functionality that does not require descriptors but is still applicable to old wallets. now this needs to be reconciled, and that's rather difficult
12:46 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Ping timeout: 250 seconds]
12:46 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
12:46 < ryanofsky> yeah, i don't see why flags aren't just obviously better in every case. you can still prevent combinations of features, you are just forced to write down which combinations are possible
12:46 < jnewbery> achow101 are you arguing that this should be a flag?
12:47 < meshcollider> Flags alone dont prevent old nodes from trying to open though do they?
12:47 < achow101> jnewbery: yes. if it is going to be an optional feature, it should be a flag
12:47 < ryanofsky> meshcollider, mandatory flags do
12:47 < jnewbery> Of course it's an optional feature. We don't force people to upgrade!
12:48 < meshcollider> Ok yes I agree with making it a mandatory flag rather than version 
12:48 < jnewbery> I'm fine with it being a flag. Like ryanofsky has said, you can do everything with flags that you can with versions (and more)
12:49 < jnewbery> As long as the valid combinations are all documented and enforced in one place
12:49 < provoostenator> A mandatory flag also means we can reduce complexity.
12:49 < provoostenator> Only supporting upgrades for basic cases.
12:49 < achow101> alright, i'll change the pr to use a flag, restore the tests, and drop the upgrading logic for now
12:50 < meshcollider> Just because its a flag doesn't mean we have to allow all possible combinations of flags
12:50 < meshcollider> achow101: +1
12:50 < meshcollider> Anything else for the last 10 minutes?
12:51 < meshcollider> Anything else for backport to 0.18.0rc4 or high priority requests? 
12:51 < jnewbery> Wallet high priority PRs are #15006 #14447 #15741
12:51 < gribble> https://github.com/bitcoin/bitcoin/issues/15006 | Add option to create an encrypted wallet by achow101 · Pull Request #15006 · bitcoin/bitcoin · GitHub
12:51 < gribble> https://github.com/bitcoin/bitcoin/issues/14447 | Armory 0.96.4 causies BitcoinCore 0.17 crash sometimes · Issue #14447 · bitcoin/bitcoin · GitHub
12:51 < gribble> https://github.com/bitcoin/bitcoin/issues/15741 | Batch write imported stuff in importmulti by achow101 · Pull Request #15741 · bitcoin/bitcoin · GitHub
12:51 -!- pinheadmz [~matthewzi@c-67-170-233-212.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
12:52 < jnewbery> sorry #15557
12:52 < gribble> https://github.com/bitcoin/bitcoin/issues/15557 | Enhance `bumpfee` to include inputs when targeting a feerate by instagibbs · Pull Request #15557 · bitcoin/bitcoin · GitHub
12:52 < jnewbery> I think 15557 is almost ready for merge. It's a really nice feature and quite easy to review
12:53 < meshcollider> Maybe kallewoof would like to have that debit/credit caching one on there
12:53 < meshcollider> #15780
12:53 < gribble> https://github.com/bitcoin/bitcoin/issues/15780 | wallet: add cachable accounts for caching credit/debit values by kallewoof · Pull Request #15780 · bitcoin/bitcoin · GitHub
12:53 -!- pinheadmz [~matthewzi@c-67-170-233-212.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
12:54 < jnewbery> I think that can go on. It blocks his other PR
12:54 < jnewbery> (which has been open for 8 months)
12:55 < meshcollider> Yes, and he is very proactive with rebasing, he deserves some acceleration lol
12:55 < jnewbery> #action review more kallewoof PRs!
12:56 < meshcollider> Ok seems thats all for the meeting today then :)
12:56 < meshcollider> #endmeeting
12:56 < lightningbot> Meeting ended Fri Apr 12 19:56:16 2019 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
12:56 < lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-04-12-19.00.html
12:56 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-04-12-19.00.txt
12:56 < lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-04-12-19.00.log.html
12:57 < achow101> when can we switch to a bdb that's shipped by distros?
12:58 < gwillen> I'm a little late to the high priority party, but I'd really like to see #15024 make it in
12:58 < gribble> https://github.com/bitcoin/bitcoin/issues/15024 | Allow specific private keys to be derived from descriptor by meshcollider · Pull Request #15024 · bitcoin/bitcoin · GitHub
12:59 < warren> achow101: drawback of that is everyone's wallet.dat would be a different format, and you wouldn't be able to use the gitian binary
12:59 < gwillen> this is a stopgap for using private-key-bearing descriptors in pre-descriptorwallets, but I expect that it can land MUCH faster than descriptorwallets will
13:00 < gwillen> I expect that it is not eligible for backport, but it would be nice to see it in master
13:02 < jnewbery> I'm fine with adding it. It does make the high priority list a bit wallet-heavy
13:02 < meshcollider> The wallet is the only important thing anyway ;)
13:03 < gwillen> hah :D
13:24 < luke-jr> achow101: probably never?
13:25 < luke-jr> achow101: modern bdb is AGPL; so we'd need to modify our software to serve source code of whatever is running to peers
13:25 < luke-jr> which IMO is stupid
13:25 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev
13:27 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Remote host closed the connection]
13:33 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
13:45 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev
13:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:54 < bitcoin-git> [bitcoin] jnewbery opened pull request #15810: [WIP] Remove nAbsurdFee fee from AcceptToMemoryPool (master...2019-04-remove-absurd-fee) https://github.com/bitcoin/bitcoin/pull/15810
13:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:55 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection]
14:00 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Remote host closed the connection]
14:14 -!- andreacab [acdacc1b@gateway/web/freenode/ip.172.218.204.27] has joined #bitcoin-core-dev
14:15 -!- riperk [uid352992@gateway/web/irccloud.com/x-cdgqofswubmcifyp] has joined #bitcoin-core-dev
14:16 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev
14:18 -!- chriswang2019 [~Mutter@2409:8955:688:3c31:941b:bd09:74c8:890a] has joined #bitcoin-core-dev
14:19 -!- rex4539 [~rex4539@2a02:587:3511:5a00:cce:8627:9e76:2048] has quit [Ping timeout: 252 seconds]
14:21 -!- chriswang2019 [~Mutter@2409:8955:688:3c31:941b:bd09:74c8:890a] has quit [Client Quit]
14:22 < promag> gh down?
14:24 < instagibbs> not for me
14:26 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
14:50 -!- jimmysong [~jimmysong@65-36-83-142.static.grandenetworks.net] has joined #bitcoin-core-dev
14:50 -!- jimmysong_ [~jimmysong@65-36-83-142.static.grandenetworks.net] has joined #bitcoin-core-dev
14:51 -!- jimmysong_ [~jimmysong@65-36-83-142.static.grandenetworks.net] has quit [Client Quit]
14:55 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has quit [Remote host closed the connection]
14:56 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has joined #bitcoin-core-dev
14:57 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds]
14:57 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 256 seconds]
15:01 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
15:05 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has quit [Remote host closed the connection]
15:16 -!- pinheadmz [~matthewzi@c-67-170-233-212.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
15:17 -!- pinheadmz [~matthewzi@c-67-170-233-212.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
15:18 -!- pinheadmz [~matthewzi@c-67-170-233-212.hsd1.ca.comcast.net] has quit [Read error: Connection reset by peer]
15:18 -!- dqx__ [~dqx@unaffiliated/dqx] has quit [Remote host closed the connection]
15:21 -!- pinheadmz [~matthewzi@c-67-170-233-212.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
15:33 -!- dqx_ [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev
15:48 -!- bitbee [~bitbee@unaffiliated/cryptocat] has quit [Quit: Leaving.]
15:50 -!- dqx_ [~dqx@unaffiliated/dqx] has quit [Remote host closed the connection]
15:51 -!- bitbee [~bitbee@unaffiliated/cryptocat] has joined #bitcoin-core-dev
15:52 -!- andreacab [acdacc1b@gateway/web/freenode/ip.172.218.204.27] has quit [Ping timeout: 256 seconds]
15:55 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
15:56 -!- dqx_ [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev
16:00 -!- dqx_ [~dqx@unaffiliated/dqx] has quit [Client Quit]
16:01 -!- promag_ [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev
16:05 -!- promag_ [~promag@bl16-114-47.dsl.telepac.pt] has quit [Ping timeout: 246 seconds]
16:11 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
16:29 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
16:32 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 250 seconds]
16:41 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
17:12 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has quit [Remote host closed the connection]
17:12 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...]
17:13 -!- michagogo [uid14316@wikia/Michagogo] has quit [Ping timeout: 252 seconds]
17:14 -!- Isthmus [sid302307@gateway/web/irccloud.com/x-mevantlxtgbhlzak] has quit [Ping timeout: 250 seconds]
17:16 -!- gleb [sid306870@gateway/web/irccloud.com/x-kiiosqowproepuek] has quit [Read error: Connection reset by peer]
17:19 -!- ccook [sid271969@gateway/web/irccloud.com/x-pieobunsxejrhoqd] has quit [Ping timeout: 258 seconds]
17:22 -!- Liliaceae [sid282374@gateway/web/irccloud.com/x-peaxvjrmudhhudaw] has quit [Ping timeout: 252 seconds]
17:30 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.4]
17:32 -!- pierre_rochard [sid299882@gateway/web/irccloud.com/x-njqrvvzbfnfanpgg] has quit [Ping timeout: 250 seconds]
17:33 -!- ccook [sid271969@gateway/web/irccloud.com/x-aklmsigwqwuyistb] has joined #bitcoin-core-dev
17:36 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev
17:38 -!- Guest24808 [sid299882@gateway/web/irccloud.com/x-nbdsuayahggphcwb] has joined #bitcoin-core-dev
17:38 -!- ccook [sid271969@gateway/web/irccloud.com/x-aklmsigwqwuyistb] has quit [Ping timeout: 252 seconds]
17:40 -!- ccook [sid271969@gateway/web/irccloud.com/x-divsopufuhhyetyp] has joined #bitcoin-core-dev
17:40 -!- gleb [sid306870@gateway/web/irccloud.com/x-kixpygepvlctunkh] has joined #bitcoin-core-dev
17:40 -!- michagogo [uid14316@wikia/Michagogo] has joined #bitcoin-core-dev
17:44 -!- Liliaceae [sid282374@gateway/web/irccloud.com/x-moqmznythxahxrsz] has joined #bitcoin-core-dev
17:49 -!- Isthmus [sid302307@gateway/web/irccloud.com/x-xmzsxufmzboffdfh] has joined #bitcoin-core-dev
17:56 < kallewoof> jnewbery: haha, thanks! I really need to learn how to push my own PRs though. I realize it's my own fault, I just don't really know how to do it without sounding demanding.
18:08 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
18:11 -!- pinheadmz [~matthewzi@c-67-170-233-212.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
18:35 -!- millerti [~millerti@cpe-66-24-91-119.stny.res.rr.com] has joined #bitcoin-core-dev
18:42 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has joined #bitcoin-core-dev
18:46 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has quit [Ping timeout: 250 seconds]
18:50 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has joined #bitcoin-core-dev
18:50 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has quit [Remote host closed the connection]
18:51 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has joined #bitcoin-core-dev
18:53 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
19:01 -!- Randolf [~randolf@96.53.47.42] has joined #bitcoin-core-dev
19:10 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
19:11 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Quit: Leaving]
19:17 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
19:35 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev
19:41 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 256 seconds]
19:41 -!- riperk [uid352992@gateway/web/irccloud.com/x-cdgqofswubmcifyp] has quit [Quit: Connection closed for inactivity]
19:48 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
19:51 -!- spinza [~spin@155.93.246.187] has quit [Ping timeout: 252 seconds]
19:55 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
19:58 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 256 seconds]
19:59 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Client Quit]
20:00 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
20:05 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
20:13 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
20:21 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
20:36 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
20:43 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
20:44 -!- jonatack [d598a1a5@gateway/web/freenode/ip.213.152.161.165] has quit [Ping timeout: 256 seconds]
20:45 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 250 seconds]
20:49 -!- scoop [~scoop@205.178.77.52] has quit [Remote host closed the connection]
20:49 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev
20:56 -!- scoop [~scoop@205.178.77.52] has quit [Ping timeout: 264 seconds]
21:00 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
21:03 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 256 seconds]
21:11 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
21:17 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev
21:20 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
21:26 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 256 seconds]
21:29 -!- teardown [~user@unaffiliated/mrush] has joined #bitcoin-core-dev
21:35 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
21:37 -!- riperk [uid352992@gateway/web/irccloud.com/x-ithplgecgisdgtrc] has joined #bitcoin-core-dev
22:21 -!- harrymm [~harrymm@209.58.188.77] has quit [Ping timeout: 250 seconds]
22:34 -!- harrymm [~harrymm@209.58.188.77] has joined #bitcoin-core-dev
22:39 < fanquake> Have thrown some numbers up into #15751, the speedup is so significant it might be worth putting into 0.18 given another rc.
22:39 < gribble> https://github.com/bitcoin/bitcoin/issues/15751 | Speed up deriveaddresses for large ranges by sipa · Pull Request #15751 · bitcoin/bitcoin · GitHub
22:40 < gwillen> fanquake: it's worth noting that this never comes up unless you do something stupid
22:40 < gwillen> I triggered it by putting in 10k for the lulz, basically
22:40 < gwillen> I'm not aware of anybody ever running into this in actual use
22:41 < fanquake> gwillen no generating 1'000'000s of addrs then o.0
22:43 < gwillen> oh, my bad, I actually ran into _importmulti_ being slow with a huge range, and I am thinking of #15741, which is a different PR
22:43 < gribble> https://github.com/bitcoin/bitcoin/issues/15741 | Batch write imported stuff in importmulti by achow101 · Pull Request #15741 · bitcoin/bitcoin · GitHub
22:48 < gmaxwell> 10,000 isn't absurd in any case... esp since it doesn't auto expand as addresses are used.
22:51 < gwillen> yeah that's fair
22:51 < gwillen> that's sort of why I hit 10k in the first place (the fact that importmulti will give me a static pool and that's it)
22:51 < gwillen> of course real descriptor wallets will obviate all of this in the Glorius Future
23:49 -!- ghost43 [~daer@gateway/tor-sasl/daer] has quit [Ping timeout: 256 seconds]
23:55 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev
23:55 < fanquake> The node used to generate those numbers has finally finished shutting down after a 2hr 3m wait.
--- Log closed Sat Apr 13 00:00:43 2019