--- Log opened Wed Apr 17 00:00:47 2019 00:02 -!- captjakk [~captjakk@2601:284:8200:175:68bf:f5d2:fc77:3f6d] has quit [Ping timeout: 252 seconds] 00:07 -!- a5m0 [~a5m0@unaffiliated/a5m0] has quit [Ping timeout: 255 seconds] 00:15 -!- scoop [~scoop@50-232-52-220-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 00:19 -!- scoop [~scoop@50-232-52-220-static.hfc.comcastbusiness.net] has quit [Ping timeout: 246 seconds] 00:28 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 00:28 -!- bralyclow [bralyclow@gateway/vpn/protonvpn/bralyclow] has quit [Ping timeout: 255 seconds] 00:29 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 00:32 -!- a5m0 [~a5m0@unaffiliated/a5m0] has joined #bitcoin-core-dev 00:39 -!- captjakk [~captjakk@2601:284:8200:175:68bf:f5d2:fc77:3f6d] has joined #bitcoin-core-dev 00:42 -!- ccdle12_ [~ccdle12@tswc1c002.netvigator.com] has joined #bitcoin-core-dev 00:42 -!- kljasdfvv [~flack@p200300D46F0FA50084CF09EA194A9C08.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 00:44 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [] 00:44 -!- ccdle12 [~ccdle12@202.130.100.146] has quit [Ping timeout: 244 seconds] 00:44 -!- captjakk [~captjakk@2601:284:8200:175:68bf:f5d2:fc77:3f6d] has quit [Ping timeout: 250 seconds] 00:45 -!- scoop [~scoop@50-232-52-220-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 00:46 -!- Bullitje_enable [~Bullit01@042-236-158-163.dynamic.caiway.nl] has quit [Quit: Leaving] 00:48 -!- kljasdfvv [~flack@p200300D46F0FA50084CF09EA194A9C08.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!] 00:50 -!- scoop [~scoop@50-232-52-220-static.hfc.comcastbusiness.net] has quit [Ping timeout: 255 seconds] 00:57 -!- kljasdfvv [~flack@p200300D46F0FA5007922229ADF7F6FC2.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 01:03 -!- scoop [~scoop@50-232-52-220-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 01:05 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 246 seconds] 01:08 -!- scoop [~scoop@50-232-52-220-static.hfc.comcastbusiness.net] has quit [Ping timeout: 250 seconds] 01:15 -!- ccdle12_ [~ccdle12@tswc1c002.netvigator.com] has quit [Ping timeout: 245 seconds] 01:17 -!- fanquake [~fanquake@unaffiliated/fanquake] has joined #bitcoin-core-dev 01:21 -!- captjakk [~captjakk@2601:284:8200:175:68bf:f5d2:fc77:3f6d] has joined #bitcoin-core-dev 01:24 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 01:26 -!- captjakk [~captjakk@2601:284:8200:175:68bf:f5d2:fc77:3f6d] has quit [Ping timeout: 250 seconds] 01:27 -!- scoop [~scoop@50-232-52-220-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 01:32 -!- scoop [~scoop@50-232-52-220-static.hfc.comcastbusiness.net] has quit [Ping timeout: 268 seconds] 01:37 -!- Bullit [~Bullit01@042-236-158-163.dynamic.caiway.nl] has joined #bitcoin-core-dev 01:41 -!- captjakk [~captjakk@2601:284:8200:175:444a:f668:cb8b:f5b1] has joined #bitcoin-core-dev 01:44 -!- ccdle12 [~ccdle12@223.197.182.203] has joined #bitcoin-core-dev 01:45 -!- captjakk [~captjakk@2601:284:8200:175:444a:f668:cb8b:f5b1] has quit [Ping timeout: 268 seconds] 01:48 -!- promag [~promag@a89-153-67-150.cpe.netcabo.pt] has joined #bitcoin-core-dev 01:52 -!- scoop [~scoop@50-232-52-220-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 01:52 -!- promag [~promag@a89-153-67-150.cpe.netcabo.pt] has quit [Ping timeout: 246 seconds] 01:54 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 01:56 -!- scoop [~scoop@50-232-52-220-static.hfc.comcastbusiness.net] has quit [Ping timeout: 246 seconds] 02:02 -!- promag [~promag@195.54.168.134] has joined #bitcoin-core-dev 02:09 -!- laptop500 [~laptop@host109-149-118-169.range109-149.btcentralplus.com] has joined #bitcoin-core-dev 02:15 -!- scoop [~scoop@50-232-52-220-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 02:17 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 250 seconds] 02:19 -!- scoop [~scoop@50-232-52-220-static.hfc.comcastbusiness.net] has quit [Ping timeout: 244 seconds] 02:22 -!- captjakk [~captjakk@2601:284:8200:175:444a:f668:cb8b:f5b1] has joined #bitcoin-core-dev 02:24 -!- bralyclow [bralyclow@gateway/vpn/protonvpn/bralyclow] has joined #bitcoin-core-dev 02:27 -!- captjakk [~captjakk@2601:284:8200:175:444a:f668:cb8b:f5b1] has quit [Ping timeout: 268 seconds] 02:33 -!- promag [~promag@195.54.168.134] has quit [Remote host closed the connection] 02:35 -!- blackbaba [~blackbaba@157.39.243.196] has joined #bitcoin-core-dev 02:37 -!- promag [~promag@195.54.168.134] has joined #bitcoin-core-dev 02:38 -!- scoop [~scoop@50-232-52-220-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 02:38 -!- timothy [~tredaelli@redhat/timothy] has quit [Ping timeout: 250 seconds] 02:39 -!- captjakk [~captjakk@2601:284:8200:175:2043:390c:70be:66d7] has joined #bitcoin-core-dev 02:40 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 02:43 -!- scoop [~scoop@50-232-52-220-static.hfc.comcastbusiness.net] has quit [Ping timeout: 250 seconds] 02:44 -!- captjakk [~captjakk@2601:284:8200:175:2043:390c:70be:66d7] has quit [Ping timeout: 268 seconds] 02:45 -!- blackbaba_ [~blackbaba@45.248.78.228] has joined #bitcoin-core-dev 02:48 -!- blackbaba [~blackbaba@157.39.243.196] has quit [Ping timeout: 246 seconds] 02:48 -!- blackbaba_ is now known as blackbaba 02:49 -!- promag [~promag@195.54.168.134] has quit [Remote host closed the connection] 02:55 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev 02:58 -!- bralyclow [bralyclow@gateway/vpn/protonvpn/bralyclow] has quit [Ping timeout: 250 seconds] 03:00 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 03:00 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 03:02 -!- blackbaba [~blackbaba@45.248.78.228] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 03:09 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 03:21 -!- captjakk [~captjakk@2601:284:8200:175:2043:390c:70be:66d7] has joined #bitcoin-core-dev 03:25 -!- scoop [~scoop@50-232-52-220-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 03:26 -!- captjakk [~captjakk@2601:284:8200:175:2043:390c:70be:66d7] has quit [Ping timeout: 268 seconds] 03:29 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 03:29 -!- scoop [~scoop@50-232-52-220-static.hfc.comcastbusiness.net] has quit [Ping timeout: 268 seconds] 03:31 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:35 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 03:38 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds] 03:39 -!- captjakk [~captjakk@2601:284:8200:175:1d21:4f83:3afb:cf0a] has joined #bitcoin-core-dev 03:41 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection] 03:42 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev 03:43 -!- promag [~promag@195.54.168.134] has joined #bitcoin-core-dev 03:43 -!- captjakk [~captjakk@2601:284:8200:175:1d21:4f83:3afb:cf0a] has quit [Ping timeout: 252 seconds] 03:52 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has quit [Ping timeout: 255 seconds] 03:53 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has quit [Read error: Connection reset by peer] 03:54 -!- Victorsueca [~Victorsue@unaffiliated/victorsueca] has joined #bitcoin-core-dev 03:57 -!- chriswang2019 [~Mutter@119.131.106.190] has joined #bitcoin-core-dev 03:57 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 244 seconds] 04:00 -!- captjakk [~captjakk@2601:284:8200:175:1d21:4f83:3afb:cf0a] has joined #bitcoin-core-dev 04:02 -!- jonatack [58aba822@gateway/web/freenode/ip.88.171.168.34] has quit [] 04:02 -!- ccdle12 [~ccdle12@223.197.182.203] has quit [Remote host closed the connection] 04:05 -!- captjakk [~captjakk@2601:284:8200:175:1d21:4f83:3afb:cf0a] has quit [Ping timeout: 250 seconds] 04:06 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 04:12 -!- scoop [~scoop@50-232-52-220-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 04:13 -!- chriswang2019 [~Mutter@119.131.106.190] has quit [Quit: Mutter: www.mutterirc.com] 04:16 -!- scoop [~scoop@50-232-52-220-static.hfc.comcastbusiness.net] has quit [Ping timeout: 250 seconds] 04:32 -!- promag [~promag@195.54.168.134] has quit [Remote host closed the connection] 04:33 -!- promag [~promag@195.54.168.134] has joined #bitcoin-core-dev 04:38 -!- captjakk [~captjakk@2601:284:8200:175:21e3:80ac:a216:c40c] has joined #bitcoin-core-dev 04:39 -!- scoop [~scoop@50-232-52-220-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 04:41 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 245 seconds] 04:43 -!- captjakk [~captjakk@2601:284:8200:175:21e3:80ac:a216:c40c] has quit [Ping timeout: 268 seconds] 04:44 -!- scoop [~scoop@50-232-52-220-static.hfc.comcastbusiness.net] has quit [Ping timeout: 245 seconds] 04:53 -!- promag [~promag@195.54.168.134] has quit [Remote host closed the connection] 04:55 -!- bralyclow [bralyclow@gateway/vpn/protonvpn/bralyclow] has joined #bitcoin-core-dev 04:59 -!- captjakk [~captjakk@2601:284:8200:175:21e3:80ac:a216:c40c] has joined #bitcoin-core-dev 05:04 -!- captjakk [~captjakk@2601:284:8200:175:21e3:80ac:a216:c40c] has quit [Ping timeout: 240 seconds] 05:08 -!- scoop [~scoop@50-232-52-220-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 05:18 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 05:20 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 05:20 -!- captjakk [~captjakk@2601:284:8200:175:21e3:80ac:a216:c40c] has joined #bitcoin-core-dev 05:25 -!- captjakk [~captjakk@2601:284:8200:175:21e3:80ac:a216:c40c] has quit [Ping timeout: 252 seconds] 05:28 -!- bralyclow [bralyclow@gateway/vpn/protonvpn/bralyclow] has quit [Ping timeout: 244 seconds] 05:37 -!- captjakk [~captjakk@2601:284:8200:175:85b7:dc69:93b5:4a4d] has joined #bitcoin-core-dev 05:38 -!- Aaronvan_ is now known as AaronvanW 05:38 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 05:41 -!- captjakk [~captjakk@2601:284:8200:175:85b7:dc69:93b5:4a4d] has quit [Ping timeout: 268 seconds] 05:46 -!- lukedashjr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev 05:48 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 268 seconds] 05:50 -!- lukedashjr is now known as luke-jr 05:56 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 05:57 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 245 seconds] 06:01 -!- scoop [~scoop@50-232-52-220-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 06:04 -!- scoop [~scoop@50-232-52-220-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 06:06 -!- Skirmant [~Skirmant@84.15.234.220] has joined #bitcoin-core-dev 06:08 -!- scoop [~scoop@50-232-52-220-static.hfc.comcastbusiness.net] has quit [Ping timeout: 246 seconds] 06:09 -!- jonatack [52661ba3@gateway/web/freenode/ip.82.102.27.163] has joined #bitcoin-core-dev 06:30 -!- bralyclow [bralyclow@gateway/vpn/protonvpn/bralyclow] has joined #bitcoin-core-dev 06:38 -!- captjakk [~captjakk@2601:284:8200:175:ec3d:8a0a:5b34:5c6c] has joined #bitcoin-core-dev 06:42 -!- captjakk [~captjakk@2601:284:8200:175:ec3d:8a0a:5b34:5c6c] has quit [Ping timeout: 252 seconds] 06:42 -!- darosior [~darosior@193-141-190-109.dsl.ovh.fr] has joined #bitcoin-core-dev 06:50 < wumpus> strange, how to get an old wallet to generate a p2sh-segwit of bech32 receiving address? I don't seem to be able to from the GUI, I've done -upgradewallet and it upgrades the wallet in the log, but still, I get a 1xxxxx address when I generate a receiving address (and I've tried to uncheck "generate legacy address" 06:52 < wumpus> fwiw it did "Performing wallet upgrade to 169900" "Upgrading wallet to HD" "Upgrading wallet to use HD chain split" 06:53 < wumpus> we might want to disable that checkbox completely in this case 07:04 -!- jonatack [52661ba3@gateway/web/freenode/ip.82.102.27.163] has quit [Ping timeout: 256 seconds] 07:14 -!- Skirmant [~Skirmant@84.15.234.220] has quit [Ping timeout: 255 seconds] 07:15 < achow101> wumpus: the wallet version shouldn't matter 07:15 < achow101> try setting addresstype=p2sh-segwit? 07:19 < wumpus> I've done that, didn't work, I don't think that's supposed to affect the GUI. Also checked that it did work with a new wallet. 07:19 -!- captjakk [~captjakk@2601:284:8200:175:ec3d:8a0a:5b34:5c6c] has joined #bitcoin-core-dev 07:23 < wumpus> I was asking in case the answer was obvious and I was missing soething, but apparently not :) I'll investigate deeper later, have some administration to do now 07:24 -!- captjakk [~captjakk@2601:284:8200:175:ec3d:8a0a:5b34:5c6c] has quit [Ping timeout: 252 seconds] 07:24 < achow101> it's supposed to effect the gui and it has been for me (at least addresstype=bech32 does) 07:25 -!- bralyclo_ [bralyclow@gateway/vpn/protonvpn/bralyclow] has joined #bitcoin-core-dev 07:25 -!- shesek [~shesek@5.102.229.163] has joined #bitcoin-core-dev 07:25 -!- shesek [~shesek@5.102.229.163] has quit [Changing host] 07:25 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 07:25 -!- bralyclo_ [bralyclow@gateway/vpn/protonvpn/bralyclow] has quit [Read error: Connection reset by peer] 07:29 -!- bralyclow [bralyclow@gateway/vpn/protonvpn/bralyclow] has quit [Ping timeout: 250 seconds] 07:29 -!- captjakk [~captjakk@2601:284:8200:175:ec3d:8a0a:5b34:5c6c] has joined #bitcoin-core-dev 07:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:31 < bitcoin-git> [bitcoin] MarcoFalke pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/0c9de67f343c...e2b5fdee0068 07:31 < bitcoin-git> bitcoin/master e377846 João Barbosa: rest/rpc: Make mempoolinfo atomic 07:31 < bitcoin-git> bitcoin/master e2b5fde MarcoFalke: Merge #15474: rest/rpc: Make mempoolinfo atomic 07:31 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 07:32 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15474: rest/rpc: Make mempoolinfo atomic (master...2019-02-atomic-mempoolinfo) https://github.com/bitcoin/bitcoin/pull/15474 07:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 07:33 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 07:33 -!- scoop [~scoop@104.129.204.71] has joined #bitcoin-core-dev 07:34 -!- jeremyrubin [~jr@c-67-180-60-249.hsd1.ca.comcast.net] has quit [Ping timeout: 264 seconds] 07:38 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 255 seconds] 07:42 -!- davterra [~none@46.19.137.116] has joined #bitcoin-core-dev 07:56 -!- DougieBot5000_ [~DougieBot@unaffiliated/dougiebot5000] has joined #bitcoin-core-dev 07:58 -!- scoop [~scoop@104.129.204.71] has quit [Remote host closed the connection] 07:58 -!- scoop [~scoop@104.129.204.110] has joined #bitcoin-core-dev 07:59 -!- DougieBot5000 [~DougieBot@unaffiliated/dougiebot5000] has quit [Ping timeout: 264 seconds] 08:03 < provoostenator> addresstype=bech32 should indeed affect the GUI, but it merely changes the default checkbox. 1x addresses suggest a different problem. 08:04 -!- scoop [~scoop@104.129.204.110] has quit [Remote host closed the connection] 08:25 -!- pinheadmz [~matthewzi@c-67-170-233-212.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 08:32 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 08:32 < sdaftuar> gmaxwell: i wonder if we should just revert #14897 for 0.18? i would like those changes to go in but i'm nervous about the edge cases we have overlooked thus far, which result in things like tx relay failing en masse and fill-up-your-memory attacks. 08:32 < gribble> https://github.com/bitcoin/bitcoin/issues/14897 | randomize GETDATA(tx) request order and introduce bias toward outbound by naumenkogs · Pull Request #14897 · bitcoin/bitcoin · GitHub 08:33 < sdaftuar> (well, maybe the memory issue is just in the bugfix PR, i need to re-read aj's comment) 08:35 -!- kljasdfvv [~flack@p200300D46F0FA5007922229ADF7F6FC2.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds] 08:35 -!- gggggggggggg [~flack@p200300D46F0FA500BC8FAA606FCBEEF9.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 08:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:41 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/e2b5fdee0068...429a7cf34fa8 08:41 < bitcoin-git> bitcoin/master fad81d8 MarcoFalke: test: Fixup creatmultisig documentation and whitespace 08:41 < bitcoin-git> bitcoin/master fab6a0a MarcoFalke: test: Add test that addmultisigaddress fails for watchonly addresses 08:41 < bitcoin-git> bitcoin/master 429a7cf MarcoFalke: Merge #15831: test: Add test that addmultisigaddress fails for watchonly a... 08:41 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 08:42 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15831: test: Add test that addmultisigaddress fails for watchonly addresses (master...1904-testMulti) https://github.com/bitcoin/bitcoin/pull/15831 08:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 08:53 -!- irc_viewer_test [irc_viewer@gateway/vpn/privateinternetaccess/ircviewertest/x-06412631] has joined #bitcoin-core-dev 08:54 -!- irc_viewer_test [irc_viewer@gateway/vpn/privateinternetaccess/ircviewertest/x-06412631] has quit [Client Quit] 08:57 -!- scoop [~scoop@104.129.204.71] has joined #bitcoin-core-dev 09:01 -!- scoop [~scoop@104.129.204.71] has quit [Ping timeout: 268 seconds] 09:05 -!- millerti [~millerti@cpe-66-24-91-119.stny.res.rr.com] has joined #bitcoin-core-dev 09:12 -!- scoop [~scoop@104.129.204.132] has joined #bitcoin-core-dev 09:16 -!- scoop [~scoop@104.129.204.132] has quit [Ping timeout: 246 seconds] 09:19 -!- davterra [~none@46.19.137.116] has quit [Quit: Leaving] 09:24 -!- murrayn_ [~murrayn@S0106f8a097f16608.ok.shawcable.net] has joined #bitcoin-core-dev 09:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:27 < bitcoin-git> [bitcoin] nkostoulas opened pull request #15838: scripts and tools: Fetch missing review comments in github-merge.py (master...2019-04-fix-merge-script) https://github.com/bitcoin/bitcoin/pull/15838 09:27 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:27 -!- jb55 [~jb55@S010660e327dca171.vc.shawcable.net] has quit [Ping timeout: 255 seconds] 09:27 -!- murrayn [~murrayn@unaffiliated/murrayn] has quit [Ping timeout: 246 seconds] 09:29 -!- jb55 [~jb55@S010660e327dca171.vc.shawcable.net] has joined #bitcoin-core-dev 09:32 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds] 09:39 -!- jb55 [~jb55@S010660e327dca171.vc.shawcable.net] has quit [Quit: WeeChat 2.4] 09:43 -!- scoop [~scoop@104.129.204.140] has joined #bitcoin-core-dev 09:44 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev 09:48 -!- scoop [~scoop@104.129.204.140] has quit [Ping timeout: 250 seconds] 09:48 -!- jeremyrubin [~jr@c-67-180-60-249.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 09:59 -!- scoop [~scoop@104.129.204.132] has joined #bitcoin-core-dev 10:03 -!- scoop [~scoop@104.129.204.132] has quit [Ping timeout: 246 seconds] 10:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:17 < bitcoin-git> [bitcoin] sdaftuar opened pull request #15839: [0.18] Revert GetData randomization change (#14897) (0.18...2019-04-revert-14897) https://github.com/bitcoin/bitcoin/pull/15839 10:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:24 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev 10:30 -!- scoop [~scoop@104.129.204.71] has joined #bitcoin-core-dev 10:31 -!- dqx_ [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev 10:34 -!- scoop [~scoop@104.129.204.71] has quit [Ping timeout: 268 seconds] 10:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:37 < bitcoin-git> [bitcoin] abitfan opened pull request #15840: Contrib scripts: Filter IPv6 by ASN (master...dnsseeder) https://github.com/bitcoin/bitcoin/pull/15840 10:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:40 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev 10:42 -!- darosior [~darosior@193-141-190-109.dsl.ovh.fr] has quit [Remote host closed the connection] 10:45 -!- scoop [~scoop@104.129.204.138] has joined #bitcoin-core-dev 10:50 -!- scoop [~scoop@104.129.204.138] has quit [Ping timeout: 245 seconds] 10:54 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 10:56 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-zuqkvybchlaclmvs] has joined #bitcoin-core-dev 11:01 -!- scoop [~scoop@104.129.204.132] has joined #bitcoin-core-dev 11:12 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection] 11:33 -!- scoop [~scoop@104.129.204.132] has quit [Remote host closed the connection] 11:35 -!- scoop [~scoop@104.129.204.142] has joined #bitcoin-core-dev 11:41 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 255 seconds] 11:46 < instagibbs> is there a static fully valid pubkey somewhere in the Core codebase to reference in say unit tests? 11:46 < sipa> use the generator? :) 11:46 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev 11:47 < instagibbs> "no" is also an acceptable answer 11:49 < gmaxwell> The generator is a fully valid pubkey... 11:50 < sipa> 0x0279BE667EF9DCBBAC55A06295CE870B07029BFCDB2DCE28D959F2815B16F81798 FYI :) 11:50 < sipa> (with secret key 0x0000....00001) 11:50 < instagibbs> indeed, hence "no", I'll have to make it 11:50 < sipa> instagibbs: i'm confused 11:50 < instagibbs> im asking if it's in the core codebase, it's not confusing at all 11:50 < instagibbs> "make your own" is fine 11:51 < sipa> sure; it's hardcoded in secp256k1 11:51 < instagibbs> it's all ok 11:51 < sipa> ok. 11:54 -!- sdaftuar_ [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 11:55 < instagibbs> functional test harness has static keys for quick reference when wallet isn't compiled in, was just checking if that existed 11:56 -!- sdaftuar_ [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Client Quit] 11:56 -!- sdaftuar_ [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 11:59 -!- sdaftuar [~sdaftuar@unaffiliated/sdaftuar] has left #bitcoin-core-dev [] 12:01 -!- midnightmagic [~midnightm@unaffiliated/midnightmagic] has quit [Ping timeout: 264 seconds] 12:04 -!- scoop [~scoop@104.129.204.142] has quit [Remote host closed the connection] 12:06 -!- sdaftuar_ is now known as sdaftuar 12:09 < MarcoFalke> instagibbs: ADDRESS_BCRT1_UNSPENDABLE or self.nodes[i].get_deterministic_priv_key().address ? 12:12 -!- captjakk [~captjakk@2601:284:8200:175:ec3d:8a0a:5b34:5c6c] has quit [] 12:13 < instagibbs> right I've used those, was just curious about C++ land 12:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:15 < bitcoin-git> [bitcoin] MarcoFalke pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/429a7cf34fa8...dae72998e857 12:15 < bitcoin-git> bitcoin/master fa46ac3 MarcoFalke: bench: Add wallet_balance benchmarks 12:15 < bitcoin-git> bitcoin/master fad7c33 MarcoFalke: refactor: Add handleNotifications method to wallet 12:15 < bitcoin-git> bitcoin/master dae7299 MarcoFalke: Merge #15779: test: Add wallet_balance benchmark 12:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 12:16 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #15779: test: Add wallet_balance benchmark (master...1904-benchWallet) https://github.com/bitcoin/bitcoin/pull/15779 12:16 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:16 < MarcoFalke> instagibbs: ADDRESS_BCRT1_UNSPENDABLE is also in cpp ;) 12:16 < MarcoFalke> Just merged a second ago 12:17 < instagibbs> :shakes fist: 12:17 < instagibbs> thanks 12:21 -!- laptop500 [~laptop@host109-149-118-169.range109-149.btcentralplus.com] has quit [Remote host closed the connection] 12:26 -!- bitbee is now known as netcat 12:26 -!- netcat is now known as bitbee 12:27 -!- bitbee [~bitbee@unaffiliated/cryptocat] has quit [Quit: Leaving.] 12:35 -!- scoop [~scoop@104.129.204.140] has joined #bitcoin-core-dev 12:40 -!- scoop [~scoop@104.129.204.140] has quit [Ping timeout: 250 seconds] 12:48 -!- bitbee [~bitbee@unaffiliated/cryptocat] has joined #bitcoin-core-dev 12:48 -!- freedomcode [~reardenco@shrugged.reardencode.com] has quit [Quit: Reconnecting] 12:48 -!- reardencode [~reardenco@shrugged.reardencode.com] has joined #bitcoin-core-dev 12:50 -!- laptop500 [~laptop@host109-149-118-169.range109-149.btcentralplus.com] has joined #bitcoin-core-dev 13:01 -!- scoop [~scoop@104.129.204.71] has joined #bitcoin-core-dev 13:03 -!- scoop [~scoop@104.129.204.71] has quit [Remote host closed the connection] 13:04 -!- shesek [~shesek@5.22.134.182] has joined #bitcoin-core-dev 13:04 -!- shesek [~shesek@5.22.134.182] has quit [Changing host] 13:04 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev 13:04 -!- scoop [~scoop@104.129.204.132] has joined #bitcoin-core-dev 13:11 -!- scoop [~scoop@104.129.204.132] has quit [Remote host closed the connection] 13:12 -!- darosior [~darosior@2a01:e35:2ff9:8200:db25:2326:fa48:942c] has joined #bitcoin-core-dev 13:13 -!- scoop [~scoop@104.129.204.110] has joined #bitcoin-core-dev 13:15 -!- scoop [~scoop@104.129.204.110] has quit [Remote host closed the connection] 13:26 -!- scoop [~scoop@104.129.204.71] has joined #bitcoin-core-dev 13:26 -!- scoop [~scoop@104.129.204.71] has quit [Remote host closed the connection] 13:36 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Remote host closed the connection] 13:37 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev 13:37 -!- OneFive [~OneFive@cpc87991-haye25-2-0-cust817.17-4.cable.virginm.net] has joined #bitcoin-core-dev 13:40 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 246 seconds] 13:51 * luke-jr wonders if #15617 should be backported 13:51 < gribble> https://github.com/bitcoin/bitcoin/issues/15617 | p2p: Do not relay banned IP addresses by sipa · Pull Request #15617 · bitcoin/bitcoin · GitHub 13:54 < gmaxwell> Probably but otoh, backports appear to be a waste of time. 13:54 < gmaxwell> (beyond the most recent major version) 14:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:01 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #15841: test: append node stderr and stdout if it exists (master...1904-testLogStdErr) https://github.com/bitcoin/bitcoin/pull/15841 14:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:01 < luke-jr> gmaxwell: well, in this case a backport would be to 0.18 ;) 14:02 < gmaxwell> oh that was supposted to go into 0.18. 14:02 < gmaxwell> Did it get missed? :-/ 14:02 < luke-jr> oh, nm, I see it there, just didn't get noted on github 14:03 < luke-jr> … or I just somehow entirely didn't see it :/ 14:05 < instagibbs> MarcoFalke, do we normally close issues when someone opens a related PR? (re 15841) 14:05 < luke-jr> I guess after reviewing the code, I ended up scrolled past the backport stuff 14:05 < sipa> 15617 is in 0.18 (commit 238ef336929606632f0564e417ee0b6fd649c2a9) 14:07 < MarcoFalke> instagibbs: Usually we don't 14:08 < MarcoFalke> But I close my issues when no one has picked them up, which shows a lack of interest 14:09 < instagibbs> got it 14:24 -!- ghost43 [~daer@gateway/tor-sasl/daer] has joined #bitcoin-core-dev 14:24 -!- darosior [~darosior@2a01:e35:2ff9:8200:db25:2326:fa48:942c] has quit [Remote host closed the connection] 14:31 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:32 -!- scoop [~scoop@50-232-52-220-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 14:32 -!- scoop [~scoop@50-232-52-220-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 14:32 -!- scoop [~scoop@50-232-52-220-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 14:35 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-zuqkvybchlaclmvs] has quit [Quit: Connection closed for inactivity] 14:41 -!- DougieBot5000_ is now known as DougieBot5000 14:43 -!- thaumavorio [~thaumavor@thaumavor.io] has quit [Quit: ZNC 1.7.1 - https://znc.in] 14:43 -!- jarthur [~jarthur@207.114.244.5] has quit [] 14:44 -!- thaumavorio [~thaumavor@thaumavor.io] has joined #bitcoin-core-dev 14:45 -!- scoop [~scoop@50-232-52-220-static.hfc.comcastbusiness.net] has quit [Remote host closed the connection] 14:47 -!- scoop [~scoop@50-232-52-220-static.hfc.comcastbusiness.net] has joined #bitcoin-core-dev 14:52 -!- scoop [~scoop@50-232-52-220-static.hfc.comcastbusiness.net] has quit [Ping timeout: 245 seconds] 14:59 -!- OneFive [~OneFive@cpc87991-haye25-2-0-cust817.17-4.cable.virginm.net] has quit [Read error: Connection reset by peer] 14:59 -!- OneFive [~OneFive@cpc87991-haye25-2-0-cust817.17-4.cable.virginm.net] has joined #bitcoin-core-dev 15:11 -!- OneFive [~OneFive@cpc87991-haye25-2-0-cust817.17-4.cable.virginm.net] has quit [Ping timeout: 255 seconds] 15:16 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 15:34 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 15:48 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 255 seconds] 15:51 -!- dqx_ [~dqx@unaffiliated/dqx] has quit [Read error: Connection reset by peer] 15:52 -!- dqx_ [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev 15:53 -!- dqx_ [~dqx@unaffiliated/dqx] has quit [Read error: Connection reset by peer] 15:55 -!- dqx_ [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev 16:00 -!- dqx_ [~dqx@unaffiliated/dqx] has quit [Ping timeout: 255 seconds] 16:03 -!- scoop [~scoop@70.42.157.22] has joined #bitcoin-core-dev 16:15 -!- Aaronvan_ is now known as AaronvanW 16:27 -!- laptop500 [~laptop@host109-149-118-169.range109-149.btcentralplus.com] has quit [Quit: Leaving] 16:31 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection] 16:51 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds] 17:18 -!- fanquake [~fanquake@unaffiliated/fanquake] has quit [] 17:50 -!- millerti [~millerti@cpe-66-24-91-119.stny.res.rr.com] has quit [Ping timeout: 246 seconds] 17:54 -!- Jackielove4u_ [uid43977@gateway/web/irccloud.com/x-nujvdxjotuwfuyga] has joined #bitcoin-core-dev 17:55 -!- Liliaceae_ [sid282374@gateway/web/irccloud.com/x-hkduaubeadzmussy] has joined #bitcoin-core-dev 17:55 -!- Varunram_ [sid210151@gateway/web/irccloud.com/x-oorburoqatokdnzy] has joined #bitcoin-core-dev 17:55 -!- michagogo_ [uid14316@wikia/Michagogo] has joined #bitcoin-core-dev 17:57 -!- gmaxwell_ [gmaxwell@mf4-xiph.osuosl.org] has joined #bitcoin-core-dev 17:57 -!- commavir_ [~vir@23.226.237.192] has joined #bitcoin-core-dev 17:57 -!- omonk_ [~omonk@unaffiliated/omonk] has joined #bitcoin-core-dev 17:57 -!- windsok_ [~windsok@rarepepe.cash] has joined #bitcoin-core-dev 18:00 -!- jonasschnelli_ [~jonasschn@2a01:4f8:172:10da::2] has joined #bitcoin-core-dev 18:02 -!- Netsplit *.net <-> *.split quits: Jackielove4u, jonasschnelli, michagogo, windsok, Liliaceae, omonk, commavir, Varunram, gmaxwell 18:02 -!- commavir_ is now known as commavir 18:02 -!- Jackielove4u_ is now known as Jackielove4u 18:02 -!- Varunram_ is now known as Varunram 18:02 -!- Liliaceae_ is now known as Liliaceae 18:07 < luke-jr> sometimes I wish software had an increment-only security-fix counter common across the rest of the version :x 18:07 < luke-jr> so one could know so long as the Nth digit is latest, it has all known security issues patched 18:12 -!- Haeapw [bacdb2ab@gateway/web/freenode/ip.186.205.178.171] has joined #bitcoin-core-dev 18:12 -!- Haeapw [bacdb2ab@gateway/web/freenode/ip.186.205.178.171] has quit [Client Quit] 18:13 -!- pinheadmz [~matthewzi@c-67-170-233-212.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 19:01 -!- gmaxwell_ [gmaxwell@mf4-xiph.osuosl.org] has quit [Changing host] 19:01 -!- gmaxwell_ [gmaxwell@wikimedia/KatWalsh/x-0001] has joined #bitcoin-core-dev 19:01 -!- gmaxwell_ is now known as gmaxwell 19:15 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 19:31 < echeveria> luke-jr: that doesn't really work so well where patches needed total rewrites, ie the utxo 19:31 < luke-jr> sure it does? if 99 has a bug, anything unaffected must be >=100 19:32 < luke-jr> then the advisory can just say "be sure you have version >= x.y.100 19:34 < kallewoof> that's a nice idea, but if version 2.1.3.99 has a vulnerability that none of the other versions have, then 2.1.2.99 is not affected even though its security counter < 100 19:35 < kallewoof> unless the authors just bump the version without changing anything every time security counter is bumped up, even for unaffected versions. 19:35 < kallewoof> s/bump the version/release same v with counter updated/ 19:38 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 19:47 -!- scoop [~scoop@70.42.157.22] has quit [Remote host closed the connection] 19:59 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 20:13 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 20:16 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 20:24 < luke-jr> kallewoof: yeah, but if that's the worst case scenario, it's still an improvement 20:25 < luke-jr> and using 2.1.3.100 instead of 2.1.2.99 is less of a problem with this, than if 2.1.3.100 might be vulnerable, but 2.1.2.99 isn't. 20:26 * kallewoof nods 20:38 -!- karna [b28039b1@gateway/web/freenode/ip.178.128.57.177] has joined #bitcoin-core-dev 20:39 -!- spinza [~spin@155.93.246.187] has quit [Quit: Coyote finally caught up with me...] 20:45 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 20:51 -!- Dean_Guss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 20:59 -!- spinza [~spin@155.93.246.187] has joined #bitcoin-core-dev 21:01 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 21:08 -!- karna [b28039b1@gateway/web/freenode/ip.178.128.57.177] has quit [Ping timeout: 256 seconds] 21:17 -!- dqx_ [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev 21:18 -!- dqx_ [~dqx@unaffiliated/dqx] has quit [Read error: Connection reset by peer] 21:22 -!- dqx_ [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev 21:40 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 245 seconds] 22:19 -!- dqx__ [~dqx@unaffiliated/dqx] has joined #bitcoin-core-dev 22:22 -!- dqx_ [~dqx@unaffiliated/dqx] has quit [Ping timeout: 250 seconds] 22:31 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 22:38 -!- dqx__ [~dqx@unaffiliated/dqx] has quit [Quit: .] 23:02 -!- pinheadmz [~matthewzi@c-76-102-227-220.hsd1.ca.comcast.net] has quit [Quit: pinheadmz] 23:04 -!- jonasschnelli_ [~jonasschn@2a01:4f8:172:10da::2] has quit [Changing host] 23:04 -!- jonasschnelli_ [~jonasschn@unaffiliated/jonasschnelli] has joined #bitcoin-core-dev 23:04 -!- jnewbery [~john@static-100-38-11-146.nycmny.fios.verizon.net] has quit [Ping timeout: 246 seconds] 23:04 -!- jnewbery [~john@static-100-38-11-146.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 23:16 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev 23:40 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev --- Log closed Thu Apr 18 00:00:48 2019