--- Log opened Fri Jun 21 00:00:03 2019
--- Day changed Fri Jun 21 2019
00:00 < jonasschnelli> The question is, if BE is reasonable anymore...
00:00 < kallewoof> i thought there was new hardware that was BE or could be BE
00:01 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
00:02 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 245 seconds]
00:04 < jonasschnelli> BE is probably relevant fpr the Power9 family
00:06 -!- promag [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev
00:07 -!- mildly_risky [~~mildly_r@14-0-156-009.static.pccw-hkt.com] has joined #bitcoin-core-dev
00:08 -!- mildly_risky [~~mildly_r@14-0-156-009.static.pccw-hkt.com] has quit [Client Quit]
00:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:26 < bitcoin-git> [bitcoin] NicolasDorier opened pull request #16258: [MSVC]: Create the config.ini as part of bitcoind build (master...msvc/build-config-ini) https://github.com/bitcoin/bitcoin/pull/16258
00:26 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:37 < kallewoof> @sipa I am confused about a commit of yours from March 2016 (sorry..!), but someone else might be able to explain this: https://github.com/bitcoin/bitcoin/commit/8a253b342c5272496926ed391b078742bbe937ae -- the nInnerLoopCount restricts the nonce to 0..65535 (16 bits), but the nonce is 32 bits. Why? I realize if you make this 0xffffffff and try to Ctrl-C a bitcoind instance while trying to find a blokc, it will lock up and
00:37 < kallewoof>  wait for the generate to finish. Is that why?
00:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:44 < bitcoin-git> [bitcoin] meshcollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/23815ee74dfd...303ec103bacf
00:44 < bitcoin-git> bitcoin/master a495034 Andrew Chow: Make and get the multisig redeemscript and destination in one function ins...
00:44 < bitcoin-git> bitcoin/master 303ec10 MeshCollider: Merge #16026: Ensure that uncompressed public keys in a multisig always re...
00:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
00:45 < bitcoin-git> [bitcoin] meshcollider merged pull request #16026: Ensure that uncompressed public keys in a multisig always returns a legacy address (master...dont-sw-ms-uncomp) https://github.com/bitcoin/bitcoin/pull/16026
00:45 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
00:49 -!- cncr04s [~cncr04s@unaffiliated/cncr04s] has quit [Ping timeout: 250 seconds]
00:49 -!- emilengler [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-dev
00:54 -!- astro [~astro@gateway/tor-sasl/astro] has quit [Remote host closed the connection]
00:54 -!- kljasdfvv [~flack@p200300D46F2D62008981703559C3476E.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
00:56 -!- cncr04s [~cncr04s@unaffiliated/cncr04s] has joined #bitcoin-core-dev
00:58 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.5]
00:59 -!- astro [~astro@gateway/tor-sasl/astro] has joined #bitcoin-core-dev
01:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:00 < bitcoin-git> [bitcoin] meshcollider pushed 3 commits to master: https://github.com/bitcoin/bitcoin/compare/303ec103bacf...fd333e15a545
01:00 < bitcoin-git> bitcoin/master 7c611e2 Andrew Chow: Move ismine to wallet module
01:00 < bitcoin-git> bitcoin/master e61de63 Andrew Chow: Change ismine to take a CWallet instead of CKeyStore
01:00 < bitcoin-git> bitcoin/master fd333e1 MeshCollider: Merge #16226: Move ismine to the wallet module
01:00 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
01:01 < bitcoin-git> [bitcoin] meshcollider merged pull request #16226: Move ismine to the wallet module (master...mv-ismine-wallet) https://github.com/bitcoin/bitcoin/pull/16226
01:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
01:13 -!- rex4539 [~rex4539@2a02:587:3516:d600:5128:5d5d:6d43:476] has quit [Quit: rex4539]
01:13 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
01:13 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 246 seconds]
01:14 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 258 seconds]
01:18 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Quit: Leaving]
01:20 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
01:22 -!- surja795 [~sourabh@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev
01:23 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds]
01:27 -!- surja795 [~sourabh@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Ping timeout: 245 seconds]
01:36 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
01:36 -!- mryandao_ [~mryandao@gateway/tor-sasl/mryandao] has joined #bitcoin-core-dev
01:36 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has quit [Remote host closed the connection]
01:39 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev
01:40 -!- sfhi [~sfhi@b9.7c.089f.ip4.static.sl-reverse.com] has joined #bitcoin-core-dev
01:51 -!- darosior [6dbe8dc1@gateway/web/freenode/ip.109.190.141.193] has joined #bitcoin-core-dev
01:54 -!- sfhi [~sfhi@b9.7c.089f.ip4.static.sl-reverse.com] has quit [Ping timeout: 258 seconds]
02:00 -!- beng-nl1 [~beng-nl@192.145.126.244] has quit []
02:00 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
02:05 -!- Honkeymagoo [~Honkeymag@185.204.1.185] has joined #bitcoin-core-dev
02:12 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev
02:14 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
02:26 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
02:26 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 245 seconds]
02:27 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 268 seconds]
02:34 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
02:48 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 248 seconds]
02:50 -!- anonymous8587 [~Mutter@2a01:598:a909:e7da:4075:aa11:6f8b:9bdc] has joined #bitcoin-core-dev
02:53 -!- anonymous8587 [~Mutter@2a01:598:a909:e7da:4075:aa11:6f8b:9bdc] has quit [Client Quit]
02:56 -!- darosior [6dbe8dc1@gateway/web/freenode/ip.109.190.141.193] has quit [Quit: Page closed]
03:04 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 258 seconds]
03:16 -!- michaelfolkson [~textual@46.233.78.146] has joined #bitcoin-core-dev
03:17 -!- michaelfolkson [~textual@46.233.78.146] has quit [Client Quit]
03:18 -!- michaelfolkson [~textual@46.233.78.146] has joined #bitcoin-core-dev
03:22 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
03:33 -!- michaelfolkson [~textual@46.233.78.146] has quit [Ping timeout: 268 seconds]
03:37 -!- astro [~astro@gateway/tor-sasl/astro] has quit [Remote host closed the connection]
03:40 -!- justanotheruser [justanothe@gateway/vpn/nordvpn/justanotheruser] has quit [Read error: Connection reset by peer]
03:41 -!- Honkeymagoo [~Honkeymag@185.204.1.185] has quit [Ping timeout: 246 seconds]
03:42 -!- astro [~astro@gateway/tor-sasl/astro] has joined #bitcoin-core-dev
03:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:42 < bitcoin-git> [bitcoin] fanquake pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/fd333e15a545...32e94538185b
03:42 < bitcoin-git> bitcoin/master 5a88ea7 Jon Atack: doc: remove orphaned header in developer notes
03:42 < bitcoin-git> bitcoin/master 32e9453 fanquake: Merge #16256: doc: remove orphaned header in developer notes
03:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:43 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
03:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:43 < bitcoin-git> [bitcoin] fanquake merged pull request #16256: doc: remove orphaned header in developer notes (master...remove-orphaned-header-link-in-developer-notes) https://github.com/bitcoin/bitcoin/pull/16256
03:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:44 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
03:45 -!- spinza [~spin@102.132.245.16] has quit [Quit: Coyote finally caught up with me...]
03:48 -!- chriswang2019 [~Mutter@2409:8955:6a0:ab4:200d:8f7e:5b7b:45c5] has joined #bitcoin-core-dev
03:48 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 258 seconds]
03:55 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev
03:56 -!- jonatack [44a1d775@gateway/web/freenode/ip.68.161.215.117] has joined #bitcoin-core-dev
03:56 -!- chriswang2019 [~Mutter@2409:8955:6a0:ab4:200d:8f7e:5b7b:45c5] has quit [Read error: Connection reset by peer]
03:59 -!- lnostdal [~lnostdal@77.70.119.51] has quit [Quit: "Fascism, Nazism, Communism and Socialism are only superficial variations of the same monstrous theme—collectivism." -- Ayn Rand]
03:59 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 245 seconds]
03:59 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 245 seconds]
03:59 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
04:02 -!- tlyu [~tlyu@185.5.172.148] has joined #bitcoin-core-dev
04:04 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
04:05 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
04:09 -!- lnostdal [~lnostdal@77.70.119.51] has joined #bitcoin-core-dev
04:21 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
04:22 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 245 seconds]
04:22 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 248 seconds]
04:24 -!- astro [~astro@gateway/tor-sasl/astro] has quit [Remote host closed the connection]
04:28 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
04:30 -!- astro [~astro@gateway/tor-sasl/astro] has joined #bitcoin-core-dev
04:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:32 < bitcoin-git> [bitcoin] natangl opened pull request #16260: Yehuda (master...yehuda) https://github.com/bitcoin/bitcoin/pull/16260
04:32 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
04:33 < bitcoin-git> [bitcoin] fanquake closed pull request #16260: Yehuda (master...yehuda) https://github.com/bitcoin/bitcoin/pull/16260
04:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
04:49 -!- astro_ [~astro@gateway/tor-sasl/astro] has joined #bitcoin-core-dev
04:51 -!- astro [~astro@gateway/tor-sasl/astro] has quit [Ping timeout: 256 seconds]
04:52 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 248 seconds]
04:56 -!- surja795 [~sourabh@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev
04:56 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection]
04:59 -!- aiprivateexchang [a7565247@gateway/web/freenode/ip.167.86.82.71] has joined #bitcoin-core-dev
05:00 -!- tlyu [~tlyu@185.5.172.148] has quit []
05:00 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has joined #bitcoin-core-dev
05:00 -!- aiprivateexchang [a7565247@gateway/web/freenode/ip.167.86.82.71] has left #bitcoin-core-dev []
05:00 -!- qwebirc303118 [6d9f3fe6@gateway/web/freenode/ip.109.159.63.230] has joined #bitcoin-core-dev
05:03 -!- hds [~hds@185.59.221.95] has joined #bitcoin-core-dev
05:12 -!- promag_ [~promag@bl6-24-70.dsl.telepac.pt] has quit [Remote host closed the connection]
05:16 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
05:18 -!- darosior [6dbe8dc1@gateway/web/freenode/ip.109.190.141.193] has joined #bitcoin-core-dev
05:26 -!- surja795 [~sourabh@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Ping timeout: 248 seconds]
05:44 -!- jonatack [44a1d775@gateway/web/freenode/ip.68.161.215.117] has quit [Ping timeout: 256 seconds]
05:57 -!- provoostenator [~vwDZ2BYsc@2a05:d014:5f:e100:fd30:8af7:2d6a:cbb1] has quit [Ping timeout: 250 seconds]
06:06 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
06:08 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
06:09 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev
06:12 -!- shesek [~shesek@unaffiliated/shesek] has quit [Excess Flood]
06:13 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 248 seconds]
06:13 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
06:14 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
06:21 -!- shesek [~shesek@unaffiliated/shesek] has quit [Read error: Connection reset by peer]
06:31 -!- provoostenator [~vwDZ2BYsc@2a05:d014:5f:e100:fd30:8af7:2d6a:cbb1] has joined #bitcoin-core-dev
06:34 -!- promag_ [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev
06:39 -!- promag_ [~promag@bl16-114-47.dsl.telepac.pt] has quit [Ping timeout: 245 seconds]
06:40 -!- hebasto [9fe07a87@gateway/web/freenode/ip.159.224.122.135] has quit [Ping timeout: 256 seconds]
06:41 -!- lightlike [~lightlike@2001:16b8:5759:5f00:7009:df4d:a237:138e] has joined #bitcoin-core-dev
06:45 -!- bralyclow01 [~bralyclow@unaffiliated/bralyclow] has joined #bitcoin-core-dev
06:46 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-vjvobwreieupkelg] has joined #bitcoin-core-dev
06:49 -!- bralyclow [~bralyclow@unaffiliated/bralyclow] has quit [Ping timeout: 268 seconds]
06:50 -!- d_t [~dt@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev
06:53 -!- aseem [~aseem@38.88.150.114] has joined #bitcoin-core-dev
06:55 < MarcoFalke> #proposedmeetingtopic  0.18.1: Backports #16035 
06:55 < gribble> https://github.com/bitcoin/bitcoin/issues/16035 | 0.18.1: Backports by MarcoFalke · Pull Request #16035 · bitcoin/bitcoin · GitHub
07:03 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
07:08 -!- mryandao [~mryandao@gateway/tor-sasl/mryandao] has joined #bitcoin-core-dev
07:10 -!- mryandao_ [~mryandao@gateway/tor-sasl/mryandao] has quit [Ping timeout: 256 seconds]
07:16 -!- provoostenator [~vwDZ2BYsc@2a05:d014:5f:e100:fd30:8af7:2d6a:cbb1] has quit [Quit: ZNC 1.6.6+deb1ubuntu0.1 - http://znc.in]
07:17 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev
07:21 -!- provoostenator [~vwDZ2BYsc@2a05:d014:5f:e100:fd30:8af7:2d6a:cbb1] has joined #bitcoin-core-dev
07:27 -!- provoostenator [~vwDZ2BYsc@2a05:d014:5f:e100:fd30:8af7:2d6a:cbb1] has quit [Quit: ZNC 1.6.6+deb1ubuntu0.1 - http://znc.in]
07:28 -!- provoostenator [~vwDZ2BYsc@2a05:d014:5f:e100:fd30:8af7:2d6a:cbb1] has joined #bitcoin-core-dev
07:28 -!- jonatack [b84af09c@gateway/web/freenode/ip.184.74.240.156] has joined #bitcoin-core-dev
07:30 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev
07:34 -!- promag_ [~promag@bl16-114-47.dsl.telepac.pt] has joined #bitcoin-core-dev
07:34 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev
07:37 -!- PastaPasta [~PastaPast@2601:244:8400:54ad:1425:5698:91af:b9c4] has joined #bitcoin-core-dev
07:38 -!- promag_ [~promag@bl16-114-47.dsl.telepac.pt] has quit [Ping timeout: 268 seconds]
07:40 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has joined #bitcoin-core-dev
07:40 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection]
07:46 -!- pinheadmz [~matthewzi@c-73-92-181-51.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
07:50 -!- d_t [~dt@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
07:50 < phantomcircuit> kallewoof, there's a pr with comments https://github.com/bitcoin/bitcoin/pull/7663
07:56 < kallewoof> @phantomcircuit thanks!
07:58 -!- shigeya [~shigeya@2001:19f0:7001:3486:5400:1ff:fe90:4da6] has quit [Ping timeout: 252 seconds]
07:59 < phantomcircuit> kallewoof, you can get to those from the commit btw
07:59 < kallewoof> how?
07:59 < kallewoof> OH.
07:59 < kallewoof> doh. thanks.
07:59 < phantomcircuit> it's right above the author
07:59 < phantomcircuit> yeah i only noticed that recently
08:00 -!- hds [~hds@185.59.221.95] has quit []
08:01 -!- bralyclow01 [~bralyclow@unaffiliated/bralyclow] has quit [Remote host closed the connection]
08:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
08:01 < bitcoin-git> [bitcoin] promag opened pull request #16261: gui: Refactor OpenWalletActivity (master...2019-06-refactor-open-wallet) https://github.com/bitcoin/bitcoin/pull/16261
08:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
08:02 -!- bralyclow [~bralyclow@unaffiliated/bralyclow] has joined #bitcoin-core-dev
08:03 -!- shigeya [~shigeya@202.182.116.58] has joined #bitcoin-core-dev
08:04 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has quit [Ping timeout: 246 seconds]
08:04 -!- StopAndDecrypt [~StopAndDe@107.181.189.41] has joined #bitcoin-core-dev
08:04 < kallewoof> phantomcircuit: unfortunately the PR doesnt give me any more clues as to why it only uses 16 out of 32 bits of the nonce...
08:04 -!- StopAndDecrypt [~StopAndDe@107.181.189.41] has quit [Changing host]
08:04 -!- StopAndDecrypt [~StopAndDe@unaffiliated/stopanddecrypt] has joined #bitcoin-core-dev
08:07 -!- bralyclow [~bralyclow@unaffiliated/bralyclow] has quit [Ping timeout: 272 seconds]
08:07 < phantomcircuit> kallewoof, well it's just the inner loop
08:08 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
08:08 < phantomcircuit> yeah actually not sure about that one
08:10 < kallewoof> I think the idea was to make it run 65535 times and then loop back and then run another 65535 times and then if it ran out of the nonce it would inccrement the extra nonce, but thats not what its doing at all.
08:15 -!- aseem [~aseem@38.88.150.114] has quit [Quit: aseem]
08:21 -!- aseem [~aseem@38.88.150.114] has joined #bitcoin-core-dev
08:23 -!- rex4539 [~rex4539@2a02:587:3b04:6500:9103:361a:4a2b:4a36] has joined #bitcoin-core-dev
08:34 -!- pinheadmz [~matthewzi@208.69.41.101] has joined #bitcoin-core-dev
08:43 -!- nyuszika7h1 [~nyuszika7@185.5.172.148] has joined #bitcoin-core-dev
09:03 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 244 seconds]
09:06 -!- bralyclow [~bralyclow@unaffiliated/bralyclow] has joined #bitcoin-core-dev
09:11 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
09:11 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
09:12 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 258 seconds]
09:12 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 258 seconds]
09:15 -!- aseem [~aseem@38.88.150.114] has quit [Quit: aseem]
09:16 -!- bralyclow [~bralyclow@unaffiliated/bralyclow] has quit [Remote host closed the connection]
09:17 -!- bralyclow [~bralyclow@unaffiliated/bralyclow] has joined #bitcoin-core-dev
09:17 -!- d_t [~dt@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev
09:18 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
09:19 -!- rex4539 [~rex4539@2a02:587:3b04:6500:9103:361a:4a2b:4a36] has quit [Quit: rex4539]
09:20 -!- rex4539 [~rex4539@2a02:587:3b04:6500:e443:857d:7673:3e6c] has joined #bitcoin-core-dev
09:20 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
09:21 -!- bralyclow [~bralyclow@unaffiliated/bralyclow] has quit [Ping timeout: 245 seconds]
09:22 -!- kljasdfvv [~flack@p200300D46F2D62008981703559C3476E.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!]
09:23 -!- aseem [~aseem@38.88.150.114] has joined #bitcoin-core-dev
09:24 -!- rex4539 [~rex4539@2a02:587:3b04:6500:e443:857d:7673:3e6c] has quit [Client Quit]
09:33 -!- brianhoffman [~brianhoff@pool-173-66-215-91.washdc.fios.verizon.net] has joined #bitcoin-core-dev
09:41 < phantomcircuit> kallewoof, i mean im sure it doesn't matter at least
09:42 < kallewoof> why not?
09:42 -!- TheRec [~toto@drupal.org/user/146860/view] has quit []
09:45 < phantomcircuit> kallewoof, the inner loop is doing all of the hashing for the block again anyways
09:45 < phantomcircuit> so changing the extra nonce value even every loop wouldn't make it any slower
09:46 < kallewoof> you lose 16 bits worth of nonce space though
09:46 < phantomcircuit> so what
09:47 < phantomcircuit> that's not even a vaguely efficient loop regardless
09:47 < kallewoof> it doesnt matter for regtest, or other trivially mineable nets, no. i am having issues with signet though cause i have to actually re-create signatures every time you run out of nonces. having 32 bits intead of 16 would make things a lot less grumpifying.
09:48 < sipa> kallewoof: the code for the generate RPC is designed for simplicity, not efficiency
09:49 < kallewoof> sipa: yeah, just wondering if that 16 bit cap was for a reason or if it was just arbitrary
09:51 -!- scoop [~scoop@205.178.77.52] has quit [Remote host closed the connection]
09:51 < phantomcircuit> sipa, wait wouldn't that be a hard stop at the inner loop limit instead of at the nmaxtries?
09:52 < phantomcircuit> actually nvm im dumb
09:53 < phantomcircuit> it should be a uint32_t though 
09:53  * phantomcircuit runs
09:58 -!- Emcy_ [~Emcy@unaffiliated/emcy] has quit [Ping timeout: 248 seconds]
10:01 < phantomcircuit> kallewoof, i cant measure a performance difference between the loop stopping at 16 vs 32 bits searched
10:01 < phantomcircuit> takes about 1 minute to generate 1000 blocks on a new regtest chain either way
10:02 < phantomcircuit> (sorry 10000)
10:02 < kallewoof> phantomcircuit: thats not the point. in signets case i have to actually ask every signer to resign whenever we run out of nonce space. i can use custom mining software but that seems overkill for a test network
10:03 < kallewoof> 65535 combos vs 4294967296 makes a big difference when you have to generate signatures and stuff. esp if you are doing multi-sig with peers all over the place.
10:04 < phantomcircuit> kallewoof, i don't see any reason not to make the  search space 32 bits
10:04 < kallewoof> great! me neither. :)
10:05 < achow101> meshcollider: do you think #15588 is mergable? It's a pretty simple change
10:05 < gribble> https://github.com/bitcoin/bitcoin/issues/15588 | Log the actual wallet file version and no longer publicly expose the "version" record by achow101 · Pull Request #15588 · bitcoin/bitcoin · GitHub
10:05 < phantomcircuit> actually i dont see any reason for the inner loop check at all
10:07 < phantomcircuit> kallewoof, actually i see why, the ShutdownRequested() check in the loop
10:07 < phantomcircuit> only gets called once per search of the nonce space
10:07 < kallewoof> Yeah, that seems to be the only reason.
10:08 < kallewoof> And thats  what I noticed when I upped it to 0xffffffff.. I couldnt actually ^C without waiting for the entire 32 bits to iterate through.
10:09 < phantomcircuit> on x86 it should be cheap enough to check that every inner loop
10:11 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 272 seconds]
10:13 < sipa> this was before we had atomic variables
10:14 < phantomcircuit> sipa, yeah no criticism from me there
10:15 < phantomcircuit> makes perfect sense this is how you did it
10:15 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!]
10:19 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev
10:20 -!- darosior [6dbe8dc1@gateway/web/freenode/ip.109.190.141.193] has quit [Quit: Page closed]
10:21 -!- bralyclow [~bralyclow@unaffiliated/bralyclow] has joined #bitcoin-core-dev
10:21 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
10:26 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds]
10:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:28 < bitcoin-git> [bitcoin] pstratem opened pull request #16262: Slightly simplify the mining loop. (master...2019-06-21-generateblocks) https://github.com/bitcoin/bitcoin/pull/16262
10:28 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:29 -!- PastaPasta [~PastaPast@2601:244:8400:54ad:1425:5698:91af:b9c4] has quit [Ping timeout: 252 seconds]
10:29 < phantomcircuit> i help
10:30 < kallewoof> i did something more complex. your solution is better.
10:32 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev
10:32 -!- scoop [~scoop@205.178.77.52] has quit [Remote host closed the connection]
10:34 -!- surja795 [~sourabh@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev
10:37 < promag> Can I have #16261 in HP?
10:37 < gribble> https://github.com/bitcoin/bitcoin/issues/16261 | gui: Refactor OpenWalletActivity by promag · Pull Request #16261 · bitcoin/bitcoin · GitHub
10:37 < promag> achow101: FYI, if you rebase with that you'll have a couple of trivial conflicts
10:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:42 < bitcoin-git> [bitcoin] hebasto opened pull request #16263: qt: Use qInfo() if no error occurs (master...20190621-qInfo) https://github.com/bitcoin/bitcoin/pull/16263
10:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:49 -!- itsiku [~itsiku@abelohost-34.207.207.185.dedicated-ip.abelons.com] has quit [Ping timeout: 248 seconds]
10:54 -!- bralyclow [~bralyclow@unaffiliated/bralyclow] has quit [Ping timeout: 248 seconds]
10:54 -!- TheRec [~toto@84-72-172-174.dclient.hispeed.ch] has joined #bitcoin-core-dev
10:54 -!- TheRec [~toto@84-72-172-174.dclient.hispeed.ch] has quit [Changing host]
10:54 -!- TheRec [~toto@drupal.org/user/146860/view] has joined #bitcoin-core-dev
10:56 -!- scoop [~scoop@4.34.68.225] has joined #bitcoin-core-dev
11:00 -!- nyuszika7h1 [~nyuszika7@185.5.172.148] has quit []
11:00 -!- scoop [~scoop@4.34.68.225] has quit [Ping timeout: 244 seconds]
11:09 -!- scoop [~scoop@4.34.68.225] has joined #bitcoin-core-dev
11:10 -!- pabelanger1 [~pabelange@178.162.204.238] has joined #bitcoin-core-dev
11:15 -!- surja795 [~sourabh@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Ping timeout: 245 seconds]
11:16 -!- aseem [~aseem@38.88.150.114] has quit [Quit: aseem]
11:17 -!- aseem [~aseem@38.88.150.114] has joined #bitcoin-core-dev
11:18 -!- scoop [~scoop@4.34.68.225] has quit [Remote host closed the connection]
11:20 -!- scoop [~scoop@4.34.68.225] has joined #bitcoin-core-dev
11:20 -!- bralyclow [~bralyclow@unaffiliated/bralyclow] has joined #bitcoin-core-dev
11:20 -!- rex4539 [~rex4539@ppp-2-84-168-248.home.otenet.gr] has joined #bitcoin-core-dev
11:22 -!- scoop [~scoop@4.34.68.225] has quit [Remote host closed the connection]
11:22 -!- scoop [~scoop@4.34.68.225] has joined #bitcoin-core-dev
11:26 -!- lightlike [~lightlike@2001:16b8:5759:5f00:7009:df4d:a237:138e] has quit [Quit: Leaving]
11:26 -!- scoop [~scoop@4.34.68.225] has quit [Remote host closed the connection]
11:27 -!- scoop [~scoop@4.34.68.225] has joined #bitcoin-core-dev
11:32 < sipa> if there is a wallet meeting today, i'll miss it (meeting with github)
11:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
11:40 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #16264: policy: Add experimental -mempoolreplacement=full (off by default) (master...1906-policyFullRbf) https://github.com/bitcoin/bitcoin/pull/16264
11:40 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
11:42 -!- bralyclow [~bralyclow@unaffiliated/bralyclow] has quit [Remote host closed the connection]
11:47 -!- bralyclow [~bralyclow@unaffiliated/bralyclow] has joined #bitcoin-core-dev
11:52 -!- bralyclow [~bralyclow@unaffiliated/bralyclow] has quit [Ping timeout: 245 seconds]
11:55 -!- scoop [~scoop@4.34.68.225] has quit [Remote host closed the connection]
11:56 -!- scoop [~scoop@4.34.68.225] has joined #bitcoin-core-dev
11:56 -!- scoop [~scoop@4.34.68.225] has quit [Remote host closed the connection]
11:57 -!- scoop [~scoop@4.34.68.225] has joined #bitcoin-core-dev
12:00 < achow101> wallet meeting?
12:00 < meshcollider> #startmeeting
12:00 < lightningbot> Meeting started Fri Jun 21 19:00:21 2019 UTC.  The chair is meshcollider. Information about MeetBot at http://wiki.debian.org/MeetBot.
12:00 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic.
12:00 < meshcollider> #bitcoin-core-dev Wallet Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky
12:01 < kanzure> hi
12:01 < achow101> hi
12:02 < achow101> something I mentioned yesterday that we could discuss here: "I've been working on implementing the scriptpubkeymanager  and I noticed a bunch of things related to key generation rely on the wallet version and wallet flags. Thoughts on how to handle those without introducing a circular dependency?"
12:03 < achow101> sipa's suggestion was to have flags and version be part of the constructors for SPKmanagers, but these things get updated during key generation and imports
12:03 < achow101> I tried having the spkmanager write out the updates to the wallet file, but then the parent cwallet instance wouldn't know about the flag changes. it also felt like a layer violation
12:03 < achow101> any thoughts on that?
12:04 < meshcollider> #topic scriptpubkeymanager wallet flags (achow101)
12:05 < kanzure> managers are assigned a key, or managers make keys?
12:06 < achow101> managers make keys
12:06 < meshcollider> Can the wallet pass a pointer on construction instead? 
12:07 < achow101> yes, but locks..
12:07 < achow101> IIRC cs_wallet needs to be locked to modify flags but spkmanagers won't have access to cs_wallet
12:09 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 245 seconds]
12:09 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
12:09 < achow101> FWIW all of the wallet flags are things that spkmanagers care about, not the wallet. so maybe it does make sense to just have the wallet's flag stuff call through to the spkmanager's?
12:09 < meshcollider> Hmm, pass a callback function down from the wallet then?
12:09 -!- surja795 [~sourabh@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev
12:10 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 258 seconds]
12:10 < instagibbs> which things/flags get updated on import, just to job my memory
12:10 < meshcollider> Which SPKManager would provide the flags then
12:11 < achow101> instagibbs: WALLET_FLAG_BLANK_WALLET changes on import and key generation. WALLET_FLAG_KEY_ORIGIN_METADATA can change on load. WALLET_FLAG_DISABLE_PRIVATE_KEYS is checked before keys are generated
12:11 < achow101> meshcollider: I think they would all have the same flags, so it doesn't matter. but I guess there's an update problem with that too..
12:12 < achow101> the only flag that SPKManagers won't use is WALLET_FLAG_AVOID_REUSE
12:12 -!- infernix [nix@unaffiliated/infernix] has quit [Ping timeout: 246 seconds]
12:13 < achow101> my initial thought was to have each spkmanager also store a pointer to it's parent cwallet, but that's circular
12:14 < meshcollider> I guess BLANK_ and KEY_ORIGIN_ can be per-spkmanager and the wallet can itetate over them all with OR
12:14 < meshcollider> Iterate*
12:15 < meshcollider> Whereas DISABLE_PRIV doesn't change does it
12:15 < achow101> it doesn't
12:15 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
12:17 -!- justan0theruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
12:17 < meshcollider> Am I right in thinking these flags only ever get set, never reset
12:17 < meshcollider> So you can just OR them all
12:17 < achow101> yeah
12:17 < meshcollider> bitwise
12:17 < achow101> so should there be a new wallet record for spkmanager flags?
12:19 < achow101> I don't think that approach will really work though since there won't necessarily be a way to uniquely identify spkmanagers
12:19 < achow101> the whole loading part is kind of an issue
12:19 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Disconnected by services]
12:19 -!- justan0theruser is now known as justanotheruser
12:21 < meshcollider> Just because one SPKManager changes a flag doesn't mean they all need to update their flags do they? It doesn't matter if they all get the same flags at reload?
12:21 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev
12:21 < meshcollider> As long as whichever one updates can write it to the wallet file
12:23 < achow101> I think so?
12:27 -!- bralyclow [~bralyclow@unaffiliated/bralyclow] has joined #bitcoin-core-dev
12:28 < achow101> so i guess the conclusion is that spkmanagers will handle the storage of BLANK, KEY_ORIGIN, an DISABLE_PRIV flags and CWallet handles the storage of AVOID_REUSE
12:29 < meshcollider> seems sensible 
12:29 < achow101> i can foresee some concurrency issues with this
12:30 < meshcollider> Hmm I don't really see why there needs to be concurrency issues if they're not being used to communicate with each other at runtime
12:32 < meshcollider> Are there any other topics or is this the only one? Just so we aren't holding up the meeting if we continue discussing this
12:32 < meshcollider> Doesn't seem like attendance is very high today so I assume this is it :)
12:33 < achow101> the flags between cwallet and each spkmanager can be out of sync, so the update of flags on one object can undo an update from another one
12:34 < meshcollider> But like I said earlier, isn't each flag only one-way
12:34 < achow101> e.g. cwallet has BLANK set. spkmanager unsets BLANK because a seed is set so it writes that to the file. CWallet still has BLANK set. it updates the flags because AVOID_REUSE is changed so now the old BLANK is written back to the wallet
12:35 < achow101> not so much concurrency than not updating objects i suppose
12:36 < meshcollider> CWallet wouldn't store BLANK anyway
12:36 < meshcollider> If it needs to know blank, it would ask the spkmanagers 
12:36 -!- astro_ [~astro@gateway/tor-sasl/astro] has quit [Remote host closed the connection]
12:36 < achow101> yeah, but the wallet flags record is just a bitfield. it can't update it without updating the whole thing
12:37 -!- astro [~astro@gateway/tor-sasl/astro] has joined #bitcoin-core-dev
12:37 < achow101> so it needs to know all flags in effect
12:39 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 245 seconds]
12:40 -!- scoop [~scoop@4.34.68.225] has quit [Remote host closed the connection]
12:40 -!- scoop [~scoop@4.34.68.225] has joined #bitcoin-core-dev
12:41 < achow101> maybe function callbacks are the best option
12:41 -!- rex4539 [~rex4539@ppp-2-84-168-248.home.otenet.gr] has quit [Quit: rex4539]
12:43 < meshcollider> It seems like it might be, or can you use the built in atomic stuff to avoid locks
12:44 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
12:44 -!- scoop [~scoop@4.34.68.225] has quit [Ping timeout: 246 seconds]
12:45 < achow101> i'll try it out
12:45 < meshcollider> Alright
12:45 < meshcollider> Yeah I don't see a particularly clean solution otherwise
12:46 < meshcollider> Ok let's end the meeting there then, too many people away today
12:46 < meshcollider> #endmeeting
12:46 < lightningbot> Meeting ended Fri Jun 21 19:46:24 2019 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)
12:46 < lightningbot> Minutes:        http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-06-21-19.00.html
12:46 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-06-21-19.00.txt
12:46 < lightningbot> Log:            http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-06-21-19.00.log.html
12:46 < achow101> this refactor has turned out to be much harder than I thought it would be
12:46 < achow101> good luck reviewing it
12:49 -!- aseem [~aseem@38.88.150.114] has quit [Quit: aseem]
12:50 -!- jarthur_ [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
12:50 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
12:54 -!- aseem [~aseem@38.88.150.114] has joined #bitcoin-core-dev
12:54 -!- jarthur [~jarthur@207.114.244.5] has quit [Ping timeout: 268 seconds]
12:57 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-vjvobwreieupkelg] has quit [Quit: Connection closed for inactivity]
12:58 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.5]
13:00 -!- bralyclow [~bralyclow@unaffiliated/bralyclow] has quit [Ping timeout: 268 seconds]
13:04 -!- scoop [~scoop@204.62.118.244] has joined #bitcoin-core-dev
13:09 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
13:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:13 < bitcoin-git> [bitcoin] asood123 opened pull request #16265: Update check disk space in bitcoind (master...patch-15813) https://github.com/bitcoin/bitcoin/pull/16265
13:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:15 -!- laptop500 [~laptop@host86-128-184-5.range86-128.btcentralplus.com] has quit [Ping timeout: 245 seconds]
13:19 -!- scoop [~scoop@204.62.118.244] has quit [Remote host closed the connection]
13:21 -!- paracyst_ [paracyst@unaffiliated/paracyst] has quit [Ping timeout: 246 seconds]
13:22 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
13:28 -!- paracyst [paracyst@unaffiliated/paracyst] has joined #bitcoin-core-dev
13:30 -!- surja795 [~sourabh@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Ping timeout: 258 seconds]
13:31 -!- scoop [~scoop@204.62.118.244] has joined #bitcoin-core-dev
13:34 -!- paracyst [paracyst@unaffiliated/paracyst] has quit [Ping timeout: 272 seconds]
13:35 -!- scoop [~scoop@204.62.118.244] has quit [Ping timeout: 248 seconds]
13:36 -!- infernix [nix@unaffiliated/infernix] has joined #bitcoin-core-dev
13:56 -!- paracyst [paracyst@unaffiliated/paracyst] has joined #bitcoin-core-dev
13:56 -!- jarthur_ [~jarthur@207.114.244.5] has quit [Remote host closed the connection]
13:57 -!- spinza [~spin@102.132.245.16] has quit [Quit: Coyote finally caught up with me...]
13:57 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
14:00 -!- pabelanger1 [~pabelange@178.162.204.238] has quit []
14:00 -!- surja795 [~sourabh@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev
14:01 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
14:02 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
14:02 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 272 seconds]
14:02 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 272 seconds]
14:06 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev
14:08 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
14:20 -!- k0da [~k0da@141.98.101.133] has joined #bitcoin-core-dev
14:21 -!- emilengler [~emilengle@unaffiliated/emilengler] has quit [Remote host closed the connection]
14:23 -!- emilengler [~emilengle@unaffiliated/emilengler] has joined #bitcoin-core-dev
14:26 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 248 seconds]
14:27 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection]
14:29 < gwillen> so I just ran into an issue (twice) where I broke one of the python tests in a confusing way with a typo
14:29 < gwillen> and ended up accidentally reusing an intermediate from a testcase in a subsequent test case without noticing it
14:29 < gwillen> my friend the python expert strongly recommends that the test cases should be separate functions as the best way to avoid this kind of issue, which doesn't seem crazy to me
14:29 < gwillen> but of course, it seems like most or all the tests are written in this style
14:30 < gwillen> so I'm curious what people think about that
14:32 < gwillen> the failure mode where one accidentally reuses an intermediate from a previous test case is EXTREMELY mystifying and hard to diagnose
14:32 -!- aseem [~aseem@38.88.150.114] has quit [Quit: aseem]
14:33 < gwillen> and it's easy to induce when adding/removing or commenting or uncommenting lines, given that each testcase uses most of the same names for intermediates
14:33 < sipa> gwillen: my favorite *ahum* bug i ever had in python was when i had two classes with the same name, and the second just overwrote the first one, without warning
14:33 < gwillen> oh geez
14:33 < sipa> making me mystified why some obvioisly broken code in the first one wasn't causing problems
14:34 < gwillen> yeah.
14:34 < sipa> even google's internal linter at the time did not catch this
14:34 < gwillen> when I suspect something like that my next move is always to break something VERY blatant in the code I'm not sure is running, like make it throw on the first line
14:34 < sipa> yeah
14:35 < sipa> anyway, your suggestions sounds very reasonable
14:35 < sipa> but i'm not a python person myself
14:36 < gwillen> my friend is one of the maintainers of mypy, and one of the Python People at dropbox
14:36 < gwillen> so I take his suggestions on python style seriously :-)
14:36 < sipa> ping MarcoFalke ^
14:38 < gwillen> (he is also the author of "Peer-to-Peer Affine Commitment using Bitcoin", which describes the "Typecoin" system, and was almost named "Massively Multiplayer Online Linear Logic")
14:46 < sipa> lol
14:46 < sipa> mmoll
14:52 -!- surja795 [~sourabh@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Ping timeout: 246 seconds]
14:54 -!- surja795 [~sourabh@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev
14:57 -!- bralyclow [~bralyclow@unaffiliated/bralyclow] has joined #bitcoin-core-dev
15:01 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds]
15:05 < luke-jr> sdaftuar: ping
15:12 -!- spinza [~spin@102.132.245.16] has quit [Quit: Coyote finally caught up with me...]
15:15 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
15:16 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Read error: Connection reset by peer]
15:16 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
15:16 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Read error: Connection reset by peer]
15:17 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
15:21 -!- shesek [~shesek@5.22.134.185] has joined #bitcoin-core-dev
15:21 -!- shesek [~shesek@5.22.134.185] has quit [Changing host]
15:21 -!- shesek [~shesek@unaffiliated/shesek] has joined #bitcoin-core-dev
15:23 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
15:24 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 245 seconds]
15:24 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev
15:25 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 272 seconds]
15:26 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection]
15:26 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev
15:29 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit [Remote host closed the connection]
15:30 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
15:30 -!- bralyclow [~bralyclow@unaffiliated/bralyclow] has quit [Ping timeout: 245 seconds]
15:43 -!- Wasyl [~WasylOne@89-64-41-98.dynamic.chello.pl] has joined #bitcoin-core-dev
15:47 -!- Wasyl [~WasylOne@89-64-41-98.dynamic.chello.pl] has quit [Client Quit]
15:57 -!- bralyclow [~bralyclow@unaffiliated/bralyclow] has joined #bitcoin-core-dev
16:04 -!- surja795 [~sourabh@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Ping timeout: 248 seconds]
16:07 -!- captjakk [~captjakk@63-238-229-186.dia.static.qwest.net] has quit [Ping timeout: 272 seconds]
16:09 -!- jarthur [~jarthur@207.114.244.5] has quit []
16:18 -!- jtimon [~quassel@205.201.35.37.dynamic.jazztel.es] has joined #bitcoin-core-dev
16:19 -!- emilengler [~emilengle@unaffiliated/emilengler] has quit [Quit: Leaving]
16:20 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 248 seconds]
16:25 -!- owowo [~ovovo@179.43.152.50] has joined #bitcoin-core-dev
16:25 -!- owowo [~ovovo@179.43.152.50] has quit [Changing host]
16:25 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
16:30 -!- bralyclow [~bralyclow@unaffiliated/bralyclow] has quit [Ping timeout: 258 seconds]
16:35 -!- spinza [~spin@102.132.245.16] has quit [Quit: Coyote finally caught up with me...]
16:35 -!- bralyclow [~bralyclow@unaffiliated/bralyclow] has joined #bitcoin-core-dev
16:42 -!- reallll [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
16:42 < jtimon> In regtest, I'm sending coins from bitcoin core to lightningd's newaddr but it doesn't seem to be receiving anything, I'm generating more blocks  on the core node and calling dev_rescan_outputs on the lightning node, but still not seeing anything in listfunds and fundchannel says "Cannot afford transaction"
16:42 < jtimon> what may I be doing wrong?
16:43 < jtimon> sorry, wrong channel
16:43 -!- spinza [~spin@102.132.245.16] has joined #bitcoin-core-dev
16:43 -!- jonatack [b84af09c@gateway/web/freenode/ip.184.74.240.156] has quit [Ping timeout: 256 seconds]
16:45 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 268 seconds]
16:53 -!- reallll is now known as belcher
16:57 -!- Skirmant [~Skirmant@78-62-14-181.static.zebra.lt] has joined #bitcoin-core-dev
17:00 -!- k0da [~k0da@141.98.101.133] has quit []
17:03 -!- Gunni1 [~Gunni@141.98.102.243] has joined #bitcoin-core-dev
17:05 -!- qwebirc303118 [6d9f3fe6@gateway/web/freenode/ip.109.159.63.230] has quit [Ping timeout: 256 seconds]
17:07 -!- scoop [~scoop@205.178.77.52] has quit [Remote host closed the connection]
17:33 -!- bralyclow [~bralyclow@unaffiliated/bralyclow] has quit [Remote host closed the connection]
17:33 -!- bralyclow [~bralyclow@unaffiliated/bralyclow] has joined #bitcoin-core-dev
17:38 -!- bralyclow [~bralyclow@unaffiliated/bralyclow] has quit [Ping timeout: 246 seconds]
17:44 -!- hugohn [~textual@45.56.153.216] has joined #bitcoin-core-dev
17:50 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
17:51 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 258 seconds]
17:56 -!- owowo [~ovovo@s91904424.blix.com] has joined #bitcoin-core-dev
17:56 -!- owowo [~ovovo@s91904424.blix.com] has quit [Changing host]
17:56 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
17:57 -!- pinheadmz [~matthewzi@208.69.41.101] has quit [Quit: pinheadmz]
18:05 -!- hugohn [~textual@45.56.153.216] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
18:10 -!- bralyclow [~bralyclow@unaffiliated/bralyclow] has joined #bitcoin-core-dev
18:33 -!- pinheadmz [~matthewzi@c-73-92-181-51.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
18:36 -!- aseem [~aseem@pool-108-46-250-150.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
18:42 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev
18:43 -!- bralyclow [~bralyclow@unaffiliated/bralyclow] has quit [Ping timeout: 268 seconds]
18:52 -!- bralyclow [~bralyclow@unaffiliated/bralyclow] has joined #bitcoin-core-dev
18:52 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
18:52 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 245 seconds]
18:52 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 245 seconds]
18:57 -!- pinheadmz [~matthewzi@c-73-92-181-51.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
18:57 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 246 seconds]
18:58 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
18:58 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 245 seconds]
19:01 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
19:07 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev
19:12 -!- scoop [~scoop@205.178.77.52] has quit [Ping timeout: 248 seconds]
19:21 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection]
19:22 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
19:27 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Ping timeout: 258 seconds]
19:32 -!- hugohn [~textual@45.56.153.216] has joined #bitcoin-core-dev
19:34 -!- pinheadmz [~matthewzi@c-73-92-181-51.hsd1.ca.comcast.net] has joined #bitcoin-core-dev
19:35 -!- aseem [~aseem@pool-108-46-250-150.nycmny.fios.verizon.net] has quit [Quit: aseem]
19:36 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
19:36 -!- aseem [~aseem@pool-108-46-250-150.nycmny.fios.verizon.net] has joined #bitcoin-core-dev
19:37 -!- hugohn [~textual@45.56.153.216] has quit [Ping timeout: 258 seconds]
19:38 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection]
19:48 -!- aseem [~aseem@pool-108-46-250-150.nycmny.fios.verizon.net] has quit [Quit: aseem]
20:00 -!- Gunni1 [~Gunni@141.98.102.243] has quit []
20:04 -!- pinheadmz [~matthewzi@c-73-92-181-51.hsd1.ca.comcast.net] has quit [Quit: pinheadmz]
20:07 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 256 seconds]
20:18 -!- ddustin [~ddustin@unaffiliated/ddustin] has joined #bitcoin-core-dev
20:18 -!- survivor [~survivor@185.5.172.148] has joined #bitcoin-core-dev
20:31 -!- jtimon [~quassel@205.201.35.37.dynamic.jazztel.es] has quit [Ping timeout: 272 seconds]
20:36 -!- ddustin [~ddustin@unaffiliated/ddustin] has quit [Remote host closed the connection]
20:44 -!- profmac [~ProfMac@2001:470:1f0f:226:14e5:79f4:c95e:941f] has quit [Ping timeout: 250 seconds]
20:53 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.5]
20:58 -!- profmac [~ProfMac@2001:470:1f0f:226:3490:9e93:6e8f:7a58] has joined #bitcoin-core-dev
21:03 -!- dongcarl [sid321684@gateway/web/irccloud.com/x-srbckoimoogdprxd] has quit [Ping timeout: 250 seconds]
21:03 -!- Isthmus [sid302307@gateway/web/irccloud.com/x-sgvcvnpxxhmzpcul] has quit [Ping timeout: 252 seconds]
21:04 -!- Isthmus [sid302307@gateway/web/irccloud.com/x-idgebvetwmgfdiee] has joined #bitcoin-core-dev
21:06 -!- dongcarl [sid321684@gateway/web/irccloud.com/x-hvsmqlonwzlajlkw] has joined #bitcoin-core-dev
21:43 -!- d_t [~dt@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
21:51 -!- surja795 [~sourabh@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev
21:56 -!- surja795 [~sourabh@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Ping timeout: 248 seconds]
22:20 -!- infinitis [~infinitis@c-67-170-82-45.hsd1.wa.comcast.net] has joined #bitcoin-core-dev
22:22 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev
22:31 -!- surja795 [~sourabh@c-24-61-194-104.hsd1.ma.comcast.net] has joined #bitcoin-core-dev
22:33 -!- bralyclow [~bralyclow@unaffiliated/bralyclow] has quit [Remote host closed the connection]
22:34 -!- bralyclow [~bralyclow@unaffiliated/bralyclow] has joined #bitcoin-core-dev
22:37 -!- surja795 [~sourabh@c-24-61-194-104.hsd1.ma.comcast.net] has quit [Ping timeout: 268 seconds]
22:38 -!- spinza [~spin@102.132.245.16] has quit [Ping timeout: 268 seconds]
22:39 -!- bralyclow [~bralyclow@unaffiliated/bralyclow] has quit [Ping timeout: 245 seconds]
22:51 -!- teardown [~user@unaffiliated/mrush] has quit [Ping timeout: 245 seconds]
23:00 -!- survivor [~survivor@185.5.172.148] has quit []
23:00 -!- bralyclow [~bralyclow@unaffiliated/bralyclow] has joined #bitcoin-core-dev
23:09 -!- scoop [~scoop@205.178.77.52] has joined #bitcoin-core-dev
23:12 -!- oneark [uid254801@gateway/web/irccloud.com/x-ogtscuwiarwfjzuy] has joined #bitcoin-core-dev
23:14 -!- rafalcpp_ [~racalcppp@84-10-11-234.static.chello.pl] has joined #bitcoin-core-dev
23:14 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 245 seconds]
23:14 -!- rafalcpp [~racalcppp@84-10-11-234.static.chello.pl] has quit [Ping timeout: 245 seconds]
23:15 -!- ddrm [67784224@gateway/web/freenode/ip.103.120.66.36] has joined #bitcoin-core-dev
23:20 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
23:34 -!- phyll1s_work [~phyll1s_w@184.75.223.219] has joined #bitcoin-core-dev
23:53 < kallewoof> sipa: I may be slow, but I thought the coinbase transaction contained the witness commitment, so simply getting the hash of everything (including coinbase) should commit to witness commitment as well.
23:54 < sipa> kallewoof: yup, it does!
23:54 < sipa> you're right
23:55 < kallewoof> sipa: OK, then I should be fine without GetWitnessHash, as the witness data is already committed to then, right?
23:55 < sipa> yeah
23:55  * sipa zZzZ
23:55 < jb55> lol
23:56 -!- teardown [~user@unaffiliated/mrush] has joined #bitcoin-core-dev
23:56 < kallewoof> Thanks :) G'night!
23:57 -!- scoop [~scoop@205.178.77.52] has quit [Remote host closed the connection]
--- Log closed Sat Jun 22 00:00:49 2019