--- Log opened Fri Jul 26 00:00:21 2019
00:04 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
00:35 -!- potatoe_face [~potatoe_f@157.230.27.253] has joined #bitcoin-core-dev
00:36 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection]
00:37 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev
01:24 -!- jonatack [6dca67aa@109.202.103.170] has joined #bitcoin-core-dev
01:25 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
01:29 -!- kljasdfvv [~flack@p200300D46F0E7800153FCF3AC373C562.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
01:33 < jonasschnelli> elichai2: re https://github.com/drone/drone: what I wanted is a lightweight solution. I'm not a fan of docker and I think especially for a CI its not ideal (but I may be wrong).
01:42 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has joined #bitcoin-core-dev
01:43 -!- hex17or [~hex17or@HSI-KBW-091-089-197-016.hsi2.kabel-badenwuerttemberg.de] has quit [Quit: leaving]
01:44 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 245 seconds]
01:48 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
01:58 -!- justanotheruser [justanothe@gateway/vpn/nordvpn/justanotheruser] has quit [Ping timeout: 244 seconds]
02:00 -!- slewis [~slewis@141.98.101.133] has quit []
02:08 < wumpus> i'm really confused about #16386
02:08 < gribble> https://github.com/bitcoin/bitcoin/issues/16386 | depends: disable unused Qt features by fanquake · Pull Request #16386 · bitcoin/bitcoin · GitHub
02:09 < wumpus> i remember merging it yesterday but it shows that MarcoFalke did so
02:10 -!- Soligor [~soligor@unaffiliated/soligor] has quit [Remote host closed the connection]
02:14 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev
02:16 -!- matael1 [~matael@195.206.169.238] has joined #bitcoin-core-dev
02:18 -!- Soligor [~soligor@unaffiliated/soligor] has joined #bitcoin-core-dev
02:18 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
02:33 -!- vincenzopalazzo [~Vincent@host77-157-dynamic.104-80-r.retail.telecomitalia.it] has joined #bitcoin-core-dev
02:44 -!- Aaronvan_ [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev
02:47 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 246 seconds]
02:55 -!- kcalvina_ [~calvin@104.143.95.21] has quit [Remote host closed the connection]
03:06 < jonasschnelli> wumpus: where did it show that MarcoFalke did?
03:06 < jonasschnelli> "where does"
03:07 < jonasschnelli> I only see Drahts "needs rebase"  comments after the merge in the timeline
03:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
03:19 < bitcoin-git> [bitcoin] jonatack opened pull request #16467: rpc: sendrawtransaction help privacy note (master...sendrawtransaction-privacy-note) https://github.com/bitcoin/bitcoin/pull/16467
03:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
03:20 < jonatack> is it just me, or did one of the last dozen commits on master break building locally on debian?
03:21 < jonatack> will try to isolate which one
03:25 < jonatack> ah nvm it's building again
03:27 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has quit [Remote host closed the connection]
03:28 < jonasschnelli> jonatack: works on my end
03:31 < jonatack> jonasschnelli: thank you
03:45 -!- gribble [~gribble@unaffiliated/nanotube/bot/gribble] has joined #bitcoin-core-dev
03:58 -!- Aaronvan_ is now known as AaronvanW
04:04 -!- timothy [~tredaelli@redhat/timothy] has quit [Quit: Konversation terminated!]
04:10 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has quit [Ping timeout: 260 seconds]
04:27 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 246 seconds]
04:37 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev
04:49 -!- lightlike [~lightlike@2001:16b8:574c:700:b4e5:e02a:21d8:b007] has joined #bitcoin-core-dev
04:49 -!- dgfhdfg [~hgfdfgh@77.243.22.21] has joined #bitcoin-core-dev
04:59 -!- victorSN [~victorSN@unaffiliated/victorsn] has quit [Read error: Connection reset by peer]
04:59 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has quit [Read error: Connection reset by peer]
05:00 -!- matael1 [~matael@195.206.169.238] has quit []
05:00 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has joined #bitcoin-core-dev
05:00 -!- victorSN [~victorSN@unaffiliated/victorsn] has joined #bitcoin-core-dev
05:04 -!- flukiluke1 [~flukiluke@192.145.126.244] has joined #bitcoin-core-dev
05:07 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has quit [Ping timeout: 268 seconds]
05:07 -!- victorSN [~victorSN@unaffiliated/victorsn] has quit [Ping timeout: 272 seconds]
05:10 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has joined #bitcoin-core-dev
05:11 -!- victorSN [~victorSN@unaffiliated/victorsn] has joined #bitcoin-core-dev
05:58 -!- vincenzopalazzo [~Vincent@host77-157-dynamic.104-80-r.retail.telecomitalia.it] has left #bitcoin-core-dev []
06:13 -!- ccdle12 [~ccdle12@cpc139350-aztw33-2-0-cust310.18-1.cable.virginm.net] has quit []
06:34 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-ilwtsqaqfyvnibqo] has joined #bitcoin-core-dev
06:49 < fanquake> wumpus: yes that confused me as well. It’d be good to get an explanation as to why/how the MarcoFalke merge message showed up in this channel.
06:50 -!- d_t [~dt@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev
06:50 < fanquake> Obviously you’d merged it first quite a while earlier, so I don’t understand how a merge message from a different user, on an already closed & merged PR has ended up posted here.
06:52 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has quit [Remote host closed the connection]
06:53 -!- davterra [~none@209.58.188.75] has joined #bitcoin-core-dev
06:55 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has joined #bitcoin-core-dev
07:02 -!- davterra [~none@209.58.188.75] has quit [Ping timeout: 258 seconds]
07:02 -!- davterra [~none@209.58.188.75] has joined #bitcoin-core-dev
07:03 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev
07:06 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/]
07:16 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Quit: laurentmt]
07:22 < cfields> jonasschnelli: sorry for missing the meeting yesterday. That looks great!
07:24 < cfields> I'm excited to catch up and play around.
07:24 -!- IGHOR [~quassel@93.178.216.72] has quit [Ping timeout: 258 seconds]
07:30 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has quit [Ping timeout: 248 seconds]
07:41 < wumpus> fanquake: i think the github API was messed up for tha tPR, also causing the bot to misbehave
07:44 < wumpus> this is the logging from the bot: https://0bin.net/paste/PeFZGajcOPfMmXV0#Dea0H42UViZiyCF86Pb2YspJma47s9NycgKX4FSspKS  it got a pull request closed event, which is strange so long after the actual merge, but anyhow, let's hope it was a fluke
07:46 < jonasschnelli> cfields: if you want to work on a better per-package dependency cache... I'm all in.
07:48 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has joined #bitcoin-core-dev
07:48 < cfields> jonasschnelli: sure, happy to lend a hand. What do you have in mind?
07:50 < cfields> jonasschnelli: fyi, the package names are deterministic and shouldn't ever collide. So the easiest option is to simply never delete them. Then, if it exists when a client requests it, it's guaranteed to be what they wanted.
07:50 -!- d_t [~dt@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
07:50 < jonasschnelli> for the CI, I guess it would be ideal to just cache all possible versions of packages to avoid rebuilding depends all the times when a package change in master
07:50 < jonasschnelli> although I might have a lack of understanding how the cache works
07:50 < cfields> jonasschnelli: see ^^, then :)
07:51 < jonasschnelli> I see
07:51 < cfields> jonasschnelli: we could just add a NO_CLEANUP option, so that depends doesn't delete as it goes. It would just leave old copies behind.
07:51 < cfields> Hmm, maybe I already did that? I certainly intended to at one point.
07:52 < cfields> I'll PR if not.
07:52 < jonasschnelli> thanks
07:53 < cfields> jonasschnelli: does that fix the problem you're talking about? I'm only pretty sure we're on the same page :)
07:53 < jonasschnelli> my head is almost exploding.. I need to dive into that once I have more time. I'll let you know it I see potential for further optimization
07:54 < cfields> Haha, no worries. I'll PR the option and we'll see if it ends up helping. I think it will.
07:58 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has joined #bitcoin-core-dev
08:00 -!- flukiluke1 [~flukiluke@192.145.126.244] has quit []
08:03 -!- kcalvinalvin [~calvin@210.222.15.191] has joined #bitcoin-core-dev
08:04 -!- CareBearemcho [~CareBeare@192.145.126.244] has joined #bitcoin-core-dev
08:09 -!- kcalvina_ [~calvin@104.143.95.18] has joined #bitcoin-core-dev
08:09 -!- CareBearemcho [~CareBeare@192.145.126.244] has quit [Ping timeout: 268 seconds]
08:12 -!- kcalvinalvin [~calvin@210.222.15.191] has quit [Ping timeout: 245 seconds]
08:13 -!- kcalvinalvin [~calvin@210.222.15.191] has joined #bitcoin-core-dev
08:15 -!- zivl [~zivl@unaffiliated/zivl] has quit [Ping timeout: 276 seconds]
08:15 -!- kcalvina_ [~calvin@104.143.95.18] has quit [Ping timeout: 268 seconds]
08:19 -!- aowi [~aowi@185.103.96.147] has joined #bitcoin-core-dev
08:20 -!- zivl [~zivl@unaffiliated/zivl] has joined #bitcoin-core-dev
08:24 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 248 seconds]
08:27 -!- lightningbot [~supybot@2400:8901::f03c:91ff:febb:bbc1] has quit [Remote host closed the connection]
08:28 -!- lightningbot [~supybot@2400:8901::f03c:91ff:febb:bbc1] has joined #bitcoin-core-dev
08:33 < phantomcircuit> there's a memory cliff for io, at 1GB im seeing 1000 tps reading the utxo set
08:33 < phantomcircuit> but at 4GB there's almost zero
08:34 < phantomcircuit> has anybody looked at the number of leveldb reads vs dbcache size?
08:41 -!- justanotheruser [justanothe@gateway/vpn/nordvpn/justanotheruser] has joined #bitcoin-core-dev
08:44 -!- emilengler [emilengler@gateway/vpn/privateinternetaccess/emilengler] has joined #bitcoin-core-dev
08:45 < cfields> jonasschnelli: I just added the option to not delete previous builds, and it works as intended, but it occurs to me that a malicious PR could simply disable the option.
08:45 < cfields> So I'm afraid it will actually need to be handled on the builder's side.
08:48 < cfields> jonasschnelli: basically, you want a filesystem where "rm -rf" of a certain directory is a no op.
08:49 < cfields> jonasschnelli: hmm, I think a chmod/chown after the build should do the trick.
08:53 < jonasschnelli> in the CI, a PR can only affect the PRs branch cache...
08:53 < jonasschnelli> and I guess one could do way more dangerous stuff
08:53 < jonasschnelli> at least bitcoinbuilds.org could exploited on PR level quite hard...
08:54 < jonasschnelli> I need to add some protection at some point
08:55 < jonasschnelli> if it builds a new branch (PR) for the first time, it copies over master depends built, builds depends and caches under the new branch
08:55 < jonasschnelli> next time the same PR gets built, it uses that cache
08:55 < jonasschnelli> master is unaffected
09:00 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 272 seconds]
09:05 < cfields> jonasschnelli: mmm, that's similar to what Travis does. It's rather non-ideal for taking advantage of depends, though :(
09:07 < cfields> jonasschnelli: let's discuss when you're less fried. I'll go ahead and push a branch with a few changes that I think would be helpful.
09:09 < jonasschnelli> thanks... its 37C here.
09:10 < sipa> jonasschnelli: jump in a lake
09:11 < fanquake> Or find a beach 🏄‍♂️
09:12 < jonasschnelli> there is no lake where I live... but the rhein... will jup in soon though!
09:12 < jonasschnelli> jump
09:12 < sipa> fanquake: i challenge you to find switzerland's coastline :)
09:13 < jonasschnelli> heh lol
09:13 < fanquake> sipa: hah yes, I guess the more viable cooling option is heading for the top of a very large mountain.
09:22 -!- kljasdfvv [~flack@p200300D46F0E7800153FCF3AC373C562.dip0.t-ipconnect.de] has quit [Quit: Konversation terminated!]
09:23 < provoostenator> What does GetDepthInMainChain do? And what is CMerkleTx? In context of #15713 where this is removed from SubmitMemoryPoolAndRelay (prev: RelayWalletTransaction).
09:23 < gribble> https://github.com/bitcoin/bitcoin/issues/15713 | refactor: Replace chain relayTransactions/submitMemoryPool by higher method by ariard · Pull Request #15713 · bitcoin/bitcoin · GitHub
09:34 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev
09:39 -!- dgfhdfg [~hgfdfgh@77.243.22.21] has quit [Ping timeout: 258 seconds]
09:44 -!- rex4539 [~rex4539@2a02:587:3514:c700:75b3:542e:84a9:197d] has joined #bitcoin-core-dev
10:16 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has quit [Ping timeout: 248 seconds]
10:17 -!- liberiga [~liberiga@gateway/tor-sasl/liberiga] has joined #bitcoin-core-dev
10:18 -!- luke-jr [~luke-jr@unaffiliated/luke-jr] has joined #bitcoin-core-dev
10:24 < cfields> jonasschnelli: Now that I've worked through it locally, I think there are a few easy changes to make on the builder side, no need to change depends. Ping me whenever you'd like to discuss.
10:24 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
10:25 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
10:26 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
10:26 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
10:29 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
10:29 < bitcoin-git> [bitcoin] promag opened pull request #16468: Exclude depends/Makefile in .gitignore (master...2019-07-gitignore) https://github.com/bitcoin/bitcoin/pull/16468
10:30 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
10:38 < promag> elichai2: re drone, I've used it, it's cool and all, but IIRC lacks support for parallel builds and caching
10:39 < elichai2> promag: caching isn't as easy as travis but you can set it up and parallel builds is definitely supported (though you need to set a env var for it) 
10:51 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev
10:52 -!- Emcy [~Emcy@unaffiliated/emcy] has quit [Remote host closed the connection]
10:58 < jonasschnelli> elichai2: can you tell docker to only use limited resources? Similar to a VM with X amount of cores and Y amount of ram?
10:59 < jonasschnelli> cfields; sounds good. Interested to hear...
10:59 < elichai2> jonasschnelli: it seems so: https://docs.docker.com/config/containers/resource_constraints/ (altough if you have a dedicated machine for that I don't see why you would want that)
11:00 -!- aowi [~aowi@185.103.96.147] has quit []
11:01 < jonasschnelli> elichai2: Good to know. I'm not an expert,... but I though limiting each build (that runs in parallel) by VM's memory and CPU may make sense for sanity reasons...
11:04 -!- theos1 [~theos@178.162.204.238] has joined #bitcoin-core-dev
11:05 < cfields> jonasschnelli: https://github.com/theuni/bitcoin/commits/depends-keep-cache
11:05 < cfields> The option is unsafe for public use, but illustrates the idea for testing.
11:07 < jonasschnelli> cfields: thanks. I see.
11:08 < jonasschnelli> How "more unsafe" is that than allowing to run arbitrary python/shell-scripts or even binaries in the build VM?
11:09 < cfields> jonasschnelli: it's unsafe in that when using that, you'd want a cache shared among all builders. Problem is that if any build removes the whole cache, that would remove the cache for all builders.
11:09 < cfields> So in reality you'd likely want to handle it with permissions changes before/after the builds.
11:10 < cfields> Or symliks, or mount options. I assume there are plenty of clever ways to handle it safely.
11:11 < jonasschnelli> cfields: is it possible somehow to make it "add only"?
11:12 < cfields> jonasschnelli: right, that's the goal. But it has to be done on the builder. Any changes to depends could be subverted by a malicious PR.
11:12 < jonasschnelli> (then eventually delete oldest package [or package with minimal hits] when cache size limit reached)
11:12 < cfields> Yup, exactly.
11:12 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Remote host closed the connection]
11:12 < jonasschnelli> I see
11:12 -!- michaelsdunn1 [~michaelsd@unaffiliated/michaelsdunn1] has quit []
11:14 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
11:17 -!- reallll [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev
11:20 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 268 seconds]
11:26 -!- dgfhdfg [~hgfdfgh@77.243.22.21] has joined #bitcoin-core-dev
11:38 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
11:40 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 258 seconds]
12:06 -!- MARKUS87 [1855eeb9@S0106905851cd15c1.vc.shawcable.net] has joined #bitcoin-core-dev
12:08 -!- MARKUS87 [1855eeb9@S0106905851cd15c1.vc.shawcable.net] has quit [Remote host closed the connection]
12:10 -!- owowo [~ovovo@unaffiliated/ovovo] has quit [Ping timeout: 272 seconds]
12:13 -!- lightlike [~lightlike@2001:16b8:574c:700:b4e5:e02a:21d8:b007] has quit [Ping timeout: 250 seconds]
12:15 -!- morcos [~morcos@gateway/tor-sasl/morcos] has quit [Remote host closed the connection]
12:15 -!- owowo [~ovovo@unaffiliated/ovovo] has joined #bitcoin-core-dev
12:15 -!- morcos [~morcos@gateway/tor-sasl/morcos] has joined #bitcoin-core-dev
12:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:20 < bitcoin-git> [bitcoin] MarcoFalke pushed 8 commits to master: https://github.com/bitcoin/bitcoin/compare/a54a12046e98...dbf4f3f86a8f
12:20 < bitcoin-git> bitcoin/master ab28e31 Andrew Chow: Change ImportScriptPubKeys' internal to apply_label
12:20 < bitcoin-git> bitcoin/master fae7a5b Andrew Chow: Log when an import is being skipped because we already have it
12:20 < bitcoin-git> bitcoin/master c6a8274 Andrew Chow: Have importprivkey use CWallet's ImportPrivKeys, ImportScripts, and Import...
12:20 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:21 < bitcoin-git> [bitcoin] MarcoFalke merged pull request #16301: Use CWallet::Import* functions in all import* RPCs (master...imports-use-cwallet-funcs) https://github.com/bitcoin/bitcoin/pull/16301
12:21 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
12:22 < MarcoFalke> > [09:49] <fanquake> wumpus: yes that confused me as well. It’d be good to get an explanation as to why/how the MarcoFalke merge message showed up in this channel.
12:22 < MarcoFalke> Just a GitHub bug
12:23 < MarcoFalke> I am glad we don't use GitHub for merges, considering how often they corrupted metadata or the git tree in the last couple of weeks
12:28 < MarcoFalke> people should start signing their ACKs *stares at everyone*
12:29 < achow101> but that takes so much more work
12:30 -!- lightlike [~lightlike@2001:16b8:574c:700:15d4:5a2e:5e46:7a0c] has joined #bitcoin-core-dev
12:31 -!- Emcy [~Emcy@unaffiliated/emcy] has joined #bitcoin-core-dev
12:31 < promag> (hides)
12:33 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection]
12:34 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev
12:34 < elichai2> achow101: should DescriptorImpl keep doing all the work for the deriving classes even when there's special work that needs to be done only for a specific desc? (i.e. I don't think you would want all of the taproot hashing/branching logic in `DescriptorImpl::ExpandHelper`, isn't it better that inheriting classes can override it? )
12:35 < achow101> probably, ask sipa, he wrote it
12:35 < elichai2> (like they override `IsSolvable` and `MakeScripts`, altough `MakeScripts` is a bad example because that's what `ExpandHelper` uses)
12:36 < sipa> expandhelper does all the work
12:36 < sipa> makescripts is the per-descriptor logic
12:36 -!- laurentmt [~Thunderbi@176.158.157.202] has joined #bitcoin-core-dev
12:37 < elichai2> I thought it would be better if the taproot descriptor kept the tree and expanded everything but i see that in the other cases you do all the work in `DescriptorImpl` and `ExpandHelper`, I'm just afraid that this function will blow up.
12:38 < elichai2> (so I guess `DescriptorImpl` will keep a unique_ptr to the tree and treat it like m_script_arg)
12:39 -!- laurentmt [~Thunderbi@176.158.157.202] has quit [Client Quit]
12:41 < sipa> elichai2: i guess the taproot descriptor impl should work pretty much like the p2sh/p2wsh ones?
12:41 < sipa> ah, i see
12:41 < elichai2> yeah, they do all the logic in the parent. 
12:42 < sipa> instead of m_script_arg you need something to store a tree
12:42 < elichai2> (parent = DescriptorImpl)
12:42 < elichai2> yes
12:42 < sipa> you can also just put that structurr in the tapprot specific one, i think
12:42 < elichai2> until now I implemented it in the taproot descriptor itself which inherits from DescriptorImpl
12:42 < sipa> if that's easier
12:43 < sipa> it's a bit of a weird design, iknow
12:43 < elichai2> but that I can't call MakeScripts on the leafs and I can't override ExpandHelper (without changing anything)
12:43 < elichai2> *but then
12:44 < elichai2> so either I make them public/virtual or I keep everything in the DescriptorImpl as it already is
12:44 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
12:46 < sipa> you could turn m_script_arg into a vector
12:47 < sipa> but you'd still need some place to storr tree structure information
12:47 < elichai2> yeah... and the base class can't access the deriving class data members. so I guess i'll keep everything in DescriptorImpl
12:48 -!- tryphe_ is now known as tryphe
12:48 < sipa> we may need to refactor stuff at some point
12:48 < elichai2> aren't you changing some of this logic with the miniscript code?
12:48 < sipa> not every descriptor will fit in the structure imposed by the current DescriptotImpl
12:49 < sipa> yeah, i was about to mention that
12:49 < elichai2> (waiting eagerly to see your changes :) )
12:49 < elichai2> will be a hard rebase but i'll get over it haha
12:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
12:57 < bitcoin-git> [bitcoin] hebasto opened pull request #16469: refactoring: Use direct list initialization for Arg struct (master...20190726-remove-arg-ctor) https://github.com/bitcoin/bitcoin/pull/16469
12:57 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:09 -!- dgfhdfg [~hgfdfgh@77.243.22.21] has quit [Ping timeout: 272 seconds]
13:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:13 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #16470: test: Fail early on disconnect in mininode.wait_for_* (master...1907-testMininodeNoWaitOnDisconnect) https://github.com/bitcoin/bitcoin/pull/16470
13:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:20 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection]
13:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
13:23 < bitcoin-git> [bitcoin] jnewbery opened pull request #16471: [mempool] log correct messages when CPFP fails (master...2019-07-fix-CalculateMempoolAncestors-logging) https://github.com/bitcoin/bitcoin/pull/16471
13:23 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
13:31 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
13:31 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
13:32 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
13:37 -!- tryphe_ [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev
13:40 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Ping timeout: 248 seconds]
13:53 -!- grubles [~grubles@unaffiliated/grubles] has left #bitcoin-core-dev []
13:56 -!- davterra [~none@209.58.188.75] has quit [Quit: Leaving]
14:00 -!- theos1 [~theos@178.162.204.238] has quit []
14:04 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has quit [Remote host closed the connection]
14:05 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has joined #bitcoin-core-dev
14:19 -!- strattog [~strattog@185.103.96.147] has joined #bitcoin-core-dev
14:25 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
14:25 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
14:30 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Ping timeout: 245 seconds]
14:32 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev
14:36 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 245 seconds]
14:37 -!- Krellan_ [~Krellan@2601:640:4100:ac00:a99a:2670:6ab:5dee] has joined #bitcoin-core-dev
14:37 -!- tryphe_ is now known as tryphe
14:38 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
14:41 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
15:01 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has quit [Ping timeout: 260 seconds]
15:01 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has joined #bitcoin-core-dev
15:14 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection]
15:16 -!- kcalvinalvin [~calvin@210.222.15.191] has quit [Ping timeout: 245 seconds]
15:25 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 244 seconds]
15:45 -!- rex4539 [~rex4539@2a02:587:3514:c700:75b3:542e:84a9:197d] has quit [Read error: Connection reset by peer]
15:45 -!- davex__ [~user@45.74.60.137] has joined #bitcoin-core-dev
15:46 -!- davex__ [~user@45.74.60.137] has quit [Remote host closed the connection]
15:47 -!- davex__ [~user@45.74.60.137] has joined #bitcoin-core-dev
15:55 -!- jb55 [~jb55@gateway/tor-sasl/jb55] has joined #bitcoin-core-dev
15:56 -!- liberiga [~liberiga@gateway/tor-sasl/liberiga] has quit [Ping timeout: 260 seconds]
16:09 -!- jarthur [~jarthur@207.114.244.5] has quit []
16:09 < fanquake> MarcoFalke: Thanks
16:09 -!- cornfeedhobo [~cornfeedh@unaffiliated/cornfeed] has quit [Remote host closed the connection]
16:10 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 260 seconds]
16:12 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.5]
16:13 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
16:22 -!- cornfeedhobo [~cornfeedh@unaffiliated/cornfeed] has joined #bitcoin-core-dev
16:31 -!- captjakk [~captjakk@75-166-175-210.hlrn.qwest.net] has quit [Remote host closed the connection]
16:32 -!- captjakk [~captjakk@75-166-175-210.hlrn.qwest.net] has joined #bitcoin-core-dev
16:36 -!- captjakk [~captjakk@75-166-175-210.hlrn.qwest.net] has quit [Ping timeout: 245 seconds]
16:41 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
16:41 -!- lightlike [~lightlike@2001:16b8:574c:700:15d4:5a2e:5e46:7a0c] has quit [Quit: Leaving]
16:51 -!- mdunnio [~mdunnio@208.59.170.5] has joined #bitcoin-core-dev
16:52 -!- mdunnio [~mdunnio@208.59.170.5] has quit [Remote host closed the connection]
16:53 -!- dviola [~diego@unaffiliated/dviola] has quit [Ping timeout: 248 seconds]
16:54 -!- emilengler [emilengler@gateway/vpn/privateinternetaccess/emilengler] has quit [Ping timeout: 268 seconds]
16:57 -!- dviola [~diego@189.7.68.220] has joined #bitcoin-core-dev
16:58 -!- dviola [~diego@189.7.68.220] has quit [Changing host]
16:58 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
17:00 -!- strattog [~strattog@185.103.96.147] has quit []
17:04 -!- netsoundW [~netsoundW@185.204.1.185] has joined #bitcoin-core-dev
17:08 -!- captjakk [~captjakk@c-73-229-14-187.hsd1.co.comcast.net] has joined #bitcoin-core-dev
17:12 -!- captjakk [~captjakk@c-73-229-14-187.hsd1.co.comcast.net] has quit [Ping timeout: 246 seconds]
17:16 -!- captjakk [~captjakk@c-73-229-14-187.hsd1.co.comcast.net] has joined #bitcoin-core-dev
17:22 -!- justanotheruser [justanothe@gateway/vpn/nordvpn/justanotheruser] has quit [Ping timeout: 244 seconds]
17:27 -!- captjakk [~captjakk@c-73-229-14-187.hsd1.co.comcast.net] has quit [Ping timeout: 245 seconds]
17:30 -!- captjakk [~captjakk@c-73-229-14-187.hsd1.co.comcast.net] has joined #bitcoin-core-dev
17:42 -!- captjakk [~captjakk@c-73-229-14-187.hsd1.co.comcast.net] has quit [Ping timeout: 244 seconds]
17:42 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev
17:45 -!- captjakk [~captjakk@2601:280:9:5ca6:8d69:c11b:40b5:e147] has joined #bitcoin-core-dev
17:53 -!- andytoshi [~apoelstra@unaffiliated/andytoshi] has quit [Ping timeout: 258 seconds]
18:52 -!- dviola [~diego@unaffiliated/dviola] has quit [Ping timeout: 245 seconds]
19:08 < fanquake> jonasschnelli: what version of Python are you using on your CI box?
19:21 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-ilwtsqaqfyvnibqo] has quit [Quit: Connection closed for inactivity]
19:21 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
19:53 -!- dviola [~diego@189.7.68.220] has joined #bitcoin-core-dev
19:53 -!- dviola [~diego@189.7.68.220] has quit [Changing host]
19:53 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
20:00 -!- netsoundW [~netsoundW@185.204.1.185] has quit []
20:04 -!- alexsuraci [~alexsurac@185.5.172.148] has joined #bitcoin-core-dev
20:14 -!- captjakk [~captjakk@2601:280:9:5ca6:8d69:c11b:40b5:e147] has quit [Remote host closed the connection]
20:15 -!- captjakk [~captjakk@2601:280:9:5ca6:8d69:c11b:40b5:e147] has joined #bitcoin-core-dev
20:19 -!- captjakk [~captjakk@2601:280:9:5ca6:8d69:c11b:40b5:e147] has quit [Ping timeout: 264 seconds]
20:46 -!- Eagle[TM] [~EagleTM@unaffiliated/eagletm] has joined #bitcoin-core-dev
20:46 -!- captjakk [~captjakk@75-166-175-210.hlrn.qwest.net] has joined #bitcoin-core-dev
20:48 -!- EagleTM [~EagleTM@unaffiliated/eagletm] has quit [Ping timeout: 272 seconds]
20:50 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 260 seconds]
20:55 -!- schnerchi [~schnerchi@p57B83B98.dip0.t-ipconnect.de] has joined #bitcoin-core-dev
20:59 -!- schnerch_ [~schnerchi@p5084AF19.dip0.t-ipconnect.de] has quit [Ping timeout: 272 seconds]
21:08 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev
21:31 -!- dviola [~diego@unaffiliated/dviola] has quit [Quit: WeeChat 2.5]
21:47 -!- dviola [~diego@unaffiliated/dviola] has joined #bitcoin-core-dev
21:59 -!- captjakk [~captjakk@75-166-175-210.hlrn.qwest.net] has quit [Remote host closed the connection]
21:59 -!- d_t [~dt@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev
21:59 -!- Karyon [~Karyon@unaffiliated/karyon] has quit [Ping timeout: 276 seconds]
21:59 -!- captjakk [~captjakk@75-166-175-210.hlrn.qwest.net] has joined #bitcoin-core-dev
22:04 -!- captjakk [~captjakk@75-166-175-210.hlrn.qwest.net] has quit [Ping timeout: 248 seconds]
22:10 -!- Karyon [~Karyon@unaffiliated/karyon] has joined #bitcoin-core-dev
22:19 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev
22:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev
22:22 < bitcoin-git> [bitcoin] hebasto closed pull request #16469: refactoring: Use direct list initialization for Arg struct (master...20190726-remove-arg-ctor) https://github.com/bitcoin/bitcoin/pull/16469
22:22 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev []
22:27 -!- d_t [~dt@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
23:00 -!- alexsuraci [~alexsurac@185.5.172.148] has quit []
23:07 -!- d_t [~dt@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev
23:09 -!- nijak [nijak@gateway/vpn/mullvad/nijak] has joined #bitcoin-core-dev
23:09 -!- wohiya [~john@cpe-24-193-26-188.nyc.res.rr.com] has joined #bitcoin-core-dev
23:11 -!- nijak_ [nijak@gateway/vpn/mullvad/nijak] has quit [Ping timeout: 258 seconds]
23:28 -!- d_t [~dt@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…]
23:33 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has quit [Ping timeout: 246 seconds]
23:33 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has joined #bitcoin-core-dev
23:36 -!- dgfhdfg [~hgfdfgh@37.19.108.124] has joined #bitcoin-core-dev
23:46 -!- forcer1 [~forcer@195.206.169.238] has joined #bitcoin-core-dev
23:57 -!- reallll is now known as belcher
--- Log closed Sat Jul 27 00:00:22 2019