--- Log opened Thu Aug 01 00:00:27 2019 00:05 < fanquake> I've just done master (b7fbf74b980ebb122ae34b142f2cc49b44b92de3) and a dummy commit, still seeing the same difference in bitcoin-qt. 00:08 < fanquake> Looks like the difference is in libbitcoinqt_a-qrc_bitcoin_locale.o 00:08 < fanquake> .rodata._ZL18qt_resource_struct 00:10 < wumpus> no, not using --prefix at the moment, I see a diffrence too between the same commits though, in bitcoin-qt but not bitcoind 00:10 < wumpus> so i'm able to reproduce your issue 00:10 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 245 seconds] 00:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:12 < bitcoin-git> [bitcoin] meshcollider pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/b7fbf74b980e...6841b013402d 00:12 < bitcoin-git> bitcoin/master c5d3787 Andrew Chow: Allow createwallet to take empty passwords to make unencrypted wallets 00:12 < bitcoin-git> bitcoin/master 6841b01 MeshCollider: Merge #16394: Allow createwallet to take empty passwords to make unencrypt... 00:12 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 00:13 < bitcoin-git> [bitcoin] meshcollider merged pull request #16394: Allow createwallet to take empty passwords to make unencrypted wallets (master...fix-born-enc) https://github.com/bitcoin/bitcoin/pull/16394 00:13 < wumpus> fanquake: my guess would be: timestamp metadata in the compiled resource data 00:13 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 00:13 < fanquake> meshcollider: If your merging, #15986 probably ready as well. 00:13 < gribble> https://github.com/bitcoin/bitcoin/issues/15986 | Add unmodified-descriptor-with-checksum to getdescriptorinfo by sipa · Pull Request #15986 · bitcoin/bitcoin · GitHub 00:14 < wumpus> fanquake: probably, this is an issue that was solved already for gitian deterministic building 00:14 < fanquake> wumpus: I know we have at least one RCC related patch 00:14 < fanquake> https://github.com/bitcoin/bitcoin/blob/master/depends/patches/qt/fix_rcc_determinism.patch 00:15 < fanquake> However if I'm using Qt from depends then that should be included ? 00:16 < fanquake> eh right, QT_RCC_SOURCE_DATE_OVERRIDE wont have been set etc 00:16 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 00:17 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev 00:18 -!- brianhoffman_ [~brianhoff@pool-173-66-215-91.washdc.fios.verizon.net] has joined #bitcoin-core-dev 00:19 -!- brianhoffman [~brianhoff@pool-173-66-215-91.washdc.fios.verizon.net] has quit [Ping timeout: 245 seconds] 00:19 -!- brianhoffman_ is now known as brianhoffman 00:24 < wumpus> (i was not not using qt from the depends for my comparison, just ubuntu 18.04's system one) 00:25 -!- coinmonks [6a334ae1@106.51.74.225] has joined #bitcoin-core-dev 00:25 < coinmonks> Hey Guys, I am writing an article around Bitcoin codebase activity, anyone wanna look it and give me some feedback.. 00:26 < wumpus> fanquake: but yes, going to test the --prefix option next 00:27 < fanquake> wumpus: no worries. I'm going to rebuild while exporting that ENV var, and i assume it'll fix the Qt issue. If so I'll probably open a PR to change it to be exported by default in depends. 00:28 < wumpus> coinmonks: maybe link it here then people can look if they're interested 00:28 < coinmonks> https://medium.com/@gaurav.agrawal/bitcoin-codebase-deep-dive-127a7cb97fbf 00:29 < coinmonks> warning - English is my second language.. 00:33 -!- kljasdfvv [~flack@p200300D46F0E7800EC11287BE12F8FEF.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 00:36 -!- kljasdfvv [~flack@p200300D46F0E7800EC11287BE12F8FEF.dip0.t-ipconnect.de] has quit [Client Quit] 00:37 -!- kljasdfvv [~flack@p200300D46F0E78007906FA620C99F7AE.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 00:38 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has quit [Remote host closed the connection] 00:38 < coinmonks> I am online if anyone have any feedback,,or they can just leave private notes on the post itself.. thank you every one for contributing on Bitcoin.. :] 00:38 -!- ossifrage [~ossifrage@unaffiliated/ossifrage] has joined #bitcoin-core-dev 00:42 -!- mzygar [~mzygar@212.123.247.72] has joined #bitcoin-core-dev 00:45 < fanquake> wumpus: yep QT_RCC_SOURCE_DATE_OVERRIDE fixed the issues with bitcoin-qt 🤦 00:47 -!- davereikher [~dave@gateway/tor-sasl/davereikher] has joined #bitcoin-core-dev 00:49 -!- EF74 [75d53a6c@117.213.58.108] has quit [Remote host closed the connection] 00:58 < coinmonks> how practicalswift generates status reports every month (https://github.com/bitcoin/bitcoin/issues/16506) .. 00:59 < fanquake> coinmonks: your best way of finding out is contacting them directly. 01:00 < coinmonks> (y) 01:00 < kallewoof> I think practicalswift has a twitter account 01:01 < coinmonks> yes, tweeted him 01:02 < davereikher> quit 01:02 -!- davereikher [~dave@gateway/tor-sasl/davereikher] has quit [Quit: WeeChat 1.4] 01:02 -!- jungly [~quassel@79.8.200.97] has joined #bitcoin-core-dev 01:08 -!- setpill [~setpill@unaffiliated/setpill] has joined #bitcoin-core-dev 01:23 < jonasschnelli> MarcoFalke: fee_ 01:23 < jonasschnelli> MarcoFalke: fee_estimation test failed on master (random fail): https://bitcoinbuilds.org/index.php?ansilog=44accd13-eea0-4aab-a6a4-f0694f12a68f.log#l7207 any idea? 01:24 < jonasschnelli> This is probably relevant: https://bitcoinbuilds.org/index.php?ansilog=44accd13-eea0-4aab-a6a4-f0694f12a68f.log#l7024 01:31 -!- Zenton [~user@unaffiliated/vicenteh] has joined #bitcoin-core-dev 01:32 -!- coinmonks [6a334ae1@106.51.74.225] has quit [Remote host closed the connection] 01:38 -!- laptop500 [~laptop@host81-147-158-108.range81-147.btcentralplus.com] has joined #bitcoin-core-dev 01:40 < wumpus> fanquake: cool, thanks for investigating, might make sense to set it by default in the compare-for-build 01:40 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 272 seconds] 01:41 < fanquake> wumpus: Sure, I can do that. 01:47 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev 01:56 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 02:00 -!- Guest64082 [~ao2@178.162.204.238] has quit [] 02:00 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has quit [Ping timeout: 245 seconds] 02:00 -!- justanotheruser [justanothe@gateway/vpn/nordvpn/justanotheruser] has quit [Ping timeout: 245 seconds] 02:16 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Read error: Connection reset by peer] 02:16 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 02:19 -!- indolering [~indolerin@185.103.96.147] has joined #bitcoin-core-dev 02:20 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 02:33 -!- timothy [~tredaelli@redhat/timothy] has joined #bitcoin-core-dev 02:39 -!- CubicEarth [~CubicEart@c-67-168-1-172.hsd1.wa.comcast.net] has joined #bitcoin-core-dev 02:54 -!- jonatack [d598a18a@213.152.161.138] has joined #bitcoin-core-dev 03:01 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 272 seconds] 03:01 -!- jonatack [d598a18a@213.152.161.138] has quit [Remote host closed the connection] 03:06 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev 03:11 -!- mzygar [~mzygar@212.123.247.72] has quit [Ping timeout: 246 seconds] 03:24 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:e8e3:af4f:841e:206a] has joined #bitcoin-core-dev 03:31 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:e8e3:af4f:841e:206a] has quit [Quit: Sleep mode] 03:32 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 03:34 -!- mzygar [~mzygar@212.123.247.72] has joined #bitcoin-core-dev 03:38 -!- mzygar [~mzygar@212.123.247.72] has quit [Ping timeout: 248 seconds] 03:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:42 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/6841b013402d...75656988ac8e 03:42 < bitcoin-git> bitcoin/master b078067 João Barbosa: gui: Remove unused RPCConsole::tabFocus 03:42 < bitcoin-git> bitcoin/master 7565698 Wladimir J. van der Laan: Merge #16514: gui: Remove unused RPCConsole::tabFocus 03:42 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 03:43 < bitcoin-git> [bitcoin] laanwj merged pull request #16514: gui: Remove unused RPCConsole::tabFocus (master...2019-07-remove-unused-tabfocus) https://github.com/bitcoin/bitcoin/pull/16514 03:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 03:55 -!- kcalvinalvin [~calvin@104.143.95.21] has joined #bitcoin-core-dev 03:57 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 04:01 -!- rex4539 [~rex4539@2a02:587:3514:c700:b1cc:4273:ad20:982b] has quit [Quit: rex4539] 04:01 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has quit [Ping timeout: 244 seconds] 04:01 -!- mzygar [~mzygar@212.123.247.72] has joined #bitcoin-core-dev 04:18 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 246 seconds] 04:22 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 04:28 -!- davec [~davec@cpe-24-243-249-218.hot.res.rr.com] has quit [Ping timeout: 272 seconds] 04:28 -!- davec [~davec@24.243.249.218] has joined #bitcoin-core-dev 04:31 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:e8e3:af4f:841e:206a] has joined #bitcoin-core-dev 04:34 -!- mzygar [~mzygar@212.123.247.72] has quit [Ping timeout: 244 seconds] 04:37 -!- lightlike [~lightlike@2001:16b8:5771:de00:bd2b:c68:162f:5c45] has joined #bitcoin-core-dev 04:38 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 04:39 -!- michaelfolkson [~textual@2a00:23c5:be04:e501:e8e3:af4f:841e:206a] has quit [Ping timeout: 264 seconds] 04:39 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has quit [Read error: Connection reset by peer] 04:39 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 04:41 -!- ezegom_ [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 04:41 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has quit [Read error: Connection reset by peer] 04:45 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 04:45 -!- ezegom_ [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has quit [Ping timeout: 258 seconds] 04:45 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has quit [Read error: Connection reset by peer] 04:46 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 04:47 -!- ezegom_ [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 04:47 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has quit [Read error: Connection reset by peer] 04:52 -!- ezegom_ [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has quit [Ping timeout: 245 seconds] 04:58 -!- mzygar [~mzygar@212.123.247.72] has joined #bitcoin-core-dev 05:00 -!- indolering [~indolerin@185.103.96.147] has quit [] 05:03 -!- shesek` [~shesek@141.226.218.3] has joined #bitcoin-core-dev 05:05 -!- shesek` [~shesek@141.226.218.3] has quit [Read error: Connection reset by peer] 05:05 -!- shesek` [~shesek@141.226.218.3] has joined #bitcoin-core-dev 05:06 -!- shesek`` [~shesek@141.226.218.3] has joined #bitcoin-core-dev 05:07 -!- shesek [~shesek@unaffiliated/shesek] has quit [Ping timeout: 244 seconds] 05:10 -!- shesek` [~shesek@141.226.218.3] has quit [Ping timeout: 258 seconds] 05:17 -!- kcalvinalvin [~calvin@104.143.95.21] has quit [Ping timeout: 245 seconds] 05:17 -!- kcalvinalvin [~calvin@104.143.95.41] has joined #bitcoin-core-dev 05:21 -!- Linoleum [~Linoleum@89.249.74.218] has joined #bitcoin-core-dev 05:31 -!- mzygar [~mzygar@212.123.247.72] has quit [Ping timeout: 245 seconds] 05:44 -!- kcalvinalvin [~calvin@104.143.95.41] has quit [Ping timeout: 272 seconds] 05:45 -!- davterra [~none@209.58.185.33] has joined #bitcoin-core-dev 05:55 -!- mzygar [~mzygar@212.123.247.72] has joined #bitcoin-core-dev 06:12 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 06:12 -!- promag [~promag@Bl19-22-20.dsl.telepac.pt] has quit [Remote host closed the connection] 06:12 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 06:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:14 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/75656988ac8e...79816278e2fb 06:14 < bitcoin-git> bitcoin/master fac2e6a MarcoFalke: test: Fail early on disconnect in mininode.wait_for_* 06:14 < bitcoin-git> bitcoin/master 7981627 Wladimir J. van der Laan: Merge #16470: test: Fail early on disconnect in mininode.wait_for_* 06:14 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:15 < bitcoin-git> [bitcoin] laanwj merged pull request #16470: test: Fail early on disconnect in mininode.wait_for_* (master...1907-testMininodeNoWaitOnDisconnect) https://github.com/bitcoin/bitcoin/pull/16470 06:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:17 < bitcoin-git> [bitcoin] laanwj pushed 2 commits to master: https://github.com/bitcoin/bitcoin/compare/79816278e2fb...e653eeff7651 06:17 < bitcoin-git> bitcoin/master 7a0c224 Gert-Jaap Glasbergen: Suppress output in test_bitcoin for expected errors 06:17 < bitcoin-git> bitcoin/master e653eef Wladimir J. van der Laan: Merge #16277: [Tests] Suppress output in test_bitcoin for expected errors 06:17 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:18 < bitcoin-git> [bitcoin] laanwj merged pull request #16277: [Tests] Suppress output in test_bitcoin for expected errors (master...issue-15944) https://github.com/bitcoin/bitcoin/pull/16277 06:18 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:25 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 272 seconds] 06:25 -!- kcalvinalvin [~calvin@104.143.95.18] has joined #bitcoin-core-dev 06:28 -!- mzygar [~mzygar@212.123.247.72] has quit [Ping timeout: 248 seconds] 06:29 -!- mzygar [~mzygar@212.123.247.72] has joined #bitcoin-core-dev 06:31 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev 06:34 -!- mzygar [~mzygar@212.123.247.72] has quit [Ping timeout: 268 seconds] 06:39 -!- mzygar [~mzygar@212.123.247.72] has joined #bitcoin-core-dev 06:39 -!- captjakk [~captjakk@75-166-173-191.hlrn.qwest.net] has joined #bitcoin-core-dev 06:41 -!- kcalvinalvin [~calvin@104.143.95.18] has quit [Remote host closed the connection] 06:42 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 06:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 06:43 < bitcoin-git> [bitcoin] hebasto closed pull request #16476: Use ArgsManager::ALLOW_STRING flag explicitly in simple cases (master...20190727-pr16097-new-flags) https://github.com/bitcoin/bitcoin/pull/16476 06:43 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 06:50 -!- d_t [~dt@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has joined #bitcoin-core-dev 06:58 -!- jonatack [d598a18a@213.152.161.138] has joined #bitcoin-core-dev 07:00 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-spplesbqpjffxqnz] has joined #bitcoin-core-dev 07:01 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 07:07 < wumpus> #proposedmeetingtopic 0.18.1 ready for final? 07:30 -!- captjakk [~captjakk@75-166-173-191.hlrn.qwest.net] has quit [Remote host closed the connection] 07:30 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Ping timeout: 245 seconds] 07:31 -!- captjakk [~captjakk@75-166-173-191.hlrn.qwest.net] has joined #bitcoin-core-dev 07:34 -!- davterra [~none@209.58.185.33] has quit [Remote host closed the connection] 07:35 -!- captjakk [~captjakk@75-166-173-191.hlrn.qwest.net] has quit [Ping timeout: 272 seconds] 07:36 -!- davterra [~none@209.58.185.33] has joined #bitcoin-core-dev 07:37 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has quit [Remote host closed the connection] 07:37 -!- davterra [~none@209.58.185.33] has quit [Client Quit] 07:38 -!- davterra [~none@209.58.185.33] has joined #bitcoin-core-dev 07:39 -!- obsrver [~quassel@p4FF1653B.dip0.t-ipconnect.de] has joined #bitcoin-core-dev 07:44 -!- jonatack [d598a18a@213.152.161.138] has quit [Ping timeout: 260 seconds] 07:46 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 07:50 -!- d_t [~dt@108-65-77-11.lightspeed.sntcca.sbcglobal.net] has quit [Quit: My MacBook has gone to sleep. ZZZzzz…] 07:54 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 07:56 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 07:57 -!- belcher [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 08:00 -!- Linoleum [~Linoleum@89.249.74.218] has quit [] 08:01 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 08:03 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 08:04 -!- hebasto [~hebasto@95.164.65.194] has joined #bitcoin-core-dev 08:04 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 08:05 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has joined #bitcoin-core-dev 08:14 -!- victorSN [~victorSN@unaffiliated/victorsn] has quit [Remote host closed the connection] 08:14 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has quit [Remote host closed the connection] 08:15 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has joined #bitcoin-core-dev 08:15 -!- [RuCTFE]tswr [~RuCTFE]ts@178.162.204.238] has joined #bitcoin-core-dev 08:19 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has quit [Ping timeout: 258 seconds] 08:23 -!- setpill [~setpill@unaffiliated/setpill] has quit [Quit: o/] 08:25 -!- rockhouse [~rockhouse@unaffiliated/rockhouse] has joined #bitcoin-core-dev 08:29 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has quit [Remote host closed the connection] 08:29 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 08:31 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has quit [Remote host closed the connection] 08:31 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 08:35 -!- emilengler [emilengler@gateway/vpn/privateinternetaccess/emilengler] has joined #bitcoin-core-dev 08:37 -!- dgfhdfg [~hgfdfgh@77.243.19.51] has joined #bitcoin-core-dev 08:40 -!- mzygar [~mzygar@212.123.247.72] has quit [Ping timeout: 268 seconds] 08:48 < emilengler> Is the path where the qt config file is being stored somewhere set in the code? Or is it the QSettings default? 08:51 -!- jonatack [d598a245@213.152.162.69] has joined #bitcoin-core-dev 09:01 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 09:03 -!- mdunnio_ [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 09:03 -!- davterra [~none@209.58.185.33] has quit [Quit: Leaving] 09:05 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Ping timeout: 245 seconds] 09:09 < sipa> emilengler: i believe it's a platform dependent default 09:11 < emilengler> sipa: My question was if it is somewhere specified by code or by qt 09:13 < jonasschnelli> emilengler: by QT 09:13 < jonasschnelli> we use the default path 09:14 < jonasschnelli> https://doc.qt.io/qt-5/qsettings.html 09:15 < emilengler> jonasschnelli: Thank you 09:16 < jonasschnelli> emilengler: I think if you pass "-resetguisettings" at startup you'll get a backup .ini file in your datadir... 09:16 < jonasschnelli> (that maybe helps if you want to inspect) 09:18 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has quit [Remote host closed the connection] 09:18 < emilengler> And where is the config file initial be loaded? In src/qt/bitcoin.cpp or src/qt/intro.cpp 09:19 -!- mdunnio_ [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 09:21 < jonasschnelli> emilengler: I think whenever it touches QSettings 09:21 < jonasschnelli> mainly qt/optionsmodel.cpp 09:21 < jonasschnelli> certainly when there is .setValue() or value() 09:23 < jonasschnelli> First "read" is probably in GetLangTerritory() 09:24 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 09:29 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 09:33 -!- darosior [~darosior@107.175.255.247] has joined #bitcoin-core-dev 09:34 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 09:35 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 09:35 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 09:36 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 09:43 -!- justanotheruser [justanothe@gateway/vpn/nordvpn/justanotheruser] has joined #bitcoin-core-dev 09:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 09:49 < bitcoin-git> [bitcoin] dongcarl opened pull request #16519: guix: Change manifest to use channels and inferiors (master...2019-06-guix-channels-and-inferiors) https://github.com/bitcoin/bitcoin/pull/16519 09:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 09:52 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 268 seconds] 09:52 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 09:55 -!- mzygar [~mzygar@ip-213-127-8-82.ip.prioritytelecom.net] has joined #bitcoin-core-dev 09:57 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Ping timeout: 268 seconds] 10:00 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 10:00 < MarcoFalke> [04:23] MarcoFalke: fee_ 10:00 < MarcoFalke> This and others should be fixed in #16493 10:00 < gribble> https://github.com/bitcoin/bitcoin/issues/16493 | test: Fix test failures by MarcoFalke · Pull Request #16493 · bitcoin/bitcoin · GitHub 10:01 < jonasschnelli> nice! 10:02 < jonasschnelli> I can't attend at todays meeting (swiss national day and some fam. duties). 10:02 < jonasschnelli> If someone wants to pickup my. topic (bitcoin-dev mailing list moderation), feel free 10:03 -!- ljlkjlger [68840050@104.132.0.80] has joined #bitcoin-core-dev 10:04 < jonasschnelli> I propose that we add more moderators to shorten the moderation lag which has been between >24h, thus makes debates cumbersome 10:04 < jonasschnelli> Eventually there are some volunteers for moderation, ideally neutral people 10:11 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has joined #bitcoin-core-dev 10:15 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 10:31 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has quit [Remote host closed the connection] 10:31 -!- afk11 [~afk11@gateway/tor-sasl/afk11] has joined #bitcoin-core-dev 10:43 -!- mzygar [~mzygar@ip-213-127-8-82.ip.prioritytelecom.net] has quit [Ping timeout: 244 seconds] 10:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 10:44 < bitcoin-git> [bitcoin] Remagpie opened pull request #16521: wallet/rpc: Use the default maxfeerate value as BTC/kB (master...maxfeerate-as-rate) https://github.com/bitcoin/bitcoin/pull/16521 10:44 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 10:55 -!- jarthur [~jarthur@207.114.244.5] has joined #bitcoin-core-dev 11:00 -!- [RuCTFE]tswr [~RuCTFE]ts@178.162.204.238] has quit [] 11:05 -!- nijak [nijak@gateway/vpn/mullvad/nijak] has joined #bitcoin-core-dev 11:05 -!- nijak_ [nijak@gateway/vpn/mullvad/nijak] has quit [Ping timeout: 258 seconds] 11:10 -!- gnomus [~gnomus@141.98.101.133] has joined #bitcoin-core-dev 11:16 < dongcarl> Serialization question: in an `Unserialize`, is it possible to do something like this: `s >> static_cast(m_network_id);`? Or do I have to split this up? `m_network_id` is an `enum class` backed by `uint8_t` 11:16 -!- ercwl [~ercwl@c-5eea2d50-74736162.cust.telenor.se] has joined #bitcoin-core-dev 11:17 -!- reallll [~belcher@unaffiliated/belcher] has joined #bitcoin-core-dev 11:18 < sipa> dongcarl: i belive static_cast(m_network_id) will work 11:18 * dongcarl trying 11:19 < sipa> seems not 11:19 < dongcarl> yeah... "invalid static_cast from type ‘NetworkID’ to type ‘uint8_t&’" 11:19 < sipa> though you can use `uint8_t x; s >> x; m_network_id = x;` 11:20 < dongcarl> sipa: Yeah I was using that before, just thought there might be something more elegant haha 11:21 < sipa> dongcarl: in my (long outdated) serialization rework #10785 i have a "READWRITEAS(type, value)" 11:21 -!- belcher [~belcher@unaffiliated/belcher] has quit [Ping timeout: 245 seconds] 11:21 < gribble> https://github.com/bitcoin/bitcoin/issues/10785 | Serialization improvements by sipa · Pull Request #10785 · bitcoin/bitcoin · GitHub 11:21 < sipa> which would let you just write READWRITEAS(uint8_t, m_networkid) for both serialization and deserialization 11:21 < dongcarl> sipa: That can still be used if we're not using the `SerializationOp` magic? 11:23 < sipa> actually i suspect it won't work here; references need to be convertible for this 11:25 < dongcarl> `s >> *(uint8_t *)&m_network_id;` worked 11:25 < dongcarl> which is... cool i guess 11:26 -!- reallll is now known as belcher 11:27 < sipa> dongcarl: i'm not sure that's legal 11:27 < sipa> s >> *static_cast(&m_network_id) does not work 11:28 < sipa> you can always access the byte representation of other objects, which means it's not UB to do this, but i'm not convinced it's guaranteed to have the desired effect 11:29 < dongcarl> sipa: Oh it's a reinterpret cast of some kind? 11:30 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection] 11:30 < sipa> yeah, it's a reinterpret cast 11:30 < sipa> i suspect that the representation of a class enum is defined to be equal to its underlying int type, which would make this correct 11:30 < sipa> but i'm not entirely sure 11:31 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev 11:32 < dongcarl> Oh well, better to have multiple lines than to be unsure about safety :-) Will probably get optimized by the compiler anyway 11:32 < sipa> yes 11:49 < achow101> dongcarl: does `static_cast(m_network_id)` not work? 11:49 < dongcarl> achow101: noop :-/ 11:50 < achow101> you can have `uint8_t id; s >> id; static_cast(id); 11:50 < achow101> just have a uint8_t temp variable 11:50 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has quit [Remote host closed the connection] 11:51 < sipa> achow101: easier is `uint8_t id; s >> id; m_network_id = NetworkID(id);` 11:52 < dongcarl> yup, we're going the temp variable route, sipa didn't know you could do `NetworkID(id)`, neat! 11:55 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 11:55 < bitcoin-git> [bitcoin] MarcoFalke opened pull request #16522: travis: Run functional tests in GUI once (master...1908-testGuiFun) https://github.com/bitcoin/bitcoin/pull/16522 11:56 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 12:00 < moneyball> meeting? 12:00 < wumpus> #startmeeting 12:00 < lightningbot> Meeting started Thu Aug 1 19:00:04 2019 UTC. The chair is wumpus. Information about MeetBot at http://wiki.debian.org/MeetBot. 12:00 < lightningbot> Useful Commands: #action #agreed #help #info #idea #link #topic. 12:00 < moneyball> https://gist.github.com/moneyball/071d608fdae217c2a6d7c35955881d8a 12:00 < jnewbery> hi 12:00 < wumpus> #bitcoin-core-dev Meeting: wumpus sipa gmaxwell jonasschnelli morcos luke-jr sdaftuar jtimon cfields petertodd kanzure bluematt instagibbs phantomcircuit codeshark michagogo marcofalke paveljanik NicolasDorier jl2012 achow101 meshcollider jnewbery maaku fanquake promag provoostenator aj Chris_Stewart_5 dongcarl gwillen jamesob ken281221 ryanofsky gleb moneyball kvaciral 12:00 < provoostenator> hi\ 12:00 < sdaftuar> hello 12:00 < kanzure> hi 12:00 < meshcollider> Hi 12:01 < achow101> hi 12:01 * jonasschnelli not really here 12:01 < wumpus> four proposed topics today in https://gist.github.com/moneyball/071d608fdae217c2a6d7c35955881d8a, though jonasschnelli is not here 12:01 < wumpus> right 12:01 -!- Kvaciral [~Kvaciral@94-214-185-162.cable.dynamic.v4.ziggo.nl] has joined #bitcoin-core-dev 12:01 < jamesob> hi 12:01 < sipa> hi 12:01 < wumpus> #topic High priority for review 12:01 -!- pinheadmz [~matthewzi@192.154.196.7] has quit [Quit: pinheadmz] 12:02 < wumpus> 7 PRs (!) left in blockers, also 7 things chasing concept ACK 12:02 < wumpus> https://github.com/bitcoin/bitcoin/projects/8 12:02 < gleb> hi 12:02 < wumpus> anything to add/remove? 12:03 < wumpus> or more or less ready for merge? 12:03 < sdaftuar> i'll beg again for review on #15759 12:03 < gribble> https://github.com/bitcoin/bitcoin/issues/15759 | [p2p] Add 2 outbound blocks-only connections by sdaftuar · Pull Request #15759 · bitcoin/bitcoin · GitHub 12:03 < wumpus> we should probably refuse to add anything more to high prio until 15759 is merged :-) 12:03 < sdaftuar> no argument from me :) 12:03 < MarcoFalke> ok, then just merge it, no? 12:04 < jamesob> I said I'd review it again and I did. still A++++++ 10/10 12:04 < sdaftuar> it only has one ack, i believe, so probably premature 12:04 < wumpus> well it needs review first 12:04 < sdaftuar> jamesob: thank you! 12:04 < wumpus> maybe something for the review club, though, possibly too difficult 12:06 < ariard> will give it a try, at least on code changes, not on p2p implications 12:06 < wumpus> thanks! 12:06 < jonatack> same 12:07 < wumpus> anything to discuss about the issues needing concept ACK? 12:08 < aj> i think i'll close #16229 in favour of #16060 12:08 < gribble> https://github.com/bitcoin/bitcoin/issues/16229 | Standardise deployment handling by ajtowns · Pull Request #16229 · bitcoin/bitcoin · GitHub 12:08 < gribble> https://github.com/bitcoin/bitcoin/issues/16060 | Bury bip9 deployments by jnewbery · Pull Request #16060 · bitcoin/bitcoin · GitHub 12:08 < aj> doesn't #14895 already have conceptacks? 12:08 < gribble> https://github.com/bitcoin/bitcoin/issues/14895 | Package relay design questions · Issue #14895 · bitcoin/bitcoin · GitHub 12:09 < jnewbery> I've just pushed to 16060. It's ready for rereview 12:09 < jnewbery> (thanks for the review, aj!) 12:09 < wumpus> aj: yes, maybe for the best, having two competing PRs open is usually not very productive 12:09 < achow101> It seems like #16341 has Concept ACKs, so maybe move it to blockers? At least isn't labeled with "needs conceptual review" anymore 12:09 < gribble> https://github.com/bitcoin/bitcoin/issues/16341 | Introduce ScriptPubKeyMan interface and use it for key and script management (aka wallet boxes) by achow101 · Pull Request #16341 · bitcoin/bitcoin · GitHub 12:10 < wumpus> I think 7 blockers is enough :) 12:10 -!- spaced0ut [~spaced0ut@unaffiliated/spaced0ut] has quit [Ping timeout: 244 seconds] 12:10 < wumpus> otoh doesn't seem you have one yet there 12:10 < achow101> it got merged :) 12:11 < wumpus> ok moving it then 12:11 < provoostenator> I'd love to build on top of The Box, so not opposed to making it high prio. 12:12 < wumpus> at least #16363 is almost, or entirely ready for merge, I think 12:12 < gribble> https://github.com/bitcoin/bitcoin/issues/16363 | test: Add test for BIP30 duplicate tx by MarcoFalke · Pull Request #16363 · bitcoin/bitcoin · GitHub 12:13 < wumpus> #topic 0.18.1? 12:13 < wumpus> rc1 was uploaded almost a week ago, do we have any reports of issues? 12:13 < MarcoFalke> I haven't heard of any issues with 18.1rc1 12:13 < wumpus> me neither 12:14 < MarcoFalke> #action ship it 12:14 < wumpus> there's also no bugfixes that need to make it in hard enough to warrant another rc, AFAIK 12:14 < wumpus> yess 12:14 < achow101> haven't heard anything, but that may be a symptom of no one using it 12:14 < wumpus> you never know that... 12:15 -!- nijak_ [nijak@gateway/vpn/mullvad/nijak] has joined #bitcoin-core-dev 12:15 < wumpus> waiting longer will not likely get more people to test it 12:16 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 12:16 < achow101> ship it! 12:16 < wumpus> clear! 12:17 < wumpus> #topic is transaction.nVersion signed or unsigned? (BlueMatt) 12:17 -!- nijak [nijak@gateway/vpn/mullvad/nijak] has quit [Ping timeout: 272 seconds] 12:17 < BlueMatt> #16513 12:17 < gribble> https://github.com/bitcoin/bitcoin/issues/16513 | [RFC] Switch CTransaction::nVersion to an unsigned integer by TheBlueMatt · Pull Request #16513 · bitcoin/bitcoin · GitHub 12:17 < BlueMatt> this came up in rust-bitcoin discussion 12:17 < BlueMatt> consens-wise its unsigned, in our code its signed, people are confused 12:17 < BlueMatt> concept ack or nack, happy either way 12:17 < BlueMatt> just a discussion to have 12:17 < achow101> I thought consensus wise it isn't signed 12:17 < BlueMatt> indeed, it is unsigned in cnosensus 12:17 < BlueMatt> in the code its signed 12:18 < sdaftuar> how about we add a comment to think about it if it ever matters? 12:18 < wumpus> FWIW, I think it's fairly risky to change the consensus code for no functional change 12:18 < MarcoFalke> How can the change even be reviewed? Look at each call site? 12:18 < BlueMatt> MarcoFalke: the way I wrote it is to remove nVersion, see every place its accessed, and go read it 12:18 < BlueMatt> its....actually not that many 12:18 < sipa> one easy way to make sure you have all the call sites is to rename it 12:18 < achow101> if our code says it's signed, then doesn't that mean consensus-wise it is signed? 12:18 < BlueMatt> but, indeed, I'm happy to take a no, just also kinda wondering if people think libraries should make it signed or unsigned 12:19 < BlueMatt> achow101: its casted to unsigned in consensus checks 12:19 < sipa> achow101: as in: all call sites either don't care about signedness, or explicitly cast to unsigned before usage 12:19 < MarcoFalke> huh, nVersion is still here: https://github.com/bitcoin/bitcoin/pull/16513/files#diff-5cb8d9decaa15620a8f98b0c6c44da9bR289 12:19 < achow101> wth 12:19 < BlueMatt> do people think this should be signed or unsigned in rust-bitcoin 12:19 < wumpus> well, other implementations could make it unsigned, if that makes the code easier 12:19 < BlueMatt> like, if its unsigned, people get confused reading crap from rpc 12:19 < BlueMatt> if its signed, people may misimplement CSV 12:20 < sipa> no strong opinion either way; if people want to change it, i think this is fairly easy to review for correctness 12:20 < wumpus> rust-bitcoin is not consensus critical, so the amount at stake for an implementation error is somewhat less their 12:20 < MarcoFalke> [15:18] one easy way to make sure you have all the call sites is to rename it 12:20 < BlueMatt> right 12:20 < provoostenator> I can confirm nVersion is a source of confusion :-) 12:20 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has quit [Ping timeout: 246 seconds] 12:21 < BlueMatt> the background is someone got confused parsing rpc output or something similar, and wants to change the unsigned nVersion to signed 12:22 < provoostenator> 1 is the same signed and unsigned? 12:22 < wumpus> that only gets the direct usage sites though, it's somewhat harder to analyse where the value ends up indirectly 12:22 < BlueMatt> anyway, enough discussion, its somewhat minor...in 5 seconds everyone say their prefernce and we'll flip a weighted coin based on the response and close or not :p 12:22 < MarcoFalke> +0.001 12:23 < aj> MarcoFalke: you're voting for signed floating point? :) 12:23 < BlueMatt> aj: no, signed Decimal 12:23 < elichai2> BlueMatt: make it signed and cast when pass to libconsensus? lol 12:24 < sdaftuar> how about we cast to unsigned in the rpc handler 12:24 < wumpus> ^^ 12:24 < sdaftuar> and then stop thinking about it for a long time 12:24 < BlueMatt> sounds fine to me too 12:24 < sipa> sgtm 12:24 < wumpus> exactly, if it confuses people in RPC, then report it differently in RPC :) 12:24 < BlueMatt> cool, next topi 12:25 < MarcoFalke> sdaftuar: Doeparsers decode 32bits to signed? 12:25 < BlueMatt> c 12:25 < MarcoFalke> Oh, json doesn't use bits 12:25 < wumpus> #topic any contributors affected by GH blocking access/functionality in certain countries? (fanquake) 12:25 < BlueMatt> well whats the eta until auzzies cant work on core cause their govt forces them ato add backdoors and gh kicks them out? 12:26 < BlueMatt> do we need to get fanquake a freedom visa? 12:26 < achow101> and aj 12:26 < BlueMatt> right 12:26 < moneyball> Nat tweeted saying it only affects private repos. I'm not sure if that matches reality or not. 12:26 < wumpus> from what I've heard, currently it shouldn't be a problem because Iran/Crimea/etc is only locked out of their private repos 12:26 < provoostenator> BlueMatt: Microsoft gladly added a backdoor to Skype for China, so I don't think they'll kick anyone out. 12:26 < wumpus> but in the longer run it's not clear what will happen 12:27 < provoostenator> Does Github allow Tor? 12:27 < achow101> https://help.github.com/en/articles/github-and-trade-controls 12:27 < sipa> yeah, it doesn't seem open projects are affected right now 12:27 < elichai2> I heard they're locked out of *their accounts* and becuase of that they can't see their private repos 12:27 < sipa> but it's a scary precedent 12:27 < sipa> elichai2: that was fixed, afaik 12:27 < moneyball> sipa: agree 12:27 < wumpus> it's definitely scary and it'd be absurd to have an international open source project be affected by one country's strange psychosis 12:27 < achow101> wumpus: I heard some reports that people were locked out of their accounts entirely 12:27 < BlueMatt> wumpus: BUT FREEDOMZ 12:28 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 12:28 < emilengler> I have a VPN, I can look if I can connect to a Crimea server if there are one 12:28 < emilengler> Or any other servers/locations which are blocked by the US 12:28 < sipa> achow101: read this thread: https://twitter.com/Hamed/status/1154268514074660864 12:28 < emilengler> Is there a list or something 12:28 < wumpus> emilengler: DO NOT log into your account from there 12:28 < achow101> emilengler: I think it only effects accounts where they believe you a resident of a sanctioned country, not if you are connecting from one 12:28 < emzy> There is a git mirror for Bitcoin in the tor network. 12:29 < emilengler> wumpus: Sure, I wanted to create a trash account for it 12:29 < wumpus> emilengler: okay :) 12:29 < sipa> achow101: in particular, private repos can still be made public if their account is restricted 12:29 < jonatack> IIUC people can be blocked based on presumed citizenship e.g. the wrong passport living in London can be frozen out of their account 12:30 < sipa> everyone, please read this first to the end: https://twitter.com/Hamed/status/1154268514074660864 12:30 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has joined #bitcoin-core-dev 12:30 < emilengler> Has someone a list of the countries who are blocked? 12:30 < emilengler> Or regions 12:30 < wumpus> emzy: right, getting the source code isn't hard, but losing access to PRs/issues etc to be able to contribute back would be bad 12:30 < achow101> emilengler: it's in the help.github article I linked earlier 12:30 < achow101> emilengler: Crimea, Cuba, Iran, North Korea, and Syria. 12:30 < sipa> afaict, the only thing we should be discussing here now is whether we should prioritize figuring out in what ways our processes are dependent on github 12:31 < wumpus> yes 12:31 < emzy> right 12:32 < dongcarl> I know that a few of the depends packages depend on other GitHub repos 12:32 < wumpus> I think our process is already kind of detached from github in a way: we dont use it for merging, a lot of us prefer reviewing locally, the ACK system could work everywhere, etc 12:32 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has joined #bitcoin-core-dev 12:32 < sipa> yeah, i think if worst comes to worst, we can spin up something else 12:32 < sipa> it'd be annoying, but not devastating 12:33 < achow101> the annoying part is losing the issues and PRs 12:33 < wumpus> the good part you mean 12:33 < wumpus> *ducks* 12:33 < sdaftuar> lol 12:33 < moneyball> ha 12:33 < meshcollider> Lol 12:33 < wumpus> just file the ones that matter again :p 12:33 < elichai2> unless we think of this ahead of time and start slowly duplicating all of github into a private gitlab (we could "fake" the PRs and issues to be the same as in github if it's an open source platform) 12:33 < moneyball> can't we just export issues/PR data on a regular basis as backup? 12:34 < wumpus> seriously though, maybe there's some way to import gh metadata 12:34 < BlueMatt> I presume as long as we (a) have very good backups of the entire pr/issue/everything context and (b) are willing to switch upon seeing any actual real-world issues for people, then I think we dont need to do anything today, no? 12:34 < wumpus> moneyball: we do! 12:34 < moneyball> oh nice! 12:34 -!- ezegom [~ezegom@pool-100-38-14-2.nycmny.fios.verizon.net] has quit [Ping timeout: 246 seconds] 12:34 < MarcoFalke> So people from those countries can create pull requests and issues, right? 12:34 < wumpus> moneyball: it's backed up to a github repo though, so be sure to pull it regularly :) https://github.com/zw/bitcoin-gh-meta 12:34 < dongcarl> Is there a GitHub<->GitLab mirroring tool that keeps them in sync? 12:34 < sipa> MarcoFalke: afaict, the only thing is access to their private repos 12:35 < achow101> MarcoFalke: seems like it 12:35 < phantomcircuit> BlueMatt, visa doesn't change an australian citizens obligation to backdoor stuff for their government 12:35 < emilengler> GitLab can import github issues/pr as well 12:35 < phantomcircuit> just cant trust those convicts anymore 12:36 < wumpus> hehe 12:36 < wumpus> phantomcircuit: discrimination! 12:36 < wumpus> anyhow, not much to say on this topic I think, no one from those countries spoke up at least 12:37 < BlueMatt> ehh, if openbsd can discriminate against us citizens for the same reason, I think we're allowed to discriminate based on a convict colony 12:37 < wumpus> (if you are from those countries feel free to PM me) 12:37 < sipa> BlueMatt: you know the difference between a cup of yoghurt and australia? 12:37 < achow101> oh no 12:38 < dongcarl> something something culture? 12:38 < wumpus> that leaves one topic "bitcoin-dev mailing list moderation", which I'm kind of scared of and jonasschnelli isn't here anyway 12:39 < sipa> is warren or kanzure here? 12:39 < phantomcircuit> wumpus, in all seriousness the first part is actually true, the obligation is of citizens and residents, not merely of people in australia 12:39 < achow101> I think it was just a question about whether we had enough mailing list moderators 12:39 < emilengler> How does the list moderation works? It is slow that's the only thing I know.. 12:39 < wumpus> "I propose that we add more moderators to shorten the moderation lag which has been between >24h, thus makes debates cumbersome" 12:39 < sipa> arguably the ML isn't really on topic here, as it's not a bitcoin core thing 12:39 -!- mzygar [~mzygar@ip-213-127-8-82.ip.prioritytelecom.net] has joined #bitcoin-core-dev 12:39 < wumpus> "Eventually there are some volunteers for moderation, ideally neutral people" 12:39 < wumpus> yea exactly... 12:40 < sipa> plus it doesn't seem that any of the list operators are here now 12:40 < MarcoFalke> Could the mailing list be used for this discussion? 12:40 < sipa> yes 12:40 < MarcoFalke> ok, endmeeting :) 12:40 < wumpus> #endmeeting 12:40 < lightningbot> Meeting ended Thu Aug 1 19:40:36 2019 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) 12:40 < lightningbot> Minutes: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-08-01-19.00.html 12:40 < lightningbot> Minutes (text): http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-08-01-19.00.txt 12:40 < lightningbot> Log: http://www.erisian.com.au/meetbot/bitcoin-core-dev/2019/bitcoin-core-dev.2019-08-01-19.00.log.html 12:40 < sipa> if you'd leave a cup of yoghurt alone for 200 years, it'd develop a culture 12:40 < wumpus> lol 12:41 < achow101> lmao 12:41 < sdaftuar> that missed the meeting minutes 12:41 < elichai2> loool 12:41 < aj> didn't want that in the minutes, eh? 12:41 < jamesob> someone call HR 12:41 < emilengler> sipa: Something similar was covered in a Simpsons Episode 12:41 < emzy> hehe 12:42 -!- PaulTroon [~paultroon@rrcs-184-74-240-156.nyc.biz.rr.com] has joined #bitcoin-core-dev 12:44 -!- mzygar [~mzygar@ip-213-127-8-82.ip.prioritytelecom.net] has quit [Ping timeout: 258 seconds] 12:46 -!- ljlkjlger [68840050@104.132.0.80] has quit [Remote host closed the connection] 12:46 -!- pinheadmz [~matthewzi@192.154.196.7] has joined #bitcoin-core-dev 12:53 -!- Emilstud [emilengler@gateway/vpn/privateinternetaccess/emilengler] has joined #bitcoin-core-dev 12:56 -!- emilengler [emilengler@gateway/vpn/privateinternetaccess/emilengler] has quit [Ping timeout: 245 seconds] 12:57 -!- Emilstud [emilengler@gateway/vpn/privateinternetaccess/emilengler] has quit [Client Quit] 13:00 -!- emilengler [emilengler@gateway/vpn/privateinternetaccess/emilengler] has joined #bitcoin-core-dev 13:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:05 < bitcoin-git> [bitcoin] MarcoFalke closed pull request #16522: travis: Run functional tests in GUI once (master...1908-testGuiFun) https://github.com/bitcoin/bitcoin/pull/16522 13:05 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 272 seconds] 13:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:06 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 13:07 -!- ercwl [~ercwl@c-5eea2d50-74736162.cust.telenor.se] has quit [Quit: ercwl] 13:19 -!- timothy [~tredaelli@redhat/timothy] has quit [Remote host closed the connection] 13:22 -!- belcher [~belcher@unaffiliated/belcher] has quit [Quit: Leaving] 13:24 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 13:31 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has joined #bitcoin-core-dev 13:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:33 < bitcoin-git> [bitcoin] metalicjames opened pull request #16523: Add removemempoolentry RPC to evict transactions from the mempool (master...removemempoolentry) https://github.com/bitcoin/bitcoin/pull/16523 13:33 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:40 < fanquake> I’m almost glad I didn’t turn up for that meeting 13:42 < fanquake> Sounds like I should cancel my Aussie citizenship ASAP heh 13:43 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 13:45 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 248 seconds] 13:48 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 13:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 13:54 < bitcoin-git> [bitcoin] jtimon opened pull request #16524: Truly decouple wallet from chainparams for -fallbackfee (master...b19-true-wallet-no-chainparams) https://github.com/bitcoin/bitcoin/pull/16524 13:54 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 13:56 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has quit [Ping timeout: 245 seconds] 14:00 -!- gnomus [~gnomus@141.98.101.133] has quit [] 14:02 -!- ptiyoyip [~hgfdfgh@77.243.19.51] has joined #bitcoin-core-dev 14:03 -!- esotericnonsense [~esotericn@unaffiliated/esotericnonsense] has joined #bitcoin-core-dev 14:04 -!- dgfhdfg [~hgfdfgh@77.243.19.51] has quit [Ping timeout: 258 seconds] 14:09 -!- DeanGuss [~dean@gateway/tor-sasl/deanguss] has quit [Ping timeout: 260 seconds] 14:12 -!- queip [~queip@unaffiliated/rezurus] has quit [Ping timeout: 245 seconds] 14:18 -!- jamesl22 [~james@185.58.225.100] has joined #bitcoin-core-dev 14:20 -!- afb [~afb@178.162.204.238] has joined #bitcoin-core-dev 14:29 -!- queip [~queip@unaffiliated/rezurus] has joined #bitcoin-core-dev 14:31 -!- PaulTroon [~paultroon@rrcs-184-74-240-156.nyc.biz.rr.com] has quit [Remote host closed the connection] 14:31 -!- PaulTroon [~paultroon@rrcs-184-74-240-156.nyc.biz.rr.com] has joined #bitcoin-core-dev 14:32 -!- PaulTroon [~paultroon@rrcs-184-74-240-156.nyc.biz.rr.com] has quit [Client Quit] 14:35 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 14:35 < bitcoin-git> [bitcoin] TheBlueMatt closed pull request #16513: [RFC] Switch CTransaction::nVersion to an unsigned integer (master...2019-07-unsigned-tx-ver) https://github.com/bitcoin/bitcoin/pull/16513 14:36 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 14:49 -!- Guyver2 [AdiIRC@guyver2.xs4all.nl] has quit [Quit: Going offline, see ya! (www.adiirc.com)] 14:54 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 272 seconds] 14:55 -!- justanotheruser [justanothe@gateway/vpn/nordvpn/justanotheruser] has quit [Ping timeout: 248 seconds] 14:56 -!- kristapsk [~KK@gateway/tor-sasl/kristapsk] has joined #bitcoin-core-dev 14:57 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 14:59 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 15:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 15:05 < bitcoin-git> [bitcoin] TheBlueMatt opened pull request #16525: Dump transaction version as an unsigned integer in RPC/TxToUniv (master...2019-07-unsigned-tx-ver) https://github.com/bitcoin/bitcoin/pull/16525 15:05 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 15:06 -!- obsrver [~quassel@p4FF1653B.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 15:08 -!- liberiga [~liberiga@gateway/tor-sasl/liberiga] has joined #bitcoin-core-dev 15:11 -!- ezegom [~ezegom@rrcs-172-254-90-3.nyc.biz.rr.com] has joined #bitcoin-core-dev 15:14 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 15:16 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 15:17 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has quit [Client Quit] 15:17 -!- Zenton [~user@unaffiliated/vicenteh] has quit [Ping timeout: 258 seconds] 15:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 15:19 < bitcoin-git> [bitcoin] jtimon opened pull request #16526: Refactor: Chainparams: readability (master...b19-chainparams-no-istestchain) https://github.com/bitcoin/bitcoin/pull/16526 15:19 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 15:20 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 15:26 -!- laptop500 [~laptop@host81-147-158-108.range81-147.btcentralplus.com] has quit [Ping timeout: 268 seconds] 15:29 -!- jamesob_ [sid180710@gateway/web/irccloud.com/x-flvzaqjrmscewzys] has joined #bitcoin-core-dev 15:30 -!- ahmed___ [sid14086@gateway/web/irccloud.com/x-yvkexnccbmtlhtqw] has joined #bitcoin-core-dev 15:31 -!- emzy_ [~quassel@raspberry.emzy.de] has joined #bitcoin-core-dev 15:36 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 15:37 -!- Netsplit *.net <-> *.split quits: jamesob, emzy, ahmed_ 15:37 -!- jamesob_ is now known as jamesob 15:37 -!- ahmed___ is now known as ahmed_ 15:43 -!- mdunnio [~mdunnio@38.126.31.226] has joined #bitcoin-core-dev 15:45 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has joined #bitcoin-core-dev 15:53 -!- jarthur [~jarthur@207.114.244.5] has quit [] 15:54 -!- ezegom [~ezegom@rrcs-172-254-90-3.nyc.biz.rr.com] has quit [Ping timeout: 248 seconds] 15:58 -!- mdunnio [~mdunnio@38.126.31.226] has quit [Remote host closed the connection] 16:09 -!- laptop500 [~laptop@host81-147-158-108.range81-147.btcentralplus.com] has joined #bitcoin-core-dev 16:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 16:15 < bitcoin-git> [bitcoin] jtimon opened pull request #16527: Get rid of Params().RequireStandard() (master...b19-chainparams-no-requirestd) https://github.com/bitcoin/bitcoin/pull/16527 16:15 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 16:32 -!- captjakk [~captjakk@75-166-173-191.hlrn.qwest.net] has joined #bitcoin-core-dev 16:41 -!- ezegom [~ezegom@rrcs-172-254-90-3.nyc.biz.rr.com] has joined #bitcoin-core-dev 16:45 -!- ezegom [~ezegom@rrcs-172-254-90-3.nyc.biz.rr.com] has quit [Ping timeout: 248 seconds] 16:46 -!- jnewbery [~john@rrcs-184-74-240-156.nyc.biz.rr.com] has quit [Ping timeout: 245 seconds] 16:46 -!- whydb [~whydb@174.138.46.134] has joined #bitcoin-core-dev 16:46 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has quit [Ping timeout: 260 seconds] 16:50 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Remote host closed the connection] 16:51 -!- sdaftuar [~sdaftuar@gateway/tor-sasl/sdaftuar] has joined #bitcoin-core-dev 16:51 -!- captjakk [~captjakk@75-166-173-191.hlrn.qwest.net] has quit [Remote host closed the connection] 16:52 -!- Chris_Stewart_5 [~chris@unaffiliated/chris-stewart-5/x-3612383] has quit [Ping timeout: 246 seconds] 16:52 -!- captjakk [~captjakk@75-166-173-191.hlrn.qwest.net] has joined #bitcoin-core-dev 16:53 -!- jnewbery [~john@rrcs-184-74-240-156.nyc.biz.rr.com] has joined #bitcoin-core-dev 16:56 -!- captjakk [~captjakk@75-166-173-191.hlrn.qwest.net] has quit [Ping timeout: 244 seconds] 17:00 -!- afb [~afb@178.162.204.238] has quit [] 17:00 < emilengler> Is there a cmake file for bitcoin core? 17:00 -!- promag_ [~promag@Bl19-22-20.dsl.telepac.pt] has joined #bitcoin-core-dev 17:01 -!- promag [~promag@bl19-22-20.dsl.telepac.pt] has quit [Read error: Connection reset by peer] 17:04 -!- rob01 [~rob0@185.59.221.95] has joined #bitcoin-core-dev 17:04 < sipa> emilengler: it's an autotools project 17:05 < fanquake> hebasto: looks like ipglider hasn't been on GH for a while. I'm going to close #15768 as "Up for grabs", feel free to pick it up if interested. 17:05 < gribble> https://github.com/bitcoin/bitcoin/issues/15768 | gui: Add CMD+W shortcut in macOS by IPGlider · Pull Request #15768 · bitcoin/bitcoin · GitHub 17:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 17:06 < bitcoin-git> [bitcoin] fanquake closed pull request #15768: gui: Add CMD+W shortcut in macOS (master...add_cmd_w_support_in_macos) https://github.com/bitcoin/bitcoin/pull/15768 17:06 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 17:09 -!- lightlike [~lightlike@2001:16b8:5771:de00:bd2b:c68:162f:5c45] has quit [Quit: Leaving] 17:12 -!- ezegom [~ezegom@rrcs-172-254-90-3.nyc.biz.rr.com] has joined #bitcoin-core-dev 17:14 -!- felco [~felco@2600:1f1e:2c9:a500:5da6:7623:c58f:bff3] has joined #bitcoin-core-dev 17:17 -!- ezegom [~ezegom@rrcs-172-254-90-3.nyc.biz.rr.com] has quit [Ping timeout: 248 seconds] 17:22 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 17:26 < emilengler> In which function/file are the blocks writen to the disk? 17:26 < emilengler> written* 17:26 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 248 seconds] 17:31 -!- felco [~felco@2600:1f1e:2c9:a500:5da6:7623:c58f:bff3] has quit [Changing host] 17:31 -!- felco [~felco@unaffiliated/felco] has joined #bitcoin-core-dev 17:32 -!- felco [~felco@unaffiliated/felco] has quit [Quit: All your IRC are belong to ZNC] 17:33 -!- felco [~felco@2600:1f1e:2c9:a500:5da6:7623:c58f:bff3] has joined #bitcoin-core-dev 17:33 -!- felco [~felco@2600:1f1e:2c9:a500:5da6:7623:c58f:bff3] has quit [Excess Flood] 17:33 -!- felco [~felco@2600:1f1e:2c9:a500:5da6:7623:c58f:bff3] has joined #bitcoin-core-dev 17:33 -!- felco [~felco@2600:1f1e:2c9:a500:5da6:7623:c58f:bff3] has quit [Excess Flood] 17:36 < mryandao> emilengler: src/validation.cpp:1635 FlushBlockFile. 17:36 < mryandao> I think. 17:37 < mryandao> there's a lot of flushing going on in validation.cp 17:59 -!- emilengler [emilengler@gateway/vpn/privateinternetaccess/emilengler] has quit [Quit: Leaving] 17:59 -!- ptiyoyip [~hgfdfgh@77.243.19.51] has quit [Ping timeout: 244 seconds] 18:03 -!- emilengler [emilengler@gateway/vpn/privateinternetaccess/emilengler] has joined #bitcoin-core-dev 18:03 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 18:08 -!- dgfhdfg [~hgfdfgh@77.243.19.51] has joined #bitcoin-core-dev 18:08 -!- dgfhdfg [~hgfdfgh@77.243.19.51] has quit [Client Quit] 18:10 -!- ezegom [~ezegom@rrcs-172-254-90-3.nyc.biz.rr.com] has joined #bitcoin-core-dev 18:11 -!- pinheadmz [~matthewzi@192.154.196.7] has quit [Quit: pinheadmz] 18:15 -!- liberiga [~liberiga@gateway/tor-sasl/liberiga] has quit [Quit: Leaving] 18:23 -!- ezegom [~ezegom@rrcs-172-254-90-3.nyc.biz.rr.com] has quit [Remote host closed the connection] 18:24 -!- ezegom [~ezegom@rrcs-172-254-90-3.nyc.biz.rr.com] has joined #bitcoin-core-dev 18:27 -!- ezegom [~ezegom@rrcs-172-254-90-3.nyc.biz.rr.com] has quit [Remote host closed the connection] 18:27 -!- ezegom [~ezegom@rrcs-172-254-90-3.nyc.biz.rr.com] has joined #bitcoin-core-dev 18:37 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 258 seconds] 18:37 -!- ezegom [~ezegom@rrcs-172-254-90-3.nyc.biz.rr.com] has quit [Ping timeout: 245 seconds] 18:39 -!- ezegom [~ezegom@rrcs-172-254-90-3.nyc.biz.rr.com] has joined #bitcoin-core-dev 18:40 -!- mzygar [~mzygar@ip-213-127-8-82.ip.prioritytelecom.net] has joined #bitcoin-core-dev 18:44 -!- tryphe [~tryphe@unaffiliated/tryphe] has quit [Remote host closed the connection] 18:44 -!- mzygar [~mzygar@ip-213-127-8-82.ip.prioritytelecom.net] has quit [Ping timeout: 244 seconds] 18:44 -!- tryphe [~tryphe@unaffiliated/tryphe] has joined #bitcoin-core-dev 18:49 -!- justanotheruser [justanothe@gateway/vpn/nordvpn/justanotheruser] has joined #bitcoin-core-dev 18:51 -!- ezegom [~ezegom@rrcs-172-254-90-3.nyc.biz.rr.com] has quit [Remote host closed the connection] 18:53 -!- ezegom [~ezegom@rrcs-172-254-90-3.nyc.biz.rr.com] has joined #bitcoin-core-dev 18:54 -!- rex4539 [~rex4539@2a02:587:3514:c700:2468:6778:82f2:1b98] has joined #bitcoin-core-dev 18:59 -!- ezegom [~ezegom@rrcs-172-254-90-3.nyc.biz.rr.com] has quit [Remote host closed the connection] 19:00 -!- ezegom [~ezegom@rrcs-172-254-90-3.nyc.biz.rr.com] has joined #bitcoin-core-dev 19:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 19:01 < bitcoin-git> [bitcoin] achow101 opened pull request #16528: [WIP] Native Descriptor Wallets (take 2) (master...wallet-of-the-glorious-future) https://github.com/bitcoin/bitcoin/pull/16528 19:01 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 19:02 < achow101> meshcollider: ^^^ 19:10 -!- elichai2 [uid212594@gateway/web/irccloud.com/x-spplesbqpjffxqnz] has quit [Quit: Connection closed for inactivity] 19:18 -!- rex4539 [~rex4539@2a02:587:3514:c700:2468:6778:82f2:1b98] has quit [Quit: rex4539] 19:25 -!- ezegom [~ezegom@rrcs-172-254-90-3.nyc.biz.rr.com] has quit [Ping timeout: 245 seconds] 19:31 -!- ezegom [~ezegom@2600:380:8e7c:d4ed:d4e2:bb48:fb59:43d4] has joined #bitcoin-core-dev 19:37 -!- captjakk [~captjakk@75-166-173-191.hlrn.qwest.net] has joined #bitcoin-core-dev 19:49 -!- ezegom [~ezegom@2600:380:8e7c:d4ed:d4e2:bb48:fb59:43d4] has quit [Remote host closed the connection] 19:49 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 19:49 < bitcoin-git> [bitcoin] Tech1k opened pull request #16530: doc: Fix grammar and punctuation in developer notes (master...Tech1k-patch-1) https://github.com/bitcoin/bitcoin/pull/16530 19:50 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 20:00 -!- rob01 [~rob0@185.59.221.95] has quit [] 20:04 -!- Kater1 [~Kater@184.75.223.219] has joined #bitcoin-core-dev 20:10 -!- ezegom [~ezegom@rrcs-172-254-90-3.nyc.biz.rr.com] has joined #bitcoin-core-dev 20:14 -!- ezegom [~ezegom@rrcs-172-254-90-3.nyc.biz.rr.com] has quit [Ping timeout: 244 seconds] 20:25 < meshcollider> achow101: \o/ 20:28 -!- captjakk [~captjakk@75-166-173-191.hlrn.qwest.net] has quit [Remote host closed the connection] 20:28 -!- captjakk [~captjakk@75-166-173-191.hlrn.qwest.net] has joined #bitcoin-core-dev 20:29 -!- captjakk [~captjakk@75-166-173-191.hlrn.qwest.net] has quit [Remote host closed the connection] 20:29 -!- captjakk [~captjakk@75-166-173-191.hlrn.qwest.net] has joined #bitcoin-core-dev 20:30 -!- captjakk [~captjakk@75-166-173-191.hlrn.qwest.net] has quit [Remote host closed the connection] 20:30 -!- captjakk [~captjakk@75-166-173-191.hlrn.qwest.net] has joined #bitcoin-core-dev 20:30 -!- captjakk [~captjakk@75-166-173-191.hlrn.qwest.net] has quit [Remote host closed the connection] 20:31 -!- captjakk [~captjakk@75-166-173-191.hlrn.qwest.net] has joined #bitcoin-core-dev 20:31 -!- captjakk [~captjakk@75-166-173-191.hlrn.qwest.net] has quit [Remote host closed the connection] 20:31 -!- captjakk [~captjakk@75-166-173-191.hlrn.qwest.net] has joined #bitcoin-core-dev 20:32 -!- captjakk [~captjakk@75-166-173-191.hlrn.qwest.net] has quit [Remote host closed the connection] 20:32 -!- captjakk [~captjakk@75-166-173-191.hlrn.qwest.net] has joined #bitcoin-core-dev 20:33 -!- captjakk [~captjakk@75-166-173-191.hlrn.qwest.net] has quit [Remote host closed the connection] 20:33 -!- captjakk [~captjakk@75-166-173-191.hlrn.qwest.net] has joined #bitcoin-core-dev 20:33 -!- captjakk [~captjakk@75-166-173-191.hlrn.qwest.net] has quit [Remote host closed the connection] 20:34 -!- captjakk [~captjakk@75-166-173-191.hlrn.qwest.net] has joined #bitcoin-core-dev 20:34 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 20:34 -!- captjakk [~captjakk@75-166-173-191.hlrn.qwest.net] has quit [Remote host closed the connection] 20:34 -!- captjakk [~captjakk@75-166-173-191.hlrn.qwest.net] has joined #bitcoin-core-dev 20:35 -!- captjakk [~captjakk@75-166-173-191.hlrn.qwest.net] has quit [Remote host closed the connection] 20:39 -!- captjakk [~captjakk@75-166-173-191.hlrn.qwest.net] has joined #bitcoin-core-dev 20:44 -!- captjakk [~captjakk@75-166-173-191.hlrn.qwest.net] has quit [Ping timeout: 268 seconds] 20:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 20:48 < bitcoin-git> [bitcoin] harding opened pull request #16532: [0.18] Doc: remove old release notes about systemd and riscv changes (0.18...2019-07-0.18.1-release-notes) https://github.com/bitcoin/bitcoin/pull/16532 20:48 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 21:06 -!- hebasto [~hebasto@95.164.65.194] has quit [Remote host closed the connection] 21:07 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 244 seconds] 21:09 -!- emilengler [emilengler@gateway/vpn/privateinternetaccess/emilengler] has quit [Quit: WeeChat 2.3] 21:11 -!- captjakk [~captjakk@75-166-173-191.hlrn.qwest.net] has joined #bitcoin-core-dev 21:13 < fanquake> If anyone's interested, I've put up some notes about doing bitcoin* binary comparisons: https://github.com/fanquake/core-review/blob/master/binary-compare.md 21:19 -!- justanotheruser [justanothe@gateway/vpn/nordvpn/justanotheruser] has quit [Ping timeout: 258 seconds] 21:30 -!- justanotheruser [~justanoth@unaffiliated/justanotheruser] has joined #bitcoin-core-dev 21:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 21:37 < bitcoin-git> [bitcoin] fanquake opened pull request #16533: build: disable libxcb extensions (master...disable_xcb_extensions) https://github.com/bitcoin/bitcoin/pull/16533 21:37 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 21:43 -!- captjakk [~captjakk@75-166-173-191.hlrn.qwest.net] has quit [Ping timeout: 272 seconds] 22:04 -!- Krellan [~Krellan@50.227.64.178] has joined #bitcoin-core-dev 22:06 -!- Krellan [~Krellan@50.227.64.178] has quit [Remote host closed the connection] 22:07 -!- Krellan [~Krellan@50.227.64.178] has joined #bitcoin-core-dev 22:16 -!- captjakk [~captjakk@75-166-173-191.hlrn.qwest.net] has joined #bitcoin-core-dev 22:40 -!- mzygar [~mzygar@ip-213-127-8-82.ip.prioritytelecom.net] has joined #bitcoin-core-dev 22:45 -!- mzygar [~mzygar@ip-213-127-8-82.ip.prioritytelecom.net] has quit [Ping timeout: 245 seconds] 22:49 -!- captjakk [~captjakk@75-166-173-191.hlrn.qwest.net] has quit [Ping timeout: 246 seconds] 22:50 -!- Krellan [~Krellan@50.227.64.178] has quit [Remote host closed the connection] 22:51 < wumpus> fanquake: yes, I think that's very useful to write those things up on how to find what is causing the non-determinism 23:00 -!- Kater1 [~Kater@184.75.223.219] has quit [] 23:04 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has joined #bitcoin-core-dev 23:15 < wumpus> how to recognize this qt resource non-determism issue, for ex :) 23:17 < fanquake> wumpus: heh. From now on if I ever see what looks like language codes in a binary diff that's probably it. 23:18 -!- rh0nj [~rh0nj@88.99.167.175] has quit [Remote host closed the connection] 23:19 -!- rh0nj [~rh0nj@88.99.167.175] has joined #bitcoin-core-dev 23:19 -!- Xing` [~Xing`@141.98.102.243] has joined #bitcoin-core-dev 23:19 < fanquake> wumpus: #16532 in then tag 0.18.1 ? 23:19 < gribble> https://github.com/bitcoin/bitcoin/issues/16532 | [0.18] Doc: remove old release notes about systemd and riscv changes by harding · Pull Request #16532 · bitcoin/bitcoin · GitHub 23:23 -!- captjakk [~captjakk@75-166-173-191.hlrn.qwest.net] has joined #bitcoin-core-dev 23:24 < fanquake> Moved #16414 to 0.18.2 23:24 < gribble> https://github.com/bitcoin/bitcoin/issues/16414 | 0.18: wallet: Fix -maxtxfee check by moving it to CWallet::CreateTransaction by promag · Pull Request #16414 · bitcoin/bitcoin · GitHub 23:37 -!- AaronvanW [~AaronvanW@unaffiliated/aaronvanw] has quit [Ping timeout: 245 seconds] 23:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has joined #bitcoin-core-dev 23:38 < bitcoin-git> [bitcoin] fanquake reopened pull request #15768: gui: Add CMD+W shortcut in macOS (master...add_cmd_w_support_in_macos) https://github.com/bitcoin/bitcoin/pull/15768 23:38 -!- bitcoin-git [~bitcoin-g@x0f.org] has left #bitcoin-core-dev [] 23:42 -!- octomatic [~textual@2601:646:c501:1960:d118:fa2:d8a4:1890] has joined #bitcoin-core-dev 23:47 -!- octomatic [~textual@2601:646:c501:1960:d118:fa2:d8a4:1890] has quit [Max SendQ exceeded] 23:48 -!- kcalvinalvin [~calvin@104.143.95.18] has joined #bitcoin-core-dev 23:52 -!- octomati_ [~textual@c-73-189-22-4.hsd1.ca.comcast.net] has joined #bitcoin-core-dev 23:56 -!- victorSN [~victorSN@unaffiliated/victorsn] has joined #bitcoin-core-dev 23:57 -!- captjakk [~captjakk@75-166-173-191.hlrn.qwest.net] has quit [Ping timeout: 268 seconds] --- Log closed Fri Aug 02 00:00:27 2019